{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/189305135","pull_request_review_id":121462275,"id":189305135,"diff_hunk":"@@ -1,11 +1,11 @@\n # moveit/moveit:melodic-release\n # Full debian-based install of MoveIt! using apt-get\n \n-FROM moveit/moveit:melodic-ci\n+FROM ros:melodic-ros-base\n MAINTAINER Dave Coleman dave@picknik.ai\n \n-# Commands are combined in single RUN statement with \"lists\" folder removal to reduce image size\n-RUN apt-get update && \\\n-    apt-get install -y \\\n-        ros-${ROS_DISTRO}-moveit-* && \\\n-    rm -rf /var/lib/apt/lists/*\n+RUN apt-get update\n+RUN apt-get install -y ros-${ROS_DISTRO}-moveit-*\n+\n+# Clear apt-cache to reduce image size\n+RUN rm -rf /var/lib/apt/lists/*","path":".docker/release/Dockerfile","position":17,"original_position":17,"commit_id":"2a7c90f29730b61055b1fbd3edf51913ab76a65e","original_commit_id":"2a7c90f29730b61055b1fbd3edf51913ab76a65e","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars2.githubusercontent.com/u/561060?v=4","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"please re-group these commands","created_at":"2018-05-18T15:23:03Z","updated_at":"2018-05-18T15:28:40Z","html_url":"https://github.com/ros-planning/moveit/pull/902#discussion_r189305135","pull_request_url":"https://api.github.com/repos/ros-planning/moveit/pulls/902","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments/189305135"},"html":{"href":"https://github.com/ros-planning/moveit/pull/902#discussion_r189305135"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit/pulls/902","id":188886250,"html_url":"https://github.com/ros-planning/moveit/pull/902","diff_url":"https://github.com/ros-planning/moveit/pull/902.diff","patch_url":"https://github.com/ros-planning/moveit/pull/902.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit/issues/902","number":902,"state":"open","locked":false,"title":"Melodic fixes","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars2.githubusercontent.com/u/5376030?v=4","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"body":"This PR comprises several fixes for Melodic:\r\n* First of all, I fixed the Travis build for Melodic, providing appropriate melodic-ci docker images.\r\n  * `ros:melodic-ros-base` docker images are now available. No need for hacks anymore.\r\n  * clang-format-3.8 is only available in Xenial, but not Bionic anymore. Hence this check is run on Xenial/Kinetic. @davetcoleman I'm curious how you can ensure clang-format-3.8 on Bionic as pointed out in https://github.com/ros-planning/moveit_ci/pull/31#issuecomment-385500450.\r\n* Next, I hot-fixed KDL solvers, as Melodic comes with KDL 1.4 and API changes.\r\n* Finally, we need to explicitly build-depend on Qt and Ogre.\r\n\r\nLocally, this setup successfully built all packages, except #901.\r\nAfter being merged, the docker setting for `melodic-ci-*` should be updated [here](https://hub.docker.com/r/moveit/moveit/~/settings/automated-builds).\r\n\r\nThere is joint Travis test running for this and #830 [here](https://travis-ci.org/ros-planning/moveit/builds/380463856).","created_at":"2018-05-17T23:23:01Z","updated_at":"2018-05-18T15:28:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1dc1051195e40e8d8f4891588477e8bd05f2759","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit/pulls/902/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit/pulls/902/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit/issues/902/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/2a7c90f29730b61055b1fbd3edf51913ab76a65e","head":{"label":"ubi-agni:melodic-fixes","ref":"melodic-fixes","sha":"2a7c90f29730b61055b1fbd3edf51913ab76a65e","user":{"login":"ubi-agni","id":7883789,"avatar_url":"https://avatars1.githubusercontent.com/u/7883789?v=4","gravatar_id":"","url":"https://api.github.com/users/ubi-agni","html_url":"https://github.com/ubi-agni","followers_url":"https://api.github.com/users/ubi-agni/followers","following_url":"https://api.github.com/users/ubi-agni/following{/other_user}","gists_url":"https://api.github.com/users/ubi-agni/gists{/gist_id}","starred_url":"https://api.github.com/users/ubi-agni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubi-agni/subscriptions","organizations_url":"https://api.github.com/users/ubi-agni/orgs","repos_url":"https://api.github.com/users/ubi-agni/repos","events_url":"https://api.github.com/users/ubi-agni/events{/privacy}","received_events_url":"https://api.github.com/users/ubi-agni/received_events","type":"Organization","site_admin":false},"repo":{"id":105209579,"name":"moveit","full_name":"ubi-agni/moveit","owner":{"login":"ubi-agni","id":7883789,"avatar_url":"https://avatars1.githubusercontent.com/u/7883789?v=4","gravatar_id":"","url":"https://api.github.com/users/ubi-agni","html_url":"https://github.com/ubi-agni","followers_url":"https://api.github.com/users/ubi-agni/followers","following_url":"https://api.github.com/users/ubi-agni/following{/other_user}","gists_url":"https://api.github.com/users/ubi-agni/gists{/gist_id}","starred_url":"https://api.github.com/users/ubi-agni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubi-agni/subscriptions","organizations_url":"https://api.github.com/users/ubi-agni/orgs","repos_url":"https://api.github.com/users/ubi-agni/repos","events_url":"https://api.github.com/users/ubi-agni/events{/privacy}","received_events_url":"https://api.github.com/users/ubi-agni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubi-agni/moveit","description":"The MoveIt! motion planning framework","fork":true,"url":"https://api.github.com/repos/ubi-agni/moveit","forks_url":"https://api.github.com/repos/ubi-agni/moveit/forks","keys_url":"https://api.github.com/repos/ubi-agni/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubi-agni/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubi-agni/moveit/teams","hooks_url":"https://api.github.com/repos/ubi-agni/moveit/hooks","issue_events_url":"https://api.github.com/repos/ubi-agni/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/ubi-agni/moveit/events","assignees_url":"https://api.github.com/repos/ubi-agni/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/ubi-agni/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/ubi-agni/moveit/tags","blobs_url":"https://api.github.com/repos/ubi-agni/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubi-agni/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubi-agni/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubi-agni/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubi-agni/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/ubi-agni/moveit/languages","stargazers_url":"https://api.github.com/repos/ubi-agni/moveit/stargazers","contributors_url":"https://api.github.com/repos/ubi-agni/moveit/contributors","subscribers_url":"https://api.github.com/repos/ubi-agni/moveit/subscribers","subscription_url":"https://api.github.com/repos/ubi-agni/moveit/subscription","commits_url":"https://api.github.com/repos/ubi-agni/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubi-agni/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubi-agni/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubi-agni/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubi-agni/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/ubi-agni/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubi-agni/moveit/merges","archive_url":"https://api.github.com/repos/ubi-agni/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubi-agni/moveit/downloads","issues_url":"https://api.github.com/repos/ubi-agni/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/ubi-agni/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/ubi-agni/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/ubi-agni/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubi-agni/moveit/labels{/name}","releases_url":"https://api.github.com/repos/ubi-agni/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/ubi-agni/moveit/deployments","created_at":"2017-09-28T23:45:20Z","updated_at":"2018-03-26T08:56:55Z","pushed_at":"2018-05-18T13:53:27Z","git_url":"git://github.com/ubi-agni/moveit.git","ssh_url":"git@github.com:ubi-agni/moveit.git","clone_url":"https://github.com/ubi-agni/moveit.git","svn_url":"https://github.com/ubi-agni/moveit","homepage":"http://moveit.ros.org/","size":54425,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros-planning:melodic-devel","ref":"melodic-devel","sha":"6cca2555a540be43c085f2024f3cebe33fa670ea","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":64340188,"name":"moveit","full_name":"ros-planning/moveit","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars2.githubusercontent.com/u/2328631?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit","description":"The MoveIt! motion planning framework","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit","forks_url":"https://api.github.com/repos/ros-planning/moveit/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit/deployments","created_at":"2016-07-27T20:38:09Z","updated_at":"2018-05-17T14:47:17Z","pushed_at":"2018-05-18T14:48:30Z","git_url":"git://github.com/ros-planning/moveit.git","ssh_url":"git@github.com:ros-planning/moveit.git","clone_url":"https://github.com/ros-planning/moveit.git","svn_url":"https://github.com/ros-planning/moveit","homepage":"http://moveit.ros.org/","size":54482,"stargazers_count":193,"watchers_count":193,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":205,"open_issues":199,"watchers":193,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/902"},"html":{"href":"https://github.com/ros-planning/moveit/pull/902"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/902"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit/statuses/2a7c90f29730b61055b1fbd3edf51913ab76a65e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davetcoleman"}}