{"action":"created","comment":{"url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/comments/185934557","pull_request_review_id":117427690,"id":185934557,"diff_hunk":"@@ -45,13 +44,14 @@ type s3Storage struct {\n \n // New method creates an implementation of Storage with S3 as the backend.\n func New(opts *Options) (storage.Storage, error) {\n-\tvar creds *credentials.Credentials\n-\tif (len(opts.Access) != 0 && len(opts.Secret) != 0){\n-\t\tcreds = credentials.NewStaticV4(opts.Access, opts.Secret, \"\")\n-\t} else {\n-\t\tcreds = credentials.NewIAM(\"\")\n-\t}\n-\tclient, err := minio.NewWithCredentials(opts.Endpoint, creds, opts.UseSSL, \"\")\n+\t// var creds *credentials.Credentials\n+\t// if len(opts.Access) != 0 && len(opts.Secret) != 0 {\n+\t// \tcreds = credentials.NewStaticV4(opts.Access, opts.Secret, \"\")\n+\t// } else {\n+\t// \tcreds = credentials.NewIAM(\"\")\n+\t// }\n+\t// client, err := minio.NewWithCredentials(opts.Endpoint, creds, opts.UseSSL, opts.Region)\n+\tclient, err := minio.NewWithRegion(opts.Endpoint, opts.Access, opts.Secret, opts.UseSSL, opts.Region)","path":"storage/s3/s3.go","position":26,"original_position":26,"commit_id":"02b008f5c19935a4f226c6c2051da9687374c7c0","original_commit_id":"02b008f5c19935a4f226c6c2051da9687374c7c0","user":{"login":"tboerger","id":156964,"avatar_url":"https://avatars3.githubusercontent.com/u/156964?v=4","gravatar_id":"","url":"https://api.github.com/users/tboerger","html_url":"https://github.com/tboerger","followers_url":"https://api.github.com/users/tboerger/followers","following_url":"https://api.github.com/users/tboerger/following{/other_user}","gists_url":"https://api.github.com/users/tboerger/gists{/gist_id}","starred_url":"https://api.github.com/users/tboerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboerger/subscriptions","organizations_url":"https://api.github.com/users/tboerger/orgs","repos_url":"https://api.github.com/users/tboerger/repos","events_url":"https://api.github.com/users/tboerger/events{/privacy}","received_events_url":"https://api.github.com/users/tboerger/received_events","type":"User","site_admin":false},"body":"This won't get merged like it is, it drops the iam role stuff.","created_at":"2018-05-03T20:59:09Z","updated_at":"2018-05-03T20:59:21Z","html_url":"https://github.com/drone-plugins/drone-s3-cache/pull/31#discussion_r185934557","pull_request_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/comments/185934557"},"html":{"href":"https://github.com/drone-plugins/drone-s3-cache/pull/31#discussion_r185934557"},"pull_request":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31","id":185816174,"html_url":"https://github.com/drone-plugins/drone-s3-cache/pull/31","diff_url":"https://github.com/drone-plugins/drone-s3-cache/pull/31.diff","patch_url":"https://github.com/drone-plugins/drone-s3-cache/pull/31.patch","issue_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/31","number":31,"state":"open","locked":false,"title":"Drone S3 Region Support","user":{"login":"captn3m0","id":584253,"avatar_url":"https://avatars3.githubusercontent.com/u/584253?v=4","gravatar_id":"","url":"https://api.github.com/users/captn3m0","html_url":"https://github.com/captn3m0","followers_url":"https://api.github.com/users/captn3m0/followers","following_url":"https://api.github.com/users/captn3m0/following{/other_user}","gists_url":"https://api.github.com/users/captn3m0/gists{/gist_id}","starred_url":"https://api.github.com/users/captn3m0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captn3m0/subscriptions","organizations_url":"https://api.github.com/users/captn3m0/orgs","repos_url":"https://api.github.com/users/captn3m0/repos","events_url":"https://api.github.com/users/captn3m0/events{/privacy}","received_events_url":"https://api.github.com/users/captn3m0/received_events","type":"User","site_admin":false},"body":"Might need changes before merging back.","created_at":"2018-05-03T19:34:41Z","updated_at":"2018-05-03T20:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31/commits","review_comments_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31/comments","review_comment_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/31/comments","statuses_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/statuses/02b008f5c19935a4f226c6c2051da9687374c7c0","head":{"label":"Hashfyre:master","ref":"master","sha":"02b008f5c19935a4f226c6c2051da9687374c7c0","user":{"login":"Hashfyre","id":581287,"avatar_url":"https://avatars1.githubusercontent.com/u/581287?v=4","gravatar_id":"","url":"https://api.github.com/users/Hashfyre","html_url":"https://github.com/Hashfyre","followers_url":"https://api.github.com/users/Hashfyre/followers","following_url":"https://api.github.com/users/Hashfyre/following{/other_user}","gists_url":"https://api.github.com/users/Hashfyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Hashfyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hashfyre/subscriptions","organizations_url":"https://api.github.com/users/Hashfyre/orgs","repos_url":"https://api.github.com/users/Hashfyre/repos","events_url":"https://api.github.com/users/Hashfyre/events{/privacy}","received_events_url":"https://api.github.com/users/Hashfyre/received_events","type":"User","site_admin":false},"repo":{"id":129223295,"name":"drone-s3-cache","full_name":"Hashfyre/drone-s3-cache","owner":{"login":"Hashfyre","id":581287,"avatar_url":"https://avatars1.githubusercontent.com/u/581287?v=4","gravatar_id":"","url":"https://api.github.com/users/Hashfyre","html_url":"https://github.com/Hashfyre","followers_url":"https://api.github.com/users/Hashfyre/followers","following_url":"https://api.github.com/users/Hashfyre/following{/other_user}","gists_url":"https://api.github.com/users/Hashfyre/gists{/gist_id}","starred_url":"https://api.github.com/users/Hashfyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hashfyre/subscriptions","organizations_url":"https://api.github.com/users/Hashfyre/orgs","repos_url":"https://api.github.com/users/Hashfyre/repos","events_url":"https://api.github.com/users/Hashfyre/events{/privacy}","received_events_url":"https://api.github.com/users/Hashfyre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hashfyre/drone-s3-cache","description":"Caches build artifacts to S3 compatible storage backends","fork":true,"url":"https://api.github.com/repos/Hashfyre/drone-s3-cache","forks_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/forks","keys_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/teams","hooks_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/hooks","issue_events_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/issues/events{/number}","events_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/events","assignees_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/assignees{/user}","branches_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/branches{/branch}","tags_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/tags","blobs_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/languages","stargazers_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/stargazers","contributors_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/contributors","subscribers_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/subscribers","subscription_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/subscription","commits_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/contents/{+path}","compare_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/merges","archive_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/downloads","issues_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/issues{/number}","pulls_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/labels{/name}","releases_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/releases{/id}","deployments_url":"https://api.github.com/repos/Hashfyre/drone-s3-cache/deployments","created_at":"2018-04-12T09:02:50Z","updated_at":"2018-04-12T10:04:26Z","pushed_at":"2018-04-12T10:04:25Z","git_url":"git://github.com/Hashfyre/drone-s3-cache.git","ssh_url":"git@github.com:Hashfyre/drone-s3-cache.git","clone_url":"https://github.com/Hashfyre/drone-s3-cache.git","svn_url":"https://github.com/Hashfyre/drone-s3-cache","homepage":null,"size":1409,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drone-plugins:master","ref":"master","sha":"385744e56ca54a84b80ba673f514b153abf6a7ab","user":{"login":"drone-plugins","id":11234644,"avatar_url":"https://avatars1.githubusercontent.com/u/11234644?v=4","gravatar_id":"","url":"https://api.github.com/users/drone-plugins","html_url":"https://github.com/drone-plugins","followers_url":"https://api.github.com/users/drone-plugins/followers","following_url":"https://api.github.com/users/drone-plugins/following{/other_user}","gists_url":"https://api.github.com/users/drone-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/drone-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drone-plugins/subscriptions","organizations_url":"https://api.github.com/users/drone-plugins/orgs","repos_url":"https://api.github.com/users/drone-plugins/repos","events_url":"https://api.github.com/users/drone-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/drone-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":76078054,"name":"drone-s3-cache","full_name":"drone-plugins/drone-s3-cache","owner":{"login":"drone-plugins","id":11234644,"avatar_url":"https://avatars1.githubusercontent.com/u/11234644?v=4","gravatar_id":"","url":"https://api.github.com/users/drone-plugins","html_url":"https://github.com/drone-plugins","followers_url":"https://api.github.com/users/drone-plugins/followers","following_url":"https://api.github.com/users/drone-plugins/following{/other_user}","gists_url":"https://api.github.com/users/drone-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/drone-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drone-plugins/subscriptions","organizations_url":"https://api.github.com/users/drone-plugins/orgs","repos_url":"https://api.github.com/users/drone-plugins/repos","events_url":"https://api.github.com/users/drone-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/drone-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drone-plugins/drone-s3-cache","description":"Caches build artifacts to S3 compatible storage backends","fork":false,"url":"https://api.github.com/repos/drone-plugins/drone-s3-cache","forks_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/forks","keys_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/teams","hooks_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/hooks","issue_events_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/events{/number}","events_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/events","assignees_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/assignees{/user}","branches_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/branches{/branch}","tags_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/tags","blobs_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/languages","stargazers_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/stargazers","contributors_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/contributors","subscribers_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/subscribers","subscription_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/subscription","commits_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/contents/{+path}","compare_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/merges","archive_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/downloads","issues_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues{/number}","pulls_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/labels{/name}","releases_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/releases{/id}","deployments_url":"https://api.github.com/repos/drone-plugins/drone-s3-cache/deployments","created_at":"2016-12-09T23:29:08Z","updated_at":"2018-05-02T05:24:08Z","pushed_at":"2018-05-03T19:34:41Z","git_url":"git://github.com/drone-plugins/drone-s3-cache.git","ssh_url":"git@github.com:drone-plugins/drone-s3-cache.git","clone_url":"https://github.com/drone-plugins/drone-s3-cache.git","svn_url":"https://github.com/drone-plugins/drone-s3-cache","homepage":null,"size":1426,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31"},"html":{"href":"https://github.com/drone-plugins/drone-s3-cache/pull/31"},"issue":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/31"},"comments":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/drone-plugins/drone-s3-cache/statuses/02b008f5c19935a4f226c6c2051da9687374c7c0"}},"author_association":"NONE"}}
{"actor":{"display_login":"tboerger"}}