{"action":"created","comment":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/comments/178522322","pull_request_review_id":108586762,"id":178522322,"diff_hunk":"@@ -88,27 +103,37 @@ class SearchForm extends React.Component {\n   _onSearch = (e) => {\n     e.preventDefault();\n \n-    this._setLoadingState();\n-    this.props.onSearch(this.refs.query.value, this._resetLoadingState);\n+    this._setLoadingState().then(() => {\n+      this.props.onSearch(this.state.query, this._resetLoadingState);\n+    });\n   };\n \n   _onReset = () => {\n     this._resetLoadingState();\n-    this.refs.query.value = '';\n-    this.props.onReset();\n+    this.setState({ query: '' }, this.props.onReset);","path":"graylog2-web-interface/src/components/common/SearchForm.jsx","position":79,"original_position":79,"commit_id":"1006bca8dddf24090042bac0e0d13cf175d0676b","original_commit_id":"1006bca8dddf24090042bac0e0d13cf175d0676b","user":{"login":"edmundoa","id":716185,"avatar_url":"https://avatars3.githubusercontent.com/u/716185?v=4","gravatar_id":"","url":"https://api.github.com/users/edmundoa","html_url":"https://github.com/edmundoa","followers_url":"https://api.github.com/users/edmundoa/followers","following_url":"https://api.github.com/users/edmundoa/following{/other_user}","gists_url":"https://api.github.com/users/edmundoa/gists{/gist_id}","starred_url":"https://api.github.com/users/edmundoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmundoa/subscriptions","organizations_url":"https://api.github.com/users/edmundoa/orgs","repos_url":"https://api.github.com/users/edmundoa/repos","events_url":"https://api.github.com/users/edmundoa/events{/privacy}","received_events_url":"https://api.github.com/users/edmundoa/received_events","type":"User","site_admin":false},"body":"Resetting the query should also call `this.props.onQueryChange()`.","created_at":"2018-04-02T10:32:02Z","updated_at":"2018-04-02T10:33:17Z","html_url":"https://github.com/Graylog2/graylog2-server/pull/4684#discussion_r178522322","pull_request_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/comments/178522322"},"html":{"href":"https://github.com/Graylog2/graylog2-server/pull/4684#discussion_r178522322"},"pull_request":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684"}},"in_reply_to_id":178521029},"pull_request":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684","id":177102831,"html_url":"https://github.com/Graylog2/graylog2-server/pull/4684","diff_url":"https://github.com/Graylog2/graylog2-server/pull/4684.diff","patch_url":"https://github.com/Graylog2/graylog2-server/pull/4684.patch","issue_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4684","number":4684,"state":"open","locked":false,"title":"Some SearchForm.jsx improvements and fixes","user":{"login":"bernd","id":461,"avatar_url":"https://avatars2.githubusercontent.com/u/461?v=4","gravatar_id":"","url":"https://api.github.com/users/bernd","html_url":"https://github.com/bernd","followers_url":"https://api.github.com/users/bernd/followers","following_url":"https://api.github.com/users/bernd/following{/other_user}","gists_url":"https://api.github.com/users/bernd/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd/subscriptions","organizations_url":"https://api.github.com/users/bernd/orgs","repos_url":"https://api.github.com/users/bernd/repos","events_url":"https://api.github.com/users/bernd/events{/privacy}","received_events_url":"https://api.github.com/users/bernd/received_events","type":"User","site_admin":false},"body":"- Fix eslint errors and fix deprecation warnings\r\n- Fix potential race condition with the loading state update\r\n- Don't reset loading indicatorin `componentWillReceiveProps()`. This fixes an issue where the loading indicator never showed up.\r\n- Convert the query string input to a controlled component and add `query` and `onQueryChange` props","created_at":"2018-03-23T15:24:09Z","updated_at":"2018-04-02T10:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8b1992edc28d56f99e38496399287634f7812a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":213832381,"url":"https://api.github.com/repos/Graylog2/graylog2-server/labels/ready-for-review","name":"ready-for-review","color":"e11d21","default":false},{"id":297588579,"url":"https://api.github.com/repos/Graylog2/graylog2-server/labels/web","name":"web","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/milestones/57","html_url":"https://github.com/Graylog2/graylog2-server/milestone/57","labels_url":"https://api.github.com/repos/Graylog2/graylog2-server/milestones/57/labels","id":1905313,"number":57,"title":"3.0.0","description":"Next major release of Graylog.\r\n\r\nFeatures and bug fixes that require external API changes will land here.","creator":{"login":"bernd","id":461,"avatar_url":"https://avatars2.githubusercontent.com/u/461?v=4","gravatar_id":"","url":"https://api.github.com/users/bernd","html_url":"https://github.com/bernd","followers_url":"https://api.github.com/users/bernd/followers","following_url":"https://api.github.com/users/bernd/following{/other_user}","gists_url":"https://api.github.com/users/bernd/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd/subscriptions","organizations_url":"https://api.github.com/users/bernd/orgs","repos_url":"https://api.github.com/users/bernd/repos","events_url":"https://api.github.com/users/bernd/events{/privacy}","received_events_url":"https://api.github.com/users/bernd/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":161,"state":"open","created_at":"2016-07-26T16:18:58Z","updated_at":"2018-03-29T11:06:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684/commits","review_comments_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684/comments","review_comment_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4684/comments","statuses_url":"https://api.github.com/repos/Graylog2/graylog2-server/statuses/1006bca8dddf24090042bac0e0d13cf175d0676b","head":{"label":"Graylog2:search-form-fixes","ref":"search-form-fixes","sha":"1006bca8dddf24090042bac0e0d13cf175d0676b","user":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars1.githubusercontent.com/u/474892?v=4","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"repo":{"id":671825,"name":"graylog2-server","full_name":"Graylog2/graylog2-server","owner":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars1.githubusercontent.com/u/474892?v=4","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Graylog2/graylog2-server","description":"Free and open source log management","fork":false,"url":"https://api.github.com/repos/Graylog2/graylog2-server","forks_url":"https://api.github.com/repos/Graylog2/graylog2-server/forks","keys_url":"https://api.github.com/repos/Graylog2/graylog2-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Graylog2/graylog2-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Graylog2/graylog2-server/teams","hooks_url":"https://api.github.com/repos/Graylog2/graylog2-server/hooks","issue_events_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/events{/number}","events_url":"https://api.github.com/repos/Graylog2/graylog2-server/events","assignees_url":"https://api.github.com/repos/Graylog2/graylog2-server/assignees{/user}","branches_url":"https://api.github.com/repos/Graylog2/graylog2-server/branches{/branch}","tags_url":"https://api.github.com/repos/Graylog2/graylog2-server/tags","blobs_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Graylog2/graylog2-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Graylog2/graylog2-server/languages","stargazers_url":"https://api.github.com/repos/Graylog2/graylog2-server/stargazers","contributors_url":"https://api.github.com/repos/Graylog2/graylog2-server/contributors","subscribers_url":"https://api.github.com/repos/Graylog2/graylog2-server/subscribers","subscription_url":"https://api.github.com/repos/Graylog2/graylog2-server/subscription","commits_url":"https://api.github.com/repos/Graylog2/graylog2-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Graylog2/graylog2-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Graylog2/graylog2-server/contents/{+path}","compare_url":"https://api.github.com/repos/Graylog2/graylog2-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Graylog2/graylog2-server/merges","archive_url":"https://api.github.com/repos/Graylog2/graylog2-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Graylog2/graylog2-server/downloads","issues_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues{/number}","pulls_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Graylog2/graylog2-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Graylog2/graylog2-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Graylog2/graylog2-server/labels{/name}","releases_url":"https://api.github.com/repos/Graylog2/graylog2-server/releases{/id}","deployments_url":"https://api.github.com/repos/Graylog2/graylog2-server/deployments","created_at":"2010-05-17T21:27:02Z","updated_at":"2018-04-02T02:10:45Z","pushed_at":"2018-03-30T14:49:42Z","git_url":"git://github.com/Graylog2/graylog2-server.git","ssh_url":"git@github.com:Graylog2/graylog2-server.git","clone_url":"https://github.com/Graylog2/graylog2-server.git","svn_url":"https://github.com/Graylog2/graylog2-server","homepage":"https://www.graylog.org/","size":81771,"stargazers_count":4154,"watchers_count":4154,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":633,"open_issues":514,"watchers":4154,"default_branch":"master"}},"base":{"label":"Graylog2:master","ref":"master","sha":"a52b61bc3c225fc4860c0e8fa153236450e873d1","user":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars1.githubusercontent.com/u/474892?v=4","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"repo":{"id":671825,"name":"graylog2-server","full_name":"Graylog2/graylog2-server","owner":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars1.githubusercontent.com/u/474892?v=4","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Graylog2/graylog2-server","description":"Free and open source log management","fork":false,"url":"https://api.github.com/repos/Graylog2/graylog2-server","forks_url":"https://api.github.com/repos/Graylog2/graylog2-server/forks","keys_url":"https://api.github.com/repos/Graylog2/graylog2-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Graylog2/graylog2-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Graylog2/graylog2-server/teams","hooks_url":"https://api.github.com/repos/Graylog2/graylog2-server/hooks","issue_events_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/events{/number}","events_url":"https://api.github.com/repos/Graylog2/graylog2-server/events","assignees_url":"https://api.github.com/repos/Graylog2/graylog2-server/assignees{/user}","branches_url":"https://api.github.com/repos/Graylog2/graylog2-server/branches{/branch}","tags_url":"https://api.github.com/repos/Graylog2/graylog2-server/tags","blobs_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Graylog2/graylog2-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Graylog2/graylog2-server/languages","stargazers_url":"https://api.github.com/repos/Graylog2/graylog2-server/stargazers","contributors_url":"https://api.github.com/repos/Graylog2/graylog2-server/contributors","subscribers_url":"https://api.github.com/repos/Graylog2/graylog2-server/subscribers","subscription_url":"https://api.github.com/repos/Graylog2/graylog2-server/subscription","commits_url":"https://api.github.com/repos/Graylog2/graylog2-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Graylog2/graylog2-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Graylog2/graylog2-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Graylog2/graylog2-server/contents/{+path}","compare_url":"https://api.github.com/repos/Graylog2/graylog2-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Graylog2/graylog2-server/merges","archive_url":"https://api.github.com/repos/Graylog2/graylog2-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Graylog2/graylog2-server/downloads","issues_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues{/number}","pulls_url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Graylog2/graylog2-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Graylog2/graylog2-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Graylog2/graylog2-server/labels{/name}","releases_url":"https://api.github.com/repos/Graylog2/graylog2-server/releases{/id}","deployments_url":"https://api.github.com/repos/Graylog2/graylog2-server/deployments","created_at":"2010-05-17T21:27:02Z","updated_at":"2018-04-02T02:10:45Z","pushed_at":"2018-03-30T14:49:42Z","git_url":"git://github.com/Graylog2/graylog2-server.git","ssh_url":"git@github.com:Graylog2/graylog2-server.git","clone_url":"https://github.com/Graylog2/graylog2-server.git","svn_url":"https://github.com/Graylog2/graylog2-server","homepage":"https://www.graylog.org/","size":81771,"stargazers_count":4154,"watchers_count":4154,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":633,"open_issues":514,"watchers":4154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684"},"html":{"href":"https://github.com/Graylog2/graylog2-server/pull/4684"},"issue":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4684"},"comments":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4684/comments"},"review_comments":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684/comments"},"review_comment":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4684/commits"},"statuses":{"href":"https://api.github.com/repos/Graylog2/graylog2-server/statuses/1006bca8dddf24090042bac0e0d13cf175d0676b"}},"author_association":"OWNER"}}
{"actor":{"display_login":"edmundoa"}}