{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/229855467","pull_request_review_id":170456748,"id":229855467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg1NTQ2Nw==","diff_hunk":"@@ -62,12 +76,18 @@ public static DockerClient newClient(Path dockerExecutable) {\n    * @return the default {@link ProcessBuilder} factory for running a {@code docker} subcommand\n    */\n   private static Function<List<String>, ProcessBuilder> defaultProcessBuilderFactory(\n-      String dockerExecutable) {\n+      String dockerExecutable, Map<String, String> dockerEnvironment) {\n     return dockerSubCommand -> {\n       List<String> dockerCommand = new ArrayList<>(1 + dockerSubCommand.size());\n       dockerCommand.add(dockerExecutable);\n       dockerCommand.addAll(dockerSubCommand);\n-      return new ProcessBuilder(dockerCommand);\n+\n+      ProcessBuilder pb = new ProcessBuilder(dockerCommand);","path":"jib-core/src/main/java/com/google/cloud/tools/jib/docker/DockerClient.java","position":63,"original_position":63,"commit_id":"4fb9d8ccc989da521c19e07733c6895eb662afa0","original_commit_id":"4fb9d8ccc989da521c19e07733c6895eb662afa0","user":{"login":"chanseokoh","id":10523105,"node_id":"MDQ6VXNlcjEwNTIzMTA1","avatar_url":"https://avatars2.githubusercontent.com/u/10523105?v=4","gravatar_id":"","url":"https://api.github.com/users/chanseokoh","html_url":"https://github.com/chanseokoh","followers_url":"https://api.github.com/users/chanseokoh/followers","following_url":"https://api.github.com/users/chanseokoh/following{/other_user}","gists_url":"https://api.github.com/users/chanseokoh/gists{/gist_id}","starred_url":"https://api.github.com/users/chanseokoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanseokoh/subscriptions","organizations_url":"https://api.github.com/users/chanseokoh/orgs","repos_url":"https://api.github.com/users/chanseokoh/repos","events_url":"https://api.github.com/users/chanseokoh/events{/privacy}","received_events_url":"https://api.github.com/users/chanseokoh/received_events","type":"User","site_admin":false},"body":"nit: let's say `ProcessBuilder processBuilder = new ...`.","created_at":"2018-10-31T20:27:51Z","updated_at":"2018-10-31T20:35:37Z","html_url":"https://github.com/GoogleContainerTools/jib/pull/1173#discussion_r229855467","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/229855467"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1173#discussion_r229855467"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173","id":224509828,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTA5ODI4","html_url":"https://github.com/GoogleContainerTools/jib/pull/1173","diff_url":"https://github.com/GoogleContainerTools/jib/pull/1173.diff","patch_url":"https://github.com/GoogleContainerTools/jib/pull/1173.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1173","number":1173,"state":"open","locked":false,"title":"added executable and environment parameters for jibDockerBuild","user":{"login":"gintautassulskus","id":18736551,"node_id":"MDQ6VXNlcjE4NzM2NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/18736551?v=4","gravatar_id":"","url":"https://api.github.com/users/gintautassulskus","html_url":"https://github.com/gintautassulskus","followers_url":"https://api.github.com/users/gintautassulskus/followers","following_url":"https://api.github.com/users/gintautassulskus/following{/other_user}","gists_url":"https://api.github.com/users/gintautassulskus/gists{/gist_id}","starred_url":"https://api.github.com/users/gintautassulskus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintautassulskus/subscriptions","organizations_url":"https://api.github.com/users/gintautassulskus/orgs","repos_url":"https://api.github.com/users/gintautassulskus/repos","events_url":"https://api.github.com/users/gintautassulskus/events{/privacy}","received_events_url":"https://api.github.com/users/gintautassulskus/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/GoogleContainerTools/jib/issues/468\r\n\r\njibDockerBuild can now be configured with two optional properties:\r\n```\r\njibDockerBuild {\r\n    dockerExecutable = \"/optional/path/to/docker/\"\r\n\r\n    def envVars = [:]\r\n        envVars[\"DOCKER_TLS_VERIFY\"] = \"1\"\r\n        envVars[\"DOCKER_HOST\"] = \"tcp://IP:PORT\"\r\n        envVars[\"DOCKER_CERT_PATH\"] = \"/path/to/.minikube/certs\"\r\n        envVars[\"DOCKER_API_VERSION\"] = \"1.35\"\r\n    dockerEnvironment = envVars\r\n}\r\n```\r\n\r\nAlso, reformatted source code to follow the suggested [Oracle conventions](https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html) (4-space indentations). Hence so many changed lines. Now not sure any more whether this was a good idea.","created_at":"2018-10-21T00:29:29Z","updated_at":"2018-10-31T20:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b1e8b55a3b00c14e21f4a90d3422c635847da9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016518109,"node_id":"MDU6TGFiZWwxMDE2NTE4MTA5","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1173/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/4fb9d8ccc989da521c19e07733c6895eb662afa0","head":{"label":"gintautassulskus:jibDockerBuild-env-support","ref":"jibDockerBuild-env-support","sha":"4fb9d8ccc989da521c19e07733c6895eb662afa0","user":{"login":"gintautassulskus","id":18736551,"node_id":"MDQ6VXNlcjE4NzM2NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/18736551?v=4","gravatar_id":"","url":"https://api.github.com/users/gintautassulskus","html_url":"https://github.com/gintautassulskus","followers_url":"https://api.github.com/users/gintautassulskus/followers","following_url":"https://api.github.com/users/gintautassulskus/following{/other_user}","gists_url":"https://api.github.com/users/gintautassulskus/gists{/gist_id}","starred_url":"https://api.github.com/users/gintautassulskus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintautassulskus/subscriptions","organizations_url":"https://api.github.com/users/gintautassulskus/orgs","repos_url":"https://api.github.com/users/gintautassulskus/repos","events_url":"https://api.github.com/users/gintautassulskus/events{/privacy}","received_events_url":"https://api.github.com/users/gintautassulskus/received_events","type":"User","site_admin":false},"repo":{"id":153851221,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM4NTEyMjE=","name":"jib","full_name":"gintautassulskus/jib","private":false,"owner":{"login":"gintautassulskus","id":18736551,"node_id":"MDQ6VXNlcjE4NzM2NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/18736551?v=4","gravatar_id":"","url":"https://api.github.com/users/gintautassulskus","html_url":"https://github.com/gintautassulskus","followers_url":"https://api.github.com/users/gintautassulskus/followers","following_url":"https://api.github.com/users/gintautassulskus/following{/other_user}","gists_url":"https://api.github.com/users/gintautassulskus/gists{/gist_id}","starred_url":"https://api.github.com/users/gintautassulskus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gintautassulskus/subscriptions","organizations_url":"https://api.github.com/users/gintautassulskus/orgs","repos_url":"https://api.github.com/users/gintautassulskus/repos","events_url":"https://api.github.com/users/gintautassulskus/events{/privacy}","received_events_url":"https://api.github.com/users/gintautassulskus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gintautassulskus/jib","description":":sailboat: Build container images for your Java applications.","fork":true,"url":"https://api.github.com/repos/gintautassulskus/jib","forks_url":"https://api.github.com/repos/gintautassulskus/jib/forks","keys_url":"https://api.github.com/repos/gintautassulskus/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gintautassulskus/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gintautassulskus/jib/teams","hooks_url":"https://api.github.com/repos/gintautassulskus/jib/hooks","issue_events_url":"https://api.github.com/repos/gintautassulskus/jib/issues/events{/number}","events_url":"https://api.github.com/repos/gintautassulskus/jib/events","assignees_url":"https://api.github.com/repos/gintautassulskus/jib/assignees{/user}","branches_url":"https://api.github.com/repos/gintautassulskus/jib/branches{/branch}","tags_url":"https://api.github.com/repos/gintautassulskus/jib/tags","blobs_url":"https://api.github.com/repos/gintautassulskus/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gintautassulskus/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gintautassulskus/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/gintautassulskus/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gintautassulskus/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/gintautassulskus/jib/languages","stargazers_url":"https://api.github.com/repos/gintautassulskus/jib/stargazers","contributors_url":"https://api.github.com/repos/gintautassulskus/jib/contributors","subscribers_url":"https://api.github.com/repos/gintautassulskus/jib/subscribers","subscription_url":"https://api.github.com/repos/gintautassulskus/jib/subscription","commits_url":"https://api.github.com/repos/gintautassulskus/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/gintautassulskus/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/gintautassulskus/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/gintautassulskus/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/gintautassulskus/jib/contents/{+path}","compare_url":"https://api.github.com/repos/gintautassulskus/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gintautassulskus/jib/merges","archive_url":"https://api.github.com/repos/gintautassulskus/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gintautassulskus/jib/downloads","issues_url":"https://api.github.com/repos/gintautassulskus/jib/issues{/number}","pulls_url":"https://api.github.com/repos/gintautassulskus/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/gintautassulskus/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/gintautassulskus/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gintautassulskus/jib/labels{/name}","releases_url":"https://api.github.com/repos/gintautassulskus/jib/releases{/id}","deployments_url":"https://api.github.com/repos/gintautassulskus/jib/deployments","created_at":"2018-10-19T23:15:44Z","updated_at":"2018-10-20T23:23:09Z","pushed_at":"2018-10-23T13:28:58Z","git_url":"git://github.com/gintautassulskus/jib.git","ssh_url":"git@github.com:gintautassulskus/jib.git","clone_url":"https://github.com/gintautassulskus/jib.git","svn_url":"https://github.com/gintautassulskus/jib","homepage":"","size":6041,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"563160b192f6926b98fe628fa6630bc031e5fb8a","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-10-31T17:00:04Z","pushed_at":"2018-10-31T17:00:03Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"git@github.com:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":6261,"stargazers_count":4842,"watchers_count":4842,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":354,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":354,"open_issues":107,"watchers":4842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/1173"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1173"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/4fb9d8ccc989da521c19e07733c6895eb662afa0"}},"author_association":"NONE"}}
{"actor":{"display_login":"chanseokoh"}}