{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/comments/217835188","pull_request_review_id":155652706,"id":217835188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzgzNTE4OA==","diff_hunk":"@@ -333,6 +354,67 @@ impl<S: StorageExt> SawtoothRaftNode<S> {\n             }\n         }\n     }\n+\n+    fn check_for_conf_change(&mut self, block_id: BlockId) -> Option<ConfChange> {\n+        // Get list of peers from settings\n+        let settings = self.service\n+            .get_settings(block_id, vec![String::from(\"sawtooth.consensus.raft.peers\")])\n+            .expect(\"Failed to get settings\");","path":"src/node.rs","position":81,"original_position":81,"commit_id":"060655db165ae3cf896bcd31a17787a6116dfe5f","original_commit_id":"060655db165ae3cf896bcd31a17787a6116dfe5f","user":{"login":"peterschwarz","id":282233,"node_id":"MDQ6VXNlcjI4MjIzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/282233?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschwarz","html_url":"https://github.com/peterschwarz","followers_url":"https://api.github.com/users/peterschwarz/followers","following_url":"https://api.github.com/users/peterschwarz/following{/other_user}","gists_url":"https://api.github.com/users/peterschwarz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschwarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschwarz/subscriptions","organizations_url":"https://api.github.com/users/peterschwarz/orgs","repos_url":"https://api.github.com/users/peterschwarz/repos","events_url":"https://api.github.com/users/peterschwarz/events{/privacy}","received_events_url":"https://api.github.com/users/peterschwarz/received_events","type":"User","site_admin":false},"body":"What happens when the validator goes down?  Does Raft go down too?","created_at":"2018-09-14T20:35:37Z","updated_at":"2018-09-14T20:35:37Z","html_url":"https://github.com/hyperledger/sawtooth-raft/pull/24#discussion_r217835188","pull_request_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/comments/217835188"},"html":{"href":"https://github.com/hyperledger/sawtooth-raft/pull/24#discussion_r217835188"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24"}},"in_reply_to_id":217824074},"pull_request":{"url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24","id":215373367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzczMzY3","html_url":"https://github.com/hyperledger/sawtooth-raft/pull/24","diff_url":"https://github.com/hyperledger/sawtooth-raft/pull/24.diff","patch_url":"https://github.com/hyperledger/sawtooth-raft/pull/24.patch","issue_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/24","number":24,"state":"open","locked":false,"title":"Implement membership changes","user":{"login":"ltseeley","id":663101,"node_id":"MDQ6VXNlcjY2MzEwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/663101?v=4","gravatar_id":"","url":"https://api.github.com/users/ltseeley","html_url":"https://github.com/ltseeley","followers_url":"https://api.github.com/users/ltseeley/followers","following_url":"https://api.github.com/users/ltseeley/following{/other_user}","gists_url":"https://api.github.com/users/ltseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/ltseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltseeley/subscriptions","organizations_url":"https://api.github.com/users/ltseeley/orgs","repos_url":"https://api.github.com/users/ltseeley/repos","events_url":"https://api.github.com/users/ltseeley/events{/privacy}","received_events_url":"https://api.github.com/users/ltseeley/received_events","type":"User","site_admin":false},"body":"Adds functionality for leader to listen for changes to the `sawtooth.consensus.raft.peers` setting and trigger a configuration change, and for all nodes to handle/apply configuration changes.\r\n\r\nAlso adds a Bash script for testing dynamic membership of a Raft network. This script will be adapted to work in a Docker service in a later PR.","created_at":"2018-09-13T18:27:06Z","updated_at":"2018-09-14T20:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcbfc6de01c662a6aa71f390d39088666c41c499","assignee":{"login":"ltseeley","id":663101,"node_id":"MDQ6VXNlcjY2MzEwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/663101?v=4","gravatar_id":"","url":"https://api.github.com/users/ltseeley","html_url":"https://github.com/ltseeley","followers_url":"https://api.github.com/users/ltseeley/followers","following_url":"https://api.github.com/users/ltseeley/following{/other_user}","gists_url":"https://api.github.com/users/ltseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/ltseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltseeley/subscriptions","organizations_url":"https://api.github.com/users/ltseeley/orgs","repos_url":"https://api.github.com/users/ltseeley/repos","events_url":"https://api.github.com/users/ltseeley/events{/privacy}","received_events_url":"https://api.github.com/users/ltseeley/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltseeley","id":663101,"node_id":"MDQ6VXNlcjY2MzEwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/663101?v=4","gravatar_id":"","url":"https://api.github.com/users/ltseeley","html_url":"https://github.com/ltseeley","followers_url":"https://api.github.com/users/ltseeley/followers","following_url":"https://api.github.com/users/ltseeley/following{/other_user}","gists_url":"https://api.github.com/users/ltseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/ltseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltseeley/subscriptions","organizations_url":"https://api.github.com/users/ltseeley/orgs","repos_url":"https://api.github.com/users/ltseeley/repos","events_url":"https://api.github.com/users/ltseeley/events{/privacy}","received_events_url":"https://api.github.com/users/ltseeley/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dcmiddle","id":4999494,"node_id":"MDQ6VXNlcjQ5OTk0OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4999494?v=4","gravatar_id":"","url":"https://api.github.com/users/dcmiddle","html_url":"https://github.com/dcmiddle","followers_url":"https://api.github.com/users/dcmiddle/followers","following_url":"https://api.github.com/users/dcmiddle/following{/other_user}","gists_url":"https://api.github.com/users/dcmiddle/gists{/gist_id}","starred_url":"https://api.github.com/users/dcmiddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcmiddle/subscriptions","organizations_url":"https://api.github.com/users/dcmiddle/orgs","repos_url":"https://api.github.com/users/dcmiddle/repos","events_url":"https://api.github.com/users/dcmiddle/events{/privacy}","received_events_url":"https://api.github.com/users/dcmiddle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24/commits","review_comments_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24/comments","review_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/24/comments","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/statuses/060655db165ae3cf896bcd31a17787a6116dfe5f","head":{"label":"ltseeley:implement-membership-changes","ref":"implement-membership-changes","sha":"060655db165ae3cf896bcd31a17787a6116dfe5f","user":{"login":"ltseeley","id":663101,"node_id":"MDQ6VXNlcjY2MzEwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/663101?v=4","gravatar_id":"","url":"https://api.github.com/users/ltseeley","html_url":"https://github.com/ltseeley","followers_url":"https://api.github.com/users/ltseeley/followers","following_url":"https://api.github.com/users/ltseeley/following{/other_user}","gists_url":"https://api.github.com/users/ltseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/ltseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltseeley/subscriptions","organizations_url":"https://api.github.com/users/ltseeley/orgs","repos_url":"https://api.github.com/users/ltseeley/repos","events_url":"https://api.github.com/users/ltseeley/events{/privacy}","received_events_url":"https://api.github.com/users/ltseeley/received_events","type":"User","site_admin":false},"repo":{"id":141450918,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NTA5MTg=","name":"sawtooth-raft","full_name":"ltseeley/sawtooth-raft","owner":{"login":"ltseeley","id":663101,"node_id":"MDQ6VXNlcjY2MzEwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/663101?v=4","gravatar_id":"","url":"https://api.github.com/users/ltseeley","html_url":"https://github.com/ltseeley","followers_url":"https://api.github.com/users/ltseeley/followers","following_url":"https://api.github.com/users/ltseeley/following{/other_user}","gists_url":"https://api.github.com/users/ltseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/ltseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltseeley/subscriptions","organizations_url":"https://api.github.com/users/ltseeley/orgs","repos_url":"https://api.github.com/users/ltseeley/repos","events_url":"https://api.github.com/users/ltseeley/events{/privacy}","received_events_url":"https://api.github.com/users/ltseeley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ltseeley/sawtooth-raft","description":null,"fork":true,"url":"https://api.github.com/repos/ltseeley/sawtooth-raft","forks_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/forks","keys_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/teams","hooks_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/hooks","issue_events_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/issues/events{/number}","events_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/events","assignees_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/assignees{/user}","branches_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/branches{/branch}","tags_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/tags","blobs_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/statuses/{sha}","languages_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/languages","stargazers_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/stargazers","contributors_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/contributors","subscribers_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/subscribers","subscription_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/subscription","commits_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/contents/{+path}","compare_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/merges","archive_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/downloads","issues_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/issues{/number}","pulls_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/pulls{/number}","milestones_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/milestones{/number}","notifications_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/labels{/name}","releases_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/releases{/id}","deployments_url":"https://api.github.com/repos/ltseeley/sawtooth-raft/deployments","created_at":"2018-07-18T15:03:31Z","updated_at":"2018-09-05T20:31:24Z","pushed_at":"2018-09-14T18:49:09Z","git_url":"git://github.com/ltseeley/sawtooth-raft.git","ssh_url":"git@github.com:ltseeley/sawtooth-raft.git","clone_url":"https://github.com/ltseeley/sawtooth-raft.git","svn_url":"https://github.com/ltseeley/sawtooth-raft","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"2ff70c8d6fb90a91a3eda445f049fbd25d2ebd9a","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":137137816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzc4MTY=","name":"sawtooth-raft","full_name":"hyperledger/sawtooth-raft","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/sawtooth-raft","description":null,"fork":false,"url":"https://api.github.com/repos/hyperledger/sawtooth-raft","forks_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/forks","keys_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/teams","hooks_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/events","assignees_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/tags","blobs_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/languages","stargazers_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/subscription","commits_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/merges","archive_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/downloads","issues_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/sawtooth-raft/deployments","created_at":"2018-06-12T23:21:46Z","updated_at":"2018-09-14T19:32:53Z","pushed_at":"2018-09-14T20:25:36Z","git_url":"git://github.com/hyperledger/sawtooth-raft.git","ssh_url":"git@github.com:hyperledger/sawtooth-raft.git","clone_url":"https://github.com/hyperledger/sawtooth-raft.git","svn_url":"https://github.com/hyperledger/sawtooth-raft","homepage":null,"size":128,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24"},"html":{"href":"https://github.com/hyperledger/sawtooth-raft/pull/24"},"issue":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/24"},"comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/sawtooth-raft/statuses/060655db165ae3cf896bcd31a17787a6116dfe5f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"peterschwarz"}}