{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/205751534","pull_request_review_id":141085430,"id":205751534,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTc1MTUzNA==","diff_hunk":"@@ -85,11 +85,19 @@ pub struct VersionInfo {\n }\n \n /// CLI Action\n-pub enum Action<F: ServiceFactory> {\n+pub enum Action<F: ServiceFactory, E: IntoExit> {\n \t/// Substrate handled the command. No need to do anything.\n \tExecutedInternally,\n \t/// Service mode requested. Caller should start the service.\n-\tRunService(FactoryFullConfiguration<F>),\n+\tRunService((FactoryFullConfiguration<F>, E)),\n+}\n+\n+/// Something that can be converted into an exit signal.\n+pub trait IntoExit {\n+\t/// Exit signal type.\n+\ttype Exit: Future<Item=(),Error=()> + Send + 'static;\n+\t/// Convet into exit signal.","path":"substrate/cli/src/lib.rs","position":17,"original_position":17,"commit_id":"f079063dde47bcfa3e1dfc8f32dec60aab94bafb","original_commit_id":"f079063dde47bcfa3e1dfc8f32dec60aab94bafb","user":{"login":"pepyakin","id":2205845,"node_id":"MDQ6VXNlcjIyMDU4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2205845?v=4","gravatar_id":"","url":"https://api.github.com/users/pepyakin","html_url":"https://github.com/pepyakin","followers_url":"https://api.github.com/users/pepyakin/followers","following_url":"https://api.github.com/users/pepyakin/following{/other_user}","gists_url":"https://api.github.com/users/pepyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/pepyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepyakin/subscriptions","organizations_url":"https://api.github.com/users/pepyakin/orgs","repos_url":"https://api.github.com/users/pepyakin/repos","events_url":"https://api.github.com/users/pepyakin/events{/privacy}","received_events_url":"https://api.github.com/users/pepyakin/received_events","type":"User","site_admin":false},"body":"typo: `Convert`","created_at":"2018-07-27T12:04:17Z","updated_at":"2018-07-27T12:16:03Z","html_url":"https://github.com/paritytech/polkadot/pull/433#discussion_r205751534","pull_request_url":"https://api.github.com/repos/paritytech/polkadot/pulls/433","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/205751534"},"html":{"href":"https://github.com/paritytech/polkadot/pull/433#discussion_r205751534"},"pull_request":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/433"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/433","id":204382604,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzgyNjA0","html_url":"https://github.com/paritytech/polkadot/pull/433","diff_url":"https://github.com/paritytech/polkadot/pull/433.diff","patch_url":"https://github.com/paritytech/polkadot/pull/433.patch","issue_url":"https://api.github.com/repos/paritytech/polkadot/issues/433","number":433,"state":"open","locked":false,"title":"Exit signal gets its own trait","user":{"login":"arkpar","id":9008569,"node_id":"MDQ6VXNlcjkwMDg1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/9008569?v=4","gravatar_id":"","url":"https://api.github.com/users/arkpar","html_url":"https://github.com/arkpar","followers_url":"https://api.github.com/users/arkpar/followers","following_url":"https://api.github.com/users/arkpar/following{/other_user}","gists_url":"https://api.github.com/users/arkpar/gists{/gist_id}","starred_url":"https://api.github.com/users/arkpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkpar/subscriptions","organizations_url":"https://api.github.com/users/arkpar/orgs","repos_url":"https://api.github.com/users/arkpar/repos","events_url":"https://api.github.com/users/arkpar/events{/privacy}","received_events_url":"https://api.github.com/users/arkpar/received_events","type":"User","site_admin":false},"body":"Fixes #424 ","created_at":"2018-07-27T09:48:22Z","updated_at":"2018-07-27T12:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abba0c0dae8153a50c6cff60d160c95e4bb51af6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rphmeier","id":10121380,"node_id":"MDQ6VXNlcjEwMTIxMzgw","avatar_url":"https://avatars1.githubusercontent.com/u/10121380?v=4","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":746560607,"node_id":"MDU6TGFiZWw3NDY1NjA2MDc=","url":"https://api.github.com/repos/paritytech/polkadot/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/polkadot/pulls/433/commits","review_comments_url":"https://api.github.com/repos/paritytech/polkadot/pulls/433/comments","review_comment_url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/polkadot/issues/433/comments","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/f079063dde47bcfa3e1dfc8f32dec60aab94bafb","head":{"label":"paritytech:a-exit-fix","ref":"a-exit-fix","sha":"f079063dde47bcfa3e1dfc8f32dec60aab94bafb","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-07-27T11:24:21Z","pushed_at":"2018-07-27T11:46:12Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":33403,"stargazers_count":288,"watchers_count":288,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":60,"open_issues":80,"watchers":288,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"4b8096449000844c7e49238e0bb4a28b2a8b88d3","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-07-27T11:24:21Z","pushed_at":"2018-07-27T11:46:12Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":33403,"stargazers_count":288,"watchers_count":288,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":60,"open_issues":80,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/433"},"html":{"href":"https://github.com/paritytech/polkadot/pull/433"},"issue":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/433"},"comments":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/433/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/433/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/433/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/polkadot/statuses/f079063dde47bcfa3e1dfc8f32dec60aab94bafb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pepyakin"}}