{"action":"created","issue":{"url":"https://api.github.com/repos/ffrgb/meshviewer/issues/270","repository_url":"https://api.github.com/repos/ffrgb/meshviewer","labels_url":"https://api.github.com/repos/ffrgb/meshviewer/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/ffrgb/meshviewer/issues/270/comments","events_url":"https://api.github.com/repos/ffrgb/meshviewer/issues/270/events","html_url":"https://github.com/ffrgb/meshviewer/pull/270","id":366320747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDIyNjUx","number":270,"title":"[TASK] Allow empty uptime fields","user":{"login":"mwarning","id":546193,"node_id":"MDQ6VXNlcjU0NjE5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/546193?v=4","gravatar_id":"","url":"https://api.github.com/users/mwarning","html_url":"https://github.com/mwarning","followers_url":"https://api.github.com/users/mwarning/followers","following_url":"https://api.github.com/users/mwarning/following{/other_user}","gists_url":"https://api.github.com/users/mwarning/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarning/subscriptions","organizations_url":"https://api.github.com/users/mwarning/orgs","repos_url":"https://api.github.com/users/mwarning/repos","events_url":"https://api.github.com/users/mwarning/events{/privacy}","received_events_url":"https://api.github.com/users/mwarning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-03T12:43:03Z","updated_at":"2018-10-03T14:52:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ffrgb/meshviewer/pulls/270","html_url":"https://github.com/ffrgb/meshviewer/pull/270","diff_url":"https://github.com/ffrgb/meshviewer/pull/270.diff","patch_url":"https://github.com/ffrgb/meshviewer/pull/270.patch"},"body":"Not all our nodes send their uptime as part of a privacy policy (only transfer essential node data by default).\r\n\r\nThis breaks the nodelist and apparently cannot be fixed using the config.default.js."},"comment":{"url":"https://api.github.com/repos/ffrgb/meshviewer/issues/comments/426667317","html_url":"https://github.com/ffrgb/meshviewer/pull/270#issuecomment-426667317","issue_url":"https://api.github.com/repos/ffrgb/meshviewer/issues/270","id":426667317,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjY2NzMxNw==","user":{"login":"xf-","id":1295633,"node_id":"MDQ6VXNlcjEyOTU2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1295633?v=4","gravatar_id":"","url":"https://api.github.com/users/xf-","html_url":"https://github.com/xf-","followers_url":"https://api.github.com/users/xf-/followers","following_url":"https://api.github.com/users/xf-/following{/other_user}","gists_url":"https://api.github.com/users/xf-/gists{/gist_id}","starred_url":"https://api.github.com/users/xf-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xf-/subscriptions","organizations_url":"https://api.github.com/users/xf-/orgs","repos_url":"https://api.github.com/users/xf-/repos","events_url":"https://api.github.com/users/xf-/events{/privacy}","received_events_url":"https://api.github.com/users/xf-/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T14:52:59Z","updated_at":"2018-10-03T14:52:59Z","author_association":"MEMBER","body":"I don't see any advantage\r\n- Everybody can add location - it is optional\r\n- Creating a chart is possible without an uptime field (No load or management traffic means it is not connected to gateway - offline)\r\n- I think is is maybe harmful - you say \"nobody knows then your node was online\", but it is easily logable and visible. Also it is visible since then your node is offline.\r\n- List sorting for uptime is broken\r\n- A lot of information's in meshviewer can easily be used to determine the uptime.\r\nWays to avoid it:\r\n  1. kill respondd, remove node for meshviewer.json\r\n  2. Use a map with nodelist.json format like freifunk-karte.de\r\n\r\n@genofire node list isn't optional\r\n\r\nMaybe some day the node list is configurable as well as node detail."}}
{"actor":{"display_login":"xf-"}}