{"action":"closed","number":1689,"pull_request":{"url":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689","id":220175290,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTc1Mjkw","html_url":"https://github.com/chef/chef-web-docs/pull/1689","diff_url":"https://github.com/chef/chef-web-docs/pull/1689.diff","patch_url":"https://github.com/chef/chef-web-docs/pull/1689.patch","issue_url":"https://api.github.com/repos/chef/chef-web-docs/issues/1689","number":1689,"state":"closed","locked":false,"title":"Custom Resource Props and Keywords","user":{"login":"sean-horn","id":1459992,"node_id":"MDQ6VXNlcjE0NTk5OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1459992?v=4","gravatar_id":"","url":"https://api.github.com/users/sean-horn","html_url":"https://github.com/sean-horn","followers_url":"https://api.github.com/users/sean-horn/followers","following_url":"https://api.github.com/users/sean-horn/following{/other_user}","gists_url":"https://api.github.com/users/sean-horn/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-horn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-horn/subscriptions","organizations_url":"https://api.github.com/users/sean-horn/orgs","repos_url":"https://api.github.com/users/sean-horn/repos","events_url":"https://api.github.com/users/sean-horn/events{/privacy}","received_events_url":"https://api.github.com/users/sean-horn/received_events","type":"User","site_admin":false},"body":"Conflicts between custom resource properties and existing keywords in the resource system, like \":name\" result in difficult to debug errors with no indication from the system that the use of \":name\" will cause an issue. We'll clarify with a warning here.","created_at":"2018-10-03T20:49:07Z","updated_at":"2018-10-04T01:00:23Z","closed_at":"2018-10-04T01:00:23Z","merged_at":"2018-10-04T01:00:23Z","merge_commit_sha":"3ebc3103b4b4a36e910afb2f5e6adb603dd78140","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689/commits","review_comments_url":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689/comments","review_comment_url":"https://api.github.com/repos/chef/chef-web-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-web-docs/issues/1689/comments","statuses_url":"https://api.github.com/repos/chef/chef-web-docs/statuses/153c08b061bcf5b83d4e742ad36fc2860de976c5","head":{"label":"chef:sh/custom-resource-prop-names","ref":"sh/custom-resource-prop-names","sha":"153c08b061bcf5b83d4e742ad36fc2860de976c5","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":51604416,"node_id":"MDEwOlJlcG9zaXRvcnk1MTYwNDQxNg==","name":"chef-web-docs","full_name":"chef/chef-web-docs","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef-web-docs","description":"All The Documentation","fork":false,"url":"https://api.github.com/repos/chef/chef-web-docs","forks_url":"https://api.github.com/repos/chef/chef-web-docs/forks","keys_url":"https://api.github.com/repos/chef/chef-web-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-web-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-web-docs/teams","hooks_url":"https://api.github.com/repos/chef/chef-web-docs/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-web-docs/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-web-docs/events","assignees_url":"https://api.github.com/repos/chef/chef-web-docs/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-web-docs/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-web-docs/tags","blobs_url":"https://api.github.com/repos/chef/chef-web-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-web-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-web-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-web-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-web-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-web-docs/languages","stargazers_url":"https://api.github.com/repos/chef/chef-web-docs/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-web-docs/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-web-docs/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-web-docs/subscription","commits_url":"https://api.github.com/repos/chef/chef-web-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-web-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-web-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-web-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-web-docs/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-web-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-web-docs/merges","archive_url":"https://api.github.com/repos/chef/chef-web-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-web-docs/downloads","issues_url":"https://api.github.com/repos/chef/chef-web-docs/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-web-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-web-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-web-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-web-docs/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-web-docs/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-web-docs/deployments","created_at":"2016-02-12T17:28:03Z","updated_at":"2018-10-01T17:54:15Z","pushed_at":"2018-10-04T01:00:23Z","git_url":"git://github.com/chef/chef-web-docs.git","ssh_url":"git@github.com:chef/chef-web-docs.git","clone_url":"https://github.com/chef/chef-web-docs.git","svn_url":"https://github.com/chef/chef-web-docs","homepage":null,"size":121203,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":323,"open_issues":63,"watchers":66,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"11e160df5f1e3a143ebdef17c201158fe7e3bfc9","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":51604416,"node_id":"MDEwOlJlcG9zaXRvcnk1MTYwNDQxNg==","name":"chef-web-docs","full_name":"chef/chef-web-docs","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef-web-docs","description":"All The Documentation","fork":false,"url":"https://api.github.com/repos/chef/chef-web-docs","forks_url":"https://api.github.com/repos/chef/chef-web-docs/forks","keys_url":"https://api.github.com/repos/chef/chef-web-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-web-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-web-docs/teams","hooks_url":"https://api.github.com/repos/chef/chef-web-docs/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-web-docs/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-web-docs/events","assignees_url":"https://api.github.com/repos/chef/chef-web-docs/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-web-docs/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-web-docs/tags","blobs_url":"https://api.github.com/repos/chef/chef-web-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-web-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-web-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-web-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-web-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-web-docs/languages","stargazers_url":"https://api.github.com/repos/chef/chef-web-docs/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-web-docs/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-web-docs/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-web-docs/subscription","commits_url":"https://api.github.com/repos/chef/chef-web-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-web-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-web-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-web-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-web-docs/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-web-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-web-docs/merges","archive_url":"https://api.github.com/repos/chef/chef-web-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-web-docs/downloads","issues_url":"https://api.github.com/repos/chef/chef-web-docs/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-web-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-web-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-web-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-web-docs/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-web-docs/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-web-docs/deployments","created_at":"2016-02-12T17:28:03Z","updated_at":"2018-10-01T17:54:15Z","pushed_at":"2018-10-04T01:00:23Z","git_url":"git://github.com/chef/chef-web-docs.git","ssh_url":"git@github.com:chef/chef-web-docs.git","clone_url":"https://github.com/chef/chef-web-docs.git","svn_url":"https://github.com/chef/chef-web-docs","homepage":null,"size":121203,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":323,"open_issues":63,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689"},"html":{"href":"https://github.com/chef/chef-web-docs/pull/1689"},"issue":{"href":"https://api.github.com/repos/chef/chef-web-docs/issues/1689"},"comments":{"href":"https://api.github.com/repos/chef/chef-web-docs/issues/1689/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-web-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-web-docs/pulls/1689/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-web-docs/statuses/153c08b061bcf5b83d4e742ad36fc2860de976c5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mjingle","id":5807053,"node_id":"MDQ6VXNlcjU4MDcwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5807053?v=4","gravatar_id":"","url":"https://api.github.com/users/mjingle","html_url":"https://github.com/mjingle","followers_url":"https://api.github.com/users/mjingle/followers","following_url":"https://api.github.com/users/mjingle/following{/other_user}","gists_url":"https://api.github.com/users/mjingle/gists{/gist_id}","starred_url":"https://api.github.com/users/mjingle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjingle/subscriptions","organizations_url":"https://api.github.com/users/mjingle/orgs","repos_url":"https://api.github.com/users/mjingle/repos","events_url":"https://api.github.com/users/mjingle/events{/privacy}","received_events_url":"https://api.github.com/users/mjingle/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":8,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"mjingle"}}