{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/1666","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/1666/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/1666/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/1666/events","html_url":"https://github.com/MetaMask/metamask-extension/issues/1666","id":238319958,"number":1666,"title":"When batch requesting sendTransaction only popup once.","user":{"login":"danfinlay","id":542863,"avatar_url":"https://avatars0.githubusercontent.com/u/542863?v=4","gravatar_id":"","url":"https://api.github.com/users/danfinlay","html_url":"https://github.com/danfinlay","followers_url":"https://api.github.com/users/danfinlay/followers","following_url":"https://api.github.com/users/danfinlay/following{/other_user}","gists_url":"https://api.github.com/users/danfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfinlay/subscriptions","organizations_url":"https://api.github.com/users/danfinlay/orgs","repos_url":"https://api.github.com/users/danfinlay/repos","events_url":"https://api.github.com/users/danfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/danfinlay/received_events","type":"User","site_admin":false},"labels":[{"id":602338228,"url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/L4-backend","name":"L4-backend","color":"73f967","default":false},{"id":602333912,"url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/P2-sooner","name":"P2-sooner","color":"df4b4a","default":false},{"id":257037922,"url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/T0-bug","name":"T0-bug","color":"fc2929","default":false},{"id":718035930,"url":"https://api.github.com/repos/MetaMask/metamask-extension/labels/bounty%20worthy","name":"bounty worthy","color":"96e05e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-06-24T14:19:51Z","updated_at":"2018-03-07T05:55:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"As reported on [this stackexchange post](https://ethereum.stackexchange.com/questions/18660/batch-transactions-for-metamask-using-sendasync), I've confirmed that [using the batch api](https://github.com/ethereum/wiki/wiki/JavaScript-API#batch-requests) to send multiple transaction signing requests opens many metamask windows.\r\n\r\nShould be a simple fix."},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/371031586","html_url":"https://github.com/MetaMask/metamask-extension/issues/1666#issuecomment-371031586","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/1666","id":371031586,"user":{"login":"trigun0x2","id":3936336,"avatar_url":"https://avatars1.githubusercontent.com/u/3936336?v=4","gravatar_id":"","url":"https://api.github.com/users/trigun0x2","html_url":"https://github.com/trigun0x2","followers_url":"https://api.github.com/users/trigun0x2/followers","following_url":"https://api.github.com/users/trigun0x2/following{/other_user}","gists_url":"https://api.github.com/users/trigun0x2/gists{/gist_id}","starred_url":"https://api.github.com/users/trigun0x2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trigun0x2/subscriptions","organizations_url":"https://api.github.com/users/trigun0x2/orgs","repos_url":"https://api.github.com/users/trigun0x2/repos","events_url":"https://api.github.com/users/trigun0x2/events{/privacy}","received_events_url":"https://api.github.com/users/trigun0x2/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T05:55:54Z","updated_at":"2018-03-07T05:55:54Z","author_association":"NONE","body":"Sorry, I've been busy for the paste few weeks, but I'm making some good progress on this issue.\r\n\r\nSeems like `NotificationManager._getPopupIn()` checks the width/height to confirm that a popup window is already open. This fails in some Linux window managers (which opens all windows in max height) and possibly when some extensions affect the window size.\r\n\r\nIs there any particular reason the height/width is being checked? I see that the `NotificationManager` can only create one type of popup anyways. Removing this constraint fixes the issue for me."}}
{"actor":{"display_login":"trigun0x2"}}