{"push_id":3103093424,"size":43,"distinct_size":13,"ref":"refs/heads/181112-ReadmeFormat","head":"82e17bcf605e859eb1753b26b5cefbf2edd9ed41","before":"e979acf290cd546605c01a8ccaf8c7df0806d38d","commits":[{"sha":"4234bf3d568dec55503de851b20ceafc15fd48d5","author":{"name":"Zaliqa","email":"1d910c7dd546eceb76cf11e2a8d4eeb54a7ad177@mcin.ca"},"message":"[Tools/Normalize_consent] Remove validation for consent status \"no\" (#3914)\n\nInitially, we assumed that consent date would only be given if status=yes. Therefore, if status=no but there is a consent date, it is assumed that consent was withdrawn, thus, a withdrawn date is required. The script validates there being a withdrawn date for withdrawn consent. However, some projects also collect a consent date for status=no, breaking down our assumption on withdrawal. This PR removes that validation.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/4234bf3d568dec55503de851b20ceafc15fd48d5"},{"sha":"b1d8e636e973ef4ce75afaf093a57e81fb1e97d1","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[statistics] Fixed undefined index errors with Demographic (#3925)\n\nInside the Demographic of the statistics module, undefined index errors were being printed. This uses isset to catch them.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/b1d8e636e973ef4ce75afaf093a57e81fb1e97d1"},{"sha":"d90a7d09f9de0fefdd698f44b4fc64bdf143ae7b","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[media][imaging_uploader] Fixed a non well formed numeric value encountered in Utility.class.inc (#3930)\n\nFix warnings in media module and imaging uploader.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/d90a7d09f9de0fefdd698f44b4fc64bdf143ae7b"},{"sha":"fd64db6fe96634adf93754cf5ba2cad9ee88c8d2","author":{"name":"Dave MacFarlane","email":"0458f94f48fa8917ec650c254640257a4748f4e2@gmail.com"},"message":"[Router] Fix routing to subpages\n\nThe default module router is supposed to delegate to the page\nbased on the first component of the path of the URL. A typo\nmeans that it was using '@' instead of '/' to determine path\ncomponents, so it would only delegate to pages that have an\nexact match.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/fd64db6fe96634adf93754cf5ba2cad9ee88c8d2"},{"sha":"5b78fc0591c4cbd679e8225fa5e12115892b860e","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[create_timepoint] Fixed Undefined index warnings (#3932)\n\nFixes undefined index warnings in create_timepoint module and when user creates a timepoint.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/5b78fc0591c4cbd679e8225fa5e12115892b860e"},{"sha":"03eea5c382db447f2a2a0dfdc1c25f310512996a","author":{"name":"John Saigle","email":"2a5adbe68b0825f273f9b04ec8e8f8177b91efe6@gmail.com"},"message":"[Docs] Update and rework CONTRIBUTING.md (#3859)\n\nThis makes various changes to the CONTRIBUTING.md document.\r\n\r\nChanges made:\r\n\r\n- Update the base branch practices\r\n- Add code formatting and branch label colours\r\n- Re-organize information flow\r\n- Skew tone toward on-boarding new devs","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/03eea5c382db447f2a2a0dfdc1c25f310512996a"},{"sha":"7734787226ba7fbb803d5b511b3e3ebe38bacf44","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[instrument_manager] Fix Warning: count(): Parameter must be an array or an object that implements Countable (#3929)\n\nFix \"warning count(): Parameter mustbbe an array or an object that implements Countable\" in instrument manager.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/7734787226ba7fbb803d5b511b3e3ebe38bacf44"},{"sha":"bfdef80ef19e46eb35d9205de300e39a1b83e2a6","author":{"name":"Liza Levitis","email":"3a4d388542a3fb1460f1d577659d227ef6e8d06e@mail.mcgill.ca"},"message":"[Tools] updating date zeros removal script (#3709)\n\nThis fixes a bug in the DB_date_zeros_removal.php script.The script doesn't currently check whether not non-nullable fields are date times or timestamps (which have different requirements) causing timestamps to fail.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/bfdef80ef19e46eb35d9205de300e39a1b83e2a6"},{"sha":"a622d85615181a538acd6b7ca48dea1da4a9d2b3","author":{"name":"John Saigle","email":"2a5adbe68b0825f273f9b04ec8e8f8177b91efe6@gmail.com"},"message":"[Examiner] Fix warnings caused by absent variable (#3953)\n\nFix warnings generated when $certificationInstruments['test'] is not present in examiner module.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/a622d85615181a538acd6b7ca48dea1da4a9d2b3"},{"sha":"80b148589dcd4ee10d4d8753e39cff90b9bb7e1b","author":{"name":"Justin Kat","email":"8ff67a33173a02f2906a6e38a032cd2924f12dd1@live.com"},"message":"[Core] Fix getAssociativeSiteList in Utility.class.inc (#3951)\n\nFix the incorrectly parsed Data Coordinating Center site in getAssociativeSiteList in Utilities.class.inc. The code was referring to the wrong field name.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/80b148589dcd4ee10d4d8753e39cff90b9bb7e1b"},{"sha":"7c6657addabdcd6a6679057c058932f790023c73","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[statistics] Fixed undefined index errors with Behavioural (#3927)\n\nThis fixes many undefined index errors inside the behavioural tab of the statistics module by adding isset guards.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/7c6657addabdcd6a6679057c058932f790023c73"},{"sha":"87e0219cbb6c10d41eb10aa6f4d1a0b4b4b84275","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[document_repository] Fixed undefined variable and index errors. (#3931)\n\nFixed undefined variable and index errors in the document_repository.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/87e0219cbb6c10d41eb10aa6f4d1a0b4b4b84275"},{"sha":"af518439d4532c3b87067952ae3a1832e421e2ef","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"Added message if no data is available to download (#3888)\n\nThis provides a message to the user (when no data is available to download) when clicking on the \"Download Data as Zip\" button. Also removes some console output.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/af518439d4532c3b87067952ae3a1832e421e2ef"},{"sha":"8027203aa4b67c2a36e5bc2bf1ca8ef383733944","author":{"name":"Alizée Wickenheiser","email":"a0f786e0b3361822fb8c91e90fbc4e3e6af3564a@users.noreply.github.com"},"message":"[RBdata.sql] Fixed feedback_bvl_type a foreign key constraint fails (#3936)\n\nFixes an issue with the RBdata.sql inserting data into LORIS for testing.\r\n\r\nFeedbacks in RBData were referencing thread types that do not exist in the feedback_types table.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/8027203aa4b67c2a36e5bc2bf1ca8ef383733944"},{"sha":"32c84a621b9dd3a2cc927f262ea67c4d147fe015","author":{"name":"ridz1208","email":"58e1424b9b513d92d36845826a2d7aaa804d329f@users.noreply.github.com"},"message":"[create timepoint] Fix error in logic when projects are enabled (#3943)\n\nIf projects are disabled all subrojects should be displayed by default when creating a timepoint (this was and still is working). When projects are enabled and the project_rel has data for all projects only the designated subprojects should be displayed in the dropdown when creating a timepoint (this was and still is working). When projects are enabled but the project_rel table IS NOT populated, no options should be displayed when creating a timepoint; this fixes that by adding a message asking the administrator to configure projects for the LORIS instance.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/32c84a621b9dd3a2cc927f262ea67c4d147fe015"},{"sha":"c56f3caeac3cc2837515d11a2a2dd8dee81a6905","author":{"name":"John Saigle","email":"2a5adbe68b0825f273f9b04ec8e8f8177b91efe6@gmail.com"},"message":"[Server Processes Manager] Prevent OS command injection (#3944)\n\nValidate that paths/files exists and are what they claim to be.\r\nSanitize parameters to exec function to prevent passing additional\r\narguments.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/c56f3caeac3cc2837515d11a2a2dd8dee81a6905"},{"sha":"9105aae6be819bf6ee2a6838bd248ea491b9c5ed","author":{"name":"ridz1208","email":"58e1424b9b513d92d36845826a2d7aaa804d329f@users.noreply.github.com"},"message":"[data_release] Fix access for admin (#3975)\n\nThe data_release test plan mentions that \"2. Make sure that only the 'superuser' can ... as well as the list of already uploaded files\" which makes sens but is not currently the case. This changes the query slightly to make sure the Admin user can see all the files and only regular users have a limited subsection.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/9105aae6be819bf6ee2a6838bd248ea491b9c5ed"},{"sha":"83d8730cf955b822b45fb3659993b25519e30018","author":{"name":"David Blader","email":"3d1d8561607daaa49656a4fbbd5642fd81c6aa9b@gmail.com"},"message":"[Instrument] Fix warning by changing to \"continue 2\" (#4008)\n\nA line in the NDB_BVL_Instrument class was generating the warning:\r\n\r\nPHP Warning: \"continue\" targeting switch is equivalent to \"break\". Did you mean to use \"continue 2\"? in /var/www/loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2118\r\non version 7.3\r\n\r\n\"continue 2\" or \"break\" would result in the same behavior in this instance since the loop only contains a switch, this changes it to \"continue 2\" because that seems to be closer with what the original author had in mind.\r\n\r\nFor more info see: http://php.net/manual/en/control-structures.continue.php","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/83d8730cf955b822b45fb3659993b25519e30018"},{"sha":"4ccb32ab2c0dfc07f8eff589c376822785298589","author":{"name":"John Saigle","email":"2a5adbe68b0825f273f9b04ec8e8f8177b91efe6@gmail.com"},"message":"[Docs] Specify Apache 2.4 required in README (#3976)\n\nSpecifiy that Apache 2.4 is required.\r\n\r\nHeroku deploy is no longer \"new\" so that is removed.\r\n\r\nResolves #3972.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/4ccb32ab2c0dfc07f8eff589c376822785298589"},{"sha":"1e064652d21f320cc1c7f25c03a0055ebf63056b","author":{"name":"David Blader","email":"3d1d8561607daaa49656a4fbbd5642fd81c6aa9b@gmail.com"},"message":"[NDB_Page] addBasicDate() use dateOptions by default (#4029)\n\nMake addBasicDate suse $this->dateOptions by default if applicable.","distinct":false,"url":"https://api.github.com/repos/johnsaigle/Loris/commits/1e064652d21f320cc1c7f25c03a0055ebf63056b"}]}
{"actor":{"display_login":"johnsaigle"}}