{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/201154853","pull_request_review_id":135601809,"id":201154853,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE1NDg1Mw==","diff_hunk":"@@ -430,31 +433,62 @@ module String {\n       }\n     }\n \n+    /*\n+      Iterates over the string Unicode character by Unicode character.\n+    */\n+    iter uchars(): int(32) {\n+      var localThis: string = this.localize();\n+\n+      var i = 0;\n+      while i < localThis.len {\n+        var codepoint: int(32);\n+        var nbytes: c_int;\n+        var multibytes = (localThis.buff + i): c_string;\n+        var maxbytes = (localThis.len - i): ssize_t;\n+        if maxbytes > 4 then","path":"modules/internal/String.chpl","position":26,"original_position":26,"commit_id":"00d82f58a7ccd0ef5c73261904d863148712261c","original_commit_id":"00d82f58a7ccd0ef5c73261904d863148712261c","user":{"login":"mppf","id":3653132,"node_id":"MDQ6VXNlcjM2NTMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"Does it help anything to have this conditional here? I would have expected qio_decode_char_buf to handle counts > 4. Does it not?","created_at":"2018-07-09T21:35:45Z","updated_at":"2018-07-09T21:45:08Z","html_url":"https://github.com/chapel-lang/chapel/pull/10213#discussion_r201154853","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/201154853"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/10213#discussion_r201154853"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213","id":200206156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjA2MTU2","html_url":"https://github.com/chapel-lang/chapel/pull/10213","diff_url":"https://github.com/chapel-lang/chapel/pull/10213.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/10213.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10213","number":10213,"state":"open","locked":false,"title":"Add UTF-8 support for the ctype methods","user":{"login":"dmk42","id":20049827,"node_id":"MDQ6VXNlcjIwMDQ5ODI3","avatar_url":"https://avatars0.githubusercontent.com/u/20049827?v=4","gravatar_id":"","url":"https://api.github.com/users/dmk42","html_url":"https://github.com/dmk42","followers_url":"https://api.github.com/users/dmk42/followers","following_url":"https://api.github.com/users/dmk42/following{/other_user}","gists_url":"https://api.github.com/users/dmk42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmk42/subscriptions","organizations_url":"https://api.github.com/users/dmk42/orgs","repos_url":"https://api.github.com/users/dmk42/repos","events_url":"https://api.github.com/users/dmk42/events{/privacy}","received_events_url":"https://api.github.com/users/dmk42/received_events","type":"User","site_admin":false},"body":"This change adds UTF-8 support for the ctype methods, `isAlpha()` et al.\r\n\r\nThis change does not attempt to go much beyond the ctype methods.  For example, `split()` will need to be addressed separately.\r\n\r\nTested in UTF-8 and non-UTF-8 environments.  `start_test` is modified to test in a UTF-8 environment now.  To avoid affecting sorting, `LC_COLLATE` is set to `C`.","created_at":"2018-07-09T20:09:07Z","updated_at":"2018-07-09T21:45:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a54cf8a981abed9caa889e9964e3cbbd70e5d1d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10213/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/00d82f58a7ccd0ef5c73261904d863148712261c","head":{"label":"dmk42:utf8_ctype","ref":"utf8_ctype","sha":"00d82f58a7ccd0ef5c73261904d863148712261c","user":{"login":"dmk42","id":20049827,"node_id":"MDQ6VXNlcjIwMDQ5ODI3","avatar_url":"https://avatars0.githubusercontent.com/u/20049827?v=4","gravatar_id":"","url":"https://api.github.com/users/dmk42","html_url":"https://github.com/dmk42","followers_url":"https://api.github.com/users/dmk42/followers","following_url":"https://api.github.com/users/dmk42/following{/other_user}","gists_url":"https://api.github.com/users/dmk42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmk42/subscriptions","organizations_url":"https://api.github.com/users/dmk42/orgs","repos_url":"https://api.github.com/users/dmk42/repos","events_url":"https://api.github.com/users/dmk42/events{/privacy}","received_events_url":"https://api.github.com/users/dmk42/received_events","type":"User","site_admin":false},"repo":{"id":68946239,"node_id":"MDEwOlJlcG9zaXRvcnk2ODk0NjIzOQ==","name":"chapel","full_name":"dmk42/chapel","owner":{"login":"dmk42","id":20049827,"node_id":"MDQ6VXNlcjIwMDQ5ODI3","avatar_url":"https://avatars0.githubusercontent.com/u/20049827?v=4","gravatar_id":"","url":"https://api.github.com/users/dmk42","html_url":"https://github.com/dmk42","followers_url":"https://api.github.com/users/dmk42/followers","following_url":"https://api.github.com/users/dmk42/following{/other_user}","gists_url":"https://api.github.com/users/dmk42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmk42/subscriptions","organizations_url":"https://api.github.com/users/dmk42/orgs","repos_url":"https://api.github.com/users/dmk42/repos","events_url":"https://api.github.com/users/dmk42/events{/privacy}","received_events_url":"https://api.github.com/users/dmk42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmk42/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/dmk42/chapel","forks_url":"https://api.github.com/repos/dmk42/chapel/forks","keys_url":"https://api.github.com/repos/dmk42/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmk42/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmk42/chapel/teams","hooks_url":"https://api.github.com/repos/dmk42/chapel/hooks","issue_events_url":"https://api.github.com/repos/dmk42/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/dmk42/chapel/events","assignees_url":"https://api.github.com/repos/dmk42/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/dmk42/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/dmk42/chapel/tags","blobs_url":"https://api.github.com/repos/dmk42/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmk42/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmk42/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmk42/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmk42/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/dmk42/chapel/languages","stargazers_url":"https://api.github.com/repos/dmk42/chapel/stargazers","contributors_url":"https://api.github.com/repos/dmk42/chapel/contributors","subscribers_url":"https://api.github.com/repos/dmk42/chapel/subscribers","subscription_url":"https://api.github.com/repos/dmk42/chapel/subscription","commits_url":"https://api.github.com/repos/dmk42/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmk42/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmk42/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmk42/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmk42/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/dmk42/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmk42/chapel/merges","archive_url":"https://api.github.com/repos/dmk42/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmk42/chapel/downloads","issues_url":"https://api.github.com/repos/dmk42/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/dmk42/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/dmk42/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/dmk42/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmk42/chapel/labels{/name}","releases_url":"https://api.github.com/repos/dmk42/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/dmk42/chapel/deployments","created_at":"2016-09-22T17:39:39Z","updated_at":"2018-07-07T04:38:22Z","pushed_at":"2018-07-09T20:02:05Z","git_url":"git://github.com/dmk42/chapel.git","ssh_url":"git@github.com:dmk42/chapel.git","clone_url":"https://github.com/dmk42/chapel.git","svn_url":"https://github.com/dmk42/chapel","homepage":"http://chapel.cray.com/","size":526949,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"885931a30c58d9ddd6c4bac775c729f4aaad52f0","user":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2MzI4NQ==","name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2018-07-09T21:40:39Z","pushed_at":"2018-07-09T21:44:13Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"https://chapel-lang.org","size":534533,"stargazers_count":679,"watchers_count":679,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":1032,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":186,"open_issues":1032,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/10213"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/10213"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/10213/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/10213/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/00d82f58a7ccd0ef5c73261904d863148712261c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mppf"}}