{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/3615","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/3615/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/3615/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/3615/events","html_url":"https://github.com/prometheus/prometheus/pull/3615","id":284266923,"number":3615,"title":"Split API structs into separate package","user":{"login":"jacksontj","id":1619869,"avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-22T23:07:14Z","updated_at":"2018-02-19T16:37:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/3615","html_url":"https://github.com/prometheus/prometheus/pull/3615","diff_url":"https://github.com/prometheus/prometheus/pull/3615.diff","patch_url":"https://github.com/prometheus/prometheus/pull/3615.patch"},"body":"All the structs are currently private structs in the v1 package. This\r\nmeans if you want to create a client in golang you have to reimplement\r\n(or copy/paste) structs etc. This Splits them out to a separate package\r\nfor clarity"},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/366745253","html_url":"https://github.com/prometheus/prometheus/pull/3615#issuecomment-366745253","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/3615","id":366745253,"user":{"login":"jacksontj","id":1619869,"avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T16:37:33Z","updated_at":"2018-02-19T16:37:33Z","author_association":"NONE","body":"**Use Case**\r\n\r\nThe use case is still to use them over the HTTP Api -- but specifically if your client is in golang right now that is a pain because (from the original message): `This\r\nmeans if you want to create a client in golang you have to reimplement\r\n(or copy/paste) structs etc.`\r\n\r\n**Separate Package**\r\n\r\nThe main reason to split them out is for docs clarity. I've submitted some PRs in the past to export structs, and the usual complaint it that it pollutes the package godoc space. If we'd prefer to not move these to a separate package I'll gladly change the PR,"}}
{"actor":{"display_login":"jacksontj"}}