{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/12071","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/12071/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/12071/comments","events_url":"https://api.github.com/repos/keybase/client/issues/12071/events","html_url":"https://github.com/keybase/client/pull/12071","id":326673784,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzAxMzI0","number":12071,"title":"Perf 3: New engine helper","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-25T21:51:37Z","updated_at":"2018-06-01T02:31:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/12071","html_url":"https://github.com/keybase/client/pull/12071","diff_url":"https://github.com/keybase/client/pull/12071.diff","patch_url":"https://github.com/keybase/client/pull/12071.patch"},"body":"New engine helper (engine/saga) for handling back and forth rpc calls. \r\n\r\n1. Only calls that are added to the enabled-calls.json are generated. We tell it which call type we want (channelMap (deprecated), promise, or engineSaga)\r\n1. Better flow typing of calls (caught some stuff already)\r\n1. Fix for WrapAndCall saga helper\r\n1. Removed incomingCallMap in promise style call\r\n1. Use saga channel for avatar loading\r\n1. Dont use parseFolderNameToUsers in chat, just split it\r\n1. When figuring out which convo to auto select use maxBy to go through the list once instead of a filter O(N) + sort O(log2n)"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/393740163","html_url":"https://github.com/keybase/client/pull/12071#issuecomment-393740163","issue_url":"https://api.github.com/repos/keybase/client/issues/12071","id":393740163,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc0MDE2Mw==","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T02:31:38Z","updated_at":"2018-06-01T02:31:38Z","author_association":"CONTRIBUTOR","body":"@mmaxim you might want to look at this and how it responds to the service call, should be a lot faster to reply"}}
{"actor":{"display_login":"chrisnojima"}}