{"action":"closed","number":930,"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930","id":241015810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDE1ODEw","html_url":"https://github.com/SpineEventEngine/core-java/pull/930","diff_url":"https://github.com/SpineEventEngine/core-java/pull/930.diff","patch_url":"https://github.com/SpineEventEngine/core-java/pull/930.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/930","number":930,"state":"closed","locked":false,"title":"Command handler contract enforcement","user":{"login":"serhii-lekariev","id":35267320,"node_id":"MDQ6VXNlcjM1MjY3MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/35267320?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-lekariev","html_url":"https://github.com/serhii-lekariev","followers_url":"https://api.github.com/users/serhii-lekariev/followers","following_url":"https://api.github.com/users/serhii-lekariev/following{/other_user}","gists_url":"https://api.github.com/users/serhii-lekariev/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-lekariev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-lekariev/subscriptions","organizations_url":"https://api.github.com/users/serhii-lekariev/orgs","repos_url":"https://api.github.com/users/serhii-lekariev/repos","events_url":"https://api.github.com/users/serhii-lekariev/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-lekariev/received_events","type":"User","site_admin":false},"body":"This PR enables `ModelVerifier` to throw a `SignatureMismatchException` when trying to verify a model that contains `Aggregates` that declare command handlers that don't match the contract.\r\n\r\nBefore, `ModelVerifier` threw an error upon finding a duplicate command handler (i.e. a handler that handles a command that is already handled), ignoring other invalid handlers.\r\n\r\nThis PR also addresses existing warnings that are produced by the `ModelVerifier`, by changing all existing subscriber method declarations to match the `@Subscribe` contract.","created_at":"2018-12-26T17:56:56Z","updated_at":"2019-01-04T17:49:10Z","closed_at":"2019-01-04T17:49:10Z","merged_at":"2019-01-04T17:49:10Z","merge_commit_sha":"1a1ce64d704e9d69edcd28489428b3d7a1fca4dc","assignee":{"login":"serhii-lekariev","id":35267320,"node_id":"MDQ6VXNlcjM1MjY3MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/35267320?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-lekariev","html_url":"https://github.com/serhii-lekariev","followers_url":"https://api.github.com/users/serhii-lekariev/followers","following_url":"https://api.github.com/users/serhii-lekariev/following{/other_user}","gists_url":"https://api.github.com/users/serhii-lekariev/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-lekariev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-lekariev/subscriptions","organizations_url":"https://api.github.com/users/serhii-lekariev/orgs","repos_url":"https://api.github.com/users/serhii-lekariev/repos","events_url":"https://api.github.com/users/serhii-lekariev/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-lekariev/received_events","type":"User","site_admin":false},"assignees":[{"login":"serhii-lekariev","id":35267320,"node_id":"MDQ6VXNlcjM1MjY3MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/35267320?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-lekariev","html_url":"https://github.com/serhii-lekariev","followers_url":"https://api.github.com/users/serhii-lekariev/followers","following_url":"https://api.github.com/users/serhii-lekariev/following{/other_user}","gists_url":"https://api.github.com/users/serhii-lekariev/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-lekariev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-lekariev/subscriptions","organizations_url":"https://api.github.com/users/serhii-lekariev/orgs","repos_url":"https://api.github.com/users/serhii-lekariev/repos","events_url":"https://api.github.com/users/serhii-lekariev/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-lekariev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/930/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/82e4d31223096d9cec1aa0b682258cd656b7a185","head":{"label":"SpineEventEngine:command-handler-contract-enforcement","ref":"command-handler-contract-enforcement","sha":"82e4d31223096d9cec1aa0b682258cd656b7a185","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"node_id":"MDEwOlJlcG9zaXRvcnkzODMxMTkwNg==","name":"core-java","full_name":"SpineEventEngine/core-java","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2019-01-03T12:49:07Z","pushed_at":"2019-01-04T17:49:10Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":113408,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":109,"watchers":12,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"11ddfcec0cccf39c37a2b9d8eb428c7ce3560775","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"node_id":"MDEwOlJlcG9zaXRvcnkzODMxMTkwNg==","name":"core-java","full_name":"SpineEventEngine/core-java","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2019-01-03T12:49:07Z","pushed_at":"2019-01-04T17:49:10Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":113408,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":109,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/930"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/930"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/930/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/930/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/82e4d31223096d9cec1aa0b682258cd656b7a185"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"serhii-lekariev","id":35267320,"node_id":"MDQ6VXNlcjM1MjY3MzIw","avatar_url":"https://avatars2.githubusercontent.com/u/35267320?v=4","gravatar_id":"","url":"https://api.github.com/users/serhii-lekariev","html_url":"https://github.com/serhii-lekariev","followers_url":"https://api.github.com/users/serhii-lekariev/followers","following_url":"https://api.github.com/users/serhii-lekariev/following{/other_user}","gists_url":"https://api.github.com/users/serhii-lekariev/gists{/gist_id}","starred_url":"https://api.github.com/users/serhii-lekariev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhii-lekariev/subscriptions","organizations_url":"https://api.github.com/users/serhii-lekariev/orgs","repos_url":"https://api.github.com/users/serhii-lekariev/repos","events_url":"https://api.github.com/users/serhii-lekariev/events{/privacy}","received_events_url":"https://api.github.com/users/serhii-lekariev/received_events","type":"User","site_admin":false},"comments":3,"review_comments":10,"maintainer_can_modify":false,"commits":24,"additions":294,"deletions":60,"changed_files":28}}
{"actor":{"display_login":"serhii-lekariev"}}