{"push_id":2860204262,"size":90,"distinct_size":36,"ref":"refs/heads/wip/djdeath/tools_changes","head":"5c6de66daf5ef4c971e10627b91634f87e535ba8","before":"734edb2ecaa4352d24cbdbc932fb0698a21676ad","commits":[{"sha":"9b0e8d87233691c1f025002f1da89ed3f8f69583","author":{"name":"Gert Wollny","email":"a4abb7b2c48b4038af2f307a789969b4cce91ae7@collabora.com"},"message":"winsys/virgl: correct resource and handle allocation (v2)\n\nFixes crash with\n  piglit/bin/map_buffer_range-invalidate CopyBufferSubData \\\n                               increment-offset -auto -fbo\n\n* Resize the resource storage already when the count is equal to the\n  allocated size, fixes:\n\n  Invalid write of size 8\n  at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629)\n  by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663)\n  by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)\n  by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)\n  by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)\n  by 0x109A1E: upload (invalidate.c:169)\n  by 0x109C2F: piglit_display (invalidate.c:215)\n  by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)\n  by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)\n  by 0x10949D: main (invalidate.c:47)\n  Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd\n  at 0x4C31B25: calloc (in\n       /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\n  by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567)\n\n* Also resize the space allocated for the handles, fixes:\n\n  Invalid write of size 4\n  at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631)\n  by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663)\n  by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)\n  by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)\n  by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)\n  by 0x109A1E: upload (invalidate.c:169)\n  by 0x109C2F: piglit_display (invalidate.c:215)\n  by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)\n  by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)\n  by 0x10949D: main (invalidate.c:47)\n  Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd\n  at 0x4C2FB0F: malloc (\n    in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so)\n  by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572)\n\nFixes: 4b15b5e803e (\"virgl: resize resource bo allocation if we need to.\")\n\nv2: - Use REALLOC macro and avoid memory leak when re-allocation fails\n    - add Fixes tag (both Emil Velikov)\n    - reorder commit message\n\nSigned-off-by: Gert Wollny <gert.wollny@collabora.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/9b0e8d87233691c1f025002f1da89ed3f8f69583"},{"sha":"5341260f62b66f8b8e503d7c8aff5703629193f0","author":{"name":"Gert Wollny","email":"a4abb7b2c48b4038af2f307a789969b4cce91ae7@collabora.com"},"message":"winsys/virgl: Initialize value to silence valgrind\n\nSilences:\n\n  Conditional jump or move depends on uninitialised value(s)\n  at 0xB72F2C0: virgl_drm_winsys_create (virgl_drm_winsys.c:854)\n  by 0xB72F2C0: virgl_drm_screen_create (virgl_drm_winsys.c:926)\n  by 0xB21C885: pipe_virgl_create_screen (drm_helper.h:275)\n  by 0xB7201F0: pipe_loader_create_screen (pipe_loader.c:137)\n  by 0xB639C91: dri2_init_screen (dri2.c:2112)\n  by 0xB634F68: driCreateNewScreen2 (dri_util.c:153)\n  by 0x63023E6: dri3_create_screen (dri3_glx.c:893)\n  by 0x62D35BD: AllocAndFetchScreenConfigs (glxext.c:820)\n  by 0x62D35BD: __glXInitialize (glxext.c:946)\n  by 0x62CECB3: GetGLXPrivScreenConfig (glxcmds.c:174)\n  by 0x62CF69C: glXQueryExtensionsString (glxcmds.c:1304)\n  by 0x60AA7D9: ??? (in /usr/lib/x86_64-linux-gnu/libwaffle-1.so.0.5.2)\n  by 0x4F81450: wfl_checked_display_connect (piglit-util-waffle.h:74)\n  by 0x4F829E0: piglit_wfl_framework_init (piglit_wfl_framework.c:627)\n\nSigned-off-by: Gert Wollny <gert.wollny@collabora.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/5341260f62b66f8b8e503d7c8aff5703629193f0"},{"sha":"218ff0d5105fe5d8d77e890d213de972980bd510","author":{"name":"Gert Wollny","email":"a4abb7b2c48b4038af2f307a789969b4cce91ae7@collabora.com"},"message":"winsys/virgl/vtest: Correct off-by-one error in resource allocation\n\nThe resource bo array must already extended when the target index is\nequal to the current size of the array.\n\nSigned-off-by: Gert Wollny <gert.wollny@collabora.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/218ff0d5105fe5d8d77e890d213de972980bd510"},{"sha":"960f6459be7fb8e55efb63af1672fc4171251e5f","author":{"name":"Alejandro Piñeiro","email":"5dfedca1889afcca58e9b95acd46f78f54f166ed@igalia.com"},"message":"intel/compiler: remove unused variable num_images\n\nReviewed-by: Jason Ekstrand <jason@jlekstrand.net>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/960f6459be7fb8e55efb63af1672fc4171251e5f"},{"sha":"2a6182fe06731b09d89cdd819e887606d683ed2f","author":{"name":"Alejandro Piñeiro","email":"5dfedca1889afcca58e9b95acd46f78f54f166ed@igalia.com"},"message":"intel/compiler: rename brw_nir_lower_glsl_images\n\nTo brw_nir_lower_gl_images, as it will be also used on the\nARB_gl_spirv codepath, that doesn't involves GLSL at all. So the\nlowering is about images following the OpenGL semantics. In any case\n\"brw_nir_lower_opengl_images\" seemed too long to me, so I just used\ngl. That shortening is already used on other parts of the code.\n\nReviewed-by: Jason Ekstrand <jason@jlekstrand.net>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/2a6182fe06731b09d89cdd819e887606d683ed2f"},{"sha":"8969777686307c5649916d0e2d1024ae1e1af1ce","author":{"name":"Alejandro Piñeiro","email":"5dfedca1889afcca58e9b95acd46f78f54f166ed@igalia.com"},"message":"i965: move brw_nir_lower_gl_images call\n\nAt this moment that lowering is using info coming from the\nUniformStorage, so for the ARB_gl_spirv codepath, it needs to be done\nafter calling gl_nir_link_uniforms. As for the GLSL codepath it can\nalso be called later, we just move the call on both cases, to avoid\nadding several shader->spirv_data checks, and keep the patch as small\nas possible.\n\nThis is the first patch needed to fix the following piglit tests:\n\n  tests/spec/arb_gl_spirv/linker/uniform/multisampler.shader_test\n  tests/spec/arb_gl_spirv/linker/uniform/multisampler-array.shader_test\n\nbut fixes thousands of tests when borrowing the tests from other specs\n(that needs to be done manually right now).\n\nReviewed-by: Jason Ekstrand <jason@jlekstrand.net>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/8969777686307c5649916d0e2d1024ae1e1af1ce"},{"sha":"4e1f8d82c2176be273a8d49f804f5b817252facc","author":{"name":"Alejandro Piñeiro","email":"5dfedca1889afcca58e9b95acd46f78f54f166ed@igalia.com"},"message":"i965/fs: include multisamplers on image_intrinsic_coord_components\n\nThis is the second patch needed to fix the following piglit tests:\n\n   tests/spec/arb_gl_spirv/linker/uniform/multisampler.shader_test\n   tests/spec/arb_gl_spirv/linker/uniform/multisampler-array.shader_test\n\nAlthough in this case it doesn't affect so many borrowed tests, as\nthere aren't too many tests using multisamplers on Intel.\n\nIt is worth to note that this patch is also needed when those tests\nare run on GLSL mode (using the --glsl option). Although most Intel\ndrivers would not be able to run/execute tests using multisamplers, as\nGL_MAX_IMAGE_SAMPLES is zero, technically those tests are expected to\nlink correctly, so linking tests should pass.\n\nReviewed-by: Jason Ekstrand <jason@jlekstrand.net>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/4e1f8d82c2176be273a8d49f804f5b817252facc"},{"sha":"16f17e3a3c1a2f171f882e09bb69ba09a86deb49","author":{"name":"Eric Anholt","email":"96f164ad4d9b2b0dacf8ebee2bb1eeb3aa69adf1@anholt.net"},"message":"loader: Drop unused argument from dri3_update_drawable().\n\nThe argument has never been used since the function was added.\n\nReviewed-by: Michel Dänzer <michel.daenzer@amd.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/16f17e3a3c1a2f171f882e09bb69ba09a86deb49"},{"sha":"f4f39fa5d9692b60a555cec8d4537f05cc93c9ac","author":{"name":"Charmaine Lee","email":"67ce69700661ea856134ddb10419a330e5f037d7@vmware.com"},"message":"winsys/drm: Fix assert when try to accumulate an invalid fd\n\nThis patch makes sure there is a valid fd before merging it\nto the context's fd in vmw_svga_winsys_fence_server_sync().\n\nThis fixes the assert running webot.\nNo regression running kmscube.\n\nReviewed-by: Sinclair Yeh <syeh@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/f4f39fa5d9692b60a555cec8d4537f05cc93c9ac"},{"sha":"bac94dfefa8f6614b6243d68def7c9beab04ec66","author":{"name":"Brian Paul","email":"3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@vmware.com"},"message":"svga: update device header files from upstream\n\nThis is a squash commit of several earlier patches.\n\nSigned-off-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/bac94dfefa8f6614b6243d68def7c9beab04ec66"},{"sha":"6b3627da08997701b837dfb166eb0fb35a6312ee","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"svga: Add SVGA3dCmdIntraSurfaceCopy command support in OpenGL driver\n\nv2: changes as per Charmaine's comment\n\nReviewed-by: Charmaine Lee <charmainel@vmware.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/6b3627da08997701b837dfb166eb0fb35a6312ee"},{"sha":"4639ef37638e34d8225c6ec0a1de864d06bdf951","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"svga/winsys: Add cap2 support in winsys\n\nReviewed-by: Charmaine Lee <charmainel@vmware.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/4639ef37638e34d8225c6ec0a1de864d06bdf951"},{"sha":"8449c33a279113f1b05d79f3e8439f0d537e18ff","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"svga: start using SVGA3dCmdIntraSurfaceCopy command for svga_blit.\n\nBasically, SVGA3dCmdIntraSurfaceCopy command allow copying when\nsource and destination are same.\n\nTested with MTT piglit, glretrace, viewperf, conform\n\nv2: changes as per Charmaine's comment\nv3: changes as per Charmaine's comment\n\nReviewed-by: Charmaine Lee <charmainel@vmware.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/8449c33a279113f1b05d79f3e8439f0d537e18ff"},{"sha":"dfab1289e84978f594972d3c47332f4bc803379d","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"winsys/svga: Avoid cap2 code path for now\n\nCAP2 functionality is not yet part of vmwgfx. This is causing unnecessary\ndmesg error messages.\n\nReviewed-by: Charmaine Lee <charmainel@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/dfab1289e84978f594972d3c47332f4bc803379d"},{"sha":"53091a0312edf38a87a4b7a6e88b52e1887750ca","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"svga: convert dst format to linear when blending is enabled.\n\nWhen blending is enabled, framebuffer colorspace has to be linear.\nPreviously, we never hit this case because we were not supporting sRGB\ndrawable. Previous patch added that support.\n\nTested with mtt glretrace, viewperf, piglit, conform.\n\nReviewed-by: Brian Paul <brianp@vmware.com>\nReviewed-by: Charmaine Lee <charmainel@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/53091a0312edf38a87a4b7a6e88b52e1887750ca"},{"sha":"4310649ccb37481fd0f15ab0c826ed626bf81caa","author":{"name":"Neha Bhende","email":"faec1a32a2d2624ef91f92ce8eed261ff4162c00@vmware.com"},"message":"svga: avoid try_blit() for some depth formats on non vgpu10.\n\nOn non vgpu10, driver doesn't support util_blitter_blit for SVGA3D_Z_D16,\nSVGA3D_Z_D24x8, SVGA3D_Z_D24S8. Patch fixes following piglit tests regression on hwv8 caused\nby commit 27bf35caea5e:\nspec@arb_depth_texture@fbo-depth-gl-depth-component16-blit\nspec@arb_depth_texture@fbo-depth-gl-depth-component24-blit\nspec@arb_depth_texture@fbo-depth-gl-depth-component32-blit\n\nTested with mtt-piglit on hw 8,9,10,11,13 and mtt-glretrace on windows and linux.\n\nReviewed-by: Charmaine Lee <charmainel@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/4310649ccb37481fd0f15ab0c826ed626bf81caa"},{"sha":"49678e9e49fd53000b265904ccabca08b64c4583","author":{"name":"Charmaine Lee","email":"67ce69700661ea856134ddb10419a330e5f037d7@vmware.com"},"message":"svga: sync with upstream changes to surface flags\n\nSVGA device now supports 64 bits surface flags. This patch\nupdates the winsys interface to allow 64 bits surface flags.\nThe linux winsys layer will for now only honor the lower 32 bits of\nthe surface flags.\n\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/49678e9e49fd53000b265904ccabca08b64c4583"},{"sha":"e334e104d0fe8a9704a51ad897cdae34006273da","author":{"name":"Brian Paul","email":"3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@vmware.com"},"message":"svga: encode sample count in resource declarations\n\nNo regressions before the corresponding host-side change.\n\nReviewed-by: Neha Bhende <bhenden@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/e334e104d0fe8a9704a51ad897cdae34006273da"},{"sha":"af104ad79984c96df846ad9ac8d10b0ba67c0a36","author":{"name":"Charmaine Lee","email":"67ce69700661ea856134ddb10419a330e5f037d7@vmware.com"},"message":"svga: rename face to layer_face\n\nReviewed-by: Neha Bhende <bhenden@vmware.com>\nReviewed-by: Brian Paul <brianp@vmware.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/af104ad79984c96df846ad9ac8d10b0ba67c0a36"},{"sha":"d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7","author":{"name":"Dylan Baker","email":"dd378c4ca75f71f527acddef5b43fc35b68d5b7a@pnwbakers.com"},"message":"meson: Print a message about why a libdrm version was selected\n\nWe require a single version of libdrm for all of our libdrm\ndependencies (core and driver), but the way this is structured can make\nthe error message less than helpful, as one driver might be the one\nsetting the libdrm requirement, while another might be the one that\ngenerates the version failure.\n\nThis adds a simple message to the output announcing which libdrm module\nset the version, which might be more helpful.\n\nv2: - Use message suggested by Eric Engstrom\n\nFixes: c445b1d56f47922206de55e557444aadb62e11f6\n       (\"meson: Use the same version for all libdrm checks\")\nReviewed-by: Eric Engestrom <eric.engestrom@intel.com>","distinct":false,"url":"https://api.github.com/repos/djdeath/mesa/commits/d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7"}]}
{"actor":{"display_login":"djdeath"}}