{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22","id":116893754,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE2ODkzNzU0","html_url":"https://github.com/Unity-Technologies/HLSLcc/pull/22","diff_url":"https://github.com/Unity-Technologies/HLSLcc/pull/22.diff","patch_url":"https://github.com/Unity-Technologies/HLSLcc/pull/22.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/22","number":22,"state":"closed","locked":false,"title":"fix issue with negation of (bool->int) result","user":{"login":"fitzymj","id":1123339,"node_id":"MDQ6VXNlcjExMjMzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1123339?v=4","gravatar_id":"","url":"https://api.github.com/users/fitzymj","html_url":"https://github.com/fitzymj","followers_url":"https://api.github.com/users/fitzymj/followers","following_url":"https://api.github.com/users/fitzymj/following{/other_user}","gists_url":"https://api.github.com/users/fitzymj/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzymj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzymj/subscriptions","organizations_url":"https://api.github.com/users/fitzymj/orgs","repos_url":"https://api.github.com/users/fitzymj/repos","events_url":"https://api.github.com/users/fitzymj/events{/privacy}","received_events_url":"https://api.github.com/users/fitzymj/received_events","type":"User","site_admin":false},"body":"An `OPCODE_NOT` followed by a `SVT_BOOL`->`SVT_INT` conversion can result in the following when the `needsBoolUpscale` block is hit:\r\n\r\n```\r\nbool myBool = false;\r\nint result = ~(myBool) * int(0xffffffffu);\r\n```\r\n\r\nThis PR emits the correct GLSL, wrapping the upscale operation in parentheses:\r\n\r\n```\r\nint result = ~((myBool) * int(0xffffffffu));\r\n```\r\n\r\nIt applies the same fix to generated Metal Shading Language.","created_at":"2017-04-21T01:04:58Z","updated_at":"2018-12-27T18:55:04Z","closed_at":"2018-12-27T18:55:04Z","merged_at":null,"merge_commit_sha":"7936674f510d55b318b87c23fc9250ccfb191fb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/22/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/statuses/39cc101381742dcc9c3a6fa7f1e023c8c17ad23c","head":{"label":"harmonix:logic_grouping_fix","ref":"logic_grouping_fix","sha":"39cc101381742dcc9c3a6fa7f1e023c8c17ad23c","user":{"login":"harmonix","id":25520591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTIwNTkx","avatar_url":"https://avatars0.githubusercontent.com/u/25520591?v=4","gravatar_id":"","url":"https://api.github.com/users/harmonix","html_url":"https://github.com/harmonix","followers_url":"https://api.github.com/users/harmonix/followers","following_url":"https://api.github.com/users/harmonix/following{/other_user}","gists_url":"https://api.github.com/users/harmonix/gists{/gist_id}","starred_url":"https://api.github.com/users/harmonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmonix/subscriptions","organizations_url":"https://api.github.com/users/harmonix/orgs","repos_url":"https://api.github.com/users/harmonix/repos","events_url":"https://api.github.com/users/harmonix/events{/privacy}","received_events_url":"https://api.github.com/users/harmonix/received_events","type":"Organization","site_admin":false},"repo":{"id":88922768,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkyMjc2OA==","name":"HLSLcc","full_name":"harmonix/HLSLcc","private":false,"owner":{"login":"harmonix","id":25520591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTIwNTkx","avatar_url":"https://avatars0.githubusercontent.com/u/25520591?v=4","gravatar_id":"","url":"https://api.github.com/users/harmonix","html_url":"https://github.com/harmonix","followers_url":"https://api.github.com/users/harmonix/followers","following_url":"https://api.github.com/users/harmonix/following{/other_user}","gists_url":"https://api.github.com/users/harmonix/gists{/gist_id}","starred_url":"https://api.github.com/users/harmonix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmonix/subscriptions","organizations_url":"https://api.github.com/users/harmonix/orgs","repos_url":"https://api.github.com/users/harmonix/repos","events_url":"https://api.github.com/users/harmonix/events{/privacy}","received_events_url":"https://api.github.com/users/harmonix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harmonix/HLSLcc","description":"DirectX shader bytecode cross compiler","fork":true,"url":"https://api.github.com/repos/harmonix/HLSLcc","forks_url":"https://api.github.com/repos/harmonix/HLSLcc/forks","keys_url":"https://api.github.com/repos/harmonix/HLSLcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harmonix/HLSLcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harmonix/HLSLcc/teams","hooks_url":"https://api.github.com/repos/harmonix/HLSLcc/hooks","issue_events_url":"https://api.github.com/repos/harmonix/HLSLcc/issues/events{/number}","events_url":"https://api.github.com/repos/harmonix/HLSLcc/events","assignees_url":"https://api.github.com/repos/harmonix/HLSLcc/assignees{/user}","branches_url":"https://api.github.com/repos/harmonix/HLSLcc/branches{/branch}","tags_url":"https://api.github.com/repos/harmonix/HLSLcc/tags","blobs_url":"https://api.github.com/repos/harmonix/HLSLcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harmonix/HLSLcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harmonix/HLSLcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/harmonix/HLSLcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harmonix/HLSLcc/statuses/{sha}","languages_url":"https://api.github.com/repos/harmonix/HLSLcc/languages","stargazers_url":"https://api.github.com/repos/harmonix/HLSLcc/stargazers","contributors_url":"https://api.github.com/repos/harmonix/HLSLcc/contributors","subscribers_url":"https://api.github.com/repos/harmonix/HLSLcc/subscribers","subscription_url":"https://api.github.com/repos/harmonix/HLSLcc/subscription","commits_url":"https://api.github.com/repos/harmonix/HLSLcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/harmonix/HLSLcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/harmonix/HLSLcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/harmonix/HLSLcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/harmonix/HLSLcc/contents/{+path}","compare_url":"https://api.github.com/repos/harmonix/HLSLcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harmonix/HLSLcc/merges","archive_url":"https://api.github.com/repos/harmonix/HLSLcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harmonix/HLSLcc/downloads","issues_url":"https://api.github.com/repos/harmonix/HLSLcc/issues{/number}","pulls_url":"https://api.github.com/repos/harmonix/HLSLcc/pulls{/number}","milestones_url":"https://api.github.com/repos/harmonix/HLSLcc/milestones{/number}","notifications_url":"https://api.github.com/repos/harmonix/HLSLcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harmonix/HLSLcc/labels{/name}","releases_url":"https://api.github.com/repos/harmonix/HLSLcc/releases{/id}","deployments_url":"https://api.github.com/repos/harmonix/HLSLcc/deployments","created_at":"2017-04-21T00:33:55Z","updated_at":"2017-04-21T00:33:56Z","pushed_at":"2017-04-21T04:52:32Z","git_url":"git://github.com/harmonix/HLSLcc.git","ssh_url":"git@github.com:harmonix/HLSLcc.git","clone_url":"https://github.com/harmonix/HLSLcc.git","svn_url":"https://github.com/harmonix/HLSLcc","homepage":null,"size":346,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unity-Technologies:master","ref":"master","sha":"e2d66dc0fa2ba3c9f87dc0d90d718b1c6bd8ce86","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":73893213,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg5MzIxMw==","name":"HLSLcc","full_name":"Unity-Technologies/HLSLcc","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/HLSLcc","description":"DirectX shader bytecode cross compiler","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/HLSLcc","forks_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/HLSLcc/deployments","created_at":"2016-11-16T07:01:58Z","updated_at":"2018-12-27T18:29:00Z","pushed_at":"2018-12-27T18:28:56Z","git_url":"git://github.com/Unity-Technologies/HLSLcc.git","ssh_url":"git@github.com:Unity-Technologies/HLSLcc.git","clone_url":"https://github.com/Unity-Technologies/HLSLcc.git","svn_url":"https://github.com/Unity-Technologies/HLSLcc","homepage":null,"size":404,"stargazers_count":351,"watchers_count":351,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":56,"open_issues":19,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22"},"html":{"href":"https://github.com/Unity-Technologies/HLSLcc/pull/22"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/22"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/HLSLcc/statuses/39cc101381742dcc9c3a6fa7f1e023c8c17ad23c"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"aet"}}