{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/223196145","pull_request_review_id":162272657,"id":223196145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE5NjE0NQ==","diff_hunk":"@@ -48,15 +48,11 @@ abstract class BenchmarkBase {\n       if (!file.exists()) {\n         file.createNewFile()\n       }\n-      output = Some(new FileOutputStream(file))\n+      output = Option(new FileOutputStream(file))","path":"core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala","position":5,"original_position":5,"commit_id":"e6f39f36b5d806f1afcea980ba43d544dadbe35f","original_commit_id":"e6f39f36b5d806f1afcea980ba43d544dadbe35f","user":{"login":"dongjoon-hyun","id":9700541,"node_id":"MDQ6VXNlcjk3MDA1NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/9700541?v=4","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"body":"IIUC, @HyukjinKwon meant `when you need to touch this file`.","created_at":"2018-10-06T23:03:14Z","updated_at":"2018-10-06T23:03:14Z","html_url":"https://github.com/apache/spark/pull/22501#discussion_r223196145","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/223196145"},"html":{"href":"https://github.com/apache/spark/pull/22501#discussion_r223196145"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22501"}},"in_reply_to_id":223195081},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22501","id":217027756,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDI3NzU2","html_url":"https://github.com/apache/spark/pull/22501","diff_url":"https://github.com/apache/spark/pull/22501.diff","patch_url":"https://github.com/apache/spark/pull/22501.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22501","number":22501,"state":"open","locked":false,"title":"[SPARK-25492][TEST] Refactor WideSchemaBenchmark to use main method","user":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nRefactor `WideSchemaBenchmark` to use main method.\r\nGenerate benchmark result:\r\n```sh\r\nSPARK_GENERATE_BENCHMARK_FILES=1 build/sbt \"sql/test:runMain org.apache.spark.sql.WideSchemaBenchmark\"\r\n```\r\n\r\n## How was this patch tested?\r\n\r\nmanual tests","created_at":"2018-09-20T16:06:52Z","updated_at":"2018-10-06T23:03:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c948ba94e57cd35cfc9d88ed6c56af2b2f897d5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22501/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22501/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22501/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e6f39f36b5d806f1afcea980ba43d544dadbe35f","head":{"label":"wangyum:SPARK-25492","ref":"SPARK-25492","sha":"e6f39f36b5d806f1afcea980ba43d544dadbe35f","user":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"repo":{"id":75173456,"node_id":"MDEwOlJlcG9zaXRvcnk3NTE3MzQ1Ng==","name":"spark","full_name":"wangyum/spark","private":false,"owner":{"login":"wangyum","id":5399861,"node_id":"MDQ6VXNlcjUzOTk4NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5399861?v=4","gravatar_id":"","url":"https://api.github.com/users/wangyum","html_url":"https://github.com/wangyum","followers_url":"https://api.github.com/users/wangyum/followers","following_url":"https://api.github.com/users/wangyum/following{/other_user}","gists_url":"https://api.github.com/users/wangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/wangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangyum/subscriptions","organizations_url":"https://api.github.com/users/wangyum/orgs","repos_url":"https://api.github.com/users/wangyum/repos","events_url":"https://api.github.com/users/wangyum/events{/privacy}","received_events_url":"https://api.github.com/users/wangyum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wangyum/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wangyum/spark","forks_url":"https://api.github.com/repos/wangyum/spark/forks","keys_url":"https://api.github.com/repos/wangyum/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangyum/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangyum/spark/teams","hooks_url":"https://api.github.com/repos/wangyum/spark/hooks","issue_events_url":"https://api.github.com/repos/wangyum/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wangyum/spark/events","assignees_url":"https://api.github.com/repos/wangyum/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wangyum/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wangyum/spark/tags","blobs_url":"https://api.github.com/repos/wangyum/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangyum/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangyum/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangyum/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangyum/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wangyum/spark/languages","stargazers_url":"https://api.github.com/repos/wangyum/spark/stargazers","contributors_url":"https://api.github.com/repos/wangyum/spark/contributors","subscribers_url":"https://api.github.com/repos/wangyum/spark/subscribers","subscription_url":"https://api.github.com/repos/wangyum/spark/subscription","commits_url":"https://api.github.com/repos/wangyum/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangyum/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangyum/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangyum/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangyum/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wangyum/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangyum/spark/merges","archive_url":"https://api.github.com/repos/wangyum/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangyum/spark/downloads","issues_url":"https://api.github.com/repos/wangyum/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wangyum/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wangyum/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wangyum/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangyum/spark/labels{/name}","releases_url":"https://api.github.com/repos/wangyum/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wangyum/spark/deployments","created_at":"2016-11-30T09:49:08Z","updated_at":"2018-09-05T05:49:48Z","pushed_at":"2018-10-06T18:11:25Z","git_url":"git://github.com/wangyum/spark.git","ssh_url":"git@github.com:wangyum/spark.git","clone_url":"https://github.com/wangyum/spark.git","svn_url":"https://github.com/wangyum/spark","homepage":null,"size":282284,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1ee472eec15e104c4cd087179a9491dc542e15d7","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-10-06T22:54:34Z","pushed_at":"2018-10-06T22:50:20Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":283799,"stargazers_count":18993,"watchers_count":18993,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17073,"mirror_url":null,"archived":false,"open_issues_count":520,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17073,"open_issues":520,"watchers":18993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22501"},"html":{"href":"https://github.com/apache/spark/pull/22501"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22501"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22501/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22501/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22501/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e6f39f36b5d806f1afcea980ba43d544dadbe35f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dongjoon-hyun"}}