{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/comments/240670940","pull_request_review_id":183754062,"id":240670940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDY3MDk0MA==","diff_hunk":"@@ -145,6 +145,25 @@\n                 }\n               ]\n             }\n+          },\n+          {\n+            \"PolicyName\": \"cfnDescribeStacks\",\n+            \"PolicyDocument\": {\n+              \"Version\": \"2012-10-17\",\n+              \"Statement\": [\n+                {\n+                  \"Action\": [\n+                    \"cloudformation:DescribeStacks\"\n+                  ],\n+                  \"Effect\": \"Allow\",\n+                  \"Resource\": [\n+                    {\n+                      \"Fn::Sub\": \"arn:${AWS::Partition}:cloudformation:${AWS::Region}:${AWS::AccountId}:stack/${ClusterName}*\"","path":"cloudformation/batch-substack.cfn.json","position":17,"original_position":17,"commit_id":"a88f6483d154b1664d175c449d6805e423c03115","original_commit_id":"a88f6483d154b1664d175c449d6805e423c03115","user":{"login":"mauri-melato","id":1615209,"node_id":"MDQ6VXNlcjE2MTUyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1615209?v=4","gravatar_id":"","url":"https://api.github.com/users/mauri-melato","html_url":"https://github.com/mauri-melato","followers_url":"https://api.github.com/users/mauri-melato/followers","following_url":"https://api.github.com/users/mauri-melato/following{/other_user}","gists_url":"https://api.github.com/users/mauri-melato/gists{/gist_id}","starred_url":"https://api.github.com/users/mauri-melato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauri-melato/subscriptions","organizations_url":"https://api.github.com/users/mauri-melato/orgs","repos_url":"https://api.github.com/users/mauri-melato/repos","events_url":"https://api.github.com/users/mauri-melato/events{/privacy}","received_events_url":"https://api.github.com/users/mauri-melato/received_events","type":"User","site_admin":false},"body":"why the final '*' ?","created_at":"2018-12-11T15:56:50Z","updated_at":"2018-12-11T15:56:50Z","html_url":"https://github.com/aws/aws-parallelcluster/pull/754#discussion_r240670940","pull_request_url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/comments/240670940"},"html":{"href":"https://github.com/aws/aws-parallelcluster/pull/754#discussion_r240670940"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754","id":237686706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Njg2NzA2","html_url":"https://github.com/aws/aws-parallelcluster/pull/754","diff_url":"https://github.com/aws/aws-parallelcluster/pull/754.diff","patch_url":"https://github.com/aws/aws-parallelcluster/pull/754.patch","issue_url":"https://api.github.com/repos/aws/aws-parallelcluster/issues/754","number":754,"state":"open","locked":false,"title":"Get MASTER_IP internally and avoid to use the variable set by awsbsub","user":{"login":"enrico-usai","id":10634438,"node_id":"MDQ6VXNlcjEwNjM0NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/10634438?v=4","gravatar_id":"","url":"https://api.github.com/users/enrico-usai","html_url":"https://github.com/enrico-usai","followers_url":"https://api.github.com/users/enrico-usai/followers","following_url":"https://api.github.com/users/enrico-usai/following{/other_user}","gists_url":"https://api.github.com/users/enrico-usai/gists{/gist_id}","starred_url":"https://api.github.com/users/enrico-usai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enrico-usai/subscriptions","organizations_url":"https://api.github.com/users/enrico-usai/orgs","repos_url":"https://api.github.com/users/enrico-usai/repos","events_url":"https://api.github.com/users/enrico-usai/events{/privacy}","received_events_url":"https://api.github.com/users/enrico-usai/received_events","type":"User","site_admin":false},"body":"- In future we could remove the MASTER_IP setting from the awsbsub. We are keeping it to avoid to broke the behaviour with existing clusters.\r\n\r\n- Use PCLUSTER_ prefix for internal variables\r\n","created_at":"2018-12-11T13:51:47Z","updated_at":"2018-12-11T15:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7efff68b6d780b1b0135df4421600738845e4767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754/commits","review_comments_url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754/comments","review_comment_url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-parallelcluster/issues/754/comments","statuses_url":"https://api.github.com/repos/aws/aws-parallelcluster/statuses/a88f6483d154b1664d175c449d6805e423c03115","head":{"label":"enrico-usai:wip/masterip","ref":"wip/masterip","sha":"a88f6483d154b1664d175c449d6805e423c03115","user":{"login":"enrico-usai","id":10634438,"node_id":"MDQ6VXNlcjEwNjM0NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/10634438?v=4","gravatar_id":"","url":"https://api.github.com/users/enrico-usai","html_url":"https://github.com/enrico-usai","followers_url":"https://api.github.com/users/enrico-usai/followers","following_url":"https://api.github.com/users/enrico-usai/following{/other_user}","gists_url":"https://api.github.com/users/enrico-usai/gists{/gist_id}","starred_url":"https://api.github.com/users/enrico-usai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enrico-usai/subscriptions","organizations_url":"https://api.github.com/users/enrico-usai/orgs","repos_url":"https://api.github.com/users/enrico-usai/repos","events_url":"https://api.github.com/users/enrico-usai/events{/privacy}","received_events_url":"https://api.github.com/users/enrico-usai/received_events","type":"User","site_admin":false},"repo":{"id":131268556,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyNjg1NTY=","name":"aws-parallelcluster","full_name":"enrico-usai/aws-parallelcluster","private":false,"owner":{"login":"enrico-usai","id":10634438,"node_id":"MDQ6VXNlcjEwNjM0NDM4","avatar_url":"https://avatars3.githubusercontent.com/u/10634438?v=4","gravatar_id":"","url":"https://api.github.com/users/enrico-usai","html_url":"https://github.com/enrico-usai","followers_url":"https://api.github.com/users/enrico-usai/followers","following_url":"https://api.github.com/users/enrico-usai/following{/other_user}","gists_url":"https://api.github.com/users/enrico-usai/gists{/gist_id}","starred_url":"https://api.github.com/users/enrico-usai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enrico-usai/subscriptions","organizations_url":"https://api.github.com/users/enrico-usai/orgs","repos_url":"https://api.github.com/users/enrico-usai/repos","events_url":"https://api.github.com/users/enrico-usai/events{/privacy}","received_events_url":"https://api.github.com/users/enrico-usai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/enrico-usai/aws-parallelcluster","description":"CfnCluster is a framework that deploys and maintains HPC clusters on AWS.","fork":true,"url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster","forks_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/forks","keys_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/teams","hooks_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/hooks","issue_events_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/issues/events{/number}","events_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/events","assignees_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/assignees{/user}","branches_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/branches{/branch}","tags_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/tags","blobs_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/languages","stargazers_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/stargazers","contributors_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/contributors","subscribers_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/subscribers","subscription_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/subscription","commits_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/contents/{+path}","compare_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/merges","archive_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/downloads","issues_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/issues{/number}","pulls_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/labels{/name}","releases_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/releases{/id}","deployments_url":"https://api.github.com/repos/enrico-usai/aws-parallelcluster/deployments","created_at":"2018-04-27T08:28:08Z","updated_at":"2018-12-11T15:42:16Z","pushed_at":"2018-12-11T15:42:14Z","git_url":"git://github.com/enrico-usai/aws-parallelcluster.git","ssh_url":"git@github.com:enrico-usai/aws-parallelcluster.git","clone_url":"https://github.com/enrico-usai/aws-parallelcluster.git","svn_url":"https://github.com/enrico-usai/aws-parallelcluster","homepage":"http://aws.amazon.com/hpc/cfncluster","size":3018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"aws:develop","ref":"develop","sha":"8f8c49aa9dfa68d4af384546bf15908ce664411f","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":19718034,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcxODAzNA==","name":"aws-parallelcluster","full_name":"aws/aws-parallelcluster","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-parallelcluster","description":"AWS ParallelCluster is an AWS supported Open Source cluster management tool to deploy and manage HPC clusters in the AWS cloud.","fork":false,"url":"https://api.github.com/repos/aws/aws-parallelcluster","forks_url":"https://api.github.com/repos/aws/aws-parallelcluster/forks","keys_url":"https://api.github.com/repos/aws/aws-parallelcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-parallelcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-parallelcluster/teams","hooks_url":"https://api.github.com/repos/aws/aws-parallelcluster/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-parallelcluster/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-parallelcluster/events","assignees_url":"https://api.github.com/repos/aws/aws-parallelcluster/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-parallelcluster/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-parallelcluster/tags","blobs_url":"https://api.github.com/repos/aws/aws-parallelcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-parallelcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-parallelcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-parallelcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-parallelcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-parallelcluster/languages","stargazers_url":"https://api.github.com/repos/aws/aws-parallelcluster/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-parallelcluster/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-parallelcluster/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-parallelcluster/subscription","commits_url":"https://api.github.com/repos/aws/aws-parallelcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-parallelcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-parallelcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-parallelcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-parallelcluster/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-parallelcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-parallelcluster/merges","archive_url":"https://api.github.com/repos/aws/aws-parallelcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-parallelcluster/downloads","issues_url":"https://api.github.com/repos/aws/aws-parallelcluster/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-parallelcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-parallelcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-parallelcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-parallelcluster/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-parallelcluster/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-parallelcluster/deployments","created_at":"2014-05-12T22:42:19Z","updated_at":"2018-12-11T15:40:57Z","pushed_at":"2018-12-11T15:54:15Z","git_url":"git://github.com/aws/aws-parallelcluster.git","ssh_url":"git@github.com:aws/aws-parallelcluster.git","clone_url":"https://github.com/aws/aws-parallelcluster.git","svn_url":"https://github.com/aws/aws-parallelcluster","homepage":"https://github.com/aws/aws-parallelcluster","size":3061,"stargazers_count":330,"watchers_count":330,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":131,"open_issues":93,"watchers":330,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754"},"html":{"href":"https://github.com/aws/aws-parallelcluster/pull/754"},"issue":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/issues/754"},"comments":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-parallelcluster/statuses/a88f6483d154b1664d175c449d6805e423c03115"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mauri-melato"}}