{"action":"created","comment":{"url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/comments/235819547","pull_request_review_id":177775289,"id":235819547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTgxOTU0Nw==","diff_hunk":"@@ -25,25 +28,30 @@ ENV HOME_DIR=/opt/payara\\\n     DEPLOY_PROPS=\\\n     POSTBOOT_COMMANDS=/opt/payara/config/post-boot-commands.asadmin\\\n     PREBOOT_COMMANDS=/opt/payara/config/pre-boot-commands.asadmin\n+ENV PATH=\"${PATH}:${PAYARA_DIR}/bin\"\n \n # Create and set the Payara user and working directory owned by the new user\n-RUN groupadd payara && \\\n-    useradd -b ${HOME_DIR} -M -s /bin/bash -d ${HOME_DIR} payara -g payara && \\\n+RUN groupadd -g 1000 payara && \\\n+    useradd -u 1000 -M -s /bin/bash -d ${HOME_DIR} payara -g payara && \\\n     echo payara:payara | chpasswd && \\\n     mkdir -p ${DEPLOY_DIR} && \\\n     mkdir -p ${CONFIG_DIR} && \\\n     mkdir -p ${SCRIPT_DIR} && \\\n-    chown -R payara:payara ${HOME_DIR}\n+    chown -R payara. ${HOME_DIR}","path":"Dockerfile","position":null,"original_position":37,"commit_id":"b8b1ac0bfc64e0a2f4c29228f11184d780e39a38","original_commit_id":"0a5646f551940f573f69a2c2aab8a59be4dfe26a","user":{"login":"poikilotherm","id":5468333,"node_id":"MDQ6VXNlcjU0NjgzMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5468333?v=4","gravatar_id":"","url":"https://api.github.com/users/poikilotherm","html_url":"https://github.com/poikilotherm","followers_url":"https://api.github.com/users/poikilotherm/followers","following_url":"https://api.github.com/users/poikilotherm/following{/other_user}","gists_url":"https://api.github.com/users/poikilotherm/gists{/gist_id}","starred_url":"https://api.github.com/users/poikilotherm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poikilotherm/subscriptions","organizations_url":"https://api.github.com/users/poikilotherm/orgs","repos_url":"https://api.github.com/users/poikilotherm/repos","events_url":"https://api.github.com/users/poikilotherm/events{/privacy}","received_events_url":"https://api.github.com/users/poikilotherm/received_events","type":"User","site_admin":false},"body":"@MattGill98 can this be resolved?","created_at":"2018-11-22T21:18:30Z","updated_at":"2018-11-22T21:18:31Z","html_url":"https://github.com/payara/docker-payaraserver-full/pull/61#discussion_r235819547","pull_request_url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/comments/235819547"},"html":{"href":"https://github.com/payara/docker-payaraserver-full/pull/61#discussion_r235819547"},"pull_request":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61"}},"in_reply_to_id":235731725},"pull_request":{"url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61","id":232969473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTY5NDcz","html_url":"https://github.com/payara/docker-payaraserver-full/pull/61","diff_url":"https://github.com/payara/docker-payaraserver-full/pull/61.diff","patch_url":"https://github.com/payara/docker-payaraserver-full/pull/61.patch","issue_url":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/61","number":61,"state":"open","locked":false,"title":"Minor tweaks plus fixing #55 & #25","user":{"login":"poikilotherm","id":5468333,"node_id":"MDQ6VXNlcjU0NjgzMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5468333?v=4","gravatar_id":"","url":"https://api.github.com/users/poikilotherm","html_url":"https://github.com/poikilotherm","followers_url":"https://api.github.com/users/poikilotherm/followers","following_url":"https://api.github.com/users/poikilotherm/following{/other_user}","gists_url":"https://api.github.com/users/poikilotherm/gists{/gist_id}","starred_url":"https://api.github.com/users/poikilotherm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poikilotherm/subscriptions","organizations_url":"https://api.github.com/users/poikilotherm/orgs","repos_url":"https://api.github.com/users/poikilotherm/repos","events_url":"https://api.github.com/users/poikilotherm/events{/privacy}","received_events_url":"https://api.github.com/users/poikilotherm/received_events","type":"User","site_admin":false},"body":"This PR adds:\r\n\r\n* A few minor tweaks to the Dockerfile\r\n* Add the JVM option to have proper heap spacing around\r\n* Fixes #55\r\n* Fixes #25 by providing direct tini support\r\n* Adds options for more complex init scripts at startup time and uses it for the deploy command generation. Possible use cases: commonly known `wait_for_it.sh`, load data, complex Glassfish commands, ...\r\n\r\nI am happy to change things on your request. Also allowing direct pushes to my feature branch for all upstream maintainers.\r\n\r\nFeedback is very much appreciated.\r\n\r\nCheers,\r\n@poikilotherm","created_at":"2018-11-22T12:52:56Z","updated_at":"2018-11-22T21:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee9a52ffbe428470bfaf42ecec921e28532e6d2a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"OndrejM","id":2195988,"node_id":"MDQ6VXNlcjIxOTU5ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/2195988?v=4","gravatar_id":"","url":"https://api.github.com/users/OndrejM","html_url":"https://github.com/OndrejM","followers_url":"https://api.github.com/users/OndrejM/followers","following_url":"https://api.github.com/users/OndrejM/following{/other_user}","gists_url":"https://api.github.com/users/OndrejM/gists{/gist_id}","starred_url":"https://api.github.com/users/OndrejM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndrejM/subscriptions","organizations_url":"https://api.github.com/users/OndrejM/orgs","repos_url":"https://api.github.com/users/OndrejM/repos","events_url":"https://api.github.com/users/OndrejM/events{/privacy}","received_events_url":"https://api.github.com/users/OndrejM/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1043824135,"node_id":"MDU6TGFiZWwxMDQzODI0MTM1","url":"https://api.github.com/repos/payara/docker-payaraserver-full/labels/CLA-signed","name":"CLA-signed","color":"36c95b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61/commits","review_comments_url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61/comments","review_comment_url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/comments{/number}","comments_url":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/61/comments","statuses_url":"https://api.github.com/repos/payara/docker-payaraserver-full/statuses/b8b1ac0bfc64e0a2f4c29228f11184d780e39a38","head":{"label":"poikilotherm:fix-multiple","ref":"fix-multiple","sha":"b8b1ac0bfc64e0a2f4c29228f11184d780e39a38","user":{"login":"poikilotherm","id":5468333,"node_id":"MDQ6VXNlcjU0NjgzMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5468333?v=4","gravatar_id":"","url":"https://api.github.com/users/poikilotherm","html_url":"https://github.com/poikilotherm","followers_url":"https://api.github.com/users/poikilotherm/followers","following_url":"https://api.github.com/users/poikilotherm/following{/other_user}","gists_url":"https://api.github.com/users/poikilotherm/gists{/gist_id}","starred_url":"https://api.github.com/users/poikilotherm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poikilotherm/subscriptions","organizations_url":"https://api.github.com/users/poikilotherm/orgs","repos_url":"https://api.github.com/users/poikilotherm/repos","events_url":"https://api.github.com/users/poikilotherm/events{/privacy}","received_events_url":"https://api.github.com/users/poikilotherm/received_events","type":"User","site_admin":false},"repo":{"id":157209672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyMDk2NzI=","name":"docker-payaraserver-full","full_name":"poikilotherm/docker-payaraserver-full","private":false,"owner":{"login":"poikilotherm","id":5468333,"node_id":"MDQ6VXNlcjU0NjgzMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5468333?v=4","gravatar_id":"","url":"https://api.github.com/users/poikilotherm","html_url":"https://github.com/poikilotherm","followers_url":"https://api.github.com/users/poikilotherm/followers","following_url":"https://api.github.com/users/poikilotherm/following{/other_user}","gists_url":"https://api.github.com/users/poikilotherm/gists{/gist_id}","starred_url":"https://api.github.com/users/poikilotherm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poikilotherm/subscriptions","organizations_url":"https://api.github.com/users/poikilotherm/orgs","repos_url":"https://api.github.com/users/poikilotherm/repos","events_url":"https://api.github.com/users/poikilotherm/events{/privacy}","received_events_url":"https://api.github.com/users/poikilotherm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/poikilotherm/docker-payaraserver-full","description":"Repository which backs the Docker Hub Payara Server full profile image","fork":true,"url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full","forks_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/forks","keys_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/teams","hooks_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/hooks","issue_events_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/issues/events{/number}","events_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/events","assignees_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/assignees{/user}","branches_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/branches{/branch}","tags_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/tags","blobs_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/git/refs{/sha}","trees_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/statuses/{sha}","languages_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/languages","stargazers_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/stargazers","contributors_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/contributors","subscribers_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/subscribers","subscription_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/subscription","commits_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/commits{/sha}","git_commits_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/git/commits{/sha}","comments_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/comments{/number}","issue_comment_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/issues/comments{/number}","contents_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/contents/{+path}","compare_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/merges","archive_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/downloads","issues_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/issues{/number}","pulls_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/pulls{/number}","milestones_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/milestones{/number}","notifications_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/labels{/name}","releases_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/releases{/id}","deployments_url":"https://api.github.com/repos/poikilotherm/docker-payaraserver-full/deployments","created_at":"2018-11-12T12:23:47Z","updated_at":"2018-11-21T15:01:05Z","pushed_at":"2018-11-22T21:10:59Z","git_url":"git://github.com/poikilotherm/docker-payaraserver-full.git","ssh_url":"git@github.com:poikilotherm/docker-payaraserver-full.git","clone_url":"https://github.com/poikilotherm/docker-payaraserver-full.git","svn_url":"https://github.com/poikilotherm/docker-payaraserver-full","homepage":"https://hub.docker.com/r/payara/server-full/","size":81,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"payara:master","ref":"master","sha":"ece673391e97970efff90aba672206187929e907","user":{"login":"payara","id":7817189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"repo":{"id":58000165,"node_id":"MDEwOlJlcG9zaXRvcnk1ODAwMDE2NQ==","name":"docker-payaraserver-full","full_name":"payara/docker-payaraserver-full","private":false,"owner":{"login":"payara","id":7817189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MTcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/7817189?v=4","gravatar_id":"","url":"https://api.github.com/users/payara","html_url":"https://github.com/payara","followers_url":"https://api.github.com/users/payara/followers","following_url":"https://api.github.com/users/payara/following{/other_user}","gists_url":"https://api.github.com/users/payara/gists{/gist_id}","starred_url":"https://api.github.com/users/payara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payara/subscriptions","organizations_url":"https://api.github.com/users/payara/orgs","repos_url":"https://api.github.com/users/payara/repos","events_url":"https://api.github.com/users/payara/events{/privacy}","received_events_url":"https://api.github.com/users/payara/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/payara/docker-payaraserver-full","description":"Repository which backs the Docker Hub Payara Server full profile image","fork":false,"url":"https://api.github.com/repos/payara/docker-payaraserver-full","forks_url":"https://api.github.com/repos/payara/docker-payaraserver-full/forks","keys_url":"https://api.github.com/repos/payara/docker-payaraserver-full/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payara/docker-payaraserver-full/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payara/docker-payaraserver-full/teams","hooks_url":"https://api.github.com/repos/payara/docker-payaraserver-full/hooks","issue_events_url":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/events{/number}","events_url":"https://api.github.com/repos/payara/docker-payaraserver-full/events","assignees_url":"https://api.github.com/repos/payara/docker-payaraserver-full/assignees{/user}","branches_url":"https://api.github.com/repos/payara/docker-payaraserver-full/branches{/branch}","tags_url":"https://api.github.com/repos/payara/docker-payaraserver-full/tags","blobs_url":"https://api.github.com/repos/payara/docker-payaraserver-full/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payara/docker-payaraserver-full/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payara/docker-payaraserver-full/git/refs{/sha}","trees_url":"https://api.github.com/repos/payara/docker-payaraserver-full/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payara/docker-payaraserver-full/statuses/{sha}","languages_url":"https://api.github.com/repos/payara/docker-payaraserver-full/languages","stargazers_url":"https://api.github.com/repos/payara/docker-payaraserver-full/stargazers","contributors_url":"https://api.github.com/repos/payara/docker-payaraserver-full/contributors","subscribers_url":"https://api.github.com/repos/payara/docker-payaraserver-full/subscribers","subscription_url":"https://api.github.com/repos/payara/docker-payaraserver-full/subscription","commits_url":"https://api.github.com/repos/payara/docker-payaraserver-full/commits{/sha}","git_commits_url":"https://api.github.com/repos/payara/docker-payaraserver-full/git/commits{/sha}","comments_url":"https://api.github.com/repos/payara/docker-payaraserver-full/comments{/number}","issue_comment_url":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/comments{/number}","contents_url":"https://api.github.com/repos/payara/docker-payaraserver-full/contents/{+path}","compare_url":"https://api.github.com/repos/payara/docker-payaraserver-full/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payara/docker-payaraserver-full/merges","archive_url":"https://api.github.com/repos/payara/docker-payaraserver-full/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payara/docker-payaraserver-full/downloads","issues_url":"https://api.github.com/repos/payara/docker-payaraserver-full/issues{/number}","pulls_url":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls{/number}","milestones_url":"https://api.github.com/repos/payara/docker-payaraserver-full/milestones{/number}","notifications_url":"https://api.github.com/repos/payara/docker-payaraserver-full/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payara/docker-payaraserver-full/labels{/name}","releases_url":"https://api.github.com/repos/payara/docker-payaraserver-full/releases{/id}","deployments_url":"https://api.github.com/repos/payara/docker-payaraserver-full/deployments","created_at":"2016-05-03T20:38:06Z","updated_at":"2018-11-22T13:21:29Z","pushed_at":"2018-11-22T21:11:01Z","git_url":"git://github.com/payara/docker-payaraserver-full.git","ssh_url":"git@github.com:payara/docker-payaraserver-full.git","clone_url":"https://github.com/payara/docker-payaraserver-full.git","svn_url":"https://github.com/payara/docker-payaraserver-full","homepage":"https://hub.docker.com/r/payara/server-full/","size":70,"stargazers_count":12,"watchers_count":12,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":16,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61"},"html":{"href":"https://github.com/payara/docker-payaraserver-full/pull/61"},"issue":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/61"},"comments":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/payara/docker-payaraserver-full/statuses/b8b1ac0bfc64e0a2f4c29228f11184d780e39a38"}},"author_association":"NONE"}}
{"actor":{"display_login":"poikilotherm"}}