{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194/events","html_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194","id":350191254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTAxNzE5","number":194,"title":"Refactor benchmark to mitigate memory problems","user":{"login":"andresag01","id":3746901,"node_id":"MDQ6VXNlcjM3NDY5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"labels":[{"id":386183719,"node_id":"MDU6TGFiZWwzODYxODM3MTk=","url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":729182830,"node_id":"MDU6TGFiZWw3MjkxODI4MzA=","url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/labels/runCI","name":"runCI","color":"57db6d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-08-13T20:56:57Z","updated_at":"2018-09-05T08:56:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/pulls/194","html_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194","diff_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194.diff","patch_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194.patch"},"body":"This PR entirely refactors the benchmark example to fix the memory usage issues in Mbed OS (particularly stack overflows). The idea is to run the benchmark for each module in a completely different (noinline) function. Also, some objects are moved to either to the global section or are allocated dynamically.\r\n\r\nThis PR also includes changes to:\r\n* Remove \\r\\n in favour of \\n\r\n* Remove the todo struct which was a remainder from when the program was command line (https://github.com/ARMmbed/mbed-os-example-tls/issues/170)\r\n* Check for errors at every stage (https://github.com/ARMmbed/mbed-os-example-tls/issues/172)\r\n* Enable more test cases by manually defining more MBEDTLS_* macros in a user config\r\n* Consistently use mbedtls_printf (https://github.com/ARMmbed/mbed-os-example-tls/issues/185)\r\n* Remove use of memory_buffer_alloc module (https://github.com/ARMmbed/mbed-os-example-tls/issues/171)\r\n\r\nAlso addresses: https://github.com/ARMmbed/mbed-os-example-tls/issues/52, https://github.com/ARMmbed/mbed-os-example-tls/issues/29, https://github.com/ARMmbed/mbed-os-example-tls/issues/15 and https://github.com/ARMmbed/mbed-os-example-tls/issues/184\r\n\r\n**NOTE:** This PR is currently under development. I have checked that it works in K64F, but I am waiting for the CI to complete to check whether any other memory issues are detected in the other targets. Regardless, the main structure of the change is in place and can be reviewed."},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/comments/418653437","html_url":"https://github.com/ARMmbed/mbed-os-example-tls/pull/194#issuecomment-418653437","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os-example-tls/issues/194","id":418653437,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODY1MzQzNw==","user":{"login":"mazimkhan","id":13520658,"node_id":"MDQ6VXNlcjEzNTIwNjU4","avatar_url":"https://avatars0.githubusercontent.com/u/13520658?v=4","gravatar_id":"","url":"https://api.github.com/users/mazimkhan","html_url":"https://github.com/mazimkhan","followers_url":"https://api.github.com/users/mazimkhan/followers","following_url":"https://api.github.com/users/mazimkhan/following{/other_user}","gists_url":"https://api.github.com/users/mazimkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/mazimkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazimkhan/subscriptions","organizations_url":"https://api.github.com/users/mazimkhan/orgs","repos_url":"https://api.github.com/users/mazimkhan/repos","events_url":"https://api.github.com/users/mazimkhan/events{/privacy}","received_events_url":"https://api.github.com/users/mazimkhan/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T08:56:16Z","updated_at":"2018-09-05T08:56:16Z","author_association":"CONTRIBUTOR","body":"retest"}}
{"actor":{"display_login":"mazimkhan"}}