{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/198162424","pull_request_review_id":132041788,"id":198162424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODE2MjQyNA==","diff_hunk":"@@ -85,10 +85,21 @@ public unsafe bool Equals(BlittableJsonReaderObject x, BlittableJsonReaderObject\n \n                     if (xCalCulated == false)\n                         _xKey.Process(_allocator, xVal);\n+\n                     if (yCalculated == false)\n                         _yKey.Process(_allocator, yVal);\n                 }\n \n+                var xIsNotAllNulls = _xKey.IsBufferSet;\n+                var yIsNotAllNulls = _yKey.IsBufferSet;\n+                // null == null\n+                if (xIsNotAllNulls == false && yIsNotAllNulls == false)\n+                    return true;\n+                // x == null and y != null or y != null and y == null\n+                if (xIsNotAllNulls == false || yIsNotAllNulls == false)\n+                    return false;\n+\n+                //At this point both buffer should be populated","path":"src/Raven.Server/Documents/Indexes/Static/JavaScriptReduceOperation.cs","position":18,"original_position":18,"commit_id":"52cf4d4d33e1818ddd34a979331f2c77ef280b26","original_commit_id":"52cf4d4d33e1818ddd34a979331f2c77ef280b26","user":{"login":"talweiss1982","id":8511829,"node_id":"MDQ6VXNlcjg1MTE4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/8511829?v=4","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"body":"It doesn't matter if this is really rare we still need to handle it correctly.\r\nI did profile JS indexes and Map-Reduce and this was the result of the performance optimization.\r\nThe bottom line is that the code is working, working fast and most importantly correct.","created_at":"2018-06-26T14:18:44Z","updated_at":"2018-06-26T14:18:44Z","html_url":"https://github.com/ravendb/ravendb/pull/6758#discussion_r198162424","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/6758","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/198162424"},"html":{"href":"https://github.com/ravendb/ravendb/pull/6758#discussion_r198162424"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/6758"}},"in_reply_to_id":198146184},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/6758","id":197408387,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDA4Mzg3","html_url":"https://github.com/ravendb/ravendb/pull/6758","diff_url":"https://github.com/ravendb/ravendb/pull/6758.diff","patch_url":"https://github.com/ravendb/ravendb/pull/6758.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/6758","number":6758,"state":"open","locked":false,"title":"Raven db 11425","user":{"login":"talweiss1982","id":8511829,"node_id":"MDQ6VXNlcjg1MTE4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/8511829?v=4","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"body":"** This PR include some minor fixes to javascript indexes examples that are unrelated to the issue (commit - RavenDB-11239 adding Map-Reduce example)","created_at":"2018-06-26T12:41:16Z","updated_at":"2018-06-26T14:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce424c8deccb4ab4046ff3855f8227d895459b67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/6758/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/6758/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/6758/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/52cf4d4d33e1818ddd34a979331f2c77ef280b26","head":{"label":"talweiss1982:RavenDB-11425","ref":"RavenDB-11425","sha":"52cf4d4d33e1818ddd34a979331f2c77ef280b26","user":{"login":"talweiss1982","id":8511829,"node_id":"MDQ6VXNlcjg1MTE4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/8511829?v=4","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"repo":{"id":25456966,"node_id":"MDEwOlJlcG9zaXRvcnkyNTQ1Njk2Ng==","name":"ravendb","full_name":"talweiss1982/ravendb","owner":{"login":"talweiss1982","id":8511829,"node_id":"MDQ6VXNlcjg1MTE4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/8511829?v=4","gravatar_id":"","url":"https://api.github.com/users/talweiss1982","html_url":"https://github.com/talweiss1982","followers_url":"https://api.github.com/users/talweiss1982/followers","following_url":"https://api.github.com/users/talweiss1982/following{/other_user}","gists_url":"https://api.github.com/users/talweiss1982/gists{/gist_id}","starred_url":"https://api.github.com/users/talweiss1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talweiss1982/subscriptions","organizations_url":"https://api.github.com/users/talweiss1982/orgs","repos_url":"https://api.github.com/users/talweiss1982/repos","events_url":"https://api.github.com/users/talweiss1982/events{/privacy}","received_events_url":"https://api.github.com/users/talweiss1982/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talweiss1982/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/talweiss1982/ravendb","forks_url":"https://api.github.com/repos/talweiss1982/ravendb/forks","keys_url":"https://api.github.com/repos/talweiss1982/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talweiss1982/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talweiss1982/ravendb/teams","hooks_url":"https://api.github.com/repos/talweiss1982/ravendb/hooks","issue_events_url":"https://api.github.com/repos/talweiss1982/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/talweiss1982/ravendb/events","assignees_url":"https://api.github.com/repos/talweiss1982/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/talweiss1982/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/talweiss1982/ravendb/tags","blobs_url":"https://api.github.com/repos/talweiss1982/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talweiss1982/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talweiss1982/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/talweiss1982/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talweiss1982/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/talweiss1982/ravendb/languages","stargazers_url":"https://api.github.com/repos/talweiss1982/ravendb/stargazers","contributors_url":"https://api.github.com/repos/talweiss1982/ravendb/contributors","subscribers_url":"https://api.github.com/repos/talweiss1982/ravendb/subscribers","subscription_url":"https://api.github.com/repos/talweiss1982/ravendb/subscription","commits_url":"https://api.github.com/repos/talweiss1982/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/talweiss1982/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/talweiss1982/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/talweiss1982/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/talweiss1982/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/talweiss1982/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talweiss1982/ravendb/merges","archive_url":"https://api.github.com/repos/talweiss1982/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talweiss1982/ravendb/downloads","issues_url":"https://api.github.com/repos/talweiss1982/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/talweiss1982/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/talweiss1982/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/talweiss1982/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talweiss1982/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/talweiss1982/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/talweiss1982/ravendb/deployments","created_at":"2014-10-20T08:14:04Z","updated_at":"2018-05-17T08:43:20Z","pushed_at":"2018-06-26T14:07:45Z","git_url":"git://github.com/talweiss1982/ravendb.git","ssh_url":"git@github.com:talweiss1982/ravendb.git","clone_url":"https://github.com/talweiss1982/ravendb.git","svn_url":"https://github.com/talweiss1982/ravendb","homepage":"http://ayende.com/Blog/","size":442404,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.1","ref":"v4.1","sha":"af63a149c29901793ce00d5a6cd01bc5bd83a673","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2018-06-26T10:08:33Z","pushed_at":"2018-06-26T14:14:51Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":443145,"stargazers_count":1961,"watchers_count":1961,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":683,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":683,"open_issues":12,"watchers":1961,"default_branch":"v4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/6758"},"html":{"href":"https://github.com/ravendb/ravendb/pull/6758"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/6758"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/6758/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/6758/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/6758/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/52cf4d4d33e1818ddd34a979331f2c77ef280b26"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"talweiss1982"}}