{"action":"created","issue":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/287","repository_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions","labels_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/287/comments","events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/287/events","html_url":"https://github.com/facebookresearch/TensorComprehensions/issues/287","id":313062448,"number":287,"title":"Autotuner questions and feedback","user":{"login":"prigoyal","id":13488275,"avatar_url":"https://avatars0.githubusercontent.com/u/13488275?v=4","gravatar_id":"","url":"https://api.github.com/users/prigoyal","html_url":"https://github.com/prigoyal","followers_url":"https://api.github.com/users/prigoyal/followers","following_url":"https://api.github.com/users/prigoyal/following{/other_user}","gists_url":"https://api.github.com/users/prigoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/prigoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prigoyal/subscriptions","organizations_url":"https://api.github.com/users/prigoyal/orgs","repos_url":"https://api.github.com/users/prigoyal/repos","events_url":"https://api.github.com/users/prigoyal/events{/privacy}","received_events_url":"https://api.github.com/users/prigoyal/received_events","type":"User","site_admin":false},"labels":[{"id":829008132,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"ttheodor","id":2536003,"avatar_url":"https://avatars0.githubusercontent.com/u/2536003?v=4","gravatar_id":"","url":"https://api.github.com/users/ttheodor","html_url":"https://github.com/ttheodor","followers_url":"https://api.github.com/users/ttheodor/followers","following_url":"https://api.github.com/users/ttheodor/following{/other_user}","gists_url":"https://api.github.com/users/ttheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/ttheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttheodor/subscriptions","organizations_url":"https://api.github.com/users/ttheodor/orgs","repos_url":"https://api.github.com/users/ttheodor/repos","events_url":"https://api.github.com/users/ttheodor/events{/privacy}","received_events_url":"https://api.github.com/users/ttheodor/received_events","type":"User","site_admin":false},"assignees":[{"login":"ttheodor","id":2536003,"avatar_url":"https://avatars0.githubusercontent.com/u/2536003?v=4","gravatar_id":"","url":"https://api.github.com/users/ttheodor","html_url":"https://github.com/ttheodor","followers_url":"https://api.github.com/users/ttheodor/followers","following_url":"https://api.github.com/users/ttheodor/following{/other_user}","gists_url":"https://api.github.com/users/ttheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/ttheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttheodor/subscriptions","organizations_url":"https://api.github.com/users/ttheodor/orgs","repos_url":"https://api.github.com/users/ttheodor/repos","events_url":"https://api.github.com/users/ttheodor/events{/privacy}","received_events_url":"https://api.github.com/users/ttheodor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-04-10T19:40:44Z","updated_at":"2018-04-10T21:30:59Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"one of our users @jzbontar was using TC autotuner and had the following feedback/questions. I am creating this issue to get more eyes and thoughts from @ttheodor who's our autotuner master :) \r\n\r\n1. When profiling a kernel, does the autotuner call it more than once (for example, to get an accurate measurement)? If yes, then consider making the number of times a kernel is called depend on the kernel’s execution time. Kernels that take a long time to run should not be executed many times. \r\n\r\n2. Can we terminate trials that take longer than, say, 3 * time_of_best_run? Is this already done currently? \r\n\r\n3. When autotuner segfaults due to illegal memory access, it raises abort. It should rather throw exception. Can this be corrected? #271 \r\n   \r\n4. Ctrl-C\r\n  When you hit Ctrl-C to stop the autotuner it does not stop immediately. Instead you have to wait until the end of the generation. This requires changes to the way thread management is implemented right now: i.e. a generation is spinned and if the SIGINT is raised then the current generation continues. \r\n "},"comment":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/comments/380253395","html_url":"https://github.com/facebookresearch/TensorComprehensions/issues/287#issuecomment-380253395","issue_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/287","id":380253395,"user":{"login":"ftynse","id":1512299,"avatar_url":"https://avatars1.githubusercontent.com/u/1512299?v=4","gravatar_id":"","url":"https://api.github.com/users/ftynse","html_url":"https://github.com/ftynse","followers_url":"https://api.github.com/users/ftynse/followers","following_url":"https://api.github.com/users/ftynse/following{/other_user}","gists_url":"https://api.github.com/users/ftynse/gists{/gist_id}","starred_url":"https://api.github.com/users/ftynse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftynse/subscriptions","organizations_url":"https://api.github.com/users/ftynse/orgs","repos_url":"https://api.github.com/users/ftynse/repos","events_url":"https://api.github.com/users/ftynse/events{/privacy}","received_events_url":"https://api.github.com/users/ftynse/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T21:30:59Z","updated_at":"2018-04-10T21:30:59Z","author_association":"COLLABORATOR","body":"4. is a issue that caused long and painful discussions in python integration;  in some cases, aborting the tuning led to python shell being killed; @prigoyal should know this part very well :)\r\n\r\nI still claim that running the entire autotuner in a separate process and killing off that process is a good idea."}}
{"actor":{"display_login":"ftynse"}}