{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/186256778","pull_request_review_id":117808533,"id":186256778,"diff_hunk":"@@ -1,4 +1,3 @@\n \\input{book.hva}\n-\\input{fancysection.hva}","path":"manual/manual/manual.hva","position":2,"original_position":2,"commit_id":"5317b717f63796ae99bd212057656ae061b6f63e","original_commit_id":"5317b717f63796ae99bd212057656ae061b6f63e","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"I should have asked before, but why was this include removed? Is it purely doing section styling?","created_at":"2018-05-05T08:46:03Z","updated_at":"2018-05-05T08:46:04Z","html_url":"https://github.com/ocaml/ocaml/pull/1757#discussion_r186256778","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1757","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/186256778"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1757#discussion_r186256778"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1757"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1757","id":185786209,"html_url":"https://github.com/ocaml/ocaml/pull/1757","diff_url":"https://github.com/ocaml/ocaml/pull/1757.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1757.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757","number":1757,"state":"closed","locked":false,"title":"Style the html manual, changing type and layout","user":{"login":"charlesetc","id":5167293,"avatar_url":"https://avatars1.githubusercontent.com/u/5167293?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesetc","html_url":"https://github.com/charlesetc","followers_url":"https://api.github.com/users/charlesetc/followers","following_url":"https://api.github.com/users/charlesetc/following{/other_user}","gists_url":"https://api.github.com/users/charlesetc/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesetc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesetc/subscriptions","organizations_url":"https://api.github.com/users/charlesetc/orgs","repos_url":"https://api.github.com/users/charlesetc/repos","events_url":"https://api.github.com/users/charlesetc/events{/privacy}","received_events_url":"https://api.github.com/users/charlesetc/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nSo this commit makes major visual changes to the OCaml manual. I'm very happy to take any feedback and make changes.\r\n\r\nI've got [a preview up](http://preview_docs.narwhal.space/index.html) of these changes. This is compared to [the current version](https://caml.inria.fr/pub/docs/manual-ocaml/).\r\n\r\nThe header font is [Fira Sans](https://mozilla.github.io/Fira/). I checked it into this repository, so the font would be served from OCaml's servers. There is an argument to be made for using Google Fonts instead, since it can make things faster through caching. I'd be interested in hearing what people think about that.\r\n\r\nThe only \"hack\" here is the following snippet:\r\n```\r\n\\newstyle{body >\r\n          div:first-child >\r\n          span:first-child >\r\n          span:first-child}{\r\n    font-family: \"Fira Sans\", sans-serif;\r\n}\r\n```\r\n\r\nWhich selects the \"The OCaml System Release 4.08 ...\" heading to make it a different font. Unfortunately there's no id or class by which to select this — if anyone knows how to add one that'd be awesome!\r\n\r\nIn reference to the recent change (https://github.com/ocaml/ocaml/commit/49abafc5872f6be347cdb72a8a4ecccd229b6118) of the manual, this keeps the max-width for the body, but adds a `margin: auto` so that the body is centered. I think this looks slightly better and also more like the current manual. On small screens, when max-width doesn't apply, this also adds a percentage padding. You can go to [preview_docs.narwhal.space](http://preview_docs.narwhal.space) on a phone to see how it looks.\r\n\r\nAnyways, I'm glad to make any changes people see fit :cactus: ","created_at":"2018-05-03T17:29:43Z","updated_at":"2018-05-05T08:46:04Z","closed_at":"2018-05-05T08:42:49Z","merged_at":"2018-05-05T08:42:49Z","merge_commit_sha":"ced02672c1ef3f147b98e12ad70943eb913f0fb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1757/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1757/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/5317b717f63796ae99bd212057656ae061b6f63e","head":{"label":"charlesetc:manual-formatting","ref":"manual-formatting","sha":"5317b717f63796ae99bd212057656ae061b6f63e","user":{"login":"charlesetc","id":5167293,"avatar_url":"https://avatars1.githubusercontent.com/u/5167293?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesetc","html_url":"https://github.com/charlesetc","followers_url":"https://api.github.com/users/charlesetc/followers","following_url":"https://api.github.com/users/charlesetc/following{/other_user}","gists_url":"https://api.github.com/users/charlesetc/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesetc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesetc/subscriptions","organizations_url":"https://api.github.com/users/charlesetc/orgs","repos_url":"https://api.github.com/users/charlesetc/repos","events_url":"https://api.github.com/users/charlesetc/events{/privacy}","received_events_url":"https://api.github.com/users/charlesetc/received_events","type":"User","site_admin":false},"repo":{"id":74731762,"name":"ocaml","full_name":"charlesetc/ocaml","owner":{"login":"charlesetc","id":5167293,"avatar_url":"https://avatars1.githubusercontent.com/u/5167293?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesetc","html_url":"https://github.com/charlesetc","followers_url":"https://api.github.com/users/charlesetc/followers","following_url":"https://api.github.com/users/charlesetc/following{/other_user}","gists_url":"https://api.github.com/users/charlesetc/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesetc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesetc/subscriptions","organizations_url":"https://api.github.com/users/charlesetc/orgs","repos_url":"https://api.github.com/users/charlesetc/repos","events_url":"https://api.github.com/users/charlesetc/events{/privacy}","received_events_url":"https://api.github.com/users/charlesetc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlesetc/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/charlesetc/ocaml","forks_url":"https://api.github.com/repos/charlesetc/ocaml/forks","keys_url":"https://api.github.com/repos/charlesetc/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesetc/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesetc/ocaml/teams","hooks_url":"https://api.github.com/repos/charlesetc/ocaml/hooks","issue_events_url":"https://api.github.com/repos/charlesetc/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/charlesetc/ocaml/events","assignees_url":"https://api.github.com/repos/charlesetc/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/charlesetc/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/charlesetc/ocaml/tags","blobs_url":"https://api.github.com/repos/charlesetc/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesetc/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesetc/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesetc/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesetc/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesetc/ocaml/languages","stargazers_url":"https://api.github.com/repos/charlesetc/ocaml/stargazers","contributors_url":"https://api.github.com/repos/charlesetc/ocaml/contributors","subscribers_url":"https://api.github.com/repos/charlesetc/ocaml/subscribers","subscription_url":"https://api.github.com/repos/charlesetc/ocaml/subscription","commits_url":"https://api.github.com/repos/charlesetc/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesetc/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesetc/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesetc/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesetc/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/charlesetc/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesetc/ocaml/merges","archive_url":"https://api.github.com/repos/charlesetc/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesetc/ocaml/downloads","issues_url":"https://api.github.com/repos/charlesetc/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/charlesetc/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesetc/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesetc/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesetc/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/charlesetc/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/charlesetc/ocaml/deployments","created_at":"2016-11-25T06:30:32Z","updated_at":"2018-05-03T16:56:17Z","pushed_at":"2018-05-05T04:41:58Z","git_url":"git://github.com/charlesetc/ocaml.git","ssh_url":"git@github.com:charlesetc/ocaml.git","clone_url":"https://github.com/charlesetc/ocaml.git","svn_url":"https://github.com/charlesetc/ocaml","homepage":"","size":163698,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"a308c361b6bffc0b3774c9d14997ad3b06f4b73f","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-05-05T08:43:13Z","pushed_at":"2018-05-05T08:42:49Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":169121,"stargazers_count":1791,"watchers_count":1791,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":454,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":454,"open_issues":159,"watchers":1791,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1757"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1757"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1757"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1757/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1757/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1757/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/5317b717f63796ae99bd212057656ae061b6f63e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gasche"}}