{"action":"created","issue":{"url":"https://api.github.com/repos/rajarshi/cdkr/issues/68","repository_url":"https://api.github.com/repos/rajarshi/cdkr","labels_url":"https://api.github.com/repos/rajarshi/cdkr/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/rajarshi/cdkr/issues/68/comments","events_url":"https://api.github.com/repos/rajarshi/cdkr/issues/68/events","html_url":"https://github.com/rajarshi/cdkr/issues/68","id":320259614,"number":68,"title":"Poor error message for invalid smiles in rinchi","user":{"login":"sneumann","id":195385,"avatar_url":"https://avatars2.githubusercontent.com/u/195385?v=4","gravatar_id":"","url":"https://api.github.com/users/sneumann","html_url":"https://github.com/sneumann","followers_url":"https://api.github.com/users/sneumann/followers","following_url":"https://api.github.com/users/sneumann/following{/other_user}","gists_url":"https://api.github.com/users/sneumann/gists{/gist_id}","starred_url":"https://api.github.com/users/sneumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sneumann/subscriptions","organizations_url":"https://api.github.com/users/sneumann/orgs","repos_url":"https://api.github.com/users/sneumann/repos","events_url":"https://api.github.com/users/sneumann/events{/privacy}","received_events_url":"https://api.github.com/users/sneumann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-04T12:39:09Z","updated_at":"2018-05-04T12:46:02Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi,\r\nwe get a not so informative error message when passing crap into `get.inchi()`\r\n```\r\n> get.inchi(\"x\")\r\nError in .jcall(\"org/guha/rcdk/util/Misc\", \"S\", \"getInChi\", molecule,  : \r\n  method getInChi with signature ()Ljava/lang/String; not found\r\n```\r\nIt would be better to throw a better error message `invalid SMILES` back to R.\r\nYours, Steffen"},"comment":{"url":"https://api.github.com/repos/rajarshi/cdkr/issues/comments/386590301","html_url":"https://github.com/rajarshi/cdkr/issues/68#issuecomment-386590301","issue_url":"https://api.github.com/repos/rajarshi/cdkr/issues/68","id":386590301,"user":{"login":"schymane","id":4070141,"avatar_url":"https://avatars2.githubusercontent.com/u/4070141?v=4","gravatar_id":"","url":"https://api.github.com/users/schymane","html_url":"https://github.com/schymane","followers_url":"https://api.github.com/users/schymane/followers","following_url":"https://api.github.com/users/schymane/following{/other_user}","gists_url":"https://api.github.com/users/schymane/gists{/gist_id}","starred_url":"https://api.github.com/users/schymane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schymane/subscriptions","organizations_url":"https://api.github.com/users/schymane/orgs","repos_url":"https://api.github.com/users/schymane/repos","events_url":"https://api.github.com/users/schymane/events{/privacy}","received_events_url":"https://api.github.com/users/schymane/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T12:46:02Z","updated_at":"2018-05-04T12:46:02Z","author_association":"CONTRIBUTOR","body":"I put tryCatch when using a lot of these functions to print out an error for myself because sometimes the java message is actually helpful to find the cause of the problem (I am not sure in this case if you’d get different ones). It’s quite hard to detect whether it’s an invalid SMILES or just one that can’t be processed properly and hence you can get a variety of causes and may be able to go through some options.\r\nSome of this has changed in the newer rcdk versions and I’ve not updated all my old functions yet :-)\r\n"}}
{"actor":{"display_login":"schymane"}}