{"action":"created","issue":{"url":"https://api.github.com/repos/github/fetch/issues/592","repository_url":"https://api.github.com/repos/github/fetch","labels_url":"https://api.github.com/repos/github/fetch/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/github/fetch/issues/592/comments","events_url":"https://api.github.com/repos/github/fetch/issues/592/events","html_url":"https://github.com/github/fetch/pull/592","id":280056149,"number":592,"title":"Support abort API","user":{"login":"jamesplease","id":2322305,"avatar_url":"https://avatars3.githubusercontent.com/u/2322305?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesplease","html_url":"https://github.com/jamesplease","followers_url":"https://api.github.com/users/jamesplease/followers","following_url":"https://api.github.com/users/jamesplease/following{/other_user}","gists_url":"https://api.github.com/users/jamesplease/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesplease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesplease/subscriptions","organizations_url":"https://api.github.com/users/jamesplease/orgs","repos_url":"https://api.github.com/users/jamesplease/repos","events_url":"https://api.github.com/users/jamesplease/events{/privacy}","received_events_url":"https://api.github.com/users/jamesplease/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2017-12-07T09:21:19Z","updated_at":"2018-02-21T17:06:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/github/fetch/pulls/592","html_url":"https://github.com/github/fetch/pull/592","diff_url":"https://github.com/github/fetch/pull/592.diff","patch_url":"https://github.com/github/fetch/pull/592.patch"},"body":"This is a quick pass at an attempt to resolve #547 . The intention is that it would supersede #572\r\n\r\nTodo:\r\n\r\n- [ ] Tests\r\n- [ ] ~~Verify that the feature detection works~~\r\n- [x] Update documentation\r\n\r\nFeedback is welcome! Thanks for reviewing :v:"},"comment":{"url":"https://api.github.com/repos/github/fetch/issues/comments/367397643","html_url":"https://github.com/github/fetch/pull/592#issuecomment-367397643","issue_url":"https://api.github.com/repos/github/fetch/issues/592","id":367397643,"user":{"login":"joaovieira","id":474603,"avatar_url":"https://avatars0.githubusercontent.com/u/474603?v=4","gravatar_id":"","url":"https://api.github.com/users/joaovieira","html_url":"https://github.com/joaovieira","followers_url":"https://api.github.com/users/joaovieira/followers","following_url":"https://api.github.com/users/joaovieira/following{/other_user}","gists_url":"https://api.github.com/users/joaovieira/gists{/gist_id}","starred_url":"https://api.github.com/users/joaovieira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaovieira/subscriptions","organizations_url":"https://api.github.com/users/joaovieira/orgs","repos_url":"https://api.github.com/users/joaovieira/repos","events_url":"https://api.github.com/users/joaovieira/events{/privacy}","received_events_url":"https://api.github.com/users/joaovieira/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T17:06:20Z","updated_at":"2018-02-21T17:06:20Z","author_association":"NONE","body":"Ok, let me clarify my points:\r\n\r\n1. I meant to pull parts of that [patch-fetch.js](https://github.com/mo/abortcontroller-polyfill/blob/master/src/patch-fetch.js) into here as another PR. This is to tackle part 2. of the problem identified in https://github.com/github/fetch/pull/592#pullrequestreview-81886705. Since we just added the aborting behaviour for the polyfilled fetch, it sounds natural to patch the native fetch in here as well. As a user I'd expect that.\r\n\r\n2. If I hadn't seen the source code of `abortcontroller-polyfill`, I would not expect it to patch fetch. I'd assume it just provides an implementation of `AbortController`/`AbortSignal`. As @jimmywarting mentioned in https://github.com/github/fetch/pull/572#issuecomment-341198011, `AbortController` is not fetch specific.\r\n\r\nIn this scenario, the import order doesn't matter since `abortcontroller-polyfill` would not do anything to `window.fetch` and `whatwg-fetch` does not require `AbortController`. This is also what @just-boris mentioned in https://github.com/github/fetch/pull/572#issuecomment-337740989."}}
{"actor":{"display_login":"joaovieira"}}