{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/28238","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/28238/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/28238/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/28238/events","html_url":"https://github.com/dotnet/corefx/issues/28238","id":306718767,"number":28238,"title":"Consolidate the string and span tests for the string-like APIs","user":{"login":"ahsonkhan","id":6527137,"avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"labels":[{"id":547241922,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Memory","name":"area-System.Memory","color":"d4c5f9","default":false},{"id":443855532,"url":"https://api.github.com/repos/dotnet/corefx/labels/test%20enhancement","name":"test enhancement","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"MarcoRossignoli","id":7894084,"avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarcoRossignoli","id":7894084,"avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/5","html_url":"https://github.com/dotnet/corefx/milestone/5","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/5/labels","id":1328080,"number":5,"title":"Future","description":"Milestone tracking issues not triaged to a planned release. Work in this milestone may happen, or may not: it is not committed.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars1.githubusercontent.com/u/1302850?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":2051,"closed_issues":109,"state":"open","created_at":"2015-09-29T00:25:45Z","updated_at":"2018-04-20T22:21:19Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-03-20T03:44:02Z","updated_at":"2018-04-21T07:55:36Z","closed_at":null,"author_association":"MEMBER","body":"See https://github.com/dotnet/corefx/pull/27319#discussion_r170049466 for additional details and context.\r\n\r\nThis way, all the tests will be in one place making it easier to maintain, rather than duplicated between assemblies. Consider moving them to Common as well and reference from System.Memory.csproj so that running System.Memory tests will run all the span related tests.\r\n\r\ncc @tarekgh "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/383275980","html_url":"https://github.com/dotnet/corefx/issues/28238#issuecomment-383275980","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/28238","id":383275980,"user":{"login":"MarcoRossignoli","id":7894084,"avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"created_at":"2018-04-21T07:55:35Z","updated_at":"2018-04-21T07:55:35Z","author_association":"COLLABORATOR","body":"> Refactor the StringTests.cs to isolate these newly added span-based tests into a separate file (possibly moving them to Common) and reference them from System.Memory.Tests.csproj so that we can execute all relevant Span tests when running msbuild on S.M.T, rather than having to run tests from several places.\r\nThis will likely result in some code duplication.\r\n\r\nDo you mean create StringTests.Span.cs under src\\Common\\tests\\Tests\\System and add reference to System.Memory.Tests. and System.Runtime.Tests?"}}
{"actor":{"display_login":"MarcoRossignoli"}}