{"action":"created","issue":{"url":"https://api.github.com/repos/smartcar/node-sdk/issues/56","repository_url":"https://api.github.com/repos/smartcar/node-sdk","labels_url":"https://api.github.com/repos/smartcar/node-sdk/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/smartcar/node-sdk/issues/56/comments","events_url":"https://api.github.com/repos/smartcar/node-sdk/issues/56/events","html_url":"https://github.com/smartcar/node-sdk/pull/56","id":339211110,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTMzMzE0","number":56,"title":"Fix user agent header and include node.js version","user":{"login":"gurpreetatwal","id":7547554,"node_id":"MDQ6VXNlcjc1NDc1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7547554?v=4","gravatar_id":"","url":"https://api.github.com/users/gurpreetatwal","html_url":"https://github.com/gurpreetatwal","followers_url":"https://api.github.com/users/gurpreetatwal/followers","following_url":"https://api.github.com/users/gurpreetatwal/following{/other_user}","gists_url":"https://api.github.com/users/gurpreetatwal/gists{/gist_id}","starred_url":"https://api.github.com/users/gurpreetatwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurpreetatwal/subscriptions","organizations_url":"https://api.github.com/users/gurpreetatwal/orgs","repos_url":"https://api.github.com/users/gurpreetatwal/repos","events_url":"https://api.github.com/users/gurpreetatwal/events{/privacy}","received_events_url":"https://api.github.com/users/gurpreetatwal/received_events","type":"User","site_admin":false},"labels":[{"id":833915875,"node_id":"MDU6TGFiZWw4MzM5MTU4NzU=","url":"https://api.github.com/repos/smartcar/node-sdk/labels/Priority:%202%20-%20Medium","name":"Priority: 2 - Medium","color":"78909C","default":false},{"id":810498505,"node_id":"MDU6TGFiZWw4MTA0OTg1MDU=","url":"https://api.github.com/repos/smartcar/node-sdk/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ffeb3b","default":false},{"id":400608726,"node_id":"MDU6TGFiZWw0MDA2MDg3MjY=","url":"https://api.github.com/repos/smartcar/node-sdk/labels/Type:%20Bug","name":"Type: Bug","color":"e51400","default":false},{"id":400608728,"node_id":"MDU6TGFiZWw0MDA2MDg3Mjg=","url":"https://api.github.com/repos/smartcar/node-sdk/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"1976D2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-08T09:22:38Z","updated_at":"2018-07-09T01:31:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/smartcar/node-sdk/pulls/56","html_url":"https://github.com/smartcar/node-sdk/pull/56","diff_url":"https://github.com/smartcar/node-sdk/pull/56.diff","patch_url":"https://github.com/smartcar/node-sdk/pull/56.patch"},"body":"Fixes the `user-agent` header so that it reports the version of the client making the request as opposed to Smartcar API being accessed (which is in the URL) as it currently does.\r\n\r\nI also added in the version of node.js that the request was made from for tracking of which node version we should support. Please take a close look at the format of the header as well as if we should be including more or less information in it. (first glance `process.platform` might be useful for windows/osx/linux support)\r\n\r\nFormat: `smartcar-node-sdk:<pkg-version> (node.js <node-version>)`\r\nExample: `smartcar-node-sdk:3.0.2 (node.js v6.14.3)`\r\n\r\nExamples of headers from other API libraries:\r\n- [Sendgrid](https://github.com/sendgrid/sendgrid-nodejs/blob/master/packages/client/src/classes/client.js#L33): `sendgrid/<pkg-version>;nodejs`\r\n- [Twillio](https://github.com/twilio/twilio-node/blob/1bd5ed6c2f42ff3bcc08ae236de577ab3eda2442/lib/rest/Twilio.js#L192) : `twilio-node/<pkg-version> (node.js <node-version>)`\r\n- [Plaid](https://github.com/plaid/plaid-node/blob/master/lib/plaidRequest.js#L55):  `Plaid Node v<pkg-version>`\r\n- [Lob](https://github.com/lob/lob-node/blob/master/lib/index.js#L7): `Lob/v1 NodeBindings/<pkg-version>`\r\n- [PayPal](https://github.com/paypal/PayPal-node-SDK/blob/master/lib/configure.js#L5):  `PayPalSDK/PayPal-node-SDK <pkg-version> (node <node-version>-${process.arch}-${process.platform}; OpenSSL ${process.versions.openssl}`\r\n- [AWS](https://github.com/aws/aws-sdk-js/blob/9c15bf971d40266f3cb7f1d9d63f8a702abb596f/lib/util.js#L32): `aws-sdk-nodejs/<pkg-version> ${process.platform}/<node-version>`\r\n- [Stripe](https://github.com/stripe/stripe-node/blob/34113d273d7db059bd255393c8c6c8983484b323/lib/stripe.js#L13):\r\n```js\r\nJSON.stringify({\r\n  bindings_version: Stripe.PACKAGE_VERSION,\r\n  lang: 'node',\r\n  lang_version: process.version,\r\n  platform: process.platform,\r\n  publisher: 'stripe',\r\n  uname: <output of `uname -a`>\r\n})\r\n```"},"comment":{"url":"https://api.github.com/repos/smartcar/node-sdk/issues/comments/403335286","html_url":"https://github.com/smartcar/node-sdk/pull/56#issuecomment-403335286","issue_url":"https://api.github.com/repos/smartcar/node-sdk/issues/56","id":403335286,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzMzNTI4Ng==","user":{"login":"KarthikBhaskara","id":8335426,"node_id":"MDQ6VXNlcjgzMzU0MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8335426?v=4","gravatar_id":"","url":"https://api.github.com/users/KarthikBhaskara","html_url":"https://github.com/KarthikBhaskara","followers_url":"https://api.github.com/users/KarthikBhaskara/followers","following_url":"https://api.github.com/users/KarthikBhaskara/following{/other_user}","gists_url":"https://api.github.com/users/KarthikBhaskara/gists{/gist_id}","starred_url":"https://api.github.com/users/KarthikBhaskara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarthikBhaskara/subscriptions","organizations_url":"https://api.github.com/users/KarthikBhaskara/orgs","repos_url":"https://api.github.com/users/KarthikBhaskara/repos","events_url":"https://api.github.com/users/KarthikBhaskara/events{/privacy}","received_events_url":"https://api.github.com/users/KarthikBhaskara/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T01:31:09Z","updated_at":"2018-07-09T01:31:09Z","author_association":"NONE","body":"@gurpreetatwal Any reason why we're choosing to use ```:``` instead of ```/```. Seems like other api's are using ```/```. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent#Syntax"}}
{"actor":{"display_login":"KarthikBhaskara"}}