{"action":"created","comment":{"url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/comments/195839067","pull_request_review_id":129287908,"id":195839067,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTgzOTA2Nw==","diff_hunk":"@@ -2,17 +2,17 @@\n \n * Set up the Kubernetes environment\n   * Create a service account and give it access to the BigQuery tables for your\n-  dataset\n-    * Navigate to the project where you will deploy Data explorer.\n-    * [Following the principle of least privilege](https://cloud.google.com/kubernetes-engine/docs/tutorials/authenticating-to-cloud-platform#why_use_service_accounts),\n-    we create a service account and give it only the necessary permissions,\n-    rather than use the default Compute Engine service account. At the end of\n-    this section, the new service account will have access to the BigQuery\n-    tables for your dataset. Before creating the service account, you must\n-    ensure that everyone who could use this service account already has access\n-    to the BigQuery tables. To see who could use this service account, navigate\n-    to `IAM & Admin` and look for `Owner`, `Editor`, and `Service Account User`\n-    roles.\n+  dataset  \n+  [Following the principle of least privilege](https://cloud.google.com/kubernetes-engine/docs/tutorials/authenticating-to-cloud-platform#why_use_service_accounts),\n+  we recommend using a service account with only the necessary permissions,\n+  rather than the default Compute Engine service account.\n+    * Create a project for deploying Data Explorer. We recommend creating a\n+      project because all project Editors/Owners will indirectly have\n+      access to the BigQuery tables. (Project Editors/Owners by default have\n+      permission to act as service accounts, and the indexer service account will be\n+      given permission to read the BigQuery tables.)\n+      * Ensure that anyone who is\n+      granted Editor/Owner roles in this project, already has access to the BigQuery tables.\n     * Create the service account\n       * Navigate to `IAM & Admin > Service Accounts > Create Service Account`.\n       * We suggest the name `DATASET-data-explorer-indexer` to make it clear","path":"bigquery/deploy/README.md","position":28,"original_position":28,"commit_id":"6c752daef5a60a5108a8f2276a44104ec6764334","original_commit_id":"6c752daef5a60a5108a8f2276a44104ec6764334","user":{"login":"melissachang","id":10929390,"node_id":"MDQ6VXNlcjEwOTI5Mzkw","avatar_url":"https://avatars1.githubusercontent.com/u/10929390?v=4","gravatar_id":"","url":"https://api.github.com/users/melissachang","html_url":"https://github.com/melissachang","followers_url":"https://api.github.com/users/melissachang/followers","following_url":"https://api.github.com/users/melissachang/following{/other_user}","gists_url":"https://api.github.com/users/melissachang/gists{/gist_id}","starred_url":"https://api.github.com/users/melissachang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissachang/subscriptions","organizations_url":"https://api.github.com/users/melissachang/orgs","repos_url":"https://api.github.com/users/melissachang/repos","events_url":"https://api.github.com/users/melissachang/events{/privacy}","received_events_url":"https://api.github.com/users/melissachang/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-06-15T19:19:35Z","updated_at":"2018-06-15T19:19:42Z","html_url":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23#discussion_r195839067","pull_request_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/comments/195839067"},"html":{"href":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23#discussion_r195839067"},"pull_request":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23"}},"in_reply_to_id":195836822},"pull_request":{"url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23","id":195051366,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDUxMzY2","html_url":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23","diff_url":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23.diff","patch_url":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23.patch","issue_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/23","number":23,"state":"open","locked":false,"title":"In deploy instructions, recommend creating a new project","user":{"login":"melissachang","id":10929390,"node_id":"MDQ6VXNlcjEwOTI5Mzkw","avatar_url":"https://avatars1.githubusercontent.com/u/10929390?v=4","gravatar_id":"","url":"https://api.github.com/users/melissachang","html_url":"https://github.com/melissachang","followers_url":"https://api.github.com/users/melissachang/followers","following_url":"https://api.github.com/users/melissachang/following{/other_user}","gists_url":"https://api.github.com/users/melissachang/gists{/gist_id}","starred_url":"https://api.github.com/users/melissachang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissachang/subscriptions","organizations_url":"https://api.github.com/users/melissachang/orgs","repos_url":"https://api.github.com/users/melissachang/repos","events_url":"https://api.github.com/users/melissachang/events{/privacy}","received_events_url":"https://api.github.com/users/melissachang/received_events","type":"User","site_admin":false},"body":"This is safer because there will be fewer Editor/Owners, and it will be easier to verify that all Editor/Owners already have access to BigQuery tables.","created_at":"2018-06-15T00:29:48Z","updated_at":"2018-06-15T19:19:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95d4c1bf053f872a70006a85b607f8e1439d6a09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23/commits","review_comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23/comments","review_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/23/comments","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/statuses/6c752daef5a60a5108a8f2276a44104ec6764334","head":{"label":"DataBiosphere:mc/new-project","ref":"mc/new-project","sha":"6c752daef5a60a5108a8f2276a44104ec6764334","user":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":123707251,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM3MDcyNTE=","name":"data-explorer-indexers","full_name":"DataBiosphere/data-explorer-indexers","owner":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/data-explorer-indexers","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers","forks_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/forks","keys_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/events","assignees_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/merges","archive_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/deployments","created_at":"2018-03-03T16:00:03Z","updated_at":"2018-06-14T23:13:53Z","pushed_at":"2018-06-15T00:29:49Z","git_url":"git://github.com/DataBiosphere/data-explorer-indexers.git","ssh_url":"git@github.com:DataBiosphere/data-explorer-indexers.git","clone_url":"https://github.com/DataBiosphere/data-explorer-indexers.git","svn_url":"https://github.com/DataBiosphere/data-explorer-indexers","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"DataBiosphere:master","ref":"master","sha":"be5398f1c5346015970f8c52c1a5eb65f2d93f1a","user":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":123707251,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM3MDcyNTE=","name":"data-explorer-indexers","full_name":"DataBiosphere/data-explorer-indexers","owner":{"login":"DataBiosphere","id":32805087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODA1MDg3","avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/data-explorer-indexers","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers","forks_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/forks","keys_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/events","assignees_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/merges","archive_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/deployments","created_at":"2018-03-03T16:00:03Z","updated_at":"2018-06-14T23:13:53Z","pushed_at":"2018-06-15T00:29:49Z","git_url":"git://github.com/DataBiosphere/data-explorer-indexers.git","ssh_url":"git@github.com:DataBiosphere/data-explorer-indexers.git","clone_url":"https://github.com/DataBiosphere/data-explorer-indexers.git","svn_url":"https://github.com/DataBiosphere/data-explorer-indexers","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23"},"html":{"href":"https://github.com/DataBiosphere/data-explorer-indexers/pull/23"},"issue":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/23"},"comments":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer-indexers/statuses/6c752daef5a60a5108a8f2276a44104ec6764334"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"melissachang"}}