{"action":"created","issue":{"url":"https://api.github.com/repos/woocommerce/storefront/issues/809","repository_url":"https://api.github.com/repos/woocommerce/storefront","labels_url":"https://api.github.com/repos/woocommerce/storefront/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/woocommerce/storefront/issues/809/comments","events_url":"https://api.github.com/repos/woocommerce/storefront/issues/809/events","html_url":"https://github.com/woocommerce/storefront/issues/809","id":312354749,"number":809,"title":"Images with ratio other than 1:1 are incorrectly cropped","user":{"login":"alaczek","id":4550351,"avatar_url":"https://avatars0.githubusercontent.com/u/4550351?v=4","gravatar_id":"","url":"https://api.github.com/users/alaczek","html_url":"https://github.com/alaczek","followers_url":"https://api.github.com/users/alaczek/followers","following_url":"https://api.github.com/users/alaczek/following{/other_user}","gists_url":"https://api.github.com/users/alaczek/gists{/gist_id}","starred_url":"https://api.github.com/users/alaczek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alaczek/subscriptions","organizations_url":"https://api.github.com/users/alaczek/orgs","repos_url":"https://api.github.com/users/alaczek/repos","events_url":"https://api.github.com/users/alaczek/events{/privacy}","received_events_url":"https://api.github.com/users/alaczek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-09T00:01:53Z","updated_at":"2018-04-16T10:35:17Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Steps to replicate\r\n\r\n@joelwills attempted to reproduce this in a test site and wasn't able to do so (see discussion ref below). Re-uploading the image seemed to help, although this issue seems to manifest in Firefox, not Chrome.\r\n\r\n<img width=\"349\" alt=\"necklace_crop1\" src=\"https://user-images.githubusercontent.com/2912202/38463739-b68936f6-3b09-11e8-9b51-3dbfbee9cf6a.png\">\r\n\r\n## Result\r\n\r\nFrom the user:\r\n\r\n>_To recap_, the display of product images greater than a 1:1 ratio, with Storefront theme, utillizing woocomerce, is subject to improper framing. So the images can appear \"cut off\" or cropped. But when the framing problem automatically catches up with itself, corrects itself, the image becomes per expected, \"normal\". This appears to be a Firefox related problem as the wordpress technician using Chrome didn't have the problem.\r\n\r\n>A related problem_ is that Firefox is showing some images as side-ways. So rotated 45 degrees. For example, go to our website homepage, display dewolf necklaces, scroll down to the coral masquerade necklace, and it appears side-ways (in Firefox, but not in Chrome). That product image appears side-ways in the media library also (using Firefox), but fine in Chrome.\r\n\r\n## Expected\r\n\r\nUploaded images should be displayed consistently and, where cropped, cropped similarly for Firefox and Chrome.\r\n\r\n<img width=\"310\" alt=\"necklace_crop\" src=\"https://user-images.githubusercontent.com/2912202/38463741-bfbdf126-3b09-11e8-909f-ddd193cbf502.png\">\r\n\r\n* User report: 2283124-hc (see also p1522340092000459-slack-C2C8F5PNJ)\r\n* Follow-up ticket: 1051005-zen\r\n* User's site: dewolfdesignden.com generally, see Pretty in Peach page.\r\n\r\n----\r\nIssue originally reported in https://github.com/Automattic/themes/issues/86"},"comment":{"url":"https://api.github.com/repos/woocommerce/storefront/issues/comments/381555743","html_url":"https://github.com/woocommerce/storefront/issues/809#issuecomment-381555743","issue_url":"https://api.github.com/repos/woocommerce/storefront/issues/809","id":381555743,"user":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars2.githubusercontent.com/u/90977?v=4","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T10:35:16Z","updated_at":"2018-04-16T10:35:16Z","author_association":"OWNER","body":"@tiagonoronha Not sure how to - I don't have the issue. WC doesn't control cropping mode or rotation. Nothing afaik rotates images...\r\n\r\nThe featured image displayed above fwiw is controlled by WP not WooCommerce. Our cropping code doesn't affect WP image sizes.\r\n\r\n> So the images can appear \"cut off\" or cropped. But when the framing problem automatically catches up with itself, corrects itself, the image becomes per expected, \"normal\". \r\n\r\nImages could be cut off before thumbs are regenerated on the frontend if the image sizes were modified. Thats expected and part of image regen process."}}
{"actor":{"display_login":"mikejolley"}}