{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/10257","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/10257/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/10257/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/10257/events","html_url":"https://github.com/PX4/Firmware/pull/10257","id":351698192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjI2Mzky","number":10257,"title":"[WIP] tune refactor","user":{"login":"davids5","id":1945821,"node_id":"MDQ6VXNlcjE5NDU4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1945821?v=4","gravatar_id":"","url":"https://api.github.com/users/davids5","html_url":"https://github.com/davids5","followers_url":"https://api.github.com/users/davids5/followers","following_url":"https://api.github.com/users/davids5/following{/other_user}","gists_url":"https://api.github.com/users/davids5/gists{/gist_id}","starred_url":"https://api.github.com/users/davids5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davids5/subscriptions","organizations_url":"https://api.github.com/users/davids5/orgs","repos_url":"https://api.github.com/users/davids5/repos","events_url":"https://api.github.com/users/davids5/events{/privacy}","received_events_url":"https://api.github.com/users/davids5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bkueng","id":281593,"node_id":"MDQ6VXNlcjI4MTU5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/281593?v=4","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false},"assignees":[{"login":"bkueng","id":281593,"node_id":"MDQ6VXNlcjI4MTU5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/281593?v=4","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-08-17T18:37:10Z","updated_at":"2018-08-20T21:32:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/10257","html_url":"https://github.com/PX4/Firmware/pull/10257","diff_url":"https://github.com/PX4/Firmware/pull/10257.diff","patch_url":"https://github.com/PX4/Firmware/pull/10257.patch"},"body":"WIP needs cross testing on v4 v2 NXPhlite, sitil\r\n\r\nRemoved all the legacy CLI for tone_alarms\r\n Removed stale doc from tone_alarms\r\nRefactored all tone_alarms to use tone_control\r\n'Small kine' cleanup in tone_alarms\r\n\r\n Refactored tune_control and friends:\r\n1 ) Adds a single file definition to provide a single point to add new tunes which clearly documants, the usage and if a tune need to be stopped will it allow interruption.\r\n\r\n2) Fixed orb overwrite on \"play tune n, stop, play tune k\" where n would continue to play.\r\n\r\nRefactored all the rc to use tune_control.\r\n The requires uOrb and tone_alarem to be started before the rcS uses `tune_control` commands.\r\n\r\nAdded support for PX4V5 Mini ( required to be bin compatible with FMUv5) where the build has the px4io firmware file but not a px4io hw. \r\n\r\nTODO: Should param SYS_USE_IO be reset on Mini?"},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/414470357","html_url":"https://github.com/PX4/Firmware/pull/10257#issuecomment-414470357","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/10257","id":414470357,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ3MDM1Nw==","user":{"login":"davids5","id":1945821,"node_id":"MDQ6VXNlcjE5NDU4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1945821?v=4","gravatar_id":"","url":"https://api.github.com/users/davids5","html_url":"https://github.com/davids5","followers_url":"https://api.github.com/users/davids5/followers","following_url":"https://api.github.com/users/davids5/following{/other_user}","gists_url":"https://api.github.com/users/davids5/gists{/gist_id}","starred_url":"https://api.github.com/users/davids5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davids5/subscriptions","organizations_url":"https://api.github.com/users/davids5/orgs","repos_url":"https://api.github.com/users/davids5/repos","events_url":"https://api.github.com/users/davids5/events{/privacy}","received_events_url":"https://api.github.com/users/davids5/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T21:32:11Z","updated_at":"2018-08-20T21:32:11Z","author_association":"MEMBER","body":"@dagar - The start up tone on V4 is cut short by the Junk publication made in commander with an all 0 message on it's advertise call. It would be a hack to detect and skip it in the driver using. So as discussed the orb fix is needed. This can come in as an improvement now, and then all the tune related advertises can be changed to the the new non-publishing version."}}
{"actor":{"display_login":"davids5"}}