{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/cw75/tiered-storage/pulls/3","id":84607649,"node_id":"MDExOlB1bGxSZXF1ZXN0ODQ2MDc2NDk=","html_url":"https://github.com/cw75/tiered-storage/pull/3","diff_url":"https://github.com/cw75/tiered-storage/pull/3.diff","patch_url":"https://github.com/cw75/tiered-storage/pull/3.patch","issue_url":"https://api.github.com/repos/cw75/tiered-storage/issues/3","number":3,"state":"closed","locked":false,"title":"Refactored CMake build.","user":{"login":"mwhittaker","id":3654277,"node_id":"MDQ6VXNlcjM2NTQyNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3654277?v=4","gravatar_id":"","url":"https://api.github.com/users/mwhittaker","html_url":"https://github.com/mwhittaker","followers_url":"https://api.github.com/users/mwhittaker/followers","following_url":"https://api.github.com/users/mwhittaker/following{/other_user}","gists_url":"https://api.github.com/users/mwhittaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhittaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhittaker/subscriptions","organizations_url":"https://api.github.com/users/mwhittaker/orgs","repos_url":"https://api.github.com/users/mwhittaker/repos","events_url":"https://api.github.com/users/mwhittaker/events{/privacy}","received_events_url":"https://api.github.com/users/mwhittaker/received_events","type":"User","site_admin":false},"body":"After a fresh clone of this repository, the code would not build. I buckled up and went down the rabbit hole that is learning CMake. After a lot (like, a ton) of Googling, I finally figured out enough to fix things and also clean up a few things too. Notably,\n- Before, compiled protos were included in the repo. This meant that\n  anyone building the project needed to have the same exact `protoc`\n  version or rebuild all the protos manually. Two unattractive options.\n  I modified things so that CMake now builds protos for us.\n- I fixed includes to follow [Google's style guide](https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes). Doing so\n  required a good amount of CMake wrangling.\n- I fixed up miscellaneous things here and there. For example, library\n  dependencies weren't being set properly and warnings like \"-lprotobuf\n  flag ignored\" were being emitted.\n\nIn the process of learning CMake, I also made a [minimal useful CMake project](https://github.com/mwhittaker/cmake_example) that others may find useful. \n","created_at":"2016-09-09T07:48:50Z","updated_at":"2018-07-06T16:50:54Z","closed_at":"2018-07-06T16:50:54Z","merged_at":null,"merge_commit_sha":"6a52da230ee05a0cb3420bb2ddd809e4b8416b2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/3/commits","review_comments_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/3/comments","review_comment_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cw75/tiered-storage/issues/3/comments","statuses_url":"https://api.github.com/repos/cw75/tiered-storage/statuses/eb3afa9a38a486901e34df8dfd880d481bd24e85","head":{"label":"mwhittaker:build_cleanup","ref":"build_cleanup","sha":"eb3afa9a38a486901e34df8dfd880d481bd24e85","user":{"login":"mwhittaker","id":3654277,"node_id":"MDQ6VXNlcjM2NTQyNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3654277?v=4","gravatar_id":"","url":"https://api.github.com/users/mwhittaker","html_url":"https://github.com/mwhittaker","followers_url":"https://api.github.com/users/mwhittaker/followers","following_url":"https://api.github.com/users/mwhittaker/following{/other_user}","gists_url":"https://api.github.com/users/mwhittaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhittaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhittaker/subscriptions","organizations_url":"https://api.github.com/users/mwhittaker/orgs","repos_url":"https://api.github.com/users/mwhittaker/repos","events_url":"https://api.github.com/users/mwhittaker/events{/privacy}","received_events_url":"https://api.github.com/users/mwhittaker/received_events","type":"User","site_admin":false},"repo":{"id":67650509,"node_id":"MDEwOlJlcG9zaXRvcnk2NzY1MDUwOQ==","name":"high-performance-lattices","full_name":"mwhittaker/high-performance-lattices","owner":{"login":"mwhittaker","id":3654277,"node_id":"MDQ6VXNlcjM2NTQyNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3654277?v=4","gravatar_id":"","url":"https://api.github.com/users/mwhittaker","html_url":"https://github.com/mwhittaker","followers_url":"https://api.github.com/users/mwhittaker/followers","following_url":"https://api.github.com/users/mwhittaker/following{/other_user}","gists_url":"https://api.github.com/users/mwhittaker/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhittaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhittaker/subscriptions","organizations_url":"https://api.github.com/users/mwhittaker/orgs","repos_url":"https://api.github.com/users/mwhittaker/repos","events_url":"https://api.github.com/users/mwhittaker/events{/privacy}","received_events_url":"https://api.github.com/users/mwhittaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwhittaker/high-performance-lattices","description":"High Performance Lattice Library in C++","fork":true,"url":"https://api.github.com/repos/mwhittaker/high-performance-lattices","forks_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/forks","keys_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/teams","hooks_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/hooks","issue_events_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/issues/events{/number}","events_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/events","assignees_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/assignees{/user}","branches_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/branches{/branch}","tags_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/tags","blobs_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/statuses/{sha}","languages_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/languages","stargazers_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/stargazers","contributors_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/contributors","subscribers_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/subscribers","subscription_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/subscription","commits_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/contents/{+path}","compare_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/merges","archive_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/downloads","issues_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/issues{/number}","pulls_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/pulls{/number}","milestones_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/milestones{/number}","notifications_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/labels{/name}","releases_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/releases{/id}","deployments_url":"https://api.github.com/repos/mwhittaker/high-performance-lattices/deployments","created_at":"2016-09-07T23:16:24Z","updated_at":"2016-09-07T23:16:25Z","pushed_at":"2016-09-27T06:46:19Z","git_url":"git://github.com/mwhittaker/high-performance-lattices.git","ssh_url":"git@github.com:mwhittaker/high-performance-lattices.git","clone_url":"https://github.com/mwhittaker/high-performance-lattices.git","svn_url":"https://github.com/mwhittaker/high-performance-lattices","homepage":"","size":3713,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cw75:master","ref":"master","sha":"ff2379e47edb178d7242d4dd097326fedb5224a8","user":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"repo":{"id":59505746,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUwNTc0Ng==","name":"tiered-storage","full_name":"cw75/tiered-storage","owner":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cw75/tiered-storage","description":"An Elastic, Tiered-Storage Service","fork":false,"url":"https://api.github.com/repos/cw75/tiered-storage","forks_url":"https://api.github.com/repos/cw75/tiered-storage/forks","keys_url":"https://api.github.com/repos/cw75/tiered-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cw75/tiered-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cw75/tiered-storage/teams","hooks_url":"https://api.github.com/repos/cw75/tiered-storage/hooks","issue_events_url":"https://api.github.com/repos/cw75/tiered-storage/issues/events{/number}","events_url":"https://api.github.com/repos/cw75/tiered-storage/events","assignees_url":"https://api.github.com/repos/cw75/tiered-storage/assignees{/user}","branches_url":"https://api.github.com/repos/cw75/tiered-storage/branches{/branch}","tags_url":"https://api.github.com/repos/cw75/tiered-storage/tags","blobs_url":"https://api.github.com/repos/cw75/tiered-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cw75/tiered-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cw75/tiered-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/cw75/tiered-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cw75/tiered-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/cw75/tiered-storage/languages","stargazers_url":"https://api.github.com/repos/cw75/tiered-storage/stargazers","contributors_url":"https://api.github.com/repos/cw75/tiered-storage/contributors","subscribers_url":"https://api.github.com/repos/cw75/tiered-storage/subscribers","subscription_url":"https://api.github.com/repos/cw75/tiered-storage/subscription","commits_url":"https://api.github.com/repos/cw75/tiered-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/cw75/tiered-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/cw75/tiered-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/cw75/tiered-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/cw75/tiered-storage/contents/{+path}","compare_url":"https://api.github.com/repos/cw75/tiered-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cw75/tiered-storage/merges","archive_url":"https://api.github.com/repos/cw75/tiered-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cw75/tiered-storage/downloads","issues_url":"https://api.github.com/repos/cw75/tiered-storage/issues{/number}","pulls_url":"https://api.github.com/repos/cw75/tiered-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/cw75/tiered-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/cw75/tiered-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cw75/tiered-storage/labels{/name}","releases_url":"https://api.github.com/repos/cw75/tiered-storage/releases{/id}","deployments_url":"https://api.github.com/repos/cw75/tiered-storage/deployments","created_at":"2016-05-23T17:50:34Z","updated_at":"2018-07-06T16:50:34Z","pushed_at":"2018-07-06T16:50:32Z","git_url":"git://github.com/cw75/tiered-storage.git","ssh_url":"git@github.com:cw75/tiered-storage.git","clone_url":"https://github.com/cw75/tiered-storage.git","svn_url":"https://github.com/cw75/tiered-storage","homepage":"","size":4533,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":8,"open_issues":22,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/3"},"html":{"href":"https://github.com/cw75/tiered-storage/pull/3"},"issue":{"href":"https://api.github.com/repos/cw75/tiered-storage/issues/3"},"comments":{"href":"https://api.github.com/repos/cw75/tiered-storage/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/cw75/tiered-storage/statuses/eb3afa9a38a486901e34df8dfd880d481bd24e85"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":550,"deletions":9524,"changed_files":31}}
{"actor":{"display_login":"vsreekanti"}}