{"action":"created","comment":{"url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/comments/200387325","pull_request_review_id":134693243,"id":200387325,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDM4NzMyNQ==","diff_hunk":"@@ -0,0 +1,5 @@\n+{\"id\":1,\"name\":\"Piotreksssss\", \"balance\":\"9999\"}","path":"backend/src/test/resources/account.txt","position":1,"original_position":1,"commit_id":"4143b3b0b6070c6ba73794aa7fa18d85bbaf51d2","original_commit_id":"4143b3b0b6070c6ba73794aa7fa18d85bbaf51d2","user":{"login":"pio-kol","id":16766227,"node_id":"MDQ6VXNlcjE2NzY2MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/16766227?v=4","gravatar_id":"","url":"https://api.github.com/users/pio-kol","html_url":"https://github.com/pio-kol","followers_url":"https://api.github.com/users/pio-kol/followers","following_url":"https://api.github.com/users/pio-kol/following{/other_user}","gists_url":"https://api.github.com/users/pio-kol/gists{/gist_id}","starred_url":"https://api.github.com/users/pio-kol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pio-kol/subscriptions","organizations_url":"https://api.github.com/users/pio-kol/orgs","repos_url":"https://api.github.com/users/pio-kol/repos","events_url":"https://api.github.com/users/pio-kol/events{/privacy}","received_events_url":"https://api.github.com/users/pio-kol/received_events","type":"User","site_admin":false},"body":"It's never good idea to keep json / data in file - unless test is about reading from file. It's much safer to keep data in objects.","created_at":"2018-07-05T15:05:49Z","updated_at":"2018-07-05T15:05:54Z","html_url":"https://github.com/programming-in-practice/personal-finance-manager/pull/24#discussion_r200387325","pull_request_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/comments/200387325"},"html":{"href":"https://github.com/programming-in-practice/personal-finance-manager/pull/24#discussion_r200387325"},"pull_request":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24","id":198373841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzczODQx","html_url":"https://github.com/programming-in-practice/personal-finance-manager/pull/24","diff_url":"https://github.com/programming-in-practice/personal-finance-manager/pull/24.diff","patch_url":"https://github.com/programming-in-practice/personal-finance-manager/pull/24.patch","issue_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/24","number":24,"state":"open","locked":false,"title":"Account controller test","user":{"login":"piotrhawlicki","id":32275237,"node_id":"MDQ6VXNlcjMyMjc1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32275237?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrhawlicki","html_url":"https://github.com/piotrhawlicki","followers_url":"https://api.github.com/users/piotrhawlicki/followers","following_url":"https://api.github.com/users/piotrhawlicki/following{/other_user}","gists_url":"https://api.github.com/users/piotrhawlicki/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrhawlicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrhawlicki/subscriptions","organizations_url":"https://api.github.com/users/piotrhawlicki/orgs","repos_url":"https://api.github.com/users/piotrhawlicki/repos","events_url":"https://api.github.com/users/piotrhawlicki/events{/privacy}","received_events_url":"https://api.github.com/users/piotrhawlicki/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-29T17:05:27Z","updated_at":"2018-07-05T15:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24a90b23299cccbdd5d6b8307953459ec6e543c0","assignee":{"login":"piotrhawlicki","id":32275237,"node_id":"MDQ6VXNlcjMyMjc1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32275237?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrhawlicki","html_url":"https://github.com/piotrhawlicki","followers_url":"https://api.github.com/users/piotrhawlicki/followers","following_url":"https://api.github.com/users/piotrhawlicki/following{/other_user}","gists_url":"https://api.github.com/users/piotrhawlicki/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrhawlicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrhawlicki/subscriptions","organizations_url":"https://api.github.com/users/piotrhawlicki/orgs","repos_url":"https://api.github.com/users/piotrhawlicki/repos","events_url":"https://api.github.com/users/piotrhawlicki/events{/privacy}","received_events_url":"https://api.github.com/users/piotrhawlicki/received_events","type":"User","site_admin":false},"assignees":[{"login":"piotrhawlicki","id":32275237,"node_id":"MDQ6VXNlcjMyMjc1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32275237?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrhawlicki","html_url":"https://github.com/piotrhawlicki","followers_url":"https://api.github.com/users/piotrhawlicki/followers","following_url":"https://api.github.com/users/piotrhawlicki/following{/other_user}","gists_url":"https://api.github.com/users/piotrhawlicki/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrhawlicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrhawlicki/subscriptions","organizations_url":"https://api.github.com/users/piotrhawlicki/orgs","repos_url":"https://api.github.com/users/piotrhawlicki/repos","events_url":"https://api.github.com/users/piotrhawlicki/events{/privacy}","received_events_url":"https://api.github.com/users/piotrhawlicki/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jmykhailovych","id":27205164,"node_id":"MDQ6VXNlcjI3MjA1MTY0","avatar_url":"https://avatars0.githubusercontent.com/u/27205164?v=4","gravatar_id":"","url":"https://api.github.com/users/jmykhailovych","html_url":"https://github.com/jmykhailovych","followers_url":"https://api.github.com/users/jmykhailovych/followers","following_url":"https://api.github.com/users/jmykhailovych/following{/other_user}","gists_url":"https://api.github.com/users/jmykhailovych/gists{/gist_id}","starred_url":"https://api.github.com/users/jmykhailovych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmykhailovych/subscriptions","organizations_url":"https://api.github.com/users/jmykhailovych/orgs","repos_url":"https://api.github.com/users/jmykhailovych/repos","events_url":"https://api.github.com/users/jmykhailovych/events{/privacy}","received_events_url":"https://api.github.com/users/jmykhailovych/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24/commits","review_comments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24/comments","review_comment_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/24/comments","statuses_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/statuses/4143b3b0b6070c6ba73794aa7fa18d85bbaf51d2","head":{"label":"programming-in-practice:AccountControllerTest","ref":"AccountControllerTest","sha":"4143b3b0b6070c6ba73794aa7fa18d85bbaf51d2","user":{"login":"programming-in-practice","id":39679547,"node_id":"MDQ6VXNlcjM5Njc5NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/39679547?v=4","gravatar_id":"","url":"https://api.github.com/users/programming-in-practice","html_url":"https://github.com/programming-in-practice","followers_url":"https://api.github.com/users/programming-in-practice/followers","following_url":"https://api.github.com/users/programming-in-practice/following{/other_user}","gists_url":"https://api.github.com/users/programming-in-practice/gists{/gist_id}","starred_url":"https://api.github.com/users/programming-in-practice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programming-in-practice/subscriptions","organizations_url":"https://api.github.com/users/programming-in-practice/orgs","repos_url":"https://api.github.com/users/programming-in-practice/repos","events_url":"https://api.github.com/users/programming-in-practice/events{/privacy}","received_events_url":"https://api.github.com/users/programming-in-practice/received_events","type":"User","site_admin":false},"repo":{"id":135078200,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwNzgyMDA=","name":"personal-finance-manager","full_name":"programming-in-practice/personal-finance-manager","owner":{"login":"programming-in-practice","id":39679547,"node_id":"MDQ6VXNlcjM5Njc5NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/39679547?v=4","gravatar_id":"","url":"https://api.github.com/users/programming-in-practice","html_url":"https://github.com/programming-in-practice","followers_url":"https://api.github.com/users/programming-in-practice/followers","following_url":"https://api.github.com/users/programming-in-practice/following{/other_user}","gists_url":"https://api.github.com/users/programming-in-practice/gists{/gist_id}","starred_url":"https://api.github.com/users/programming-in-practice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programming-in-practice/subscriptions","organizations_url":"https://api.github.com/users/programming-in-practice/orgs","repos_url":"https://api.github.com/users/programming-in-practice/repos","events_url":"https://api.github.com/users/programming-in-practice/events{/privacy}","received_events_url":"https://api.github.com/users/programming-in-practice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/programming-in-practice/personal-finance-manager","description":null,"fork":false,"url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager","forks_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/forks","keys_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/teams","hooks_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/hooks","issue_events_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/events{/number}","events_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/events","assignees_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/assignees{/user}","branches_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/branches{/branch}","tags_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/tags","blobs_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/languages","stargazers_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/stargazers","contributors_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/contributors","subscribers_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/subscribers","subscription_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/subscription","commits_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/contents/{+path}","compare_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/merges","archive_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/downloads","issues_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues{/number}","pulls_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/labels{/name}","releases_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/releases{/id}","deployments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/deployments","created_at":"2018-05-27T20:12:39Z","updated_at":"2018-07-05T13:44:28Z","pushed_at":"2018-07-05T14:55:40Z","git_url":"git://github.com/programming-in-practice/personal-finance-manager.git","ssh_url":"git@github.com:programming-in-practice/personal-finance-manager.git","clone_url":"https://github.com/programming-in-practice/personal-finance-manager.git","svn_url":"https://github.com/programming-in-practice/personal-finance-manager","homepage":null,"size":258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"programming-in-practice:master","ref":"master","sha":"5f00045f3fc0aa22252947b78fd59bb0a1e9a20d","user":{"login":"programming-in-practice","id":39679547,"node_id":"MDQ6VXNlcjM5Njc5NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/39679547?v=4","gravatar_id":"","url":"https://api.github.com/users/programming-in-practice","html_url":"https://github.com/programming-in-practice","followers_url":"https://api.github.com/users/programming-in-practice/followers","following_url":"https://api.github.com/users/programming-in-practice/following{/other_user}","gists_url":"https://api.github.com/users/programming-in-practice/gists{/gist_id}","starred_url":"https://api.github.com/users/programming-in-practice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programming-in-practice/subscriptions","organizations_url":"https://api.github.com/users/programming-in-practice/orgs","repos_url":"https://api.github.com/users/programming-in-practice/repos","events_url":"https://api.github.com/users/programming-in-practice/events{/privacy}","received_events_url":"https://api.github.com/users/programming-in-practice/received_events","type":"User","site_admin":false},"repo":{"id":135078200,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwNzgyMDA=","name":"personal-finance-manager","full_name":"programming-in-practice/personal-finance-manager","owner":{"login":"programming-in-practice","id":39679547,"node_id":"MDQ6VXNlcjM5Njc5NTQ3","avatar_url":"https://avatars1.githubusercontent.com/u/39679547?v=4","gravatar_id":"","url":"https://api.github.com/users/programming-in-practice","html_url":"https://github.com/programming-in-practice","followers_url":"https://api.github.com/users/programming-in-practice/followers","following_url":"https://api.github.com/users/programming-in-practice/following{/other_user}","gists_url":"https://api.github.com/users/programming-in-practice/gists{/gist_id}","starred_url":"https://api.github.com/users/programming-in-practice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/programming-in-practice/subscriptions","organizations_url":"https://api.github.com/users/programming-in-practice/orgs","repos_url":"https://api.github.com/users/programming-in-practice/repos","events_url":"https://api.github.com/users/programming-in-practice/events{/privacy}","received_events_url":"https://api.github.com/users/programming-in-practice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/programming-in-practice/personal-finance-manager","description":null,"fork":false,"url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager","forks_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/forks","keys_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/teams","hooks_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/hooks","issue_events_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/events{/number}","events_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/events","assignees_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/assignees{/user}","branches_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/branches{/branch}","tags_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/tags","blobs_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/languages","stargazers_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/stargazers","contributors_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/contributors","subscribers_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/subscribers","subscription_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/subscription","commits_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/contents/{+path}","compare_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/merges","archive_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/downloads","issues_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues{/number}","pulls_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/labels{/name}","releases_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/releases{/id}","deployments_url":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/deployments","created_at":"2018-05-27T20:12:39Z","updated_at":"2018-07-05T13:44:28Z","pushed_at":"2018-07-05T14:55:40Z","git_url":"git://github.com/programming-in-practice/personal-finance-manager.git","ssh_url":"git@github.com:programming-in-practice/personal-finance-manager.git","clone_url":"https://github.com/programming-in-practice/personal-finance-manager.git","svn_url":"https://github.com/programming-in-practice/personal-finance-manager","homepage":null,"size":258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24"},"html":{"href":"https://github.com/programming-in-practice/personal-finance-manager/pull/24"},"issue":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/24"},"comments":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/programming-in-practice/personal-finance-manager/statuses/4143b3b0b6070c6ba73794aa7fa18d85bbaf51d2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pio-kol"}}