{"action":"created","issue":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/34481","repository_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp","labels_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/34481/labels{/name}","comments_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/34481/comments","events_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/34481/events","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/34481","id":385769634,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjYzODA2","number":34481,"title":"Feat: /welcome Supporters","user":{"login":"Bouncey","id":18572518,"node_id":"MDQ6VXNlcjE4NTcyNTE4","avatar_url":"https://avatars1.githubusercontent.com/u/18572518?v=4","gravatar_id":"","url":"https://api.github.com/users/Bouncey","html_url":"https://github.com/Bouncey","followers_url":"https://api.github.com/users/Bouncey/followers","following_url":"https://api.github.com/users/Bouncey/following{/other_user}","gists_url":"https://api.github.com/users/Bouncey/gists{/gist_id}","starred_url":"https://api.github.com/users/Bouncey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bouncey/subscriptions","organizations_url":"https://api.github.com/users/Bouncey/orgs","repos_url":"https://api.github.com/users/Bouncey/repos","events_url":"https://api.github.com/users/Bouncey/events{/privacy}","received_events_url":"https://api.github.com/users/Bouncey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-29T14:45:02Z","updated_at":"2018-12-01T11:20:13Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/pulls/34481","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/34481","diff_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/34481.diff","patch_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/34481.patch"},"body":"- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).\r\n- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)\r\n- [x] My pull request targets the `master` branch of freeCodeCamp.\r\n\r\nPoints to note:\r\n\r\n1. I moved the label outside of the progress bar because at lower percentages, the label truncates relative to the `active` progress width, rendering it incomplete. \r\n2. `activeDonations` only tracks active donations in our db (an active donation is defined currently as a donation record without an `endDate`). This count is inaccurate due to it only holding records from the revamped donation page and the donation model. The count does not include paypal donations. I plan to write a donation migration script to add/remove donations so they reflect the state of stripe and paypal. This will then allow us to correctly manage donations through a UI.\r\n3. The `Click here to become a Supporter` button links to `https://donate.freecodecamp.org`. A future PR can change this behaviour when we port over the new `/donate` page.\r\n\r\nNon-Donator View:\r\n![image](https://user-images.githubusercontent.com/18572518/49228619-aa97c900-f3e3-11e8-9461-f987175e7685.png)\r\n\r\nDonator View:\r\n![image](https://user-images.githubusercontent.com/18572518/49228687-ce5b0f00-f3e3-11e8-820f-af8c1efdd435.png)\r\n"},"comment":{"url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/comments/443419123","html_url":"https://github.com/freeCodeCamp/freeCodeCamp/pull/34481#issuecomment-443419123","issue_url":"https://api.github.com/repos/freeCodeCamp/freeCodeCamp/issues/34481","id":443419123,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQxOTEyMw==","user":{"login":"Bouncey","id":18572518,"node_id":"MDQ6VXNlcjE4NTcyNTE4","avatar_url":"https://avatars1.githubusercontent.com/u/18572518?v=4","gravatar_id":"","url":"https://api.github.com/users/Bouncey","html_url":"https://github.com/Bouncey","followers_url":"https://api.github.com/users/Bouncey/followers","following_url":"https://api.github.com/users/Bouncey/following{/other_user}","gists_url":"https://api.github.com/users/Bouncey/gists{/gist_id}","starred_url":"https://api.github.com/users/Bouncey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bouncey/subscriptions","organizations_url":"https://api.github.com/users/Bouncey/orgs","repos_url":"https://api.github.com/users/Bouncey/repos","events_url":"https://api.github.com/users/Bouncey/events{/privacy}","received_events_url":"https://api.github.com/users/Bouncey/received_events","type":"User","site_admin":false},"created_at":"2018-12-01T11:20:13Z","updated_at":"2018-12-01T11:20:13Z","author_association":"MEMBER","body":"I had planned to add some sort of caching mechanism, I just wanted some feedback on the overall look so far. \r\n\r\n> is it possible to put the text inside the progress bar like in my example? \r\n\r\nYes, but we would struggle with contrast ratios if using white or black text:\r\n![contrast comparisons](https://user-images.githubusercontent.com/18572518/49327547-fb7dfd80-f55a-11e8-8061-ae0cf292adfc.png)\r\n\r\n\r\n"}}
{"actor":{"display_login":"Bouncey"}}