{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/166824738","pull_request_review_id":94948341,"id":166824738,"diff_hunk":"@@ -199,6 +200,7 @@ pub struct Peer {\n     pending_reads: ReadIndexQueue,\n     // Record the last instant of each peer's heartbeat response.\n     pub peer_heartbeats: FlatMap<u64, Instant>,\n+    pub learner_heartbeats: FlatMap<u64, Instant>,","path":"src/raftstore/store/peer.rs","position":12,"original_position":12,"commit_id":"3ebc84ee7b761bce7a27c782847c030e627f774c","original_commit_id":"3ebc84ee7b761bce7a27c782847c030e627f774c","user":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars2.githubusercontent.com/u/1080370?v=4","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"body":"Seem we can use peer_heartbeats only.","created_at":"2018-02-08T03:32:05Z","updated_at":"2018-02-08T03:32:05Z","html_url":"https://github.com/pingcap/tikv/pull/2726#discussion_r166824738","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/2726","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/166824738"},"html":{"href":"https://github.com/pingcap/tikv/pull/2726#discussion_r166824738"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2726"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/2726","id":165924821,"html_url":"https://github.com/pingcap/tikv/pull/2726","diff_url":"https://github.com/pingcap/tikv/pull/2726.diff","patch_url":"https://github.com/pingcap/tikv/pull/2726.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/2726","number":2726,"state":"open","locked":false,"title":"support raft learner in raftstore. ","user":{"login":"hicqu","id":8407317,"avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false},"body":"This PR remove `unimplemented` panic for raft learn in raftstore by implement it.\r\nNow we can do:\r\n1. PeerStorage can know it's learner or not when it start up;\r\n2. Report learners and pending-learners to pd;\r\n3. Send AddLearner/PromoteLearner ConfChange to raftstore.","created_at":"2018-01-30T09:21:50Z","updated_at":"2018-02-08T03:32:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dac330a44bae2fb0bd6f59a6f76a0871a3aa79e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Hoverbear","id":130903,"avatar_url":"https://avatars3.githubusercontent.com/u/130903?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoverbear","html_url":"https://github.com/Hoverbear","followers_url":"https://api.github.com/users/Hoverbear/followers","following_url":"https://api.github.com/users/Hoverbear/following{/other_user}","gists_url":"https://api.github.com/users/Hoverbear/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoverbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoverbear/subscriptions","organizations_url":"https://api.github.com/users/Hoverbear/orgs","repos_url":"https://api.github.com/users/Hoverbear/repos","events_url":"https://api.github.com/users/Hoverbear/events{/privacy}","received_events_url":"https://api.github.com/users/Hoverbear/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/2726/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/2726/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/2726/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/3ebc84ee7b761bce7a27c782847c030e627f774c","head":{"label":"hicqu:raftstore-learner","ref":"raftstore-learner","sha":"3ebc84ee7b761bce7a27c782847c030e627f774c","user":{"login":"hicqu","id":8407317,"avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false},"repo":{"id":86659766,"name":"tikv","full_name":"hicqu/tikv","owner":{"login":"hicqu","id":8407317,"avatar_url":"https://avatars1.githubusercontent.com/u/8407317?v=4","gravatar_id":"","url":"https://api.github.com/users/hicqu","html_url":"https://github.com/hicqu","followers_url":"https://api.github.com/users/hicqu/followers","following_url":"https://api.github.com/users/hicqu/following{/other_user}","gists_url":"https://api.github.com/users/hicqu/gists{/gist_id}","starred_url":"https://api.github.com/users/hicqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hicqu/subscriptions","organizations_url":"https://api.github.com/users/hicqu/orgs","repos_url":"https://api.github.com/users/hicqu/repos","events_url":"https://api.github.com/users/hicqu/events{/privacy}","received_events_url":"https://api.github.com/users/hicqu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hicqu/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/hicqu/tikv","forks_url":"https://api.github.com/repos/hicqu/tikv/forks","keys_url":"https://api.github.com/repos/hicqu/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hicqu/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hicqu/tikv/teams","hooks_url":"https://api.github.com/repos/hicqu/tikv/hooks","issue_events_url":"https://api.github.com/repos/hicqu/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/hicqu/tikv/events","assignees_url":"https://api.github.com/repos/hicqu/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/hicqu/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/hicqu/tikv/tags","blobs_url":"https://api.github.com/repos/hicqu/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hicqu/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hicqu/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/hicqu/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hicqu/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/hicqu/tikv/languages","stargazers_url":"https://api.github.com/repos/hicqu/tikv/stargazers","contributors_url":"https://api.github.com/repos/hicqu/tikv/contributors","subscribers_url":"https://api.github.com/repos/hicqu/tikv/subscribers","subscription_url":"https://api.github.com/repos/hicqu/tikv/subscription","commits_url":"https://api.github.com/repos/hicqu/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/hicqu/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/hicqu/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/hicqu/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/hicqu/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/hicqu/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hicqu/tikv/merges","archive_url":"https://api.github.com/repos/hicqu/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hicqu/tikv/downloads","issues_url":"https://api.github.com/repos/hicqu/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/hicqu/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/hicqu/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/hicqu/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hicqu/tikv/labels{/name}","releases_url":"https://api.github.com/repos/hicqu/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/hicqu/tikv/deployments","created_at":"2017-03-30T04:43:28Z","updated_at":"2017-03-30T04:43:30Z","pushed_at":"2018-02-07T10:50:58Z","git_url":"git://github.com/hicqu/tikv.git","ssh_url":"git@github.com:hicqu/tikv.git","clone_url":"https://github.com/hicqu/tikv.git","svn_url":"https://github.com/hicqu/tikv","homepage":"","size":12833,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"18ab0e5db93763675525e029533d8ca37f5d3eab","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-02-08T02:18:12Z","pushed_at":"2018-02-08T02:33:50Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":11905,"stargazers_count":2698,"watchers_count":2698,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"archived":false,"open_issues_count":166,"license":null,"forks":330,"open_issues":166,"watchers":2698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2726"},"html":{"href":"https://github.com/pingcap/tikv/pull/2726"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2726"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2726/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2726/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2726/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/3ebc84ee7b761bce7a27c782847c030e627f774c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"siddontang"}}