{"action":"created","issue":{"url":"https://api.github.com/repos/michu2k/Accordion/issues/6","repository_url":"https://api.github.com/repos/michu2k/Accordion","labels_url":"https://api.github.com/repos/michu2k/Accordion/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/michu2k/Accordion/issues/6/comments","events_url":"https://api.github.com/repos/michu2k/Accordion/issues/6/events","html_url":"https://github.com/michu2k/Accordion/issues/6","id":390303187,"node_id":"MDU6SXNzdWUzOTAzMDMxODc=","number":6,"title":"Prevent accordion content from being tabbable when closed","user":{"login":"Flowgram","id":1196906,"node_id":"MDQ6VXNlcjExOTY5MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1196906?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowgram","html_url":"https://github.com/Flowgram","followers_url":"https://api.github.com/users/Flowgram/followers","following_url":"https://api.github.com/users/Flowgram/following{/other_user}","gists_url":"https://api.github.com/users/Flowgram/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowgram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowgram/subscriptions","organizations_url":"https://api.github.com/users/Flowgram/orgs","repos_url":"https://api.github.com/users/Flowgram/repos","events_url":"https://api.github.com/users/Flowgram/events{/privacy}","received_events_url":"https://api.github.com/users/Flowgram/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-12T16:23:44Z","updated_at":"2018-12-12T16:47:15Z","closed_at":null,"author_association":"NONE","body":"Nice little lightweight library you've got here.\r\n\r\nFor accessibility reasons, a site should be keyboard navigable. One thing I'm thinking about is how to prevent the contents of closed accordion panels from being accessible via the tab key. This includes links, buttons, youtube embeds etc.\r\n\r\nThen once the accordion panel is open, the user should be able to tab through everything as normal.\r\n\r\nOne solution would be to loop through all the children elements and set tabindex=\"-1\", special consideration would need to be made for iframe contents (youtube embeds). Opening the panel would need to reverse this.\r\n\r\nAnother cleaner solution might be to set the content of each accordion panel to display:none; until it's open. This would mess with the current system for gaging the height and thus the opening animation, however, there should be ways around this.\r\n\r\nI'd be curious to know your thoughts."},"comment":{"url":"https://api.github.com/repos/michu2k/Accordion/issues/comments/446657756","html_url":"https://github.com/michu2k/Accordion/issues/6#issuecomment-446657756","issue_url":"https://api.github.com/repos/michu2k/Accordion/issues/6","id":446657756,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjY1Nzc1Ng==","user":{"login":"Flowgram","id":1196906,"node_id":"MDQ6VXNlcjExOTY5MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1196906?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowgram","html_url":"https://github.com/Flowgram","followers_url":"https://api.github.com/users/Flowgram/followers","following_url":"https://api.github.com/users/Flowgram/following{/other_user}","gists_url":"https://api.github.com/users/Flowgram/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowgram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowgram/subscriptions","organizations_url":"https://api.github.com/users/Flowgram/orgs","repos_url":"https://api.github.com/users/Flowgram/repos","events_url":"https://api.github.com/users/Flowgram/events{/privacy}","received_events_url":"https://api.github.com/users/Flowgram/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T16:47:15Z","updated_at":"2018-12-12T16:47:15Z","author_association":"NONE","body":"How do there guys do it? https://a11y.nicolas-hoffmann.net/accordion/?animated=1"}}
{"actor":{"display_login":"Flowgram"}}