{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/234600825","pull_request_review_id":175789102,"id":234600825,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDYwMDgyNQ==","diff_hunk":"@@ -0,0 +1,150 @@\n+protocol CategorySettingsViewControllerDelegate: class {\n+  func handleCategorySettingsChange()\n+}\n+\n+class CategorySettingsViewController: MWMTableViewController {\n+  \n+  var categoryId: MWMMarkGroupID?\n+  var maxCategoryNameLength: UInt?\n+  var minCategoryNameLength: UInt?\n+  \n+  var manager: MWMBookmarksManager {\n+    return MWMBookmarksManager.shared()\n+  }\n+  \n+  weak var delegate: CategorySettingsViewControllerDelegate?\n+  \n+  @IBOutlet private weak var accessStatusLabel: UILabel!\n+  @IBOutlet private weak var nameTextField: UITextField!\n+  @IBOutlet private weak var descriptionTextView: UITextView!\n+  @IBOutlet private weak var descriptionCell: UITableViewCell!\n+  var saveButton: UIBarButtonItem = UIBarButtonItem(barButtonSystemItem: .save, target: self,\n+                                                    action: #selector(onSave))\n+  \n+  override func viewDidLoad() {\n+    super.viewDidLoad()\n+    \n+    title = L(\"settings\")\n+    \n+    assert(categoryId != nil || minCategoryNameLength != nil || maxCategoryNameLength != nil,\n+           \"must provide category info\")","path":"iphone/Maps/Bookmarks/Categories/Category settings/CategorySettingsViewController.swift","position":30,"original_position":30,"commit_id":"30add9efa59c0cb73040a1a6abe3711f8ac45c1f","original_commit_id":"30add9efa59c0cb73040a1a6abe3711f8ac45c1f","user":{"login":"beloal","id":5368791,"node_id":"MDQ6VXNlcjUzNjg3OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5368791?v=4","gravatar_id":"","url":"https://api.github.com/users/beloal","html_url":"https://github.com/beloal","followers_url":"https://api.github.com/users/beloal/followers","following_url":"https://api.github.com/users/beloal/following{/other_user}","gists_url":"https://api.github.com/users/beloal/gists{/gist_id}","starred_url":"https://api.github.com/users/beloal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beloal/subscriptions","organizations_url":"https://api.github.com/users/beloal/orgs","repos_url":"https://api.github.com/users/beloal/repos","events_url":"https://api.github.com/users/beloal/events{/privacy}","received_events_url":"https://api.github.com/users/beloal/received_events","type":"User","site_admin":false},"body":"You check if any (not all) of these conditions are met. Is it ok?","created_at":"2018-11-19T12:30:30Z","updated_at":"2018-11-19T12:35:51Z","html_url":"https://github.com/mapsme/omim/pull/9845#discussion_r234600825","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/9845","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/234600825"},"html":{"href":"https://github.com/mapsme/omim/pull/9845#discussion_r234600825"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9845"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/9845","id":231261513,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjYxNTEz","html_url":"https://github.com/mapsme/omim/pull/9845","diff_url":"https://github.com/mapsme/omim/pull/9845.diff","patch_url":"https://github.com/mapsme/omim/pull/9845.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/9845","number":9845,"state":"open","locked":false,"title":"[ios] category settings screen","user":{"login":"kadetlessy","id":2388608,"node_id":"MDQ6VXNlcjIzODg2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2388608?v=4","gravatar_id":"","url":"https://api.github.com/users/kadetlessy","html_url":"https://github.com/kadetlessy","followers_url":"https://api.github.com/users/kadetlessy/followers","following_url":"https://api.github.com/users/kadetlessy/following{/other_user}","gists_url":"https://api.github.com/users/kadetlessy/gists{/gist_id}","starred_url":"https://api.github.com/users/kadetlessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadetlessy/subscriptions","organizations_url":"https://api.github.com/users/kadetlessy/orgs","repos_url":"https://api.github.com/users/kadetlessy/repos","events_url":"https://api.github.com/users/kadetlessy/events{/privacy}","received_events_url":"https://api.github.com/users/kadetlessy/received_events","type":"User","site_admin":false},"body":"https://jira.mail.ru/browse/MAPSME-8851","created_at":"2018-11-15T16:43:27Z","updated_at":"2018-11-19T12:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e5bcc7b20748ec26c20f533da26bcfb457194d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/9845/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/9845/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/9845/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/30add9efa59c0cb73040a1a6abe3711f8ac45c1f","head":{"label":"kadetlessy:list_settings","ref":"list_settings","sha":"30add9efa59c0cb73040a1a6abe3711f8ac45c1f","user":{"login":"kadetlessy","id":2388608,"node_id":"MDQ6VXNlcjIzODg2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2388608?v=4","gravatar_id":"","url":"https://api.github.com/users/kadetlessy","html_url":"https://github.com/kadetlessy","followers_url":"https://api.github.com/users/kadetlessy/followers","following_url":"https://api.github.com/users/kadetlessy/following{/other_user}","gists_url":"https://api.github.com/users/kadetlessy/gists{/gist_id}","starred_url":"https://api.github.com/users/kadetlessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadetlessy/subscriptions","organizations_url":"https://api.github.com/users/kadetlessy/orgs","repos_url":"https://api.github.com/users/kadetlessy/repos","events_url":"https://api.github.com/users/kadetlessy/events{/privacy}","received_events_url":"https://api.github.com/users/kadetlessy/received_events","type":"User","site_admin":false},"repo":{"id":152086721,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwODY3MjE=","name":"omim","full_name":"kadetlessy/omim","private":false,"owner":{"login":"kadetlessy","id":2388608,"node_id":"MDQ6VXNlcjIzODg2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2388608?v=4","gravatar_id":"","url":"https://api.github.com/users/kadetlessy","html_url":"https://github.com/kadetlessy","followers_url":"https://api.github.com/users/kadetlessy/followers","following_url":"https://api.github.com/users/kadetlessy/following{/other_user}","gists_url":"https://api.github.com/users/kadetlessy/gists{/gist_id}","starred_url":"https://api.github.com/users/kadetlessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadetlessy/subscriptions","organizations_url":"https://api.github.com/users/kadetlessy/orgs","repos_url":"https://api.github.com/users/kadetlessy/repos","events_url":"https://api.github.com/users/kadetlessy/events{/privacy}","received_events_url":"https://api.github.com/users/kadetlessy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kadetlessy/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/kadetlessy/omim","forks_url":"https://api.github.com/repos/kadetlessy/omim/forks","keys_url":"https://api.github.com/repos/kadetlessy/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadetlessy/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadetlessy/omim/teams","hooks_url":"https://api.github.com/repos/kadetlessy/omim/hooks","issue_events_url":"https://api.github.com/repos/kadetlessy/omim/issues/events{/number}","events_url":"https://api.github.com/repos/kadetlessy/omim/events","assignees_url":"https://api.github.com/repos/kadetlessy/omim/assignees{/user}","branches_url":"https://api.github.com/repos/kadetlessy/omim/branches{/branch}","tags_url":"https://api.github.com/repos/kadetlessy/omim/tags","blobs_url":"https://api.github.com/repos/kadetlessy/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadetlessy/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadetlessy/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadetlessy/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadetlessy/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/kadetlessy/omim/languages","stargazers_url":"https://api.github.com/repos/kadetlessy/omim/stargazers","contributors_url":"https://api.github.com/repos/kadetlessy/omim/contributors","subscribers_url":"https://api.github.com/repos/kadetlessy/omim/subscribers","subscription_url":"https://api.github.com/repos/kadetlessy/omim/subscription","commits_url":"https://api.github.com/repos/kadetlessy/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadetlessy/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadetlessy/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadetlessy/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadetlessy/omim/contents/{+path}","compare_url":"https://api.github.com/repos/kadetlessy/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadetlessy/omim/merges","archive_url":"https://api.github.com/repos/kadetlessy/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadetlessy/omim/downloads","issues_url":"https://api.github.com/repos/kadetlessy/omim/issues{/number}","pulls_url":"https://api.github.com/repos/kadetlessy/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/kadetlessy/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/kadetlessy/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadetlessy/omim/labels{/name}","releases_url":"https://api.github.com/repos/kadetlessy/omim/releases{/id}","deployments_url":"https://api.github.com/repos/kadetlessy/omim/deployments","created_at":"2018-10-08T13:41:50Z","updated_at":"2018-10-08T13:43:10Z","pushed_at":"2018-11-16T18:17:21Z","git_url":"git://github.com/kadetlessy/omim.git","ssh_url":"git@github.com:kadetlessy/omim.git","clone_url":"https://github.com/kadetlessy/omim.git","svn_url":"https://github.com/kadetlessy/omim","homepage":"","size":4190953,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"849493346752bc4838c399f29d384af39af431ec","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","private":false,"owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-11-19T12:29:14Z","pushed_at":"2018-11-19T12:29:04Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":4192932,"stargazers_count":2838,"watchers_count":2838,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":616,"mirror_url":null,"archived":false,"open_issues_count":770,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":616,"open_issues":770,"watchers":2838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9845"},"html":{"href":"https://github.com/mapsme/omim/pull/9845"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/9845"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/9845/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9845/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9845/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/30add9efa59c0cb73040a1a6abe3711f8ac45c1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"beloal"}}