{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/comments/218905700","pull_request_review_id":156949290,"id":218905700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODkwNTcwMA==","diff_hunk":"@@ -171,34 +201,39 @@ func (optr *Operator) syncClusterAPIController(config render.OperatorConfig) err\n \tif err != nil {\n \t\treturn err\n \t}\n+\tglog.Infof(\"1\")","path":"pkg/operator/sync.go","position":83,"original_position":83,"commit_id":"9770c58ed104a5c376e0e88451eb965b59ab4f45","original_commit_id":"9770c58ed104a5c376e0e88451eb965b59ab4f45","user":{"login":"enxebre","id":1230698,"node_id":"MDQ6VXNlcjEyMzA2OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1230698?v=4","gravatar_id":"","url":"https://api.github.com/users/enxebre","html_url":"https://github.com/enxebre","followers_url":"https://api.github.com/users/enxebre/followers","following_url":"https://api.github.com/users/enxebre/following{/other_user}","gists_url":"https://api.github.com/users/enxebre/gists{/gist_id}","starred_url":"https://api.github.com/users/enxebre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enxebre/subscriptions","organizations_url":"https://api.github.com/users/enxebre/orgs","repos_url":"https://api.github.com/users/enxebre/repos","events_url":"https://api.github.com/users/enxebre/events{/privacy}","received_events_url":"https://api.github.com/users/enxebre/received_events","type":"User","site_admin":false},"body":"can we remove dev logging","created_at":"2018-09-19T18:01:26Z","updated_at":"2018-09-19T18:01:27Z","html_url":"https://github.com/openshift/machine-api-operator/pull/60#discussion_r218905700","pull_request_url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/comments/218905700"},"html":{"href":"https://github.com/openshift/machine-api-operator/pull/60#discussion_r218905700"},"pull_request":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60","id":216552280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTUyMjgw","html_url":"https://github.com/openshift/machine-api-operator/pull/60","diff_url":"https://github.com/openshift/machine-api-operator/pull/60.diff","patch_url":"https://github.com/openshift/machine-api-operator/pull/60.patch","issue_url":"https://api.github.com/repos/openshift/machine-api-operator/issues/60","number":60,"state":"open","locked":false,"title":"[WIP]Reconcile","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"body":"Fixes for the issues found in local testing. Rebased against master as well.\r\n\r\nThese changes have lots of debugging prints which i will remove before removing WIP ","created_at":"2018-09-19T08:20:22Z","updated_at":"2018-09-19T18:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d041d180ae674639a99bd0b40ba6138caab39f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bison","id":240676,"node_id":"MDQ6VXNlcjI0MDY3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/240676?v=4","gravatar_id":"","url":"https://api.github.com/users/bison","html_url":"https://github.com/bison","followers_url":"https://api.github.com/users/bison/followers","following_url":"https://api.github.com/users/bison/following{/other_user}","gists_url":"https://api.github.com/users/bison/gists{/gist_id}","starred_url":"https://api.github.com/users/bison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bison/subscriptions","organizations_url":"https://api.github.com/users/bison/orgs","repos_url":"https://api.github.com/users/bison/repos","events_url":"https://api.github.com/users/bison/events{/privacy}","received_events_url":"https://api.github.com/users/bison/received_events","type":"User","site_admin":false},{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":999954610,"node_id":"MDU6TGFiZWw5OTk5NTQ2MTA=","url":"https://api.github.com/repos/openshift/machine-api-operator/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":999954321,"node_id":"MDU6TGFiZWw5OTk5NTQzMjE=","url":"https://api.github.com/repos/openshift/machine-api-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60/commits","review_comments_url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60/comments","review_comment_url":"https://api.github.com/repos/openshift/machine-api-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/machine-api-operator/issues/60/comments","statuses_url":"https://api.github.com/repos/openshift/machine-api-operator/statuses/9770c58ed104a5c376e0e88451eb965b59ab4f45","head":{"label":"vikaschoudhary16:reconcile","ref":"reconcile","sha":"9770c58ed104a5c376e0e88451eb965b59ab4f45","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"repo":{"id":146891490,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4OTE0OTA=","name":"machine-api-operator","full_name":"vikaschoudhary16/machine-api-operator","private":false,"owner":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vikaschoudhary16/machine-api-operator","description":"Machine API operator","fork":true,"url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator","forks_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/forks","keys_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/teams","hooks_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/hooks","issue_events_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/issues/events{/number}","events_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/events","assignees_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/assignees{/user}","branches_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/branches{/branch}","tags_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/tags","blobs_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/languages","stargazers_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/stargazers","contributors_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/contributors","subscribers_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/subscribers","subscription_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/subscription","commits_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/contents/{+path}","compare_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/merges","archive_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/downloads","issues_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/issues{/number}","pulls_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/labels{/name}","releases_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/releases{/id}","deployments_url":"https://api.github.com/repos/vikaschoudhary16/machine-api-operator/deployments","created_at":"2018-08-31T12:51:17Z","updated_at":"2018-08-31T12:51:19Z","pushed_at":"2018-09-19T17:33:37Z","git_url":"git://github.com/vikaschoudhary16/machine-api-operator.git","ssh_url":"git@github.com:vikaschoudhary16/machine-api-operator.git","clone_url":"https://github.com/vikaschoudhary16/machine-api-operator.git","svn_url":"https://github.com/vikaschoudhary16/machine-api-operator","homepage":null,"size":7748,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:cvo-integration","ref":"cvo-integration","sha":"f9065a2c73a7a537785d9722a1fba7b6ef480084","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":141598983,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1OTg5ODM=","name":"machine-api-operator","full_name":"openshift/machine-api-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/machine-api-operator","description":"Machine API operator","fork":false,"url":"https://api.github.com/repos/openshift/machine-api-operator","forks_url":"https://api.github.com/repos/openshift/machine-api-operator/forks","keys_url":"https://api.github.com/repos/openshift/machine-api-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/machine-api-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/machine-api-operator/teams","hooks_url":"https://api.github.com/repos/openshift/machine-api-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/machine-api-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/machine-api-operator/events","assignees_url":"https://api.github.com/repos/openshift/machine-api-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/machine-api-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/machine-api-operator/tags","blobs_url":"https://api.github.com/repos/openshift/machine-api-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/machine-api-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/machine-api-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/machine-api-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/machine-api-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/machine-api-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/machine-api-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/machine-api-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/machine-api-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/machine-api-operator/subscription","commits_url":"https://api.github.com/repos/openshift/machine-api-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/machine-api-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/machine-api-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/machine-api-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/machine-api-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/machine-api-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/machine-api-operator/merges","archive_url":"https://api.github.com/repos/openshift/machine-api-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/machine-api-operator/downloads","issues_url":"https://api.github.com/repos/openshift/machine-api-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/machine-api-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/machine-api-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/machine-api-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/machine-api-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/machine-api-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/machine-api-operator/deployments","created_at":"2018-07-19T15:32:44Z","updated_at":"2018-09-18T16:30:48Z","pushed_at":"2018-09-19T17:33:38Z","git_url":"git://github.com/openshift/machine-api-operator.git","ssh_url":"git@github.com:openshift/machine-api-operator.git","clone_url":"https://github.com/openshift/machine-api-operator.git","svn_url":"https://github.com/openshift/machine-api-operator","homepage":null,"size":8225,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60"},"html":{"href":"https://github.com/openshift/machine-api-operator/pull/60"},"issue":{"href":"https://api.github.com/repos/openshift/machine-api-operator/issues/60"},"comments":{"href":"https://api.github.com/repos/openshift/machine-api-operator/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/machine-api-operator/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/machine-api-operator/statuses/9770c58ed104a5c376e0e88451eb965b59ab4f45"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"enxebre"}}