{"action":"closed","number":20506,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/20506","id":170410914,"html_url":"https://github.com/ceph/ceph/pull/20506","diff_url":"https://github.com/ceph/ceph/pull/20506.diff","patch_url":"https://github.com/ceph/ceph/pull/20506.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/20506","number":20506,"state":"closed","locked":false,"title":"pybind/mgr/prometheus: don't export metrics for dead daemon; new metrics","user":{"login":"jan--f","id":458501,"avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false},"body":"So far the module held on to metrics that are no longer updated. Say an OSD went down, the metrics for this OSD would keep being exported with the last value that the MGR reported. This PR removes these old metrics on every scrape, so that only current daemon metrics are exported.\r\nThis also adds a few new metrics, most notably ```mon_quorum_count``` is replaced by ```mon_quorum_status``` for every MON in the cluster. Also filesystem and MDS metadata metrics are added. I'm not certain the label selection is ideal for those two.\r\n\r\nThis will conflict with #20456, so happy to rebase this PR once #20456 is merged.","created_at":"2018-02-21T09:09:31Z","updated_at":"2018-03-02T00:57:43Z","closed_at":"2018-03-02T00:57:43Z","merged_at":"2018-03-02T00:57:43Z","merge_commit_sha":"ca2fd5abb8f516e42a18bc8db5845a21c8f4e6cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":850326757,"url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":454906768,"url":"https://api.github.com/repos/ceph/ceph/labels/mgr","name":"mgr","color":"c2e0c6","default":false},{"id":148431321,"url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":219859248,"url":"https://api.github.com/repos/ceph/ceph/labels/wip-kefu-testing","name":"wip-kefu-testing","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/20506/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/20506/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/20506/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/d03c79676b1761b016ceaed82f7e3f03f99cda73","head":{"label":"jan--f:prometheus-rm-outdated-daemon-metrics","ref":"prometheus-rm-outdated-daemon-metrics","sha":"d03c79676b1761b016ceaed82f7e3f03f99cda73","user":{"login":"jan--f","id":458501,"avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false},"repo":{"id":62213105,"name":"ceph","full_name":"jan--f/ceph","owner":{"login":"jan--f","id":458501,"avatar_url":"https://avatars0.githubusercontent.com/u/458501?v=4","gravatar_id":"","url":"https://api.github.com/users/jan--f","html_url":"https://github.com/jan--f","followers_url":"https://api.github.com/users/jan--f/followers","following_url":"https://api.github.com/users/jan--f/following{/other_user}","gists_url":"https://api.github.com/users/jan--f/gists{/gist_id}","starred_url":"https://api.github.com/users/jan--f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan--f/subscriptions","organizations_url":"https://api.github.com/users/jan--f/orgs","repos_url":"https://api.github.com/users/jan--f/repos","events_url":"https://api.github.com/users/jan--f/events{/privacy}","received_events_url":"https://api.github.com/users/jan--f/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jan--f/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/jan--f/ceph","forks_url":"https://api.github.com/repos/jan--f/ceph/forks","keys_url":"https://api.github.com/repos/jan--f/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jan--f/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jan--f/ceph/teams","hooks_url":"https://api.github.com/repos/jan--f/ceph/hooks","issue_events_url":"https://api.github.com/repos/jan--f/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/jan--f/ceph/events","assignees_url":"https://api.github.com/repos/jan--f/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/jan--f/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/jan--f/ceph/tags","blobs_url":"https://api.github.com/repos/jan--f/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jan--f/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jan--f/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/jan--f/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jan--f/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/jan--f/ceph/languages","stargazers_url":"https://api.github.com/repos/jan--f/ceph/stargazers","contributors_url":"https://api.github.com/repos/jan--f/ceph/contributors","subscribers_url":"https://api.github.com/repos/jan--f/ceph/subscribers","subscription_url":"https://api.github.com/repos/jan--f/ceph/subscription","commits_url":"https://api.github.com/repos/jan--f/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/jan--f/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/jan--f/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/jan--f/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/jan--f/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/jan--f/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jan--f/ceph/merges","archive_url":"https://api.github.com/repos/jan--f/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jan--f/ceph/downloads","issues_url":"https://api.github.com/repos/jan--f/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/jan--f/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/jan--f/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/jan--f/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jan--f/ceph/labels{/name}","releases_url":"https://api.github.com/repos/jan--f/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/jan--f/ceph/deployments","created_at":"2016-06-29T09:22:41Z","updated_at":"2016-06-29T09:23:03Z","pushed_at":"2018-03-01T07:45:08Z","git_url":"git://github.com/jan--f/ceph.git","ssh_url":"git@github.com:jan--f/ceph.git","clone_url":"https://github.com/jan--f/ceph.git","svn_url":"https://github.com/jan--f/ceph","homepage":"http://ceph.com","size":276686,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"59da11b195dce6709b101b84916d18ede7c01e76","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-03-01T12:41:06Z","pushed_at":"2018-03-02T00:57:43Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":270680,"stargazers_count":4163,"watchers_count":4163,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2326,"mirror_url":null,"archived":false,"open_issues_count":630,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2326,"open_issues":630,"watchers":4163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20506"},"html":{"href":"https://github.com/ceph/ceph/pull/20506"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/20506"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/20506/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20506/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20506/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/d03c79676b1761b016ceaed82f7e3f03f99cda73"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"comments":7,"review_comments":16,"maintainer_can_modify":false,"commits":4,"additions":235,"deletions":132,"changed_files":1}}
{"actor":{"display_login":"tchaikov"}}