{"action":"created","issue":{"url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/19","repository_url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript","labels_url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/19/comments","events_url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/19/events","html_url":"https://github.com/larrymyers/protoc-gen-twirp_typescript/issues/19","id":381771225,"node_id":"MDU6SXNzdWUzODE3NzEyMjU=","number":19,"title":"Allow configurable pathPrefix","user":{"login":"rynop","id":372730,"node_id":"MDQ6VXNlcjM3MjczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/372730?v=4","gravatar_id":"","url":"https://api.github.com/users/rynop","html_url":"https://github.com/rynop","followers_url":"https://api.github.com/users/rynop/followers","following_url":"https://api.github.com/users/rynop/following{/other_user}","gists_url":"https://api.github.com/users/rynop/gists{/gist_id}","starred_url":"https://api.github.com/users/rynop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynop/subscriptions","organizations_url":"https://api.github.com/users/rynop/orgs","repos_url":"https://api.github.com/users/rynop/repos","events_url":"https://api.github.com/users/rynop/events{/privacy}","received_events_url":"https://api.github.com/users/rynop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-16T21:44:32Z","updated_at":"2018-11-20T20:06:06Z","closed_at":null,"author_association":"NONE","body":"1st off THANK YOU for this.  I want to give you a hug cuz I've been debating for about a week on starting a Protobuf.js implementation and just noticed you pushed it 2 days ago!\r\n\r\nYou may already know that the https://github.com/twitchtv/twirp/tree/v6_prerelease branch no longer has the `/twirp` path prefix by default.\r\n\r\nDo you think its possible to make this configurable in your generator? Ex: https://github.com/larrymyers/protoc-gen-twirp_typescript/blob/master/example/ts_client/service.ts#L60 would optionally not contain `/twirp`\r\n\r\nUltimately you'd run something like this (I use [retool](https://github.com/twitchtv/retool)):\r\n\r\n```\r\nretool add github.com/golang/protobuf/protoc-gen-go origin/master\r\nretool add github.com/twitchtv/twirp/protoc-gen-twirp origin/v6_prerelease\r\nretool add github.com/larrymyers/protoc-gen-twirp_typescript/tree/master/generator origin/master\r\nretool do protoc --twirp_typescript_out=path_prefix=:./example/ts_client ./example/service.proto\r\n```\r\n\r\nI've never written protoc plugin before so syntax is prob way off, just trying to convey idea..."},"comment":{"url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/comments/440412041","html_url":"https://github.com/larrymyers/protoc-gen-twirp_typescript/issues/19#issuecomment-440412041","issue_url":"https://api.github.com/repos/larrymyers/protoc-gen-twirp_typescript/issues/19","id":440412041,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDQxMjA0MQ==","user":{"login":"larrymyers","id":50755,"node_id":"MDQ6VXNlcjUwNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/50755?v=4","gravatar_id":"","url":"https://api.github.com/users/larrymyers","html_url":"https://github.com/larrymyers","followers_url":"https://api.github.com/users/larrymyers/followers","following_url":"https://api.github.com/users/larrymyers/following{/other_user}","gists_url":"https://api.github.com/users/larrymyers/gists{/gist_id}","starred_url":"https://api.github.com/users/larrymyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larrymyers/subscriptions","organizations_url":"https://api.github.com/users/larrymyers/orgs","repos_url":"https://api.github.com/users/larrymyers/repos","events_url":"https://api.github.com/users/larrymyers/events{/privacy}","received_events_url":"https://api.github.com/users/larrymyers/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T20:06:06Z","updated_at":"2018-11-20T20:06:06Z","author_association":"OWNER","body":"Okay, a custom path prefix should be pretty straight forward if provided as another cli arg when executing proton.  I'll mark this as a feature request."}}
{"actor":{"display_login":"larrymyers"}}