{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-devtools/issues/1162","repository_url":"https://api.github.com/repos/facebook/react-devtools","labels_url":"https://api.github.com/repos/facebook/react-devtools/issues/1162/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-devtools/issues/1162/comments","events_url":"https://api.github.com/repos/facebook/react-devtools/issues/1162/events","html_url":"https://github.com/facebook/react-devtools/pull/1162","id":361901787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzU2MDgz","number":1162,"title":"add `color by self time` option to ProfilerSettings","user":{"login":"bennyhobart","id":3694930,"node_id":"MDQ6VXNlcjM2OTQ5MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3694930?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyhobart","html_url":"https://github.com/bennyhobart","followers_url":"https://api.github.com/users/bennyhobart/followers","following_url":"https://api.github.com/users/bennyhobart/following{/other_user}","gists_url":"https://api.github.com/users/bennyhobart/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyhobart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyhobart/subscriptions","organizations_url":"https://api.github.com/users/bennyhobart/orgs","repos_url":"https://api.github.com/users/bennyhobart/repos","events_url":"https://api.github.com/users/bennyhobart/events{/privacy}","received_events_url":"https://api.github.com/users/bennyhobart/received_events","type":"User","site_admin":false},"labels":[{"id":196859157,"node_id":"MDU6TGFiZWwxOTY4NTkxNTc=","url":"https://api.github.com/repos/facebook/react-devtools/labels/CLA%20Signed","name":"CLA Signed","color":"cccccc","default":false}],"state":"open","locked":false,"assignee":{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"assignees":[{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-09-19T19:51:04Z","updated_at":"2018-09-19T21:51:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facebook/react-devtools/pulls/1162","html_url":"https://github.com/facebook/react-devtools/pull/1162","diff_url":"https://github.com/facebook/react-devtools/pull/1162.diff","patch_url":"https://github.com/facebook/react-devtools/pull/1162.patch"},"body":"Hi,\r\n\r\nI'd find it extremely useful to color components based on the time they took to run their render method, as opposed to how long the component and all its descendants took to render.\r\n\r\nHere's a video showing off the feature https://vimeo.com/290768458\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/facebook/react-devtools/issues/comments/422970926","html_url":"https://github.com/facebook/react-devtools/pull/1162#issuecomment-422970926","issue_url":"https://api.github.com/repos/facebook/react-devtools/issues/1162","id":422970926,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjk3MDkyNg==","user":{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T21:51:37Z","updated_at":"2018-09-19T21:51:37Z","author_association":"CONTRIBUTOR","body":"Firstly, this is really exciting. Thanks for contributing! 😁 I'm excited to play around with this some and see if it makes spotting perf problems easier (I think it will).\r\n\r\nI do think there's a bit of an oddity about the current implementation though, captured in this GIF:\r\n![kapture 2018-09-19 at 14 49 13](https://user-images.githubusercontent.com/29597/45783652-37234f80-bc1b-11e8-88af-38a89ec26d52.gif)\r\n\r\nI think we need to ignore self base time for native nodes if they've been filtered out of DevTools, else we risk showing a confusing commit like the GIF above shows. I think this– coupled with the potential for small discrepancies between `actualDuration` and `selfBaseDuration` might be reason enough to go with the approach of JIT determining the max \"self time\" via `committedNodes.forEach` rather than using the `_onMountOrUpdate` approach. (I suppose we _could_ just collect _two_ `_maxSelfBaseDuration` values– one included host nodes and one not, but that feels kind of janky.)"}}
{"actor":{"display_login":"bvaughn"}}