{"action":"created","issue":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/75","repository_url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts","labels_url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/75/comments","events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/75/events","html_url":"https://github.com/ghoneycutt/puppet-module-hosts/issues/75","id":392417786,"node_id":"MDU6SXNzdWUzOTI0MTc3ODY=","number":75,"title":"v3 no longer creating default host entries as expected when using 'include ::hosts' with no data","user":{"login":"ulysses-31","id":33386027,"node_id":"MDQ6VXNlcjMzMzg2MDI3","avatar_url":"https://avatars2.githubusercontent.com/u/33386027?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysses-31","html_url":"https://github.com/ulysses-31","followers_url":"https://api.github.com/users/ulysses-31/followers","following_url":"https://api.github.com/users/ulysses-31/following{/other_user}","gists_url":"https://api.github.com/users/ulysses-31/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysses-31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysses-31/subscriptions","organizations_url":"https://api.github.com/users/ulysses-31/orgs","repos_url":"https://api.github.com/users/ulysses-31/repos","events_url":"https://api.github.com/users/ulysses-31/events{/privacy}","received_events_url":"https://api.github.com/users/ulysses-31/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-19T02:43:07Z","updated_at":"2018-12-19T03:16:24Z","closed_at":null,"author_association":"NONE","body":"Previous 2.x versions you were able to keep the host fqdn entry in /etc/hosts up-to-date by just including the 'hosts' module (with no associated data defined for the hosts module). \r\nI have noticed the following two issues:\r\n\r\n(1) With v3 of the hosts module the local fqdn entry is still managed however it is no longer idempotent resulting in an additional duplicate host entry being added each time puppet is run.\r\n\r\ne.g. /etc/hosts after multiple puppet runs\r\n10.3.4.148  testserver.mydomain.local      testserver\r\n10.3.4.148  testserver.mydomain.local      testserver\r\n10.3.4.148  testserver.mydomain.local      testserver\r\n\r\n(2) v3 no longer ensures these default localhost entries are created in /etc/hosts:\r\n\r\n127.0.0.1       localhost.localdomain   localhost localhost4 localhost4.localdomain4\r\n::1     localhost6.localdomain6 localhost6 localhost6.localdomain6"},"comment":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/comments/448455139","html_url":"https://github.com/ghoneycutt/puppet-module-hosts/issues/75#issuecomment-448455139","issue_url":"https://api.github.com/repos/ghoneycutt/puppet-module-hosts/issues/75","id":448455139,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQ1NTEzOQ==","user":{"login":"ghoneycutt","id":313891,"node_id":"MDQ6VXNlcjMxMzg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/313891?v=4","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T03:16:24Z","updated_at":"2018-12-19T03:16:24Z","author_association":"OWNER","body":"Thanks for pointing this out! Added acceptance tests which also catch this at https://github.com/ghoneycutt/puppet-module-hosts/pull/65/commits/03d05f56b5139407557e69149b5819c303ae9f62#diff-8793845accebc0de146174b602f0afccR13"}}
{"actor":{"display_login":"ghoneycutt"}}