{"action":"created","issue":{"url":"https://api.github.com/repos/Bixal/move.mil/issues/105","repository_url":"https://api.github.com/repos/Bixal/move.mil","labels_url":"https://api.github.com/repos/Bixal/move.mil/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/Bixal/move.mil/issues/105/comments","events_url":"https://api.github.com/repos/Bixal/move.mil/issues/105/events","html_url":"https://github.com/Bixal/move.mil/pull/105","id":316015918,"number":105,"title":"Section dividers (tied to jump link targets)","user":{"login":"jkoulish-bixal","id":29130580,"avatar_url":"https://avatars3.githubusercontent.com/u/29130580?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoulish-bixal","html_url":"https://github.com/jkoulish-bixal","followers_url":"https://api.github.com/users/jkoulish-bixal/followers","following_url":"https://api.github.com/users/jkoulish-bixal/following{/other_user}","gists_url":"https://api.github.com/users/jkoulish-bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoulish-bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoulish-bixal/subscriptions","organizations_url":"https://api.github.com/users/jkoulish-bixal/orgs","repos_url":"https://api.github.com/users/jkoulish-bixal/repos","events_url":"https://api.github.com/users/jkoulish-bixal/events{/privacy}","received_events_url":"https://api.github.com/users/jkoulish-bixal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T19:48:02Z","updated_at":"2018-04-19T19:49:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Bixal/move.mil/pulls/105","html_url":"https://github.com/Bixal/move.mil/pull/105","diff_url":"https://github.com/Bixal/move.mil/pull/105.diff","patch_url":"https://github.com/Bixal/move.mil/pull/105.patch"},"body":"We're going to need to revisit cases where sections and their dividers aren't so neatly tied to jump links, not to mention cases where the jump links currently differ from the live site.\r\n\r\nBut going with a general rule that the sections delineated by jump links have a light gray divider between them, the contents of this PR should be able to cover much of the spacing between/around page sections.\r\n\r\n## Checklist\r\n\r\nI have…\r\n\r\n- [x] run the application locally (`make up`) and verified that my changes behave as expected.\r\n- [x] run static behat test suite (`circleci build --job behat`) against my changes.\r\n- [x] run the code sniffer (`circleci build --job code-sniffer`) against my changes.\r\n- [x] run the code coverage tool (`circleci build --job code-coverage`) \r\n      against my changes\r\n- [x] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.\r\n- [x] thoroughly outlined below the steps necessary to test my changes.\r\n- [x] attached screenshots illustrating relevant behavior before and after my changes.\r\n- [x] read, understand, and agree to the terms described in [CONTRIBUTING.md](https://github.com/Bixal/move.mil/blob/master/CONTRIBUTING.md).\r\n- [x] added my name, email address, and copyright date to [CONTRIBUTORS.md](https://github.com/Bixal/move.mil/blob/master/CONTRIBUTORS.md).\r\n\r\n## Summary of Changes\r\n\r\nThis pull request…\r\n\r\n- Except for the first paragraph on the page, puts 20px padding, 1px border (aka the section divider) and 20px margin above the title fields of Basic Text paragraphs (the specific fields referenced in the jump links module). \r\n- Creates a special snowflake override to mimic the divider behavior on the Nightmare Moves page, which has Basic Text and Pro Tips paragraphs together in a grid sort of layout. No other overrides are needed at this time, though that may change sooner rather than later as content becomes better-aligned with jump links generation.\r\n\r\n## Testing\r\n\r\nTo verify the changes proposed in this pull request…\r\n\r\n1. Pull code\r\n1. Build theme assets\r\n1. Browse various pages, mostly within Moving Guide section, to see the dividers and how they differ across pages.\r\n\r\n## Screenshots\r\n\r\nLocal (CONUS page):\r\n([compare to live site](https://www.move.mil/moving-guide/conus#assignment))\r\n<img width=\"881\" alt=\"screen shot 2018-04-19 at 3 44 26 pm\" src=\"https://user-images.githubusercontent.com/29130580/39014565-b2f67ca0-43e8-11e8-89cb-af0b21d3ba80.png\">\r\n\r\nLocal (Nightmare moves page):\r\n([compare to live site](https://www.move.mil/moving-guide/nightmare-moves#bolt-box))\r\n<img width=\"838\" alt=\"screen shot 2018-04-19 at 3 45 55 pm\" src=\"https://user-images.githubusercontent.com/29130580/39014602-d0147a08-43e8-11e8-93dd-28a52ef7d029.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/Bixal/move.mil/issues/comments/382859437","html_url":"https://github.com/Bixal/move.mil/pull/105#issuecomment-382859437","issue_url":"https://api.github.com/repos/Bixal/move.mil/issues/105","id":382859437,"user":{"login":"jkoulish-bixal","id":29130580,"avatar_url":"https://avatars3.githubusercontent.com/u/29130580?v=4","gravatar_id":"","url":"https://api.github.com/users/jkoulish-bixal","html_url":"https://github.com/jkoulish-bixal","followers_url":"https://api.github.com/users/jkoulish-bixal/followers","following_url":"https://api.github.com/users/jkoulish-bixal/following{/other_user}","gists_url":"https://api.github.com/users/jkoulish-bixal/gists{/gist_id}","starred_url":"https://api.github.com/users/jkoulish-bixal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkoulish-bixal/subscriptions","organizations_url":"https://api.github.com/users/jkoulish-bixal/orgs","repos_url":"https://api.github.com/users/jkoulish-bixal/repos","events_url":"https://api.github.com/users/jkoulish-bixal/events{/privacy}","received_events_url":"https://api.github.com/users/jkoulish-bixal/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T19:49:59Z","updated_at":"2018-04-19T19:49:59Z","author_association":"CONTRIBUTOR","body":"cc @scottqueen-bixal you might want to take a look at this too"}}
{"actor":{"display_login":"jkoulish-bixal"}}