{"action":"created","issue":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3487","repository_url":"https://api.github.com/repos/umbraco/Umbraco-CMS","labels_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3487/labels{/name}","comments_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3487/comments","events_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3487/events","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3487","id":375819353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTc0Nzc5","number":3487,"title":"Fixed strange Email validation behaviour in the backend","user":{"login":"renetruelsen","id":43169509,"node_id":"MDQ6VXNlcjQzMTY5NTA5","avatar_url":"https://avatars3.githubusercontent.com/u/43169509?v=4","gravatar_id":"","url":"https://api.github.com/users/renetruelsen","html_url":"https://github.com/renetruelsen","followers_url":"https://api.github.com/users/renetruelsen/followers","following_url":"https://api.github.com/users/renetruelsen/following{/other_user}","gists_url":"https://api.github.com/users/renetruelsen/gists{/gist_id}","starred_url":"https://api.github.com/users/renetruelsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renetruelsen/subscriptions","organizations_url":"https://api.github.com/users/renetruelsen/orgs","repos_url":"https://api.github.com/users/renetruelsen/repos","events_url":"https://api.github.com/users/renetruelsen/events{/privacy}","received_events_url":"https://api.github.com/users/renetruelsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-31T06:37:47Z","updated_at":"2018-11-06T16:13:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/pulls/3487","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3487","diff_url":"https://github.com/umbraco/Umbraco-CMS/pull/3487.diff","patch_url":"https://github.com/umbraco/Umbraco-CMS/pull/3487.patch"},"body":"\r\nFixes: https://github.com/umbraco/Umbraco-CMS/issues/3013\r\n\r\n### Changes:\r\n\r\n1) Synkronized the email validation patterns to fix irregularities between frontend and backend validation. (had to adapt the regex pattern to work with both angular and .NET)\r\n2) Aligned this regular expression with the default \"Email pattern\"-validation in the Umbraco backend.\r\n3) Changed size of backend  validation-box for regex-patterns (2 rows instead of 1 row)\r\n4) Bugfixed the valpropertymsg and valserver directives to ignore an empty string, since this is handled by the valrequired-directive.\r\n\r\n### Tests\r\n\r\n- I tested on the backend validating email-datatypes with and without \"required\" validation. \r\n- On string-datatypes with combinations of email-regex-validation and \"required\"-validation.\r\n\r\n...this is my first pull-request, so be gentle. And let me know if I overlooked something in the process. :-)\r\n"},"comment":{"url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/comments/436310539","html_url":"https://github.com/umbraco/Umbraco-CMS/pull/3487#issuecomment-436310539","issue_url":"https://api.github.com/repos/umbraco/Umbraco-CMS/issues/3487","id":436310539,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjMxMDUzOQ==","user":{"login":"nul800sebastiaan","id":304656,"node_id":"MDQ6VXNlcjMwNDY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/304656?v=4","gravatar_id":"","url":"https://api.github.com/users/nul800sebastiaan","html_url":"https://github.com/nul800sebastiaan","followers_url":"https://api.github.com/users/nul800sebastiaan/followers","following_url":"https://api.github.com/users/nul800sebastiaan/following{/other_user}","gists_url":"https://api.github.com/users/nul800sebastiaan/gists{/gist_id}","starred_url":"https://api.github.com/users/nul800sebastiaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nul800sebastiaan/subscriptions","organizations_url":"https://api.github.com/users/nul800sebastiaan/orgs","repos_url":"https://api.github.com/users/nul800sebastiaan/repos","events_url":"https://api.github.com/users/nul800sebastiaan/events{/privacy}","received_events_url":"https://api.github.com/users/nul800sebastiaan/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T16:13:03Z","updated_at":"2018-11-06T16:13:03Z","author_association":"MEMBER","body":"Hi there @renetruelsen,\n\nFirst of all: **A big #H5YR** for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing :pray:\n\nIf you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the [Umbraco Hacktoberfest Aftermath blog post](https://umbraco.com/blog/the-2018-hacktoberfest-aftermath/).\n\nIn the spirit of Hacktoberfest we've prepared some **exclusive Umbraco swag** for all our contributors - _including you_! \n\n[Receive your swag!](https://goo.gl/forms/smjQwEMDM5cUnz6x1) :point_left: Please follow this link to fill out and submit the form, **before November 21st 2018**.\n\nFollowing this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient :pray:\n\nThe only thing left to say is **thank you so much for participating in Hacktoberfest**! We really appreciate the help!\n\nKind regards,\nThe Umbraco PR Team & The Documentation Curators"}}
{"actor":{"display_login":"nul800sebastiaan"}}