{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph-container/issues/1029","repository_url":"https://api.github.com/repos/ceph/ceph-container","labels_url":"https://api.github.com/repos/ceph/ceph-container/issues/1029/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph-container/issues/1029/comments","events_url":"https://api.github.com/repos/ceph/ceph-container/issues/1029/events","html_url":"https://github.com/ceph/ceph-container/pull/1029","id":315966938,"number":1029,"title":"make: revise the meaning of a 'flavor', and allow overrides of BASEOS_ vars - fix #1028","user":{"login":"BlaineEXE","id":3989526,"avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-19T17:17:27Z","updated_at":"2018-04-20T16:28:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph-container/pulls/1029","html_url":"https://github.com/ceph/ceph-container/pull/1029","diff_url":"https://github.com/ceph/ceph-container/pull/1029.diff","patch_url":"https://github.com/ceph/ceph-container/pull/1029.patch"},"body":"It isn't very straightforward for a user that the BASEOS_REPO and\r\nBASEOS_TAG specified in the flavor spec (`<ceph version>[point\r\nrelease],<baseos repo>, <baseos tag>`) refer to the ceph-container\r\nsource directories. Fix this by changing BASEOS_REPO to DISTRO and\r\nBASEOS_TAG to DISTRO_VERSION in the makefile. We still need BASEOS_REPO\r\nand BASEOS_TAG, because we are planning to make these overrideable.    \r\n\r\nSince we now are making the flavor clearly ceph-release source path\r\nlocations, the user may want to override any of the individual\r\ncomponents, not just BASE_IMAGE as a whole.\r\n\r\nWe still have BASE_IMAGE which can be used with `__ENV_[BASE_IMAGE]__`,\r\nbut BASE_IMAGE is now calculated and set in staging Python code. Since\r\nvisual feedback of the value is still valuable, we add a 'Computed:'\r\nsection to the staging output with BASE_IMAGE verified in it.\r\n\r\nfixes #1028 \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph-container/issues/comments/383150559","html_url":"https://github.com/ceph/ceph-container/pull/1029#issuecomment-383150559","issue_url":"https://api.github.com/repos/ceph/ceph-container/issues/1029","id":383150559,"user":{"login":"BlaineEXE","id":3989526,"avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T16:28:13Z","updated_at":"2018-04-20T16:28:13Z","author_association":"COLLABORATOR","body":"> I like the proposal but noticed something which confused me.\r\n> \r\n> In this example:\r\n> \r\n>     make FLAVORS=luminous,centos-arm64,7 BASEOS_REPO=centos stage\r\n>     STAGING_DIR : staging/luminous-centos-7-x86_64\r\n> \r\n> If STAGING_DIR is using the BASEOS_REPO, it means that is conflicting with any other flavor using that which isn't that nice.\r\n> \r\n> I think that STAGING_DIR should used centos-arm64 which is supposed to be unique.\r\n\r\nI started to go about changing this to source from DISTRO instead, but I realized that there is more intricacy here. When you specify any overrideable variable, you are potentially messing up other flavor builds. If I said `make FLAVORS=\"luminous,centos-arm64,7 luminous,opensuse,42.3\" BASEOS_REPO=centos, then both the centos-arm64 and opensuse builds will use 'centos' as the baseos repo. This isn't a bad thing, but it **is** undocumented, which I should change. (You could still do `make FLAVORS=\"luminous,centos-arm64,7 luminous,centos,7\" BASEOS_REPO=centos build.parallel` and still have success)\r\n\r\nThe other intricacy is that in staging, if you see the ceph-version, distro, and distro-version used to source the stage (which is good), you have to inspect the stage files to see what base image is used for that stage. This isn't necessarily a bad thing."}}
{"actor":{"display_login":"BlaineEXE"}}