{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/221842297","pull_request_review_id":160586546,"id":221842297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg0MjI5Nw==","diff_hunk":"@@ -20,6 +20,7 @@ export function canvas(kibana) {\n         title: 'Canvas',\n         description: 'Data driven workpads',\n         icon: 'plugins/canvas/icon.svg',\n+        euiIconType: 'reportingApp', // TODO: replace with real icon once it exists in EUI","path":"x-pack/plugins/canvas/index.js","position":4,"original_position":4,"commit_id":"4466d0a3e046e29b0c464a1a234a9bfadaa4ebcf","original_commit_id":"555f53b01998c276a4977da0aa361bc4aca83278","user":{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Yeah, I was just wondering whether we have some sort default `no-icon` placeholder somewhere in EUI that will be used for `canvasApp` and will \"automatically\" switch to the right icon once EUI provides it.","created_at":"2018-10-02T07:04:00Z","updated_at":"2018-10-02T07:04:00Z","html_url":"https://github.com/elastic/kibana/pull/23300#discussion_r221842297","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/23300","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/221842297"},"html":{"href":"https://github.com/elastic/kibana/pull/23300#discussion_r221842297"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23300"}},"in_reply_to_id":221017730},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/23300","id":216457826,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDU3ODI2","html_url":"https://github.com/elastic/kibana/pull/23300","diff_url":"https://github.com/elastic/kibana/pull/23300.diff","patch_url":"https://github.com/elastic/kibana/pull/23300.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/23300","number":23300,"state":"open","locked":false,"title":"Add K7 header navigation","user":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your interest in and contributing to Kibana! There\r\nare a few simple things to check before submitting your pull request\r\nthat can help with the review process. You should delete these items\r\nfrom your submission, but they are here to help bring them to your\r\nattention.\r\n\r\n- Have you signed the [contributor license agreement](https://www.elastic.co/contributor-agreement)?\r\n- Have you followed the [contributor guidelines](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md)?\r\n- If submitting code, have you included unit tests that cover the changes?\r\n- If submitting code, have you tested and built your code locally prior to submission with `yarn test && yarn build`?\r\n- If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.\r\n-->\r\n\r\nAdds the new K7 header navigation as an optional UI. To enable, go to Management > Advanced Settings > Search for \"k7\" > Toggle the k7design setting.\r\n\r\nFeatures supported:\r\n- Custom nav controls. Similar to our existing UI, plugins can add their own widgets to the navbar using a nav control registry. Plugins can specify which side of the nav they'd like to put their controls on. Currently, only the security plugin is using this for the current user / logout widget. Spaces will use this to attach the current space / space switcher to the left side of the header.\r\n- Breadcrumbs. Plugins can now populate a global breadcrumb UI that supports linking.\r\n- App Menu. The app menu has been ported to a new \"keypad palette\" style. Plugins will need to provide new icons to support this new style. Currently\r\n\r\n![image](https://user-images.githubusercontent.com/1813008/46021783-002fbc80-c0a7-11e8-9979-727b0d0908cb.png)\r\n\r\n![image](https://user-images.githubusercontent.com/1813008/45972315-0bc8a800-c001-11e8-8433-0c99fdd5b0e1.png)\r\n\r\n\r\n### Add a nav control\r\n\r\n```js\r\nimport { chromeHeaderNavControlsRegistry } from 'ui/registry/chrome_header_nav_controls';\r\nimport { NavControlSide } from 'ui/chrome/directives/global_header_nav';\r\n\r\nchromeHeaderNavControlsRegistry.register((myAngularDep) => ({\r\n  name: 'myPluginControl',\r\n  order: 100,\r\n  side: NavControlSide.Right, // controls can be on right or left sides\r\n  render(domNode) {\r\n    const thingFromDep = myAngularDep.get();\r\n    \r\n    // Render with whatever you want React, Angular, Vue.js, vanilla JS\r\n    ReactDOM.render(<MyComponent thing={thingFromDep} />, domNode);\r\n\r\n    // Provide a function that will do any deconstruction + cleanup needed when this UI goes away\r\n    return () => ReactDOM.unmountComponentAtNode(domNode);\r\n  }\r\n});\r\n```\r\n\r\n### Update breadcrumbs\r\n\r\n```js\r\n// Inside an angular module\r\napp.directive('myDirective', (breadcrumbState) => {\r\n  breadcrumbState.set([\r\n    { text: 'MyPlugin', href: '/app/myplugin' },\r\n    { text: 'MySection' }\r\n  ]);\r\n}\r\n\r\n// anywhere else\r\nimport { set } from 'ui/chrome/services/breadcrumb_state';\r\n\r\nset([\r\n  { text: 'MyPlugin', href: '/app/myplugin' },\r\n  { text: 'MySection' }\r\n]);\r\n```\r\n\r\n\r\n## TODO\r\n- [x] Add support for breadcrumbs\r\n- [x] Hide old-style breadcrumbs when new header UI is shown\r\n- [x] ~~Add support back in for whitelabeled logos~~\r\n  - Our current custom branding API is undocumented/unsupported. Decided not to reimplement this now.\r\n- [x] ~~Fallback to icon images if iconType is not provided~~\r\n  - Will be done later by Design team","created_at":"2018-09-18T22:03:25Z","updated_at":"2018-10-02T07:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d39b75849ed531ca44ed23ea68fa434ad3fada0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/:Platform","name":":Platform","color":"fef2c0","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/23300/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/23300/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/23300/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/4466d0a3e046e29b0c464a1a234a9bfadaa4ebcf","head":{"label":"joshdover:k7-nav","ref":"k7-nav","sha":"4466d0a3e046e29b0c464a1a234a9bfadaa4ebcf","user":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"repo":{"id":139932255,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MzIyNTU=","name":"kibana","full_name":"joshdover/kibana","private":false,"owner":{"login":"joshdover","id":1813008,"node_id":"MDQ6VXNlcjE4MTMwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1813008?v=4","gravatar_id":"","url":"https://api.github.com/users/joshdover","html_url":"https://github.com/joshdover","followers_url":"https://api.github.com/users/joshdover/followers","following_url":"https://api.github.com/users/joshdover/following{/other_user}","gists_url":"https://api.github.com/users/joshdover/gists{/gist_id}","starred_url":"https://api.github.com/users/joshdover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshdover/subscriptions","organizations_url":"https://api.github.com/users/joshdover/orgs","repos_url":"https://api.github.com/users/joshdover/repos","events_url":"https://api.github.com/users/joshdover/events{/privacy}","received_events_url":"https://api.github.com/users/joshdover/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshdover/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/joshdover/kibana","forks_url":"https://api.github.com/repos/joshdover/kibana/forks","keys_url":"https://api.github.com/repos/joshdover/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshdover/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshdover/kibana/teams","hooks_url":"https://api.github.com/repos/joshdover/kibana/hooks","issue_events_url":"https://api.github.com/repos/joshdover/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/joshdover/kibana/events","assignees_url":"https://api.github.com/repos/joshdover/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/joshdover/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/joshdover/kibana/tags","blobs_url":"https://api.github.com/repos/joshdover/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshdover/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshdover/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshdover/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshdover/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/joshdover/kibana/languages","stargazers_url":"https://api.github.com/repos/joshdover/kibana/stargazers","contributors_url":"https://api.github.com/repos/joshdover/kibana/contributors","subscribers_url":"https://api.github.com/repos/joshdover/kibana/subscribers","subscription_url":"https://api.github.com/repos/joshdover/kibana/subscription","commits_url":"https://api.github.com/repos/joshdover/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshdover/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshdover/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshdover/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshdover/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/joshdover/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshdover/kibana/merges","archive_url":"https://api.github.com/repos/joshdover/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshdover/kibana/downloads","issues_url":"https://api.github.com/repos/joshdover/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/joshdover/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/joshdover/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/joshdover/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshdover/kibana/labels{/name}","releases_url":"https://api.github.com/repos/joshdover/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/joshdover/kibana/deployments","created_at":"2018-07-06T04:15:01Z","updated_at":"2018-09-17T17:29:37Z","pushed_at":"2018-10-01T21:59:52Z","git_url":"git://github.com/joshdover/kibana.git","ssh_url":"git@github.com:joshdover/kibana.git","clone_url":"https://github.com/joshdover/kibana.git","svn_url":"https://github.com/joshdover/kibana","homepage":"https://www.elastic.co/products/kibana","size":504395,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"6b3bc45b9aa41e0e2a73a2bc62752af63801e9ac","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-10-02T03:34:55Z","pushed_at":"2018-10-02T06:51:26Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":520445,"stargazers_count":10177,"watchers_count":10177,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3959,"mirror_url":null,"archived":false,"open_issues_count":3616,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3959,"open_issues":3616,"watchers":10177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23300"},"html":{"href":"https://github.com/elastic/kibana/pull/23300"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/23300"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/23300/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23300/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/23300/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/4466d0a3e046e29b0c464a1a234a9bfadaa4ebcf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"azasypkin"}}