{"push_id":2854389323,"size":21,"distinct_size":0,"ref":"refs/heads/2.8","head":"992a174470fd557e1cddccd3a35447209602aea3","before":"53c1a5f2bc0c4b3b983b0400a34e236739e85877","commits":[{"sha":"0edbbd3feaaf1fa852dd4b92c1004f7d383c23b1","author":{"name":"Julien Fredon","email":"09e7240318a913382747ea19e25f960faf9289d3@gmail.com"},"message":"Format file size in validation message according to binaryFormat option","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/0edbbd3feaaf1fa852dd4b92c1004f7d383c23b1"},{"sha":"d2e9e0bcf3d0860e19f95872ad566763adbc9910","author":{"name":"Yanick Witschi","email":"a1b0bc8ef74d1f473893b332e403e253f4e4129e@terminal42.ch"},"message":"Fixed the interface description of the url generator interface","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/d2e9e0bcf3d0860e19f95872ad566763adbc9910"},{"sha":"599de83b3342367eee9dc317db0fa17d8128be56","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"Fix appveyor","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/599de83b3342367eee9dc317db0fa17d8128be56"},{"sha":"a39133179197e9b9f9bbc5ae3ad9d32209410f2c","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"[appveyor] minor CI fix","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/a39133179197e9b9f9bbc5ae3ad9d32209410f2c"},{"sha":"3b687fd09d89c689d1f7fae49c8b1fc2df9d2263","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"minor #28340 [appveyor] minor CI fix (nicolas-grekas)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[appveyor] minor CI fix\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nShould fix this message on appveyor:\n`fatal: Not a valid object name HEAD^`\n\nCommits\n-------\n\na391331791 [appveyor] minor CI fix","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/3b687fd09d89c689d1f7fae49c8b1fc2df9d2263"},{"sha":"9d24400b1f52c842c9d13feb376fd860966c1e9f","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"[appveyor] fix bis","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/9d24400b1f52c842c9d13feb376fd860966c1e9f"},{"sha":"450098a5a1dce0c2b81052b43afa8309aa82952e","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"minor #28342 [appveyor] fix bis (nicolas-grekas)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[appveyor] fix bis\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nGive it another try...\n\nCommits\n-------\n\n9d24400b1f [appveyor] fix bis","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/450098a5a1dce0c2b81052b43afa8309aa82952e"},{"sha":"74b6689838625112aef5e696b932aec16ca04e6f","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"[travis][appveyor] fix ter","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/74b6689838625112aef5e696b932aec16ca04e6f"},{"sha":"f9bd8acc580f69d3af8bea56dcc31f1d2322a4d8","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"[travis] minor fix (quater)","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/f9bd8acc580f69d3af8bea56dcc31f1d2322a4d8"},{"sha":"b133bd6bd30e54f9dfedff68f998def65988ae03","author":{"name":"Hugo Alliaume","email":"81e527f5ae27a8bad941aa9f89a3ed661db2dbe9@live.fr"},"message":"chore: rename Appveyor filename","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/b133bd6bd30e54f9dfedff68f998def65988ae03"},{"sha":"62e620843e30a228fc830783215384b68f31ba5f","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"fixed usage of setUp in tests","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/62e620843e30a228fc830783215384b68f31ba5f"},{"sha":"26b173b91522ddc48cbaad2a0a75d82ced345f84","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"minor #28347 Fix usage of setUp in tests (fabpot)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\nFix usage of setUp in tests\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | no\n| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\n| License       | MIT\n\n<!--\nWrite a short README entry for your feature/bugfix here (replace this comment block.)\nThis will help people understand your PR and can be used as a start of the Doc PR.\nAdditionally:\n - Bug fixes must be submitted against the lowest branch where they apply\n   (lowest branches are regularly merged to upper ones so they get the fixes too).\n - Features and deprecations must be submitted against the master branch.\n-->\n\nCommits\n-------\n\n62e620843e fixed usage of setUp in tests","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/26b173b91522ddc48cbaad2a0a75d82ced345f84"},{"sha":"255455430a9363b5b7862e8729d870533e34826c","author":{"name":"Nicolas Grekas","email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com"},"message":"[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/255455430a9363b5b7862e8729d870533e34826c"},{"sha":"b102e7285640a504ba276b70410c59f3c66b6013","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"minor #28345 chore: rename AppVeyor filename (Kocal)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\nchore: rename AppVeyor filename\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | no\n| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\n| Fixed tickets | ~   <!-- #-prefixed issue number(s), if any -->\n| License       | MIT\n| Doc PR        | ~ <!-- required for new features -->\n\n<!--\nWrite a short README entry for your feature/bugfix here (replace this comment block.)\nThis will help people understand your PR and can be used as a start of the Doc PR.\nAdditionally:\n - Bug fixes must be submitted against the lowest branch where they apply\n   (lowest branches are regularly merged to upper ones so they get the fixes too).\n - Features and deprecations must be submitted against the master branch.\n-->\n\nIn [AppVeyor documentation](https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming), it says that is possible to use alternative filename `.appveyor.yml`.\n\nBy doing this, I find this more consistent with Travis file which starts with a `.` too.\n\nCommits\n-------\n\nb133bd6bd3 chore: rename Appveyor filename","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/b102e7285640a504ba276b70410c59f3c66b6013"},{"sha":"cf359c2e79c85992bfcd3cd7588eb6cbea2a2f80","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"bug #28344 [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients (nicolas-grekas)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #28125\n| License       | MIT\n| Doc PR        | -\n\nCommits\n-------\n\n255455430a [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/cf359c2e79c85992bfcd3cd7588eb6cbea2a2f80"},{"sha":"487f8acde58baf73c601f480b217488e549caca2","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"minor #28321 [Routing] Fixed the interface description of the url generator interface (Toflar)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[Routing] Fixed the interface description of the url generator interface\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nThe `UrlGenerator` has always been able to return `null`. Many tests assert this for many years but the interface actually always only allowed a `string` return.\n\nExamples for tests:\n\n- https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L206\n- https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L217\n- https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php#L471\n\nSo I think I would not consider this change as a BC break but rather a doc fix because it seems like `null` has always been an accepted return value.\n\nCommits\n-------\n\nd2e9e0bcf3 Fixed the interface description of the url generator interface","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/487f8acde58baf73c601f480b217488e549caca2"},{"sha":"ef1f7ff0bb1f3ac80c34505148532c3a34ab0bd3","author":{"name":"Christian Flothmann","email":"99edea749d976752fc257334ca5ee456d4d4f1b4@sensiolabs.de"},"message":"remove cache warmers when Twig cache is disabled","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/ef1f7ff0bb1f3ac80c34505148532c3a34ab0bd3"},{"sha":"e7d325f49f0b16f0f6e9c0331d341da8bbfa1d3a","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"bug #28029 [TwigBundle] remove cache warmers when Twig cache is disabled (xabbuh)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[TwigBundle] remove cache warmers when Twig cache is disabled\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #28009\n| License       | MIT\n| Doc PR        |\n\nCommits\n-------\n\nef1f7ff0bb remove cache warmers when Twig cache is disabled","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/e7d325f49f0b16f0f6e9c0331d341da8bbfa1d3a"},{"sha":"a1596382338f0cd9057bd911a4e71599798d1e82","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"bug #27970 [FileValidator] Format file size in validation message according to binaryFormat option (jfredon)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[FileValidator] Format file size in validation message according to binaryFormat option\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8 up to master\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #27682\n| License       | MIT\n| Doc PR        |\n\nThe binaryFormat option of the constraint is not taken into account if the maxsize limit is defined by the php configuration files.\nThis patch correct this inconsistent behavior.\n\nIf the binaryOption is not set, the unit of measurement used remains in binary because it’s the unit used in php configuration files.\n\nCommits\n-------\n\n0edbbd3fea Format file size in validation message according to binaryFormat option","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/a1596382338f0cd9057bd911a4e71599798d1e82"},{"sha":"90494c20cc1f029293d12b480c280cb056751a2b","author":{"name":"Fabien Potencier","email":"777bcfcf9efee56bedca63c5eb2304e67df52892@potencier.org"},"message":"Revert \"minor #28321 [Routing] Fixed the interface description of the url generator interface (Toflar)\"\n\nThis reverts commit 487f8acde58baf73c601f480b217488e549caca2, reversing\nchanges made to cf359c2e79c85992bfcd3cd7588eb6cbea2a2f80.","distinct":false,"url":"https://api.github.com/repos/edoger/symfony/commits/90494c20cc1f029293d12b480c280cb056751a2b"}]}
{"actor":{"display_login":"edoger"}}