{"action":"closed","number":1143,"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/1143","id":223033688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDMzNjg4","html_url":"https://github.com/transcom/mymove/pull/1143","diff_url":"https://github.com/transcom/mymove/pull/1143.diff","patch_url":"https://github.com/transcom/mymove/pull/1143.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/1143","number":1143,"state":"closed","locked":false,"title":"Support uploading docs for hhg move","user":{"login":"Ronolibert","id":13622298,"node_id":"MDQ6VXNlcjEzNjIyMjk4","avatar_url":"https://avatars2.githubusercontent.com/u/13622298?v=4","gravatar_id":"","url":"https://api.github.com/users/Ronolibert","html_url":"https://github.com/Ronolibert","followers_url":"https://api.github.com/users/Ronolibert/followers","following_url":"https://api.github.com/users/Ronolibert/following{/other_user}","gists_url":"https://api.github.com/users/Ronolibert/gists{/gist_id}","starred_url":"https://api.github.com/users/Ronolibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ronolibert/subscriptions","organizations_url":"https://api.github.com/users/Ronolibert/orgs","repos_url":"https://api.github.com/users/Ronolibert/repos","events_url":"https://api.github.com/users/Ronolibert/events{/privacy}","received_events_url":"https://api.github.com/users/Ronolibert/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAdd support for uploading documents to an HHG move. Affected areas are office app and approved service member\r\n\r\n## Reviewer Notes\r\n- not sure if ppmId is even needed\r\n\r\n## Setup\r\n\r\n```sh\r\nmake db_populate_e2e\r\nmake server_run\r\nmake office_client_run\r\nmake client_run\r\n```\r\n\r\n## Code Review Verification Steps\r\n\r\n* [x] End to end tests pass (`make e2e_test`).\r\n* [x] Request review from a member of a different team.\r\n* [x] Have the Pivotal acceptance criteria been met for this change?\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/161066343) for this change\r\n\r\n## Screenshots\r\n\r\n![Upload-hhg](https://user-images.githubusercontent.com/13622298/46976537-993a6d80-d07e-11e8-84ab-7cfbae15bab5.gif)\r\n","created_at":"2018-10-15T20:31:51Z","updated_at":"2018-10-16T20:45:30Z","closed_at":"2018-10-16T20:45:30Z","merged_at":"2018-10-16T20:45:30Z","merge_commit_sha":"87e1359e53da0451b93cfa771fc381977f96a52f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kahlouie","id":5531789,"node_id":"MDQ6VXNlcjU1MzE3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/5531789?v=4","gravatar_id":"","url":"https://api.github.com/users/kahlouie","html_url":"https://github.com/kahlouie","followers_url":"https://api.github.com/users/kahlouie/followers","following_url":"https://api.github.com/users/kahlouie/following{/other_user}","gists_url":"https://api.github.com/users/kahlouie/gists{/gist_id}","starred_url":"https://api.github.com/users/kahlouie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kahlouie/subscriptions","organizations_url":"https://api.github.com/users/kahlouie/orgs","repos_url":"https://api.github.com/users/kahlouie/repos","events_url":"https://api.github.com/users/kahlouie/events{/privacy}","received_events_url":"https://api.github.com/users/kahlouie/received_events","type":"User","site_admin":false},{"login":"amitch23","id":8170735,"node_id":"MDQ6VXNlcjgxNzA3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8170735?v=4","gravatar_id":"","url":"https://api.github.com/users/amitch23","html_url":"https://github.com/amitch23","followers_url":"https://api.github.com/users/amitch23/followers","following_url":"https://api.github.com/users/amitch23/following{/other_user}","gists_url":"https://api.github.com/users/amitch23/gists{/gist_id}","starred_url":"https://api.github.com/users/amitch23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitch23/subscriptions","organizations_url":"https://api.github.com/users/amitch23/orgs","repos_url":"https://api.github.com/users/amitch23/repos","events_url":"https://api.github.com/users/amitch23/events{/privacy}","received_events_url":"https://api.github.com/users/amitch23/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/1143/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/1143/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/1143/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/2e6319af6320448c2689a17d44435b44cede596a","head":{"label":"transcom:rc-#161066343-upload-documents-hhg","ref":"rc-#161066343-upload-documents-hhg","sha":"2e6319af6320448c2689a17d44435b44cede596a","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-10-16T20:42:43Z","pushed_at":"2018-10-16T20:45:30Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":28413,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":15,"watchers":15,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"e18dd4ddf3b3130254da4307455f062eabad5002","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-10-16T20:42:43Z","pushed_at":"2018-10-16T20:45:30Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":28413,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":15,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1143"},"html":{"href":"https://github.com/transcom/mymove/pull/1143"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/1143"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/1143/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1143/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1143/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/2e6319af6320448c2689a17d44435b44cede596a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Ronolibert","id":13622298,"node_id":"MDQ6VXNlcjEzNjIyMjk4","avatar_url":"https://avatars2.githubusercontent.com/u/13622298?v=4","gravatar_id":"","url":"https://api.github.com/users/Ronolibert","html_url":"https://github.com/Ronolibert","followers_url":"https://api.github.com/users/Ronolibert/followers","following_url":"https://api.github.com/users/Ronolibert/following{/other_user}","gists_url":"https://api.github.com/users/Ronolibert/gists{/gist_id}","starred_url":"https://api.github.com/users/Ronolibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ronolibert/subscriptions","organizations_url":"https://api.github.com/users/Ronolibert/orgs","repos_url":"https://api.github.com/users/Ronolibert/repos","events_url":"https://api.github.com/users/Ronolibert/events{/privacy}","received_events_url":"https://api.github.com/users/Ronolibert/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":140,"deletions":43,"changed_files":6}}
{"actor":{"display_login":"Ronolibert"}}