{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/3557","repository_url":"https://api.github.com/repos/apollographql/apollo-client","labels_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3557/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3557/comments","events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3557/events","html_url":"https://github.com/apollographql/apollo-client/pull/3557","id":330398271,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDE4OTQ2","number":3557,"title":"perf: prevent falsy error prop re-renders","user":{"login":"toddtarsi","id":4707505,"node_id":"MDQ6VXNlcjQ3MDc1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4707505?v=4","gravatar_id":"","url":"https://api.github.com/users/toddtarsi","html_url":"https://github.com/toddtarsi","followers_url":"https://api.github.com/users/toddtarsi/followers","following_url":"https://api.github.com/users/toddtarsi/following{/other_user}","gists_url":"https://api.github.com/users/toddtarsi/gists{/gist_id}","starred_url":"https://api.github.com/users/toddtarsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddtarsi/subscriptions","organizations_url":"https://api.github.com/users/toddtarsi/orgs","repos_url":"https://api.github.com/users/toddtarsi/repos","events_url":"https://api.github.com/users/toddtarsi/events{/privacy}","received_events_url":"https://api.github.com/users/toddtarsi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hwillson","id":137740,"node_id":"MDQ6VXNlcjEzNzc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/137740?v=4","gravatar_id":"","url":"https://api.github.com/users/hwillson","html_url":"https://github.com/hwillson","followers_url":"https://api.github.com/users/hwillson/followers","following_url":"https://api.github.com/users/hwillson/following{/other_user}","gists_url":"https://api.github.com/users/hwillson/gists{/gist_id}","starred_url":"https://api.github.com/users/hwillson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwillson/subscriptions","organizations_url":"https://api.github.com/users/hwillson/orgs","repos_url":"https://api.github.com/users/hwillson/repos","events_url":"https://api.github.com/users/hwillson/events{/privacy}","received_events_url":"https://api.github.com/users/hwillson/received_events","type":"User","site_admin":false},"assignees":[{"login":"hwillson","id":137740,"node_id":"MDQ6VXNlcjEzNzc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/137740?v=4","gravatar_id":"","url":"https://api.github.com/users/hwillson","html_url":"https://github.com/hwillson","followers_url":"https://api.github.com/users/hwillson/followers","following_url":"https://api.github.com/users/hwillson/following{/other_user}","gists_url":"https://api.github.com/users/hwillson/gists{/gist_id}","starred_url":"https://api.github.com/users/hwillson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwillson/subscriptions","organizations_url":"https://api.github.com/users/hwillson/orgs","repos_url":"https://api.github.com/users/hwillson/repos","events_url":"https://api.github.com/users/hwillson/events{/privacy}","received_events_url":"https://api.github.com/users/hwillson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-07T19:07:09Z","updated_at":"2018-09-20T17:50:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3557","html_url":"https://github.com/apollographql/apollo-client/pull/3557","diff_url":"https://github.com/apollographql/apollo-client/pull/3557.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/3557.patch"},"body":"Sometimes queryStoreValue is undefined. This is triggering some extra processing steps because we're checking if errors have changed if `[] !== undefined` and that seems silly to me. I've actually yet to see errorStatusChanged of false on a `fetchMore` request with an errorPolicy of `all`. Namely, data won't equal data when it essentially can. You can tell this by checking on line 598. Sometimes you'll get this to equal to false, and then true if you call `JSON.stringify(lastResult.data) === JSON.stringify(resultFromStore.data)`. \r\n\r\nTo note, this is a more researched implementation of this optimization, which actually works and doesn't break everything:\r\n\r\nhttps://github.com/apollographql/apollo-client/pull/3552\r\n\r\nThanks again for the great repo!\r\nWhen I use this, I find the performance gains to be rather significant, as re-renders can be a bit like round trips on low to mid tier mobile."},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments/423274460","html_url":"https://github.com/apollographql/apollo-client/pull/3557#issuecomment-423274460","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3557","id":423274460,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzI3NDQ2MA==","user":{"login":"toddtarsi","id":4707505,"node_id":"MDQ6VXNlcjQ3MDc1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4707505?v=4","gravatar_id":"","url":"https://api.github.com/users/toddtarsi","html_url":"https://github.com/toddtarsi","followers_url":"https://api.github.com/users/toddtarsi/followers","following_url":"https://api.github.com/users/toddtarsi/following{/other_user}","gists_url":"https://api.github.com/users/toddtarsi/gists{/gist_id}","starred_url":"https://api.github.com/users/toddtarsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddtarsi/subscriptions","organizations_url":"https://api.github.com/users/toddtarsi/orgs","repos_url":"https://api.github.com/users/toddtarsi/repos","events_url":"https://api.github.com/users/toddtarsi/events{/privacy}","received_events_url":"https://api.github.com/users/toddtarsi/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T17:50:35Z","updated_at":"2018-09-20T17:50:35Z","author_association":"NONE","body":"No, it's okay to close this. The amount of code drift since then has been pretty significant. I'm just trying to find my footing in the latest version of the codebase and am too exhausted from local bug hunts. I have enough in my own backyard that I can't really pursue this now lol. Thank you for the great codebase and keeping things moving forward. Sorry to provide a half researched and un-benchmarked set of changes. "}}
{"actor":{"display_login":"toddtarsi"}}