{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/godot/issues/19164","repository_url":"https://api.github.com/repos/godotengine/godot","labels_url":"https://api.github.com/repos/godotengine/godot/issues/19164/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/19164/comments","events_url":"https://api.github.com/repos/godotengine/godot/issues/19164/events","html_url":"https://github.com/godotengine/godot/pull/19164","id":326607516,"number":19164,"title":"Improve TileMap undo operations, second try","user":{"login":"marcelofg55","id":10578225,"avatar_url":"https://avatars1.githubusercontent.com/u/10578225?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelofg55","html_url":"https://github.com/marcelofg55","followers_url":"https://api.github.com/users/marcelofg55/followers","following_url":"https://api.github.com/users/marcelofg55/following{/other_user}","gists_url":"https://api.github.com/users/marcelofg55/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelofg55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelofg55/subscriptions","organizations_url":"https://api.github.com/users/marcelofg55/orgs","repos_url":"https://api.github.com/users/marcelofg55/repos","events_url":"https://api.github.com/users/marcelofg55/events{/privacy}","received_events_url":"https://api.github.com/users/marcelofg55/received_events","type":"User","site_admin":false},"labels":[{"id":73330066,"url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"44bbff","default":true},{"id":279097966,"url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffdd44","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/7","html_url":"https://github.com/godotengine/godot/milestone/7","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/7/labels","id":2529217,"number":7,"title":"3.1","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":961,"closed_issues":1445,"state":"open","created_at":"2017-05-18T13:33:56Z","updated_at":"2018-05-26T00:24:16Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-05-25T17:34:11Z","updated_at":"2018-05-26T01:10:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/19164","html_url":"https://github.com/godotengine/godot/pull/19164","diff_url":"https://github.com/godotengine/godot/pull/19164.diff","patch_url":"https://github.com/godotengine/godot/pull/19164.patch"},"body":"Fixes #18996\r\nThis an improved version of #19127. Basically the same logic as #19127 is used here but I've added a function on TileMap: `set_cellv_and_update_bitmask_area` which fixes the autotiling problems that #19127 had.\r\n\r\nNote: I first thought about adding a parameter on set_cellv like: `bool update__bitmask_area = false ` but I couldn't go that route since VARIANT_ARG_MAX = 5 and that would make set_cellv args be 6, so instead I've added the `set_cellv_and_update_bitmask_area` function."},"comment":{"url":"https://api.github.com/repos/godotengine/godot/issues/comments/392224117","html_url":"https://github.com/godotengine/godot/pull/19164#issuecomment-392224117","issue_url":"https://api.github.com/repos/godotengine/godot/issues/19164","id":392224117,"user":{"login":"MarianoGnu","id":1776044,"avatar_url":"https://avatars2.githubusercontent.com/u/1776044?v=4","gravatar_id":"","url":"https://api.github.com/users/MarianoGnu","html_url":"https://github.com/MarianoGnu","followers_url":"https://api.github.com/users/MarianoGnu/followers","following_url":"https://api.github.com/users/MarianoGnu/following{/other_user}","gists_url":"https://api.github.com/users/MarianoGnu/gists{/gist_id}","starred_url":"https://api.github.com/users/MarianoGnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarianoGnu/subscriptions","organizations_url":"https://api.github.com/users/MarianoGnu/orgs","repos_url":"https://api.github.com/users/MarianoGnu/repos","events_url":"https://api.github.com/users/MarianoGnu/events{/privacy}","received_events_url":"https://api.github.com/users/MarianoGnu/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T01:10:14Z","updated_at":"2018-05-26T01:10:14Z","author_association":"CONTRIBUTOR","body":"This PR has the same problem why i ended up using set_tile_data/get_tile_data: when you have more than 1 subtile with the same bitmask, calling undo/redo will select a new random subtile for each cell, making the operation undeterministic"}}
{"actor":{"display_login":"MarianoGnu"}}