{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1802","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1802/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1802/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1802/events","html_url":"https://github.com/ocaml/ocaml/pull/1802","id":326755235,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzUyMDky","number":1802,"title":"Make the character set for OCaml source code officially UTF-8.","user":{"login":"pmetzger","id":1907413,"node_id":"MDQ6VXNlcjE5MDc0MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1907413?v=4","gravatar_id":"","url":"https://api.github.com/users/pmetzger","html_url":"https://github.com/pmetzger","followers_url":"https://api.github.com/users/pmetzger/followers","following_url":"https://api.github.com/users/pmetzger/following{/other_user}","gists_url":"https://api.github.com/users/pmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/pmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmetzger/subscriptions","organizations_url":"https://api.github.com/users/pmetzger/orgs","repos_url":"https://api.github.com/users/pmetzger/repos","events_url":"https://api.github.com/users/pmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/pmetzger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":37,"created_at":"2018-05-26T17:40:44Z","updated_at":"2018-05-31T09:19:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1802","html_url":"https://github.com/ocaml/ocaml/pull/1802","diff_url":"https://github.com/ocaml/ocaml/pull/1802.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1802.patch"},"body":"By doing this, editors and other tools can presume that UTF-8 is the encoding to use for OCaml source. I think this is an idea whose time has come. Latin-1 identifiers have now been deprecated with a warning for many years.\r\n\r\nNote: I've made the `Changes` entry assuming this would _NOT_ be a candidate for 4.07.\r\n\r\n1. lexer.mll: change to no longer recognize latin-1 in identifiers and the like. Previously this was accepted with a warning. UTF-8 encoding conflicts with Latin-1.\r\n2. lex.etex: change documentation to state explicitly that the character set for source code is Unicode/UTF-8, but that only ASCII codepoints are permitted in source except for comments and string literals. Also note that character literals can't contain non-ASCII. Note in the identifier syntax that letters mean ASCII letters.\r\n3. Changes: Note the above has happened."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/393469379","html_url":"https://github.com/ocaml/ocaml/pull/1802#issuecomment-393469379","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1802","id":393469379,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQ2OTM3OQ==","user":{"login":"xavierleroy","id":3845810,"node_id":"MDQ6VXNlcjM4NDU4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T09:19:03Z","updated_at":"2018-05-31T09:19:03Z","author_association":"CONTRIBUTOR","body":"> Or are you proposing that we should allow the UTF-8 representation of the latin1 identifiers we presently allow? (not sure what I think of that yet!)\r\n\r\nI didn't think of this one either!  Technically, it's a trivial modification to the lexer.  Conceptually, it's a compromise that sends an odd message, but a better message than the current Latin-1-based situation."}}
{"actor":{"display_login":"xavierleroy"}}