{"action":"created","comment":{"url":"https://api.github.com/repos/openfun/marsha/pulls/comments/235153658","pull_request_review_id":176955296,"id":235153658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTE1MzY1OA==","diff_hunk":"@@ -7,7 +7,9 @@\n     \"build\": \"webpack\",\n     \"build-dev\": \"yarn copy-iframe-resizer; yarn build\",\n     \"copy-iframe-resizer\": \"cp node_modules/iframe-resizer/js/iframeResizer.min.js ../backend/marsha/static/js\",\n-    \"lint\": \"tslint -c tslint.json '**/*.ts?(x)' -e 'node_modules/**/*'\",\n+    \"lint\": \"tslint --fix -c tslint.json '**/*.ts?(x)' -e 'node_modules/**/*'\",","path":"src/frontend/package.json","position":5,"original_position":5,"commit_id":"1d1899bc83cb2d436618280a003f972e25d109b1","original_commit_id":"1d1899bc83cb2d436618280a003f972e25d109b1","user":{"login":"mbenadda","id":1932937,"node_id":"MDQ6VXNlcjE5MzI5Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1932937?v=4","gravatar_id":"","url":"https://api.github.com/users/mbenadda","html_url":"https://github.com/mbenadda","followers_url":"https://api.github.com/users/mbenadda/followers","following_url":"https://api.github.com/users/mbenadda/following{/other_user}","gists_url":"https://api.github.com/users/mbenadda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbenadda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbenadda/subscriptions","organizations_url":"https://api.github.com/users/mbenadda/orgs","repos_url":"https://api.github.com/users/mbenadda/repos","events_url":"https://api.github.com/users/mbenadda/events{/privacy}","received_events_url":"https://api.github.com/users/mbenadda/received_events","type":"User","site_admin":false},"body":"Sorry, maybe I should have mentioned this earlier.\r\n\r\nIf you prefer write mode maybe we can make a `lint-fix` command to run tslint with fixes and bundle it in `lint-all`?","created_at":"2018-11-20T20:14:17Z","updated_at":"2018-11-20T20:14:17Z","html_url":"https://github.com/openfun/marsha/pull/148#discussion_r235153658","pull_request_url":"https://api.github.com/repos/openfun/marsha/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openfun/marsha/pulls/comments/235153658"},"html":{"href":"https://github.com/openfun/marsha/pull/148#discussion_r235153658"},"pull_request":{"href":"https://api.github.com/repos/openfun/marsha/pulls/148"}},"in_reply_to_id":235084878},"pull_request":{"url":"https://api.github.com/repos/openfun/marsha/pulls/148","id":231910652,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTEwNjUy","html_url":"https://github.com/openfun/marsha/pull/148","diff_url":"https://github.com/openfun/marsha/pull/148.diff","patch_url":"https://github.com/openfun/marsha/pull/148.patch","issue_url":"https://api.github.com/repos/openfun/marsha/issues/148","number":148,"state":"open","locked":false,"title":"⚡(front) add helper in yarn script to run easily linters","user":{"login":"lunika","id":767834,"node_id":"MDQ6VXNlcjc2NzgzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/767834?v=4","gravatar_id":"","url":"https://api.github.com/users/lunika","html_url":"https://github.com/lunika","followers_url":"https://api.github.com/users/lunika/followers","following_url":"https://api.github.com/users/lunika/following{/other_user}","gists_url":"https://api.github.com/users/lunika/gists{/gist_id}","starred_url":"https://api.github.com/users/lunika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunika/subscriptions","organizations_url":"https://api.github.com/users/lunika/orgs","repos_url":"https://api.github.com/users/lunika/repos","events_url":"https://api.github.com/users/lunika/events{/privacy}","received_events_url":"https://api.github.com/users/lunika/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nWe use both tslint and prettier to manage our code styles. Prettier was\r\nnot configured in package.json. This PR add a prettier script and a more\r\ngeneral one to run both tslint and prettier at the same time. This\r\ncommand can be used in a pre-commit hook for example.\r\n\r\n## Proposal\r\n\r\nadd two new scripts in package definition:\r\n\r\n- [x] script to run prettier\r\n- [x] script to run at the same time tslint and prettier.\r\n\r\n\r\n","created_at":"2018-11-19T09:52:51Z","updated_at":"2018-11-20T20:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1155bb63ef6c9728ea912926067d214ab3efd1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1064438747,"node_id":"MDU6TGFiZWwxMDY0NDM4NzQ3","url":"https://api.github.com/repos/openfun/marsha/labels/improvement","name":"improvement","color":"9900ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openfun/marsha/pulls/148/commits","review_comments_url":"https://api.github.com/repos/openfun/marsha/pulls/148/comments","review_comment_url":"https://api.github.com/repos/openfun/marsha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfun/marsha/issues/148/comments","statuses_url":"https://api.github.com/repos/openfun/marsha/statuses/1d1899bc83cb2d436618280a003f972e25d109b1","head":{"label":"openfun:yarn-enhancement","ref":"yarn-enhancement","sha":"1d1899bc83cb2d436618280a003f972e25d109b1","user":{"login":"openfun","id":7224891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMjQ4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7224891?v=4","gravatar_id":"","url":"https://api.github.com/users/openfun","html_url":"https://github.com/openfun","followers_url":"https://api.github.com/users/openfun/followers","following_url":"https://api.github.com/users/openfun/following{/other_user}","gists_url":"https://api.github.com/users/openfun/gists{/gist_id}","starred_url":"https://api.github.com/users/openfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfun/subscriptions","organizations_url":"https://api.github.com/users/openfun/orgs","repos_url":"https://api.github.com/users/openfun/repos","events_url":"https://api.github.com/users/openfun/events{/privacy}","received_events_url":"https://api.github.com/users/openfun/received_events","type":"Organization","site_admin":false},"repo":{"id":129740507,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NDA1MDc=","name":"marsha","full_name":"openfun/marsha","private":false,"owner":{"login":"openfun","id":7224891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMjQ4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7224891?v=4","gravatar_id":"","url":"https://api.github.com/users/openfun","html_url":"https://github.com/openfun","followers_url":"https://api.github.com/users/openfun/followers","following_url":"https://api.github.com/users/openfun/following{/other_user}","gists_url":"https://api.github.com/users/openfun/gists{/gist_id}","starred_url":"https://api.github.com/users/openfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfun/subscriptions","organizations_url":"https://api.github.com/users/openfun/orgs","repos_url":"https://api.github.com/users/openfun/repos","events_url":"https://api.github.com/users/openfun/events{/privacy}","received_events_url":"https://api.github.com/users/openfun/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openfun/marsha","description":"🐠 A FUN LTI video provider","fork":false,"url":"https://api.github.com/repos/openfun/marsha","forks_url":"https://api.github.com/repos/openfun/marsha/forks","keys_url":"https://api.github.com/repos/openfun/marsha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfun/marsha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfun/marsha/teams","hooks_url":"https://api.github.com/repos/openfun/marsha/hooks","issue_events_url":"https://api.github.com/repos/openfun/marsha/issues/events{/number}","events_url":"https://api.github.com/repos/openfun/marsha/events","assignees_url":"https://api.github.com/repos/openfun/marsha/assignees{/user}","branches_url":"https://api.github.com/repos/openfun/marsha/branches{/branch}","tags_url":"https://api.github.com/repos/openfun/marsha/tags","blobs_url":"https://api.github.com/repos/openfun/marsha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfun/marsha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfun/marsha/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfun/marsha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfun/marsha/statuses/{sha}","languages_url":"https://api.github.com/repos/openfun/marsha/languages","stargazers_url":"https://api.github.com/repos/openfun/marsha/stargazers","contributors_url":"https://api.github.com/repos/openfun/marsha/contributors","subscribers_url":"https://api.github.com/repos/openfun/marsha/subscribers","subscription_url":"https://api.github.com/repos/openfun/marsha/subscription","commits_url":"https://api.github.com/repos/openfun/marsha/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfun/marsha/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfun/marsha/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfun/marsha/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfun/marsha/contents/{+path}","compare_url":"https://api.github.com/repos/openfun/marsha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfun/marsha/merges","archive_url":"https://api.github.com/repos/openfun/marsha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfun/marsha/downloads","issues_url":"https://api.github.com/repos/openfun/marsha/issues{/number}","pulls_url":"https://api.github.com/repos/openfun/marsha/pulls{/number}","milestones_url":"https://api.github.com/repos/openfun/marsha/milestones{/number}","notifications_url":"https://api.github.com/repos/openfun/marsha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfun/marsha/labels{/name}","releases_url":"https://api.github.com/repos/openfun/marsha/releases{/id}","deployments_url":"https://api.github.com/repos/openfun/marsha/deployments","created_at":"2018-04-16T12:32:54Z","updated_at":"2018-11-20T11:23:00Z","pushed_at":"2018-11-20T18:01:22Z","git_url":"git://github.com/openfun/marsha.git","ssh_url":"git@github.com:openfun/marsha.git","clone_url":"https://github.com/openfun/marsha.git","svn_url":"https://github.com/openfun/marsha","homepage":"","size":629,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"openfun:master","ref":"master","sha":"51947562ccbbc3c5ceaa0e16c6d3e00016119257","user":{"login":"openfun","id":7224891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMjQ4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7224891?v=4","gravatar_id":"","url":"https://api.github.com/users/openfun","html_url":"https://github.com/openfun","followers_url":"https://api.github.com/users/openfun/followers","following_url":"https://api.github.com/users/openfun/following{/other_user}","gists_url":"https://api.github.com/users/openfun/gists{/gist_id}","starred_url":"https://api.github.com/users/openfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfun/subscriptions","organizations_url":"https://api.github.com/users/openfun/orgs","repos_url":"https://api.github.com/users/openfun/repos","events_url":"https://api.github.com/users/openfun/events{/privacy}","received_events_url":"https://api.github.com/users/openfun/received_events","type":"Organization","site_admin":false},"repo":{"id":129740507,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NDA1MDc=","name":"marsha","full_name":"openfun/marsha","private":false,"owner":{"login":"openfun","id":7224891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMjQ4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7224891?v=4","gravatar_id":"","url":"https://api.github.com/users/openfun","html_url":"https://github.com/openfun","followers_url":"https://api.github.com/users/openfun/followers","following_url":"https://api.github.com/users/openfun/following{/other_user}","gists_url":"https://api.github.com/users/openfun/gists{/gist_id}","starred_url":"https://api.github.com/users/openfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfun/subscriptions","organizations_url":"https://api.github.com/users/openfun/orgs","repos_url":"https://api.github.com/users/openfun/repos","events_url":"https://api.github.com/users/openfun/events{/privacy}","received_events_url":"https://api.github.com/users/openfun/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openfun/marsha","description":"🐠 A FUN LTI video provider","fork":false,"url":"https://api.github.com/repos/openfun/marsha","forks_url":"https://api.github.com/repos/openfun/marsha/forks","keys_url":"https://api.github.com/repos/openfun/marsha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfun/marsha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfun/marsha/teams","hooks_url":"https://api.github.com/repos/openfun/marsha/hooks","issue_events_url":"https://api.github.com/repos/openfun/marsha/issues/events{/number}","events_url":"https://api.github.com/repos/openfun/marsha/events","assignees_url":"https://api.github.com/repos/openfun/marsha/assignees{/user}","branches_url":"https://api.github.com/repos/openfun/marsha/branches{/branch}","tags_url":"https://api.github.com/repos/openfun/marsha/tags","blobs_url":"https://api.github.com/repos/openfun/marsha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfun/marsha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfun/marsha/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfun/marsha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfun/marsha/statuses/{sha}","languages_url":"https://api.github.com/repos/openfun/marsha/languages","stargazers_url":"https://api.github.com/repos/openfun/marsha/stargazers","contributors_url":"https://api.github.com/repos/openfun/marsha/contributors","subscribers_url":"https://api.github.com/repos/openfun/marsha/subscribers","subscription_url":"https://api.github.com/repos/openfun/marsha/subscription","commits_url":"https://api.github.com/repos/openfun/marsha/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfun/marsha/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfun/marsha/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfun/marsha/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfun/marsha/contents/{+path}","compare_url":"https://api.github.com/repos/openfun/marsha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfun/marsha/merges","archive_url":"https://api.github.com/repos/openfun/marsha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfun/marsha/downloads","issues_url":"https://api.github.com/repos/openfun/marsha/issues{/number}","pulls_url":"https://api.github.com/repos/openfun/marsha/pulls{/number}","milestones_url":"https://api.github.com/repos/openfun/marsha/milestones{/number}","notifications_url":"https://api.github.com/repos/openfun/marsha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfun/marsha/labels{/name}","releases_url":"https://api.github.com/repos/openfun/marsha/releases{/id}","deployments_url":"https://api.github.com/repos/openfun/marsha/deployments","created_at":"2018-04-16T12:32:54Z","updated_at":"2018-11-20T11:23:00Z","pushed_at":"2018-11-20T18:01:22Z","git_url":"git://github.com/openfun/marsha.git","ssh_url":"git@github.com:openfun/marsha.git","clone_url":"https://github.com/openfun/marsha.git","svn_url":"https://github.com/openfun/marsha","homepage":"","size":629,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfun/marsha/pulls/148"},"html":{"href":"https://github.com/openfun/marsha/pull/148"},"issue":{"href":"https://api.github.com/repos/openfun/marsha/issues/148"},"comments":{"href":"https://api.github.com/repos/openfun/marsha/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/openfun/marsha/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/openfun/marsha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfun/marsha/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/openfun/marsha/statuses/1d1899bc83cb2d436618280a003f972e25d109b1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mbenadda"}}