{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/206459733","pull_request_review_id":141874096,"id":206459733,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQ1OTczMw==","diff_hunk":"@@ -83,8 +83,8 @@ User can create BloomFilter datamap using the Create DataMap DDL:\n | Property | Is Required | Default Value | Description |\n |-------------|----------|--------|---------|\n | INDEX_COLUMNS | YES |  | Carbondata will generate BloomFilter index on these columns. Queries on there columns are usually like 'COL = VAL'. |\n-| BLOOM_SIZE | NO | 32000 | This value is internally used by BloomFilter as the number of expected insertions, it will affects the size of BloomFilter index. Since each blocklet has a BloomFilter here, so the value is the approximate records in a blocklet. In another word, the value 32000 * #noOfPagesInBlocklet. The value should be an integer. |\n-| BLOOM_FPP | NO | 0.01 | This value is internally used by BloomFilter as the False-Positive Probability, it will affects the size of bloomfilter index as well as the number of hash functions for the BloomFilter. The value should be in range (0, 1). |\n+| BLOOM_SIZE | NO | 640000 | This value is internally used by BloomFilter as the number of expected insertions, it will affects the size of BloomFilter index. Since each blocklet has a BloomFilter here, so the value is the approximate records in a blocklet. In another word, the value 32000 * #noOfPagesInBlocklet. The value should be an integer. |","path":"docs/datamap/bloomfilter-datamap-guide.md","position":6,"original_position":6,"commit_id":"d8d582d24d79792e8279734f01b6660a4f0aba97","original_commit_id":"d8d582d24d79792e8279734f01b6660a4f0aba97","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"body":"OK， changed it to\r\n```\r\nso the default value is the approximate distinct index values in a blocklet assuming the blocklet size is 20 pages and each page contains 32000 records.\r\n```","created_at":"2018-07-31T09:37:47Z","updated_at":"2018-07-31T09:37:47Z","html_url":"https://github.com/apache/carbondata/pull/2567#discussion_r206459733","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2567","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/206459733"},"html":{"href":"https://github.com/apache/carbondata/pull/2567#discussion_r206459733"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2567"}},"in_reply_to_id":206416298},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2567","id":204324390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzI0Mzkw","html_url":"https://github.com/apache/carbondata/pull/2567","diff_url":"https://github.com/apache/carbondata/pull/2567.diff","patch_url":"https://github.com/apache/carbondata/pull/2567.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2567","number":2567,"state":"open","locked":false,"title":"[CARBONDATA-2790][BloomDataMap]Optimize default parameter for bloomfilter datamap","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"body":"To provide better query performance for bloomfilter datamap by default,\r\nwe optimize bloom_size from 32000 to 640000 and optimize bloom_fpp from\r\n0.01 to 0.00001.\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [ ] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2018-07-27T04:05:16Z","updated_at":"2018-07-31T09:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd6a5e0b0a28b19a3daa3ab5ef9581ca6d8b205","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2567/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2567/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2567/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/d8d582d24d79792e8279734f01b6660a4f0aba97","head":{"label":"xuchuanyin:0727_bloom_default_para","ref":"0727_bloom_default_para","sha":"d8d582d24d79792e8279734f01b6660a4f0aba97","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"repo":{"id":101835130,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MzUxMzA=","name":"carbondata","full_name":"xuchuanyin/carbondata","owner":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuchuanyin/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/xuchuanyin/carbondata","forks_url":"https://api.github.com/repos/xuchuanyin/carbondata/forks","keys_url":"https://api.github.com/repos/xuchuanyin/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuchuanyin/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuchuanyin/carbondata/teams","hooks_url":"https://api.github.com/repos/xuchuanyin/carbondata/hooks","issue_events_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/xuchuanyin/carbondata/events","assignees_url":"https://api.github.com/repos/xuchuanyin/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/xuchuanyin/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/xuchuanyin/carbondata/tags","blobs_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuchuanyin/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/xuchuanyin/carbondata/languages","stargazers_url":"https://api.github.com/repos/xuchuanyin/carbondata/stargazers","contributors_url":"https://api.github.com/repos/xuchuanyin/carbondata/contributors","subscribers_url":"https://api.github.com/repos/xuchuanyin/carbondata/subscribers","subscription_url":"https://api.github.com/repos/xuchuanyin/carbondata/subscription","commits_url":"https://api.github.com/repos/xuchuanyin/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuchuanyin/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuchuanyin/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/xuchuanyin/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuchuanyin/carbondata/merges","archive_url":"https://api.github.com/repos/xuchuanyin/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuchuanyin/carbondata/downloads","issues_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/xuchuanyin/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/xuchuanyin/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/xuchuanyin/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuchuanyin/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/xuchuanyin/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/xuchuanyin/carbondata/deployments","created_at":"2017-08-30T03:49:15Z","updated_at":"2018-07-28T14:23:58Z","pushed_at":"2018-07-31T09:30:54Z","git_url":"git://github.com/xuchuanyin/carbondata.git","ssh_url":"git@github.com:xuchuanyin/carbondata.git","clone_url":"https://github.com/xuchuanyin/carbondata.git","svn_url":"https://github.com/xuchuanyin/carbondata","homepage":"","size":61430,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c79fc90d5d9804d65aea8d363f2249b12696aef0","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-07-31T08:09:33Z","pushed_at":"2018-07-31T09:30:56Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":61170,"stargazers_count":719,"watchers_count":719,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":444,"open_issues":98,"watchers":719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2567"},"html":{"href":"https://github.com/apache/carbondata/pull/2567"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2567"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2567/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2567/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2567/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/d8d582d24d79792e8279734f01b6660a4f0aba97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xuchuanyin"}}