{"action":"created","comment":{"url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/comments/184052717","pull_request_review_id":115168465,"id":184052717,"diff_hunk":"@@ -0,0 +1,39 @@\n+Value MODULE (0\\/(FT|PM)\\d)","path":"templates/cisco_xr_admin_show_environment_fan.template","position":1,"original_position":1,"commit_id":"d0ec6d8bb45229768a8c74a6bc9bfa6ae3c45c3f","original_commit_id":"d0ec6d8bb45229768a8c74a6bc9bfa6ae3c45c3f","user":{"login":"itdependsnetworks","id":9260483,"avatar_url":"https://avatars3.githubusercontent.com/u/9260483?v=4","gravatar_id":"","url":"https://api.github.com/users/itdependsnetworks","html_url":"https://github.com/itdependsnetworks","followers_url":"https://api.github.com/users/itdependsnetworks/followers","following_url":"https://api.github.com/users/itdependsnetworks/following{/other_user}","gists_url":"https://api.github.com/users/itdependsnetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/itdependsnetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itdependsnetworks/subscriptions","organizations_url":"https://api.github.com/users/itdependsnetworks/orgs","repos_url":"https://api.github.com/users/itdependsnetworks/repos","events_url":"https://api.github.com/users/itdependsnetworks/events{/privacy}","received_events_url":"https://api.github.com/users/itdependsnetworks/received_events","type":"User","site_admin":false},"body":"To an extent yes, to an extent no :) \r\n\r\nLooking at the data, it doesn't seem like that would cover all future use cases. You are fairly well protected here in that you properly transition state to `FM`, after which I think it's a safe assumption that this is the only thing that would fit, and not be a false positive.","created_at":"2018-04-25T13:13:06Z","updated_at":"2018-04-25T13:13:06Z","html_url":"https://github.com/networktocode/ntc-templates/pull/184#discussion_r184052717","pull_request_url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/comments/184052717"},"html":{"href":"https://github.com/networktocode/ntc-templates/pull/184#discussion_r184052717"},"pull_request":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184"}},"in_reply_to_id":182470617},"pull_request":{"url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184","id":174320762,"html_url":"https://github.com/networktocode/ntc-templates/pull/184","diff_url":"https://github.com/networktocode/ntc-templates/pull/184.diff","patch_url":"https://github.com/networktocode/ntc-templates/pull/184.patch","issue_url":"https://api.github.com/repos/networktocode/ntc-templates/issues/184","number":184,"state":"open","locked":false,"title":"added template for cisco xr : \"admin show environment fan\" ,\"admin show vm\" and \"show version\"","user":{"login":"rishabh5j","id":13395827,"avatar_url":"https://avatars2.githubusercontent.com/u/13395827?v=4","gravatar_id":"","url":"https://api.github.com/users/rishabh5j","html_url":"https://github.com/rishabh5j","followers_url":"https://api.github.com/users/rishabh5j/followers","following_url":"https://api.github.com/users/rishabh5j/following{/other_user}","gists_url":"https://api.github.com/users/rishabh5j/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh5j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh5j/subscriptions","organizations_url":"https://api.github.com/users/rishabh5j/orgs","repos_url":"https://api.github.com/users/rishabh5j/repos","events_url":"https://api.github.com/users/rishabh5j/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh5j/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n - New Template Pull Request\r\n\r\n##### COMPONENT\r\ncisco_xr_admin_show_environment_fan.template\r\ncisco_xr_admin_show_vm.template\r\ncisco_xr_show_version.template\r\n\r\n##### SUMMARY\r\nAdded template cisco_xr_admin_show_environment_fan.template\r\nAdded template cisco_xr_admin_show_vm.template , \r\nAdded template cisco_xr_show_version.template ,\r\nModified the index \r\nAdded tests for all three\r\n\r\n```\r\n","created_at":"2018-03-12T10:07:29Z","updated_at":"2018-04-25T13:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34e03e2d0bf27adef4314ed3808dc5dfc191e3e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184/commits","review_comments_url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184/comments","review_comment_url":"https://api.github.com/repos/networktocode/ntc-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/networktocode/ntc-templates/issues/184/comments","statuses_url":"https://api.github.com/repos/networktocode/ntc-templates/statuses/d0ec6d8bb45229768a8c74a6bc9bfa6ae3c45c3f","head":{"label":"rishabh5j:xr","ref":"xr","sha":"d0ec6d8bb45229768a8c74a6bc9bfa6ae3c45c3f","user":{"login":"rishabh5j","id":13395827,"avatar_url":"https://avatars2.githubusercontent.com/u/13395827?v=4","gravatar_id":"","url":"https://api.github.com/users/rishabh5j","html_url":"https://github.com/rishabh5j","followers_url":"https://api.github.com/users/rishabh5j/followers","following_url":"https://api.github.com/users/rishabh5j/following{/other_user}","gists_url":"https://api.github.com/users/rishabh5j/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh5j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh5j/subscriptions","organizations_url":"https://api.github.com/users/rishabh5j/orgs","repos_url":"https://api.github.com/users/rishabh5j/repos","events_url":"https://api.github.com/users/rishabh5j/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh5j/received_events","type":"User","site_admin":false},"repo":{"id":124867716,"name":"ntc-templates","full_name":"rishabh5j/ntc-templates","owner":{"login":"rishabh5j","id":13395827,"avatar_url":"https://avatars2.githubusercontent.com/u/13395827?v=4","gravatar_id":"","url":"https://api.github.com/users/rishabh5j","html_url":"https://github.com/rishabh5j","followers_url":"https://api.github.com/users/rishabh5j/followers","following_url":"https://api.github.com/users/rishabh5j/following{/other_user}","gists_url":"https://api.github.com/users/rishabh5j/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh5j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh5j/subscriptions","organizations_url":"https://api.github.com/users/rishabh5j/orgs","repos_url":"https://api.github.com/users/rishabh5j/repos","events_url":"https://api.github.com/users/rishabh5j/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh5j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rishabh5j/ntc-templates","description":"TextFSM templates for parsing show commands of network devices","fork":true,"url":"https://api.github.com/repos/rishabh5j/ntc-templates","forks_url":"https://api.github.com/repos/rishabh5j/ntc-templates/forks","keys_url":"https://api.github.com/repos/rishabh5j/ntc-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rishabh5j/ntc-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rishabh5j/ntc-templates/teams","hooks_url":"https://api.github.com/repos/rishabh5j/ntc-templates/hooks","issue_events_url":"https://api.github.com/repos/rishabh5j/ntc-templates/issues/events{/number}","events_url":"https://api.github.com/repos/rishabh5j/ntc-templates/events","assignees_url":"https://api.github.com/repos/rishabh5j/ntc-templates/assignees{/user}","branches_url":"https://api.github.com/repos/rishabh5j/ntc-templates/branches{/branch}","tags_url":"https://api.github.com/repos/rishabh5j/ntc-templates/tags","blobs_url":"https://api.github.com/repos/rishabh5j/ntc-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rishabh5j/ntc-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rishabh5j/ntc-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/rishabh5j/ntc-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rishabh5j/ntc-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/rishabh5j/ntc-templates/languages","stargazers_url":"https://api.github.com/repos/rishabh5j/ntc-templates/stargazers","contributors_url":"https://api.github.com/repos/rishabh5j/ntc-templates/contributors","subscribers_url":"https://api.github.com/repos/rishabh5j/ntc-templates/subscribers","subscription_url":"https://api.github.com/repos/rishabh5j/ntc-templates/subscription","commits_url":"https://api.github.com/repos/rishabh5j/ntc-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/rishabh5j/ntc-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/rishabh5j/ntc-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/rishabh5j/ntc-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/rishabh5j/ntc-templates/contents/{+path}","compare_url":"https://api.github.com/repos/rishabh5j/ntc-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rishabh5j/ntc-templates/merges","archive_url":"https://api.github.com/repos/rishabh5j/ntc-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rishabh5j/ntc-templates/downloads","issues_url":"https://api.github.com/repos/rishabh5j/ntc-templates/issues{/number}","pulls_url":"https://api.github.com/repos/rishabh5j/ntc-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/rishabh5j/ntc-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/rishabh5j/ntc-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rishabh5j/ntc-templates/labels{/name}","releases_url":"https://api.github.com/repos/rishabh5j/ntc-templates/releases{/id}","deployments_url":"https://api.github.com/repos/rishabh5j/ntc-templates/deployments","created_at":"2018-03-12T09:51:04Z","updated_at":"2018-03-12T09:51:07Z","pushed_at":"2018-04-25T12:34:11Z","git_url":"git://github.com/rishabh5j/ntc-templates.git","ssh_url":"git@github.com:rishabh5j/ntc-templates.git","clone_url":"https://github.com/rishabh5j/ntc-templates.git","svn_url":"https://github.com/rishabh5j/ntc-templates","homepage":null,"size":656,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"networktocode:master","ref":"master","sha":"f5fb01e9809dd6e4019ebeaf88e8ada5455c0697","user":{"login":"networktocode","id":13106404,"avatar_url":"https://avatars0.githubusercontent.com/u/13106404?v=4","gravatar_id":"","url":"https://api.github.com/users/networktocode","html_url":"https://github.com/networktocode","followers_url":"https://api.github.com/users/networktocode/followers","following_url":"https://api.github.com/users/networktocode/following{/other_user}","gists_url":"https://api.github.com/users/networktocode/gists{/gist_id}","starred_url":"https://api.github.com/users/networktocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/networktocode/subscriptions","organizations_url":"https://api.github.com/users/networktocode/orgs","repos_url":"https://api.github.com/users/networktocode/repos","events_url":"https://api.github.com/users/networktocode/events{/privacy}","received_events_url":"https://api.github.com/users/networktocode/received_events","type":"Organization","site_admin":false},"repo":{"id":57225950,"name":"ntc-templates","full_name":"networktocode/ntc-templates","owner":{"login":"networktocode","id":13106404,"avatar_url":"https://avatars0.githubusercontent.com/u/13106404?v=4","gravatar_id":"","url":"https://api.github.com/users/networktocode","html_url":"https://github.com/networktocode","followers_url":"https://api.github.com/users/networktocode/followers","following_url":"https://api.github.com/users/networktocode/following{/other_user}","gists_url":"https://api.github.com/users/networktocode/gists{/gist_id}","starred_url":"https://api.github.com/users/networktocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/networktocode/subscriptions","organizations_url":"https://api.github.com/users/networktocode/orgs","repos_url":"https://api.github.com/users/networktocode/repos","events_url":"https://api.github.com/users/networktocode/events{/privacy}","received_events_url":"https://api.github.com/users/networktocode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/networktocode/ntc-templates","description":"TextFSM templates for parsing show commands of network devices","fork":false,"url":"https://api.github.com/repos/networktocode/ntc-templates","forks_url":"https://api.github.com/repos/networktocode/ntc-templates/forks","keys_url":"https://api.github.com/repos/networktocode/ntc-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/networktocode/ntc-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/networktocode/ntc-templates/teams","hooks_url":"https://api.github.com/repos/networktocode/ntc-templates/hooks","issue_events_url":"https://api.github.com/repos/networktocode/ntc-templates/issues/events{/number}","events_url":"https://api.github.com/repos/networktocode/ntc-templates/events","assignees_url":"https://api.github.com/repos/networktocode/ntc-templates/assignees{/user}","branches_url":"https://api.github.com/repos/networktocode/ntc-templates/branches{/branch}","tags_url":"https://api.github.com/repos/networktocode/ntc-templates/tags","blobs_url":"https://api.github.com/repos/networktocode/ntc-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/networktocode/ntc-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/networktocode/ntc-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/networktocode/ntc-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/networktocode/ntc-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/networktocode/ntc-templates/languages","stargazers_url":"https://api.github.com/repos/networktocode/ntc-templates/stargazers","contributors_url":"https://api.github.com/repos/networktocode/ntc-templates/contributors","subscribers_url":"https://api.github.com/repos/networktocode/ntc-templates/subscribers","subscription_url":"https://api.github.com/repos/networktocode/ntc-templates/subscription","commits_url":"https://api.github.com/repos/networktocode/ntc-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/networktocode/ntc-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/networktocode/ntc-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/networktocode/ntc-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/networktocode/ntc-templates/contents/{+path}","compare_url":"https://api.github.com/repos/networktocode/ntc-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/networktocode/ntc-templates/merges","archive_url":"https://api.github.com/repos/networktocode/ntc-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/networktocode/ntc-templates/downloads","issues_url":"https://api.github.com/repos/networktocode/ntc-templates/issues{/number}","pulls_url":"https://api.github.com/repos/networktocode/ntc-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/networktocode/ntc-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/networktocode/ntc-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/networktocode/ntc-templates/labels{/name}","releases_url":"https://api.github.com/repos/networktocode/ntc-templates/releases{/id}","deployments_url":"https://api.github.com/repos/networktocode/ntc-templates/deployments","created_at":"2016-04-27T15:49:07Z","updated_at":"2018-04-10T15:28:22Z","pushed_at":"2018-04-25T12:43:27Z","git_url":"git://github.com/networktocode/ntc-templates.git","ssh_url":"git@github.com:networktocode/ntc-templates.git","clone_url":"https://github.com/networktocode/ntc-templates.git","svn_url":"https://github.com/networktocode/ntc-templates","homepage":null,"size":627,"stargazers_count":142,"watchers_count":142,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":76,"open_issues":27,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184"},"html":{"href":"https://github.com/networktocode/ntc-templates/pull/184"},"issue":{"href":"https://api.github.com/repos/networktocode/ntc-templates/issues/184"},"comments":{"href":"https://api.github.com/repos/networktocode/ntc-templates/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/networktocode/ntc-templates/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/networktocode/ntc-templates/statuses/d0ec6d8bb45229768a8c74a6bc9bfa6ae3c45c3f"}},"author_association":"NONE"}}
{"actor":{"display_login":"itdependsnetworks"}}