{"action":"created","issue":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4437","repository_url":"https://api.github.com/repos/pioneerspacesim/pioneer","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4437/labels{/name}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4437/comments","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4437/events","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4437","id":357471561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDc3MTU1","number":4437,"title":"Update bundled IMGUI to v1.64","user":{"login":"Web-eWorks","id":4218491,"node_id":"MDQ6VXNlcjQyMTg0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4218491?v=4","gravatar_id":"","url":"https://api.github.com/users/Web-eWorks","html_url":"https://github.com/Web-eWorks","followers_url":"https://api.github.com/users/Web-eWorks/followers","following_url":"https://api.github.com/users/Web-eWorks/following{/other_user}","gists_url":"https://api.github.com/users/Web-eWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/Web-eWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Web-eWorks/subscriptions","organizations_url":"https://api.github.com/users/Web-eWorks/orgs","repos_url":"https://api.github.com/users/Web-eWorks/repos","events_url":"https://api.github.com/users/Web-eWorks/events{/privacy}","received_events_url":"https://api.github.com/users/Web-eWorks/received_events","type":"User","site_admin":false},"labels":[{"id":6632503,"node_id":"MDU6TGFiZWw2NjMyNTAz","url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels/WIP","name":"WIP","color":"444444","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-09-06T02:19:20Z","updated_at":"2018-09-10T05:34:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/4437","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4437","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/4437.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/4437.patch"},"body":"This PR supersedes #4317, as it actually gets IMGUI rendering again.\r\n\r\nDue to changes in how WindowBorders work, the \"ShowBorders\" flag has been removed, and will need to be replaced with code that sets the StyleVar \"WindowBorderSize\". In addition, the styling has changed enough that some windows render scrollbars where they should not - the main menu progress bar, for one.\r\n\r\nThe `ImGui::IO.KeysDown` vector is using SDL_Scancode instead of SDL_Keycode - this was changed upstream. Use `SDL_GetKeycodeFromScancode` or `SDL_GetScancodeFromKeycode` if you need to swap between the two.\r\n\r\nThe radial menu is currently non-optimal - when it opens, the cursor snaps to the middle of the screen (usually causing an item to be hovered), and it's position is used to calculate the radial rather than the relative movement.\r\n\r\nOtherwise, I believe everything works currently, though I would appreciate it if numerous people could test this PR. "},"comment":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments/419791983","html_url":"https://github.com/pioneerspacesim/pioneer/pull/4437#issuecomment-419791983","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/4437","id":419791983,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTc5MTk4Mw==","user":{"login":"ecraven","id":215510,"node_id":"MDQ6VXNlcjIxNTUxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/215510?v=4","gravatar_id":"","url":"https://api.github.com/users/ecraven","html_url":"https://github.com/ecraven","followers_url":"https://api.github.com/users/ecraven/followers","following_url":"https://api.github.com/users/ecraven/following{/other_user}","gists_url":"https://api.github.com/users/ecraven/gists{/gist_id}","starred_url":"https://api.github.com/users/ecraven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecraven/subscriptions","organizations_url":"https://api.github.com/users/ecraven/orgs","repos_url":"https://api.github.com/users/ecraven/repos","events_url":"https://api.github.com/users/ecraven/events{/privacy}","received_events_url":"https://api.github.com/users/ecraven/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T05:34:36Z","updated_at":"2018-09-10T05:34:36Z","author_association":"CONTRIBUTOR","body":"@Web-eWorks can you please split this into one commit with upstream imgui, then one or more commits with our changes? The way it is now it's impossible to see which changes are local and which are due to upstream's update.\r\nThanks!"}}
{"actor":{"display_login":"ecraven"}}