{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr-android/pulls/comments/237183550","pull_request_review_id":179420677,"id":237183550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE4MzU1MA==","diff_hunk":"@@ -122,63 +100,174 @@ open class PlayerTest {\n         player.configure(Options(source = \"valid\"))\n         assertEquals(\"invalid state (not NONE)\", Player.State.NONE, player.state)\n \n-        val testPlayback = player.core?.activePlayback as PlayerTestPlayback\n-\n-        testPlayback.internalState = Playback.State.ERROR\n+        PlayerTestPlayback.internalState = Playback.State.ERROR\n         assertEquals(\"invalid state (not ERROR)\", Player.State.ERROR, player.state)\n-        testPlayback.internalState = Playback.State.IDLE\n+        PlayerTestPlayback.internalState = Playback.State.IDLE\n         assertEquals(\"invalid state (not IDLE)\", Player.State.IDLE, player.state)\n-        testPlayback.internalState = Playback.State.PAUSED\n+        PlayerTestPlayback.internalState = Playback.State.PAUSED\n         assertEquals(\"invalid state (not PAUSED)\", Player.State.PAUSED, player.state)\n-        testPlayback.internalState = Playback.State.PLAYING\n+        PlayerTestPlayback.internalState = Playback.State.PLAYING\n         assertEquals(\"invalid state (not PLAYING)\", Player.State.PLAYING, player.state)\n-        testPlayback.internalState = Playback.State.STALLING\n+        PlayerTestPlayback.internalState = Playback.State.STALLING\n         assertEquals(\"invalid state (not STALLING)\", Player.State.STALLING, player.state)\n     }\n \n     @Test\n     fun shouldUnbindOnConfigure() {\n         var willPauseCalled = false\n         var didPauseCalled = false\n+\n         player.on(Event.WILL_PAUSE.value, Callback.wrap { willPauseCalled = true })\n         player.on(Event.DID_PAUSE.value, Callback.wrap { didPauseCalled = true })\n \n         player.configure(Options(source = \"valid\"))\n-\n-        val oldCore = player.core\n-\n         player.configure(Options(source = \"\"))\n \n-        oldCore!!.activePlayback?.pause()\n+        player.pause()\n \n         assertFalse(\"WILL_PAUSE triggered\", willPauseCalled)\n         assertFalse(\"DID_PAUSE triggered\", didPauseCalled)\n     }\n \n+    /************************************* DISCLAIMER ***********************************************\n+     * The following tests use unconventional methods to test core related behaviours in the Player\n+     * class. Since now the core is protected in Player we can no longer use it to test some\n+     * behaviours. To ensure testability we should inject core in the Player and not create it\n+     * there. Until we change our architecture, to maintain the same tests we use some plugins and\n+     * send some events with data that will normally not be sent. To be easier to understand each\n+     * test we tried to explain it and add some comments.\n+     ***********************************************************************************************/\n+\n+    /**\n+     * To be able to test the change in the Options we make the PlayerTestPlayback return in its\n+     * position attribute the START_AT option. Then we call the configure method twice\n+     * with different START_AT configurations and check if the change was successful. With this\n+     * method we can check if the core passed on the options to Playback, that way we ensure that we\n+     * are changing the options when we call two consecutives configures.\n+     */\n     @Test\n-    fun shouldCoreHaveSameInstanceOnPlayerConfigure() {\n-        player.configure(Options(source = \"valid\"))\n-        val expectedCore = player.core\n-        player.configure(Options(source = \"\"))\n+    fun shouldCoreChangeOptionsOnPlayerConfigure() {\n+        val expectedFirstStartAtOption = 10.0\n+        val expectedSecondStartAtOption = 5.0\n+\n+        player.configure(Options(source= \"valid\",\n+                options = hashMapOf(ClapprOption.START_AT.value to expectedFirstStartAtOption)))\n+        // Check the START_AT option using the PlayerTestPlayback position attribute\n+        assertEquals(expectedFirstStartAtOption.toInt(), player.position.toInt())\n+\n+        player.configure(Options(source= \"valid\",\n+                options = hashMapOf(ClapprOption.START_AT.value to expectedSecondStartAtOption)))\n+        // Ensure the START_AT option changed using the PlayerTestPlayback position attribute\n+        assertEquals(expectedSecondStartAtOption.toInt(), player.position.toInt())\n+    }\n \n-        assertSame(expectedCore, player.core)\n+    /**\n+     * This test use the PlayerTestPlayback to send by Bundle in the WILL_PLAY event the current\n+     * source passed by options. Since the core is protected we can't check if it received the\n+     * correct options, but with this method we can check if the core passed on the options to\n+     * Playback, that way we ensure that we are changing the options when we call a load before\n+     * a configure.\n+     */\n+    @Test\n+    fun shouldCoreChangeOptionsOnPlayerLoad() {\n+        val expectedFirstSource = \"source\"\n+        val expectedSecondSource = \"other-source\"\n+\n+        // Listen for WILL_PLAY event to receive current source\n+        var sourceToPlay = \"\"\n+        player.on(Event.WILL_PLAY.value, Callback.wrap { bundle ->\n+            bundle?.let {\n+                sourceToPlay = it.getString(\"source\")\n+            }\n+        })\n+\n+        player.configure(Options(source=expectedFirstSource))\n+        // Trigger WILL_PLAY in PlayerTestPlayback that will send by Bundle the current source\n+        player.play()\n+        // Check if this source is the same passed in configure\n+        assertEquals(expectedFirstSource, sourceToPlay)\n+\n+        player.load(source=expectedSecondSource)\n+        // Trigger WILL_PLAY in PlayerTestPlayback that will send by Bundle the current source\n+        player.play()\n+        // Check if this source is the same passed in load\n+        assertEquals(expectedSecondSource, sourceToPlay)\n     }\n \n+    /**\n+     * This test use the CoreTestPlugin to send by Error event the core hash code. That way we can\n+     * compare the hash between two configures performed in Player, ensuring that the same core instance\n+     * is used between configures. To force the CoreTestPlugin to send the error event we trigger a\n+     * WILL_PLAY event when the Playback play is called using the PlayerTestPlayback.\n+     */\n     @Test\n-    fun shouldCoreChangeOptionsOnPlayerConfigure() {\n-        player.configure(Options(source = \"valid\"))\n-        val expectedSource = \"new source\"\n-        player.configure(Options(expectedSource))\n+    fun shouldCoreHaveSameInstanceOnPlayerConfigure() {\n+        val expectedDistinctHashCode = 1\n+\n+        // Listen for ERROR event to receive core hash code\n+        val coreHashCode = mutableSetOf<Int>()\n+        player.on(Event.ERROR.value, Callback.wrap { bundle ->\n+            bundle?.let { coreHashCode.add(it.getInt(\"coreHashCode\")) }","path":"clappr/src/test/kotlin/io/clappr/player/PlayerTest.kt","position":null,"original_position":191,"commit_id":"cc9bc271adaba2467a4dcd9b6c912ddbbe47fdef","original_commit_id":"f6dc8b8ffeb616cee66180a63814c0dc854aa10d","user":{"login":"arthursz","id":6000680,"node_id":"MDQ6VXNlcjYwMDA2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6000680?v=4","gravatar_id":"","url":"https://api.github.com/users/arthursz","html_url":"https://github.com/arthursz","followers_url":"https://api.github.com/users/arthursz/followers","following_url":"https://api.github.com/users/arthursz/following{/other_user}","gists_url":"https://api.github.com/users/arthursz/gists{/gist_id}","starred_url":"https://api.github.com/users/arthursz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthursz/subscriptions","organizations_url":"https://api.github.com/users/arthursz/orgs","repos_url":"https://api.github.com/users/arthursz/repos","events_url":"https://api.github.com/users/arthursz/events{/privacy}","received_events_url":"https://api.github.com/users/arthursz/received_events","type":"User","site_admin":false},"body":"Done in cc9bc27","created_at":"2018-11-28T17:23:24Z","updated_at":"2018-11-28T17:23:24Z","html_url":"https://github.com/clappr/clappr-android/pull/159#discussion_r237183550","pull_request_url":"https://api.github.com/repos/clappr/clappr-android/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/comments/237183550"},"html":{"href":"https://github.com/clappr/clappr-android/pull/159#discussion_r237183550"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/159"}},"in_reply_to_id":236808255},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr-android/pulls/159","id":233674152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjc0MTUy","html_url":"https://github.com/clappr/clappr-android/pull/159","diff_url":"https://github.com/clappr/clappr-android/pull/159.diff","patch_url":"https://github.com/clappr/clappr-android/pull/159.patch","issue_url":"https://api.github.com/repos/clappr/clappr-android/issues/159","number":159,"state":"open","locked":false,"title":"Change core visibility in player","user":{"login":"daianefreira","id":969604,"node_id":"MDQ6VXNlcjk2OTYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/969604?v=4","gravatar_id":"","url":"https://api.github.com/users/daianefreira","html_url":"https://github.com/daianefreira","followers_url":"https://api.github.com/users/daianefreira/followers","following_url":"https://api.github.com/users/daianefreira/following{/other_user}","gists_url":"https://api.github.com/users/daianefreira/gists{/gist_id}","starred_url":"https://api.github.com/users/daianefreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daianefreira/subscriptions","organizations_url":"https://api.github.com/users/daianefreira/orgs","repos_url":"https://api.github.com/users/daianefreira/repos","events_url":"https://api.github.com/users/daianefreira/events{/privacy}","received_events_url":"https://api.github.com/users/daianefreira/received_events","type":"User","site_admin":false},"body":"Goal\r\nChange core visibility in player\r\n\r\nHow to test\r\n1 - Run Unit tests\r\n2 - Open sample app\r\n3 - Check if video everything is working correctly, play/pause the video, perform seek, wait for it to finish and play it again, go fullscreen and back to portrait","created_at":"2018-11-26T19:42:43Z","updated_at":"2018-11-28T17:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d04a9ee65de6fe8252cecee8ce3ed7565de41876","assignee":{"login":"daianefreira","id":969604,"node_id":"MDQ6VXNlcjk2OTYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/969604?v=4","gravatar_id":"","url":"https://api.github.com/users/daianefreira","html_url":"https://github.com/daianefreira","followers_url":"https://api.github.com/users/daianefreira/followers","following_url":"https://api.github.com/users/daianefreira/following{/other_user}","gists_url":"https://api.github.com/users/daianefreira/gists{/gist_id}","starred_url":"https://api.github.com/users/daianefreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daianefreira/subscriptions","organizations_url":"https://api.github.com/users/daianefreira/orgs","repos_url":"https://api.github.com/users/daianefreira/repos","events_url":"https://api.github.com/users/daianefreira/events{/privacy}","received_events_url":"https://api.github.com/users/daianefreira/received_events","type":"User","site_admin":false},"assignees":[{"login":"daianefreira","id":969604,"node_id":"MDQ6VXNlcjk2OTYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/969604?v=4","gravatar_id":"","url":"https://api.github.com/users/daianefreira","html_url":"https://github.com/daianefreira","followers_url":"https://api.github.com/users/daianefreira/followers","following_url":"https://api.github.com/users/daianefreira/following{/other_user}","gists_url":"https://api.github.com/users/daianefreira/gists{/gist_id}","starred_url":"https://api.github.com/users/daianefreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daianefreira/subscriptions","organizations_url":"https://api.github.com/users/daianefreira/orgs","repos_url":"https://api.github.com/users/daianefreira/repos","events_url":"https://api.github.com/users/daianefreira/events{/privacy}","received_events_url":"https://api.github.com/users/daianefreira/received_events","type":"User","site_admin":false},{"login":"arthursz","id":6000680,"node_id":"MDQ6VXNlcjYwMDA2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6000680?v=4","gravatar_id":"","url":"https://api.github.com/users/arthursz","html_url":"https://github.com/arthursz","followers_url":"https://api.github.com/users/arthursz/followers","following_url":"https://api.github.com/users/arthursz/following{/other_user}","gists_url":"https://api.github.com/users/arthursz/gists{/gist_id}","starred_url":"https://api.github.com/users/arthursz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthursz/subscriptions","organizations_url":"https://api.github.com/users/arthursz/orgs","repos_url":"https://api.github.com/users/arthursz/repos","events_url":"https://api.github.com/users/arthursz/events{/privacy}","received_events_url":"https://api.github.com/users/arthursz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":500170248,"node_id":"MDU6TGFiZWw1MDAxNzAyNDg=","url":"https://api.github.com/repos/clappr/clappr-android/labels/done","name":"done","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr-android/pulls/159/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr-android/pulls/159/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr-android/issues/159/comments","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/cc9bc271adaba2467a4dcd9b6c912ddbbe47fdef","head":{"label":"clappr:feature/player_visibility","ref":"feature/player_visibility","sha":"cc9bc271adaba2467a4dcd9b6c912ddbbe47fdef","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22734795,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNDc5NQ==","name":"clappr-android","full_name":"clappr/clappr-android","private":false,"owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clappr/clappr-android","description":"An extensible media player for Android.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-android","forks_url":"https://api.github.com/repos/clappr/clappr-android/forks","keys_url":"https://api.github.com/repos/clappr/clappr-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-android/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-android/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-android/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-android/events","assignees_url":"https://api.github.com/repos/clappr/clappr-android/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-android/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-android/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-android/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-android/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-android/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-android/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-android/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-android/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-android/merges","archive_url":"https://api.github.com/repos/clappr/clappr-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-android/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-android/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-android/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-android/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-android/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-android/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-android/deployments","created_at":"2014-08-07T20:01:54Z","updated_at":"2018-11-23T13:38:38Z","pushed_at":"2018-11-28T17:21:53Z","git_url":"git://github.com/clappr/clappr-android.git","ssh_url":"git@github.com:clappr/clappr-android.git","clone_url":"https://github.com/clappr/clappr-android.git","svn_url":"https://github.com/clappr/clappr-android","homepage":null,"size":1530,"stargazers_count":50,"watchers_count":50,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":16,"open_issues":7,"watchers":50,"default_branch":"dev"}},"base":{"label":"clappr:dev","ref":"dev","sha":"1f99e2e1b8fa8d27140ada1813301a137c1d21c6","user":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":22734795,"node_id":"MDEwOlJlcG9zaXRvcnkyMjczNDc5NQ==","name":"clappr-android","full_name":"clappr/clappr-android","private":false,"owner":{"login":"clappr","id":10685859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjg1ODU5","avatar_url":"https://avatars1.githubusercontent.com/u/10685859?v=4","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/clappr/clappr-android","description":"An extensible media player for Android.","fork":false,"url":"https://api.github.com/repos/clappr/clappr-android","forks_url":"https://api.github.com/repos/clappr/clappr-android/forks","keys_url":"https://api.github.com/repos/clappr/clappr-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr-android/teams","hooks_url":"https://api.github.com/repos/clappr/clappr-android/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr-android/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr-android/events","assignees_url":"https://api.github.com/repos/clappr/clappr-android/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr-android/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr-android/tags","blobs_url":"https://api.github.com/repos/clappr/clappr-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr-android/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr-android/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr-android/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr-android/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr-android/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr-android/subscription","commits_url":"https://api.github.com/repos/clappr/clappr-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr-android/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr-android/merges","archive_url":"https://api.github.com/repos/clappr/clappr-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr-android/downloads","issues_url":"https://api.github.com/repos/clappr/clappr-android/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr-android/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr-android/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr-android/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr-android/releases{/id}","deployments_url":"https://api.github.com/repos/clappr/clappr-android/deployments","created_at":"2014-08-07T20:01:54Z","updated_at":"2018-11-23T13:38:38Z","pushed_at":"2018-11-28T17:21:53Z","git_url":"git://github.com/clappr/clappr-android.git","ssh_url":"git@github.com:clappr/clappr-android.git","clone_url":"https://github.com/clappr/clappr-android.git","svn_url":"https://github.com/clappr/clappr-android","homepage":null,"size":1530,"stargazers_count":50,"watchers_count":50,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":16,"open_issues":7,"watchers":50,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/159"},"html":{"href":"https://github.com/clappr/clappr-android/pull/159"},"issue":{"href":"https://api.github.com/repos/clappr/clappr-android/issues/159"},"comments":{"href":"https://api.github.com/repos/clappr/clappr-android/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr-android/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr-android/statuses/cc9bc271adaba2467a4dcd9b6c912ddbbe47fdef"}},"author_association":"NONE"}}
{"actor":{"display_login":"arthursz"}}