{"action":"created","issue":{"url":"https://api.github.com/repos/fluid-project/infusion/issues/927","repository_url":"https://api.github.com/repos/fluid-project/infusion","labels_url":"https://api.github.com/repos/fluid-project/infusion/issues/927/labels{/name}","comments_url":"https://api.github.com/repos/fluid-project/infusion/issues/927/comments","events_url":"https://api.github.com/repos/fluid-project/infusion/issues/927/events","html_url":"https://github.com/fluid-project/infusion/pull/927","id":352890685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDg1ODk3","number":927,"title":"Add SKIP_NODE_MODULES_BIND_MOUNT env var to Vagrantfile","user":{"login":"gtirloni","id":5902830,"node_id":"MDQ6VXNlcjU5MDI4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/5902830?v=4","gravatar_id":"","url":"https://api.github.com/users/gtirloni","html_url":"https://github.com/gtirloni","followers_url":"https://api.github.com/users/gtirloni/followers","following_url":"https://api.github.com/users/gtirloni/following{/other_user}","gists_url":"https://api.github.com/users/gtirloni/gists{/gist_id}","starred_url":"https://api.github.com/users/gtirloni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtirloni/subscriptions","organizations_url":"https://api.github.com/users/gtirloni/orgs","repos_url":"https://api.github.com/users/gtirloni/repos","events_url":"https://api.github.com/users/gtirloni/events{/privacy}","received_events_url":"https://api.github.com/users/gtirloni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-22T10:20:02Z","updated_at":"2018-08-29T17:30:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fluid-project/infusion/pulls/927","html_url":"https://github.com/fluid-project/infusion/pull/927","diff_url":"https://github.com/fluid-project/infusion/pull/927.diff","patch_url":"https://github.com/fluid-project/infusion/pull/927.patch"},"body":"In certain situations, it's perfectly fine to have the node_modules shared between host and a vagrant box:\r\n\r\n* When host/VM architecture are the same\r\n* When all work happens inside the VM\r\n\r\nThat is the situation in CI Linux build nodes.\r\n\r\nThis has the advantage that certain operations like publishing the build artifacts can happen outside the VM (as they need access to credentials that would be hard to import into the VM) without having to run `npm install` a second time.\r\n\r\nThis PR adds an environment variable that allow CI (and Linux users) to avoid the bind mount during the `vagrant up` phase by specifying SKIP_NODE_MODULES_BIND_MOUNT=1."},"comment":{"url":"https://api.github.com/repos/fluid-project/infusion/issues/comments/417038106","html_url":"https://github.com/fluid-project/infusion/pull/927#issuecomment-417038106","issue_url":"https://api.github.com/repos/fluid-project/infusion/issues/927","id":417038106,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzAzODEwNg==","user":{"login":"incd-ci-robot","id":41127776,"node_id":"MDQ6VXNlcjQxMTI3Nzc2","avatar_url":"https://avatars0.githubusercontent.com/u/41127776?v=4","gravatar_id":"","url":"https://api.github.com/users/incd-ci-robot","html_url":"https://github.com/incd-ci-robot","followers_url":"https://api.github.com/users/incd-ci-robot/followers","following_url":"https://api.github.com/users/incd-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/incd-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/incd-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incd-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/incd-ci-robot/orgs","repos_url":"https://api.github.com/users/incd-ci-robot/repos","events_url":"https://api.github.com/users/incd-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/incd-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T17:30:55Z","updated_at":"2018-08-29T17:30:55Z","author_association":"NONE","body":"CI job passed: https://ci.fluidproject.org/job/infusion-pull-request/34/\n"}}
{"actor":{"display_login":"incd-ci-robot"}}