{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/192410371","pull_request_review_id":125182745,"id":192410371,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQxMDM3MQ==","diff_hunk":"@@ -523,7 +512,7 @@ func (a *Actuator) updateStatus(machine *clusterv1.Machine, instance *ec2.Instan\n \treturn nil\n }\n \n-func (a *Actuator) terminateInstances(client *ec2.EC2, instanceIDs []*string, mLog log.FieldLogger) error {\n+func (a *Actuator) terminateInstances(client ec2iface.EC2API, instanceIDs []*string, mLog log.FieldLogger) error {","path":"pkg/clusterapi/aws/actuator.go","position":143,"original_position":143,"commit_id":"a2209e105a1dd162135620b4ed3ed1a6a457f39a","original_commit_id":"a2209e105a1dd162135620b4ed3ed1a6a457f39a","user":{"login":"staebler","id":30120115,"node_id":"MDQ6VXNlcjMwMTIwMTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30120115?v=4","gravatar_id":"","url":"https://api.github.com/users/staebler","html_url":"https://github.com/staebler","followers_url":"https://api.github.com/users/staebler/followers","following_url":"https://api.github.com/users/staebler/following{/other_user}","gists_url":"https://api.github.com/users/staebler/gists{/gist_id}","starred_url":"https://api.github.com/users/staebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staebler/subscriptions","organizations_url":"https://api.github.com/users/staebler/orgs","repos_url":"https://api.github.com/users/staebler/repos","events_url":"https://api.github.com/users/staebler/events{/privacy}","received_events_url":"https://api.github.com/users/staebler/received_events","type":"User","site_admin":false},"body":"Should we move this into the aws utils too?","created_at":"2018-06-01T14:17:58Z","updated_at":"2018-06-01T14:42:30Z","html_url":"https://github.com/openshift/cluster-operator/pull/247#discussion_r192410371","pull_request_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/247","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments/192410371"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/247#discussion_r192410371"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-operator/pulls/247","id":192032662,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDMyNjYy","html_url":"https://github.com/openshift/cluster-operator/pull/247","diff_url":"https://github.com/openshift/cluster-operator/pull/247.diff","patch_url":"https://github.com/openshift/cluster-operator/pull/247.patch","issue_url":"https://api.github.com/repos/openshift/cluster-operator/issues/247","number":247,"state":"open","locked":false,"title":"Add controller to add masters to internal/external ELB.","user":{"login":"dgoodwin","id":51265,"node_id":"MDQ6VXNlcjUxMjY1","avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"Watches machines, and if they're masters adds them to internal/external ELB. This happens on every machine sync, the API call appears idempotent, however if we feel this is too much chatter I could modify to only re-try adding to the ELB after a certain amount of time has elapsed since successfully being added.\r\n\r\nAlso disables the check for deprovisioning remote machinesets as we do not\r\ncurrently create them, and this blocks the infra deprovision job and\r\nthus cluster deletion.","created_at":"2018-06-01T13:20:45Z","updated_at":"2018-06-01T14:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9add038ccdf6c5045b11059f33b24f5c9e3b844","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":770572197,"node_id":"MDU6TGFiZWw3NzA1NzIxOTc=","url":"https://api.github.com/repos/openshift/cluster-operator/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/247/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/247/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/issues/247/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/a2209e105a1dd162135620b4ed3ed1a6a457f39a","head":{"label":"dgoodwin:elb-controller","ref":"elb-controller","sha":"a2209e105a1dd162135620b4ed3ed1a6a457f39a","user":{"login":"dgoodwin","id":51265,"node_id":"MDQ6VXNlcjUxMjY1","avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"repo":{"id":113201123,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMDExMjM=","name":"cluster-operator","full_name":"dgoodwin/cluster-operator","owner":{"login":"dgoodwin","id":51265,"node_id":"MDQ6VXNlcjUxMjY1","avatar_url":"https://avatars3.githubusercontent.com/u/51265?v=4","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgoodwin/cluster-operator","description":null,"fork":true,"url":"https://api.github.com/repos/dgoodwin/cluster-operator","forks_url":"https://api.github.com/repos/dgoodwin/cluster-operator/forks","keys_url":"https://api.github.com/repos/dgoodwin/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgoodwin/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgoodwin/cluster-operator/teams","hooks_url":"https://api.github.com/repos/dgoodwin/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/dgoodwin/cluster-operator/events","assignees_url":"https://api.github.com/repos/dgoodwin/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/dgoodwin/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/dgoodwin/cluster-operator/tags","blobs_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgoodwin/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/dgoodwin/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/dgoodwin/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/dgoodwin/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/dgoodwin/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/dgoodwin/cluster-operator/subscription","commits_url":"https://api.github.com/repos/dgoodwin/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgoodwin/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgoodwin/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgoodwin/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/dgoodwin/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgoodwin/cluster-operator/merges","archive_url":"https://api.github.com/repos/dgoodwin/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgoodwin/cluster-operator/downloads","issues_url":"https://api.github.com/repos/dgoodwin/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/dgoodwin/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/dgoodwin/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/dgoodwin/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgoodwin/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/dgoodwin/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/dgoodwin/cluster-operator/deployments","created_at":"2017-12-05T15:44:11Z","updated_at":"2018-04-18T12:08:21Z","pushed_at":"2018-06-01T14:05:17Z","git_url":"git://github.com/dgoodwin/cluster-operator.git","ssh_url":"git@github.com:dgoodwin/cluster-operator.git","clone_url":"https://github.com/dgoodwin/cluster-operator.git","svn_url":"https://github.com/dgoodwin/cluster-operator","homepage":null,"size":95406,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a83f1b04c4d128e93a6ff3c0d02e2d3e69ab40d2","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":113197161,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxOTcxNjE=","name":"cluster-operator","full_name":"openshift/cluster-operator","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/cluster-operator","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/cluster-operator","forks_url":"https://api.github.com/repos/openshift/cluster-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-operator/deployments","created_at":"2017-12-05T15:09:17Z","updated_at":"2018-06-01T11:15:51Z","pushed_at":"2018-06-01T14:05:18Z","git_url":"git://github.com/openshift/cluster-operator.git","ssh_url":"git@github.com:openshift/cluster-operator.git","clone_url":"https://github.com/openshift/cluster-operator.git","svn_url":"https://github.com/openshift/cluster-operator","homepage":null,"size":90484,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":19,"open_issues":19,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/247"},"html":{"href":"https://github.com/openshift/cluster-operator/pull/247"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/247"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-operator/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-operator/statuses/a2209e105a1dd162135620b4ed3ed1a6a457f39a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"staebler"}}