{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/171928794","pull_request_review_id":100872709,"id":171928794,"diff_hunk":"@@ -116,12 +116,14 @@ And then updating your log4j.xml to include the appender:\n \n #### Stream Log4j Appender\n \n-Samza provides a StreamAppender to publish the logs into a specific system. You can specify the system name using \"task.log4j.system\" and change name of log stream with param 'StreamName'. Also, we have the [MDC](http://logback.qos.ch/manual/mdc.html) keys \"containerName\", \"jobName\" and \"jobId\", which help identify the source of the log. In order to use this appender, simply add:\n+Samza provides a StreamAppender to publish the logs into a specific system. You can specify the system name using \"task.log4j.system\" and change name of log stream with param 'StreamName'. You can also specify the number of partitions for the log stream with param 'DefaultPartitionCount'; otherwise, the number of partitions will equal the number of containers configured for the job. The partition count is set upon the creation of the logging stream and changing the partition count requires manual intervention with the system stream. The [MDC](http://logback.qos.ch/manual/mdc.html) contains the keys \"containerName\", \"jobName\" and \"jobId\", which help identify the source of the log. In order to use this appender, add:\n \n {% highlight xml %}\n <appender name=\"StreamAppender\" class=\"org.apache.samza.logging.log4j.StreamAppender\">\n    <!-- optional -->\n    <param name=\"StreamName\" value=\"EpicStreamName\"/>\n+   <!-- optional -->\n+   <param name=\"DefaultPartitionCount\" value=\"8\"/>","path":"docs/learn/documentation/versioned/jobs/logging.md","position":12,"original_position":12,"commit_id":"b2d2b08da819c1e04c3c5ec5e8577c5c6e38a890","original_commit_id":"b2d2b08da819c1e04c3c5ec5e8577c5c6e38a890","user":{"login":"prateekm","id":1085859,"avatar_url":"https://avatars2.githubusercontent.com/u/1085859?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekm","html_url":"https://github.com/prateekm","followers_url":"https://api.github.com/users/prateekm/followers","following_url":"https://api.github.com/users/prateekm/following{/other_user}","gists_url":"https://api.github.com/users/prateekm/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekm/subscriptions","organizations_url":"https://api.github.com/users/prateekm/orgs","repos_url":"https://api.github.com/users/prateekm/repos","events_url":"https://api.github.com/users/prateekm/events{/privacy}","received_events_url":"https://api.github.com/users/prateekm/received_events","type":"User","site_admin":false},"body":"I think PartitionCount would be fine since you described the behavior above. DefaultPartitionCount isn't much more descriptive.","created_at":"2018-03-02T18:42:33Z","updated_at":"2018-03-02T18:45:14Z","html_url":"https://github.com/apache/samza/pull/423#discussion_r171928794","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/423","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/171928794"},"html":{"href":"https://github.com/apache/samza/pull/423#discussion_r171928794"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/423","id":169756064,"html_url":"https://github.com/apache/samza/pull/423","diff_url":"https://github.com/apache/samza/pull/423.diff","patch_url":"https://github.com/apache/samza/pull/423.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/423","number":423,"state":"open","locked":false,"title":"SAMZA-1460: StreamAppender does not explicitly create logging topic","user":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"body":"Creates the StreamAppender stream explicitly instead of relying on auto stream creation.","created_at":"2018-02-17T00:29:23Z","updated_at":"2018-03-02T18:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"628bbcc9d2f125cbb6b76d03aabd1d02ae958cb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/423/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/423/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/423/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/b2d2b08da819c1e04c3c5ec5e8577c5c6e38a890","head":{"label":"dnishimura:samza-1460-streamappender-create-logging-topic","ref":"samza-1460-streamappender-create-logging-topic","sha":"b2d2b08da819c1e04c3c5ec5e8577c5c6e38a890","user":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"repo":{"id":102049608,"name":"samza","full_name":"dnishimura/samza","owner":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnishimura/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/dnishimura/samza","forks_url":"https://api.github.com/repos/dnishimura/samza/forks","keys_url":"https://api.github.com/repos/dnishimura/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnishimura/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnishimura/samza/teams","hooks_url":"https://api.github.com/repos/dnishimura/samza/hooks","issue_events_url":"https://api.github.com/repos/dnishimura/samza/issues/events{/number}","events_url":"https://api.github.com/repos/dnishimura/samza/events","assignees_url":"https://api.github.com/repos/dnishimura/samza/assignees{/user}","branches_url":"https://api.github.com/repos/dnishimura/samza/branches{/branch}","tags_url":"https://api.github.com/repos/dnishimura/samza/tags","blobs_url":"https://api.github.com/repos/dnishimura/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnishimura/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnishimura/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnishimura/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnishimura/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/dnishimura/samza/languages","stargazers_url":"https://api.github.com/repos/dnishimura/samza/stargazers","contributors_url":"https://api.github.com/repos/dnishimura/samza/contributors","subscribers_url":"https://api.github.com/repos/dnishimura/samza/subscribers","subscription_url":"https://api.github.com/repos/dnishimura/samza/subscription","commits_url":"https://api.github.com/repos/dnishimura/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnishimura/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnishimura/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnishimura/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnishimura/samza/contents/{+path}","compare_url":"https://api.github.com/repos/dnishimura/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnishimura/samza/merges","archive_url":"https://api.github.com/repos/dnishimura/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnishimura/samza/downloads","issues_url":"https://api.github.com/repos/dnishimura/samza/issues{/number}","pulls_url":"https://api.github.com/repos/dnishimura/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/dnishimura/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/dnishimura/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnishimura/samza/labels{/name}","releases_url":"https://api.github.com/repos/dnishimura/samza/releases{/id}","deployments_url":"https://api.github.com/repos/dnishimura/samza/deployments","created_at":"2017-08-31T22:09:13Z","updated_at":"2017-08-31T22:09:17Z","pushed_at":"2018-03-02T05:29:35Z","git_url":"git://github.com/dnishimura/samza.git","ssh_url":"git@github.com:dnishimura/samza.git","clone_url":"https://github.com/dnishimura/samza.git","svn_url":"https://github.com/dnishimura/samza","homepage":null,"size":19233,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ed7e4af2fd059910425dec8e3faf7c8e0eecc9fd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2018-02-28T07:09:24Z","pushed_at":"2018-03-02T18:04:07Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":19139,"stargazers_count":407,"watchers_count":407,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":182,"open_issues":19,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/423"},"html":{"href":"https://github.com/apache/samza/pull/423"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/423"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/b2d2b08da819c1e04c3c5ec5e8577c5c6e38a890"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"prateekm"}}