{"action":"created","issue":{"url":"https://api.github.com/repos/Turbo87/utm/issues/24","repository_url":"https://api.github.com/repos/Turbo87/utm","labels_url":"https://api.github.com/repos/Turbo87/utm/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/Turbo87/utm/issues/24/comments","events_url":"https://api.github.com/repos/Turbo87/utm/issues/24/events","html_url":"https://github.com/Turbo87/utm/pull/24","id":174736108,"node_id":"MDExOlB1bGxSZXF1ZXN0ODM3ODQ1NTk=","number":24,"title":"Implement numpy support","user":{"login":"TheBB","id":619375,"node_id":"MDQ6VXNlcjYxOTM3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/619375?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBB","html_url":"https://github.com/TheBB","followers_url":"https://api.github.com/users/TheBB/followers","following_url":"https://api.github.com/users/TheBB/following{/other_user}","gists_url":"https://api.github.com/users/TheBB/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBB/subscriptions","organizations_url":"https://api.github.com/users/TheBB/orgs","repos_url":"https://api.github.com/users/TheBB/repos","events_url":"https://api.github.com/users/TheBB/events{/privacy}","received_events_url":"https://api.github.com/users/TheBB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-02T11:14:08Z","updated_at":"2018-06-26T08:32:05Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Turbo87/utm/pulls/24","html_url":"https://github.com/Turbo87/utm/pull/24","diff_url":"https://github.com/Turbo87/utm/pull/24.diff","patch_url":"https://github.com/Turbo87/utm/pull/24.patch"},"body":"It was deemed “out of scope” in https://github.com/Turbo87/utm/issues/18 but it's actually very simple to do and doubtless a useful feature. For people like me who are working with heightmaps with thousands of points in each direction in different coordinate systems, converting coordinate pairs one-by-one is unacceptably slow.\n\nIn principle, the numpy module implements all the functions that are needed from math, and they work transparently for arrays as well as floats, so it's a drop-in replacement.\n\nExceptions:\n- Bounds checking, I delegated this to a helper function that catches all cases.\n- Possibly ambiguous input in the zone calculation in from_latlon. Here I just use the first point to compute the zone, assuming that the user is careful enough to have all points in the same zone (or that they will be fine with having input points in one zone converted to UTM coordinates in another).\n- Mixed north/south latitudes in from_latlon. Right now the code throws an exception in this case. However now that I think about it, I assume it would be correct to add 10e6 northing to every point with a southern latitude and to not change the northern latitude points? If so I can modify this to work without throwing an error.\n\nI wrote the tests to require numpy since it's safer. Not sure what Travis will think of this so let's see…\n\nI'm already using this modified version in my code so it's not critical to me that this is merged, but I'm fairly sure this would be useful to others.\n"},"comment":{"url":"https://api.github.com/repos/Turbo87/utm/issues/comments/400226176","html_url":"https://github.com/Turbo87/utm/pull/24#issuecomment-400226176","issue_url":"https://api.github.com/repos/Turbo87/utm/issues/24","id":400226176,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIyNjE3Ng==","user":{"login":"Juanlu001","id":316517,"node_id":"MDQ6VXNlcjMxNjUxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:32:05Z","updated_at":"2018-06-26T08:32:05Z","author_association":"COLLABORATOR","body":"Thanks for the invitation @Turbo87, I hope I will do a good job as a maintainer :)\r\n\r\nI will proceed and merge this, and hopefully we can prepare a release this week or the following one."}}
{"actor":{"display_login":"Juanlu001"}}