{"action":"closed","number":23140,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140","id":185868740,"html_url":"https://github.com/cms-sw/cmssw/pull/23140","diff_url":"https://github.com/cms-sw/cmssw/pull/23140.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23140.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23140","number":23140,"state":"closed","locked":false,"title":"HCALDQM: Monitor bad capid rotation, uHTR/L1T mismatches (10_2_X)","user":{"login":"DryRun","id":1634307,"avatar_url":"https://avatars2.githubusercontent.com/u/1634307?v=4","gravatar_id":"","url":"https://api.github.com/users/DryRun","html_url":"https://github.com/DryRun","followers_url":"https://api.github.com/users/DryRun/followers","following_url":"https://api.github.com/users/DryRun/following{/other_user}","gists_url":"https://api.github.com/users/DryRun/gists{/gist_id}","starred_url":"https://api.github.com/users/DryRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DryRun/subscriptions","organizations_url":"https://api.github.com/users/DryRun/orgs","repos_url":"https://api.github.com/users/DryRun/repos","events_url":"https://api.github.com/users/DryRun/events{/privacy}","received_events_url":"https://api.github.com/users/DryRun/received_events","type":"User","site_admin":false},"body":"Adds the following, mostly related to the issues seen so far in 2018:\r\n- Monitor bad capid rotation. (BX - capid) % 4 should be a constant.\r\n- Monitor uHTR-L1T mismatches. This is copied straight from the L1T DQM code, but it's extremely useful for HCAL.\r\n\r\nMinor additions:\r\n- Add LED pin diode plots to local DQM.\r\n- UMNioTask now handles LED events correctly, instead of labeling them HF.\r\n- Implement code rule check as suggested by Fabio. These were all \"using namespace * in header\" violations, which were fairly ubiquitous in the HcalCommon infrastructure.","created_at":"2018-05-04T00:11:45Z","updated_at":"2018-05-16T08:06:40Z","closed_at":"2018-05-16T08:06:39Z","merged_at":"2018-05-16T08:06:39Z","merge_commit_sha":"8382e10e6773e67428c6b27f97be2c6dc800bc2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"2cbe4e","default":false},{"id":53149121,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"2cbe4e","default":false},{"id":290514704,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"2cbe4e","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":310,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-16T08:06:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23140/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/1d1bc22a207521b74db8ca6b61e320ddceeeb156","head":{"label":"DryRun:CMSSW_10_2_0_pre1_globalled_fede2","ref":"CMSSW_10_2_0_pre1_globalled_fede2","sha":"1d1bc22a207521b74db8ca6b61e320ddceeeb156","user":{"login":"DryRun","id":1634307,"avatar_url":"https://avatars2.githubusercontent.com/u/1634307?v=4","gravatar_id":"","url":"https://api.github.com/users/DryRun","html_url":"https://github.com/DryRun","followers_url":"https://api.github.com/users/DryRun/followers","following_url":"https://api.github.com/users/DryRun/following{/other_user}","gists_url":"https://api.github.com/users/DryRun/gists{/gist_id}","starred_url":"https://api.github.com/users/DryRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DryRun/subscriptions","organizations_url":"https://api.github.com/users/DryRun/orgs","repos_url":"https://api.github.com/users/DryRun/repos","events_url":"https://api.github.com/users/DryRun/events{/privacy}","received_events_url":"https://api.github.com/users/DryRun/received_events","type":"User","site_admin":false},"repo":{"id":51483289,"name":"cmssw","full_name":"DryRun/cmssw","owner":{"login":"DryRun","id":1634307,"avatar_url":"https://avatars2.githubusercontent.com/u/1634307?v=4","gravatar_id":"","url":"https://api.github.com/users/DryRun","html_url":"https://github.com/DryRun","followers_url":"https://api.github.com/users/DryRun/followers","following_url":"https://api.github.com/users/DryRun/following{/other_user}","gists_url":"https://api.github.com/users/DryRun/gists{/gist_id}","starred_url":"https://api.github.com/users/DryRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DryRun/subscriptions","organizations_url":"https://api.github.com/users/DryRun/orgs","repos_url":"https://api.github.com/users/DryRun/repos","events_url":"https://api.github.com/users/DryRun/events{/privacy}","received_events_url":"https://api.github.com/users/DryRun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DryRun/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/DryRun/cmssw","forks_url":"https://api.github.com/repos/DryRun/cmssw/forks","keys_url":"https://api.github.com/repos/DryRun/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DryRun/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DryRun/cmssw/teams","hooks_url":"https://api.github.com/repos/DryRun/cmssw/hooks","issue_events_url":"https://api.github.com/repos/DryRun/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/DryRun/cmssw/events","assignees_url":"https://api.github.com/repos/DryRun/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/DryRun/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/DryRun/cmssw/tags","blobs_url":"https://api.github.com/repos/DryRun/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DryRun/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DryRun/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/DryRun/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DryRun/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/DryRun/cmssw/languages","stargazers_url":"https://api.github.com/repos/DryRun/cmssw/stargazers","contributors_url":"https://api.github.com/repos/DryRun/cmssw/contributors","subscribers_url":"https://api.github.com/repos/DryRun/cmssw/subscribers","subscription_url":"https://api.github.com/repos/DryRun/cmssw/subscription","commits_url":"https://api.github.com/repos/DryRun/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/DryRun/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/DryRun/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/DryRun/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/DryRun/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/DryRun/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DryRun/cmssw/merges","archive_url":"https://api.github.com/repos/DryRun/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DryRun/cmssw/downloads","issues_url":"https://api.github.com/repos/DryRun/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/DryRun/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/DryRun/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/DryRun/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DryRun/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/DryRun/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/DryRun/cmssw/deployments","created_at":"2016-02-11T00:15:12Z","updated_at":"2016-02-11T00:18:12Z","pushed_at":"2018-05-15T12:10:38Z","git_url":"git://github.com/DryRun/cmssw.git","ssh_url":"git@github.com:DryRun/cmssw.git","clone_url":"https://github.com/DryRun/cmssw.git","svn_url":"https://github.com/DryRun/cmssw","homepage":"http://cms-sw.github.io/","size":991977,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_8_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"f4ffc8bffbbfe88fffe91cf5dd8849ea5c6af621","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-05-15T20:58:45Z","pushed_at":"2018-05-16T08:06:39Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1002070,"stargazers_count":548,"watchers_count":548,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2563,"mirror_url":null,"archived":false,"open_issues_count":419,"license":null,"forks":2563,"open_issues":419,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23140"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23140"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23140/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23140/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/1d1bc22a207521b74db8ca6b61e320ddceeeb156"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"comments":54,"review_comments":0,"maintainer_can_modify":false,"commits":61,"additions":2006,"deletions":446,"changed_files":56}}
{"actor":{"display_login":"cmsbuild"}}