{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments/216065436","pull_request_review_id":153427680,"id":216065436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA2NTQzNg==","diff_hunk":"@@ -1,6 +1,8 @@\n RSpec.describe BundleContextTemporary do\n   let(:revs_context) { context_from_proj(:proj_revs) }\n \n+  before { allow_any_instance_of(described_class).to receive(:validate_usage) } # to be replaced w/ AR validation","path":"spec/lib/bundle_context_temporary_spec.rb","position":4,"original_position":4,"commit_id":"1998b2843eeca4aac28bcf3bbae619aba6595db8","original_commit_id":"1998b2843eeca4aac28bcf3bbae619aba6595db8","user":{"login":"jmartin-sul","id":7741604,"node_id":"MDQ6VXNlcjc3NDE2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7741604?v=4","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"body":"was this allowance added because previously valid fixture configs are no longer valid?","created_at":"2018-09-07T19:31:30Z","updated_at":"2018-09-07T19:38:41Z","html_url":"https://github.com/sul-dlss/pre-assembly/pull/207#discussion_r216065436","pull_request_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments/216065436"},"html":{"href":"https://github.com/sul-dlss/pre-assembly/pull/207#discussion_r216065436"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207","id":213479307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDc5MzA3","html_url":"https://github.com/sul-dlss/pre-assembly/pull/207","diff_url":"https://github.com/sul-dlss/pre-assembly/pull/207.diff","patch_url":"https://github.com/sul-dlss/pre-assembly/pull/207.patch","issue_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/207","number":207,"state":"open","locked":false,"title":"Down with scope 2","user":{"login":"atz","id":109954,"node_id":"MDQ6VXNlcjEwOTk1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/109954?v=4","gravatar_id":"","url":"https://api.github.com/users/atz","html_url":"https://github.com/atz","followers_url":"https://api.github.com/users/atz/followers","following_url":"https://api.github.com/users/atz/following{/other_user}","gists_url":"https://api.github.com/users/atz/gists{/gist_id}","starred_url":"https://api.github.com/users/atz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atz/subscriptions","organizations_url":"https://api.github.com/users/atz/orgs","repos_url":"https://api.github.com/users/atz/repos","events_url":"https://api.github.com/users/atz/events{/privacy}","received_events_url":"https://api.github.com/users/atz/received_events","type":"User","site_admin":false},"body":"Because of underlying file splits and namespace shifts, this was probably the most intractable rebase I've had in years.  \n\nLots of things removed here:\n- `checksums_file`\n- `object_discovery`\n- `use_manifest`\n- `get_druid_from`\n-  `checksums_file`, `confirm_checksums` and related checksum-file methods\n- `cleanup!`\n- `required_files`: only manifest is required, and it is always required\n- `object_containers` (effectively an alias w/ manifest required)\n\nLots of timing complexities removed.  Specifically, instead of a pattern of `populate_my_instance_var` and `get_my_instance_var`, the \"getting\" logic moves inside the getter method.  The caller only needs to know the getter, not the getter plus a timing-dependent pre-requisite call.  See `druid`, `pid` and `digital_objects` methods for examples.\n\nFixture YAMLs start looking a lot simpler.\n\nA couple things added:\n- A valid manifest file w/ druids, something most of our fixtures did not have\n- Some stricter validation/raise behavior around file loading\n\nFixes #131","created_at":"2018-09-06T02:37:38Z","updated_at":"2018-09-07T19:38:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"877f6e14ef7b012f8737ff7b33cc461731715a9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1023448210,"node_id":"MDU6TGFiZWwxMDIzNDQ4MjEw","url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/207/comments","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/1998b2843eeca4aac28bcf3bbae619aba6595db8","head":{"label":"sul-dlss:down_with_scope_2","ref":"down_with_scope_2","sha":"1998b2843eeca4aac28bcf3bbae619aba6595db8","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":22521770,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUyMTc3MA==","name":"pre-assembly","full_name":"sul-dlss/pre-assembly","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/pre-assembly","description":null,"fork":false,"url":"https://api.github.com/repos/sul-dlss/pre-assembly","forks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/forks","keys_url":"https://api.github.com/repos/sul-dlss/pre-assembly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/pre-assembly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/pre-assembly/teams","hooks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/events","assignees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/pre-assembly/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/tags","blobs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/pre-assembly/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscription","commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/pre-assembly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/pre-assembly/merges","archive_url":"https://api.github.com/repos/sul-dlss/pre-assembly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/pre-assembly/downloads","issues_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/pre-assembly/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/pre-assembly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/pre-assembly/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/deployments","created_at":"2014-08-01T18:07:56Z","updated_at":"2018-09-07T14:05:44Z","pushed_at":"2018-09-07T18:59:04Z","git_url":"git://github.com/sul-dlss/pre-assembly.git","ssh_url":"git@github.com:sul-dlss/pre-assembly.git","clone_url":"https://github.com/sul-dlss/pre-assembly.git","svn_url":"https://github.com/sul-dlss/pre-assembly","homepage":"https://consul.stanford.edu/display/chimera/Automated+Accessioning+and+Object+Remediation+%28pre-assembly+and+assembly%29","size":2321,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":54,"watchers":1,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"ec776852ee88d8aa313f1f70082a56169b4188e2","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":22521770,"node_id":"MDEwOlJlcG9zaXRvcnkyMjUyMTc3MA==","name":"pre-assembly","full_name":"sul-dlss/pre-assembly","owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/pre-assembly","description":null,"fork":false,"url":"https://api.github.com/repos/sul-dlss/pre-assembly","forks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/forks","keys_url":"https://api.github.com/repos/sul-dlss/pre-assembly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/pre-assembly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/pre-assembly/teams","hooks_url":"https://api.github.com/repos/sul-dlss/pre-assembly/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/pre-assembly/events","assignees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/pre-assembly/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/tags","blobs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/pre-assembly/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/pre-assembly/subscription","commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/pre-assembly/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/pre-assembly/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/pre-assembly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/pre-assembly/merges","archive_url":"https://api.github.com/repos/sul-dlss/pre-assembly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/pre-assembly/downloads","issues_url":"https://api.github.com/repos/sul-dlss/pre-assembly/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/pre-assembly/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/pre-assembly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/pre-assembly/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/pre-assembly/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/pre-assembly/deployments","created_at":"2014-08-01T18:07:56Z","updated_at":"2018-09-07T14:05:44Z","pushed_at":"2018-09-07T18:59:04Z","git_url":"git://github.com/sul-dlss/pre-assembly.git","ssh_url":"git@github.com:sul-dlss/pre-assembly.git","clone_url":"https://github.com/sul-dlss/pre-assembly.git","svn_url":"https://github.com/sul-dlss/pre-assembly","homepage":"https://consul.stanford.edu/display/chimera/Automated+Accessioning+and+Object+Remediation+%28pre-assembly+and+assembly%29","size":2321,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":54,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207"},"html":{"href":"https://github.com/sul-dlss/pre-assembly/pull/207"},"issue":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/207"},"comments":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/pre-assembly/statuses/1998b2843eeca4aac28bcf3bbae619aba6595db8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmartin-sul"}}