{"action":"created","comment":{"url":"https://api.github.com/repos/jdereus/labman/pulls/comments/205192009","pull_request_review_id":140414014,"id":205192009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE5MjAwOQ==","diff_hunk":"@@ -129,6 +129,13 @@ PlateViewer.prototype.initialize = function (rows, cols) {\n                        cssClass: 'slick-header-column',\n                        headerCssClass: 'full-height-header'}];\n \n+  // Fetch the blank names before initializing the grid. This way we only make\n+  // one request to get this data instead of one per cell instantiation.\n+  var blanksRequest = $.ajax({\n+    dataType: 'json',\n+    url: '/sample/control?term=',","path":"labman/gui/static/js/plateViewer.js","position":8,"original_position":8,"commit_id":"005651fd801a6b69ef6ce1e44c4fa010c2f57406","original_commit_id":"005651fd801a6b69ef6ce1e44c4fa010c2f57406","user":{"login":"wasade","id":474290,"node_id":"MDQ6VXNlcjQ3NDI5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/474290?v=4","gravatar_id":"","url":"https://api.github.com/users/wasade","html_url":"https://github.com/wasade","followers_url":"https://api.github.com/users/wasade/followers","following_url":"https://api.github.com/users/wasade/following{/other_user}","gists_url":"https://api.github.com/users/wasade/gists{/gist_id}","starred_url":"https://api.github.com/users/wasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wasade/subscriptions","organizations_url":"https://api.github.com/users/wasade/orgs","repos_url":"https://api.github.com/users/wasade/repos","events_url":"https://api.github.com/users/wasade/events{/privacy}","received_events_url":"https://api.github.com/users/wasade/received_events","type":"User","site_admin":false},"body":"Okay, thanks. Would it be possible to add a comment indicating as such as the behavior is implicit? ","created_at":"2018-07-25T17:16:15Z","updated_at":"2018-07-25T17:16:15Z","html_url":"https://github.com/jdereus/labman/pull/258#discussion_r205192009","pull_request_url":"https://api.github.com/repos/jdereus/labman/pulls/258","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jdereus/labman/pulls/comments/205192009"},"html":{"href":"https://github.com/jdereus/labman/pull/258#discussion_r205192009"},"pull_request":{"href":"https://api.github.com/repos/jdereus/labman/pulls/258"}},"in_reply_to_id":205171170},"pull_request":{"url":"https://api.github.com/repos/jdereus/labman/pulls/258","id":200779854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzc5ODU0","html_url":"https://github.com/jdereus/labman/pull/258","diff_url":"https://github.com/jdereus/labman/pull/258.diff","patch_url":"https://github.com/jdereus/labman/pull/258.patch","issue_url":"https://api.github.com/repos/jdereus/labman/issues/258","number":258,"state":"open","locked":false,"title":"BUG: Fix broken copy-paste","user":{"login":"ElDeveloper","id":375307,"node_id":"MDQ6VXNlcjM3NTMwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/375307?v=4","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"body":"The assignment of the `this.blankNames` property was being done\r\nasynchronously on a per-cell basis. This worked fine if the user inputed\r\na value by hand, as it gave enough time for the request to return.\r\nHowever, when someone copy-pasted text into the grid, the request\r\nwouldn't return in time and the `this.blankNames` property wouldn't be\r\ncorrectly assigned leading to a ReferenceError.\r\n\r\nThis is now fixed by getting the contents of `this.blankNames` before\r\ninitializing the whole grid. This way every cell has access to the data\r\nbefore instantiation.\r\n\r\n![242](https://user-images.githubusercontent.com/375307/42590508-db507e52-84f8-11e8-8563-f9ff80e6df8e.gif)\r\n\r\nFixes #243 \r\n","created_at":"2018-07-11T17:55:08Z","updated_at":"2018-07-25T17:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed4ed2fd1252ebbb67c6455fac2820e56548e711","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jdereus/labman/pulls/258/commits","review_comments_url":"https://api.github.com/repos/jdereus/labman/pulls/258/comments","review_comment_url":"https://api.github.com/repos/jdereus/labman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdereus/labman/issues/258/comments","statuses_url":"https://api.github.com/repos/jdereus/labman/statuses/005651fd801a6b69ef6ce1e44c4fa010c2f57406","head":{"label":"ElDeveloper:issue-243","ref":"issue-243","sha":"005651fd801a6b69ef6ce1e44c4fa010c2f57406","user":{"login":"ElDeveloper","id":375307,"node_id":"MDQ6VXNlcjM3NTMwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/375307?v=4","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"repo":{"id":118657877,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2NTc4Nzc=","name":"labman","full_name":"ElDeveloper/labman","owner":{"login":"ElDeveloper","id":375307,"node_id":"MDQ6VXNlcjM3NTMwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/375307?v=4","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElDeveloper/labman","description":"lab manager for plate maps and sequence flows","fork":true,"url":"https://api.github.com/repos/ElDeveloper/labman","forks_url":"https://api.github.com/repos/ElDeveloper/labman/forks","keys_url":"https://api.github.com/repos/ElDeveloper/labman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElDeveloper/labman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElDeveloper/labman/teams","hooks_url":"https://api.github.com/repos/ElDeveloper/labman/hooks","issue_events_url":"https://api.github.com/repos/ElDeveloper/labman/issues/events{/number}","events_url":"https://api.github.com/repos/ElDeveloper/labman/events","assignees_url":"https://api.github.com/repos/ElDeveloper/labman/assignees{/user}","branches_url":"https://api.github.com/repos/ElDeveloper/labman/branches{/branch}","tags_url":"https://api.github.com/repos/ElDeveloper/labman/tags","blobs_url":"https://api.github.com/repos/ElDeveloper/labman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElDeveloper/labman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElDeveloper/labman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElDeveloper/labman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElDeveloper/labman/statuses/{sha}","languages_url":"https://api.github.com/repos/ElDeveloper/labman/languages","stargazers_url":"https://api.github.com/repos/ElDeveloper/labman/stargazers","contributors_url":"https://api.github.com/repos/ElDeveloper/labman/contributors","subscribers_url":"https://api.github.com/repos/ElDeveloper/labman/subscribers","subscription_url":"https://api.github.com/repos/ElDeveloper/labman/subscription","commits_url":"https://api.github.com/repos/ElDeveloper/labman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElDeveloper/labman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElDeveloper/labman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElDeveloper/labman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElDeveloper/labman/contents/{+path}","compare_url":"https://api.github.com/repos/ElDeveloper/labman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElDeveloper/labman/merges","archive_url":"https://api.github.com/repos/ElDeveloper/labman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElDeveloper/labman/downloads","issues_url":"https://api.github.com/repos/ElDeveloper/labman/issues{/number}","pulls_url":"https://api.github.com/repos/ElDeveloper/labman/pulls{/number}","milestones_url":"https://api.github.com/repos/ElDeveloper/labman/milestones{/number}","notifications_url":"https://api.github.com/repos/ElDeveloper/labman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElDeveloper/labman/labels{/name}","releases_url":"https://api.github.com/repos/ElDeveloper/labman/releases{/id}","deployments_url":"https://api.github.com/repos/ElDeveloper/labman/deployments","created_at":"2018-01-23T19:23:16Z","updated_at":"2018-07-10T18:05:29Z","pushed_at":"2018-07-11T21:25:12Z","git_url":"git://github.com/ElDeveloper/labman.git","ssh_url":"git@github.com:ElDeveloper/labman.git","clone_url":"https://github.com/ElDeveloper/labman.git","svn_url":"https://github.com/ElDeveloper/labman","homepage":"","size":3399,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdereus:master","ref":"master","sha":"20922d23565c623b2c1953c41a50285337d386f9","user":{"login":"jdereus","id":14333677,"node_id":"MDQ6VXNlcjE0MzMzNjc3","avatar_url":"https://avatars2.githubusercontent.com/u/14333677?v=4","gravatar_id":"","url":"https://api.github.com/users/jdereus","html_url":"https://github.com/jdereus","followers_url":"https://api.github.com/users/jdereus/followers","following_url":"https://api.github.com/users/jdereus/following{/other_user}","gists_url":"https://api.github.com/users/jdereus/gists{/gist_id}","starred_url":"https://api.github.com/users/jdereus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdereus/subscriptions","organizations_url":"https://api.github.com/users/jdereus/orgs","repos_url":"https://api.github.com/users/jdereus/repos","events_url":"https://api.github.com/users/jdereus/events{/privacy}","received_events_url":"https://api.github.com/users/jdereus/received_events","type":"User","site_admin":false},"repo":{"id":91131580,"node_id":"MDEwOlJlcG9zaXRvcnk5MTEzMTU4MA==","name":"labman","full_name":"jdereus/labman","owner":{"login":"jdereus","id":14333677,"node_id":"MDQ6VXNlcjE0MzMzNjc3","avatar_url":"https://avatars2.githubusercontent.com/u/14333677?v=4","gravatar_id":"","url":"https://api.github.com/users/jdereus","html_url":"https://github.com/jdereus","followers_url":"https://api.github.com/users/jdereus/followers","following_url":"https://api.github.com/users/jdereus/following{/other_user}","gists_url":"https://api.github.com/users/jdereus/gists{/gist_id}","starred_url":"https://api.github.com/users/jdereus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdereus/subscriptions","organizations_url":"https://api.github.com/users/jdereus/orgs","repos_url":"https://api.github.com/users/jdereus/repos","events_url":"https://api.github.com/users/jdereus/events{/privacy}","received_events_url":"https://api.github.com/users/jdereus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdereus/labman","description":"lab manager for plate maps and sequence flows","fork":false,"url":"https://api.github.com/repos/jdereus/labman","forks_url":"https://api.github.com/repos/jdereus/labman/forks","keys_url":"https://api.github.com/repos/jdereus/labman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdereus/labman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdereus/labman/teams","hooks_url":"https://api.github.com/repos/jdereus/labman/hooks","issue_events_url":"https://api.github.com/repos/jdereus/labman/issues/events{/number}","events_url":"https://api.github.com/repos/jdereus/labman/events","assignees_url":"https://api.github.com/repos/jdereus/labman/assignees{/user}","branches_url":"https://api.github.com/repos/jdereus/labman/branches{/branch}","tags_url":"https://api.github.com/repos/jdereus/labman/tags","blobs_url":"https://api.github.com/repos/jdereus/labman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdereus/labman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdereus/labman/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdereus/labman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdereus/labman/statuses/{sha}","languages_url":"https://api.github.com/repos/jdereus/labman/languages","stargazers_url":"https://api.github.com/repos/jdereus/labman/stargazers","contributors_url":"https://api.github.com/repos/jdereus/labman/contributors","subscribers_url":"https://api.github.com/repos/jdereus/labman/subscribers","subscription_url":"https://api.github.com/repos/jdereus/labman/subscription","commits_url":"https://api.github.com/repos/jdereus/labman/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdereus/labman/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdereus/labman/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdereus/labman/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdereus/labman/contents/{+path}","compare_url":"https://api.github.com/repos/jdereus/labman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdereus/labman/merges","archive_url":"https://api.github.com/repos/jdereus/labman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdereus/labman/downloads","issues_url":"https://api.github.com/repos/jdereus/labman/issues{/number}","pulls_url":"https://api.github.com/repos/jdereus/labman/pulls{/number}","milestones_url":"https://api.github.com/repos/jdereus/labman/milestones{/number}","notifications_url":"https://api.github.com/repos/jdereus/labman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdereus/labman/labels{/name}","releases_url":"https://api.github.com/repos/jdereus/labman/releases{/id}","deployments_url":"https://api.github.com/repos/jdereus/labman/deployments","created_at":"2017-05-12T21:38:53Z","updated_at":"2018-07-11T19:02:55Z","pushed_at":"2018-07-25T14:05:27Z","git_url":"git://github.com/jdereus/labman.git","ssh_url":"git@github.com:jdereus/labman.git","clone_url":"https://github.com/jdereus/labman.git","svn_url":"https://github.com/jdereus/labman","homepage":"","size":3405,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":46,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdereus/labman/pulls/258"},"html":{"href":"https://github.com/jdereus/labman/pull/258"},"issue":{"href":"https://api.github.com/repos/jdereus/labman/issues/258"},"comments":{"href":"https://api.github.com/repos/jdereus/labman/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/jdereus/labman/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/jdereus/labman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdereus/labman/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/jdereus/labman/statuses/005651fd801a6b69ef6ce1e44c4fa010c2f57406"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wasade"}}