{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/492","repository_url":"https://api.github.com/repos/redhat-developer/vscode-java","labels_url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/492/comments","events_url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/492/events","html_url":"https://github.com/redhat-developer/vscode-java/pull/492","id":311415536,"number":492,"title":"[Discussion] [Live Share] Restricting language services on file scheme","user":{"login":"lostintangent","id":116461,"avatar_url":"https://avatars3.githubusercontent.com/u/116461?v=4","gravatar_id":"","url":"https://api.github.com/users/lostintangent","html_url":"https://github.com/lostintangent","followers_url":"https://api.github.com/users/lostintangent/followers","following_url":"https://api.github.com/users/lostintangent/following{/other_user}","gists_url":"https://api.github.com/users/lostintangent/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintangent/subscriptions","organizations_url":"https://api.github.com/users/lostintangent/orgs","repos_url":"https://api.github.com/users/lostintangent/repos","events_url":"https://api.github.com/users/lostintangent/events{/privacy}","received_events_url":"https://api.github.com/users/lostintangent/received_events","type":"User","site_admin":false},"labels":[{"id":423855031,"url":"https://api.github.com/repos/redhat-developer/vscode-java/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":423855032,"url":"https://api.github.com/repos/redhat-developer/vscode-java/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":447881952,"url":"https://api.github.com/repos/redhat-developer/vscode-java/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/redhat-developer/vscode-java/milestones/35","html_url":"https://github.com/redhat-developer/vscode-java/milestone/35","labels_url":"https://api.github.com/repos/redhat-developer/vscode-java/milestones/35/labels","id":3246077,"number":35,"title":"Mid April 2018","description":"","creator":{"login":"fbricon","id":148698,"avatar_url":"https://avatars3.githubusercontent.com/u/148698?v=4","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2018-04-05T19:13:23Z","updated_at":"2018-04-05T22:44:09Z","due_on":"2018-04-16T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-04-04T22:41:41Z","updated_at":"2018-04-05T22:44:40Z","closed_at":"2018-04-05T22:44:09Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/redhat-developer/vscode-java/pulls/492","html_url":"https://github.com/redhat-developer/vscode-java/pull/492","diff_url":"https://github.com/redhat-developer/vscode-java/pull/492.diff","patch_url":"https://github.com/redhat-developer/vscode-java/pull/492.patch"},"body":"In preparation for [Visual Studio Live Share](http://aka.ms/vsls) adding support for \"guests\" to receive remote language services for Java, this PR simply updates the current `DocumentSelector` to be limited to `file` and `untitled` (unsaved) files. This way, when someone has this extension installed, and joins a Live Share session (where files use the `vsls:` scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).\r\n\r\nIf someone joins a Java project using Live Share, and doesn't have this extension installed, then they will automatically receive language services from the host (which is awesome! 🎉), so this PR is simply an optimization for the case where collaborating developers both have the Java extension installed. Additionally, this wouldn't impact the \"local\" Java development experience.\r\n\r\n*Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code [already have this scheme restriction](https://github.com/Microsoft/vscode/blob/master/extensions/typescript-language-features/src/utils/fileSchemes.ts#L12), and so this PR replicates that behavior.*"},"comment":{"url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/comments/379098693","html_url":"https://github.com/redhat-developer/vscode-java/pull/492#issuecomment-379098693","issue_url":"https://api.github.com/repos/redhat-developer/vscode-java/issues/492","id":379098693,"user":{"login":"fbricon","id":148698,"avatar_url":"https://avatars3.githubusercontent.com/u/148698?v=4","gravatar_id":"","url":"https://api.github.com/users/fbricon","html_url":"https://github.com/fbricon","followers_url":"https://api.github.com/users/fbricon/followers","following_url":"https://api.github.com/users/fbricon/following{/other_user}","gists_url":"https://api.github.com/users/fbricon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbricon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbricon/subscriptions","organizations_url":"https://api.github.com/users/fbricon/orgs","repos_url":"https://api.github.com/users/fbricon/repos","events_url":"https://api.github.com/users/fbricon/events{/privacy}","received_events_url":"https://api.github.com/users/fbricon/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T22:44:40Z","updated_at":"2018-04-05T22:44:40Z","author_association":"CONTRIBUTOR","body":"@lostintangent thanks for the patch!"}}
{"actor":{"display_login":"fbricon"}}