{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/169809365","pull_request_review_id":98397901,"id":169809365,"diff_hunk":"@@ -138,6 +138,22 @@ else\n     echo -e \"Warning: Installation script couldn't detect host OS..\\n\" # exit ?\n fi\n \n+SET_CUSTOM_ICU() {\n+    ICU_PATH=$1\n+    if [[ ! -d \"$ICU_PATH\" || ! -d \"$ICU_PATH/unicode\" ]]; then\n+        ICU_PATH_LOCAL=\"$CHAKRACORE_DIR/$ICU_PATH\"\n+        if [[ ! -d \"$ICU_PATH_LOCAL\" || ! -d \"$ICU_PATH_LOCAL/unicode\" ]]; then\n+            # if a path was explicitly provided, do not fallback to no-icu\n+            echo \"!!! couldn't find ICU at either $ICU_PATH or $ICU_PATH_LOCAL\"\n+            exit 1\n+        else\n+            ICU_PATH=\"$ICU_PATH_LOCAL\"\n+        fi\n+    fi\n+    CMAKE_ICU=\"-DICU_INCLUDE_PATH_SH=$ICU_PATH\"","path":"build.sh","position":16,"original_position":16,"commit_id":"18305df14471f139a23dbdc8f7b2c4c571e37e69","original_commit_id":"18305df14471f139a23dbdc8f7b2c4c571e37e69","user":{"login":"jackhorton","id":4370013,"avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"body":"any particular reason?","created_at":"2018-02-21T23:16:57Z","updated_at":"2018-02-21T23:16:57Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/4716#discussion_r169809365","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/169809365"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4716#discussion_r169809365"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716"}},"in_reply_to_id":169790668},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716","id":170568146,"html_url":"https://github.com/Microsoft/ChakraCore/pull/4716","diff_url":"https://github.com/Microsoft/ChakraCore/pull/4716.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/4716.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4716","number":4716,"state":"open","locked":false,"title":"Fix local --icu/--custom-icu configuration","user":{"login":"jackhorton","id":4370013,"avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"body":"Unblocks Node-ChakraCore#chakracore-master","created_at":"2018-02-21T19:39:33Z","updated_at":"2018-02-21T23:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a1d254dae4ff8031a2a41cf0a7c3eced062b41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4716/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/18305df14471f139a23dbdc8f7b2c4c571e37e69","head":{"label":"jackhorton:fix-local-icu","ref":"fix-local-icu","sha":"18305df14471f139a23dbdc8f7b2c4c571e37e69","user":{"login":"jackhorton","id":4370013,"avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"repo":{"id":96947022,"name":"ChakraCore","full_name":"jackhorton/ChakraCore","owner":{"login":"jackhorton","id":4370013,"avatar_url":"https://avatars2.githubusercontent.com/u/4370013?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackhorton/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/jackhorton/ChakraCore","forks_url":"https://api.github.com/repos/jackhorton/ChakraCore/forks","keys_url":"https://api.github.com/repos/jackhorton/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackhorton/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackhorton/ChakraCore/teams","hooks_url":"https://api.github.com/repos/jackhorton/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/jackhorton/ChakraCore/events","assignees_url":"https://api.github.com/repos/jackhorton/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/jackhorton/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/jackhorton/ChakraCore/tags","blobs_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackhorton/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/jackhorton/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/jackhorton/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/jackhorton/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/jackhorton/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/jackhorton/ChakraCore/subscription","commits_url":"https://api.github.com/repos/jackhorton/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackhorton/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackhorton/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackhorton/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/jackhorton/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackhorton/ChakraCore/merges","archive_url":"https://api.github.com/repos/jackhorton/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackhorton/ChakraCore/downloads","issues_url":"https://api.github.com/repos/jackhorton/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/jackhorton/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/jackhorton/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/jackhorton/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackhorton/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/jackhorton/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/jackhorton/ChakraCore/deployments","created_at":"2017-07-12T00:01:08Z","updated_at":"2017-07-12T02:25:53Z","pushed_at":"2018-02-21T21:44:56Z","git_url":"git://github.com/jackhorton/ChakraCore.git","ssh_url":"git@github.com:jackhorton/ChakraCore.git","clone_url":"https://github.com/jackhorton/ChakraCore.git","svn_url":"https://github.com/jackhorton/ChakraCore","homepage":"","size":108932,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"c17731d4acf45f3770a7c864033fe06104df58c0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2018-02-21T21:37:04Z","pushed_at":"2018-02-21T23:11:10Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":114197,"stargazers_count":6766,"watchers_count":6766,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":863,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":863,"open_issues":335,"watchers":6766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/4716"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4716"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/4716/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/4716/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/18305df14471f139a23dbdc8f7b2c4c571e37e69"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jackhorton"}}