{"action":"created","issue":{"url":"https://api.github.com/repos/PathwayCommons/factoid/issues/248","repository_url":"https://api.github.com/repos/PathwayCommons/factoid","labels_url":"https://api.github.com/repos/PathwayCommons/factoid/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/PathwayCommons/factoid/issues/248/comments","events_url":"https://api.github.com/repos/PathwayCommons/factoid/issues/248/events","html_url":"https://github.com/PathwayCommons/factoid/issues/248","id":313106761,"number":248,"title":"Synchronizing entity info with grounding popover","user":{"login":"fdurupinar","id":13474166,"avatar_url":"https://avatars2.githubusercontent.com/u/13474166?v=4","gravatar_id":"","url":"https://api.github.com/users/fdurupinar","html_url":"https://github.com/fdurupinar","followers_url":"https://api.github.com/users/fdurupinar/followers","following_url":"https://api.github.com/users/fdurupinar/following{/other_user}","gists_url":"https://api.github.com/users/fdurupinar/gists{/gist_id}","starred_url":"https://api.github.com/users/fdurupinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdurupinar/subscriptions","organizations_url":"https://api.github.com/users/fdurupinar/orgs","repos_url":"https://api.github.com/users/fdurupinar/repos","events_url":"https://api.github.com/users/fdurupinar/events{/privacy}","received_events_url":"https://api.github.com/users/fdurupinar/received_events","type":"User","site_admin":false},"labels":[{"id":2488634,"url":"https://api.github.com/repos/PathwayCommons/factoid/labels/bug","name":"bug","color":"e11d21","default":true}],"state":"open","locked":false,"assignee":{"login":"maxkfranz","id":989043,"avatar_url":"https://avatars0.githubusercontent.com/u/989043?v=4","gravatar_id":"","url":"https://api.github.com/users/maxkfranz","html_url":"https://github.com/maxkfranz","followers_url":"https://api.github.com/users/maxkfranz/followers","following_url":"https://api.github.com/users/maxkfranz/following{/other_user}","gists_url":"https://api.github.com/users/maxkfranz/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkfranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkfranz/subscriptions","organizations_url":"https://api.github.com/users/maxkfranz/orgs","repos_url":"https://api.github.com/users/maxkfranz/repos","events_url":"https://api.github.com/users/maxkfranz/events{/privacy}","received_events_url":"https://api.github.com/users/maxkfranz/received_events","type":"User","site_admin":false},"assignees":[{"login":"maxkfranz","id":989043,"avatar_url":"https://avatars0.githubusercontent.com/u/989043?v=4","gravatar_id":"","url":"https://api.github.com/users/maxkfranz","html_url":"https://github.com/maxkfranz","followers_url":"https://api.github.com/users/maxkfranz/followers","following_url":"https://api.github.com/users/maxkfranz/following{/other_user}","gists_url":"https://api.github.com/users/maxkfranz/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkfranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkfranz/subscriptions","organizations_url":"https://api.github.com/users/maxkfranz/orgs","repos_url":"https://api.github.com/users/maxkfranz/repos","events_url":"https://api.github.com/users/maxkfranz/events{/privacy}","received_events_url":"https://api.github.com/users/maxkfranz/received_events","type":"User","site_admin":false},{"login":"metincansiper","id":6534865,"avatar_url":"https://avatars1.githubusercontent.com/u/6534865?v=4","gravatar_id":"","url":"https://api.github.com/users/metincansiper","html_url":"https://github.com/metincansiper","followers_url":"https://api.github.com/users/metincansiper/followers","following_url":"https://api.github.com/users/metincansiper/following{/other_user}","gists_url":"https://api.github.com/users/metincansiper/gists{/gist_id}","starred_url":"https://api.github.com/users/metincansiper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metincansiper/subscriptions","organizations_url":"https://api.github.com/users/metincansiper/orgs","repos_url":"https://api.github.com/users/metincansiper/repos","events_url":"https://api.github.com/users/metincansiper/events{/privacy}","received_events_url":"https://api.github.com/users/metincansiper/received_events","type":"User","site_admin":false},{"login":"fdurupinar","id":13474166,"avatar_url":"https://avatars2.githubusercontent.com/u/13474166?v=4","gravatar_id":"","url":"https://api.github.com/users/fdurupinar","html_url":"https://github.com/fdurupinar","followers_url":"https://api.github.com/users/fdurupinar/followers","following_url":"https://api.github.com/users/fdurupinar/following{/other_user}","gists_url":"https://api.github.com/users/fdurupinar/gists{/gist_id}","starred_url":"https://api.github.com/users/fdurupinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdurupinar/subscriptions","organizations_url":"https://api.github.com/users/fdurupinar/orgs","repos_url":"https://api.github.com/users/fdurupinar/repos","events_url":"https://api.github.com/users/fdurupinar/events{/privacy}","received_events_url":"https://api.github.com/users/fdurupinar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-04-10T22:08:27Z","updated_at":"2018-04-12T18:09:40Z","closed_at":null,"author_association":"NONE","body":"\r\n## Current (buggy) behaviour\r\nWhen an entity name is updated in the form, its popover does not reflect this change. E.g.\r\nThe entity name is initially correctly selected as RAF (1), but it cannot be updated to AKT1 (1).\r\n\r\n1. \r\n\r\n ![screen shot 2018-04-10 at 3 01 36 pm](https://user-images.githubusercontent.com/13474166/38585847-420e15d0-3cd0-11e8-81f2-df76c0a09aa7.png)\r\n\r\n2.\r\n\r\n ![screen shot 2018-04-10 at 3 01 53 pm](https://user-images.githubusercontent.com/13474166/38585854-43e982b8-3cd0-11e8-9c04-b8f930328f18.png)\r\n\r\n\r\n## Minimum steps to reproduce\r\nIn the form UI:\r\n\r\n- Writea gene name in an entity box and click on the box to see its grounding popover.\r\n- Press esc and update the entity name.\r\n- Click on the entity box again to see that entity name is not updated.\r\n\r\n## Relevant code\r\nhttps://github.com/PathwayCommons/factoid/blob/4bddc5b0838c24ef44f28671320b40484d12cfb7/src/client/components/form-editor/entity-form.js#L68-L76\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PathwayCommons/factoid/issues/comments/380895771","html_url":"https://github.com/PathwayCommons/factoid/issues/248#issuecomment-380895771","issue_url":"https://api.github.com/repos/PathwayCommons/factoid/issues/248","id":380895771,"user":{"login":"fdurupinar","id":13474166,"avatar_url":"https://avatars2.githubusercontent.com/u/13474166?v=4","gravatar_id":"","url":"https://api.github.com/users/fdurupinar","html_url":"https://github.com/fdurupinar","followers_url":"https://api.github.com/users/fdurupinar/followers","following_url":"https://api.github.com/users/fdurupinar/following{/other_user}","gists_url":"https://api.github.com/users/fdurupinar/gists{/gist_id}","starred_url":"https://api.github.com/users/fdurupinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdurupinar/subscriptions","organizations_url":"https://api.github.com/users/fdurupinar/orgs","repos_url":"https://api.github.com/users/fdurupinar/repos","events_url":"https://api.github.com/users/fdurupinar/events{/privacy}","received_events_url":"https://api.github.com/users/fdurupinar/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T18:09:40Z","updated_at":"2018-04-12T18:09:40Z","author_association":"NONE","body":"In this specific case, although we achieve the desired result, using name as a key is not the best solution. \r\n\r\nHere, EntityInfo is updated even when \"name\" is not passed as a key, but Popover is not:\r\nhttps://github.com/PathwayCommons/factoid/blob/4bddc5b0838c24ef44f28671320b40484d12cfb7/src/client/components/form-editor/entity-form.js#L68"}}
{"actor":{"display_login":"fdurupinar"}}