{"action":"closed","number":49404,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49404","id":235196650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTk2NjUw","html_url":"https://github.com/ansible/ansible/pull/49404","diff_url":"https://github.com/ansible/ansible/pull/49404.diff","patch_url":"https://github.com/ansible/ansible/pull/49404.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49404","number":49404,"state":"closed","locked":false,"title":"Rabbitmq user permission fixes","user":{"login":"ptzianos","id":1652175,"node_id":"MDQ6VXNlcjE2NTIxNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1652175?v=4","gravatar_id":"","url":"https://api.github.com/users/ptzianos","html_url":"https://github.com/ptzianos","followers_url":"https://api.github.com/users/ptzianos/followers","following_url":"https://api.github.com/users/ptzianos/following{/other_user}","gists_url":"https://api.github.com/users/ptzianos/gists{/gist_id}","starred_url":"https://api.github.com/users/ptzianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptzianos/subscriptions","organizations_url":"https://api.github.com/users/ptzianos/orgs","repos_url":"https://api.github.com/users/ptzianos/repos","events_url":"https://api.github.com/users/ptzianos/events{/privacy}","received_events_url":"https://api.github.com/users/ptzianos/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\n\r\nFixes #49120 but in a different way\r\nImproves the situation with #29281\r\n\r\nThe purpose of this PR is to improve the idempotency of the module using Python features that behave consistently in version 2.7 and 3.5+.\r\n\r\nChanges have been tested in Python 2.7.15, 3.5.6, 3.6.7, 3.7.1.\r\n\r\nChanges:\r\n1. Further improves the method that checks whether or not the permissions of a user are modified to ensure consistent behavior.\r\n2. Adds some checks to ensure that the user permissions dictionary list is correct.\r\n3. Simplifies the code that modifies the permissions of the user.\r\n4. Includes tests for all the changes introduced in the PR plus some for existing functionality.\r\n5. Adds helper for simulating `collections.Counter` in Python 2.6\r\n\r\nThis is a first batch of fixes for this module. More will follow to eventually add full test coverage for the module and make the module idempotent.\r\n\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue -->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Write the short name of the module, plugin, task or feature below -->\r\nrabbitmq_user","created_at":"2018-12-01T14:36:28Z","updated_at":"2018-12-07T13:19:09Z","closed_at":"2018-12-07T13:19:09Z","merged_at":"2018-12-07T13:19:09Z","merge_commit_sha":"a4eb4b2551c62c350100b7e3dbf8692295db13b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/49404/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/49404/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49404/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/fc8f3febce6f6f15ae33afd42d8b6557af69473d","head":{"label":"ptzianos:rabbitmq_user_permission_fixes","ref":"rabbitmq_user_permission_fixes","sha":"fc8f3febce6f6f15ae33afd42d8b6557af69473d","user":{"login":"ptzianos","id":1652175,"node_id":"MDQ6VXNlcjE2NTIxNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1652175?v=4","gravatar_id":"","url":"https://api.github.com/users/ptzianos","html_url":"https://github.com/ptzianos","followers_url":"https://api.github.com/users/ptzianos/followers","following_url":"https://api.github.com/users/ptzianos/following{/other_user}","gists_url":"https://api.github.com/users/ptzianos/gists{/gist_id}","starred_url":"https://api.github.com/users/ptzianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptzianos/subscriptions","organizations_url":"https://api.github.com/users/ptzianos/orgs","repos_url":"https://api.github.com/users/ptzianos/repos","events_url":"https://api.github.com/users/ptzianos/events{/privacy}","received_events_url":"https://api.github.com/users/ptzianos/received_events","type":"User","site_admin":false},"repo":{"id":159950489,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk5NTA0ODk=","name":"ansible","full_name":"ptzianos/ansible","private":false,"owner":{"login":"ptzianos","id":1652175,"node_id":"MDQ6VXNlcjE2NTIxNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1652175?v=4","gravatar_id":"","url":"https://api.github.com/users/ptzianos","html_url":"https://github.com/ptzianos","followers_url":"https://api.github.com/users/ptzianos/followers","following_url":"https://api.github.com/users/ptzianos/following{/other_user}","gists_url":"https://api.github.com/users/ptzianos/gists{/gist_id}","starred_url":"https://api.github.com/users/ptzianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptzianos/subscriptions","organizations_url":"https://api.github.com/users/ptzianos/orgs","repos_url":"https://api.github.com/users/ptzianos/repos","events_url":"https://api.github.com/users/ptzianos/events{/privacy}","received_events_url":"https://api.github.com/users/ptzianos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ptzianos/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/ptzianos/ansible","forks_url":"https://api.github.com/repos/ptzianos/ansible/forks","keys_url":"https://api.github.com/repos/ptzianos/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptzianos/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptzianos/ansible/teams","hooks_url":"https://api.github.com/repos/ptzianos/ansible/hooks","issue_events_url":"https://api.github.com/repos/ptzianos/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ptzianos/ansible/events","assignees_url":"https://api.github.com/repos/ptzianos/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ptzianos/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ptzianos/ansible/tags","blobs_url":"https://api.github.com/repos/ptzianos/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptzianos/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptzianos/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptzianos/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptzianos/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ptzianos/ansible/languages","stargazers_url":"https://api.github.com/repos/ptzianos/ansible/stargazers","contributors_url":"https://api.github.com/repos/ptzianos/ansible/contributors","subscribers_url":"https://api.github.com/repos/ptzianos/ansible/subscribers","subscription_url":"https://api.github.com/repos/ptzianos/ansible/subscription","commits_url":"https://api.github.com/repos/ptzianos/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptzianos/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptzianos/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptzianos/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptzianos/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ptzianos/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptzianos/ansible/merges","archive_url":"https://api.github.com/repos/ptzianos/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptzianos/ansible/downloads","issues_url":"https://api.github.com/repos/ptzianos/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ptzianos/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ptzianos/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ptzianos/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptzianos/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ptzianos/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ptzianos/ansible/deployments","created_at":"2018-12-01T14:04:34Z","updated_at":"2018-12-01T14:05:06Z","pushed_at":"2018-12-07T09:20:37Z","git_url":"git://github.com/ptzianos/ansible.git","ssh_url":"git@github.com:ptzianos/ansible.git","clone_url":"https://github.com/ptzianos/ansible.git","svn_url":"https://github.com/ptzianos/ansible","homepage":"https://www.ansible.com/","size":139318,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"a1a0893ebd106d6ad3f889ae08ecd81141d34cea","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-12-07T12:35:44Z","pushed_at":"2018-12-07T13:19:09Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":147392,"stargazers_count":34163,"watchers_count":34163,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13703,"mirror_url":null,"archived":false,"open_issues_count":5529,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13703,"open_issues":5529,"watchers":34163,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49404"},"html":{"href":"https://github.com/ansible/ansible/pull/49404"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/49404"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/49404/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49404/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49404/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/fc8f3febce6f6f15ae33afd42d8b6557af69473d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gundalow","id":940557,"node_id":"MDQ6VXNlcjk0MDU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/940557?v=4","gravatar_id":"","url":"https://api.github.com/users/gundalow","html_url":"https://github.com/gundalow","followers_url":"https://api.github.com/users/gundalow/followers","following_url":"https://api.github.com/users/gundalow/following{/other_user}","gists_url":"https://api.github.com/users/gundalow/gists{/gist_id}","starred_url":"https://api.github.com/users/gundalow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gundalow/subscriptions","organizations_url":"https://api.github.com/users/gundalow/orgs","repos_url":"https://api.github.com/users/gundalow/repos","events_url":"https://api.github.com/users/gundalow/events{/privacy}","received_events_url":"https://api.github.com/users/gundalow/received_events","type":"User","site_admin":false},"comments":9,"review_comments":1,"maintainer_can_modify":false,"commits":6,"additions":174,"deletions":21,"changed_files":5}}
{"actor":{"display_login":"gundalow"}}