{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/225030703","pull_request_review_id":164540764,"id":225030703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTAzMDcwMw==","diff_hunk":"@@ -6013,7 +6013,7 @@ enum {\n     CFFormatDummyPointerType = 42\t/* special case for %n */\n };\n \n-#if DEPLOYMENT_TARGET_MACOSX || DEPLOYMENT_TARGET_EMBEDDED || DEPLOYMENT_TARGET_WINDOWS\n+#if DEPLOYMENT_TARGET_MACOSX || DEPLOYMENT_TARGET_EMBEDDED || DEPLOYMENT_TARGET_WINDOWS || DEPLOYMENT_TARGET_LINUX","path":"CoreFoundation/String.subproj/CFString.c","position":null,"original_position":5,"commit_id":"94e6c021020d1cfc67f51f19cc770246689975af","original_commit_id":"aa9e13da27469632fdc54fd6824f036b2067672a","user":{"login":"millenomi","id":44005,"node_id":"MDQ6VXNlcjQ0MDA1","avatar_url":"https://avatars0.githubusercontent.com/u/44005?v=4","gravatar_id":"","url":"https://api.github.com/users/millenomi","html_url":"https://github.com/millenomi","followers_url":"https://api.github.com/users/millenomi/followers","following_url":"https://api.github.com/users/millenomi/following{/other_user}","gists_url":"https://api.github.com/users/millenomi/gists{/gist_id}","starred_url":"https://api.github.com/users/millenomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millenomi/subscriptions","organizations_url":"https://api.github.com/users/millenomi/orgs","repos_url":"https://api.github.com/users/millenomi/repos","events_url":"https://api.github.com/users/millenomi/events{/privacy}","received_events_url":"https://api.github.com/users/millenomi/received_events","type":"User","site_admin":false},"body":"_MAC includes _IPHONE and _OSX; _IPHONE includes _IOS, _WATCH etc.","created_at":"2018-10-15T03:32:20Z","updated_at":"2018-10-15T03:32:21Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1724#discussion_r225030703","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/225030703"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1724#discussion_r225030703"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724"}},"in_reply_to_id":225007352},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724","id":222701150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzAxMTUw","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1724","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1724.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1724.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1724","number":1724,"state":"open","locked":false,"title":"SR-1464: NSNumber.description is not compatible between OS X and linux","user":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"body":"- Use Swift's stringification of numbers for .description and .stringValue\r\n\r\n- Use String(format:locale:...) with the correct format for the\r\n  NSNumber type if locale is not nil.\r\n\r\n- Enable use of __CFStringFormatLocalizedNumber() on\r\n  DEPLOYMENT_TARGET_LINUX.","created_at":"2018-10-14T08:35:06Z","updated_at":"2018-10-15T03:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a47ed992f324dc441292da359bcbbd0ff380714","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1724/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/94e6c021020d1cfc67f51f19cc770246689975af","head":{"label":"spevans:pr_sr_1464","ref":"pr_sr_1464","sha":"94e6c021020d1cfc67f51f19cc770246689975af","user":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"repo":{"id":64701801,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwMTgwMQ==","name":"swift-corelibs-foundation","full_name":"spevans/swift-corelibs-foundation","private":false,"owner":{"login":"spevans","id":1093011,"node_id":"MDQ6VXNlcjEwOTMwMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1093011?v=4","gravatar_id":"","url":"https://api.github.com/users/spevans","html_url":"https://github.com/spevans","followers_url":"https://api.github.com/users/spevans/followers","following_url":"https://api.github.com/users/spevans/following{/other_user}","gists_url":"https://api.github.com/users/spevans/gists{/gist_id}","starred_url":"https://api.github.com/users/spevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spevans/subscriptions","organizations_url":"https://api.github.com/users/spevans/orgs","repos_url":"https://api.github.com/users/spevans/repos","events_url":"https://api.github.com/users/spevans/events{/privacy}","received_events_url":"https://api.github.com/users/spevans/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spevans/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/spevans/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/spevans/swift-corelibs-foundation/deployments","created_at":"2016-08-01T21:09:21Z","updated_at":"2017-09-06T13:14:21Z","pushed_at":"2018-10-14T21:14:12Z","git_url":"git://github.com/spevans/swift-corelibs-foundation.git","ssh_url":"git@github.com:spevans/swift-corelibs-foundation.git","clone_url":"https://github.com/spevans/swift-corelibs-foundation.git","svn_url":"https://github.com/spevans/swift-corelibs-foundation","homepage":"swift.org","size":13678,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"544238d2f8b40e12bf3192309bd7b5dc030fb9fd","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2Mzg5MA==","name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2018-10-14T23:46:52Z","pushed_at":"2018-10-15T01:14:27Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":14046,"stargazers_count":3128,"watchers_count":3128,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":757,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":757,"open_issues":38,"watchers":3128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/1724"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1724"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1724/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1724/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/94e6c021020d1cfc67f51f19cc770246689975af"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"millenomi"}}