{"action":"created","comment":{"url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/comments/195300482","pull_request_review_id":128635907,"id":195300482,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTMwMDQ4Mg==","diff_hunk":"@@ -0,0 +1,106 @@\n+<template>\n+  <div class=\"notification-list-container\" @scroll=\"infiniteScroll\">\n+    <app-header showDefaultHeaderNav showOnlySessionLinksOnPc class=\"logo-original\"/>\n+    <h1 class=\"area-title\">{{ title }}</h1>\n+    <notification-card-list :notifications=\"notifications\"/>\n+    <the-loader :lastEvaluatedKey=\"notificationsLastEvaluatedKey\"/>\n+    <app-footer/>\n+  </div>\n+</template>\n+\n+<script>\n+import { mapGetters, mapActions } from 'vuex'\n+import AppHeader from '../organisms/AppHeader'\n+import NotificationCardList from '../organisms/NotificationCardList'\n+import TheLoader from '../atoms/TheLoader'\n+import AppFooter from '../organisms/AppFooter'\n+\n+export default {\n+  components: {\n+    AppHeader,\n+    NotificationCardList,\n+    TheLoader,\n+    AppFooter\n+  },\n+  computed: {\n+    title() {\n+      return 'お知らせ'\n+    },\n+    ...mapGetters('user', ['notifications', 'notificationsLastEvaluatedKey', 'hasNotificationsLastEvaluatedKey'])","path":"app/components/pages/NotificationPage.vue","position":29,"original_position":29,"commit_id":"fb277c0eb7260fb566856055c4283cb4bd16f869","original_commit_id":"fb277c0eb7260fb566856055c4283cb4bd16f869","user":{"login":"y-temp4","id":13657589,"node_id":"MDQ6VXNlcjEzNjU3NTg5","avatar_url":"https://avatars0.githubusercontent.com/u/13657589?v=4","gravatar_id":"","url":"https://api.github.com/users/y-temp4","html_url":"https://github.com/y-temp4","followers_url":"https://api.github.com/users/y-temp4/followers","following_url":"https://api.github.com/users/y-temp4/following{/other_user}","gists_url":"https://api.github.com/users/y-temp4/gists{/gist_id}","starred_url":"https://api.github.com/users/y-temp4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-temp4/subscriptions","organizations_url":"https://api.github.com/users/y-temp4/orgs","repos_url":"https://api.github.com/users/y-temp4/repos","events_url":"https://api.github.com/users/y-temp4/events{/privacy}","received_events_url":"https://api.github.com/users/y-temp4/received_events","type":"User","site_admin":false},"body":"`notificationListScrollHeight`の呼び出しが必要ですね。\r\n\r\n```js\r\n    ...mapGetters('presentation', ['notificationListScrollHeight'])\r\n```","created_at":"2018-06-14T04:37:09Z","updated_at":"2018-06-14T04:46:14Z","html_url":"https://github.com/AlisProject/frontend-application/pull/242#discussion_r195300482","pull_request_url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/comments/195300482"},"html":{"href":"https://github.com/AlisProject/frontend-application/pull/242#discussion_r195300482"},"pull_request":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242","id":192187649,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTg3NjQ5","html_url":"https://github.com/AlisProject/frontend-application/pull/242","diff_url":"https://github.com/AlisProject/frontend-application/pull/242.diff","patch_url":"https://github.com/AlisProject/frontend-application/pull/242.patch","issue_url":"https://api.github.com/repos/AlisProject/frontend-application/issues/242","number":242,"state":"open","locked":false,"title":"ALIS-915: Notification feature","user":{"login":"matsumatsu20","id":9876274,"node_id":"MDQ6VXNlcjk4NzYyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9876274?v=4","gravatar_id":"","url":"https://api.github.com/users/matsumatsu20","html_url":"https://github.com/matsumatsu20","followers_url":"https://api.github.com/users/matsumatsu20/followers","following_url":"https://api.github.com/users/matsumatsu20/following{/other_user}","gists_url":"https://api.github.com/users/matsumatsu20/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumatsu20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumatsu20/subscriptions","organizations_url":"https://api.github.com/users/matsumatsu20/orgs","repos_url":"https://api.github.com/users/matsumatsu20/repos","events_url":"https://api.github.com/users/matsumatsu20/events{/privacy}","received_events_url":"https://api.github.com/users/matsumatsu20/received_events","type":"User","site_admin":false},"body":"## 概要\r\n* ユーザーが通知（現時点ではいいねの通知）の一覧を確認できるようにする\r\n\r\n## 環境変数(SSMパラメータ)\r\n特になし\r\n\r\n## 影響範囲(ユーザ)\r\n* 全ユーザー\r\n\r\n## 影響範囲(システム) \r\n- サーバレス\r\n- フロントエンド\r\n\r\n## 技術的変更点概要\r\n* /me/notificationにルーティングを追加\r\n  * 上記画面で通知一覧APIをcallし、返却結果を描画（無限スクロールなどindexに必要な処理も含む）\r\n  * 上記画面で未読管理APIにputをして、未読状態を解除している\r\n* ログインユーザー用のヘッダー（ユーザーアイコンや通知アイコンが出ているところ）のmount時に未読状態を確認するAPIをcallして、未読状態を管理するstateを更新している（これによって赤ポチが出たり消えたりしている）\r\n\r\n## 使い方\r\n* 特になし\r\n\r\n## 個人情報の取り扱いに変更のあるリリースか\r\n* ユーザー名の描画のみ\r\n  * かつそのユーザー名は公開されているものである。\r\n\r\n## テスト結果とテスト項目\r\n\r\n- [ ] 通知の一覧が問題なく表示できるか\r\n- [ ] 10件以上ある場合、ページネーション処理で10件以上表示できるか\r\n- [ ] 通知カードをクリックするとその記事の公開用URLへ遷移するか\r\n- [ ] 全体的にデザインは崩れていないか\r\n- [ ] 未読の通知が存在する場合（新規にいいねされた時）は通知アイコンに赤い丸が付いているか\r\n- [ ] 通知一覧に遷移したら赤い丸が消えるか\r\n\r\n## 残タスク\r\n- [x] CSSの調整（デザイン調整）\r\n- [x] サーバ側のバグ修正（自分にいいねした時に通知対象に含めないようにする）\r\n## 注意点・その他\r\n* 特になし","created_at":"2018-06-02T08:39:29Z","updated_at":"2018-06-14T04:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dde404f344f6078a08537befb3ef371d70324515","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242/commits","review_comments_url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242/comments","review_comment_url":"https://api.github.com/repos/AlisProject/frontend-application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlisProject/frontend-application/issues/242/comments","statuses_url":"https://api.github.com/repos/AlisProject/frontend-application/statuses/fb277c0eb7260fb566856055c4283cb4bd16f869","head":{"label":"matsumatsu20:feature-notification","ref":"feature-notification","sha":"fb277c0eb7260fb566856055c4283cb4bd16f869","user":{"login":"matsumatsu20","id":9876274,"node_id":"MDQ6VXNlcjk4NzYyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9876274?v=4","gravatar_id":"","url":"https://api.github.com/users/matsumatsu20","html_url":"https://github.com/matsumatsu20","followers_url":"https://api.github.com/users/matsumatsu20/followers","following_url":"https://api.github.com/users/matsumatsu20/following{/other_user}","gists_url":"https://api.github.com/users/matsumatsu20/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumatsu20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumatsu20/subscriptions","organizations_url":"https://api.github.com/users/matsumatsu20/orgs","repos_url":"https://api.github.com/users/matsumatsu20/repos","events_url":"https://api.github.com/users/matsumatsu20/events{/privacy}","received_events_url":"https://api.github.com/users/matsumatsu20/received_events","type":"User","site_admin":false},"repo":{"id":129097875,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwOTc4NzU=","name":"frontend-application","full_name":"matsumatsu20/frontend-application","owner":{"login":"matsumatsu20","id":9876274,"node_id":"MDQ6VXNlcjk4NzYyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9876274?v=4","gravatar_id":"","url":"https://api.github.com/users/matsumatsu20","html_url":"https://github.com/matsumatsu20","followers_url":"https://api.github.com/users/matsumatsu20/followers","following_url":"https://api.github.com/users/matsumatsu20/following{/other_user}","gists_url":"https://api.github.com/users/matsumatsu20/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumatsu20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumatsu20/subscriptions","organizations_url":"https://api.github.com/users/matsumatsu20/orgs","repos_url":"https://api.github.com/users/matsumatsu20/repos","events_url":"https://api.github.com/users/matsumatsu20/events{/privacy}","received_events_url":"https://api.github.com/users/matsumatsu20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matsumatsu20/frontend-application","description":"💮 ALIS Media - Frontend Application","fork":true,"url":"https://api.github.com/repos/matsumatsu20/frontend-application","forks_url":"https://api.github.com/repos/matsumatsu20/frontend-application/forks","keys_url":"https://api.github.com/repos/matsumatsu20/frontend-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsumatsu20/frontend-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsumatsu20/frontend-application/teams","hooks_url":"https://api.github.com/repos/matsumatsu20/frontend-application/hooks","issue_events_url":"https://api.github.com/repos/matsumatsu20/frontend-application/issues/events{/number}","events_url":"https://api.github.com/repos/matsumatsu20/frontend-application/events","assignees_url":"https://api.github.com/repos/matsumatsu20/frontend-application/assignees{/user}","branches_url":"https://api.github.com/repos/matsumatsu20/frontend-application/branches{/branch}","tags_url":"https://api.github.com/repos/matsumatsu20/frontend-application/tags","blobs_url":"https://api.github.com/repos/matsumatsu20/frontend-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsumatsu20/frontend-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsumatsu20/frontend-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsumatsu20/frontend-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsumatsu20/frontend-application/statuses/{sha}","languages_url":"https://api.github.com/repos/matsumatsu20/frontend-application/languages","stargazers_url":"https://api.github.com/repos/matsumatsu20/frontend-application/stargazers","contributors_url":"https://api.github.com/repos/matsumatsu20/frontend-application/contributors","subscribers_url":"https://api.github.com/repos/matsumatsu20/frontend-application/subscribers","subscription_url":"https://api.github.com/repos/matsumatsu20/frontend-application/subscription","commits_url":"https://api.github.com/repos/matsumatsu20/frontend-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsumatsu20/frontend-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsumatsu20/frontend-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsumatsu20/frontend-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsumatsu20/frontend-application/contents/{+path}","compare_url":"https://api.github.com/repos/matsumatsu20/frontend-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsumatsu20/frontend-application/merges","archive_url":"https://api.github.com/repos/matsumatsu20/frontend-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsumatsu20/frontend-application/downloads","issues_url":"https://api.github.com/repos/matsumatsu20/frontend-application/issues{/number}","pulls_url":"https://api.github.com/repos/matsumatsu20/frontend-application/pulls{/number}","milestones_url":"https://api.github.com/repos/matsumatsu20/frontend-application/milestones{/number}","notifications_url":"https://api.github.com/repos/matsumatsu20/frontend-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsumatsu20/frontend-application/labels{/name}","releases_url":"https://api.github.com/repos/matsumatsu20/frontend-application/releases{/id}","deployments_url":"https://api.github.com/repos/matsumatsu20/frontend-application/deployments","created_at":"2018-04-11T13:26:38Z","updated_at":"2018-04-11T13:26:40Z","pushed_at":"2018-06-13T16:46:18Z","git_url":"git://github.com/matsumatsu20/frontend-application.git","ssh_url":"git@github.com:matsumatsu20/frontend-application.git","clone_url":"https://github.com/matsumatsu20/frontend-application.git","svn_url":"https://github.com/matsumatsu20/frontend-application","homepage":"","size":3724,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AlisProject:master","ref":"master","sha":"58d85d15ea2076f503ae055b6578e3728b59391d","user":{"login":"AlisProject","id":29245117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjQ1MTE3","avatar_url":"https://avatars2.githubusercontent.com/u/29245117?v=4","gravatar_id":"","url":"https://api.github.com/users/AlisProject","html_url":"https://github.com/AlisProject","followers_url":"https://api.github.com/users/AlisProject/followers","following_url":"https://api.github.com/users/AlisProject/following{/other_user}","gists_url":"https://api.github.com/users/AlisProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AlisProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlisProject/subscriptions","organizations_url":"https://api.github.com/users/AlisProject/orgs","repos_url":"https://api.github.com/users/AlisProject/repos","events_url":"https://api.github.com/users/AlisProject/events{/privacy}","received_events_url":"https://api.github.com/users/AlisProject/received_events","type":"Organization","site_admin":false},"repo":{"id":117187953,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxODc5NTM=","name":"frontend-application","full_name":"AlisProject/frontend-application","owner":{"login":"AlisProject","id":29245117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjQ1MTE3","avatar_url":"https://avatars2.githubusercontent.com/u/29245117?v=4","gravatar_id":"","url":"https://api.github.com/users/AlisProject","html_url":"https://github.com/AlisProject","followers_url":"https://api.github.com/users/AlisProject/followers","following_url":"https://api.github.com/users/AlisProject/following{/other_user}","gists_url":"https://api.github.com/users/AlisProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AlisProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlisProject/subscriptions","organizations_url":"https://api.github.com/users/AlisProject/orgs","repos_url":"https://api.github.com/users/AlisProject/repos","events_url":"https://api.github.com/users/AlisProject/events{/privacy}","received_events_url":"https://api.github.com/users/AlisProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AlisProject/frontend-application","description":"💮 ALIS Media - Frontend Application","fork":false,"url":"https://api.github.com/repos/AlisProject/frontend-application","forks_url":"https://api.github.com/repos/AlisProject/frontend-application/forks","keys_url":"https://api.github.com/repos/AlisProject/frontend-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlisProject/frontend-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlisProject/frontend-application/teams","hooks_url":"https://api.github.com/repos/AlisProject/frontend-application/hooks","issue_events_url":"https://api.github.com/repos/AlisProject/frontend-application/issues/events{/number}","events_url":"https://api.github.com/repos/AlisProject/frontend-application/events","assignees_url":"https://api.github.com/repos/AlisProject/frontend-application/assignees{/user}","branches_url":"https://api.github.com/repos/AlisProject/frontend-application/branches{/branch}","tags_url":"https://api.github.com/repos/AlisProject/frontend-application/tags","blobs_url":"https://api.github.com/repos/AlisProject/frontend-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlisProject/frontend-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlisProject/frontend-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlisProject/frontend-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlisProject/frontend-application/statuses/{sha}","languages_url":"https://api.github.com/repos/AlisProject/frontend-application/languages","stargazers_url":"https://api.github.com/repos/AlisProject/frontend-application/stargazers","contributors_url":"https://api.github.com/repos/AlisProject/frontend-application/contributors","subscribers_url":"https://api.github.com/repos/AlisProject/frontend-application/subscribers","subscription_url":"https://api.github.com/repos/AlisProject/frontend-application/subscription","commits_url":"https://api.github.com/repos/AlisProject/frontend-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlisProject/frontend-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlisProject/frontend-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlisProject/frontend-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlisProject/frontend-application/contents/{+path}","compare_url":"https://api.github.com/repos/AlisProject/frontend-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlisProject/frontend-application/merges","archive_url":"https://api.github.com/repos/AlisProject/frontend-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlisProject/frontend-application/downloads","issues_url":"https://api.github.com/repos/AlisProject/frontend-application/issues{/number}","pulls_url":"https://api.github.com/repos/AlisProject/frontend-application/pulls{/number}","milestones_url":"https://api.github.com/repos/AlisProject/frontend-application/milestones{/number}","notifications_url":"https://api.github.com/repos/AlisProject/frontend-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlisProject/frontend-application/labels{/name}","releases_url":"https://api.github.com/repos/AlisProject/frontend-application/releases{/id}","deployments_url":"https://api.github.com/repos/AlisProject/frontend-application/deployments","created_at":"2018-01-12T03:33:55Z","updated_at":"2018-06-08T05:13:55Z","pushed_at":"2018-06-13T16:46:20Z","git_url":"git://github.com/AlisProject/frontend-application.git","ssh_url":"git@github.com:AlisProject/frontend-application.git","clone_url":"https://github.com/AlisProject/frontend-application.git","svn_url":"https://github.com/AlisProject/frontend-application","homepage":"https://alis.to","size":3683,"stargazers_count":40,"watchers_count":40,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":7,"open_issues":11,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242"},"html":{"href":"https://github.com/AlisProject/frontend-application/pull/242"},"issue":{"href":"https://api.github.com/repos/AlisProject/frontend-application/issues/242"},"comments":{"href":"https://api.github.com/repos/AlisProject/frontend-application/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlisProject/frontend-application/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/AlisProject/frontend-application/statuses/fb277c0eb7260fb566856055c4283cb4bd16f869"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"y-temp4"}}