{"action":"closed","number":391,"pull_request":{"url":"https://api.github.com/repos/icatproject/topcat/pulls/391","id":231981781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTgxNzgx","html_url":"https://github.com/icatproject/topcat/pull/391","diff_url":"https://github.com/icatproject/topcat/pull/391.diff","patch_url":"https://github.com/icatproject/topcat/pull/391.patch","issue_url":"https://api.github.com/repos/icatproject/topcat/issues/391","number":391,"state":"closed","locked":false,"title":"Make setup mail properties optional","user":{"login":"brianritchie1312","id":12734386,"node_id":"MDQ6VXNlcjEyNzM0Mzg2","avatar_url":"https://avatars0.githubusercontent.com/u/12734386?v=4","gravatar_id":"","url":"https://api.github.com/users/brianritchie1312","html_url":"https://github.com/brianritchie1312","followers_url":"https://api.github.com/users/brianritchie1312/followers","following_url":"https://api.github.com/users/brianritchie1312/following{/other_user}","gists_url":"https://api.github.com/users/brianritchie1312/gists{/gist_id}","starred_url":"https://api.github.com/users/brianritchie1312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianritchie1312/subscriptions","organizations_url":"https://api.github.com/users/brianritchie1312/orgs","repos_url":"https://api.github.com/users/brianritchie1312/repos","events_url":"https://api.github.com/users/brianritchie1312/events{/privacy}","received_events_url":"https://api.github.com/users/brianritchie1312/received_events","type":"User","site_admin":false},"body":"If any of the mail.xxx properties in topcat-setup.properties are omitted, do not create the mail resource. (Previously, omission caused setup to fail.)\r\nIn this case, mail.enable MUST NOT be set to true in topcat.properties. This is not tested during setup. Added a note to the installation notes to point this out.\r\nFixes #389.","created_at":"2018-11-19T13:56:36Z","updated_at":"2018-11-19T15:21:42Z","closed_at":"2018-11-19T15:21:42Z","merged_at":"2018-11-19T15:21:41Z","merge_commit_sha":"47e2109e383ffd2942cad8f235b4615f64f86c9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":225977381,"node_id":"MDU6TGFiZWwyMjU5NzczODE=","url":"https://api.github.com/repos/icatproject/topcat/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/icatproject/topcat/pulls/391/commits","review_comments_url":"https://api.github.com/repos/icatproject/topcat/pulls/391/comments","review_comment_url":"https://api.github.com/repos/icatproject/topcat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icatproject/topcat/issues/391/comments","statuses_url":"https://api.github.com/repos/icatproject/topcat/statuses/4512959f46b169f31e1307131764fd0013f2b1a7","head":{"label":"icatproject:issue#389-make-setup-mail-props-optional","ref":"issue#389-make-setup-mail-props-optional","sha":"4512959f46b169f31e1307131764fd0013f2b1a7","user":{"login":"icatproject","id":11672419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjcyNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/11672419?v=4","gravatar_id":"","url":"https://api.github.com/users/icatproject","html_url":"https://github.com/icatproject","followers_url":"https://api.github.com/users/icatproject/followers","following_url":"https://api.github.com/users/icatproject/following{/other_user}","gists_url":"https://api.github.com/users/icatproject/gists{/gist_id}","starred_url":"https://api.github.com/users/icatproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icatproject/subscriptions","organizations_url":"https://api.github.com/users/icatproject/orgs","repos_url":"https://api.github.com/users/icatproject/repos","events_url":"https://api.github.com/users/icatproject/events{/privacy}","received_events_url":"https://api.github.com/users/icatproject/received_events","type":"Organization","site_admin":false},"repo":{"id":36436300,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQzNjMwMA==","name":"topcat","full_name":"icatproject/topcat","private":false,"owner":{"login":"icatproject","id":11672419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjcyNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/11672419?v=4","gravatar_id":"","url":"https://api.github.com/users/icatproject","html_url":"https://github.com/icatproject","followers_url":"https://api.github.com/users/icatproject/followers","following_url":"https://api.github.com/users/icatproject/following{/other_user}","gists_url":"https://api.github.com/users/icatproject/gists{/gist_id}","starred_url":"https://api.github.com/users/icatproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icatproject/subscriptions","organizations_url":"https://api.github.com/users/icatproject/orgs","repos_url":"https://api.github.com/users/icatproject/repos","events_url":"https://api.github.com/users/icatproject/events{/privacy}","received_events_url":"https://api.github.com/users/icatproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/icatproject/topcat","description":"GUI to work with multiple ICAT and IDS servers.","fork":false,"url":"https://api.github.com/repos/icatproject/topcat","forks_url":"https://api.github.com/repos/icatproject/topcat/forks","keys_url":"https://api.github.com/repos/icatproject/topcat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icatproject/topcat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icatproject/topcat/teams","hooks_url":"https://api.github.com/repos/icatproject/topcat/hooks","issue_events_url":"https://api.github.com/repos/icatproject/topcat/issues/events{/number}","events_url":"https://api.github.com/repos/icatproject/topcat/events","assignees_url":"https://api.github.com/repos/icatproject/topcat/assignees{/user}","branches_url":"https://api.github.com/repos/icatproject/topcat/branches{/branch}","tags_url":"https://api.github.com/repos/icatproject/topcat/tags","blobs_url":"https://api.github.com/repos/icatproject/topcat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icatproject/topcat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icatproject/topcat/git/refs{/sha}","trees_url":"https://api.github.com/repos/icatproject/topcat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icatproject/topcat/statuses/{sha}","languages_url":"https://api.github.com/repos/icatproject/topcat/languages","stargazers_url":"https://api.github.com/repos/icatproject/topcat/stargazers","contributors_url":"https://api.github.com/repos/icatproject/topcat/contributors","subscribers_url":"https://api.github.com/repos/icatproject/topcat/subscribers","subscription_url":"https://api.github.com/repos/icatproject/topcat/subscription","commits_url":"https://api.github.com/repos/icatproject/topcat/commits{/sha}","git_commits_url":"https://api.github.com/repos/icatproject/topcat/git/commits{/sha}","comments_url":"https://api.github.com/repos/icatproject/topcat/comments{/number}","issue_comment_url":"https://api.github.com/repos/icatproject/topcat/issues/comments{/number}","contents_url":"https://api.github.com/repos/icatproject/topcat/contents/{+path}","compare_url":"https://api.github.com/repos/icatproject/topcat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icatproject/topcat/merges","archive_url":"https://api.github.com/repos/icatproject/topcat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icatproject/topcat/downloads","issues_url":"https://api.github.com/repos/icatproject/topcat/issues{/number}","pulls_url":"https://api.github.com/repos/icatproject/topcat/pulls{/number}","milestones_url":"https://api.github.com/repos/icatproject/topcat/milestones{/number}","notifications_url":"https://api.github.com/repos/icatproject/topcat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icatproject/topcat/labels{/name}","releases_url":"https://api.github.com/repos/icatproject/topcat/releases{/id}","deployments_url":"https://api.github.com/repos/icatproject/topcat/deployments","created_at":"2015-05-28T12:16:46Z","updated_at":"2018-11-16T14:39:25Z","pushed_at":"2018-11-19T15:21:41Z","git_url":"git://github.com/icatproject/topcat.git","ssh_url":"git@github.com:icatproject/topcat.git","clone_url":"https://github.com/icatproject/topcat.git","svn_url":"https://github.com/icatproject/topcat","homepage":null,"size":18213,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":36,"watchers":1,"default_branch":"master"}},"base":{"label":"icatproject:master","ref":"master","sha":"5857edc037582019518e71ce4b51a425238f66f8","user":{"login":"icatproject","id":11672419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjcyNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/11672419?v=4","gravatar_id":"","url":"https://api.github.com/users/icatproject","html_url":"https://github.com/icatproject","followers_url":"https://api.github.com/users/icatproject/followers","following_url":"https://api.github.com/users/icatproject/following{/other_user}","gists_url":"https://api.github.com/users/icatproject/gists{/gist_id}","starred_url":"https://api.github.com/users/icatproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icatproject/subscriptions","organizations_url":"https://api.github.com/users/icatproject/orgs","repos_url":"https://api.github.com/users/icatproject/repos","events_url":"https://api.github.com/users/icatproject/events{/privacy}","received_events_url":"https://api.github.com/users/icatproject/received_events","type":"Organization","site_admin":false},"repo":{"id":36436300,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQzNjMwMA==","name":"topcat","full_name":"icatproject/topcat","private":false,"owner":{"login":"icatproject","id":11672419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjcyNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/11672419?v=4","gravatar_id":"","url":"https://api.github.com/users/icatproject","html_url":"https://github.com/icatproject","followers_url":"https://api.github.com/users/icatproject/followers","following_url":"https://api.github.com/users/icatproject/following{/other_user}","gists_url":"https://api.github.com/users/icatproject/gists{/gist_id}","starred_url":"https://api.github.com/users/icatproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icatproject/subscriptions","organizations_url":"https://api.github.com/users/icatproject/orgs","repos_url":"https://api.github.com/users/icatproject/repos","events_url":"https://api.github.com/users/icatproject/events{/privacy}","received_events_url":"https://api.github.com/users/icatproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/icatproject/topcat","description":"GUI to work with multiple ICAT and IDS servers.","fork":false,"url":"https://api.github.com/repos/icatproject/topcat","forks_url":"https://api.github.com/repos/icatproject/topcat/forks","keys_url":"https://api.github.com/repos/icatproject/topcat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icatproject/topcat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icatproject/topcat/teams","hooks_url":"https://api.github.com/repos/icatproject/topcat/hooks","issue_events_url":"https://api.github.com/repos/icatproject/topcat/issues/events{/number}","events_url":"https://api.github.com/repos/icatproject/topcat/events","assignees_url":"https://api.github.com/repos/icatproject/topcat/assignees{/user}","branches_url":"https://api.github.com/repos/icatproject/topcat/branches{/branch}","tags_url":"https://api.github.com/repos/icatproject/topcat/tags","blobs_url":"https://api.github.com/repos/icatproject/topcat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icatproject/topcat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icatproject/topcat/git/refs{/sha}","trees_url":"https://api.github.com/repos/icatproject/topcat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icatproject/topcat/statuses/{sha}","languages_url":"https://api.github.com/repos/icatproject/topcat/languages","stargazers_url":"https://api.github.com/repos/icatproject/topcat/stargazers","contributors_url":"https://api.github.com/repos/icatproject/topcat/contributors","subscribers_url":"https://api.github.com/repos/icatproject/topcat/subscribers","subscription_url":"https://api.github.com/repos/icatproject/topcat/subscription","commits_url":"https://api.github.com/repos/icatproject/topcat/commits{/sha}","git_commits_url":"https://api.github.com/repos/icatproject/topcat/git/commits{/sha}","comments_url":"https://api.github.com/repos/icatproject/topcat/comments{/number}","issue_comment_url":"https://api.github.com/repos/icatproject/topcat/issues/comments{/number}","contents_url":"https://api.github.com/repos/icatproject/topcat/contents/{+path}","compare_url":"https://api.github.com/repos/icatproject/topcat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icatproject/topcat/merges","archive_url":"https://api.github.com/repos/icatproject/topcat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icatproject/topcat/downloads","issues_url":"https://api.github.com/repos/icatproject/topcat/issues{/number}","pulls_url":"https://api.github.com/repos/icatproject/topcat/pulls{/number}","milestones_url":"https://api.github.com/repos/icatproject/topcat/milestones{/number}","notifications_url":"https://api.github.com/repos/icatproject/topcat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icatproject/topcat/labels{/name}","releases_url":"https://api.github.com/repos/icatproject/topcat/releases{/id}","deployments_url":"https://api.github.com/repos/icatproject/topcat/deployments","created_at":"2015-05-28T12:16:46Z","updated_at":"2018-11-16T14:39:25Z","pushed_at":"2018-11-19T15:21:41Z","git_url":"git://github.com/icatproject/topcat.git","ssh_url":"git@github.com:icatproject/topcat.git","clone_url":"https://github.com/icatproject/topcat.git","svn_url":"https://github.com/icatproject/topcat","homepage":null,"size":18213,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":36,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/icatproject/topcat/pulls/391"},"html":{"href":"https://github.com/icatproject/topcat/pull/391"},"issue":{"href":"https://api.github.com/repos/icatproject/topcat/issues/391"},"comments":{"href":"https://api.github.com/repos/icatproject/topcat/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/icatproject/topcat/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/icatproject/topcat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icatproject/topcat/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/icatproject/topcat/statuses/4512959f46b169f31e1307131764fd0013f2b1a7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brianritchie1312","id":12734386,"node_id":"MDQ6VXNlcjEyNzM0Mzg2","avatar_url":"https://avatars0.githubusercontent.com/u/12734386?v=4","gravatar_id":"","url":"https://api.github.com/users/brianritchie1312","html_url":"https://github.com/brianritchie1312","followers_url":"https://api.github.com/users/brianritchie1312/followers","following_url":"https://api.github.com/users/brianritchie1312/following{/other_user}","gists_url":"https://api.github.com/users/brianritchie1312/gists{/gist_id}","starred_url":"https://api.github.com/users/brianritchie1312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianritchie1312/subscriptions","organizations_url":"https://api.github.com/users/brianritchie1312/orgs","repos_url":"https://api.github.com/users/brianritchie1312/repos","events_url":"https://api.github.com/users/brianritchie1312/events{/privacy}","received_events_url":"https://api.github.com/users/brianritchie1312/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"brianritchie1312"}}