{"action":"created","issue":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/5415","repository_url":"https://api.github.com/repos/rubocop-hq/rubocop","labels_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/5415/labels{/name}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/5415/comments","events_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/5415/events","html_url":"https://github.com/rubocop-hq/rubocop/issues/5415","id":286567391,"node_id":"MDU6SXNzdWUyODY1NjczOTE=","number":5415,"title":"Is strip_indent a bad practice in tests?","user":{"login":"flyerhzm","id":66836,"node_id":"MDQ6VXNlcjY2ODM2","avatar_url":"https://avatars2.githubusercontent.com/u/66836?v=4","gravatar_id":"","url":"https://api.github.com/users/flyerhzm","html_url":"https://github.com/flyerhzm","followers_url":"https://api.github.com/users/flyerhzm/followers","following_url":"https://api.github.com/users/flyerhzm/following{/other_user}","gists_url":"https://api.github.com/users/flyerhzm/gists{/gist_id}","starred_url":"https://api.github.com/users/flyerhzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyerhzm/subscriptions","organizations_url":"https://api.github.com/users/flyerhzm/orgs","repos_url":"https://api.github.com/users/flyerhzm/repos","events_url":"https://api.github.com/users/flyerhzm/events{/privacy}","received_events_url":"https://api.github.com/users/flyerhzm/received_events","type":"User","site_admin":false},"labels":[{"id":3608336,"node_id":"MDU6TGFiZWwzNjA4MzM2","url":"https://api.github.com/repos/rubocop-hq/rubocop/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-07T13:00:15Z","updated_at":"2018-06-27T10:34:36Z","closed_at":"2018-06-25T11:21:29Z","author_association":"CONTRIBUTOR","body":"I have fixed 2 issues about indent #5410 and #5292, all tests did not figure out the issues because they use `strip_indent` to ignore indent.\r\n\r\nSo I open a question here: is `strip_indent` a bad practice in tests? If so, I'll try to create a PR to remove `strip_indent`."},"comment":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/comments/400625446","html_url":"https://github.com/rubocop-hq/rubocop/issues/5415#issuecomment-400625446","issue_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/5415","id":400625446,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDYyNTQ0Ng==","user":{"login":"bbatsov","id":103882,"node_id":"MDQ6VXNlcjEwMzg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T10:34:36Z","updated_at":"2018-06-27T10:34:36Z","author_association":"COLLABORATOR","body":"Agreed.\n\nOn Mon, 25 Jun 2018 at 14:21, Ted Johansson <notifications@github.com>\nwrote:\n\n> The way the question is asked, the answer is “no”, but things are rarely\n> that simple. 🙂 Our exceptions would be the cops that explicitly deal\n> with leading indentation. Stripping the leading indent in those test cases\n> would lead to pretty convoluted tests. In those cases, #strip_margin\n> works better. 🙂\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rubocop-hq/rubocop/issues/5415#issuecomment-399918252>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAGVykKJvmLwPH7E8_OPmXrfWahcX4Aeks5uAMe6gaJpZM4RVo99>\n> .\n>\n-- \nBest Regards,\nBozhidar Batsov\n\nhttp://www.batsov.com\n"}}
{"actor":{"display_login":"bbatsov"}}