{"action":"created","comment":{"url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/comments/206335997","pull_request_review_id":141733550,"id":206335997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjMzNTk5Nw==","diff_hunk":"@@ -0,0 +1,7 @@\n+#!/usr/bin/env bash\n+\n+set -o errexit\n+set -o nounset\n+set -o pipefail\n+\n+./main --v=6 --output-file-base=register --input-dirs k8s.io/api/admission/v1beta1,k8s.io/api/admissionregistration/v1alpha1,k8s.io/api/admissionregistration/v1beta1,k8s.io/api/apps/v1,k8s.io/api/apps/v1beta1,k8s.io/api/apps/v1beta2,k8s.io/api/authentication/v1,k8s.io/api/authentication/v1beta1,k8s.io/api/authorization/v1,k8s.io/api/authorization/v1beta1,k8s.io/api/autoscaling/v1,k8s.io/api/autoscaling/v2beta1,k8s.io/api/batch/v1,k8s.io/api/batch/v1beta1,k8s.io/api/batch/v2alpha1,k8s.io/api/certificates/v1beta1,k8s.io/api/coordination/v1beta1,k8s.io/api/core/v1,k8s.io/api/events/v1beta1,k8s.io/api/extensions/v1beta1,k8s.io/api/imagepolicy/v1alpha1,k8s.io/api/networking/v1,k8s.io/api/policy/v1beta1,k8s.io/api/rbac/v1,k8s.io/api/rbac/v1alpha1,k8s.io/api/rbac/v1beta1,k8s.io/api/scheduling/v1alpha1,k8s.io/api/scheduling/v1beta1,k8s.io/api/settings/v1alpha1,k8s.io/api/storage/v1,k8s.io/api/storage/v1alpha1,k8s.io/api/storage/v1beta1","path":"staging/src/k8s.io/code-generator/cmd/register-gen/runme.sh","position":7,"original_position":7,"commit_id":"5ec47dd8055885506bf797e9b52c92b6606cbb80","original_commit_id":"5ec47dd8055885506bf797e9b52c92b6606cbb80","user":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"body":"the script I used to generate `register.go` files, the output is here https://github.com/p0lyn0mial/api/pull/1","created_at":"2018-07-30T21:58:50Z","updated_at":"2018-07-30T21:58:50Z","html_url":"https://github.com/p0lyn0mial/kubernetes/pull/5#discussion_r206335997","pull_request_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/comments/206335997"},"html":{"href":"https://github.com/p0lyn0mial/kubernetes/pull/5#discussion_r206335997"},"pull_request":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5","id":204941971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTQxOTcx","html_url":"https://github.com/p0lyn0mial/kubernetes/pull/5","diff_url":"https://github.com/p0lyn0mial/kubernetes/pull/5.diff","patch_url":"https://github.com/p0lyn0mial/kubernetes/pull/5.patch","issue_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/5","number":5,"state":"open","locked":false,"title":"detects internal types","user":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\n```\r\n","created_at":"2018-07-30T21:58:07Z","updated_at":"2018-07-30T21:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c2cdee4bc61acde7ce77bbc689161887bbe533a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5/commits","review_comments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5/comments","review_comment_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/5/comments","statuses_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/statuses/5ec47dd8055885506bf797e9b52c92b6606cbb80","head":{"label":"p0lyn0mial:register_generator_detect_internal_types_apis_test","ref":"register_generator_detect_internal_types_apis_test","sha":"5ec47dd8055885506bf797e9b52c92b6606cbb80","user":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"repo":{"id":74416520,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQxNjUyMA==","name":"kubernetes","full_name":"p0lyn0mial/kubernetes","owner":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/p0lyn0mial/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/p0lyn0mial/kubernetes","forks_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/forks","keys_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/teams","hooks_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/events","assignees_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/tags","blobs_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/languages","stargazers_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/subscription","commits_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/merges","archive_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/downloads","issues_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/deployments","created_at":"2016-11-21T23:54:40Z","updated_at":"2016-11-21T23:55:18Z","pushed_at":"2018-07-30T21:58:07Z","git_url":"git://github.com/p0lyn0mial/kubernetes.git","ssh_url":"git@github.com:p0lyn0mial/kubernetes.git","clone_url":"https://github.com/p0lyn0mial/kubernetes.git","svn_url":"https://github.com/p0lyn0mial/kubernetes","homepage":"http://kubernetes.io","size":559809,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"p0lyn0mial:generate_register_file","ref":"generate_register_file","sha":"350a5434d235cef1c65081069cd29685c4ac8c2c","user":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"repo":{"id":74416520,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQxNjUyMA==","name":"kubernetes","full_name":"p0lyn0mial/kubernetes","owner":{"login":"p0lyn0mial","id":21304151,"node_id":"MDQ6VXNlcjIxMzA0MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/21304151?v=4","gravatar_id":"","url":"https://api.github.com/users/p0lyn0mial","html_url":"https://github.com/p0lyn0mial","followers_url":"https://api.github.com/users/p0lyn0mial/followers","following_url":"https://api.github.com/users/p0lyn0mial/following{/other_user}","gists_url":"https://api.github.com/users/p0lyn0mial/gists{/gist_id}","starred_url":"https://api.github.com/users/p0lyn0mial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0lyn0mial/subscriptions","organizations_url":"https://api.github.com/users/p0lyn0mial/orgs","repos_url":"https://api.github.com/users/p0lyn0mial/repos","events_url":"https://api.github.com/users/p0lyn0mial/events{/privacy}","received_events_url":"https://api.github.com/users/p0lyn0mial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/p0lyn0mial/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/p0lyn0mial/kubernetes","forks_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/forks","keys_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/teams","hooks_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/events","assignees_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/tags","blobs_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/languages","stargazers_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/subscription","commits_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/merges","archive_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/downloads","issues_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/p0lyn0mial/kubernetes/deployments","created_at":"2016-11-21T23:54:40Z","updated_at":"2016-11-21T23:55:18Z","pushed_at":"2018-07-30T21:58:07Z","git_url":"git://github.com/p0lyn0mial/kubernetes.git","ssh_url":"git@github.com:p0lyn0mial/kubernetes.git","clone_url":"https://github.com/p0lyn0mial/kubernetes.git","svn_url":"https://github.com/p0lyn0mial/kubernetes","homepage":"http://kubernetes.io","size":559809,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5"},"html":{"href":"https://github.com/p0lyn0mial/kubernetes/pull/5"},"issue":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/5"},"comments":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/p0lyn0mial/kubernetes/statuses/5ec47dd8055885506bf797e9b52c92b6606cbb80"}},"author_association":"OWNER"}}
{"actor":{"display_login":"p0lyn0mial"}}