{"action":"created","issue":{"url":"https://api.github.com/repos/foliojs/brotli.js/issues/20","repository_url":"https://api.github.com/repos/foliojs/brotli.js","labels_url":"https://api.github.com/repos/foliojs/brotli.js/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/foliojs/brotli.js/issues/20/comments","events_url":"https://api.github.com/repos/foliojs/brotli.js/issues/20/events","html_url":"https://github.com/foliojs/brotli.js/issues/20","id":243311643,"node_id":"MDU6SXNzdWUyNDMzMTE2NDM=","number":20,"title":"Browser blockers","user":{"login":"buu700","id":415435,"node_id":"MDQ6VXNlcjQxNTQzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/415435?v=4","gravatar_id":"","url":"https://api.github.com/users/buu700","html_url":"https://github.com/buu700","followers_url":"https://api.github.com/users/buu700/followers","following_url":"https://api.github.com/users/buu700/following{/other_user}","gists_url":"https://api.github.com/users/buu700/gists{/gist_id}","starred_url":"https://api.github.com/users/buu700/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buu700/subscriptions","organizations_url":"https://api.github.com/users/buu700/orgs","repos_url":"https://api.github.com/users/buu700/repos","events_url":"https://api.github.com/users/buu700/events{/privacy}","received_events_url":"https://api.github.com/users/buu700/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-07-17T07:11:10Z","updated_at":"2018-08-28T22:55:29Z","closed_at":null,"author_association":"NONE","body":"There's a `Browser.T` referenced in the emscripten runtime output of the current published build that doesn't refer to anything as far as I can tell, causing the output of either browserify or webpack to produce the error `Uncaught ReferenceError: Browser is not defined`.\r\n\r\nRebuilding the library fixes this, but adds an error that encode.js.mem can't be found. Adding `Module['readAsync']=function(_,f){f(Module['readBinary']())};` seems to fix this, but then I get `Uncaught Error: [ReadHuffmanCode] invalid num_codes or space`.\r\n\r\nYou'd lose the benefits of compressing the memfile, but it may be worth considering switching to emscripten's [upcoming `SINGLE_FILE` flag](https://github.com/kripken/emscripten/pull/5296) that does base64 encoding if there's no other workaround. (Is there actually a space advantage to compressing it at this stage vs leaving it to be brotli'd/gzip'd at the same time as the rest of the JS in the user's build pipeline? I'd expect the latter to at least be slightly more CPU-efficient since it'd be decompressed by native code.)\r\n\r\nMisc issues:\r\n\r\n* The `bro` command in the makefile no longer works with the latest brotli; the equivalent command is now `brotli -c`. (Alternatively, there's always `./vendor/brotli/bin/bro`.)\r\n\r\n* `NO_BROWSER` has been removed from emscripten."},"comment":{"url":"https://api.github.com/repos/foliojs/brotli.js/issues/comments/416766832","html_url":"https://github.com/foliojs/brotli.js/issues/20#issuecomment-416766832","issue_url":"https://api.github.com/repos/foliojs/brotli.js/issues/20","id":416766832,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjc2NjgzMg==","user":{"login":"pimterry","id":1526883,"node_id":"MDQ6VXNlcjE1MjY4ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1526883?v=4","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T22:55:29Z","updated_at":"2018-08-28T22:55:29Z","author_association":"NONE","body":"One note that might be useful to others: this only affects the compress build, not the decompress build. `require('brotli')` or `require('brotli/compress')` fail for me, but `require('brotli/decompress')` works fine, and that's all I need for my case anyway."}}
{"actor":{"display_login":"pimterry"}}