{"action":"created","comment":{"url":"https://api.github.com/repos/vm6502q/qrack/pulls/comments/194521016","pull_request_review_id":127709257,"id":194521016,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDUyMTAxNg==","diff_hunk":"@@ -22,17 +22,17 @@ namespace Qrack {\n  * Iterate through the permutations a maximum of end-begin times, allowing the\n  * caller to control the incrementation offset through 'inc'.\n  */\n-void ParallelFor::par_for_inc(const bitCapInt begin, const bitCapInt end, IncrementFunc inc, ParallelFunc fn)\n+void ParallelFor::par_for_inc(const bitCapInt begin, const bitCapInt end, const bitCapInt itemCount, IncrementFunc inc, ParallelFunc fn)","path":"src/common/parallel_for.cpp","position":5,"original_position":5,"commit_id":"ced727eb623309e80228543c506a242601447200","original_commit_id":"8595eea0543b494d0471519ba72ad4a4e2047ce2","user":{"login":"WrathfulSpatula","id":2674693,"node_id":"MDQ6VXNlcjI2NzQ2OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2674693?v=4","gravatar_id":"","url":"https://api.github.com/users/WrathfulSpatula","html_url":"https://github.com/WrathfulSpatula","followers_url":"https://api.github.com/users/WrathfulSpatula/followers","following_url":"https://api.github.com/users/WrathfulSpatula/following{/other_user}","gists_url":"https://api.github.com/users/WrathfulSpatula/gists{/gist_id}","starred_url":"https://api.github.com/users/WrathfulSpatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrathfulSpatula/subscriptions","organizations_url":"https://api.github.com/users/WrathfulSpatula/orgs","repos_url":"https://api.github.com/users/WrathfulSpatula/repos","events_url":"https://api.github.com/users/WrathfulSpatula/events{/privacy}","received_events_url":"https://api.github.com/users/WrathfulSpatula/received_events","type":"User","site_admin":false},"body":"\"end\" is not \"begin + itemCount.\" Depending on the increment function, \"itemCount\" is potentially any number <= (end - begin). This is why I added the parameter.","created_at":"2018-06-11T19:31:50Z","updated_at":"2018-06-11T19:31:50Z","html_url":"https://github.com/vm6502q/qrack/pull/64#discussion_r194521016","pull_request_url":"https://api.github.com/repos/vm6502q/qrack/pulls/64","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/comments/194521016"},"html":{"href":"https://github.com/vm6502q/qrack/pull/64#discussion_r194521016"},"pull_request":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/64"}},"in_reply_to_id":194287438},"pull_request":{"url":"https://api.github.com/repos/vm6502q/qrack/pulls/64","id":192874003,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODc0MDAz","html_url":"https://github.com/vm6502q/qrack/pull/64","diff_url":"https://github.com/vm6502q/qrack/pull/64.diff","patch_url":"https://github.com/vm6502q/qrack/pull/64.patch","issue_url":"https://api.github.com/repos/vm6502q/qrack/issues/64","number":64,"state":"open","locked":false,"title":"OpenCL coverage and optimization, optional float accuracy","user":{"login":"WrathfulSpatula","id":2674693,"node_id":"MDQ6VXNlcjI2NzQ2OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2674693?v=4","gravatar_id":"","url":"https://api.github.com/users/WrathfulSpatula","html_url":"https://github.com/WrathfulSpatula","followers_url":"https://api.github.com/users/WrathfulSpatula/followers","following_url":"https://api.github.com/users/WrathfulSpatula/following{/other_user}","gists_url":"https://api.github.com/users/WrathfulSpatula/gists{/gist_id}","starred_url":"https://api.github.com/users/WrathfulSpatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrathfulSpatula/subscriptions","organizations_url":"https://api.github.com/users/WrathfulSpatula/orgs","repos_url":"https://api.github.com/users/WrathfulSpatula/repos","events_url":"https://api.github.com/users/WrathfulSpatula/events{/privacy}","received_events_url":"https://api.github.com/users/WrathfulSpatula/received_events","type":"User","site_admin":false},"body":"This work in progress will ultimately offer \"full coverage\" for OpenCL, in the sense that all manipulations of the state vector can potentially be offloaded onto OpenCL kernels. The point of this is to allow distribution on a heterogeneous cluster, with aid of a framework that supplements OpenCL with the ability to address a cluster as a single logical platform.\r\n\r\nOpenCL and CPU engine implementations have also been optimized, slightly. Passes all unit tests.","created_at":"2018-06-06T00:56:25Z","updated_at":"2018-06-11T19:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf4240991099405447c8949e5752e1b32a7fe308","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vm6502q/qrack/pulls/64/commits","review_comments_url":"https://api.github.com/repos/vm6502q/qrack/pulls/64/comments","review_comment_url":"https://api.github.com/repos/vm6502q/qrack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vm6502q/qrack/issues/64/comments","statuses_url":"https://api.github.com/repos/vm6502q/qrack/statuses/ced727eb623309e80228543c506a242601447200","head":{"label":"vm6502q:opencl_coverage","ref":"opencl_coverage","sha":"ced727eb623309e80228543c506a242601447200","user":{"login":"vm6502q","id":37188146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTg4MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/37188146?v=4","gravatar_id":"","url":"https://api.github.com/users/vm6502q","html_url":"https://github.com/vm6502q","followers_url":"https://api.github.com/users/vm6502q/followers","following_url":"https://api.github.com/users/vm6502q/following{/other_user}","gists_url":"https://api.github.com/users/vm6502q/gists{/gist_id}","starred_url":"https://api.github.com/users/vm6502q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vm6502q/subscriptions","organizations_url":"https://api.github.com/users/vm6502q/orgs","repos_url":"https://api.github.com/users/vm6502q/repos","events_url":"https://api.github.com/users/vm6502q/events{/privacy}","received_events_url":"https://api.github.com/users/vm6502q/received_events","type":"Organization","site_admin":false},"repo":{"id":114947047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NDcwNDc=","name":"qrack","full_name":"vm6502q/qrack","owner":{"login":"vm6502q","id":37188146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTg4MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/37188146?v=4","gravatar_id":"","url":"https://api.github.com/users/vm6502q","html_url":"https://github.com/vm6502q","followers_url":"https://api.github.com/users/vm6502q/followers","following_url":"https://api.github.com/users/vm6502q/following{/other_user}","gists_url":"https://api.github.com/users/vm6502q/gists{/gist_id}","starred_url":"https://api.github.com/users/vm6502q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vm6502q/subscriptions","organizations_url":"https://api.github.com/users/vm6502q/orgs","repos_url":"https://api.github.com/users/vm6502q/repos","events_url":"https://api.github.com/users/vm6502q/events{/privacy}","received_events_url":"https://api.github.com/users/vm6502q/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vm6502q/qrack","description":"Comprehensive qubit and gate implementation for developing universal virtual quantum processors.","fork":false,"url":"https://api.github.com/repos/vm6502q/qrack","forks_url":"https://api.github.com/repos/vm6502q/qrack/forks","keys_url":"https://api.github.com/repos/vm6502q/qrack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vm6502q/qrack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vm6502q/qrack/teams","hooks_url":"https://api.github.com/repos/vm6502q/qrack/hooks","issue_events_url":"https://api.github.com/repos/vm6502q/qrack/issues/events{/number}","events_url":"https://api.github.com/repos/vm6502q/qrack/events","assignees_url":"https://api.github.com/repos/vm6502q/qrack/assignees{/user}","branches_url":"https://api.github.com/repos/vm6502q/qrack/branches{/branch}","tags_url":"https://api.github.com/repos/vm6502q/qrack/tags","blobs_url":"https://api.github.com/repos/vm6502q/qrack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vm6502q/qrack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vm6502q/qrack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vm6502q/qrack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vm6502q/qrack/statuses/{sha}","languages_url":"https://api.github.com/repos/vm6502q/qrack/languages","stargazers_url":"https://api.github.com/repos/vm6502q/qrack/stargazers","contributors_url":"https://api.github.com/repos/vm6502q/qrack/contributors","subscribers_url":"https://api.github.com/repos/vm6502q/qrack/subscribers","subscription_url":"https://api.github.com/repos/vm6502q/qrack/subscription","commits_url":"https://api.github.com/repos/vm6502q/qrack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vm6502q/qrack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vm6502q/qrack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vm6502q/qrack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vm6502q/qrack/contents/{+path}","compare_url":"https://api.github.com/repos/vm6502q/qrack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vm6502q/qrack/merges","archive_url":"https://api.github.com/repos/vm6502q/qrack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vm6502q/qrack/downloads","issues_url":"https://api.github.com/repos/vm6502q/qrack/issues{/number}","pulls_url":"https://api.github.com/repos/vm6502q/qrack/pulls{/number}","milestones_url":"https://api.github.com/repos/vm6502q/qrack/milestones{/number}","notifications_url":"https://api.github.com/repos/vm6502q/qrack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vm6502q/qrack/labels{/name}","releases_url":"https://api.github.com/repos/vm6502q/qrack/releases{/id}","deployments_url":"https://api.github.com/repos/vm6502q/qrack/deployments","created_at":"2017-12-21T01:15:29Z","updated_at":"2018-06-09T03:30:57Z","pushed_at":"2018-06-11T13:49:13Z","git_url":"git://github.com/vm6502q/qrack.git","ssh_url":"git@github.com:vm6502q/qrack.git","clone_url":"https://github.com/vm6502q/qrack.git","svn_url":"https://github.com/vm6502q/qrack","homepage":"","size":11435,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"vm6502q:master","ref":"master","sha":"ffc01e49f190725512a66d707639f7f9b48d7713","user":{"login":"vm6502q","id":37188146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTg4MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/37188146?v=4","gravatar_id":"","url":"https://api.github.com/users/vm6502q","html_url":"https://github.com/vm6502q","followers_url":"https://api.github.com/users/vm6502q/followers","following_url":"https://api.github.com/users/vm6502q/following{/other_user}","gists_url":"https://api.github.com/users/vm6502q/gists{/gist_id}","starred_url":"https://api.github.com/users/vm6502q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vm6502q/subscriptions","organizations_url":"https://api.github.com/users/vm6502q/orgs","repos_url":"https://api.github.com/users/vm6502q/repos","events_url":"https://api.github.com/users/vm6502q/events{/privacy}","received_events_url":"https://api.github.com/users/vm6502q/received_events","type":"Organization","site_admin":false},"repo":{"id":114947047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NDcwNDc=","name":"qrack","full_name":"vm6502q/qrack","owner":{"login":"vm6502q","id":37188146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTg4MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/37188146?v=4","gravatar_id":"","url":"https://api.github.com/users/vm6502q","html_url":"https://github.com/vm6502q","followers_url":"https://api.github.com/users/vm6502q/followers","following_url":"https://api.github.com/users/vm6502q/following{/other_user}","gists_url":"https://api.github.com/users/vm6502q/gists{/gist_id}","starred_url":"https://api.github.com/users/vm6502q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vm6502q/subscriptions","organizations_url":"https://api.github.com/users/vm6502q/orgs","repos_url":"https://api.github.com/users/vm6502q/repos","events_url":"https://api.github.com/users/vm6502q/events{/privacy}","received_events_url":"https://api.github.com/users/vm6502q/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vm6502q/qrack","description":"Comprehensive qubit and gate implementation for developing universal virtual quantum processors.","fork":false,"url":"https://api.github.com/repos/vm6502q/qrack","forks_url":"https://api.github.com/repos/vm6502q/qrack/forks","keys_url":"https://api.github.com/repos/vm6502q/qrack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vm6502q/qrack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vm6502q/qrack/teams","hooks_url":"https://api.github.com/repos/vm6502q/qrack/hooks","issue_events_url":"https://api.github.com/repos/vm6502q/qrack/issues/events{/number}","events_url":"https://api.github.com/repos/vm6502q/qrack/events","assignees_url":"https://api.github.com/repos/vm6502q/qrack/assignees{/user}","branches_url":"https://api.github.com/repos/vm6502q/qrack/branches{/branch}","tags_url":"https://api.github.com/repos/vm6502q/qrack/tags","blobs_url":"https://api.github.com/repos/vm6502q/qrack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vm6502q/qrack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vm6502q/qrack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vm6502q/qrack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vm6502q/qrack/statuses/{sha}","languages_url":"https://api.github.com/repos/vm6502q/qrack/languages","stargazers_url":"https://api.github.com/repos/vm6502q/qrack/stargazers","contributors_url":"https://api.github.com/repos/vm6502q/qrack/contributors","subscribers_url":"https://api.github.com/repos/vm6502q/qrack/subscribers","subscription_url":"https://api.github.com/repos/vm6502q/qrack/subscription","commits_url":"https://api.github.com/repos/vm6502q/qrack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vm6502q/qrack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vm6502q/qrack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vm6502q/qrack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vm6502q/qrack/contents/{+path}","compare_url":"https://api.github.com/repos/vm6502q/qrack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vm6502q/qrack/merges","archive_url":"https://api.github.com/repos/vm6502q/qrack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vm6502q/qrack/downloads","issues_url":"https://api.github.com/repos/vm6502q/qrack/issues{/number}","pulls_url":"https://api.github.com/repos/vm6502q/qrack/pulls{/number}","milestones_url":"https://api.github.com/repos/vm6502q/qrack/milestones{/number}","notifications_url":"https://api.github.com/repos/vm6502q/qrack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vm6502q/qrack/labels{/name}","releases_url":"https://api.github.com/repos/vm6502q/qrack/releases{/id}","deployments_url":"https://api.github.com/repos/vm6502q/qrack/deployments","created_at":"2017-12-21T01:15:29Z","updated_at":"2018-06-09T03:30:57Z","pushed_at":"2018-06-11T13:49:13Z","git_url":"git://github.com/vm6502q/qrack.git","ssh_url":"git@github.com:vm6502q/qrack.git","clone_url":"https://github.com/vm6502q/qrack.git","svn_url":"https://github.com/vm6502q/qrack","homepage":"","size":11435,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/64"},"html":{"href":"https://github.com/vm6502q/qrack/pull/64"},"issue":{"href":"https://api.github.com/repos/vm6502q/qrack/issues/64"},"comments":{"href":"https://api.github.com/repos/vm6502q/qrack/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vm6502q/qrack/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/vm6502q/qrack/statuses/ced727eb623309e80228543c506a242601447200"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"WrathfulSpatula"}}