{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/comments/181597707","pull_request_review_id":112251921,"id":181597707,"diff_hunk":"@@ -27,37 +27,40 @@ IP Forwarding\n ~~~~~~~~~~~~~\n \n BungeeCord has a mode called IP Forwarding, which allows BungeeCord to pass the player's UUID and IP address to any\n-connected server, even though the servers are being run in offline mode. With current builds of BungeeCord, IP\n-Forwarding works with SpongeVanilla, whilst IP Forwarding only supports SpongeForge when vanilla clients connect -\n-modded servers that require modded clients cannot natively make use of IP Forwarding with the current version of\n-BungeeCord. SpongeForge is only fully supported with the use of a patched version of BungeeCord, or a community\n-supplied BungeeCord plugin.\n+connected server, even though the servers are being run in offline mode. \n \n-A pull request has been supplied to BungeeCord to allow BungeeCord to support SpongeForge natively. We are awaiting it\n-to be included in the main product:\n-\n-* Old PR, has context: `BungeeCord PR 1557 <https://github.com/SpigotMC/BungeeCord/pull/1557>`_\n-* New PR, uses a different method to avoid breakages: `BungeeCord PR 1678 <https://github.com/SpigotMC/BungeeCord/pull/1678>`_\n-\n-Using BungeeCord without IP Forwarding\n-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+.. warning::\n+ SpongeForge modded servers that require modded clients, will only work if you use a BungeeCord fork like\n+ `Waterfall <https://github.com/WaterfallMC/Waterfall/blob/master/README.md#waterfall->`_, or a BungeeCord plugin like\n+ `SpongePls <https://forums.spongepowered.org/t/spongepls/9891>`_. SpongePowered does not officially support these\n+ products, although they are developed by trusted members of the community.\n \n-While it is recommended that you use IP Forwarding wherever possible. If you do not wish to do so, simply ensure that\n-``online-mode`` is set to ``false`` in your ``server.properties`` file and add the server details to Bungee's\n-``config.yml`` file. Bungee will then forward any connections to the server when required. It is a good precaution to\n-set the ``server-port`` to something other than ``25565``.\n+For SpongeVanilla or Vanilla clients connecting to unmodded SpongeForge, IP Forwarding works out of the box.\n+`Pull <https://github.com/SpigotMC/BungeeCord/pull/1557>`_ `requests <https://github.com/SpigotMC/BungeeCord/pull/1678>`_\n+have been supplied to BungeeCord to allow BungeeCord to support SpongeForge natively. We are awaiting it to be included\n+in the main product. For now please use one of the solutions mentioned above.\n \n-This will work with all implementations of Sponge, including with mods.\n \n Using BungeeCord with IP Forwarding\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n If you wish to use IP Forwarding:\n \n * In the BungeeCord ``config.yml``, set ``ip_forward`` to ``true``\n-* In Sponge's config (config/sponge/global.conf), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to\n+* In Sponge's config (``config/sponge/global.conf``), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to","path":"source/server/getting-started/bungeecord.rst","position":43,"original_position":43,"commit_id":"b658e3c1d99b4c41ce37bda407696f3cbffc00cc","original_commit_id":"b658e3c1d99b4c41ce37bda407696f3cbffc00cc","user":{"login":"phit","id":2097483,"avatar_url":"https://avatars2.githubusercontent.com/u/2097483?v=4","gravatar_id":"","url":"https://api.github.com/users/phit","html_url":"https://github.com/phit","followers_url":"https://api.github.com/users/phit/followers","following_url":"https://api.github.com/users/phit/following{/other_user}","gists_url":"https://api.github.com/users/phit/gists{/gist_id}","starred_url":"https://api.github.com/users/phit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phit/subscriptions","organizations_url":"https://api.github.com/users/phit/orgs","repos_url":"https://api.github.com/users/phit/repos","events_url":"https://api.github.com/users/phit/events{/privacy}","received_events_url":"https://api.github.com/users/phit/received_events","type":"User","site_admin":false},"body":"it was already above 120 qq","created_at":"2018-04-15T21:27:24Z","updated_at":"2018-04-15T21:27:24Z","html_url":"https://github.com/SpongePowered/SpongeDocs/pull/682#discussion_r181597707","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/comments/181597707"},"html":{"href":"https://github.com/SpongePowered/SpongeDocs/pull/682#discussion_r181597707"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682"}},"in_reply_to_id":181597062},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682","id":181702676,"html_url":"https://github.com/SpongePowered/SpongeDocs/pull/682","diff_url":"https://github.com/SpongePowered/SpongeDocs/pull/682.diff","patch_url":"https://github.com/SpongePowered/SpongeDocs/pull/682.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/682","number":682,"state":"open","locked":false,"title":"Updated BungeeCord docs","user":{"login":"phit","id":2097483,"avatar_url":"https://avatars2.githubusercontent.com/u/2097483?v=4","gravatar_id":"","url":"https://api.github.com/users/phit","html_url":"https://github.com/phit","followers_url":"https://api.github.com/users/phit/followers","following_url":"https://api.github.com/users/phit/following{/other_user}","gists_url":"https://api.github.com/users/phit/gists{/gist_id}","starred_url":"https://api.github.com/users/phit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phit/subscriptions","organizations_url":"https://api.github.com/users/phit/orgs","repos_url":"https://api.github.com/users/phit/repos","events_url":"https://api.github.com/users/phit/events{/privacy}","received_events_url":"https://api.github.com/users/phit/received_events","type":"User","site_admin":false},"body":"As it has been years at this point and the PR's have no progress,\r\nI'd rather link to an actual solution to people, tired of having to link\r\npeople a solution when it could just be in the Docs.\r\n\r\nAlso moved without IP Forwarding to the end as nobody should be really using that, and with is more important.","created_at":"2018-04-15T14:45:55Z","updated_at":"2018-04-15T21:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08a54f489d894463413226ba7c37e847143a29f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":171200297,"url":"https://api.github.com/repos/SpongePowered/SpongeDocs/labels/input%20wanted","name":"input wanted","color":"fbca04","default":false},{"id":259364098,"url":"https://api.github.com/repos/SpongePowered/SpongeDocs/labels/needs%20review","name":"needs review","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/682/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/statuses/b658e3c1d99b4c41ce37bda407696f3cbffc00cc","head":{"label":"phit:bungeecord","ref":"bungeecord","sha":"b658e3c1d99b4c41ce37bda407696f3cbffc00cc","user":{"login":"phit","id":2097483,"avatar_url":"https://avatars2.githubusercontent.com/u/2097483?v=4","gravatar_id":"","url":"https://api.github.com/users/phit","html_url":"https://github.com/phit","followers_url":"https://api.github.com/users/phit/followers","following_url":"https://api.github.com/users/phit/following{/other_user}","gists_url":"https://api.github.com/users/phit/gists{/gist_id}","starred_url":"https://api.github.com/users/phit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phit/subscriptions","organizations_url":"https://api.github.com/users/phit/orgs","repos_url":"https://api.github.com/users/phit/repos","events_url":"https://api.github.com/users/phit/events{/privacy}","received_events_url":"https://api.github.com/users/phit/received_events","type":"User","site_admin":false},"repo":{"id":107470868,"name":"SpongeDocs","full_name":"phit/SpongeDocs","owner":{"login":"phit","id":2097483,"avatar_url":"https://avatars2.githubusercontent.com/u/2097483?v=4","gravatar_id":"","url":"https://api.github.com/users/phit","html_url":"https://github.com/phit","followers_url":"https://api.github.com/users/phit/followers","following_url":"https://api.github.com/users/phit/following{/other_user}","gists_url":"https://api.github.com/users/phit/gists{/gist_id}","starred_url":"https://api.github.com/users/phit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phit/subscriptions","organizations_url":"https://api.github.com/users/phit/orgs","repos_url":"https://api.github.com/users/phit/repos","events_url":"https://api.github.com/users/phit/events{/privacy}","received_events_url":"https://api.github.com/users/phit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phit/SpongeDocs","description":"Documentation for Sponge and its Implementations","fork":true,"url":"https://api.github.com/repos/phit/SpongeDocs","forks_url":"https://api.github.com/repos/phit/SpongeDocs/forks","keys_url":"https://api.github.com/repos/phit/SpongeDocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phit/SpongeDocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phit/SpongeDocs/teams","hooks_url":"https://api.github.com/repos/phit/SpongeDocs/hooks","issue_events_url":"https://api.github.com/repos/phit/SpongeDocs/issues/events{/number}","events_url":"https://api.github.com/repos/phit/SpongeDocs/events","assignees_url":"https://api.github.com/repos/phit/SpongeDocs/assignees{/user}","branches_url":"https://api.github.com/repos/phit/SpongeDocs/branches{/branch}","tags_url":"https://api.github.com/repos/phit/SpongeDocs/tags","blobs_url":"https://api.github.com/repos/phit/SpongeDocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phit/SpongeDocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phit/SpongeDocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/phit/SpongeDocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phit/SpongeDocs/statuses/{sha}","languages_url":"https://api.github.com/repos/phit/SpongeDocs/languages","stargazers_url":"https://api.github.com/repos/phit/SpongeDocs/stargazers","contributors_url":"https://api.github.com/repos/phit/SpongeDocs/contributors","subscribers_url":"https://api.github.com/repos/phit/SpongeDocs/subscribers","subscription_url":"https://api.github.com/repos/phit/SpongeDocs/subscription","commits_url":"https://api.github.com/repos/phit/SpongeDocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/phit/SpongeDocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/phit/SpongeDocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/phit/SpongeDocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/phit/SpongeDocs/contents/{+path}","compare_url":"https://api.github.com/repos/phit/SpongeDocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phit/SpongeDocs/merges","archive_url":"https://api.github.com/repos/phit/SpongeDocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phit/SpongeDocs/downloads","issues_url":"https://api.github.com/repos/phit/SpongeDocs/issues{/number}","pulls_url":"https://api.github.com/repos/phit/SpongeDocs/pulls{/number}","milestones_url":"https://api.github.com/repos/phit/SpongeDocs/milestones{/number}","notifications_url":"https://api.github.com/repos/phit/SpongeDocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phit/SpongeDocs/labels{/name}","releases_url":"https://api.github.com/repos/phit/SpongeDocs/releases{/id}","deployments_url":"https://api.github.com/repos/phit/SpongeDocs/deployments","created_at":"2017-10-18T22:39:45Z","updated_at":"2017-10-18T22:39:47Z","pushed_at":"2018-04-15T15:12:44Z","git_url":"git://github.com/phit/SpongeDocs.git","ssh_url":"git@github.com:phit/SpongeDocs.git","clone_url":"https://github.com/phit/SpongeDocs.git","svn_url":"https://github.com/phit/SpongeDocs","homepage":"","size":5976,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"SpongePowered:stable","ref":"stable","sha":"5f90e6ccc5197afaf2365a34d339a153410415ec","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":27024702,"name":"SpongeDocs","full_name":"SpongePowered/SpongeDocs","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeDocs","description":"Documentation for Sponge and its Implementations","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeDocs","forks_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeDocs/deployments","created_at":"2014-11-23T06:56:04Z","updated_at":"2018-04-15T20:23:21Z","pushed_at":"2018-04-15T20:58:54Z","git_url":"git://github.com/SpongePowered/SpongeDocs.git","ssh_url":"git@github.com:SpongePowered/SpongeDocs.git","clone_url":"https://github.com/SpongePowered/SpongeDocs.git","svn_url":"https://github.com/SpongePowered/SpongeDocs","homepage":"","size":5975,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0"},"forks":85,"open_issues":66,"watchers":80,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682"},"html":{"href":"https://github.com/SpongePowered/SpongeDocs/pull/682"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/682"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeDocs/statuses/b658e3c1d99b4c41ce37bda407696f3cbffc00cc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"phit"}}