{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/166326850","pull_request_review_id":94370547,"id":166326850,"diff_hunk":"@@ -11,5 +11,21 @@\n export function getProfile(state: Object) {\n     const profileStateSlice = state['features/base/profile'];\n \n-    return profileStateSlice ? profileStateSlice.profile || {} : {};\n+    return _toProfile(profileStateSlice);\n+}\n+\n+/**\n+ * Converts the related redux subtree to a profile object, considering\n+ * the legacy implementation of the profile too.\n+ * FIXME: This may be removed later.\n+ *\n+ * @param {Object} slice - The Redux state.\n+ * @returns {Object}\n+ */\n+function _toProfile(slice: Object) {","path":"react/features/base/profile/functions.js","position":16,"original_position":16,"commit_id":"b301b451a2fa26402b4c23c29e799c0f7c992045","original_commit_id":"b301b451a2fa26402b4c23c29e799c0f7c992045","user":{"login":"lyubomir","id":3251887,"avatar_url":"https://avatars0.githubusercontent.com/u/3251887?v=4","gravatar_id":"","url":"https://api.github.com/users/lyubomir","html_url":"https://github.com/lyubomir","followers_url":"https://api.github.com/users/lyubomir/followers","following_url":"https://api.github.com/users/lyubomir/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir/subscriptions","organizations_url":"https://api.github.com/users/lyubomir/orgs","repos_url":"https://api.github.com/users/lyubomir/repos","events_url":"https://api.github.com/users/lyubomir/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir/received_events","type":"User","site_admin":false},"body":"Considering we don't have a release version with the Settings, is it really necessary to have legacy support for the purposes of an internal release?","created_at":"2018-02-06T14:52:39Z","updated_at":"2018-02-06T14:52:39Z","html_url":"https://github.com/jitsi/jitsi-meet/pull/2457#discussion_r166326850","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/166326850"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/2457#discussion_r166326850"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457","id":167402387,"html_url":"https://github.com/jitsi/jitsi-meet/pull/2457","diff_url":"https://github.com/jitsi/jitsi-meet/pull/2457.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/2457.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2457","number":2457,"state":"open","locked":false,"title":"Flatten redux trees","user":{"login":"zbettenbuk","id":9974975,"avatar_url":"https://avatars0.githubusercontent.com/u/9974975?v=4","gravatar_id":"","url":"https://api.github.com/users/zbettenbuk","html_url":"https://github.com/zbettenbuk","followers_url":"https://api.github.com/users/zbettenbuk/followers","following_url":"https://api.github.com/users/zbettenbuk/following{/other_user}","gists_url":"https://api.github.com/users/zbettenbuk/gists{/gist_id}","starred_url":"https://api.github.com/users/zbettenbuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbettenbuk/subscriptions","organizations_url":"https://api.github.com/users/zbettenbuk/orgs","repos_url":"https://api.github.com/users/zbettenbuk/repos","events_url":"https://api.github.com/users/zbettenbuk/events{/privacy}","received_events_url":"https://api.github.com/users/zbettenbuk/received_events","type":"User","site_admin":false},"body":"Commits:\r\n1: Prepare the PersistenceRegistry to handle both flattened and unflattened objects\r\n2: Flattening the state of the recent list feature, so its state is just a simple array\r\n3: Flattening the state of the profile feature. so its state is no longer encapsulated into a profile: {} property.\r\n\r\nBoth implementation handles the legacy and the new mode too.","created_at":"2018-02-06T12:37:42Z","updated_at":"2018-02-06T14:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8041486ca0b5b03c86f1fe427c960b94c4fb379","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2457/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/b301b451a2fa26402b4c23c29e799c0f7c992045","head":{"label":"zbettenbuk:flatten-redux-trees","ref":"flatten-redux-trees","sha":"b301b451a2fa26402b4c23c29e799c0f7c992045","user":{"login":"zbettenbuk","id":9974975,"avatar_url":"https://avatars0.githubusercontent.com/u/9974975?v=4","gravatar_id":"","url":"https://api.github.com/users/zbettenbuk","html_url":"https://github.com/zbettenbuk","followers_url":"https://api.github.com/users/zbettenbuk/followers","following_url":"https://api.github.com/users/zbettenbuk/following{/other_user}","gists_url":"https://api.github.com/users/zbettenbuk/gists{/gist_id}","starred_url":"https://api.github.com/users/zbettenbuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbettenbuk/subscriptions","organizations_url":"https://api.github.com/users/zbettenbuk/orgs","repos_url":"https://api.github.com/users/zbettenbuk/repos","events_url":"https://api.github.com/users/zbettenbuk/events{/privacy}","received_events_url":"https://api.github.com/users/zbettenbuk/received_events","type":"User","site_admin":false},"repo":{"id":113438639,"name":"jitsi-meet","full_name":"zbettenbuk/jitsi-meet","owner":{"login":"zbettenbuk","id":9974975,"avatar_url":"https://avatars0.githubusercontent.com/u/9974975?v=4","gravatar_id":"","url":"https://api.github.com/users/zbettenbuk","html_url":"https://github.com/zbettenbuk","followers_url":"https://api.github.com/users/zbettenbuk/followers","following_url":"https://api.github.com/users/zbettenbuk/following{/other_user}","gists_url":"https://api.github.com/users/zbettenbuk/gists{/gist_id}","starred_url":"https://api.github.com/users/zbettenbuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbettenbuk/subscriptions","organizations_url":"https://api.github.com/users/zbettenbuk/orgs","repos_url":"https://api.github.com/users/zbettenbuk/repos","events_url":"https://api.github.com/users/zbettenbuk/events{/privacy}","received_events_url":"https://api.github.com/users/zbettenbuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zbettenbuk/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":true,"url":"https://api.github.com/repos/zbettenbuk/jitsi-meet","forks_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/forks","keys_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/events","assignees_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/merges","archive_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/zbettenbuk/jitsi-meet/deployments","created_at":"2017-12-07T10:47:22Z","updated_at":"2017-12-07T10:47:29Z","pushed_at":"2018-02-06T12:29:37Z","git_url":"git://github.com/zbettenbuk/jitsi-meet.git","ssh_url":"git@github.com:zbettenbuk/jitsi-meet.git","clone_url":"https://github.com/zbettenbuk/jitsi-meet.git","svn_url":"https://github.com/zbettenbuk/jitsi-meet","homepage":"https://jitsi.org/meet","size":23908,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"9e53d40b9cacf956a529b1b1697c22c0543e2bf0","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2018-02-06T14:43:37Z","pushed_at":"2018-02-06T12:37:42Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/meet","size":23919,"stargazers_count":2107,"watchers_count":2107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":720,"mirror_url":null,"archived":false,"open_issues_count":417,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":720,"open_issues":417,"watchers":2107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/2457"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2457"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2457/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2457/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/b301b451a2fa26402b4c23c29e799c0f7c992045"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lyubomir"}}