{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-desktop/pulls/comments/238473583","pull_request_review_id":181024225,"id":238473583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ3MzU4Mw==","diff_hunk":"@@ -214,41 +214,40 @@ export default class AppiumMethodHandler {\n       } catch (ign) { }\n     }\n   }\n+}\n \n-  static createSession (driver, sender, winId) {\n-    const {appiumHandlers} = AppiumMethodHandler;\n-    log.info(`Creating method handler for session with window id: ${winId}`);\n-    const handler = AppiumMethodHandler.appiumHandlers[winId] = new AppiumMethodHandler(driver, sender);\n-    log.info(`The following session window ID's have active sessions: '${JSON.stringify(_.keys(appiumHandlers))}'`);\n-    return handler;\n-  }\n-\n-  static killSession (winId, killedByUser) {\n-    const {appiumHandlers} = AppiumMethodHandler;\n-    const handler = appiumHandlers[winId];\n-    delete AppiumMethodHandler.appiumHandlers[winId];\n-    log.info(`Killing session for window with id: ${winId}`);\n+export function createSession (driver, sender, winId) {","path":"app/main/appium-method-handler.js","position":19,"original_position":19,"commit_id":"44b933622207af42250ecece099e0c211832e30c","original_commit_id":"735a0bf5033a1766c053f4168048e8ca14976c1d","user":{"login":"dpgraham","id":852574,"node_id":"MDQ6VXNlcjg1MjU3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/852574?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgraham","html_url":"https://github.com/dpgraham","followers_url":"https://api.github.com/users/dpgraham/followers","following_url":"https://api.github.com/users/dpgraham/following{/other_user}","gists_url":"https://api.github.com/users/dpgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgraham/subscriptions","organizations_url":"https://api.github.com/users/dpgraham/orgs","repos_url":"https://api.github.com/users/dpgraham/repos","events_url":"https://api.github.com/users/dpgraham/events{/privacy}","received_events_url":"https://api.github.com/users/dpgraham/received_events","type":"User","site_admin":false},"body":"Had to change from `static` to `export` because Babel 7 doesn't accept the format of exporting objects and then doing destructured imports. You have to explicitly export each named variable.","created_at":"2018-12-03T23:05:55Z","updated_at":"2018-12-03T23:05:55Z","html_url":"https://github.com/appium/appium-desktop/pull/752#discussion_r238473583","pull_request_url":"https://api.github.com/repos/appium/appium-desktop/pulls/752","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/comments/238473583"},"html":{"href":"https://github.com/appium/appium-desktop/pull/752#discussion_r238473583"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/752"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-desktop/pulls/752","id":235622242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjIyMjQy","html_url":"https://github.com/appium/appium-desktop/pull/752","diff_url":"https://github.com/appium/appium-desktop/pull/752.diff","patch_url":"https://github.com/appium/appium-desktop/pull/752.patch","issue_url":"https://api.github.com/repos/appium/appium-desktop/issues/752","number":752,"state":"open","locked":false,"title":"Dpgraham webpack to parcel","user":{"login":"dpgraham","id":852574,"node_id":"MDQ6VXNlcjg1MjU3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/852574?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgraham","html_url":"https://github.com/dpgraham","followers_url":"https://api.github.com/users/dpgraham/followers","following_url":"https://api.github.com/users/dpgraham/following{/other_user}","gists_url":"https://api.github.com/users/dpgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgraham/subscriptions","organizations_url":"https://api.github.com/users/dpgraham/orgs","repos_url":"https://api.github.com/users/dpgraham/repos","events_url":"https://api.github.com/users/dpgraham/events{/privacy}","received_events_url":"https://api.github.com/users/dpgraham/received_events","type":"User","site_admin":false},"body":"To get Appium 1.10 working, I needed to get babel 7 working which meant I needed to migrate from Webpack 1 to Webpack 4. I made the executive decision that since Weback 1 to 4 has a complicated migration path, we'd do just as well migrating to ParcelJS.\r\n\r\nIt uses ParcelJS now to build the main thread code and the renderer code. I was able to just rip out all the webpack configs and they didn't need to be replaced with anything (because it actually is zero-config). \r\n\r\nThe way it builds the renderer now is that it targets `renderer/index.html` as the \"entry-point\" (instead of `index.js`) and _everything_ gets copied to the `dist/` folder now. The index.html page, the javascript, the CSS and the images.\r\n\r\nI had to make some coding changes to make this work with Babel 7 as well.","created_at":"2018-12-03T23:00:02Z","updated_at":"2018-12-03T23:05:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fe0e5e42d710e8883364a48a287c29484119812","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-desktop/pulls/752/commits","review_comments_url":"https://api.github.com/repos/appium/appium-desktop/pulls/752/comments","review_comment_url":"https://api.github.com/repos/appium/appium-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-desktop/issues/752/comments","statuses_url":"https://api.github.com/repos/appium/appium-desktop/statuses/44b933622207af42250ecece099e0c211832e30c","head":{"label":"appium:dpgraham-webpack-to-parcel","ref":"dpgraham-webpack-to-parcel","sha":"44b933622207af42250ecece099e0c211832e30c","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":63558084,"node_id":"MDEwOlJlcG9zaXRvcnk2MzU1ODA4NA==","name":"appium-desktop","full_name":"appium/appium-desktop","private":false,"owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appium/appium-desktop","description":"Appium Server and Inspector in Desktop GUIs for Mac, Windows, and Linux","fork":false,"url":"https://api.github.com/repos/appium/appium-desktop","forks_url":"https://api.github.com/repos/appium/appium-desktop/forks","keys_url":"https://api.github.com/repos/appium/appium-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-desktop/teams","hooks_url":"https://api.github.com/repos/appium/appium-desktop/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-desktop/events","assignees_url":"https://api.github.com/repos/appium/appium-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-desktop/tags","blobs_url":"https://api.github.com/repos/appium/appium-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-desktop/languages","stargazers_url":"https://api.github.com/repos/appium/appium-desktop/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-desktop/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-desktop/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-desktop/subscription","commits_url":"https://api.github.com/repos/appium/appium-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-desktop/merges","archive_url":"https://api.github.com/repos/appium/appium-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-desktop/downloads","issues_url":"https://api.github.com/repos/appium/appium-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-desktop/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-desktop/deployments","created_at":"2016-07-18T00:08:00Z","updated_at":"2018-12-03T18:04:05Z","pushed_at":"2018-12-03T23:04:28Z","git_url":"git://github.com/appium/appium-desktop.git","ssh_url":"git@github.com:appium/appium-desktop.git","clone_url":"https://github.com/appium/appium-desktop.git","svn_url":"https://github.com/appium/appium-desktop","homepage":null,"size":7386,"stargazers_count":1295,"watchers_count":1295,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":376,"open_issues":60,"watchers":1295,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"227439ff48892f147be70570ddbcf95248813612","user":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":63558084,"node_id":"MDEwOlJlcG9zaXRvcnk2MzU1ODA4NA==","name":"appium-desktop","full_name":"appium/appium-desktop","private":false,"owner":{"login":"appium","id":3221291,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjEyOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appium/appium-desktop","description":"Appium Server and Inspector in Desktop GUIs for Mac, Windows, and Linux","fork":false,"url":"https://api.github.com/repos/appium/appium-desktop","forks_url":"https://api.github.com/repos/appium/appium-desktop/forks","keys_url":"https://api.github.com/repos/appium/appium-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-desktop/teams","hooks_url":"https://api.github.com/repos/appium/appium-desktop/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-desktop/events","assignees_url":"https://api.github.com/repos/appium/appium-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-desktop/tags","blobs_url":"https://api.github.com/repos/appium/appium-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-desktop/languages","stargazers_url":"https://api.github.com/repos/appium/appium-desktop/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-desktop/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-desktop/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-desktop/subscription","commits_url":"https://api.github.com/repos/appium/appium-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-desktop/merges","archive_url":"https://api.github.com/repos/appium/appium-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-desktop/downloads","issues_url":"https://api.github.com/repos/appium/appium-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-desktop/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-desktop/deployments","created_at":"2016-07-18T00:08:00Z","updated_at":"2018-12-03T18:04:05Z","pushed_at":"2018-12-03T23:04:28Z","git_url":"git://github.com/appium/appium-desktop.git","ssh_url":"git@github.com:appium/appium-desktop.git","clone_url":"https://github.com/appium/appium-desktop.git","svn_url":"https://github.com/appium/appium-desktop","homepage":null,"size":7386,"stargazers_count":1295,"watchers_count":1295,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":376,"open_issues":60,"watchers":1295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/752"},"html":{"href":"https://github.com/appium/appium-desktop/pull/752"},"issue":{"href":"https://api.github.com/repos/appium/appium-desktop/issues/752"},"comments":{"href":"https://api.github.com/repos/appium/appium-desktop/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-desktop/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-desktop/statuses/44b933622207af42250ecece099e0c211832e30c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dpgraham"}}