{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/166219131","pull_request_review_id":94259550,"id":166219131,"diff_hunk":"@@ -109,8 +109,13 @@ int convert_double(PyObject *obj, void *p)\n int convert_bool(PyObject *obj, void *p)\n {\n     bool *val = (bool *)p;\n+    int ret;","path":"src/py_converters.cpp","position":4,"original_position":4,"commit_id":"8e3d72c08d6f2663b3cdd53883135d70d2f797ea","original_commit_id":"8e3d72c08d6f2663b3cdd53883135d70d2f797ea","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"All of the convert functions use `void*`.","created_at":"2018-02-06T08:41:22Z","updated_at":"2018-02-06T08:41:22Z","html_url":"https://github.com/matplotlib/matplotlib/pull/10383#discussion_r166219131","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/166219131"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10383#discussion_r166219131"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383"}},"in_reply_to_id":166210255},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383","id":167295588,"html_url":"https://github.com/matplotlib/matplotlib/pull/10383","diff_url":"https://github.com/matplotlib/matplotlib/pull/10383.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/10383.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10383","number":10383,"state":"open","locked":false,"title":"Fix some C++ warnings","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nThis fixes various minor type conversion and other casting warnings. It is not completely clean now, but saves about 100 lines of warnings in every AppVeyor build.\r\n\r\n## PR Checklist\r\n\r\n- [ ] Has Pytest style unit tests\r\n- [ ] Code is PEP 8 compliant\r\n- [N/A] New features are documented, with examples if plot related\r\n- [N/A] Documentation is sphinx and numpydoc compliant\r\n- [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way","created_at":"2018-02-06T01:04:12Z","updated_at":"2018-02-06T08:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aa2f1501b38387f2b94864f52cbefd367a39c5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10383/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/8e3d72c08d6f2663b3cdd53883135d70d2f797ea","head":{"label":"QuLogic:c-warnings","ref":"c-warnings","sha":"8e3d72c08d6f2663b3cdd53883135d70d2f797ea","user":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"repo":{"id":21548241,"name":"matplotlib","full_name":"QuLogic/matplotlib","owner":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars2.githubusercontent.com/u/302469?v=4","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QuLogic/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/QuLogic/matplotlib","forks_url":"https://api.github.com/repos/QuLogic/matplotlib/forks","keys_url":"https://api.github.com/repos/QuLogic/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuLogic/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuLogic/matplotlib/teams","hooks_url":"https://api.github.com/repos/QuLogic/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/QuLogic/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/QuLogic/matplotlib/events","assignees_url":"https://api.github.com/repos/QuLogic/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/QuLogic/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/QuLogic/matplotlib/tags","blobs_url":"https://api.github.com/repos/QuLogic/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuLogic/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuLogic/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuLogic/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuLogic/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/QuLogic/matplotlib/languages","stargazers_url":"https://api.github.com/repos/QuLogic/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/QuLogic/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/QuLogic/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/QuLogic/matplotlib/subscription","commits_url":"https://api.github.com/repos/QuLogic/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuLogic/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuLogic/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuLogic/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuLogic/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/QuLogic/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuLogic/matplotlib/merges","archive_url":"https://api.github.com/repos/QuLogic/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuLogic/matplotlib/downloads","issues_url":"https://api.github.com/repos/QuLogic/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/QuLogic/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/QuLogic/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/QuLogic/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuLogic/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/QuLogic/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/QuLogic/matplotlib/deployments","created_at":"2014-07-06T20:41:46Z","updated_at":"2018-01-21T18:26:22Z","pushed_at":"2018-02-06T08:04:27Z","git_url":"git://github.com/QuLogic/matplotlib.git","ssh_url":"git@github.com:QuLogic/matplotlib.git","clone_url":"https://github.com/QuLogic/matplotlib.git","svn_url":"https://github.com/QuLogic/matplotlib","homepage":"http://matplotlib.org/","size":330943,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"2e83a8a89ecb8bb0d3467ffbe5f6a135ecbbcb49","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-02-06T07:13:25Z","pushed_at":"2018-02-06T08:28:23Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":321836,"stargazers_count":6706,"watchers_count":6706,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3156,"mirror_url":null,"archived":false,"open_issues_count":1353,"license":null,"forks":3156,"open_issues":1353,"watchers":6706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10383"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10383"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10383/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10383/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/8e3d72c08d6f2663b3cdd53883135d70d2f797ea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"QuLogic"}}