{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/226202237","pull_request_review_id":165965583,"id":226202237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIwMjIzNw==","diff_hunk":"@@ -31,11 +31,16 @@\n \n     /**\n      * Attachment key that if present signifies that the security subsystem is installed.\n-     *\n+     * <p>\n      * If this is not present either the subsystem has been removed from the config or excluded\n      * via jboss-deployment-structure.xml. This allows deployments to disable security, and\n      * avoid the overhead of running unneeded security code.\n+     *\n+     * @deprecated Check the presence of {@link org.jboss.as.security.SecuritySubsystemRootResourceDefinition#SECURITY_SUBSYSTEM}","path":"security/subsystem/src/main/java/org/jboss/as/security/deployment/SecurityAttachments.java","position":10,"original_position":10,"commit_id":"e1336eb000c69b0bad69ba6655101206cc8fdeb2","original_commit_id":"e1336eb000c69b0bad69ba6655101206cc8fdeb2","user":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"body":"Done in https://github.com/wildfly/wildfly/pull/11763","created_at":"2018-10-18T07:57:20Z","updated_at":"2018-10-18T07:57:21Z","html_url":"https://github.com/wildfly/wildfly/pull/11757#discussion_r226202237","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11757","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/226202237"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11757#discussion_r226202237"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11757"}},"in_reply_to_id":225989271},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/11757","id":223557162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTU3MTYy","html_url":"https://github.com/wildfly/wildfly/pull/11757","diff_url":"https://github.com/wildfly/wildfly/pull/11757.diff","patch_url":"https://github.com/wildfly/wildfly/pull/11757.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/11757","number":11757,"state":"closed","locked":false,"title":"[WFLY-11137] Make undertow extension module's dependency on org.jbossas.security and org.picketbox modules optional ","user":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"body":"- Makes org.jbossas.security and org.picketbox optional. Those modules are not required if legacy subsystem is not available.\r\n- Removes the no longer used DigestCredentialImpl\r\n- Deprecates SECURITY_ENABLED attachment in favor of capability uses\r\n\r\nJira issue: https://issues.jboss.org/browse/WFLY-11137\r\n\r\n@darranl could you take a look to approve these changes related with the removal of DigestCredentialImpl? thanks","created_at":"2018-10-17T10:56:12Z","updated_at":"2018-10-18T07:57:20Z","closed_at":"2018-10-18T00:00:04Z","merged_at":"2018-10-18T00:00:04Z","merge_commit_sha":"de2e10961352510d06b9230271f14adc09ea0a93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":124774923,"node_id":"MDU6TGFiZWwxMjQ3NzQ5MjM=","url":"https://api.github.com/repos/wildfly/wildfly/labels/ready-for-merge","name":"ready-for-merge","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11757/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/11757/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/11757/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/e1336eb000c69b0bad69ba6655101206cc8fdeb2","head":{"label":"yersan:tasks/WFLY-11137","ref":"tasks/WFLY-11137","sha":"e1336eb000c69b0bad69ba6655101206cc8fdeb2","user":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"repo":{"id":51616834,"node_id":"MDEwOlJlcG9zaXRvcnk1MTYxNjgzNA==","name":"wildfly","full_name":"yersan/wildfly","private":false,"owner":{"login":"yersan","id":5951113,"node_id":"MDQ6VXNlcjU5NTExMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yersan/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/yersan/wildfly","forks_url":"https://api.github.com/repos/yersan/wildfly/forks","keys_url":"https://api.github.com/repos/yersan/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yersan/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yersan/wildfly/teams","hooks_url":"https://api.github.com/repos/yersan/wildfly/hooks","issue_events_url":"https://api.github.com/repos/yersan/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/yersan/wildfly/events","assignees_url":"https://api.github.com/repos/yersan/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/yersan/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/yersan/wildfly/tags","blobs_url":"https://api.github.com/repos/yersan/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yersan/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yersan/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/yersan/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yersan/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/yersan/wildfly/languages","stargazers_url":"https://api.github.com/repos/yersan/wildfly/stargazers","contributors_url":"https://api.github.com/repos/yersan/wildfly/contributors","subscribers_url":"https://api.github.com/repos/yersan/wildfly/subscribers","subscription_url":"https://api.github.com/repos/yersan/wildfly/subscription","commits_url":"https://api.github.com/repos/yersan/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/yersan/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/yersan/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/yersan/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/yersan/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/yersan/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yersan/wildfly/merges","archive_url":"https://api.github.com/repos/yersan/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yersan/wildfly/downloads","issues_url":"https://api.github.com/repos/yersan/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/yersan/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/yersan/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/yersan/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yersan/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/yersan/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/yersan/wildfly/deployments","created_at":"2016-02-12T21:13:07Z","updated_at":"2018-10-18T07:43:29Z","pushed_at":"2018-10-18T07:53:17Z","git_url":"git://github.com/yersan/wildfly.git","ssh_url":"git@github.com:yersan/wildfly.git","clone_url":"https://github.com/yersan/wildfly.git","svn_url":"https://github.com/yersan/wildfly","homepage":"http://wildfly.org","size":188776,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"fc112ba15c611de0069edc6e2c607052947b886a","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQ3MDg=","name":"wildfly","full_name":"wildfly/wildfly","private":false,"owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2018-10-18T05:53:14Z","pushed_at":"2018-10-18T07:55:53Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":188802,"stargazers_count":2064,"watchers_count":2064,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1828,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1828,"open_issues":57,"watchers":2064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11757"},"html":{"href":"https://github.com/wildfly/wildfly/pull/11757"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11757"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/11757/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11757/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/11757/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/e1336eb000c69b0bad69ba6655101206cc8fdeb2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yersan"}}