{"action":"closed","number":4562,"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/4562","id":195923948,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTIzOTQ4","html_url":"https://github.com/cilium/cilium/pull/4562","diff_url":"https://github.com/cilium/cilium/pull/4562.diff","patch_url":"https://github.com/cilium/cilium/pull/4562.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/4562","number":4562,"state":"closed","locked":false,"title":"Fix index out of range error in ParseToCiliumRule","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":"Recent refactoring introduced an indexing error:\r\n    \r\n    panic: runtime error: index out of range\r\n    \r\n    goroutine 743 [running]:\r\n    github.com/cilium/cilium/pkg/k8s/apis/cilium.io/utils.ParseToCiliumRule(...)\r\n            /go/src/github.com/cilium/cilium/pkg/k8s/apis/cilium.io/utils/utils.go:200 +0x9ee\r\n    github.com/cilium/cilium/pkg/k8s/apis/cilium.io/v2.(*CiliumNetworkPolicy).Parse(...)\r\n            /go/src/github.com/cilium/cilium/pkg/k8s/apis/cilium.io/v2/types.go:161 +0x1b9\r\n    main.(*Daemon).addCiliumNetworkPolicyV2(...)\r\n            /go/src/github.com/cilium/cilium/daemon/k8s_watcher.go:1308 +0x2d3\r\n    main.(*Daemon).EnableK8sWatcher.func13.1(...)\r\n            /go/src/github.com/cilium/cilium/daemon/k8s_watcher.go:414 +0x45\r\n    github.com/cilium/cilium/pkg/serializer.(*functionQueue).run(...)\r\n            /go/src/github.com/cilium/cilium/pkg/serializer/func_queue.go:65 +0x70\r\n    created by github.com/cilium/cilium/pkg/serializer.NewFunctionQueue\r\n            /go/src/github.com/cilium/cilium/pkg/serializer/func_queue.go:45 +0xca\r\n    \r\nFix the issue and introduce unit tests to catch this in future.\r\n    \r\nFixes: #4548\r\nFixes: 86c5ac2a32e9 (\"utils: Refactor reaching into EndpointSelector\")\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/4562)\n<!-- Reviewable:end -->\n","created_at":"2018-06-19T18:51:09Z","updated_at":"2018-06-19T23:45:52Z","closed_at":"2018-06-19T23:45:52Z","merged_at":"2018-06-19T23:45:52Z","merge_commit_sha":"2cb38fdaadf05a2c93f08a7b1008d8b856199c0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721366651,"node_id":"MDU6TGFiZWw3MjEzNjY2NTE=","url":"https://api.github.com/repos/cilium/cilium/labels/area/k8s","name":"area/k8s","color":"2c3aa0","default":false},{"id":746643464,"node_id":"MDU6TGFiZWw3NDY2NDM0NjQ=","url":"https://api.github.com/repos/cilium/cilium/labels/area/policy","name":"area/policy","color":"c9f97a","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":627462913,"node_id":"MDU6TGFiZWw2Mjc0NjI5MTM=","url":"https://api.github.com/repos/cilium/cilium/labels/priority/high","name":"priority/high","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/4562/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/4562/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/4562/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/1d6cf47b43aca24d17f0bd16344af95e0aac5da9","head":{"label":"joestringer:submit/parse-crash","ref":"submit/parse-crash","sha":"1d6cf47b43aca24d17f0bd16344af95e0aac5da9","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"repo":{"id":103188387,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMxODgzODc=","name":"cilium","full_name":"joestringer/cilium","owner":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joestringer/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/joestringer/cilium","forks_url":"https://api.github.com/repos/joestringer/cilium/forks","keys_url":"https://api.github.com/repos/joestringer/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joestringer/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joestringer/cilium/teams","hooks_url":"https://api.github.com/repos/joestringer/cilium/hooks","issue_events_url":"https://api.github.com/repos/joestringer/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/joestringer/cilium/events","assignees_url":"https://api.github.com/repos/joestringer/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/joestringer/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/joestringer/cilium/tags","blobs_url":"https://api.github.com/repos/joestringer/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joestringer/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joestringer/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/joestringer/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joestringer/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/joestringer/cilium/languages","stargazers_url":"https://api.github.com/repos/joestringer/cilium/stargazers","contributors_url":"https://api.github.com/repos/joestringer/cilium/contributors","subscribers_url":"https://api.github.com/repos/joestringer/cilium/subscribers","subscription_url":"https://api.github.com/repos/joestringer/cilium/subscription","commits_url":"https://api.github.com/repos/joestringer/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/joestringer/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/joestringer/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/joestringer/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/joestringer/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/joestringer/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joestringer/cilium/merges","archive_url":"https://api.github.com/repos/joestringer/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joestringer/cilium/downloads","issues_url":"https://api.github.com/repos/joestringer/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/joestringer/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/joestringer/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/joestringer/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joestringer/cilium/labels{/name}","releases_url":"https://api.github.com/repos/joestringer/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/joestringer/cilium/deployments","created_at":"2017-09-11T21:09:05Z","updated_at":"2017-09-11T21:09:08Z","pushed_at":"2018-06-19T23:28:10Z","git_url":"git://github.com/joestringer/cilium.git","ssh_url":"git@github.com:joestringer/cilium.git","clone_url":"https://github.com/joestringer/cilium.git","svn_url":"https://github.com/joestringer/cilium","homepage":"","size":49776,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"ff08f88a354d50f40e9473e3c4fd0ae503e0e703","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-06-19T20:03:13Z","pushed_at":"2018-06-19T23:45:52Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":52375,"stargazers_count":2410,"watchers_count":2410,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":547,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":206,"open_issues":547,"watchers":2410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4562"},"html":{"href":"https://github.com/cilium/cilium/pull/4562"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/4562"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/4562/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4562/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4562/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/1d6cf47b43aca24d17f0bd16344af95e0aac5da9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":195,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"tgraf"}}