{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/893","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/893/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/893/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/893/events","html_url":"https://github.com/jetstack/cert-manager/pull/893","id":359521962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTkzNzYy","number":893,"title":"Configurable issuer duration and renewBefore Take 2","user":{"login":"Queuecumber","id":5865387,"node_id":"MDQ6VXNlcjU4NjUzODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5865387?v=4","gravatar_id":"","url":"https://api.github.com/users/Queuecumber","html_url":"https://github.com/Queuecumber","followers_url":"https://api.github.com/users/Queuecumber/followers","following_url":"https://api.github.com/users/Queuecumber/following{/other_user}","gists_url":"https://api.github.com/users/Queuecumber/gists{/gist_id}","starred_url":"https://api.github.com/users/Queuecumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Queuecumber/subscriptions","organizations_url":"https://api.github.com/users/Queuecumber/orgs","repos_url":"https://api.github.com/users/Queuecumber/repos","events_url":"https://api.github.com/users/Queuecumber/events{/privacy}","received_events_url":"https://api.github.com/users/Queuecumber/received_events","type":"User","site_admin":false},"labels":[{"id":1041273320,"node_id":"MDU6TGFiZWwxMDQxMjczMzIw","url":"https://api.github.com/repos/jetstack/cert-manager/labels/dco-signoff:%20yes","name":"dco-signoff: yes","color":"ededed","default":false},{"id":728590545,"node_id":"MDU6TGFiZWw3Mjg1OTA1NDU=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":727722560,"node_id":"MDU6TGFiZWw3Mjc3MjI1NjA=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":728244369,"node_id":"MDU6TGFiZWw3MjgyNDQzNjk=","url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false},"assignees":[{"login":"kragniz","id":735008,"node_id":"MDQ6VXNlcjczNTAwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/735008?v=4","gravatar_id":"","url":"https://api.github.com/users/kragniz","html_url":"https://github.com/kragniz","followers_url":"https://api.github.com/users/kragniz/followers","following_url":"https://api.github.com/users/kragniz/following{/other_user}","gists_url":"https://api.github.com/users/kragniz/gists{/gist_id}","starred_url":"https://api.github.com/users/kragniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kragniz/subscriptions","organizations_url":"https://api.github.com/users/kragniz/orgs","repos_url":"https://api.github.com/users/kragniz/repos","events_url":"https://api.github.com/users/kragniz/events{/privacy}","received_events_url":"https://api.github.com/users/kragniz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-09-12T14:59:27Z","updated_at":"2018-10-08T12:55:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/893","html_url":"https://github.com/jetstack/cert-manager/pull/893","diff_url":"https://github.com/jetstack/cert-manager/pull/893.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/893.patch"},"body":"This is me commandeering #520 because it is clearly not being worked on\r\n\r\nPlan right now is to skip 516be06435970401a92f6223750d76586db1d563 in favor of validation which disallows duration for ACME issuers. \r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis pull request makes possible to configure the certificate validity duration and the renewal before duration per issuer.\r\n\r\n**Which issue this PR fixes** \r\n\r\n#437\r\n\r\n**Special notes for your reviewer**:\r\n\r\nTODO\r\n1. ~~Salvage code from 723015174a167d746323f506ab3575cfb243d8bd~~\r\n1. ~~Make the existing unit and e2e tests work~~\r\n1. ~~Use duration config in self-signed issuer~~\r\n1. General code quality updates\r\n1. ~~Validate that duration is not set for ACME certs (w/ unit test)~~\r\n1. ~~Test everything in a real cluster~~\r\n1. ~~Validate durations in validation and not issuer setup~~\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nConfigurable certificate duration and renewal duration using fields Issuer.spec.duration and \r\nIssuer.spec.renewBefore respectively.\r\nThe CA Issuer default duration is now 90 days instead of 365 days to make all issuers more consistent when configured without explicit duration.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments/427821335","html_url":"https://github.com/jetstack/cert-manager/pull/893#issuecomment-427821335","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/893","id":427821335,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzgyMTMzNQ==","user":{"login":"jetstack-bot","id":32282838,"node_id":"MDQ6VXNlcjMyMjgyODM4","avatar_url":"https://avatars1.githubusercontent.com/u/32282838?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-bot","html_url":"https://github.com/jetstack-bot","followers_url":"https://api.github.com/users/jetstack-bot/followers","following_url":"https://api.github.com/users/jetstack-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-bot/orgs","repos_url":"https://api.github.com/users/jetstack-bot/repos","events_url":"https://api.github.com/users/jetstack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T12:55:44Z","updated_at":"2018-10-08T12:55:44Z","author_association":"COLLABORATOR","body":"@Queuecumber: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-cert-manager-docs | 33fc46a07c5b5d293684d312f6801d78f0ae2b09 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/893/pull-cert-manager-docs/191/) | `/test docs`\npull-cert-manager-codegen | 33fc46a07c5b5d293684d312f6801d78f0ae2b09 | [link](https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_cert-manager/893/pull-cert-manager-codegen/193/) | `/test codegen`\n\n[Full PR test history](https://jetstack-build-infra.appspot.com/pr/jetstack_cert-manager/893). [Your PR dashboard](https://jetstack-build-infra.appspot.com/pr/Queuecumber). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/jetstack/cert-manager/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"jetstack-bot"}}