{"action":"closed","number":2645,"pull_request":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/2645","id":170024060,"html_url":"https://github.com/graknlabs/grakn/pull/2645","diff_url":"https://github.com/graknlabs/grakn/pull/2645.diff","patch_url":"https://github.com/graknlabs/grakn/pull/2645.patch","issue_url":"https://api.github.com/repos/graknlabs/grakn/issues/2645","number":2645,"state":"closed","locked":false,"title":"More explicit count post processor method names","user":{"login":"lolski","id":464164,"avatar_url":"https://avatars0.githubusercontent.com/u/464164?v=4","gravatar_id":"","url":"https://api.github.com/users/lolski","html_url":"https://github.com/lolski","followers_url":"https://api.github.com/users/lolski/followers","following_url":"https://api.github.com/users/lolski/following{/other_user}","gists_url":"https://api.github.com/users/lolski/gists{/gist_id}","starred_url":"https://api.github.com/users/lolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolski/subscriptions","organizations_url":"https://api.github.com/users/lolski/orgs","repos_url":"https://api.github.com/users/lolski/repos","events_url":"https://api.github.com/users/lolski/events{/privacy}","received_events_url":"https://api.github.com/users/lolski/received_events","type":"User","site_admin":false},"body":"# Why is this PR needed?\r\nMinor stuff - renaming methods and method parameters to be more explicit\r\n\r\n# What does the PR do?\r\nMinor stuff - renaming methods and method parameters to be more explicit\r\n\r\n# Does it break backwards compatibility?\r\nNo\r\n\r\n# List of future improvements not on this PR\r\n`incrementInstanceCountAndCheckIfShardingIsNeeded` can be split into two - `incrementInstanceCount` and `checkIfShardingIsNeeded`, but this will do for now.","created_at":"2018-02-19T18:02:27Z","updated_at":"2018-02-20T14:09:52Z","closed_at":"2018-02-20T14:09:52Z","merged_at":"2018-02-20T14:09:52Z","merge_commit_sha":"853a4e1dad2c9f823d17f2b6efbcc9fe33e7c82f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2645/commits","review_comments_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2645/comments","review_comment_url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graknlabs/grakn/issues/2645/comments","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/dd176219c1a652f8698c469e03590d9e8a127602","head":{"label":"lolski:count-postprocessor-minor-refactor","ref":"count-postprocessor-minor-refactor","sha":"dd176219c1a652f8698c469e03590d9e8a127602","user":{"login":"lolski","id":464164,"avatar_url":"https://avatars0.githubusercontent.com/u/464164?v=4","gravatar_id":"","url":"https://api.github.com/users/lolski","html_url":"https://github.com/lolski","followers_url":"https://api.github.com/users/lolski/followers","following_url":"https://api.github.com/users/lolski/following{/other_user}","gists_url":"https://api.github.com/users/lolski/gists{/gist_id}","starred_url":"https://api.github.com/users/lolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolski/subscriptions","organizations_url":"https://api.github.com/users/lolski/orgs","repos_url":"https://api.github.com/users/lolski/repos","events_url":"https://api.github.com/users/lolski/events{/privacy}","received_events_url":"https://api.github.com/users/lolski/received_events","type":"User","site_admin":false},"repo":{"id":91786257,"name":"grakn","full_name":"lolski/grakn","owner":{"login":"lolski","id":464164,"avatar_url":"https://avatars0.githubusercontent.com/u/464164?v=4","gravatar_id":"","url":"https://api.github.com/users/lolski","html_url":"https://github.com/lolski","followers_url":"https://api.github.com/users/lolski/followers","following_url":"https://api.github.com/users/lolski/following{/other_user}","gists_url":"https://api.github.com/users/lolski/gists{/gist_id}","starred_url":"https://api.github.com/users/lolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolski/subscriptions","organizations_url":"https://api.github.com/users/lolski/orgs","repos_url":"https://api.github.com/users/lolski/repos","events_url":"https://api.github.com/users/lolski/events{/privacy}","received_events_url":"https://api.github.com/users/lolski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lolski/grakn","description":"The Database for AI","fork":true,"url":"https://api.github.com/repos/lolski/grakn","forks_url":"https://api.github.com/repos/lolski/grakn/forks","keys_url":"https://api.github.com/repos/lolski/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lolski/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lolski/grakn/teams","hooks_url":"https://api.github.com/repos/lolski/grakn/hooks","issue_events_url":"https://api.github.com/repos/lolski/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/lolski/grakn/events","assignees_url":"https://api.github.com/repos/lolski/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/lolski/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/lolski/grakn/tags","blobs_url":"https://api.github.com/repos/lolski/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lolski/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lolski/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/lolski/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lolski/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/lolski/grakn/languages","stargazers_url":"https://api.github.com/repos/lolski/grakn/stargazers","contributors_url":"https://api.github.com/repos/lolski/grakn/contributors","subscribers_url":"https://api.github.com/repos/lolski/grakn/subscribers","subscription_url":"https://api.github.com/repos/lolski/grakn/subscription","commits_url":"https://api.github.com/repos/lolski/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/lolski/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/lolski/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/lolski/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/lolski/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/lolski/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lolski/grakn/merges","archive_url":"https://api.github.com/repos/lolski/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lolski/grakn/downloads","issues_url":"https://api.github.com/repos/lolski/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/lolski/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/lolski/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/lolski/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lolski/grakn/labels{/name}","releases_url":"https://api.github.com/repos/lolski/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/lolski/grakn/deployments","created_at":"2017-05-19T08:52:03Z","updated_at":"2017-10-25T14:49:33Z","pushed_at":"2018-02-20T12:30:12Z","git_url":"git://github.com/lolski/grakn.git","ssh_url":"git@github.com:lolski/grakn.git","clone_url":"https://github.com/lolski/grakn.git","svn_url":"https://github.com/lolski/grakn","homepage":"https://grakn.ai","size":49324,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graknlabs:master","ref":"master","sha":"de147925bff19d31ac06fa4033fae2e46566214c","user":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63110867,"name":"grakn","full_name":"graknlabs/grakn","owner":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graknlabs/grakn","description":"The Hyper-Relational Database for Knowledge Engineering","fork":false,"url":"https://api.github.com/repos/graknlabs/grakn","forks_url":"https://api.github.com/repos/graknlabs/grakn/forks","keys_url":"https://api.github.com/repos/graknlabs/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graknlabs/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graknlabs/grakn/teams","hooks_url":"https://api.github.com/repos/graknlabs/grakn/hooks","issue_events_url":"https://api.github.com/repos/graknlabs/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/graknlabs/grakn/events","assignees_url":"https://api.github.com/repos/graknlabs/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/graknlabs/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/graknlabs/grakn/tags","blobs_url":"https://api.github.com/repos/graknlabs/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graknlabs/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graknlabs/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/graknlabs/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/graknlabs/grakn/languages","stargazers_url":"https://api.github.com/repos/graknlabs/grakn/stargazers","contributors_url":"https://api.github.com/repos/graknlabs/grakn/contributors","subscribers_url":"https://api.github.com/repos/graknlabs/grakn/subscribers","subscription_url":"https://api.github.com/repos/graknlabs/grakn/subscription","commits_url":"https://api.github.com/repos/graknlabs/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/graknlabs/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/graknlabs/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/graknlabs/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/graknlabs/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/graknlabs/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graknlabs/grakn/merges","archive_url":"https://api.github.com/repos/graknlabs/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graknlabs/grakn/downloads","issues_url":"https://api.github.com/repos/graknlabs/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/graknlabs/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/graknlabs/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/graknlabs/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graknlabs/grakn/labels{/name}","releases_url":"https://api.github.com/repos/graknlabs/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/graknlabs/grakn/deployments","created_at":"2016-07-11T23:59:57Z","updated_at":"2018-02-20T13:45:18Z","pushed_at":"2018-02-20T14:09:52Z","git_url":"git://github.com/graknlabs/grakn.git","ssh_url":"git@github.com:graknlabs/grakn.git","clone_url":"https://github.com/graknlabs/grakn.git","svn_url":"https://github.com/graknlabs/grakn","homepage":"https://grakn.ai","size":48717,"stargazers_count":789,"watchers_count":789,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":109,"open_issues":37,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2645"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2645"},"issue":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2645"},"comments":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2645/comments"},"review_comments":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2645/comments"},"review_comment":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2645/commits"},"statuses":{"href":"https://api.github.com/repos/graknlabs/grakn/statuses/dd176219c1a652f8698c469e03590d9e8a127602"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lolski","id":464164,"avatar_url":"https://avatars0.githubusercontent.com/u/464164?v=4","gravatar_id":"","url":"https://api.github.com/users/lolski","html_url":"https://github.com/lolski","followers_url":"https://api.github.com/users/lolski/followers","following_url":"https://api.github.com/users/lolski/following{/other_user}","gists_url":"https://api.github.com/users/lolski/gists{/gist_id}","starred_url":"https://api.github.com/users/lolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolski/subscriptions","organizations_url":"https://api.github.com/users/lolski/orgs","repos_url":"https://api.github.com/users/lolski/repos","events_url":"https://api.github.com/users/lolski/events{/privacy}","received_events_url":"https://api.github.com/users/lolski/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":18,"changed_files":4}}
{"actor":{"display_login":"lolski"}}