{"action":"opened","issue":{"url":"https://api.github.com/repos/gausby/tortoise/issues/27","repository_url":"https://api.github.com/repos/gausby/tortoise","labels_url":"https://api.github.com/repos/gausby/tortoise/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/gausby/tortoise/issues/27/comments","events_url":"https://api.github.com/repos/gausby/tortoise/issues/27/events","html_url":"https://github.com/gausby/tortoise/issues/27","id":320627223,"number":27,"title":"Consider what to do when subscriptions are rejected or otherwise fail","user":{"login":"gausby","id":482052,"avatar_url":"https://avatars3.githubusercontent.com/u/482052?v=4","gravatar_id":"","url":"https://api.github.com/users/gausby","html_url":"https://github.com/gausby","followers_url":"https://api.github.com/users/gausby/followers","following_url":"https://api.github.com/users/gausby/following{/other_user}","gists_url":"https://api.github.com/users/gausby/gists{/gist_id}","starred_url":"https://api.github.com/users/gausby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gausby/subscriptions","organizations_url":"https://api.github.com/users/gausby/orgs","repos_url":"https://api.github.com/users/gausby/repos","events_url":"https://api.github.com/users/gausby/events{/privacy}","received_events_url":"https://api.github.com/users/gausby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-06T20:51:23Z","updated_at":"2018-05-06T20:51:23Z","closed_at":null,"author_association":"OWNER","body":"When subscribing to a filter topic the broker can choose to accept the subscription but with a different quality of service than the one requested. Right now the subscription will return a map as a result with the keys:\r\n\r\n  - `:ok`, for the topics that got accepted with the requested QoS,\r\n  - `:warn` for the topics that got accepted with a different QoS than requested, and \r\n  - `:error` for the topics that returned a access denied error\r\n\r\nWe should think about what should happen in cases where a subscription result in a warning, or an error. Should we crash? After all, the expectations was not met. I suggest that we could make this a config option.\r\n\r\nThe user defined callback module has a callback called `subscription` which will get a `:up` message when a subscription is accepted, and a `:down` when it is unsubscribed. This could get an extra, such as `:denied`; this would require the user to implement extra stuff, which wouldn't be that bad because the user should think about what to do in this situation.\r\n\r\nThis needs some R&D."}}
{"actor":{"display_login":"gausby"}}