{"action":"created","issue":{"url":"https://api.github.com/repos/containers/virtcontainers/issues/614","repository_url":"https://api.github.com/repos/containers/virtcontainers","labels_url":"https://api.github.com/repos/containers/virtcontainers/issues/614/labels{/name}","comments_url":"https://api.github.com/repos/containers/virtcontainers/issues/614/comments","events_url":"https://api.github.com/repos/containers/virtcontainers/issues/614/events","html_url":"https://github.com/containers/virtcontainers/pull/614","id":296067478,"number":614,"title":"qemu: Add support for ARM","user":{"login":"devimc","id":13009432,"avatar_url":"https://avatars0.githubusercontent.com/u/13009432?v=4","gravatar_id":"","url":"https://api.github.com/users/devimc","html_url":"https://github.com/devimc","followers_url":"https://api.github.com/users/devimc/followers","following_url":"https://api.github.com/users/devimc/following{/other_user}","gists_url":"https://api.github.com/users/devimc/gists{/gist_id}","starred_url":"https://api.github.com/users/devimc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devimc/subscriptions","organizations_url":"https://api.github.com/users/devimc/orgs","repos_url":"https://api.github.com/users/devimc/repos","events_url":"https://api.github.com/users/devimc/events{/privacy}","received_events_url":"https://api.github.com/users/devimc/received_events","type":"User","site_admin":false},"labels":[{"id":832913980,"url":"https://api.github.com/repos/containers/virtcontainers/labels/WIP","name":"WIP","color":"d93f0b","default":false},{"id":550573725,"url":"https://api.github.com/repos/containers/virtcontainers/labels/do-not-merge","name":"do-not-merge","color":"b60205","default":false},{"id":832019411,"url":"https://api.github.com/repos/containers/virtcontainers/labels/review","name":"review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-10T02:58:48Z","updated_at":"2018-02-15T11:11:43Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/containers/virtcontainers/pulls/614","html_url":"https://github.com/containers/virtcontainers/pull/614","diff_url":"https://github.com/containers/virtcontainers/pull/614.diff","patch_url":"https://github.com/containers/virtcontainers/pull/614.patch"},"body":"This patch introduces a new interface called qemuArch that contains\r\nthe functions needed to create qemu specific architecture implementations.\r\nThis patch also includes three qemu specific architecture\r\nimplementations: qemuKVM, qemuAmd64 and qemuArm64, since all architectures\r\nuse similar qemu command lines, the base structure is qemuKVM that is an\r\nagnostic implementation to start virtual machines, qemuAmd64 and qemuArm64\r\ninherit and override (if needed) the functions of qemuKVM, therefore architecture\r\nspecific optimizations are in qemuAmd64 and qemuArm64.\r\nFor example the `appendImage` function defined by qemuKVM uses a block\r\ndevice to provide the image to the VM, qemuArm64 inherits and doesn't\r\noverwrite it, but qemuAmd64 inherits and overwites it to provide the\r\nimage throught NVDIMM and DAX.\r\n    \r\nfixes #608\r\nfixes #610\r\nfixes #611\r\nfixes #612\r\n\r\nSigned-off-by: Julio Montes <julio.montes@intel.com>"},"comment":{"url":"https://api.github.com/repos/containers/virtcontainers/issues/comments/365896412","html_url":"https://github.com/containers/virtcontainers/pull/614#issuecomment-365896412","issue_url":"https://api.github.com/repos/containers/virtcontainers/issues/614","id":365896412,"user":{"login":"jodh-intel","id":20315601,"avatar_url":"https://avatars1.githubusercontent.com/u/20315601?v=4","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T11:11:43Z","updated_at":"2018-02-15T11:11:43Z","author_association":"COLLABORATOR","body":"Nice PR.\r\n\r\nLooks like it needs a rebase and a re-vendor of govmm for `qemu.Machine.Options`.\r\n"}}
{"actor":{"display_login":"jodh-intel"}}