{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20","id":177322673,"html_url":"https://github.com/timschofield/webERP-svn/pull/20","diff_url":"https://github.com/timschofield/webERP-svn/pull/20.diff","patch_url":"https://github.com/timschofield/webERP-svn/pull/20.patch","issue_url":"https://api.github.com/repos/timschofield/webERP-svn/issues/20","number":20,"state":"closed","locked":false,"title":"Improve Logout cookie handling","user":{"login":"TurboPT","id":16810539,"avatar_url":"https://avatars3.githubusercontent.com/u/16810539?v=4","gravatar_id":"","url":"https://api.github.com/users/TurboPT","html_url":"https://github.com/TurboPT","followers_url":"https://api.github.com/users/TurboPT/followers","following_url":"https://api.github.com/users/TurboPT/following{/other_user}","gists_url":"https://api.github.com/users/TurboPT/gists{/gist_id}","starred_url":"https://api.github.com/users/TurboPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurboPT/subscriptions","organizations_url":"https://api.github.com/users/TurboPT/orgs","repos_url":"https://api.github.com/users/TurboPT/repos","events_url":"https://api.github.com/users/TurboPT/events{/privacy}","received_events_url":"https://api.github.com/users/TurboPT/received_events","type":"User","site_admin":false},"body":"Change the setcookie lifetime to 1, and retrieve other parameters needed for cookie removal.\r\nBoth of these matters are due in part to OWASP recommendations and PHP.net documentation info.\r\n\r\nAlso, get the session.name in case some other session name is in use other than the default.\r\nAs one example of this potential need, see: http://www.weberp.org/forum/showthread.php?tid=8133&pid=14643#pid14643\r\n\r\nBeyond that simple session.name example, other systems may have defined session.name to something other than the default PHPSESSID in their php.ini file.","created_at":"2018-03-26T01:00:34Z","updated_at":"2018-03-26T08:59:28Z","closed_at":"2018-03-26T08:59:28Z","merged_at":"2018-03-26T08:59:28Z","merge_commit_sha":"245714860510109ab8a2d25266574af090b446bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20/commits","review_comments_url":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20/comments","review_comment_url":"https://api.github.com/repos/timschofield/webERP-svn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/timschofield/webERP-svn/issues/20/comments","statuses_url":"https://api.github.com/repos/timschofield/webERP-svn/statuses/b163d75c1f7ef9cfe863fb555c0c744ac8a0f821","head":{"label":"TurboPT:Logout-cookie-delete","ref":"Logout-cookie-delete","sha":"b163d75c1f7ef9cfe863fb555c0c744ac8a0f821","user":{"login":"TurboPT","id":16810539,"avatar_url":"https://avatars3.githubusercontent.com/u/16810539?v=4","gravatar_id":"","url":"https://api.github.com/users/TurboPT","html_url":"https://github.com/TurboPT","followers_url":"https://api.github.com/users/TurboPT/followers","following_url":"https://api.github.com/users/TurboPT/following{/other_user}","gists_url":"https://api.github.com/users/TurboPT/gists{/gist_id}","starred_url":"https://api.github.com/users/TurboPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurboPT/subscriptions","organizations_url":"https://api.github.com/users/TurboPT/orgs","repos_url":"https://api.github.com/users/TurboPT/repos","events_url":"https://api.github.com/users/TurboPT/events{/privacy}","received_events_url":"https://api.github.com/users/TurboPT/received_events","type":"User","site_admin":false},"repo":{"id":123301859,"name":"webERP-svn","full_name":"TurboPT/webERP-svn","owner":{"login":"TurboPT","id":16810539,"avatar_url":"https://avatars3.githubusercontent.com/u/16810539?v=4","gravatar_id":"","url":"https://api.github.com/users/TurboPT","html_url":"https://github.com/TurboPT","followers_url":"https://api.github.com/users/TurboPT/followers","following_url":"https://api.github.com/users/TurboPT/following{/other_user}","gists_url":"https://api.github.com/users/TurboPT/gists{/gist_id}","starred_url":"https://api.github.com/users/TurboPT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurboPT/subscriptions","organizations_url":"https://api.github.com/users/TurboPT/orgs","repos_url":"https://api.github.com/users/TurboPT/repos","events_url":"https://api.github.com/users/TurboPT/events{/privacy}","received_events_url":"https://api.github.com/users/TurboPT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TurboPT/webERP-svn","description":null,"fork":true,"url":"https://api.github.com/repos/TurboPT/webERP-svn","forks_url":"https://api.github.com/repos/TurboPT/webERP-svn/forks","keys_url":"https://api.github.com/repos/TurboPT/webERP-svn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TurboPT/webERP-svn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TurboPT/webERP-svn/teams","hooks_url":"https://api.github.com/repos/TurboPT/webERP-svn/hooks","issue_events_url":"https://api.github.com/repos/TurboPT/webERP-svn/issues/events{/number}","events_url":"https://api.github.com/repos/TurboPT/webERP-svn/events","assignees_url":"https://api.github.com/repos/TurboPT/webERP-svn/assignees{/user}","branches_url":"https://api.github.com/repos/TurboPT/webERP-svn/branches{/branch}","tags_url":"https://api.github.com/repos/TurboPT/webERP-svn/tags","blobs_url":"https://api.github.com/repos/TurboPT/webERP-svn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TurboPT/webERP-svn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TurboPT/webERP-svn/git/refs{/sha}","trees_url":"https://api.github.com/repos/TurboPT/webERP-svn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TurboPT/webERP-svn/statuses/{sha}","languages_url":"https://api.github.com/repos/TurboPT/webERP-svn/languages","stargazers_url":"https://api.github.com/repos/TurboPT/webERP-svn/stargazers","contributors_url":"https://api.github.com/repos/TurboPT/webERP-svn/contributors","subscribers_url":"https://api.github.com/repos/TurboPT/webERP-svn/subscribers","subscription_url":"https://api.github.com/repos/TurboPT/webERP-svn/subscription","commits_url":"https://api.github.com/repos/TurboPT/webERP-svn/commits{/sha}","git_commits_url":"https://api.github.com/repos/TurboPT/webERP-svn/git/commits{/sha}","comments_url":"https://api.github.com/repos/TurboPT/webERP-svn/comments{/number}","issue_comment_url":"https://api.github.com/repos/TurboPT/webERP-svn/issues/comments{/number}","contents_url":"https://api.github.com/repos/TurboPT/webERP-svn/contents/{+path}","compare_url":"https://api.github.com/repos/TurboPT/webERP-svn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TurboPT/webERP-svn/merges","archive_url":"https://api.github.com/repos/TurboPT/webERP-svn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TurboPT/webERP-svn/downloads","issues_url":"https://api.github.com/repos/TurboPT/webERP-svn/issues{/number}","pulls_url":"https://api.github.com/repos/TurboPT/webERP-svn/pulls{/number}","milestones_url":"https://api.github.com/repos/TurboPT/webERP-svn/milestones{/number}","notifications_url":"https://api.github.com/repos/TurboPT/webERP-svn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TurboPT/webERP-svn/labels{/name}","releases_url":"https://api.github.com/repos/TurboPT/webERP-svn/releases{/id}","deployments_url":"https://api.github.com/repos/TurboPT/webERP-svn/deployments","created_at":"2018-02-28T15:11:51Z","updated_at":"2018-03-26T01:08:36Z","pushed_at":"2018-03-26T01:08:35Z","git_url":"git://github.com/TurboPT/webERP-svn.git","ssh_url":"git@github.com:TurboPT/webERP-svn.git","clone_url":"https://github.com/TurboPT/webERP-svn.git","svn_url":"https://github.com/TurboPT/webERP-svn","homepage":null,"size":385811,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"timschofield:master","ref":"master","sha":"13e476a909a92fc4c66f442de1dbdb034e6a186d","user":{"login":"timschofield","id":48940,"avatar_url":"https://avatars2.githubusercontent.com/u/48940?v=4","gravatar_id":"","url":"https://api.github.com/users/timschofield","html_url":"https://github.com/timschofield","followers_url":"https://api.github.com/users/timschofield/followers","following_url":"https://api.github.com/users/timschofield/following{/other_user}","gists_url":"https://api.github.com/users/timschofield/gists{/gist_id}","starred_url":"https://api.github.com/users/timschofield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timschofield/subscriptions","organizations_url":"https://api.github.com/users/timschofield/orgs","repos_url":"https://api.github.com/users/timschofield/repos","events_url":"https://api.github.com/users/timschofield/events{/privacy}","received_events_url":"https://api.github.com/users/timschofield/received_events","type":"User","site_admin":false},"repo":{"id":122996980,"name":"webERP-svn","full_name":"timschofield/webERP-svn","owner":{"login":"timschofield","id":48940,"avatar_url":"https://avatars2.githubusercontent.com/u/48940?v=4","gravatar_id":"","url":"https://api.github.com/users/timschofield","html_url":"https://github.com/timschofield","followers_url":"https://api.github.com/users/timschofield/followers","following_url":"https://api.github.com/users/timschofield/following{/other_user}","gists_url":"https://api.github.com/users/timschofield/gists{/gist_id}","starred_url":"https://api.github.com/users/timschofield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timschofield/subscriptions","organizations_url":"https://api.github.com/users/timschofield/orgs","repos_url":"https://api.github.com/users/timschofield/repos","events_url":"https://api.github.com/users/timschofield/events{/privacy}","received_events_url":"https://api.github.com/users/timschofield/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timschofield/webERP-svn","description":null,"fork":false,"url":"https://api.github.com/repos/timschofield/webERP-svn","forks_url":"https://api.github.com/repos/timschofield/webERP-svn/forks","keys_url":"https://api.github.com/repos/timschofield/webERP-svn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timschofield/webERP-svn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timschofield/webERP-svn/teams","hooks_url":"https://api.github.com/repos/timschofield/webERP-svn/hooks","issue_events_url":"https://api.github.com/repos/timschofield/webERP-svn/issues/events{/number}","events_url":"https://api.github.com/repos/timschofield/webERP-svn/events","assignees_url":"https://api.github.com/repos/timschofield/webERP-svn/assignees{/user}","branches_url":"https://api.github.com/repos/timschofield/webERP-svn/branches{/branch}","tags_url":"https://api.github.com/repos/timschofield/webERP-svn/tags","blobs_url":"https://api.github.com/repos/timschofield/webERP-svn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timschofield/webERP-svn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timschofield/webERP-svn/git/refs{/sha}","trees_url":"https://api.github.com/repos/timschofield/webERP-svn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timschofield/webERP-svn/statuses/{sha}","languages_url":"https://api.github.com/repos/timschofield/webERP-svn/languages","stargazers_url":"https://api.github.com/repos/timschofield/webERP-svn/stargazers","contributors_url":"https://api.github.com/repos/timschofield/webERP-svn/contributors","subscribers_url":"https://api.github.com/repos/timschofield/webERP-svn/subscribers","subscription_url":"https://api.github.com/repos/timschofield/webERP-svn/subscription","commits_url":"https://api.github.com/repos/timschofield/webERP-svn/commits{/sha}","git_commits_url":"https://api.github.com/repos/timschofield/webERP-svn/git/commits{/sha}","comments_url":"https://api.github.com/repos/timschofield/webERP-svn/comments{/number}","issue_comment_url":"https://api.github.com/repos/timschofield/webERP-svn/issues/comments{/number}","contents_url":"https://api.github.com/repos/timschofield/webERP-svn/contents/{+path}","compare_url":"https://api.github.com/repos/timschofield/webERP-svn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timschofield/webERP-svn/merges","archive_url":"https://api.github.com/repos/timschofield/webERP-svn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timschofield/webERP-svn/downloads","issues_url":"https://api.github.com/repos/timschofield/webERP-svn/issues{/number}","pulls_url":"https://api.github.com/repos/timschofield/webERP-svn/pulls{/number}","milestones_url":"https://api.github.com/repos/timschofield/webERP-svn/milestones{/number}","notifications_url":"https://api.github.com/repos/timschofield/webERP-svn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timschofield/webERP-svn/labels{/name}","releases_url":"https://api.github.com/repos/timschofield/webERP-svn/releases{/id}","deployments_url":"https://api.github.com/repos/timschofield/webERP-svn/deployments","created_at":"2018-02-26T16:28:15Z","updated_at":"2018-03-22T07:27:20Z","pushed_at":"2018-03-26T08:59:28Z","git_url":"git://github.com/timschofield/webERP-svn.git","ssh_url":"git@github.com:timschofield/webERP-svn.git","clone_url":"https://github.com/timschofield/webERP-svn.git","svn_url":"https://github.com/timschofield/webERP-svn","homepage":null,"size":385872,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20"},"html":{"href":"https://github.com/timschofield/webERP-svn/pull/20"},"issue":{"href":"https://api.github.com/repos/timschofield/webERP-svn/issues/20"},"comments":{"href":"https://api.github.com/repos/timschofield/webERP-svn/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/timschofield/webERP-svn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/timschofield/webERP-svn/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/timschofield/webERP-svn/statuses/b163d75c1f7ef9cfe863fb555c0c744ac8a0f821"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"timschofield","id":48940,"avatar_url":"https://avatars2.githubusercontent.com/u/48940?v=4","gravatar_id":"","url":"https://api.github.com/users/timschofield","html_url":"https://github.com/timschofield","followers_url":"https://api.github.com/users/timschofield/followers","following_url":"https://api.github.com/users/timschofield/following{/other_user}","gists_url":"https://api.github.com/users/timschofield/gists{/gist_id}","starred_url":"https://api.github.com/users/timschofield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timschofield/subscriptions","organizations_url":"https://api.github.com/users/timschofield/orgs","repos_url":"https://api.github.com/users/timschofield/repos","events_url":"https://api.github.com/users/timschofield/events{/privacy}","received_events_url":"https://api.github.com/users/timschofield/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":39,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"timschofield"}}