{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments/166991483","pull_request_review_id":95141490,"id":166991483,"diff_hunk":"@@ -27,6 +27,9 @@ static CloudSdkService getInstance() {\n     return ServiceManager.getService(CloudSdkService.class);\n   }\n \n+  /** Called when this service becomes primary choice for serving Cloud SDK. */\n+  void activate();","path":"google-cloud-tools-plugin/src/com/google/cloud/tools/intellij/appengine/sdk/CloudSdkService.java","position":5,"original_position":5,"commit_id":"03087176122f813cdc3dd66e0f64c788059b7a79","original_commit_id":"03087176122f813cdc3dd66e0f64c788059b7a79","user":{"login":"etanshaul","id":1735744,"avatar_url":"https://avatars3.githubusercontent.com/u/1735744?v=4","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"body":"yeah thats true. I'm ok leaving it.","created_at":"2018-02-08T16:31:00Z","updated_at":"2018-02-08T16:31:00Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890#discussion_r166991483","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments/166991483"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890#discussion_r166991483"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890"}},"in_reply_to_id":166983898},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890","id":167535408,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/1890","number":1890,"state":"open","locked":false,"title":"Managed SDK service implementation","user":{"login":"ivanporty","id":11686100,"avatar_url":"https://avatars3.githubusercontent.com/u/11686100?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanporty","html_url":"https://github.com/ivanporty","followers_url":"https://api.github.com/users/ivanporty/followers","following_url":"https://api.github.com/users/ivanporty/following{/other_user}","gists_url":"https://api.github.com/users/ivanporty/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanporty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanporty/subscriptions","organizations_url":"https://api.github.com/users/ivanporty/orgs","repos_url":"https://api.github.com/users/ivanporty/repos","events_url":"https://api.github.com/users/ivanporty/events{/privacy}","received_events_url":"https://api.github.com/users/ivanporty/received_events","type":"User","site_admin":false},"body":"Implements:\r\n* SDK service interface \r\n* background installation \r\n* low level logging\r\n* cancellation and other housekeeping.\r\n\r\nNot here, for the following PRs:\r\n* UI and integration\r\n* SDK auto-updates\r\n","created_at":"2018-02-06T21:35:05Z","updated_at":"2018-02-08T16:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfba2e1c2b39ec61ed93063fb41422da7d5eeb33","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nbashirbello","id":6805942,"avatar_url":"https://avatars1.githubusercontent.com/u/6805942?v=4","gravatar_id":"","url":"https://api.github.com/users/nbashirbello","html_url":"https://github.com/nbashirbello","followers_url":"https://api.github.com/users/nbashirbello/followers","following_url":"https://api.github.com/users/nbashirbello/following{/other_user}","gists_url":"https://api.github.com/users/nbashirbello/gists{/gist_id}","starred_url":"https://api.github.com/users/nbashirbello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbashirbello/subscriptions","organizations_url":"https://api.github.com/users/nbashirbello/orgs","repos_url":"https://api.github.com/users/nbashirbello/repos","events_url":"https://api.github.com/users/nbashirbello/events{/privacy}","received_events_url":"https://api.github.com/users/nbashirbello/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/1890/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/03087176122f813cdc3dd66e0f64c788059b7a79","head":{"label":"GoogleCloudPlatform:managedsdk-implementation","ref":"managedsdk-implementation","sha":"03087176122f813cdc3dd66e0f64c788059b7a79","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"name":"google-cloud-intellij","full_name":"GoogleCloudPlatform/google-cloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2018-02-05T02:49:52Z","pushed_at":"2018-02-07T22:49:51Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","homepage":"","size":19384,"stargazers_count":79,"watchers_count":79,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":29,"open_issues":173,"watchers":79,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"d62a5d7b834f62b9de515f1ae40b7b7730fa9e17","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":38834157,"name":"google-cloud-intellij","full_name":"GoogleCloudPlatform/google-cloud-intellij","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","description":"Plugin to support the Google Cloud Platform in IntelliJ IDEA.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/deployments","created_at":"2015-07-09T17:08:59Z","updated_at":"2018-02-05T02:49:52Z","pushed_at":"2018-02-07T22:49:51Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-intellij.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-intellij.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-intellij","homepage":"","size":19384,"stargazers_count":79,"watchers_count":79,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":29,"open_issues":173,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/1890"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/1890"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/issues/1890/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/pulls/1890/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-intellij/statuses/03087176122f813cdc3dd66e0f64c788059b7a79"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"etanshaul"}}