{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11","id":201089478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDg5NDc4","html_url":"https://github.com/auth0/webtask-runtime/pull/11","diff_url":"https://github.com/auth0/webtask-runtime/pull/11.diff","patch_url":"https://github.com/auth0/webtask-runtime/pull/11.patch","issue_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/11","number":11,"state":"closed","locked":false,"title":"Update deprecated babel dep","user":{"login":"SkyHacks","id":10717361,"node_id":"MDQ6VXNlcjEwNzE3MzYx","avatar_url":"https://avatars0.githubusercontent.com/u/10717361?v=4","gravatar_id":"","url":"https://api.github.com/users/SkyHacks","html_url":"https://github.com/SkyHacks","followers_url":"https://api.github.com/users/SkyHacks/followers","following_url":"https://api.github.com/users/SkyHacks/following{/other_user}","gists_url":"https://api.github.com/users/SkyHacks/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyHacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyHacks/subscriptions","organizations_url":"https://api.github.com/users/SkyHacks/orgs","repos_url":"https://api.github.com/users/SkyHacks/repos","events_url":"https://api.github.com/users/SkyHacks/events{/privacy}","received_events_url":"https://api.github.com/users/SkyHacks/received_events","type":"User","site_admin":false},"body":"`wt-cli` is showing a deprecation warning for `minimatch`. Running `npm ls minimatch` shows:\r\n```\r\nwt-cli@10.0.1 /Users/sky/Desktop/Dev/Auth0/wt-cli\r\n├─┬ eslint@4.19.1\r\n│ ├─┬ file-entry-cache@2.0.0\r\n│ │ └─┬ flat-cache@1.3.0\r\n│ │   └─┬ del@2.2.2\r\n│ │     ├─┬ globby@5.0.0\r\n│ │     │ └─┬ glob@7.1.2\r\n│ │     │   └── minimatch@3.0.4  deduped\r\n│ │     └─┬ rimraf@2.6.2\r\n│ │       └─┬ glob@7.1.2\r\n│ │         └── minimatch@3.0.4  deduped\r\n│ ├─┬ glob@7.1.2\r\n│ │ └── minimatch@3.0.4  deduped\r\n│ └── minimatch@3.0.4  deduped\r\n├── minimatch@3.0.4\r\n├─┬ webtask-bundle@3.2.2\r\n│ ├─┬ glob@6.0.4\r\n│ │ └── minimatch@3.0.4  deduped\r\n│ └─┬ webpack@4.15.1\r\n│   └─┬ uglifyjs-webpack-plugin@1.2.7\r\n│     └─┬ cacache@10.0.4\r\n│       └─┬ glob@7.1.2\r\n│         └── minimatch@3.0.4  deduped\r\n└─┬ webtask-runtime@1.7.0\r\n  └─┬ babel@5.8.38\r\n    ├─┬ babel-core@5.8.38\r\n    │ ├── minimatch@2.0.10   <--- Notice the deprecated version here\r\n    │ └─┬ regenerator@0.8.40\r\n    │   └─┬ commoner@0.10.8\r\n    │     └─┬ glob@5.0.15\r\n    │       └── minimatch@3.0.4  deduped\r\n    ├─┬ chokidar@1.7.0\r\n    │ ├─┬ fsevents@1.2.4\r\n    │ │ └─┬ node-pre-gyp@0.10.0\r\n    │ │   ├─┬ npm-packlist@1.1.10\r\n    │ │   │ └─┬ ignore-walk@3.0.1\r\n    │ │   │   └── minimatch@3.0.4\r\n    │ │   └─┬ rimraf@2.6.2\r\n    │ │     └─┬ glob@7.1.2\r\n    │ │       └── minimatch@3.0.4  deduped\r\n    │ └─┬ readdirp@2.1.0\r\n    │   └── minimatch@3.0.4  deduped\r\n    └─┬ glob@5.0.15\r\n      └── minimatch@3.0.4  deduped\r\n```\r\nNotice that `minimatch@2.0.10` is being required by `webtask-runtime` because of `babel`.\r\n\r\n`babel` is only being used in the compiler to transform webtask code.\r\n\r\nhttps://github.com/auth0/webtask-runtime/blob/f524e9f48b38a0022ba3b010005b2e1b697288a5/lib/compiler.js#L54-L65\r\n\r\nThe `babel` project is [deprecated](https://www.npmjs.com/package/babel). In order to update `minimatch`, `babel` needs to be replaced with `babel-core`. In order to support the `loose` property, `babel-preset-env` has been added and the `transform` call has been modified slightly.\r\n\r\nTest suite is still passing ✅\r\n\r\nHere are the inputs that have been tested between the two implementations:\r\n```\r\n\"\"\r\nnull\r\nfalse\r\ntrue\r\n\"var test = () => {console.log('Hello World');}\"\r\n\"({foo}) => foo\"\r\n\"(foo=1) => foo\"\r\n\"`${test}23`\"\r\n\"[a,b,...c] = [1,2,3,4,5];\"\r\n\"var test = {...foo, ...bar};\"\r\n\"var {a,b,c,...d} = {a:1, b:2, c:3, d:4};\"\r\n\"var a = 1; var obj = {a};\"\r\n\"class Rectangle {constructor(height, width) {this.height = height;this.width = width;}}\"\r\n\"var test = 'dynamic'; var obj = {[test]:'yo'};\"\r\n\"var f = (x, y, z) => { x + y + z; }; f(...[1,2,3]) == 6\"\r\n\"let x = 1; if (x) { let y = 2; }\"\r\n\"const x = 1;\"\r\n\"for (var value of {1:1}) {}\"\r\n```\r\n\r\nRunning `npm ls minimatch` now returns:\r\n```\r\nwebtask-runtime@1.7.1 /Users/sky/Desktop/Dev/Auth0/webtask-runtime\r\n├─┬ babel-core@6.26.3\r\n│ └── minimatch@3.0.4\r\n└─┬ eslint@4.19.1\r\n  ├─┬ glob@7.1.2\r\n  │ └── minimatch@3.0.4  deduped\r\n  └── minimatch@3.0.4  deduped\r\n```","created_at":"2018-07-12T18:36:19Z","updated_at":"2018-07-12T20:33:47Z","closed_at":"2018-07-12T20:33:46Z","merged_at":"2018-07-12T20:33:46Z","merge_commit_sha":"cdeb465c402594eb303edcc7e159b102cc65cab9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11/commits","review_comments_url":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11/comments","review_comment_url":"https://api.github.com/repos/auth0/webtask-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/11/comments","statuses_url":"https://api.github.com/repos/auth0/webtask-runtime/statuses/f047b808dc8de1d80864a43c6df7a3c430f4a8b1","head":{"label":"auth0:update-babel","ref":"update-babel","sha":"f047b808dc8de1d80864a43c6df7a3c430f4a8b1","user":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":57246099,"node_id":"MDEwOlJlcG9zaXRvcnk1NzI0NjA5OQ==","name":"webtask-runtime","full_name":"auth0/webtask-runtime","owner":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/webtask-runtime","description":"Runtime components of the webtask.io sandbox","fork":false,"url":"https://api.github.com/repos/auth0/webtask-runtime","forks_url":"https://api.github.com/repos/auth0/webtask-runtime/forks","keys_url":"https://api.github.com/repos/auth0/webtask-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/webtask-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/webtask-runtime/teams","hooks_url":"https://api.github.com/repos/auth0/webtask-runtime/hooks","issue_events_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/webtask-runtime/events","assignees_url":"https://api.github.com/repos/auth0/webtask-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/webtask-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/webtask-runtime/tags","blobs_url":"https://api.github.com/repos/auth0/webtask-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/webtask-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/webtask-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/webtask-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/webtask-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/webtask-runtime/languages","stargazers_url":"https://api.github.com/repos/auth0/webtask-runtime/stargazers","contributors_url":"https://api.github.com/repos/auth0/webtask-runtime/contributors","subscribers_url":"https://api.github.com/repos/auth0/webtask-runtime/subscribers","subscription_url":"https://api.github.com/repos/auth0/webtask-runtime/subscription","commits_url":"https://api.github.com/repos/auth0/webtask-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/webtask-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/webtask-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/webtask-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/webtask-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/webtask-runtime/merges","archive_url":"https://api.github.com/repos/auth0/webtask-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/webtask-runtime/downloads","issues_url":"https://api.github.com/repos/auth0/webtask-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/webtask-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/webtask-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/webtask-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/webtask-runtime/labels{/name}","releases_url":"https://api.github.com/repos/auth0/webtask-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/webtask-runtime/deployments","created_at":"2016-04-27T20:41:34Z","updated_at":"2018-06-10T10:33:53Z","pushed_at":"2018-07-12T20:33:46Z","git_url":"git://github.com/auth0/webtask-runtime.git","ssh_url":"git@github.com:auth0/webtask-runtime.git","clone_url":"https://github.com/auth0/webtask-runtime.git","svn_url":"https://github.com/auth0/webtask-runtime","homepage":null,"size":126,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":9,"open_issues":3,"watchers":19,"default_branch":"master"}},"base":{"label":"auth0:master","ref":"master","sha":"43091192b3a3079cf0a59f266e4c7de7c03a5705","user":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"repo":{"id":57246099,"node_id":"MDEwOlJlcG9zaXRvcnk1NzI0NjA5OQ==","name":"webtask-runtime","full_name":"auth0/webtask-runtime","owner":{"login":"auth0","id":2824157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2824157?v=4","gravatar_id":"","url":"https://api.github.com/users/auth0","html_url":"https://github.com/auth0","followers_url":"https://api.github.com/users/auth0/followers","following_url":"https://api.github.com/users/auth0/following{/other_user}","gists_url":"https://api.github.com/users/auth0/gists{/gist_id}","starred_url":"https://api.github.com/users/auth0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auth0/subscriptions","organizations_url":"https://api.github.com/users/auth0/orgs","repos_url":"https://api.github.com/users/auth0/repos","events_url":"https://api.github.com/users/auth0/events{/privacy}","received_events_url":"https://api.github.com/users/auth0/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auth0/webtask-runtime","description":"Runtime components of the webtask.io sandbox","fork":false,"url":"https://api.github.com/repos/auth0/webtask-runtime","forks_url":"https://api.github.com/repos/auth0/webtask-runtime/forks","keys_url":"https://api.github.com/repos/auth0/webtask-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auth0/webtask-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auth0/webtask-runtime/teams","hooks_url":"https://api.github.com/repos/auth0/webtask-runtime/hooks","issue_events_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/auth0/webtask-runtime/events","assignees_url":"https://api.github.com/repos/auth0/webtask-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/auth0/webtask-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/auth0/webtask-runtime/tags","blobs_url":"https://api.github.com/repos/auth0/webtask-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auth0/webtask-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auth0/webtask-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/auth0/webtask-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auth0/webtask-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/auth0/webtask-runtime/languages","stargazers_url":"https://api.github.com/repos/auth0/webtask-runtime/stargazers","contributors_url":"https://api.github.com/repos/auth0/webtask-runtime/contributors","subscribers_url":"https://api.github.com/repos/auth0/webtask-runtime/subscribers","subscription_url":"https://api.github.com/repos/auth0/webtask-runtime/subscription","commits_url":"https://api.github.com/repos/auth0/webtask-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/auth0/webtask-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/auth0/webtask-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/auth0/webtask-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/auth0/webtask-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/auth0/webtask-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auth0/webtask-runtime/merges","archive_url":"https://api.github.com/repos/auth0/webtask-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auth0/webtask-runtime/downloads","issues_url":"https://api.github.com/repos/auth0/webtask-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/auth0/webtask-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/auth0/webtask-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/auth0/webtask-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auth0/webtask-runtime/labels{/name}","releases_url":"https://api.github.com/repos/auth0/webtask-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/auth0/webtask-runtime/deployments","created_at":"2016-04-27T20:41:34Z","updated_at":"2018-06-10T10:33:53Z","pushed_at":"2018-07-12T20:33:46Z","git_url":"git://github.com/auth0/webtask-runtime.git","ssh_url":"git@github.com:auth0/webtask-runtime.git","clone_url":"https://github.com/auth0/webtask-runtime.git","svn_url":"https://github.com/auth0/webtask-runtime","homepage":null,"size":126,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":9,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11"},"html":{"href":"https://github.com/auth0/webtask-runtime/pull/11"},"issue":{"href":"https://api.github.com/repos/auth0/webtask-runtime/issues/11"},"comments":{"href":"https://api.github.com/repos/auth0/webtask-runtime/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/auth0/webtask-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auth0/webtask-runtime/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/auth0/webtask-runtime/statuses/f047b808dc8de1d80864a43c6df7a3c430f4a8b1"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ggoodman","id":50030,"node_id":"MDQ6VXNlcjUwMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/50030?v=4","gravatar_id":"","url":"https://api.github.com/users/ggoodman","html_url":"https://github.com/ggoodman","followers_url":"https://api.github.com/users/ggoodman/followers","following_url":"https://api.github.com/users/ggoodman/following{/other_user}","gists_url":"https://api.github.com/users/ggoodman/gists{/gist_id}","starred_url":"https://api.github.com/users/ggoodman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggoodman/subscriptions","organizations_url":"https://api.github.com/users/ggoodman/orgs","repos_url":"https://api.github.com/users/ggoodman/repos","events_url":"https://api.github.com/users/ggoodman/events{/privacy}","received_events_url":"https://api.github.com/users/ggoodman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2627,"deletions":5313,"changed_files":3}}
{"actor":{"display_login":"ggoodman"}}