{"action":"created","issue":{"url":"https://api.github.com/repos/perrymant/moneymaker/issues/25","repository_url":"https://api.github.com/repos/perrymant/moneymaker","labels_url":"https://api.github.com/repos/perrymant/moneymaker/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/perrymant/moneymaker/issues/25/comments","events_url":"https://api.github.com/repos/perrymant/moneymaker/issues/25/events","html_url":"https://github.com/perrymant/moneymaker/pull/25","id":381951892,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzgyODcz","number":25,"title":"rest api design document created","user":{"login":"perrymant","id":7896623,"node_id":"MDQ6VXNlcjc4OTY2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/7896623?v=4","gravatar_id":"","url":"https://api.github.com/users/perrymant","html_url":"https://github.com/perrymant","followers_url":"https://api.github.com/users/perrymant/followers","following_url":"https://api.github.com/users/perrymant/following{/other_user}","gists_url":"https://api.github.com/users/perrymant/gists{/gist_id}","starred_url":"https://api.github.com/users/perrymant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrymant/subscriptions","organizations_url":"https://api.github.com/users/perrymant/orgs","repos_url":"https://api.github.com/users/perrymant/repos","events_url":"https://api.github.com/users/perrymant/events{/privacy}","received_events_url":"https://api.github.com/users/perrymant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-18T11:35:57Z","updated_at":"2018-11-27T21:52:21Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/perrymant/moneymaker/pulls/25","html_url":"https://github.com/perrymant/moneymaker/pull/25","diff_url":"https://github.com/perrymant/moneymaker/pull/25.diff","patch_url":"https://github.com/perrymant/moneymaker/pull/25.patch"},"body":"1. `Layout`: I had a hard time making \"readable/aesthetically pleasing\" markdown output, because of conflicts with how the JSON is laid out. It's almost better reading the raw markdown as the document. I wonder if you know how I could better lay this out.\r\n\r\n2. `Content`: Besides layout, I hope I have included the correct information for the API design. Can you point me to anything I'm missing. The sprint task is below for convenience.\r\n\r\n3. `Learning Notes`: I've also made some learning notes on API design (This resides in my Learning Notes repo at: https://github.com/perrymant/learning-notes/blob/master/17-rest-api-design.md.) Should I have branched this new document and PR'ed it rather than just add it to master?\r\n\r\nSprint task: \"API design. Identify the functionalities of my current CLI and map these to HTTP REST endpoints. What should the URL look like, the HTTP methods, what is the structure of the JSON for both requests and responses. Look at server codes, and put these in the design.\""},"comment":{"url":"https://api.github.com/repos/perrymant/moneymaker/issues/comments/442231112","html_url":"https://github.com/perrymant/moneymaker/pull/25#issuecomment-442231112","issue_url":"https://api.github.com/repos/perrymant/moneymaker/issues/25","id":442231112,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjIzMTExMg==","user":{"login":"perrymant","id":7896623,"node_id":"MDQ6VXNlcjc4OTY2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/7896623?v=4","gravatar_id":"","url":"https://api.github.com/users/perrymant","html_url":"https://github.com/perrymant","followers_url":"https://api.github.com/users/perrymant/followers","following_url":"https://api.github.com/users/perrymant/following{/other_user}","gists_url":"https://api.github.com/users/perrymant/gists{/gist_id}","starred_url":"https://api.github.com/users/perrymant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrymant/subscriptions","organizations_url":"https://api.github.com/users/perrymant/orgs","repos_url":"https://api.github.com/users/perrymant/repos","events_url":"https://api.github.com/users/perrymant/events{/privacy}","received_events_url":"https://api.github.com/users/perrymant/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T21:52:21Z","updated_at":"2018-11-27T21:52:21Z","author_association":"OWNER","body":"I *think* I've addressed the improvements you have identified in this PR."}}
{"actor":{"display_login":"perrymant"}}