{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/212642187","pull_request_review_id":149321073,"id":212642187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY0MjE4Nw==","diff_hunk":"@@ -349,22 +350,28 @@ func statStartGc(m *bpf.Map, family gcFamily) gcStats {\n \n func (s *gcStats) finish() {\n \ts.finished = time.Now()\n-\n+\tduration := s.finished.Sub(s.started)\n+\tvar family string = s.family.String()","path":"pkg/maps/ctmap/ctmap.go","position":14,"original_position":14,"commit_id":"25111a095fda48401506391067fc28e857afe8e6","original_commit_id":"25111a095fda48401506391067fc28e857afe8e6","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"should omit type string from declaration of var family; it will be inferred from the right-hand side","created_at":"2018-08-24T14:14:54Z","updated_at":"2018-08-24T14:14:55Z","html_url":"https://github.com/cilium/cilium/pull/5296#discussion_r212642187","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/5296","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/212642187"},"html":{"href":"https://github.com/cilium/cilium/pull/5296#discussion_r212642187"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5296"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5296","id":210055934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDU1OTM0","html_url":"https://github.com/cilium/cilium/pull/5296","diff_url":"https://github.com/cilium/cilium/pull/5296.diff","patch_url":"https://github.com/cilium/cilium/pull/5296.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5296","number":5296,"state":"open","locked":false,"title":"Conntrack garbage collector metrics","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"body":"Hi, \r\n\r\n Added the following metrics to the system:\r\n                                           \r\n cilium_datapath_conntrack_gc_duration     \r\n cilium_datapath_conntrack_gc_expired_total\r\n cilium_datapath_conntrack_gc_key_fallbacks\r\n cilium_datapath_conntrack_gc_runs_total   \r\n cilium_datapath_conntrack_gc_size         \r\n cilium_datapath_errors_total              \r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5296)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-08-22T08:28:52Z","updated_at":"2018-08-24T14:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b85c305f499831e58bbae42a4876b750752556b0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"bpf","id":2519779,"node_id":"MDQ6VGVhbTI1MTk3Nzk=","slug":"bpf","description":"BPF datapath","privacy":"closed","url":"https://api.github.com/teams/2519779","members_url":"https://api.github.com/teams/2519779/members{/member}","repositories_url":"https://api.github.com/teams/2519779/repos","permission":"pull"},{"name":"metrics","id":2834672,"node_id":"MDQ6VGVhbTI4MzQ2NzI=","slug":"metrics","description":"cilium-agent metrics","privacy":"closed","url":"https://api.github.com/teams/2834672","members_url":"https://api.github.com/teams/2834672/members{/member}","repositories_url":"https://api.github.com/teams/2834672/repos","permission":"pull"}],"labels":[{"id":877550534,"node_id":"MDU6TGFiZWw4Nzc1NTA1MzQ=","url":"https://api.github.com/repos/cilium/cilium/labels/area/metrics","name":"area/metrics","color":"8ea6db","default":false},{"id":732923415,"node_id":"MDU6TGFiZWw3MzI5MjM0MTU=","url":"https://api.github.com/repos/cilium/cilium/labels/release-note/minor","name":"release-note/minor","color":"c2e0c6","default":false},{"id":403244562,"node_id":"MDU6TGFiZWw0MDMyNDQ1NjI=","url":"https://api.github.com/repos/cilium/cilium/labels/wip","name":"wip","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/5296/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/5296/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5296/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/25111a095fda48401506391067fc28e857afe8e6","head":{"label":"eloycoto:GCMetrics","ref":"GCMetrics","sha":"25111a095fda48401506391067fc28e857afe8e6","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"repo":{"id":93093102,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA5MzEwMg==","name":"cilium","full_name":"eloycoto/cilium","owner":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eloycoto/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/eloycoto/cilium","forks_url":"https://api.github.com/repos/eloycoto/cilium/forks","keys_url":"https://api.github.com/repos/eloycoto/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eloycoto/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eloycoto/cilium/teams","hooks_url":"https://api.github.com/repos/eloycoto/cilium/hooks","issue_events_url":"https://api.github.com/repos/eloycoto/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/eloycoto/cilium/events","assignees_url":"https://api.github.com/repos/eloycoto/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/eloycoto/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/eloycoto/cilium/tags","blobs_url":"https://api.github.com/repos/eloycoto/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eloycoto/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eloycoto/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eloycoto/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eloycoto/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/eloycoto/cilium/languages","stargazers_url":"https://api.github.com/repos/eloycoto/cilium/stargazers","contributors_url":"https://api.github.com/repos/eloycoto/cilium/contributors","subscribers_url":"https://api.github.com/repos/eloycoto/cilium/subscribers","subscription_url":"https://api.github.com/repos/eloycoto/cilium/subscription","commits_url":"https://api.github.com/repos/eloycoto/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eloycoto/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eloycoto/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eloycoto/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eloycoto/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/eloycoto/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eloycoto/cilium/merges","archive_url":"https://api.github.com/repos/eloycoto/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eloycoto/cilium/downloads","issues_url":"https://api.github.com/repos/eloycoto/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/eloycoto/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/eloycoto/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/eloycoto/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eloycoto/cilium/labels{/name}","releases_url":"https://api.github.com/repos/eloycoto/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/eloycoto/cilium/deployments","created_at":"2017-06-01T19:40:10Z","updated_at":"2018-08-02T13:46:45Z","pushed_at":"2018-08-24T14:13:48Z","git_url":"git://github.com/eloycoto/cilium.git","ssh_url":"git@github.com:eloycoto/cilium.git","clone_url":"https://github.com/eloycoto/cilium.git","svn_url":"https://github.com/eloycoto/cilium","homepage":"","size":78895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"0c9728feab4f3354634e8db07512ac4b72a66137","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-08-24T12:52:44Z","pushed_at":"2018-08-24T14:13:54Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":58308,"stargazers_count":2729,"watchers_count":2729,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":243,"open_issues":514,"watchers":2729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5296"},"html":{"href":"https://github.com/cilium/cilium/pull/5296"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/5296"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/5296/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5296/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5296/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/25111a095fda48401506391067fc28e857afe8e6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}