{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/231922560","pull_request_review_id":173000298,"id":231922560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTkyMjU2MA==","diff_hunk":"@@ -61,7 +61,7 @@ test('Pass props correctly to Url component', () => {\n     expect(url.find(UrlComponent).prop('value')).toEqual('http://www.sulu.io');\n });\n \n-test('Pass correct default props to Url component', () => {\n+test('Not call changed when only protocol is given', () => {\n     const schemaOptions = {};","path":"src/Sulu/Bundle/AdminBundle/Resources/js/containers/Form/tests/fields/Url.test.js","position":null,"original_position":6,"commit_id":"8a9a05404825906ec6dcc8dcc27336570f762be8","original_commit_id":"1d88e464271e07090263b588ebd63e4486653485","user":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-11-08T15:00:54Z","updated_at":"2018-11-08T15:00:54Z","html_url":"https://github.com/sulu/sulu/pull/4257#discussion_r231922560","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/4257","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/231922560"},"html":{"href":"https://github.com/sulu/sulu/pull/4257#discussion_r231922560"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/4257"}},"in_reply_to_id":231906425},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/4257","id":229312428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzEyNDI4","html_url":"https://github.com/sulu/sulu/pull/4257","diff_url":"https://github.com/sulu/sulu/pull/4257.diff","patch_url":"https://github.com/sulu/sulu/pull/4257.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/4257","number":4257,"state":"open","locked":false,"title":"Fixed url field type initial value","user":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| License | MIT\r\n\r\n#### What's in this PR?\r\n\r\nFixed url field type initial value.\r\n\r\n#### Why?\r\n\r\nIt should not submit a url with just a protocol. \r\n\r\n#### Example Usage\r\n\r\n1. Create a template with url field type e.g.:\r\n\r\n~~~xml\r\n<property name=\"website\" type=\"url\" colspan=\"4\">\r\n    <meta>\r\n        <title>app.website</title>\r\n    </meta>\r\n</property>\r\n~~~\r\n\r\n2. try to save the template \r\n\r\n**before**\r\n\r\nValue was: `https://`\r\n\r\n**after**\r\n\r\nValue is *empty*\r\n\r\n","created_at":"2018-11-08T10:15:57Z","updated_at":"2018-11-08T15:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f0efa70b4d1590a63d7c95da4aaa05801d0b4f0","assignee":{"login":"danrot","id":405874,"node_id":"MDQ6VXNlcjQwNTg3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/405874?v=4","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"assignees":[{"login":"danrot","id":405874,"node_id":"MDQ6VXNlcjQwNTg3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/405874?v=4","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":61522940,"node_id":"MDU6TGFiZWw2MTUyMjk0MA==","url":"https://api.github.com/repos/sulu/sulu/labels/Bug","name":"Bug","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/sulu/sulu/milestones/15","html_url":"https://github.com/sulu/sulu/milestone/15","labels_url":"https://api.github.com/repos/sulu/sulu/milestones/15/labels","id":1227184,"node_id":"MDk6TWlsZXN0b25lMTIyNzE4NA==","number":15,"title":"Release 2.0","description":null,"creator":{"login":"chirimoya","id":627313,"node_id":"MDQ6VXNlcjYyNzMxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/627313?v=4","gravatar_id":"","url":"https://api.github.com/users/chirimoya","html_url":"https://github.com/chirimoya","followers_url":"https://api.github.com/users/chirimoya/followers","following_url":"https://api.github.com/users/chirimoya/following{/other_user}","gists_url":"https://api.github.com/users/chirimoya/gists{/gist_id}","starred_url":"https://api.github.com/users/chirimoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirimoya/subscriptions","organizations_url":"https://api.github.com/users/chirimoya/orgs","repos_url":"https://api.github.com/users/chirimoya/repos","events_url":"https://api.github.com/users/chirimoya/events{/privacy}","received_events_url":"https://api.github.com/users/chirimoya/received_events","type":"User","site_admin":false},"open_issues":114,"closed_issues":241,"state":"open","created_at":"2015-07-27T09:42:54Z","updated_at":"2018-11-08T13:18:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/4257/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/4257/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/4257/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/8a9a05404825906ec6dcc8dcc27336570f762be8","head":{"label":"alexander-schranz:bugfix/url-field-type-default-value","ref":"bugfix/url-field-type-default-value","sha":"8a9a05404825906ec6dcc8dcc27336570f762be8","user":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"repo":{"id":60774457,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc3NDQ1Nw==","name":"sulu","full_name":"alexander-schranz/sulu","private":false,"owner":{"login":"alexander-schranz","id":1698337,"node_id":"MDQ6VXNlcjE2OTgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1698337?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexander-schranz/sulu","description":"THIS IS A DEV FORK DONT USE IT FOR YOUR PROJECT: https://github.com/sulu/sulu","fork":true,"url":"https://api.github.com/repos/alexander-schranz/sulu","forks_url":"https://api.github.com/repos/alexander-schranz/sulu/forks","keys_url":"https://api.github.com/repos/alexander-schranz/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexander-schranz/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexander-schranz/sulu/teams","hooks_url":"https://api.github.com/repos/alexander-schranz/sulu/hooks","issue_events_url":"https://api.github.com/repos/alexander-schranz/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/alexander-schranz/sulu/events","assignees_url":"https://api.github.com/repos/alexander-schranz/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/alexander-schranz/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/alexander-schranz/sulu/tags","blobs_url":"https://api.github.com/repos/alexander-schranz/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexander-schranz/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexander-schranz/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexander-schranz/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexander-schranz/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/alexander-schranz/sulu/languages","stargazers_url":"https://api.github.com/repos/alexander-schranz/sulu/stargazers","contributors_url":"https://api.github.com/repos/alexander-schranz/sulu/contributors","subscribers_url":"https://api.github.com/repos/alexander-schranz/sulu/subscribers","subscription_url":"https://api.github.com/repos/alexander-schranz/sulu/subscription","commits_url":"https://api.github.com/repos/alexander-schranz/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexander-schranz/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexander-schranz/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexander-schranz/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexander-schranz/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/alexander-schranz/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexander-schranz/sulu/merges","archive_url":"https://api.github.com/repos/alexander-schranz/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexander-schranz/sulu/downloads","issues_url":"https://api.github.com/repos/alexander-schranz/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/alexander-schranz/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/alexander-schranz/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/alexander-schranz/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexander-schranz/sulu/labels{/name}","releases_url":"https://api.github.com/repos/alexander-schranz/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/alexander-schranz/sulu/deployments","created_at":"2016-06-09T12:51:29Z","updated_at":"2018-10-16T13:21:45Z","pushed_at":"2018-11-08T15:00:46Z","git_url":"git://github.com/alexander-schranz/sulu.git","ssh_url":"git@github.com:alexander-schranz/sulu.git","clone_url":"https://github.com/alexander-schranz/sulu.git","svn_url":"https://github.com/alexander-schranz/sulu","homepage":"https://sulu.io","size":96297,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"ed7aba45fbe15581c8d37d9d2b27e5c0d45b9322","user":{"login":"sulu","id":5717006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTcwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5717006?v=4","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3ODAxNQ==","name":"sulu","full_name":"sulu/sulu","private":false,"owner":{"login":"sulu","id":5717006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTcwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5717006?v=4","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2018-11-08T12:31:57Z","pushed_at":"2018-11-08T15:00:48Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"https://sulu.io","size":95782,"stargazers_count":279,"watchers_count":279,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":516,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":126,"open_issues":516,"watchers":279,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/4257"},"html":{"href":"https://github.com/sulu/sulu/pull/4257"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/4257"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/4257/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/4257/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/4257/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/8a9a05404825906ec6dcc8dcc27336570f762be8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexander-schranz"}}