{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/5683","repository_url":"https://api.github.com/repos/rust-lang/cargo","labels_url":"https://api.github.com/repos/rust-lang/cargo/issues/5683/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/5683/comments","events_url":"https://api.github.com/repos/rust-lang/cargo/issues/5683/events","html_url":"https://github.com/rust-lang/cargo/pull/5683","id":338369549,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzE5NDk0","number":5683,"title":"Display environment variables when showing the command being run","user":{"login":"mikeyhew","id":6751033,"node_id":"MDQ6VXNlcjY3NTEwMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/6751033?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeyhew","html_url":"https://github.com/mikeyhew","followers_url":"https://api.github.com/users/mikeyhew/followers","following_url":"https://api.github.com/users/mikeyhew/following{/other_user}","gists_url":"https://api.github.com/users/mikeyhew/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeyhew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeyhew/subscriptions","organizations_url":"https://api.github.com/users/mikeyhew/orgs","repos_url":"https://api.github.com/users/mikeyhew/repos","events_url":"https://api.github.com/users/mikeyhew/events{/privacy}","received_events_url":"https://api.github.com/users/mikeyhew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-07-04T20:24:05Z","updated_at":"2018-08-08T04:42:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/5683","html_url":"https://github.com/rust-lang/cargo/pull/5683","diff_url":"https://github.com/rust-lang/cargo/pull/5683.diff","patch_url":"https://github.com/rust-lang/cargo/pull/5683.patch"},"body":"Even with #5666, when commands are shown in verbose output, there are still some cases where they can’t be run in the terminal. This is because the code is expecting certain environment variables that are provided by cargo. This PR updates the `Display` impl for `ProcessBuilder` to show the environment variables in front of the command (on unix), so that the command can be run. Example output:\r\n\r\n![screen shot 2018-07-04 at 4 14 34 pm](https://user-images.githubusercontent.com/6751033/42293092-70ee2cc4-7fa5-11e8-96e2-d8559f227c98.png)\r\n\r\nNote that for workspaces, you will still have to run the command from the workspace root.\r\n\r\nI deliberately didn’t update any of the tests yet, because I want to see if this is desired. I also want to see if this can be done on windows, so hopefully someone with experience with that platform can comment.\r\n"},"comment":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/comments/411283149","html_url":"https://github.com/rust-lang/cargo/pull/5683#issuecomment-411283149","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/5683","id":411283149,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTI4MzE0OQ==","user":{"login":"wycats","id":4,"node_id":"MDQ6VXNlcjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4?v=4","gravatar_id":"","url":"https://api.github.com/users/wycats","html_url":"https://github.com/wycats","followers_url":"https://api.github.com/users/wycats/followers","following_url":"https://api.github.com/users/wycats/following{/other_user}","gists_url":"https://api.github.com/users/wycats/gists{/gist_id}","starred_url":"https://api.github.com/users/wycats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wycats/subscriptions","organizations_url":"https://api.github.com/users/wycats/orgs","repos_url":"https://api.github.com/users/wycats/repos","events_url":"https://api.github.com/users/wycats/events{/privacy}","received_events_url":"https://api.github.com/users/wycats/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T04:42:24Z","updated_at":"2018-08-08T04:42:24Z","author_association":"CONTRIBUTOR","body":"I like gating it on -vv. I also think that if we think that the copy-pasting facility is useful on Linux and OSX, we should try to figure out how to make it work on Windows. I don't love that these micro-decisions often result in a noticeably worse user-experience on Windows in aggregate, and I don't think it would be too hard to figure out how to make this work properly."}}
{"actor":{"display_login":"wycats"}}