{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19524","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19524/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19524/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19524/events","html_url":"https://github.com/nodejs/node/pull/19524","id":307463055,"number":19524,"title":"buffer: do deprecation warning outside `node_modules`","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155267414,"url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7","default":false},{"id":491152610,"url":"https://api.github.com/repos/nodejs/node/labels/notable-change","name":"notable-change","color":"f9d0c4","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/26","html_url":"https://github.com/nodejs/node/milestone/26","labels_url":"https://api.github.com/repos/nodejs/node/milestones/26/labels","id":2551352,"number":26,"title":"10.0.0","description":"","creator":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":17,"state":"open","created_at":"2017-05-30T19:07:02Z","updated_at":"2018-03-22T00:20:16Z","due_on":"2018-04-30T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-03-22T00:20:15Z","updated_at":"2018-03-22T15:31:04Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19524","html_url":"https://github.com/nodejs/node/pull/19524","diff_url":"https://github.com/nodejs/node/pull/19524.diff","patch_url":"https://github.com/nodejs/node/pull/19524.patch"},"body":"In addition to `--pending-deprecation`, emit a deprecation warning\r\nfor usage of the `Buffer()` constructor for call sites that are outside\r\nof `node_modules`.\r\n\r\nThe goal of this is to better target developers, rather than\r\nburdening users with an omnipresent and quickly ignored warning.\r\n\r\nThis implements the result of a TSC meeting discussion\r\nfrom March 22, 2018.\r\n\r\nRefs: https://github.com/nodejs/node/issues/19079#issuecomment-375121443\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nfyi @nodejs/collaborators \r\n\r\n(Fwiw, I would still prefer to not do this and/or wait until after the Node 10 release.)"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/375349029","html_url":"https://github.com/nodejs/node/pull/19524#issuecomment-375349029","issue_url":"https://api.github.com/repos/nodejs/node/issues/19524","id":375349029,"user":{"login":"MylesBorins","id":498775,"avatar_url":"https://avatars1.githubusercontent.com/u/498775?v=4","gravatar_id":"","url":"https://api.github.com/users/MylesBorins","html_url":"https://github.com/MylesBorins","followers_url":"https://api.github.com/users/MylesBorins/followers","following_url":"https://api.github.com/users/MylesBorins/following{/other_user}","gists_url":"https://api.github.com/users/MylesBorins/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesBorins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesBorins/subscriptions","organizations_url":"https://api.github.com/users/MylesBorins/orgs","repos_url":"https://api.github.com/users/MylesBorins/repos","events_url":"https://api.github.com/users/MylesBorins/events{/privacy}","received_events_url":"https://api.github.com/users/MylesBorins/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T15:31:04Z","updated_at":"2018-03-22T15:31:04Z","author_association":"OWNER","body":"@mafintosh did you mean to 👍🏽?\r\n\r\nTo be more explicit, are you in support of this approach? I personally think it is a good idea, but just wanted to confirm that the above concern wasn't an issue"}}
{"actor":{"display_login":"MylesBorins"}}