{"action":"created","comment":{"url":"https://api.github.com/repos/box/ClusterRunner/pulls/comments/182287017","pull_request_review_id":113053048,"id":182287017,"diff_hunk":"@@ -28,6 +29,7 @@ def __init__(self, cluster_master):\n         default_params = {\n             'cluster_master': cluster_master,\n         }\n+        self._slave_registry = SlaveRegistry.singleton()","path":"app/web_framework/cluster_master_application.py","position":12,"original_position":12,"commit_id":"8d1d981ad6bdcfbc53818d2afb188bc86a7f3e95","original_commit_id":"d81beaa18c07dd28aae8574e8c23469af481d7e2","user":{"login":"shriganeshs","id":9456350,"avatar_url":"https://avatars2.githubusercontent.com/u/9456350?v=4","gravatar_id":"","url":"https://api.github.com/users/shriganeshs","html_url":"https://github.com/shriganeshs","followers_url":"https://api.github.com/users/shriganeshs/followers","following_url":"https://api.github.com/users/shriganeshs/following{/other_user}","gists_url":"https://api.github.com/users/shriganeshs/gists{/gist_id}","starred_url":"https://api.github.com/users/shriganeshs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shriganeshs/subscriptions","organizations_url":"https://api.github.com/users/shriganeshs/orgs","repos_url":"https://api.github.com/users/shriganeshs/repos","events_url":"https://api.github.com/users/shriganeshs/events{/privacy}","received_events_url":"https://api.github.com/users/shriganeshs/received_events","type":"User","site_admin":false},"body":"I was using it before. Now removed.","created_at":"2018-04-18T01:33:52Z","updated_at":"2018-04-18T01:33:52Z","html_url":"https://github.com/box/ClusterRunner/pull/427#discussion_r182287017","pull_request_url":"https://api.github.com/repos/box/ClusterRunner/pulls/427","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/comments/182287017"},"html":{"href":"https://github.com/box/ClusterRunner/pull/427#discussion_r182287017"},"pull_request":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/427"}},"in_reply_to_id":182270975},"pull_request":{"url":"https://api.github.com/repos/box/ClusterRunner/pulls/427","id":182254484,"html_url":"https://github.com/box/ClusterRunner/pull/427","diff_url":"https://github.com/box/ClusterRunner/pull/427.diff","patch_url":"https://github.com/box/ClusterRunner/pull/427.patch","issue_url":"https://api.github.com/repos/box/ClusterRunner/issues/427","number":427,"state":"open","locked":false,"title":"Remove slave from registry when shutdown-ed","user":{"login":"shriganeshs","id":9456350,"avatar_url":"https://avatars2.githubusercontent.com/u/9456350?v=4","gravatar_id":"","url":"https://api.github.com/users/shriganeshs","html_url":"https://github.com/shriganeshs","followers_url":"https://api.github.com/users/shriganeshs/followers","following_url":"https://api.github.com/users/shriganeshs/following{/other_user}","gists_url":"https://api.github.com/users/shriganeshs/gists{/gist_id}","starred_url":"https://api.github.com/users/shriganeshs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shriganeshs/subscriptions","organizations_url":"https://api.github.com/users/shriganeshs/orgs","repos_url":"https://api.github.com/users/shriganeshs/repos","events_url":"https://api.github.com/users/shriganeshs/events{/privacy}","received_events_url":"https://api.github.com/users/shriganeshs/received_events","type":"User","site_admin":false},"body":"Add remove functionality to the existing /shutdown endpoint.\r\nAdd slave registry to store connected slaves at master side.\r\nThis PR adds a `SlaveRegistry` singleton class to store and maintain all slaves by url (and id) dictionary. It provides methods `add_slave` and `remove_slave`. `Shutdown` will delete the slave from this dictionary. This will help with autoscaling as it adds ability to remove slaves during auto scale-in operation (i.e. shutdown/dead) by removing these slaves from the SlaveRegistry.","created_at":"2018-04-17T18:25:31Z","updated_at":"2018-04-18T01:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b08e0e34662088ef9f60cd20755b95347289a3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/box/ClusterRunner/pulls/427/commits","review_comments_url":"https://api.github.com/repos/box/ClusterRunner/pulls/427/comments","review_comment_url":"https://api.github.com/repos/box/ClusterRunner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/box/ClusterRunner/issues/427/comments","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/8d1d981ad6bdcfbc53818d2afb188bc86a7f3e95","head":{"label":"box:remove-slave","ref":"remove-slave","sha":"8d1d981ad6bdcfbc53818d2afb188bc86a7f3e95","user":{"login":"box","id":23900,"avatar_url":"https://avatars0.githubusercontent.com/u/23900?v=4","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"repo":{"id":25371175,"name":"ClusterRunner","full_name":"box/ClusterRunner","owner":{"login":"box","id":23900,"avatar_url":"https://avatars0.githubusercontent.com/u/23900?v=4","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/box/ClusterRunner","description":"ClusterRunner makes it easy to parallelize test suites across your infrastructure in the fastest and most efficient way possible.","fork":false,"url":"https://api.github.com/repos/box/ClusterRunner","forks_url":"https://api.github.com/repos/box/ClusterRunner/forks","keys_url":"https://api.github.com/repos/box/ClusterRunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/box/ClusterRunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/box/ClusterRunner/teams","hooks_url":"https://api.github.com/repos/box/ClusterRunner/hooks","issue_events_url":"https://api.github.com/repos/box/ClusterRunner/issues/events{/number}","events_url":"https://api.github.com/repos/box/ClusterRunner/events","assignees_url":"https://api.github.com/repos/box/ClusterRunner/assignees{/user}","branches_url":"https://api.github.com/repos/box/ClusterRunner/branches{/branch}","tags_url":"https://api.github.com/repos/box/ClusterRunner/tags","blobs_url":"https://api.github.com/repos/box/ClusterRunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/box/ClusterRunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/box/ClusterRunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/box/ClusterRunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/{sha}","languages_url":"https://api.github.com/repos/box/ClusterRunner/languages","stargazers_url":"https://api.github.com/repos/box/ClusterRunner/stargazers","contributors_url":"https://api.github.com/repos/box/ClusterRunner/contributors","subscribers_url":"https://api.github.com/repos/box/ClusterRunner/subscribers","subscription_url":"https://api.github.com/repos/box/ClusterRunner/subscription","commits_url":"https://api.github.com/repos/box/ClusterRunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/box/ClusterRunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/box/ClusterRunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/box/ClusterRunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/box/ClusterRunner/contents/{+path}","compare_url":"https://api.github.com/repos/box/ClusterRunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/box/ClusterRunner/merges","archive_url":"https://api.github.com/repos/box/ClusterRunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/box/ClusterRunner/downloads","issues_url":"https://api.github.com/repos/box/ClusterRunner/issues{/number}","pulls_url":"https://api.github.com/repos/box/ClusterRunner/pulls{/number}","milestones_url":"https://api.github.com/repos/box/ClusterRunner/milestones{/number}","notifications_url":"https://api.github.com/repos/box/ClusterRunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/box/ClusterRunner/labels{/name}","releases_url":"https://api.github.com/repos/box/ClusterRunner/releases{/id}","deployments_url":"https://api.github.com/repos/box/ClusterRunner/deployments","created_at":"2014-10-17T18:20:39Z","updated_at":"2018-04-17T18:28:34Z","pushed_at":"2018-04-18T00:38:34Z","git_url":"git://github.com/box/ClusterRunner.git","ssh_url":"git@github.com:box/ClusterRunner.git","clone_url":"https://github.com/box/ClusterRunner.git","svn_url":"https://github.com/box/ClusterRunner","homepage":"https://clusterrunner.com","size":6361,"stargazers_count":156,"watchers_count":156,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":37,"open_issues":68,"watchers":156,"default_branch":"master"}},"base":{"label":"box:master","ref":"master","sha":"4ff9b19dea68482b71e53e0e81b8d0f1d2c5b028","user":{"login":"box","id":23900,"avatar_url":"https://avatars0.githubusercontent.com/u/23900?v=4","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"repo":{"id":25371175,"name":"ClusterRunner","full_name":"box/ClusterRunner","owner":{"login":"box","id":23900,"avatar_url":"https://avatars0.githubusercontent.com/u/23900?v=4","gravatar_id":"","url":"https://api.github.com/users/box","html_url":"https://github.com/box","followers_url":"https://api.github.com/users/box/followers","following_url":"https://api.github.com/users/box/following{/other_user}","gists_url":"https://api.github.com/users/box/gists{/gist_id}","starred_url":"https://api.github.com/users/box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/box/subscriptions","organizations_url":"https://api.github.com/users/box/orgs","repos_url":"https://api.github.com/users/box/repos","events_url":"https://api.github.com/users/box/events{/privacy}","received_events_url":"https://api.github.com/users/box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/box/ClusterRunner","description":"ClusterRunner makes it easy to parallelize test suites across your infrastructure in the fastest and most efficient way possible.","fork":false,"url":"https://api.github.com/repos/box/ClusterRunner","forks_url":"https://api.github.com/repos/box/ClusterRunner/forks","keys_url":"https://api.github.com/repos/box/ClusterRunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/box/ClusterRunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/box/ClusterRunner/teams","hooks_url":"https://api.github.com/repos/box/ClusterRunner/hooks","issue_events_url":"https://api.github.com/repos/box/ClusterRunner/issues/events{/number}","events_url":"https://api.github.com/repos/box/ClusterRunner/events","assignees_url":"https://api.github.com/repos/box/ClusterRunner/assignees{/user}","branches_url":"https://api.github.com/repos/box/ClusterRunner/branches{/branch}","tags_url":"https://api.github.com/repos/box/ClusterRunner/tags","blobs_url":"https://api.github.com/repos/box/ClusterRunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/box/ClusterRunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/box/ClusterRunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/box/ClusterRunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/box/ClusterRunner/statuses/{sha}","languages_url":"https://api.github.com/repos/box/ClusterRunner/languages","stargazers_url":"https://api.github.com/repos/box/ClusterRunner/stargazers","contributors_url":"https://api.github.com/repos/box/ClusterRunner/contributors","subscribers_url":"https://api.github.com/repos/box/ClusterRunner/subscribers","subscription_url":"https://api.github.com/repos/box/ClusterRunner/subscription","commits_url":"https://api.github.com/repos/box/ClusterRunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/box/ClusterRunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/box/ClusterRunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/box/ClusterRunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/box/ClusterRunner/contents/{+path}","compare_url":"https://api.github.com/repos/box/ClusterRunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/box/ClusterRunner/merges","archive_url":"https://api.github.com/repos/box/ClusterRunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/box/ClusterRunner/downloads","issues_url":"https://api.github.com/repos/box/ClusterRunner/issues{/number}","pulls_url":"https://api.github.com/repos/box/ClusterRunner/pulls{/number}","milestones_url":"https://api.github.com/repos/box/ClusterRunner/milestones{/number}","notifications_url":"https://api.github.com/repos/box/ClusterRunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/box/ClusterRunner/labels{/name}","releases_url":"https://api.github.com/repos/box/ClusterRunner/releases{/id}","deployments_url":"https://api.github.com/repos/box/ClusterRunner/deployments","created_at":"2014-10-17T18:20:39Z","updated_at":"2018-04-17T18:28:34Z","pushed_at":"2018-04-18T00:38:34Z","git_url":"git://github.com/box/ClusterRunner.git","ssh_url":"git@github.com:box/ClusterRunner.git","clone_url":"https://github.com/box/ClusterRunner.git","svn_url":"https://github.com/box/ClusterRunner","homepage":"https://clusterrunner.com","size":6361,"stargazers_count":156,"watchers_count":156,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":37,"open_issues":68,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/427"},"html":{"href":"https://github.com/box/ClusterRunner/pull/427"},"issue":{"href":"https://api.github.com/repos/box/ClusterRunner/issues/427"},"comments":{"href":"https://api.github.com/repos/box/ClusterRunner/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/box/ClusterRunner/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/box/ClusterRunner/statuses/8d1d981ad6bdcfbc53818d2afb188bc86a7f3e95"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shriganeshs"}}