{"action":"created","issue":{"url":"https://api.github.com/repos/bisq-network/pricenode/issues/7","repository_url":"https://api.github.com/repos/bisq-network/pricenode","labels_url":"https://api.github.com/repos/bisq-network/pricenode/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/bisq-network/pricenode/issues/7/comments","events_url":"https://api.github.com/repos/bisq-network/pricenode/issues/7/events","html_url":"https://github.com/bisq-network/pricenode/pull/7","id":294324375,"number":7,"title":"Refactor pricenode","user":{"login":"cbeams","id":301810,"avatar_url":"https://avatars0.githubusercontent.com/u/301810?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeams","html_url":"https://github.com/cbeams","followers_url":"https://api.github.com/users/cbeams/followers","following_url":"https://api.github.com/users/cbeams/following{/other_user}","gists_url":"https://api.github.com/users/cbeams/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeams/subscriptions","organizations_url":"https://api.github.com/users/cbeams/orgs","repos_url":"https://api.github.com/users/cbeams/repos","events_url":"https://api.github.com/users/cbeams/events{/privacy}","received_events_url":"https://api.github.com/users/cbeams/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cbeams","id":301810,"avatar_url":"https://avatars0.githubusercontent.com/u/301810?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeams","html_url":"https://github.com/cbeams","followers_url":"https://api.github.com/users/cbeams/followers","following_url":"https://api.github.com/users/cbeams/following{/other_user}","gists_url":"https://api.github.com/users/cbeams/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeams/subscriptions","organizations_url":"https://api.github.com/users/cbeams/orgs","repos_url":"https://api.github.com/users/cbeams/repos","events_url":"https://api.github.com/users/cbeams/events{/privacy}","received_events_url":"https://api.github.com/users/cbeams/received_events","type":"User","site_admin":false},"assignees":[{"login":"cbeams","id":301810,"avatar_url":"https://avatars0.githubusercontent.com/u/301810?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeams","html_url":"https://github.com/cbeams","followers_url":"https://api.github.com/users/cbeams/followers","following_url":"https://api.github.com/users/cbeams/following{/other_user}","gists_url":"https://api.github.com/users/cbeams/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeams/subscriptions","organizations_url":"https://api.github.com/users/cbeams/orgs","repos_url":"https://api.github.com/users/cbeams/repos","events_url":"https://api.github.com/users/cbeams/events{/privacy}","received_events_url":"https://api.github.com/users/cbeams/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-02-05T09:28:58Z","updated_at":"2018-02-21T22:20:48Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/bisq-network/pricenode/pulls/7","html_url":"https://github.com/bisq-network/pricenode/pull/7","diff_url":"https://github.com/bisq-network/pricenode/pull/7.diff","patch_url":"https://github.com/bisq-network/pricenode/pull/7.patch"},"body":"This pull request contains a number of pure refactorings after the initial migration to the new repository in #2.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bisq-network/pricenode/issues/comments/367495832","html_url":"https://github.com/bisq-network/pricenode/pull/7#issuecomment-367495832","issue_url":"https://api.github.com/repos/bisq-network/pricenode/issues/7","id":367495832,"user":{"login":"ManfredKarrer","id":1449498,"avatar_url":"https://avatars0.githubusercontent.com/u/1449498?v=4","gravatar_id":"","url":"https://api.github.com/users/ManfredKarrer","html_url":"https://github.com/ManfredKarrer","followers_url":"https://api.github.com/users/ManfredKarrer/followers","following_url":"https://api.github.com/users/ManfredKarrer/following{/other_user}","gists_url":"https://api.github.com/users/ManfredKarrer/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredKarrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredKarrer/subscriptions","organizations_url":"https://api.github.com/users/ManfredKarrer/orgs","repos_url":"https://api.github.com/users/ManfredKarrer/repos","events_url":"https://api.github.com/users/ManfredKarrer/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredKarrer/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T22:20:48Z","updated_at":"2018-02-21T22:20:48Z","author_association":"OWNER","body":"Re removeOutdatedPrices:\r\nIn case a provider is not responding (happens from time to time) for longer then 30 min. we would get delivered outdated prices as it is. \r\nThe code in the app is handling the caching and the age of the price as well so out dated prices will get ignored there. So from that point of view it it probably ok as it is now.\r\nI perfer to have security related aspects in the app to reduce required trust into the price nodes.\r\n\r\n\r\nRe provider priotities:\r\nI assumed as well that the order annotation is the key for that ;-). \r\nBut I am worried that this is not very clear, specially for those who are not familiar with the Spring framework.\r\nI would prefer to have that important logic more explicit.\r\n\r\n\r\nRe TODO:\r\nAgree with most...\r\n- I find the pretty-printing json better if I check the data on Tor browser, not suere if bandwith costs are really so high?\r\n- Re dependency to CurrencyUtil: Do you have a good idea for that? The list changes with each release when we add altcoins.\r\n\r\n\r\nA general though about the price node is that it is in reality a data aggregation node. We might add maybe more data in future there like historucal trade data which are delivered by the seed node now.\r\nI don't see it as kind of micro service as TOR connections are expensive and slow so we try to collect all calls together to have the min. required requests from the Bisq app to the service.\r\nThere is headroom for optimizing the current state where we request fee and market price separately. \r\nThe only reason why we added those nodes was because of problems to API providers over Tor (Cloudflare) - initially the Bisq apps requested directly from BTCA, Polo etc... but only BTCA was working over TOR the other required clearnet connections.\r\nWith that background I think it is worth considering a renaming of the project to a more generic name and emphasising on the aggregation aspect.\r\n\r\nAnother future aspect is to use protobuffer for the data transfer to the Bisq app. Not 100% sure about that but once we would use more complex data structures it might become cumbesome to need to translate json data to the native Bisq data models.\r\nThough that would require dependency on the Bisq core app.\r\nWe can discuss that later once we have a concrete use case....\r\n\r\nFor the PR I leave it you you when you want to merge (adding the small changes first or after the PR). So from my side there is a uACK."}}
{"actor":{"display_login":"ManfredKarrer"}}