{"action":"created","comment":{"url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/comments/182652269","pull_request_review_id":113489168,"id":182652269,"diff_hunk":"@@ -71,6 +75,9 @@ sub get_ns_ips {\n     return \\@adresses;\n }\n \n+$json_schemas{get_data_from_parent_zone} = joi->object->strict->props(\n+    domain   => $Zonemaster::Backend::Validator::domain_name->required","path":"lib/Zonemaster/Backend/RPCAPI.pm","position":31,"original_position":31,"commit_id":"6892eb2880a59a0f91cbb9b2c433fdece43fc38c","original_commit_id":"e28acfba84d7486b2d3ce664c62ff7add99bc476","user":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"body":"Could you give me an explanation (or example :p) ? i don't understand.","created_at":"2018-04-19T07:15:34Z","updated_at":"2018-04-19T07:15:34Z","html_url":"https://github.com/dotse/zonemaster-backend/pull/399#discussion_r182652269","pull_request_url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/comments/182652269"},"html":{"href":"https://github.com/dotse/zonemaster-backend/pull/399#discussion_r182652269"},"pull_request":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399"}},"in_reply_to_id":182474918},"pull_request":{"url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399","id":180584667,"html_url":"https://github.com/dotse/zonemaster-backend/pull/399","diff_url":"https://github.com/dotse/zonemaster-backend/pull/399.diff","patch_url":"https://github.com/dotse/zonemaster-backend/pull/399.patch","issue_url":"https://api.github.com/repos/dotse/zonemaster-backend/issues/399","number":399,"state":"open","locked":false,"title":"Add input validation layer","user":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nA quick Proof Of Concept of an input validation layer using JSON::Validator (cpan install JSON::Validator).","created_at":"2018-04-10T12:25:32Z","updated_at":"2018-04-19T07:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1755a74ff28a458c3639d7378dfdc2d262230772","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mtoma","id":5492426,"avatar_url":"https://avatars1.githubusercontent.com/u/5492426?v=4","gravatar_id":"","url":"https://api.github.com/users/mtoma","html_url":"https://github.com/mtoma","followers_url":"https://api.github.com/users/mtoma/followers","following_url":"https://api.github.com/users/mtoma/following{/other_user}","gists_url":"https://api.github.com/users/mtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/mtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtoma/subscriptions","organizations_url":"https://api.github.com/users/mtoma/orgs","repos_url":"https://api.github.com/users/mtoma/repos","events_url":"https://api.github.com/users/mtoma/events{/privacy}","received_events_url":"https://api.github.com/users/mtoma/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399/commits","review_comments_url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399/comments","review_comment_url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotse/zonemaster-backend/issues/399/comments","statuses_url":"https://api.github.com/repos/dotse/zonemaster-backend/statuses/6892eb2880a59a0f91cbb9b2c433fdece43fc38c","head":{"label":"pamasse:fix-issue-380","ref":"fix-issue-380","sha":"6892eb2880a59a0f91cbb9b2c433fdece43fc38c","user":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"repo":{"id":122068692,"name":"zonemaster-backend","full_name":"pamasse/zonemaster-backend","owner":{"login":"pamasse","id":28790708,"avatar_url":"https://avatars3.githubusercontent.com/u/28790708?v=4","gravatar_id":"","url":"https://api.github.com/users/pamasse","html_url":"https://github.com/pamasse","followers_url":"https://api.github.com/users/pamasse/followers","following_url":"https://api.github.com/users/pamasse/following{/other_user}","gists_url":"https://api.github.com/users/pamasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pamasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamasse/subscriptions","organizations_url":"https://api.github.com/users/pamasse/orgs","repos_url":"https://api.github.com/users/pamasse/repos","events_url":"https://api.github.com/users/pamasse/events{/privacy}","received_events_url":"https://api.github.com/users/pamasse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pamasse/zonemaster-backend","description":"The Zonemaster Backend - part of the Zonemaster project","fork":true,"url":"https://api.github.com/repos/pamasse/zonemaster-backend","forks_url":"https://api.github.com/repos/pamasse/zonemaster-backend/forks","keys_url":"https://api.github.com/repos/pamasse/zonemaster-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pamasse/zonemaster-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pamasse/zonemaster-backend/teams","hooks_url":"https://api.github.com/repos/pamasse/zonemaster-backend/hooks","issue_events_url":"https://api.github.com/repos/pamasse/zonemaster-backend/issues/events{/number}","events_url":"https://api.github.com/repos/pamasse/zonemaster-backend/events","assignees_url":"https://api.github.com/repos/pamasse/zonemaster-backend/assignees{/user}","branches_url":"https://api.github.com/repos/pamasse/zonemaster-backend/branches{/branch}","tags_url":"https://api.github.com/repos/pamasse/zonemaster-backend/tags","blobs_url":"https://api.github.com/repos/pamasse/zonemaster-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pamasse/zonemaster-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pamasse/zonemaster-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/pamasse/zonemaster-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pamasse/zonemaster-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/pamasse/zonemaster-backend/languages","stargazers_url":"https://api.github.com/repos/pamasse/zonemaster-backend/stargazers","contributors_url":"https://api.github.com/repos/pamasse/zonemaster-backend/contributors","subscribers_url":"https://api.github.com/repos/pamasse/zonemaster-backend/subscribers","subscription_url":"https://api.github.com/repos/pamasse/zonemaster-backend/subscription","commits_url":"https://api.github.com/repos/pamasse/zonemaster-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/pamasse/zonemaster-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/pamasse/zonemaster-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/pamasse/zonemaster-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/pamasse/zonemaster-backend/contents/{+path}","compare_url":"https://api.github.com/repos/pamasse/zonemaster-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pamasse/zonemaster-backend/merges","archive_url":"https://api.github.com/repos/pamasse/zonemaster-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pamasse/zonemaster-backend/downloads","issues_url":"https://api.github.com/repos/pamasse/zonemaster-backend/issues{/number}","pulls_url":"https://api.github.com/repos/pamasse/zonemaster-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/pamasse/zonemaster-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/pamasse/zonemaster-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pamasse/zonemaster-backend/labels{/name}","releases_url":"https://api.github.com/repos/pamasse/zonemaster-backend/releases{/id}","deployments_url":"https://api.github.com/repos/pamasse/zonemaster-backend/deployments","created_at":"2018-02-19T13:47:48Z","updated_at":"2018-02-19T13:47:50Z","pushed_at":"2018-04-19T07:08:19Z","git_url":"git://github.com/pamasse/zonemaster-backend.git","ssh_url":"git@github.com:pamasse/zonemaster-backend.git","clone_url":"https://github.com/pamasse/zonemaster-backend.git","svn_url":"https://github.com/pamasse/zonemaster-backend","homepage":null,"size":784,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotse:develop","ref":"develop","sha":"a07d6916711723729fb6d6a908de44ffd7c7744a","user":{"login":"dotse","id":243884,"avatar_url":"https://avatars3.githubusercontent.com/u/243884?v=4","gravatar_id":"","url":"https://api.github.com/users/dotse","html_url":"https://github.com/dotse","followers_url":"https://api.github.com/users/dotse/followers","following_url":"https://api.github.com/users/dotse/following{/other_user}","gists_url":"https://api.github.com/users/dotse/gists{/gist_id}","starred_url":"https://api.github.com/users/dotse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotse/subscriptions","organizations_url":"https://api.github.com/users/dotse/orgs","repos_url":"https://api.github.com/users/dotse/repos","events_url":"https://api.github.com/users/dotse/events{/privacy}","received_events_url":"https://api.github.com/users/dotse/received_events","type":"Organization","site_admin":false},"repo":{"id":26903539,"name":"zonemaster-backend","full_name":"dotse/zonemaster-backend","owner":{"login":"dotse","id":243884,"avatar_url":"https://avatars3.githubusercontent.com/u/243884?v=4","gravatar_id":"","url":"https://api.github.com/users/dotse","html_url":"https://github.com/dotse","followers_url":"https://api.github.com/users/dotse/followers","following_url":"https://api.github.com/users/dotse/following{/other_user}","gists_url":"https://api.github.com/users/dotse/gists{/gist_id}","starred_url":"https://api.github.com/users/dotse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotse/subscriptions","organizations_url":"https://api.github.com/users/dotse/orgs","repos_url":"https://api.github.com/users/dotse/repos","events_url":"https://api.github.com/users/dotse/events{/privacy}","received_events_url":"https://api.github.com/users/dotse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotse/zonemaster-backend","description":"The Zonemaster Backend - part of the Zonemaster project","fork":false,"url":"https://api.github.com/repos/dotse/zonemaster-backend","forks_url":"https://api.github.com/repos/dotse/zonemaster-backend/forks","keys_url":"https://api.github.com/repos/dotse/zonemaster-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotse/zonemaster-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotse/zonemaster-backend/teams","hooks_url":"https://api.github.com/repos/dotse/zonemaster-backend/hooks","issue_events_url":"https://api.github.com/repos/dotse/zonemaster-backend/issues/events{/number}","events_url":"https://api.github.com/repos/dotse/zonemaster-backend/events","assignees_url":"https://api.github.com/repos/dotse/zonemaster-backend/assignees{/user}","branches_url":"https://api.github.com/repos/dotse/zonemaster-backend/branches{/branch}","tags_url":"https://api.github.com/repos/dotse/zonemaster-backend/tags","blobs_url":"https://api.github.com/repos/dotse/zonemaster-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotse/zonemaster-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotse/zonemaster-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotse/zonemaster-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotse/zonemaster-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/dotse/zonemaster-backend/languages","stargazers_url":"https://api.github.com/repos/dotse/zonemaster-backend/stargazers","contributors_url":"https://api.github.com/repos/dotse/zonemaster-backend/contributors","subscribers_url":"https://api.github.com/repos/dotse/zonemaster-backend/subscribers","subscription_url":"https://api.github.com/repos/dotse/zonemaster-backend/subscription","commits_url":"https://api.github.com/repos/dotse/zonemaster-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotse/zonemaster-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotse/zonemaster-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotse/zonemaster-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotse/zonemaster-backend/contents/{+path}","compare_url":"https://api.github.com/repos/dotse/zonemaster-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotse/zonemaster-backend/merges","archive_url":"https://api.github.com/repos/dotse/zonemaster-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotse/zonemaster-backend/downloads","issues_url":"https://api.github.com/repos/dotse/zonemaster-backend/issues{/number}","pulls_url":"https://api.github.com/repos/dotse/zonemaster-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/dotse/zonemaster-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/dotse/zonemaster-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotse/zonemaster-backend/labels{/name}","releases_url":"https://api.github.com/repos/dotse/zonemaster-backend/releases{/id}","deployments_url":"https://api.github.com/repos/dotse/zonemaster-backend/deployments","created_at":"2014-11-20T08:45:46Z","updated_at":"2018-03-12T15:02:39Z","pushed_at":"2018-04-19T07:08:20Z","git_url":"git://github.com/dotse/zonemaster-backend.git","ssh_url":"git@github.com:dotse/zonemaster-backend.git","clone_url":"https://github.com/dotse/zonemaster-backend.git","svn_url":"https://github.com/dotse/zonemaster-backend","homepage":null,"size":764,"stargazers_count":3,"watchers_count":3,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":62,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399"},"html":{"href":"https://github.com/dotse/zonemaster-backend/pull/399"},"issue":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/issues/399"},"comments":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/dotse/zonemaster-backend/statuses/6892eb2880a59a0f91cbb9b2c433fdece43fc38c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pamasse"}}