{"action":"created","comment":{"url":"https://api.github.com/repos/google/santa/pulls/comments/194543175","pull_request_review_id":127735959,"id":194543175,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU0MzE3NQ==","diff_hunk":"@@ -211,85 +213,27 @@ - (void)beginListening {\n   }\n   TPASS();\n \n-  // Fetch the SHA-256 of /bin/ed, as we'll be using that for the cache invalidation test.\n-  NSString *edSHA = [self sha256ForPath:@\"/bin/ed\"];\n-\n-  // Create the RE used for matching testexe's\n-  NSString *cwd = [[NSFileManager defaultManager] currentDirectoryPath];\n-  NSString *pattern = [cwd stringByAppendingPathComponent:@\"testexe\\\\.(\\\\d+)\"];\n-  NSRegularExpression *re = [NSRegularExpression regularExpressionWithPattern:pattern\n-                                                                      options:0\n-                                                                        error:NULL];\n-\n   /// Begin listening for events\n-  queueMemory = (IODataQueueMemory *)address;\n+  IODataQueueMemory *queueMemory = (IODataQueueMemory *)address;\n+  santa_message_t vdata;","path":"Tests/KernelTests/main.mm","position":null,"original_position":138,"commit_id":"0378cc5ce4d8c783fabe4a17201ca54f2ef66151","original_commit_id":"91493e83300934fdafa5022e967ad64e7e7f17cc","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-06-11T20:49:31Z","updated_at":"2018-06-11T20:49:31Z","html_url":"https://github.com/google/santa/pull/282#discussion_r194543175","pull_request_url":"https://api.github.com/repos/google/santa/pulls/282","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/comments/194543175"},"html":{"href":"https://github.com/google/santa/pull/282#discussion_r194543175"},"pull_request":{"href":"https://api.github.com/repos/google/santa/pulls/282"}},"in_reply_to_id":194480681},"pull_request":{"url":"https://api.github.com/repos/google/santa/pulls/282","id":194043597,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDQzNTk3","html_url":"https://github.com/google/santa/pull/282","diff_url":"https://github.com/google/santa/pull/282.diff","patch_url":"https://github.com/google/santa/pull/282.patch","issue_url":"https://api.github.com/repos/google/santa/issues/282","number":282,"state":"open","locked":false,"title":"KernelTests: Simplify kernel tests","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"This change does 2 major things:\r\n\r\n1) Makes the test runnable from within Xcode, unloading any running\r\nsantad and santa-driver, loading the just-built driver from the same folder and\r\nthen running each test.\r\n2) Makes each test responsible for declaring what should happen to\r\nincoming requests from the driver, instead of keeping all of that\r\ncode near the top of the file. This makes each test much clearer in what\r\nshould be happening.","created_at":"2018-06-11T17:00:10Z","updated_at":"2018-06-11T20:49:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"067470eecd88b5de36feca96062d92f8390ffcf6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":136341304,"node_id":"MDU6TGFiZWwxMzYzNDEzMDQ=","url":"https://api.github.com/repos/google/santa/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/google/santa/pulls/282/commits","review_comments_url":"https://api.github.com/repos/google/santa/pulls/282/comments","review_comment_url":"https://api.github.com/repos/google/santa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/santa/issues/282/comments","statuses_url":"https://api.github.com/repos/google/santa/statuses/0378cc5ce4d8c783fabe4a17201ca54f2ef66151","head":{"label":"russellhancox:kernel-handler-tests","ref":"kernel-handler-tests","sha":"0378cc5ce4d8c783fabe4a17201ca54f2ef66151","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"repo":{"id":39463898,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2Mzg5OA==","name":"santa","full_name":"russellhancox/santa","owner":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhancox/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":true,"url":"https://api.github.com/repos/russellhancox/santa","forks_url":"https://api.github.com/repos/russellhancox/santa/forks","keys_url":"https://api.github.com/repos/russellhancox/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhancox/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhancox/santa/teams","hooks_url":"https://api.github.com/repos/russellhancox/santa/hooks","issue_events_url":"https://api.github.com/repos/russellhancox/santa/issues/events{/number}","events_url":"https://api.github.com/repos/russellhancox/santa/events","assignees_url":"https://api.github.com/repos/russellhancox/santa/assignees{/user}","branches_url":"https://api.github.com/repos/russellhancox/santa/branches{/branch}","tags_url":"https://api.github.com/repos/russellhancox/santa/tags","blobs_url":"https://api.github.com/repos/russellhancox/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhancox/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhancox/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhancox/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhancox/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhancox/santa/languages","stargazers_url":"https://api.github.com/repos/russellhancox/santa/stargazers","contributors_url":"https://api.github.com/repos/russellhancox/santa/contributors","subscribers_url":"https://api.github.com/repos/russellhancox/santa/subscribers","subscription_url":"https://api.github.com/repos/russellhancox/santa/subscription","commits_url":"https://api.github.com/repos/russellhancox/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhancox/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhancox/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhancox/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhancox/santa/contents/{+path}","compare_url":"https://api.github.com/repos/russellhancox/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhancox/santa/merges","archive_url":"https://api.github.com/repos/russellhancox/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhancox/santa/downloads","issues_url":"https://api.github.com/repos/russellhancox/santa/issues{/number}","pulls_url":"https://api.github.com/repos/russellhancox/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhancox/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhancox/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhancox/santa/labels{/name}","releases_url":"https://api.github.com/repos/russellhancox/santa/releases{/id}","deployments_url":"https://api.github.com/repos/russellhancox/santa/deployments","created_at":"2015-07-21T18:53:19Z","updated_at":"2018-06-11T16:55:15Z","pushed_at":"2018-06-11T20:47:24Z","git_url":"git://github.com/russellhancox/santa.git","ssh_url":"git@github.com:russellhancox/santa.git","clone_url":"https://github.com/russellhancox/santa.git","svn_url":"https://github.com/russellhancox/santa","homepage":"","size":2121,"stargazers_count":3,"watchers_count":3,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e1b5438865a5b9a577d810fd590d7adf0eb6b3e5","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25009012,"node_id":"MDEwOlJlcG9zaXRvcnkyNTAwOTAxMg==","name":"santa","full_name":"google/santa","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":false,"url":"https://api.github.com/repos/google/santa","forks_url":"https://api.github.com/repos/google/santa/forks","keys_url":"https://api.github.com/repos/google/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/santa/teams","hooks_url":"https://api.github.com/repos/google/santa/hooks","issue_events_url":"https://api.github.com/repos/google/santa/issues/events{/number}","events_url":"https://api.github.com/repos/google/santa/events","assignees_url":"https://api.github.com/repos/google/santa/assignees{/user}","branches_url":"https://api.github.com/repos/google/santa/branches{/branch}","tags_url":"https://api.github.com/repos/google/santa/tags","blobs_url":"https://api.github.com/repos/google/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/google/santa/languages","stargazers_url":"https://api.github.com/repos/google/santa/stargazers","contributors_url":"https://api.github.com/repos/google/santa/contributors","subscribers_url":"https://api.github.com/repos/google/santa/subscribers","subscription_url":"https://api.github.com/repos/google/santa/subscription","commits_url":"https://api.github.com/repos/google/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/santa/contents/{+path}","compare_url":"https://api.github.com/repos/google/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/santa/merges","archive_url":"https://api.github.com/repos/google/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/santa/downloads","issues_url":"https://api.github.com/repos/google/santa/issues{/number}","pulls_url":"https://api.github.com/repos/google/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/google/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/google/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/santa/labels{/name}","releases_url":"https://api.github.com/repos/google/santa/releases{/id}","deployments_url":"https://api.github.com/repos/google/santa/deployments","created_at":"2014-10-09T21:18:31Z","updated_at":"2018-06-11T16:54:31Z","pushed_at":"2018-06-11T20:47:25Z","git_url":"git://github.com/google/santa.git","ssh_url":"git@github.com:google/santa.git","clone_url":"https://github.com/google/santa.git","svn_url":"https://github.com/google/santa","homepage":"","size":2142,"stargazers_count":2305,"watchers_count":2305,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":157,"open_issues":19,"watchers":2305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/282"},"html":{"href":"https://github.com/google/santa/pull/282"},"issue":{"href":"https://api.github.com/repos/google/santa/issues/282"},"comments":{"href":"https://api.github.com/repos/google/santa/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/google/santa/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/google/santa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/santa/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/google/santa/statuses/0378cc5ce4d8c783fabe4a17201ca54f2ef66151"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"russellhancox"}}