{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/comments/233222533","pull_request_review_id":174587743,"id":233222533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIyMjUzMw==","diff_hunk":"@@ -71,6 +90,11 @@ public SqlQuerySpec BuildSqlQuerySpec(SearchOptions searchOptions)\n                 return query;\n             }\n \n+            private static string GetCompartmentIndicesParamName(CompartmentType compartmentType)\n+            {\n+                return $\"{KnownResourceWrapperProperties.CompartmentIndices}.{s_compartmentTypeToParamName[compartmentType]}\";","path":"src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/QueryBuilder.cs","position":48,"original_position":48,"commit_id":"24337e39291fd061bde476c0a07d190370e109df","original_commit_id":"24337e39291fd061bde476c0a07d190370e109df","user":{"login":"jackliums","id":15789906,"node_id":"MDQ6VXNlcjE1Nzg5OTA2","avatar_url":"https://avatars0.githubusercontent.com/u/15789906?v=4","gravatar_id":"","url":"https://api.github.com/users/jackliums","html_url":"https://github.com/jackliums","followers_url":"https://api.github.com/users/jackliums/followers","following_url":"https://api.github.com/users/jackliums/following{/other_user}","gists_url":"https://api.github.com/users/jackliums/gists{/gist_id}","starred_url":"https://api.github.com/users/jackliums/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackliums/subscriptions","organizations_url":"https://api.github.com/users/jackliums/orgs","repos_url":"https://api.github.com/users/jackliums/repos","events_url":"https://api.github.com/users/jackliums/events{/privacy}","received_events_url":"https://api.github.com/users/jackliums/received_events","type":"User","site_admin":false},"body":"nit: can we add debug check or something to make sure all of the compartment type has a corresponding name entry? Better than failing with generic ArgumentException.","created_at":"2018-11-13T21:10:03Z","updated_at":"2018-11-13T21:10:03Z","html_url":"https://github.com/Microsoft/fhir-server/pull/198#discussion_r233222533","pull_request_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/comments/233222533"},"html":{"href":"https://github.com/Microsoft/fhir-server/pull/198#discussion_r233222533"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198","id":230617260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjE3MjYw","html_url":"https://github.com/Microsoft/fhir-server/pull/198","diff_url":"https://github.com/Microsoft/fhir-server/pull/198.diff","patch_url":"https://github.com/Microsoft/fhir-server/pull/198.patch","issue_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/198","number":198,"state":"open","locked":false,"title":"Enable Compartment Search","user":{"login":"garamamo","id":36745011,"node_id":"MDQ6VXNlcjM2NzQ1MDEx","avatar_url":"https://avatars3.githubusercontent.com/u/36745011?v=4","gravatar_id":"","url":"https://api.github.com/users/garamamo","html_url":"https://github.com/garamamo","followers_url":"https://api.github.com/users/garamamo/followers","following_url":"https://api.github.com/users/garamamo/following{/other_user}","gists_url":"https://api.github.com/users/garamamo/gists{/gist_id}","starred_url":"https://api.github.com/users/garamamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garamamo/subscriptions","organizations_url":"https://api.github.com/users/garamamo/orgs","repos_url":"https://api.github.com/users/garamamo/repos","events_url":"https://api.github.com/users/garamamo/events{/privacy}","received_events_url":"https://api.github.com/users/garamamo/received_events","type":"User","site_admin":false},"body":"After the work done for indexing documents with compartment ids in https://github.com/Microsoft/fhir-server/issues/149, this pr enables end to end compartment search.\r\n\r\nIt includes\r\na) Controller and Routing changes for searching on compartments as per spec (https://www.hl7.org/fhir/compartmentdefinition.html) as GET.\r\nb) Core changes to support compartment search including resource specific and wildcard searches.\r\nc) CosmosDB querybuilder changes to support compartment search as per spec.\r\nd) Unit and Integration Tests.\r\n","created_at":"2018-11-13T20:39:51Z","updated_at":"2018-11-13T21:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edcd4f431a85316ecdc1980fbfd310fd8d552d96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198/commits","review_comments_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198/comments","review_comment_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/198/comments","statuses_url":"https://api.github.com/repos/Microsoft/fhir-server/statuses/24337e39291fd061bde476c0a07d190370e109df","head":{"label":"Microsoft:personal/garamamo/compartmentquery","ref":"personal/garamamo/compartmentquery","sha":"24337e39291fd061bde476c0a07d190370e109df","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":145907688,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MDc2ODg=","name":"fhir-server","full_name":"Microsoft/fhir-server","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/fhir-server","description":"A service that implements the FHIR standard","fork":false,"url":"https://api.github.com/repos/Microsoft/fhir-server","forks_url":"https://api.github.com/repos/Microsoft/fhir-server/forks","keys_url":"https://api.github.com/repos/Microsoft/fhir-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/fhir-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/fhir-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/fhir-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/fhir-server/events","assignees_url":"https://api.github.com/repos/Microsoft/fhir-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/fhir-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/fhir-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/fhir-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/fhir-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/fhir-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/fhir-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/fhir-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/fhir-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/fhir-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/fhir-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/fhir-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/fhir-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/fhir-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/fhir-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/fhir-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/fhir-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/fhir-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/fhir-server/merges","archive_url":"https://api.github.com/repos/Microsoft/fhir-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/fhir-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/fhir-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/fhir-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/fhir-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/fhir-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/fhir-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/fhir-server/deployments","created_at":"2018-08-23T21:11:07Z","updated_at":"2018-11-13T19:51:15Z","pushed_at":"2018-11-13T20:39:52Z","git_url":"git://github.com/Microsoft/fhir-server.git","ssh_url":"git@github.com:Microsoft/fhir-server.git","clone_url":"https://github.com/Microsoft/fhir-server.git","svn_url":"https://github.com/Microsoft/fhir-server","homepage":null,"size":1410,"stargazers_count":29,"watchers_count":29,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":51,"watchers":29,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"88fbf57989058cb9d242e82e75b233c9ea4c30fc","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":145907688,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MDc2ODg=","name":"fhir-server","full_name":"Microsoft/fhir-server","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/fhir-server","description":"A service that implements the FHIR standard","fork":false,"url":"https://api.github.com/repos/Microsoft/fhir-server","forks_url":"https://api.github.com/repos/Microsoft/fhir-server/forks","keys_url":"https://api.github.com/repos/Microsoft/fhir-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/fhir-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/fhir-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/fhir-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/fhir-server/events","assignees_url":"https://api.github.com/repos/Microsoft/fhir-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/fhir-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/fhir-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/fhir-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/fhir-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/fhir-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/fhir-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/fhir-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/fhir-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/fhir-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/fhir-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/fhir-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/fhir-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/fhir-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/fhir-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/fhir-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/fhir-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/fhir-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/fhir-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/fhir-server/merges","archive_url":"https://api.github.com/repos/Microsoft/fhir-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/fhir-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/fhir-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/fhir-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/fhir-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/fhir-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/fhir-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/fhir-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/fhir-server/deployments","created_at":"2018-08-23T21:11:07Z","updated_at":"2018-11-13T19:51:15Z","pushed_at":"2018-11-13T20:39:52Z","git_url":"git://github.com/Microsoft/fhir-server.git","ssh_url":"git@github.com:Microsoft/fhir-server.git","clone_url":"https://github.com/Microsoft/fhir-server.git","svn_url":"https://github.com/Microsoft/fhir-server","homepage":null,"size":1410,"stargazers_count":29,"watchers_count":29,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":51,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198"},"html":{"href":"https://github.com/Microsoft/fhir-server/pull/198"},"issue":{"href":"https://api.github.com/repos/Microsoft/fhir-server/issues/198"},"comments":{"href":"https://api.github.com/repos/Microsoft/fhir-server/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/fhir-server/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/fhir-server/statuses/24337e39291fd061bde476c0a07d190370e109df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackliums"}}