{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/181922306","pull_request_review_id":112630158,"id":181922306,"diff_hunk":"@@ -0,0 +1,125 @@\n+# Copyright 2018 Google LLC\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+# Generate the version information from the CMake values.\n+configure_file(version_info.h.in version_info.h)\n+\n+# the client library\n+add_library(firestore_client\n+        field_path.h\n+\tfield_path.cc\n+\t)\n+target_link_libraries(firestore_client PUBLIC\n+        firestore_protos)","path":"firestore/client/CMakeLists.txt","position":24,"original_position":24,"commit_id":"b1d167d1564297d908fee01ef4401a8a74b5831c","original_commit_id":"b1d167d1564297d908fee01ef4401a8a74b5831c","user":{"login":"coryan","id":6241635,"avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"If you do not have a `filestore_protos` library defined we should remove this.","created_at":"2018-04-17T00:21:59Z","updated_at":"2018-04-17T00:28:10Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431#discussion_r181922306","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/181922306"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431#discussion_r181922306"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431","id":181570784,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/431","number":431,"state":"open","locked":false,"title":"Firestore Field Path","user":{"login":"chemelnucfin","id":3982092,"avatar_url":"https://avatars1.githubusercontent.com/u/3982092?v=4","gravatar_id":"","url":"https://api.github.com/users/chemelnucfin","html_url":"https://github.com/chemelnucfin","followers_url":"https://api.github.com/users/chemelnucfin/followers","following_url":"https://api.github.com/users/chemelnucfin/following{/other_user}","gists_url":"https://api.github.com/users/chemelnucfin/gists{/gist_id}","starred_url":"https://api.github.com/users/chemelnucfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemelnucfin/subscriptions","organizations_url":"https://api.github.com/users/chemelnucfin/orgs","repos_url":"https://api.github.com/users/chemelnucfin/repos","events_url":"https://api.github.com/users/chemelnucfin/events{/privacy}","received_events_url":"https://api.github.com/users/chemelnucfin/received_events","type":"User","site_admin":false},"body":"@coryan I wrote this class for google-cloud-python and I wanted to write some C++.  I don't recall a lot of the details with RVO and copy elision, but maybe it's a start somewhere.  No urgency, just a toy program.\r\n","created_at":"2018-04-13T19:01:01Z","updated_at":"2018-04-17T00:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d9c3b28b23a165a42d68b1fd2938d0e1fb8d91c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":760104389,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/431/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/b1d167d1564297d908fee01ef4401a8a74b5831c","head":{"label":"chemelnucfin:firestore_field_path","ref":"firestore_field_path","sha":"b1d167d1564297d908fee01ef4401a8a74b5831c","user":{"login":"chemelnucfin","id":3982092,"avatar_url":"https://avatars1.githubusercontent.com/u/3982092?v=4","gravatar_id":"","url":"https://api.github.com/users/chemelnucfin","html_url":"https://github.com/chemelnucfin","followers_url":"https://api.github.com/users/chemelnucfin/followers","following_url":"https://api.github.com/users/chemelnucfin/following{/other_user}","gists_url":"https://api.github.com/users/chemelnucfin/gists{/gist_id}","starred_url":"https://api.github.com/users/chemelnucfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemelnucfin/subscriptions","organizations_url":"https://api.github.com/users/chemelnucfin/orgs","repos_url":"https://api.github.com/users/chemelnucfin/repos","events_url":"https://api.github.com/users/chemelnucfin/events{/privacy}","received_events_url":"https://api.github.com/users/chemelnucfin/received_events","type":"User","site_admin":false},"repo":{"id":112121526,"name":"google-cloud-cpp","full_name":"chemelnucfin/google-cloud-cpp","owner":{"login":"chemelnucfin","id":3982092,"avatar_url":"https://avatars1.githubusercontent.com/u/3982092?v=4","gravatar_id":"","url":"https://api.github.com/users/chemelnucfin","html_url":"https://github.com/chemelnucfin","followers_url":"https://api.github.com/users/chemelnucfin/followers","following_url":"https://api.github.com/users/chemelnucfin/following{/other_user}","gists_url":"https://api.github.com/users/chemelnucfin/gists{/gist_id}","starred_url":"https://api.github.com/users/chemelnucfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemelnucfin/subscriptions","organizations_url":"https://api.github.com/users/chemelnucfin/orgs","repos_url":"https://api.github.com/users/chemelnucfin/repos","events_url":"https://api.github.com/users/chemelnucfin/events{/privacy}","received_events_url":"https://api.github.com/users/chemelnucfin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chemelnucfin/google-cloud-cpp","description":"Google Cloud Platform C++ client libraries","fork":true,"url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp","forks_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/chemelnucfin/google-cloud-cpp/deployments","created_at":"2017-11-26T22:23:39Z","updated_at":"2018-04-08T02:37:57Z","pushed_at":"2018-04-16T23:54:28Z","git_url":"git://github.com/chemelnucfin/google-cloud-cpp.git","ssh_url":"git@github.com:chemelnucfin/google-cloud-cpp.git","clone_url":"https://github.com/chemelnucfin/google-cloud-cpp.git","svn_url":"https://github.com/chemelnucfin/google-cloud-cpp","homepage":"https://cloud.google.com/","size":850,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"e6397ac48571202ee9a7adef298aad9c7c6facde","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":111860063,"name":"google-cloud-cpp","full_name":"GoogleCloudPlatform/google-cloud-cpp","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","description":"Google Cloud Client Library for C++","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/deployments","created_at":"2017-11-24T00:19:31Z","updated_at":"2018-04-16T20:36:44Z","pushed_at":"2018-04-16T23:54:29Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-cpp.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-cpp.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","homepage":"https://cloud.google.com/","size":85357,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":69,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/431"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/431"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/b1d167d1564297d908fee01ef4401a8a74b5831c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"coryan"}}