{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pip/issues/5571","repository_url":"https://api.github.com/repos/pypa/pip","labels_url":"https://api.github.com/repos/pypa/pip/issues/5571/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pip/issues/5571/comments","events_url":"https://api.github.com/repos/pypa/pip/issues/5571/events","html_url":"https://github.com/pypa/pip/pull/5571","id":338696578,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTY0NTc2","number":5571,"title":"Allow PEP508 url dependencies in install_requires","user":{"login":"bstrdsmkr","id":1282802,"node_id":"MDQ6VXNlcjEyODI4MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1282802?v=4","gravatar_id":"","url":"https://api.github.com/users/bstrdsmkr","html_url":"https://github.com/bstrdsmkr","followers_url":"https://api.github.com/users/bstrdsmkr/followers","following_url":"https://api.github.com/users/bstrdsmkr/following{/other_user}","gists_url":"https://api.github.com/users/bstrdsmkr/gists{/gist_id}","starred_url":"https://api.github.com/users/bstrdsmkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstrdsmkr/subscriptions","organizations_url":"https://api.github.com/users/bstrdsmkr/orgs","repos_url":"https://api.github.com/users/bstrdsmkr/repos","events_url":"https://api.github.com/users/bstrdsmkr/events{/privacy}","received_events_url":"https://api.github.com/users/bstrdsmkr/received_events","type":"User","site_admin":false},"labels":[{"id":929593901,"node_id":"MDU6TGFiZWw5Mjk1OTM5MDE=","url":"https://api.github.com/repos/pypa/pip/labels/PEP%20implementation","name":"PEP implementation","color":"d80a6a","default":false},{"id":82424,"node_id":"MDU6TGFiZWw4MjQyNA==","url":"https://api.github.com/repos/pypa/pip/labels/T:%20enhancement","name":"T: enhancement","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pypa/pip/milestones/29","html_url":"https://github.com/pypa/pip/milestone/29","labels_url":"https://api.github.com/repos/pypa/pip/milestones/29/labels","id":3443702,"node_id":"MDk6TWlsZXN0b25lMzQ0MzcwMg==","number":29,"title":"18.1","description":"","creator":{"login":"pradyunsg","id":3275593,"node_id":"MDQ6VXNlcjMyNzU1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3275593?v=4","gravatar_id":"","url":"https://api.github.com/users/pradyunsg","html_url":"https://github.com/pradyunsg","followers_url":"https://api.github.com/users/pradyunsg/followers","following_url":"https://api.github.com/users/pradyunsg/following{/other_user}","gists_url":"https://api.github.com/users/pradyunsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pradyunsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradyunsg/subscriptions","organizations_url":"https://api.github.com/users/pradyunsg/orgs","repos_url":"https://api.github.com/users/pradyunsg/repos","events_url":"https://api.github.com/users/pradyunsg/events{/privacy}","received_events_url":"https://api.github.com/users/pradyunsg/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":1,"state":"open","created_at":"2018-06-22T02:34:11Z","updated_at":"2018-07-22T09:35:05Z","due_on":"2018-10-01T07:00:00Z","closed_at":null},"comments":16,"created_at":"2018-07-05T19:23:27Z","updated_at":"2018-07-22T15:00:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/5571","html_url":"https://github.com/pypa/pip/pull/5571","diff_url":"https://github.com/pypa/pip/pull/5571.diff","patch_url":"https://github.com/pypa/pip/pull/5571.patch"},"body":"This is intended to be the minimum obvious approach to allow users to make user of PEP508 urls as dependencies. Per the discussion in #4187, packages originating from PyPI (by virtue of being hosted at `files.pythonhosted.org`) are explicitly excluded from this feature in an effort to provide some security and avoid the (possibly) unexpected side effect of `pip install` grabbing packages from arbitrary 3rd party urls. Once PyPI is able to block such packages themselves, this patch will be obviated and should be removed.\r\n\r\nAdding a property to the PyPI Index instance feels dirty, especially since it is only ever used once, but I decided on adding it there instead of hard coding it in the conditional logic. My reasoning is that if/when PyPI changes their hosting url, it'll need to be updated and the point of instance creation seemed the most logical location for someone to look when that time comes around. \r\n\r\nFixes #4187 "},"comment":{"url":"https://api.github.com/repos/pypa/pip/issues/comments/406872920","html_url":"https://github.com/pypa/pip/pull/5571#issuecomment-406872920","issue_url":"https://api.github.com/repos/pypa/pip/issues/5571","id":406872920,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg3MjkyMA==","user":{"login":"dstufft","id":145979,"node_id":"MDQ6VXNlcjE0NTk3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/145979?v=4","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T15:00:58Z","updated_at":"2018-07-22T15:00:58Z","author_association":"MEMBER","body":"With pip 18, we've now switched to a regular release cadence, which you can find the full details at https://pip.pypa.io/en/stable/development/#release-cadence, but the tl;dr is the next release will be October, so if everything is ready and merged before October, it'll go out then."}}
{"actor":{"display_login":"dstufft"}}