{"action":"created","comment":{"url":"https://api.github.com/repos/runelite/runelite/pulls/comments/185649261","pull_request_review_id":117082211,"id":185649261,"diff_hunk":"@@ -24,8 +24,19 @@\n  */\n package net.runelite.api;\n \n+import java.awt.Rectangle;\n+\n public interface RenderOverview\n {\n+\tPoint getWorldMapPosition();\n+\n+\tRectangle getWorldMapDisplay();\n+\n+\tfloat getWorldMapZoom();\n+\n+\t//Takes a world point\n+\tvoid setWorldMapPositionTarget(int worldPointX, int worldPointY);","path":"runelite-api/src/main/java/net/runelite/api/RenderOverview.java","position":15,"original_position":15,"commit_id":"cd6acd60318ad9e3f9c96c564d0514904845609d","original_commit_id":"cd6acd60318ad9e3f9c96c564d0514904845609d","user":{"login":"Adam-","id":309739,"avatar_url":"https://avatars2.githubusercontent.com/u/309739?v=4","gravatar_id":"","url":"https://api.github.com/users/Adam-","html_url":"https://github.com/Adam-","followers_url":"https://api.github.com/users/Adam-/followers","following_url":"https://api.github.com/users/Adam-/following{/other_user}","gists_url":"https://api.github.com/users/Adam-/gists{/gist_id}","starred_url":"https://api.github.com/users/Adam-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adam-/subscriptions","organizations_url":"https://api.github.com/users/Adam-/orgs","repos_url":"https://api.github.com/users/Adam-/repos","events_url":"https://api.github.com/users/Adam-/events{/privacy}","received_events_url":"https://api.github.com/users/Adam-/received_events","type":"User","site_admin":false},"body":"Should this actually take a `WorldPoint`?","created_at":"2018-05-02T21:50:07Z","updated_at":"2018-05-02T21:53:52Z","html_url":"https://github.com/runelite/runelite/pull/2064#discussion_r185649261","pull_request_url":"https://api.github.com/repos/runelite/runelite/pulls/2064","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments/185649261"},"html":{"href":"https://github.com/runelite/runelite/pull/2064#discussion_r185649261"},"pull_request":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2064"}}},"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/2064","id":184745019,"html_url":"https://github.com/runelite/runelite/pull/2064","diff_url":"https://github.com/runelite/runelite/pull/2064.diff","patch_url":"https://github.com/runelite/runelite/pull/2064.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/2064","number":2064,"state":"open","locked":false,"title":"Add world map overlay to clue scroll plugin","user":{"login":"MESLewis","id":597053,"avatar_url":"https://avatars2.githubusercontent.com/u/597053?v=4","gravatar_id":"","url":"https://api.github.com/users/MESLewis","html_url":"https://github.com/MESLewis","followers_url":"https://api.github.com/users/MESLewis/followers","following_url":"https://api.github.com/users/MESLewis/following{/other_user}","gists_url":"https://api.github.com/users/MESLewis/gists{/gist_id}","starred_url":"https://api.github.com/users/MESLewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MESLewis/subscriptions","organizations_url":"https://api.github.com/users/MESLewis/orgs","repos_url":"https://api.github.com/users/MESLewis/repos","events_url":"https://api.github.com/users/MESLewis/events{/privacy}","received_events_url":"https://api.github.com/users/MESLewis/received_events","type":"User","site_admin":false},"body":"Add overlays that are drawn on the world map, correctly handling zoom, and the resizing of the world map.\r\n\r\nAlso adds a WorldMapService to aid with further additions to the world map and general world map usage by plugins.\r\n\r\nSetting the map location and adding an overlay dot there (Developer plugin: WorldMapOverlayTest):\r\n![smoothjump](https://user-images.githubusercontent.com/597053/39410500-811705d0-4bb6-11e8-8197-9b821ec2dcaa.gif)\r\n\r\nDrawing image on map, with snapping to map edges:\r\n![movesnap1](https://user-images.githubusercontent.com/597053/39492851-243c3e72-4d4e-11e8-8f81-6f624cb42205.gif)\r\n\r\n\r\nClickable overlays:\r\n![overlayclick](https://user-images.githubusercontent.com/597053/39492853-27e31e7e-4d4e-11e8-8fde-3f024f30a619.gif)\r\n\r\n\r\n\r\nWill fix #1446 \r\n\r\nTodo\r\n- [x] Fix coordinates detection\r\n- [ ] Change overlay wording to mention world map\r\n- [ ] Remove Plugin param from WorldMapPoint\r\n- [x] Make WorldMapPoint more flexible\r\n- [x] Change clue image when snapped to edge to be correctly visible on top edge\r\n- [X] Use Mixin to augment functionality\r\n- [X] Move from overlay to manager\r\n- [X] Clip rendering to map bounds\r\n- [X] Smooth map movement. Mimic how search does it.\r\n- [X] Add clue scroll overlay displaying an image at the clue location\r\n- [X] Overlay click to center map\r\n- [X] Optionally snap overlays to the edge of map (like the 'you are here' arrows)","created_at":"2018-04-27T22:59:35Z","updated_at":"2018-05-02T21:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4704a807315ada9c0752b5a49974a969dfc4c168","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":771846940,"url":"https://api.github.com/repos/runelite/runelite/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/2064/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/2064/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/2064/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/cd6acd60318ad9e3f9c96c564d0514904845609d","head":{"label":"MESLewis:world-map-overlay","ref":"world-map-overlay","sha":"cd6acd60318ad9e3f9c96c564d0514904845609d","user":{"login":"MESLewis","id":597053,"avatar_url":"https://avatars2.githubusercontent.com/u/597053?v=4","gravatar_id":"","url":"https://api.github.com/users/MESLewis","html_url":"https://github.com/MESLewis","followers_url":"https://api.github.com/users/MESLewis/followers","following_url":"https://api.github.com/users/MESLewis/following{/other_user}","gists_url":"https://api.github.com/users/MESLewis/gists{/gist_id}","starred_url":"https://api.github.com/users/MESLewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MESLewis/subscriptions","organizations_url":"https://api.github.com/users/MESLewis/orgs","repos_url":"https://api.github.com/users/MESLewis/repos","events_url":"https://api.github.com/users/MESLewis/events{/privacy}","received_events_url":"https://api.github.com/users/MESLewis/received_events","type":"User","site_admin":false},"repo":{"id":126539045,"name":"runelite","full_name":"MESLewis/runelite","owner":{"login":"MESLewis","id":597053,"avatar_url":"https://avatars2.githubusercontent.com/u/597053?v=4","gravatar_id":"","url":"https://api.github.com/users/MESLewis","html_url":"https://github.com/MESLewis","followers_url":"https://api.github.com/users/MESLewis/followers","following_url":"https://api.github.com/users/MESLewis/following{/other_user}","gists_url":"https://api.github.com/users/MESLewis/gists{/gist_id}","starred_url":"https://api.github.com/users/MESLewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MESLewis/subscriptions","organizations_url":"https://api.github.com/users/MESLewis/orgs","repos_url":"https://api.github.com/users/MESLewis/repos","events_url":"https://api.github.com/users/MESLewis/events{/privacy}","received_events_url":"https://api.github.com/users/MESLewis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MESLewis/runelite","description":"Open source Old School RuneScape client","fork":true,"url":"https://api.github.com/repos/MESLewis/runelite","forks_url":"https://api.github.com/repos/MESLewis/runelite/forks","keys_url":"https://api.github.com/repos/MESLewis/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MESLewis/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MESLewis/runelite/teams","hooks_url":"https://api.github.com/repos/MESLewis/runelite/hooks","issue_events_url":"https://api.github.com/repos/MESLewis/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/MESLewis/runelite/events","assignees_url":"https://api.github.com/repos/MESLewis/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/MESLewis/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/MESLewis/runelite/tags","blobs_url":"https://api.github.com/repos/MESLewis/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MESLewis/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MESLewis/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/MESLewis/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MESLewis/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/MESLewis/runelite/languages","stargazers_url":"https://api.github.com/repos/MESLewis/runelite/stargazers","contributors_url":"https://api.github.com/repos/MESLewis/runelite/contributors","subscribers_url":"https://api.github.com/repos/MESLewis/runelite/subscribers","subscription_url":"https://api.github.com/repos/MESLewis/runelite/subscription","commits_url":"https://api.github.com/repos/MESLewis/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/MESLewis/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/MESLewis/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/MESLewis/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/MESLewis/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/MESLewis/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MESLewis/runelite/merges","archive_url":"https://api.github.com/repos/MESLewis/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MESLewis/runelite/downloads","issues_url":"https://api.github.com/repos/MESLewis/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/MESLewis/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/MESLewis/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/MESLewis/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MESLewis/runelite/labels{/name}","releases_url":"https://api.github.com/repos/MESLewis/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/MESLewis/runelite/deployments","created_at":"2018-03-23T21:08:04Z","updated_at":"2018-03-28T03:25:23Z","pushed_at":"2018-05-02T20:21:57Z","git_url":"git://github.com/MESLewis/runelite.git","ssh_url":"git@github.com:MESLewis/runelite.git","clone_url":"https://github.com/MESLewis/runelite.git","svn_url":"https://github.com/MESLewis/runelite","homepage":"https://runelite.net","size":55212,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"c596e7bd5f6fc2aa4f49a75f6e372413b3a3f48b","user":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-05-02T21:28:26Z","pushed_at":"2018-05-02T20:11:29Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":38801,"stargazers_count":450,"watchers_count":450,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"archived":false,"open_issues_count":655,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":383,"open_issues":655,"watchers":450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2064"},"html":{"href":"https://github.com/runelite/runelite/pull/2064"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/2064"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/2064/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2064/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2064/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/cd6acd60318ad9e3f9c96c564d0514904845609d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Adam-"}}