{"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/188002960","pull_request_review_id":119893808,"id":188002960,"diff_hunk":"@@ -145,8 +161,9 @@ export default {\n \n \t\tlet noticeMessage;\n \t\tlet shouldShowLink = true;\n-\t\tif ( ! isPublished && ! willPublish ) {\n-\t\t\t// If saving a non published post, don't show any notice\n+\n+\t\tif ( isAutosave || ( ! isPublished && ! willPublish ) ) {","path":"editor/store/effects.js","position":108,"original_position":108,"commit_id":"c31eb055d276ea4fe44bbbd1764eecaaa3fad920","original_commit_id":"c31eb055d276ea4fe44bbbd1764eecaaa3fad920","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":"When will `isAutosave` be truthy ? (Now that we've removed `REQUEST_POST_UPDATE_SUCCESS` from the `isAutosave` flow above)","created_at":"2018-05-14T15:44:55Z","updated_at":"2018-05-14T15:52:56Z","html_url":"https://github.com/WordPress/gutenberg/pull/6257#discussion_r188002960","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/188002960"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/6257#discussion_r188002960"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257","id":182551596,"html_url":"https://github.com/WordPress/gutenberg/pull/6257","diff_url":"https://github.com/WordPress/gutenberg/pull/6257.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/6257.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6257","number":6257,"state":"open","locked":false,"title":"Improve Autosaves - take 2","user":{"login":"adamsilverstein","id":2676022,"avatar_url":"https://avatars0.githubusercontent.com/u/2676022?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsilverstein","html_url":"https://github.com/adamsilverstein","followers_url":"https://api.github.com/users/adamsilverstein/followers","following_url":"https://api.github.com/users/adamsilverstein/following{/other_user}","gists_url":"https://api.github.com/users/adamsilverstein/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsilverstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsilverstein/subscriptions","organizations_url":"https://api.github.com/users/adamsilverstein/orgs","repos_url":"https://api.github.com/users/adamsilverstein/repos","events_url":"https://api.github.com/users/adamsilverstein/events{/privacy}","received_events_url":"https://api.github.com/users/adamsilverstein/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nBased on previous work from https://github.com/WordPress/gutenberg/pull/4156.\r\n\r\nLeverages the final version of the Autosaves controller from @azaozz in Trac, https://core.trac.wordpress.org/ticket/43316#comment:76\r\n\r\nFixes https://github.com/WordPress/gutenberg/issues/4112.\r\n\r\nDoes not implement the autosave alert when an autosave exists and the deletion of stale autosaves on load, these are handled in https://github.com/WordPress/gutenberg/pull/4218\r\n\r\n## How Has This Been Tested?\r\nLocal testing, db monitoring. Verified behavior as expected, matches core.\r\n\r\n* Create a new post, don't type anything\r\n* Check the database, there will be a single auto-draft\r\n* type a title and some content, pause for 10 seconds\r\n* note the message 'Autosaving' ... 'Saved' ... 'Save draft'\r\n* check the database, not that there is a single row for the post, with a draft status\r\n* Click the 'save draft' button\r\n* note the message 'Saving' ... 'Saved'  - button stays in saved state\r\n* check the database, note a revision has been created because of the manual save action (not an autosave)\r\n* publish the post\r\n* check the database, note the post status is now published\r\n* make some more changes and wait 10 seconds\r\n* note the message 'Autosaving' ... then disappears (not save draft option) - @todo maybe should show saved briefly here?\r\n* check the database, note an autosave revision has been created\r\n* make some more changes and wait again for the autosave\r\n* check the database and note the autosave is updated, and that there is only one autosave\r\n* note that the 'update button' is available, click it\r\n* note that 'update' is disabled (until you change the post)\r\n* check the database, note that a new revision was created\r\n* repeat the last three steps\r\n* exit the post edit screen and log in as a different user, open the same post\r\n* edit the post and wait for an autosave\r\n* check the database, note that there are now two autosaves for the post, one for each user.\r\n\r\n## Types of changes\r\n* New WP_REST_Autosaves_Controller\r\n* New REQUEST_POST_AUTOSAVE effect, autosavePost action\r\n* Tracks `isPostAutosavable` separately from `isEditedPostSaveable`\r\n* Leverage `withChangeDetection` to track autosave state (this needs more testing) \r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style.\r\n- [x] My code follows has proper inline documentation.","created_at":"2018-04-18T17:35:35Z","updated_at":"2018-05-14T15:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ee957ab24197b26f059d084120b86e5ef1cfa12","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mkaz","id":45363,"avatar_url":"https://avatars2.githubusercontent.com/u/45363?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaz","html_url":"https://github.com/mkaz","followers_url":"https://api.github.com/users/mkaz/followers","following_url":"https://api.github.com/users/mkaz/following{/other_user}","gists_url":"https://api.github.com/users/mkaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaz/subscriptions","organizations_url":"https://api.github.com/users/mkaz/orgs","repos_url":"https://api.github.com/users/mkaz/repos","events_url":"https://api.github.com/users/mkaz/events{/privacy}","received_events_url":"https://api.github.com/users/mkaz/received_events","type":"User","site_admin":false},{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6257/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/c31eb055d276ea4fe44bbbd1764eecaaa3fad920","head":{"label":"WordPress:fix/autosaves","ref":"fix/autosaves","sha":"c31eb055d276ea4fe44bbbd1764eecaaa3fad920","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-05-14T15:26:34Z","pushed_at":"2018-05-14T15:19:44Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":13717,"stargazers_count":2452,"watchers_count":2452,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":859,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":610,"open_issues":859,"watchers":2452,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"c45d6bd5380f2e7a9a5d9ce82b3fcb845fb715b4","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-05-14T15:26:34Z","pushed_at":"2018-05-14T15:19:44Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":13717,"stargazers_count":2452,"watchers_count":2452,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":859,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":610,"open_issues":859,"watchers":2452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/6257"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/6257"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/6257/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/6257/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/c31eb055d276ea4fe44bbbd1764eecaaa3fad920"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aduth"}}