{"action":"opened","issue":{"url":"https://api.github.com/repos/okTurtles/group-income-simple/issues/463","repository_url":"https://api.github.com/repos/okTurtles/group-income-simple","labels_url":"https://api.github.com/repos/okTurtles/group-income-simple/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/okTurtles/group-income-simple/issues/463/comments","events_url":"https://api.github.com/repos/okTurtles/group-income-simple/issues/463/events","html_url":"https://github.com/okTurtles/group-income-simple/issues/463","id":348053501,"node_id":"MDU6SXNzdWUzNDgwNTM1MDE=","number":463,"title":"Improve giLodash.test.js tests","user":{"login":"taoeffect","id":138706,"node_id":"MDQ6VXNlcjEzODcwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/138706?v=4","gravatar_id":"","url":"https://api.github.com/users/taoeffect","html_url":"https://github.com/taoeffect","followers_url":"https://api.github.com/users/taoeffect/followers","following_url":"https://api.github.com/users/taoeffect/following{/other_user}","gists_url":"https://api.github.com/users/taoeffect/gists{/gist_id}","starred_url":"https://api.github.com/users/taoeffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoeffect/subscriptions","organizations_url":"https://api.github.com/users/taoeffect/orgs","repos_url":"https://api.github.com/users/taoeffect/repos","events_url":"https://api.github.com/users/taoeffect/events{/privacy}","received_events_url":"https://api.github.com/users/taoeffect/received_events","type":"User","site_admin":false},"labels":[{"id":347224009,"node_id":"MDU6TGFiZWwzNDcyMjQwMDk=","url":"https://api.github.com/repos/okTurtles/group-income-simple/labels/App:Frontend","name":"App:Frontend","color":"c7def8","default":false},{"id":347215225,"node_id":"MDU6TGFiZWwzNDcyMTUyMjU=","url":"https://api.github.com/repos/okTurtles/group-income-simple/labels/Kind:Bug","name":"Kind:Bug","color":"fc2929","default":false},{"id":347227161,"node_id":"MDU6TGFiZWwzNDcyMjcxNjE=","url":"https://api.github.com/repos/okTurtles/group-income-simple/labels/Kind:Test","name":"Kind:Test","color":"68C9B6","default":false},{"id":348004622,"node_id":"MDU6TGFiZWwzNDgwMDQ2MjI=","url":"https://api.github.com/repos/okTurtles/group-income-simple/labels/Priority:High","name":"Priority:High","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"vijayee","id":7297296,"node_id":"MDQ6VXNlcjcyOTcyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7297296?v=4","gravatar_id":"","url":"https://api.github.com/users/vijayee","html_url":"https://github.com/vijayee","followers_url":"https://api.github.com/users/vijayee/followers","following_url":"https://api.github.com/users/vijayee/following{/other_user}","gists_url":"https://api.github.com/users/vijayee/gists{/gist_id}","starred_url":"https://api.github.com/users/vijayee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijayee/subscriptions","organizations_url":"https://api.github.com/users/vijayee/orgs","repos_url":"https://api.github.com/users/vijayee/repos","events_url":"https://api.github.com/users/vijayee/events{/privacy}","received_events_url":"https://api.github.com/users/vijayee/received_events","type":"User","site_admin":false},"assignees":[{"login":"vijayee","id":7297296,"node_id":"MDQ6VXNlcjcyOTcyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7297296?v=4","gravatar_id":"","url":"https://api.github.com/users/vijayee","html_url":"https://github.com/vijayee","followers_url":"https://api.github.com/users/vijayee/followers","following_url":"https://api.github.com/users/vijayee/following{/other_user}","gists_url":"https://api.github.com/users/vijayee/gists{/gist_id}","starred_url":"https://api.github.com/users/vijayee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijayee/subscriptions","organizations_url":"https://api.github.com/users/vijayee/orgs","repos_url":"https://api.github.com/users/vijayee/repos","events_url":"https://api.github.com/users/vijayee/events{/privacy}","received_events_url":"https://api.github.com/users/vijayee/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-06T19:31:59Z","updated_at":"2018-08-06T19:31:59Z","closed_at":null,"author_association":"MEMBER","body":"### Problem\r\n\r\nTests for `debounce`, `merge`, `zip`, and `fromPairs` should be shortened where necessary and made more thorough.\r\n\r\nFor example:\r\n\r\n- `debounce` only tests if the function was delayed once correctly, it doesn't attempt to see if it was called twice correctly\r\n- `merge`, `zip`, and `fromPairs` test subparts of the output, and doing it this way results in incomplete and also more verbose tests\r\n\r\n### Solution\r\n\r\n- `debounce` should be more thoroughly tested, including more edge cases. For example, in addition to the current test that verifies it's called once after 500 msec, it needs to test that it will be called twice after 1000 msec, and that calls in between that interval do not result in a function call. `should-sinon` should be used for this\r\n- The other 3 functions should verify that the entire expected output is output by the function instead of checking subparts of the output. This will result in a complete test and it will also remove unnecessary LOC"}}
{"actor":{"display_login":"taoeffect"}}