{"action":"created","issue":{"url":"https://api.github.com/repos/facebookresearch/faiss/issues/545","repository_url":"https://api.github.com/repos/facebookresearch/faiss","labels_url":"https://api.github.com/repos/facebookresearch/faiss/issues/545/labels{/name}","comments_url":"https://api.github.com/repos/facebookresearch/faiss/issues/545/comments","events_url":"https://api.github.com/repos/facebookresearch/faiss/issues/545/events","html_url":"https://github.com/facebookresearch/faiss/issues/545","id":344346545,"node_id":"MDU6SXNzdWUzNDQzNDY1NDU=","number":545,"title":"Implementing merge_from for indexes with pre-transform","user":{"login":"AKSHAYUBHAT","id":35259,"node_id":"MDQ6VXNlcjM1MjU5","avatar_url":"https://avatars0.githubusercontent.com/u/35259?v=4","gravatar_id":"","url":"https://api.github.com/users/AKSHAYUBHAT","html_url":"https://github.com/AKSHAYUBHAT","followers_url":"https://api.github.com/users/AKSHAYUBHAT/followers","following_url":"https://api.github.com/users/AKSHAYUBHAT/following{/other_user}","gists_url":"https://api.github.com/users/AKSHAYUBHAT/gists{/gist_id}","starred_url":"https://api.github.com/users/AKSHAYUBHAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKSHAYUBHAT/subscriptions","organizations_url":"https://api.github.com/users/AKSHAYUBHAT/orgs","repos_url":"https://api.github.com/users/AKSHAYUBHAT/repos","events_url":"https://api.github.com/users/AKSHAYUBHAT/events{/privacy}","received_events_url":"https://api.github.com/users/AKSHAYUBHAT/received_events","type":"User","site_admin":false},"labels":[{"id":534246311,"node_id":"MDU6TGFiZWw1MzQyNDYzMTE=","url":"https://api.github.com/repos/facebookresearch/faiss/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"mdouze","id":25364969,"node_id":"MDQ6VXNlcjI1MzY0OTY5","avatar_url":"https://avatars1.githubusercontent.com/u/25364969?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouze","html_url":"https://github.com/mdouze","followers_url":"https://api.github.com/users/mdouze/followers","following_url":"https://api.github.com/users/mdouze/following{/other_user}","gists_url":"https://api.github.com/users/mdouze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouze/subscriptions","organizations_url":"https://api.github.com/users/mdouze/orgs","repos_url":"https://api.github.com/users/mdouze/repos","events_url":"https://api.github.com/users/mdouze/events{/privacy}","received_events_url":"https://api.github.com/users/mdouze/received_events","type":"User","site_admin":false},"assignees":[{"login":"mdouze","id":25364969,"node_id":"MDQ6VXNlcjI1MzY0OTY5","avatar_url":"https://avatars1.githubusercontent.com/u/25364969?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouze","html_url":"https://github.com/mdouze","followers_url":"https://api.github.com/users/mdouze/followers","following_url":"https://api.github.com/users/mdouze/following{/other_user}","gists_url":"https://api.github.com/users/mdouze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouze/subscriptions","organizations_url":"https://api.github.com/users/mdouze/orgs","repos_url":"https://api.github.com/users/mdouze/repos","events_url":"https://api.github.com/users/mdouze/events{/privacy}","received_events_url":"https://api.github.com/users/mdouze/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-25T08:38:59Z","updated_at":"2018-07-25T08:56:57Z","closed_at":null,"author_association":"NONE","body":"I currently have an index with factory `PCAR128,IVF4096,SQ8`, \r\nhowever when I try to merge indexes using merge_from, it throws error saying indexPreTransform cannot be merged. My assumption was that having a pre index transform step should not matter when merging since its essentially just combining the Inverted vertex files. The code works correctly for `IVF4096,Flat` and I am verifying if it works for `IVF4096,SQ8`.\r\n\r\nI am currently on this commit \r\nhttps://github.com/facebookresearch/faiss/commit/7f996bd9df4cd01537f632916a6df625edfcb83f\r\n\r\n```\r\n  File \"/root/DVA/server/dvalib/retriever.py\", line 134, in add_vectors\r\n    self.faiss_index.merge_from(index, self.faiss_index.ntotal)\r\n  File \"/root/thirdparty/faiss/python/swigfaiss.py\", line 1784, in <lambda>\r\n    __getattr__ = lambda self, name: _swig_getattr(self, IndexPreTransform, name)\r\n  File \"/root/thirdparty/faiss/python/swigfaiss.py\", line 80, in _swig_getattr\r\n    raise AttributeError(\"'%s' object has no attribute '%s'\" % (class_type.__name__, name))\r\nAttributeError: 'IndexPreTransform' object has no attribute 'merge_from'\r\n```"},"comment":{"url":"https://api.github.com/repos/facebookresearch/faiss/issues/comments/407684052","html_url":"https://github.com/facebookresearch/faiss/issues/545#issuecomment-407684052","issue_url":"https://api.github.com/repos/facebookresearch/faiss/issues/545","id":407684052,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzY4NDA1Mg==","user":{"login":"mdouze","id":25364969,"node_id":"MDQ6VXNlcjI1MzY0OTY5","avatar_url":"https://avatars1.githubusercontent.com/u/25364969?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouze","html_url":"https://github.com/mdouze","followers_url":"https://api.github.com/users/mdouze/followers","following_url":"https://api.github.com/users/mdouze/following{/other_user}","gists_url":"https://api.github.com/users/mdouze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouze/subscriptions","organizations_url":"https://api.github.com/users/mdouze/orgs","repos_url":"https://api.github.com/users/mdouze/repos","events_url":"https://api.github.com/users/mdouze/events{/privacy}","received_events_url":"https://api.github.com/users/mdouze/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T08:56:57Z","updated_at":"2018-07-25T08:56:57Z","author_association":"CONTRIBUTOR","body":"The merge function for `IndexPreTransform`'s will be added to faiss shortly. "}}
{"actor":{"display_login":"mdouze"}}