{"action":"created","issue":{"url":"https://api.github.com/repos/teamdigitale/italia-app/issues/498","repository_url":"https://api.github.com/repos/teamdigitale/italia-app","labels_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/498/labels{/name}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/498/comments","events_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/498/events","html_url":"https://github.com/teamdigitale/italia-app/pull/498","id":360622686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODEzOTI1","number":498,"title":"[#155934635,#160282768,#160394383,#159523446] Messages and push notification handling","user":{"login":"fpersico","id":30595520,"node_id":"MDQ6VXNlcjMwNTk1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/30595520?v=4","gravatar_id":"","url":"https://api.github.com/users/fpersico","html_url":"https://github.com/fpersico","followers_url":"https://api.github.com/users/fpersico/followers","following_url":"https://api.github.com/users/fpersico/following{/other_user}","gists_url":"https://api.github.com/users/fpersico/gists{/gist_id}","starred_url":"https://api.github.com/users/fpersico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpersico/subscriptions","organizations_url":"https://api.github.com/users/fpersico/orgs","repos_url":"https://api.github.com/users/fpersico/repos","events_url":"https://api.github.com/users/fpersico/events{/privacy}","received_events_url":"https://api.github.com/users/fpersico/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-16T09:44:26Z","updated_at":"2018-09-16T11:05:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/498","html_url":"https://github.com/teamdigitale/italia-app/pull/498","diff_url":"https://github.com/teamdigitale/italia-app/pull/498.diff","patch_url":"https://github.com/teamdigitale/italia-app/pull/498.patch"},"body":"In this PR:\r\n\r\n**Refactor of the message related screens (list and detail)**\r\n\r\nOnly the screen components are connected to the store and dispatch actions. The message detail screen just receive the messageId as parameter and handle invalid/loading/error (with retry)/ok cases. The UI of the invalid/loading/error states is not the final one. I am already writing a Provider/HOC component to allow each screen to handle in a simple way all the render states.\r\n\r\n**Proper handling of the push notification**\r\n\r\nPush notification tested scenarios:\r\n- App killed\r\n- App in foreground on the message list screen\r\n- App in foreground on a different tab/screen\r\n- App in background < 30 seconds (no pin unlock request)\r\n- App in background > 30 seconds (pin unlock request)"},"comment":{"url":"https://api.github.com/repos/teamdigitale/italia-app/issues/comments/421746156","html_url":"https://github.com/teamdigitale/italia-app/pull/498#issuecomment-421746156","issue_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/498","id":421746156,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTc0NjE1Ng==","user":{"login":"cloudify","id":48206,"node_id":"MDQ6VXNlcjQ4MjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48206?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify","html_url":"https://github.com/cloudify","followers_url":"https://api.github.com/users/cloudify/followers","following_url":"https://api.github.com/users/cloudify/following{/other_user}","gists_url":"https://api.github.com/users/cloudify/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify/subscriptions","organizations_url":"https://api.github.com/users/cloudify/orgs","repos_url":"https://api.github.com/users/cloudify/repos","events_url":"https://api.github.com/users/cloudify/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T11:05:15Z","updated_at":"2018-09-16T11:05:15Z","author_association":"MEMBER","body":"more than 2000 lines have changed... is it possible to split this PR into multiple, smaller PR? I will need a high level explanation of what has changed\r\n\r\n "}}
{"actor":{"display_login":"cloudify"}}