{"action":"created","issue":{"url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/131","repository_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode","labels_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/131/comments","events_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/131/events","html_url":"https://github.com/pcb2gcode/pcb2gcode/issues/131","id":321141826,"number":131,"title":"vectorial improperly rendering gerber file outline","user":{"login":"eyal0","id":109809,"avatar_url":"https://avatars0.githubusercontent.com/u/109809?v=4","gravatar_id":"","url":"https://api.github.com/users/eyal0","html_url":"https://github.com/eyal0","followers_url":"https://api.github.com/users/eyal0/followers","following_url":"https://api.github.com/users/eyal0/following{/other_user}","gists_url":"https://api.github.com/users/eyal0/gists{/gist_id}","starred_url":"https://api.github.com/users/eyal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyal0/subscriptions","organizations_url":"https://api.github.com/users/eyal0/orgs","repos_url":"https://api.github.com/users/eyal0/repos","events_url":"https://api.github.com/users/eyal0/events{/privacy}","received_events_url":"https://api.github.com/users/eyal0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-08T11:08:21Z","updated_at":"2018-05-08T12:08:04Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The code that reads in a gerber file has created an illegal shape.  In gerbv on the am-test file, the corner looks like this:\r\n\r\n![image](https://user-images.githubusercontent.com/109809/39753853-e8107712-52c8-11e8-8ae4-8eef1336ade6.png)\r\n\r\nAfter reading it in with vectorial mode and converting it to polygons, it looks like this:\r\n\r\n![image](https://user-images.githubusercontent.com/109809/39753920-243514fa-52c9-11e8-89dc-c9c4779773a0.png)\r\n\r\nThe outer edge of that shape looks fine and is a rounded corner.  But the inner loop is self-intersecting, which is not a valid polygon."},"comment":{"url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/comments/387380840","html_url":"https://github.com/pcb2gcode/pcb2gcode/issues/131#issuecomment-387380840","issue_url":"https://api.github.com/repos/pcb2gcode/pcb2gcode/issues/131","id":387380840,"user":{"login":"eyal0","id":109809,"avatar_url":"https://avatars0.githubusercontent.com/u/109809?v=4","gravatar_id":"","url":"https://api.github.com/users/eyal0","html_url":"https://github.com/eyal0","followers_url":"https://api.github.com/users/eyal0/followers","following_url":"https://api.github.com/users/eyal0/following{/other_user}","gists_url":"https://api.github.com/users/eyal0/gists{/gist_id}","starred_url":"https://api.github.com/users/eyal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyal0/subscriptions","organizations_url":"https://api.github.com/users/eyal0/orgs","repos_url":"https://api.github.com/users/eyal0/repos","events_url":"https://api.github.com/users/eyal0/events{/privacy}","received_events_url":"https://api.github.com/users/eyal0/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T12:08:04Z","updated_at":"2018-05-08T12:08:04Z","author_association":"CONTRIBUTOR","body":"This is happening because https://github.com/pcb2gcode/pcb2gcode/blob/master/gerberimporter.cpp#L650 is using `bg::buffer` on integer inputs.  That's been a problem in the past in https://github.com/pcb2gcode/pcb2gcode/blob/master/surface_vectorial.cpp#L319.  The solution is to `bg::buffer` in floating point and then convert back."}}
{"actor":{"display_login":"eyal0"}}