{"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/228744007","pull_request_review_id":169087692,"id":228744007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc0NDAwNw==","diff_hunk":"@@ -5507,112 +5507,135 @@ int TLuaInterpreter::showToolBar(lua_State* L)\n // Documentation: https://wiki.mudlet.org/w/Manual:Lua_Functions#sendATCP\n int TLuaInterpreter::sendATCP(lua_State* L)\n {\n+    Host& host = getHostFromLua(L);\n     string msg;\n     if (!lua_isstring(L, 1)) {\n-        lua_pushstring(L, \"sendATCP: what do you want to send?\");\n-        lua_error(L);\n-        return 1;\n+        lua_pushfstring(L, \"sendATCP: bad argument #1 type (message as string expected, got %1!)\", luaL_typename(L,1));\n+        return lua_error(L);\n     } else {\n-        msg = lua_tostring(L, 1);\n+        msg = host.mTelnet.encodeAndCookBytes(lua_tostring(L, 1));\n     }\n \n     string what;\n-    if (!lua_isstring(L, 2)) {\n-        lua_pushstring(L, \"sendATCP: wrong argument type\");\n-        lua_error(L);\n-        return 1;\n-    } else {\n-        what = lua_tostring(L, 2);\n+    if (lua_gettop(L) > 1) {\n+        if (!lua_isstring(L, 2)) {\n+            lua_pushfstring(L, \"sendATCP: bad argument #2 type (what as string is optional, got %1!)\", luaL_typename(L,2));\n+            return lua_error(L);\n+        } else {\n+            what = host.mTelnet.encodeAndCookBytes(lua_tostring(L, 2));\n+        }\n     }\n-    string _h;\n-    _h += TN_IAC;\n-    _h += TN_SB;\n-    _h += static_cast<char>(200);\n-    _h += msg;\n+\n+    string output;\n+    output += TN_IAC;\n+    output += TN_SB;\n+    output += OPT_ATCP;\n+    output += msg;\n     if (!what.empty()) {\n-        _h += \" \";\n-        _h += what;\n+        output += \" \";\n+        output += what;\n     }\n-    _h += TN_IAC;\n-    _h += TN_SE;\n+    output += TN_IAC;\n+    output += TN_SE;\n \n-    Host& host = getHostFromLua(L);\n-    host.mTelnet.socketOutRaw(_h);\n-    return 0;\n+    if (!host.mTelnet.isATCPEnabled()) {\n+        lua_pushnil(L);\n+        lua_pushstring(L, \"ATCP is not currently enabled by negotiation with the server\");","path":"src/TLuaInterpreter.cpp","position":59,"original_position":59,"commit_id":"ced1cf497312c8ac2910c71e2981b5e6e60b8a0e","original_commit_id":"ced1cf497312c8ac2910c71e2981b5e6e60b8a0e","user":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"body":"So would \"ATCP is not currently enabled\" work to cover all those cases?\r\n\r\nThe original message is just confusing, so I'm trying to find text that's clearer.","created_at":"2018-10-28T11:07:26Z","updated_at":"2018-10-28T11:07:26Z","html_url":"https://github.com/Mudlet/Mudlet/pull/1852#discussion_r228744007","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/228744007"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1852#discussion_r228744007"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852"}},"in_reply_to_id":226519435},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852","id":204301331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzAxMzMx","html_url":"https://github.com/Mudlet/Mudlet/pull/1852","diff_url":"https://github.com/Mudlet/Mudlet/pull/1852.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/1852.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1852","number":1852,"state":"open","locked":false,"title":"Fix handling of non-ASCII by OutOfBand protocols (MSDP/GMPC/ATCP)","user":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"body":"Correct the `cTelnet::processTelnetCommand(const string&)` to correctly measure the length of the msdp data in bytes (appropriate for UTF-8 encoded data) and not `QChar`s (appropriate for UTF-16 encoded `QStrings`) so that the correct size is passed to `(void) TLuaInterpreter::msdp2Lua(char *, int)` - this was changed to a `const char *` for the first argument to show the intent to not modify the passed array, and because it is a `const char *` it was also appropriate to change the length to the correct `size_t` type to use when indexing into it.\r\n\r\nRevise `(void) TLuaInterpreter::msdp2Lua(const char *, size_t)` to process the supplied array as a `QByteArray` and NOT a `QString` - as it is processing a single BYTE and not a `QChar` at a time.  The conversion to a `QString` is only done when the processed data is passed to `(void) TLuaInterpreter::setMSDPTable(QString&, const QString&)` .\r\n\r\nSome other clean up operations were done for MSDP - including unifying the mix-mash of `69` and the `const char MSDP = 69` to the consistent `const char OPT_MSDP = 69` which more closely matches other constants used for other OOB protocols in the code.\r\n\r\nSome raw strings were revised to be placed in `QLatin1String` wrappers when used to initialise or compare against `QString` and some others removed from `QLatin1Char` wrappers when they are now added or compared to `QByteArrays`.\r\n\r\nThis should fix #1851 - but will need a decent test to check that I haven't messed up somehow - also, as `TLuaInterpreter::setMSDPTable` calls `TLuaInterpreter::parseJSON` and so does `TLuaInterpreter::setGMCPTable` it may be worthwhile checking to see that the latter still works and also handles UTF-8 data correctly...!\r\n\r\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>","created_at":"2018-07-27T00:31:40Z","updated_at":"2018-10-28T11:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2640d66272acde93e499db25c04008aafbfbc48","assignee":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"assignees":[{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":119740317,"node_id":"MDU6TGFiZWwxMTk3NDAzMTc=","url":"https://api.github.com/repos/Mudlet/Mudlet/labels/1%20-%20Ready%20for%20review","name":"1 - Ready for review","color":"009800","default":false},{"id":70158102,"node_id":"MDU6TGFiZWw3MDE1ODEwMg==","url":"https://api.github.com/repos/Mudlet/Mudlet/labels/bugfix","name":"bugfix","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/21","html_url":"https://github.com/Mudlet/Mudlet/milestone/21","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/21/labels","id":3717271,"node_id":"MDk6TWlsZXN0b25lMzcxNzI3MQ==","number":21,"title":"3.15","description":"","creator":{"login":"vadi2","id":110988,"node_id":"MDQ6VXNlcjExMDk4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":10,"state":"open","created_at":"2018-10-07T05:06:34Z","updated_at":"2018-10-26T09:31:01Z","due_on":"2018-11-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1852/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/ced1cf497312c8ac2910c71e2981b5e6e60b8a0e","head":{"label":"SlySven:BugFix_attemptToFixUTF-8HandlingOfMSDP","ref":"BugFix_attemptToFixUTF-8HandlingOfMSDP","sha":"ced1cf497312c8ac2910c71e2981b5e6e60b8a0e","user":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"repo":{"id":22490921,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ5MDkyMQ==","name":"Mudlet","full_name":"SlySven/Mudlet","private":false,"owner":{"login":"SlySven","id":6163092,"node_id":"MDQ6VXNlcjYxNjMwOTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SlySven/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/SlySven/Mudlet","forks_url":"https://api.github.com/repos/SlySven/Mudlet/forks","keys_url":"https://api.github.com/repos/SlySven/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlySven/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlySven/Mudlet/teams","hooks_url":"https://api.github.com/repos/SlySven/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/SlySven/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/SlySven/Mudlet/events","assignees_url":"https://api.github.com/repos/SlySven/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/SlySven/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/SlySven/Mudlet/tags","blobs_url":"https://api.github.com/repos/SlySven/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlySven/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlySven/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlySven/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlySven/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/SlySven/Mudlet/languages","stargazers_url":"https://api.github.com/repos/SlySven/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/SlySven/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/SlySven/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/SlySven/Mudlet/subscription","commits_url":"https://api.github.com/repos/SlySven/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlySven/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlySven/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlySven/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlySven/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/SlySven/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlySven/Mudlet/merges","archive_url":"https://api.github.com/repos/SlySven/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlySven/Mudlet/downloads","issues_url":"https://api.github.com/repos/SlySven/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/SlySven/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/SlySven/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/SlySven/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlySven/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/SlySven/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/SlySven/Mudlet/deployments","created_at":"2014-08-01T01:05:26Z","updated_at":"2018-10-15T21:55:41Z","pushed_at":"2018-10-28T01:21:24Z","git_url":"git://github.com/SlySven/Mudlet.git","ssh_url":"git@github.com:SlySven/Mudlet.git","clone_url":"https://github.com/SlySven/Mudlet.git","svn_url":"https://github.com/SlySven/Mudlet","homepage":null,"size":37118,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"1a25b2caad5b2c6df9ac0a4350fe8f7d9d1bc8ba","user":{"login":"Mudlet","id":6158612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTg2MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwODgxMg==","name":"Mudlet","full_name":"Mudlet/Mudlet","private":false,"owner":{"login":"Mudlet","id":6158612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTg2MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Mudlet/Mudlet","description":"A cross-platform, open source, and super fast MUD client with scripting in Lua","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/Mudlet/Mudlet/deployments","created_at":"2013-12-11T14:04:21Z","updated_at":"2018-10-28T01:21:23Z","pushed_at":"2018-10-28T09:48:37Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":"https://mudlet.org","size":33020,"stargazers_count":204,"watchers_count":204,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":96,"open_issues":523,"watchers":204,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1852"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1852"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1852/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1852/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/ced1cf497312c8ac2910c71e2981b5e6e60b8a0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vadi2"}}