{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/comments/172400164","pull_request_review_id":101405964,"id":172400164,"diff_hunk":"@@ -3170,6 +3279,229 @@ resource \"vsphere_virtual_machine\" \"vm\" {\n \t)\n }\n \n+func testAccResourceVSphereVirtualMachineConfigClientCdrom() string {\n+\treturn fmt.Sprintf(`\n+variable \"datacenter\" {\n+  default = \"%s\"\n+}\n+\n+variable \"resource_pool\" {\n+  default = \"%s\"\n+}\n+\n+variable \"network_label\" {\n+  default = \"%s\"\n+}\n+\n+variable \"datastore\" {\n+  default = \"%s\"\n+}\n+\n+data \"vsphere_datacenter\" \"dc\" {\n+  name = \"${var.datacenter}\"\n+}\n+\n+data \"vsphere_datastore\" \"datastore\" {\n+  name          = \"${var.datastore}\"\n+  datacenter_id = \"${data.vsphere_datacenter.dc.id}\"\n+}\n+\n+data \"vsphere_resource_pool\" \"pool\" {\n+  name          = \"${var.resource_pool}\"\n+  datacenter_id = \"${data.vsphere_datacenter.dc.id}\"\n+}\n+\n+data \"vsphere_network\" \"network\" {\n+  name          = \"${var.network_label}\"\n+  datacenter_id = \"${data.vsphere_datacenter.dc.id}\"\n+}\n+\n+resource \"vsphere_virtual_machine\" \"vm\" {\n+  name             = \"terraform-test\"\n+  resource_pool_id = \"${data.vsphere_resource_pool.pool.id}\"\n+  datastore_id     = \"${data.vsphere_datastore.datastore.id}\"\n+\n+  num_cpus = 2\n+  memory   = 2048\n+  guest_id = \"other3xLinux64Guest\"\n+\n+  wait_for_guest_net_timeout = -1\n+\n+  network_interface {\n+    network_id = \"${data.vsphere_network.network.id}\"\n+  }\n+\n+  disk {\n+    label = \"disk0\"\n+    size  = 20\n+  }\n+\n+  cdrom {\n+\t\tclient_device = true","path":"vsphere/resource_vsphere_virtual_machine_test.go","position":231,"original_position":231,"commit_id":"52e17d0197e7eccce39f1dfe2dae139d173e85bb","original_commit_id":"52e17d0197e7eccce39f1dfe2dae139d173e85bb","user":{"login":"vancluever","id":10704423,"avatar_url":"https://avatars0.githubusercontent.com/u/10704423?v=4","gravatar_id":"","url":"https://api.github.com/users/vancluever","html_url":"https://github.com/vancluever","followers_url":"https://api.github.com/users/vancluever/followers","following_url":"https://api.github.com/users/vancluever/following{/other_user}","gists_url":"https://api.github.com/users/vancluever/gists{/gist_id}","starred_url":"https://api.github.com/users/vancluever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancluever/subscriptions","organizations_url":"https://api.github.com/users/vancluever/orgs","repos_url":"https://api.github.com/users/vancluever/repos","events_url":"https://api.github.com/users/vancluever/events{/privacy}","received_events_url":"https://api.github.com/users/vancluever/received_events","type":"User","site_admin":false},"body":"Remember to filter the fixture code through `terraform fmt -` to fix these formatting issues that will normally be hidden from you in the editor.","created_at":"2018-03-06T03:26:42Z","updated_at":"2018-03-06T03:31:15Z","html_url":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421#discussion_r172400164","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/comments/172400164"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421#discussion_r172400164"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421","id":173018602,"html_url":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421","diff_url":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/421","number":421,"state":"open","locked":false,"title":"r/virtual_machine: Add support for remote backed CDROMs","user":{"login":"bill-rich","id":3035677,"avatar_url":"https://avatars1.githubusercontent.com/u/3035677?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-rich","html_url":"https://github.com/bill-rich","followers_url":"https://api.github.com/users/bill-rich/followers","following_url":"https://api.github.com/users/bill-rich/following{/other_user}","gists_url":"https://api.github.com/users/bill-rich/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-rich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-rich/subscriptions","organizations_url":"https://api.github.com/users/bill-rich/orgs","repos_url":"https://api.github.com/users/bill-rich/repos","events_url":"https://api.github.com/users/bill-rich/events{/privacy}","received_events_url":"https://api.github.com/users/bill-rich/received_events","type":"User","site_admin":false},"body":"Previously, only ISO backed CDROMs were supported. This adds the ability to use\r\na remote client device instead.","created_at":"2018-03-05T23:38:09Z","updated_at":"2018-03-06T03:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f9b87f5aa0b38c7e79bd9020698bbb7397ef203","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/421/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/statuses/52e17d0197e7eccce39f1dfe2dae139d173e85bb","head":{"label":"bill-rich:Add_support_for_client_cdrom","ref":"Add_support_for_client_cdrom","sha":"52e17d0197e7eccce39f1dfe2dae139d173e85bb","user":{"login":"bill-rich","id":3035677,"avatar_url":"https://avatars1.githubusercontent.com/u/3035677?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-rich","html_url":"https://github.com/bill-rich","followers_url":"https://api.github.com/users/bill-rich/followers","following_url":"https://api.github.com/users/bill-rich/following{/other_user}","gists_url":"https://api.github.com/users/bill-rich/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-rich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-rich/subscriptions","organizations_url":"https://api.github.com/users/bill-rich/orgs","repos_url":"https://api.github.com/users/bill-rich/repos","events_url":"https://api.github.com/users/bill-rich/events{/privacy}","received_events_url":"https://api.github.com/users/bill-rich/received_events","type":"User","site_admin":false},"repo":{"id":123040601,"name":"terraform-provider-vsphere","full_name":"bill-rich/terraform-provider-vsphere","owner":{"login":"bill-rich","id":3035677,"avatar_url":"https://avatars1.githubusercontent.com/u/3035677?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-rich","html_url":"https://github.com/bill-rich","followers_url":"https://api.github.com/users/bill-rich/followers","following_url":"https://api.github.com/users/bill-rich/following{/other_user}","gists_url":"https://api.github.com/users/bill-rich/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-rich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-rich/subscriptions","organizations_url":"https://api.github.com/users/bill-rich/orgs","repos_url":"https://api.github.com/users/bill-rich/repos","events_url":"https://api.github.com/users/bill-rich/events{/privacy}","received_events_url":"https://api.github.com/users/bill-rich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bill-rich/terraform-provider-vsphere","description":"Terraform VMware vSphere provider","fork":true,"url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere","forks_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/forks","keys_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/teams","hooks_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/hooks","issue_events_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/events","assignees_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/tags","blobs_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/languages","stargazers_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/stargazers","contributors_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/contributors","subscribers_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/subscribers","subscription_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/subscription","commits_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/merges","archive_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/downloads","issues_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/bill-rich/terraform-provider-vsphere/deployments","created_at":"2018-02-26T22:43:07Z","updated_at":"2018-02-26T22:43:09Z","pushed_at":"2018-03-05T23:35:52Z","git_url":"git://github.com/bill-rich/terraform-provider-vsphere.git","ssh_url":"git@github.com:bill-rich/terraform-provider-vsphere.git","clone_url":"https://github.com/bill-rich/terraform-provider-vsphere.git","svn_url":"https://github.com/bill-rich/terraform-provider-vsphere","homepage":"https://www.terraform.io/docs/providers/vsphere/","size":6384,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"79e7cf2ea347f57d41043d8cf0bf3c292bbe6c95","user":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446037,"name":"terraform-provider-vsphere","full_name":"terraform-providers/terraform-provider-vsphere","owner":{"login":"terraform-providers","id":29154831,"avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-vsphere","description":"Terraform VMware vSphere provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-03-03T14:38:11Z","pushed_at":"2018-03-05T23:38:10Z","git_url":"git://github.com/terraform-providers/terraform-provider-vsphere.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-vsphere.git","clone_url":"https://github.com/terraform-providers/terraform-provider-vsphere.git","svn_url":"https://github.com/terraform-providers/terraform-provider-vsphere","homepage":"https://www.terraform.io/docs/providers/vsphere/","size":6368,"stargazers_count":93,"watchers_count":93,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":72,"open_issues":99,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-vsphere/pull/421"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/421"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-vsphere/statuses/52e17d0197e7eccce39f1dfe2dae139d173e85bb"}},"author_association":"NONE"}}
{"actor":{"display_login":"vancluever"}}