{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60457","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60457/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60457/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60457/events","html_url":"https://github.com/kubernetes/kubernetes/pull/60457","id":300403615,"number":60457,"title":"tests: e2e: empty msg from channel other than stdout should be non-fatal","user":{"login":"sjenning","id":493891,"avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":687345274,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/milestone/removed","name":"milestone/removed","color":"ededed","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2018-02-26T21:31:34Z","updated_at":"2018-03-18T08:34:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60457","html_url":"https://github.com/kubernetes/kubernetes/pull/60457","diff_url":"https://github.com/kubernetes/kubernetes/pull/60457.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60457.patch"},"body":"Currently, if the exec websocket encounters a message that is not in the stdout stream, it immediately fails.  However it also currently requests the stderr steam in the query params.  There doesn't seem to be any guarantee that we don't get an empty message on the stderr stream.\r\n\r\nRequesting the stderr stream in the query is desirable if, for some reason, something in the container fails and writes to stderr.\r\n\r\nHowever, we do not need fail the test if we get an empty message on another stream.  If the message is not empty, then that _does_ indicate and error and we should fail.\r\n\r\nThis is the situation we are currently observing with docker 1.13 in the origin CI https://github.com/openshift/origin/issues/18726\r\n\r\n@derekwaynecarr @smarterclayton @gabemontero @liggitt @deads2k \r\n\r\n/sig node"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/373981351","html_url":"https://github.com/kubernetes/kubernetes/pull/60457#issuecomment-373981351","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60457","id":373981351,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T08:34:12Z","updated_at":"2018-03-18T08:34:12Z","author_association":"COLLABORATOR","body":"/test all\n\nTests are more than 96 hours old. Re-running tests."}}
{"actor":{"display_login":"k8s-merge-robot"}}