{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/12977","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/12977/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/12977/comments","events_url":"https://api.github.com/repos/keybase/client/issues/12977/events","html_url":"https://github.com/keybase/client/pull/12977","id":344557176,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTI0NTE0","number":12977,"title":"Team: Add People fixes","user":{"login":"cjb","id":21217,"node_id":"MDQ6VXNlcjIxMjE3","avatar_url":"https://avatars2.githubusercontent.com/u/21217?v=4","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-25T18:30:31Z","updated_at":"2018-07-25T21:40:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/12977","html_url":"https://github.com/keybase/client/pull/12977","diff_url":"https://github.com/keybase/client/pull/12977.diff","patch_url":"https://github.com/keybase/client/pull/12977.patch"},"body":"@keybase/react-hackers CC @cecileboucheron\r\n\r\n* Add button now shows the number of people that will be added\r\n* Clicking search input \"x\" only clears the search selections\r\n* Show \"Already a member\" next to members, make their avatar transparent and don't color their rows on hover\r\n* Remove blue + button\r\n* Clicking \"Add\" brings up the role picker\r\n* Allow customizing the title, add button label on the role picker\r\n* Allow hiding the \"Back\" label on the back button in header hoc header"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/407905195","html_url":"https://github.com/keybase/client/pull/12977#issuecomment-407905195","issue_url":"https://api.github.com/repos/keybase/client/issues/12977","id":407905195,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzkwNTE5NQ==","user":{"login":"cecileboucheron","id":2807426,"node_id":"MDQ6VXNlcjI4MDc0MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2807426?v=4","gravatar_id":"","url":"https://api.github.com/users/cecileboucheron","html_url":"https://github.com/cecileboucheron","followers_url":"https://api.github.com/users/cecileboucheron/followers","following_url":"https://api.github.com/users/cecileboucheron/following{/other_user}","gists_url":"https://api.github.com/users/cecileboucheron/gists{/gist_id}","starred_url":"https://api.github.com/users/cecileboucheron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cecileboucheron/subscriptions","organizations_url":"https://api.github.com/users/cecileboucheron/orgs","repos_url":"https://api.github.com/users/cecileboucheron/repos","events_url":"https://api.github.com/users/cecileboucheron/events{/privacy}","received_events_url":"https://api.github.com/users/cecileboucheron/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T21:40:48Z","updated_at":"2018-07-25T21:40:48Z","author_association":"CONTRIBUTOR","body":"Looking so much better already! A few comments:\r\n* The blue check on the right side should show up for people already in list up top, not for people already in team. \r\n* These people (already in list up top) should show a disabled avatar and no hover state (right now they look like you can add them again)\r\n* Window should be 620 wide by 520 maximum with 40px margins around it. If the viewport gets smaller than the total of all that, window should shrink and scroll. Right now it's going edge to edge (screenshot).\r\n* No back button (right now there's even 2) - on the mockup there was one because you were coming from the `Name your team` step.\r\n![image](https://user-images.githubusercontent.com/2807426/43229039-371f0b70-9018-11e8-95b1-65eee855f7a9.png)\r\n"}}
{"actor":{"display_login":"cecileboucheron"}}