{"action":"created","comment":{"url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/comments/243740851","pull_request_review_id":187596828,"id":243740851,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc0MDg1MQ==","diff_hunk":"@@ -198,8 +198,9 @@ clickCommandCards = function()\n \t\tfor _, cardSlot in pairs(currentCardTypeStorage) do\n \t\t\tclick(COMMAND_CARD_CLICK_ARRAY[cardSlot])\n \t\t\tclickCount = clickCount + 1\n-\t\n-\t\t\tif clickCount == 3 then\n+\t\t\t\n+\t\t\t-- Increased clickCount requirement from 3 to 5 to prevent fastclick from missing a click\n+\t\t\tif clickCount == 5 then","path":"modules/card.lua","position":25,"original_position":25,"commit_id":"7315b800e8add4958cd2ccac80cfdd350598d79c","original_commit_id":"7315b800e8add4958cd2ccac80cfdd350598d79c","user":{"login":"potchy","id":4316326,"node_id":"MDQ6VXNlcjQzMTYzMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4316326?v=4","gravatar_id":"","url":"https://api.github.com/users/potchy","html_url":"https://github.com/potchy","followers_url":"https://api.github.com/users/potchy/followers","following_url":"https://api.github.com/users/potchy/following{/other_user}","gists_url":"https://api.github.com/users/potchy/gists{/gist_id}","starred_url":"https://api.github.com/users/potchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potchy/subscriptions","organizations_url":"https://api.github.com/users/potchy/orgs","repos_url":"https://api.github.com/users/potchy/repos","events_url":"https://api.github.com/users/potchy/events{/privacy}","received_events_url":"https://api.github.com/users/potchy/received_events","type":"User","site_admin":false},"body":"Regardless of this condition, if the script misses a click, your card order will be messed up anyway, so isn't it better to increase your fast click delay a bit instead?","created_at":"2018-12-22T16:34:39Z","updated_at":"2018-12-22T16:35:56Z","html_url":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139#discussion_r243740851","pull_request_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/comments/243740851"},"html":{"href":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139#discussion_r243740851"},"pull_request":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139","id":240605439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjA1NDM5","html_url":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139","diff_url":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139.diff","patch_url":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139.patch","issue_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/139","number":139,"state":"open","locked":false,"title":"Took a bit of tinkering","user":{"login":"TryBane","id":24114484,"node_id":"MDQ6VXNlcjI0MTE0NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/24114484?v=4","gravatar_id":"","url":"https://api.github.com/users/TryBane","html_url":"https://github.com/TryBane","followers_url":"https://api.github.com/users/TryBane/followers","following_url":"https://api.github.com/users/TryBane/following{/other_user}","gists_url":"https://api.github.com/users/TryBane/gists{/gist_id}","starred_url":"https://api.github.com/users/TryBane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryBane/subscriptions","organizations_url":"https://api.github.com/users/TryBane/orgs","repos_url":"https://api.github.com/users/TryBane/repos","events_url":"https://api.github.com/users/TryBane/events{/privacy}","received_events_url":"https://api.github.com/users/TryBane/received_events","type":"User","site_admin":false},"body":"But I managed to get it.\r\n\r\n### Changes in autoskill.lua\r\n\r\nThis will allow for image recognition to be used rather than straight wait times during farming. @potchy made it so that the image being searched for is a better option so that extensive wait times are uneeded during Raid/Boss fights and still functions almost the same as normal. There is a slight delay in comparison due to the screen capture of the stage taking a couple seconds (which was handled by the time skills could be clicked) but it is better than using an arbitrary number for a wait time that may change in any number of situations.\r\n\r\n### Changes in regular.lua and FGO_NA_REGULAR.lua\r\n\r\nAlso added the functionality of choosing multiple types of apples along with All Apples allowing you to clear out your current apple stock in order from Bronze->Silver->Gold. Changed \"How_Many\" to \"Repetitions\" to reflect the change since Bronze Apples can be used in multiples. Also added comments to explain this functionalities use. Also please note that I have NOT made these changes in the other FGO_XX_REGULAR.lua files! Someone please get that for me? I don't know how to write the explanations and such in those languages ;(\r\n\r\n### Changes in card.lua\r\n\r\nChanged the range for the search regarding the command cards (fixes the bug someone pointed out previously) Also changed the required 3 card clicks to 5 cards to account for the occasional issue where someone uses fastclick and the script skips a card.\r\n\r\n### Small notes added to autoskill.lua\r\n\r\nI made a note regarding the variable \"isFirstSkill\". With the use of the new image for recognition and using image recognition itself for determining when to cast skills, I do not see the point of having this variable any longer. I left it in in case there was something I was unaware of that it affected, but thought I'd point it out. The only use I saw was in decodeSkill() where it ensures you have enough time for skill animations.","created_at":"2018-12-22T00:36:56Z","updated_at":"2018-12-22T16:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee47f6c4b8aa94b95f5e391dfe7b90b51a032e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139/commits","review_comments_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139/comments","review_comment_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/139/comments","statuses_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/statuses/7315b800e8add4958cd2ccac80cfdd350598d79c","head":{"label":"TryBane:master","ref":"master","sha":"7315b800e8add4958cd2ccac80cfdd350598d79c","user":{"login":"TryBane","id":24114484,"node_id":"MDQ6VXNlcjI0MTE0NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/24114484?v=4","gravatar_id":"","url":"https://api.github.com/users/TryBane","html_url":"https://github.com/TryBane","followers_url":"https://api.github.com/users/TryBane/followers","following_url":"https://api.github.com/users/TryBane/following{/other_user}","gists_url":"https://api.github.com/users/TryBane/gists{/gist_id}","starred_url":"https://api.github.com/users/TryBane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryBane/subscriptions","organizations_url":"https://api.github.com/users/TryBane/orgs","repos_url":"https://api.github.com/users/TryBane/repos","events_url":"https://api.github.com/users/TryBane/events{/privacy}","received_events_url":"https://api.github.com/users/TryBane/received_events","type":"User","site_admin":false},"repo":{"id":162762701,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3NjI3MDE=","name":"Fate-Grand-Order_Lua","full_name":"TryBane/Fate-Grand-Order_Lua","private":false,"owner":{"login":"TryBane","id":24114484,"node_id":"MDQ6VXNlcjI0MTE0NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/24114484?v=4","gravatar_id":"","url":"https://api.github.com/users/TryBane","html_url":"https://github.com/TryBane","followers_url":"https://api.github.com/users/TryBane/followers","following_url":"https://api.github.com/users/TryBane/following{/other_user}","gists_url":"https://api.github.com/users/TryBane/gists{/gist_id}","starred_url":"https://api.github.com/users/TryBane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryBane/subscriptions","organizations_url":"https://api.github.com/users/TryBane/orgs","repos_url":"https://api.github.com/users/TryBane/repos","events_url":"https://api.github.com/users/TryBane/events{/privacy}","received_events_url":"https://api.github.com/users/TryBane/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TryBane/Fate-Grand-Order_Lua","description":"Fate Grand Order auto battle script - no root needed, for Android use only","fork":true,"url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua","forks_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/forks","keys_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/teams","hooks_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/hooks","issue_events_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/issues/events{/number}","events_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/events","assignees_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/assignees{/user}","branches_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/branches{/branch}","tags_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/tags","blobs_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/statuses/{sha}","languages_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/languages","stargazers_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/stargazers","contributors_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/contributors","subscribers_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/subscribers","subscription_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/subscription","commits_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/contents/{+path}","compare_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/merges","archive_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/downloads","issues_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/issues{/number}","pulls_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/pulls{/number}","milestones_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/milestones{/number}","notifications_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/labels{/name}","releases_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/releases{/id}","deployments_url":"https://api.github.com/repos/TryBane/Fate-Grand-Order_Lua/deployments","created_at":"2018-12-21T22:23:16Z","updated_at":"2018-12-22T13:36:34Z","pushed_at":"2018-12-22T13:37:22Z","git_url":"git://github.com/TryBane/Fate-Grand-Order_Lua.git","ssh_url":"git@github.com:TryBane/Fate-Grand-Order_Lua.git","clone_url":"https://github.com/TryBane/Fate-Grand-Order_Lua.git","svn_url":"https://github.com/TryBane/Fate-Grand-Order_Lua","homepage":"","size":62874,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"29988122:master","ref":"master","sha":"78a1427f1b854bba8e0ff294b872c4ecb764dba5","user":{"login":"29988122","id":5474709,"node_id":"MDQ6VXNlcjU0NzQ3MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5474709?v=4","gravatar_id":"","url":"https://api.github.com/users/29988122","html_url":"https://github.com/29988122","followers_url":"https://api.github.com/users/29988122/followers","following_url":"https://api.github.com/users/29988122/following{/other_user}","gists_url":"https://api.github.com/users/29988122/gists{/gist_id}","starred_url":"https://api.github.com/users/29988122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/29988122/subscriptions","organizations_url":"https://api.github.com/users/29988122/orgs","repos_url":"https://api.github.com/users/29988122/repos","events_url":"https://api.github.com/users/29988122/events{/privacy}","received_events_url":"https://api.github.com/users/29988122/received_events","type":"User","site_admin":false},"repo":{"id":80001337,"node_id":"MDEwOlJlcG9zaXRvcnk4MDAwMTMzNw==","name":"Fate-Grand-Order_Lua","full_name":"29988122/Fate-Grand-Order_Lua","private":false,"owner":{"login":"29988122","id":5474709,"node_id":"MDQ6VXNlcjU0NzQ3MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5474709?v=4","gravatar_id":"","url":"https://api.github.com/users/29988122","html_url":"https://github.com/29988122","followers_url":"https://api.github.com/users/29988122/followers","following_url":"https://api.github.com/users/29988122/following{/other_user}","gists_url":"https://api.github.com/users/29988122/gists{/gist_id}","starred_url":"https://api.github.com/users/29988122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/29988122/subscriptions","organizations_url":"https://api.github.com/users/29988122/orgs","repos_url":"https://api.github.com/users/29988122/repos","events_url":"https://api.github.com/users/29988122/events{/privacy}","received_events_url":"https://api.github.com/users/29988122/received_events","type":"User","site_admin":false},"html_url":"https://github.com/29988122/Fate-Grand-Order_Lua","description":"Fate Grand Order auto battle script - no root needed, for Android use only","fork":false,"url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua","forks_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/forks","keys_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/teams","hooks_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/hooks","issue_events_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/events{/number}","events_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/events","assignees_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/assignees{/user}","branches_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/branches{/branch}","tags_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/tags","blobs_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/git/refs{/sha}","trees_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/statuses/{sha}","languages_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/languages","stargazers_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/stargazers","contributors_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/contributors","subscribers_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/subscribers","subscription_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/subscription","commits_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/commits{/sha}","git_commits_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/git/commits{/sha}","comments_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/comments{/number}","issue_comment_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/comments{/number}","contents_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/contents/{+path}","compare_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/merges","archive_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/downloads","issues_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues{/number}","pulls_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls{/number}","milestones_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/milestones{/number}","notifications_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/labels{/name}","releases_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/releases{/id}","deployments_url":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/deployments","created_at":"2017-01-25T09:45:43Z","updated_at":"2018-12-21T19:50:01Z","pushed_at":"2018-12-22T13:36:34Z","git_url":"git://github.com/29988122/Fate-Grand-Order_Lua.git","ssh_url":"git@github.com:29988122/Fate-Grand-Order_Lua.git","clone_url":"https://github.com/29988122/Fate-Grand-Order_Lua.git","svn_url":"https://github.com/29988122/Fate-Grand-Order_Lua","homepage":"","size":63041,"stargazers_count":106,"watchers_count":106,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":27,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139"},"html":{"href":"https://github.com/29988122/Fate-Grand-Order_Lua/pull/139"},"issue":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/139"},"comments":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/29988122/Fate-Grand-Order_Lua/statuses/7315b800e8add4958cd2ccac80cfdd350598d79c"}},"author_association":"NONE"}}
{"actor":{"display_login":"potchy"}}