{"action":"created","issue":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2208","repository_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2208/labels{/name}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2208/comments","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2208/events","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2208","id":360668614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODM5ODQ0","number":2208,"title":"Brain Freeze munching change to check for icicle stacks","user":{"login":"Dambroda","id":43309639,"node_id":"MDQ6VXNlcjQzMzA5NjM5","avatar_url":"https://avatars3.githubusercontent.com/u/43309639?v=4","gravatar_id":"","url":"https://api.github.com/users/Dambroda","html_url":"https://github.com/Dambroda","followers_url":"https://api.github.com/users/Dambroda/followers","following_url":"https://api.github.com/users/Dambroda/following{/other_user}","gists_url":"https://api.github.com/users/Dambroda/gists{/gist_id}","starred_url":"https://api.github.com/users/Dambroda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dambroda/subscriptions","organizations_url":"https://api.github.com/users/Dambroda/orgs","repos_url":"https://api.github.com/users/Dambroda/repos","events_url":"https://api.github.com/users/Dambroda/events{/privacy}","received_events_url":"https://api.github.com/users/Dambroda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-16T19:08:23Z","updated_at":"2018-09-18T20:29:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/2208","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2208","diff_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2208.diff","patch_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2208.patch"},"body":"With this change, icicle stacks will be taken into account when suggesting whether or not the player munched too many Brain Freeze procs. Previously, there was simply a comment that said it might be ok to overwrite procs if you had 3 icicles, this change should have the analyzer do that checking for the player"},"comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments/422541791","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2208#issuecomment-422541791","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2208","id":422541791,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjU0MTc5MQ==","user":{"login":"Sharrq","id":1304554,"node_id":"MDQ6VXNlcjEzMDQ1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1304554?v=4","gravatar_id":"","url":"https://api.github.com/users/Sharrq","html_url":"https://github.com/Sharrq","followers_url":"https://api.github.com/users/Sharrq/followers","following_url":"https://api.github.com/users/Sharrq/following{/other_user}","gists_url":"https://api.github.com/users/Sharrq/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharrq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharrq/subscriptions","organizations_url":"https://api.github.com/users/Sharrq/orgs","repos_url":"https://api.github.com/users/Sharrq/repos","events_url":"https://api.github.com/users/Sharrq/events{/privacy}","received_events_url":"https://api.github.com/users/Sharrq/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T20:29:24Z","updated_at":"2018-09-18T20:29:24Z","author_association":"CONTRIBUTOR","body":"I added the comment in line but since its hidden now, ill repost here in response to why i was suggesting using 4 in the suggestion instead of 3.\r\n\r\nI dont have a problem with using the constant in the suggestion, i just dont really like that the constant doesnt represent the same value throughout the module. Cause in the suggestion it means 3 but in the if statement it means 4 (or 3+1) .... Its probably just a personal annoyance and doesnt matter in the grand scheme of things .... also im not a developer/programmer, so me not understanding might just be because i dont do this for a living (i do some scripting and such but i dont know much about javascript and im not a developer ... which is why i am not allowed to review/approve/merge things :P )\r\n\r\nThough the point i was trying to make earlier about assuming they are casting Frostbolt is that Yes I understand that they should not be casting Ebonbolt unless they have 5 Icicles and no Brain Freeze .... but people are going to do it anyway. Yes all the guides say to never cast Ebonbolt unless you have 5 icicles and need a brain freeze proc, but I can guarantee you that there will be people that choose to cast Ebonbolt on cooldown regardless. So I was wanting the suggestion to use the number 4 not 3 because I prefer to assume that not everyone is going to play correctly and i would rather the suggestions be accurate regardless of whether they are playing correctly or not."}}
{"actor":{"display_login":"Sharrq"}}