{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/219666258","pull_request_review_id":157904428,"id":219666258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY2NjI1OA==","diff_hunk":"@@ -153,6 +153,7 @@ foreach(lib IN LISTS required_dyload dyload_optional ITEMS Shairplay)\n endforeach()\n add_bundle_file(${ASS_LIBRARY} ${libdir} \"\")\n add_bundle_file(${BLURAY_LIBRARY} ${libdir} \"\")\n+add_bundle_file(${NFS_LIBRARY} ${libdir} \"\")","path":"cmake/scripts/android/Install.cmake","position":null,"original_position":4,"commit_id":"1c399fef7e6a5d19bb791d7ae11e21504e900cac","original_commit_id":"4dc650532088641fbfddd72ed0892898abb981d3","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"body":"@wsnipex updated","created_at":"2018-09-22T09:15:34Z","updated_at":"2018-09-22T09:15:34Z","html_url":"https://github.com/xbmc/xbmc/pull/14450#discussion_r219666258","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14450","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/219666258"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14450#discussion_r219666258"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14450"}},"in_reply_to_id":218455233},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14450","id":216301120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzAxMTIw","html_url":"https://github.com/xbmc/xbmc/pull/14450","diff_url":"https://github.com/xbmc/xbmc/pull/14450.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14450.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14450","number":14450,"state":"open","locked":false,"title":"link with libnfs instead of loading it dynamic","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"body":"## Description\r\nDon't load libnfs dynamic, but link against it (shared/static).\r\n\r\n## How Has This Been Tested?\r\ncompiled for windows and linux\r\n\r\n## Types of change\r\n- [ ] **Bug fix** (non-breaking change which fixes an issue)\r\n- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)\r\n- [x] **Improvement** (non-breaking change which improves existing functionality)\r\n- [ ] **New feature** (non-breaking change which adds functionality)\r\n- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)\r\n- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)\r\n- [ ] **None of the above** (please explain below)\r\n\r\n## Checklist:\r\n- [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n","created_at":"2018-09-18T13:07:40Z","updated_at":"2018-09-22T09:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83ed892b599b0e18eb9ab12a68418c4418a5421c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1659220,"node_id":"MDU6TGFiZWwxNjU5MjIw","url":"https://api.github.com/repos/xbmc/xbmc/labels/Cleanup","name":"Cleanup","color":"0b02e1","default":false},{"id":400751192,"node_id":"MDU6TGFiZWw0MDA3NTExOTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14450/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14450/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14450/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/1c399fef7e6a5d19bb791d7ae11e21504e900cac","head":{"label":"Rechi:cleanup/dlopen","ref":"cleanup/dlopen","sha":"1c399fef7e6a5d19bb791d7ae11e21504e900cac","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"repo":{"id":31212951,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxMjk1MQ==","name":"xbmc","full_name":"Rechi/xbmc","private":false,"owner":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Rechi/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/Rechi/xbmc","forks_url":"https://api.github.com/repos/Rechi/xbmc/forks","keys_url":"https://api.github.com/repos/Rechi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rechi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rechi/xbmc/teams","hooks_url":"https://api.github.com/repos/Rechi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Rechi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Rechi/xbmc/events","assignees_url":"https://api.github.com/repos/Rechi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Rechi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Rechi/xbmc/tags","blobs_url":"https://api.github.com/repos/Rechi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rechi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rechi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rechi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rechi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Rechi/xbmc/languages","stargazers_url":"https://api.github.com/repos/Rechi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Rechi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Rechi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Rechi/xbmc/subscription","commits_url":"https://api.github.com/repos/Rechi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rechi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rechi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rechi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rechi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Rechi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rechi/xbmc/merges","archive_url":"https://api.github.com/repos/Rechi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rechi/xbmc/downloads","issues_url":"https://api.github.com/repos/Rechi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Rechi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Rechi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Rechi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rechi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Rechi/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/Rechi/xbmc/deployments","created_at":"2015-02-23T15:03:56Z","updated_at":"2018-09-22T09:05:17Z","pushed_at":"2018-09-22T09:15:13Z","git_url":"git://github.com/Rechi/xbmc.git","ssh_url":"git@github.com:Rechi/xbmc.git","clone_url":"https://github.com/Rechi/xbmc.git","svn_url":"https://github.com/Rechi/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":615011,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"94f8b83777f26f0c85c74cbce7365e6ef8c3127d","user":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NjE0","name":"xbmc","full_name":"xbmc/xbmc","private":false,"owner":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xbmc/xbmc","description":"Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, Linux, macOS, iOS and Windows.","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2018-09-22T09:00:24Z","pushed_at":"2018-09-22T09:15:16Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"https://kodi.tv/","size":1466676,"stargazers_count":7394,"watchers_count":7394,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4713,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4713,"open_issues":106,"watchers":7394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14450"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14450"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14450"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14450/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14450/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14450/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/1c399fef7e6a5d19bb791d7ae11e21504e900cac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Rechi"}}