{"action":"created","issue":{"url":"https://api.github.com/repos/sinonjs/referee/issues/47","repository_url":"https://api.github.com/repos/sinonjs/referee","labels_url":"https://api.github.com/repos/sinonjs/referee/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/sinonjs/referee/issues/47/comments","events_url":"https://api.github.com/repos/sinonjs/referee/issues/47/events","html_url":"https://github.com/sinonjs/referee/issues/47","id":378273699,"node_id":"MDU6SXNzdWUzNzgyNzM2OTk=","number":47,"title":"Proposal: remove referee.count","user":{"login":"mroderick","id":20321,"node_id":"MDQ6VXNlcjIwMzIx","avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-07T12:48:42Z","updated_at":"2018-11-07T15:07:52Z","closed_at":null,"author_association":"MEMBER","body":"`referee.count` is an artefact from `buster`, which was made so that `buster` could report on how many assertions were run, and could fail a test that had no assertions.\r\n\r\nI don't know of any other test runner that has this feature or uses `referee.count` for anything.\r\n\r\nSince `master` is already primed for another MAJOR release by merging #46, I think now would be a good time to remove `referee.count`.\r\n\r\nOpinions?"},"comment":{"url":"https://api.github.com/repos/sinonjs/referee/issues/comments/436654573","html_url":"https://github.com/sinonjs/referee/issues/47#issuecomment-436654573","issue_url":"https://api.github.com/repos/sinonjs/referee/issues/47","id":436654573,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjY1NDU3Mw==","user":{"login":"mantoni","id":332271,"node_id":"MDQ6VXNlcjMzMjI3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/332271?v=4","gravatar_id":"","url":"https://api.github.com/users/mantoni","html_url":"https://github.com/mantoni","followers_url":"https://api.github.com/users/mantoni/followers","following_url":"https://api.github.com/users/mantoni/following{/other_user}","gists_url":"https://api.github.com/users/mantoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mantoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantoni/subscriptions","organizations_url":"https://api.github.com/users/mantoni/orgs","repos_url":"https://api.github.com/users/mantoni/repos","events_url":"https://api.github.com/users/mantoni/events{/privacy}","received_events_url":"https://api.github.com/users/mantoni/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T15:07:52Z","updated_at":"2018-11-07T15:07:52Z","author_association":"MEMBER","body":"You understood me correctly. That describes the plan.\r\n\r\nI think adding a method is enough for an assertion library. I would think of this like calling `sinon.restore()`. It's optional, so yes, you can forget it, but at least we don't add magical behaviour.\r\n\r\nAs a side node: Hooking into `process.on('exit')` isn't guaranteed to work either because newer versions of Mocha don't call `process.exit()` anymore. They simply set `process.exitCode = 1` in case of a failure and let node decide whether it's done."}}
{"actor":{"display_login":"mantoni"}}