{"action":"created","issue":{"url":"https://api.github.com/repos/CCAFS/MARLO/issues/1287","repository_url":"https://api.github.com/repos/CCAFS/MARLO","labels_url":"https://api.github.com/repos/CCAFS/MARLO/issues/1287/labels{/name}","comments_url":"https://api.github.com/repos/CCAFS/MARLO/issues/1287/comments","events_url":"https://api.github.com/repos/CCAFS/MARLO/issues/1287/events","html_url":"https://github.com/CCAFS/MARLO/issues/1287","id":295441973,"number":1287,"title":"Move MARLO configuartion files into marlo-web project","user":{"login":"Grant-Lay","id":2264925,"avatar_url":"https://avatars3.githubusercontent.com/u/2264925?v=4","gravatar_id":"","url":"https://api.github.com/users/Grant-Lay","html_url":"https://github.com/Grant-Lay","followers_url":"https://api.github.com/users/Grant-Lay/followers","following_url":"https://api.github.com/users/Grant-Lay/following{/other_user}","gists_url":"https://api.github.com/users/Grant-Lay/gists{/gist_id}","starred_url":"https://api.github.com/users/Grant-Lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grant-Lay/subscriptions","organizations_url":"https://api.github.com/users/Grant-Lay/orgs","repos_url":"https://api.github.com/users/Grant-Lay/repos","events_url":"https://api.github.com/users/Grant-Lay/events{/privacy}","received_events_url":"https://api.github.com/users/Grant-Lay/received_events","type":"User","site_admin":false},"labels":[{"id":375110728,"url":"https://api.github.com/repos/CCAFS/MARLO/labels/Priority%20-%20Low","name":"Priority - Low","color":"bfd4f2","default":false},{"id":375157159,"url":"https://api.github.com/repos/CCAFS/MARLO/labels/Review/QA","name":"Review/QA","color":"95a5a6","default":false},{"id":375113191,"url":"https://api.github.com/repos/CCAFS/MARLO/labels/Type%20-Task","name":"Type -Task","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"Grant-Lay","id":2264925,"avatar_url":"https://avatars3.githubusercontent.com/u/2264925?v=4","gravatar_id":"","url":"https://api.github.com/users/Grant-Lay","html_url":"https://github.com/Grant-Lay","followers_url":"https://api.github.com/users/Grant-Lay/followers","following_url":"https://api.github.com/users/Grant-Lay/following{/other_user}","gists_url":"https://api.github.com/users/Grant-Lay/gists{/gist_id}","starred_url":"https://api.github.com/users/Grant-Lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grant-Lay/subscriptions","organizations_url":"https://api.github.com/users/Grant-Lay/orgs","repos_url":"https://api.github.com/users/Grant-Lay/repos","events_url":"https://api.github.com/users/Grant-Lay/events{/privacy}","received_events_url":"https://api.github.com/users/Grant-Lay/received_events","type":"User","site_admin":false},"assignees":[{"login":"Grant-Lay","id":2264925,"avatar_url":"https://avatars3.githubusercontent.com/u/2264925?v=4","gravatar_id":"","url":"https://api.github.com/users/Grant-Lay","html_url":"https://github.com/Grant-Lay","followers_url":"https://api.github.com/users/Grant-Lay/followers","following_url":"https://api.github.com/users/Grant-Lay/following{/other_user}","gists_url":"https://api.github.com/users/Grant-Lay/gists{/gist_id}","starred_url":"https://api.github.com/users/Grant-Lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grant-Lay/subscriptions","organizations_url":"https://api.github.com/users/Grant-Lay/orgs","repos_url":"https://api.github.com/users/Grant-Lay/repos","events_url":"https://api.github.com/users/Grant-Lay/events{/privacy}","received_events_url":"https://api.github.com/users/Grant-Lay/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CCAFS/MARLO/milestones/29","html_url":"https://github.com/CCAFS/MARLO/milestone/29","labels_url":"https://api.github.com/repos/CCAFS/MARLO/milestones/29/labels","id":3072715,"number":29,"title":"v4.2.5 - POWB Synthesis partially","description":"","creator":{"login":"HermesJim","id":13221179,"avatar_url":"https://avatars2.githubusercontent.com/u/13221179?v=4","gravatar_id":"","url":"https://api.github.com/users/HermesJim","html_url":"https://github.com/HermesJim","followers_url":"https://api.github.com/users/HermesJim/followers","following_url":"https://api.github.com/users/HermesJim/following{/other_user}","gists_url":"https://api.github.com/users/HermesJim/gists{/gist_id}","starred_url":"https://api.github.com/users/HermesJim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HermesJim/subscriptions","organizations_url":"https://api.github.com/users/HermesJim/orgs","repos_url":"https://api.github.com/users/HermesJim/repos","events_url":"https://api.github.com/users/HermesJim/events{/privacy}","received_events_url":"https://api.github.com/users/HermesJim/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":11,"state":"open","created_at":"2018-01-29T19:22:27Z","updated_at":"2018-02-20T02:15:36Z","due_on":"2018-02-16T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-02-08T09:36:02Z","updated_at":"2018-02-20T09:41:40Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"As per the conversation with the MARLO development team in 2017 when I presented the spring changes, we agreed that I would move the configuration files from the parent folder into the marlo-web project src/main/resources folder.  The benefits are that we do not need to do a maven build if we want to test out changes to property values, saving developers time.  We also can remove the warning in the pom.xml about copying files from outside the project.\r\n\r\nOne other benefit is that by having the properties files in the marlo-web project we can make use of Spring profiles, where we can declare the environment we are running in and disable or enable specific beans depending on which environment we are in.  For example the Swagger beans which document our web services are enabled for all environments unless we write logic which checks which environment we are in.  Using spring we can use an annotation @Profile({'dev', 'test'}) and the beans would only be enabled in the dev and test environments, or @Profile('!prod') which would equate to every environment except for production. \r\nOther uses would be that we could write a notification bean that behaved differently in our dev and test environments and we could check the emails that are sent are correct, rather than throw exceptions as it does now."},"comment":{"url":"https://api.github.com/repos/CCAFS/MARLO/issues/comments/366921817","html_url":"https://github.com/CCAFS/MARLO/issues/1287#issuecomment-366921817","issue_url":"https://api.github.com/repos/CCAFS/MARLO/issues/1287","id":366921817,"user":{"login":"Grant-Lay","id":2264925,"avatar_url":"https://avatars3.githubusercontent.com/u/2264925?v=4","gravatar_id":"","url":"https://api.github.com/users/Grant-Lay","html_url":"https://github.com/Grant-Lay","followers_url":"https://api.github.com/users/Grant-Lay/followers","following_url":"https://api.github.com/users/Grant-Lay/following{/other_user}","gists_url":"https://api.github.com/users/Grant-Lay/gists{/gist_id}","starred_url":"https://api.github.com/users/Grant-Lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grant-Lay/subscriptions","organizations_url":"https://api.github.com/users/Grant-Lay/orgs","repos_url":"https://api.github.com/users/Grant-Lay/repos","events_url":"https://api.github.com/users/Grant-Lay/events{/privacy}","received_events_url":"https://api.github.com/users/Grant-Lay/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T09:41:40Z","updated_at":"2018-02-20T09:41:40Z","author_association":"CONTRIBUTOR","body":"I discovered that logback wasn't working correctly so have fixed that.  For logging to work correctly on the developers machine add the following property -Dspring.profiles.active=dev.\r\n\r\nFor tomcat in production go to the conf/catalina.properties file and add the following to the end of the file:\r\n\r\n#Custom MARLO properties\r\nspring.profiles.active=pro\r\nmysql.password=the_real_production_password\r\n\r\nSame as above for the test environment but change the property values to:\r\n\r\n#Custom MARLO properties\r\nspring.profiles.active=test\r\nmysql.password=the_real_test_password\r\n\r\n"}}
{"actor":{"display_login":"Grant-Lay"}}