{"action":"created","comment":{"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments/228724035","pull_request_review_id":169067499,"id":228724035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODcyNDAzNQ==","diff_hunk":"@@ -14,6 +14,12 @@\n from MobSF.utils import PrintException, isFileExists\r\n \r\n \r\n+SECURE = \"Secure\"\r\n+IN_SECURE = \"Insecure\"\r\n+INFO = \"Info\"\r\n+WARNING = \"warning\"\r","path":"StaticAnalyzer/views/ios/binary_analysis.py","position":7,"original_position":7,"commit_id":"d277dacf51161f22b13eba13a433e54ce8f28f88","original_commit_id":"d277dacf51161f22b13eba13a433e54ce8f28f88","user":{"login":"ajinabraham","id":4301109,"node_id":"MDQ6VXNlcjQzMDExMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/4301109?v=4","gravatar_id":"","url":"https://api.github.com/users/ajinabraham","html_url":"https://github.com/ajinabraham","followers_url":"https://api.github.com/users/ajinabraham/followers","following_url":"https://api.github.com/users/ajinabraham/following{/other_user}","gists_url":"https://api.github.com/users/ajinabraham/gists{/gist_id}","starred_url":"https://api.github.com/users/ajinabraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajinabraham/subscriptions","organizations_url":"https://api.github.com/users/ajinabraham/orgs","repos_url":"https://api.github.com/users/ajinabraham/repos","events_url":"https://api.github.com/users/ajinabraham/events{/privacy}","received_events_url":"https://api.github.com/users/ajinabraham/received_events","type":"User","site_admin":false},"body":"Use consistent case. `Warning`","created_at":"2018-10-27T19:34:22Z","updated_at":"2018-10-27T19:46:36Z","html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756#discussion_r228724035","pull_request_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments/228724035"},"html":{"href":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756#discussion_r228724035"},"pull_request":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756"}}},"pull_request":{"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756","id":225301929,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzAxOTI5","html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756","diff_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756.diff","patch_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756.patch","issue_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/756","number":756,"state":"open","locked":false,"title":"Increase information in the info.plist file in iOS, change some database column","user":{"login":"magaofei","id":3363787,"node_id":"MDQ6VXNlcjMzNjM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/3363787?v=4","gravatar_id":"","url":"https://api.github.com/users/magaofei","html_url":"https://github.com/magaofei","followers_url":"https://api.github.com/users/magaofei/followers","following_url":"https://api.github.com/users/magaofei/following{/other_user}","gists_url":"https://api.github.com/users/magaofei/gists{/gist_id}","starred_url":"https://api.github.com/users/magaofei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magaofei/subscriptions","organizations_url":"https://api.github.com/users/magaofei/orgs","repos_url":"https://api.github.com/users/magaofei/repos","events_url":"https://api.github.com/users/magaofei/events{/privacy}","received_events_url":"https://api.github.com/users/magaofei/received_events","type":"User","site_admin":false},"body":"Increase information in the info.plist file in iOS, change some database field types.\r\n\r\nI found that some information is missing from the iOS scan results. For example, the version is CFBundleVersion instead of CFBundleShortVersionString. I try to modify and add some information.\r\n\r\nI modified some of the database fields to make the field type smaller, so the performance will be better.\r\n\r\nI don't know whether to add a migrations file or regenerate one based on the original one. Now I have regenerated one.\r\n\r\nI tried to change the structure of some iOS result fields to make it more reasonable.","created_at":"2018-10-24T08:02:53Z","updated_at":"2018-10-27T19:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"620dccb14e14bb8f4a7ebf1bcfa789633f597a25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756/commits","review_comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756/comments","review_comment_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/756/comments","statuses_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/d277dacf51161f22b13eba13a433e54ce8f28f88","head":{"label":"MobSF:ios_plist_content","ref":"ios_plist_content","sha":"d277dacf51161f22b13eba13a433e54ce8f28f88","user":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"repo":{"id":30102273,"node_id":"MDEwOlJlcG9zaXRvcnkzMDEwMjI3Mw==","name":"Mobile-Security-Framework-MobSF","full_name":"MobSF/Mobile-Security-Framework-MobSF","private":false,"owner":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","description":"Mobile Security Framework is an automated, all-in-one mobile application (Android/iOS/Windows) pen-testing framework capable of performing static analysis, dynamic analysis, malware analysis and web API testing.","fork":false,"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF","forks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/forks","keys_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/teams","hooks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/hooks","issue_events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/events{/number}","events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/events","assignees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/assignees{/user}","branches_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/branches{/branch}","tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/tags","blobs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/refs{/sha}","trees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/{sha}","languages_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/languages","stargazers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/stargazers","contributors_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contributors","subscribers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscribers","subscription_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscription","commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/commits{/sha}","git_commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/commits{/sha}","comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/comments{/number}","issue_comment_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/comments{/number}","contents_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contents/{+path}","compare_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/merges","archive_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/downloads","issues_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues{/number}","pulls_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls{/number}","milestones_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/milestones{/number}","notifications_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/labels{/name}","releases_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/releases{/id}","deployments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/deployments","created_at":"2015-01-31T04:36:01Z","updated_at":"2018-10-27T13:36:36Z","pushed_at":"2018-10-27T11:28:32Z","git_url":"git://github.com/MobSF/Mobile-Security-Framework-MobSF.git","ssh_url":"git@github.com:MobSF/Mobile-Security-Framework-MobSF.git","clone_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF.git","svn_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","homepage":"https://opensecurity.in","size":242470,"stargazers_count":3245,"watchers_count":3245,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1070,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1070,"open_issues":14,"watchers":3245,"default_branch":"master"}},"base":{"label":"MobSF:master","ref":"master","sha":"52f7c7308fcde87b4b32994f317b674d67e14686","user":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"repo":{"id":30102273,"node_id":"MDEwOlJlcG9zaXRvcnkzMDEwMjI3Mw==","name":"Mobile-Security-Framework-MobSF","full_name":"MobSF/Mobile-Security-Framework-MobSF","private":false,"owner":{"login":"MobSF","id":25052637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDUyNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/25052637?v=4","gravatar_id":"","url":"https://api.github.com/users/MobSF","html_url":"https://github.com/MobSF","followers_url":"https://api.github.com/users/MobSF/followers","following_url":"https://api.github.com/users/MobSF/following{/other_user}","gists_url":"https://api.github.com/users/MobSF/gists{/gist_id}","starred_url":"https://api.github.com/users/MobSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MobSF/subscriptions","organizations_url":"https://api.github.com/users/MobSF/orgs","repos_url":"https://api.github.com/users/MobSF/repos","events_url":"https://api.github.com/users/MobSF/events{/privacy}","received_events_url":"https://api.github.com/users/MobSF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","description":"Mobile Security Framework is an automated, all-in-one mobile application (Android/iOS/Windows) pen-testing framework capable of performing static analysis, dynamic analysis, malware analysis and web API testing.","fork":false,"url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF","forks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/forks","keys_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/teams","hooks_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/hooks","issue_events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/events{/number}","events_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/events","assignees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/assignees{/user}","branches_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/branches{/branch}","tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/tags","blobs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/refs{/sha}","trees_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/{sha}","languages_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/languages","stargazers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/stargazers","contributors_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contributors","subscribers_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscribers","subscription_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/subscription","commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/commits{/sha}","git_commits_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/git/commits{/sha}","comments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/comments{/number}","issue_comment_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/comments{/number}","contents_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/contents/{+path}","compare_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/merges","archive_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/downloads","issues_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues{/number}","pulls_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls{/number}","milestones_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/milestones{/number}","notifications_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/labels{/name}","releases_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/releases{/id}","deployments_url":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/deployments","created_at":"2015-01-31T04:36:01Z","updated_at":"2018-10-27T13:36:36Z","pushed_at":"2018-10-27T11:28:32Z","git_url":"git://github.com/MobSF/Mobile-Security-Framework-MobSF.git","ssh_url":"git@github.com:MobSF/Mobile-Security-Framework-MobSF.git","clone_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF.git","svn_url":"https://github.com/MobSF/Mobile-Security-Framework-MobSF","homepage":"https://opensecurity.in","size":242470,"stargazers_count":3245,"watchers_count":3245,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1070,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1070,"open_issues":14,"watchers":3245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756"},"html":{"href":"https://github.com/MobSF/Mobile-Security-Framework-MobSF/pull/756"},"issue":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/756"},"comments":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/issues/756/comments"},"review_comments":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756/comments"},"review_comment":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/pulls/756/commits"},"statuses":{"href":"https://api.github.com/repos/MobSF/Mobile-Security-Framework-MobSF/statuses/d277dacf51161f22b13eba13a433e54ce8f28f88"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ajinabraham"}}