{"action":"created","issue":{"url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/524","repository_url":"https://api.github.com/repos/ArduPilot/MAVProxy","labels_url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/524/labels{/name}","comments_url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/524/comments","events_url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/524/events","html_url":"https://github.com/ArduPilot/MAVProxy/pull/524","id":345609849,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjkzMjAz","number":524,"title":"\"arm check foo\" changes","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T04:46:31Z","updated_at":"2018-10-17T17:13:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ArduPilot/MAVProxy/pulls/524","html_url":"https://github.com/ArduPilot/MAVProxy/pull/524","diff_url":"https://github.com/ArduPilot/MAVProxy/pull/524.diff","patch_url":"https://github.com/ArduPilot/MAVProxy/pull/524.patch"},"body":"These changes disambiguate some \"arm check\" uses.\r\n\r\nNow:\r\n`arm check all` - sets ARMING_CHECK to 1 (rather than bits individually)\r\n`arm uncheck all` - sets ARMING_CHECK to 0\r\n`arm uncheck LOGGING` - IF ARMING_CHECK was \"1\", sets it to zero then sets all bits we know about (https://github.com/ArduPilot/MAVProxy/blob/master/MAVProxy/modules/mavproxy_arm.py#L9), *then* sets LOGGING bit to zero.\r\n\r\nIn the third case, I'm wondering if we should set the first 28 bits or so to 1 instead (rather than just the bits we know about), so newer arming checks aren't disabled by `arm uncheck FOO`.\r\n"},"comment":{"url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/comments/430712188","html_url":"https://github.com/ArduPilot/MAVProxy/pull/524#issuecomment-430712188","issue_url":"https://api.github.com/repos/ArduPilot/MAVProxy/issues/524","id":430712188,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDcxMjE4OA==","user":{"login":"OXINARF","id":1778527,"node_id":"MDQ6VXNlcjE3Nzg1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T17:13:11Z","updated_at":"2018-10-17T17:13:11Z","author_association":"MEMBER","body":"> In the third case, I'm wondering if we should set the first 28 bits or so to 1 instead (rather than just the bits we know about), so newer arming checks aren't disabled by arm uncheck FOO.\r\n\r\nI think that makes more sense. As far as I know, it's not an issue on ArduPilot side."}}
{"actor":{"display_login":"OXINARF"}}