{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitica/issues/10826","repository_url":"https://api.github.com/repos/HabitRPG/habitica","labels_url":"https://api.github.com/repos/HabitRPG/habitica/issues/10826/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitica/issues/10826/comments","events_url":"https://api.github.com/repos/HabitRPG/habitica/issues/10826/events","html_url":"https://github.com/HabitRPG/habitica/pull/10826","id":379021630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTg3MjY5","number":10826,"title":"Empty the armory feature","user":{"login":"Arsnael","id":9005025,"node_id":"MDQ6VXNlcjkwMDUwMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9005025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arsnael","html_url":"https://github.com/Arsnael","followers_url":"https://api.github.com/users/Arsnael/followers","following_url":"https://api.github.com/users/Arsnael/following{/other_user}","gists_url":"https://api.github.com/users/Arsnael/gists{/gist_id}","starred_url":"https://api.github.com/users/Arsnael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arsnael/subscriptions","organizations_url":"https://api.github.com/users/Arsnael/orgs","repos_url":"https://api.github.com/users/Arsnael/repos","events_url":"https://api.github.com/users/Arsnael/events{/privacy}","received_events_url":"https://api.github.com/users/Arsnael/received_events","type":"User","site_admin":false},"labels":[{"id":192741463,"node_id":"MDU6TGFiZWwxOTI3NDE0NjM=","url":"https://api.github.com/repos/HabitRPG/habitica/labels/status:%20pr:%20ready%20for%20review","name":"status: pr: ready for review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-11-09T04:46:41Z","updated_at":"2018-11-30T17:33:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitica/pulls/10826","html_url":"https://github.com/HabitRPG/habitica/pull/10826","diff_url":"https://github.com/HabitRPG/habitica/pull/10826.diff","patch_url":"https://github.com/HabitRPG/habitica/pull/10826.patch"},"body":"[//]: # (Note: See http://habitica.wikia.com/wiki/Using_Your_Local_Install_to_Modify_Habitica%27s_Website_and_API for more info)\r\n\r\n[//]: # (Put Issue # here, if applicable. This will automatically close the issue if your PR is merged in)\r\nImplements #7991 (Closes #7991)\r\n\r\n### Changes\r\n[//]: # (Describe the changes that were made in detail here. Include pictures if necessary)\r\nImplemented the 'Empty the armory' feature. I keep the WIP for now as I still need to test it a bit more and write more tests, but as of now it looks quite ok. So you can start checking and also maybe coming up with better text messages for this feature than mine. Here is a list : \r\n\r\n* similar to 'Orb of rebirth', can buy at lvl50 for 2 gems and free at lvl 100,\r\n* resets all equipment,\r\n* has its own achievement,\r\n* when equipment is reset, can buy it back at the market for gold (class none for most of items, normal behavior I guess, I didn't change anything special here),\r\n* no bug with animal ears, thanks to https://github.com/HabitRPG/habitica/issues/10668 (one less issue to tackle^^),\r\n* rebased with recent code (2 days ago).\r\n\r\nWhat's left : \r\n* writing more tests,\r\n* update messages? My guess is I didn't put much thoughts in it yet, and this is something you probably want to change/discuss as well,\r\n* should we add a loading screen tip for this feature too?\r\n* I noticed some v4 implementation in the code lately server side. Should I take it into consideration? Didn't look into it to be honest.\r\n\r\nIf you notice anything else, please report ! And sorry for the delay, been busy lately :)\r\n\r\nSome quick screenshots : \r\n![emptyarmory1](https://user-images.githubusercontent.com/9005025/48243832-0094d480-e415-11e8-94a0-10578bb938cc.png)\r\n![emptyarmory2](https://user-images.githubusercontent.com/9005025/48243836-068ab580-e415-11e8-8dc3-e874ce63ef67.png)\r\n![emptyarmory3](https://user-images.githubusercontent.com/9005025/48243837-08ed0f80-e415-11e8-9933-df4b713438fc.png)\r\n![emptyarmory4](https://user-images.githubusercontent.com/9005025/48243839-0b4f6980-e415-11e8-866e-b4e6fbcb285b.png)\r\n![emptyarmory5](https://user-images.githubusercontent.com/9005025/48243840-0db1c380-e415-11e8-9641-3b76c8d70b4c.png)\r\n\r\n\r\n[//]: # (Put User ID in here - found on the Habitica website at User Icon > Settings > API)\r\n\r\n----\r\nUUID: bbffb2f4-9bf8-46c4-b749-523e2ca93ef6\r\n"},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitica/issues/comments/443279261","html_url":"https://github.com/HabitRPG/habitica/pull/10826#issuecomment-443279261","issue_url":"https://api.github.com/repos/HabitRPG/habitica/issues/10826","id":443279261,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzI3OTI2MQ==","user":{"login":"SabreCat","id":4501321,"node_id":"MDQ6VXNlcjQ1MDEzMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4501321?v=4","gravatar_id":"","url":"https://api.github.com/users/SabreCat","html_url":"https://github.com/SabreCat","followers_url":"https://api.github.com/users/SabreCat/followers","following_url":"https://api.github.com/users/SabreCat/following{/other_user}","gists_url":"https://api.github.com/users/SabreCat/gists{/gist_id}","starred_url":"https://api.github.com/users/SabreCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SabreCat/subscriptions","organizations_url":"https://api.github.com/users/SabreCat/orgs","repos_url":"https://api.github.com/users/SabreCat/repos","events_url":"https://api.github.com/users/SabreCat/events{/privacy}","received_events_url":"https://api.github.com/users/SabreCat/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T17:33:56Z","updated_at":"2018-11-30T17:33:56Z","author_association":"MEMBER","body":"@citrusella I could be mistaken, sorry! We've changed things around so many times with the gear logic I probably got confused. @_@"}}
{"actor":{"display_login":"SabreCat"}}