{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/182480165","pull_request_review_id":113283878,"id":182480165,"diff_hunk":"@@ -361,7 +368,7 @@ export class Overlay extends React.PureComponent<IOverlayProps, IOverlayState> {\n \n         const isClickInThisOverlayOrDescendant = openStack\n             .slice(stackIndex)\n-            .some(({ containerElement }) => containerElement && containerElement.contains(eventTarget));\n+            .some(({ containerElement: elem }) => elem && elem.contains(eventTarget) && !elem.isSameNode(eventTarget));","path":"packages/core/src/components/overlay/overlay.tsx","position":28,"original_position":28,"commit_id":"5e24bcf930d647af10451ce4a507eab9de12c231","original_commit_id":"5e24bcf930d647af10451ce4a507eab9de12c231","user":{"login":"JKillian","id":1400151,"avatar_url":"https://avatars2.githubusercontent.com/u/1400151?v=4","gravatar_id":"","url":"https://api.github.com/users/JKillian","html_url":"https://github.com/JKillian","followers_url":"https://api.github.com/users/JKillian/followers","following_url":"https://api.github.com/users/JKillian/following{/other_user}","gists_url":"https://api.github.com/users/JKillian/gists{/gist_id}","starred_url":"https://api.github.com/users/JKillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JKillian/subscriptions","organizations_url":"https://api.github.com/users/JKillian/orgs","repos_url":"https://api.github.com/users/JKillian/repos","events_url":"https://api.github.com/users/JKillian/events{/privacy}","received_events_url":"https://api.github.com/users/JKillian/received_events","type":"User","site_admin":false},"body":"leave a comment why we need the `isSameNode` check?","created_at":"2018-04-18T15:57:21Z","updated_at":"2018-04-18T15:57:21Z","html_url":"https://github.com/palantir/blueprint/pull/2399#discussion_r182480165","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/2399","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/182480165"},"html":{"href":"https://github.com/palantir/blueprint/pull/2399#discussion_r182480165"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2399"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/2399","id":182316366,"html_url":"https://github.com/palantir/blueprint/pull/2399","diff_url":"https://github.com/palantir/blueprint/pull/2399.diff","patch_url":"https://github.com/palantir/blueprint/pull/2399.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/2399","number":2399,"state":"open","locked":false,"title":"ContextMenu fixes & Overlay didClose","user":{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"#### Fixes #2131, Fixes #803, Fixes #1188 \r\n\r\n#### Changes proposed in this pull request:\r\n\r\nseveral intertwined changes here with some very tricky associated logic. i added unit tests!\r\n\r\n- change `ContextMenu` modifiers such that it won't leave the viewport (instead of window; fixes #803)\r\n- `Overlay` `didClose` and `Popover` `popoverDidClose` lifecycle methods!\r\n    - now possible with `react-transition-group` `onExited` method (did not exist in 1.0)\r\n- remove `ContextMenu` element when the menu closes (using lifecycle method above; fixes #2131)\r\n- fix `Overlay` outside click logic #1188 \r\n","created_at":"2018-04-17T21:58:34Z","updated_at":"2018-04-18T15:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb0394c222b33e86203f0b20eb41df311c75de6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/2399/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/2399/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/2399/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/5e24bcf930d647af10451ce4a507eab9de12c231","head":{"label":"palantir:gg/context-menu","ref":"gg/context-menu","sha":"5e24bcf930d647af10451ce4a507eab9de12c231","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-04-18T15:35:53Z","pushed_at":"2018-04-18T01:33:08Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":63533,"stargazers_count":8994,"watchers_count":8994,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":612,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":612,"open_issues":246,"watchers":8994,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"a2707da8bcb88f7e23ec2317ef9bd67d89fde9a4","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-04-18T15:35:53Z","pushed_at":"2018-04-18T01:33:08Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":63533,"stargazers_count":8994,"watchers_count":8994,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":612,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":612,"open_issues":246,"watchers":8994,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2399"},"html":{"href":"https://github.com/palantir/blueprint/pull/2399"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2399"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2399/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2399/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2399/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/5e24bcf930d647af10451ce4a507eab9de12c231"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JKillian"}}