{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments/170479474","pull_request_review_id":99168472,"id":170479474,"diff_hunk":"@@ -45,6 +45,24 @@ struct ATenCompilationUnitTest : public ::testing::Test {\n   }\n };\n \n+TEST_F(ATenCompilationUnitTest, DISABLED_Concat) {","path":"test/test_execution_engine.cc","position":4,"original_position":4,"commit_id":"8cdae25ed31e9afe4c6433d3f6a71cde9156b8bc","original_commit_id":"8cdae25ed31e9afe4c6433d3f6a71cde9156b8bc","user":{"login":"nicolasvasilache","id":10148468,"avatar_url":"https://avatars3.githubusercontent.com/u/10148468?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasvasilache","html_url":"https://github.com/nicolasvasilache","followers_url":"https://api.github.com/users/nicolasvasilache/followers","following_url":"https://api.github.com/users/nicolasvasilache/following{/other_user}","gists_url":"https://api.github.com/users/nicolasvasilache/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasvasilache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasvasilache/subscriptions","organizations_url":"https://api.github.com/users/nicolasvasilache/orgs","repos_url":"https://api.github.com/users/nicolasvasilache/repos","events_url":"https://api.github.com/users/nicolasvasilache/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasvasilache/received_events","type":"User","site_admin":false},"body":"This is dead code, I see this has been activated in master, still in the future for such cases, please make a test that does something and:\r\n1.  expect the throw / failure that is expected\r\n2. open a proper issue\r\n3. tag the issue in the test as TODO(#number)\r\n\r\nThanks! ","created_at":"2018-02-26T01:45:56Z","updated_at":"2018-02-26T01:45:56Z","html_url":"https://github.com/facebookresearch/TensorComprehensions/pull/17#discussion_r170479474","pull_request_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments/170479474"},"html":{"href":"https://github.com/facebookresearch/TensorComprehensions/pull/17#discussion_r170479474"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17","id":169237677,"html_url":"https://github.com/facebookresearch/TensorComprehensions/pull/17","diff_url":"https://github.com/facebookresearch/TensorComprehensions/pull/17.diff","patch_url":"https://github.com/facebookresearch/TensorComprehensions/pull/17.patch","issue_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/17","number":17,"state":"closed","locked":false,"title":"Add test case for concat operation","user":{"login":"prigoyal","id":13488275,"avatar_url":"https://avatars0.githubusercontent.com/u/13488275?v=4","gravatar_id":"","url":"https://api.github.com/users/prigoyal","html_url":"https://github.com/prigoyal","followers_url":"https://api.github.com/users/prigoyal/followers","following_url":"https://api.github.com/users/prigoyal/following{/other_user}","gists_url":"https://api.github.com/users/prigoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/prigoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prigoyal/subscriptions","organizations_url":"https://api.github.com/users/prigoyal/orgs","repos_url":"https://api.github.com/users/prigoyal/repos","events_url":"https://api.github.com/users/prigoyal/events{/privacy}","received_events_url":"https://api.github.com/users/prigoyal/received_events","type":"User","site_admin":false},"body":"for repro, we should support comparison operators","created_at":"2018-02-14T22:18:30Z","updated_at":"2018-02-26T01:45:56Z","closed_at":"2018-02-14T22:22:47Z","merged_at":"2018-02-14T22:22:47Z","merge_commit_sha":"18c911a00dac08331877fdfe5c7deddaf1dda0dd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ftynse","id":1512299,"avatar_url":"https://avatars1.githubusercontent.com/u/1512299?v=4","gravatar_id":"","url":"https://api.github.com/users/ftynse","html_url":"https://github.com/ftynse","followers_url":"https://api.github.com/users/ftynse/followers","following_url":"https://api.github.com/users/ftynse/following{/other_user}","gists_url":"https://api.github.com/users/ftynse/gists{/gist_id}","starred_url":"https://api.github.com/users/ftynse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftynse/subscriptions","organizations_url":"https://api.github.com/users/ftynse/orgs","repos_url":"https://api.github.com/users/ftynse/repos","events_url":"https://api.github.com/users/ftynse/events{/privacy}","received_events_url":"https://api.github.com/users/ftynse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":829008246,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels/CLA%20Signed","name":"CLA Signed","color":"c2f4fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/17/comments","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/8cdae25ed31e9afe4c6433d3f6a71cde9156b8bc","head":{"label":"facebookresearch:concat-test","ref":"concat-test","sha":"8cdae25ed31e9afe4c6433d3f6a71cde9156b8bc","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":120494252,"name":"TensorComprehensions","full_name":"facebookresearch/TensorComprehensions","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/TensorComprehensions","description":"A domain specific language to express machine learning workloads.","fork":false,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions","forks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/forks","keys_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/teams","hooks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/events","assignees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/tags","blobs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscription","commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/merges","archive_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/downloads","issues_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/deployments","created_at":"2018-02-06T17:11:07Z","updated_at":"2018-02-25T16:32:29Z","pushed_at":"2018-02-24T21:25:37Z","git_url":"git://github.com/facebookresearch/TensorComprehensions.git","ssh_url":"git@github.com:facebookresearch/TensorComprehensions.git","clone_url":"https://github.com/facebookresearch/TensorComprehensions.git","svn_url":"https://github.com/facebookresearch/TensorComprehensions","homepage":"https://facebookresearch.github.io/TensorComprehensions/","size":31267,"stargazers_count":794,"watchers_count":794,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":16,"watchers":794,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"8850eb095dcab27f0352dbee6ed6bd285e437a2a","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":120494252,"name":"TensorComprehensions","full_name":"facebookresearch/TensorComprehensions","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/TensorComprehensions","description":"A domain specific language to express machine learning workloads.","fork":false,"url":"https://api.github.com/repos/facebookresearch/TensorComprehensions","forks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/forks","keys_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/teams","hooks_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/events","assignees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/tags","blobs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/subscription","commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/merges","archive_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/downloads","issues_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/TensorComprehensions/deployments","created_at":"2018-02-06T17:11:07Z","updated_at":"2018-02-25T16:32:29Z","pushed_at":"2018-02-24T21:25:37Z","git_url":"git://github.com/facebookresearch/TensorComprehensions.git","ssh_url":"git@github.com:facebookresearch/TensorComprehensions.git","clone_url":"https://github.com/facebookresearch/TensorComprehensions.git","svn_url":"https://github.com/facebookresearch/TensorComprehensions","homepage":"https://facebookresearch.github.io/TensorComprehensions/","size":31267,"stargazers_count":794,"watchers_count":794,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":55,"open_issues":16,"watchers":794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17"},"html":{"href":"https://github.com/facebookresearch/TensorComprehensions/pull/17"},"issue":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/17"},"comments":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/TensorComprehensions/statuses/8cdae25ed31e9afe4c6433d3f6a71cde9156b8bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicolasvasilache"}}