{"action":"created","comment":{"url":"https://api.github.com/repos/handsontable/handsontable/pulls/comments/171861720","pull_request_review_id":100791920,"id":171861720,"diff_hunk":"@@ -784,6 +784,43 @@ describe('UndoRedo', () => {\n           hot2.destroy();\n           this.$container2.remove();\n         });\n+\n+        it('should return the right amount after undo removal of single column', () => {\n+          const HOT = handsontable({\n+            data: Handsontable.helper.createSpreadsheetData(2, 3)\n+          });\n+\n+          const afterCreateColCallback = jasmine.createSpy('afterCreateColCallback');\n+          HOT.addHook('afterCreateCol', afterCreateColCallback);\n+\n+          expect(countCols()).toEqual(3);\n+          expect(getDataAtCell(0, 0)).toEqual('A1');\n+          expect(getDataAtCell(0, 1)).toEqual('B1');\n+          expect(getDataAtCell(0, 2)).toEqual('C1');\n+          expect(getDataAtCell(1, 0)).toEqual('A2');\n+          expect(getDataAtCell(1, 1)).toEqual('B2');\n+          expect(getDataAtCell(1, 2)).toEqual('C2');\n+\n+          alter('remove_col', 1);\n+\n+          expect(countCols()).toEqual(2);\n+          expect(getDataAtCell(0, 0)).toEqual('A1');\n+          expect(getDataAtCell(0, 1)).toEqual('C1');\n+          expect(getDataAtCell(1, 0)).toEqual('A2');\n+          expect(getDataAtCell(1, 1)).toEqual('C2');\n+\n+          HOT.undo();\n+\n+          expect(afterCreateColCallback).toHaveBeenCalledWith(1, 1, 'UndoRedo.undo', undefined, undefined, undefined);","path":"src/plugins/undoRedo/test/UndoRedo.e2e.js","position":31,"original_position":31,"commit_id":"f62bc8a8221adc6b76964ab64a6138eb1ea8121a","original_commit_id":"f62bc8a8221adc6b76964ab64a6138eb1ea8121a","user":{"login":"jansiegel","id":7397134,"avatar_url":"https://avatars3.githubusercontent.com/u/7397134?v=4","gravatar_id":"","url":"https://api.github.com/users/jansiegel","html_url":"https://github.com/jansiegel","followers_url":"https://api.github.com/users/jansiegel/followers","following_url":"https://api.github.com/users/jansiegel/following{/other_user}","gists_url":"https://api.github.com/users/jansiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/jansiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansiegel/subscriptions","organizations_url":"https://api.github.com/users/jansiegel/orgs","repos_url":"https://api.github.com/users/jansiegel/repos","events_url":"https://api.github.com/users/jansiegel/events{/privacy}","received_events_url":"https://api.github.com/users/jansiegel/received_events","type":"User","site_admin":false},"body":"It might be a better idea to use `void 0` instead of `undefined`, as `undefined` can be easily overwritten by mistake.","created_at":"2018-03-02T14:33:42Z","updated_at":"2018-03-02T14:34:05Z","html_url":"https://github.com/handsontable/handsontable/pull/4890#discussion_r171861720","pull_request_url":"https://api.github.com/repos/handsontable/handsontable/pulls/4890","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/comments/171861720"},"html":{"href":"https://github.com/handsontable/handsontable/pull/4890#discussion_r171861720"},"pull_request":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/4890"}}},"pull_request":{"url":"https://api.github.com/repos/handsontable/handsontable/pulls/4890","id":172505059,"html_url":"https://github.com/handsontable/handsontable/pull/4890","diff_url":"https://github.com/handsontable/handsontable/pull/4890.diff","patch_url":"https://github.com/handsontable/handsontable/pull/4890.patch","issue_url":"https://api.github.com/repos/handsontable/handsontable/issues/4890","number":4890,"state":"open","locked":false,"title":"afterCreateCol returns wrong amount parameter if triggered by undo","user":{"login":"pnowak","id":1555809,"avatar_url":"https://avatars2.githubusercontent.com/u/1555809?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowak","html_url":"https://github.com/pnowak","followers_url":"https://api.github.com/users/pnowak/followers","following_url":"https://api.github.com/users/pnowak/following{/other_user}","gists_url":"https://api.github.com/users/pnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowak/subscriptions","organizations_url":"https://api.github.com/users/pnowak/orgs","repos_url":"https://api.github.com/users/pnowak/repos","events_url":"https://api.github.com/users/pnowak/events{/privacy}","received_events_url":"https://api.github.com/users/pnowak/received_events","type":"User","site_admin":false},"body":"### Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature or improvement (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n### Related issue(s):\r\n1. #4210 \r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project,\r\n- [ ] My change requires a change to the documentation.\r\n","created_at":"2018-03-02T13:40:08Z","updated_at":"2018-03-02T14:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7196af5348116ac6a1f0de1e3aa13b53a27d09a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/handsontable/handsontable/pulls/4890/commits","review_comments_url":"https://api.github.com/repos/handsontable/handsontable/pulls/4890/comments","review_comment_url":"https://api.github.com/repos/handsontable/handsontable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/handsontable/handsontable/issues/4890/comments","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/f62bc8a8221adc6b76964ab64a6138eb1ea8121a","head":{"label":"handsontable:feature/issue-4210","ref":"feature/issue-4210","sha":"f62bc8a8221adc6b76964ab64a6138eb1ea8121a","user":{"login":"handsontable","id":8068250,"avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"repo":{"id":1790564,"name":"handsontable","full_name":"handsontable/handsontable","owner":{"login":"handsontable","id":8068250,"avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/handsontable/handsontable","description":"Handsontable Community Edition - JavaScript/HTML5 Spreadsheet Component for Web Apps","fork":false,"url":"https://api.github.com/repos/handsontable/handsontable","forks_url":"https://api.github.com/repos/handsontable/handsontable/forks","keys_url":"https://api.github.com/repos/handsontable/handsontable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/handsontable/handsontable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/handsontable/handsontable/teams","hooks_url":"https://api.github.com/repos/handsontable/handsontable/hooks","issue_events_url":"https://api.github.com/repos/handsontable/handsontable/issues/events{/number}","events_url":"https://api.github.com/repos/handsontable/handsontable/events","assignees_url":"https://api.github.com/repos/handsontable/handsontable/assignees{/user}","branches_url":"https://api.github.com/repos/handsontable/handsontable/branches{/branch}","tags_url":"https://api.github.com/repos/handsontable/handsontable/tags","blobs_url":"https://api.github.com/repos/handsontable/handsontable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/handsontable/handsontable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/handsontable/handsontable/git/refs{/sha}","trees_url":"https://api.github.com/repos/handsontable/handsontable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/{sha}","languages_url":"https://api.github.com/repos/handsontable/handsontable/languages","stargazers_url":"https://api.github.com/repos/handsontable/handsontable/stargazers","contributors_url":"https://api.github.com/repos/handsontable/handsontable/contributors","subscribers_url":"https://api.github.com/repos/handsontable/handsontable/subscribers","subscription_url":"https://api.github.com/repos/handsontable/handsontable/subscription","commits_url":"https://api.github.com/repos/handsontable/handsontable/commits{/sha}","git_commits_url":"https://api.github.com/repos/handsontable/handsontable/git/commits{/sha}","comments_url":"https://api.github.com/repos/handsontable/handsontable/comments{/number}","issue_comment_url":"https://api.github.com/repos/handsontable/handsontable/issues/comments{/number}","contents_url":"https://api.github.com/repos/handsontable/handsontable/contents/{+path}","compare_url":"https://api.github.com/repos/handsontable/handsontable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/handsontable/handsontable/merges","archive_url":"https://api.github.com/repos/handsontable/handsontable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/handsontable/handsontable/downloads","issues_url":"https://api.github.com/repos/handsontable/handsontable/issues{/number}","pulls_url":"https://api.github.com/repos/handsontable/handsontable/pulls{/number}","milestones_url":"https://api.github.com/repos/handsontable/handsontable/milestones{/number}","notifications_url":"https://api.github.com/repos/handsontable/handsontable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/handsontable/handsontable/labels{/name}","releases_url":"https://api.github.com/repos/handsontable/handsontable/releases{/id}","deployments_url":"https://api.github.com/repos/handsontable/handsontable/deployments","created_at":"2011-05-23T22:38:58Z","updated_at":"2018-03-02T10:59:47Z","pushed_at":"2018-03-02T14:08:14Z","git_url":"git://github.com/handsontable/handsontable.git","ssh_url":"git@github.com:handsontable/handsontable.git","clone_url":"https://github.com/handsontable/handsontable.git","svn_url":"https://github.com/handsontable/handsontable","homepage":"https://handsontable.com","size":52253,"stargazers_count":9417,"watchers_count":9417,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1942,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1942,"open_issues":511,"watchers":9417,"default_branch":"master"}},"base":{"label":"handsontable:develop","ref":"develop","sha":"434019f5f6242cdbe0bb890861d69694893ba94e","user":{"login":"handsontable","id":8068250,"avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"repo":{"id":1790564,"name":"handsontable","full_name":"handsontable/handsontable","owner":{"login":"handsontable","id":8068250,"avatar_url":"https://avatars3.githubusercontent.com/u/8068250?v=4","gravatar_id":"","url":"https://api.github.com/users/handsontable","html_url":"https://github.com/handsontable","followers_url":"https://api.github.com/users/handsontable/followers","following_url":"https://api.github.com/users/handsontable/following{/other_user}","gists_url":"https://api.github.com/users/handsontable/gists{/gist_id}","starred_url":"https://api.github.com/users/handsontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/handsontable/subscriptions","organizations_url":"https://api.github.com/users/handsontable/orgs","repos_url":"https://api.github.com/users/handsontable/repos","events_url":"https://api.github.com/users/handsontable/events{/privacy}","received_events_url":"https://api.github.com/users/handsontable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/handsontable/handsontable","description":"Handsontable Community Edition - JavaScript/HTML5 Spreadsheet Component for Web Apps","fork":false,"url":"https://api.github.com/repos/handsontable/handsontable","forks_url":"https://api.github.com/repos/handsontable/handsontable/forks","keys_url":"https://api.github.com/repos/handsontable/handsontable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/handsontable/handsontable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/handsontable/handsontable/teams","hooks_url":"https://api.github.com/repos/handsontable/handsontable/hooks","issue_events_url":"https://api.github.com/repos/handsontable/handsontable/issues/events{/number}","events_url":"https://api.github.com/repos/handsontable/handsontable/events","assignees_url":"https://api.github.com/repos/handsontable/handsontable/assignees{/user}","branches_url":"https://api.github.com/repos/handsontable/handsontable/branches{/branch}","tags_url":"https://api.github.com/repos/handsontable/handsontable/tags","blobs_url":"https://api.github.com/repos/handsontable/handsontable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/handsontable/handsontable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/handsontable/handsontable/git/refs{/sha}","trees_url":"https://api.github.com/repos/handsontable/handsontable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/handsontable/handsontable/statuses/{sha}","languages_url":"https://api.github.com/repos/handsontable/handsontable/languages","stargazers_url":"https://api.github.com/repos/handsontable/handsontable/stargazers","contributors_url":"https://api.github.com/repos/handsontable/handsontable/contributors","subscribers_url":"https://api.github.com/repos/handsontable/handsontable/subscribers","subscription_url":"https://api.github.com/repos/handsontable/handsontable/subscription","commits_url":"https://api.github.com/repos/handsontable/handsontable/commits{/sha}","git_commits_url":"https://api.github.com/repos/handsontable/handsontable/git/commits{/sha}","comments_url":"https://api.github.com/repos/handsontable/handsontable/comments{/number}","issue_comment_url":"https://api.github.com/repos/handsontable/handsontable/issues/comments{/number}","contents_url":"https://api.github.com/repos/handsontable/handsontable/contents/{+path}","compare_url":"https://api.github.com/repos/handsontable/handsontable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/handsontable/handsontable/merges","archive_url":"https://api.github.com/repos/handsontable/handsontable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/handsontable/handsontable/downloads","issues_url":"https://api.github.com/repos/handsontable/handsontable/issues{/number}","pulls_url":"https://api.github.com/repos/handsontable/handsontable/pulls{/number}","milestones_url":"https://api.github.com/repos/handsontable/handsontable/milestones{/number}","notifications_url":"https://api.github.com/repos/handsontable/handsontable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/handsontable/handsontable/labels{/name}","releases_url":"https://api.github.com/repos/handsontable/handsontable/releases{/id}","deployments_url":"https://api.github.com/repos/handsontable/handsontable/deployments","created_at":"2011-05-23T22:38:58Z","updated_at":"2018-03-02T10:59:47Z","pushed_at":"2018-03-02T14:08:14Z","git_url":"git://github.com/handsontable/handsontable.git","ssh_url":"git@github.com:handsontable/handsontable.git","clone_url":"https://github.com/handsontable/handsontable.git","svn_url":"https://github.com/handsontable/handsontable","homepage":"https://handsontable.com","size":52253,"stargazers_count":9417,"watchers_count":9417,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1942,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1942,"open_issues":511,"watchers":9417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/4890"},"html":{"href":"https://github.com/handsontable/handsontable/pull/4890"},"issue":{"href":"https://api.github.com/repos/handsontable/handsontable/issues/4890"},"comments":{"href":"https://api.github.com/repos/handsontable/handsontable/issues/4890/comments"},"review_comments":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/4890/comments"},"review_comment":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/handsontable/handsontable/pulls/4890/commits"},"statuses":{"href":"https://api.github.com/repos/handsontable/handsontable/statuses/f62bc8a8221adc6b76964ab64a6138eb1ea8121a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jansiegel"}}