{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/186167276","pull_request_review_id":117702572,"id":186167276,"diff_hunk":"@@ -80,6 +83,14 @@ NoKnockback: Monsters will be immune to Knockback's.\n Random Target: Picks a new random target in range on each attack / skill.\n \t(not implemented)\n \n+No Random Walk: Monsters will not randomly walk around during idle state.","path":"doc/mob_db_mode_list.txt","position":48,"original_position":48,"commit_id":"e9d1108631da9467166f80eefaa5e9a65cc6e5f9","original_commit_id":"e9d1108631da9467166f80eefaa5e9a65cc6e5f9","user":{"login":"AnnieRuru","id":6211477,"avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"body":"no random walk and no cast skill is official, I can quite confirm this is in wave dungeon\r\nhttps://irowiki.org/wiki/Wave_Mode\r\nhowever can attack mob is unofficial ...\r\nso just add (unofficial) ?","created_at":"2018-05-04T17:51:03Z","updated_at":"2018-05-04T17:51:04Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2031#discussion_r186167276","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/186167276"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2031#discussion_r186167276"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031"}},"in_reply_to_id":186129197},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031","id":185995220,"html_url":"https://github.com/HerculesWS/Hercules/pull/2031","diff_url":"https://github.com/HerculesWS/Hercules/pull/2031.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2031.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2031","number":2031,"state":"open","locked":false,"title":"Add MD_NORANDOM_WALK, MD_NOCAST_SKILL & MD_CANATTACK_MOB monster mode flag","user":{"login":"AnnieRuru","id":6211477,"avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"body":"### Pull Request Prelude\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n### Issues addressed\r\nThis is part of unit controller script commands -> https://github.com/HerculesWS/Hercules/issues/998\r\n### Changes Proposed\r\nAdd **MD_NORANDOM_WALK**, **MD_NOCAST_SKILL** & **MD_CANATTACK_MOB** monster mode flag\r\n\r\n### Affected Branches\r\n* Master\r\n\r\n### Tested with\r\n```\r\nprontera,155,185,5\tscript\tjskdhfjshfd\t1_F_MARIA,{\r\n\tif ( .monster_a || .monster_b ) end;\r\n\t.monster_a = monster( \"this\", -1,-1, \"monster A\", PORING,1, strnpcinfo(3)+\"::Onaaa\" );\r\n\t.monster_b = monster( \"this\", -1,-1, \"monster B\", PORING,1, strnpcinfo(3)+\"::Onbbb\" );\r\n//\tsetunitdata .monster_a, UDT_MODE, getunitdata(.monster_a, UDT_MODE) | (MD_AGGRESSIVE|MD_CANATTACK|MD_CANATTACK_MOB);\r\n//\tsetunitdata .monster_b, UDT_MODE, getunitdata(.monster_b, UDT_MODE) | (MD_CANATTACK|MD_CANATTACK_MOB);\r\n//\tsetunitdata .monster_b, UDT_MODE, getunitdata(.monster_b, UDT_MODE) | (MD_CANATTACK);\r\n//\tsetunitdata .monster_b, UDT_MODE, getunitdata(.monster_b, UDT_MODE) | (MD_NORANDOM_WALK);\r\n//\tsetunitdata .monster_b, UDT_MODE, getunitdata(.monster_b, UDT_MODE) | (MD_NORANDOM_WALK);\r\n\t\r\n\t.monster_c = monster( \"this\", -1,-1, \"monster C\", G_KATRINN,1, strnpcinfo(3)+\"::Onccc\" );\r\n\tsetunitdata .monster_c, UDT_MODE, getunitdata(.monster_c, UDT_MODE) | (MD_NOCAST_SKILL);\r\n\tend;\r\nOnaaa:\r\n\t.monster_a = 0;\r\n\tend;\r\nOnbbb:\r\n\t.monster_b = 0;\r\n\tend;\r\nOnccc:\r\n\t.monster_c = 0;\r\n\tend;\r\n}\r\n```\r\n```\r\nprontera\tmapflag\tbattleground\r\nprontera,155,185,5\tscript\tjskdhfjshfd\t1_F_MARIA,{\r\n\tif ( getcharid(4) ) bg_leave;\r\n\t.@test = bg_create_team( .map$, .x, .y );\r\n\tbg_join_team .@test;\r\n\tdispbottom getcharid(4) +\"\";\r\n\tbg_monster 0, .map$, .x +1, .y, \"--ja--\", 1001, strnpcinfo(3) +\"::Onaaa\";\r\n\t.@a = bg_monster(0, .map$, .x +2, .y, \"--ja--\", 1001, strnpcinfo(3) +\"::Onaaa\");\r\n\t.@b = bg_monster(.@test, .map$, .x +3, .y, \"--ja--\", 1001, strnpcinfo(3) +\"::Onaaa\");\r\n\t.@c = bg_monster(.@test, .map$, .x +4, .y, \"--ja--\", 1001, strnpcinfo(3) +\"::Onaaa\");\r\n\tsetunitdata .@a, UDT_MODE, getunitdata(.@a, UDT_MODE) | (MD_AGGRESSIVE|MD_CANATTACK|MD_CANATTACK_MOB);\r\n\tsetunitdata .@b, UDT_MODE, getunitdata(.@b, UDT_MODE) | (MD_AGGRESSIVE|MD_CANATTACK|MD_CANATTACK_MOB);\r\n\tsetunitdata .@c, UDT_MODE, getunitdata(.@c, UDT_MODE) | (MD_AGGRESSIVE|MD_CANATTACK|MD_CANATTACK_MOB);\r\n\tend;\r\nOnaaa:\r\n\tend;\r\nOnInit:\r\n\tgetmapxy .map$, .x, .y, UNITTYPE_NPC;\r\n\t.x += 2;\r\n\tend;\r\n}\r\n```\r\n### Known Issues and TODO List\r\nis it true that bg_monster spawn inside battleground map, the monster will follow you around ?\r\nboth rathena and hercules has this behavior","created_at":"2018-05-04T14:10:07Z","updated_at":"2018-05-04T17:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bba7a24c0c01ce6ccdae7451c23418526810eb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":48712198,"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:core","name":"component:core","color":"803050","default":false},{"id":287787453,"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:core:scriptengine","name":"component:core:scriptengine","color":"803050","default":false},{"id":264336620,"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/status:code-review","name":"status:code-review","color":"bfe5bf","default":false},{"id":24494842,"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/type:enhancement","name":"type:enhancement","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2031/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/e9d1108631da9467166f80eefaa5e9a65cc6e5f9","head":{"label":"AnnieRuru:33-MD_CANATTACK_MOB","ref":"33-MD_CANATTACK_MOB","sha":"e9d1108631da9467166f80eefaa5e9a65cc6e5f9","user":{"login":"AnnieRuru","id":6211477,"avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"repo":{"id":17571108,"name":"Hercules","full_name":"AnnieRuru/Hercules","owner":{"login":"AnnieRuru","id":6211477,"avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnnieRuru/Hercules","description":null,"fork":true,"url":"https://api.github.com/repos/AnnieRuru/Hercules","forks_url":"https://api.github.com/repos/AnnieRuru/Hercules/forks","keys_url":"https://api.github.com/repos/AnnieRuru/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnnieRuru/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnnieRuru/Hercules/teams","hooks_url":"https://api.github.com/repos/AnnieRuru/Hercules/hooks","issue_events_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/AnnieRuru/Hercules/events","assignees_url":"https://api.github.com/repos/AnnieRuru/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/AnnieRuru/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/AnnieRuru/Hercules/tags","blobs_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnnieRuru/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/AnnieRuru/Hercules/languages","stargazers_url":"https://api.github.com/repos/AnnieRuru/Hercules/stargazers","contributors_url":"https://api.github.com/repos/AnnieRuru/Hercules/contributors","subscribers_url":"https://api.github.com/repos/AnnieRuru/Hercules/subscribers","subscription_url":"https://api.github.com/repos/AnnieRuru/Hercules/subscription","commits_url":"https://api.github.com/repos/AnnieRuru/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnnieRuru/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnnieRuru/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/AnnieRuru/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnnieRuru/Hercules/merges","archive_url":"https://api.github.com/repos/AnnieRuru/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnnieRuru/Hercules/downloads","issues_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/AnnieRuru/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/AnnieRuru/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/AnnieRuru/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnnieRuru/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/AnnieRuru/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/AnnieRuru/Hercules/deployments","created_at":"2014-03-09T18:52:55Z","updated_at":"2018-05-04T07:08:48Z","pushed_at":"2018-05-04T13:52:25Z","git_url":"git://github.com/AnnieRuru/Hercules.git","ssh_url":"git@github.com:AnnieRuru/Hercules.git","clone_url":"https://github.com/AnnieRuru/Hercules.git","svn_url":"https://github.com/AnnieRuru/Hercules","homepage":"http://hercules.ws","size":156320,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"d6785d389cbee4f34078f6762626ca61b2d6cc25","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2018-05-04T07:12:31Z","pushed_at":"2018-05-04T15:13:17Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":177546,"stargazers_count":413,"watchers_count":413,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":530,"mirror_url":null,"archived":false,"open_issues_count":409,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":530,"open_issues":409,"watchers":413,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2031"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2031"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2031/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2031/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/e9d1108631da9467166f80eefaa5e9a65cc6e5f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AnnieRuru"}}