{"action":"created","issue":{"url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/20","repository_url":"https://api.github.com/repos/astefanutti/metrics-cdi","labels_url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/20/comments","events_url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/20/events","html_url":"https://github.com/astefanutti/metrics-cdi/pull/20","id":292334395,"number":20,"title":"allow to configure Reservoir implementations","user":{"login":"McFoggy","id":1119660,"avatar_url":"https://avatars2.githubusercontent.com/u/1119660?v=4","gravatar_id":"","url":"https://api.github.com/users/McFoggy","html_url":"https://github.com/McFoggy","followers_url":"https://api.github.com/users/McFoggy/followers","following_url":"https://api.github.com/users/McFoggy/following{/other_user}","gists_url":"https://api.github.com/users/McFoggy/gists{/gist_id}","starred_url":"https://api.github.com/users/McFoggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McFoggy/subscriptions","organizations_url":"https://api.github.com/users/McFoggy/orgs","repos_url":"https://api.github.com/users/McFoggy/repos","events_url":"https://api.github.com/users/McFoggy/events{/privacy}","received_events_url":"https://api.github.com/users/McFoggy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-01-29T09:20:23Z","updated_at":"2018-02-19T10:31:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/astefanutti/metrics-cdi/pulls/20","html_url":"https://github.com/astefanutti/metrics-cdi/pull/20","diff_url":"https://github.com/astefanutti/metrics-cdi/pull/20.diff","patch_url":"https://github.com/astefanutti/metrics-cdi/pull/20.patch"},"body":"simple enhancement of MetricsConfiguration class to be able to register a ReservoirBuilder class allowing for specific Reservoir instances to be used in produced Timer & Histogram"},"comment":{"url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/comments/366648763","html_url":"https://github.com/astefanutti/metrics-cdi/pull/20#issuecomment-366648763","issue_url":"https://api.github.com/repos/astefanutti/metrics-cdi/issues/20","id":366648763,"user":{"login":"astefanutti","id":366207,"avatar_url":"https://avatars0.githubusercontent.com/u/366207?v=4","gravatar_id":"","url":"https://api.github.com/users/astefanutti","html_url":"https://github.com/astefanutti","followers_url":"https://api.github.com/users/astefanutti/followers","following_url":"https://api.github.com/users/astefanutti/following{/other_user}","gists_url":"https://api.github.com/users/astefanutti/gists{/gist_id}","starred_url":"https://api.github.com/users/astefanutti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astefanutti/subscriptions","organizations_url":"https://api.github.com/users/astefanutti/orgs","repos_url":"https://api.github.com/users/astefanutti/repos","events_url":"https://api.github.com/users/astefanutti/events{/privacy}","received_events_url":"https://api.github.com/users/astefanutti/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T10:31:08Z","updated_at":"2018-02-19T10:31:08Z","author_association":"OWNER","body":"@McFoggy \r\n\r\n> I have adapted a bit the PR to integrate your remarks.\r\n\r\nThanks a lot. That looks great!\r\n\r\n> I have not changed:\r\n> \r\n> the EnumeSet into EnumMap: I can do it if you think it is required\r\n\r\nI can do it, no big deal.\r\n\r\n> the tests to make them functional: here honestly I do not understand why a technical test like the one provided is not enough to ensure that the functionnality is correctly used ; imho in this situation writing a dedicated ReservoirBuilder building \"functionally testable\" Reservoirs would be far more work than what is required and provided by the PR to ensure the correctness.\r\n\r\nIt's more a matter of style and I appreciate that this is going to be a lot more work in that case. So that's perfectly ok."}}
{"actor":{"display_login":"astefanutti"}}