{"action":"created","comment":{"url":"https://api.github.com/repos/r-lib/devtools/pulls/comments/169447610","pull_request_review_id":97975254,"id":169447610,"diff_hunk":"@@ -77,6 +79,11 @@ check <- function(pkg = \".\",\n     warning(\"`cleanup` is deprecated\", call. = FALSE)\n   }\n \n+  if (missing(error_on) && !interactive()) {","path":"R/check.r","position":15,"original_position":15,"commit_id":"f63c5b2da380ea8756b01dcf55515d74e931ceb4","original_commit_id":"e89ae0d6e7c3a9bb7727c1d8849a48b4e0ff43c6","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars3.githubusercontent.com/u/205275?v=4","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"FWIW I generally think you _should_ default to the first argument, just because that is the normal convention. In this particular case I wanted to have different default behavior when run non-interactively, so needed to do this.\r\n\r\nMaybe I should have used `error_on = NULL` so could have had the logic only in one place rather than two, I am not sure...","created_at":"2018-02-20T20:24:14Z","updated_at":"2018-02-20T20:24:14Z","html_url":"https://github.com/r-lib/devtools/pull/1713#discussion_r169447610","pull_request_url":"https://api.github.com/repos/r-lib/devtools/pulls/1713","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/comments/169447610"},"html":{"href":"https://github.com/r-lib/devtools/pull/1713#discussion_r169447610"},"pull_request":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/1713"}},"in_reply_to_id":169433984},"pull_request":{"url":"https://api.github.com/repos/r-lib/devtools/pulls/1713","id":170282274,"html_url":"https://github.com/r-lib/devtools/pull/1713","diff_url":"https://github.com/r-lib/devtools/pull/1713.diff","patch_url":"https://github.com/r-lib/devtools/pull/1713.patch","issue_url":"https://api.github.com/repos/r-lib/devtools/issues/1713","number":1713,"state":"open","locked":false,"title":"Add an error_on argument to check and check_built","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars3.githubusercontent.com/u/205275?v=4","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/rstudio/rstudio/issues/2235","created_at":"2018-02-20T19:11:57Z","updated_at":"2018-02-20T20:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f867573046161d40f468450dbcdcfd4e5cee179","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/r-lib/devtools/pulls/1713/commits","review_comments_url":"https://api.github.com/repos/r-lib/devtools/pulls/1713/comments","review_comment_url":"https://api.github.com/repos/r-lib/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r-lib/devtools/issues/1713/comments","statuses_url":"https://api.github.com/repos/r-lib/devtools/statuses/f63c5b2da380ea8756b01dcf55515d74e931ceb4","head":{"label":"jimhester:error_on","ref":"error_on","sha":"f63c5b2da380ea8756b01dcf55515d74e931ceb4","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars3.githubusercontent.com/u/205275?v=4","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":25137194,"name":"devtools","full_name":"jimhester/devtools","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars3.githubusercontent.com/u/205275?v=4","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/devtools","description":"Tools to make an R developer's life easier","fork":true,"url":"https://api.github.com/repos/jimhester/devtools","forks_url":"https://api.github.com/repos/jimhester/devtools/forks","keys_url":"https://api.github.com/repos/jimhester/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/devtools/teams","hooks_url":"https://api.github.com/repos/jimhester/devtools/hooks","issue_events_url":"https://api.github.com/repos/jimhester/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/devtools/events","assignees_url":"https://api.github.com/repos/jimhester/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/devtools/tags","blobs_url":"https://api.github.com/repos/jimhester/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/devtools/languages","stargazers_url":"https://api.github.com/repos/jimhester/devtools/stargazers","contributors_url":"https://api.github.com/repos/jimhester/devtools/contributors","subscribers_url":"https://api.github.com/repos/jimhester/devtools/subscribers","subscription_url":"https://api.github.com/repos/jimhester/devtools/subscription","commits_url":"https://api.github.com/repos/jimhester/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimhester/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/devtools/merges","archive_url":"https://api.github.com/repos/jimhester/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/devtools/downloads","issues_url":"https://api.github.com/repos/jimhester/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/devtools/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/jimhester/devtools/deployments","created_at":"2014-10-13T00:56:25Z","updated_at":"2017-05-21T13:55:50Z","pushed_at":"2018-02-20T20:21:30Z","git_url":"git://github.com/jimhester/devtools.git","ssh_url":"git@github.com:jimhester/devtools.git","clone_url":"https://github.com/jimhester/devtools.git","svn_url":"https://github.com/jimhester/devtools","homepage":"","size":4154,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"r-lib:master","ref":"master","sha":"50d2dee67922e304f494e2d5ffb1c5e61aa8e860","user":{"login":"r-lib","id":22618716,"avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"repo":{"id":643909,"name":"devtools","full_name":"r-lib/devtools","owner":{"login":"r-lib","id":22618716,"avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/r-lib/devtools","description":"Tools to make an R developer's life easier","fork":false,"url":"https://api.github.com/repos/r-lib/devtools","forks_url":"https://api.github.com/repos/r-lib/devtools/forks","keys_url":"https://api.github.com/repos/r-lib/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r-lib/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r-lib/devtools/teams","hooks_url":"https://api.github.com/repos/r-lib/devtools/hooks","issue_events_url":"https://api.github.com/repos/r-lib/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/r-lib/devtools/events","assignees_url":"https://api.github.com/repos/r-lib/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/r-lib/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/r-lib/devtools/tags","blobs_url":"https://api.github.com/repos/r-lib/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r-lib/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r-lib/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/r-lib/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r-lib/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/r-lib/devtools/languages","stargazers_url":"https://api.github.com/repos/r-lib/devtools/stargazers","contributors_url":"https://api.github.com/repos/r-lib/devtools/contributors","subscribers_url":"https://api.github.com/repos/r-lib/devtools/subscribers","subscription_url":"https://api.github.com/repos/r-lib/devtools/subscription","commits_url":"https://api.github.com/repos/r-lib/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/r-lib/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/r-lib/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/r-lib/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/r-lib/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/r-lib/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r-lib/devtools/merges","archive_url":"https://api.github.com/repos/r-lib/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r-lib/devtools/downloads","issues_url":"https://api.github.com/repos/r-lib/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/r-lib/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/r-lib/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/r-lib/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r-lib/devtools/labels{/name}","releases_url":"https://api.github.com/repos/r-lib/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/r-lib/devtools/deployments","created_at":"2010-05-03T04:08:49Z","updated_at":"2018-02-18T23:28:02Z","pushed_at":"2018-02-20T20:21:32Z","git_url":"git://github.com/r-lib/devtools.git","ssh_url":"git@github.com:r-lib/devtools.git","clone_url":"https://github.com/r-lib/devtools.git","svn_url":"https://github.com/r-lib/devtools","homepage":"","size":4107,"stargazers_count":1616,"watchers_count":1616,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":569,"open_issues":20,"watchers":1616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/1713"},"html":{"href":"https://github.com/r-lib/devtools/pull/1713"},"issue":{"href":"https://api.github.com/repos/r-lib/devtools/issues/1713"},"comments":{"href":"https://api.github.com/repos/r-lib/devtools/issues/1713/comments"},"review_comments":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/1713/comments"},"review_comment":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r-lib/devtools/pulls/1713/commits"},"statuses":{"href":"https://api.github.com/repos/r-lib/devtools/statuses/f63c5b2da380ea8756b01dcf55515d74e931ceb4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jimhester"}}