{"action":"created","issue":{"url":"https://api.github.com/repos/nanograv/PINT/issues/407","repository_url":"https://api.github.com/repos/nanograv/PINT","labels_url":"https://api.github.com/repos/nanograv/PINT/issues/407/labels{/name}","comments_url":"https://api.github.com/repos/nanograv/PINT/issues/407/comments","events_url":"https://api.github.com/repos/nanograv/PINT/issues/407/events","html_url":"https://github.com/nanograv/PINT/pull/407","id":347427894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDU0Nzg0","number":407,"title":"Basic Solar Wind Dispersion Model","user":{"login":"jcolen","id":25908365,"node_id":"MDQ6VXNlcjI1OTA4MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/25908365?v=4","gravatar_id":"","url":"https://api.github.com/users/jcolen","html_url":"https://github.com/jcolen","followers_url":"https://api.github.com/users/jcolen/followers","following_url":"https://api.github.com/users/jcolen/following{/other_user}","gists_url":"https://api.github.com/users/jcolen/gists{/gist_id}","starred_url":"https://api.github.com/users/jcolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcolen/subscriptions","organizations_url":"https://api.github.com/users/jcolen/orgs","repos_url":"https://api.github.com/users/jcolen/repos","events_url":"https://api.github.com/users/jcolen/events{/privacy}","received_events_url":"https://api.github.com/users/jcolen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-03T14:53:17Z","updated_at":"2018-08-07T16:33:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nanograv/PINT/pulls/407","html_url":"https://github.com/nanograv/PINT/pull/407","diff_url":"https://github.com/nanograv/PINT/pull/407.diff","patch_url":"https://github.com/nanograv/PINT/pull/407.patch"},"body":"Basic implementation of solar wind model, as discussed in Issue #291 "},"comment":{"url":"https://api.github.com/repos/nanograv/PINT/issues/comments/411120268","html_url":"https://github.com/nanograv/PINT/pull/407#issuecomment-411120268","issue_url":"https://api.github.com/repos/nanograv/PINT/issues/407","id":411120268,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTEyMDI2OA==","user":{"login":"luojing1211","id":5324931,"node_id":"MDQ6VXNlcjUzMjQ5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5324931?v=4","gravatar_id":"","url":"https://api.github.com/users/luojing1211","html_url":"https://github.com/luojing1211","followers_url":"https://api.github.com/users/luojing1211/followers","following_url":"https://api.github.com/users/luojing1211/following{/other_user}","gists_url":"https://api.github.com/users/luojing1211/gists{/gist_id}","starred_url":"https://api.github.com/users/luojing1211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luojing1211/subscriptions","organizations_url":"https://api.github.com/users/luojing1211/orgs","repos_url":"https://api.github.com/users/luojing1211/repos","events_url":"https://api.github.com/users/luojing1211/events{/privacy}","received_events_url":"https://api.github.com/users/luojing1211/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T16:33:30Z","updated_at":"2018-08-07T16:33:30Z","author_association":"MEMBER","body":"That is a good point. I can modify the diapers on base class a little bit\nto make resolve the conflict.\n\n\n-Jing\nOn Tue, Aug 7, 2018 at 11:03 AM jcolen <notifications@github.com> wrote:\n\n> I re-implemented the subclass approach, creating a new class extending\n> Dispersion with the changed category attribute to allow for multiple types\n> of Dispersion delay at once. There still exists an issue when using\n> parfiles with both DMX and SWM. Both DispersionDMX and SolarWindDispersion\n> require the DM parameter, and after the components are created, the model\n> has two copies of DM. One of them is always the value given in the parfile,\n> and the other is always zero (the default value). This creates issues when\n> fitting, because one of the components always starts off with the wrong DM\n> value which leads to bad results.\n>\n> Does anybody know of a way to consolidate the two DM parameter objects,\n> given the current structure of the Python code? The best solution I can\n> think of would be to change model_builder and timing_model.read_parfile so\n> that parameters are created from each parfile line and then components are\n> given pointers to those parameters (to ensure that each component\n> references the same object), but this would require a major rewrite and\n> Python is a bit weird with pointers.\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/nanograv/PINT/pull/407#issuecomment-411109971>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AFFAg8uqA35F1oqDIV85yprcT7h08SEJks5uObo0gaJpZM4VuIdY>\n> .\n>\n"}}
{"actor":{"display_login":"luojing1211"}}