{"action":"closed","number":154,"pull_request":{"url":"https://api.github.com/repos/amberframework/granite-orm/pulls/154","id":171514145,"html_url":"https://github.com/amberframework/granite-orm/pull/154","diff_url":"https://github.com/amberframework/granite-orm/pull/154.diff","patch_url":"https://github.com/amberframework/granite-orm/pull/154.patch","issue_url":"https://api.github.com/repos/amberframework/granite-orm/issues/154","number":154,"state":"closed","locked":false,"title":"add spec for callbacks","user":{"login":"maiha","id":12258,"avatar_url":"https://avatars3.githubusercontent.com/u/12258?v=4","gravatar_id":"","url":"https://api.github.com/users/maiha","html_url":"https://github.com/maiha","followers_url":"https://api.github.com/users/maiha/followers","following_url":"https://api.github.com/users/maiha/following{/other_user}","gists_url":"https://api.github.com/users/maiha/gists{/gist_id}","starred_url":"https://api.github.com/users/maiha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maiha/subscriptions","organizations_url":"https://api.github.com/users/maiha/orgs","repos_url":"https://api.github.com/users/maiha/repos","events_url":"https://api.github.com/users/maiha/events{/privacy}","received_events_url":"https://api.github.com/users/maiha/received_events","type":"User","site_admin":false},"body":"https://github.com/amberframework/granite-orm/pull/153#discussion_r170689455\r\n> an exception thrown in a hook will get swallowed\r\n\r\nThis PR explicitly specifies why `DB::Error` is rescued in `#save`. After this PR, we can detect #153 is well regressed. 😄 \r\n\r\nIn addition, this also ensures the callbacks are fired and its order.\r\nBest regard,","created_at":"2018-02-26T22:46:44Z","updated_at":"2018-03-26T20:44:04Z","closed_at":"2018-03-26T20:44:04Z","merged_at":"2018-03-26T20:44:04Z","merge_commit_sha":"f7977996e97c09fe6508290f5dd462b399b138a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":870698503,"url":"https://api.github.com/repos/amberframework/granite-orm/labels/pr:needs-review","name":"pr:needs-review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/amberframework/granite-orm/pulls/154/commits","review_comments_url":"https://api.github.com/repos/amberframework/granite-orm/pulls/154/comments","review_comment_url":"https://api.github.com/repos/amberframework/granite-orm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amberframework/granite-orm/issues/154/comments","statuses_url":"https://api.github.com/repos/amberframework/granite-orm/statuses/03aa3c7b0a61a710652d53d426c1db6bdb221336","head":{"label":"maiha:spec-callbacks","ref":"spec-callbacks","sha":"03aa3c7b0a61a710652d53d426c1db6bdb221336","user":{"login":"maiha","id":12258,"avatar_url":"https://avatars3.githubusercontent.com/u/12258?v=4","gravatar_id":"","url":"https://api.github.com/users/maiha","html_url":"https://github.com/maiha","followers_url":"https://api.github.com/users/maiha/followers","following_url":"https://api.github.com/users/maiha/following{/other_user}","gists_url":"https://api.github.com/users/maiha/gists{/gist_id}","starred_url":"https://api.github.com/users/maiha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maiha/subscriptions","organizations_url":"https://api.github.com/users/maiha/orgs","repos_url":"https://api.github.com/users/maiha/repos","events_url":"https://api.github.com/users/maiha/events{/privacy}","received_events_url":"https://api.github.com/users/maiha/received_events","type":"User","site_admin":false},"repo":{"id":112625345,"name":"granite-orm","full_name":"maiha/granite-orm","owner":{"login":"maiha","id":12258,"avatar_url":"https://avatars3.githubusercontent.com/u/12258?v=4","gravatar_id":"","url":"https://api.github.com/users/maiha","html_url":"https://github.com/maiha","followers_url":"https://api.github.com/users/maiha/followers","following_url":"https://api.github.com/users/maiha/following{/other_user}","gists_url":"https://api.github.com/users/maiha/gists{/gist_id}","starred_url":"https://api.github.com/users/maiha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maiha/subscriptions","organizations_url":"https://api.github.com/users/maiha/orgs","repos_url":"https://api.github.com/users/maiha/repos","events_url":"https://api.github.com/users/maiha/events{/privacy}","received_events_url":"https://api.github.com/users/maiha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maiha/granite-orm","description":"Difference from original: support fast-spec, record-statuses, natural keys.","fork":true,"url":"https://api.github.com/repos/maiha/granite-orm","forks_url":"https://api.github.com/repos/maiha/granite-orm/forks","keys_url":"https://api.github.com/repos/maiha/granite-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maiha/granite-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maiha/granite-orm/teams","hooks_url":"https://api.github.com/repos/maiha/granite-orm/hooks","issue_events_url":"https://api.github.com/repos/maiha/granite-orm/issues/events{/number}","events_url":"https://api.github.com/repos/maiha/granite-orm/events","assignees_url":"https://api.github.com/repos/maiha/granite-orm/assignees{/user}","branches_url":"https://api.github.com/repos/maiha/granite-orm/branches{/branch}","tags_url":"https://api.github.com/repos/maiha/granite-orm/tags","blobs_url":"https://api.github.com/repos/maiha/granite-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maiha/granite-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maiha/granite-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/maiha/granite-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maiha/granite-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/maiha/granite-orm/languages","stargazers_url":"https://api.github.com/repos/maiha/granite-orm/stargazers","contributors_url":"https://api.github.com/repos/maiha/granite-orm/contributors","subscribers_url":"https://api.github.com/repos/maiha/granite-orm/subscribers","subscription_url":"https://api.github.com/repos/maiha/granite-orm/subscription","commits_url":"https://api.github.com/repos/maiha/granite-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/maiha/granite-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/maiha/granite-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/maiha/granite-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/maiha/granite-orm/contents/{+path}","compare_url":"https://api.github.com/repos/maiha/granite-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maiha/granite-orm/merges","archive_url":"https://api.github.com/repos/maiha/granite-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maiha/granite-orm/downloads","issues_url":"https://api.github.com/repos/maiha/granite-orm/issues{/number}","pulls_url":"https://api.github.com/repos/maiha/granite-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/maiha/granite-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/maiha/granite-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maiha/granite-orm/labels{/name}","releases_url":"https://api.github.com/repos/maiha/granite-orm/releases{/id}","deployments_url":"https://api.github.com/repos/maiha/granite-orm/deployments","created_at":"2017-11-30T15:08:05Z","updated_at":"2018-02-27T22:27:09Z","pushed_at":"2018-02-27T22:26:03Z","git_url":"git://github.com/maiha/granite-orm.git","ssh_url":"git@github.com:maiha/granite-orm.git","clone_url":"https://github.com/maiha/granite-orm.git","svn_url":"https://github.com/maiha/granite-orm","homepage":"","size":584,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amberframework:master","ref":"master","sha":"719d2e58c207ef55f150bca433585aa195bdf440","user":{"login":"amberframework","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amberframework","html_url":"https://github.com/amberframework","followers_url":"https://api.github.com/users/amberframework/followers","following_url":"https://api.github.com/users/amberframework/following{/other_user}","gists_url":"https://api.github.com/users/amberframework/gists{/gist_id}","starred_url":"https://api.github.com/users/amberframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberframework/subscriptions","organizations_url":"https://api.github.com/users/amberframework/orgs","repos_url":"https://api.github.com/users/amberframework/repos","events_url":"https://api.github.com/users/amberframework/events{/privacy}","received_events_url":"https://api.github.com/users/amberframework/received_events","type":"Organization","site_admin":false},"repo":{"id":41196214,"name":"granite-orm","full_name":"amberframework/granite-orm","owner":{"login":"amberframework","id":27691024,"avatar_url":"https://avatars1.githubusercontent.com/u/27691024?v=4","gravatar_id":"","url":"https://api.github.com/users/amberframework","html_url":"https://github.com/amberframework","followers_url":"https://api.github.com/users/amberframework/followers","following_url":"https://api.github.com/users/amberframework/following{/other_user}","gists_url":"https://api.github.com/users/amberframework/gists{/gist_id}","starred_url":"https://api.github.com/users/amberframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberframework/subscriptions","organizations_url":"https://api.github.com/users/amberframework/orgs","repos_url":"https://api.github.com/users/amberframework/repos","events_url":"https://api.github.com/users/amberframework/events{/privacy}","received_events_url":"https://api.github.com/users/amberframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amberframework/granite-orm","description":"ORM Model with Adapters for mysql, pg, sqlite in the Crystal Language.","fork":false,"url":"https://api.github.com/repos/amberframework/granite-orm","forks_url":"https://api.github.com/repos/amberframework/granite-orm/forks","keys_url":"https://api.github.com/repos/amberframework/granite-orm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amberframework/granite-orm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amberframework/granite-orm/teams","hooks_url":"https://api.github.com/repos/amberframework/granite-orm/hooks","issue_events_url":"https://api.github.com/repos/amberframework/granite-orm/issues/events{/number}","events_url":"https://api.github.com/repos/amberframework/granite-orm/events","assignees_url":"https://api.github.com/repos/amberframework/granite-orm/assignees{/user}","branches_url":"https://api.github.com/repos/amberframework/granite-orm/branches{/branch}","tags_url":"https://api.github.com/repos/amberframework/granite-orm/tags","blobs_url":"https://api.github.com/repos/amberframework/granite-orm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amberframework/granite-orm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amberframework/granite-orm/git/refs{/sha}","trees_url":"https://api.github.com/repos/amberframework/granite-orm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amberframework/granite-orm/statuses/{sha}","languages_url":"https://api.github.com/repos/amberframework/granite-orm/languages","stargazers_url":"https://api.github.com/repos/amberframework/granite-orm/stargazers","contributors_url":"https://api.github.com/repos/amberframework/granite-orm/contributors","subscribers_url":"https://api.github.com/repos/amberframework/granite-orm/subscribers","subscription_url":"https://api.github.com/repos/amberframework/granite-orm/subscription","commits_url":"https://api.github.com/repos/amberframework/granite-orm/commits{/sha}","git_commits_url":"https://api.github.com/repos/amberframework/granite-orm/git/commits{/sha}","comments_url":"https://api.github.com/repos/amberframework/granite-orm/comments{/number}","issue_comment_url":"https://api.github.com/repos/amberframework/granite-orm/issues/comments{/number}","contents_url":"https://api.github.com/repos/amberframework/granite-orm/contents/{+path}","compare_url":"https://api.github.com/repos/amberframework/granite-orm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amberframework/granite-orm/merges","archive_url":"https://api.github.com/repos/amberframework/granite-orm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amberframework/granite-orm/downloads","issues_url":"https://api.github.com/repos/amberframework/granite-orm/issues{/number}","pulls_url":"https://api.github.com/repos/amberframework/granite-orm/pulls{/number}","milestones_url":"https://api.github.com/repos/amberframework/granite-orm/milestones{/number}","notifications_url":"https://api.github.com/repos/amberframework/granite-orm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amberframework/granite-orm/labels{/name}","releases_url":"https://api.github.com/repos/amberframework/granite-orm/releases{/id}","deployments_url":"https://api.github.com/repos/amberframework/granite-orm/deployments","created_at":"2015-08-22T07:28:16Z","updated_at":"2018-03-23T15:16:44Z","pushed_at":"2018-03-26T20:44:04Z","git_url":"git://github.com/amberframework/granite-orm.git","ssh_url":"git@github.com:amberframework/granite-orm.git","clone_url":"https://github.com/amberframework/granite-orm.git","svn_url":"https://github.com/amberframework/granite-orm","homepage":"","size":572,"stargazers_count":102,"watchers_count":102,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":31,"open_issues":37,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amberframework/granite-orm/pulls/154"},"html":{"href":"https://github.com/amberframework/granite-orm/pull/154"},"issue":{"href":"https://api.github.com/repos/amberframework/granite-orm/issues/154"},"comments":{"href":"https://api.github.com/repos/amberframework/granite-orm/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/amberframework/granite-orm/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/amberframework/granite-orm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amberframework/granite-orm/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/amberframework/granite-orm/statuses/03aa3c7b0a61a710652d53d426c1db6bdb221336"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"drujensen","id":18718,"avatar_url":"https://avatars2.githubusercontent.com/u/18718?v=4","gravatar_id":"","url":"https://api.github.com/users/drujensen","html_url":"https://github.com/drujensen","followers_url":"https://api.github.com/users/drujensen/followers","following_url":"https://api.github.com/users/drujensen/following{/other_user}","gists_url":"https://api.github.com/users/drujensen/gists{/gist_id}","starred_url":"https://api.github.com/users/drujensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drujensen/subscriptions","organizations_url":"https://api.github.com/users/drujensen/orgs","repos_url":"https://api.github.com/users/drujensen/repos","events_url":"https://api.github.com/users/drujensen/events{/privacy}","received_events_url":"https://api.github.com/users/drujensen/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":89,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"drujensen"}}