{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/173317280","pull_request_review_id":102490146,"id":173317280,"diff_hunk":"@@ -99,5 +99,21 @@ export default function (props: GraphDashboardProps) {\n         <Metric name=\"cr.node.sys.cpu.sys.ns\" title=\"Sys CPU Time\" nonNegativeRate />\n       </Axis>\n     </LineGraph>,\n+\n+    <LineGraph title=\"Clock Offset\" sources={nodeSources}\n+    tooltip={`Mean clock offset of each node against the rest of the cluster.`}>\n+      <Axis label=\"offset\" units={AxisUnits.Duration}>\n+        {\n+          _.map(nodeIDs, (nid) => (\n+            <Metric\n+              key={nid}\n+              name=\"cr.node.clock-offset.meannanos\"\n+              title={nodeDisplayName(nodesSummary, nid)}\n+              sources={storeIDsForNode(nodesSummary, nid)}\n+            />\n+          ))\n+        }\n+      </Axis>\n+    </LineGraph>,","path":"pkg/ui/src/views/cluster/containers/nodeGraphs/dashboards/runtime.tsx","position":null,"original_position":32,"commit_id":"7cf3689db87622f3dac5a4561c7797c70f92e722","original_commit_id":"c219393ef09010ff688d15eff312d9a1f3b0145a","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"body":"Weird, vim is lying to me:\r\n\r\n<img width=\"601\" alt=\"screen shot 2018-03-08 at 5 48 04 pm\" src=\"https://user-images.githubusercontent.com/7085343/37180945-ec5b7d8a-22f8-11e8-9206-30390881b12b.png\">\r\n","created_at":"2018-03-08T22:48:38Z","updated_at":"2018-03-08T22:48:39Z","html_url":"https://github.com/cockroachdb/cockroach/pull/23618#discussion_r173317280","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/173317280"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/23618#discussion_r173317280"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618"}},"in_reply_to_id":173313139},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618","id":173867916,"html_url":"https://github.com/cockroachdb/cockroach/pull/23618","diff_url":"https://github.com/cockroachdb/cockroach/pull/23618.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23618.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23618","number":23618,"state":"open","locked":false,"title":"ui: Move Clock Offset graph to runtime dashboard and display per node","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"body":"Since the Distributed dashboard isn't currently a place for metrics of\r\ninterest to end users.\r\n\r\nAlso, aggregating the offsets and standard deviations together using a\r\nSUM aggregator was basically meaningless. This metric makes the most\r\nsense on a per-node basis.\r\n\r\nTouches https://github.com/cockroachdb/docs/issues/2664\r\n\r\nRelease note (admin ui change): Moved the Clock Offset graph from the\r\nDistributed dashboard to the Runtime dashboard, and display each node's\r\nclock offset independently rather than aggregating them together.\r\n\r\nLooks like:\r\n<img width=\"860\" alt=\"screen shot 2018-03-08 at 5 22 50 pm\" src=\"https://user-images.githubusercontent.com/7085343/37179934-5f25f60a-22f5-11e8-9e09-28350d013b1f.png\">\r\n","created_at":"2018-03-08T22:23:10Z","updated_at":"2018-03-08T22:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8030dbbf5540354cdf35aa6ac6e0a9cd79e4dff7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"couchand","id":793969,"avatar_url":"https://avatars1.githubusercontent.com/u/793969?v=4","gravatar_id":"","url":"https://api.github.com/users/couchand","html_url":"https://github.com/couchand","followers_url":"https://api.github.com/users/couchand/followers","following_url":"https://api.github.com/users/couchand/following{/other_user}","gists_url":"https://api.github.com/users/couchand/gists{/gist_id}","starred_url":"https://api.github.com/users/couchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchand/subscriptions","organizations_url":"https://api.github.com/users/couchand/orgs","repos_url":"https://api.github.com/users/couchand/repos","events_url":"https://api.github.com/users/couchand/events{/privacy}","received_events_url":"https://api.github.com/users/couchand/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23618/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/7cf3689db87622f3dac5a4561c7797c70f92e722","head":{"label":"a-robinson:offsetgraph","ref":"offsetgraph","sha":"7cf3689db87622f3dac5a4561c7797c70f92e722","user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"repo":{"id":60129294,"name":"cockroach","full_name":"a-robinson/cockroach","owner":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-robinson/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/a-robinson/cockroach","forks_url":"https://api.github.com/repos/a-robinson/cockroach/forks","keys_url":"https://api.github.com/repos/a-robinson/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-robinson/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-robinson/cockroach/teams","hooks_url":"https://api.github.com/repos/a-robinson/cockroach/hooks","issue_events_url":"https://api.github.com/repos/a-robinson/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/a-robinson/cockroach/events","assignees_url":"https://api.github.com/repos/a-robinson/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/a-robinson/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/a-robinson/cockroach/tags","blobs_url":"https://api.github.com/repos/a-robinson/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-robinson/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-robinson/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-robinson/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-robinson/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/a-robinson/cockroach/languages","stargazers_url":"https://api.github.com/repos/a-robinson/cockroach/stargazers","contributors_url":"https://api.github.com/repos/a-robinson/cockroach/contributors","subscribers_url":"https://api.github.com/repos/a-robinson/cockroach/subscribers","subscription_url":"https://api.github.com/repos/a-robinson/cockroach/subscription","commits_url":"https://api.github.com/repos/a-robinson/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-robinson/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-robinson/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-robinson/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-robinson/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/a-robinson/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-robinson/cockroach/merges","archive_url":"https://api.github.com/repos/a-robinson/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-robinson/cockroach/downloads","issues_url":"https://api.github.com/repos/a-robinson/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/a-robinson/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/a-robinson/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/a-robinson/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-robinson/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/a-robinson/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/a-robinson/cockroach/deployments","created_at":"2016-05-31T22:58:50Z","updated_at":"2016-12-21T03:05:47Z","pushed_at":"2018-03-08T22:44:22Z","git_url":"git://github.com/a-robinson/cockroach.git","ssh_url":"git@github.com:a-robinson/cockroach.git","clone_url":"https://github.com/a-robinson/cockroach.git","svn_url":"https://github.com/a-robinson/cockroach","homepage":"https://www.cockroachlabs.com","size":525159,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"7e789fda4e01d0a0dab6cc04070bd2f43c132468","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-03-08T22:46:31Z","pushed_at":"2018-03-08T22:46:14Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":971462,"stargazers_count":12735,"watchers_count":12735,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1296,"mirror_url":null,"archived":false,"open_issues_count":1541,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1296,"open_issues":1541,"watchers":12735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/23618"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23618"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23618/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23618/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/7cf3689db87622f3dac5a4561c7797c70f92e722"}},"author_association":"OWNER"}}
{"actor":{"display_login":"a-robinson"}}