{"action":"created","issue":{"url":"https://api.github.com/repos/simint-chem/simint-generator/issues/13","repository_url":"https://api.github.com/repos/simint-chem/simint-generator","labels_url":"https://api.github.com/repos/simint-chem/simint-generator/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/simint-chem/simint-generator/issues/13/comments","events_url":"https://api.github.com/repos/simint-chem/simint-generator/issues/13/events","html_url":"https://github.com/simint-chem/simint-generator/pull/13","id":377117877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTU1OTM1","number":13,"title":"Change in ostei to free pointer, Issue #12","user":{"login":"colleeneb","id":18434185,"node_id":"MDQ6VXNlcjE4NDM0MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/18434185?v=4","gravatar_id":"","url":"https://api.github.com/users/colleeneb","html_url":"https://github.com/colleeneb","followers_url":"https://api.github.com/users/colleeneb/followers","following_url":"https://api.github.com/users/colleeneb/following{/other_user}","gists_url":"https://api.github.com/users/colleeneb/gists{/gist_id}","starred_url":"https://api.github.com/users/colleeneb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colleeneb/subscriptions","organizations_url":"https://api.github.com/users/colleeneb/orgs","repos_url":"https://api.github.com/users/colleeneb/repos","events_url":"https://api.github.com/users/colleeneb/events{/privacy}","received_events_url":"https://api.github.com/users/colleeneb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-04T03:45:45Z","updated_at":"2018-12-11T18:48:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/simint-chem/simint-generator/pulls/13","html_url":"https://github.com/simint-chem/simint-generator/pull/13","diff_url":"https://github.com/simint-chem/simint-generator/pull/13.diff","patch_url":"https://github.com/simint-chem/simint-generator/pull/13.patch"},"body":"This is in reference to Issue #12 (more detail is there). Valgrind shows a memory leak for a test case, and this fix is meant to fix it. \r\n\r\nThis changes the conditional in an if statement. Currently it checks if the pointer is NULL and frees it the pointer if it's NULL, which sounds strange:\r\n\r\n```if (!offset_info) free(offset_info);```\r\n\r\nThe pointer itself should never be NULL since there's an assert statement around it earlier in the function.\r\n\r\nThis PR changes the code so that the pointer is freed if the pointer is nonNULL, not if the pointer is NULL. I think this is the correct fix, but let me know if I'm missing something. Thanks!"},"comment":{"url":"https://api.github.com/repos/simint-chem/simint-generator/issues/comments/446316142","html_url":"https://github.com/simint-chem/simint-generator/pull/13#issuecomment-446316142","issue_url":"https://api.github.com/repos/simint-chem/simint-generator/issues/13","id":446316142,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjMxNjE0Mg==","user":{"login":"bennybp","id":4708439,"node_id":"MDQ6VXNlcjQ3MDg0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4708439?v=4","gravatar_id":"","url":"https://api.github.com/users/bennybp","html_url":"https://github.com/bennybp","followers_url":"https://api.github.com/users/bennybp/followers","following_url":"https://api.github.com/users/bennybp/following{/other_user}","gists_url":"https://api.github.com/users/bennybp/gists{/gist_id}","starred_url":"https://api.github.com/users/bennybp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennybp/subscriptions","organizations_url":"https://api.github.com/users/bennybp/orgs","repos_url":"https://api.github.com/users/bennybp/repos","events_url":"https://api.github.com/users/bennybp/events{/privacy}","received_events_url":"https://api.github.com/users/bennybp/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T18:48:27Z","updated_at":"2018-12-11T18:48:27Z","author_association":"CONTRIBUTOR","body":"Sorry for the delay. Thanks for finding/fixing this."}}
{"actor":{"display_login":"bennybp"}}