{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40","id":173758082,"html_url":"https://github.com/SkillsFundingAgency/das-recruit/pull/40","diff_url":"https://github.com/SkillsFundingAgency/das-recruit/pull/40.diff","patch_url":"https://github.com/SkillsFundingAgency/das-recruit/pull/40.patch","issue_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/40","number":40,"state":"closed","locked":false,"title":":speaker: - Adding handling for application exceptions","user":{"login":"sachpatel","id":10399742,"avatar_url":"https://avatars0.githubusercontent.com/u/10399742?v=4","gravatar_id":"","url":"https://api.github.com/users/sachpatel","html_url":"https://github.com/sachpatel","followers_url":"https://api.github.com/users/sachpatel/followers","following_url":"https://api.github.com/users/sachpatel/following{/other_user}","gists_url":"https://api.github.com/users/sachpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/sachpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachpatel/subscriptions","organizations_url":"https://api.github.com/users/sachpatel/orgs","repos_url":"https://api.github.com/users/sachpatel/repos","events_url":"https://api.github.com/users/sachpatel/events{/privacy}","received_events_url":"https://api.github.com/users/sachpatel/received_events","type":"User","site_admin":false},"body":"This is a bit of a crude method.\r\n\r\nI have looked at using IExceptionFilter's or our own custom Exception middleware for handling of global exceptions we raise. Both options were not quite right or appropriate.\r\n\r\nI have only put the exception raising in one place at the moment which is when attempting to go to the `sections` page for a vacancy that has `submitted` status.\r\n\r\nI have placed the example `ConcurrencyException` in the web project as I was not sure where to put it if at all in the VacancyClient project application or domain layer folders.\r\n\r\nBecause we want to surface an error such as the one for trying to edit a submitted vacancy on the dashboard, I have made the dashboard a Shared view that can be called to display from any controller.\r\n\r\nTo see in action, in the `Startup.Configure.cs` file, replace `app.UseDeveloperExceptionPage();` with `app.UseExceptionHandler(\"/error/handle\");` and then click onto the title of a vacancy that has a `Submitted` status from the dashboard.\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-03-08T14:58:18Z","updated_at":"2018-03-12T11:43:58Z","closed_at":"2018-03-12T11:43:58Z","merged_at":"2018-03-12T11:43:58Z","merge_commit_sha":"d01c17d2c4e0f60a3e26089ec2c83796e6589e97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40/commits","review_comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40/comments","review_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/40/comments","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/statuses/bcebeeef9d96cd6f3904745a6de92fb00e8b563c","head":{"label":"SkillsFundingAgency:exception-handling","ref":"exception-handling","sha":"bcebeeef9d96cd6f3904745a6de92fb00e8b563c","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":118602713,"name":"das-recruit","full_name":"SkillsFundingAgency/das-recruit","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/das-recruit","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/deployments","created_at":"2018-01-23T11:43:46Z","updated_at":"2018-02-27T11:32:19Z","pushed_at":"2018-03-12T11:43:58Z","git_url":"git://github.com/SkillsFundingAgency/das-recruit.git","ssh_url":"git@github.com:SkillsFundingAgency/das-recruit.git","clone_url":"https://github.com/SkillsFundingAgency/das-recruit.git","svn_url":"https://github.com/SkillsFundingAgency/das-recruit","homepage":null,"size":1360,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"SkillsFundingAgency:master","ref":"master","sha":"58f95b3755f25b3290a28a582bfdd09651bd7aa8","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":118602713,"name":"das-recruit","full_name":"SkillsFundingAgency/das-recruit","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/das-recruit","description":null,"fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit","forks_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/deployments","created_at":"2018-01-23T11:43:46Z","updated_at":"2018-02-27T11:32:19Z","pushed_at":"2018-03-12T11:43:58Z","git_url":"git://github.com/SkillsFundingAgency/das-recruit.git","ssh_url":"git@github.com:SkillsFundingAgency/das-recruit.git","clone_url":"https://github.com/SkillsFundingAgency/das-recruit.git","svn_url":"https://github.com/SkillsFundingAgency/das-recruit","homepage":null,"size":1360,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40"},"html":{"href":"https://github.com/SkillsFundingAgency/das-recruit/pull/40"},"issue":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/40"},"comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/SkillsFundingAgency/das-recruit/statuses/bcebeeef9d96cd6f3904745a6de92fb00e8b563c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sachpatel","id":10399742,"avatar_url":"https://avatars0.githubusercontent.com/u/10399742?v=4","gravatar_id":"","url":"https://api.github.com/users/sachpatel","html_url":"https://github.com/sachpatel","followers_url":"https://api.github.com/users/sachpatel/followers","following_url":"https://api.github.com/users/sachpatel/following{/other_user}","gists_url":"https://api.github.com/users/sachpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/sachpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachpatel/subscriptions","organizations_url":"https://api.github.com/users/sachpatel/orgs","repos_url":"https://api.github.com/users/sachpatel/repos","events_url":"https://api.github.com/users/sachpatel/events{/privacy}","received_events_url":"https://api.github.com/users/sachpatel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":11,"maintainer_can_modify":false,"commits":7,"additions":190,"deletions":59,"changed_files":22}}
{"actor":{"display_login":"sachpatel"}}