{"action":"created","comment":{"url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/comments/182524834","pull_request_review_id":113337662,"id":182524834,"diff_hunk":"@@ -26,15 +26,13 @@ def _eliottree(logs):\n \n     :return bytes: The rendered string.","path":"src/txkube/testing/_eliot.py","position":null,"original_position":18,"commit_id":"224695ec507af92dd5c4dc6c3ddf186e6a5ba5c1","original_commit_id":"745e19d0be6ed4918f5ef1745c49cf47cb15d1de","user":{"login":"exarkun","id":254565,"avatar_url":"https://avatars1.githubusercontent.com/u/254565?v=4","gravatar_id":"","url":"https://api.github.com/users/exarkun","html_url":"https://github.com/exarkun","followers_url":"https://api.github.com/users/exarkun/followers","following_url":"https://api.github.com/users/exarkun/following{/other_user}","gists_url":"https://api.github.com/users/exarkun/gists{/gist_id}","starred_url":"https://api.github.com/users/exarkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exarkun/subscriptions","organizations_url":"https://api.github.com/users/exarkun/orgs","repos_url":"https://api.github.com/users/exarkun/repos","events_url":"https://api.github.com/users/exarkun/events{/privacy}","received_events_url":"https://api.github.com/users/exarkun/received_events","type":"User","site_admin":false},"body":"Here's an example of \"meaningful\":\r\n\r\n```\r\nFailure: testtools.testresult.real._StringException: foo: {{{☃}}}\r\n```\r\n","created_at":"2018-04-18T18:24:38Z","updated_at":"2018-04-18T18:24:38Z","html_url":"https://github.com/LeastAuthority/txkube/pull/174#discussion_r182524834","pull_request_url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/comments/182524834"},"html":{"href":"https://github.com/LeastAuthority/txkube/pull/174#discussion_r182524834"},"pull_request":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174"}},"in_reply_to_id":178040637},"pull_request":{"url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174","id":178220320,"html_url":"https://github.com/LeastAuthority/txkube/pull/174","diff_url":"https://github.com/LeastAuthority/txkube/pull/174.diff","patch_url":"https://github.com/LeastAuthority/txkube/pull/174.patch","issue_url":"https://api.github.com/repos/LeastAuthority/txkube/issues/174","number":174,"state":"open","locked":false,"title":"Replace deprecated functions in eliottree with newer functions","user":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars1.githubusercontent.com/u/1895943?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"body":"I saw these deprecation warnings when running the txkube tests:\r\n\r\n```\r\n/Users/crodrigues/txkube/src/txkube/testing/test/test_eliot.py:27: DeprecationWarning: add_destination is deprecated since 1.1.0. Use add_destinations instead.\r\n/Users/crodrigues/txkube/src/txkube/testing/_eliot.py:29: DeprecationWarning: Tree is deprecated, use eliottree.tasks_from_iterable instead\r\n/Users/crodrigues/txkube/src/txkube/testing/_eliot.py:37: DeprecationWarning: render_task_nodes is deprecated, use eliottree.render_tasks instead\r\n```\r\n\r\nso took a stab at using newer functions.\r\n\r\nFixes https://github.com/LeastAuthority/txkube/issues/179","created_at":"2018-03-29T03:46:07Z","updated_at":"2018-04-18T18:24:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30be4c0fc8c0f06ed4bf0fbf9f6ec7fc3b0ff14a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174/commits","review_comments_url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174/comments","review_comment_url":"https://api.github.com/repos/LeastAuthority/txkube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LeastAuthority/txkube/issues/174/comments","statuses_url":"https://api.github.com/repos/LeastAuthority/txkube/statuses/224695ec507af92dd5c4dc6c3ddf186e6a5ba5c1","head":{"label":"rodrigc:eliot-deprecations","ref":"eliot-deprecations","sha":"224695ec507af92dd5c4dc6c3ddf186e6a5ba5c1","user":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars1.githubusercontent.com/u/1895943?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"repo":{"id":101859678,"name":"txkube","full_name":"rodrigc/txkube","owner":{"login":"rodrigc","id":1895943,"avatar_url":"https://avatars1.githubusercontent.com/u/1895943?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigc","html_url":"https://github.com/rodrigc","followers_url":"https://api.github.com/users/rodrigc/followers","following_url":"https://api.github.com/users/rodrigc/following{/other_user}","gists_url":"https://api.github.com/users/rodrigc/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigc/subscriptions","organizations_url":"https://api.github.com/users/rodrigc/orgs","repos_url":"https://api.github.com/users/rodrigc/repos","events_url":"https://api.github.com/users/rodrigc/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rodrigc/txkube","description":"A Twisted-based Kubernetes client.","fork":true,"url":"https://api.github.com/repos/rodrigc/txkube","forks_url":"https://api.github.com/repos/rodrigc/txkube/forks","keys_url":"https://api.github.com/repos/rodrigc/txkube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rodrigc/txkube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rodrigc/txkube/teams","hooks_url":"https://api.github.com/repos/rodrigc/txkube/hooks","issue_events_url":"https://api.github.com/repos/rodrigc/txkube/issues/events{/number}","events_url":"https://api.github.com/repos/rodrigc/txkube/events","assignees_url":"https://api.github.com/repos/rodrigc/txkube/assignees{/user}","branches_url":"https://api.github.com/repos/rodrigc/txkube/branches{/branch}","tags_url":"https://api.github.com/repos/rodrigc/txkube/tags","blobs_url":"https://api.github.com/repos/rodrigc/txkube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rodrigc/txkube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rodrigc/txkube/git/refs{/sha}","trees_url":"https://api.github.com/repos/rodrigc/txkube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rodrigc/txkube/statuses/{sha}","languages_url":"https://api.github.com/repos/rodrigc/txkube/languages","stargazers_url":"https://api.github.com/repos/rodrigc/txkube/stargazers","contributors_url":"https://api.github.com/repos/rodrigc/txkube/contributors","subscribers_url":"https://api.github.com/repos/rodrigc/txkube/subscribers","subscription_url":"https://api.github.com/repos/rodrigc/txkube/subscription","commits_url":"https://api.github.com/repos/rodrigc/txkube/commits{/sha}","git_commits_url":"https://api.github.com/repos/rodrigc/txkube/git/commits{/sha}","comments_url":"https://api.github.com/repos/rodrigc/txkube/comments{/number}","issue_comment_url":"https://api.github.com/repos/rodrigc/txkube/issues/comments{/number}","contents_url":"https://api.github.com/repos/rodrigc/txkube/contents/{+path}","compare_url":"https://api.github.com/repos/rodrigc/txkube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rodrigc/txkube/merges","archive_url":"https://api.github.com/repos/rodrigc/txkube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rodrigc/txkube/downloads","issues_url":"https://api.github.com/repos/rodrigc/txkube/issues{/number}","pulls_url":"https://api.github.com/repos/rodrigc/txkube/pulls{/number}","milestones_url":"https://api.github.com/repos/rodrigc/txkube/milestones{/number}","notifications_url":"https://api.github.com/repos/rodrigc/txkube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rodrigc/txkube/labels{/name}","releases_url":"https://api.github.com/repos/rodrigc/txkube/releases{/id}","deployments_url":"https://api.github.com/repos/rodrigc/txkube/deployments","created_at":"2017-08-30T08:52:24Z","updated_at":"2018-04-04T08:09:36Z","pushed_at":"2018-04-04T08:10:31Z","git_url":"git://github.com/rodrigc/txkube.git","ssh_url":"git@github.com:rodrigc/txkube.git","clone_url":"https://github.com/rodrigc/txkube.git","svn_url":"https://github.com/rodrigc/txkube","homepage":null,"size":664,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LeastAuthority:master","ref":"master","sha":"21dbd1b82bd379717fa897b352322c9911785e06","user":{"login":"LeastAuthority","id":3720472,"avatar_url":"https://avatars2.githubusercontent.com/u/3720472?v=4","gravatar_id":"","url":"https://api.github.com/users/LeastAuthority","html_url":"https://github.com/LeastAuthority","followers_url":"https://api.github.com/users/LeastAuthority/followers","following_url":"https://api.github.com/users/LeastAuthority/following{/other_user}","gists_url":"https://api.github.com/users/LeastAuthority/gists{/gist_id}","starred_url":"https://api.github.com/users/LeastAuthority/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeastAuthority/subscriptions","organizations_url":"https://api.github.com/users/LeastAuthority/orgs","repos_url":"https://api.github.com/users/LeastAuthority/repos","events_url":"https://api.github.com/users/LeastAuthority/events{/privacy}","received_events_url":"https://api.github.com/users/LeastAuthority/received_events","type":"Organization","site_admin":false},"repo":{"id":79145542,"name":"txkube","full_name":"LeastAuthority/txkube","owner":{"login":"LeastAuthority","id":3720472,"avatar_url":"https://avatars2.githubusercontent.com/u/3720472?v=4","gravatar_id":"","url":"https://api.github.com/users/LeastAuthority","html_url":"https://github.com/LeastAuthority","followers_url":"https://api.github.com/users/LeastAuthority/followers","following_url":"https://api.github.com/users/LeastAuthority/following{/other_user}","gists_url":"https://api.github.com/users/LeastAuthority/gists{/gist_id}","starred_url":"https://api.github.com/users/LeastAuthority/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeastAuthority/subscriptions","organizations_url":"https://api.github.com/users/LeastAuthority/orgs","repos_url":"https://api.github.com/users/LeastAuthority/repos","events_url":"https://api.github.com/users/LeastAuthority/events{/privacy}","received_events_url":"https://api.github.com/users/LeastAuthority/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeastAuthority/txkube","description":"A Twisted-based Kubernetes client.","fork":false,"url":"https://api.github.com/repos/LeastAuthority/txkube","forks_url":"https://api.github.com/repos/LeastAuthority/txkube/forks","keys_url":"https://api.github.com/repos/LeastAuthority/txkube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeastAuthority/txkube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeastAuthority/txkube/teams","hooks_url":"https://api.github.com/repos/LeastAuthority/txkube/hooks","issue_events_url":"https://api.github.com/repos/LeastAuthority/txkube/issues/events{/number}","events_url":"https://api.github.com/repos/LeastAuthority/txkube/events","assignees_url":"https://api.github.com/repos/LeastAuthority/txkube/assignees{/user}","branches_url":"https://api.github.com/repos/LeastAuthority/txkube/branches{/branch}","tags_url":"https://api.github.com/repos/LeastAuthority/txkube/tags","blobs_url":"https://api.github.com/repos/LeastAuthority/txkube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeastAuthority/txkube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeastAuthority/txkube/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeastAuthority/txkube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeastAuthority/txkube/statuses/{sha}","languages_url":"https://api.github.com/repos/LeastAuthority/txkube/languages","stargazers_url":"https://api.github.com/repos/LeastAuthority/txkube/stargazers","contributors_url":"https://api.github.com/repos/LeastAuthority/txkube/contributors","subscribers_url":"https://api.github.com/repos/LeastAuthority/txkube/subscribers","subscription_url":"https://api.github.com/repos/LeastAuthority/txkube/subscription","commits_url":"https://api.github.com/repos/LeastAuthority/txkube/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeastAuthority/txkube/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeastAuthority/txkube/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeastAuthority/txkube/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeastAuthority/txkube/contents/{+path}","compare_url":"https://api.github.com/repos/LeastAuthority/txkube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeastAuthority/txkube/merges","archive_url":"https://api.github.com/repos/LeastAuthority/txkube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeastAuthority/txkube/downloads","issues_url":"https://api.github.com/repos/LeastAuthority/txkube/issues{/number}","pulls_url":"https://api.github.com/repos/LeastAuthority/txkube/pulls{/number}","milestones_url":"https://api.github.com/repos/LeastAuthority/txkube/milestones{/number}","notifications_url":"https://api.github.com/repos/LeastAuthority/txkube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeastAuthority/txkube/labels{/name}","releases_url":"https://api.github.com/repos/LeastAuthority/txkube/releases{/id}","deployments_url":"https://api.github.com/repos/LeastAuthority/txkube/deployments","created_at":"2017-01-16T18:15:16Z","updated_at":"2018-04-18T18:09:35Z","pushed_at":"2018-04-18T18:09:32Z","git_url":"git://github.com/LeastAuthority/txkube.git","ssh_url":"git@github.com:LeastAuthority/txkube.git","clone_url":"https://github.com/LeastAuthority/txkube.git","svn_url":"https://github.com/LeastAuthority/txkube","homepage":null,"size":646,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":20,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174"},"html":{"href":"https://github.com/LeastAuthority/txkube/pull/174"},"issue":{"href":"https://api.github.com/repos/LeastAuthority/txkube/issues/174"},"comments":{"href":"https://api.github.com/repos/LeastAuthority/txkube/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LeastAuthority/txkube/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/LeastAuthority/txkube/statuses/224695ec507af92dd5c4dc6c3ddf186e6a5ba5c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"exarkun"}}