{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/187618441","pull_request_review_id":119438999,"id":187618441,"diff_hunk":"@@ -1472,56 +1463,6 @@ def diff_values(a, b, rtol=0.0, atol=0.0):\n         return a != b\n \n \n-def report_diff_values(fileobj, a, b, ind=0):\n-    \"\"\"Write a diff between two values to the specified file-like object.\"\"\"\n-\n-    typea = type(a)\n-    typeb = type(b)\n-\n-    if (isinstance(a, str) and not isinstance(b, str)):\n-        a = repr(a).lstrip('u')\n-    elif (isinstance(b, str) and not isinstance(a, str)):\n-        b = repr(b).lstrip('u')","path":"astropy/io/fits/diff.py","position":84,"original_position":69,"commit_id":"ade1d826514c65f5f91ce64abc1c1bb266959a73","original_commit_id":"c137956d91880b28aef2482809bc5a5579866f2e","user":{"login":"pllim","id":2090236,"avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"body":"Yes, I did. To work on it now concurrently would introduce a lot of conflicts.","created_at":"2018-05-11T13:46:57Z","updated_at":"2018-05-11T13:46:58Z","html_url":"https://github.com/astropy/astropy/pull/7444#discussion_r187618441","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/7444","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/187618441"},"html":{"href":"https://github.com/astropy/astropy/pull/7444#discussion_r187618441"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7444"}},"in_reply_to_id":186866768},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/7444","id":186681350,"html_url":"https://github.com/astropy/astropy/pull/7444","diff_url":"https://github.com/astropy/astropy/pull/7444.diff","patch_url":"https://github.com/astropy/astropy/pull/7444.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/7444","number":7444,"state":"open","locked":false,"title":"Move generic diff functions to utils","user":{"login":"pllim","id":2090236,"avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"body":"Address part (if not all) of #7442.\r\n\r\nc/c @stsci-hack\r\n\r\n**Rendered doc screenshots**\r\n\r\nThis is `astropy.utils.diff` API listing:\r\n\r\n![ss_1](https://user-images.githubusercontent.com/2090236/39838863-88835068-53a8-11e8-91d5-5baba1075fc2.png)\r\n\r\nThis is \"Table operations\" listing:\r\n\r\n![ss_2](https://user-images.githubusercontent.com/2090236/39838869-8c44f620-53a8-11e8-8bd6-289210dce468.png)\r\n\r\nThis is the new section I added under \"Table operations\":\r\n\r\n![ss_3](https://user-images.githubusercontent.com/2090236/39838878-901b51cc-53a8-11e8-906d-8afe86996038.png)\r\n\r\nTODO:\r\n- [x] Move other generic functions out of `astropy.io.fits.diff`?\r\n- [x] Add documentation in `astropy.table` subpackage doc to show example how to use diff function.","created_at":"2018-05-08T16:00:30Z","updated_at":"2018-05-11T13:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"477f9ca69ab0a1203808381f6a988b974038f580","assignee":null,"assignees":[],"requested_reviewers":[{"login":"taldcroft","id":348089,"avatar_url":"https://avatars1.githubusercontent.com/u/348089?v=4","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":316473427,"url":"https://api.github.com/repos/astropy/astropy/labels/Refactoring","name":"Refactoring","color":"fef2c0","default":false},{"id":3496818,"url":"https://api.github.com/repos/astropy/astropy/labels/io.fits","name":"io.fits","color":"c7def8","default":false},{"id":42438611,"url":"https://api.github.com/repos/astropy/astropy/labels/utils","name":"utils","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/52","html_url":"https://github.com/astropy/astropy/milestone/52","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/52/labels","id":2929745,"number":52,"title":"v3.1","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":40,"state":"open","created_at":"2017-11-21T23:24:18Z","updated_at":"2018-05-10T14:37:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/7444/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/7444/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/7444/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/ade1d826514c65f5f91ce64abc1c1bb266959a73","head":{"label":"pllim:diff-utils","ref":"diff-utils","sha":"ade1d826514c65f5f91ce64abc1c1bb266959a73","user":{"login":"pllim","id":2090236,"avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"repo":{"id":5286745,"name":"astropy","full_name":"pllim/astropy","owner":{"login":"pllim","id":2090236,"avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pllim/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/pllim/astropy","forks_url":"https://api.github.com/repos/pllim/astropy/forks","keys_url":"https://api.github.com/repos/pllim/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pllim/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pllim/astropy/teams","hooks_url":"https://api.github.com/repos/pllim/astropy/hooks","issue_events_url":"https://api.github.com/repos/pllim/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/pllim/astropy/events","assignees_url":"https://api.github.com/repos/pllim/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/pllim/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/pllim/astropy/tags","blobs_url":"https://api.github.com/repos/pllim/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pllim/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pllim/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pllim/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pllim/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/pllim/astropy/languages","stargazers_url":"https://api.github.com/repos/pllim/astropy/stargazers","contributors_url":"https://api.github.com/repos/pllim/astropy/contributors","subscribers_url":"https://api.github.com/repos/pllim/astropy/subscribers","subscription_url":"https://api.github.com/repos/pllim/astropy/subscription","commits_url":"https://api.github.com/repos/pllim/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pllim/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pllim/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pllim/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pllim/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/pllim/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pllim/astropy/merges","archive_url":"https://api.github.com/repos/pllim/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pllim/astropy/downloads","issues_url":"https://api.github.com/repos/pllim/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/pllim/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/pllim/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/pllim/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pllim/astropy/labels{/name}","releases_url":"https://api.github.com/repos/pllim/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/pllim/astropy/deployments","created_at":"2012-08-03T15:10:18Z","updated_at":"2018-04-21T19:49:18Z","pushed_at":"2018-05-10T14:47:48Z","git_url":"git://github.com/pllim/astropy.git","ssh_url":"git@github.com:pllim/astropy.git","clone_url":"https://github.com/pllim/astropy.git","svn_url":"https://github.com/pllim/astropy","homepage":"astropy.org","size":63198,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"placeholder"}},"base":{"label":"astropy:master","ref":"master","sha":"a3ece74b1b42b146f9024f633ed737e04eb7823e","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2018-05-10T02:46:54Z","pushed_at":"2018-05-11T12:29:55Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":70306,"stargazers_count":1597,"watchers_count":1597,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":868,"mirror_url":null,"archived":false,"open_issues_count":877,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":868,"open_issues":877,"watchers":1597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7444"},"html":{"href":"https://github.com/astropy/astropy/pull/7444"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/7444"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/7444/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7444/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7444/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/ade1d826514c65f5f91ce64abc1c1bb266959a73"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pllim"}}