{"action":"created","issue":{"url":"https://api.github.com/repos/fabricjs/fabric.js/issues/2775","repository_url":"https://api.github.com/repos/fabricjs/fabric.js","labels_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/2775/labels{/name}","comments_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/2775/comments","events_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/2775/events","html_url":"https://github.com/fabricjs/fabric.js/issues/2775","id":132028494,"number":2775,"title":"Allow installation via npm for browser usage","user":{"login":"vkammerer","id":1177483,"avatar_url":"https://avatars3.githubusercontent.com/u/1177483?v=4","gravatar_id":"","url":"https://api.github.com/users/vkammerer","html_url":"https://github.com/vkammerer","followers_url":"https://api.github.com/users/vkammerer/followers","following_url":"https://api.github.com/users/vkammerer/following{/other_user}","gists_url":"https://api.github.com/users/vkammerer/gists{/gist_id}","starred_url":"https://api.github.com/users/vkammerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkammerer/subscriptions","organizations_url":"https://api.github.com/users/vkammerer/orgs","repos_url":"https://api.github.com/users/vkammerer/repos","events_url":"https://api.github.com/users/vkammerer/events{/privacy}","received_events_url":"https://api.github.com/users/vkammerer/received_events","type":"User","site_admin":false},"labels":[{"id":86774,"url":"https://api.github.com/repos/fabricjs/fabric.js/labels/feature","name":"feature","color":"02e10c","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":47,"created_at":"2016-02-08T00:24:35Z","updated_at":"2018-05-06T08:56:17Z","closed_at":"2016-04-23T03:16:30Z","author_association":"NONE","body":"npm has become the de-facto package manager for front end dependencies (bower is on its way out), and I would guess that most people who want to use it in a browser app nowadays try to install with npm, as I just did.\n\nUnfortunately, the fabric.js package distributed on npm assumes that people want to use it in a node context, and has dependencies on cairo.\n\nI don't know what the solution can be here:\n- distribute it under a different name (\"fabric-frontend\"?)\n- or more simply, just stop including other dependencies in the package.json, and list the requirement to cairo in the installing instructions\n"},"comment":{"url":"https://api.github.com/repos/fabricjs/fabric.js/issues/comments/386864464","html_url":"https://github.com/fabricjs/fabric.js/issues/2775#issuecomment-386864464","issue_url":"https://api.github.com/repos/fabricjs/fabric.js/issues/2775","id":386864464,"user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars3.githubusercontent.com/u/1194048?v=4","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"created_at":"2018-05-06T08:56:17Z","updated_at":"2018-05-06T08:56:17Z","author_association":"OWNER","body":"ok so i made this thing here:\r\n\r\nhttps://travis-ci.org/fabricjs/fabricjs-webpack/\r\n\r\nthis is just an example, i took latest webpack, latest node ( to have latest npm ) and build a simple webpack bundle with fabricJS.\r\n\r\nWhat i can see is that the build succedes, there are information stating that xmldom and jsdom are not bundled.\r\n\r\nThen i test this on travis with a linux docker image where canvas can't be installed because libs are missing, npm throws warning says that an unmet optional dep is missing ( canvas ) but the intall does not fail. The build run.\r\n\r\nSo i tend toward considering this a non issue with current tools and recent fabric changes, unless someone can clearly show me a problem."}}
{"actor":{"display_login":"asturur"}}