{"action":"created","comment":{"url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/comments/177843152","pull_request_review_id":107792278,"id":177843152,"diff_hunk":"@@ -668,7 +668,7 @@ AUI.add(\n \n \t\t\t\tvar secondOperandTypeValue = instance._getSecondOperandTypeValue(index);\n \n-\t\t\t\tvar visible = instance._isConstant(secondOperandTypeValue) && !instance._isFieldList(firstOperand);\n+\t\t\t\tvar visible = instance._isText(secondOperandTypeValue) && !instance._isFieldList(firstOperand);","path":"modules/apps/forms-and-workflow/dynamic-data-mapping/dynamic-data-mapping-form-builder/src/main/resources/META-INF/resources/js/form_builder_render_rule_condition.js","position":241,"original_position":5,"commit_id":"13d5296b97ea5dec6f19acacaf2643557bf0a5ac","original_commit_id":"3815af129934ca371aa1039fecffb1c9366edd89","user":{"login":"alinedoleron","id":26491796,"avatar_url":"https://avatars1.githubusercontent.com/u/26491796?v=4","gravatar_id":"","url":"https://api.github.com/users/alinedoleron","html_url":"https://github.com/alinedoleron","followers_url":"https://api.github.com/users/alinedoleron/followers","following_url":"https://api.github.com/users/alinedoleron/following{/other_user}","gists_url":"https://api.github.com/users/alinedoleron/gists{/gist_id}","starred_url":"https://api.github.com/users/alinedoleron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinedoleron/subscriptions","organizations_url":"https://api.github.com/users/alinedoleron/orgs","repos_url":"https://api.github.com/users/alinedoleron/repos","events_url":"https://api.github.com/users/alinedoleron/events{/privacy}","received_events_url":"https://api.github.com/users/alinedoleron/received_events","type":"User","site_admin":false},"body":"It's ok. But the \"visible\" variable is being used outside the \"if\" condition, so I'll keep it.","created_at":"2018-03-28T18:14:47Z","updated_at":"2018-03-28T18:14:47Z","html_url":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42#discussion_r177843152","pull_request_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/comments/177843152"},"html":{"href":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42#discussion_r177843152"},"pull_request":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42"}},"in_reply_to_id":177776959},"pull_request":{"url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42","id":177557499,"html_url":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42","diff_url":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42.diff","patch_url":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42.patch","issue_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/42","number":42,"state":"open","locked":false,"title":"LPS-0 DO NOT MERGE Run all forms tests","user":{"login":"alinedoleron","id":26491796,"avatar_url":"https://avatars1.githubusercontent.com/u/26491796?v=4","gravatar_id":"","url":"https://api.github.com/users/alinedoleron","html_url":"https://github.com/alinedoleron","followers_url":"https://api.github.com/users/alinedoleron/followers","following_url":"https://api.github.com/users/alinedoleron/following{/other_user}","gists_url":"https://api.github.com/users/alinedoleron/gists{/gist_id}","starred_url":"https://api.github.com/users/alinedoleron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinedoleron/subscriptions","organizations_url":"https://api.github.com/users/alinedoleron/orgs","repos_url":"https://api.github.com/users/alinedoleron/repos","events_url":"https://api.github.com/users/alinedoleron/events{/privacy}","received_events_url":"https://api.github.com/users/alinedoleron/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-03-26T20:23:32Z","updated_at":"2018-03-28T18:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f72e781aa881056ebc40e9cdceaa3a0886b7be2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":873724301,"url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42/commits","review_comments_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42/comments","review_comment_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/42/comments","statuses_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/statuses/13d5296b97ea5dec6f19acacaf2643557bf0a5ac","head":{"label":"alinedoleron:LPS-78779","ref":"LPS-78779","sha":"13d5296b97ea5dec6f19acacaf2643557bf0a5ac","user":{"login":"alinedoleron","id":26491796,"avatar_url":"https://avatars1.githubusercontent.com/u/26491796?v=4","gravatar_id":"","url":"https://api.github.com/users/alinedoleron","html_url":"https://github.com/alinedoleron","followers_url":"https://api.github.com/users/alinedoleron/followers","following_url":"https://api.github.com/users/alinedoleron/following{/other_user}","gists_url":"https://api.github.com/users/alinedoleron/gists{/gist_id}","starred_url":"https://api.github.com/users/alinedoleron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinedoleron/subscriptions","organizations_url":"https://api.github.com/users/alinedoleron/orgs","repos_url":"https://api.github.com/users/alinedoleron/repos","events_url":"https://api.github.com/users/alinedoleron/events{/privacy}","received_events_url":"https://api.github.com/users/alinedoleron/received_events","type":"User","site_admin":false},"repo":{"id":104886028,"name":"liferay-portal","full_name":"alinedoleron/liferay-portal","owner":{"login":"alinedoleron","id":26491796,"avatar_url":"https://avatars1.githubusercontent.com/u/26491796?v=4","gravatar_id":"","url":"https://api.github.com/users/alinedoleron","html_url":"https://github.com/alinedoleron","followers_url":"https://api.github.com/users/alinedoleron/followers","following_url":"https://api.github.com/users/alinedoleron/following{/other_user}","gists_url":"https://api.github.com/users/alinedoleron/gists{/gist_id}","starred_url":"https://api.github.com/users/alinedoleron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinedoleron/subscriptions","organizations_url":"https://api.github.com/users/alinedoleron/orgs","repos_url":"https://api.github.com/users/alinedoleron/repos","events_url":"https://api.github.com/users/alinedoleron/events{/privacy}","received_events_url":"https://api.github.com/users/alinedoleron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alinedoleron/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/alinedoleron/liferay-portal","forks_url":"https://api.github.com/repos/alinedoleron/liferay-portal/forks","keys_url":"https://api.github.com/repos/alinedoleron/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alinedoleron/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alinedoleron/liferay-portal/teams","hooks_url":"https://api.github.com/repos/alinedoleron/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/alinedoleron/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/alinedoleron/liferay-portal/events","assignees_url":"https://api.github.com/repos/alinedoleron/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/alinedoleron/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/alinedoleron/liferay-portal/tags","blobs_url":"https://api.github.com/repos/alinedoleron/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alinedoleron/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alinedoleron/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/alinedoleron/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alinedoleron/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/alinedoleron/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/alinedoleron/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/alinedoleron/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/alinedoleron/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/alinedoleron/liferay-portal/subscription","commits_url":"https://api.github.com/repos/alinedoleron/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/alinedoleron/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/alinedoleron/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/alinedoleron/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/alinedoleron/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/alinedoleron/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alinedoleron/liferay-portal/merges","archive_url":"https://api.github.com/repos/alinedoleron/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alinedoleron/liferay-portal/downloads","issues_url":"https://api.github.com/repos/alinedoleron/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/alinedoleron/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/alinedoleron/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/alinedoleron/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alinedoleron/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/alinedoleron/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/alinedoleron/liferay-portal/deployments","created_at":"2017-09-26T13:08:55Z","updated_at":"2018-03-28T17:18:09Z","pushed_at":"2018-03-28T17:56:29Z","git_url":"git://github.com/alinedoleron/liferay-portal.git","ssh_url":"git@github.com:alinedoleron/liferay-portal.git","clone_url":"https://github.com/alinedoleron/liferay-portal.git","svn_url":"https://github.com/alinedoleron/liferay-portal","homepage":"http://liferay.com","size":12566857,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"clovisdasilvaneto:master","ref":"master","sha":"9012049451d9c8849f9722f12156f5baeb7a5fec","user":{"login":"clovisdasilvaneto","id":4555665,"avatar_url":"https://avatars1.githubusercontent.com/u/4555665?v=4","gravatar_id":"","url":"https://api.github.com/users/clovisdasilvaneto","html_url":"https://github.com/clovisdasilvaneto","followers_url":"https://api.github.com/users/clovisdasilvaneto/followers","following_url":"https://api.github.com/users/clovisdasilvaneto/following{/other_user}","gists_url":"https://api.github.com/users/clovisdasilvaneto/gists{/gist_id}","starred_url":"https://api.github.com/users/clovisdasilvaneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clovisdasilvaneto/subscriptions","organizations_url":"https://api.github.com/users/clovisdasilvaneto/orgs","repos_url":"https://api.github.com/users/clovisdasilvaneto/repos","events_url":"https://api.github.com/users/clovisdasilvaneto/events{/privacy}","received_events_url":"https://api.github.com/users/clovisdasilvaneto/received_events","type":"User","site_admin":false},"repo":{"id":102119762,"name":"liferay-portal","full_name":"clovisdasilvaneto/liferay-portal","owner":{"login":"clovisdasilvaneto","id":4555665,"avatar_url":"https://avatars1.githubusercontent.com/u/4555665?v=4","gravatar_id":"","url":"https://api.github.com/users/clovisdasilvaneto","html_url":"https://github.com/clovisdasilvaneto","followers_url":"https://api.github.com/users/clovisdasilvaneto/followers","following_url":"https://api.github.com/users/clovisdasilvaneto/following{/other_user}","gists_url":"https://api.github.com/users/clovisdasilvaneto/gists{/gist_id}","starred_url":"https://api.github.com/users/clovisdasilvaneto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clovisdasilvaneto/subscriptions","organizations_url":"https://api.github.com/users/clovisdasilvaneto/orgs","repos_url":"https://api.github.com/users/clovisdasilvaneto/repos","events_url":"https://api.github.com/users/clovisdasilvaneto/events{/privacy}","received_events_url":"https://api.github.com/users/clovisdasilvaneto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clovisdasilvaneto/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal","forks_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/forks","keys_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/teams","hooks_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/events","assignees_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/tags","blobs_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/subscription","commits_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/merges","archive_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/downloads","issues_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/deployments","created_at":"2017-09-01T14:12:38Z","updated_at":"2018-03-28T17:56:32Z","pushed_at":"2018-03-28T18:13:47Z","git_url":"git://github.com/clovisdasilvaneto/liferay-portal.git","ssh_url":"git@github.com:clovisdasilvaneto/liferay-portal.git","clone_url":"https://github.com/clovisdasilvaneto/liferay-portal.git","svn_url":"https://github.com/clovisdasilvaneto/liferay-portal","homepage":"http://liferay.com","size":12565708,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42"},"html":{"href":"https://github.com/clovisdasilvaneto/liferay-portal/pull/42"},"issue":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/42"},"comments":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/clovisdasilvaneto/liferay-portal/statuses/13d5296b97ea5dec6f19acacaf2643557bf0a5ac"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alinedoleron"}}