{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/jurismarches/luqum/pulls/19","id":155137925,"html_url":"https://github.com/jurismarches/luqum/pull/19","diff_url":"https://github.com/jurismarches/luqum/pull/19.diff","patch_url":"https://github.com/jurismarches/luqum/pull/19.patch","issue_url":"https://api.github.com/repos/jurismarches/luqum/issues/19","number":19,"state":"closed","locked":false,"title":"Remove \"type\": \"phrase\" from `match` queries","user":{"login":"davidlmorton","id":650482,"avatar_url":"https://avatars1.githubusercontent.com/u/650482?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlmorton","html_url":"https://github.com/davidlmorton","followers_url":"https://api.github.com/users/davidlmorton/followers","following_url":"https://api.github.com/users/davidlmorton/following{/other_user}","gists_url":"https://api.github.com/users/davidlmorton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlmorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlmorton/subscriptions","organizations_url":"https://api.github.com/users/davidlmorton/orgs","repos_url":"https://api.github.com/users/davidlmorton/repos","events_url":"https://api.github.com/users/davidlmorton/events{/privacy}","received_events_url":"https://api.github.com/users/davidlmorton/received_events","type":"User","site_admin":false},"body":"I don't expect you'd like to take this PR as-is.  I would like you to consider making the choice between `match` and `match_phrase` queries configurable somehow.  For my use-cases the `match_phrase` query isn't appropriate, so I just removed it.  I think `match_phrase` should be the default (as it is the only choice now), with the ability to configure behavior (ideally per field/subfield).\r\n\r\nAlso, \"type\": \"phrase\" is deprecated by newer versions of ES.  I get a warning like this when I try to execute a query built with \"type\": \"phrase\" in it:\r\n\r\n```\r\n#! Deprecation: Deprecated field [type] used, replaced by [match_phrase and match_phrase_prefix query]\r\n```","created_at":"2017-11-28T17:39:18Z","updated_at":"2018-03-20T13:41:13Z","closed_at":"2018-03-20T13:41:13Z","merged_at":null,"merge_commit_sha":"fda4d539d296850053dc2a75ce145a14c4a4dc05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jurismarches/luqum/pulls/19/commits","review_comments_url":"https://api.github.com/repos/jurismarches/luqum/pulls/19/comments","review_comment_url":"https://api.github.com/repos/jurismarches/luqum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jurismarches/luqum/issues/19/comments","statuses_url":"https://api.github.com/repos/jurismarches/luqum/statuses/3a7633ddd5bb9f77b72dd216fca9d79474cd6a0e","head":{"label":"davidlmorton:remove-type-phrase","ref":"remove-type-phrase","sha":"3a7633ddd5bb9f77b72dd216fca9d79474cd6a0e","user":{"login":"davidlmorton","id":650482,"avatar_url":"https://avatars1.githubusercontent.com/u/650482?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlmorton","html_url":"https://github.com/davidlmorton","followers_url":"https://api.github.com/users/davidlmorton/followers","following_url":"https://api.github.com/users/davidlmorton/following{/other_user}","gists_url":"https://api.github.com/users/davidlmorton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlmorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlmorton/subscriptions","organizations_url":"https://api.github.com/users/davidlmorton/orgs","repos_url":"https://api.github.com/users/davidlmorton/repos","events_url":"https://api.github.com/users/davidlmorton/events{/privacy}","received_events_url":"https://api.github.com/users/davidlmorton/received_events","type":"User","site_admin":false},"repo":{"id":112361137,"name":"luqum","full_name":"davidlmorton/luqum","owner":{"login":"davidlmorton","id":650482,"avatar_url":"https://avatars1.githubusercontent.com/u/650482?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlmorton","html_url":"https://github.com/davidlmorton","followers_url":"https://api.github.com/users/davidlmorton/followers","following_url":"https://api.github.com/users/davidlmorton/following{/other_user}","gists_url":"https://api.github.com/users/davidlmorton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlmorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlmorton/subscriptions","organizations_url":"https://api.github.com/users/davidlmorton/orgs","repos_url":"https://api.github.com/users/davidlmorton/repos","events_url":"https://api.github.com/users/davidlmorton/events{/privacy}","received_events_url":"https://api.github.com/users/davidlmorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidlmorton/luqum","description":"A lucene query parser in Python, using PLY. \"luqum\" as in LUcene QUery Manipolator","fork":true,"url":"https://api.github.com/repos/davidlmorton/luqum","forks_url":"https://api.github.com/repos/davidlmorton/luqum/forks","keys_url":"https://api.github.com/repos/davidlmorton/luqum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidlmorton/luqum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidlmorton/luqum/teams","hooks_url":"https://api.github.com/repos/davidlmorton/luqum/hooks","issue_events_url":"https://api.github.com/repos/davidlmorton/luqum/issues/events{/number}","events_url":"https://api.github.com/repos/davidlmorton/luqum/events","assignees_url":"https://api.github.com/repos/davidlmorton/luqum/assignees{/user}","branches_url":"https://api.github.com/repos/davidlmorton/luqum/branches{/branch}","tags_url":"https://api.github.com/repos/davidlmorton/luqum/tags","blobs_url":"https://api.github.com/repos/davidlmorton/luqum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidlmorton/luqum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidlmorton/luqum/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidlmorton/luqum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidlmorton/luqum/statuses/{sha}","languages_url":"https://api.github.com/repos/davidlmorton/luqum/languages","stargazers_url":"https://api.github.com/repos/davidlmorton/luqum/stargazers","contributors_url":"https://api.github.com/repos/davidlmorton/luqum/contributors","subscribers_url":"https://api.github.com/repos/davidlmorton/luqum/subscribers","subscription_url":"https://api.github.com/repos/davidlmorton/luqum/subscription","commits_url":"https://api.github.com/repos/davidlmorton/luqum/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidlmorton/luqum/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidlmorton/luqum/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidlmorton/luqum/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidlmorton/luqum/contents/{+path}","compare_url":"https://api.github.com/repos/davidlmorton/luqum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidlmorton/luqum/merges","archive_url":"https://api.github.com/repos/davidlmorton/luqum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidlmorton/luqum/downloads","issues_url":"https://api.github.com/repos/davidlmorton/luqum/issues{/number}","pulls_url":"https://api.github.com/repos/davidlmorton/luqum/pulls{/number}","milestones_url":"https://api.github.com/repos/davidlmorton/luqum/milestones{/number}","notifications_url":"https://api.github.com/repos/davidlmorton/luqum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidlmorton/luqum/labels{/name}","releases_url":"https://api.github.com/repos/davidlmorton/luqum/releases{/id}","deployments_url":"https://api.github.com/repos/davidlmorton/luqum/deployments","created_at":"2017-11-28T16:35:26Z","updated_at":"2017-11-28T16:35:27Z","pushed_at":"2017-11-28T17:17:25Z","git_url":"git://github.com/davidlmorton/luqum.git","ssh_url":"git@github.com:davidlmorton/luqum.git","clone_url":"https://github.com/davidlmorton/luqum.git","svn_url":"https://github.com/davidlmorton/luqum","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jurismarches:master","ref":"master","sha":"ffdda1be913cbf65b3a1c18b06e1b366db60bb61","user":{"login":"jurismarches","id":5868152,"avatar_url":"https://avatars1.githubusercontent.com/u/5868152?v=4","gravatar_id":"","url":"https://api.github.com/users/jurismarches","html_url":"https://github.com/jurismarches","followers_url":"https://api.github.com/users/jurismarches/followers","following_url":"https://api.github.com/users/jurismarches/following{/other_user}","gists_url":"https://api.github.com/users/jurismarches/gists{/gist_id}","starred_url":"https://api.github.com/users/jurismarches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurismarches/subscriptions","organizations_url":"https://api.github.com/users/jurismarches/orgs","repos_url":"https://api.github.com/users/jurismarches/repos","events_url":"https://api.github.com/users/jurismarches/events{/privacy}","received_events_url":"https://api.github.com/users/jurismarches/received_events","type":"Organization","site_admin":false},"repo":{"id":49724057,"name":"luqum","full_name":"jurismarches/luqum","owner":{"login":"jurismarches","id":5868152,"avatar_url":"https://avatars1.githubusercontent.com/u/5868152?v=4","gravatar_id":"","url":"https://api.github.com/users/jurismarches","html_url":"https://github.com/jurismarches","followers_url":"https://api.github.com/users/jurismarches/followers","following_url":"https://api.github.com/users/jurismarches/following{/other_user}","gists_url":"https://api.github.com/users/jurismarches/gists{/gist_id}","starred_url":"https://api.github.com/users/jurismarches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurismarches/subscriptions","organizations_url":"https://api.github.com/users/jurismarches/orgs","repos_url":"https://api.github.com/users/jurismarches/repos","events_url":"https://api.github.com/users/jurismarches/events{/privacy}","received_events_url":"https://api.github.com/users/jurismarches/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jurismarches/luqum","description":"A lucene query parser generating ElasticSearch queries  and more !","fork":false,"url":"https://api.github.com/repos/jurismarches/luqum","forks_url":"https://api.github.com/repos/jurismarches/luqum/forks","keys_url":"https://api.github.com/repos/jurismarches/luqum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jurismarches/luqum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jurismarches/luqum/teams","hooks_url":"https://api.github.com/repos/jurismarches/luqum/hooks","issue_events_url":"https://api.github.com/repos/jurismarches/luqum/issues/events{/number}","events_url":"https://api.github.com/repos/jurismarches/luqum/events","assignees_url":"https://api.github.com/repos/jurismarches/luqum/assignees{/user}","branches_url":"https://api.github.com/repos/jurismarches/luqum/branches{/branch}","tags_url":"https://api.github.com/repos/jurismarches/luqum/tags","blobs_url":"https://api.github.com/repos/jurismarches/luqum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jurismarches/luqum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jurismarches/luqum/git/refs{/sha}","trees_url":"https://api.github.com/repos/jurismarches/luqum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jurismarches/luqum/statuses/{sha}","languages_url":"https://api.github.com/repos/jurismarches/luqum/languages","stargazers_url":"https://api.github.com/repos/jurismarches/luqum/stargazers","contributors_url":"https://api.github.com/repos/jurismarches/luqum/contributors","subscribers_url":"https://api.github.com/repos/jurismarches/luqum/subscribers","subscription_url":"https://api.github.com/repos/jurismarches/luqum/subscription","commits_url":"https://api.github.com/repos/jurismarches/luqum/commits{/sha}","git_commits_url":"https://api.github.com/repos/jurismarches/luqum/git/commits{/sha}","comments_url":"https://api.github.com/repos/jurismarches/luqum/comments{/number}","issue_comment_url":"https://api.github.com/repos/jurismarches/luqum/issues/comments{/number}","contents_url":"https://api.github.com/repos/jurismarches/luqum/contents/{+path}","compare_url":"https://api.github.com/repos/jurismarches/luqum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jurismarches/luqum/merges","archive_url":"https://api.github.com/repos/jurismarches/luqum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jurismarches/luqum/downloads","issues_url":"https://api.github.com/repos/jurismarches/luqum/issues{/number}","pulls_url":"https://api.github.com/repos/jurismarches/luqum/pulls{/number}","milestones_url":"https://api.github.com/repos/jurismarches/luqum/milestones{/number}","notifications_url":"https://api.github.com/repos/jurismarches/luqum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jurismarches/luqum/labels{/name}","releases_url":"https://api.github.com/repos/jurismarches/luqum/releases{/id}","deployments_url":"https://api.github.com/repos/jurismarches/luqum/deployments","created_at":"2016-01-15T14:37:28Z","updated_at":"2018-03-20T13:31:19Z","pushed_at":"2018-03-20T13:31:26Z","git_url":"git://github.com/jurismarches/luqum.git","ssh_url":"git@github.com:jurismarches/luqum.git","clone_url":"https://github.com/jurismarches/luqum.git","svn_url":"https://github.com/jurismarches/luqum","homepage":"","size":265,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":5,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jurismarches/luqum/pulls/19"},"html":{"href":"https://github.com/jurismarches/luqum/pull/19"},"issue":{"href":"https://api.github.com/repos/jurismarches/luqum/issues/19"},"comments":{"href":"https://api.github.com/repos/jurismarches/luqum/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/jurismarches/luqum/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/jurismarches/luqum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jurismarches/luqum/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/jurismarches/luqum/statuses/3a7633ddd5bb9f77b72dd216fca9d79474cd6a0e"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"alexgarel"}}