{"action":"closed","number":1322,"pull_request":{"url":"https://api.github.com/repos/pmd/pmd/pulls/1322","id":211253967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjUzOTY3","html_url":"https://github.com/pmd/pmd/pull/1322","diff_url":"https://github.com/pmd/pmd/pull/1322.diff","patch_url":"https://github.com/pmd/pmd/pull/1322.patch","issue_url":"https://api.github.com/repos/pmd/pmd/issues/1322","number":1322,"state":"closed","locked":false,"title":"[core] Improvements and planned updates around PropertySource","user":{"login":"oowekyala","id":24524930,"node_id":"MDQ6VXNlcjI0NTI0OTMw","avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"body":"I was working on making required properties a thing for #973 (the last comments), and it occurred to me that for that to work, PropertySources should provide kind of the same functionality as RuleReferences: track the overridden properties. This was already kind of the case, except it wasn't documented. \r\n\r\nThis PR brushes up on PropertySource, fixing some inconsistencies, deprecating unneeded API, and making it consistent with RuleReference. The goal for 7.0.0 would be to have RuleReference extend AbstractPropertySource to share the implementation. This can't be done right now as making AbstractDelegateRule extend AbstractPropertySource would break the contract of AbstractDelegateRule by baking in some property overriding facilities. Since AbstractDelegateRule is only used by RuleReference anyway, I think we can remove it without regret come 7.0.0","created_at":"2018-08-27T22:52:50Z","updated_at":"2018-09-11T12:14:24Z","closed_at":"2018-09-11T12:14:24Z","merged_at":"2018-09-11T12:14:24Z","merge_commit_sha":"faabb2a84e11c081f6ef98779a597ec9f6826130","assignee":{"login":"adangel","id":1573684,"node_id":"MDQ6VXNlcjE1NzM2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false},"assignees":[{"login":"adangel","id":1573684,"node_id":"MDQ6VXNlcjE1NzM2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":9035846,"node_id":"MDU6TGFiZWw5MDM1ODQ2","url":"https://api.github.com/repos/pmd/pmd/labels/an:enhancement","name":"an:enhancement","color":"84b6eb","default":false},{"id":491899533,"node_id":"MDU6TGFiZWw0OTE4OTk1MzM=","url":"https://api.github.com/repos/pmd/pmd/labels/in:pmd-internals","name":"in:pmd-internals","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/pmd/pmd/milestones/25","html_url":"https://github.com/pmd/pmd/milestone/25","labels_url":"https://api.github.com/repos/pmd/pmd/milestones/25/labels","id":3615329,"node_id":"MDk6TWlsZXN0b25lMzYxNTMyOQ==","number":25,"title":"6.8.0","description":"","creator":{"login":"adangel","id":1573684,"node_id":"MDQ6VXNlcjE1NzM2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":9,"state":"open","created_at":"2018-09-01T18:11:12Z","updated_at":"2018-09-11T12:14:24Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pmd/pmd/pulls/1322/commits","review_comments_url":"https://api.github.com/repos/pmd/pmd/pulls/1322/comments","review_comment_url":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmd/pmd/issues/1322/comments","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/faabb2a84e11c081f6ef98779a597ec9f6826130","head":{"label":"oowekyala:improve-property-source","ref":"improve-property-source","sha":"faabb2a84e11c081f6ef98779a597ec9f6826130","user":{"login":"oowekyala","id":24524930,"node_id":"MDQ6VXNlcjI0NTI0OTMw","avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"repo":{"id":84992686,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk5MjY4Ng==","name":"pmd","full_name":"oowekyala/pmd","owner":{"login":"oowekyala","id":24524930,"node_id":"MDQ6VXNlcjI0NTI0OTMw","avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oowekyala/pmd","description":null,"fork":true,"url":"https://api.github.com/repos/oowekyala/pmd","forks_url":"https://api.github.com/repos/oowekyala/pmd/forks","keys_url":"https://api.github.com/repos/oowekyala/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oowekyala/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oowekyala/pmd/teams","hooks_url":"https://api.github.com/repos/oowekyala/pmd/hooks","issue_events_url":"https://api.github.com/repos/oowekyala/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/oowekyala/pmd/events","assignees_url":"https://api.github.com/repos/oowekyala/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/oowekyala/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/oowekyala/pmd/tags","blobs_url":"https://api.github.com/repos/oowekyala/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oowekyala/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oowekyala/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/oowekyala/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oowekyala/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/oowekyala/pmd/languages","stargazers_url":"https://api.github.com/repos/oowekyala/pmd/stargazers","contributors_url":"https://api.github.com/repos/oowekyala/pmd/contributors","subscribers_url":"https://api.github.com/repos/oowekyala/pmd/subscribers","subscription_url":"https://api.github.com/repos/oowekyala/pmd/subscription","commits_url":"https://api.github.com/repos/oowekyala/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/oowekyala/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/oowekyala/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/oowekyala/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/oowekyala/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/oowekyala/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oowekyala/pmd/merges","archive_url":"https://api.github.com/repos/oowekyala/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oowekyala/pmd/downloads","issues_url":"https://api.github.com/repos/oowekyala/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/oowekyala/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/oowekyala/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/oowekyala/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oowekyala/pmd/labels{/name}","releases_url":"https://api.github.com/repos/oowekyala/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/oowekyala/pmd/deployments","created_at":"2017-03-14T20:11:44Z","updated_at":"2018-07-27T23:42:15Z","pushed_at":"2018-09-04T10:30:47Z","git_url":"git://github.com/oowekyala/pmd.git","ssh_url":"git@github.com:oowekyala/pmd.git","clone_url":"https://github.com/oowekyala/pmd.git","svn_url":"https://github.com/oowekyala/pmd","homepage":"https://pmd.github.io","size":245614,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmd:master","ref":"master","sha":"079fe951523d9a17308c5069b27022942d85e15d","user":{"login":"pmd","id":1958157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTgxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"repo":{"id":4992906,"node_id":"MDEwOlJlcG9zaXRvcnk0OTkyOTA2","name":"pmd","full_name":"pmd/pmd","owner":{"login":"pmd","id":1958157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTgxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmd/pmd","description":"An extensible cross-language static code analyzer.","fork":false,"url":"https://api.github.com/repos/pmd/pmd","forks_url":"https://api.github.com/repos/pmd/pmd/forks","keys_url":"https://api.github.com/repos/pmd/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmd/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmd/pmd/teams","hooks_url":"https://api.github.com/repos/pmd/pmd/hooks","issue_events_url":"https://api.github.com/repos/pmd/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/pmd/pmd/events","assignees_url":"https://api.github.com/repos/pmd/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/pmd/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/pmd/pmd/tags","blobs_url":"https://api.github.com/repos/pmd/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmd/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmd/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmd/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/pmd/pmd/languages","stargazers_url":"https://api.github.com/repos/pmd/pmd/stargazers","contributors_url":"https://api.github.com/repos/pmd/pmd/contributors","subscribers_url":"https://api.github.com/repos/pmd/pmd/subscribers","subscription_url":"https://api.github.com/repos/pmd/pmd/subscription","commits_url":"https://api.github.com/repos/pmd/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmd/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmd/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmd/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmd/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/pmd/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmd/pmd/merges","archive_url":"https://api.github.com/repos/pmd/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmd/pmd/downloads","issues_url":"https://api.github.com/repos/pmd/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/pmd/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/pmd/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/pmd/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmd/pmd/labels{/name}","releases_url":"https://api.github.com/repos/pmd/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/pmd/pmd/deployments","created_at":"2012-07-11T18:03:00Z","updated_at":"2018-09-11T08:26:47Z","pushed_at":"2018-09-11T12:14:21Z","git_url":"git://github.com/pmd/pmd.git","ssh_url":"git@github.com:pmd/pmd.git","clone_url":"https://github.com/pmd/pmd.git","svn_url":"https://github.com/pmd/pmd","homepage":"https://pmd.github.io","size":248784,"stargazers_count":1772,"watchers_count":1772,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":600,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":600,"open_issues":190,"watchers":1772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1322"},"html":{"href":"https://github.com/pmd/pmd/pull/1322"},"issue":{"href":"https://api.github.com/repos/pmd/pmd/issues/1322"},"comments":{"href":"https://api.github.com/repos/pmd/pmd/issues/1322/comments"},"review_comments":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1322/comments"},"review_comment":{"href":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmd/pmd/pulls/1322/commits"},"statuses":{"href":"https://api.github.com/repos/pmd/pmd/statuses/faabb2a84e11c081f6ef98779a597ec9f6826130"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adangel","id":1573684,"node_id":"MDQ6VXNlcjE1NzM2ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":9,"maintainer_can_modify":false,"commits":2,"additions":233,"deletions":104,"changed_files":11}}
{"actor":{"display_login":"adangel"}}