{"action":"created","issue":{"url":"https://api.github.com/repos/google/kythe/issues/684","repository_url":"https://api.github.com/repos/google/kythe","labels_url":"https://api.github.com/repos/google/kythe/issues/684/labels{/name}","comments_url":"https://api.github.com/repos/google/kythe/issues/684/comments","events_url":"https://api.github.com/repos/google/kythe/issues/684/events","html_url":"https://github.com/google/kythe/issues/684","id":335575665,"node_id":"MDU6SXNzdWUzMzU1NzU2NjU=","number":684,"title":"Deduplicate output early using a memcache. [phab:D452]","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"labels":[{"id":932824657,"node_id":"MDU6TGFiZWw5MzI4MjQ2NTc=","url":"https://api.github.com/repos/google/kythe/labels/phabricator%20diff","name":"phabricator diff","color":"efd57f","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-06-25T21:31:51Z","updated_at":"2018-06-26T18:36:14Z","closed_at":"2018-06-25T21:31:52Z","author_association":"COLLABORATOR","body":"_Created by **zarko** at 2015-08-18 00:07:44_: \n\nThis diff gathers output entries into bunches based on\nhigher-level semantic signals. Before being emitted, these\nbunches are hashed and the hash is checked against a memcache.\nIf the memcache holds the hash, then the bunch is dropped on\nthe floor. Bunches are merged together to maintain a\nminimum size (to avoid overtaxing the memcache) and they are\nsplit to avoid a maximum size (to make hashing more effective).\n\nWith the cache turned off, the speedup for raw computation\nis ~0.97 (e.g., there is a slight slowdown) for the previous\nset of four benchmark units. With the cache off and when we're\nwriting to a graphstore with the *cxx_common* .kindex files\nthat we used to benchmark the hash patch (#682), the speedup is\n~1.04. With the cache on, the speedup for the *cxx_common*\nfiles is ~1.39. (The baseline for this speedup is the time\ntaken for *cxx_common* with vname hashing patched in; without it,\nthe speedup from pre-#682 is ~1.65.)"},"comment":{"url":"https://api.github.com/repos/google/kythe/issues/comments/400419218","html_url":"https://github.com/google/kythe/issues/684#issuecomment-400419218","issue_url":"https://api.github.com/repos/google/kythe/issues/684","id":400419218,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQxOTIxOA==","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T18:36:14Z","updated_at":"2018-06-26T18:36:14Z","author_association":"COLLABORATOR","body":"_**zarko** wrote at 2015-08-20 19:30:25_:\n\n  - Use std::vector<unsigned char> instead of std::string for buffers.\n"}}
{"actor":{"display_login":"kythe"}}