{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/205257767","pull_request_review_id":140494263,"id":205257767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTI1Nzc2Nw==","diff_hunk":"@@ -110,15 +110,15 @@ TEST_CASE(\"rnn\") {\n     LSTM model(2, 2);\n     for (auto& v : model->parameters()) {\n       float size = v->numel();\n-      auto p = static_cast<float*>(v->data().storage()->data());\n+      auto p = static_cast<float*>(v->data().storage()->storage_impl_->data());","path":"test/cpp/api/rnn.cpp","position":5,"original_position":5,"commit_id":"aa42020b145ba81eedf5e82a75ead6c838ef5070","original_commit_id":"aa42020b145ba81eedf5e82a75ead6c838ef5070","user":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"Why not just put the actual methods on Storage? Or even better, implement `->` overloading so you don't have to enumerate all of them.","created_at":"2018-07-25T20:49:52Z","updated_at":"2018-07-25T20:49:52Z","html_url":"https://github.com/pytorch/pytorch/pull/9772#discussion_r205257767","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9772","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/205257767"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9772#discussion_r205257767"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9772"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/9772","id":203598511,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTk4NTEx","html_url":"https://github.com/pytorch/pytorch/pull/9772","diff_url":"https://github.com/pytorch/pytorch/pull/9772.diff","patch_url":"https://github.com/pytorch/pytorch/pull/9772.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/9772","number":9772,"state":"open","locked":false,"title":"Merge THStorage into at::Storage","user":{"login":"cpuhrsch","id":1716488,"node_id":"MDQ6VXNlcjE3MTY0ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-24T17:20:54Z","updated_at":"2018-07-25T20:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28da674845151ac2c0674ae839cf30ee3a473d44","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"node_id":"MDQ6VXNlcjY1NTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"ebetica","id":3605224,"node_id":"MDQ6VXNlcjM2MDUyMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3605224?v=4","gravatar_id":"","url":"https://api.github.com/users/ebetica","html_url":"https://github.com/ebetica","followers_url":"https://api.github.com/users/ebetica/followers","following_url":"https://api.github.com/users/ebetica/following{/other_user}","gists_url":"https://api.github.com/users/ebetica/gists{/gist_id}","starred_url":"https://api.github.com/users/ebetica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebetica/subscriptions","organizations_url":"https://api.github.com/users/ebetica/orgs","repos_url":"https://api.github.com/users/ebetica/repos","events_url":"https://api.github.com/users/ebetica/events{/privacy}","received_events_url":"https://api.github.com/users/ebetica/received_events","type":"User","site_admin":false},{"login":"apaszke","id":4583066,"node_id":"MDQ6VXNlcjQ1ODMwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false},{"login":"goldsborough","id":6429851,"node_id":"MDQ6VXNlcjY0Mjk4NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9772/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/9772/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/9772/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/aa42020b145ba81eedf5e82a75ead6c838ef5070","head":{"label":"cpuhrsch:tmmerge","ref":"tmmerge","sha":"aa42020b145ba81eedf5e82a75ead6c838ef5070","user":{"login":"cpuhrsch","id":1716488,"node_id":"MDQ6VXNlcjE3MTY0ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"repo":{"id":118517346,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MTczNDY=","name":"pytorch","full_name":"cpuhrsch/pytorch","owner":{"login":"cpuhrsch","id":1716488,"node_id":"MDQ6VXNlcjE3MTY0ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpuhrsch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/cpuhrsch/pytorch","forks_url":"https://api.github.com/repos/cpuhrsch/pytorch/forks","keys_url":"https://api.github.com/repos/cpuhrsch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuhrsch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuhrsch/pytorch/teams","hooks_url":"https://api.github.com/repos/cpuhrsch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/cpuhrsch/pytorch/events","assignees_url":"https://api.github.com/repos/cpuhrsch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/cpuhrsch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/cpuhrsch/pytorch/tags","blobs_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuhrsch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuhrsch/pytorch/languages","stargazers_url":"https://api.github.com/repos/cpuhrsch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/cpuhrsch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/cpuhrsch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/cpuhrsch/pytorch/subscription","commits_url":"https://api.github.com/repos/cpuhrsch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuhrsch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpuhrsch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/cpuhrsch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuhrsch/pytorch/merges","archive_url":"https://api.github.com/repos/cpuhrsch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuhrsch/pytorch/downloads","issues_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/cpuhrsch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuhrsch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuhrsch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuhrsch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/cpuhrsch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/cpuhrsch/pytorch/deployments","created_at":"2018-01-22T21:26:11Z","updated_at":"2018-05-14T16:24:59Z","pushed_at":"2018-07-25T19:21:41Z","git_url":"git://github.com/cpuhrsch/pytorch.git","ssh_url":"git@github.com:cpuhrsch/pytorch.git","clone_url":"https://github.com/cpuhrsch/pytorch.git","svn_url":"https://github.com/cpuhrsch/pytorch","homepage":"http://pytorch.org","size":67111,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"4b0098f3ae1a445760f1bf743e1accbf7ae70b56","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-07-25T20:42:27Z","pushed_at":"2018-07-25T20:48:38Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":65053,"stargazers_count":17346,"watchers_count":17346,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4048,"mirror_url":null,"archived":false,"open_issues_count":1528,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4048,"open_issues":1528,"watchers":17346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9772"},"html":{"href":"https://github.com/pytorch/pytorch/pull/9772"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9772"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/9772/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9772/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/9772/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/aa42020b145ba81eedf5e82a75ead6c838ef5070"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ezyang"}}