{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297/events","html_url":"https://github.com/kubernetes/kubernetes/pull/62297","id":312712380,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwNDQ2MDE1","number":62297,"title":"Refactoring GCE Disk APIs to use generated client","user":{"login":"verult","id":1689416,"node_id":"MDQ6VXNlcjE2ODk0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1689416?v=4","gravatar_id":"","url":"https://api.github.com/users/verult","html_url":"https://github.com/verult","followers_url":"https://api.github.com/users/verult/followers","following_url":"https://api.github.com/users/verult/following{/other_user}","gists_url":"https://api.github.com/users/verult/gists{/gist_id}","starred_url":"https://api.github.com/users/verult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verult/subscriptions","organizations_url":"https://api.github.com/users/verult/orgs","repos_url":"https://api.github.com/users/verult/repos","events_url":"https://api.github.com/users/verult/events{/privacy}","received_events_url":"https://api.github.com/users/verult/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253451093,"node_id":"MDU6TGFiZWwyNTM0NTEwOTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false},{"id":611767149,"node_id":"MDU6TGFiZWw2MTE3NjcxNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"assignees":[{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"node_id":"MDk6TWlsZXN0b25lMjg0ODM5Ng==","number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"node_id":"MDQ6VXNlcjkwMzYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":316,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-06-06T23:16:54Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2018-04-09T22:37:15Z","updated_at":"2018-06-06T23:17:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62297","html_url":"https://github.com/kubernetes/kubernetes/pull/62297","diff_url":"https://github.com/kubernetes/kubernetes/pull/62297.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62297.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: Improves maintainability and testing of GCE disks code.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #62296\r\n\r\nNote that `gen.go` and `gen_test.go` are generated files.\r\n\r\nI'm planning to do a more extensive refactor that takes advantage of the generated cloud provider mocks, but that'll be in a separate PR and will be a larger change.\r\n\r\n/cc @davidz627\r\n/assign @saad-ali \r\n/release-note-none\r\n/sig storage"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/395243564","html_url":"https://github.com/kubernetes/kubernetes/pull/62297#issuecomment-395243564","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62297","id":395243564,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTI0MzU2NA==","user":{"login":"k8s-merge-robot","id":13653959,"node_id":"MDQ6VXNlcjEzNjUzOTU5","avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T23:17:41Z","updated_at":"2018-06-06T23:17:41Z","author_association":"COLLABORATOR","body":"[MILESTONENOTIFIER] Milestone Pull Request: **Up-to-date for process**\n\n@saad-ali @verult\n\n<details open>\n<summary>Pull Request Labels</summary>\n\n- `sig/storage`: Pull Request will be escalated to these SIGs if needed.\n- `priority/critical-urgent`: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.\n- `kind/feature`: New functionality.\n</details>\n<details>\n<summary>Help</summary>\n<ul>\n <li><a href=\"https://git.k8s.io/sig-release/ephemera/issues.md\">Additional instructions</a></li>\n <li><a href=\"https://go.k8s.io/bot-commands\">Commands for setting labels</a></li>\n</ul>\n</details>"}}
{"actor":{"display_login":"k8s-merge-robot"}}