{"action":"closed","number":516,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516","id":211333553,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzMzNTUz","html_url":"https://github.com/alphagov/govuk-design-system/pull/516","diff_url":"https://github.com/alphagov/govuk-design-system/pull/516.diff","patch_url":"https://github.com/alphagov/govuk-design-system/pull/516.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/516","number":516,"state":"closed","locked":false,"title":"Rewrite \"search\" functionality to follow GOV.UK Frontend conventions","user":{"login":"igloosi","id":3758555,"node_id":"MDQ6VXNlcjM3NTg1NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3758555?v=4","gravatar_id":"","url":"https://api.github.com/users/igloosi","html_url":"https://github.com/igloosi","followers_url":"https://api.github.com/users/igloosi/followers","following_url":"https://api.github.com/users/igloosi/following{/other_user}","gists_url":"https://api.github.com/users/igloosi/gists{/gist_id}","starred_url":"https://api.github.com/users/igloosi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igloosi/subscriptions","organizations_url":"https://api.github.com/users/igloosi/orgs","repos_url":"https://api.github.com/users/igloosi/repos","events_url":"https://api.github.com/users/igloosi/events{/privacy}","received_events_url":"https://api.github.com/users/igloosi/received_events","type":"User","site_admin":false},"body":"This PR modernises search javascript to follow GOV.UK Frontend conventions\r\n- Use of data-module attribute to initialise the script\r\n- Rewrite functions to match they way they're written in GOV.UK Frontend\r\n\r\nEasier to review without whitespace: https://github.com/alphagov/govuk-design-system/pull/516/files?utf8=%E2%9C%93&diff=split&w=1","created_at":"2018-08-28T07:59:17Z","updated_at":"2018-09-05T09:59:02Z","closed_at":"2018-09-05T09:59:02Z","merged_at":"2018-09-05T09:59:02Z","merge_commit_sha":"fbebedefe007ea3685150ec129b0ac0a296ed879","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/516/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-design-system/statuses/32b07785c15c3f7570fe87569a340d48f11918ba","head":{"label":"alphagov:rewrite-search-to-follow-conventions","ref":"rewrite-search-to-follow-conventions","sha":"32b07785c15c3f7570fe87569a340d48f11918ba","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":93611204,"node_id":"MDEwOlJlcG9zaXRvcnk5MzYxMTIwNA==","name":"govuk-design-system","full_name":"alphagov/govuk-design-system","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-design-system","description":"One place for service teams to find styles, components and patterns for designing government services.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-design-system","forks_url":"https://api.github.com/repos/alphagov/govuk-design-system/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-design-system/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-design-system/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-design-system/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-design-system/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-design-system/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-design-system/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-design-system/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-design-system/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-design-system/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-design-system/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-design-system/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-design-system/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-design-system/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-design-system/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-design-system/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-design-system/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-design-system/deployments","created_at":"2017-06-07T08:27:16Z","updated_at":"2018-09-04T21:50:24Z","pushed_at":"2018-09-05T09:59:02Z","git_url":"git://github.com/alphagov/govuk-design-system.git","ssh_url":"git@github.com:alphagov/govuk-design-system.git","clone_url":"https://github.com/alphagov/govuk-design-system.git","svn_url":"https://github.com/alphagov/govuk-design-system","homepage":"https://www.gov.uk/design-system","size":3665,"stargazers_count":45,"watchers_count":45,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":22,"watchers":45,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"338d3ab23bccc20e16933699260ecc77667a73eb","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":93611204,"node_id":"MDEwOlJlcG9zaXRvcnk5MzYxMTIwNA==","name":"govuk-design-system","full_name":"alphagov/govuk-design-system","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-design-system","description":"One place for service teams to find styles, components and patterns for designing government services.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-design-system","forks_url":"https://api.github.com/repos/alphagov/govuk-design-system/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-design-system/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-design-system/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-design-system/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-design-system/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-design-system/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-design-system/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-design-system/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-design-system/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-design-system/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-design-system/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-design-system/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-design-system/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-design-system/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-design-system/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-design-system/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-design-system/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-design-system/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-design-system/deployments","created_at":"2017-06-07T08:27:16Z","updated_at":"2018-09-04T21:50:24Z","pushed_at":"2018-09-05T09:59:02Z","git_url":"git://github.com/alphagov/govuk-design-system.git","ssh_url":"git@github.com:alphagov/govuk-design-system.git","clone_url":"https://github.com/alphagov/govuk-design-system.git","svn_url":"https://github.com/alphagov/govuk-design-system","homepage":"https://www.gov.uk/design-system","size":3665,"stargazers_count":45,"watchers_count":45,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":22,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516"},"html":{"href":"https://github.com/alphagov/govuk-design-system/pull/516"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/issues/516"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-design-system/statuses/32b07785c15c3f7570fe87569a340d48f11918ba"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hannalaakso","id":5007934,"node_id":"MDQ6VXNlcjUwMDc5MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5007934?v=4","gravatar_id":"","url":"https://api.github.com/users/hannalaakso","html_url":"https://github.com/hannalaakso","followers_url":"https://api.github.com/users/hannalaakso/followers","following_url":"https://api.github.com/users/hannalaakso/following{/other_user}","gists_url":"https://api.github.com/users/hannalaakso/gists{/gist_id}","starred_url":"https://api.github.com/users/hannalaakso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannalaakso/subscriptions","organizations_url":"https://api.github.com/users/hannalaakso/orgs","repos_url":"https://api.github.com/users/hannalaakso/repos","events_url":"https://api.github.com/users/hannalaakso/events{/privacy}","received_events_url":"https://api.github.com/users/hannalaakso/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":130,"deletions":118,"changed_files":3}}
{"actor":{"display_login":"hannalaakso"}}