{"action":"closed","number":1025,"pull_request":{"url":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025","id":140224808,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQwMjI0ODA4","html_url":"https://github.com/popcodeorg/popcode/pull/1025","diff_url":"https://github.com/popcodeorg/popcode/pull/1025.diff","patch_url":"https://github.com/popcodeorg/popcode/pull/1025.patch","issue_url":"https://api.github.com/repos/popcodeorg/popcode/issues/1025","number":1025,"state":"closed","locked":false,"title":"Element highlighter","user":{"login":"pwjablonski","id":9774128,"node_id":"MDQ6VXNlcjk3NzQxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/9774128?v=4","gravatar_id":"","url":"https://api.github.com/users/pwjablonski","html_url":"https://github.com/pwjablonski","followers_url":"https://api.github.com/users/pwjablonski/followers","following_url":"https://api.github.com/users/pwjablonski/following{/other_user}","gists_url":"https://api.github.com/users/pwjablonski/gists{/gist_id}","starred_url":"https://api.github.com/users/pwjablonski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwjablonski/subscriptions","organizations_url":"https://api.github.com/users/pwjablonski/orgs","repos_url":"https://api.github.com/users/pwjablonski/repos","events_url":"https://api.github.com/users/pwjablonski/events{/privacy}","received_events_url":"https://api.github.com/users/pwjablonski/received_events","type":"User","site_admin":false},"body":"Hey! This is my first pass. Would love to get feedback if I'm on the right track in approaching this.\r\n\r\nThis feature detects if the cursor is located in within a CSS block and determines the associated selector.  It then sends the selector to the preview window and adds a highlighter div to cover the corresponding elements based on the elements' positions. \r\n\r\n![screen shot 2017-09-10 at 4 39 29 pm](https://user-images.githubusercontent.com/9774128/30252799-bd8382da-9646-11e7-8cd1-6455d2efa0e7.png)\r\n\r\nI used [C9 core](https://github.com/c9/core) as a starting point specifically\r\n[livecss,js](https://github.com/c9/core/blob/2c74d6b799544490a6d3f87862ef3a8cda802e9f/plugins/c9.preview/static/livecss.js)\r\n\r\nCouple Points\r\n- Works for the CSS only\r\n- Highlight scheme (shadowing/ color)  is borrowed from C9. Might want to update.\r\n- Doesn't include the selector label with the highlight as C9\r\n- Doesn't display padding margin on elements which would be great to have.\r\n- Currently, works only if cursor between braces of CSS block\r\n\r\nFor HTML\r\nThis is a lot more tricky and still wrapping my head around it. Quite a few more steps to think through. \r\n- C9 used an HTML Instrumentor and Simple DOM. \r\n","created_at":"2017-09-10T20:50:16Z","updated_at":"2018-10-26T01:01:11Z","closed_at":"2018-10-26T01:01:11Z","merged_at":null,"merge_commit_sha":"6f7d421df3fe2e3b553dc69da6d0f9b4d3846f8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"outoftime","id":14214,"node_id":"MDQ6VXNlcjE0MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/14214?v=4","gravatar_id":"","url":"https://api.github.com/users/outoftime","html_url":"https://github.com/outoftime","followers_url":"https://api.github.com/users/outoftime/followers","following_url":"https://api.github.com/users/outoftime/following{/other_user}","gists_url":"https://api.github.com/users/outoftime/gists{/gist_id}","starred_url":"https://api.github.com/users/outoftime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outoftime/subscriptions","organizations_url":"https://api.github.com/users/outoftime/orgs","repos_url":"https://api.github.com/users/outoftime/repos","events_url":"https://api.github.com/users/outoftime/events{/privacy}","received_events_url":"https://api.github.com/users/outoftime/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025/commits","review_comments_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025/comments","review_comment_url":"https://api.github.com/repos/popcodeorg/popcode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/popcodeorg/popcode/issues/1025/comments","statuses_url":"https://api.github.com/repos/popcodeorg/popcode/statuses/f1ba3b6013041d2dda7ce39d5376844120c0e5c0","head":{"label":"pwjablonski:element-highlighter","ref":"element-highlighter","sha":"f1ba3b6013041d2dda7ce39d5376844120c0e5c0","user":{"login":"pwjablonski","id":9774128,"node_id":"MDQ6VXNlcjk3NzQxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/9774128?v=4","gravatar_id":"","url":"https://api.github.com/users/pwjablonski","html_url":"https://github.com/pwjablonski","followers_url":"https://api.github.com/users/pwjablonski/followers","following_url":"https://api.github.com/users/pwjablonski/following{/other_user}","gists_url":"https://api.github.com/users/pwjablonski/gists{/gist_id}","starred_url":"https://api.github.com/users/pwjablonski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwjablonski/subscriptions","organizations_url":"https://api.github.com/users/pwjablonski/orgs","repos_url":"https://api.github.com/users/pwjablonski/repos","events_url":"https://api.github.com/users/pwjablonski/events{/privacy}","received_events_url":"https://api.github.com/users/pwjablonski/received_events","type":"User","site_admin":false},"repo":{"id":84984719,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk4NDcxOQ==","name":"popcode","full_name":"pwjablonski/popcode","private":false,"owner":{"login":"pwjablonski","id":9774128,"node_id":"MDQ6VXNlcjk3NzQxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/9774128?v=4","gravatar_id":"","url":"https://api.github.com/users/pwjablonski","html_url":"https://github.com/pwjablonski","followers_url":"https://api.github.com/users/pwjablonski/followers","following_url":"https://api.github.com/users/pwjablonski/following{/other_user}","gists_url":"https://api.github.com/users/pwjablonski/gists{/gist_id}","starred_url":"https://api.github.com/users/pwjablonski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwjablonski/subscriptions","organizations_url":"https://api.github.com/users/pwjablonski/orgs","repos_url":"https://api.github.com/users/pwjablonski/repos","events_url":"https://api.github.com/users/pwjablonski/events{/privacy}","received_events_url":"https://api.github.com/users/pwjablonski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pwjablonski/popcode","description":"An HTML/CSS/JavaScript editor for use in the classroom","fork":true,"url":"https://api.github.com/repos/pwjablonski/popcode","forks_url":"https://api.github.com/repos/pwjablonski/popcode/forks","keys_url":"https://api.github.com/repos/pwjablonski/popcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwjablonski/popcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwjablonski/popcode/teams","hooks_url":"https://api.github.com/repos/pwjablonski/popcode/hooks","issue_events_url":"https://api.github.com/repos/pwjablonski/popcode/issues/events{/number}","events_url":"https://api.github.com/repos/pwjablonski/popcode/events","assignees_url":"https://api.github.com/repos/pwjablonski/popcode/assignees{/user}","branches_url":"https://api.github.com/repos/pwjablonski/popcode/branches{/branch}","tags_url":"https://api.github.com/repos/pwjablonski/popcode/tags","blobs_url":"https://api.github.com/repos/pwjablonski/popcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwjablonski/popcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwjablonski/popcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwjablonski/popcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwjablonski/popcode/statuses/{sha}","languages_url":"https://api.github.com/repos/pwjablonski/popcode/languages","stargazers_url":"https://api.github.com/repos/pwjablonski/popcode/stargazers","contributors_url":"https://api.github.com/repos/pwjablonski/popcode/contributors","subscribers_url":"https://api.github.com/repos/pwjablonski/popcode/subscribers","subscription_url":"https://api.github.com/repos/pwjablonski/popcode/subscription","commits_url":"https://api.github.com/repos/pwjablonski/popcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwjablonski/popcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwjablonski/popcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwjablonski/popcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwjablonski/popcode/contents/{+path}","compare_url":"https://api.github.com/repos/pwjablonski/popcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwjablonski/popcode/merges","archive_url":"https://api.github.com/repos/pwjablonski/popcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwjablonski/popcode/downloads","issues_url":"https://api.github.com/repos/pwjablonski/popcode/issues{/number}","pulls_url":"https://api.github.com/repos/pwjablonski/popcode/pulls{/number}","milestones_url":"https://api.github.com/repos/pwjablonski/popcode/milestones{/number}","notifications_url":"https://api.github.com/repos/pwjablonski/popcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwjablonski/popcode/labels{/name}","releases_url":"https://api.github.com/repos/pwjablonski/popcode/releases{/id}","deployments_url":"https://api.github.com/repos/pwjablonski/popcode/deployments","created_at":"2017-03-14T18:38:51Z","updated_at":"2018-10-09T13:35:41Z","pushed_at":"2018-10-09T13:55:11Z","git_url":"git://github.com/pwjablonski/popcode.git","ssh_url":"git@github.com:pwjablonski/popcode.git","clone_url":"https://github.com/pwjablonski/popcode.git","svn_url":"https://github.com/pwjablonski/popcode","homepage":null,"size":6343,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"popcodeorg:master","ref":"master","sha":"daf63a63a32745bb7248e33664aa371d6b715e6a","user":{"login":"popcodeorg","id":15622831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjIyODMx","avatar_url":"https://avatars0.githubusercontent.com/u/15622831?v=4","gravatar_id":"","url":"https://api.github.com/users/popcodeorg","html_url":"https://github.com/popcodeorg","followers_url":"https://api.github.com/users/popcodeorg/followers","following_url":"https://api.github.com/users/popcodeorg/following{/other_user}","gists_url":"https://api.github.com/users/popcodeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/popcodeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcodeorg/subscriptions","organizations_url":"https://api.github.com/users/popcodeorg/orgs","repos_url":"https://api.github.com/users/popcodeorg/repos","events_url":"https://api.github.com/users/popcodeorg/events{/privacy}","received_events_url":"https://api.github.com/users/popcodeorg/received_events","type":"Organization","site_admin":false},"repo":{"id":39417599,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQxNzU5OQ==","name":"popcode","full_name":"popcodeorg/popcode","private":false,"owner":{"login":"popcodeorg","id":15622831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjIyODMx","avatar_url":"https://avatars0.githubusercontent.com/u/15622831?v=4","gravatar_id":"","url":"https://api.github.com/users/popcodeorg","html_url":"https://github.com/popcodeorg","followers_url":"https://api.github.com/users/popcodeorg/followers","following_url":"https://api.github.com/users/popcodeorg/following{/other_user}","gists_url":"https://api.github.com/users/popcodeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/popcodeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcodeorg/subscriptions","organizations_url":"https://api.github.com/users/popcodeorg/orgs","repos_url":"https://api.github.com/users/popcodeorg/repos","events_url":"https://api.github.com/users/popcodeorg/events{/privacy}","received_events_url":"https://api.github.com/users/popcodeorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/popcodeorg/popcode","description":"An HTML/CSS/JavaScript editor for use in the classroom","fork":false,"url":"https://api.github.com/repos/popcodeorg/popcode","forks_url":"https://api.github.com/repos/popcodeorg/popcode/forks","keys_url":"https://api.github.com/repos/popcodeorg/popcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/popcodeorg/popcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/popcodeorg/popcode/teams","hooks_url":"https://api.github.com/repos/popcodeorg/popcode/hooks","issue_events_url":"https://api.github.com/repos/popcodeorg/popcode/issues/events{/number}","events_url":"https://api.github.com/repos/popcodeorg/popcode/events","assignees_url":"https://api.github.com/repos/popcodeorg/popcode/assignees{/user}","branches_url":"https://api.github.com/repos/popcodeorg/popcode/branches{/branch}","tags_url":"https://api.github.com/repos/popcodeorg/popcode/tags","blobs_url":"https://api.github.com/repos/popcodeorg/popcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/popcodeorg/popcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/popcodeorg/popcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/popcodeorg/popcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/popcodeorg/popcode/statuses/{sha}","languages_url":"https://api.github.com/repos/popcodeorg/popcode/languages","stargazers_url":"https://api.github.com/repos/popcodeorg/popcode/stargazers","contributors_url":"https://api.github.com/repos/popcodeorg/popcode/contributors","subscribers_url":"https://api.github.com/repos/popcodeorg/popcode/subscribers","subscription_url":"https://api.github.com/repos/popcodeorg/popcode/subscription","commits_url":"https://api.github.com/repos/popcodeorg/popcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/popcodeorg/popcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/popcodeorg/popcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/popcodeorg/popcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/popcodeorg/popcode/contents/{+path}","compare_url":"https://api.github.com/repos/popcodeorg/popcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/popcodeorg/popcode/merges","archive_url":"https://api.github.com/repos/popcodeorg/popcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/popcodeorg/popcode/downloads","issues_url":"https://api.github.com/repos/popcodeorg/popcode/issues{/number}","pulls_url":"https://api.github.com/repos/popcodeorg/popcode/pulls{/number}","milestones_url":"https://api.github.com/repos/popcodeorg/popcode/milestones{/number}","notifications_url":"https://api.github.com/repos/popcodeorg/popcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/popcodeorg/popcode/labels{/name}","releases_url":"https://api.github.com/repos/popcodeorg/popcode/releases{/id}","deployments_url":"https://api.github.com/repos/popcodeorg/popcode/deployments","created_at":"2015-07-21T01:40:09Z","updated_at":"2018-10-24T12:52:42Z","pushed_at":"2018-10-25T20:12:47Z","git_url":"git://github.com/popcodeorg/popcode.git","ssh_url":"git@github.com:popcodeorg/popcode.git","clone_url":"https://github.com/popcodeorg/popcode.git","svn_url":"https://github.com/popcodeorg/popcode","homepage":null,"size":5783,"stargazers_count":120,"watchers_count":120,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":93,"open_issues":161,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025"},"html":{"href":"https://github.com/popcodeorg/popcode/pull/1025"},"issue":{"href":"https://api.github.com/repos/popcodeorg/popcode/issues/1025"},"comments":{"href":"https://api.github.com/repos/popcodeorg/popcode/issues/1025/comments"},"review_comments":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025/comments"},"review_comment":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/popcodeorg/popcode/pulls/1025/commits"},"statuses":{"href":"https://api.github.com/repos/popcodeorg/popcode/statuses/f1ba3b6013041d2dda7ce39d5376844120c0e5c0"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":15,"review_comments":145,"maintainer_can_modify":false,"commits":13,"additions":352,"deletions":1,"changed_files":23}}
{"actor":{"display_login":"outoftime"}}