{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/bench/issues/709","repository_url":"https://api.github.com/repos/frappe/bench","labels_url":"https://api.github.com/repos/frappe/bench/issues/709/labels{/name}","comments_url":"https://api.github.com/repos/frappe/bench/issues/709/comments","events_url":"https://api.github.com/repos/frappe/bench/issues/709/events","html_url":"https://github.com/frappe/bench/pull/709","id":352417792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzMyNDUx","number":709,"title":"Allow user to set single wildcard certificate for all domains","user":{"login":"vjFaLk","id":6697133,"node_id":"MDQ6VXNlcjY2OTcxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/6697133?v=4","gravatar_id":"","url":"https://api.github.com/users/vjFaLk","html_url":"https://github.com/vjFaLk","followers_url":"https://api.github.com/users/vjFaLk/followers","following_url":"https://api.github.com/users/vjFaLk/following{/other_user}","gists_url":"https://api.github.com/users/vjFaLk/gists{/gist_id}","starred_url":"https://api.github.com/users/vjFaLk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjFaLk/subscriptions","organizations_url":"https://api.github.com/users/vjFaLk/orgs","repos_url":"https://api.github.com/users/vjFaLk/repos","events_url":"https://api.github.com/users/vjFaLk/events{/privacy}","received_events_url":"https://api.github.com/users/vjFaLk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-21T07:30:30Z","updated_at":"2018-09-19T18:37:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/frappe/bench/pulls/709","html_url":"https://github.com/frappe/bench/pull/709","diff_url":"https://github.com/frappe/bench/pull/709.diff","patch_url":"https://github.com/frappe/bench/pull/709.patch"},"body":"This is for a scenario when you have a single wildcard certificate for multiple domains. By default the nginx generation logic will only set the certs for domains that match the one set as the wildcard domain. \r\n\r\nHowever, by doing this, when you just set the domain as \"*\", the domain variable in the next line is set as empty string, which then is used in an `endswith`, which will always resolve `True`."},"comment":{"url":"https://api.github.com/repos/frappe/bench/issues/comments/422912651","html_url":"https://github.com/frappe/bench/pull/709#issuecomment-422912651","issue_url":"https://api.github.com/repos/frappe/bench/issues/709","id":422912651,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjkxMjY1MQ==","user":{"login":"vjFaLk","id":6697133,"node_id":"MDQ6VXNlcjY2OTcxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/6697133?v=4","gravatar_id":"","url":"https://api.github.com/users/vjFaLk","html_url":"https://github.com/vjFaLk","followers_url":"https://api.github.com/users/vjFaLk/followers","following_url":"https://api.github.com/users/vjFaLk/following{/other_user}","gists_url":"https://api.github.com/users/vjFaLk/gists{/gist_id}","starred_url":"https://api.github.com/users/vjFaLk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjFaLk/subscriptions","organizations_url":"https://api.github.com/users/vjFaLk/orgs","repos_url":"https://api.github.com/users/vjFaLk/repos","events_url":"https://api.github.com/users/vjFaLk/events{/privacy}","received_events_url":"https://api.github.com/users/vjFaLk/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T18:37:15Z","updated_at":"2018-09-19T18:37:15Z","author_association":"CONTRIBUTOR","body":"@codingCoffee LOL, will fix and update"}}
{"actor":{"display_login":"vjFaLk"}}