{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/186664343","pull_request_review_id":118285018,"id":186664343,"diff_hunk":"@@ -202,9 +202,23 @@ class FsNewHandler : public FileSystemCommandHandler\n     mon->osdmon()->propose_pending();\n \n     // All checks passed, go ahead and create.\n-    fsmap.create_filesystem(fs_name, metadata, data,\n-                            mon->get_quorum_con_features());\n+    auto fs = fsmap.create_filesystem(fs_name, metadata, data,\n+        mon->get_quorum_con_features());\n+\n     ss << \"new fs with metadata pool \" << metadata << \" and data pool \" << data;\n+\n+    // assign a standby to rank 0 to avoid health warnings\n+    std::string _name;","path":"src/mon/FSCommands.cc","position":12,"original_position":12,"commit_id":"93bc8c53ef51bf4fbaafad0c2d1ad79dbff8eb8b","original_commit_id":"93bc8c53ef51bf4fbaafad0c2d1ad79dbff8eb8b","user":{"login":"jcsp","id":944640,"avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"body":"Does it work to just call \"maybe_promote_standby(fs)\" here?  I see that calling tick() was problematic because it does a propose_pending(), but maybe_promote_standby in isolation should be alright","created_at":"2018-05-08T09:16:11Z","updated_at":"2018-05-08T09:16:12Z","html_url":"https://github.com/ceph/ceph/pull/21810#discussion_r186664343","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/21810","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/186664343"},"html":{"href":"https://github.com/ceph/ceph/pull/21810#discussion_r186664343"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21810"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21810","id":185893671,"html_url":"https://github.com/ceph/ceph/pull/21810","diff_url":"https://github.com/ceph/ceph/pull/21810.diff","patch_url":"https://github.com/ceph/ceph/pull/21810.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21810","number":21810,"state":"open","locked":false,"title":"MDSMonitor: avoid health checks on new file system","user":{"login":"batrick","id":548304,"avatar_url":"https://avatars3.githubusercontent.com/u/548304?v=4","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false},"body":"Fixes: http://tracker.ceph.com/issues/23885\r\n\r\nSigned-off-by: Patrick Donnelly <pdonnell@redhat.com>","created_at":"2018-05-04T05:09:41Z","updated_at":"2018-05-08T09:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57906f3d485285c1ef7d7e4da673c963885e527d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jecluis","id":506918,"avatar_url":"https://avatars3.githubusercontent.com/u/506918?v=4","gravatar_id":"","url":"https://api.github.com/users/jecluis","html_url":"https://github.com/jecluis","followers_url":"https://api.github.com/users/jecluis/followers","following_url":"https://api.github.com/users/jecluis/following{/other_user}","gists_url":"https://api.github.com/users/jecluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jecluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jecluis/subscriptions","organizations_url":"https://api.github.com/users/jecluis/orgs","repos_url":"https://api.github.com/users/jecluis/repos","events_url":"https://api.github.com/users/jecluis/events{/privacy}","received_events_url":"https://api.github.com/users/jecluis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329802,"url":"https://api.github.com/repos/ceph/ceph/labels/cephfs","name":"cephfs","color":"b192ff","default":false},{"id":340048817,"url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false},{"id":635439348,"url":"https://api.github.com/repos/ceph/ceph/labels/wip-pdonnell-testing","name":"wip-pdonnell-testing","color":"12346b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21810/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21810/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21810/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/93bc8c53ef51bf4fbaafad0c2d1ad79dbff8eb8b","head":{"label":"batrick:i23885","ref":"i23885","sha":"93bc8c53ef51bf4fbaafad0c2d1ad79dbff8eb8b","user":{"login":"batrick","id":548304,"avatar_url":"https://avatars3.githubusercontent.com/u/548304?v=4","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false},"repo":{"id":49215218,"name":"ceph","full_name":"batrick/ceph","owner":{"login":"batrick","id":548304,"avatar_url":"https://avatars3.githubusercontent.com/u/548304?v=4","gravatar_id":"","url":"https://api.github.com/users/batrick","html_url":"https://github.com/batrick","followers_url":"https://api.github.com/users/batrick/followers","following_url":"https://api.github.com/users/batrick/following{/other_user}","gists_url":"https://api.github.com/users/batrick/gists{/gist_id}","starred_url":"https://api.github.com/users/batrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batrick/subscriptions","organizations_url":"https://api.github.com/users/batrick/orgs","repos_url":"https://api.github.com/users/batrick/repos","events_url":"https://api.github.com/users/batrick/events{/privacy}","received_events_url":"https://api.github.com/users/batrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/batrick/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/batrick/ceph","forks_url":"https://api.github.com/repos/batrick/ceph/forks","keys_url":"https://api.github.com/repos/batrick/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batrick/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batrick/ceph/teams","hooks_url":"https://api.github.com/repos/batrick/ceph/hooks","issue_events_url":"https://api.github.com/repos/batrick/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/batrick/ceph/events","assignees_url":"https://api.github.com/repos/batrick/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/batrick/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/batrick/ceph/tags","blobs_url":"https://api.github.com/repos/batrick/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batrick/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batrick/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/batrick/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batrick/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/batrick/ceph/languages","stargazers_url":"https://api.github.com/repos/batrick/ceph/stargazers","contributors_url":"https://api.github.com/repos/batrick/ceph/contributors","subscribers_url":"https://api.github.com/repos/batrick/ceph/subscribers","subscription_url":"https://api.github.com/repos/batrick/ceph/subscription","commits_url":"https://api.github.com/repos/batrick/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/batrick/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/batrick/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/batrick/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/batrick/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/batrick/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batrick/ceph/merges","archive_url":"https://api.github.com/repos/batrick/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batrick/ceph/downloads","issues_url":"https://api.github.com/repos/batrick/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/batrick/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/batrick/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/batrick/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batrick/ceph/labels{/name}","releases_url":"https://api.github.com/repos/batrick/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/batrick/ceph/deployments","created_at":"2016-01-07T16:12:11Z","updated_at":"2016-05-26T15:36:55Z","pushed_at":"2018-05-07T22:55:26Z","git_url":"git://github.com/batrick/ceph.git","ssh_url":"git@github.com:batrick/ceph.git","clone_url":"https://github.com/batrick/ceph.git","svn_url":"https://github.com/batrick/ceph","homepage":"http://ceph.com","size":276771,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"4afd5ece9c99f85e15851c3df5918f02ed4263c3","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-05-08T06:05:15Z","pushed_at":"2018-05-08T09:07:39Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":281975,"stargazers_count":4464,"watchers_count":4464,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2432,"mirror_url":null,"archived":false,"open_issues_count":686,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2432,"open_issues":686,"watchers":4464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21810"},"html":{"href":"https://github.com/ceph/ceph/pull/21810"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21810"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21810/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21810/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21810/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/93bc8c53ef51bf4fbaafad0c2d1ad79dbff8eb8b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jcsp"}}