{"action":"closed","number":2849,"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849","id":176060308,"html_url":"https://github.com/envoyproxy/envoy/pull/2849","diff_url":"https://github.com/envoyproxy/envoy/pull/2849.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2849.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2849","number":2849,"state":"closed","locked":false,"title":"Expand the namespaces of the SINGLETON_MANAGER_REGISTRATION macro.","user":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"body":"This allows the use of the macro in build environments that do not allow\r\n\"using namespace\".\r\n\r\nRisk Level: Low\r\n","created_at":"2018-03-20T00:28:49Z","updated_at":"2018-03-20T17:47:43Z","closed_at":"2018-03-20T17:47:43Z","merged_at":"2018-03-20T17:47:43Z","merge_commit_sha":"851b435c685586c9d634ac33cedb1879c2891534","assignee":{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2849/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/8a9844a53d64ffe6f587e7158a9e999a908ea790","head":{"label":"nt:expand-macro","ref":"expand-macro","sha":"8a9844a53d64ffe6f587e7158a9e999a908ea790","user":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"repo":{"id":119728981,"name":"envoy","full_name":"nt/envoy","owner":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nt/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/nt/envoy","forks_url":"https://api.github.com/repos/nt/envoy/forks","keys_url":"https://api.github.com/repos/nt/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nt/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nt/envoy/teams","hooks_url":"https://api.github.com/repos/nt/envoy/hooks","issue_events_url":"https://api.github.com/repos/nt/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/nt/envoy/events","assignees_url":"https://api.github.com/repos/nt/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/nt/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/nt/envoy/tags","blobs_url":"https://api.github.com/repos/nt/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nt/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nt/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nt/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nt/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/nt/envoy/languages","stargazers_url":"https://api.github.com/repos/nt/envoy/stargazers","contributors_url":"https://api.github.com/repos/nt/envoy/contributors","subscribers_url":"https://api.github.com/repos/nt/envoy/subscribers","subscription_url":"https://api.github.com/repos/nt/envoy/subscription","commits_url":"https://api.github.com/repos/nt/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nt/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nt/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nt/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nt/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/nt/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nt/envoy/merges","archive_url":"https://api.github.com/repos/nt/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nt/envoy/downloads","issues_url":"https://api.github.com/repos/nt/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/nt/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/nt/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/nt/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nt/envoy/labels{/name}","releases_url":"https://api.github.com/repos/nt/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/nt/envoy/deployments","created_at":"2018-01-31T18:51:33Z","updated_at":"2018-03-20T17:00:26Z","pushed_at":"2018-03-20T17:00:21Z","git_url":"git://github.com/nt/envoy.git","ssh_url":"git@github.com:nt/envoy.git","clone_url":"https://github.com/nt/envoy.git","svn_url":"https://github.com/nt/envoy","homepage":"https://envoyproxy.github.io/","size":54382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"da0dc5f5dac12651f211e321f9cd7b2c70bedde9","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-03-20T17:24:14Z","pushed_at":"2018-03-20T17:47:43Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":12916,"stargazers_count":4217,"watchers_count":4217,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":520,"mirror_url":null,"archived":false,"open_issues_count":260,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":520,"open_issues":260,"watchers":4217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2849"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2849"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2849/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2849/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/8a9844a53d64ffe6f587e7158a9e999a908ea790"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mattklein123"}}