{"action":"created","comment":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/177757193","pull_request_review_id":107687331,"id":177757193,"diff_hunk":"@@ -36,20 +36,39 @@ class RF\n     }\n \n     template <typename T>\n-    void write( Register num, const T& val, bool accumulating_instr = false)\n+    void addition( T& new_val, const T& val)\n+    {\n+      const auto entry_hi = get_entry( Register::mips_hi);\n+      const auto entry_lo = get_entry( Register::mips_lo);\n+      auto hi_lo = static_cast<uint64>( entry_hi.value);\n+      hi_lo <<= 32;\n+      hi_lo += static_cast<uint64>( entry_lo.value);\n+      hi_lo += static_cast<uint64>( val);\n+      new_val = static_cast<T>( hi_lo);\n+    }\n+\n+    template <typename T>\n+    void subtraction( T& new_val, const T& val)\n+    {\n+      const auto entry_hi = get_entry( Register::mips_hi);\n+      const auto entry_lo = get_entry( Register::mips_lo);\n+      auto hi_lo = static_cast<uint64>( entry_hi.value);\n+      hi_lo <<= 32;\n+      hi_lo += static_cast<uint64>( entry_lo.value);","path":"simulator/func_sim/rf/rf.h","position":11,"original_position":23,"commit_id":"6d989f494b062f56155942431a3f2ebbda2b1395","original_commit_id":"fea6231e72cea2e0089ce9b77c6ab8927f68d6d8","user":{"login":"pavelkryukov","id":11466405,"avatar_url":"https://avatars3.githubusercontent.com/u/11466405?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkryukov","html_url":"https://github.com/pavelkryukov","followers_url":"https://api.github.com/users/pavelkryukov/followers","following_url":"https://api.github.com/users/pavelkryukov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkryukov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkryukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkryukov/subscriptions","organizations_url":"https://api.github.com/users/pavelkryukov/orgs","repos_url":"https://api.github.com/users/pavelkryukov/repos","events_url":"https://api.github.com/users/pavelkryukov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkryukov/received_events","type":"User","site_admin":false},"body":"I still think you need to add a method to merge hi-lo into single value:\r\n\r\n```c++\r\nRegDstUint get_hi_lo() const\r\n{\r\n\r\n};\r\n```","created_at":"2018-03-28T13:54:45Z","updated_at":"2018-03-28T13:58:50Z","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/368#discussion_r177757193","pull_request_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/177757193"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/368#discussion_r177757193"},"pull_request":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368"}},"in_reply_to_id":177705261},"pull_request":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368","id":177993430,"html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/368","diff_url":"https://github.com/MIPT-ILab/mipt-mips/pull/368.diff","patch_url":"https://github.com/MIPT-ILab/mipt-mips/pull/368.patch","issue_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/368","number":368,"state":"open","locked":false,"title":"Adding msub and msubu instructions","user":{"login":"AndrewSultan","id":32276135,"avatar_url":"https://avatars0.githubusercontent.com/u/32276135?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSultan","html_url":"https://github.com/AndrewSultan","followers_url":"https://api.github.com/users/AndrewSultan/followers","following_url":"https://api.github.com/users/AndrewSultan/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSultan/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSultan/subscriptions","organizations_url":"https://api.github.com/users/AndrewSultan/orgs","repos_url":"https://api.github.com/users/AndrewSultan/repos","events_url":"https://api.github.com/users/AndrewSultan/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSultan/received_events","type":"User","site_admin":false},"body":"#282 ","created_at":"2018-03-28T10:24:34Z","updated_at":"2018-03-28T13:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a4dc405244d6c701252ec8f97ac44806e52a0d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368/commits","review_comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368/comments","review_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/368/comments","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/6d989f494b062f56155942431a3f2ebbda2b1395","head":{"label":"AndrewSultan:master","ref":"master","sha":"6d989f494b062f56155942431a3f2ebbda2b1395","user":{"login":"AndrewSultan","id":32276135,"avatar_url":"https://avatars0.githubusercontent.com/u/32276135?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSultan","html_url":"https://github.com/AndrewSultan","followers_url":"https://api.github.com/users/AndrewSultan/followers","following_url":"https://api.github.com/users/AndrewSultan/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSultan/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSultan/subscriptions","organizations_url":"https://api.github.com/users/AndrewSultan/orgs","repos_url":"https://api.github.com/users/AndrewSultan/repos","events_url":"https://api.github.com/users/AndrewSultan/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSultan/received_events","type":"User","site_admin":false},"repo":{"id":126900060,"name":"mipt-mips","full_name":"AndrewSultan/mipt-mips","owner":{"login":"AndrewSultan","id":32276135,"avatar_url":"https://avatars0.githubusercontent.com/u/32276135?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSultan","html_url":"https://github.com/AndrewSultan","followers_url":"https://api.github.com/users/AndrewSultan/followers","following_url":"https://api.github.com/users/AndrewSultan/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSultan/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSultan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSultan/subscriptions","organizations_url":"https://api.github.com/users/AndrewSultan/orgs","repos_url":"https://api.github.com/users/AndrewSultan/repos","events_url":"https://api.github.com/users/AndrewSultan/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSultan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndrewSultan/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":true,"url":"https://api.github.com/repos/AndrewSultan/mipt-mips","forks_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/forks","keys_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/teams","hooks_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/events","assignees_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/tags","blobs_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/subscription","commits_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/merges","archive_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/downloads","issues_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/AndrewSultan/mipt-mips/deployments","created_at":"2018-03-26T23:05:04Z","updated_at":"2018-03-28T13:44:00Z","pushed_at":"2018-03-28T13:43:59Z","git_url":"git://github.com/AndrewSultan/mipt-mips.git","ssh_url":"git@github.com:AndrewSultan/mipt-mips.git","clone_url":"https://github.com/AndrewSultan/mipt-mips.git","svn_url":"https://github.com/AndrewSultan/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":10156,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MIPT-ILab:master","ref":"master","sha":"6878eb44bbd753e9d051676bd2480f98b3c90505","user":{"login":"MIPT-ILab","id":13999586,"avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"repo":{"id":42990634,"name":"mipt-mips","full_name":"MIPT-ILab/mipt-mips","owner":{"login":"MIPT-ILab","id":13999586,"avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MIPT-ILab/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":false,"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips","forks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/forks","keys_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/teams","hooks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/events","assignees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/tags","blobs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscription","commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/merges","archive_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/downloads","issues_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/deployments","created_at":"2015-09-23T09:12:26Z","updated_at":"2018-03-28T13:18:47Z","pushed_at":"2018-03-28T13:44:00Z","git_url":"git://github.com/MIPT-ILab/mipt-mips.git","ssh_url":"git@github.com:MIPT-ILab/mipt-mips.git","clone_url":"https://github.com/MIPT-ILab/mipt-mips.git","svn_url":"https://github.com/MIPT-ILab/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":115166,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":47,"open_issues":34,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/368"},"issue":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/368"},"comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/6d989f494b062f56155942431a3f2ebbda2b1395"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pavelkryukov"}}