{"action":"closed","number":5849,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5849","id":183626361,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNjI2MzYx","html_url":"https://github.com/minio/minio/pull/5849","diff_url":"https://github.com/minio/minio/pull/5849.diff","patch_url":"https://github.com/minio/minio/pull/5849.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/5849","number":5849,"state":"closed","locked":false,"title":"Manta gateway fixes for subuser and private manta support","user":{"login":"nocsi","id":17055956,"node_id":"MDQ6VXNlcjE3MDU1OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/17055956?v=4","gravatar_id":"","url":"https://api.github.com/users/nocsi","html_url":"https://github.com/nocsi","followers_url":"https://api.github.com/users/nocsi/followers","following_url":"https://api.github.com/users/nocsi/following{/other_user}","gists_url":"https://api.github.com/users/nocsi/gists{/gist_id}","starred_url":"https://api.github.com/users/nocsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nocsi/subscriptions","organizations_url":"https://api.github.com/users/nocsi/orgs","repos_url":"https://api.github.com/users/nocsi/repos","events_url":"https://api.github.com/users/nocsi/events{/privacy}","received_events_url":"https://api.github.com/users/nocsi/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThe parsing on custom manta url was incorrect and would strip 'https://'. In order to support subuser authentication, the subuser needed to be passed in with the client config. The referenced triton-go branch needs to be rebased to a newer version. \r\n\r\nI'm waiting on multipart upload to hit public manta before merging the metadata and minio multipart upload code as well.\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\nManta gateway has always been broken for private and subuser.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\nTested against public joyent endpoint (https://us-east.manta.joyent.com) as well as against a private endpoint, both with and without subuser.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [ ] All new and existing tests passed.","created_at":"2018-04-24T05:45:11Z","updated_at":"2018-06-04T06:46:09Z","closed_at":"2018-06-04T06:46:09Z","merged_at":null,"merge_commit_sha":"093a3de2d7937cd4106981207a5b163688bb4fe5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/5849/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/5849/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/5849/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/6c394bcc5ca94266b5bc4146b0ca4e5531503255","head":{"label":"nocsi:manta-gateway-ng","ref":"manta-gateway-ng","sha":"6c394bcc5ca94266b5bc4146b0ca4e5531503255","user":{"login":"nocsi","id":17055956,"node_id":"MDQ6VXNlcjE3MDU1OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/17055956?v=4","gravatar_id":"","url":"https://api.github.com/users/nocsi","html_url":"https://github.com/nocsi","followers_url":"https://api.github.com/users/nocsi/followers","following_url":"https://api.github.com/users/nocsi/following{/other_user}","gists_url":"https://api.github.com/users/nocsi/gists{/gist_id}","starred_url":"https://api.github.com/users/nocsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nocsi/subscriptions","organizations_url":"https://api.github.com/users/nocsi/orgs","repos_url":"https://api.github.com/users/nocsi/repos","events_url":"https://api.github.com/users/nocsi/events{/privacy}","received_events_url":"https://api.github.com/users/nocsi/received_events","type":"User","site_admin":false},"repo":{"id":126845642,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NDU2NDI=","name":"minio","full_name":"nocsi/minio","owner":{"login":"nocsi","id":17055956,"node_id":"MDQ6VXNlcjE3MDU1OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/17055956?v=4","gravatar_id":"","url":"https://api.github.com/users/nocsi","html_url":"https://github.com/nocsi","followers_url":"https://api.github.com/users/nocsi/followers","following_url":"https://api.github.com/users/nocsi/following{/other_user}","gists_url":"https://api.github.com/users/nocsi/gists{/gist_id}","starred_url":"https://api.github.com/users/nocsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nocsi/subscriptions","organizations_url":"https://api.github.com/users/nocsi/orgs","repos_url":"https://api.github.com/users/nocsi/repos","events_url":"https://api.github.com/users/nocsi/events{/privacy}","received_events_url":"https://api.github.com/users/nocsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nocsi/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/nocsi/minio","forks_url":"https://api.github.com/repos/nocsi/minio/forks","keys_url":"https://api.github.com/repos/nocsi/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nocsi/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nocsi/minio/teams","hooks_url":"https://api.github.com/repos/nocsi/minio/hooks","issue_events_url":"https://api.github.com/repos/nocsi/minio/issues/events{/number}","events_url":"https://api.github.com/repos/nocsi/minio/events","assignees_url":"https://api.github.com/repos/nocsi/minio/assignees{/user}","branches_url":"https://api.github.com/repos/nocsi/minio/branches{/branch}","tags_url":"https://api.github.com/repos/nocsi/minio/tags","blobs_url":"https://api.github.com/repos/nocsi/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nocsi/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nocsi/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nocsi/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nocsi/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/nocsi/minio/languages","stargazers_url":"https://api.github.com/repos/nocsi/minio/stargazers","contributors_url":"https://api.github.com/repos/nocsi/minio/contributors","subscribers_url":"https://api.github.com/repos/nocsi/minio/subscribers","subscription_url":"https://api.github.com/repos/nocsi/minio/subscription","commits_url":"https://api.github.com/repos/nocsi/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nocsi/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nocsi/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nocsi/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nocsi/minio/contents/{+path}","compare_url":"https://api.github.com/repos/nocsi/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nocsi/minio/merges","archive_url":"https://api.github.com/repos/nocsi/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nocsi/minio/downloads","issues_url":"https://api.github.com/repos/nocsi/minio/issues{/number}","pulls_url":"https://api.github.com/repos/nocsi/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/nocsi/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/nocsi/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nocsi/minio/labels{/name}","releases_url":"https://api.github.com/repos/nocsi/minio/releases{/id}","deployments_url":"https://api.github.com/repos/nocsi/minio/deployments","created_at":"2018-03-26T14:58:38Z","updated_at":"2018-03-26T14:58:42Z","pushed_at":"2018-04-24T05:31:27Z","git_url":"git://github.com/nocsi/minio.git","ssh_url":"git@github.com:nocsi/minio.git","clone_url":"https://github.com/nocsi/minio.git","svn_url":"https://github.com/nocsi/minio","homepage":"https://minio.io/downloads.html#download-server","size":35088,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"7ac0fccb6eb2f3bb69af3ba670faf6b6a8a6755f","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-06-04T05:52:38Z","pushed_at":"2018-06-04T06:20:57Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":36257,"stargazers_count":11605,"watchers_count":11605,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":993,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":993,"open_issues":136,"watchers":11605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/5849"},"html":{"href":"https://github.com/minio/minio/pull/5849"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/5849"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/5849/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/5849/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/5849/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/6c394bcc5ca94266b5bc4146b0ca4e5531503255"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":5,"maintainer_can_modify":false,"commits":3,"additions":282,"deletions":127,"changed_files":15}}
{"actor":{"display_login":"harshavardhana"}}