{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/166743994","pull_request_review_id":94857079,"id":166743994,"diff_hunk":"@@ -430,6 +431,34 @@ internal static void VerifyMethodBodies(ImmutableArray<byte> peImage, Action<byt\n \n         static readonly byte[] ThrowNull = new[] { (byte)ILOpCode.Ldnull, (byte)ILOpCode.Throw };\n \n+        internal static void AssertReferencedIsReadOnlyAttributes(MetadataReader reader, CustomAttributeHandleCollection customAttributes, Accessibility accessibility)\n+        {\n+            AssertAttributePresent(reader, customAttributes, accessibility, \"IsReadOnlyAttribute\");\n+        }\n+\n+        internal static void AssertReferencedIsByRefLikeAttributes(MetadataReader reader, CustomAttributeHandleCollection customAttributes, Accessibility accessibility)\n+        {\n+            AssertAttributePresent(reader, customAttributes, accessibility, \"IsByRefLikeAttribute\");\n+        }\n+\n+        private static void AssertAttributePresent(MetadataReader reader, CustomAttributeHandleCollection customAttributes, Accessibility accessibility, string name)\n+        {\n+            var isByRefLikes = customAttributes.Where(a => Dump(reader, reader.GetCustomAttribute(a).Constructor) == $\"MethodDefinition:Void {name}..ctor()\");\n+\n+            int foundCount = isByRefLikes.Count();\n+            Assert.True(foundCount == 1, $\"Got {foundCount}. Actual attributes were: {customAttributes.Select(a => Dump(reader, reader.GetCustomAttribute(a).Constructor)).Join(\", \")}\");\n+\n+            var isByRefLike = isByRefLikes.Single();\n+            var attributeData = reader.GetCustomAttribute(isByRefLike);\n+            var attributeCtor = reader.GetMethodDefinition((MethodDefinitionHandle)attributeData.Constructor);\n+            var attribute = reader.GetTypeDefinition(attributeCtor.GetDeclaringType());\n+            Assert.Equal(name, reader.GetString(attribute.Name));\n+            Assert.Equal(\"System.Runtime.CompilerServices\", reader.GetString(attribute.Namespace));\n+\n+            var accesibilityFlags = attribute.Attributes & TypeAttributes.VisibilityMask;","path":"src/Test/Utilities/Portable/Metadata/MetadataReaderUtils.cs","position":54,"original_position":54,"commit_id":"2c24a0cc525d7c7ba9ebb7ade25a8f0d28481562","original_commit_id":"2c24a0cc525d7c7ba9ebb7ade25a8f0d28481562","user":{"login":"cston","id":10732005,"avatar_url":"https://avatars2.githubusercontent.com/u/10732005?v=4","gravatar_id":"","url":"https://api.github.com/users/cston","html_url":"https://github.com/cston","followers_url":"https://api.github.com/users/cston/followers","following_url":"https://api.github.com/users/cston/following{/other_user}","gists_url":"https://api.github.com/users/cston/gists{/gist_id}","starred_url":"https://api.github.com/users/cston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cston/subscriptions","organizations_url":"https://api.github.com/users/cston/orgs","repos_url":"https://api.github.com/users/cston/repos","events_url":"https://api.github.com/users/cston/events{/privacy}","received_events_url":"https://api.github.com/users/cston/received_events","type":"User","site_admin":false},"body":"Typo: `accessibility`","created_at":"2018-02-07T20:24:14Z","updated_at":"2018-02-07T20:24:14Z","html_url":"https://github.com/dotnet/roslyn/pull/24492#discussion_r166743994","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24492","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/166743994"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24492#discussion_r166743994"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24492"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/24492","id":165533325,"html_url":"https://github.com/dotnet/roslyn/pull/24492","diff_url":"https://github.com/dotnet/roslyn/pull/24492.diff","patch_url":"https://github.com/dotnet/roslyn/pull/24492.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/24492","number":24492,"state":"open","locked":false,"title":"Override completion with in parameter should omit IsReadOnly attribute","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dotnet/roslyn/issues/24490\r\nFixes https://github.com/dotnet/roslyn/issues/24615\r\n\r\nUpdate: the PR now filters the `IsReadOnly` and `IsByRefLike` attributes in the compiler `GetAttributes()` API.\r\n","created_at":"2018-01-27T19:47:16Z","updated_at":"2018-02-07T20:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4b547f4a172648819288b5b3a5bbd6a59f24919","assignee":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/32","html_url":"https://github.com/dotnet/roslyn/milestone/32","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/32/labels","id":2817494,"number":32,"title":"15.7","description":null,"creator":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":240,"closed_issues":75,"state":"open","created_at":"2017-10-05T14:58:29Z","updated_at":"2018-02-07T08:17:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24492/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24492/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/24492/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/2c24a0cc525d7c7ba9ebb7ade25a8f0d28481562","head":{"label":"jcouv:in-override","ref":"in-override","sha":"2c24a0cc525d7c7ba9ebb7ade25a8f0d28481562","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"repo":{"id":50162064,"name":"roslyn","full_name":"jcouv/roslyn","owner":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcouv/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/jcouv/roslyn","forks_url":"https://api.github.com/repos/jcouv/roslyn/forks","keys_url":"https://api.github.com/repos/jcouv/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcouv/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcouv/roslyn/teams","hooks_url":"https://api.github.com/repos/jcouv/roslyn/hooks","issue_events_url":"https://api.github.com/repos/jcouv/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/jcouv/roslyn/events","assignees_url":"https://api.github.com/repos/jcouv/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/jcouv/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/jcouv/roslyn/tags","blobs_url":"https://api.github.com/repos/jcouv/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcouv/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcouv/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcouv/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcouv/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jcouv/roslyn/languages","stargazers_url":"https://api.github.com/repos/jcouv/roslyn/stargazers","contributors_url":"https://api.github.com/repos/jcouv/roslyn/contributors","subscribers_url":"https://api.github.com/repos/jcouv/roslyn/subscribers","subscription_url":"https://api.github.com/repos/jcouv/roslyn/subscription","commits_url":"https://api.github.com/repos/jcouv/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcouv/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcouv/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcouv/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcouv/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/jcouv/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcouv/roslyn/merges","archive_url":"https://api.github.com/repos/jcouv/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcouv/roslyn/downloads","issues_url":"https://api.github.com/repos/jcouv/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/jcouv/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jcouv/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jcouv/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcouv/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/jcouv/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/jcouv/roslyn/deployments","created_at":"2016-01-22T06:19:22Z","updated_at":"2016-01-22T06:19:52Z","pushed_at":"2018-02-07T00:30:14Z","git_url":"git://github.com/jcouv/roslyn.git","ssh_url":"git@github.com:jcouv/roslyn.git","clone_url":"https://github.com/jcouv/roslyn.git","svn_url":"https://github.com/jcouv/roslyn","homepage":"","size":268216,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev15.7.x","ref":"dev15.7.x","sha":"0e01a3d573d623543673b7245b593dca64cc959f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-02-07T18:56:42Z","pushed_at":"2018-02-07T20:20:12Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":280767,"stargazers_count":8806,"watchers_count":8806,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2126,"mirror_url":null,"archived":false,"open_issues_count":4371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2126,"open_issues":4371,"watchers":8806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24492"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24492"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24492"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24492/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24492/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24492/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/2c24a0cc525d7c7ba9ebb7ade25a8f0d28481562"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cston"}}