{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/ci/pulls/comments/170694494","pull_request_review_id":99419949,"id":170694494,"diff_hunk":"@@ -88,12 +88,13 @@ def login(email: nil, password: nil)\n       user_password = BCrypt::Password.new(user.password_hash)\n \n       # sweet, it matches, return the user\n-      if user_password.to_s == password\n+      if user_password == password\n         logger.debug(\"user #{email} authenticated\")\n         return user\n       end\n \n       # nope, wrong password\n+      logger.debug(\"user #{email} authentication failed\")","path":"services/data_sources/json_user_data_source.rb","position":11,"original_position":11,"commit_id":"878082aa987847d0de86114ff55dc67b4daac964","original_commit_id":"878082aa987847d0de86114ff55dc67b4daac964","user":{"login":"taquitos","id":1304821,"avatar_url":"https://avatars2.githubusercontent.com/u/1304821?v=4","gravatar_id":"","url":"https://api.github.com/users/taquitos","html_url":"https://github.com/taquitos","followers_url":"https://api.github.com/users/taquitos/followers","following_url":"https://api.github.com/users/taquitos/following{/other_user}","gists_url":"https://api.github.com/users/taquitos/gists{/gist_id}","starred_url":"https://api.github.com/users/taquitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taquitos/subscriptions","organizations_url":"https://api.github.com/users/taquitos/orgs","repos_url":"https://api.github.com/users/taquitos/repos","events_url":"https://api.github.com/users/taquitos/events{/privacy}","received_events_url":"https://api.github.com/users/taquitos/received_events","type":"User","site_admin":false},"body":"good idea 🚀 ","created_at":"2018-02-26T18:47:21Z","updated_at":"2018-02-26T18:47:21Z","html_url":"https://github.com/fastlane/ci/pull/175#discussion_r170694494","pull_request_url":"https://api.github.com/repos/fastlane/ci/pulls/175","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments/170694494"},"html":{"href":"https://github.com/fastlane/ci/pull/175#discussion_r170694494"},"pull_request":{"href":"https://api.github.com/repos/fastlane/ci/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/ci/pulls/175","id":171458906,"html_url":"https://github.com/fastlane/ci/pull/175","diff_url":"https://github.com/fastlane/ci/pull/175.diff","patch_url":"https://github.com/fastlane/ci/pull/175.patch","issue_url":"https://api.github.com/repos/fastlane/ci/issues/175","number":175,"state":"open","locked":false,"title":"Fix the user authentication to properly assert the decoded password","user":{"login":"nakhbari","id":2754461,"avatar_url":"https://avatars0.githubusercontent.com/u/2754461?v=4","gravatar_id":"","url":"https://api.github.com/users/nakhbari","html_url":"https://github.com/nakhbari","followers_url":"https://api.github.com/users/nakhbari/followers","following_url":"https://api.github.com/users/nakhbari/following{/other_user}","gists_url":"https://api.github.com/users/nakhbari/gists{/gist_id}","starred_url":"https://api.github.com/users/nakhbari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakhbari/subscriptions","organizations_url":"https://api.github.com/users/nakhbari/orgs","repos_url":"https://api.github.com/users/nakhbari/repos","events_url":"https://api.github.com/users/nakhbari/events{/privacy}","received_events_url":"https://api.github.com/users/nakhbari/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-26T18:46:43Z","updated_at":"2018-02-26T18:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd03b91d80efcc3b69d848a8f0fdd4e08a84b095","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/ci/pulls/175/commits","review_comments_url":"https://api.github.com/repos/fastlane/ci/pulls/175/comments","review_comment_url":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/ci/issues/175/comments","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/878082aa987847d0de86114ff55dc67b4daac964","head":{"label":"fastlane:fix_password","ref":"fix_password","sha":"878082aa987847d0de86114ff55dc67b4daac964","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":114287404,"name":"ci","full_name":"fastlane/ci","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":false,"url":"https://api.github.com/repos/fastlane/ci","forks_url":"https://api.github.com/repos/fastlane/ci/forks","keys_url":"https://api.github.com/repos/fastlane/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/ci/teams","hooks_url":"https://api.github.com/repos/fastlane/ci/hooks","issue_events_url":"https://api.github.com/repos/fastlane/ci/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/ci/events","assignees_url":"https://api.github.com/repos/fastlane/ci/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/ci/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/ci/tags","blobs_url":"https://api.github.com/repos/fastlane/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/ci/languages","stargazers_url":"https://api.github.com/repos/fastlane/ci/stargazers","contributors_url":"https://api.github.com/repos/fastlane/ci/contributors","subscribers_url":"https://api.github.com/repos/fastlane/ci/subscribers","subscription_url":"https://api.github.com/repos/fastlane/ci/subscription","commits_url":"https://api.github.com/repos/fastlane/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/ci/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/ci/merges","archive_url":"https://api.github.com/repos/fastlane/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/ci/downloads","issues_url":"https://api.github.com/repos/fastlane/ci/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/ci/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/ci/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/ci/deployments","created_at":"2017-12-14T19:17:22Z","updated_at":"2018-02-26T15:32:23Z","pushed_at":"2018-02-26T18:46:44Z","git_url":"git://github.com/fastlane/ci.git","ssh_url":"git@github.com:fastlane/ci.git","clone_url":"https://github.com/fastlane/ci.git","svn_url":"https://github.com/fastlane/ci","homepage":"https://fastlane.tools","size":998,"stargazers_count":1156,"watchers_count":1156,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":37,"open_issues":41,"watchers":1156,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"948fb5c3e5b5837496cb54067bb2fc449c959cde","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":114287404,"name":"ci","full_name":"fastlane/ci","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars2.githubusercontent.com/u/11098337?v=4","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/ci","description":"Open source, self hosted, mobile optimized CI powered by fastlane","fork":false,"url":"https://api.github.com/repos/fastlane/ci","forks_url":"https://api.github.com/repos/fastlane/ci/forks","keys_url":"https://api.github.com/repos/fastlane/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/ci/teams","hooks_url":"https://api.github.com/repos/fastlane/ci/hooks","issue_events_url":"https://api.github.com/repos/fastlane/ci/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/ci/events","assignees_url":"https://api.github.com/repos/fastlane/ci/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/ci/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/ci/tags","blobs_url":"https://api.github.com/repos/fastlane/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/ci/languages","stargazers_url":"https://api.github.com/repos/fastlane/ci/stargazers","contributors_url":"https://api.github.com/repos/fastlane/ci/contributors","subscribers_url":"https://api.github.com/repos/fastlane/ci/subscribers","subscription_url":"https://api.github.com/repos/fastlane/ci/subscription","commits_url":"https://api.github.com/repos/fastlane/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/ci/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/ci/merges","archive_url":"https://api.github.com/repos/fastlane/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/ci/downloads","issues_url":"https://api.github.com/repos/fastlane/ci/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/ci/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/ci/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/ci/deployments","created_at":"2017-12-14T19:17:22Z","updated_at":"2018-02-26T15:32:23Z","pushed_at":"2018-02-26T18:46:44Z","git_url":"git://github.com/fastlane/ci.git","ssh_url":"git@github.com:fastlane/ci.git","clone_url":"https://github.com/fastlane/ci.git","svn_url":"https://github.com/fastlane/ci","homepage":"https://fastlane.tools","size":998,"stargazers_count":1156,"watchers_count":1156,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":37,"open_issues":41,"watchers":1156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/ci/pulls/175"},"html":{"href":"https://github.com/fastlane/ci/pull/175"},"issue":{"href":"https://api.github.com/repos/fastlane/ci/issues/175"},"comments":{"href":"https://api.github.com/repos/fastlane/ci/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/ci/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/ci/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/ci/statuses/878082aa987847d0de86114ff55dc67b4daac964"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"taquitos"}}