{"action":"created","comment":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/236510283","pull_request_review_id":178599428,"id":236510283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUxMDI4Mw==","diff_hunk":"@@ -53,32 +50,28 @@ public override async Task Initialize()\n                 allCountries.Insert(0, selectedElement);\n             }\n \n-            Suggestions.AddRange(\n-                allCountries.Select(country => new SelectableCountryViewModel(\n-                    country,\n-                    country.Id == selectedCountryId)));\n+            Countries = filterText\n+                .Select(text => text.Trim())\n+                .DistinctUntilChanged()\n+                .Select(trimmedText =>","path":"Toggl.Foundation.MvvmCross/ViewModels/SelectCountryViewModel.cs","position":74,"original_position":74,"commit_id":"d8155def9b6ff539c3fc791e5f27ab89a150e28f","original_commit_id":"d8155def9b6ff539c3fc791e5f27ab89a150e28f","user":{"login":"khoi","id":6994441,"node_id":"MDQ6VXNlcjY5OTQ0NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/6994441?v=4","gravatar_id":"","url":"https://api.github.com/users/khoi","html_url":"https://github.com/khoi","followers_url":"https://api.github.com/users/khoi/followers","following_url":"https://api.github.com/users/khoi/following{/other_user}","gists_url":"https://api.github.com/users/khoi/gists{/gist_id}","starred_url":"https://api.github.com/users/khoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoi/subscriptions","organizations_url":"https://api.github.com/users/khoi/orgs","repos_url":"https://api.github.com/users/khoi/repos","events_url":"https://api.github.com/users/khoi/events{/privacy}","received_events_url":"https://api.github.com/users/khoi/received_events","type":"User","site_admin":false},"body":"hmm, I tried to extract this out to a local function, but it doesn't look nicer. I prefer the closure version better. How would you name the method?","created_at":"2018-11-27T03:40:46Z","updated_at":"2018-11-27T03:40:46Z","html_url":"https://github.com/toggl/mobileapp/pull/3752#discussion_r236510283","pull_request_url":"https://api.github.com/repos/toggl/mobileapp/pulls/3752","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/236510283"},"html":{"href":"https://github.com/toggl/mobileapp/pull/3752#discussion_r236510283"},"pull_request":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3752"}},"in_reply_to_id":236248702},"pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/3752","id":233121587,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTIxNTg3","html_url":"https://github.com/toggl/mobileapp/pull/3752","diff_url":"https://github.com/toggl/mobileapp/pull/3752.diff","patch_url":"https://github.com/toggl/mobileapp/pull/3752.patch","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/3752","number":3752,"state":"open","locked":false,"title":"🇻🇳Rxfactor SelectCountryViewModel","user":{"login":"khoi","id":6994441,"node_id":"MDQ6VXNlcjY5OTQ0NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/6994441?v=4","gravatar_id":"","url":"https://api.github.com/users/khoi","html_url":"https://github.com/khoi","followers_url":"https://api.github.com/users/khoi/followers","following_url":"https://api.github.com/users/khoi/following{/other_user}","gists_url":"https://api.github.com/users/khoi/gists{/gist_id}","starred_url":"https://api.github.com/users/khoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoi/subscriptions","organizations_url":"https://api.github.com/users/khoi/orgs","repos_url":"https://api.github.com/users/khoi/repos","events_url":"https://api.github.com/users/khoi/events{/privacy}","received_events_url":"https://api.github.com/users/khoi/received_events","type":"User","site_admin":false},"body":"## What's this?\nRxfactor of country selection screen.\n\n### Relationships\nPart of #3352\n\n## Why do we want this?\n🔫 mvx\n\n## How is it done?\nThe VM exposes `IObservable<IEnumerable<SelectableCountryViewModel>>` which get binded to the table.\n\n### Why not another way?\n\n\n### Side effects\nI don't think there is any.\n\n## Review hints\nNone.\n\nThe implementation is similar to #3600\n\n## :squid: Permissions\n🦑","created_at":"2018-11-23T07:23:23Z","updated_at":"2018-11-27T03:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":772341325,"node_id":"MDU6TGFiZWw3NzIzNDEzMjU=","url":"https://api.github.com/repos/toggl/mobileapp/labels/android","name":"android","color":"A4C639","default":false},{"id":831152836,"node_id":"MDU6TGFiZWw4MzExNTI4MzY=","url":"https://api.github.com/repos/toggl/mobileapp/labels/foundation","name":"foundation","color":"646490","default":false},{"id":773208974,"node_id":"MDU6TGFiZWw3NzMyMDg5NzQ=","url":"https://api.github.com/repos/toggl/mobileapp/labels/ios","name":"ios","color":"51bdf7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/toggl/mobileapp/pulls/3752/commits","review_comments_url":"https://api.github.com/repos/toggl/mobileapp/pulls/3752/comments","review_comment_url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/3752/comments","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/d8155def9b6ff539c3fc791e5f27ab89a150e28f","head":{"label":"toggl:khoi/rx-select-country-vm","ref":"khoi/rx-select-country-vm","sha":"d8155def9b6ff539c3fc791e5f27ab89a150e28f","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-11-26T17:19:05Z","pushed_at":"2018-11-26T21:28:57Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":27447,"stargazers_count":95,"watchers_count":95,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":289,"watchers":95,"default_branch":"develop"}},"base":{"label":"toggl:develop","ref":"develop","sha":"4ccacad2a0d21ae45f4974eb67320d7e8cad394a","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","private":false,"owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-11-26T17:19:05Z","pushed_at":"2018-11-26T21:28:57Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":27447,"stargazers_count":95,"watchers_count":95,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":32,"open_issues":289,"watchers":95,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3752"},"html":{"href":"https://github.com/toggl/mobileapp/pull/3752"},"issue":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/3752"},"comments":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/3752/comments"},"review_comments":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3752/comments"},"review_comment":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/3752/commits"},"statuses":{"href":"https://api.github.com/repos/toggl/mobileapp/statuses/d8155def9b6ff539c3fc791e5f27ab89a150e28f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"khoi"}}