{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/230465182","pull_request_review_id":171216941,"id":230465182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ2NTE4Mg==","diff_hunk":"@@ -623,12 +611,10 @@ protected override void Dispose(bool disposing)\n \n                 FinishPendingIORequests();\n \n-                // Signal the other side that we're closing.  Should do regardless of whether we've called\n-                // Close() or not Dispose()\n+                // Signal the other side that we're closing\n                 if (_handle != null && !_handle.IsInvalid)","path":"src/System.IO.Ports/src/System/IO/Ports/SerialStream.Unix.cs","position":67,"original_position":67,"commit_id":"c3cf165b310bbd6f418d7c619d35f4fddc5b52d1","original_commit_id":"c3cf165b310bbd6f418d7c619d35f4fddc5b52d1","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"You don't need the `&& !_handle.IsInvalid` check.  Just Dispose it.","created_at":"2018-11-02T18:19:50Z","updated_at":"2018-11-02T18:19:50Z","html_url":"https://github.com/dotnet/corefx/pull/33221#discussion_r230465182","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/33221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/230465182"},"html":{"href":"https://github.com/dotnet/corefx/pull/33221#discussion_r230465182"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33221"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33221","id":228000096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDAwMDk2","html_url":"https://github.com/dotnet/corefx/pull/33221","diff_url":"https://github.com/dotnet/corefx/pull/33221.diff","patch_url":"https://github.com/dotnet/corefx/pull/33221.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33221","number":33221,"state":"open","locked":false,"title":"Improve/fix SerialStream.Dispose","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"This is fixing an issue where opening UART device on RaspberryPI is causing it to be forever locked and not openable anymore (exclusive access set on file descriptor is not being reset automatically when close is called). I also improved the dispose a bit so that all of the shutdown stuff is wrapped in the SafeHandle.\r\n\r\ncontributes to: https://github.com/dotnet/corefx/issues/33146\r\n\r\ncc: @joshfree ","created_at":"2018-11-02T16:58:52Z","updated_at":"2018-11-02T18:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d6f600718c24c6468df63351029f4f850b27e46","assignee":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"assignees":[{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JeremyKuhne","id":8184940,"node_id":"MDQ6VXNlcjgxODQ5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8184940?v=4","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":154422420,"node_id":"MDU6TGFiZWwxNTQ0MjI0MjA=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.IO","name":"area-System.IO","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33221/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33221/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33221/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/c3cf165b310bbd6f418d7c619d35f4fddc5b52d1","head":{"label":"krwq:sp_dispose","ref":"sp_dispose","sha":"c3cf165b310bbd6f418d7c619d35f4fddc5b52d1","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"repo":{"id":26556399,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU1NjM5OQ==","name":"corefx","full_name":"krwq/corefx","private":false,"owner":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krwq/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/krwq/corefx","forks_url":"https://api.github.com/repos/krwq/corefx/forks","keys_url":"https://api.github.com/repos/krwq/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krwq/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krwq/corefx/teams","hooks_url":"https://api.github.com/repos/krwq/corefx/hooks","issue_events_url":"https://api.github.com/repos/krwq/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/krwq/corefx/events","assignees_url":"https://api.github.com/repos/krwq/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/krwq/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/krwq/corefx/tags","blobs_url":"https://api.github.com/repos/krwq/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krwq/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krwq/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/krwq/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krwq/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/krwq/corefx/languages","stargazers_url":"https://api.github.com/repos/krwq/corefx/stargazers","contributors_url":"https://api.github.com/repos/krwq/corefx/contributors","subscribers_url":"https://api.github.com/repos/krwq/corefx/subscribers","subscription_url":"https://api.github.com/repos/krwq/corefx/subscription","commits_url":"https://api.github.com/repos/krwq/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/krwq/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/krwq/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/krwq/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/krwq/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/krwq/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krwq/corefx/merges","archive_url":"https://api.github.com/repos/krwq/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krwq/corefx/downloads","issues_url":"https://api.github.com/repos/krwq/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/krwq/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/krwq/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/krwq/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krwq/corefx/labels{/name}","releases_url":"https://api.github.com/repos/krwq/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/krwq/corefx/deployments","created_at":"2014-11-12T21:11:44Z","updated_at":"2016-10-24T18:54:42Z","pushed_at":"2018-11-02T16:32:17Z","git_url":"git://github.com/krwq/corefx.git","ssh_url":"git@github.com:krwq/corefx.git","clone_url":"https://github.com/krwq/corefx.git","svn_url":"https://github.com/krwq/corefx","homepage":"","size":184769,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5ce7a52c22f6f4cfe0824739a24e895cd87f8f61","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-02T16:35:15Z","pushed_at":"2018-11-02T18:11:17Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":190536,"stargazers_count":15077,"watchers_count":15077,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4464,"mirror_url":null,"archived":false,"open_issues_count":2584,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4464,"open_issues":2584,"watchers":15077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33221"},"html":{"href":"https://github.com/dotnet/corefx/pull/33221"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33221"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33221/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33221/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33221/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/c3cf165b310bbd6f418d7c619d35f4fddc5b52d1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stephentoub"}}