{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/199882160","pull_request_review_id":134088352,"id":199882160,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg4MjE2MA==","diff_hunk":"@@ -403,3 +414,19 @@ __pairs()\n \n Iterates through every *metadata* entry. *key* is a string that supplies a *metadata*\n key. *value* is *metadata* entry value.\n+\n+.. _config_http_filters_lua_connection_wrapper:\n+\n+Connection object API\n+---------------------\n+\n+secure()","path":"docs/root/configuration/http_filters/lua_filter.rst","position":28,"original_position":28,"commit_id":"f16e2207b9c1a58633c5f1e25cfb296b9bf257dc","original_commit_id":"f16e2207b9c1a58633c5f1e25cfb296b9bf257dc","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Thing for the future where I'm guessing people are going to ask for SSL/TLS connection properties in Lua, should we instead return an SSL/TLS object? This object could have no methods right now but the presence of the object or nil could indicate secure? Just thinking for the future. Thoughts?","created_at":"2018-07-03T16:59:11Z","updated_at":"2018-07-03T16:59:19Z","html_url":"https://github.com/envoyproxy/envoy/pull/3761#discussion_r199882160","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/199882160"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3761#discussion_r199882160"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761","id":198292796,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjkyNzk2","html_url":"https://github.com/envoyproxy/envoy/pull/3761","diff_url":"https://github.com/envoyproxy/envoy/pull/3761.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3761.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3761","number":3761,"state":"open","locked":false,"title":"lua: add connection():secure() API","user":{"login":"dio","id":73152,"node_id":"MDQ6VXNlcjczMTUy","avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nThis patch adds `connection():secure()` to `StreamHandleWrapper`. This\r\nAPI returns the indication if the underlying connection using SSL or not.\r\n\r\n*Risk Level*: Low\r\n\r\n*Testing*: \r\nUnit and integration tests\r\n\r\n*Docs Changes*: \r\n- Add `connection():secure()` API.\r\n\r\n*Release Notes*:\r\n- lua: added `connection()` wrapper and `secure()` API.\r\n\r\nRelated issue: #3704\r\n\r\nSigned-off-by: Dhi Aurrahman <dio@rockybars.com>","created_at":"2018-06-29T11:40:30Z","updated_at":"2018-07-03T16:59:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c53af59b4a8edad066c4c6eb84bf412f1e8b657","assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3761/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/f16e2207b9c1a58633c5f1e25cfb296b9bf257dc","head":{"label":"dio:lua-connection-secure","ref":"lua-connection-secure","sha":"f16e2207b9c1a58633c5f1e25cfb296b9bf257dc","user":{"login":"dio","id":73152,"node_id":"MDQ6VXNlcjczMTUy","avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"repo":{"id":105332260,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzMzIyNjA=","name":"envoy","full_name":"dio/envoy","owner":{"login":"dio","id":73152,"node_id":"MDQ6VXNlcjczMTUy","avatar_url":"https://avatars3.githubusercontent.com/u/73152?v=4","gravatar_id":"","url":"https://api.github.com/users/dio","html_url":"https://github.com/dio","followers_url":"https://api.github.com/users/dio/followers","following_url":"https://api.github.com/users/dio/following{/other_user}","gists_url":"https://api.github.com/users/dio/gists{/gist_id}","starred_url":"https://api.github.com/users/dio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dio/subscriptions","organizations_url":"https://api.github.com/users/dio/orgs","repos_url":"https://api.github.com/users/dio/repos","events_url":"https://api.github.com/users/dio/events{/privacy}","received_events_url":"https://api.github.com/users/dio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dio/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/dio/envoy","forks_url":"https://api.github.com/repos/dio/envoy/forks","keys_url":"https://api.github.com/repos/dio/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dio/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dio/envoy/teams","hooks_url":"https://api.github.com/repos/dio/envoy/hooks","issue_events_url":"https://api.github.com/repos/dio/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/dio/envoy/events","assignees_url":"https://api.github.com/repos/dio/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/dio/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/dio/envoy/tags","blobs_url":"https://api.github.com/repos/dio/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dio/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dio/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dio/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dio/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/dio/envoy/languages","stargazers_url":"https://api.github.com/repos/dio/envoy/stargazers","contributors_url":"https://api.github.com/repos/dio/envoy/contributors","subscribers_url":"https://api.github.com/repos/dio/envoy/subscribers","subscription_url":"https://api.github.com/repos/dio/envoy/subscription","commits_url":"https://api.github.com/repos/dio/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dio/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dio/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dio/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dio/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/dio/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dio/envoy/merges","archive_url":"https://api.github.com/repos/dio/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dio/envoy/downloads","issues_url":"https://api.github.com/repos/dio/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/dio/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/dio/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/dio/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dio/envoy/labels{/name}","releases_url":"https://api.github.com/repos/dio/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/dio/envoy/deployments","created_at":"2017-09-30T01:53:34Z","updated_at":"2018-07-03T02:17:31Z","pushed_at":"2018-07-03T16:39:13Z","git_url":"git://github.com/dio/envoy.git","ssh_url":"git@github.com:dio/envoy.git","clone_url":"https://github.com/dio/envoy.git","svn_url":"https://github.com/dio/envoy","homepage":"https://envoyproxy.github.io/","size":55502,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"93d96b52b47ac2f296379c15b03946cb33c58252","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-07-03T16:24:33Z","pushed_at":"2018-07-03T16:46:03Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":17118,"stargazers_count":5563,"watchers_count":5563,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":705,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":705,"open_issues":324,"watchers":5563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3761"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3761"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3761/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3761/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/f16e2207b9c1a58633c5f1e25cfb296b9bf257dc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattklein123"}}