{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22195","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22195/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22195/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22195/events","html_url":"https://github.com/Automattic/wp-calypso/pull/22195","id":294988197,"number":22195,"title":"2FA: TwoStepAuthorization.fetch no longer sends a code via SMS.","user":{"login":"rodrigoi","id":233601,"avatar_url":"https://avatars2.githubusercontent.com/u/233601?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigoi","html_url":"https://github.com/rodrigoi","followers_url":"https://api.github.com/users/rodrigoi/followers","following_url":"https://api.github.com/users/rodrigoi/following{/other_user}","gists_url":"https://api.github.com/users/rodrigoi/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigoi/subscriptions","organizations_url":"https://api.github.com/users/rodrigoi/orgs","repos_url":"https://api.github.com/users/rodrigoi/repos","events_url":"https://api.github.com/users/rodrigoi/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigoi/received_events","type":"User","site_admin":false},"labels":[{"id":287948414,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Security","name":"Security","color":"006b75","default":false},{"id":285010007,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Pri]%20High","name":"[Pri] High","color":"ec9a71","default":false},{"id":285010017,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20In%20Progress","name":"[Status] In Progress","color":"207de5","default":false},{"id":285010023,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"13CDF7","default":false},{"id":285009975,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Bug","name":"[Type] Bug","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"rodrigoi","id":233601,"avatar_url":"https://avatars2.githubusercontent.com/u/233601?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigoi","html_url":"https://github.com/rodrigoi","followers_url":"https://api.github.com/users/rodrigoi/followers","following_url":"https://api.github.com/users/rodrigoi/following{/other_user}","gists_url":"https://api.github.com/users/rodrigoi/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigoi/subscriptions","organizations_url":"https://api.github.com/users/rodrigoi/orgs","repos_url":"https://api.github.com/users/rodrigoi/repos","events_url":"https://api.github.com/users/rodrigoi/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigoi/received_events","type":"User","site_admin":false},"assignees":[{"login":"rodrigoi","id":233601,"avatar_url":"https://avatars2.githubusercontent.com/u/233601?v=4","gravatar_id":"","url":"https://api.github.com/users/rodrigoi","html_url":"https://github.com/rodrigoi","followers_url":"https://api.github.com/users/rodrigoi/followers","following_url":"https://api.github.com/users/rodrigoi/following{/other_user}","gists_url":"https://api.github.com/users/rodrigoi/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigoi/subscriptions","organizations_url":"https://api.github.com/users/rodrigoi/orgs","repos_url":"https://api.github.com/users/rodrigoi/repos","events_url":"https://api.github.com/users/rodrigoi/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigoi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-02-07T02:47:47Z","updated_at":"2018-02-08T20:16:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/22195","html_url":"https://github.com/Automattic/wp-calypso/pull/22195","diff_url":"https://github.com/Automattic/wp-calypso/pull/22195.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/22195.patch"},"body":"Part of #22100 \r\n\r\nHow to test:\r\n\r\n- Start a session with a WordPress.com user with SMS only Two-Factor Authentication enabled.\r\n- Delete the 2FA cookie.\r\n- Navigate to the `/me` section.\r\n\r\nThe 2FA dialog should show with a _Send SMS Code_ button, and no SMS should be sent unless that button is clicked.\r\n\r\n![screen shot 2018-02-08 at 00 12 51](https://user-images.githubusercontent.com/233601/35953753-dce0216c-0c64-11e8-8bd1-857c585e5038.png)\r\n\r\nThrottle should work as expected and accounts with SMS and App Codes shouldn't be affected.\r\n\r\n![screen shot 2018-02-08 at 00 24 07](https://user-images.githubusercontent.com/233601/35954110-ab9d5398-0c66-11e8-859a-263df8460a6f.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/364235168","html_url":"https://github.com/Automattic/wp-calypso/pull/22195#issuecomment-364235168","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/22195","id":364235168,"user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T20:16:29Z","updated_at":"2018-02-08T20:16:29Z","author_association":"OWNER","body":"Thanks @rodrigoi looks like this works pretty well. \r\n\r\n@iamtakashi or @drw158 any suggestions on the modal design?\r\n\r\nAfter this we'll want to follow up on:\r\n- [ ] Tracing down the privileged endpoints calling outside of /me\r\n- [ ] Depending on ^^ we'll either make this modal available in any section or move actions to /me\r\n- [ ] Add some sort of automated warning for developers to not call such endpoints outside of /me\r\n"}}
{"actor":{"display_login":"gwwar"}}