{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/tarmak/issues/288","repository_url":"https://api.github.com/repos/jetstack/tarmak","labels_url":"https://api.github.com/repos/jetstack/tarmak/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/288/comments","events_url":"https://api.github.com/repos/jetstack/tarmak/issues/288/events","html_url":"https://github.com/jetstack/tarmak/pull/288","id":329459120,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzA5MTc5","number":288,"title":"Improve vault tunnel creation","user":{"login":"dippynark","id":28210877,"node_id":"MDQ6VXNlcjI4MjEwODc3","avatar_url":"https://avatars3.githubusercontent.com/u/28210877?v=4","gravatar_id":"","url":"https://api.github.com/users/dippynark","html_url":"https://github.com/dippynark","followers_url":"https://api.github.com/users/dippynark/followers","following_url":"https://api.github.com/users/dippynark/following{/other_user}","gists_url":"https://api.github.com/users/dippynark/gists{/gist_id}","starred_url":"https://api.github.com/users/dippynark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippynark/subscriptions","organizations_url":"https://api.github.com/users/dippynark/orgs","repos_url":"https://api.github.com/users/dippynark/repos","events_url":"https://api.github.com/users/dippynark/events{/privacy}","received_events_url":"https://api.github.com/users/dippynark/received_events","type":"User","site_admin":false},"labels":[{"id":729324202,"node_id":"MDU6TGFiZWw3MjkzMjQyMDI=","url":"https://api.github.com/repos/jetstack/tarmak/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":729324234,"node_id":"MDU6TGFiZWw3MjkzMjQyMzQ=","url":"https://api.github.com/repos/jetstack/tarmak/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"dippynark","id":28210877,"node_id":"MDQ6VXNlcjI4MjEwODc3","avatar_url":"https://avatars3.githubusercontent.com/u/28210877?v=4","gravatar_id":"","url":"https://api.github.com/users/dippynark","html_url":"https://github.com/dippynark","followers_url":"https://api.github.com/users/dippynark/followers","following_url":"https://api.github.com/users/dippynark/following{/other_user}","gists_url":"https://api.github.com/users/dippynark/gists{/gist_id}","starred_url":"https://api.github.com/users/dippynark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippynark/subscriptions","organizations_url":"https://api.github.com/users/dippynark/orgs","repos_url":"https://api.github.com/users/dippynark/repos","events_url":"https://api.github.com/users/dippynark/events{/privacy}","received_events_url":"https://api.github.com/users/dippynark/received_events","type":"User","site_admin":false},"assignees":[{"login":"dippynark","id":28210877,"node_id":"MDQ6VXNlcjI4MjEwODc3","avatar_url":"https://avatars3.githubusercontent.com/u/28210877?v=4","gravatar_id":"","url":"https://api.github.com/users/dippynark","html_url":"https://github.com/dippynark","followers_url":"https://api.github.com/users/dippynark/followers","following_url":"https://api.github.com/users/dippynark/following{/other_user}","gists_url":"https://api.github.com/users/dippynark/gists{/gist_id}","starred_url":"https://api.github.com/users/dippynark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dippynark/subscriptions","organizations_url":"https://api.github.com/users/dippynark/orgs","repos_url":"https://api.github.com/users/dippynark/repos","events_url":"https://api.github.com/users/dippynark/events{/privacy}","received_events_url":"https://api.github.com/users/dippynark/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-05T13:34:30Z","updated_at":"2018-06-08T10:34:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/288","html_url":"https://github.com/jetstack/tarmak/pull/288","diff_url":"https://github.com/jetstack/tarmak/pull/288.diff","patch_url":"https://github.com/jetstack/tarmak/pull/288.patch"},"body":"This PR fixes the following:\r\n- when testing connection to the bastion before creating vault tunnels, we use the `-N` flag, which shouldn't be used as we are running a remote command (`/bin/true`)\r\n- when creating vault tunnels, if a problem occurs, there was a chance we could hang indefinitely - this change reduces the chance of a blocking channel so that this hanging doesn't occur\r\n\r\n```release-note\r\nImprove Vault tunnel creation preventing indefinite hanging in certain situations\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/tarmak/issues/comments/395721645","html_url":"https://github.com/jetstack/tarmak/pull/288#issuecomment-395721645","issue_url":"https://api.github.com/repos/jetstack/tarmak/issues/288","id":395721645,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTcyMTY0NQ==","user":{"login":"jetstack-bot","id":32282838,"node_id":"MDQ6VXNlcjMyMjgyODM4","avatar_url":"https://avatars1.githubusercontent.com/u/32282838?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-bot","html_url":"https://github.com/jetstack-bot","followers_url":"https://api.github.com/users/jetstack-bot/followers","following_url":"https://api.github.com/users/jetstack-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-bot/orgs","repos_url":"https://api.github.com/users/jetstack-bot/repos","events_url":"https://api.github.com/users/jetstack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T10:34:53Z","updated_at":"2018-06-08T10:34:53Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: \nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **dippynark**\n\nAssign the PR to them by writing `/assign @dippynark` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/jetstack/tarmak/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dippynark\"]} -->"}}
{"actor":{"display_login":"jetstack-bot"}}