{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/188769203","pull_request_review_id":120815811,"id":188769203,"diff_hunk":"@@ -30,14 +20,12 @@ $ mvn spring-boot:run\n ----\n \n Browse to `http://localhost:8080`. This will trigger the `ExampleController.work()` method,\n-which in turn will call other services, and also a remote RESTful call to `ExampleController.meet()`\n-method.\n+which in turn will call other services, and also a remote RESTful call to `ExampleController.meet()` method.\n \n-To see the traces, navigate to Stackdriver Trace console's\n-https://console.cloud.google.com/traces/traces[Trace List] view.\n+To see the traces, navigate to Stackdriver Trace console's https://console.cloud.google.com/traces/traces[Trace List] view.\n You should see the trace information in detail.\n+Additionally, if you logged in with the Google Cloud SDK or have the `GOOGLE_CLOUD_PROJECT` environment variable set to your GCP project ID, you can also click the `View` link in front of the `Details` -> `Log` to view the log entries related to that trace ID.","path":"spring-cloud-gcp-samples/spring-cloud-gcp-trace-sample/README.adoc","position":44,"original_position":44,"commit_id":"a3a04765b47a33c467f3bf71cab90917becb967f","original_commit_id":"a3a04765b47a33c467f3bf71cab90917becb967f","user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"body":"This is really the only addition here. The rest is just putting sentences in the same line.","created_at":"2018-05-16T20:53:52Z","updated_at":"2018-05-16T20:53:52Z","html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683#discussion_r188769203","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments/188769203"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683#discussion_r188769203"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683","id":188556949,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683","diff_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/683","number":683,"state":"open","locked":false,"title":"Sets trace ID in log entries correctly","user":{"login":"joaoandremartins","id":3290856,"avatar_url":"https://avatars0.githubusercontent.com/u/3290856?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoandremartins","html_url":"https://github.com/joaoandremartins","followers_url":"https://api.github.com/users/joaoandremartins/followers","following_url":"https://api.github.com/users/joaoandremartins/following{/other_user}","gists_url":"https://api.github.com/users/joaoandremartins/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoandremartins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoandremartins/subscriptions","organizations_url":"https://api.github.com/users/joaoandremartins/orgs","repos_url":"https://api.github.com/users/joaoandremartins/repos","events_url":"https://api.github.com/users/joaoandremartins/events{/privacy}","received_events_url":"https://api.github.com/users/joaoandremartins/received_events","type":"User","site_admin":false},"body":"Adds a new logging enhancer that sets the right field for the log\r\nentries to be linkable from a trace, in the Google Cloud Console.\r\nAlso updates Trace code sample to show this capability.\r\n\r\nFixes #664","created_at":"2018-05-16T20:53:27Z","updated_at":"2018-05-16T20:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96fcaa7b591bdb0f0d50ab362d56a50e465e3636","assignee":null,"assignees":[],"requested_reviewers":[{"login":"artembilan","id":1071590,"avatar_url":"https://avatars3.githubusercontent.com/u/1071590?v=4","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},{"login":"ChengyuanZhao","id":29288945,"avatar_url":"https://avatars3.githubusercontent.com/u/29288945?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengyuanZhao","html_url":"https://github.com/ChengyuanZhao","followers_url":"https://api.github.com/users/ChengyuanZhao/followers","following_url":"https://api.github.com/users/ChengyuanZhao/following{/other_user}","gists_url":"https://api.github.com/users/ChengyuanZhao/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengyuanZhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengyuanZhao/subscriptions","organizations_url":"https://api.github.com/users/ChengyuanZhao/orgs","repos_url":"https://api.github.com/users/ChengyuanZhao/repos","events_url":"https://api.github.com/users/ChengyuanZhao/events{/privacy}","received_events_url":"https://api.github.com/users/ChengyuanZhao/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/683/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/a3a04765b47a33c467f3bf71cab90917becb967f","head":{"label":"spring-cloud:gh-664-trace-id","ref":"gh-664-trace-id","sha":"a3a04765b47a33c467f3bf71cab90917becb967f","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":86105877,"name":"spring-cloud-gcp","full_name":"spring-cloud/spring-cloud-gcp","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/deployments","created_at":"2017-03-24T19:58:20Z","updated_at":"2018-05-16T18:59:29Z","pushed_at":"2018-05-16T20:53:28Z","git_url":"git://github.com/spring-cloud/spring-cloud-gcp.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-gcp.git","clone_url":"https://github.com/spring-cloud/spring-cloud-gcp.git","svn_url":"https://github.com/spring-cloud/spring-cloud-gcp","homepage":null,"size":2896,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":53,"open_issues":50,"watchers":116,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"1e04d47f8f70dacd260b304ad797073c1bfb5333","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":86105877,"name":"spring-cloud-gcp","full_name":"spring-cloud/spring-cloud-gcp","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-gcp","description":"Integration for Google Cloud Platform APIs with Spring","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/deployments","created_at":"2017-03-24T19:58:20Z","updated_at":"2018-05-16T18:59:29Z","pushed_at":"2018-05-16T20:53:28Z","git_url":"git://github.com/spring-cloud/spring-cloud-gcp.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-gcp.git","clone_url":"https://github.com/spring-cloud/spring-cloud-gcp.git","svn_url":"https://github.com/spring-cloud/spring-cloud-gcp","homepage":null,"size":2896,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":53,"open_issues":50,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-gcp/pull/683"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/683"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-gcp/statuses/a3a04765b47a33c467f3bf71cab90917becb967f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"joaoandremartins"}}