{"action":"created","issue":{"url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/25","repository_url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys","labels_url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/25/comments","events_url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/25/events","html_url":"https://github.com/BayAreaMetro/onboard-surveys/pull/25","id":376102846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzk2NzI3","number":25,"title":"Canonical Route Names - NEW BRANCH","user":{"login":"jhelsel11","id":29383881,"node_id":"MDQ6VXNlcjI5MzgzODgx","avatar_url":"https://avatars0.githubusercontent.com/u/29383881?v=4","gravatar_id":"","url":"https://api.github.com/users/jhelsel11","html_url":"https://github.com/jhelsel11","followers_url":"https://api.github.com/users/jhelsel11/followers","following_url":"https://api.github.com/users/jhelsel11/following{/other_user}","gists_url":"https://api.github.com/users/jhelsel11/gists{/gist_id}","starred_url":"https://api.github.com/users/jhelsel11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhelsel11/subscriptions","organizations_url":"https://api.github.com/users/jhelsel11/orgs","repos_url":"https://api.github.com/users/jhelsel11/repos","events_url":"https://api.github.com/users/jhelsel11/events{/privacy}","received_events_url":"https://api.github.com/users/jhelsel11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-31T18:28:12Z","updated_at":"2018-11-02T23:45:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/pulls/25","html_url":"https://github.com/BayAreaMetro/onboard-surveys/pull/25","diff_url":"https://github.com/BayAreaMetro/onboard-surveys/pull/25.diff","patch_url":"https://github.com/BayAreaMetro/onboard-surveys/pull/25.patch"},"body":"This code began on the transitland_database branch, but is being moved to a new branch because transitland did not work out. See Canonical Route Names - OLD DISCUSSION for pull request comments prior to the new name."},"comment":{"url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/comments/435540258","html_url":"https://github.com/BayAreaMetro/onboard-surveys/pull/25#issuecomment-435540258","issue_url":"https://api.github.com/repos/BayAreaMetro/onboard-surveys/issues/25","id":435540258,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTU0MDI1OA==","user":{"login":"jhelsel11","id":29383881,"node_id":"MDQ6VXNlcjI5MzgzODgx","avatar_url":"https://avatars0.githubusercontent.com/u/29383881?v=4","gravatar_id":"","url":"https://api.github.com/users/jhelsel11","html_url":"https://github.com/jhelsel11","followers_url":"https://api.github.com/users/jhelsel11/followers","following_url":"https://api.github.com/users/jhelsel11/following{/other_user}","gists_url":"https://api.github.com/users/jhelsel11/gists{/gist_id}","starred_url":"https://api.github.com/users/jhelsel11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhelsel11/subscriptions","organizations_url":"https://api.github.com/users/jhelsel11/orgs","repos_url":"https://api.github.com/users/jhelsel11/repos","events_url":"https://api.github.com/users/jhelsel11/events{/privacy}","received_events_url":"https://api.github.com/users/jhelsel11/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T23:45:15Z","updated_at":"2018-11-02T23:45:15Z","author_association":"COLLABORATOR","body":"@DavidOry I've made a first pass at changing \"BART\" to the boarding and alighting stations. It works for a very limited case (one set of lat/long coordinates for BART only for the SF Muni survey), but I think I can turn it into a function and handle more use cases. In my mind the next steps for this effort are:\r\n1) Turn lines 565 to 643 of standard_route_name_db.R into a function that takes strings as inputs to handle each of the route legs.\r\n2) Go through the minimum distance calculation. Right now more than half of the minimum distances between boarding or alighting lat/long are more than 5000 meters. Something has clearly gone wrong given what the stations look like when they're actually mapped. If we want to keep this in simple features, I'll have to dive more deeply into the st_distance function. Alternatively, the coordinates can be brought out of sfc objects, and we do a cartesian distance calculation directly on the coordinates.\r\n3) The BART replacement with station names needs to be moved prior to the code creating the canonical names.\r\n4) The canonical names code needs to be redone to handle the new BART station names.\r\n5) The minimum distance code needs to handle all use cases for sf_muni, caltrain, bart, and ac_transit surveys."}}
{"actor":{"display_login":"jhelsel11"}}