{"action":"closed","number":399,"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399","id":228877438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODc3NDM4","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/399","diff_url":"https://github.com/kubernetes-sigs/federation-v2/pull/399.diff","patch_url":"https://github.com/kubernetes-sigs/federation-v2/pull/399.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/399","number":399,"state":"closed","locked":false,"title":"Migrate ReplicaSchedulingPreferences controller to the dynamic client","user":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"body":"This PR migrates the RSP controller to use the dynamic client both in anticipation of generic overrides and the removal of primitive CRDs from the codebase in favor of generating them with `kubefed2 federate`. ","created_at":"2018-11-07T00:10:45Z","updated_at":"2018-11-20T07:00:48Z","closed_at":"2018-11-20T07:00:48Z","merged_at":"2018-11-20T07:00:48Z","merge_commit_sha":"c65bcf44afc671841e4dbed84e64b00ebe6256f7","assignee":{"login":"irfanurrehman","id":10027921,"node_id":"MDQ6VXNlcjEwMDI3OTIx","avatar_url":"https://avatars0.githubusercontent.com/u/10027921?v=4","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false},"assignees":[{"login":"irfanurrehman","id":10027921,"node_id":"MDQ6VXNlcjEwMDI3OTIx","avatar_url":"https://avatars0.githubusercontent.com/u/10027921?v=4","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"font","id":3596535,"node_id":"MDQ6VXNlcjM1OTY1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3596535?v=4","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},{"login":"shashidharatd","id":8734900,"node_id":"MDQ6VXNlcjg3MzQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":909764227,"node_id":"MDU6TGFiZWw5MDk3NjQyMjc=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":888036019,"node_id":"MDU6TGFiZWw4ODgwMzYwMTk=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":908823522,"node_id":"MDU6TGFiZWw5MDg4MjM1MjI=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":888036092,"node_id":"MDU6TGFiZWw4ODgwMzYwOTI=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/399/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/30689f6ab11d8c4d60f5f4171a11437bc5396f95","head":{"label":"marun:rsp-dynamic-client","ref":"rsp-dynamic-client","sha":"30689f6ab11d8c4d60f5f4171a11437bc5396f95","user":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"repo":{"id":130527783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1Mjc3ODM=","name":"federation-v2","full_name":"marun/federation-v2","private":false,"owner":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marun/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":true,"url":"https://api.github.com/repos/marun/federation-v2","forks_url":"https://api.github.com/repos/marun/federation-v2/forks","keys_url":"https://api.github.com/repos/marun/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marun/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marun/federation-v2/teams","hooks_url":"https://api.github.com/repos/marun/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/marun/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/marun/federation-v2/events","assignees_url":"https://api.github.com/repos/marun/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/marun/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/marun/federation-v2/tags","blobs_url":"https://api.github.com/repos/marun/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marun/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marun/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/marun/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marun/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/marun/federation-v2/languages","stargazers_url":"https://api.github.com/repos/marun/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/marun/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/marun/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/marun/federation-v2/subscription","commits_url":"https://api.github.com/repos/marun/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/marun/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/marun/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/marun/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/marun/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/marun/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marun/federation-v2/merges","archive_url":"https://api.github.com/repos/marun/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marun/federation-v2/downloads","issues_url":"https://api.github.com/repos/marun/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/marun/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/marun/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/marun/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marun/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/marun/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/marun/federation-v2/deployments","created_at":"2018-04-22T02:15:08Z","updated_at":"2018-08-24T16:41:38Z","pushed_at":"2018-11-19T23:11:30Z","git_url":"git://github.com/marun/federation-v2.git","ssh_url":"git@github.com:marun/federation-v2.git","clone_url":"https://github.com/marun/federation-v2.git","svn_url":"https://github.com/marun/federation-v2","homepage":"","size":76307,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"bf1a5a7bff79456f45972cdc828ed519f0e32b12","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":116825580,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjU1ODA=","name":"federation-v2","full_name":"kubernetes-sigs/federation-v2","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2","forks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/deployments","created_at":"2018-01-09T14:21:03Z","updated_at":"2018-11-20T02:49:25Z","pushed_at":"2018-11-20T07:00:48Z","git_url":"git://github.com/kubernetes-sigs/federation-v2.git","ssh_url":"git@github.com:kubernetes-sigs/federation-v2.git","clone_url":"https://github.com/kubernetes-sigs/federation-v2.git","svn_url":"https://github.com/kubernetes-sigs/federation-v2","homepage":"","size":76273,"stargazers_count":111,"watchers_count":111,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":87,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/399"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/399"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/30689f6ab11d8c4d60f5f4171a11437bc5396f95"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":7,"review_comments":6,"maintainer_can_modify":false,"commits":3,"additions":433,"deletions":772,"changed_files":16}}
{"actor":{"display_login":"k8s-ci-robot"}}