{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/183806035","pull_request_review_id":114874658,"id":183806035,"diff_hunk":"@@ -132,6 +132,48 @@ proc parseProtocol(protocol: string): tuple[orig: string, major, minor: int] =\n proc sendStatus(client: AsyncSocket, status: string): Future[void] =\n   client.send(\"HTTP/1.1 \" & status & \"\\c\\L\\c\\L\")\n \n+proc parseUppercaseMethod(name: string): HttpMethod =","path":"lib/pure/asynchttpserver.nim","position":4,"original_position":4,"commit_id":"44c18bc0b2087d7dbc9eff0b0bacfc5a60311941","original_commit_id":"44c18bc0b2087d7dbc9eff0b0bacfc5a60311941","user":{"login":"genotrance","id":192231,"avatar_url":"https://avatars0.githubusercontent.com/u/192231?v=4","gravatar_id":"","url":"https://api.github.com/users/genotrance","html_url":"https://github.com/genotrance","followers_url":"https://api.github.com/users/genotrance/followers","following_url":"https://api.github.com/users/genotrance/following{/other_user}","gists_url":"https://api.github.com/users/genotrance/gists{/gist_id}","starred_url":"https://api.github.com/users/genotrance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genotrance/subscriptions","organizations_url":"https://api.github.com/users/genotrance/orgs","repos_url":"https://api.github.com/users/genotrance/repos","events_url":"https://api.github.com/users/genotrance/events{/privacy}","received_events_url":"https://api.github.com/users/genotrance/received_events","type":"User","site_admin":false},"body":"Cool code but how much faster is this compared to a readable `name == \"POST\"`?","created_at":"2018-04-24T16:52:30Z","updated_at":"2018-04-24T16:52:30Z","html_url":"https://github.com/nim-lang/Nim/pull/7682#discussion_r183806035","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/183806035"},"html":{"href":"https://github.com/nim-lang/Nim/pull/7682#discussion_r183806035"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7682"}}},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/7682","id":183573108,"html_url":"https://github.com/nim-lang/Nim/pull/7682","diff_url":"https://github.com/nim-lang/Nim/pull/7682.diff","patch_url":"https://github.com/nim-lang/Nim/pull/7682.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/7682","number":7682,"state":"open","locked":false,"title":"Change parseEnum to something faster for method parsing in asynchttpserver","user":{"login":"hlaaftana","id":10591326,"avatar_url":"https://avatars0.githubusercontent.com/u/10591326?v=4","gravatar_id":"","url":"https://api.github.com/users/hlaaftana","html_url":"https://github.com/hlaaftana","followers_url":"https://api.github.com/users/hlaaftana/followers","following_url":"https://api.github.com/users/hlaaftana/following{/other_user}","gists_url":"https://api.github.com/users/hlaaftana/gists{/gist_id}","starred_url":"https://api.github.com/users/hlaaftana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlaaftana/subscriptions","organizations_url":"https://api.github.com/users/hlaaftana/orgs","repos_url":"https://api.github.com/users/hlaaftana/repos","events_url":"https://api.github.com/users/hlaaftana/events{/privacy}","received_events_url":"https://api.github.com/users/hlaaftana/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-23T22:20:31Z","updated_at":"2018-04-24T16:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c735ff3345a738485cf6e082d85a332c6fab019","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7682/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/7682/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/7682/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/44c18bc0b2087d7dbc9eff0b0bacfc5a60311941","head":{"label":"hlaaftana:patch-2","ref":"patch-2","sha":"44c18bc0b2087d7dbc9eff0b0bacfc5a60311941","user":{"login":"hlaaftana","id":10591326,"avatar_url":"https://avatars0.githubusercontent.com/u/10591326?v=4","gravatar_id":"","url":"https://api.github.com/users/hlaaftana","html_url":"https://github.com/hlaaftana","followers_url":"https://api.github.com/users/hlaaftana/followers","following_url":"https://api.github.com/users/hlaaftana/following{/other_user}","gists_url":"https://api.github.com/users/hlaaftana/gists{/gist_id}","starred_url":"https://api.github.com/users/hlaaftana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlaaftana/subscriptions","organizations_url":"https://api.github.com/users/hlaaftana/orgs","repos_url":"https://api.github.com/users/hlaaftana/repos","events_url":"https://api.github.com/users/hlaaftana/events{/privacy}","received_events_url":"https://api.github.com/users/hlaaftana/received_events","type":"User","site_admin":false},"repo":{"id":127390056,"name":"Nim","full_name":"hlaaftana/Nim","owner":{"login":"hlaaftana","id":10591326,"avatar_url":"https://avatars0.githubusercontent.com/u/10591326?v=4","gravatar_id":"","url":"https://api.github.com/users/hlaaftana","html_url":"https://github.com/hlaaftana","followers_url":"https://api.github.com/users/hlaaftana/followers","following_url":"https://api.github.com/users/hlaaftana/following{/other_user}","gists_url":"https://api.github.com/users/hlaaftana/gists{/gist_id}","starred_url":"https://api.github.com/users/hlaaftana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlaaftana/subscriptions","organizations_url":"https://api.github.com/users/hlaaftana/orgs","repos_url":"https://api.github.com/users/hlaaftana/repos","events_url":"https://api.github.com/users/hlaaftana/events{/privacy}","received_events_url":"https://api.github.com/users/hlaaftana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlaaftana/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).","fork":true,"url":"https://api.github.com/repos/hlaaftana/Nim","forks_url":"https://api.github.com/repos/hlaaftana/Nim/forks","keys_url":"https://api.github.com/repos/hlaaftana/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlaaftana/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlaaftana/Nim/teams","hooks_url":"https://api.github.com/repos/hlaaftana/Nim/hooks","issue_events_url":"https://api.github.com/repos/hlaaftana/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/hlaaftana/Nim/events","assignees_url":"https://api.github.com/repos/hlaaftana/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/hlaaftana/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/hlaaftana/Nim/tags","blobs_url":"https://api.github.com/repos/hlaaftana/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlaaftana/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlaaftana/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlaaftana/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlaaftana/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/hlaaftana/Nim/languages","stargazers_url":"https://api.github.com/repos/hlaaftana/Nim/stargazers","contributors_url":"https://api.github.com/repos/hlaaftana/Nim/contributors","subscribers_url":"https://api.github.com/repos/hlaaftana/Nim/subscribers","subscription_url":"https://api.github.com/repos/hlaaftana/Nim/subscription","commits_url":"https://api.github.com/repos/hlaaftana/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlaaftana/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlaaftana/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlaaftana/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlaaftana/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/hlaaftana/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlaaftana/Nim/merges","archive_url":"https://api.github.com/repos/hlaaftana/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlaaftana/Nim/downloads","issues_url":"https://api.github.com/repos/hlaaftana/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/hlaaftana/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/hlaaftana/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/hlaaftana/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlaaftana/Nim/labels{/name}","releases_url":"https://api.github.com/repos/hlaaftana/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/hlaaftana/Nim/deployments","created_at":"2018-03-30T06:23:08Z","updated_at":"2018-03-30T06:23:15Z","pushed_at":"2018-04-24T16:25:23Z","git_url":"git://github.com/hlaaftana/Nim.git","ssh_url":"git@github.com:hlaaftana/Nim.git","clone_url":"https://github.com/hlaaftana/Nim.git","svn_url":"https://github.com/hlaaftana/Nim","homepage":"http://nim-lang.org/","size":67762,"stargazers_count":0,"watchers_count":0,"language":"Nim","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"8caf257607e0b76f103155add7849fb934371678","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars1.githubusercontent.com/u/603863?v=4","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim is a compiled, garbage-collected systems programming language with a design that focuses on efficiency, expressiveness, and elegance (in that order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","deployments_url":"https://api.github.com/repos/nim-lang/Nim/deployments","created_at":"2010-08-16T20:38:58Z","updated_at":"2018-04-24T10:46:18Z","pushed_at":"2018-04-24T16:32:55Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":66759,"stargazers_count":4793,"watchers_count":4793,"language":"Nim","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":653,"mirror_url":null,"archived":false,"open_issues_count":1348,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":653,"open_issues":1348,"watchers":4793,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7682"},"html":{"href":"https://github.com/nim-lang/Nim/pull/7682"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/7682"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/7682/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7682/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/7682/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/44c18bc0b2087d7dbc9eff0b0bacfc5a60311941"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"genotrance"}}