{"action":"created","comment":{"url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/comments/203551925","pull_request_review_id":138457836,"id":203551925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzU1MTkyNQ==","diff_hunk":"@@ -0,0 +1,6 @@\n+import pytest\n+from pidgin.app import app as pidgin_app\n+\n+@pytest.fixture","path":"tests/conftest.py","position":4,"original_position":4,"commit_id":"85f2aec9df04a6612d190a5ac1c5619c34a9ea8e","original_commit_id":"85f2aec9df04a6612d190a5ac1c5619c34a9ea8e","user":{"login":"rudyardrichter","id":11139473,"node_id":"MDQ6VXNlcjExMTM5NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/11139473?v=4","gravatar_id":"","url":"https://api.github.com/users/rudyardrichter","html_url":"https://github.com/rudyardrichter","followers_url":"https://api.github.com/users/rudyardrichter/followers","following_url":"https://api.github.com/users/rudyardrichter/following{/other_user}","gists_url":"https://api.github.com/users/rudyardrichter/gists{/gist_id}","starred_url":"https://api.github.com/users/rudyardrichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudyardrichter/subscriptions","organizations_url":"https://api.github.com/users/rudyardrichter/orgs","repos_url":"https://api.github.com/users/rudyardrichter/repos","events_url":"https://api.github.com/users/rudyardrichter/events{/privacy}","received_events_url":"https://api.github.com/users/rudyardrichter/received_events","type":"User","site_admin":false},"body":"Something to keep in mind for pytest fixtures is the [scope](https://docs.pytest.org/en/latest/fixture.html#scope-sharing-a-fixture-instance-across-tests-in-a-class-module-or-session). For mutable things you generally want the default, which is `function`, but for things which won't be changed throughout running the tests use `session` to save having to set up the same fixture multiple times for no reason. Also for fixtures that would be expensive to set up, you can think about how to keep these immutable (or resetting them between tests) to be able to use the `session` scope and save the cost of instantiating the same thing for hundreds of tests.\r\n\r\n(Just to be clear—nothing wrong with this code specifically—just something to keep in mind as this codebase gets larger, or for working on other codebases)","created_at":"2018-07-18T22:33:58Z","updated_at":"2018-07-18T22:36:50Z","html_url":"https://github.com/uc-cdis/pidgin/pull/11#discussion_r203551925","pull_request_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/comments/203551925"},"html":{"href":"https://github.com/uc-cdis/pidgin/pull/11#discussion_r203551925"},"pull_request":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11","id":202393050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzkzMDUw","html_url":"https://github.com/uc-cdis/pidgin/pull/11","diff_url":"https://github.com/uc-cdis/pidgin/pull/11.diff","patch_url":"https://github.com/uc-cdis/pidgin/pull/11.patch","issue_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/11","number":11,"state":"open","locked":false,"title":"PXD-1162 feat/unit tests","user":{"login":"paulineribeyre","id":4224001,"node_id":"MDQ6VXNlcjQyMjQwMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4224001?v=4","gravatar_id":"","url":"https://api.github.com/users/paulineribeyre","html_url":"https://github.com/paulineribeyre","followers_url":"https://api.github.com/users/paulineribeyre/followers","following_url":"https://api.github.com/users/paulineribeyre/following{/other_user}","gists_url":"https://api.github.com/users/paulineribeyre/gists{/gist_id}","starred_url":"https://api.github.com/users/paulineribeyre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulineribeyre/subscriptions","organizations_url":"https://api.github.com/users/paulineribeyre/orgs","repos_url":"https://api.github.com/users/paulineribeyre/repos","events_url":"https://api.github.com/users/paulineribeyre/events{/privacy}","received_events_url":"https://api.github.com/users/paulineribeyre/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T22:03:32Z","updated_at":"2018-07-18T22:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"Avantol13","id":9382451,"node_id":"MDQ6VXNlcjkzODI0NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9382451?v=4","gravatar_id":"","url":"https://api.github.com/users/Avantol13","html_url":"https://github.com/Avantol13","followers_url":"https://api.github.com/users/Avantol13/followers","following_url":"https://api.github.com/users/Avantol13/following{/other_user}","gists_url":"https://api.github.com/users/Avantol13/gists{/gist_id}","starred_url":"https://api.github.com/users/Avantol13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avantol13/subscriptions","organizations_url":"https://api.github.com/users/Avantol13/orgs","repos_url":"https://api.github.com/users/Avantol13/repos","events_url":"https://api.github.com/users/Avantol13/events{/privacy}","received_events_url":"https://api.github.com/users/Avantol13/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11/commits","review_comments_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11/comments","review_comment_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/11/comments","statuses_url":"https://api.github.com/repos/uc-cdis/pidgin/statuses/85f2aec9df04a6612d190a5ac1c5619c34a9ea8e","head":{"label":"uc-cdis:feat/unit-tests","ref":"feat/unit-tests","sha":"85f2aec9df04a6612d190a5ac1c5619c34a9ea8e","user":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"repo":{"id":137088859,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwODg4NTk=","name":"pidgin","full_name":"uc-cdis/pidgin","owner":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uc-cdis/pidgin","description":"key value metadata service","fork":false,"url":"https://api.github.com/repos/uc-cdis/pidgin","forks_url":"https://api.github.com/repos/uc-cdis/pidgin/forks","keys_url":"https://api.github.com/repos/uc-cdis/pidgin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uc-cdis/pidgin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uc-cdis/pidgin/teams","hooks_url":"https://api.github.com/repos/uc-cdis/pidgin/hooks","issue_events_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/events{/number}","events_url":"https://api.github.com/repos/uc-cdis/pidgin/events","assignees_url":"https://api.github.com/repos/uc-cdis/pidgin/assignees{/user}","branches_url":"https://api.github.com/repos/uc-cdis/pidgin/branches{/branch}","tags_url":"https://api.github.com/repos/uc-cdis/pidgin/tags","blobs_url":"https://api.github.com/repos/uc-cdis/pidgin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uc-cdis/pidgin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uc-cdis/pidgin/git/refs{/sha}","trees_url":"https://api.github.com/repos/uc-cdis/pidgin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uc-cdis/pidgin/statuses/{sha}","languages_url":"https://api.github.com/repos/uc-cdis/pidgin/languages","stargazers_url":"https://api.github.com/repos/uc-cdis/pidgin/stargazers","contributors_url":"https://api.github.com/repos/uc-cdis/pidgin/contributors","subscribers_url":"https://api.github.com/repos/uc-cdis/pidgin/subscribers","subscription_url":"https://api.github.com/repos/uc-cdis/pidgin/subscription","commits_url":"https://api.github.com/repos/uc-cdis/pidgin/commits{/sha}","git_commits_url":"https://api.github.com/repos/uc-cdis/pidgin/git/commits{/sha}","comments_url":"https://api.github.com/repos/uc-cdis/pidgin/comments{/number}","issue_comment_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/comments{/number}","contents_url":"https://api.github.com/repos/uc-cdis/pidgin/contents/{+path}","compare_url":"https://api.github.com/repos/uc-cdis/pidgin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uc-cdis/pidgin/merges","archive_url":"https://api.github.com/repos/uc-cdis/pidgin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uc-cdis/pidgin/downloads","issues_url":"https://api.github.com/repos/uc-cdis/pidgin/issues{/number}","pulls_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls{/number}","milestones_url":"https://api.github.com/repos/uc-cdis/pidgin/milestones{/number}","notifications_url":"https://api.github.com/repos/uc-cdis/pidgin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uc-cdis/pidgin/labels{/name}","releases_url":"https://api.github.com/repos/uc-cdis/pidgin/releases{/id}","deployments_url":"https://api.github.com/repos/uc-cdis/pidgin/deployments","created_at":"2018-06-12T15:05:43Z","updated_at":"2018-07-10T18:20:58Z","pushed_at":"2018-07-18T22:03:32Z","git_url":"git://github.com/uc-cdis/pidgin.git","ssh_url":"git@github.com:uc-cdis/pidgin.git","clone_url":"https://github.com/uc-cdis/pidgin.git","svn_url":"https://github.com/uc-cdis/pidgin","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"uc-cdis:master","ref":"master","sha":"082dfabaca923c3539be2807607cb8f3e315ba17","user":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"repo":{"id":137088859,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwODg4NTk=","name":"pidgin","full_name":"uc-cdis/pidgin","owner":{"login":"uc-cdis","id":15327655,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzI3NjU1","avatar_url":"https://avatars0.githubusercontent.com/u/15327655?v=4","gravatar_id":"","url":"https://api.github.com/users/uc-cdis","html_url":"https://github.com/uc-cdis","followers_url":"https://api.github.com/users/uc-cdis/followers","following_url":"https://api.github.com/users/uc-cdis/following{/other_user}","gists_url":"https://api.github.com/users/uc-cdis/gists{/gist_id}","starred_url":"https://api.github.com/users/uc-cdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uc-cdis/subscriptions","organizations_url":"https://api.github.com/users/uc-cdis/orgs","repos_url":"https://api.github.com/users/uc-cdis/repos","events_url":"https://api.github.com/users/uc-cdis/events{/privacy}","received_events_url":"https://api.github.com/users/uc-cdis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uc-cdis/pidgin","description":"key value metadata service","fork":false,"url":"https://api.github.com/repos/uc-cdis/pidgin","forks_url":"https://api.github.com/repos/uc-cdis/pidgin/forks","keys_url":"https://api.github.com/repos/uc-cdis/pidgin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uc-cdis/pidgin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uc-cdis/pidgin/teams","hooks_url":"https://api.github.com/repos/uc-cdis/pidgin/hooks","issue_events_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/events{/number}","events_url":"https://api.github.com/repos/uc-cdis/pidgin/events","assignees_url":"https://api.github.com/repos/uc-cdis/pidgin/assignees{/user}","branches_url":"https://api.github.com/repos/uc-cdis/pidgin/branches{/branch}","tags_url":"https://api.github.com/repos/uc-cdis/pidgin/tags","blobs_url":"https://api.github.com/repos/uc-cdis/pidgin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uc-cdis/pidgin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uc-cdis/pidgin/git/refs{/sha}","trees_url":"https://api.github.com/repos/uc-cdis/pidgin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uc-cdis/pidgin/statuses/{sha}","languages_url":"https://api.github.com/repos/uc-cdis/pidgin/languages","stargazers_url":"https://api.github.com/repos/uc-cdis/pidgin/stargazers","contributors_url":"https://api.github.com/repos/uc-cdis/pidgin/contributors","subscribers_url":"https://api.github.com/repos/uc-cdis/pidgin/subscribers","subscription_url":"https://api.github.com/repos/uc-cdis/pidgin/subscription","commits_url":"https://api.github.com/repos/uc-cdis/pidgin/commits{/sha}","git_commits_url":"https://api.github.com/repos/uc-cdis/pidgin/git/commits{/sha}","comments_url":"https://api.github.com/repos/uc-cdis/pidgin/comments{/number}","issue_comment_url":"https://api.github.com/repos/uc-cdis/pidgin/issues/comments{/number}","contents_url":"https://api.github.com/repos/uc-cdis/pidgin/contents/{+path}","compare_url":"https://api.github.com/repos/uc-cdis/pidgin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uc-cdis/pidgin/merges","archive_url":"https://api.github.com/repos/uc-cdis/pidgin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uc-cdis/pidgin/downloads","issues_url":"https://api.github.com/repos/uc-cdis/pidgin/issues{/number}","pulls_url":"https://api.github.com/repos/uc-cdis/pidgin/pulls{/number}","milestones_url":"https://api.github.com/repos/uc-cdis/pidgin/milestones{/number}","notifications_url":"https://api.github.com/repos/uc-cdis/pidgin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uc-cdis/pidgin/labels{/name}","releases_url":"https://api.github.com/repos/uc-cdis/pidgin/releases{/id}","deployments_url":"https://api.github.com/repos/uc-cdis/pidgin/deployments","created_at":"2018-06-12T15:05:43Z","updated_at":"2018-07-10T18:20:58Z","pushed_at":"2018-07-18T22:03:32Z","git_url":"git://github.com/uc-cdis/pidgin.git","ssh_url":"git@github.com:uc-cdis/pidgin.git","clone_url":"https://github.com/uc-cdis/pidgin.git","svn_url":"https://github.com/uc-cdis/pidgin","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11"},"html":{"href":"https://github.com/uc-cdis/pidgin/pull/11"},"issue":{"href":"https://api.github.com/repos/uc-cdis/pidgin/issues/11"},"comments":{"href":"https://api.github.com/repos/uc-cdis/pidgin/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uc-cdis/pidgin/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/uc-cdis/pidgin/statuses/85f2aec9df04a6612d190a5ac1c5619c34a9ea8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rudyardrichter"}}