{"action":"created","comment":{"url":"https://api.github.com/repos/celery/celery/pulls/comments/189592582","pull_request_review_id":121800895,"id":189592582,"diff_hunk":"@@ -255,10 +255,16 @@ def create_pidlock(pidfile):\n     return pidlock\n \n \n+def _can_create_pidlock(pidlock):","path":"celery/platforms.py","position":4,"original_position":4,"commit_id":"b6a2caf03e8e52d99fddb902ff4c12e55397795f","original_commit_id":"b6a2caf03e8e52d99fddb902ff4c12e55397795f","user":{"login":"arhoyling","id":7500364,"avatar_url":"https://avatars0.githubusercontent.com/u/7500364?v=4","gravatar_id":"","url":"https://api.github.com/users/arhoyling","html_url":"https://github.com/arhoyling","followers_url":"https://api.github.com/users/arhoyling/followers","following_url":"https://api.github.com/users/arhoyling/following{/other_user}","gists_url":"https://api.github.com/users/arhoyling/gists{/gist_id}","starred_url":"https://api.github.com/users/arhoyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhoyling/subscriptions","organizations_url":"https://api.github.com/users/arhoyling/orgs","repos_url":"https://api.github.com/users/arhoyling/repos","events_url":"https://api.github.com/users/arhoyling/events{/privacy}","received_events_url":"https://api.github.com/users/arhoyling/received_events","type":"User","site_admin":false},"body":"I actually thought it would be better in the Pidfile class but I wanted to minimize changes.\r\nI'll try to commit something soon.","created_at":"2018-05-21T13:43:14Z","updated_at":"2018-05-21T13:43:14Z","html_url":"https://github.com/celery/celery/pull/4704#discussion_r189592582","pull_request_url":"https://api.github.com/repos/celery/celery/pulls/4704","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/celery/celery/pulls/comments/189592582"},"html":{"href":"https://github.com/celery/celery/pull/4704#discussion_r189592582"},"pull_request":{"href":"https://api.github.com/repos/celery/celery/pulls/4704"}},"in_reply_to_id":185994159},"pull_request":{"url":"https://api.github.com/repos/celery/celery/pulls/4704","id":185676054,"html_url":"https://github.com/celery/celery/pull/4704","diff_url":"https://github.com/celery/celery/pull/4704.diff","patch_url":"https://github.com/celery/celery/pull/4704.patch","issue_url":"https://api.github.com/repos/celery/celery/issues/4704","number":4704,"state":"open","locked":false,"title":"Do not create temporary lockfiles before detaching processes (#4174)","user":{"login":"arhoyling","id":7500364,"avatar_url":"https://avatars0.githubusercontent.com/u/7500364?v=4","gravatar_id":"","url":"https://api.github.com/users/arhoyling","html_url":"https://github.com/arhoyling","followers_url":"https://api.github.com/users/arhoyling/followers","following_url":"https://api.github.com/users/arhoyling/following{/other_user}","gists_url":"https://api.github.com/users/arhoyling/gists{/gist_id}","starred_url":"https://api.github.com/users/arhoyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhoyling/subscriptions","organizations_url":"https://api.github.com/users/arhoyling/orgs","repos_url":"https://api.github.com/users/arhoyling/repos","events_url":"https://api.github.com/users/arhoyling/events{/privacy}","received_events_url":"https://api.github.com/users/arhoyling/received_events","type":"User","site_admin":false},"body":"Although it is the responsibility of the child to create its pidlock,\r\nthe parent process was temporarily creating it when checking if a\r\nsimilar process was already running. This could cause race conditions\r\nwith external processes - e.g. a process monitoring the existence of the\r\npidfile.\r\n\r\nThe fix still checks if a child process is running but does not attempt\r\nto acquire the lock (even temporarily). All other pidfile\r\nrelated behaviour is unchanged.\r\n\r\n*Note*: Before submitting this pull request, please review our [contributing\r\nguidelines](https://docs.celeryproject.org/en/master/contributing.html).\r\n\r\n## Description\r\n\r\nPlease describe your pull request.\r\n\r\nNOTE: All patches should be made against master, not a maintenance branch like\r\n3.1, 2.5, etc.  That is unless the bug is already fixed in master, but not in\r\nthat version series.\r\n\r\nIf it fixes a bug or resolves a feature request,\r\nbe sure to link to that issue via (Fixes #4412) for example.\r\n","created_at":"2018-05-03T10:37:11Z","updated_at":"2018-05-21T13:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c752d1af071ed04d0af7e64f4974146b26f6a973","assignee":{"login":"georgepsarakis","id":963304,"avatar_url":"https://avatars1.githubusercontent.com/u/963304?v=4","gravatar_id":"","url":"https://api.github.com/users/georgepsarakis","html_url":"https://github.com/georgepsarakis","followers_url":"https://api.github.com/users/georgepsarakis/followers","following_url":"https://api.github.com/users/georgepsarakis/following{/other_user}","gists_url":"https://api.github.com/users/georgepsarakis/gists{/gist_id}","starred_url":"https://api.github.com/users/georgepsarakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgepsarakis/subscriptions","organizations_url":"https://api.github.com/users/georgepsarakis/orgs","repos_url":"https://api.github.com/users/georgepsarakis/repos","events_url":"https://api.github.com/users/georgepsarakis/events{/privacy}","received_events_url":"https://api.github.com/users/georgepsarakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"georgepsarakis","id":963304,"avatar_url":"https://avatars1.githubusercontent.com/u/963304?v=4","gravatar_id":"","url":"https://api.github.com/users/georgepsarakis","html_url":"https://github.com/georgepsarakis","followers_url":"https://api.github.com/users/georgepsarakis/followers","following_url":"https://api.github.com/users/georgepsarakis/following{/other_user}","gists_url":"https://api.github.com/users/georgepsarakis/gists{/gist_id}","starred_url":"https://api.github.com/users/georgepsarakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgepsarakis/subscriptions","organizations_url":"https://api.github.com/users/georgepsarakis/orgs","repos_url":"https://api.github.com/users/georgepsarakis/repos","events_url":"https://api.github.com/users/georgepsarakis/events{/privacy}","received_events_url":"https://api.github.com/users/georgepsarakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":84246273,"url":"https://api.github.com/repos/celery/celery/labels/Category:%20Deployment","name":"Category: Deployment","color":"772123","default":false},{"id":774806383,"url":"https://api.github.com/repos/celery/celery/labels/PR%20Type:%20Enhancement","name":"PR Type: Enhancement","color":"7ec6dd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/celery/celery/pulls/4704/commits","review_comments_url":"https://api.github.com/repos/celery/celery/pulls/4704/comments","review_comment_url":"https://api.github.com/repos/celery/celery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/celery/celery/issues/4704/comments","statuses_url":"https://api.github.com/repos/celery/celery/statuses/b6a2caf03e8e52d99fddb902ff4c12e55397795f","head":{"label":"arhoyling:master","ref":"master","sha":"b6a2caf03e8e52d99fddb902ff4c12e55397795f","user":{"login":"arhoyling","id":7500364,"avatar_url":"https://avatars0.githubusercontent.com/u/7500364?v=4","gravatar_id":"","url":"https://api.github.com/users/arhoyling","html_url":"https://github.com/arhoyling","followers_url":"https://api.github.com/users/arhoyling/followers","following_url":"https://api.github.com/users/arhoyling/following{/other_user}","gists_url":"https://api.github.com/users/arhoyling/gists{/gist_id}","starred_url":"https://api.github.com/users/arhoyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhoyling/subscriptions","organizations_url":"https://api.github.com/users/arhoyling/orgs","repos_url":"https://api.github.com/users/arhoyling/repos","events_url":"https://api.github.com/users/arhoyling/events{/privacy}","received_events_url":"https://api.github.com/users/arhoyling/received_events","type":"User","site_admin":false},"repo":{"id":131974814,"name":"celery","full_name":"arhoyling/celery","owner":{"login":"arhoyling","id":7500364,"avatar_url":"https://avatars0.githubusercontent.com/u/7500364?v=4","gravatar_id":"","url":"https://api.github.com/users/arhoyling","html_url":"https://github.com/arhoyling","followers_url":"https://api.github.com/users/arhoyling/followers","following_url":"https://api.github.com/users/arhoyling/following{/other_user}","gists_url":"https://api.github.com/users/arhoyling/gists{/gist_id}","starred_url":"https://api.github.com/users/arhoyling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhoyling/subscriptions","organizations_url":"https://api.github.com/users/arhoyling/orgs","repos_url":"https://api.github.com/users/arhoyling/repos","events_url":"https://api.github.com/users/arhoyling/events{/privacy}","received_events_url":"https://api.github.com/users/arhoyling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arhoyling/celery","description":"Distributed Task Queue (development branch)","fork":true,"url":"https://api.github.com/repos/arhoyling/celery","forks_url":"https://api.github.com/repos/arhoyling/celery/forks","keys_url":"https://api.github.com/repos/arhoyling/celery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhoyling/celery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhoyling/celery/teams","hooks_url":"https://api.github.com/repos/arhoyling/celery/hooks","issue_events_url":"https://api.github.com/repos/arhoyling/celery/issues/events{/number}","events_url":"https://api.github.com/repos/arhoyling/celery/events","assignees_url":"https://api.github.com/repos/arhoyling/celery/assignees{/user}","branches_url":"https://api.github.com/repos/arhoyling/celery/branches{/branch}","tags_url":"https://api.github.com/repos/arhoyling/celery/tags","blobs_url":"https://api.github.com/repos/arhoyling/celery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhoyling/celery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhoyling/celery/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhoyling/celery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhoyling/celery/statuses/{sha}","languages_url":"https://api.github.com/repos/arhoyling/celery/languages","stargazers_url":"https://api.github.com/repos/arhoyling/celery/stargazers","contributors_url":"https://api.github.com/repos/arhoyling/celery/contributors","subscribers_url":"https://api.github.com/repos/arhoyling/celery/subscribers","subscription_url":"https://api.github.com/repos/arhoyling/celery/subscription","commits_url":"https://api.github.com/repos/arhoyling/celery/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhoyling/celery/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhoyling/celery/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhoyling/celery/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhoyling/celery/contents/{+path}","compare_url":"https://api.github.com/repos/arhoyling/celery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhoyling/celery/merges","archive_url":"https://api.github.com/repos/arhoyling/celery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhoyling/celery/downloads","issues_url":"https://api.github.com/repos/arhoyling/celery/issues{/number}","pulls_url":"https://api.github.com/repos/arhoyling/celery/pulls{/number}","milestones_url":"https://api.github.com/repos/arhoyling/celery/milestones{/number}","notifications_url":"https://api.github.com/repos/arhoyling/celery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhoyling/celery/labels{/name}","releases_url":"https://api.github.com/repos/arhoyling/celery/releases{/id}","deployments_url":"https://api.github.com/repos/arhoyling/celery/deployments","created_at":"2018-05-03T09:47:08Z","updated_at":"2018-05-03T10:29:13Z","pushed_at":"2018-05-03T10:29:10Z","git_url":"git://github.com/arhoyling/celery.git","ssh_url":"git@github.com:arhoyling/celery.git","clone_url":"https://github.com/arhoyling/celery.git","svn_url":"https://github.com/arhoyling/celery","homepage":"http://celeryproject.org","size":46690,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"celery:master","ref":"master","sha":"8c753d7febd3be4e56cb0fda78b0704130a85299","user":{"login":"celery","id":319983,"avatar_url":"https://avatars2.githubusercontent.com/u/319983?v=4","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"repo":{"id":184460,"name":"celery","full_name":"celery/celery","owner":{"login":"celery","id":319983,"avatar_url":"https://avatars2.githubusercontent.com/u/319983?v=4","gravatar_id":"","url":"https://api.github.com/users/celery","html_url":"https://github.com/celery","followers_url":"https://api.github.com/users/celery/followers","following_url":"https://api.github.com/users/celery/following{/other_user}","gists_url":"https://api.github.com/users/celery/gists{/gist_id}","starred_url":"https://api.github.com/users/celery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celery/subscriptions","organizations_url":"https://api.github.com/users/celery/orgs","repos_url":"https://api.github.com/users/celery/repos","events_url":"https://api.github.com/users/celery/events{/privacy}","received_events_url":"https://api.github.com/users/celery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/celery/celery","description":"Distributed Task Queue (development branch)","fork":false,"url":"https://api.github.com/repos/celery/celery","forks_url":"https://api.github.com/repos/celery/celery/forks","keys_url":"https://api.github.com/repos/celery/celery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/celery/celery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/celery/celery/teams","hooks_url":"https://api.github.com/repos/celery/celery/hooks","issue_events_url":"https://api.github.com/repos/celery/celery/issues/events{/number}","events_url":"https://api.github.com/repos/celery/celery/events","assignees_url":"https://api.github.com/repos/celery/celery/assignees{/user}","branches_url":"https://api.github.com/repos/celery/celery/branches{/branch}","tags_url":"https://api.github.com/repos/celery/celery/tags","blobs_url":"https://api.github.com/repos/celery/celery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/celery/celery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/celery/celery/git/refs{/sha}","trees_url":"https://api.github.com/repos/celery/celery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/celery/celery/statuses/{sha}","languages_url":"https://api.github.com/repos/celery/celery/languages","stargazers_url":"https://api.github.com/repos/celery/celery/stargazers","contributors_url":"https://api.github.com/repos/celery/celery/contributors","subscribers_url":"https://api.github.com/repos/celery/celery/subscribers","subscription_url":"https://api.github.com/repos/celery/celery/subscription","commits_url":"https://api.github.com/repos/celery/celery/commits{/sha}","git_commits_url":"https://api.github.com/repos/celery/celery/git/commits{/sha}","comments_url":"https://api.github.com/repos/celery/celery/comments{/number}","issue_comment_url":"https://api.github.com/repos/celery/celery/issues/comments{/number}","contents_url":"https://api.github.com/repos/celery/celery/contents/{+path}","compare_url":"https://api.github.com/repos/celery/celery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/celery/celery/merges","archive_url":"https://api.github.com/repos/celery/celery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/celery/celery/downloads","issues_url":"https://api.github.com/repos/celery/celery/issues{/number}","pulls_url":"https://api.github.com/repos/celery/celery/pulls{/number}","milestones_url":"https://api.github.com/repos/celery/celery/milestones{/number}","notifications_url":"https://api.github.com/repos/celery/celery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/celery/celery/labels{/name}","releases_url":"https://api.github.com/repos/celery/celery/releases{/id}","deployments_url":"https://api.github.com/repos/celery/celery/deployments","created_at":"2009-04-24T11:31:24Z","updated_at":"2018-05-21T12:58:27Z","pushed_at":"2018-05-21T11:59:32Z","git_url":"git://github.com/celery/celery.git","ssh_url":"git@github.com:celery/celery.git","clone_url":"https://github.com/celery/celery.git","svn_url":"https://github.com/celery/celery","homepage":"http://celeryproject.org","size":46653,"stargazers_count":9448,"watchers_count":9448,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2654,"mirror_url":null,"archived":false,"open_issues_count":372,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2654,"open_issues":372,"watchers":9448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/celery/celery/pulls/4704"},"html":{"href":"https://github.com/celery/celery/pull/4704"},"issue":{"href":"https://api.github.com/repos/celery/celery/issues/4704"},"comments":{"href":"https://api.github.com/repos/celery/celery/issues/4704/comments"},"review_comments":{"href":"https://api.github.com/repos/celery/celery/pulls/4704/comments"},"review_comment":{"href":"https://api.github.com/repos/celery/celery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/celery/celery/pulls/4704/commits"},"statuses":{"href":"https://api.github.com/repos/celery/celery/statuses/b6a2caf03e8e52d99fddb902ff4c12e55397795f"}},"author_association":"NONE"}}
{"actor":{"display_login":"arhoyling"}}