{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/186320224","pull_request_review_id":117874668,"id":186320224,"diff_hunk":"@@ -1919,16 +1919,12 @@ namespace MWGui\n             mInventoryWindow->cycle(next);\n     }\n \n-    void WindowManager::playSound(const std::string& soundId, bool preventOverlapping, float volume, float pitch)\n+    void WindowManager::playSound(const std::string& soundId, float volume, float pitch)\n     {\n         if (soundId.empty())\n             return;\n \n-        MWBase::SoundManager *sndmgr = MWBase::Environment::get().getSoundManager();\n-        if (preventOverlapping && sndmgr->getSoundPlaying(MWWorld::Ptr(), soundId))\n-            return;\n-\n-        sndmgr->playSound(soundId, volume, pitch, MWSound::Type::Sfx, MWSound::PlayMode::NoEnv);\n+        MWBase::Environment::get().getSoundManager()->playSound(soundId, volume, pitch, MWSound::Type::Sfx, MWSound::PlayMode::NoEnv);","path":"apps/openmw/mwgui/windowmanagerimp.cpp","position":15,"original_position":15,"commit_id":"4872edc5edd396bbb4ee0ba29bc14df8c87bb7f7","original_commit_id":"4872edc5edd396bbb4ee0ba29bc14df8c87bb7f7","user":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"body":"Should we treat GUI sound differently from other ones?","created_at":"2018-05-07T03:27:10Z","updated_at":"2018-05-07T03:27:10Z","html_url":"https://github.com/OpenMW/openmw/pull/1692#discussion_r186320224","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1692","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/186320224"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1692#discussion_r186320224"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1692"}},"in_reply_to_id":186308094},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1692","id":185169710,"html_url":"https://github.com/OpenMW/openmw/pull/1692","diff_url":"https://github.com/OpenMW/openmw/pull/1692.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1692.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1692","number":1692,"state":"open","locked":false,"title":"Prevent PlaySound overlapping","user":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"body":"If we play a new sound, we should stop the previous copy of this sound. This is easily to check: execute \"playsound X\" several times in console in vanilla game.\r\nWe already use similar approach for 3D sounds: we allow to play only one copy of given sound per object, so this PR just makes sound playing consistent.\r\n\r\nAs a side effect, this PR fixes a nightmare scene in Arktwend, so it should not crash now.","created_at":"2018-05-01T12:30:08Z","updated_at":"2018-05-07T03:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c996abb891269d10ba5af565be97c39371dcea5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1692/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1692/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1692/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/4872edc5edd396bbb4ee0ba29bc14df8c87bb7f7","head":{"label":"akortunov:playsound","ref":"playsound","sha":"4872edc5edd396bbb4ee0ba29bc14df8c87bb7f7","user":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"repo":{"id":85070122,"name":"openmw","full_name":"akortunov/openmw","owner":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akortunov/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/akortunov/openmw","forks_url":"https://api.github.com/repos/akortunov/openmw/forks","keys_url":"https://api.github.com/repos/akortunov/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akortunov/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akortunov/openmw/teams","hooks_url":"https://api.github.com/repos/akortunov/openmw/hooks","issue_events_url":"https://api.github.com/repos/akortunov/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/akortunov/openmw/events","assignees_url":"https://api.github.com/repos/akortunov/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/akortunov/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/akortunov/openmw/tags","blobs_url":"https://api.github.com/repos/akortunov/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akortunov/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akortunov/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/akortunov/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akortunov/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/akortunov/openmw/languages","stargazers_url":"https://api.github.com/repos/akortunov/openmw/stargazers","contributors_url":"https://api.github.com/repos/akortunov/openmw/contributors","subscribers_url":"https://api.github.com/repos/akortunov/openmw/subscribers","subscription_url":"https://api.github.com/repos/akortunov/openmw/subscription","commits_url":"https://api.github.com/repos/akortunov/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/akortunov/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/akortunov/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/akortunov/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/akortunov/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/akortunov/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akortunov/openmw/merges","archive_url":"https://api.github.com/repos/akortunov/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akortunov/openmw/downloads","issues_url":"https://api.github.com/repos/akortunov/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/akortunov/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/akortunov/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/akortunov/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akortunov/openmw/labels{/name}","releases_url":"https://api.github.com/repos/akortunov/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/akortunov/openmw/deployments","created_at":"2017-03-15T12:32:34Z","updated_at":"2018-04-30T09:36:18Z","pushed_at":"2018-05-06T12:42:19Z","git_url":"git://github.com/akortunov/openmw.git","ssh_url":"git@github.com:akortunov/openmw.git","clone_url":"https://github.com/akortunov/openmw.git","svn_url":"https://github.com/akortunov/openmw","homepage":"http://www.openmw.org/","size":50998,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"b995584ad2f9c7063416bdb36c457536ef0c04bb","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2018-05-06T08:57:35Z","pushed_at":"2018-05-06T20:02:24Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":50707,"stargazers_count":2124,"watchers_count":2124,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":642,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":642,"open_issues":47,"watchers":2124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1692"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1692"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1692"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1692/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1692/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1692/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/4872edc5edd396bbb4ee0ba29bc14df8c87bb7f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akortunov"}}