{"action":"created","issue":{"url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/49","repository_url":"https://api.github.com/repos/fac-13/vith-Mixtape","labels_url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/49/comments","events_url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/49/events","html_url":"https://github.com/fac-13/vith-Mixtape/issues/49","id":305875682,"number":49,"title":"Unnecessary reassignment of variable ","user":{"login":"parkhabit","id":16639540,"avatar_url":"https://avatars0.githubusercontent.com/u/16639540?v=4","gravatar_id":"","url":"https://api.github.com/users/parkhabit","html_url":"https://github.com/parkhabit","followers_url":"https://api.github.com/users/parkhabit/followers","following_url":"https://api.github.com/users/parkhabit/following{/other_user}","gists_url":"https://api.github.com/users/parkhabit/gists{/gist_id}","starred_url":"https://api.github.com/users/parkhabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkhabit/subscriptions","organizations_url":"https://api.github.com/users/parkhabit/orgs","repos_url":"https://api.github.com/users/parkhabit/repos","events_url":"https://api.github.com/users/parkhabit/events{/privacy}","received_events_url":"https://api.github.com/users/parkhabit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-16T10:28:01Z","updated_at":"2018-03-16T10:56:31Z","closed_at":null,"author_association":"NONE","body":"In your DOM.js file you've written the function `displayMusic` with `music` as a parameter but then instantly reassign it to another variable `musisResult` [here](https://github.com/fac-13/vith-Mixtape/blob/master/DOM.js#L50). Instead, you could just write the function with `musicResult` as the parameter. "},"comment":{"url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/comments/373678952","html_url":"https://github.com/fac-13/vith-Mixtape/issues/49#issuecomment-373678952","issue_url":"https://api.github.com/repos/fac-13/vith-Mixtape/issues/49","id":373678952,"user":{"login":"haydnba","id":22300973,"avatar_url":"https://avatars2.githubusercontent.com/u/22300973?v=4","gravatar_id":"","url":"https://api.github.com/users/haydnba","html_url":"https://github.com/haydnba","followers_url":"https://api.github.com/users/haydnba/followers","following_url":"https://api.github.com/users/haydnba/following{/other_user}","gists_url":"https://api.github.com/users/haydnba/gists{/gist_id}","starred_url":"https://api.github.com/users/haydnba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haydnba/subscriptions","organizations_url":"https://api.github.com/users/haydnba/orgs","repos_url":"https://api.github.com/users/haydnba/repos","events_url":"https://api.github.com/users/haydnba/events{/privacy}","received_events_url":"https://api.github.com/users/haydnba/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T10:56:31Z","updated_at":"2018-03-16T10:56:31Z","author_association":"NONE","body":"I would add that you also never properly declared musicResult as a variable in this code, which could be dangerous:\r\n\r\n`musicResult = music` should be `var musicResult = music` ??\r\n\r\nBut obvs pointless if you avoid the unnecessary reassignment...\r\n\r\n😒"}}
{"actor":{"display_login":"haydnba"}}