{"action":"created","issue":{"url":"https://api.github.com/repos/patternfly/patternfly/issues/947","repository_url":"https://api.github.com/repos/patternfly/patternfly","labels_url":"https://api.github.com/repos/patternfly/patternfly/issues/947/labels{/name}","comments_url":"https://api.github.com/repos/patternfly/patternfly/issues/947/comments","events_url":"https://api.github.com/repos/patternfly/patternfly/issues/947/events","html_url":"https://github.com/patternfly/patternfly/issues/947","id":293809280,"number":947,"title":"TreeGrid table is slow with large datasets ","user":{"login":"jamesnetherton","id":4721408,"avatar_url":"https://avatars2.githubusercontent.com/u/4721408?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesnetherton","html_url":"https://github.com/jamesnetherton","followers_url":"https://api.github.com/users/jamesnetherton/followers","following_url":"https://api.github.com/users/jamesnetherton/following{/other_user}","gists_url":"https://api.github.com/users/jamesnetherton/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesnetherton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesnetherton/subscriptions","organizations_url":"https://api.github.com/users/jamesnetherton/orgs","repos_url":"https://api.github.com/users/jamesnetherton/repos","events_url":"https://api.github.com/users/jamesnetherton/events{/privacy}","received_events_url":"https://api.github.com/users/jamesnetherton/received_events","type":"User","site_admin":false},"labels":[{"id":685253370,"url":"https://api.github.com/repos/patternfly/patternfly/labels/js","name":"js","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-02T08:29:17Z","updated_at":"2018-02-06T07:07:02Z","closed_at":null,"author_association":"NONE","body":"I'm working with a TreeGrid table which has around 600 items. It's quite slow to do the initial tree view render and when subsequently expanding or collapsing any of the tree nodes.\r\n\r\nAfter a brief bit of profiling, it seems much of the time is being spent [here](https://github.com/patternfly/patternfly/blob/master/src/js/patternfly-functions-tree-grid.js#L10).\r\n\r\nDoes it need to use `closest`? Parent is the id attribute of some `<tr>` element that should be considered the parent tree node. Isn't this unique? If so, instead of `closest`, maybe we use `parent = $(parent)`. It performs much better."},"comment":{"url":"https://api.github.com/repos/patternfly/patternfly/issues/comments/363330611","html_url":"https://github.com/patternfly/patternfly/issues/947#issuecomment-363330611","issue_url":"https://api.github.com/repos/patternfly/patternfly/issues/947","id":363330611,"user":{"login":"dabeng","id":5689075,"avatar_url":"https://avatars1.githubusercontent.com/u/5689075?v=4","gravatar_id":"","url":"https://api.github.com/users/dabeng","html_url":"https://github.com/dabeng","followers_url":"https://api.github.com/users/dabeng/followers","following_url":"https://api.github.com/users/dabeng/following{/other_user}","gists_url":"https://api.github.com/users/dabeng/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeng/subscriptions","organizations_url":"https://api.github.com/users/dabeng/orgs","repos_url":"https://api.github.com/users/dabeng/repos","events_url":"https://api.github.com/users/dabeng/events{/privacy}","received_events_url":"https://api.github.com/users/dabeng/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T07:07:02Z","updated_at":"2018-02-06T07:07:02Z","author_association":"CONTRIBUTOR","body":"Hi @jamesnetherton , I agree with you. `rows.closest(parent)` will bring performance impact. It's better to replace `rows.closest(parent)` with `$(parent)`\r\n\r\n@dlabrecq @jeff-phillips-18 @cliffpyles  Any thoughts ?"}}
{"actor":{"display_login":"dabeng"}}