{"action":"created","comment":{"url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/comments/234763881","pull_request_review_id":176475573,"id":234763881,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc2Mzg4MQ==","diff_hunk":"@@ -63,30 +52,83 @@ The resulting rendered template will be:\n           The content to be placed inside the 'default part'\n         </div>\n \n-.. note:: \n-        If the part is named `default` the ``part``-tag can be ommited in the template that should implement the other template.\n+Note in the above example the use of the ``part-tag``.\n+In the insert template this tag indicates the location at which the content of the part-tag in the implementing template should be rendered to.\n+ \n+.. note:: It is also possible to have multiple part tags with different names to inject content into different parts of the template that is implemented.\n \n-        .. code-block:: html\n+Scope\n+-----\n+The actual contents of each insert is rendered separately and has its own scope. \n+It does however have access to the global scope of the original template (not to be confused with the template scope).\n \n-              [implement:'wrapper']\n-                The content to be placed inside the 'default part'\n-              [/implement]\n+`Part-tags` have read-access to the scope of the template in which they are located. Meaning you can use this mechanism to render information only available in the template which inserts a different template related to the part-tag.\n+\n+Example 1\n+---------\n \n-The ``implement``-tag also supports passing variables similarly to the ``include``-tag:\n+Code\n+++++\n \n .. code-block:: html\n+   :caption: insert.xpart\n \n-      [implement:'wrapper' arg1=\"<argument>\"]\n-        ...\n-      [/implement]\n+      Hello there.\n \n-The passed variable is then available under an auto-generated variable called ``include``.\n-With the above example the value of the ``arg1``-argument can then be accessed in the included template with ``[include.arg1]``\n+      [insert.person]\n \n-[part='<part-name>']\n-++++++++++++++++++++\n+.. code-block:: html\n+   :caption: template.xpage\n \n-Note in the above example the use of the ``part-tag``.\n-In the implemented template this tag indicates the location at which the content of the part-tag in the implementing template should be rendered to.\n- \n-.. note:: It is also possible to have multiple part tags with different names to inject content into different parts of the template that is implemented.\n+      Woosh.\n+\n+      [insert:'insert-template' person=\"General Kenobi\" /]\n+\n+Output\n+++++++\n+.. code-block:: html\n+\n+      Woosh.\n+\n+      Hello there.\n+\n+      General Kenobi\n+\n+\n+Example 2\n+---------\n+\n+.. code-block:: html\n+   :caption: insert.xpart\n+\n+    Hello there.\n+\n+    [part='name' /]\n+\n+.. code-block:: html\n+   :caption: template.xpage\n+\n+    [name=force->getOpponent /] <!-- Assume this is set to `General Kenobi` -->","path":"docs/templates/tags/include-implement.rst","position":null,"original_position":141,"commit_id":"eb443276dbdad1c911df6b777e64ed08c60edc9e","original_commit_id":"fab2857714640fac11e31212c293a89aa943fe25","user":{"login":"ttveldhuis","id":1822698,"node_id":"MDQ6VXNlcjE4MjI2OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1822698?v=4","gravatar_id":"","url":"https://api.github.com/users/ttveldhuis","html_url":"https://github.com/ttveldhuis","followers_url":"https://api.github.com/users/ttveldhuis/followers","following_url":"https://api.github.com/users/ttveldhuis/following{/other_user}","gists_url":"https://api.github.com/users/ttveldhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/ttveldhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttveldhuis/subscriptions","organizations_url":"https://api.github.com/users/ttveldhuis/orgs","repos_url":"https://api.github.com/users/ttveldhuis/repos","events_url":"https://api.github.com/users/ttveldhuis/events{/privacy}","received_events_url":"https://api.github.com/users/ttveldhuis/received_events","type":"User","site_admin":false},"body":"I have made a change to this, could you review?","created_at":"2018-11-19T20:07:02Z","updated_at":"2018-11-19T20:07:03Z","html_url":"https://github.com/Nentix/xentriq.docs/pull/24#discussion_r234763881","pull_request_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/comments/234763881"},"html":{"href":"https://github.com/Nentix/xentriq.docs/pull/24#discussion_r234763881"},"pull_request":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24"}},"in_reply_to_id":234460095},"pull_request":{"url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24","id":220803418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODAzNDE4","html_url":"https://github.com/Nentix/xentriq.docs/pull/24","diff_url":"https://github.com/Nentix/xentriq.docs/pull/24.diff","patch_url":"https://github.com/Nentix/xentriq.docs/pull/24.patch","issue_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/24","number":24,"state":"open","locked":false,"title":"Xentriq 1.0 documentation","user":{"login":"mpwaldhorst","id":13185130,"node_id":"MDQ6VXNlcjEzMTg1MTMw","avatar_url":"https://avatars2.githubusercontent.com/u/13185130?v=4","gravatar_id":"","url":"https://api.github.com/users/mpwaldhorst","html_url":"https://github.com/mpwaldhorst","followers_url":"https://api.github.com/users/mpwaldhorst/followers","following_url":"https://api.github.com/users/mpwaldhorst/following{/other_user}","gists_url":"https://api.github.com/users/mpwaldhorst/gists{/gist_id}","starred_url":"https://api.github.com/users/mpwaldhorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpwaldhorst/subscriptions","organizations_url":"https://api.github.com/users/mpwaldhorst/orgs","repos_url":"https://api.github.com/users/mpwaldhorst/repos","events_url":"https://api.github.com/users/mpwaldhorst/events{/privacy}","received_events_url":"https://api.github.com/users/mpwaldhorst/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-05T19:36:31Z","updated_at":"2018-11-19T20:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37bdd79dc90caeff5deea622fa55ff95759fba78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Nentix/xentriq.docs/milestones/1","html_url":"https://github.com/Nentix/xentriq.docs/milestone/1","labels_url":"https://api.github.com/repos/Nentix/xentriq.docs/milestones/1/labels","id":3410421,"node_id":"MDk6TWlsZXN0b25lMzQxMDQyMQ==","number":1,"title":"1.0","description":"","creator":{"login":"ttveldhuis","id":1822698,"node_id":"MDQ6VXNlcjE4MjI2OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1822698?v=4","gravatar_id":"","url":"https://api.github.com/users/ttveldhuis","html_url":"https://github.com/ttveldhuis","followers_url":"https://api.github.com/users/ttveldhuis/followers","following_url":"https://api.github.com/users/ttveldhuis/following{/other_user}","gists_url":"https://api.github.com/users/ttveldhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/ttveldhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttveldhuis/subscriptions","organizations_url":"https://api.github.com/users/ttveldhuis/orgs","repos_url":"https://api.github.com/users/ttveldhuis/repos","events_url":"https://api.github.com/users/ttveldhuis/events{/privacy}","received_events_url":"https://api.github.com/users/ttveldhuis/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2018-06-08T11:17:00Z","updated_at":"2018-11-09T19:47:09Z","due_on":"2018-06-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/24/comments","statuses_url":"https://api.github.com/repos/Nentix/xentriq.docs/statuses/eb443276dbdad1c911df6b777e64ed08c60edc9e","head":{"label":"Nentix:version_1_0","ref":"version_1_0","sha":"eb443276dbdad1c911df6b777e64ed08c60edc9e","user":{"login":"Nentix","id":26377826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mzc3ODI2","avatar_url":"https://avatars3.githubusercontent.com/u/26377826?v=4","gravatar_id":"","url":"https://api.github.com/users/Nentix","html_url":"https://github.com/Nentix","followers_url":"https://api.github.com/users/Nentix/followers","following_url":"https://api.github.com/users/Nentix/following{/other_user}","gists_url":"https://api.github.com/users/Nentix/gists{/gist_id}","starred_url":"https://api.github.com/users/Nentix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nentix/subscriptions","organizations_url":"https://api.github.com/users/Nentix/orgs","repos_url":"https://api.github.com/users/Nentix/repos","events_url":"https://api.github.com/users/Nentix/events{/privacy}","received_events_url":"https://api.github.com/users/Nentix/received_events","type":"Organization","site_admin":false},"repo":{"id":89490556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ5MDU1Ng==","name":"xentriq.docs","full_name":"Nentix/xentriq.docs","private":false,"owner":{"login":"Nentix","id":26377826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mzc3ODI2","avatar_url":"https://avatars3.githubusercontent.com/u/26377826?v=4","gravatar_id":"","url":"https://api.github.com/users/Nentix","html_url":"https://github.com/Nentix","followers_url":"https://api.github.com/users/Nentix/followers","following_url":"https://api.github.com/users/Nentix/following{/other_user}","gists_url":"https://api.github.com/users/Nentix/gists{/gist_id}","starred_url":"https://api.github.com/users/Nentix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nentix/subscriptions","organizations_url":"https://api.github.com/users/Nentix/orgs","repos_url":"https://api.github.com/users/Nentix/repos","events_url":"https://api.github.com/users/Nentix/events{/privacy}","received_events_url":"https://api.github.com/users/Nentix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Nentix/xentriq.docs","description":"Documentation for Xentriq","fork":false,"url":"https://api.github.com/repos/Nentix/xentriq.docs","forks_url":"https://api.github.com/repos/Nentix/xentriq.docs/forks","keys_url":"https://api.github.com/repos/Nentix/xentriq.docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nentix/xentriq.docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nentix/xentriq.docs/teams","hooks_url":"https://api.github.com/repos/Nentix/xentriq.docs/hooks","issue_events_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/events{/number}","events_url":"https://api.github.com/repos/Nentix/xentriq.docs/events","assignees_url":"https://api.github.com/repos/Nentix/xentriq.docs/assignees{/user}","branches_url":"https://api.github.com/repos/Nentix/xentriq.docs/branches{/branch}","tags_url":"https://api.github.com/repos/Nentix/xentriq.docs/tags","blobs_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nentix/xentriq.docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Nentix/xentriq.docs/languages","stargazers_url":"https://api.github.com/repos/Nentix/xentriq.docs/stargazers","contributors_url":"https://api.github.com/repos/Nentix/xentriq.docs/contributors","subscribers_url":"https://api.github.com/repos/Nentix/xentriq.docs/subscribers","subscription_url":"https://api.github.com/repos/Nentix/xentriq.docs/subscription","commits_url":"https://api.github.com/repos/Nentix/xentriq.docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nentix/xentriq.docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nentix/xentriq.docs/contents/{+path}","compare_url":"https://api.github.com/repos/Nentix/xentriq.docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nentix/xentriq.docs/merges","archive_url":"https://api.github.com/repos/Nentix/xentriq.docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nentix/xentriq.docs/downloads","issues_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues{/number}","pulls_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Nentix/xentriq.docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Nentix/xentriq.docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nentix/xentriq.docs/labels{/name}","releases_url":"https://api.github.com/repos/Nentix/xentriq.docs/releases{/id}","deployments_url":"https://api.github.com/repos/Nentix/xentriq.docs/deployments","created_at":"2017-04-26T14:28:50Z","updated_at":"2018-06-18T11:55:37Z","pushed_at":"2018-11-19T20:06:23Z","git_url":"git://github.com/Nentix/xentriq.docs.git","ssh_url":"git@github.com:Nentix/xentriq.docs.git","clone_url":"https://github.com/Nentix/xentriq.docs.git","svn_url":"https://github.com/Nentix/xentriq.docs","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"Nentix:development","ref":"development","sha":"39943d0b7efcf2ca1381d9e8297e00af5076fc45","user":{"login":"Nentix","id":26377826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mzc3ODI2","avatar_url":"https://avatars3.githubusercontent.com/u/26377826?v=4","gravatar_id":"","url":"https://api.github.com/users/Nentix","html_url":"https://github.com/Nentix","followers_url":"https://api.github.com/users/Nentix/followers","following_url":"https://api.github.com/users/Nentix/following{/other_user}","gists_url":"https://api.github.com/users/Nentix/gists{/gist_id}","starred_url":"https://api.github.com/users/Nentix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nentix/subscriptions","organizations_url":"https://api.github.com/users/Nentix/orgs","repos_url":"https://api.github.com/users/Nentix/repos","events_url":"https://api.github.com/users/Nentix/events{/privacy}","received_events_url":"https://api.github.com/users/Nentix/received_events","type":"Organization","site_admin":false},"repo":{"id":89490556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTQ5MDU1Ng==","name":"xentriq.docs","full_name":"Nentix/xentriq.docs","private":false,"owner":{"login":"Nentix","id":26377826,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Mzc3ODI2","avatar_url":"https://avatars3.githubusercontent.com/u/26377826?v=4","gravatar_id":"","url":"https://api.github.com/users/Nentix","html_url":"https://github.com/Nentix","followers_url":"https://api.github.com/users/Nentix/followers","following_url":"https://api.github.com/users/Nentix/following{/other_user}","gists_url":"https://api.github.com/users/Nentix/gists{/gist_id}","starred_url":"https://api.github.com/users/Nentix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nentix/subscriptions","organizations_url":"https://api.github.com/users/Nentix/orgs","repos_url":"https://api.github.com/users/Nentix/repos","events_url":"https://api.github.com/users/Nentix/events{/privacy}","received_events_url":"https://api.github.com/users/Nentix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Nentix/xentriq.docs","description":"Documentation for Xentriq","fork":false,"url":"https://api.github.com/repos/Nentix/xentriq.docs","forks_url":"https://api.github.com/repos/Nentix/xentriq.docs/forks","keys_url":"https://api.github.com/repos/Nentix/xentriq.docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nentix/xentriq.docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nentix/xentriq.docs/teams","hooks_url":"https://api.github.com/repos/Nentix/xentriq.docs/hooks","issue_events_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/events{/number}","events_url":"https://api.github.com/repos/Nentix/xentriq.docs/events","assignees_url":"https://api.github.com/repos/Nentix/xentriq.docs/assignees{/user}","branches_url":"https://api.github.com/repos/Nentix/xentriq.docs/branches{/branch}","tags_url":"https://api.github.com/repos/Nentix/xentriq.docs/tags","blobs_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nentix/xentriq.docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Nentix/xentriq.docs/languages","stargazers_url":"https://api.github.com/repos/Nentix/xentriq.docs/stargazers","contributors_url":"https://api.github.com/repos/Nentix/xentriq.docs/contributors","subscribers_url":"https://api.github.com/repos/Nentix/xentriq.docs/subscribers","subscription_url":"https://api.github.com/repos/Nentix/xentriq.docs/subscription","commits_url":"https://api.github.com/repos/Nentix/xentriq.docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nentix/xentriq.docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nentix/xentriq.docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nentix/xentriq.docs/contents/{+path}","compare_url":"https://api.github.com/repos/Nentix/xentriq.docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nentix/xentriq.docs/merges","archive_url":"https://api.github.com/repos/Nentix/xentriq.docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nentix/xentriq.docs/downloads","issues_url":"https://api.github.com/repos/Nentix/xentriq.docs/issues{/number}","pulls_url":"https://api.github.com/repos/Nentix/xentriq.docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Nentix/xentriq.docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Nentix/xentriq.docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nentix/xentriq.docs/labels{/name}","releases_url":"https://api.github.com/repos/Nentix/xentriq.docs/releases{/id}","deployments_url":"https://api.github.com/repos/Nentix/xentriq.docs/deployments","created_at":"2017-04-26T14:28:50Z","updated_at":"2018-06-18T11:55:37Z","pushed_at":"2018-11-19T20:06:23Z","git_url":"git://github.com/Nentix/xentriq.docs.git","ssh_url":"git@github.com:Nentix/xentriq.docs.git","clone_url":"https://github.com/Nentix/xentriq.docs.git","svn_url":"https://github.com/Nentix/xentriq.docs","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24"},"html":{"href":"https://github.com/Nentix/xentriq.docs/pull/24"},"issue":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/issues/24"},"comments":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Nentix/xentriq.docs/statuses/eb443276dbdad1c911df6b777e64ed08c60edc9e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ttveldhuis"}}