{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/comments/171830891","pull_request_review_id":100753932,"id":171830891,"diff_hunk":"@@ -155,29 +154,26 @@ public void class_with_nosqale_annotation() throws Exception {\n     class RuleClass {\n     }\n \n-    Repository repository = buildRepository(true, RuleClass.class);\n+    Repository repository = buildRepository(RuleClass.class);\n     assertThat(repository.rules()).hasSize(1);\n   }\n \n   @Test\n   public void class_with_sqale_constant_remediation() throws Exception {\n \n     @Rule(key = \"key1\", name = \"name1\", description = \"description1\")\n-    @SqaleSubCharacteristic(SubCharacteristics.CPU_EFFICIENCY)","path":"src/test/java/org/sonar/squidbridge/annotations/AnnotationBasedRulesDefinitionTest.java","position":65,"original_position":65,"commit_id":"6bc3b58205e053d0c66297f6bd0a42993710184a","original_commit_id":"97819cf289b396b2f366c66e81c48f673b9ed455","user":{"login":"pynicolas","id":6371790,"avatar_url":"https://avatars2.githubusercontent.com/u/6371790?v=4","gravatar_id":"","url":"https://api.github.com/users/pynicolas","html_url":"https://github.com/pynicolas","followers_url":"https://api.github.com/users/pynicolas/followers","following_url":"https://api.github.com/users/pynicolas/following{/other_user}","gists_url":"https://api.github.com/users/pynicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/pynicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynicolas/subscriptions","organizations_url":"https://api.github.com/users/pynicolas/orgs","repos_url":"https://api.github.com/users/pynicolas/repos","events_url":"https://api.github.com/users/pynicolas/events{/privacy}","received_events_url":"https://api.github.com/users/pynicolas/received_events","type":"User","site_admin":false},"body":"Shouldn't we keep at least one test to assert that no subcharacteristic is saved even when we use the annotation?","created_at":"2018-03-02T12:03:17Z","updated_at":"2018-03-02T12:06:38Z","html_url":"https://github.com/SonarSource/sslr-squid-bridge/pull/15#discussion_r171830891","pull_request_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/comments/171830891"},"html":{"href":"https://github.com/SonarSource/sslr-squid-bridge/pull/15#discussion_r171830891"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15","id":171997607,"html_url":"https://github.com/SonarSource/sslr-squid-bridge/pull/15","diff_url":"https://github.com/SonarSource/sslr-squid-bridge/pull/15.diff","patch_url":"https://github.com/SonarSource/sslr-squid-bridge/pull/15.patch","issue_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/15","number":15,"state":"open","locked":false,"title":"SSLRSQBR-67 Upgrade dependency on SonarQube to LTS 6.7","user":{"login":"m-g-sonar","id":10588758,"avatar_url":"https://avatars2.githubusercontent.com/u/10588758?v=4","gravatar_id":"","url":"https://api.github.com/users/m-g-sonar","html_url":"https://github.com/m-g-sonar","followers_url":"https://api.github.com/users/m-g-sonar/followers","following_url":"https://api.github.com/users/m-g-sonar/following{/other_user}","gists_url":"https://api.github.com/users/m-g-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/m-g-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-g-sonar/subscriptions","organizations_url":"https://api.github.com/users/m-g-sonar/orgs","repos_url":"https://api.github.com/users/m-g-sonar/repos","events_url":"https://api.github.com/users/m-g-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/m-g-sonar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-28T16:05:45Z","updated_at":"2018-03-02T12:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b7815fd1a7d8bc3563caaa505fc9699476e213e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/15/comments","statuses_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/statuses/6bc3b58205e053d0c66297f6bd0a42993710184a","head":{"label":"SonarSource:SSLRSQBR-67","ref":"SSLRSQBR-67","sha":"6bc3b58205e053d0c66297f6bd0a42993710184a","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4160026,"name":"sslr-squid-bridge","full_name":"SonarSource/sslr-squid-bridge","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sslr-squid-bridge","description":null,"fork":false,"url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge","forks_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/forks","keys_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/teams","hooks_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/events","assignees_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/tags","blobs_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/subscription","commits_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/merges","archive_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/downloads","issues_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/deployments","created_at":"2012-04-27T16:08:05Z","updated_at":"2018-02-27T08:24:59Z","pushed_at":"2018-03-02T10:06:15Z","git_url":"git://github.com/SonarSource/sslr-squid-bridge.git","ssh_url":"git@github.com:SonarSource/sslr-squid-bridge.git","clone_url":"https://github.com/SonarSource/sslr-squid-bridge.git","svn_url":"https://github.com/SonarSource/sslr-squid-bridge","homepage":null,"size":538,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"SonarSource:SSLRSQBR-71","ref":"SSLRSQBR-71","sha":"bc1fb8e1b16c6a934cdada1d75cece4109202776","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4160026,"name":"sslr-squid-bridge","full_name":"SonarSource/sslr-squid-bridge","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sslr-squid-bridge","description":null,"fork":false,"url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge","forks_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/forks","keys_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/teams","hooks_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/events","assignees_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/tags","blobs_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/subscription","commits_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/merges","archive_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/downloads","issues_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/deployments","created_at":"2012-04-27T16:08:05Z","updated_at":"2018-02-27T08:24:59Z","pushed_at":"2018-03-02T10:06:15Z","git_url":"git://github.com/SonarSource/sslr-squid-bridge.git","ssh_url":"git@github.com:SonarSource/sslr-squid-bridge.git","clone_url":"https://github.com/SonarSource/sslr-squid-bridge.git","svn_url":"https://github.com/SonarSource/sslr-squid-bridge","homepage":null,"size":538,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15"},"html":{"href":"https://github.com/SonarSource/sslr-squid-bridge/pull/15"},"issue":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/15"},"comments":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sslr-squid-bridge/statuses/6bc3b58205e053d0c66297f6bd0a42993710184a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pynicolas"}}