{"action":"created","comment":{"url":"https://api.github.com/repos/j2kan/ta-works/pulls/comments/172079764","pull_request_review_id":101035497,"id":172079764,"diff_hunk":"@@ -30,27 +44,18 @@ <h4>Monitor the status of graduate student rankings for the upcoming term's cour\n \t<th class=\"tg-8fvv\">Instructor</th>\n \t<th class=\"tg-8fvv\">Instructor Email</th>\n \t<th class=\"tg-8fvv\">Ranking Status</th>\n+\t<th class=\"tg-8fvv\">Ranking Link</th>\n \t</tr>\n-{% if emptyApps %}\n+\n \t{% for c in ranking_status %}\n <tr>\n-\t<td class=\"tg-yw4l\"><a href=\"https://team4.uwaterloo.ca/taform/instructor/{{c.url_hash}}/\">MSCI&nbsp;{{c.course_id}}</a></td>\n+\t<td class=\"tg-yw4l\"><a target=\"_blank\" href=\"http://www.adm.uwaterloo.ca/cgi-bin/cgiwrap/infocour/salook.pl?sess={{c.term}}&subject={{c.course_subject}}&cournum={{c.course_id}}\">{{c.course_subject}} {{c.course_id}}</a></td>\n \t<td>{{c.section}}</td>\n-\t<td>0</td>\n-\t<td>{{c.instructor_name}}</td>\n-\t<td>{{c.instructor_email}}</td>\n-\t<td><b>No Applicants</b></td>\n-</tr>\n-\t{% endfor %}\n-{% else %}\n-\t{% for c in ranking_status %}\n-<tr>\n-\t<td class=\"tg-yw4l\"><a href=\"https://team4.uwaterloo.ca/taform/instructor/{{c.course__url_hash}}/\">MSCI&nbsp;{{c.course__course_id}}</a></td>\n-\t<td>{{c.course__section}}</td>\n \t<td>{{c.count}}</td>\n-\t<td>{{c.course__instructor_name}}</td>\n-\t<td>{{c.course__instructor_email}}</td>\n+\t<td>{{c.instructor_name}}</td>\n+\t<td><a href=\"mailto:{{c.instructor_email}}\">{{c.instructor_email}}</a></td>\n \t<td>{{c.status}}</td>\n+\t<td><a href=\"https://team4.uwaterloo.ca/taform/instructor/{{c.course__url_hash}}/\">Link</a></td>","path":"taworks/taform/templates/taform/ranking_status.html","position":69,"original_position":69,"commit_id":"e73af45762df38b7ea4d41a9c72377a076d28c90","original_commit_id":"e73af45762df38b7ea4d41a9c72377a076d28c90","user":{"login":"amyleblond","id":22120696,"avatar_url":"https://avatars0.githubusercontent.com/u/22120696?v=4","gravatar_id":"","url":"https://api.github.com/users/amyleblond","html_url":"https://github.com/amyleblond","followers_url":"https://api.github.com/users/amyleblond/followers","following_url":"https://api.github.com/users/amyleblond/following{/other_user}","gists_url":"https://api.github.com/users/amyleblond/gists{/gist_id}","starred_url":"https://api.github.com/users/amyleblond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyleblond/subscriptions","organizations_url":"https://api.github.com/users/amyleblond/orgs","repos_url":"https://api.github.com/users/amyleblond/repos","events_url":"https://api.github.com/users/amyleblond/events{/privacy}","received_events_url":"https://api.github.com/users/amyleblond/received_events","type":"User","site_admin":false},"body":"or the url doesnt show hash??","created_at":"2018-03-05T02:28:32Z","updated_at":"2018-03-05T02:28:33Z","html_url":"https://github.com/j2kan/ta-works/pull/96#discussion_r172079764","pull_request_url":"https://api.github.com/repos/j2kan/ta-works/pulls/96","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/comments/172079764"},"html":{"href":"https://github.com/j2kan/ta-works/pull/96#discussion_r172079764"},"pull_request":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/96"}},"in_reply_to_id":172078800},"pull_request":{"url":"https://api.github.com/repos/j2kan/ta-works/pulls/96","id":172754134,"html_url":"https://github.com/j2kan/ta-works/pull/96","diff_url":"https://github.com/j2kan/ta-works/pull/96.diff","patch_url":"https://github.com/j2kan/ta-works/pull/96.patch","issue_url":"https://api.github.com/repos/j2kan/ta-works/issues/96","number":96,"state":"open","locked":false,"title":"Ranking cleanup","user":{"login":"amyleblond","id":22120696,"avatar_url":"https://avatars0.githubusercontent.com/u/22120696?v=4","gravatar_id":"","url":"https://api.github.com/users/amyleblond","html_url":"https://github.com/amyleblond","followers_url":"https://api.github.com/users/amyleblond/followers","following_url":"https://api.github.com/users/amyleblond/following{/other_user}","gists_url":"https://api.github.com/users/amyleblond/gists{/gist_id}","starred_url":"https://api.github.com/users/amyleblond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amyleblond/subscriptions","organizations_url":"https://api.github.com/users/amyleblond/orgs","repos_url":"https://api.github.com/users/amyleblond/repos","events_url":"https://api.github.com/users/amyleblond/events{/privacy}","received_events_url":"https://api.github.com/users/amyleblond/received_events","type":"User","site_admin":false},"body":"changes:\r\n\r\n**README.me** - testing and user instruction updates\r\n**style.css** - adding class for email sending confirmation\r\n**app-jquery.js** - adding function for email sending confirmation\r\n**algorithm.html** - adding success message for algorun\r\n**instructor_ranking.html** - message to contact AC if there are no applicants\r\n**ranking_status.html** - adding pop up for confirmation, failure message if no courses have been uploaded yet, removing if loop (no longer required based on views.py), add mail-to tags\r\n**views.py**: changing the query for count of applications to be over the course table with a join on applications (was originally vice versa). This makes sure that we are attempting to count for courses that do not have applicants.\r\n\r\n![screen shot 2018-03-04 at 7 48 28 pm](https://user-images.githubusercontent.com/22120696/36953225-07f509fe-1fe7-11e8-964b-b175a27f0189.png)\r\n![screen shot 2018-03-04 at 7 48 58 pm](https://user-images.githubusercontent.com/22120696/36953228-0df24fb0-1fe7-11e8-88cb-40119579d5cb.png)\r\n![screen shot 2018-03-04 at 7 49 57 pm](https://user-images.githubusercontent.com/22120696/36953229-100c8a5e-1fe7-11e8-9523-3ba403ec5aff.png)\r\n![screen shot 2018-03-04 at 7 51 14 pm](https://user-images.githubusercontent.com/22120696/36953230-119a0838-1fe7-11e8-9a02-a3d6ac017b49.png)\r\n![screen shot 2018-03-04 at 7 52 07 pm](https://user-images.githubusercontent.com/22120696/36953231-1328f222-1fe7-11e8-873c-6317d893e9b8.png)\r\n![screen shot 2018-03-04 at 7 54 18 pm](https://user-images.githubusercontent.com/22120696/36953232-152f9882-1fe7-11e8-8cca-91bed200828b.png)\r\n\r\nTested with all Dummy data -- run ranking status page with nothing in DB, courses in DB with no applicants, some courses with applicants and others without, open up instructor ranking links","created_at":"2018-03-05T01:04:34Z","updated_at":"2018-03-05T02:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e1eb635a0393d1f7f28cc829b4ccf5722db8e91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},{"login":"lauradobson","id":22123056,"avatar_url":"https://avatars2.githubusercontent.com/u/22123056?v=4","gravatar_id":"","url":"https://api.github.com/users/lauradobson","html_url":"https://github.com/lauradobson","followers_url":"https://api.github.com/users/lauradobson/followers","following_url":"https://api.github.com/users/lauradobson/following{/other_user}","gists_url":"https://api.github.com/users/lauradobson/gists{/gist_id}","starred_url":"https://api.github.com/users/lauradobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauradobson/subscriptions","organizations_url":"https://api.github.com/users/lauradobson/orgs","repos_url":"https://api.github.com/users/lauradobson/repos","events_url":"https://api.github.com/users/lauradobson/events{/privacy}","received_events_url":"https://api.github.com/users/lauradobson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/j2kan/ta-works/pulls/96/commits","review_comments_url":"https://api.github.com/repos/j2kan/ta-works/pulls/96/comments","review_comment_url":"https://api.github.com/repos/j2kan/ta-works/pulls/comments{/number}","comments_url":"https://api.github.com/repos/j2kan/ta-works/issues/96/comments","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/e73af45762df38b7ea4d41a9c72377a076d28c90","head":{"label":"j2kan:ranking_cleanup","ref":"ranking_cleanup","sha":"e73af45762df38b7ea4d41a9c72377a076d28c90","user":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"repo":{"id":95298493,"name":"ta-works","full_name":"j2kan/ta-works","owner":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j2kan/ta-works","description":"A web application that has a matching algorithm to assign teaching assistants to courses.","fork":false,"url":"https://api.github.com/repos/j2kan/ta-works","forks_url":"https://api.github.com/repos/j2kan/ta-works/forks","keys_url":"https://api.github.com/repos/j2kan/ta-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j2kan/ta-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j2kan/ta-works/teams","hooks_url":"https://api.github.com/repos/j2kan/ta-works/hooks","issue_events_url":"https://api.github.com/repos/j2kan/ta-works/issues/events{/number}","events_url":"https://api.github.com/repos/j2kan/ta-works/events","assignees_url":"https://api.github.com/repos/j2kan/ta-works/assignees{/user}","branches_url":"https://api.github.com/repos/j2kan/ta-works/branches{/branch}","tags_url":"https://api.github.com/repos/j2kan/ta-works/tags","blobs_url":"https://api.github.com/repos/j2kan/ta-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j2kan/ta-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j2kan/ta-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/j2kan/ta-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/{sha}","languages_url":"https://api.github.com/repos/j2kan/ta-works/languages","stargazers_url":"https://api.github.com/repos/j2kan/ta-works/stargazers","contributors_url":"https://api.github.com/repos/j2kan/ta-works/contributors","subscribers_url":"https://api.github.com/repos/j2kan/ta-works/subscribers","subscription_url":"https://api.github.com/repos/j2kan/ta-works/subscription","commits_url":"https://api.github.com/repos/j2kan/ta-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/j2kan/ta-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/j2kan/ta-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/j2kan/ta-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/j2kan/ta-works/contents/{+path}","compare_url":"https://api.github.com/repos/j2kan/ta-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j2kan/ta-works/merges","archive_url":"https://api.github.com/repos/j2kan/ta-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j2kan/ta-works/downloads","issues_url":"https://api.github.com/repos/j2kan/ta-works/issues{/number}","pulls_url":"https://api.github.com/repos/j2kan/ta-works/pulls{/number}","milestones_url":"https://api.github.com/repos/j2kan/ta-works/milestones{/number}","notifications_url":"https://api.github.com/repos/j2kan/ta-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j2kan/ta-works/labels{/name}","releases_url":"https://api.github.com/repos/j2kan/ta-works/releases{/id}","deployments_url":"https://api.github.com/repos/j2kan/ta-works/deployments","created_at":"2017-06-24T13:14:12Z","updated_at":"2017-07-10T19:47:12Z","pushed_at":"2018-03-05T01:10:20Z","git_url":"git://github.com/j2kan/ta-works.git","ssh_url":"git@github.com:j2kan/ta-works.git","clone_url":"https://github.com/j2kan/ta-works.git","svn_url":"https://github.com/j2kan/ta-works","homepage":null,"size":2151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"j2kan:master","ref":"master","sha":"67beec08fd931237bd709b3d1a3cf4c741f05b39","user":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"repo":{"id":95298493,"name":"ta-works","full_name":"j2kan/ta-works","owner":{"login":"j2kan","id":18583351,"avatar_url":"https://avatars3.githubusercontent.com/u/18583351?v=4","gravatar_id":"","url":"https://api.github.com/users/j2kan","html_url":"https://github.com/j2kan","followers_url":"https://api.github.com/users/j2kan/followers","following_url":"https://api.github.com/users/j2kan/following{/other_user}","gists_url":"https://api.github.com/users/j2kan/gists{/gist_id}","starred_url":"https://api.github.com/users/j2kan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2kan/subscriptions","organizations_url":"https://api.github.com/users/j2kan/orgs","repos_url":"https://api.github.com/users/j2kan/repos","events_url":"https://api.github.com/users/j2kan/events{/privacy}","received_events_url":"https://api.github.com/users/j2kan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j2kan/ta-works","description":"A web application that has a matching algorithm to assign teaching assistants to courses.","fork":false,"url":"https://api.github.com/repos/j2kan/ta-works","forks_url":"https://api.github.com/repos/j2kan/ta-works/forks","keys_url":"https://api.github.com/repos/j2kan/ta-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j2kan/ta-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j2kan/ta-works/teams","hooks_url":"https://api.github.com/repos/j2kan/ta-works/hooks","issue_events_url":"https://api.github.com/repos/j2kan/ta-works/issues/events{/number}","events_url":"https://api.github.com/repos/j2kan/ta-works/events","assignees_url":"https://api.github.com/repos/j2kan/ta-works/assignees{/user}","branches_url":"https://api.github.com/repos/j2kan/ta-works/branches{/branch}","tags_url":"https://api.github.com/repos/j2kan/ta-works/tags","blobs_url":"https://api.github.com/repos/j2kan/ta-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j2kan/ta-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j2kan/ta-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/j2kan/ta-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j2kan/ta-works/statuses/{sha}","languages_url":"https://api.github.com/repos/j2kan/ta-works/languages","stargazers_url":"https://api.github.com/repos/j2kan/ta-works/stargazers","contributors_url":"https://api.github.com/repos/j2kan/ta-works/contributors","subscribers_url":"https://api.github.com/repos/j2kan/ta-works/subscribers","subscription_url":"https://api.github.com/repos/j2kan/ta-works/subscription","commits_url":"https://api.github.com/repos/j2kan/ta-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/j2kan/ta-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/j2kan/ta-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/j2kan/ta-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/j2kan/ta-works/contents/{+path}","compare_url":"https://api.github.com/repos/j2kan/ta-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j2kan/ta-works/merges","archive_url":"https://api.github.com/repos/j2kan/ta-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j2kan/ta-works/downloads","issues_url":"https://api.github.com/repos/j2kan/ta-works/issues{/number}","pulls_url":"https://api.github.com/repos/j2kan/ta-works/pulls{/number}","milestones_url":"https://api.github.com/repos/j2kan/ta-works/milestones{/number}","notifications_url":"https://api.github.com/repos/j2kan/ta-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j2kan/ta-works/labels{/name}","releases_url":"https://api.github.com/repos/j2kan/ta-works/releases{/id}","deployments_url":"https://api.github.com/repos/j2kan/ta-works/deployments","created_at":"2017-06-24T13:14:12Z","updated_at":"2017-07-10T19:47:12Z","pushed_at":"2018-03-05T01:10:20Z","git_url":"git://github.com/j2kan/ta-works.git","ssh_url":"git@github.com:j2kan/ta-works.git","clone_url":"https://github.com/j2kan/ta-works.git","svn_url":"https://github.com/j2kan/ta-works","homepage":null,"size":2151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/96"},"html":{"href":"https://github.com/j2kan/ta-works/pull/96"},"issue":{"href":"https://api.github.com/repos/j2kan/ta-works/issues/96"},"comments":{"href":"https://api.github.com/repos/j2kan/ta-works/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/j2kan/ta-works/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/j2kan/ta-works/statuses/e73af45762df38b7ea4d41a9c72377a076d28c90"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"amyleblond"}}