{"action":"created","issue":{"url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/119","repository_url":"https://api.github.com/repos/nwplus/nwhacks2019","labels_url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/119/comments","events_url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/119/events","html_url":"https://github.com/nwplus/nwhacks2019/pull/119","id":367430782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODY5NTgw","number":119,"title":"Web/section/footer","user":{"login":"chamkank","id":12876696,"node_id":"MDQ6VXNlcjEyODc2Njk2","avatar_url":"https://avatars2.githubusercontent.com/u/12876696?v=4","gravatar_id":"","url":"https://api.github.com/users/chamkank","html_url":"https://github.com/chamkank","followers_url":"https://api.github.com/users/chamkank/followers","following_url":"https://api.github.com/users/chamkank/following{/other_user}","gists_url":"https://api.github.com/users/chamkank/gists{/gist_id}","starred_url":"https://api.github.com/users/chamkank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamkank/subscriptions","organizations_url":"https://api.github.com/users/chamkank/orgs","repos_url":"https://api.github.com/users/chamkank/repos","events_url":"https://api.github.com/users/chamkank/events{/privacy}","received_events_url":"https://api.github.com/users/chamkank/received_events","type":"User","site_admin":false},"labels":[{"id":963610125,"node_id":"MDU6TGFiZWw5NjM2MTAxMjU=","url":"https://api.github.com/repos/nwplus/nwhacks2019/labels/:web","name":":web","color":"1d76db","default":false},{"id":963611169,"node_id":"MDU6TGFiZWw5NjM2MTExNjk=","url":"https://api.github.com/repos/nwplus/nwhacks2019/labels/status:%20finalized","name":"status: finalized","color":"0e8a16","default":false},{"id":963610480,"node_id":"MDU6TGFiZWw5NjM2MTA0ODA=","url":"https://api.github.com/repos/nwplus/nwhacks2019/labels/type:%20feature","name":"type: feature","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nwplus/nwhacks2019/milestones/2","html_url":"https://github.com/nwplus/nwhacks2019/milestone/2","labels_url":"https://api.github.com/repos/nwplus/nwhacks2019/milestones/2/labels","id":3562261,"node_id":"MDk6TWlsZXN0b25lMzU2MjI2MQ==","number":2,"title":"homepage (october 8th edition)","description":"","creator":{"login":"bobheadxi","id":23356519,"node_id":"MDQ6VXNlcjIzMzU2NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/23356519?v=4","gravatar_id":"","url":"https://api.github.com/users/bobheadxi","html_url":"https://github.com/bobheadxi","followers_url":"https://api.github.com/users/bobheadxi/followers","following_url":"https://api.github.com/users/bobheadxi/following{/other_user}","gists_url":"https://api.github.com/users/bobheadxi/gists{/gist_id}","starred_url":"https://api.github.com/users/bobheadxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobheadxi/subscriptions","organizations_url":"https://api.github.com/users/bobheadxi/orgs","repos_url":"https://api.github.com/users/bobheadxi/repos","events_url":"https://api.github.com/users/bobheadxi/events{/privacy}","received_events_url":"https://api.github.com/users/bobheadxi/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":19,"state":"open","created_at":"2018-08-11T02:47:08Z","updated_at":"2018-10-07T21:57:13Z","due_on":"2018-10-08T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-10-06T06:59:50Z","updated_at":"2018-10-08T18:43:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nwplus/nwhacks2019/pulls/119","html_url":"https://github.com/nwplus/nwhacks2019/pull/119","diff_url":"https://github.com/nwplus/nwhacks2019/pull/119.diff","patch_url":"https://github.com/nwplus/nwhacks2019/pull/119.patch"},"body":":tickets: **Ticket(s)**: Closes #72 \r\n\r\n---\r\n\r\n## :construction_worker: Changes\r\n\r\nImplemented the footer for desktop and mobile.\r\n\r\n## :thought_balloon: Notes\r\n\r\n- Each of the scenery trees (and the bear) were separate SVGs that were manually positioned for desktop.\r\n  - This is so I can individually hide each item as the screen size shrinks (see the preview)\r\n- On mobile, they're grouped into left and right scenery SVGs.\r\n- Ignore the horizontal scrollbar, that will be address in #118 \r\n\r\n**Preview: [https://i.imgur.com/sXpV7ao.gifv](https://i.imgur.com/sXpV7ao.gifv)**\r\n\r\n## :flashlight: Testing Instructions\r\n\r\nI've tried it from 4k down to 320px screen width on Chrome and FireFox. Should also verify that it's not broken on Safari. \r\n"},"comment":{"url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/comments/427939470","html_url":"https://github.com/nwplus/nwhacks2019/pull/119#issuecomment-427939470","issue_url":"https://api.github.com/repos/nwplus/nwhacks2019/issues/119","id":427939470,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzkzOTQ3MA==","user":{"login":"chamkank","id":12876696,"node_id":"MDQ6VXNlcjEyODc2Njk2","avatar_url":"https://avatars2.githubusercontent.com/u/12876696?v=4","gravatar_id":"","url":"https://api.github.com/users/chamkank","html_url":"https://github.com/chamkank","followers_url":"https://api.github.com/users/chamkank/followers","following_url":"https://api.github.com/users/chamkank/following{/other_user}","gists_url":"https://api.github.com/users/chamkank/gists{/gist_id}","starred_url":"https://api.github.com/users/chamkank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamkank/subscriptions","organizations_url":"https://api.github.com/users/chamkank/orgs","repos_url":"https://api.github.com/users/chamkank/repos","events_url":"https://api.github.com/users/chamkank/events{/privacy}","received_events_url":"https://api.github.com/users/chamkank/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T18:43:15Z","updated_at":"2018-10-08T18:43:15Z","author_association":"MEMBER","body":"> It seems like there are no arbutus trees (the green ones) at 1024 width, but that's no big deal\r\n> also at 800px, there's no bear and only two ever greens\r\n\r\nYeah I just arbitrarily removed the elements as the screen size shrinks because they wouldn't fit. A better way to handle the screen size reduction would have been to resize and reposition the elements for desktop, laptop, tablet, and mobile. And to only use the `left_trees.svg`, `bear.svg`, and `right_trees.svg` files instead of individual svg files for each object.\r\n\r\nI'll see if I can quickly refactor this in the same PR, if not I'll open up an issue. Thanks!"}}
{"actor":{"display_login":"chamkank"}}