{"action":"created","comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments/180444707","pull_request_review_id":110864869,"id":180444707,"diff_hunk":"@@ -331,6 +333,10 @@ protected int handlePriority(ReaderWay way, int priorityFromRelation) {\n         else\n             weightToPrioMap.put(110d, priorityFromRelation);\n \n+        if (isWayAccessDestination(way))","path":"core/src/main/java/com/graphhopper/routing/util/FootFlagEncoder.java","position":13,"original_position":13,"commit_id":"5c0bea6a397e4b3230a5bdcf96b9f4f93e275f0f","original_commit_id":"32ae531bf5e4409da76e96f8bdda8cdc946b0670","user":{"login":"karussell","id":129644,"avatar_url":"https://avatars0.githubusercontent.com/u/129644?v=4","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"body":"This looks good to me.","created_at":"2018-04-10T14:35:54Z","updated_at":"2018-04-10T14:35:54Z","html_url":"https://github.com/graphhopper/graphhopper/pull/1272#discussion_r180444707","pull_request_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments/180444707"},"html":{"href":"https://github.com/graphhopper/graphhopper/pull/1272#discussion_r180444707"},"pull_request":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272"}},"in_reply_to_id":162539448},"pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272","id":163887855,"html_url":"https://github.com/graphhopper/graphhopper/pull/1272","diff_url":"https://github.com/graphhopper/graphhopper/pull/1272.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/1272.patch","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1272","number":1272,"state":"open","locked":false,"title":"Avoid access=destination for bike and foot as well","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"body":"This PR should fix #733. It adds support for access=destination tags.\r\n\r\nI unfortunately needed to not only change the priority but also the speed. Some cases might have been solved by the priority only, but all 3 cases by @ftrebien, reported [here](https://github.com/graphhopper/graphhopper/issues/733#issuecomment-357673369), were not properly solved by only changing the Priority. \r\n\r\nIf you look at the examples, the generated detour is sometimes huge, e.g. 500m instead of 80m.\r\n\r\nBTW: The changed test in GraphHopperIT is actually a nice improvement. It misses an unnecessary continue instruction. I debugged it and it seems like there was a small road with access=destination (it's not there in the current OSM data anymore).  The small road with access=destination had the same name like the current road and the same flags. Now that we change the flags for roads with access=destination, the instruction get's ignored [here](https://github.com/graphhopper/graphhopper/blob/d1d60828ce4493c799990b5a817272d101406af4/core/src/main/java/com/graphhopper/routing/InstructionsFromEdges.java#L369).","created_at":"2018-01-19T05:16:10Z","updated_at":"2018-04-10T14:35:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1d133435339ee41dee6c3152978cfa1f558dc37","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":32202724,"url":"https://api.github.com/repos/graphhopper/graphhopper/labels/improvement","name":"improvement","color":"d7e102","default":false}],"milestone":{"url":"https://api.github.com/repos/graphhopper/graphhopper/milestones/12","html_url":"https://github.com/graphhopper/graphhopper/milestone/12","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/milestones/12/labels","id":3052876,"number":12,"title":"0.11","description":"","creator":{"login":"karussell","id":129644,"avatar_url":"https://avatars0.githubusercontent.com/u/129644?v=4","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":7,"state":"open","created_at":"2018-01-22T08:57:10Z","updated_at":"2018-04-09T15:43:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272/commits","review_comments_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272/comments","review_comment_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/1272/comments","statuses_url":"https://api.github.com/repos/graphhopper/graphhopper/statuses/5c0bea6a397e4b3230a5bdcf96b9f4f93e275f0f","head":{"label":"boldtrn:issue_733_bike","ref":"issue_733_bike","sha":"5c0bea6a397e4b3230a5bdcf96b9f4f93e275f0f","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"repo":{"id":46709952,"name":"graphhopper","full_name":"boldtrn/graphhopper","owner":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boldtrn/graphhopper","description":"Fast routing library and server using OpenStreetMap. #route #planner","fork":true,"url":"https://api.github.com/repos/boldtrn/graphhopper","forks_url":"https://api.github.com/repos/boldtrn/graphhopper/forks","keys_url":"https://api.github.com/repos/boldtrn/graphhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boldtrn/graphhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boldtrn/graphhopper/teams","hooks_url":"https://api.github.com/repos/boldtrn/graphhopper/hooks","issue_events_url":"https://api.github.com/repos/boldtrn/graphhopper/issues/events{/number}","events_url":"https://api.github.com/repos/boldtrn/graphhopper/events","assignees_url":"https://api.github.com/repos/boldtrn/graphhopper/assignees{/user}","branches_url":"https://api.github.com/repos/boldtrn/graphhopper/branches{/branch}","tags_url":"https://api.github.com/repos/boldtrn/graphhopper/tags","blobs_url":"https://api.github.com/repos/boldtrn/graphhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boldtrn/graphhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boldtrn/graphhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/boldtrn/graphhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boldtrn/graphhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/boldtrn/graphhopper/languages","stargazers_url":"https://api.github.com/repos/boldtrn/graphhopper/stargazers","contributors_url":"https://api.github.com/repos/boldtrn/graphhopper/contributors","subscribers_url":"https://api.github.com/repos/boldtrn/graphhopper/subscribers","subscription_url":"https://api.github.com/repos/boldtrn/graphhopper/subscription","commits_url":"https://api.github.com/repos/boldtrn/graphhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/boldtrn/graphhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/boldtrn/graphhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/boldtrn/graphhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/boldtrn/graphhopper/contents/{+path}","compare_url":"https://api.github.com/repos/boldtrn/graphhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boldtrn/graphhopper/merges","archive_url":"https://api.github.com/repos/boldtrn/graphhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boldtrn/graphhopper/downloads","issues_url":"https://api.github.com/repos/boldtrn/graphhopper/issues{/number}","pulls_url":"https://api.github.com/repos/boldtrn/graphhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/boldtrn/graphhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/boldtrn/graphhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boldtrn/graphhopper/labels{/name}","releases_url":"https://api.github.com/repos/boldtrn/graphhopper/releases{/id}","deployments_url":"https://api.github.com/repos/boldtrn/graphhopper/deployments","created_at":"2015-11-23T09:28:28Z","updated_at":"2018-04-06T05:56:09Z","pushed_at":"2018-04-06T05:56:06Z","git_url":"git://github.com/boldtrn/graphhopper.git","ssh_url":"git@github.com:boldtrn/graphhopper.git","clone_url":"https://github.com/boldtrn/graphhopper.git","svn_url":"https://github.com/boldtrn/graphhopper","homepage":"https://graphhopper.com","size":54125,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"b914f0826c36c031d51054f2fd29e16716d57a08","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":3480666,"name":"graphhopper","full_name":"graphhopper/graphhopper","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/graphhopper","description":"An open source route planning library and server using OpenStreetMap.","fork":false,"url":"https://api.github.com/repos/graphhopper/graphhopper","forks_url":"https://api.github.com/repos/graphhopper/graphhopper/forks","keys_url":"https://api.github.com/repos/graphhopper/graphhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/graphhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/graphhopper/teams","hooks_url":"https://api.github.com/repos/graphhopper/graphhopper/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/graphhopper/events","assignees_url":"https://api.github.com/repos/graphhopper/graphhopper/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/graphhopper/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/graphhopper/tags","blobs_url":"https://api.github.com/repos/graphhopper/graphhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/graphhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/graphhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/graphhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/graphhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/graphhopper/languages","stargazers_url":"https://api.github.com/repos/graphhopper/graphhopper/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/graphhopper/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/graphhopper/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/graphhopper/subscription","commits_url":"https://api.github.com/repos/graphhopper/graphhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/graphhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/graphhopper/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/graphhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/graphhopper/merges","archive_url":"https://api.github.com/repos/graphhopper/graphhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/graphhopper/downloads","issues_url":"https://api.github.com/repos/graphhopper/graphhopper/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/graphhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/graphhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/graphhopper/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/graphhopper/deployments","created_at":"2012-02-18T19:57:38Z","updated_at":"2018-04-10T06:28:14Z","pushed_at":"2018-04-10T08:22:38Z","git_url":"git://github.com/graphhopper/graphhopper.git","ssh_url":"git@github.com:graphhopper/graphhopper.git","clone_url":"https://github.com/graphhopper/graphhopper.git","svn_url":"https://github.com/graphhopper/graphhopper","homepage":"https://www.graphhopper.com/open-source/","size":65641,"stargazers_count":1553,"watchers_count":1553,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":649,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":649,"open_issues":217,"watchers":1553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272"},"html":{"href":"https://github.com/graphhopper/graphhopper/pull/1272"},"issue":{"href":"https://api.github.com/repos/graphhopper/graphhopper/issues/1272"},"comments":{"href":"https://api.github.com/repos/graphhopper/graphhopper/issues/1272/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/1272/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/graphhopper/statuses/5c0bea6a397e4b3230a5bdcf96b9f4f93e275f0f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"karussell"}}