{"action":"created","comment":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments/203451076","pull_request_review_id":138338260,"id":203451076,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ1MTA3Ng==","diff_hunk":"@@ -0,0 +1,49 @@\n+# yellowbrick.utils.timer\n+# Timer utilities\n+#\n+# Author:   ZJ Poh <poh.zijie@gmail.com>\n+# Created:  Mon Jul 16 10:51:13 2017 -0700\n+#\n+# Copyright (C) 2017 District Data Labs\n+# For license information, see LICENSE.txt\n+\"\"\"\n+Timer utilities\n+\"\"\"\n+\n+##########################################################################\n+## Imports\n+##########################################################################\n+\n+import time\n+\n+##########################################################################\n+## Timer Class\n+##########################################################################\n+\n+\n+def human_readable_time(s):\n+    h, s = divmod(s, 3600)\n+    m, s = divmod(s, 60)\n+    return \"{:>02.0f}:{:02.0f}:{:>07.4f}\".format(h, m, s)","path":"yellowbrick/utils/timer.py","position":27,"original_position":27,"commit_id":"ef9c7958c77bdb9f4be638dfd3305dc2524ed6c9","original_commit_id":"ef9c7958c77bdb9f4be638dfd3305dc2524ed6c9","user":{"login":"bbengfort","id":745966,"node_id":"MDQ6VXNlcjc0NTk2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/745966?v=4","gravatar_id":"","url":"https://api.github.com/users/bbengfort","html_url":"https://github.com/bbengfort","followers_url":"https://api.github.com/users/bbengfort/followers","following_url":"https://api.github.com/users/bbengfort/following{/other_user}","gists_url":"https://api.github.com/users/bbengfort/gists{/gist_id}","starred_url":"https://api.github.com/users/bbengfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbengfort/subscriptions","organizations_url":"https://api.github.com/users/bbengfort/orgs","repos_url":"https://api.github.com/users/bbengfort/repos","events_url":"https://api.github.com/users/bbengfort/events{/privacy}","received_events_url":"https://api.github.com/users/bbengfort/received_events","type":"User","site_admin":false},"body":"This is a great function that doesn't require the python-dateutil library; thanks! ","created_at":"2018-07-18T16:45:21Z","updated_at":"2018-07-18T16:45:58Z","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/493#discussion_r203451076","pull_request_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments/203451076"},"html":{"href":"https://github.com/DistrictDataLabs/yellowbrick/pull/493#discussion_r203451076"},"pull_request":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493"}}},"pull_request":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493","id":199643745,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjQzNzQ1","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/493","diff_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/493.diff","patch_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/493.patch","issue_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/493","number":493,"state":"open","locked":false,"title":"[WIP] Add Fit Timer Utility","user":{"login":"zjpoh","id":8103276,"node_id":"MDQ6VXNlcjgxMDMyNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8103276?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpoh","html_url":"https://github.com/zjpoh","followers_url":"https://api.github.com/users/zjpoh/followers","following_url":"https://api.github.com/users/zjpoh/following{/other_user}","gists_url":"https://api.github.com/users/zjpoh/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpoh/subscriptions","organizations_url":"https://api.github.com/users/zjpoh/orgs","repos_url":"https://api.github.com/users/zjpoh/repos","events_url":"https://api.github.com/users/zjpoh/events{/privacy}","received_events_url":"https://api.github.com/users/zjpoh/received_events","type":"User","site_admin":false},"body":"Add feature per [#439](https://github.com/DistrictDataLabs/yellowbrick/issues/439)\r\n\r\nFrom initial exploration, the only `fit_time_` that I found is in `yellowbrick.features.manifold`.\r\n\r\nA couple questions.\r\n1. Should I be adding the Timer class to `yellowbrick.utils.helpers`?\r\n1. Is it better to calculate the fit time using a context or by adding a decorator to `self.manifold.fit_transform`?\r\n\r\nFirst time contributing~ Please let me know if this makes sense.","created_at":"2018-07-06T04:42:44Z","updated_at":"2018-07-18T16:45:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ad4476f9839ea05364435e2a6bb5171bdb33f70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":378474408,"node_id":"MDU6TGFiZWwzNzg0NzQ0MDg=","url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels/ready","name":"ready","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493/commits","review_comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493/comments","review_comment_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/493/comments","statuses_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/ef9c7958c77bdb9f4be638dfd3305dc2524ed6c9","head":{"label":"zjpoh:feature/fit-timer","ref":"feature/fit-timer","sha":"ef9c7958c77bdb9f4be638dfd3305dc2524ed6c9","user":{"login":"zjpoh","id":8103276,"node_id":"MDQ6VXNlcjgxMDMyNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8103276?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpoh","html_url":"https://github.com/zjpoh","followers_url":"https://api.github.com/users/zjpoh/followers","following_url":"https://api.github.com/users/zjpoh/following{/other_user}","gists_url":"https://api.github.com/users/zjpoh/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpoh/subscriptions","organizations_url":"https://api.github.com/users/zjpoh/orgs","repos_url":"https://api.github.com/users/zjpoh/repos","events_url":"https://api.github.com/users/zjpoh/events{/privacy}","received_events_url":"https://api.github.com/users/zjpoh/received_events","type":"User","site_admin":false},"repo":{"id":139897129,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4OTcxMjk=","name":"yellowbrick","full_name":"zjpoh/yellowbrick","owner":{"login":"zjpoh","id":8103276,"node_id":"MDQ6VXNlcjgxMDMyNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8103276?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpoh","html_url":"https://github.com/zjpoh","followers_url":"https://api.github.com/users/zjpoh/followers","following_url":"https://api.github.com/users/zjpoh/following{/other_user}","gists_url":"https://api.github.com/users/zjpoh/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpoh/subscriptions","organizations_url":"https://api.github.com/users/zjpoh/orgs","repos_url":"https://api.github.com/users/zjpoh/repos","events_url":"https://api.github.com/users/zjpoh/events{/privacy}","received_events_url":"https://api.github.com/users/zjpoh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zjpoh/yellowbrick","description":"Visual analysis and diagnostic tools to facilitate machine learning model selection.","fork":true,"url":"https://api.github.com/repos/zjpoh/yellowbrick","forks_url":"https://api.github.com/repos/zjpoh/yellowbrick/forks","keys_url":"https://api.github.com/repos/zjpoh/yellowbrick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zjpoh/yellowbrick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zjpoh/yellowbrick/teams","hooks_url":"https://api.github.com/repos/zjpoh/yellowbrick/hooks","issue_events_url":"https://api.github.com/repos/zjpoh/yellowbrick/issues/events{/number}","events_url":"https://api.github.com/repos/zjpoh/yellowbrick/events","assignees_url":"https://api.github.com/repos/zjpoh/yellowbrick/assignees{/user}","branches_url":"https://api.github.com/repos/zjpoh/yellowbrick/branches{/branch}","tags_url":"https://api.github.com/repos/zjpoh/yellowbrick/tags","blobs_url":"https://api.github.com/repos/zjpoh/yellowbrick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zjpoh/yellowbrick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zjpoh/yellowbrick/git/refs{/sha}","trees_url":"https://api.github.com/repos/zjpoh/yellowbrick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zjpoh/yellowbrick/statuses/{sha}","languages_url":"https://api.github.com/repos/zjpoh/yellowbrick/languages","stargazers_url":"https://api.github.com/repos/zjpoh/yellowbrick/stargazers","contributors_url":"https://api.github.com/repos/zjpoh/yellowbrick/contributors","subscribers_url":"https://api.github.com/repos/zjpoh/yellowbrick/subscribers","subscription_url":"https://api.github.com/repos/zjpoh/yellowbrick/subscription","commits_url":"https://api.github.com/repos/zjpoh/yellowbrick/commits{/sha}","git_commits_url":"https://api.github.com/repos/zjpoh/yellowbrick/git/commits{/sha}","comments_url":"https://api.github.com/repos/zjpoh/yellowbrick/comments{/number}","issue_comment_url":"https://api.github.com/repos/zjpoh/yellowbrick/issues/comments{/number}","contents_url":"https://api.github.com/repos/zjpoh/yellowbrick/contents/{+path}","compare_url":"https://api.github.com/repos/zjpoh/yellowbrick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zjpoh/yellowbrick/merges","archive_url":"https://api.github.com/repos/zjpoh/yellowbrick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zjpoh/yellowbrick/downloads","issues_url":"https://api.github.com/repos/zjpoh/yellowbrick/issues{/number}","pulls_url":"https://api.github.com/repos/zjpoh/yellowbrick/pulls{/number}","milestones_url":"https://api.github.com/repos/zjpoh/yellowbrick/milestones{/number}","notifications_url":"https://api.github.com/repos/zjpoh/yellowbrick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zjpoh/yellowbrick/labels{/name}","releases_url":"https://api.github.com/repos/zjpoh/yellowbrick/releases{/id}","deployments_url":"https://api.github.com/repos/zjpoh/yellowbrick/deployments","created_at":"2018-07-05T20:29:32Z","updated_at":"2018-07-05T20:29:35Z","pushed_at":"2018-07-18T06:45:02Z","git_url":"git://github.com/zjpoh/yellowbrick.git","ssh_url":"git@github.com:zjpoh/yellowbrick.git","clone_url":"https://github.com/zjpoh/yellowbrick.git","svn_url":"https://github.com/zjpoh/yellowbrick","homepage":"http://www.scikit-yb.org/","size":39481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"DistrictDataLabs:develop","ref":"develop","sha":"3f6ca6d7128f30a41dbfc2e17e540cab6fe7a78a","user":{"login":"DistrictDataLabs","id":7107115,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMDcxMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7107115?v=4","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":59121694,"node_id":"MDEwOlJlcG9zaXRvcnk1OTEyMTY5NA==","name":"yellowbrick","full_name":"DistrictDataLabs/yellowbrick","owner":{"login":"DistrictDataLabs","id":7107115,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMDcxMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7107115?v=4","gravatar_id":"","url":"https://api.github.com/users/DistrictDataLabs","html_url":"https://github.com/DistrictDataLabs","followers_url":"https://api.github.com/users/DistrictDataLabs/followers","following_url":"https://api.github.com/users/DistrictDataLabs/following{/other_user}","gists_url":"https://api.github.com/users/DistrictDataLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DistrictDataLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DistrictDataLabs/subscriptions","organizations_url":"https://api.github.com/users/DistrictDataLabs/orgs","repos_url":"https://api.github.com/users/DistrictDataLabs/repos","events_url":"https://api.github.com/users/DistrictDataLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DistrictDataLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DistrictDataLabs/yellowbrick","description":"Visual analysis and diagnostic tools to facilitate machine learning model selection.","fork":false,"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick","forks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/forks","keys_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/teams","hooks_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/hooks","issue_events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/events{/number}","events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/events","assignees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/assignees{/user}","branches_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/branches{/branch}","tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/tags","blobs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/refs{/sha}","trees_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/{sha}","languages_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/languages","stargazers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/stargazers","contributors_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contributors","subscribers_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscribers","subscription_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/subscription","commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/commits{/sha}","git_commits_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/git/commits{/sha}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/comments{/number}","issue_comment_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/comments{/number}","contents_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/contents/{+path}","compare_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/merges","archive_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/downloads","issues_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues{/number}","pulls_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls{/number}","milestones_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/milestones{/number}","notifications_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/labels{/name}","releases_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/releases{/id}","deployments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/deployments","created_at":"2016-05-18T14:12:17Z","updated_at":"2018-07-18T10:11:51Z","pushed_at":"2018-07-18T06:45:02Z","git_url":"git://github.com/DistrictDataLabs/yellowbrick.git","ssh_url":"git@github.com:DistrictDataLabs/yellowbrick.git","clone_url":"https://github.com/DistrictDataLabs/yellowbrick.git","svn_url":"https://github.com/DistrictDataLabs/yellowbrick","homepage":"http://www.scikit-yb.org/","size":39282,"stargazers_count":1429,"watchers_count":1429,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":211,"open_issues":114,"watchers":1429,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493"},"html":{"href":"https://github.com/DistrictDataLabs/yellowbrick/pull/493"},"issue":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/493"},"comments":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/statuses/ef9c7958c77bdb9f4be638dfd3305dc2524ed6c9"}},"author_association":"NONE"}}
{"actor":{"display_login":"bbengfort"}}