{"action":"created","issue":{"url":"https://api.github.com/repos/srsLTE/srsLTE/issues/257","repository_url":"https://api.github.com/repos/srsLTE/srsLTE","labels_url":"https://api.github.com/repos/srsLTE/srsLTE/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/srsLTE/srsLTE/issues/257/comments","events_url":"https://api.github.com/repos/srsLTE/srsLTE/issues/257/events","html_url":"https://github.com/srsLTE/srsLTE/issues/257","id":373110438,"node_id":"MDU6SXNzdWUzNzMxMTA0Mzg=","number":257,"title":"mch_config() factory default struct has incorrect defaults for um.rx_mod and um.tx_mod","user":{"login":"JonathanRennison","id":18557289,"node_id":"MDQ6VXNlcjE4NTU3Mjg5","avatar_url":"https://avatars1.githubusercontent.com/u/18557289?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanRennison","html_url":"https://github.com/JonathanRennison","followers_url":"https://api.github.com/users/JonathanRennison/followers","following_url":"https://api.github.com/users/JonathanRennison/following{/other_user}","gists_url":"https://api.github.com/users/JonathanRennison/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanRennison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanRennison/subscriptions","organizations_url":"https://api.github.com/users/JonathanRennison/orgs","repos_url":"https://api.github.com/users/JonathanRennison/repos","events_url":"https://api.github.com/users/JonathanRennison/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanRennison/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"andrepuschmann","id":525775,"node_id":"MDQ6VXNlcjUyNTc3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/525775?v=4","gravatar_id":"","url":"https://api.github.com/users/andrepuschmann","html_url":"https://github.com/andrepuschmann","followers_url":"https://api.github.com/users/andrepuschmann/followers","following_url":"https://api.github.com/users/andrepuschmann/following{/other_user}","gists_url":"https://api.github.com/users/andrepuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepuschmann/subscriptions","organizations_url":"https://api.github.com/users/andrepuschmann/orgs","repos_url":"https://api.github.com/users/andrepuschmann/repos","events_url":"https://api.github.com/users/andrepuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/andrepuschmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrepuschmann","id":525775,"node_id":"MDQ6VXNlcjUyNTc3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/525775?v=4","gravatar_id":"","url":"https://api.github.com/users/andrepuschmann","html_url":"https://github.com/andrepuschmann","followers_url":"https://api.github.com/users/andrepuschmann/followers","following_url":"https://api.github.com/users/andrepuschmann/following{/other_user}","gists_url":"https://api.github.com/users/andrepuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepuschmann/subscriptions","organizations_url":"https://api.github.com/users/andrepuschmann/orgs","repos_url":"https://api.github.com/users/andrepuschmann/repos","events_url":"https://api.github.com/users/andrepuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/andrepuschmann/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-23T17:23:10Z","updated_at":"2018-12-17T16:41:35Z","closed_at":"2018-12-17T16:41:35Z","author_association":"NONE","body":"The `mch_config()` factory method returns a default `srslte_rlc_config_t` instance where `um.rx_mod` and `um.tx_mod` are both set to 1.\r\nThis is inconsistent with the values for `um.rx_sn_field_length` and `cfg.um.tx_sn_field_length`, which are set to RLC_UMD_SN_SIZE_5_BITS, which corresponds with a value of 32.\r\nThis prevents MCH PDU-> SDU packet reassembly in `rlc_um::rlc_um_rx::reassemble_rx_sdus` from working as a receive window of 1 is used instead of 32."},"comment":{"url":"https://api.github.com/repos/srsLTE/srsLTE/issues/comments/447911899","html_url":"https://github.com/srsLTE/srsLTE/issues/257#issuecomment-447911899","issue_url":"https://api.github.com/repos/srsLTE/srsLTE/issues/257","id":447911899,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzkxMTg5OQ==","user":{"login":"andrepuschmann","id":525775,"node_id":"MDQ6VXNlcjUyNTc3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/525775?v=4","gravatar_id":"","url":"https://api.github.com/users/andrepuschmann","html_url":"https://github.com/andrepuschmann","followers_url":"https://api.github.com/users/andrepuschmann/followers","following_url":"https://api.github.com/users/andrepuschmann/following{/other_user}","gists_url":"https://api.github.com/users/andrepuschmann/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepuschmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepuschmann/subscriptions","organizations_url":"https://api.github.com/users/andrepuschmann/orgs","repos_url":"https://api.github.com/users/andrepuschmann/repos","events_url":"https://api.github.com/users/andrepuschmann/events{/privacy}","received_events_url":"https://api.github.com/users/andrepuschmann/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T16:41:35Z","updated_at":"2018-12-17T16:41:35Z","author_association":"MEMBER","body":"Fixed in next. "}}
{"actor":{"display_login":"andrepuschmann"}}