{"action":"created","issue":{"url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/572","repository_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema","labels_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/572/labels{/name}","comments_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/572/comments","events_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/572/events","html_url":"https://github.com/HumanCellAtlas/metadata-schema/issues/572","id":366811384,"node_id":"MDU6SXNzdWUzNjY4MTEzODQ=","number":572,"title":"Add protocol_type field to imaging_protocol.json","user":{"login":"hewgreen","id":23357242,"node_id":"MDQ6VXNlcjIzMzU3MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/23357242?v=4","gravatar_id":"","url":"https://api.github.com/users/hewgreen","html_url":"https://github.com/hewgreen","followers_url":"https://api.github.com/users/hewgreen/followers","following_url":"https://api.github.com/users/hewgreen/following{/other_user}","gists_url":"https://api.github.com/users/hewgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/hewgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewgreen/subscriptions","organizations_url":"https://api.github.com/users/hewgreen/orgs","repos_url":"https://api.github.com/users/hewgreen/repos","events_url":"https://api.github.com/users/hewgreen/events{/privacy}","received_events_url":"https://api.github.com/users/hewgreen/received_events","type":"User","site_admin":false},"labels":[{"id":683104172,"node_id":"MDU6TGFiZWw2ODMxMDQxNzI=","url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/labels/bug","name":"bug","color":"ee0701","default":true},{"id":757956924,"node_id":"MDU6TGFiZWw3NTc5NTY5MjQ=","url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/labels/content","name":"content","color":"9e0135","default":false}],"state":"open","locked":false,"assignee":{"login":"dosumis","id":112839,"node_id":"MDQ6VXNlcjExMjgzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/112839?v=4","gravatar_id":"","url":"https://api.github.com/users/dosumis","html_url":"https://github.com/dosumis","followers_url":"https://api.github.com/users/dosumis/followers","following_url":"https://api.github.com/users/dosumis/following{/other_user}","gists_url":"https://api.github.com/users/dosumis/gists{/gist_id}","starred_url":"https://api.github.com/users/dosumis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosumis/subscriptions","organizations_url":"https://api.github.com/users/dosumis/orgs","repos_url":"https://api.github.com/users/dosumis/repos","events_url":"https://api.github.com/users/dosumis/events{/privacy}","received_events_url":"https://api.github.com/users/dosumis/received_events","type":"User","site_admin":false},"assignees":[{"login":"dosumis","id":112839,"node_id":"MDQ6VXNlcjExMjgzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/112839?v=4","gravatar_id":"","url":"https://api.github.com/users/dosumis","html_url":"https://github.com/dosumis","followers_url":"https://api.github.com/users/dosumis/followers","following_url":"https://api.github.com/users/dosumis/following{/other_user}","gists_url":"https://api.github.com/users/dosumis/gists{/gist_id}","starred_url":"https://api.github.com/users/dosumis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosumis/subscriptions","organizations_url":"https://api.github.com/users/dosumis/orgs","repos_url":"https://api.github.com/users/dosumis/repos","events_url":"https://api.github.com/users/dosumis/events{/privacy}","received_events_url":"https://api.github.com/users/dosumis/received_events","type":"User","site_admin":false},{"login":"zperova","id":38244059,"node_id":"MDQ6VXNlcjM4MjQ0MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/38244059?v=4","gravatar_id":"","url":"https://api.github.com/users/zperova","html_url":"https://github.com/zperova","followers_url":"https://api.github.com/users/zperova/followers","following_url":"https://api.github.com/users/zperova/following{/other_user}","gists_url":"https://api.github.com/users/zperova/gists{/gist_id}","starred_url":"https://api.github.com/users/zperova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zperova/subscriptions","organizations_url":"https://api.github.com/users/zperova/orgs","repos_url":"https://api.github.com/users/zperova/repos","events_url":"https://api.github.com/users/zperova/events{/privacy}","received_events_url":"https://api.github.com/users/zperova/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-04T14:14:28Z","updated_at":"2018-10-09T15:59:56Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Give the bug a title**\r\n\r\nprotocol_type is a required field but the field is not in the schema. Worryingly this passed validation.\r\n\r\nWe either need to remove this from the required fields list or add the field.\r\n\r\n**Schema versions**\r\n\r\nimaging_protocol.json\r\n\r\n**Expected behavior**\r\n\r\nIs protocol_type a duplication of assay_type? We record assay type for each target.\r\n\r\n        \"assay_type\": {\r\n            \"description\": \"Type of assay used to detect target.\",\r\n            \"type\": \"object\",\r\n            \"$ref\": \"module/ontology/process_type_ontology.json\",\r\n            \"example\": \"MERFISH, smFISH, immunofluorescence, fluorescent cell stain\",\r\n            \"user_friendly\": \"Assay type\"\r\n        },\r\n\r\nAs we have this do we need protocol_type at the level of imaging_protocol.json?\r\n"},"comment":{"url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/comments/428249975","html_url":"https://github.com/HumanCellAtlas/metadata-schema/issues/572#issuecomment-428249975","issue_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/572","id":428249975,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI0OTk3NQ==","user":{"login":"hewgreen","id":23357242,"node_id":"MDQ6VXNlcjIzMzU3MjQy","avatar_url":"https://avatars0.githubusercontent.com/u/23357242?v=4","gravatar_id":"","url":"https://api.github.com/users/hewgreen","html_url":"https://github.com/hewgreen","followers_url":"https://api.github.com/users/hewgreen/followers","following_url":"https://api.github.com/users/hewgreen/following{/other_user}","gists_url":"https://api.github.com/users/hewgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/hewgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewgreen/subscriptions","organizations_url":"https://api.github.com/users/hewgreen/orgs","repos_url":"https://api.github.com/users/hewgreen/repos","events_url":"https://api.github.com/users/hewgreen/events{/privacy}","received_events_url":"https://api.github.com/users/hewgreen/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T15:59:56Z","updated_at":"2018-10-09T15:59:56Z","author_association":"CONTRIBUTOR","body":"I agree remove it. This is a bad way to describe what I presume it was anyway and capturing this at a more granular level is likely to be better."}}
{"actor":{"display_login":"hewgreen"}}