{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/comments/238618030","pull_request_review_id":181201245,"id":238618030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODYxODAzMA==","diff_hunk":"@@ -92,13 +92,14 @@ RUN \\\n     apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*\n \n # install required python packages from file\n-COPY pydeps.txt /tmp/pydeps.txt\n-COPY pypkgs.txt /tmp/pypkgs.txt\n+COPY deps_requirements.txt /tmp/deps_requirements.txt","path":"Dockerfile","position":20,"original_position":6,"commit_id":"e89b94e2954f681a9bdb087ced0784752058b06b","original_commit_id":"e89b94e2954f681a9bdb087ced0784752058b06b","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"@kaspar030 good suggestions!","created_at":"2018-12-04T11:07:58Z","updated_at":"2018-12-04T11:07:58Z","html_url":"https://github.com/RIOT-OS/riotdocker/pull/56#discussion_r238618030","pull_request_url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/comments/238618030"},"html":{"href":"https://github.com/RIOT-OS/riotdocker/pull/56#discussion_r238618030"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56"}},"in_reply_to_id":238612565},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56","id":221722016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzIyMDE2","html_url":"https://github.com/RIOT-OS/riotdocker/pull/56","diff_url":"https://github.com/RIOT-OS/riotdocker/pull/56.diff","patch_url":"https://github.com/RIOT-OS/riotdocker/pull/56.patch","issue_url":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/56","number":56,"state":"open","locked":false,"title":"use python pip to install required packages","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"This changes the install procedure for python packages from using APT packages to use python-pip and install packages from a file. This has several advantages:\r\n\r\n- not all pythons deps for RIOT are available as APT packages (see Murdocks `dwq` for instance)\r\n- installing from file makes dependencies more explicit\r\n- and also allows to specify (and fix) package version (if needed)\r\n","created_at":"2018-10-10T09:41:01Z","updated_at":"2018-12-04T11:07:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac3b3c93dacc90dc2a1bef3f9e8e4ce180c6e7a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gebart","id":317506,"node_id":"MDQ6VXNlcjMxNzUwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/317506?v=4","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":190515348,"node_id":"MDU6TGFiZWwxOTA1MTUzNDg=","url":"https://api.github.com/repos/RIOT-OS/riotdocker/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/56/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/riotdocker/statuses/e89b94e2954f681a9bdb087ced0784752058b06b","head":{"label":"smlng:pr/pip3","ref":"pr/pip3","sha":"e89b94e2954f681a9bdb087ced0784752058b06b","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"repo":{"id":117080769,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwODA3Njk=","name":"riotdocker","full_name":"smlng/riotdocker","private":false,"owner":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smlng/riotdocker","description":"Fork of riotdocker for Murdock build slaves","fork":true,"url":"https://api.github.com/repos/smlng/riotdocker","forks_url":"https://api.github.com/repos/smlng/riotdocker/forks","keys_url":"https://api.github.com/repos/smlng/riotdocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smlng/riotdocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smlng/riotdocker/teams","hooks_url":"https://api.github.com/repos/smlng/riotdocker/hooks","issue_events_url":"https://api.github.com/repos/smlng/riotdocker/issues/events{/number}","events_url":"https://api.github.com/repos/smlng/riotdocker/events","assignees_url":"https://api.github.com/repos/smlng/riotdocker/assignees{/user}","branches_url":"https://api.github.com/repos/smlng/riotdocker/branches{/branch}","tags_url":"https://api.github.com/repos/smlng/riotdocker/tags","blobs_url":"https://api.github.com/repos/smlng/riotdocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smlng/riotdocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smlng/riotdocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/smlng/riotdocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smlng/riotdocker/statuses/{sha}","languages_url":"https://api.github.com/repos/smlng/riotdocker/languages","stargazers_url":"https://api.github.com/repos/smlng/riotdocker/stargazers","contributors_url":"https://api.github.com/repos/smlng/riotdocker/contributors","subscribers_url":"https://api.github.com/repos/smlng/riotdocker/subscribers","subscription_url":"https://api.github.com/repos/smlng/riotdocker/subscription","commits_url":"https://api.github.com/repos/smlng/riotdocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/smlng/riotdocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/smlng/riotdocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/smlng/riotdocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/smlng/riotdocker/contents/{+path}","compare_url":"https://api.github.com/repos/smlng/riotdocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smlng/riotdocker/merges","archive_url":"https://api.github.com/repos/smlng/riotdocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smlng/riotdocker/downloads","issues_url":"https://api.github.com/repos/smlng/riotdocker/issues{/number}","pulls_url":"https://api.github.com/repos/smlng/riotdocker/pulls{/number}","milestones_url":"https://api.github.com/repos/smlng/riotdocker/milestones{/number}","notifications_url":"https://api.github.com/repos/smlng/riotdocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smlng/riotdocker/labels{/name}","releases_url":"https://api.github.com/repos/smlng/riotdocker/releases{/id}","deployments_url":"https://api.github.com/repos/smlng/riotdocker/deployments","created_at":"2018-01-11T09:45:22Z","updated_at":"2018-12-04T09:19:44Z","pushed_at":"2018-12-04T10:03:27Z","git_url":"git://github.com/smlng/riotdocker.git","ssh_url":"git@github.com:smlng/riotdocker.git","clone_url":"https://github.com/smlng/riotdocker.git","svn_url":"https://github.com/smlng/riotdocker","homepage":"","size":94,"stargazers_count":0,"watchers_count":0,"language":"Dockerfile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"97c77bd8fe9f7e63d0ac4f2f1fd4357e779ab5fb","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":32677832,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY3NzgzMg==","name":"riotdocker","full_name":"RIOT-OS/riotdocker","private":false,"owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RIOT-OS/riotdocker","description":"Dockerfiles for creating build environment for building RIOT projects. ","fork":false,"url":"https://api.github.com/repos/RIOT-OS/riotdocker","forks_url":"https://api.github.com/repos/RIOT-OS/riotdocker/forks","keys_url":"https://api.github.com/repos/RIOT-OS/riotdocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/riotdocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/riotdocker/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/riotdocker/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/riotdocker/events","assignees_url":"https://api.github.com/repos/RIOT-OS/riotdocker/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/riotdocker/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/riotdocker/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/riotdocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/riotdocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/riotdocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/riotdocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/riotdocker/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/riotdocker/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/riotdocker/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/riotdocker/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/riotdocker/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/riotdocker/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/riotdocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/riotdocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/riotdocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/riotdocker/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/riotdocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/riotdocker/merges","archive_url":"https://api.github.com/repos/RIOT-OS/riotdocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/riotdocker/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/riotdocker/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/riotdocker/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/riotdocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/riotdocker/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/riotdocker/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/riotdocker/deployments","created_at":"2015-03-22T14:00:18Z","updated_at":"2018-11-28T17:54:08Z","pushed_at":"2018-12-04T10:03:28Z","git_url":"git://github.com/RIOT-OS/riotdocker.git","ssh_url":"git@github.com:RIOT-OS/riotdocker.git","clone_url":"https://github.com/RIOT-OS/riotdocker.git","svn_url":"https://github.com/RIOT-OS/riotdocker","homepage":"","size":76,"stargazers_count":18,"watchers_count":18,"language":"Dockerfile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":27,"open_issues":8,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56"},"html":{"href":"https://github.com/RIOT-OS/riotdocker/pull/56"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/56"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/riotdocker/statuses/e89b94e2954f681a9bdb087ced0784752058b06b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smlng"}}