{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/221106608","pull_request_review_id":159676957,"id":221106608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTEwNjYwOA==","diff_hunk":"@@ -123,9 +124,16 @@ public void init() {\n             IOUtils.copy(attachmentInfo.getStream(), temporaryFileBackedOutputStream);\n \n             for (Splitter splitter : lookupSplitters(attachmentInfo.getContentType())) {\n-              if (attemptToSplitAndStore(\n-                  response, listType, attachmentInfo, temporaryFileBackedOutputStream, splitter))\n-                break;\n+              try {\n+                if (attemptToSplitAndStore(\n+                    response, listType, attachmentInfo, temporaryFileBackedOutputStream, splitter))\n+                  break;\n+              } catch (StopSplitterExecutionException e) {","path":"catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/metacard/ListApplication.java","position":19,"original_position":19,"commit_id":"75140cfa00876afe128c0d93f16c1428677fec90","original_commit_id":"75140cfa00876afe128c0d93f16c1428677fec90","user":{"login":"paouelle","id":10549555,"node_id":"MDQ6VXNlcjEwNTQ5NTU1","avatar_url":"https://avatars0.githubusercontent.com/u/10549555?v=4","gravatar_id":"","url":"https://api.github.com/users/paouelle","html_url":"https://github.com/paouelle","followers_url":"https://api.github.com/users/paouelle/followers","following_url":"https://api.github.com/users/paouelle/following{/other_user}","gists_url":"https://api.github.com/users/paouelle/gists{/gist_id}","starred_url":"https://api.github.com/users/paouelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paouelle/subscriptions","organizations_url":"https://api.github.com/users/paouelle/orgs","repos_url":"https://api.github.com/users/paouelle/repos","events_url":"https://api.github.com/users/paouelle/events{/privacy}","received_events_url":"https://api.github.com/users/paouelle/received_events","type":"User","site_admin":false},"body":"❗️ Although caught here and documented as a throws clause in other methods, I do not see anywhere it would actually be thrown.","created_at":"2018-09-27T23:29:22Z","updated_at":"2018-09-27T23:29:29Z","html_url":"https://github.com/codice/ddf/pull/3815#discussion_r221106608","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3815","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/221106608"},"html":{"href":"https://github.com/codice/ddf/pull/3815#discussion_r221106608"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3815"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3815","id":218805433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODA1NDMz","html_url":"https://github.com/codice/ddf/pull/3815","diff_url":"https://github.com/codice/ddf/pull/3815.diff","patch_url":"https://github.com/codice/ddf/pull/3815.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3815","number":3815,"state":"open","locked":false,"title":"DDF-4185 Allow custom stopping of execution for uploading lists","user":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nCreate a new exception to allow early termination of parsing through zip files and other relevant mime types when uploading certain files into a list.\r\n\r\n#### Who is reviewing it? \r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n@Bdthomson \r\n@middlets719 \r\n@Schachte \r\n@gordocanchola \r\n@adimka \r\n\r\n#### Select relevant component teams: \r\nhttps://github.com/orgs/codice/teams\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@bdeining \r\n@rzwiefel\r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\nFull build and check if uploading files into a list works as normal.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nhttps://codice.atlassian.net/browse/DDF-4185\r\n\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-09-27T22:22:31Z","updated_at":"2018-09-27T23:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f17d416f56a15f2c5baba99dff633e7723178b2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3815/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3815/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3815/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/75140cfa00876afe128c0d93f16c1428677fec90","head":{"label":"cantstoptheunk:DDF-4185","ref":"DDF-4185","sha":"75140cfa00876afe128c0d93f16c1428677fec90","user":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"repo":{"id":136080288,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODAyODg=","name":"ddf","full_name":"cantstoptheunk/ddf","private":false,"owner":{"login":"cantstoptheunk","id":23177404,"node_id":"MDQ6VXNlcjIzMTc3NDA0","avatar_url":"https://avatars3.githubusercontent.com/u/23177404?v=4","gravatar_id":"","url":"https://api.github.com/users/cantstoptheunk","html_url":"https://github.com/cantstoptheunk","followers_url":"https://api.github.com/users/cantstoptheunk/followers","following_url":"https://api.github.com/users/cantstoptheunk/following{/other_user}","gists_url":"https://api.github.com/users/cantstoptheunk/gists{/gist_id}","starred_url":"https://api.github.com/users/cantstoptheunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantstoptheunk/subscriptions","organizations_url":"https://api.github.com/users/cantstoptheunk/orgs","repos_url":"https://api.github.com/users/cantstoptheunk/repos","events_url":"https://api.github.com/users/cantstoptheunk/events{/privacy}","received_events_url":"https://api.github.com/users/cantstoptheunk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cantstoptheunk/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/cantstoptheunk/ddf","forks_url":"https://api.github.com/repos/cantstoptheunk/ddf/forks","keys_url":"https://api.github.com/repos/cantstoptheunk/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cantstoptheunk/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cantstoptheunk/ddf/teams","hooks_url":"https://api.github.com/repos/cantstoptheunk/ddf/hooks","issue_events_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/cantstoptheunk/ddf/events","assignees_url":"https://api.github.com/repos/cantstoptheunk/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/cantstoptheunk/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/cantstoptheunk/ddf/tags","blobs_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cantstoptheunk/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/cantstoptheunk/ddf/languages","stargazers_url":"https://api.github.com/repos/cantstoptheunk/ddf/stargazers","contributors_url":"https://api.github.com/repos/cantstoptheunk/ddf/contributors","subscribers_url":"https://api.github.com/repos/cantstoptheunk/ddf/subscribers","subscription_url":"https://api.github.com/repos/cantstoptheunk/ddf/subscription","commits_url":"https://api.github.com/repos/cantstoptheunk/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/cantstoptheunk/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/cantstoptheunk/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/cantstoptheunk/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/cantstoptheunk/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cantstoptheunk/ddf/merges","archive_url":"https://api.github.com/repos/cantstoptheunk/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cantstoptheunk/ddf/downloads","issues_url":"https://api.github.com/repos/cantstoptheunk/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/cantstoptheunk/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/cantstoptheunk/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/cantstoptheunk/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cantstoptheunk/ddf/labels{/name}","releases_url":"https://api.github.com/repos/cantstoptheunk/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/cantstoptheunk/ddf/deployments","created_at":"2018-06-04T20:41:45Z","updated_at":"2018-09-27T22:57:26Z","pushed_at":"2018-09-27T22:57:24Z","git_url":"git://github.com/cantstoptheunk/ddf.git","ssh_url":"git@github.com:cantstoptheunk/ddf.git","clone_url":"https://github.com/cantstoptheunk/ddf.git","svn_url":"https://github.com/cantstoptheunk/ddf","homepage":"http://ddf.codice.org","size":395316,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"3bdce2a77c02e77c8441ae53557abd5b37767cb7","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-09-27T22:39:50Z","pushed_at":"2018-09-27T22:47:12Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":405106,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":154,"open_issues":47,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3815"},"html":{"href":"https://github.com/codice/ddf/pull/3815"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3815"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3815/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3815/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3815/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/75140cfa00876afe128c0d93f16c1428677fec90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paouelle"}}