{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/lbann/pulls/comments/238049995","pull_request_review_id":180507999,"id":238049995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA0OTk5NQ==","diff_hunk":"@@ -130,7 +130,8 @@ void numpy_reader::load() {\n   select_subset_of_data();\n }\n \n-bool numpy_reader::fetch_datum(Mat& X, int data_id, int mb_idx, int tid) {\n+bool numpy_reader::fetch_datum(Mat& X, int data_id, int mb_idx, thread_pool& io_thread_pool) {\n+  //  int tid = io_thread_pool.get_local_thread_id();","path":"src/data_readers/data_reader_numpy.cpp","position":6,"original_position":6,"commit_id":"c35ed3223da4707cf7f53eec1930c24bb5c1f0cb","original_commit_id":"c35ed3223da4707cf7f53eec1930c24bb5c1f0cb","user":{"login":"ndryden","id":1119788,"node_id":"MDQ6VXNlcjExMTk3ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/1119788?v=4","gravatar_id":"","url":"https://api.github.com/users/ndryden","html_url":"https://github.com/ndryden","followers_url":"https://api.github.com/users/ndryden/followers","following_url":"https://api.github.com/users/ndryden/following{/other_user}","gists_url":"https://api.github.com/users/ndryden/gists{/gist_id}","starred_url":"https://api.github.com/users/ndryden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndryden/subscriptions","organizations_url":"https://api.github.com/users/ndryden/orgs","repos_url":"https://api.github.com/users/ndryden/repos","events_url":"https://api.github.com/users/ndryden/events{/privacy}","received_events_url":"https://api.github.com/users/ndryden/received_events","type":"User","site_admin":false},"body":"Ditto.","created_at":"2018-12-01T03:07:46Z","updated_at":"2018-12-01T03:14:06Z","html_url":"https://github.com/LLNL/lbann/pull/415#discussion_r238049995","pull_request_url":"https://api.github.com/repos/LLNL/lbann/pulls/415","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/comments/238049995"},"html":{"href":"https://github.com/LLNL/lbann/pull/415#discussion_r238049995"},"pull_request":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/lbann/pulls/415","id":194046338,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDQ2MzM4","html_url":"https://github.com/LLNL/lbann/pull/415","diff_url":"https://github.com/LLNL/lbann/pull/415.diff","patch_url":"https://github.com/LLNL/lbann/pull/415.patch","issue_url":"https://api.github.com/repos/LLNL/lbann/issues/415","number":415,"state":"open","locked":false,"title":"Feature asynch io layers","user":{"login":"bvanessen","id":6210171,"node_id":"MDQ6VXNlcjYyMTAxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6210171?v=4","gravatar_id":"","url":"https://api.github.com/users/bvanessen","html_url":"https://github.com/bvanessen","followers_url":"https://api.github.com/users/bvanessen/followers","following_url":"https://api.github.com/users/bvanessen/following{/other_user}","gists_url":"https://api.github.com/users/bvanessen/gists{/gist_id}","starred_url":"https://api.github.com/users/bvanessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvanessen/subscriptions","organizations_url":"https://api.github.com/users/bvanessen/orgs","repos_url":"https://api.github.com/users/bvanessen/repos","events_url":"https://api.github.com/users/bvanessen/events{/privacy}","received_events_url":"https://api.github.com/users/bvanessen/received_events","type":"User","site_admin":false},"body":"Add support for double buffering in the I/O layers and fetching data asynchronously.","created_at":"2018-06-11T17:11:56Z","updated_at":"2018-12-01T03:14:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"464cee4b95bdca8525d63fdd54ef7821a7dbcc4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":374636004,"node_id":"MDU6TGFiZWwzNzQ2MzYwMDQ=","url":"https://api.github.com/repos/LLNL/lbann/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":808127874,"node_id":"MDU6TGFiZWw4MDgxMjc4NzQ=","url":"https://api.github.com/repos/LLNL/lbann/labels/in%20progress","name":"in progress","color":"d88d61","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/lbann/pulls/415/commits","review_comments_url":"https://api.github.com/repos/LLNL/lbann/pulls/415/comments","review_comment_url":"https://api.github.com/repos/LLNL/lbann/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/lbann/issues/415/comments","statuses_url":"https://api.github.com/repos/LLNL/lbann/statuses/c35ed3223da4707cf7f53eec1930c24bb5c1f0cb","head":{"label":"bvanessen:feature-asynch-io-layers","ref":"feature-asynch-io-layers","sha":"c35ed3223da4707cf7f53eec1930c24bb5c1f0cb","user":{"login":"bvanessen","id":6210171,"node_id":"MDQ6VXNlcjYyMTAxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6210171?v=4","gravatar_id":"","url":"https://api.github.com/users/bvanessen","html_url":"https://github.com/bvanessen","followers_url":"https://api.github.com/users/bvanessen/followers","following_url":"https://api.github.com/users/bvanessen/following{/other_user}","gists_url":"https://api.github.com/users/bvanessen/gists{/gist_id}","starred_url":"https://api.github.com/users/bvanessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvanessen/subscriptions","organizations_url":"https://api.github.com/users/bvanessen/orgs","repos_url":"https://api.github.com/users/bvanessen/repos","events_url":"https://api.github.com/users/bvanessen/events{/privacy}","received_events_url":"https://api.github.com/users/bvanessen/received_events","type":"User","site_admin":false},"repo":{"id":108304421,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMDQ0MjE=","name":"lbann","full_name":"bvanessen/lbann","private":false,"owner":{"login":"bvanessen","id":6210171,"node_id":"MDQ6VXNlcjYyMTAxNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6210171?v=4","gravatar_id":"","url":"https://api.github.com/users/bvanessen","html_url":"https://github.com/bvanessen","followers_url":"https://api.github.com/users/bvanessen/followers","following_url":"https://api.github.com/users/bvanessen/following{/other_user}","gists_url":"https://api.github.com/users/bvanessen/gists{/gist_id}","starred_url":"https://api.github.com/users/bvanessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvanessen/subscriptions","organizations_url":"https://api.github.com/users/bvanessen/orgs","repos_url":"https://api.github.com/users/bvanessen/repos","events_url":"https://api.github.com/users/bvanessen/events{/privacy}","received_events_url":"https://api.github.com/users/bvanessen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bvanessen/lbann","description":"Livermore Big Artificial Neural Network Toolkit","fork":true,"url":"https://api.github.com/repos/bvanessen/lbann","forks_url":"https://api.github.com/repos/bvanessen/lbann/forks","keys_url":"https://api.github.com/repos/bvanessen/lbann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvanessen/lbann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvanessen/lbann/teams","hooks_url":"https://api.github.com/repos/bvanessen/lbann/hooks","issue_events_url":"https://api.github.com/repos/bvanessen/lbann/issues/events{/number}","events_url":"https://api.github.com/repos/bvanessen/lbann/events","assignees_url":"https://api.github.com/repos/bvanessen/lbann/assignees{/user}","branches_url":"https://api.github.com/repos/bvanessen/lbann/branches{/branch}","tags_url":"https://api.github.com/repos/bvanessen/lbann/tags","blobs_url":"https://api.github.com/repos/bvanessen/lbann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvanessen/lbann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvanessen/lbann/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvanessen/lbann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvanessen/lbann/statuses/{sha}","languages_url":"https://api.github.com/repos/bvanessen/lbann/languages","stargazers_url":"https://api.github.com/repos/bvanessen/lbann/stargazers","contributors_url":"https://api.github.com/repos/bvanessen/lbann/contributors","subscribers_url":"https://api.github.com/repos/bvanessen/lbann/subscribers","subscription_url":"https://api.github.com/repos/bvanessen/lbann/subscription","commits_url":"https://api.github.com/repos/bvanessen/lbann/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvanessen/lbann/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvanessen/lbann/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvanessen/lbann/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvanessen/lbann/contents/{+path}","compare_url":"https://api.github.com/repos/bvanessen/lbann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvanessen/lbann/merges","archive_url":"https://api.github.com/repos/bvanessen/lbann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvanessen/lbann/downloads","issues_url":"https://api.github.com/repos/bvanessen/lbann/issues{/number}","pulls_url":"https://api.github.com/repos/bvanessen/lbann/pulls{/number}","milestones_url":"https://api.github.com/repos/bvanessen/lbann/milestones{/number}","notifications_url":"https://api.github.com/repos/bvanessen/lbann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvanessen/lbann/labels{/name}","releases_url":"https://api.github.com/repos/bvanessen/lbann/releases{/id}","deployments_url":"https://api.github.com/repos/bvanessen/lbann/deployments","created_at":"2017-10-25T17:45:12Z","updated_at":"2018-11-21T23:41:19Z","pushed_at":"2018-11-30T22:18:53Z","git_url":"git://github.com/bvanessen/lbann.git","ssh_url":"git@github.com:bvanessen/lbann.git","clone_url":"https://github.com/bvanessen/lbann.git","svn_url":"https://github.com/bvanessen/lbann","homepage":"http://software.llnl.gov/lbann/","size":13358,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"7112d57ba94e299ac6d058dddc7b58a3b2309993","user":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":58576874,"node_id":"MDEwOlJlcG9zaXRvcnk1ODU3Njg3NA==","name":"lbann","full_name":"LLNL/lbann","private":false,"owner":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LLNL/lbann","description":"Livermore Big Artificial Neural Network Toolkit","fork":false,"url":"https://api.github.com/repos/LLNL/lbann","forks_url":"https://api.github.com/repos/LLNL/lbann/forks","keys_url":"https://api.github.com/repos/LLNL/lbann/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/lbann/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/lbann/teams","hooks_url":"https://api.github.com/repos/LLNL/lbann/hooks","issue_events_url":"https://api.github.com/repos/LLNL/lbann/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/lbann/events","assignees_url":"https://api.github.com/repos/LLNL/lbann/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/lbann/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/lbann/tags","blobs_url":"https://api.github.com/repos/LLNL/lbann/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/lbann/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/lbann/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/lbann/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/lbann/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/lbann/languages","stargazers_url":"https://api.github.com/repos/LLNL/lbann/stargazers","contributors_url":"https://api.github.com/repos/LLNL/lbann/contributors","subscribers_url":"https://api.github.com/repos/LLNL/lbann/subscribers","subscription_url":"https://api.github.com/repos/LLNL/lbann/subscription","commits_url":"https://api.github.com/repos/LLNL/lbann/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/lbann/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/lbann/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/lbann/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/lbann/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/lbann/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/lbann/merges","archive_url":"https://api.github.com/repos/LLNL/lbann/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/lbann/downloads","issues_url":"https://api.github.com/repos/LLNL/lbann/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/lbann/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/lbann/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/lbann/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/lbann/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/lbann/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/lbann/deployments","created_at":"2016-05-11T20:04:20Z","updated_at":"2018-12-01T02:00:52Z","pushed_at":"2018-12-01T02:00:47Z","git_url":"git://github.com/LLNL/lbann.git","ssh_url":"git@github.com:LLNL/lbann.git","clone_url":"https://github.com/LLNL/lbann.git","svn_url":"https://github.com/LLNL/lbann","homepage":"http://software.llnl.gov/lbann/","size":13232,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":80,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/415"},"html":{"href":"https://github.com/LLNL/lbann/pull/415"},"issue":{"href":"https://api.github.com/repos/LLNL/lbann/issues/415"},"comments":{"href":"https://api.github.com/repos/LLNL/lbann/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/lbann/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/lbann/statuses/c35ed3223da4707cf7f53eec1930c24bb5c1f0cb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ndryden"}}