{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/217645811","pull_request_review_id":155408652,"id":217645811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY0NTgxMQ==","diff_hunk":"@@ -1662,11 +1662,8 @@ def _cleanse_time_partitioning(destination_dataset_table, time_partitioning_in):\n \n     time_partitioning_out = {}\n     if destination_dataset_table and '$' in destination_dataset_table:\n-        if time_partitioning_in.get('field'):\n-            raise ValueError(\n-                \"Cannot specify field partition and partition name\"\n-                \"(dataset.table$partition) at the same time\")\n-        time_partitioning_out['type'] = 'DAY'\n+        if not time_partitioning_in.get('field') and not time_partitioning_in.get(\"type\"):","path":"airflow/contrib/hooks/bigquery_hook.py","position":9,"original_position":9,"commit_id":"e2ce862fff06817b828d74277b690e2b6763da47","original_commit_id":"e2ce862fff06817b828d74277b690e2b6763da47","user":{"login":"kaxil","id":8811558,"node_id":"MDQ6VXNlcjg4MTE1NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/8811558?v=4","gravatar_id":"","url":"https://api.github.com/users/kaxil","html_url":"https://github.com/kaxil","followers_url":"https://api.github.com/users/kaxil/followers","following_url":"https://api.github.com/users/kaxil/following{/other_user}","gists_url":"https://api.github.com/users/kaxil/gists{/gist_id}","starred_url":"https://api.github.com/users/kaxil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaxil/subscriptions","organizations_url":"https://api.github.com/users/kaxil/orgs","repos_url":"https://api.github.com/users/kaxil/repos","events_url":"https://api.github.com/users/kaxil/events{/privacy}","received_events_url":"https://api.github.com/users/kaxil/received_events","type":"User","site_admin":false},"body":"Also update this https://github.com/apache/incubator-airflow/blob/7d60d2686d40342255a5e326f31d3cc42c72a68b/airflow/contrib/hooks/bigquery_hook.py#L566\r\n\r\n","created_at":"2018-09-14T09:00:14Z","updated_at":"2018-09-14T09:00:14Z","html_url":"https://github.com/apache/incubator-airflow/pull/3901#discussion_r217645811","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/217645811"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3901#discussion_r217645811"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901"}},"in_reply_to_id":217645701},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901","id":215524540,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTI0NTQw","html_url":"https://github.com/apache/incubator-airflow/pull/3901","diff_url":"https://github.com/apache/incubator-airflow/pull/3901.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3901.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3901","number":3901,"state":"open","locked":false,"title":"[AIRFLOW-2772] BigQuery hook allow specifying both the partition fiel…","user":{"login":"xnuinside","id":15959809,"node_id":"MDQ6VXNlcjE1OTU5ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/15959809?v=4","gravatar_id":"","url":"https://api.github.com/users/xnuinside","html_url":"https://github.com/xnuinside","followers_url":"https://api.github.com/users/xnuinside/followers","following_url":"https://api.github.com/users/xnuinside/following{/other_user}","gists_url":"https://api.github.com/users/xnuinside/gists{/gist_id}","starred_url":"https://api.github.com/users/xnuinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnuinside/subscriptions","organizations_url":"https://api.github.com/users/xnuinside/orgs","repos_url":"https://api.github.com/users/xnuinside/repos","events_url":"https://api.github.com/users/xnuinside/events{/privacy}","received_events_url":"https://api.github.com/users/xnuinside/received_events","type":"User","site_admin":false},"body":"…d name and table name with $\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-2772\r\n  - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n\r\n### Description\r\n\r\n- [ ] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\n### Tests\r\n\r\n- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n### Commits\r\n\r\n- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [ ] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [ ] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n","created_at":"2018-09-14T08:52:38Z","updated_at":"2018-09-14T09:00:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e7e8913a7b23a6cbbd1f0ffe4d4ca9a2b5544fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3901/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/e2ce862fff06817b828d74277b690e2b6763da47","head":{"label":"xnuinside:AIRFLOW-2772","ref":"AIRFLOW-2772","sha":"e2ce862fff06817b828d74277b690e2b6763da47","user":{"login":"xnuinside","id":15959809,"node_id":"MDQ6VXNlcjE1OTU5ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/15959809?v=4","gravatar_id":"","url":"https://api.github.com/users/xnuinside","html_url":"https://github.com/xnuinside","followers_url":"https://api.github.com/users/xnuinside/followers","following_url":"https://api.github.com/users/xnuinside/following{/other_user}","gists_url":"https://api.github.com/users/xnuinside/gists{/gist_id}","starred_url":"https://api.github.com/users/xnuinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnuinside/subscriptions","organizations_url":"https://api.github.com/users/xnuinside/orgs","repos_url":"https://api.github.com/users/xnuinside/repos","events_url":"https://api.github.com/users/xnuinside/events{/privacy}","received_events_url":"https://api.github.com/users/xnuinside/received_events","type":"User","site_admin":false},"repo":{"id":144283591,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyODM1OTE=","name":"incubator-airflow","full_name":"xnuinside/incubator-airflow","owner":{"login":"xnuinside","id":15959809,"node_id":"MDQ6VXNlcjE1OTU5ODA5","avatar_url":"https://avatars1.githubusercontent.com/u/15959809?v=4","gravatar_id":"","url":"https://api.github.com/users/xnuinside","html_url":"https://github.com/xnuinside","followers_url":"https://api.github.com/users/xnuinside/followers","following_url":"https://api.github.com/users/xnuinside/following{/other_user}","gists_url":"https://api.github.com/users/xnuinside/gists{/gist_id}","starred_url":"https://api.github.com/users/xnuinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnuinside/subscriptions","organizations_url":"https://api.github.com/users/xnuinside/orgs","repos_url":"https://api.github.com/users/xnuinside/repos","events_url":"https://api.github.com/users/xnuinside/events{/privacy}","received_events_url":"https://api.github.com/users/xnuinside/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xnuinside/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/xnuinside/incubator-airflow","forks_url":"https://api.github.com/repos/xnuinside/incubator-airflow/forks","keys_url":"https://api.github.com/repos/xnuinside/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xnuinside/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xnuinside/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/xnuinside/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/xnuinside/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/xnuinside/incubator-airflow/events","assignees_url":"https://api.github.com/repos/xnuinside/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/xnuinside/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/xnuinside/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/xnuinside/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xnuinside/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xnuinside/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/xnuinside/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xnuinside/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/xnuinside/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/xnuinside/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/xnuinside/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/xnuinside/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/xnuinside/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/xnuinside/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/xnuinside/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/xnuinside/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/xnuinside/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/xnuinside/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/xnuinside/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xnuinside/incubator-airflow/merges","archive_url":"https://api.github.com/repos/xnuinside/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xnuinside/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/xnuinside/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/xnuinside/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/xnuinside/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/xnuinside/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xnuinside/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/xnuinside/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/xnuinside/incubator-airflow/deployments","created_at":"2018-08-10T12:31:00Z","updated_at":"2018-09-12T16:40:01Z","pushed_at":"2018-09-14T08:52:04Z","git_url":"git://github.com/xnuinside/incubator-airflow.git","ssh_url":"git@github.com:xnuinside/incubator-airflow.git","clone_url":"https://github.com/xnuinside/incubator-airflow.git","svn_url":"https://github.com/xnuinside/incubator-airflow","homepage":"https://airflow.apache.org","size":23855,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7d60d2686d40342255a5e326f31d3cc42c72a68b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"incubator-airflow","full_name":"apache/incubator-airflow","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2018-09-14T08:35:51Z","pushed_at":"2018-09-14T08:52:39Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"https://airflow.apache.org","size":24241,"stargazers_count":9371,"watchers_count":9371,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3160,"mirror_url":null,"archived":false,"open_issues_count":341,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3160,"open_issues":341,"watchers":9371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3901"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3901"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3901/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3901/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/e2ce862fff06817b828d74277b690e2b6763da47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaxil"}}