{"action":"created","issue":{"url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/75","repository_url":"https://api.github.com/repos/gmarm/BetterSegmentedControl","labels_url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/75/comments","events_url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/75/events","html_url":"https://github.com/gmarm/BetterSegmentedControl/issues/75","id":339978112,"node_id":"MDU6SXNzdWUzMzk5NzgxMTI=","number":75,"title":"Suggestion","user":{"login":"Idomo","id":26777129,"node_id":"MDQ6VXNlcjI2Nzc3MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/26777129?v=4","gravatar_id":"","url":"https://api.github.com/users/Idomo","html_url":"https://github.com/Idomo","followers_url":"https://api.github.com/users/Idomo/followers","following_url":"https://api.github.com/users/Idomo/following{/other_user}","gists_url":"https://api.github.com/users/Idomo/gists{/gist_id}","starred_url":"https://api.github.com/users/Idomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Idomo/subscriptions","organizations_url":"https://api.github.com/users/Idomo/orgs","repos_url":"https://api.github.com/users/Idomo/repos","events_url":"https://api.github.com/users/Idomo/events{/privacy}","received_events_url":"https://api.github.com/users/Idomo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-10T19:33:11Z","updated_at":"2018-07-22T15:57:35Z","closed_at":null,"author_association":"NONE","body":"Hi @gmarm,\r\nFirst thing, thanks for building this library, it's great and exactly what I was needed!\r\n\r\nI'd like to suggest few things to change, to make the library even better:\r\n1. **Make settings `options` more easier to understand**\r\nIn the beginning I thought there is no way to change it, but now I find out that I can change it via `options` property, it's not the most understandable way and I couldn't find any examples in the `README.md` or in the Example project, I think you should do something about it.\r\n\r\n2. **Remove `layer.masksToBounds = true` from line 310 when `indicatorViewInset` is negative**\r\nWhen the `indicatorViewInset` is negative you should get nice effect like this:\r\n![img_ea39e9e44b0f-1](https://user-images.githubusercontent.com/26777129/42532729-7b961ade-8490-11e8-9249-8c5ddd82823f.jpeg)\r\nBut instead of that the `indicatorViewBackground` is cutting of when it's passing the `BetterSegmentedControl` parent view because of this line.\r\nI don't see any problem after comment it out so it's just unnecessary.\r\n\r\nI'v created pull request for this: #76 \r\n\r\nThanks,\r\nIdo."},"comment":{"url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/comments/406877285","html_url":"https://github.com/gmarm/BetterSegmentedControl/issues/75#issuecomment-406877285","issue_url":"https://api.github.com/repos/gmarm/BetterSegmentedControl/issues/75","id":406877285,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg3NzI4NQ==","user":{"login":"gmarm","id":1718656,"node_id":"MDQ6VXNlcjE3MTg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1718656?v=4","gravatar_id":"","url":"https://api.github.com/users/gmarm","html_url":"https://github.com/gmarm","followers_url":"https://api.github.com/users/gmarm/followers","following_url":"https://api.github.com/users/gmarm/following{/other_user}","gists_url":"https://api.github.com/users/gmarm/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarm/subscriptions","organizations_url":"https://api.github.com/users/gmarm/orgs","repos_url":"https://api.github.com/users/gmarm/repos","events_url":"https://api.github.com/users/gmarm/events{/privacy}","received_events_url":"https://api.github.com/users/gmarm/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T15:57:35Z","updated_at":"2018-07-22T15:57:35Z","author_association":"OWNER","body":"1. has been addressed by https://github.com/gmarm/BetterSegmentedControl/pull/78\r\n2. I will be having a look at this and your PR since the implementation changed a bit there."}}
{"actor":{"display_login":"gmarm"}}