{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/comments/182647236","pull_request_review_id":113483025,"id":182647236,"diff_hunk":"@@ -10,7 +10,7 @@ import (\n \t\"github.com/giantswarm/microerror\"\n \t\"github.com/giantswarm/micrologger\"\n \t\"github.com/giantswarm/operatorkit/client/k8srestconfig\"\n-\t\"github.com/giantswarm/operatorkit/framework\"\n+\toperatorkitcontroller \"github.com/giantswarm/operatorkit/controller\"","path":"service/service.go","position":5,"original_position":5,"commit_id":"f736b616175b593386773cbef3fbdf5f04ef1845","original_commit_id":"f736b616175b593386773cbef3fbdf5f04ef1845","user":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"We agreed on embedding operatorkit controller into the actual controller. Then you don't have the import here at all. Check https://github.com/giantswarm/azure-operator/blob/7086fa68dbe678aa00f4cf70f493c15ee0f95874/service/controller/cluster.go#L32-L34","created_at":"2018-04-19T06:47:38Z","updated_at":"2018-04-19T06:47:38Z","html_url":"https://github.com/giantswarm/cert-operator/pull/172#discussion_r182647236","pull_request_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/comments/182647236"},"html":{"href":"https://github.com/giantswarm/cert-operator/pull/172#discussion_r182647236"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172"}},"in_reply_to_id":182642870},"pull_request":{"url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172","id":182674962,"html_url":"https://github.com/giantswarm/cert-operator/pull/172","diff_url":"https://github.com/giantswarm/cert-operator/pull/172.diff","patch_url":"https://github.com/giantswarm/cert-operator/pull/172.patch","issue_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/172","number":172,"state":"open","locked":false,"title":"Vendor update to latest operatorkit","user":{"login":"MarcelMue","id":9303709,"avatar_url":"https://avatars1.githubusercontent.com/u/9303709?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelMue","html_url":"https://github.com/MarcelMue","followers_url":"https://api.github.com/users/MarcelMue/followers","following_url":"https://api.github.com/users/MarcelMue/following{/other_user}","gists_url":"https://api.github.com/users/MarcelMue/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelMue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelMue/subscriptions","organizations_url":"https://api.github.com/users/MarcelMue/orgs","repos_url":"https://api.github.com/users/MarcelMue/repos","events_url":"https://api.github.com/users/MarcelMue/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelMue/received_events","type":"User","site_admin":false},"body":"Towards https://github.com/giantswarm/giantswarm/issues/2995","created_at":"2018-04-19T06:11:19Z","updated_at":"2018-04-19T06:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"421aa04e0c5d59baf3e25587866fa9119ef47c91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"sig-operator","id":2690126,"slug":"sig-operator","description":"Driver: @xh3b4sd","privacy":"closed","url":"https://api.github.com/teams/2690126","members_url":"https://api.github.com/teams/2690126/members{/member}","repositories_url":"https://api.github.com/teams/2690126/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172/commits","review_comments_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172/comments","review_comment_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/172/comments","statuses_url":"https://api.github.com/repos/giantswarm/cert-operator/statuses/f736b616175b593386773cbef3fbdf5f04ef1845","head":{"label":"giantswarm:vendor-update","ref":"vendor-update","sha":"f736b616175b593386773cbef3fbdf5f04ef1845","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":84860971,"name":"cert-operator","full_name":"giantswarm/cert-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/cert-operator","description":"cert-operator creates/manages certificates for Kubernetes clusters running on Giantnetes","fork":false,"url":"https://api.github.com/repos/giantswarm/cert-operator","forks_url":"https://api.github.com/repos/giantswarm/cert-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/cert-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/cert-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/cert-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/cert-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/cert-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/cert-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/cert-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/cert-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/cert-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/cert-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/cert-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/cert-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/cert-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/cert-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/cert-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/cert-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/cert-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/cert-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/cert-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/cert-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/cert-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/cert-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/cert-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/cert-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/cert-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/cert-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/cert-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/cert-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/cert-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/cert-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/cert-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/cert-operator/deployments","created_at":"2017-03-13T18:28:57Z","updated_at":"2018-04-17T08:14:51Z","pushed_at":"2018-04-19T06:11:21Z","git_url":"git://github.com/giantswarm/cert-operator.git","ssh_url":"git@github.com:giantswarm/cert-operator.git","clone_url":"https://github.com/giantswarm/cert-operator.git","svn_url":"https://github.com/giantswarm/cert-operator","homepage":"","size":47089,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":2,"watchers":21,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"4fbddc59a6230d0c843ea7c1d4ae884ecea647d3","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":84860971,"name":"cert-operator","full_name":"giantswarm/cert-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/cert-operator","description":"cert-operator creates/manages certificates for Kubernetes clusters running on Giantnetes","fork":false,"url":"https://api.github.com/repos/giantswarm/cert-operator","forks_url":"https://api.github.com/repos/giantswarm/cert-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/cert-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/cert-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/cert-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/cert-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/cert-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/cert-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/cert-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/cert-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/cert-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/cert-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/cert-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/cert-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/cert-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/cert-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/cert-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/cert-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/cert-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/cert-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/cert-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/cert-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/cert-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/cert-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/cert-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/cert-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/cert-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/cert-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/cert-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/cert-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/cert-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/cert-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/cert-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/cert-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/cert-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/cert-operator/deployments","created_at":"2017-03-13T18:28:57Z","updated_at":"2018-04-17T08:14:51Z","pushed_at":"2018-04-19T06:11:21Z","git_url":"git://github.com/giantswarm/cert-operator.git","ssh_url":"git@github.com:giantswarm/cert-operator.git","clone_url":"https://github.com/giantswarm/cert-operator.git","svn_url":"https://github.com/giantswarm/cert-operator","homepage":"","size":47089,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172"},"html":{"href":"https://github.com/giantswarm/cert-operator/pull/172"},"issue":{"href":"https://api.github.com/repos/giantswarm/cert-operator/issues/172"},"comments":{"href":"https://api.github.com/repos/giantswarm/cert-operator/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/cert-operator/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/cert-operator/statuses/f736b616175b593386773cbef3fbdf5f04ef1845"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kopiczko"}}