{"push_id":2551336122,"size":3,"distinct_size":0,"ref":"refs/heads/master","head":"5632c7fad122548dfabeb3011e98d3b0a08a89d7","before":"70bbb05ea8c6502189a73862f956dac687b91075","commits":[{"sha":"027139b1be4290457df202b74c84d82d5188b10d","author":{"name":"Dmitri Shuralyov","email":"3e7b0c396ed8de245aa9bebbd359a431b4980612@shuralyov.com"},"message":"Improve documentation consistency.","distinct":false,"url":"https://api.github.com/repos/andygrunwald/go-gerrit/commits/027139b1be4290457df202b74c84d82d5188b10d"},{"sha":"90fea2ddaa1296d860b670a12a06fb7040eb82c8","author":{"name":"Dmitri Shuralyov","email":"3e7b0c396ed8de245aa9bebbd359a431b4980612@shuralyov.com"},"message":"Improve consistency of baseURL trailing slash handling.\n\nThere were mismatches between the documentation and actual behavior\nof how the baseURL trailing slash was handled.\n\nThere were also inconsistency of the gerritURL/endpoint parameter name\nin the documentation of NewClient and the actual function signature.\n\nThis change fixes those and simplifies code.","distinct":false,"url":"https://api.github.com/repos/andygrunwald/go-gerrit/commits/90fea2ddaa1296d860b670a12a06fb7040eb82c8"},{"sha":"5632c7fad122548dfabeb3011e98d3b0a08a89d7","author":{"name":"Dmitri Shuralyov","email":"3e7b0c396ed8de245aa9bebbd359a431b4980612@shuralyov.com"},"message":"Expose the client's BaseURL.\n\nThe motivation for doing this is as follows.\n\nNewClient takes a gerritURL string, which is then parsed into a baseURL\ninternal to the gerrit.Client.\n\nSome users of gerrit.Client may need to know the Gerrit instance that\nthe client targets. Currently, they'd have to be provided the target\nseparately, which can lead to a mismatch from the actual gerrit.Client\nGerrit instance:\n\n\tclient, err := gerrit.NewClient(\"https://go-review.googlesource.com/\", nil)\n\tif err != nil {\n\t\treturn err\n\t}\n\tservice := gerritapi.NewService(client, \"https://upspin-review.googlesource.com/\") // mismatch\n\nBaseURL method is added to allow users to find out the Gerrit URL\nendpoint directly from the gerrit.Client, removing the chance for\nany mismatches:\n\n\tclient, err := gerrit.NewClient(\"https://go-review.googlesource.com/\", nil)\n\tif err != nil {\n\t\treturn err\n\t}\n\tservice := gerritapi.NewService(client) // no mismatch possible, gerritapi queries actual client.BaseURL()","distinct":false,"url":"https://api.github.com/repos/andygrunwald/go-gerrit/commits/5632c7fad122548dfabeb3011e98d3b0a08a89d7"}]}
{"actor":{"display_login":"shurcooL"}}