{"action":"closed","number":502,"pull_request":{"url":"https://api.github.com/repos/CESNET/libyang/pulls/502","id":187951619,"html_url":"https://github.com/CESNET/libyang/pull/502","diff_url":"https://github.com/CESNET/libyang/pull/502.diff","patch_url":"https://github.com/CESNET/libyang/pull/502.patch","issue_url":"https://api.github.com/repos/CESNET/libyang/issues/502","number":502,"state":"closed","locked":false,"title":"Resolving issue with yang and yin printers regarding typedefs in submodules","user":{"login":"aweast","id":38564732,"avatar_url":"https://avatars1.githubusercontent.com/u/38564732?v=4","gravatar_id":"","url":"https://api.github.com/users/aweast","html_url":"https://github.com/aweast","followers_url":"https://api.github.com/users/aweast/followers","following_url":"https://api.github.com/users/aweast/following{/other_user}","gists_url":"https://api.github.com/users/aweast/gists{/gist_id}","starred_url":"https://api.github.com/users/aweast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweast/subscriptions","organizations_url":"https://api.github.com/users/aweast/orgs","repos_url":"https://api.github.com/users/aweast/repos","events_url":"https://api.github.com/users/aweast/events{/privacy}","received_events_url":"https://api.github.com/users/aweast/received_events","type":"User","site_admin":false},"body":"There is an issue with the yin and yang printer when a leaf uses a type defined in a submodule of an imported module. Without the patch, the printer would try to find the prefix of the submodule, instead of finding the prefix of the submodule’s main module.\r\n\r\nThe suggested fix ensures that the printer always attempts to get the prefix of the main module. The accompanying unit test uses a yang model that demonstrates the original issue.\r\n\r\n### Resolves #501 ","created_at":"2018-05-14T21:08:46Z","updated_at":"2018-05-15T07:09:51Z","closed_at":"2018-05-15T07:09:51Z","merged_at":"2018-05-15T07:09:51Z","merge_commit_sha":"875e91904db2750a460af65df0316aad76451c88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CESNET/libyang/pulls/502/commits","review_comments_url":"https://api.github.com/repos/CESNET/libyang/pulls/502/comments","review_comment_url":"https://api.github.com/repos/CESNET/libyang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CESNET/libyang/issues/502/comments","statuses_url":"https://api.github.com/repos/CESNET/libyang/statuses/a59b6b31acef5a00577d8db8f108957d84a60674","head":{"label":"aweast:yin-and-yang-printer-fix","ref":"yin-and-yang-printer-fix","sha":"a59b6b31acef5a00577d8db8f108957d84a60674","user":{"login":"aweast","id":38564732,"avatar_url":"https://avatars1.githubusercontent.com/u/38564732?v=4","gravatar_id":"","url":"https://api.github.com/users/aweast","html_url":"https://github.com/aweast","followers_url":"https://api.github.com/users/aweast/followers","following_url":"https://api.github.com/users/aweast/following{/other_user}","gists_url":"https://api.github.com/users/aweast/gists{/gist_id}","starred_url":"https://api.github.com/users/aweast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweast/subscriptions","organizations_url":"https://api.github.com/users/aweast/orgs","repos_url":"https://api.github.com/users/aweast/repos","events_url":"https://api.github.com/users/aweast/events{/privacy}","received_events_url":"https://api.github.com/users/aweast/received_events","type":"User","site_admin":false},"repo":{"id":133420707,"name":"libyang","full_name":"aweast/libyang","owner":{"login":"aweast","id":38564732,"avatar_url":"https://avatars1.githubusercontent.com/u/38564732?v=4","gravatar_id":"","url":"https://api.github.com/users/aweast","html_url":"https://github.com/aweast","followers_url":"https://api.github.com/users/aweast/followers","following_url":"https://api.github.com/users/aweast/following{/other_user}","gists_url":"https://api.github.com/users/aweast/gists{/gist_id}","starred_url":"https://api.github.com/users/aweast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweast/subscriptions","organizations_url":"https://api.github.com/users/aweast/orgs","repos_url":"https://api.github.com/users/aweast/repos","events_url":"https://api.github.com/users/aweast/events{/privacy}","received_events_url":"https://api.github.com/users/aweast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aweast/libyang","description":"YANG data modeling language library","fork":true,"url":"https://api.github.com/repos/aweast/libyang","forks_url":"https://api.github.com/repos/aweast/libyang/forks","keys_url":"https://api.github.com/repos/aweast/libyang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aweast/libyang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aweast/libyang/teams","hooks_url":"https://api.github.com/repos/aweast/libyang/hooks","issue_events_url":"https://api.github.com/repos/aweast/libyang/issues/events{/number}","events_url":"https://api.github.com/repos/aweast/libyang/events","assignees_url":"https://api.github.com/repos/aweast/libyang/assignees{/user}","branches_url":"https://api.github.com/repos/aweast/libyang/branches{/branch}","tags_url":"https://api.github.com/repos/aweast/libyang/tags","blobs_url":"https://api.github.com/repos/aweast/libyang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aweast/libyang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aweast/libyang/git/refs{/sha}","trees_url":"https://api.github.com/repos/aweast/libyang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aweast/libyang/statuses/{sha}","languages_url":"https://api.github.com/repos/aweast/libyang/languages","stargazers_url":"https://api.github.com/repos/aweast/libyang/stargazers","contributors_url":"https://api.github.com/repos/aweast/libyang/contributors","subscribers_url":"https://api.github.com/repos/aweast/libyang/subscribers","subscription_url":"https://api.github.com/repos/aweast/libyang/subscription","commits_url":"https://api.github.com/repos/aweast/libyang/commits{/sha}","git_commits_url":"https://api.github.com/repos/aweast/libyang/git/commits{/sha}","comments_url":"https://api.github.com/repos/aweast/libyang/comments{/number}","issue_comment_url":"https://api.github.com/repos/aweast/libyang/issues/comments{/number}","contents_url":"https://api.github.com/repos/aweast/libyang/contents/{+path}","compare_url":"https://api.github.com/repos/aweast/libyang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aweast/libyang/merges","archive_url":"https://api.github.com/repos/aweast/libyang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aweast/libyang/downloads","issues_url":"https://api.github.com/repos/aweast/libyang/issues{/number}","pulls_url":"https://api.github.com/repos/aweast/libyang/pulls{/number}","milestones_url":"https://api.github.com/repos/aweast/libyang/milestones{/number}","notifications_url":"https://api.github.com/repos/aweast/libyang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aweast/libyang/labels{/name}","releases_url":"https://api.github.com/repos/aweast/libyang/releases{/id}","deployments_url":"https://api.github.com/repos/aweast/libyang/deployments","created_at":"2018-05-14T20:58:31Z","updated_at":"2018-05-14T20:58:35Z","pushed_at":"2018-05-14T21:05:33Z","git_url":"git://github.com/aweast/libyang.git","ssh_url":"git@github.com:aweast/libyang.git","clone_url":"https://github.com/aweast/libyang.git","svn_url":"https://github.com/aweast/libyang","homepage":"","size":20284,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CESNET:devel","ref":"devel","sha":"864fc688c1e6e2a951fecc0f3a70da699bc55986","user":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars2.githubusercontent.com/u/1116469?v=4","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"repo":{"id":32149716,"name":"libyang","full_name":"CESNET/libyang","owner":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars2.githubusercontent.com/u/1116469?v=4","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESNET/libyang","description":"YANG data modeling language library","fork":false,"url":"https://api.github.com/repos/CESNET/libyang","forks_url":"https://api.github.com/repos/CESNET/libyang/forks","keys_url":"https://api.github.com/repos/CESNET/libyang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESNET/libyang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESNET/libyang/teams","hooks_url":"https://api.github.com/repos/CESNET/libyang/hooks","issue_events_url":"https://api.github.com/repos/CESNET/libyang/issues/events{/number}","events_url":"https://api.github.com/repos/CESNET/libyang/events","assignees_url":"https://api.github.com/repos/CESNET/libyang/assignees{/user}","branches_url":"https://api.github.com/repos/CESNET/libyang/branches{/branch}","tags_url":"https://api.github.com/repos/CESNET/libyang/tags","blobs_url":"https://api.github.com/repos/CESNET/libyang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESNET/libyang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESNET/libyang/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESNET/libyang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESNET/libyang/statuses/{sha}","languages_url":"https://api.github.com/repos/CESNET/libyang/languages","stargazers_url":"https://api.github.com/repos/CESNET/libyang/stargazers","contributors_url":"https://api.github.com/repos/CESNET/libyang/contributors","subscribers_url":"https://api.github.com/repos/CESNET/libyang/subscribers","subscription_url":"https://api.github.com/repos/CESNET/libyang/subscription","commits_url":"https://api.github.com/repos/CESNET/libyang/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESNET/libyang/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESNET/libyang/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESNET/libyang/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESNET/libyang/contents/{+path}","compare_url":"https://api.github.com/repos/CESNET/libyang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESNET/libyang/merges","archive_url":"https://api.github.com/repos/CESNET/libyang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESNET/libyang/downloads","issues_url":"https://api.github.com/repos/CESNET/libyang/issues{/number}","pulls_url":"https://api.github.com/repos/CESNET/libyang/pulls{/number}","milestones_url":"https://api.github.com/repos/CESNET/libyang/milestones{/number}","notifications_url":"https://api.github.com/repos/CESNET/libyang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESNET/libyang/labels{/name}","releases_url":"https://api.github.com/repos/CESNET/libyang/releases{/id}","deployments_url":"https://api.github.com/repos/CESNET/libyang/deployments","created_at":"2015-03-13T10:25:52Z","updated_at":"2018-05-09T10:00:54Z","pushed_at":"2018-05-15T07:09:51Z","git_url":"git://github.com/CESNET/libyang.git","ssh_url":"git@github.com:CESNET/libyang.git","clone_url":"https://github.com/CESNET/libyang.git","svn_url":"https://github.com/CESNET/libyang","homepage":"","size":20282,"stargazers_count":89,"watchers_count":89,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":71,"open_issues":26,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CESNET/libyang/pulls/502"},"html":{"href":"https://github.com/CESNET/libyang/pull/502"},"issue":{"href":"https://api.github.com/repos/CESNET/libyang/issues/502"},"comments":{"href":"https://api.github.com/repos/CESNET/libyang/issues/502/comments"},"review_comments":{"href":"https://api.github.com/repos/CESNET/libyang/pulls/502/comments"},"review_comment":{"href":"https://api.github.com/repos/CESNET/libyang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CESNET/libyang/pulls/502/commits"},"statuses":{"href":"https://api.github.com/repos/CESNET/libyang/statuses/a59b6b31acef5a00577d8db8f108957d84a60674"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"michalvasko","id":12510224,"avatar_url":"https://avatars3.githubusercontent.com/u/12510224?v=4","gravatar_id":"","url":"https://api.github.com/users/michalvasko","html_url":"https://github.com/michalvasko","followers_url":"https://api.github.com/users/michalvasko/followers","following_url":"https://api.github.com/users/michalvasko/following{/other_user}","gists_url":"https://api.github.com/users/michalvasko/gists{/gist_id}","starred_url":"https://api.github.com/users/michalvasko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalvasko/subscriptions","organizations_url":"https://api.github.com/users/michalvasko/orgs","repos_url":"https://api.github.com/users/michalvasko/repos","events_url":"https://api.github.com/users/michalvasko/events{/privacy}","received_events_url":"https://api.github.com/users/michalvasko/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":91,"deletions":2,"changed_files":6}}
{"actor":{"display_login":"michalvasko"}}