{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/712","repository_url":"https://api.github.com/repos/ethereum/EIPs","labels_url":"https://api.github.com/repos/ethereum/EIPs/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/EIPs/issues/712/comments","events_url":"https://api.github.com/repos/ethereum/EIPs/issues/712/events","html_url":"https://github.com/ethereum/EIPs/pull/712","id":257207367,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQwNzAwNDQ4","number":712,"title":"[WIP] Add eth_signTypedData as a standard for machine-verifiable and human-readable typed data signing with Ethereum keys","user":{"login":"LogvinovLeon","id":6204356,"node_id":"MDQ6VXNlcjYyMDQzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"labels":[{"id":290507092,"node_id":"MDU6TGFiZWwyOTA1MDcwOTI=","url":"https://api.github.com/repos/ethereum/EIPs/labels/ERC","name":"ERC","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":180,"created_at":"2017-09-12T22:52:46Z","updated_at":"2018-10-12T15:32:36Z","closed_at":"2018-06-09T19:19:15Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereum/EIPs/pulls/712","html_url":"https://github.com/ethereum/EIPs/pull/712","diff_url":"https://github.com/ethereum/EIPs/pull/712.diff","patch_url":"https://github.com/ethereum/EIPs/pull/712.patch"},"body":"https://github.com/0xProject/EIPs/blob/master/EIPS/eip-signTypedData.md"},"comment":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/comments/429366459","html_url":"https://github.com/ethereum/EIPs/pull/712#issuecomment-429366459","issue_url":"https://api.github.com/repos/ethereum/EIPs/issues/712","id":429366459,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM2NjQ1OQ==","user":{"login":"0xbitcoin","id":36060731,"node_id":"MDQ6VXNlcjM2MDYwNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/36060731?v=4","gravatar_id":"","url":"https://api.github.com/users/0xbitcoin","html_url":"https://github.com/0xbitcoin","followers_url":"https://api.github.com/users/0xbitcoin/followers","following_url":"https://api.github.com/users/0xbitcoin/following{/other_user}","gists_url":"https://api.github.com/users/0xbitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/0xbitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xbitcoin/subscriptions","organizations_url":"https://api.github.com/users/0xbitcoin/orgs","repos_url":"https://api.github.com/users/0xbitcoin/repos","events_url":"https://api.github.com/users/0xbitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/0xbitcoin/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T15:32:36Z","updated_at":"2018-10-12T15:32:36Z","author_association":"NONE","body":"Hi Ronan,\n\nIs there a Gitter channel or something like that for this EIP 712 ?   Id\nlike to be able to discuss more freely.  This EIP is instrumental to\nMetamask and the way that Ethereum Dapps will interact with their smart\ncontracts (through Metamask) and so it is of extreme importance that this\nbe done correctly.   I do like the general ideas end-to-end encryption and\nfor origin checking but why are they necessary and what exactly is being\nchecked (IPFS hash of document origin?  What is an example?)   and why is\nit necessary to encrypt data when we use HTTPS for everything now anyways ?\n\nI just feel as though if this is overcomplicated then 1) it will take\nforever to finalize  and 2) it will be harder to implement which means less\npeople will implement it and less people will implement it correctly (very\nimportant!!!)\n\nI dont mean to be a negative nancy but want an open discussion for the\nbetterment of Ethereum.  I am building a series of interconnected dapps\nthat depend on Typed Signed Data and I want to help out EIP712 because it\nis a major bottleneck for my Dapp and I cannot progress forward until i\nknow that this is finalized and will not change.\n\n  I am of the personal opinion that the previous interation of the spec was\nvery good, basically perfect, and it seems that this new update is\nbasically the same (all fields are arbitrary and optional) but now we can\nuse structs to organize and group the fields into fieldgroups.  Super cool\n!!   Is that assumption correct?   I don't understand how 'origins' fit in\nhere and I also dont understand how solidity can check for a 'domain' and\nfor a 'url' address.   Just by hardcoding the hash of the domain string and\nthe url address in the contract code and assuming the javascript will pass\nit in properly ??  Couldnt hacked javascript lie about the URL?    Also is\nthat optional to do or enforced  ?\n\n Infernaltoast\n\n\nOn Fri, Oct 12, 2018 at 10:58 AM Ronan Sandford <notifications@github.com>\nwrote:\n\n> Finally published my post explaining 3 different proposal 2 of which would\n> improve EIP712:\n>\n> https://medium.com/@wighawag/3-proposals-for-making-web3-a-better-experience-974f97765700\n>\n> The last proposal requires automated \"origin checks\" to work and should\n> bring a far greater experiences to users. Check it out.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ethereum/EIPs/pull/712#issuecomment-429354934>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AiY-O0Yvcxg7nEr997ncdp0t0_bS0Xupks5ukK4vgaJpZM4PVW8c>\n> .\n>\n"}}
{"actor":{"display_login":"0xbitcoin"}}