{"action":"closed","issue":{"url":"https://api.github.com/repos/OpenLiberty/draft-guide-springboot-mvc/issues/16","repository_url":"https://api.github.com/repos/OpenLiberty/draft-guide-springboot-mvc","labels_url":"https://api.github.com/repos/OpenLiberty/draft-guide-springboot-mvc/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/OpenLiberty/draft-guide-springboot-mvc/issues/16/comments","events_url":"https://api.github.com/repos/OpenLiberty/draft-guide-springboot-mvc/issues/16/events","html_url":"https://github.com/OpenLiberty/draft-guide-springboot-mvc/issues/16","id":362778605,"node_id":"MDU6SXNzdWUzNjI3Nzg2MDU=","number":16,"title":"User review the Spring MVC guide","user":{"login":"Rachelwrq","id":25073063,"node_id":"MDQ6VXNlcjI1MDczMDYz","avatar_url":"https://avatars2.githubusercontent.com/u/25073063?v=4","gravatar_id":"","url":"https://api.github.com/users/Rachelwrq","html_url":"https://github.com/Rachelwrq","followers_url":"https://api.github.com/users/Rachelwrq/followers","following_url":"https://api.github.com/users/Rachelwrq/following{/other_user}","gists_url":"https://api.github.com/users/Rachelwrq/gists{/gist_id}","starred_url":"https://api.github.com/users/Rachelwrq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rachelwrq/subscriptions","organizations_url":"https://api.github.com/users/Rachelwrq/orgs","repos_url":"https://api.github.com/users/Rachelwrq/repos","events_url":"https://api.github.com/users/Rachelwrq/events{/privacy}","received_events_url":"https://api.github.com/users/Rachelwrq/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"evelinec","id":33134427,"node_id":"MDQ6VXNlcjMzMTM0NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/33134427?v=4","gravatar_id":"","url":"https://api.github.com/users/evelinec","html_url":"https://github.com/evelinec","followers_url":"https://api.github.com/users/evelinec/followers","following_url":"https://api.github.com/users/evelinec/following{/other_user}","gists_url":"https://api.github.com/users/evelinec/gists{/gist_id}","starred_url":"https://api.github.com/users/evelinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evelinec/subscriptions","organizations_url":"https://api.github.com/users/evelinec/orgs","repos_url":"https://api.github.com/users/evelinec/repos","events_url":"https://api.github.com/users/evelinec/events{/privacy}","received_events_url":"https://api.github.com/users/evelinec/received_events","type":"User","site_admin":false},"assignees":[{"login":"evelinec","id":33134427,"node_id":"MDQ6VXNlcjMzMTM0NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/33134427?v=4","gravatar_id":"","url":"https://api.github.com/users/evelinec","html_url":"https://github.com/evelinec","followers_url":"https://api.github.com/users/evelinec/followers","following_url":"https://api.github.com/users/evelinec/following{/other_user}","gists_url":"https://api.github.com/users/evelinec/gists{/gist_id}","starred_url":"https://api.github.com/users/evelinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evelinec/subscriptions","organizations_url":"https://api.github.com/users/evelinec/orgs","repos_url":"https://api.github.com/users/evelinec/repos","events_url":"https://api.github.com/users/evelinec/events{/privacy}","received_events_url":"https://api.github.com/users/evelinec/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-21T21:22:27Z","updated_at":"2018-09-25T15:51:20Z","closed_at":"2018-09-25T15:51:19Z","author_association":"NONE","body":"## Timing\r\nTook around 18 minutes to complete the guide.\r\n\r\n## Overall Review\r\nThis guide is very straight forward and mostly informative. User was able to follow the instructions and explanations. There are a few suggestions:\r\n- [ ] Maybe still include a short description of what Spring MVC is and how is it different from Open Liberty, so that user would know they are migrating a Spring Boot MVC Application to Open Liberty.\r\n\r\n## Section Feedback\r\n### Getting Started\r\n- [x] the sentence “You’ll see from the page output that the `name` request parameter was received and handled” is unclear to user.\r\n\r\n### Modifying the POM\r\n#### Changing the packaging type\r\n- [x] \"so add `<packaging>liberty-assembly</packaging>` near the top of the POM\", \"near the top\" is considered to be vague and user might get confused, the position of the code should be clarified, maybe write something like underneath the `<version>1.0-SNAPSHOT</version>`\r\n- [ ] The format for presenting the code different, I had to select the code and copy it manually instead of click the copy button. \r\n\r\n#### Adding POM properties\r\n- [x] Instead of copy the whole block of properties, maybe just copy the one needed to add and tell the user to add it, for example: underneath java property, since what the `pom.xml` file would look like is posted below.\r\n\r\n#### Adding and modifying dependencies\r\n- [x] Specify the location of dependency: it is under dependencies block, so user don't accidentally remove the `<dependencies>` block and cause errors later on.\r\n\r\n#### Adding the Liberty Maven Plugin\r\n- [x] Specify the location of the plugin, example: inside `build` and `plugins`,  just to be perfectly clear to the audience."}}
{"actor":{"display_login":"evelinec"}}