{"action":"closed","number":37457,"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37457","id":201406004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDA2MDA0","html_url":"https://github.com/moby/moby/pull/37457","diff_url":"https://github.com/moby/moby/pull/37457.diff","patch_url":"https://github.com/moby/moby/pull/37457.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/37457","number":37457,"state":"closed","locked":false,"title":"moved integration tests from docker_cli_config_create_test.go to integration/config","user":{"login":"adshmh","id":23505281,"node_id":"MDQ6VXNlcjIzNTA1Mjgx","avatar_url":"https://avatars2.githubusercontent.com/u/23505281?v=4","gravatar_id":"","url":"https://api.github.com/users/adshmh","html_url":"https://github.com/adshmh","followers_url":"https://api.github.com/users/adshmh/followers","following_url":"https://api.github.com/users/adshmh/following{/other_user}","gists_url":"https://api.github.com/users/adshmh/gists{/gist_id}","starred_url":"https://api.github.com/users/adshmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshmh/subscriptions","organizations_url":"https://api.github.com/users/adshmh/orgs","repos_url":"https://api.github.com/users/adshmh/repos","events_url":"https://api.github.com/users/adshmh/events{/privacy}","received_events_url":"https://api.github.com/users/adshmh/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\nMoved several integration tests from `integration-cli/docker_cli_config_create_test.go` to `integration/config/config_test.go`.\r\n\r\n**- How I did it**\r\nRefactored and moved the integration tests to `integration/config/config_test.go`. One test was deleted as it seemed redundant.\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\nMoved several integration tests from `integration-cli/docker_cli_config_create_test.go` to `integration/config/create_test.go`\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n","created_at":"2018-07-13T21:37:06Z","updated_at":"2018-07-16T12:00:45Z","closed_at":"2018-07-16T12:00:45Z","merged_at":"2018-07-16T12:00:45Z","merge_commit_sha":"a5495f289aafafac8a01c62f2a9cb44856658ece","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":175375407,"node_id":"MDU6TGFiZWwxNzUzNzU0MDc=","url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/37457/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/37457/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/37457/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/0e57ceae0dd42491ed81538bf4d9164218080b66","head":{"label":"adshmh:migrate-docker_cli_config_create_test-integration-tests-to-integration-config","ref":"migrate-docker_cli_config_create_test-integration-tests-to-integration-config","sha":"0e57ceae0dd42491ed81538bf4d9164218080b66","user":{"login":"adshmh","id":23505281,"node_id":"MDQ6VXNlcjIzNTA1Mjgx","avatar_url":"https://avatars2.githubusercontent.com/u/23505281?v=4","gravatar_id":"","url":"https://api.github.com/users/adshmh","html_url":"https://github.com/adshmh","followers_url":"https://api.github.com/users/adshmh/followers","following_url":"https://api.github.com/users/adshmh/following{/other_user}","gists_url":"https://api.github.com/users/adshmh/gists{/gist_id}","starred_url":"https://api.github.com/users/adshmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshmh/subscriptions","organizations_url":"https://api.github.com/users/adshmh/orgs","repos_url":"https://api.github.com/users/adshmh/repos","events_url":"https://api.github.com/users/adshmh/events{/privacy}","received_events_url":"https://api.github.com/users/adshmh/received_events","type":"User","site_admin":false},"repo":{"id":75154627,"node_id":"MDEwOlJlcG9zaXRvcnk3NTE1NDYyNw==","name":"docker","full_name":"adshmh/docker","owner":{"login":"adshmh","id":23505281,"node_id":"MDQ6VXNlcjIzNTA1Mjgx","avatar_url":"https://avatars2.githubusercontent.com/u/23505281?v=4","gravatar_id":"","url":"https://api.github.com/users/adshmh","html_url":"https://github.com/adshmh","followers_url":"https://api.github.com/users/adshmh/followers","following_url":"https://api.github.com/users/adshmh/following{/other_user}","gists_url":"https://api.github.com/users/adshmh/gists{/gist_id}","starred_url":"https://api.github.com/users/adshmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adshmh/subscriptions","organizations_url":"https://api.github.com/users/adshmh/orgs","repos_url":"https://api.github.com/users/adshmh/repos","events_url":"https://api.github.com/users/adshmh/events{/privacy}","received_events_url":"https://api.github.com/users/adshmh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adshmh/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/adshmh/docker","forks_url":"https://api.github.com/repos/adshmh/docker/forks","keys_url":"https://api.github.com/repos/adshmh/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adshmh/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adshmh/docker/teams","hooks_url":"https://api.github.com/repos/adshmh/docker/hooks","issue_events_url":"https://api.github.com/repos/adshmh/docker/issues/events{/number}","events_url":"https://api.github.com/repos/adshmh/docker/events","assignees_url":"https://api.github.com/repos/adshmh/docker/assignees{/user}","branches_url":"https://api.github.com/repos/adshmh/docker/branches{/branch}","tags_url":"https://api.github.com/repos/adshmh/docker/tags","blobs_url":"https://api.github.com/repos/adshmh/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adshmh/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adshmh/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/adshmh/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adshmh/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/adshmh/docker/languages","stargazers_url":"https://api.github.com/repos/adshmh/docker/stargazers","contributors_url":"https://api.github.com/repos/adshmh/docker/contributors","subscribers_url":"https://api.github.com/repos/adshmh/docker/subscribers","subscription_url":"https://api.github.com/repos/adshmh/docker/subscription","commits_url":"https://api.github.com/repos/adshmh/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/adshmh/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/adshmh/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/adshmh/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/adshmh/docker/contents/{+path}","compare_url":"https://api.github.com/repos/adshmh/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adshmh/docker/merges","archive_url":"https://api.github.com/repos/adshmh/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adshmh/docker/downloads","issues_url":"https://api.github.com/repos/adshmh/docker/issues{/number}","pulls_url":"https://api.github.com/repos/adshmh/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/adshmh/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/adshmh/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adshmh/docker/labels{/name}","releases_url":"https://api.github.com/repos/adshmh/docker/releases{/id}","deployments_url":"https://api.github.com/repos/adshmh/docker/deployments","created_at":"2016-11-30T05:29:42Z","updated_at":"2016-11-30T05:30:00Z","pushed_at":"2018-07-14T14:47:35Z","git_url":"git://github.com/adshmh/docker.git","ssh_url":"git@github.com:adshmh/docker.git","clone_url":"https://github.com/adshmh/docker.git","svn_url":"https://github.com/adshmh/docker","homepage":"http://www.docker.com","size":134559,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"23f4a3d5091b878b252bef73ce6ab10a54641eb4","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-07-16T10:27:57Z","pushed_at":"2018-07-16T12:00:45Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":136533,"stargazers_count":49569,"watchers_count":49569,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14466,"mirror_url":null,"archived":false,"open_issues_count":3232,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14466,"open_issues":3232,"watchers":49569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/37457"},"html":{"href":"https://github.com/moby/moby/pull/37457"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/37457"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/37457/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/37457/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/37457/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/0e57ceae0dd42491ed81538bf4d9164218080b66"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":88,"deletions":112,"changed_files":2}}
{"actor":{"display_login":"vdemeester"}}