{"action":"created","issue":{"url":"https://api.github.com/repos/less/less.js/issues/3041","repository_url":"https://api.github.com/repos/less/less.js","labels_url":"https://api.github.com/repos/less/less.js/issues/3041/labels{/name}","comments_url":"https://api.github.com/repos/less/less.js/issues/3041/comments","events_url":"https://api.github.com/repos/less/less.js/issues/3041/events","html_url":"https://github.com/less/less.js/pull/3041","id":217423167,"node_id":"MDExOlB1bGxSZXF1ZXN0MTEyODczMzE1","number":3041,"title":"Feature rewrite-urls","user":{"login":"jhnns","id":781746,"node_id":"MDQ6VXNlcjc4MTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/781746?v=4","gravatar_id":"","url":"https://api.github.com/users/jhnns","html_url":"https://github.com/jhnns","followers_url":"https://api.github.com/users/jhnns/followers","following_url":"https://api.github.com/users/jhnns/following{/other_user}","gists_url":"https://api.github.com/users/jhnns/gists{/gist_id}","starred_url":"https://api.github.com/users/jhnns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhnns/subscriptions","organizations_url":"https://api.github.com/users/jhnns/orgs","repos_url":"https://api.github.com/users/jhnns/repos","events_url":"https://api.github.com/users/jhnns/events{/privacy}","received_events_url":"https://api.github.com/users/jhnns/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/less/less.js/milestones/14","html_url":"https://github.com/less/less.js/milestone/14","labels_url":"https://api.github.com/repos/less/less.js/milestones/14/labels","id":3451139,"node_id":"MDk6TWlsZXN0b25lMzQ1MTEzOQ==","number":14,"title":"4.0","description":"","creator":{"login":"matthew-dean","id":414752,"node_id":"MDQ6VXNlcjQxNDc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/414752?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-dean","html_url":"https://github.com/matthew-dean","followers_url":"https://api.github.com/users/matthew-dean/followers","following_url":"https://api.github.com/users/matthew-dean/following{/other_user}","gists_url":"https://api.github.com/users/matthew-dean/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-dean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-dean/subscriptions","organizations_url":"https://api.github.com/users/matthew-dean/orgs","repos_url":"https://api.github.com/users/matthew-dean/repos","events_url":"https://api.github.com/users/matthew-dean/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-dean/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-06-25T21:31:55Z","updated_at":"2018-06-25T21:33:25Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2017-03-28T01:38:37Z","updated_at":"2018-06-26T13:31:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/less/less.js/pulls/3041","html_url":"https://github.com/less/less.js/pull/3041","diff_url":"https://github.com/less/less.js/pull/3041.diff","patch_url":"https://github.com/less/less.js/pull/3041.patch"},"body":"This PR is based on the discussion https://github.com/less/less.js/pull/2615. It introduces a new option called `rewrite-urls` that can have two possible values:\r\n\r\n- `all`: Rewrite all `url()` statements to the base less file\r\n- `explicit-relative`: Only rewrite `url()` statements that start with a `.`. This enables CSS modules support\r\n\r\nThe option is disabled by default. The option `relative-urls` is superseded by `rewrite-urls=all`.\r\n\r\n**As a side-effect, this PR also introduces a second change**: Explicit relative URLs stay explicit relative – irregardless of the `rewrite-url` option. Check out the changes in `test/css/static-urls/urls.css ` and `test/css/urls.css`."},"comment":{"url":"https://api.github.com/repos/less/less.js/issues/comments/400309509","html_url":"https://github.com/less/less.js/pull/3041#issuecomment-400309509","issue_url":"https://api.github.com/repos/less/less.js/issues/3041","id":400309509,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDMwOTUwOQ==","user":{"login":"jhnns","id":781746,"node_id":"MDQ6VXNlcjc4MTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/781746?v=4","gravatar_id":"","url":"https://api.github.com/users/jhnns","html_url":"https://github.com/jhnns","followers_url":"https://api.github.com/users/jhnns/followers","following_url":"https://api.github.com/users/jhnns/following{/other_user}","gists_url":"https://api.github.com/users/jhnns/gists{/gist_id}","starred_url":"https://api.github.com/users/jhnns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhnns/subscriptions","organizations_url":"https://api.github.com/users/jhnns/orgs","repos_url":"https://api.github.com/users/jhnns/repos","events_url":"https://api.github.com/users/jhnns/events{/privacy}","received_events_url":"https://api.github.com/users/jhnns/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T13:31:48Z","updated_at":"2018-06-26T13:31:48Z","author_association":"CONTRIBUTOR","body":"I resolved the merge conflicts, changed the options to `all|local|off` and [added additional tests for the case where the `rootpath` and the `rewrite-urls` option is mixed](https://github.com/less/less.js/pull/3041/files#diff-53410acf673cf7995161036b8ae56229).\r\n\r\nThe PR is almost done from my point of view. If used from the command line (via `bin/lessc`) or in the browser, the deprecated `relativeUrls` option is mapped to `rewriteUrls: 'all'`. The only problem I currently have is that we also need to ensure backwards compatibility for the Node.js API. I don't know where to put the mapping from `relativeUrls` to `rewiteUrls: 'all'`.\r\n\r\nI'd appreciate some help here so that we can finally merge that feature :)"}}
{"actor":{"display_login":"jhnns"}}