{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/174299384","pull_request_review_id":103630701,"id":174299384,"diff_hunk":"@@ -102,6 +103,11 @@ func NewGCEClient() *gce.GCECloud {\n \t\t\t// manually to re-create the client.\n \t\t\t// TODO: why do we bail with success out if there is a permission error???\n \t\t\tif _, err = cloud.ListGlobalBackendServices(); err == nil || utils.IsHTTPErrorCode(err, http.StatusForbidden) {\n+\t\t\t\trl, err := ratelimit.ConfigureGCERateLimiting(flags.F.GCERateLimit)\n+\t\t\t\tif err != nil {\n+\t\t\t\t\tglog.Infof(\"Error in configuring rate limiting: %v\", err)","path":"cmd/glbc/app/clients.go","position":null,"original_position":14,"commit_id":"5190ea453769a592a5257e7a81abb9bde55461a3","original_commit_id":"0138a304d743befca81acd7db8f759fe037ffdbb","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"Good catch, fixed.","created_at":"2018-03-13T22:03:50Z","updated_at":"2018-03-13T22:03:50Z","html_url":"https://github.com/kubernetes/ingress-gce/pull/148#discussion_r174299384","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/174299384"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/148#discussion_r174299384"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148"}},"in_reply_to_id":174290544},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148","id":174551220,"html_url":"https://github.com/kubernetes/ingress-gce/pull/148","diff_url":"https://github.com/kubernetes/ingress-gce/pull/148.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/148.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/148","number":148,"state":"open","locked":false,"title":"Initial implementation for ingress rate limiting","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"body":"Will add unit tests once the overall approach is LGTM'd.\r\n\r\n/assign @nicksardo @bowei ","created_at":"2018-03-13T03:47:05Z","updated_at":"2018-03-13T22:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad29cbc97c9124c26b5e079ae47767855c2e77ee","assignee":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712525210,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":712525281,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/148/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/5190ea453769a592a5257e7a81abb9bde55461a3","head":{"label":"rramkumar1:rate-limit","ref":"rate-limit","sha":"5190ea453769a592a5257e7a81abb9bde55461a3","user":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"repo":{"id":114787128,"name":"ingress-gce","full_name":"rramkumar1/ingress-gce","owner":{"login":"rramkumar1","id":20979322,"avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rramkumar1/ingress-gce","description":"Ingress controller for Google Cloud","fork":true,"url":"https://api.github.com/repos/rramkumar1/ingress-gce","forks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/forks","keys_url":"https://api.github.com/repos/rramkumar1/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rramkumar1/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rramkumar1/ingress-gce/teams","hooks_url":"https://api.github.com/repos/rramkumar1/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/rramkumar1/ingress-gce/events","assignees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/rramkumar1/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/tags","blobs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rramkumar1/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/rramkumar1/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/rramkumar1/ingress-gce/subscription","commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/rramkumar1/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/rramkumar1/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/rramkumar1/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rramkumar1/ingress-gce/merges","archive_url":"https://api.github.com/repos/rramkumar1/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rramkumar1/ingress-gce/downloads","issues_url":"https://api.github.com/repos/rramkumar1/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/rramkumar1/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/rramkumar1/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/rramkumar1/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rramkumar1/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/rramkumar1/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/rramkumar1/ingress-gce/deployments","created_at":"2017-12-19T16:25:49Z","updated_at":"2017-12-19T16:25:51Z","pushed_at":"2018-03-13T22:03:38Z","git_url":"git://github.com/rramkumar1/ingress-gce.git","ssh_url":"git@github.com:rramkumar1/ingress-gce.git","clone_url":"https://github.com/rramkumar1/ingress-gce.git","svn_url":"https://github.com/rramkumar1/ingress-gce","homepage":"","size":33396,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"332d4f755725c1b094109a0418457c9e6bfe6386","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":105967469,"name":"ingress-gce","full_name":"kubernetes/ingress-gce","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-gce","description":"Ingress controller for Google Cloud","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-gce","forks_url":"https://api.github.com/repos/kubernetes/ingress-gce/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-gce/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-gce/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-gce/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-gce/deployments","created_at":"2017-10-06T04:32:12Z","updated_at":"2018-03-13T20:13:02Z","pushed_at":"2018-03-13T22:03:39Z","git_url":"git://github.com/kubernetes/ingress-gce.git","ssh_url":"git@github.com:kubernetes/ingress-gce.git","clone_url":"https://github.com/kubernetes/ingress-gce.git","svn_url":"https://github.com/kubernetes/ingress-gce","homepage":"","size":33388,"stargazers_count":140,"watchers_count":140,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":46,"open_issues":40,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/148"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/148"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/5190ea453769a592a5257e7a81abb9bde55461a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rramkumar1"}}