{"action":"opened","number":2871,"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2871","id":226463677,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDYzNjc3","html_url":"https://github.com/apache/carbondata/pull/2871","diff_url":"https://github.com/apache/carbondata/pull/2871.diff","patch_url":"https://github.com/apache/carbondata/pull/2871.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2871","number":2871,"state":"open","locked":false,"title":"[CARBONDATA-3051] Fix bugs in unclosed streams","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"body":"Failed to run CarbonReaderTests in windows env. This is due to two\r\nproblems in carbondata:\r\n\r\nProblem 1: While encountering problems, we should close all the streams instead of\r\nonly close current one.\r\n\r\nProblem 2: Current FileReader is not singleton nor the fileCache\r\nvariable is a class variable, so it can only provide cache function if\r\nwe pass the object among the methods. After reading version info, the\r\nfileReader cannot be used by other methods, so we must close it.\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [x] Any interfaces changed?\r\n `NA`\r\n - [x] Any backward compatibility impacted?\r\n  `NA`\r\n - [x] Document update required?\r\n `NA`\r\n - [x] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n `NA, only fix bugs`\r\n        - How it is tested? Please attach test report.\r\n `Tested in local machine`\r\n        - Is it a performance related change? Please attach the performance test report.\r\n `NA`\r\n        - Any additional information to help reviewers in testing this change.\r\n        `NA`\r\n - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n `NA`\r\n","created_at":"2018-10-29T07:40:52Z","updated_at":"2018-10-29T07:40:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2871/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2871/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2871/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/bf966bcc9bec3eab286f1fec7679d6e650c050d0","head":{"label":"xuchuanyin:181029_bug_close_stream","ref":"181029_bug_close_stream","sha":"bf966bcc9bec3eab286f1fec7679d6e650c050d0","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"repo":{"id":101835130,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MzUxMzA=","name":"carbondata","full_name":"xuchuanyin/carbondata","private":false,"owner":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xuchuanyin/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/xuchuanyin/carbondata","forks_url":"https://api.github.com/repos/xuchuanyin/carbondata/forks","keys_url":"https://api.github.com/repos/xuchuanyin/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuchuanyin/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuchuanyin/carbondata/teams","hooks_url":"https://api.github.com/repos/xuchuanyin/carbondata/hooks","issue_events_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/xuchuanyin/carbondata/events","assignees_url":"https://api.github.com/repos/xuchuanyin/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/xuchuanyin/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/xuchuanyin/carbondata/tags","blobs_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuchuanyin/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/xuchuanyin/carbondata/languages","stargazers_url":"https://api.github.com/repos/xuchuanyin/carbondata/stargazers","contributors_url":"https://api.github.com/repos/xuchuanyin/carbondata/contributors","subscribers_url":"https://api.github.com/repos/xuchuanyin/carbondata/subscribers","subscription_url":"https://api.github.com/repos/xuchuanyin/carbondata/subscription","commits_url":"https://api.github.com/repos/xuchuanyin/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuchuanyin/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuchuanyin/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuchuanyin/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/xuchuanyin/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuchuanyin/carbondata/merges","archive_url":"https://api.github.com/repos/xuchuanyin/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuchuanyin/carbondata/downloads","issues_url":"https://api.github.com/repos/xuchuanyin/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/xuchuanyin/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/xuchuanyin/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/xuchuanyin/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuchuanyin/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/xuchuanyin/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/xuchuanyin/carbondata/deployments","created_at":"2017-08-30T03:49:15Z","updated_at":"2018-10-19T01:01:26Z","pushed_at":"2018-10-29T07:39:08Z","git_url":"git://github.com/xuchuanyin/carbondata.git","ssh_url":"git@github.com:xuchuanyin/carbondata.git","clone_url":"https://github.com/xuchuanyin/carbondata.git","svn_url":"https://github.com/xuchuanyin/carbondata","homepage":"","size":65009,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"db5da530eca68c347955cf139dc9ab0bb33c5473","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-10-29T06:40:14Z","pushed_at":"2018-10-29T07:17:24Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":64849,"stargazers_count":768,"watchers_count":768,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":466,"open_issues":102,"watchers":768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2871"},"html":{"href":"https://github.com/apache/carbondata/pull/2871"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2871"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2871/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2871/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2871/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/bf966bcc9bec3eab286f1fec7679d6e650c050d0"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"xuchuanyin"}}