{"action":"created","comment":{"url":"https://api.github.com/repos/jihaepat/jtelips/pulls/comments/197679285","pull_request_review_id":131466531,"id":197679285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzY3OTI4NQ==","diff_hunk":"@@ -1,46 +1,101 @@\n from base.types import Type\n+from task.enums import TaskStatus\n from task.models import Task\n \n \n-class ProgrammingTask(Task):\n+class DevelopmentTask(Task):\n     class Meta:\n         proxy = True\n \n     start_child_task_type = Type.PlanTask\n-    next_task_types = (Type.PlanTask,)\n \n \n class PlanTask(Task):\n     class Meta:\n         proxy = True\n \n-    next_task_types = (Type.InterfaceTask,)\n+    next_task_types = (Type.ProgrammingTask,)\n+\n+\n+class ProgrammingTask(Task):\n+    class Meta:\n+        proxy = True\n+\n+    start_child_task_type = Type.InterfaceTask\n+    next_task_types = (Type.ServerVerifyTask, Type.ClientVerifyTask,)\n \n \n class InterfaceTask(Task):\n     class Meta:\n         proxy = True\n \n-    next_task_types = (Type.PlanTask, Type.UnitTestTask,)\n+    next_task_types = (Type.UnitTestTask,)\n \n \n class UnitTestTask(Task):\n     class Meta:\n         proxy = True\n \n-    next_task_types = (Type.PlanTask, Type.InterfaceTask, Type.ImplTask,)\n+    next_task_types = (Type.InterfaceTask, Type.ServerImplTask, Type.ClientImplTask)\n \n \n-class ImplTask(Task):\n+class ServerImplTask(Task):\n     class Meta:\n         proxy = True\n \n-    next_task_types = (Type.PlanTask, Type.UnitTestTask, Type.InterfaceTask, Type.VerifyTask)\n+    next_task_types = (Type.UnitTestTask, Type.InterfaceTask,)\n+\n+    def complete(self, next_type=None):\n+        assert self.task_status.is_finishable(), 'task_status가 complete함수를 호출할 수 없는 값입니다.'\n+        assert all([child.task_status for child in self.parent.childs.all()]), 'parent의 childs가 모두 complete되지 않았습니다.'\n+        if next_type:","path":"programming/models.py","position":58,"original_position":58,"commit_id":"3db8ced07518df277daef1d1c85fc00a90258f39","original_commit_id":"3db8ced07518df277daef1d1c85fc00a90258f39","user":{"login":"gulby","id":15087566,"node_id":"MDQ6VXNlcjE1MDg3NTY2","avatar_url":"https://avatars2.githubusercontent.com/u/15087566?v=4","gravatar_id":"","url":"https://api.github.com/users/gulby","html_url":"https://github.com/gulby","followers_url":"https://api.github.com/users/gulby/followers","following_url":"https://api.github.com/users/gulby/following{/other_user}","gists_url":"https://api.github.com/users/gulby/gists{/gist_id}","starred_url":"https://api.github.com/users/gulby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulby/subscriptions","organizations_url":"https://api.github.com/users/gulby/orgs","repos_url":"https://api.github.com/users/gulby/repos","events_url":"https://api.github.com/users/gulby/events{/privacy}","received_events_url":"https://api.github.com/users/gulby/received_events","type":"User","site_admin":false},"body":"next_task = super().complete(next_type)\r\nif not next_type:\r\n____assert not next_work\r\n____next_task = self.parent.complete(Type.QATask)\r\nreturn next_task","created_at":"2018-06-25T04:53:37Z","updated_at":"2018-06-25T05:01:35Z","html_url":"https://github.com/jihaepat/jtelips/pull/64#discussion_r197679285","pull_request_url":"https://api.github.com/repos/jihaepat/jtelips/pulls/64","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/comments/197679285"},"html":{"href":"https://github.com/jihaepat/jtelips/pull/64#discussion_r197679285"},"pull_request":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/jihaepat/jtelips/pulls/64","id":196893893,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODkzODkz","html_url":"https://github.com/jihaepat/jtelips/pull/64","diff_url":"https://github.com/jihaepat/jtelips/pull/64.diff","patch_url":"https://github.com/jihaepat/jtelips/pull/64.patch","issue_url":"https://api.github.com/repos/jihaepat/jtelips/issues/64","number":64,"state":"open","locked":false,"title":"Issue task app 2","user":{"login":"lhs950204","id":19319167,"node_id":"MDQ6VXNlcjE5MzE5MTY3","avatar_url":"https://avatars0.githubusercontent.com/u/19319167?v=4","gravatar_id":"","url":"https://api.github.com/users/lhs950204","html_url":"https://github.com/lhs950204","followers_url":"https://api.github.com/users/lhs950204/followers","following_url":"https://api.github.com/users/lhs950204/following{/other_user}","gists_url":"https://api.github.com/users/lhs950204/gists{/gist_id}","starred_url":"https://api.github.com/users/lhs950204/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhs950204/subscriptions","organizations_url":"https://api.github.com/users/lhs950204/orgs","repos_url":"https://api.github.com/users/lhs950204/repos","events_url":"https://api.github.com/users/lhs950204/events{/privacy}","received_events_url":"https://api.github.com/users/lhs950204/received_events","type":"User","site_admin":false},"body":"complete 와 오전에 말씀해주신 task구조를 sample.py에 구성하여 현재 작업중입니다.","created_at":"2018-06-23T10:10:30Z","updated_at":"2018-06-25T05:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1ade1e4bb12adb2f390acf440f17bb1705553cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jihaepat/jtelips/pulls/64/commits","review_comments_url":"https://api.github.com/repos/jihaepat/jtelips/pulls/64/comments","review_comment_url":"https://api.github.com/repos/jihaepat/jtelips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jihaepat/jtelips/issues/64/comments","statuses_url":"https://api.github.com/repos/jihaepat/jtelips/statuses/3db8ced07518df277daef1d1c85fc00a90258f39","head":{"label":"jihaepat:issue_task_app_2","ref":"issue_task_app_2","sha":"3db8ced07518df277daef1d1c85fc00a90258f39","user":{"login":"jihaepat","id":37129057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI5MDU3","avatar_url":"https://avatars3.githubusercontent.com/u/37129057?v=4","gravatar_id":"","url":"https://api.github.com/users/jihaepat","html_url":"https://github.com/jihaepat","followers_url":"https://api.github.com/users/jihaepat/followers","following_url":"https://api.github.com/users/jihaepat/following{/other_user}","gists_url":"https://api.github.com/users/jihaepat/gists{/gist_id}","starred_url":"https://api.github.com/users/jihaepat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihaepat/subscriptions","organizations_url":"https://api.github.com/users/jihaepat/orgs","repos_url":"https://api.github.com/users/jihaepat/repos","events_url":"https://api.github.com/users/jihaepat/events{/privacy}","received_events_url":"https://api.github.com/users/jihaepat/received_events","type":"Organization","site_admin":false},"repo":{"id":126777156,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3NzcxNTY=","name":"jtelips","full_name":"jihaepat/jtelips","owner":{"login":"jihaepat","id":37129057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI5MDU3","avatar_url":"https://avatars3.githubusercontent.com/u/37129057?v=4","gravatar_id":"","url":"https://api.github.com/users/jihaepat","html_url":"https://github.com/jihaepat","followers_url":"https://api.github.com/users/jihaepat/followers","following_url":"https://api.github.com/users/jihaepat/following{/other_user}","gists_url":"https://api.github.com/users/jihaepat/gists{/gist_id}","starred_url":"https://api.github.com/users/jihaepat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihaepat/subscriptions","organizations_url":"https://api.github.com/users/jihaepat/orgs","repos_url":"https://api.github.com/users/jihaepat/repos","events_url":"https://api.github.com/users/jihaepat/events{/privacy}","received_events_url":"https://api.github.com/users/jihaepat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jihaepat/jtelips","description":null,"fork":false,"url":"https://api.github.com/repos/jihaepat/jtelips","forks_url":"https://api.github.com/repos/jihaepat/jtelips/forks","keys_url":"https://api.github.com/repos/jihaepat/jtelips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihaepat/jtelips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihaepat/jtelips/teams","hooks_url":"https://api.github.com/repos/jihaepat/jtelips/hooks","issue_events_url":"https://api.github.com/repos/jihaepat/jtelips/issues/events{/number}","events_url":"https://api.github.com/repos/jihaepat/jtelips/events","assignees_url":"https://api.github.com/repos/jihaepat/jtelips/assignees{/user}","branches_url":"https://api.github.com/repos/jihaepat/jtelips/branches{/branch}","tags_url":"https://api.github.com/repos/jihaepat/jtelips/tags","blobs_url":"https://api.github.com/repos/jihaepat/jtelips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihaepat/jtelips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihaepat/jtelips/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihaepat/jtelips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihaepat/jtelips/statuses/{sha}","languages_url":"https://api.github.com/repos/jihaepat/jtelips/languages","stargazers_url":"https://api.github.com/repos/jihaepat/jtelips/stargazers","contributors_url":"https://api.github.com/repos/jihaepat/jtelips/contributors","subscribers_url":"https://api.github.com/repos/jihaepat/jtelips/subscribers","subscription_url":"https://api.github.com/repos/jihaepat/jtelips/subscription","commits_url":"https://api.github.com/repos/jihaepat/jtelips/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihaepat/jtelips/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihaepat/jtelips/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihaepat/jtelips/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihaepat/jtelips/contents/{+path}","compare_url":"https://api.github.com/repos/jihaepat/jtelips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihaepat/jtelips/merges","archive_url":"https://api.github.com/repos/jihaepat/jtelips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihaepat/jtelips/downloads","issues_url":"https://api.github.com/repos/jihaepat/jtelips/issues{/number}","pulls_url":"https://api.github.com/repos/jihaepat/jtelips/pulls{/number}","milestones_url":"https://api.github.com/repos/jihaepat/jtelips/milestones{/number}","notifications_url":"https://api.github.com/repos/jihaepat/jtelips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihaepat/jtelips/labels{/name}","releases_url":"https://api.github.com/repos/jihaepat/jtelips/releases{/id}","deployments_url":"https://api.github.com/repos/jihaepat/jtelips/deployments","created_at":"2018-03-26T05:23:21Z","updated_at":"2018-06-25T01:13:09Z","pushed_at":"2018-06-25T04:40:03Z","git_url":"git://github.com/jihaepat/jtelips.git","ssh_url":"git@github.com:jihaepat/jtelips.git","clone_url":"https://github.com/jihaepat/jtelips.git","svn_url":"https://github.com/jihaepat/jtelips","homepage":null,"size":10658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"jihaepat:master","ref":"master","sha":"ab74515a55591f855a6af5731df3584e615038ad","user":{"login":"jihaepat","id":37129057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI5MDU3","avatar_url":"https://avatars3.githubusercontent.com/u/37129057?v=4","gravatar_id":"","url":"https://api.github.com/users/jihaepat","html_url":"https://github.com/jihaepat","followers_url":"https://api.github.com/users/jihaepat/followers","following_url":"https://api.github.com/users/jihaepat/following{/other_user}","gists_url":"https://api.github.com/users/jihaepat/gists{/gist_id}","starred_url":"https://api.github.com/users/jihaepat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihaepat/subscriptions","organizations_url":"https://api.github.com/users/jihaepat/orgs","repos_url":"https://api.github.com/users/jihaepat/repos","events_url":"https://api.github.com/users/jihaepat/events{/privacy}","received_events_url":"https://api.github.com/users/jihaepat/received_events","type":"Organization","site_admin":false},"repo":{"id":126777156,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3NzcxNTY=","name":"jtelips","full_name":"jihaepat/jtelips","owner":{"login":"jihaepat","id":37129057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTI5MDU3","avatar_url":"https://avatars3.githubusercontent.com/u/37129057?v=4","gravatar_id":"","url":"https://api.github.com/users/jihaepat","html_url":"https://github.com/jihaepat","followers_url":"https://api.github.com/users/jihaepat/followers","following_url":"https://api.github.com/users/jihaepat/following{/other_user}","gists_url":"https://api.github.com/users/jihaepat/gists{/gist_id}","starred_url":"https://api.github.com/users/jihaepat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihaepat/subscriptions","organizations_url":"https://api.github.com/users/jihaepat/orgs","repos_url":"https://api.github.com/users/jihaepat/repos","events_url":"https://api.github.com/users/jihaepat/events{/privacy}","received_events_url":"https://api.github.com/users/jihaepat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jihaepat/jtelips","description":null,"fork":false,"url":"https://api.github.com/repos/jihaepat/jtelips","forks_url":"https://api.github.com/repos/jihaepat/jtelips/forks","keys_url":"https://api.github.com/repos/jihaepat/jtelips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihaepat/jtelips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihaepat/jtelips/teams","hooks_url":"https://api.github.com/repos/jihaepat/jtelips/hooks","issue_events_url":"https://api.github.com/repos/jihaepat/jtelips/issues/events{/number}","events_url":"https://api.github.com/repos/jihaepat/jtelips/events","assignees_url":"https://api.github.com/repos/jihaepat/jtelips/assignees{/user}","branches_url":"https://api.github.com/repos/jihaepat/jtelips/branches{/branch}","tags_url":"https://api.github.com/repos/jihaepat/jtelips/tags","blobs_url":"https://api.github.com/repos/jihaepat/jtelips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihaepat/jtelips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihaepat/jtelips/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihaepat/jtelips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihaepat/jtelips/statuses/{sha}","languages_url":"https://api.github.com/repos/jihaepat/jtelips/languages","stargazers_url":"https://api.github.com/repos/jihaepat/jtelips/stargazers","contributors_url":"https://api.github.com/repos/jihaepat/jtelips/contributors","subscribers_url":"https://api.github.com/repos/jihaepat/jtelips/subscribers","subscription_url":"https://api.github.com/repos/jihaepat/jtelips/subscription","commits_url":"https://api.github.com/repos/jihaepat/jtelips/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihaepat/jtelips/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihaepat/jtelips/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihaepat/jtelips/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihaepat/jtelips/contents/{+path}","compare_url":"https://api.github.com/repos/jihaepat/jtelips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihaepat/jtelips/merges","archive_url":"https://api.github.com/repos/jihaepat/jtelips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihaepat/jtelips/downloads","issues_url":"https://api.github.com/repos/jihaepat/jtelips/issues{/number}","pulls_url":"https://api.github.com/repos/jihaepat/jtelips/pulls{/number}","milestones_url":"https://api.github.com/repos/jihaepat/jtelips/milestones{/number}","notifications_url":"https://api.github.com/repos/jihaepat/jtelips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihaepat/jtelips/labels{/name}","releases_url":"https://api.github.com/repos/jihaepat/jtelips/releases{/id}","deployments_url":"https://api.github.com/repos/jihaepat/jtelips/deployments","created_at":"2018-03-26T05:23:21Z","updated_at":"2018-06-25T01:13:09Z","pushed_at":"2018-06-25T04:40:03Z","git_url":"git://github.com/jihaepat/jtelips.git","ssh_url":"git@github.com:jihaepat/jtelips.git","clone_url":"https://github.com/jihaepat/jtelips.git","svn_url":"https://github.com/jihaepat/jtelips","homepage":null,"size":10658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/64"},"html":{"href":"https://github.com/jihaepat/jtelips/pull/64"},"issue":{"href":"https://api.github.com/repos/jihaepat/jtelips/issues/64"},"comments":{"href":"https://api.github.com/repos/jihaepat/jtelips/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jihaepat/jtelips/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/jihaepat/jtelips/statuses/3db8ced07518df277daef1d1c85fc00a90258f39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gulby"}}