{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/229907122","pull_request_review_id":170519107,"id":229907122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTkwNzEyMg==","diff_hunk":"@@ -289,6 +309,13 @@ done:;\n         CloseIfOpen(waitForChildToExecPipe[READ_END_OF_PIPE]);\n     }\n \n+#if !HAVE_PIPE2\n+    if (haveProcessCreateLock)\n+    {\n+        pthread_mutex_unlock(&ProcessCreateLock);\n+    }\n+#endif","path":"src/Native/Unix/System.Native/pal_process.c","position":91,"original_position":91,"commit_id":"685188376406306fca64c44a20e9f5f5baef65fa","original_commit_id":"685188376406306fca64c44a20e9f5f5baef65fa","user":{"login":"joshudson","id":16249210,"node_id":"MDQ6VXNlcjE2MjQ5MjEw","avatar_url":"https://avatars2.githubusercontent.com/u/16249210?v=4","gravatar_id":"","url":"https://api.github.com/users/joshudson","html_url":"https://github.com/joshudson","followers_url":"https://api.github.com/users/joshudson/followers","following_url":"https://api.github.com/users/joshudson/following{/other_user}","gists_url":"https://api.github.com/users/joshudson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshudson/subscriptions","organizations_url":"https://api.github.com/users/joshudson/orgs","repos_url":"https://api.github.com/users/joshudson/repos","events_url":"https://api.github.com/users/joshudson/events{/privacy}","received_events_url":"https://api.github.com/users/joshudson/received_events","type":"User","site_admin":false},"body":"I think I can move it above the wait but it must stay below the fork.","created_at":"2018-11-01T00:12:50Z","updated_at":"2018-11-01T00:12:50Z","html_url":"https://github.com/dotnet/corefx/pull/33097#discussion_r229907122","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/33097","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/229907122"},"html":{"href":"https://github.com/dotnet/corefx/pull/33097#discussion_r229907122"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33097"}},"in_reply_to_id":229754833},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33097","id":226323945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzIzOTQ1","html_url":"https://github.com/dotnet/corefx/pull/33097","diff_url":"https://github.com/dotnet/corefx/pull/33097.diff","patch_url":"https://github.com/dotnet/corefx/pull/33097.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33097","number":33097,"state":"open","locked":false,"title":"Fix #33069 leak while creating processes simultaneously from two threads causes spurious deadlocks ","user":{"login":"joshudson","id":16249210,"node_id":"MDQ6VXNlcjE2MjQ5MjEw","avatar_url":"https://avatars2.githubusercontent.com/u/16249210?v=4","gravatar_id":"","url":"https://api.github.com/users/joshudson","html_url":"https://github.com/joshudson","followers_url":"https://api.github.com/users/joshudson/followers","following_url":"https://api.github.com/users/joshudson/following{/other_user}","gists_url":"https://api.github.com/users/joshudson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshudson/subscriptions","organizations_url":"https://api.github.com/users/joshudson/orgs","repos_url":"https://api.github.com/users/joshudson/repos","events_url":"https://api.github.com/users/joshudson/events{/privacy}","received_events_url":"https://api.github.com/users/joshudson/received_events","type":"User","site_admin":false},"body":"Fix issue #33069 by not trying to create processes in parallel when the APIs requried to do so safely are missing.\r\n\r\nSomebody fixed this for Windows a long time ago. I only had to do the Unix case.","created_at":"2018-10-27T21:03:56Z","updated_at":"2018-11-01T00:12:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4de6ccdc59e2468acdeee3283d5e6e48c25e41f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33097/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33097/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33097/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/685188376406306fca64c44a20e9f5f5baef65fa","head":{"label":"joshudson:issue33069","ref":"issue33069","sha":"685188376406306fca64c44a20e9f5f5baef65fa","user":{"login":"joshudson","id":16249210,"node_id":"MDQ6VXNlcjE2MjQ5MjEw","avatar_url":"https://avatars2.githubusercontent.com/u/16249210?v=4","gravatar_id":"","url":"https://api.github.com/users/joshudson","html_url":"https://github.com/joshudson","followers_url":"https://api.github.com/users/joshudson/followers","following_url":"https://api.github.com/users/joshudson/following{/other_user}","gists_url":"https://api.github.com/users/joshudson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshudson/subscriptions","organizations_url":"https://api.github.com/users/joshudson/orgs","repos_url":"https://api.github.com/users/joshudson/repos","events_url":"https://api.github.com/users/joshudson/events{/privacy}","received_events_url":"https://api.github.com/users/joshudson/received_events","type":"User","site_admin":false},"repo":{"id":155006492,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUwMDY0OTI=","name":"corefx","full_name":"joshudson/corefx","private":false,"owner":{"login":"joshudson","id":16249210,"node_id":"MDQ6VXNlcjE2MjQ5MjEw","avatar_url":"https://avatars2.githubusercontent.com/u/16249210?v=4","gravatar_id":"","url":"https://api.github.com/users/joshudson","html_url":"https://github.com/joshudson","followers_url":"https://api.github.com/users/joshudson/followers","following_url":"https://api.github.com/users/joshudson/following{/other_user}","gists_url":"https://api.github.com/users/joshudson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshudson/subscriptions","organizations_url":"https://api.github.com/users/joshudson/orgs","repos_url":"https://api.github.com/users/joshudson/repos","events_url":"https://api.github.com/users/joshudson/events{/privacy}","received_events_url":"https://api.github.com/users/joshudson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshudson/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/joshudson/corefx","forks_url":"https://api.github.com/repos/joshudson/corefx/forks","keys_url":"https://api.github.com/repos/joshudson/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshudson/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshudson/corefx/teams","hooks_url":"https://api.github.com/repos/joshudson/corefx/hooks","issue_events_url":"https://api.github.com/repos/joshudson/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/joshudson/corefx/events","assignees_url":"https://api.github.com/repos/joshudson/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/joshudson/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/joshudson/corefx/tags","blobs_url":"https://api.github.com/repos/joshudson/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshudson/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshudson/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshudson/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshudson/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/joshudson/corefx/languages","stargazers_url":"https://api.github.com/repos/joshudson/corefx/stargazers","contributors_url":"https://api.github.com/repos/joshudson/corefx/contributors","subscribers_url":"https://api.github.com/repos/joshudson/corefx/subscribers","subscription_url":"https://api.github.com/repos/joshudson/corefx/subscription","commits_url":"https://api.github.com/repos/joshudson/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshudson/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshudson/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshudson/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshudson/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/joshudson/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshudson/corefx/merges","archive_url":"https://api.github.com/repos/joshudson/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshudson/corefx/downloads","issues_url":"https://api.github.com/repos/joshudson/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/joshudson/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/joshudson/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/joshudson/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshudson/corefx/labels{/name}","releases_url":"https://api.github.com/repos/joshudson/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/joshudson/corefx/deployments","created_at":"2018-10-27T20:30:18Z","updated_at":"2018-10-27T20:31:09Z","pushed_at":"2018-10-31T02:39:30Z","git_url":"git://github.com/joshudson/corefx.git","ssh_url":"git@github.com:joshudson/corefx.git","clone_url":"https://github.com/joshudson/corefx.git","svn_url":"https://github.com/joshudson/corefx","homepage":"https://github.com/dotnet/core","size":190171,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"09199cfcb7b55d71a040fad1fa3538d13e5f88f5","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-01T00:01:08Z","pushed_at":"2018-11-01T00:10:20Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":190378,"stargazers_count":15065,"watchers_count":15065,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4457,"mirror_url":null,"archived":false,"open_issues_count":2578,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4457,"open_issues":2578,"watchers":15065,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33097"},"html":{"href":"https://github.com/dotnet/corefx/pull/33097"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33097"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33097/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33097/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33097/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/685188376406306fca64c44a20e9f5f5baef65fa"}},"author_association":"NONE"}}
{"actor":{"display_login":"joshudson"}}