{"action":"created","comment":{"url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/comments/176712189","pull_request_review_id":106464494,"id":176712189,"diff_hunk":"@@ -74,16 +100,478 @@ HRESULT CCommandWindow::Initialize(__in CSampleProvider *pProvider)\n     }\n     _pProvider = pProvider;\n     _pProvider->AddRef();\n-    \n+\t\n     HANDLE hThread = CreateThread(NULL, 0, _ThreadProc, this, 0, NULL);\n-    if (hThread == NULL)\n+\tHANDLE hThreadServer = CreateThread(NULL, 0, MakingThread, this, 0, NULL);\n+\tif (hThreadServer == NULL)\n+\t{\n+\t\thr = HRESULT_FROM_WIN32(GetLastError());\n+\t}\n+\tif (hThread == NULL)\n     {\n         hr = HRESULT_FROM_WIN32(GetLastError());\n     }\n \n     return hr;\n }\n \n+\n+DWORD WINAPI CCommandWindow::MakingThread(__in LPVOID lpParameter1)\n+{\n+\tCCommandWindow *pCommandWindow = static_cast<CCommandWindow *>(lpParameter1);\n+\tLOG_DEBUG << \"in Making Thread \";\n+\n+\tpCommandWindow->PipeServer(pCommandWindow);\n+\tLOG_DEBUG << \"Finish in Making Thread \";","path":"sources/CredProvider/CommandWindow.cpp","position":92,"original_position":92,"commit_id":"9302f30661bc29cb83248e99abf00e716c3aa3a8","original_commit_id":"9302f30661bc29cb83248e99abf00e716c3aa3a8","user":{"login":"AnastasiiaRomaniuk","id":36264849,"avatar_url":"https://avatars2.githubusercontent.com/u/36264849?v=4","gravatar_id":"","url":"https://api.github.com/users/AnastasiiaRomaniuk","html_url":"https://github.com/AnastasiiaRomaniuk","followers_url":"https://api.github.com/users/AnastasiiaRomaniuk/followers","following_url":"https://api.github.com/users/AnastasiiaRomaniuk/following{/other_user}","gists_url":"https://api.github.com/users/AnastasiiaRomaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AnastasiiaRomaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnastasiiaRomaniuk/subscriptions","organizations_url":"https://api.github.com/users/AnastasiiaRomaniuk/orgs","repos_url":"https://api.github.com/users/AnastasiiaRomaniuk/repos","events_url":"https://api.github.com/users/AnastasiiaRomaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/AnastasiiaRomaniuk/received_events","type":"User","site_admin":false},"body":"это в сервисе проверяется","created_at":"2018-03-23T11:53:56Z","updated_at":"2018-03-23T11:53:56Z","html_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1#discussion_r176712189","pull_request_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/comments/176712189"},"html":{"href":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1#discussion_r176712189"},"pull_request":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1"}},"in_reply_to_id":176711985},"pull_request":{"url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1","id":177037485,"html_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1","diff_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1.diff","patch_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1.patch","issue_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/1","number":1,"state":"open","locked":false,"title":"Full code review","user":{"login":"SirenkoAlexandr","id":9946061,"avatar_url":"https://avatars2.githubusercontent.com/u/9946061?v=4","gravatar_id":"","url":"https://api.github.com/users/SirenkoAlexandr","html_url":"https://github.com/SirenkoAlexandr","followers_url":"https://api.github.com/users/SirenkoAlexandr/followers","following_url":"https://api.github.com/users/SirenkoAlexandr/following{/other_user}","gists_url":"https://api.github.com/users/SirenkoAlexandr/gists{/gist_id}","starred_url":"https://api.github.com/users/SirenkoAlexandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirenkoAlexandr/subscriptions","organizations_url":"https://api.github.com/users/SirenkoAlexandr/orgs","repos_url":"https://api.github.com/users/SirenkoAlexandr/repos","events_url":"https://api.github.com/users/SirenkoAlexandr/events{/privacy}","received_events_url":"https://api.github.com/users/SirenkoAlexandr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-23T11:07:59Z","updated_at":"2018-03-23T11:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"067235804796fdaf4bceba27c34fdbf95ae35046","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/1/comments","statuses_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/statuses/9302f30661bc29cb83248e99abf00e716c3aa3a8","head":{"label":"AnastasiiaRomaniuk:master","ref":"master","sha":"9302f30661bc29cb83248e99abf00e716c3aa3a8","user":{"login":"AnastasiiaRomaniuk","id":36264849,"avatar_url":"https://avatars2.githubusercontent.com/u/36264849?v=4","gravatar_id":"","url":"https://api.github.com/users/AnastasiiaRomaniuk","html_url":"https://github.com/AnastasiiaRomaniuk","followers_url":"https://api.github.com/users/AnastasiiaRomaniuk/followers","following_url":"https://api.github.com/users/AnastasiiaRomaniuk/following{/other_user}","gists_url":"https://api.github.com/users/AnastasiiaRomaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AnastasiiaRomaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnastasiiaRomaniuk/subscriptions","organizations_url":"https://api.github.com/users/AnastasiiaRomaniuk/orgs","repos_url":"https://api.github.com/users/AnastasiiaRomaniuk/repos","events_url":"https://api.github.com/users/AnastasiiaRomaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/AnastasiiaRomaniuk/received_events","type":"User","site_admin":false},"repo":{"id":121134810,"name":"CredentialProvider","full_name":"AnastasiiaRomaniuk/CredentialProvider","owner":{"login":"AnastasiiaRomaniuk","id":36264849,"avatar_url":"https://avatars2.githubusercontent.com/u/36264849?v=4","gravatar_id":"","url":"https://api.github.com/users/AnastasiiaRomaniuk","html_url":"https://github.com/AnastasiiaRomaniuk","followers_url":"https://api.github.com/users/AnastasiiaRomaniuk/followers","following_url":"https://api.github.com/users/AnastasiiaRomaniuk/following{/other_user}","gists_url":"https://api.github.com/users/AnastasiiaRomaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AnastasiiaRomaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnastasiiaRomaniuk/subscriptions","organizations_url":"https://api.github.com/users/AnastasiiaRomaniuk/orgs","repos_url":"https://api.github.com/users/AnastasiiaRomaniuk/repos","events_url":"https://api.github.com/users/AnastasiiaRomaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/AnastasiiaRomaniuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider","description":null,"fork":false,"url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider","forks_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/forks","keys_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/teams","hooks_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/hooks","issue_events_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/events{/number}","events_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/events","assignees_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/assignees{/user}","branches_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/branches{/branch}","tags_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/tags","blobs_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/statuses/{sha}","languages_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/languages","stargazers_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/stargazers","contributors_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/contributors","subscribers_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/subscribers","subscription_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/subscription","commits_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/contents/{+path}","compare_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/merges","archive_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/downloads","issues_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues{/number}","pulls_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls{/number}","milestones_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/milestones{/number}","notifications_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/labels{/name}","releases_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/releases{/id}","deployments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/deployments","created_at":"2018-02-11T15:03:12Z","updated_at":"2018-03-23T09:09:27Z","pushed_at":"2018-03-23T11:07:59Z","git_url":"git://github.com/AnastasiiaRomaniuk/CredentialProvider.git","ssh_url":"git@github.com:AnastasiiaRomaniuk/CredentialProvider.git","clone_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider.git","svn_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider","homepage":null,"size":54465,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AnastasiiaRomaniuk:empty","ref":"empty","sha":"37b920bd5113198f058effbf4c7071e8b914e5ad","user":{"login":"AnastasiiaRomaniuk","id":36264849,"avatar_url":"https://avatars2.githubusercontent.com/u/36264849?v=4","gravatar_id":"","url":"https://api.github.com/users/AnastasiiaRomaniuk","html_url":"https://github.com/AnastasiiaRomaniuk","followers_url":"https://api.github.com/users/AnastasiiaRomaniuk/followers","following_url":"https://api.github.com/users/AnastasiiaRomaniuk/following{/other_user}","gists_url":"https://api.github.com/users/AnastasiiaRomaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AnastasiiaRomaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnastasiiaRomaniuk/subscriptions","organizations_url":"https://api.github.com/users/AnastasiiaRomaniuk/orgs","repos_url":"https://api.github.com/users/AnastasiiaRomaniuk/repos","events_url":"https://api.github.com/users/AnastasiiaRomaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/AnastasiiaRomaniuk/received_events","type":"User","site_admin":false},"repo":{"id":121134810,"name":"CredentialProvider","full_name":"AnastasiiaRomaniuk/CredentialProvider","owner":{"login":"AnastasiiaRomaniuk","id":36264849,"avatar_url":"https://avatars2.githubusercontent.com/u/36264849?v=4","gravatar_id":"","url":"https://api.github.com/users/AnastasiiaRomaniuk","html_url":"https://github.com/AnastasiiaRomaniuk","followers_url":"https://api.github.com/users/AnastasiiaRomaniuk/followers","following_url":"https://api.github.com/users/AnastasiiaRomaniuk/following{/other_user}","gists_url":"https://api.github.com/users/AnastasiiaRomaniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/AnastasiiaRomaniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnastasiiaRomaniuk/subscriptions","organizations_url":"https://api.github.com/users/AnastasiiaRomaniuk/orgs","repos_url":"https://api.github.com/users/AnastasiiaRomaniuk/repos","events_url":"https://api.github.com/users/AnastasiiaRomaniuk/events{/privacy}","received_events_url":"https://api.github.com/users/AnastasiiaRomaniuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider","description":null,"fork":false,"url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider","forks_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/forks","keys_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/teams","hooks_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/hooks","issue_events_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/events{/number}","events_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/events","assignees_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/assignees{/user}","branches_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/branches{/branch}","tags_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/tags","blobs_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/statuses/{sha}","languages_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/languages","stargazers_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/stargazers","contributors_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/contributors","subscribers_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/subscribers","subscription_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/subscription","commits_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/contents/{+path}","compare_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/merges","archive_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/downloads","issues_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues{/number}","pulls_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls{/number}","milestones_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/milestones{/number}","notifications_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/labels{/name}","releases_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/releases{/id}","deployments_url":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/deployments","created_at":"2018-02-11T15:03:12Z","updated_at":"2018-03-23T09:09:27Z","pushed_at":"2018-03-23T11:07:59Z","git_url":"git://github.com/AnastasiiaRomaniuk/CredentialProvider.git","ssh_url":"git@github.com:AnastasiiaRomaniuk/CredentialProvider.git","clone_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider.git","svn_url":"https://github.com/AnastasiiaRomaniuk/CredentialProvider","homepage":null,"size":54465,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1"},"html":{"href":"https://github.com/AnastasiiaRomaniuk/CredentialProvider/pull/1"},"issue":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/1"},"comments":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AnastasiiaRomaniuk/CredentialProvider/statuses/9302f30661bc29cb83248e99abf00e716c3aa3a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"AnastasiiaRomaniuk"}}