{"action":"created","issue":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/2171","repository_url":"https://api.github.com/repos/apache/activemq-artemis","labels_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2171/labels{/name}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2171/comments","events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2171/events","html_url":"https://github.com/apache/activemq-artemis/pull/2171","id":338504150,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDE2NzI1","number":2171,"title":"ARTEMIS-1966 Replication channel closed but not connection if flow co…","user":{"login":"wy96f","id":7719761,"node_id":"MDQ6VXNlcjc3MTk3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7719761?v=4","gravatar_id":"","url":"https://api.github.com/users/wy96f","html_url":"https://github.com/wy96f","followers_url":"https://api.github.com/users/wy96f/followers","following_url":"https://api.github.com/users/wy96f/following{/other_user}","gists_url":"https://api.github.com/users/wy96f/gists{/gist_id}","starred_url":"https://api.github.com/users/wy96f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wy96f/subscriptions","organizations_url":"https://api.github.com/users/wy96f/orgs","repos_url":"https://api.github.com/users/wy96f/repos","events_url":"https://api.github.com/users/wy96f/events{/privacy}","received_events_url":"https://api.github.com/users/wy96f/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-05T09:52:54Z","updated_at":"2018-07-12T17:42:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2171","html_url":"https://github.com/apache/activemq-artemis/pull/2171","diff_url":"https://github.com/apache/activemq-artemis/pull/2171.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2171.patch"},"body":"We use SharedNothing Activation. If flow control occurs during replication, replication channel would be closed and enabled flag  is set to false. After it, the message would not be sent to backup node. If live server crashes at this time, the backup node will fail over, resulting in data loss.\r\n\r\nSo we close connection if flow controlled, then backup node would be signaled failure replicating and restart server."},"comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments/404592704","html_url":"https://github.com/apache/activemq-artemis/pull/2171#issuecomment-404592704","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2171","id":404592704,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDU5MjcwNA==","user":{"login":"clebertsuconic","id":750514,"node_id":"MDQ6VXNlcjc1MDUxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/750514?v=4","gravatar_id":"","url":"https://api.github.com/users/clebertsuconic","html_url":"https://github.com/clebertsuconic","followers_url":"https://api.github.com/users/clebertsuconic/followers","following_url":"https://api.github.com/users/clebertsuconic/following{/other_user}","gists_url":"https://api.github.com/users/clebertsuconic/gists{/gist_id}","starred_url":"https://api.github.com/users/clebertsuconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebertsuconic/subscriptions","organizations_url":"https://api.github.com/users/clebertsuconic/orgs","repos_url":"https://api.github.com/users/clebertsuconic/repos","events_url":"https://api.github.com/users/clebertsuconic/events{/privacy}","received_events_url":"https://api.github.com/users/clebertsuconic/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T17:42:32Z","updated_at":"2018-07-12T17:42:32Z","author_association":"CONTRIBUTOR","body":"Thanks... I'm also adding a commit to improve the test you added. Take a look please for future references. (I decided to just change it instead of asking the change here).\r\n\r\nthanks a lot."}}
{"actor":{"display_login":"clebertsuconic"}}