{"action":"created","issue":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/118","repository_url":"https://api.github.com/repos/jeyvison/liferay-portal","labels_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/118/comments","events_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/118/events","html_url":"https://github.com/jeyvison/liferay-portal/pull/118","id":357194183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjY2NzA2","number":118,"title":"LPS-83662 Use ActionableDynamicQuery instead of traversing through the KaleoTaskAssignments ","user":{"login":"IstvanD","id":6039187,"node_id":"MDQ6VXNlcjYwMzkxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6039187?v=4","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"labels":[{"id":877120916,"node_id":"MDU6TGFiZWw4NzcxMjA5MTY=","url":"https://api.github.com/repos/jeyvison/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false},{"id":911633441,"node_id":"MDU6TGFiZWw5MTE2MzM0NDE=","url":"https://api.github.com/repos/jeyvison/liferay-portal/labels/ci:test:relevant%20-%20failure","name":"ci:test:relevant - failure","color":"fccdcc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-09-05T11:55:19Z","updated_at":"2018-09-07T07:34:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/pulls/118","html_url":"https://github.com/jeyvison/liferay-portal/pull/118","diff_url":"https://github.com/jeyvison/liferay-portal/pull/118.diff","patch_url":"https://github.com/jeyvison/liferay-portal/pull/118.patch"},"body":"Hey @jeyvison \r\n\r\nFollowing you suggestions in https://github.com/jeyvison/liferay-portal/pull/113#discussion_r214995840 it resorted to use ActionableDynamicQuery to fetch and delete the task assignments.\r\nI'm not yet sure how to handle the other cases though.\r\nNotifications about non-existent tasks are deleted automatically as the user views the Notifications portlet, and they also cannot view the task assignment once it's role is deleted.\r\nWorkflowInstanceLinks contain the information on what asset should they operation (for example JournalArticle if the article has to be approved/rejected) but not on the roles.\r\nIs there are way to fetch the information about the roles, so it could be checked if any of them are assigned to it?\r\n\r\nThank you!\r\n\r\nBest regards,\r\nIstván"},"comment":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/comments/419350630","html_url":"https://github.com/jeyvison/liferay-portal/pull/118#issuecomment-419350630","issue_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/118","id":419350630,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTM1MDYzMA==","user":{"login":"IstvanD","id":6039187,"node_id":"MDQ6VXNlcjYwMzkxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6039187?v=4","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T07:34:56Z","updated_at":"2018-09-07T07:34:56Z","author_association":"NONE","body":"Hi @jeyvison \r\n\r\nThank you for showing your point.\r\n\r\nI made the test with creating a user (UserA), and assigning him the Site Content Reviewer role. As the default Test user, I submitted a Web Content for publication, and both UserA and I received notifications, and we also received entries in our Workflow tasks.\r\nThen I deleted the Site Content Reviewer role. As UserA, I could see the \"Notification no longer applied\", and then the notification was automatically deleted. UserA also could not see his assigned workflow task.\r\nAs the default Test user, the notification and the workflow task were still there.\r\nI assume, that the default Test user has roles that enables him to review content, aside from the Site Content Reviewer role.\r\n"}}
{"actor":{"display_login":"IstvanD"}}