{"action":"created","issue":{"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/29","repository_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules","labels_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/29/comments","events_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/29/events","html_url":"https://github.com/cms-gem-daq-project/ctp7_modules/pull/29","id":303932863,"number":29,"title":"Refactoring, documentation and status/monitoring tools","user":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"labels":[{"id":671530945,"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/labels/Priority:%20High","name":"Priority: High","color":"ff8000","default":false},{"id":671530949,"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/labels/Status:%20Review%20Needed","name":"Status: Review Needed","color":"ff8000","default":false},{"id":671530958,"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false},{"id":671530950,"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/labels/Type:%20Maintenance","name":"Type: Maintenance","color":"2e9afe","default":false}],"state":"open","locked":false,"assignee":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"assignees":[{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/milestones/4","html_url":"https://github.com/cms-gem-daq-project/ctp7_modules/milestone/4","labels_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/milestones/4/labels","id":3174757,"number":4,"title":"Release v1.0.0","description":"","creator":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-03-09T18:16:08Z","updated_at":"2018-03-09T18:16:59Z","due_on":"2018-03-23T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-03-09T18:16:15Z","updated_at":"2018-04-16T19:25:07Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/pulls/29","html_url":"https://github.com/cms-gem-daq-project/ctp7_modules/pull/29","diff_url":"https://github.com/cms-gem-daq-project/ctp7_modules/pull/29.diff","patch_url":"https://github.com/cms-gem-daq-project/ctp7_modules/pull/29.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nFixes #21, #25, #27, #30 and adds documentation and status/monitoring tools requested in #19 \r\nRequires https://github.com/cms-gem-daq-project/xhal/pull/54\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n**New features**:\r\n* `statusVFAT3s` method \r\n* `statusOH` method\r\n* added `Doxygen`-style documentation\r\n* Major refactoring, headers and sources are properly populated now, `Makefile` altered to reflect the changes\r\n\r\n**Breaking changes**:\r\n* Modules updated according to name conventions described in #6 \r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue(s) here. -->\r\nProvides documentation and puts code in better order\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n### Screenshots (if appropriate):\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n<!--- Template thanks to https://www.talater.com/open-source-templates/#/page/99 -->"},"comment":{"url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/comments/381720108","html_url":"https://github.com/cms-gem-daq-project/ctp7_modules/pull/29#issuecomment-381720108","issue_url":"https://api.github.com/repos/cms-gem-daq-project/ctp7_modules/issues/29","id":381720108,"user":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T19:25:07Z","updated_at":"2018-04-16T19:25:07Z","author_association":"COLLABORATOR","body":"The issue is solved by this commit: https://github.com/cms-gem-daq-project/ctp7_modules/pull/29/commits/2d22de6b1018c2410de5c3f9893c12bc17891c4a\r\nI don't know why it doesn't appear in a main dialog window where you've started a review... Maybe it holds the old one... However the change is there"}}
{"actor":{"display_login":"mexanick"}}