{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19","id":189197464,"html_url":"https://github.com/sanctuary-js/sanctuary-style/pull/19","diff_url":"https://github.com/sanctuary-js/sanctuary-style/pull/19.diff","patch_url":"https://github.com/sanctuary-js/sanctuary-style/pull/19.patch","issue_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/19","number":19,"state":"closed","locked":false,"title":"eslint: disable \"prefer-template\" rule","user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"body":"I have found the `prefer-template` rule to be overly prescriptive, and have disabled it in several projects. I see the appeal of a consistent approach to string concatenation, but template literals are significantly noisier in some cases. Consider the following examples:\r\n\r\n```javascript\r\n`${x}${y}`\r\n`${x} ${y}`\r\n`${f (x)}${f (y)}`\r\n`${f (x)} ${f (y)}`\r\n```\r\n\r\nThe equivalent expressions without template literals read better:\r\n\r\n```javascript\r\nx + y\r\nx + ' ' + y\r\nf (x) + f (y)\r\nf (x) + ' ' + f (y)\r\n```\r\n\r\nIn some cases, of course, template literals are the better option. By disabling the `prefer-template` rule we allow authors to exercise their judgement.\r\n","created_at":"2018-05-19T17:11:14Z","updated_at":"2018-05-19T17:11:57Z","closed_at":"2018-05-19T17:11:57Z","merged_at":"2018-05-19T17:11:57Z","merge_commit_sha":"a4d6a428f0a8aec8da1b938169badf5e9f07fcb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19/commits","review_comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19/comments","review_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/19/comments","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/statuses/88e58e72f3b897c2fb5bf6d9cda3febac0f13627","head":{"label":"sanctuary-js:davidchambers/eslint","ref":"davidchambers/eslint","sha":"88e58e72f3b897c2fb5bf6d9cda3febac0f13627","user":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"repo":{"id":57527299,"name":"sanctuary-style","full_name":"sanctuary-js/sanctuary-style","owner":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanctuary-js/sanctuary-style","description":"ESLint configuration","fork":false,"url":"https://api.github.com/repos/sanctuary-js/sanctuary-style","forks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/forks","keys_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/teams","hooks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/hooks","issue_events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/events{/number}","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/events","assignees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/assignees{/user}","branches_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/branches{/branch}","tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/tags","blobs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/statuses/{sha}","languages_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/languages","stargazers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/stargazers","contributors_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/contributors","subscribers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/subscribers","subscription_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/subscription","commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/contents/{+path}","compare_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/merges","archive_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/downloads","issues_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues{/number}","pulls_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls{/number}","milestones_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/milestones{/number}","notifications_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/labels{/name}","releases_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/releases{/id}","deployments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/deployments","created_at":"2016-05-01T05:38:09Z","updated_at":"2018-05-19T16:53:26Z","pushed_at":"2018-05-19T17:11:57Z","git_url":"git://github.com/sanctuary-js/sanctuary-style.git","ssh_url":"git@github.com:sanctuary-js/sanctuary-style.git","clone_url":"https://github.com/sanctuary-js/sanctuary-style.git","svn_url":"https://github.com/sanctuary-js/sanctuary-style","homepage":null,"size":41,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"sanctuary-js:master","ref":"master","sha":"bd300b1bd148de28f37c7ea721a252e1a62c561c","user":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"repo":{"id":57527299,"name":"sanctuary-style","full_name":"sanctuary-js/sanctuary-style","owner":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanctuary-js/sanctuary-style","description":"ESLint configuration","fork":false,"url":"https://api.github.com/repos/sanctuary-js/sanctuary-style","forks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/forks","keys_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/teams","hooks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/hooks","issue_events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/events{/number}","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/events","assignees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/assignees{/user}","branches_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/branches{/branch}","tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/tags","blobs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/statuses/{sha}","languages_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/languages","stargazers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/stargazers","contributors_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/contributors","subscribers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/subscribers","subscription_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/subscription","commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/contents/{+path}","compare_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/merges","archive_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/downloads","issues_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues{/number}","pulls_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls{/number}","milestones_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/milestones{/number}","notifications_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/labels{/name}","releases_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/releases{/id}","deployments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-style/deployments","created_at":"2016-05-01T05:38:09Z","updated_at":"2018-05-19T16:53:26Z","pushed_at":"2018-05-19T17:11:57Z","git_url":"git://github.com/sanctuary-js/sanctuary-style.git","ssh_url":"git@github.com:sanctuary-js/sanctuary-style.git","clone_url":"https://github.com/sanctuary-js/sanctuary-style.git","svn_url":"https://github.com/sanctuary-js/sanctuary-style","homepage":null,"size":41,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19"},"html":{"href":"https://github.com/sanctuary-js/sanctuary-style/pull/19"},"issue":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/19"},"comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-style/statuses/88e58e72f3b897c2fb5bf6d9cda3febac0f13627"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"davidchambers"}}