{"action":"closed","issue":{"url":"https://api.github.com/repos/broccolijs/broccoli/issues/360","repository_url":"https://api.github.com/repos/broccolijs/broccoli","labels_url":"https://api.github.com/repos/broccolijs/broccoli/issues/360/labels{/name}","comments_url":"https://api.github.com/repos/broccolijs/broccoli/issues/360/comments","events_url":"https://api.github.com/repos/broccolijs/broccoli/issues/360/events","html_url":"https://github.com/broccolijs/broccoli/issues/360","id":310902082,"node_id":"MDU6SXNzdWUzMTA5MDIwODI=","number":360,"title":"Port ember-cli/broccoli-builder to master","user":{"login":"oligriffiths","id":1246671,"node_id":"MDQ6VXNlcjEyNDY2NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1246671?v=4","gravatar_id":"","url":"https://api.github.com/users/oligriffiths","html_url":"https://github.com/oligriffiths","followers_url":"https://api.github.com/users/oligriffiths/followers","following_url":"https://api.github.com/users/oligriffiths/following{/other_user}","gists_url":"https://api.github.com/users/oligriffiths/gists{/gist_id}","starred_url":"https://api.github.com/users/oligriffiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oligriffiths/subscriptions","organizations_url":"https://api.github.com/users/oligriffiths/orgs","repos_url":"https://api.github.com/users/oligriffiths/repos","events_url":"https://api.github.com/users/oligriffiths/events{/privacy}","received_events_url":"https://api.github.com/users/oligriffiths/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-03T16:10:52Z","updated_at":"2018-11-29T17:11:15Z","closed_at":"2018-11-29T17:11:15Z","author_association":"CONTRIBUTOR","body":"I am going to attempt to summarize the work that needs to be done to port the changes made to https://github.com/ember-cli/broccoli-builder into broccoli, so that the fork can be retired and `ember-cli` can use broccoli master\r\n\r\n# Glossary:\r\n* `master` refers to https://github.com/broccolijs/broccoli/tree/master\r\n* `0-18-x` refers to https://github.com/ember-cli/broccoli-builder/tree/0-18-x\r\n* Branch point: The commit `ab404ef725be5c265c901838be40d0358a867ec4` that ember-cli/broccoli-builder branched from broccoli master\r\n* Branch point + tests: The commit just after branch point, `f5a1f3ddb1a01a4a9c312be12f1efed2b6d38611` that the test suite was converted from tap to mocha and exists in `master` but not `0-18-x`\r\n\r\n# Diff:\r\nI created a patch from `branch-point-with-tests` to `0-18-x` https://github.com/oligriffiths/broccoli-builder/pull/7 that shows the changes basically from the whole 0-18-x series so we can see what has actually changed (minus file deletions and the conversion of the test suite from tap to mocha).\r\n\r\n# Todo:\r\n* [x] On `0-18-x`, port test suite to mocha from `branch point + tests`, as this happened *just* after the branch point, so to make comparisons easier I have ported the test suite to use mocha\r\n* [x] On `master`, add the ability to overwrite a `dist` directory without having to remove the directory first https://github.com/broccolijs/broccoli/pull/354\r\n* [x] On `master`, port the protection of the `dist` directory from `-0-18-x` if it's a direct parent of the project https://github.com/broccolijs/broccoli/pull/358\r\n* [x] On `0-18x` deprecate `api_compat.js`. This was to support the old read API, and is no longer supported in Broccoli and hasn’t been used in ember for some time. Start with a console warning, then remove.  https://github.com/oligriffiths/broccoli-builder/blob/diff/lib/api_compat.js https://github.com/ember-cli/broccoli-builder/pull/26\r\n* [ ] On `0-18x` kill `api_compat.js`.\r\n* [x] On `master`, port `heimdall` stats collection from `0-18-x`  Investigate the event api in Broccoli for this instead of hand jamming: https://github.com/broccolijs/broccoli/pull/362\r\n* [x] On `master`, port `cancellation` from `0-18-x` https://github.com/broccolijs/broccoli/pull/350\r\n* [ ] On `master` port `broccoli-build-error` from `0-18-x` https://github.com/oligriffiths/broccoli-builder/blob/diff/lib/broccoli-build-error.js this is a nicer error output that only shows the stack trace for where the error happened within a Broccoli plugin\r\n* [x] On `master` validate the ability to have the `tmp` directory in the project root (per ember-cli) for compat with addons that have used this hack\r\nhttps://github.com/ember-cli/ember-cli/pull/7798\r\n\r\n# Bonus points\r\n* [ ] Mid-build change events should cancel the current build and queue up behind the existing cancel before kicking off another build. This allows for if a watched file changing mid build, to cancel the current build and kick off a new one. This is out of scope for upstreaming to master. https://github.com/broccolijs/broccoli/pull/350"}}
{"actor":{"display_login":"stefanpenner"}}