{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/190674753","pull_request_review_id":123102934,"id":190674753,"diff_hunk":"@@ -41,45 +41,91 @@ if(BUILD_CAFFE2)\n endif()\n \n # ---[ BLAS\n-if(BUILD_ATEN)\n-  set(BLAS \"MKL\" CACHE STRING \"Selected BLAS library\")\n-else()\n-  set(BLAS \"Eigen\" CACHE STRING \"Selected BLAS library\")\n+if(NOT BLAS_SET_BY_USER)\n+  if(BUILD_ATEN)\n+    set(BLAS \"MKL\" CACHE STRING \"Selected BLAS library\")\n+  else()\n+    set(BLAS \"Eigen\" CACHE STRING \"Selected BLAS library\")\n+  endif()\n endif()\n set_property(CACHE BLAS PROPERTY STRINGS \"Eigen;ATLAS;OpenBLAS;MKL;vecLib\")\n message(STATUS \"The BLAS backend of choice:\" ${BLAS})\n \n-if(BLAS STREQUAL \"Eigen\")\n-  # Eigen is header-only and we do not have any dependent libraries\n-  set(CAFFE2_USE_EIGEN_FOR_BLAS ON)\n-elseif(BLAS STREQUAL \"ATLAS\")\n-  find_package(Atlas REQUIRED)\n-  include_directories(${ATLAS_INCLUDE_DIRS})\n-  list(APPEND Caffe2_PUBLIC_DEPENDENCY_LIBS ${ATLAS_LIBRARIES})\n-  list(APPEND Caffe2_PUBLIC_DEPENDENCY_LIBS cblas)\n+# Atlas\n+if(BLAS STREQUAL \"ATLAS\")\n+  if(BLAS_SET_BY_USER)\n+    find_package(Atlas REQUIRED)\n+  else()\n+    find_package(Atlas)\n+  endif()\n+  if(Atlas_FOUND)","path":"cmake/Dependencies.cmake","position":33,"original_position":33,"commit_id":"5cbc09afcfed2cb20dd719a400d586e2309c3249","original_commit_id":"5cbc09afcfed2cb20dd719a400d586e2309c3249","user":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"body":"The include_directories list-appends have to go after both find_package calls though. I could move if(NOT Atlas_FOUND) with a 'break' into the else(), but that doesn't seem worth it to me","created_at":"2018-05-24T17:50:03Z","updated_at":"2018-05-24T17:50:03Z","html_url":"https://github.com/pytorch/pytorch/pull/7813#discussion_r190674753","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/7813","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/190674753"},"html":{"href":"https://github.com/pytorch/pytorch/pull/7813#discussion_r190674753"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/7813"}},"in_reply_to_id":190672648},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/7813","id":190367493,"html_url":"https://github.com/pytorch/pytorch/pull/7813","diff_url":"https://github.com/pytorch/pytorch/pull/7813.diff","patch_url":"https://github.com/pytorch/pytorch/pull/7813.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/7813","number":7813,"state":"open","locked":false,"title":"Making blas REQUIRED only when user specified","user":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-24T17:39:32Z","updated_at":"2018-05-24T17:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c7a2c25b4fba8926384725210d2d19968c447fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/7813/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/7813/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/7813/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/5cbc09afcfed2cb20dd719a400d586e2309c3249","head":{"label":"pjh5:mkl_fix","ref":"mkl_fix","sha":"5cbc09afcfed2cb20dd719a400d586e2309c3249","user":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"repo":{"id":127456178,"name":"pytorch","full_name":"pjh5/pytorch","owner":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjh5/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/pjh5/pytorch","forks_url":"https://api.github.com/repos/pjh5/pytorch/forks","keys_url":"https://api.github.com/repos/pjh5/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjh5/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjh5/pytorch/teams","hooks_url":"https://api.github.com/repos/pjh5/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pjh5/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pjh5/pytorch/events","assignees_url":"https://api.github.com/repos/pjh5/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pjh5/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pjh5/pytorch/tags","blobs_url":"https://api.github.com/repos/pjh5/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjh5/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjh5/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjh5/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjh5/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pjh5/pytorch/languages","stargazers_url":"https://api.github.com/repos/pjh5/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pjh5/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pjh5/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pjh5/pytorch/subscription","commits_url":"https://api.github.com/repos/pjh5/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjh5/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjh5/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjh5/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjh5/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pjh5/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjh5/pytorch/merges","archive_url":"https://api.github.com/repos/pjh5/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjh5/pytorch/downloads","issues_url":"https://api.github.com/repos/pjh5/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pjh5/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pjh5/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pjh5/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjh5/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pjh5/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pjh5/pytorch/deployments","created_at":"2018-03-30T17:41:09Z","updated_at":"2018-05-24T16:32:22Z","pushed_at":"2018-05-24T17:38:41Z","git_url":"git://github.com/pjh5/pytorch.git","ssh_url":"git@github.com:pjh5/pytorch.git","clone_url":"https://github.com/pjh5/pytorch.git","svn_url":"https://github.com/pjh5/pytorch","homepage":"http://pytorch.org","size":55721,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"9a736f5228cc825babb1142e149069927c6945b8","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-05-24T17:31:19Z","pushed_at":"2018-05-24T17:39:32Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":55729,"stargazers_count":15805,"watchers_count":15805,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3561,"mirror_url":null,"archived":false,"open_issues_count":1129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3561,"open_issues":1129,"watchers":15805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/7813"},"html":{"href":"https://github.com/pytorch/pytorch/pull/7813"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/7813"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/7813/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/7813/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/7813/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/5cbc09afcfed2cb20dd719a400d586e2309c3249"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pjh5"}}