{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/235099937","pull_request_review_id":176888586,"id":235099937,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTA5OTkzNw==","diff_hunk":"@@ -0,0 +1,86 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.nifi.pulsar.cache;\n+\n+import java.io.Closeable;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.LinkedHashMap;\n+import java.util.Map;\n+\n+public class LRUCache<K, V extends Closeable> {","path":"nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/cache/LRUCache.java","position":25,"original_position":25,"commit_id":"0c85ce122b1bf06149320a2475aa396838de9493","original_commit_id":"0c85ce122b1bf06149320a2475aa396838de9493","user":{"login":"joewitt","id":3057465,"node_id":"MDQ6VXNlcjMwNTc0NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3057465?v=4","gravatar_id":"","url":"https://api.github.com/users/joewitt","html_url":"https://github.com/joewitt","followers_url":"https://api.github.com/users/joewitt/followers","following_url":"https://api.github.com/users/joewitt/following{/other_user}","gists_url":"https://api.github.com/users/joewitt/gists{/gist_id}","starred_url":"https://api.github.com/users/joewitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewitt/subscriptions","organizations_url":"https://api.github.com/users/joewitt/orgs","repos_url":"https://api.github.com/users/joewitt/repos","events_url":"https://api.github.com/users/joewitt/events{/privacy}","received_events_url":"https://api.github.com/users/joewitt/received_events","type":"User","site_admin":false},"body":"@david-streamlio can you confirm this is a uniquely written class for this purpose and not taken from elsewhere?  I ask because I've had the displeasure of finding copied code before and it makes for some build/release messes and this is the type of thing that often hits that trigger.  This is fresh/clean room stuff?","created_at":"2018-11-20T17:31:37Z","updated_at":"2018-11-20T17:31:37Z","html_url":"https://github.com/apache/nifi/pull/3178#discussion_r235099937","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/3178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/235099937"},"html":{"href":"https://github.com/apache/nifi/pull/3178#discussion_r235099937"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/3178"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/3178","id":232160410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTYwNDEw","html_url":"https://github.com/apache/nifi/pull/3178","diff_url":"https://github.com/apache/nifi/pull/3178.diff","patch_url":"https://github.com/apache/nifi/pull/3178.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/3178","number":3178,"state":"open","locked":false,"title":"NIFI-4914: Add Apache Pulsar processors","user":{"login":"david-streamlio","id":35466513,"node_id":"MDQ6VXNlcjM1NDY2NTEz","avatar_url":"https://avatars3.githubusercontent.com/u/35466513?v=4","gravatar_id":"","url":"https://api.github.com/users/david-streamlio","html_url":"https://github.com/david-streamlio","followers_url":"https://api.github.com/users/david-streamlio/followers","following_url":"https://api.github.com/users/david-streamlio/following{/other_user}","gists_url":"https://api.github.com/users/david-streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/david-streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-streamlio/subscriptions","organizations_url":"https://api.github.com/users/david-streamlio/orgs","repos_url":"https://api.github.com/users/david-streamlio/repos","events_url":"https://api.github.com/users/david-streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/david-streamlio/received_events","type":"User","site_admin":false},"body":"Thank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2018-11-20T01:02:09Z","updated_at":"2018-11-20T17:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af5bd4fb85d5e88f2dcabab070d8b312d7cf726a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/3178/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/3178/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/3178/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/0c85ce122b1bf06149320a2475aa396838de9493","head":{"label":"david-streamlio:NIFI-4914","ref":"NIFI-4914","sha":"0c85ce122b1bf06149320a2475aa396838de9493","user":{"login":"david-streamlio","id":35466513,"node_id":"MDQ6VXNlcjM1NDY2NTEz","avatar_url":"https://avatars3.githubusercontent.com/u/35466513?v=4","gravatar_id":"","url":"https://api.github.com/users/david-streamlio","html_url":"https://github.com/david-streamlio","followers_url":"https://api.github.com/users/david-streamlio/followers","following_url":"https://api.github.com/users/david-streamlio/following{/other_user}","gists_url":"https://api.github.com/users/david-streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/david-streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-streamlio/subscriptions","organizations_url":"https://api.github.com/users/david-streamlio/orgs","repos_url":"https://api.github.com/users/david-streamlio/repos","events_url":"https://api.github.com/users/david-streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/david-streamlio/received_events","type":"User","site_admin":false},"repo":{"id":140653841,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NTM4NDE=","name":"nifi","full_name":"david-streamlio/nifi","private":false,"owner":{"login":"david-streamlio","id":35466513,"node_id":"MDQ6VXNlcjM1NDY2NTEz","avatar_url":"https://avatars3.githubusercontent.com/u/35466513?v=4","gravatar_id":"","url":"https://api.github.com/users/david-streamlio","html_url":"https://github.com/david-streamlio","followers_url":"https://api.github.com/users/david-streamlio/followers","following_url":"https://api.github.com/users/david-streamlio/following{/other_user}","gists_url":"https://api.github.com/users/david-streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/david-streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-streamlio/subscriptions","organizations_url":"https://api.github.com/users/david-streamlio/orgs","repos_url":"https://api.github.com/users/david-streamlio/repos","events_url":"https://api.github.com/users/david-streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/david-streamlio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/david-streamlio/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/david-streamlio/nifi","forks_url":"https://api.github.com/repos/david-streamlio/nifi/forks","keys_url":"https://api.github.com/repos/david-streamlio/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-streamlio/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-streamlio/nifi/teams","hooks_url":"https://api.github.com/repos/david-streamlio/nifi/hooks","issue_events_url":"https://api.github.com/repos/david-streamlio/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/david-streamlio/nifi/events","assignees_url":"https://api.github.com/repos/david-streamlio/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/david-streamlio/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/david-streamlio/nifi/tags","blobs_url":"https://api.github.com/repos/david-streamlio/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-streamlio/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-streamlio/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-streamlio/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-streamlio/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/david-streamlio/nifi/languages","stargazers_url":"https://api.github.com/repos/david-streamlio/nifi/stargazers","contributors_url":"https://api.github.com/repos/david-streamlio/nifi/contributors","subscribers_url":"https://api.github.com/repos/david-streamlio/nifi/subscribers","subscription_url":"https://api.github.com/repos/david-streamlio/nifi/subscription","commits_url":"https://api.github.com/repos/david-streamlio/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-streamlio/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-streamlio/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-streamlio/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-streamlio/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/david-streamlio/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-streamlio/nifi/merges","archive_url":"https://api.github.com/repos/david-streamlio/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-streamlio/nifi/downloads","issues_url":"https://api.github.com/repos/david-streamlio/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/david-streamlio/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/david-streamlio/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/david-streamlio/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-streamlio/nifi/labels{/name}","releases_url":"https://api.github.com/repos/david-streamlio/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/david-streamlio/nifi/deployments","created_at":"2018-07-12T03:04:15Z","updated_at":"2018-11-19T17:53:44Z","pushed_at":"2018-11-20T01:50:54Z","git_url":"git://github.com/david-streamlio/nifi.git","ssh_url":"git@github.com:david-streamlio/nifi.git","clone_url":"https://github.com/david-streamlio/nifi.git","svn_url":"https://github.com/david-streamlio/nifi","homepage":"","size":128313,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7bcf9fcb5da4f9b71a65314dd369d786ad032e69","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"node_id":"MDEwOlJlcG9zaXRvcnkyNzkxMTA4OA==","name":"nifi","full_name":"apache/nifi","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2018-11-20T16:02:43Z","pushed_at":"2018-11-20T16:31:03Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":128617,"stargazers_count":1167,"watchers_count":1167,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1081,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1081,"open_issues":144,"watchers":1167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/3178"},"html":{"href":"https://github.com/apache/nifi/pull/3178"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/3178"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/3178/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/3178/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/3178/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/0c85ce122b1bf06149320a2475aa396838de9493"}},"author_association":"NONE"}}
{"actor":{"display_login":"joewitt"}}