{"action":"created","comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/241010475","pull_request_review_id":184172995,"id":241010475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAxMDQ3NQ==","diff_hunk":"@@ -60,13 +60,13 @@ pclviewer.h\n \n .. literalinclude:: sources/qt_colorize_cloud/pclviewer.h\n    :language: cpp\n-   :lines: 42-57\n+   :lines: 41-56\n \n These are the public slots triggered by the buttons in the UI.\n \n .. literalinclude:: sources/qt_colorize_cloud/pclviewer.h\n    :language: cpp\n-   :lines: 59-86\n+   :lines: 89-85","path":"doc/tutorials/content/qt_colorize_cloud.rst","position":12,"original_position":12,"commit_id":"736ffba4db17b195fd94581c0f56e0e15173e43c","original_commit_id":"736ffba4db17b195fd94581c0f56e0e15173e43c","user":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"body":"Ups xD","created_at":"2018-12-12T13:21:38Z","updated_at":"2018-12-12T13:21:38Z","html_url":"https://github.com/PointCloudLibrary/pcl/pull/2707#discussion_r241010475","pull_request_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/241010475"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/2707#discussion_r241010475"},"pull_request":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707"}},"in_reply_to_id":241010246},"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707","id":238027285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDI3Mjg1","html_url":"https://github.com/PointCloudLibrary/pcl/pull/2707","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/2707.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/2707.patch","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2707","number":2707,"state":"open","locked":false,"title":"Second round replacing #ifndef guards by #pragma once include guards","user":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"body":"Continues #429/#2617. Last time I searched for `#include PCL`, now I searched just for `#ifndef`. I just skipped `3rdparty` directory (opennurbs/poisson4), because I'm not sure how you handle 3rdParty libraries.\r\n\r\nThere could be a compile issue, because some macros were multiple times used:\r\nhttps://github.com/PointCloudLibrary/pcl/blob/5cef903b3be806105cfa9f8600e8bda9d3650a6b/doc/tutorials/content/sources/iros2011/include/object_recognition.h#L1-L2\r\nhttps://github.com/PointCloudLibrary/pcl/blob/5cef903b3be806105cfa9f8600e8bda9d3650a6b/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h#L1-L2\r\n\r\nhttps://github.com/PointCloudLibrary/pcl/blob/5cef903b3be806105cfa9f8600e8bda9d3650a6b/doc/tutorials/content/sources/iros2011/include/surface.h#L1-L2\r\nhttps://github.com/PointCloudLibrary/pcl/blob/5cef903b3be806105cfa9f8600e8bda9d3650a6b/doc/tutorials/content/sources/iros2011/include/solution/surface.h#L1-L2\r\n\r\nI didn't checked if we can remove solution directory or not, because it seems to be just a copy of parent directory.","created_at":"2018-12-12T12:55:00Z","updated_at":"2018-12-12T13:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"141c61dacc230e7769933920056a6ee42ce21426","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707/commits","review_comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707/comments","review_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2707/comments","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/736ffba4db17b195fd94581c0f56e0e15173e43c","head":{"label":"SunBlack:pragma_once","ref":"pragma_once","sha":"736ffba4db17b195fd94581c0f56e0e15173e43c","user":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"repo":{"id":157413444,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MTM0NDQ=","name":"pcl","full_name":"SunBlack/pcl","private":false,"owner":{"login":"SunBlack","id":483922,"node_id":"MDQ6VXNlcjQ4MzkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/483922?v=4","gravatar_id":"","url":"https://api.github.com/users/SunBlack","html_url":"https://github.com/SunBlack","followers_url":"https://api.github.com/users/SunBlack/followers","following_url":"https://api.github.com/users/SunBlack/following{/other_user}","gists_url":"https://api.github.com/users/SunBlack/gists{/gist_id}","starred_url":"https://api.github.com/users/SunBlack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunBlack/subscriptions","organizations_url":"https://api.github.com/users/SunBlack/orgs","repos_url":"https://api.github.com/users/SunBlack/repos","events_url":"https://api.github.com/users/SunBlack/events{/privacy}","received_events_url":"https://api.github.com/users/SunBlack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SunBlack/pcl","description":"Point Cloud Library (PCL)","fork":true,"url":"https://api.github.com/repos/SunBlack/pcl","forks_url":"https://api.github.com/repos/SunBlack/pcl/forks","keys_url":"https://api.github.com/repos/SunBlack/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SunBlack/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SunBlack/pcl/teams","hooks_url":"https://api.github.com/repos/SunBlack/pcl/hooks","issue_events_url":"https://api.github.com/repos/SunBlack/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/SunBlack/pcl/events","assignees_url":"https://api.github.com/repos/SunBlack/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/SunBlack/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/SunBlack/pcl/tags","blobs_url":"https://api.github.com/repos/SunBlack/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SunBlack/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SunBlack/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/SunBlack/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SunBlack/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/SunBlack/pcl/languages","stargazers_url":"https://api.github.com/repos/SunBlack/pcl/stargazers","contributors_url":"https://api.github.com/repos/SunBlack/pcl/contributors","subscribers_url":"https://api.github.com/repos/SunBlack/pcl/subscribers","subscription_url":"https://api.github.com/repos/SunBlack/pcl/subscription","commits_url":"https://api.github.com/repos/SunBlack/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/SunBlack/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/SunBlack/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/SunBlack/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/SunBlack/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/SunBlack/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SunBlack/pcl/merges","archive_url":"https://api.github.com/repos/SunBlack/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SunBlack/pcl/downloads","issues_url":"https://api.github.com/repos/SunBlack/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/SunBlack/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/SunBlack/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/SunBlack/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SunBlack/pcl/labels{/name}","releases_url":"https://api.github.com/repos/SunBlack/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/SunBlack/pcl/deployments","created_at":"2018-11-13T16:44:53Z","updated_at":"2018-11-13T16:45:06Z","pushed_at":"2018-12-12T13:17:50Z","git_url":"git://github.com/SunBlack/pcl.git","ssh_url":"git@github.com:SunBlack/pcl.git","clone_url":"https://github.com/SunBlack/pcl.git","svn_url":"https://github.com/SunBlack/pcl","homepage":"http://www.pointclouds.org","size":224701,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PointCloudLibrary:master","ref":"master","sha":"5cef903b3be806105cfa9f8600e8bda9d3650a6b","user":{"login":"PointCloudLibrary","id":2059451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTk0NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":8162615,"node_id":"MDEwOlJlcG9zaXRvcnk4MTYyNjE1","name":"pcl","full_name":"PointCloudLibrary/pcl","private":false,"owner":{"login":"PointCloudLibrary","id":2059451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNTk0NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/2059451?v=4","gravatar_id":"","url":"https://api.github.com/users/PointCloudLibrary","html_url":"https://github.com/PointCloudLibrary","followers_url":"https://api.github.com/users/PointCloudLibrary/followers","following_url":"https://api.github.com/users/PointCloudLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PointCloudLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PointCloudLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PointCloudLibrary/subscriptions","organizations_url":"https://api.github.com/users/PointCloudLibrary/orgs","repos_url":"https://api.github.com/users/PointCloudLibrary/repos","events_url":"https://api.github.com/users/PointCloudLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PointCloudLibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PointCloudLibrary/pcl","description":"Point Cloud Library (PCL)","fork":false,"url":"https://api.github.com/repos/PointCloudLibrary/pcl","forks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/forks","keys_url":"https://api.github.com/repos/PointCloudLibrary/pcl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PointCloudLibrary/pcl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PointCloudLibrary/pcl/teams","hooks_url":"https://api.github.com/repos/PointCloudLibrary/pcl/hooks","issue_events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/events{/number}","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/events","assignees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/assignees{/user}","branches_url":"https://api.github.com/repos/PointCloudLibrary/pcl/branches{/branch}","tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/tags","blobs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/{sha}","languages_url":"https://api.github.com/repos/PointCloudLibrary/pcl/languages","stargazers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/stargazers","contributors_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contributors","subscribers_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscribers","subscription_url":"https://api.github.com/repos/PointCloudLibrary/pcl/subscription","commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PointCloudLibrary/pcl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PointCloudLibrary/pcl/contents/{+path}","compare_url":"https://api.github.com/repos/PointCloudLibrary/pcl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PointCloudLibrary/pcl/merges","archive_url":"https://api.github.com/repos/PointCloudLibrary/pcl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PointCloudLibrary/pcl/downloads","issues_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues{/number}","pulls_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls{/number}","milestones_url":"https://api.github.com/repos/PointCloudLibrary/pcl/milestones{/number}","notifications_url":"https://api.github.com/repos/PointCloudLibrary/pcl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/labels{/name}","releases_url":"https://api.github.com/repos/PointCloudLibrary/pcl/releases{/id}","deployments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/deployments","created_at":"2013-02-12T16:40:25Z","updated_at":"2018-12-12T12:07:41Z","pushed_at":"2018-12-12T13:17:51Z","git_url":"git://github.com/PointCloudLibrary/pcl.git","ssh_url":"git@github.com:PointCloudLibrary/pcl.git","clone_url":"https://github.com/PointCloudLibrary/pcl.git","svn_url":"https://github.com/PointCloudLibrary/pcl","homepage":"http://www.pointclouds.org","size":224720,"stargazers_count":3186,"watchers_count":3186,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2461,"mirror_url":null,"archived":false,"open_issues_count":390,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2461,"open_issues":390,"watchers":3186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/2707"},"issue":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2707"},"comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/2707/comments"},"review_comments":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707/comments"},"review_comment":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/2707/commits"},"statuses":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/statuses/736ffba4db17b195fd94581c0f56e0e15173e43c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SunBlack"}}