{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/26435","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/26435/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/26435/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/26435/events","html_url":"https://github.com/elastic/kibana/pull/26435","id":385916863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzc4Nzgw","number":26435,"title":"Even moar 'ui/public' LESS to SASS","user":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"labels":[{"id":271062529,"node_id":"MDU6TGFiZWwyNzEwNjI1Mjk=","url":"https://api.github.com/repos/elastic/kibana/labels/:Design","name":":Design","color":"fef2c0","default":false},{"id":1055842724,"node_id":"MDU6TGFiZWwxMDU1ODQyNzI0","url":"https://api.github.com/repos/elastic/kibana/labels/:KibanaApp","name":":KibanaApp","color":"fef2c0","default":false},{"id":222889424,"node_id":"MDU6TGFiZWwyMjI4ODk0MjQ=","url":"https://api.github.com/repos/elastic/kibana/labels/chore","name":"chore","color":"f9d0c4","default":false},{"id":1062169267,"node_id":"MDU6TGFiZWwxMDYyMTY5MjY3","url":"https://api.github.com/repos/elastic/kibana/labels/v6.6.0","name":"v6.6.0","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false},"assignees":[{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2018-11-29T20:40:00Z","updated_at":"2018-12-13T16:32:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/26435","html_url":"https://github.com/elastic/kibana/pull/26435","diff_url":"https://github.com/elastic/kibana/pull/26435.diff","patch_url":"https://github.com/elastic/kibana/pull/26435.patch"},"body":"This PR removes the LESS files in ui/public/**accessibility, chrome, error_[...], field_editor, notify** and replaces them with Sass.\r\n\r\n### Process taken\r\n\r\n1. The `ui/public/_index.scss` file was updated include a `_index.scss` file from each of the folders.\r\n2. All Less files were replaced with sass counterparts.\r\n    * The sass files now live with separated `_index.scss` and `_component_names.scss` files next to the components or views they live next to (or close to it).\r\n    * Some files were even moved across folders to be closer to their actual component counterparts\r\n    * The Less files that are no longer being used were deleted entirely.\r\n    * The new sass files use EUI variables whenever possible. The most important being color and sizing variables.\r\n    * The selectors were all _mostly_ changed to match EUI's BEM formatting. This means the html/js templating was touched as well.\r\n    * Additionally, a three-letter prefixes `kbn` was added to all selectors to namespace them and avoid conflicts.\r\n\r\n### Notes/Fixes\r\n\r\n1. Fixes #26597 The **errors** had no styling at all because they just used base HTML elements. Without needing to convert them right now, I just added the `.euiText` class to them so they'd get that base text styles.\r\n\r\n<img src=\"https://d.pr/free/i/qGfcwQ+\" />\r\n\r\n2. The scrollbar in the sidebar nav used to block/cut off some icons/avatars.\r\n\r\n<img width=\"715\" alt=\"screen shot 2018-11-21 at 13 08 56\" src=\"https://user-images.githubusercontent.com/549577/49250440-d4092280-f3ec-11e8-93b5-5410c0b01e0c.png\">\r\n\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n- ~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~\r\n- ~[ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~\r\n- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- ~[ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/447033843","html_url":"https://github.com/elastic/kibana/pull/26435#issuecomment-447033843","issue_url":"https://api.github.com/repos/elastic/kibana/issues/26435","id":447033843,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzAzMzg0Mw==","user":{"login":"elasticmachine","id":15837671,"node_id":"MDQ6VXNlcjE1ODM3Njcx","avatar_url":"https://avatars3.githubusercontent.com/u/15837671?v=4","gravatar_id":"","url":"https://api.github.com/users/elasticmachine","html_url":"https://github.com/elasticmachine","followers_url":"https://api.github.com/users/elasticmachine/followers","following_url":"https://api.github.com/users/elasticmachine/following{/other_user}","gists_url":"https://api.github.com/users/elasticmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/elasticmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elasticmachine/subscriptions","organizations_url":"https://api.github.com/users/elasticmachine/orgs","repos_url":"https://api.github.com/users/elasticmachine/repos","events_url":"https://api.github.com/users/elasticmachine/events{/privacy}","received_events_url":"https://api.github.com/users/elasticmachine/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T16:32:27Z","updated_at":"2018-12-13T16:32:27Z","author_association":"NONE","body":"## :broken_heart: Build Failed\n* [continuous-integration/kibana-ci/pull-request](https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/3615/)\n\n"}}
{"actor":{"display_login":"elasticmachine"}}