{"action":"closed","number":4428,"pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428","id":179728199,"html_url":"https://github.com/statsmodels/statsmodels/pull/4428","diff_url":"https://github.com/statsmodels/statsmodels/pull/4428.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/4428.patch","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/4428","number":4428,"state":"closed","locked":false,"title":"BUG/REF: GMM fix exog_names, summary","user":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"body":" closes #4340 \r\n\r\nbug fix with a bit of refactoring/enhancements\r\n\r\n- fixes the exog_names in GMM, use generic names if xnames from data too short\r\n- also adds a new method `set_param_names` for users to override the default names.  \r\n  currently only in GMM class, but we might want to have something like this more generally.\r\n- also summary `summary_params` raises now an exception if params and exog_names have a length mismatch, instead of silently truncating the params tabel\r\n\r\nI opened #4426 for more general param_names/xnames/exog_names inconsistencies\r\n\r\n","created_at":"2018-04-05T16:20:52Z","updated_at":"2018-04-05T17:37:38Z","closed_at":"2018-04-05T17:37:38Z","merged_at":"2018-04-05T17:37:38Z","merge_commit_sha":"e614a4229fc64c12ec762f2cd91574c2aaad99fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":163965,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/comp-regression","name":"comp-regression","color":"ededed","default":false},{"id":142960,"url":"https://api.github.com/repos/statsmodels/statsmodels/labels/type-bug","name":"type-bug","color":"ff9999","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428/commits","review_comments_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428/comments","review_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/4428/comments","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/52465a6471f7ddbe2d00e7f5f4bb4d48aaa52214","head":{"label":"josef-pkt:bug_gmm_xnmaes","ref":"bug_gmm_xnmaes","sha":"52465a6471f7ddbe2d00e7f5f4bb4d48aaa52214","user":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"repo":{"id":1885313,"name":"statsmodels","full_name":"josef-pkt/statsmodels","owner":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josef-pkt/statsmodels","description":"main repo of statsmodels","fork":true,"url":"https://api.github.com/repos/josef-pkt/statsmodels","forks_url":"https://api.github.com/repos/josef-pkt/statsmodels/forks","keys_url":"https://api.github.com/repos/josef-pkt/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josef-pkt/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josef-pkt/statsmodels/teams","hooks_url":"https://api.github.com/repos/josef-pkt/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/josef-pkt/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/josef-pkt/statsmodels/events","assignees_url":"https://api.github.com/repos/josef-pkt/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/josef-pkt/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/josef-pkt/statsmodels/tags","blobs_url":"https://api.github.com/repos/josef-pkt/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josef-pkt/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josef-pkt/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/josef-pkt/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josef-pkt/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/josef-pkt/statsmodels/languages","stargazers_url":"https://api.github.com/repos/josef-pkt/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/josef-pkt/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/josef-pkt/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/josef-pkt/statsmodels/subscription","commits_url":"https://api.github.com/repos/josef-pkt/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/josef-pkt/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/josef-pkt/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/josef-pkt/statsmodels/issues/comments{/number}","contents_url":"https://api.github.com/repos/josef-pkt/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/josef-pkt/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josef-pkt/statsmodels/merges","archive_url":"https://api.github.com/repos/josef-pkt/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josef-pkt/statsmodels/downloads","issues_url":"https://api.github.com/repos/josef-pkt/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/josef-pkt/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/josef-pkt/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/josef-pkt/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josef-pkt/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/josef-pkt/statsmodels/releases{/id}","deployments_url":"https://api.github.com/repos/josef-pkt/statsmodels/deployments","created_at":"2011-06-12T17:30:37Z","updated_at":"2018-04-01T02:04:48Z","pushed_at":"2018-04-05T16:12:22Z","git_url":"git://github.com/josef-pkt/statsmodels.git","ssh_url":"git@github.com:josef-pkt/statsmodels.git","clone_url":"https://github.com/josef-pkt/statsmodels.git","svn_url":"https://github.com/josef-pkt/statsmodels","homepage":"http://www.statsmodels.org/devel","size":29184,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":1,"watchers":17,"default_branch":"master"}},"base":{"label":"statsmodels:master","ref":"master","sha":"5a01211ab0c73b8b9182396e6d551efe220c2ee9","user":{"login":"statsmodels","id":717666,"avatar_url":"https://avatars3.githubusercontent.com/u/717666?v=4","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":1885237,"name":"statsmodels","full_name":"statsmodels/statsmodels","owner":{"login":"statsmodels","id":717666,"avatar_url":"https://avatars3.githubusercontent.com/u/717666?v=4","gravatar_id":"","url":"https://api.github.com/users/statsmodels","html_url":"https://github.com/statsmodels","followers_url":"https://api.github.com/users/statsmodels/followers","following_url":"https://api.github.com/users/statsmodels/following{/other_user}","gists_url":"https://api.github.com/users/statsmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/statsmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/statsmodels/subscriptions","organizations_url":"https://api.github.com/users/statsmodels/orgs","repos_url":"https://api.github.com/users/statsmodels/repos","events_url":"https://api.github.com/users/statsmodels/events{/privacy}","received_events_url":"https://api.github.com/users/statsmodels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/statsmodels/statsmodels","description":"Statsmodels: statistical modeling and econometrics in Python","fork":false,"url":"https://api.github.com/repos/statsmodels/statsmodels","forks_url":"https://api.github.com/repos/statsmodels/statsmodels/forks","keys_url":"https://api.github.com/repos/statsmodels/statsmodels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/statsmodels/statsmodels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/statsmodels/statsmodels/teams","hooks_url":"https://api.github.com/repos/statsmodels/statsmodels/hooks","issue_events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/events{/number}","events_url":"https://api.github.com/repos/statsmodels/statsmodels/events","assignees_url":"https://api.github.com/repos/statsmodels/statsmodels/assignees{/user}","branches_url":"https://api.github.com/repos/statsmodels/statsmodels/branches{/branch}","tags_url":"https://api.github.com/repos/statsmodels/statsmodels/tags","blobs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/statsmodels/statsmodels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/statsmodels/statsmodels/git/refs{/sha}","trees_url":"https://api.github.com/repos/statsmodels/statsmodels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/statsmodels/statsmodels/statuses/{sha}","languages_url":"https://api.github.com/repos/statsmodels/statsmodels/languages","stargazers_url":"https://api.github.com/repos/statsmodels/statsmodels/stargazers","contributors_url":"https://api.github.com/repos/statsmodels/statsmodels/contributors","subscribers_url":"https://api.github.com/repos/statsmodels/statsmodels/subscribers","subscription_url":"https://api.github.com/repos/statsmodels/statsmodels/subscription","commits_url":"https://api.github.com/repos/statsmodels/statsmodels/commits{/sha}","git_commits_url":"https://api.github.com/repos/statsmodels/statsmodels/git/commits{/sha}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/comments{/number}","issue_comment_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments{/number}","contents_url":"https://api.github.com/repos/statsmodels/statsmodels/contents/{+path}","compare_url":"https://api.github.com/repos/statsmodels/statsmodels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/statsmodels/statsmodels/merges","archive_url":"https://api.github.com/repos/statsmodels/statsmodels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/statsmodels/statsmodels/downloads","issues_url":"https://api.github.com/repos/statsmodels/statsmodels/issues{/number}","pulls_url":"https://api.github.com/repos/statsmodels/statsmodels/pulls{/number}","milestones_url":"https://api.github.com/repos/statsmodels/statsmodels/milestones{/number}","notifications_url":"https://api.github.com/repos/statsmodels/statsmodels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/labels{/name}","releases_url":"https://api.github.com/repos/statsmodels/statsmodels/releases{/id}","deployments_url":"https://api.github.com/repos/statsmodels/statsmodels/deployments","created_at":"2011-06-12T17:04:50Z","updated_at":"2018-04-05T13:37:48Z","pushed_at":"2018-04-05T17:37:38Z","git_url":"git://github.com/statsmodels/statsmodels.git","ssh_url":"git@github.com:statsmodels/statsmodels.git","clone_url":"https://github.com/statsmodels/statsmodels.git","svn_url":"https://github.com/statsmodels/statsmodels","homepage":"http://www.statsmodels.org/devel/","size":27774,"stargazers_count":2745,"watchers_count":2745,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1210,"mirror_url":null,"archived":false,"open_issues_count":1766,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1210,"open_issues":1766,"watchers":2745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428"},"html":{"href":"https://github.com/statsmodels/statsmodels/pull/4428"},"issue":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/4428"},"comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/issues/4428/comments"},"review_comments":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428/comments"},"review_comment":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/statsmodels/statsmodels/pulls/4428/commits"},"statuses":{"href":"https://api.github.com/repos/statsmodels/statsmodels/statuses/52465a6471f7ddbe2d00e7f5f4bb4d48aaa52214"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"josef-pkt","id":440735,"avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":81,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"josef-pkt"}}