{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/currency/pulls/comments/180267416","pull_request_review_id":110659272,"id":180267416,"diff_hunk":"@@ -0,0 +1,16 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>","path":"account_cryptocurrency/data/res_currency_move_sequence.xml","position":1,"original_position":1,"commit_id":"c998d00ace65cd1d04e6032a89da086d24fab48f","original_commit_id":"05c0c1a125c6a9cb19027fce66002105e4e52a9c","user":{"login":"elicoidal","id":7600613,"avatar_url":"https://avatars0.githubusercontent.com/u/7600613?v=4","gravatar_id":"","url":"https://api.github.com/users/elicoidal","html_url":"https://github.com/elicoidal","followers_url":"https://api.github.com/users/elicoidal/followers","following_url":"https://api.github.com/users/elicoidal/following{/other_user}","gists_url":"https://api.github.com/users/elicoidal/gists{/gist_id}","starred_url":"https://api.github.com/users/elicoidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elicoidal/subscriptions","organizations_url":"https://api.github.com/users/elicoidal/orgs","repos_url":"https://api.github.com/users/elicoidal/repos","events_url":"https://api.github.com/users/elicoidal/events{/privacy}","received_events_url":"https://api.github.com/users/elicoidal/received_events","type":"User","site_admin":false},"body":"@pedrobaeza do we have a guideline for that?","created_at":"2018-04-10T00:22:44Z","updated_at":"2018-04-10T00:25:28Z","html_url":"https://github.com/OCA/currency/pull/11#discussion_r180267416","pull_request_url":"https://api.github.com/repos/OCA/currency/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OCA/currency/pulls/comments/180267416"},"html":{"href":"https://github.com/OCA/currency/pull/11#discussion_r180267416"},"pull_request":{"href":"https://api.github.com/repos/OCA/currency/pulls/11"}},"in_reply_to_id":176282055},"pull_request":{"url":"https://api.github.com/repos/OCA/currency/pulls/11","id":176507661,"html_url":"https://github.com/OCA/currency/pull/11","diff_url":"https://github.com/OCA/currency/pull/11.diff","patch_url":"https://github.com/OCA/currency/pull/11.patch","issue_url":"https://api.github.com/repos/OCA/currency/issues/11","number":11,"state":"open","locked":false,"title":"[11.0][add][account_cryptocurrency]","user":{"login":"jbeficent","id":7683926,"avatar_url":"https://avatars0.githubusercontent.com/u/7683926?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeficent","html_url":"https://github.com/jbeficent","followers_url":"https://api.github.com/users/jbeficent/followers","following_url":"https://api.github.com/users/jbeficent/following{/other_user}","gists_url":"https://api.github.com/users/jbeficent/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeficent/subscriptions","organizations_url":"https://api.github.com/users/jbeficent/orgs","repos_url":"https://api.github.com/users/jbeficent/repos","events_url":"https://api.github.com/users/jbeficent/events{/privacy}","received_events_url":"https://api.github.com/users/jbeficent/received_events","type":"User","site_admin":false},"body":"Account Cryptocurrency\r\n===================\r\n\r\nThis module provides basic support for the management of cryptocurrencies.\r\n\r\n* Cryptocurrencies sare commonly considered property from a\r\n  taxation standpoint.\r\n\r\n* This means that every time that you receive or send cryptocurrencies, you\r\n  are entering into a taxable transaction, and will need to report on the\r\n  gain/loss resulting from the receipt/issue of the cryptocurrency.\r\n\r\n* When you receive cryptocurrencies (in exchange for goods delivered,\r\n  service rendered or because you mined it), that translates into taxable\r\n  income to the recipient. The valuation should be based on the market value of\r\n  the cryptocurrency at the time of receipt, and it can be provided by a\r\n  third party (e.g. the exchange platform) or needs to be identified by\r\n  you somehow.\r\n\r\n* You have to retain the cost of the crytptocurrency for as long as you keep\r\n  it.\r\n\r\n* When you pay out cryptocurrencies (in exchange for goods or services\r\n  purchased, or if you exchanged fpr another crypto or normal currency) this\r\n  constitutes again a taxable transaction. In that case the gain/loss is\r\n  computed as the difference between the cost of the cryptocurrency that\r\n  you pay with, and the value of what you receive back, valued in your\r\n  operating normal currency.\r\n\r\n\r\nInstallation\r\n============\r\n\r\n* Install the module 'account_invoicing' to be able to display the menus.\r\n\r\nConfiguration\r\n=============\r\n\r\n* For the user that will do the configuration, make sure to activate the\r\n  option 'Show Full Accounting Features' in the user profile.\r\n\r\n* Activate the Multi-Currency in 'Invoicing / Configuration /\r\n  Settings / Multi-Currencies.\r\n\r\n* Create the crypto currency in 'Invoicing / Configuration / Accounting /\r\n  Currencies'. Complete the following fields:  'Inventoried', 'Valuation\r\n  Method'.\r\n\r\n* Add to the crypto currency an 'Inventory Account'. This Account must\r\n  indicate in field 'Account Currency' the same currency.\r\n\r\n* Create an Account Journal associated to the payments of the crypto\r\n  currency, in 'Invoicing / Configuration / Accounting / Journals'. Indicate\r\n  in the 'Currency' field the crypto currency. In the 'Default Credit Account'\r\n  and 'Default Debit Account' you should indicate a new Account of type\r\n  'Expenses', with a name similar to 'Crypto currency X Gain/Loss'. The new\r\n  Account must also refer to the crypto currency account.\r\n\r\n\r\nAdditional remarks:\r\n\r\n * In case that your company currency is not EUR, make sure that the main\r\n   company currency has no exchange rates. Go to 'Invoicing / Configuration /\r\n   Accounting / Currencies' and for the company currency press the\r\n   button 'Rates' and delete any rate listed.\r\n\r\n\r\n\r\nUsage\r\n=====\r\n\r\n* If you have negotiated your invoices with customers / suppliers using\r\n  crypto currencies, you can indicate them in the corresponding invoice.\r\n\r\n* When you receive/send payments you can indicate the crypto currency that\r\n  you want to use for the payment. Once the payment has been posted you will\r\n  be able to navigate to the associated currency moves.\r\n\r\n* You cannot make internal transfers using cryptocurrencies.\r\n","created_at":"2018-03-21T15:10:08Z","updated_at":"2018-04-10T00:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e9bb6829358773c3cfddacb81162254af0e3c49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/currency/pulls/11/commits","review_comments_url":"https://api.github.com/repos/OCA/currency/pulls/11/comments","review_comment_url":"https://api.github.com/repos/OCA/currency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/currency/issues/11/comments","statuses_url":"https://api.github.com/repos/OCA/currency/statuses/c998d00ace65cd1d04e6032a89da086d24fab48f","head":{"label":"Eficent:11.0-add-account_cryptocurrency","ref":"11.0-add-account_cryptocurrency","sha":"c998d00ace65cd1d04e6032a89da086d24fab48f","user":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars0.githubusercontent.com/u/7718403?v=4","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"repo":{"id":125842902,"name":"currency","full_name":"Eficent/currency","owner":{"login":"Eficent","id":7718403,"avatar_url":"https://avatars0.githubusercontent.com/u/7718403?v=4","gravatar_id":"","url":"https://api.github.com/users/Eficent","html_url":"https://github.com/Eficent","followers_url":"https://api.github.com/users/Eficent/followers","following_url":"https://api.github.com/users/Eficent/following{/other_user}","gists_url":"https://api.github.com/users/Eficent/gists{/gist_id}","starred_url":"https://api.github.com/users/Eficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eficent/subscriptions","organizations_url":"https://api.github.com/users/Eficent/orgs","repos_url":"https://api.github.com/users/Eficent/repos","events_url":"https://api.github.com/users/Eficent/events{/privacy}","received_events_url":"https://api.github.com/users/Eficent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eficent/currency","description":" Odoo Currency related Addons (crypto currencies, rate conversion, integrations with third party applications,...)","fork":true,"url":"https://api.github.com/repos/Eficent/currency","forks_url":"https://api.github.com/repos/Eficent/currency/forks","keys_url":"https://api.github.com/repos/Eficent/currency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eficent/currency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eficent/currency/teams","hooks_url":"https://api.github.com/repos/Eficent/currency/hooks","issue_events_url":"https://api.github.com/repos/Eficent/currency/issues/events{/number}","events_url":"https://api.github.com/repos/Eficent/currency/events","assignees_url":"https://api.github.com/repos/Eficent/currency/assignees{/user}","branches_url":"https://api.github.com/repos/Eficent/currency/branches{/branch}","tags_url":"https://api.github.com/repos/Eficent/currency/tags","blobs_url":"https://api.github.com/repos/Eficent/currency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eficent/currency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eficent/currency/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eficent/currency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eficent/currency/statuses/{sha}","languages_url":"https://api.github.com/repos/Eficent/currency/languages","stargazers_url":"https://api.github.com/repos/Eficent/currency/stargazers","contributors_url":"https://api.github.com/repos/Eficent/currency/contributors","subscribers_url":"https://api.github.com/repos/Eficent/currency/subscribers","subscription_url":"https://api.github.com/repos/Eficent/currency/subscription","commits_url":"https://api.github.com/repos/Eficent/currency/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eficent/currency/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eficent/currency/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eficent/currency/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eficent/currency/contents/{+path}","compare_url":"https://api.github.com/repos/Eficent/currency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eficent/currency/merges","archive_url":"https://api.github.com/repos/Eficent/currency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eficent/currency/downloads","issues_url":"https://api.github.com/repos/Eficent/currency/issues{/number}","pulls_url":"https://api.github.com/repos/Eficent/currency/pulls{/number}","milestones_url":"https://api.github.com/repos/Eficent/currency/milestones{/number}","notifications_url":"https://api.github.com/repos/Eficent/currency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eficent/currency/labels{/name}","releases_url":"https://api.github.com/repos/Eficent/currency/releases{/id}","deployments_url":"https://api.github.com/repos/Eficent/currency/deployments","created_at":"2018-03-19T10:47:00Z","updated_at":"2018-03-19T14:46:12Z","pushed_at":"2018-04-07T21:01:52Z","git_url":"git://github.com/Eficent/currency.git","ssh_url":"git@github.com:Eficent/currency.git","clone_url":"https://github.com/Eficent/currency.git","svn_url":"https://github.com/Eficent/currency","homepage":null,"size":420,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"11.0"}},"base":{"label":"OCA:11.0","ref":"11.0","sha":"e8d4e4e5316a53da6066035af8e9f04ae36ddb73","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":125831372,"name":"currency","full_name":"OCA/currency","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/currency","description":" Odoo Currency related Addons (crypto currencies, rate conversion, integrations with third party applications,...)","fork":false,"url":"https://api.github.com/repos/OCA/currency","forks_url":"https://api.github.com/repos/OCA/currency/forks","keys_url":"https://api.github.com/repos/OCA/currency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/currency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/currency/teams","hooks_url":"https://api.github.com/repos/OCA/currency/hooks","issue_events_url":"https://api.github.com/repos/OCA/currency/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/currency/events","assignees_url":"https://api.github.com/repos/OCA/currency/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/currency/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/currency/tags","blobs_url":"https://api.github.com/repos/OCA/currency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/currency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/currency/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/currency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/currency/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/currency/languages","stargazers_url":"https://api.github.com/repos/OCA/currency/stargazers","contributors_url":"https://api.github.com/repos/OCA/currency/contributors","subscribers_url":"https://api.github.com/repos/OCA/currency/subscribers","subscription_url":"https://api.github.com/repos/OCA/currency/subscription","commits_url":"https://api.github.com/repos/OCA/currency/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/currency/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/currency/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/currency/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/currency/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/currency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/currency/merges","archive_url":"https://api.github.com/repos/OCA/currency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/currency/downloads","issues_url":"https://api.github.com/repos/OCA/currency/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/currency/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/currency/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/currency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/currency/labels{/name}","releases_url":"https://api.github.com/repos/OCA/currency/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/currency/deployments","created_at":"2018-03-19T09:15:09Z","updated_at":"2018-03-31T03:19:35Z","pushed_at":"2018-04-07T21:01:54Z","git_url":"git://github.com/OCA/currency.git","ssh_url":"git@github.com:OCA/currency.git","clone_url":"https://github.com/OCA/currency.git","svn_url":"https://github.com/OCA/currency","homepage":null,"size":540,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":8,"open_issues":3,"watchers":3,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/currency/pulls/11"},"html":{"href":"https://github.com/OCA/currency/pull/11"},"issue":{"href":"https://api.github.com/repos/OCA/currency/issues/11"},"comments":{"href":"https://api.github.com/repos/OCA/currency/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/currency/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/currency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/currency/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/currency/statuses/c998d00ace65cd1d04e6032a89da086d24fab48f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"elicoidal"}}