{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2590","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2590/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2590/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2590/events","html_url":"https://github.com/apache/cloudstack/pull/2590","id":316564813,"number":2590,"title":"network: Fix security groups for CentOS","user":{"login":"rhtyd","id":95203,"avatar_url":"https://avatars0.githubusercontent.com/u/95203?v=4","gravatar_id":"","url":"https://api.github.com/users/rhtyd","html_url":"https://github.com/rhtyd","followers_url":"https://api.github.com/users/rhtyd/followers","following_url":"https://api.github.com/users/rhtyd/following{/other_user}","gists_url":"https://api.github.com/users/rhtyd/gists{/gist_id}","starred_url":"https://api.github.com/users/rhtyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhtyd/subscriptions","organizations_url":"https://api.github.com/users/rhtyd/orgs","repos_url":"https://api.github.com/users/rhtyd/repos","events_url":"https://api.github.com/users/rhtyd/events{/privacy}","received_events_url":"https://api.github.com/users/rhtyd/received_events","type":"User","site_admin":false},"labels":[{"id":592953226,"url":"https://api.github.com/repos/apache/cloudstack/labels/BLOCKER","name":"BLOCKER","color":"b60205","default":false},{"id":584074658,"url":"https://api.github.com/repos/apache/cloudstack/labels/security-group","name":"security-group","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apache/cloudstack/milestones/5","html_url":"https://github.com/apache/cloudstack/milestone/5","labels_url":"https://api.github.com/repos/apache/cloudstack/milestones/5/labels","id":3033298,"number":5,"title":"4.11.1.0","description":"Milestone covering PRs for the next 4.11.1.0 release. All PRs using this milestone should send PR against the 4.11 branch.","creator":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":66,"state":"open","created_at":"2018-01-13T20:06:17Z","updated_at":"2018-04-23T15:53:03Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-04-22T09:46:21Z","updated_at":"2018-04-24T01:07:21Z","closed_at":"2018-04-23T14:54:04Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2590","html_url":"https://github.com/apache/cloudstack/pull/2590","diff_url":"https://github.com/apache/cloudstack/pull/2590.diff","patch_url":"https://github.com/apache/cloudstack/pull/2590.patch"},"body":"On RHEL/CentOS/Fedora the bridge related sysctl rules are enabled\r\nin kernel by default but can only be disabled. Enabling those keys\r\nwill fail, causing iptables/ebtables tables to not be created\r\nand fails SG on CentOS. Therefore, SG does not work on CentOS.\r\n\r\nThis also fixes an integration test case, which assumes first few\r\ntests complete within 3 minutes. In nested env the value may be large,\r\nthis increases the value to 20 minutes.\r\n<!-- For new features, provide link to FS, dev ML discussion etc. -->\r\n<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## GitHub Issue/PRs\r\n<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->\r\n<!-- When \"Fixes: #<id>\" is specified, the issue/PR will automatically be closed when this PR gets merged -->\r\n<!-- For addressing multiple issues/PRs, use multiple \"Fixes: #<id>\" -->\r\n\r\n<!-- Fixes: # -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## How Has This Been Tested?\r\n\r\n<!-- Please describe in detail how you tested your changes. -->\r\n<!-- Include details of your testing environment, and the tests you ran to -->\r\n<!-- see how your change affects other areas of the code, etc. -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\nTesting\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [x] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/383770118","html_url":"https://github.com/apache/cloudstack/pull/2590#issuecomment-383770118","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2590","id":383770118,"user":{"login":"blueorangutan","id":16489489,"avatar_url":"https://avatars2.githubusercontent.com/u/16489489?v=4","gravatar_id":"","url":"https://api.github.com/users/blueorangutan","html_url":"https://github.com/blueorangutan","followers_url":"https://api.github.com/users/blueorangutan/followers","following_url":"https://api.github.com/users/blueorangutan/following{/other_user}","gists_url":"https://api.github.com/users/blueorangutan/gists{/gist_id}","starred_url":"https://api.github.com/users/blueorangutan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueorangutan/subscriptions","organizations_url":"https://api.github.com/users/blueorangutan/orgs","repos_url":"https://api.github.com/users/blueorangutan/repos","events_url":"https://api.github.com/users/blueorangutan/events{/privacy}","received_events_url":"https://api.github.com/users/blueorangutan/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T01:07:21Z","updated_at":"2018-04-24T01:07:21Z","author_association":"NONE","body":"<b>Trillian test result (tid-2533)</b>\nEnvironment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7\nTotal time taken: 106241 seconds\nMarvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2590-t2533-kvm-centos7.zip\nIntermitten failure detected: /marvin/tests/smoke/test_network.py\nIntermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py\nSmoke tests completed. 66 look OK, 1 have error(s)\nOnly failed tests results shown below:\n\n\nTest | Result | Time (s) | Test File\n--- | --- | --- | ---\ntest_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 210.03 | test_privategw_acl.py\n"}}
{"actor":{"display_login":"blueorangutan"}}