{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/lagom/pulls/comments/214760244","pull_request_review_id":151879156,"id":214760244,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc2MDI0NA==","diff_hunk":"@@ -205,6 +192,30 @@ object Reloader {\n     }\n   }\n \n+  private def delegatingLoader1(","path":"dev/build-tool-support/src/main/scala/com/lightbend/lagom/dev/Reloader.scala","position":66,"original_position":66,"commit_id":"209bd5e91cbd9c1d2e229c3cb4612590df9757c7","original_commit_id":"209bd5e91cbd9c1d2e229c3cb4612590df9757c7","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":"I think Scala should support `val delegatingLoader = delegatingLoader(...)`, but that's not what you're asking..\r\n\r\nI don't mind what it's called.","created_at":"2018-09-03T22:40:13Z","updated_at":"2018-09-03T22:40:13Z","html_url":"https://github.com/lagom/lagom/pull/1568#discussion_r214760244","pull_request_url":"https://api.github.com/repos/lagom/lagom/pulls/1568","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments/214760244"},"html":{"href":"https://github.com/lagom/lagom/pull/1568#discussion_r214760244"},"pull_request":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1568"}},"in_reply_to_id":214759444},"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1568","id":212791831,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzkxODMx","html_url":"https://github.com/lagom/lagom/pull/1568","diff_url":"https://github.com/lagom/lagom/pull/1568.diff","patch_url":"https://github.com/lagom/lagom/pull/1568.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1568","number":1568,"state":"open","locked":false,"title":"Miscellaneous cleanups","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n\r\n* [x] Have you read through the [contributor guidelines](https://github.com/lagom/lagom/tree/master/CONTRIBUTING.md)?\r\n* [x] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [x] Have you added copyright headers to new files?\r\n* [x] Have you updated the documentation?\r\n* [x] Have you added tests for any changed functionality?\r\n\r\n ## Purpose\r\n\r\nMiscellaneous cleanups while studying #1443 to do #1537.\r\nWhat does this PR do?","created_at":"2018-09-03T16:35:33Z","updated_at":"2018-09-03T22:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78c55f4926cfa1a54f06796d84b900d1ef7d09a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"renatocaval","id":502982,"node_id":"MDQ6VXNlcjUwMjk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1568/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1568/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1568/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/209bd5e91cbd9c1d2e229c3cb4612590df9757c7","head":{"label":"dwijnand:cleanups","ref":"cleanups","sha":"209bd5e91cbd9c1d2e229c3cb4612590df9757c7","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"repo":{"id":145561840,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1NjE4NDA=","name":"lagom","full_name":"dwijnand/lagom","owner":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwijnand/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/dwijnand/lagom","forks_url":"https://api.github.com/repos/dwijnand/lagom/forks","keys_url":"https://api.github.com/repos/dwijnand/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwijnand/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwijnand/lagom/teams","hooks_url":"https://api.github.com/repos/dwijnand/lagom/hooks","issue_events_url":"https://api.github.com/repos/dwijnand/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/dwijnand/lagom/events","assignees_url":"https://api.github.com/repos/dwijnand/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/dwijnand/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/dwijnand/lagom/tags","blobs_url":"https://api.github.com/repos/dwijnand/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwijnand/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwijnand/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwijnand/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwijnand/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/dwijnand/lagom/languages","stargazers_url":"https://api.github.com/repos/dwijnand/lagom/stargazers","contributors_url":"https://api.github.com/repos/dwijnand/lagom/contributors","subscribers_url":"https://api.github.com/repos/dwijnand/lagom/subscribers","subscription_url":"https://api.github.com/repos/dwijnand/lagom/subscription","commits_url":"https://api.github.com/repos/dwijnand/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwijnand/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwijnand/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwijnand/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwijnand/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/dwijnand/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwijnand/lagom/merges","archive_url":"https://api.github.com/repos/dwijnand/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwijnand/lagom/downloads","issues_url":"https://api.github.com/repos/dwijnand/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/dwijnand/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/dwijnand/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/dwijnand/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwijnand/lagom/labels{/name}","releases_url":"https://api.github.com/repos/dwijnand/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/dwijnand/lagom/deployments","created_at":"2018-08-21T12:36:03Z","updated_at":"2018-08-21T12:36:07Z","pushed_at":"2018-09-03T16:34:12Z","git_url":"git://github.com/dwijnand/lagom.git","ssh_url":"git@github.com:dwijnand/lagom.git","clone_url":"https://github.com/dwijnand/lagom.git","svn_url":"https://github.com/dwijnand/lagom","homepage":"https://www.lagomframework.com","size":8449,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"b6706a61894e3d0ca687623ea75791f9c0cb2117","user":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyMDk2Nw==","name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTY4ODUx","avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2018-09-03T14:46:17Z","pushed_at":"2018-09-03T16:35:34Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":8441,"stargazers_count":1985,"watchers_count":1985,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":444,"open_issues":298,"watchers":1985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1568"},"html":{"href":"https://github.com/lagom/lagom/pull/1568"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1568"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1568/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1568/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1568/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/209bd5e91cbd9c1d2e229c3cb4612590df9757c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dwijnand"}}