{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/191917258","pull_request_review_id":124586090,"id":191917258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTkxNzI1OA==","diff_hunk":"@@ -661,7 +661,12 @@ static const uint16_t tls12_sigalgs[] = {\n \n     TLSEXT_SIGALG_dsa_sha256,\n     TLSEXT_SIGALG_dsa_sha384,\n-    TLSEXT_SIGALG_dsa_sha512\n+    TLSEXT_SIGALG_dsa_sha512,\n+#endif\n+#ifndef OPENSSL_NO_GOST\n+    TLSEXT_SIGALG_gostr34102012_256_gostr34112012_256,\n+    TLSEXT_SIGALG_gostr34102012_512_gostr34112012_512,\n+    TLSEXT_SIGALG_gostr34102001_gostr3411,","path":"ssl/t1_lib.c","position":10,"original_position":10,"commit_id":"1fbb1ee066477303bfddea1b3b14ef5384331341","original_commit_id":"1fbb1ee066477303bfddea1b3b14ef5384331341","user":{"login":"vdukhovni","id":1107986,"node_id":"MDQ6VXNlcjExMDc5ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1107986?v=4","gravatar_id":"","url":"https://api.github.com/users/vdukhovni","html_url":"https://github.com/vdukhovni","followers_url":"https://api.github.com/users/vdukhovni/followers","following_url":"https://api.github.com/users/vdukhovni/following{/other_user}","gists_url":"https://api.github.com/users/vdukhovni/gists{/gist_id}","starred_url":"https://api.github.com/users/vdukhovni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdukhovni/subscriptions","organizations_url":"https://api.github.com/users/vdukhovni/orgs","repos_url":"https://api.github.com/users/vdukhovni/repos","events_url":"https://api.github.com/users/vdukhovni/events{/privacy}","received_events_url":"https://api.github.com/users/vdukhovni/received_events","type":"User","site_admin":false},"body":"TLS 1.2 only would make the picture less murky, and the client would should (I hope) then not accept the signature algorithm if it offered no ciphers with a GOST public key algorithm.  Matt can comment on whether perchance we already don't support these sigalgs with TLS 1.3.  The remaining question is then whether it is OK to use the code points in question without IANA assignments.","created_at":"2018-05-30T20:46:19Z","updated_at":"2018-05-30T20:46:19Z","html_url":"https://github.com/openssl/openssl/pull/6168#discussion_r191917258","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6168","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/191917258"},"html":{"href":"https://github.com/openssl/openssl/pull/6168#discussion_r191917258"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6168"}},"in_reply_to_id":191777520},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6168","id":185756301,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1NzU2MzAx","html_url":"https://github.com/openssl/openssl/pull/6168","diff_url":"https://github.com/openssl/openssl/pull/6168.diff","patch_url":"https://github.com/openssl/openssl/pull/6168.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6168","number":6168,"state":"closed","locked":false,"title":"Gostcerts2012 1 1 1","user":{"login":"beldmit","id":13785747,"node_id":"MDQ6VXNlcjEzNzg1NzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/13785747?v=4","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"body":"Restoring GOST TLS support in upstream/master.\r\n\r\nProvided GOST SignatureAlgorithms for TLS 1.2\r\nRestored selection of certificate for GOST ciphersuites allowing more than one auth type.\r\n\r\n","created_at":"2018-05-03T15:35:19Z","updated_at":"2018-05-30T20:46:19Z","closed_at":"2018-05-30T08:19:49Z","merged_at":null,"merge_commit_sha":"7abd01f4391aed64d44dd61c7586c3fa68ea072a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":314766253,"node_id":"MDU6TGFiZWwzMTQ3NjYyNTM=","url":"https://api.github.com/repos/openssl/openssl/labels/ready","name":"ready","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6168/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6168/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6168/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/1fbb1ee066477303bfddea1b3b14ef5384331341","head":{"label":"beldmit:gostcerts2012_1_1_1","ref":"gostcerts2012_1_1_1","sha":"1fbb1ee066477303bfddea1b3b14ef5384331341","user":{"login":"beldmit","id":13785747,"node_id":"MDQ6VXNlcjEzNzg1NzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/13785747?v=4","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"repo":{"id":42886943,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4Njk0Mw==","name":"openssl","full_name":"beldmit/openssl","owner":{"login":"beldmit","id":13785747,"node_id":"MDQ6VXNlcjEzNzg1NzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/13785747?v=4","gravatar_id":"","url":"https://api.github.com/users/beldmit","html_url":"https://github.com/beldmit","followers_url":"https://api.github.com/users/beldmit/followers","following_url":"https://api.github.com/users/beldmit/following{/other_user}","gists_url":"https://api.github.com/users/beldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/beldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beldmit/subscriptions","organizations_url":"https://api.github.com/users/beldmit/orgs","repos_url":"https://api.github.com/users/beldmit/repos","events_url":"https://api.github.com/users/beldmit/events{/privacy}","received_events_url":"https://api.github.com/users/beldmit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beldmit/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/beldmit/openssl","forks_url":"https://api.github.com/repos/beldmit/openssl/forks","keys_url":"https://api.github.com/repos/beldmit/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beldmit/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beldmit/openssl/teams","hooks_url":"https://api.github.com/repos/beldmit/openssl/hooks","issue_events_url":"https://api.github.com/repos/beldmit/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/beldmit/openssl/events","assignees_url":"https://api.github.com/repos/beldmit/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/beldmit/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/beldmit/openssl/tags","blobs_url":"https://api.github.com/repos/beldmit/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beldmit/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beldmit/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/beldmit/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beldmit/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/beldmit/openssl/languages","stargazers_url":"https://api.github.com/repos/beldmit/openssl/stargazers","contributors_url":"https://api.github.com/repos/beldmit/openssl/contributors","subscribers_url":"https://api.github.com/repos/beldmit/openssl/subscribers","subscription_url":"https://api.github.com/repos/beldmit/openssl/subscription","commits_url":"https://api.github.com/repos/beldmit/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/beldmit/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/beldmit/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/beldmit/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/beldmit/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/beldmit/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beldmit/openssl/merges","archive_url":"https://api.github.com/repos/beldmit/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beldmit/openssl/downloads","issues_url":"https://api.github.com/repos/beldmit/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/beldmit/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/beldmit/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/beldmit/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beldmit/openssl/labels{/name}","releases_url":"https://api.github.com/repos/beldmit/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/beldmit/openssl/deployments","created_at":"2015-09-21T18:50:11Z","updated_at":"2018-05-10T17:03:50Z","pushed_at":"2018-05-13T19:10:15Z","git_url":"git://github.com/beldmit/openssl.git","ssh_url":"git@github.com:beldmit/openssl.git","clone_url":"https://github.com/beldmit/openssl.git","svn_url":"https://github.com/beldmit/openssl","homepage":null,"size":137604,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"781fb90cd7ec28a0d4e94cbb4a95fecb72020c2d","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-05-30T20:40:41Z","pushed_at":"2018-05-30T20:12:32Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":148084,"stargazers_count":7241,"watchers_count":7241,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3484,"mirror_url":null,"archived":false,"open_issues_count":385,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3484,"open_issues":385,"watchers":7241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6168"},"html":{"href":"https://github.com/openssl/openssl/pull/6168"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6168"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6168/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6168/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6168/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/1fbb1ee066477303bfddea1b3b14ef5384331341"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vdukhovni"}}