{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28710","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28710/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28710/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28710/events","html_url":"https://github.com/cockroachdb/cockroach/pull/28710","id":351287822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTIyMzQy","number":28710,"title":"libroach: ensure encryption flags are passed if previously used.","user":{"login":"mberhault","id":5901480,"node_id":"MDQ6VXNlcjU5MDE0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5901480?v=4","gravatar_id":"","url":"https://api.github.com/users/mberhault","html_url":"https://github.com/mberhault","followers_url":"https://api.github.com/users/mberhault/followers","following_url":"https://api.github.com/users/mberhault/following{/other_user}","gists_url":"https://api.github.com/users/mberhault/gists{/gist_id}","starred_url":"https://api.github.com/users/mberhault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mberhault/subscriptions","organizations_url":"https://api.github.com/users/mberhault/orgs","repos_url":"https://api.github.com/users/mberhault/repos","events_url":"https://api.github.com/users/mberhault/events{/privacy}","received_events_url":"https://api.github.com/users/mberhault/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-16T16:55:05Z","updated_at":"2018-08-16T22:08:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28710","html_url":"https://github.com/cockroachdb/cockroach/pull/28710","diff_url":"https://github.com/cockroachdb/cockroach/pull/28710.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28710.patch"},"body":"Add some safeguards around the encryption flag.\r\nWhen we have a `COCKROACH_REGISTRY` file, we absolutely must keep using\r\nit to keep track of all files.\r\n\r\nIt gets created the first time a file is created when using the\r\nfile_registry which currently only happens when\r\n`--enterprise-encryption` is specified.\r\n\r\nThis means that if we have a registry file, we MUST have encryption\r\noptions (and be using a CCL build).\r\n\r\nAlso add a simple interactive test to check encryption transition and\r\nhandling of some bad args (wrong keys, no encryption flag)\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/413699563","html_url":"https://github.com/cockroachdb/cockroach/pull/28710#issuecomment-413699563","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28710","id":413699563,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzY5OTU2Mw==","user":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-08-16T22:08:38Z","updated_at":"2018-08-16T22:08:38Z","author_association":"NONE","body":"# Build succeeded\n  * [GitHub CI (Cockroach)](https://teamcity.cockroachdb.com/viewLog.html?buildId=842742&buildTypeId=Cockroach_UnitTests)"}}
{"actor":{"display_login":"craig"}}