{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7185","repository_url":"https://api.github.com/repos/zfsonlinux/zfs","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7185/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7185/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7185/events","html_url":"https://github.com/zfsonlinux/zfs/pull/7185","id":298019785,"number":7185,"title":"Test SPL #685","user":{"login":"DeHackEd","id":1657601,"avatar_url":"https://avatars0.githubusercontent.com/u/1657601?v=4","gravatar_id":"","url":"https://api.github.com/users/DeHackEd","html_url":"https://github.com/DeHackEd","followers_url":"https://api.github.com/users/DeHackEd/followers","following_url":"https://api.github.com/users/DeHackEd/following{/other_user}","gists_url":"https://api.github.com/users/DeHackEd/gists{/gist_id}","starred_url":"https://api.github.com/users/DeHackEd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeHackEd/subscriptions","organizations_url":"https://api.github.com/users/DeHackEd/orgs","repos_url":"https://api.github.com/users/DeHackEd/repos","events_url":"https://api.github.com/users/DeHackEd/events{/privacy}","received_events_url":"https://api.github.com/users/DeHackEd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-17T17:08:20Z","updated_at":"2018-02-21T22:55:38Z","closed_at":"2018-02-21T22:55:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7185","html_url":"https://github.com/zfsonlinux/zfs/pull/7185","diff_url":"https://github.com/zfsonlinux/zfs/pull/7185.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/7185.patch"},"body":"Requires-spl: refs/pull/685/head\r\nSigned-off-by: DHE <git@dehacked.net>\r\n\r\n### Description\r\nThe current implementation in SPL evaluates its parameters twice if the condition fails. This might lead to unexpected results, from hangs to the error message reported to `dmesg` having the wrong return code. I have seen `VERIFY3 failed (0 == 0)` today.\r\n\r\n### Motivation and Context\r\nSomeone in IRC had the `(0 == 0)` scenario happen. That needs fixing.\r\n\r\n### How Has This Been Tested?\r\nBuild test only for now. Buildbots can run a kernel test plz.\r\n\r\n### Types of changes\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Performance enhancement (non-breaking change which improves efficiency)\r\n- [ ] Code cleanup (non-breaking change which makes code smaller or more readable)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation (a change to man pages or other documentation)\r\n\r\n### Checklist:\r\n- [X] My code follows the ZFS on Linux code style requirements.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n- [X] All commit messages are properly formatted and contain `Signed-off-by`.\r\n- [ ] Change has been approved by a ZFS on Linux member.\r\n"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/367505880","html_url":"https://github.com/zfsonlinux/zfs/pull/7185#issuecomment-367505880","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7185","id":367505880,"user":{"login":"DeHackEd","id":1657601,"avatar_url":"https://avatars0.githubusercontent.com/u/1657601?v=4","gravatar_id":"","url":"https://api.github.com/users/DeHackEd","html_url":"https://github.com/DeHackEd","followers_url":"https://api.github.com/users/DeHackEd/followers","following_url":"https://api.github.com/users/DeHackEd/following{/other_user}","gists_url":"https://api.github.com/users/DeHackEd/gists{/gist_id}","starred_url":"https://api.github.com/users/DeHackEd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeHackEd/subscriptions","organizations_url":"https://api.github.com/users/DeHackEd/orgs","repos_url":"https://api.github.com/users/DeHackEd/repos","events_url":"https://api.github.com/users/DeHackEd/events{/privacy}","received_events_url":"https://api.github.com/users/DeHackEd/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T22:55:38Z","updated_at":"2018-02-21T22:55:38Z","author_association":"CONTRIBUTOR","body":"Closing since Brian merged the SPL PR."}}
{"actor":{"display_login":"DeHackEd"}}