{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/199533229","pull_request_review_id":133669991,"id":199533229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTUzMzIyOQ==","diff_hunk":"@@ -386,12 +395,6 @@ func (configgen *ConfigGeneratorImpl) buildSidecarOutboundListeners(env model.En\n \t\t\t\toperation := http_conn.EGRESS\n \t\t\t\tuseRemoteAddress := false\n \n-\t\t\t\tif node.Type == model.Router {","path":"pilot/pkg/networking/core/v1alpha3/listener.go","position":27,"original_position":27,"commit_id":"39bc39280ebd4c67721983bf84b4596c5a3a73ff","original_commit_id":"39bc39280ebd4c67721983bf84b4596c5a3a73ff","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"why remove this?","created_at":"2018-07-02T15:21:26Z","updated_at":"2018-07-02T15:21:26Z","html_url":"https://github.com/istio/istio/pull/6402#discussion_r199533229","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6402","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/199533229"},"html":{"href":"https://github.com/istio/istio/pull/6402#discussion_r199533229"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6402"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6402","id":195893249,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODkzMjQ5","html_url":"https://github.com/istio/istio/pull/6402","diff_url":"https://github.com/istio/istio/pull/6402.diff","patch_url":"https://github.com/istio/istio/pull/6402.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6402","number":6402,"state":"open","locked":false,"title":"SNI routing from sidecar to gateway with virtual services","user":{"login":"ijsnellf","id":19473346,"node_id":"MDQ6VXNlcjE5NDczMzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"body":"This PR adds basic SNI routing with matching of `sourceLabels` and `mesh` but no L4 attributes. Virtual service hosts must exist in the registry and the match port and destination ports must match.\r\n\r\nThe aim is to be able to support forcing traffic through the egress gateway using SNI.\r\n```yaml\r\napiVersion: networking.istio.io/v1alpha3\r\nkind: ServiceEntry\r\nmetadata:\r\n  name: wikipedia-sni\r\nspec:\r\n  hosts:\r\n  - www.wikipedia.org\r\n  ports:\r\n    - number: 443\r\n      protocol: TLS\r\n      name: tls-port\r\n  resolution: DNS\r\n---\r\napiVersion: networking.istio.io/v1alpha3\r\nkind: Gateway\r\nmetadata:\r\n  name: istio-egressgateway\r\nspec:\r\n  selector:\r\n    # DO NOT CHANGE THESE LABELS\r\n    # The egressgateway is defined in install/kubernetes/helm/istio/values.yaml\r\n    # with these labels\r\n    istio: egressgateway\r\n  servers:\r\n  - port:\r\n      number: 443\r\n      name: tls\r\n      protocol: tls\r\n    hosts:\r\n    - \"www.wikipedia.org\"\r\n    tls:\r\n      mode: PASSTHROUGH\r\n---\r\napiVersion: networking.istio.io/v1alpha3\r\nkind: VirtualService\r\nmetadata:\r\n  name: force-a-to-wiki-through-egress-gateway\r\nspec:\r\n  hosts:\r\n  - www.wikipedia.org\r\n  tls:\r\n  - match:\r\n    - sourceLabels:\r\n        app: a\r\n      gateways:\r\n      - mesh\r\n      sniHosts:\r\n      - \"www.wikipedia.org\"\r\n    route:\r\n    - destination:\r\n        # use the shortname so the test doesn't depend on istio-system namespace\r\n        host: istio-egressgateway\r\n        port:\r\n          number: 443\r\n  - match:\r\n    - gateways:\r\n      - istio-egressgateway\r\n      sniHosts:\r\n      - \"www.wikipedia.org\"\r\n    route:\r\n    - destination:\r\n        host: www.wikipedia.org\r\n        port:\r\n          number: 443\r\n```\r\n\r\n","created_at":"2018-06-19T16:51:54Z","updated_at":"2018-07-02T15:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a935be197a2adf4eec303bd4e2593abb9deae3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"louiscryan","id":9046588,"node_id":"MDQ6VXNlcjkwNDY1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/9046588?v=4","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},{"login":"vadimeisenbergibm","id":16784982,"node_id":"MDQ6VXNlcjE2Nzg0OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/16784982?v=4","gravatar_id":"","url":"https://api.github.com/users/vadimeisenbergibm","html_url":"https://github.com/vadimeisenbergibm","followers_url":"https://api.github.com/users/vadimeisenbergibm/followers","following_url":"https://api.github.com/users/vadimeisenbergibm/following{/other_user}","gists_url":"https://api.github.com/users/vadimeisenbergibm/gists{/gist_id}","starred_url":"https://api.github.com/users/vadimeisenbergibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadimeisenbergibm/subscriptions","organizations_url":"https://api.github.com/users/vadimeisenbergibm/orgs","repos_url":"https://api.github.com/users/vadimeisenbergibm/repos","events_url":"https://api.github.com/users/vadimeisenbergibm/events{/privacy}","received_events_url":"https://api.github.com/users/vadimeisenbergibm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/istio/istio/milestones/12","html_url":"https://github.com/istio/istio/milestone/12","labels_url":"https://api.github.com/repos/istio/istio/milestones/12/labels","id":3443496,"node_id":"MDk6TWlsZXN0b25lMzQ0MzQ5Ng==","number":12,"title":"1.0","description":"Items that are triaged and specifically targeted for 1.0","creator":{"login":"louiscryan","id":9046588,"node_id":"MDQ6VXNlcjkwNDY1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/9046588?v=4","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":19,"state":"open","created_at":"2018-06-21T22:58:17Z","updated_at":"2018-07-02T13:47:36Z","due_on":"2018-07-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/istio/istio/pulls/6402/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6402/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6402/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/39bc39280ebd4c67721983bf84b4596c5a3a73ff","head":{"label":"ijsnellf:basic_sni_routing","ref":"basic_sni_routing","sha":"39bc39280ebd4c67721983bf84b4596c5a3a73ff","user":{"login":"ijsnellf","id":19473346,"node_id":"MDQ6VXNlcjE5NDczMzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"repo":{"id":123497648,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTc2NDg=","name":"istio","full_name":"ijsnellf/istio","owner":{"login":"ijsnellf","id":19473346,"node_id":"MDQ6VXNlcjE5NDczMzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijsnellf/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ijsnellf/istio","forks_url":"https://api.github.com/repos/ijsnellf/istio/forks","keys_url":"https://api.github.com/repos/ijsnellf/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijsnellf/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijsnellf/istio/teams","hooks_url":"https://api.github.com/repos/ijsnellf/istio/hooks","issue_events_url":"https://api.github.com/repos/ijsnellf/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ijsnellf/istio/events","assignees_url":"https://api.github.com/repos/ijsnellf/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ijsnellf/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ijsnellf/istio/tags","blobs_url":"https://api.github.com/repos/ijsnellf/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijsnellf/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijsnellf/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijsnellf/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijsnellf/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ijsnellf/istio/languages","stargazers_url":"https://api.github.com/repos/ijsnellf/istio/stargazers","contributors_url":"https://api.github.com/repos/ijsnellf/istio/contributors","subscribers_url":"https://api.github.com/repos/ijsnellf/istio/subscribers","subscription_url":"https://api.github.com/repos/ijsnellf/istio/subscription","commits_url":"https://api.github.com/repos/ijsnellf/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijsnellf/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijsnellf/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijsnellf/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijsnellf/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ijsnellf/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijsnellf/istio/merges","archive_url":"https://api.github.com/repos/ijsnellf/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijsnellf/istio/downloads","issues_url":"https://api.github.com/repos/ijsnellf/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ijsnellf/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ijsnellf/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ijsnellf/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijsnellf/istio/labels{/name}","releases_url":"https://api.github.com/repos/ijsnellf/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ijsnellf/istio/deployments","created_at":"2018-03-01T22:03:57Z","updated_at":"2018-03-01T22:04:02Z","pushed_at":"2018-07-02T14:49:32Z","git_url":"git://github.com/ijsnellf/istio.git","ssh_url":"git@github.com:ijsnellf/istio.git","clone_url":"https://github.com/ijsnellf/istio.git","svn_url":"https://github.com/ijsnellf/istio","homepage":"https://istio.io","size":40221,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"d6a0aa71449970c5b7dd498f16cf956d01cb000c","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-07-02T14:57:33Z","pushed_at":"2018-07-02T14:49:34Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":40625,"stargazers_count":9026,"watchers_count":9026,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1241,"mirror_url":null,"archived":false,"open_issues_count":812,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1241,"open_issues":812,"watchers":9026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6402"},"html":{"href":"https://github.com/istio/istio/pull/6402"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6402"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6402/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6402/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6402/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/39bc39280ebd4c67721983bf84b4596c5a3a73ff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rshriram"}}