{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/comments/177575273","pull_request_review_id":107381862,"id":177575273,"diff_hunk":"@@ -0,0 +1,51 @@\n+CRM.$(function ($) {","path":"js/directDebitInformation.js","position":1,"original_position":1,"commit_id":"bf3fa183fc6b7e76165bd45ce755cf9156625db2","original_commit_id":"bf3fa183fc6b7e76165bd45ce755cf9156625db2","user":{"login":"omarabuhussein","id":6275540,"avatar_url":"https://avatars1.githubusercontent.com/u/6275540?v=4","gravatar_id":"","url":"https://api.github.com/users/omarabuhussein","html_url":"https://github.com/omarabuhussein","followers_url":"https://api.github.com/users/omarabuhussein/followers","following_url":"https://api.github.com/users/omarabuhussein/following{/other_user}","gists_url":"https://api.github.com/users/omarabuhussein/gists{/gist_id}","starred_url":"https://api.github.com/users/omarabuhussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarabuhussein/subscriptions","organizations_url":"https://api.github.com/users/omarabuhussein/orgs","repos_url":"https://api.github.com/users/omarabuhussein/repos","events_url":"https://api.github.com/users/omarabuhussein/events{/privacy}","received_events_url":"https://api.github.com/users/omarabuhussein/received_events","type":"User","site_admin":false},"body":"but this js file do nothing currently, right ? because I don't see you adding it to any page in the PR code, or am I miss something ?","created_at":"2018-03-27T21:17:03Z","updated_at":"2018-03-27T21:19:04Z","html_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10#discussion_r177575273","pull_request_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/comments/177575273"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10#discussion_r177575273"},"pull_request":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10","id":177431376,"html_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10","diff_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/10","number":10,"state":"open","locked":false,"title":"DD-6: Show Mandate ID in recurring contribution and provide mandate view in a modal for admin","user":{"login":"awg-github","id":36959503,"avatar_url":"https://avatars2.githubusercontent.com/u/36959503?v=4","gravatar_id":"","url":"https://api.github.com/users/awg-github","html_url":"https://github.com/awg-github","followers_url":"https://api.github.com/users/awg-github/followers","following_url":"https://api.github.com/users/awg-github/following{/other_user}","gists_url":"https://api.github.com/users/awg-github/gists{/gist_id}","starred_url":"https://api.github.com/users/awg-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awg-github/subscriptions","organizations_url":"https://api.github.com/users/awg-github/orgs","repos_url":"https://api.github.com/users/awg-github/repos","events_url":"https://api.github.com/users/awg-github/events{/privacy}","received_events_url":"https://api.github.com/users/awg-github/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n1. When a new contribution is created, empty mandate record is created. It's generated mandate_id is assigned to just created contribution.\r\n2. For any contribution types (recurring or individual) the assigned mandate_id is added to the \"direct_debit_information\" custom group.\r\n3. For recurring contribution assigned mandate_id plus recurr_id are added into dd_contribution_recurr_mandate_ref table. To keep relation between recurring contribution and mandate\r\n4. For recurring contribution preview screen we display the \"Direct Debit information\" custom group with assigned mandate_id. By clicking on this mandate_is the modal view appears and displays detailed information about this mandate.\r\n5. Add constraint (foreign keys) in dd_contribution_recurr_mandate_ref custom table.\r\n6. Remove linked parameters from BAO methods, remove transaction, remove deleteEntity() method and change creation BAO object from full reference to new self() .\r\n7. Modify title and description in DAO object.\r\n\r\n![dd-6](https://user-images.githubusercontent.com/36959503/37906258-21ffbcf2-310a-11e8-9b42-e09ad4b86de9.gif)","created_at":"2018-03-26T12:32:59Z","updated_at":"2018-03-27T21:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5472171ea3cff4a7943a86fdd96a42222628cee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"guanhuan","id":6278917,"avatar_url":"https://avatars3.githubusercontent.com/u/6278917?v=4","gravatar_id":"","url":"https://api.github.com/users/guanhuan","html_url":"https://github.com/guanhuan","followers_url":"https://api.github.com/users/guanhuan/followers","following_url":"https://api.github.com/users/guanhuan/following{/other_user}","gists_url":"https://api.github.com/users/guanhuan/gists{/gist_id}","starred_url":"https://api.github.com/users/guanhuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guanhuan/subscriptions","organizations_url":"https://api.github.com/users/guanhuan/orgs","repos_url":"https://api.github.com/users/guanhuan/repos","events_url":"https://api.github.com/users/guanhuan/events{/privacy}","received_events_url":"https://api.github.com/users/guanhuan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/10/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/statuses/bf3fa183fc6b7e76165bd45ce755cf9156625db2","head":{"label":"compucorp:DD-6","ref":"DD-6","sha":"bf3fa183fc6b7e76165bd45ce755cf9156625db2","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":120764046,"name":"uk.co.compucorp.manualdirectdebit","full_name":"compucorp/uk.co.compucorp.manualdirectdebit","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit","description":"CiviCRM Manual Direct Debit","fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/deployments","created_at":"2018-02-08T13:21:02Z","updated_at":"2018-03-12T18:52:26Z","pushed_at":"2018-03-26T12:32:59Z","git_url":"git://github.com/compucorp/uk.co.compucorp.manualdirectdebit.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.manualdirectdebit.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"compucorp:develop","ref":"develop","sha":"47a8f61e5e2a3bb3268c53cdc0669027975db65d","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":120764046,"name":"uk.co.compucorp.manualdirectdebit","full_name":"compucorp/uk.co.compucorp.manualdirectdebit","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit","description":"CiviCRM Manual Direct Debit","fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/deployments","created_at":"2018-02-08T13:21:02Z","updated_at":"2018-03-12T18:52:26Z","pushed_at":"2018-03-26T12:32:59Z","git_url":"git://github.com/compucorp/uk.co.compucorp.manualdirectdebit.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.manualdirectdebit.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit","homepage":null,"size":58,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.manualdirectdebit/pull/10"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/10"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.manualdirectdebit/statuses/bf3fa183fc6b7e76165bd45ce755cf9156625db2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"omarabuhussein"}}