{"action":"created","comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/172916484","pull_request_review_id":101998599,"id":172916484,"diff_hunk":"@@ -0,0 +1,49 @@\n+<?php\n+/**\n+ *\n+ * SugarCRM Community Edition is a customer relationship management program developed by\n+ * SugarCRM, Inc. Copyright (C) 2004-2013 SugarCRM Inc.\n+ *\n+ * SuiteCRM is an extension to SugarCRM Community Edition developed by SalesAgility Ltd.\n+ * Copyright (C) 2011 - 2018 SalesAgility Ltd.\n+ *\n+ * This program is free software; you can redistribute it and/or modify it under\n+ * the terms of the GNU Affero General Public License version 3 as published by the\n+ * Free Software Foundation with the addition of the following permission added\n+ * to Section 15 as permitted in Section 7(a): FOR ANY PART OF THE COVERED WORK\n+ * IN WHICH THE COPYRIGHT IS OWNED BY SUGARCRM, SUGARCRM DISCLAIMS THE WARRANTY\n+ * OF NON INFRINGEMENT OF THIRD PARTY RIGHTS.\n+ *\n+ * This program is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS\n+ * FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more\n+ * details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License along with\n+ * this program; if not, see http://www.gnu.org/licenses or write to the Free\n+ * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA\n+ * 02110-1301 USA.\n+ *\n+ * You can contact SugarCRM, Inc. headquarters at 10050 North Wolfe Road,\n+ * SW2-130, Cupertino, CA 95014, USA. or at email address contact@sugarcrm.com.\n+ *\n+ * The interactive user interfaces in modified source and object code versions\n+ * of this program must display Appropriate Legal Notices, as required under\n+ * Section 5 of the GNU Affero General Public License version 3.\n+ *\n+ * In accordance with Section 7(b) of the GNU Affero General Public License version 3,\n+ * these Appropriate Legal Notices must retain the display of the \"Powered by\n+ * SugarCRM\" logo and \"Supercharged by SuiteCRM\" logo. If the display of the logos is not\n+ * reasonably feasible for technical reasons, the Appropriate Legal Notices must\n+ * display the words \"Powered by SugarCRM\" and \"Supercharged by SuiteCRM\".\n+ */\n+\n+if (!defined('sugarEntry') || !sugarEntry) {\n+    die('Not A Valid Entry Point');\n+}\n+\n+\n+/**\n+ * Class JAccountException\n+ */\n+class JAccountException extends Exception {}","path":"modules/JAccount/JAccountException.php","position":49,"original_position":49,"commit_id":"7492e5292ba16b3d2d8fdf6b70909e7da8583add","original_commit_id":"7492e5292ba16b3d2d8fdf6b70909e7da8583add","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"body":"Please Don't defined empty exceptions, conside using the constructor to define a default message and error code.","created_at":"2018-03-07T17:13:45Z","updated_at":"2018-03-07T17:19:47Z","html_url":"https://github.com/salesagility/SuiteCRM/pull/5426#discussion_r172916484","pull_request_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/172916484"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5426#discussion_r172916484"},"pull_request":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426"}}},"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426","id":173443773,"html_url":"https://github.com/salesagility/SuiteCRM/pull/5426","diff_url":"https://github.com/salesagility/SuiteCRM/pull/5426.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/5426.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5426","number":5426,"state":"open","locked":false,"title":"Multi AOP","user":{"login":"gymad","id":13831178,"avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\n\r\nability to join multiple joomla site to suitecrm\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n\r\njoin multiple joomla site to crm, try each functionality in cases module with multiple users...\r\ntest for backward compatibility, upgrade an older version of suitecrm and add more joomla sites\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-03-07T12:56:15Z","updated_at":"2018-03-07T17:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fc7543becabf0e18e0572f37151a42ee21e5b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5426/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/7492e5292ba16b3d2d8fdf6b70909e7da8583add","head":{"label":"gymad:develop_multi_aop","ref":"develop_multi_aop","sha":"7492e5292ba16b3d2d8fdf6b70909e7da8583add","user":{"login":"gymad","id":13831178,"avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"repo":{"id":41494060,"name":"SuiteCRM","full_name":"gymad/SuiteCRM","owner":{"login":"gymad","id":13831178,"avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gymad/SuiteCRM","description":"SuiteCRM is SugarCRM Supercharged. It's the Free Open Source alternative to SugarCRM Professional.","fork":true,"url":"https://api.github.com/repos/gymad/SuiteCRM","forks_url":"https://api.github.com/repos/gymad/SuiteCRM/forks","keys_url":"https://api.github.com/repos/gymad/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gymad/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gymad/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/gymad/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/gymad/SuiteCRM/events","assignees_url":"https://api.github.com/repos/gymad/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/gymad/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/gymad/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gymad/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/gymad/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gymad/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/gymad/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/gymad/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/gymad/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/gymad/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/gymad/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/gymad/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/gymad/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/gymad/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/gymad/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/gymad/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gymad/SuiteCRM/merges","archive_url":"https://api.github.com/repos/gymad/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gymad/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/gymad/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/gymad/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/gymad/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/gymad/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gymad/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/gymad/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/gymad/SuiteCRM/deployments","created_at":"2015-08-27T15:11:18Z","updated_at":"2016-06-30T11:24:42Z","pushed_at":"2018-03-07T15:00:03Z","git_url":"git://github.com/gymad/SuiteCRM.git","ssh_url":"git@github.com:gymad/SuiteCRM.git","clone_url":"https://github.com/gymad/SuiteCRM.git","svn_url":"https://github.com/gymad/SuiteCRM","homepage":"http://www.suitecrm.com","size":89749,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:develop","ref":"develop","sha":"159968fbb0a49911f22867acef01b3ffd4d1a57e","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-03-07T14:12:59Z","pushed_at":"2018-03-07T16:03:27Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":88213,"stargazers_count":911,"watchers_count":911,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":730,"mirror_url":null,"archived":false,"open_issues_count":898,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":730,"open_issues":898,"watchers":911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5426"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5426"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5426/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5426/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/7492e5292ba16b3d2d8fdf6b70909e7da8583add"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"daniel-samson"}}