{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/180641514","pull_request_review_id":111094706,"id":180641514,"diff_hunk":"@@ -120,6 +128,24 @@ void SiPixelDigitizerAlgorithm::init(const edm::EventSetup& es) {\n   //gets the map and geometry from the DB (to kill ROCs)\n   es.get<SiPixelFedCablingMapRcd>().get(map_);\n   es.get<TrackerDigiGeometryRecord>().get(geom_);\n+\n+  // Read template files for charge reweighting\n+  if (UseTemplateAgeing){","path":"SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc","position":53,"original_position":48,"commit_id":"7e5e26285e03f3c61f52f7d4c5d63deee92d8ea8","original_commit_id":"5d2251cc82bfd4b5118c84bd86ceb7424d5491d8","user":{"login":"schuetzepaul","id":9463445,"avatar_url":"https://avatars0.githubusercontent.com/u/9463445?v=4","gravatar_id":"","url":"https://api.github.com/users/schuetzepaul","html_url":"https://github.com/schuetzepaul","followers_url":"https://api.github.com/users/schuetzepaul/followers","following_url":"https://api.github.com/users/schuetzepaul/following{/other_user}","gists_url":"https://api.github.com/users/schuetzepaul/gists{/gist_id}","starred_url":"https://api.github.com/users/schuetzepaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuetzepaul/subscriptions","organizations_url":"https://api.github.com/users/schuetzepaul/orgs","repos_url":"https://api.github.com/users/schuetzepaul/repos","events_url":"https://api.github.com/users/schuetzepaul/events{/privacy}","received_events_url":"https://api.github.com/users/schuetzepaul/received_events","type":"User","site_admin":false},"body":"You're completely right. I took this flag from Andreas and never touched it. Probably something like `UseTemplates` or `UseReweighting` would describe the feature more adequately. ","created_at":"2018-04-11T05:52:00Z","updated_at":"2018-04-11T05:52:01Z","html_url":"https://github.com/cms-sw/cmssw/pull/22911#discussion_r180641514","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/180641514"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22911#discussion_r180641514"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911"}},"in_reply_to_id":180550751},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911","id":180305414,"html_url":"https://github.com/cms-sw/cmssw/pull/22911","diff_url":"https://github.com/cms-sw/cmssw/pull/22911.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22911.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22911","number":22911,"state":"open","locked":false,"title":"Pixel Digitizer: Cluster charge re-weighting for 10_2_X","user":{"login":"schuetzepaul","id":9463445,"avatar_url":"https://avatars0.githubusercontent.com/u/9463445?v=4","gravatar_id":"","url":"https://api.github.com/users/schuetzepaul","html_url":"https://github.com/schuetzepaul","followers_url":"https://api.github.com/users/schuetzepaul/followers","following_url":"https://api.github.com/users/schuetzepaul/following{/other_user}","gists_url":"https://api.github.com/users/schuetzepaul/gists{/gist_id}","starred_url":"https://api.github.com/users/schuetzepaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuetzepaul/subscriptions","organizations_url":"https://api.github.com/users/schuetzepaul/orgs","repos_url":"https://api.github.com/users/schuetzepaul/repos","events_url":"https://api.github.com/users/schuetzepaul/events{/privacy}","received_events_url":"https://api.github.com/users/schuetzepaul/received_events","type":"User","site_admin":false},"body":"_This replaces #22470 ._\r\n\r\nPixel Digitizer for simulated data:\r\n\r\nThe possibility to apply a re-weighting to the charge was added for a proper modelling of radiation damage in the silicon sensors. The re-weighting is based on the 2D cluster templates for the Phase 1 Pixel Detector introduced in #22458 , which is now merged. In addition to changes in the digitizer part, a bug was fixed in the template definition.\r\n\r\nThe newly added code is _by default turned off_, a flag in the configuration is needed to run it. Therefore the changes in the digitizer are fully backwards compatible.\r\nWe still open a PR for the upcoming release in order to simplify the testing and future development of the re-weighting.\r\n\r\nFor running the new code, the following lines serve as an example:\r\n```\r\nfrom SimGeneral.MixingModule.pixelDigitizer_cfi import *\r\nprocess.mix.digitizers.pixel.UseTemplateAgeing = cms.bool(True)\r\n\r\nfrom Configuration.AlCa.GlobalTag import GlobalTag\r\nprocess.GlobalTag = GlobalTag(process.GlobalTag, '101X_upgrade2018_realistic_Candidate_2018_03_15_16_26_46', '')\r\n```\r\n\r\nThe GlobalTag was created for this purpose by @tvami  - there are also alternatives for loading the databases available if needed.\r\n\r\nHere is a quick note on the concept and plots with tests in the current status: https://desycloud.desy.de/index.php/s/63lG4vCeMNf7XaE","created_at":"2018-04-09T13:08:14Z","updated_at":"2018-04-11T05:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e2023449691b4c54b8247e03095430bd430d2bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":116,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-04-10T20:43:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22911/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/7e5e26285e03f3c61f52f7d4c5d63deee92d8ea8","head":{"label":"schuetzepaul:clusterChargeReweightingPR_10_2_X","ref":"clusterChargeReweightingPR_10_2_X","sha":"7e5e26285e03f3c61f52f7d4c5d63deee92d8ea8","user":{"login":"schuetzepaul","id":9463445,"avatar_url":"https://avatars0.githubusercontent.com/u/9463445?v=4","gravatar_id":"","url":"https://api.github.com/users/schuetzepaul","html_url":"https://github.com/schuetzepaul","followers_url":"https://api.github.com/users/schuetzepaul/followers","following_url":"https://api.github.com/users/schuetzepaul/following{/other_user}","gists_url":"https://api.github.com/users/schuetzepaul/gists{/gist_id}","starred_url":"https://api.github.com/users/schuetzepaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuetzepaul/subscriptions","organizations_url":"https://api.github.com/users/schuetzepaul/orgs","repos_url":"https://api.github.com/users/schuetzepaul/repos","events_url":"https://api.github.com/users/schuetzepaul/events{/privacy}","received_events_url":"https://api.github.com/users/schuetzepaul/received_events","type":"User","site_admin":false},"repo":{"id":83779177,"name":"cmssw","full_name":"schuetzepaul/cmssw","owner":{"login":"schuetzepaul","id":9463445,"avatar_url":"https://avatars0.githubusercontent.com/u/9463445?v=4","gravatar_id":"","url":"https://api.github.com/users/schuetzepaul","html_url":"https://github.com/schuetzepaul","followers_url":"https://api.github.com/users/schuetzepaul/followers","following_url":"https://api.github.com/users/schuetzepaul/following{/other_user}","gists_url":"https://api.github.com/users/schuetzepaul/gists{/gist_id}","starred_url":"https://api.github.com/users/schuetzepaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuetzepaul/subscriptions","organizations_url":"https://api.github.com/users/schuetzepaul/orgs","repos_url":"https://api.github.com/users/schuetzepaul/repos","events_url":"https://api.github.com/users/schuetzepaul/events{/privacy}","received_events_url":"https://api.github.com/users/schuetzepaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schuetzepaul/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/schuetzepaul/cmssw","forks_url":"https://api.github.com/repos/schuetzepaul/cmssw/forks","keys_url":"https://api.github.com/repos/schuetzepaul/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schuetzepaul/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schuetzepaul/cmssw/teams","hooks_url":"https://api.github.com/repos/schuetzepaul/cmssw/hooks","issue_events_url":"https://api.github.com/repos/schuetzepaul/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/schuetzepaul/cmssw/events","assignees_url":"https://api.github.com/repos/schuetzepaul/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/schuetzepaul/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/schuetzepaul/cmssw/tags","blobs_url":"https://api.github.com/repos/schuetzepaul/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schuetzepaul/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schuetzepaul/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/schuetzepaul/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schuetzepaul/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/schuetzepaul/cmssw/languages","stargazers_url":"https://api.github.com/repos/schuetzepaul/cmssw/stargazers","contributors_url":"https://api.github.com/repos/schuetzepaul/cmssw/contributors","subscribers_url":"https://api.github.com/repos/schuetzepaul/cmssw/subscribers","subscription_url":"https://api.github.com/repos/schuetzepaul/cmssw/subscription","commits_url":"https://api.github.com/repos/schuetzepaul/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/schuetzepaul/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/schuetzepaul/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/schuetzepaul/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/schuetzepaul/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/schuetzepaul/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schuetzepaul/cmssw/merges","archive_url":"https://api.github.com/repos/schuetzepaul/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schuetzepaul/cmssw/downloads","issues_url":"https://api.github.com/repos/schuetzepaul/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/schuetzepaul/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/schuetzepaul/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/schuetzepaul/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schuetzepaul/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/schuetzepaul/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/schuetzepaul/cmssw/deployments","created_at":"2017-03-03T09:04:13Z","updated_at":"2017-03-03T09:07:13Z","pushed_at":"2018-04-10T12:37:22Z","git_url":"git://github.com/schuetzepaul/cmssw.git","ssh_url":"git@github.com:schuetzepaul/cmssw.git","clone_url":"https://github.com/schuetzepaul/cmssw.git","svn_url":"https://github.com/schuetzepaul/cmssw","homepage":"http://cms-sw.github.io/","size":998385,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"0811eb61e66388c91980544b24cd950e5a162fbc","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-04-10T20:43:50Z","pushed_at":"2018-04-10T22:23:50Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":998188,"stargazers_count":540,"watchers_count":540,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2527,"mirror_url":null,"archived":false,"open_issues_count":460,"license":null,"forks":2527,"open_issues":460,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/22911"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22911"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/22911/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/22911/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/7e5e26285e03f3c61f52f7d4c5d63deee92d8ea8"}},"author_association":"NONE"}}
{"actor":{"display_login":"schuetzepaul"}}