{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/234167361","pull_request_review_id":175753307,"id":234167361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE2NzM2MQ==","diff_hunk":"@@ -47,6 +47,7 @@ exports.getIPFS = (argv, callback) => {\n   // Required inline to reduce startup time\n   const IPFS = require('../core')\n   const node = new IPFS({\n+    print: argv.print,","path":"src/cli/utils.js","position":4,"original_position":4,"commit_id":"f880357e288b669ada231615b17282cdec1a0cb9","original_commit_id":"f880357e288b669ada231615b17282cdec1a0cb9","user":{"login":"alanshaw","id":152863,"node_id":"MDQ6VXNlcjE1Mjg2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/152863?v=4","gravatar_id":"","url":"https://api.github.com/users/alanshaw","html_url":"https://github.com/alanshaw","followers_url":"https://api.github.com/users/alanshaw/followers","following_url":"https://api.github.com/users/alanshaw/following{/other_user}","gists_url":"https://api.github.com/users/alanshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/alanshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanshaw/subscriptions","organizations_url":"https://api.github.com/users/alanshaw/orgs","repos_url":"https://api.github.com/users/alanshaw/repos","events_url":"https://api.github.com/users/alanshaw/events{/privacy}","received_events_url":"https://api.github.com/users/alanshaw/received_events","type":"User","site_admin":false},"body":"The option name is `silent`, not `print`.","created_at":"2018-11-16T11:03:11Z","updated_at":"2018-11-16T11:03:12Z","html_url":"https://github.com/ipfs/js-ipfs/pull/1712#discussion_r234167361","pull_request_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments/234167361"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1712#discussion_r234167361"},"pull_request":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712"}},"in_reply_to_id":234165130},"pull_request":{"url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712","id":231125385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTI1Mzg1","html_url":"https://github.com/ipfs/js-ipfs/pull/1712","diff_url":"https://github.com/ipfs/js-ipfs/pull/1712.diff","patch_url":"https://github.com/ipfs/js-ipfs/pull/1712.patch","issue_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1712","number":1712,"state":"open","locked":false,"title":"First attempt at activating silent option in cli","user":{"login":"pkafei","id":1463964,"node_id":"MDQ6VXNlcjE0NjM5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1463964?v=4","gravatar_id":"","url":"https://api.github.com/users/pkafei","html_url":"https://github.com/pkafei","followers_url":"https://api.github.com/users/pkafei/followers","following_url":"https://api.github.com/users/pkafei/following{/other_user}","gists_url":"https://api.github.com/users/pkafei/gists{/gist_id}","starred_url":"https://api.github.com/users/pkafei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkafei/subscriptions","organizations_url":"https://api.github.com/users/pkafei/orgs","repos_url":"https://api.github.com/users/pkafei/repos","events_url":"https://api.github.com/users/pkafei/events{/privacy}","received_events_url":"https://api.github.com/users/pkafei/received_events","type":"User","site_admin":false},"body":"This PR is related to https://github.com/ipfs/js-ipfs/issues/1683. This PR is not merge-ready and I wanted to highlight some of the issues I've currently ran into.\r\n\r\n`node src/cli/bin daemon --silent` does not disable printing \"Swarming listening on...\" and I'm not sure exactly why this option is not picked up by the core library. \r\n\r\nAlso, when I use `print` as a property the peer address is printed on a new line. Not sure how to remedy this behavior but I did try using `process.stdout.write()`. https://stackoverflow.com/questions/6157497/node-js-printing-to-console-without-a-trailing-newline\r\n\r\nHowever when I implemented `process.stdout.write()` the address came before the print statement `process.stdout.write()`\r\n```\r\nInitializing IPFS daemon...\r\n/ip4/127.0.0.1/tcp/4003/ws/ipfs/QmYT3Sv3paCcitjsSbBaeCuXRjcpTs4J87hVPyS4YLiji6Swarm listening on\r\n/ip4/127.0.0.1/tcp/4002/ipfs/QmYT3Sv3paCcitjsSbBaeCuXRjcpTs4J87hVPyS4YLiji6Swarm listening on\r\n/ip4/192.168.1.27/tcp/4002/ipfs/QmYT3Sv3paCcitjsSbBaeCuXRjcpTs4J87hVPyS4YLiji6Swarm listening on\r\n/ip4/10.52.0.22/tcp/4002/ipfs/QmYT3Sv3paCcitjsSbBaeCuXRjcpTs4J87hVPyS4YLiji6Swarm listening on\r\nAPI listening on /ip4/127.0.0.1/tcp/5002\r\nGateway (read only) listening on /ip4/127.0.0.1/tcp/9090\r\nWeb UI available at http://127.0.0.1:5002/webui\r\n```","created_at":"2018-11-15T09:35:23Z","updated_at":"2018-11-16T11:03:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c9d514aae8bb50517bdb17ed1ceba803ec0c276","assignee":{"login":"pkafei","id":1463964,"node_id":"MDQ6VXNlcjE0NjM5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1463964?v=4","gravatar_id":"","url":"https://api.github.com/users/pkafei","html_url":"https://github.com/pkafei","followers_url":"https://api.github.com/users/pkafei/followers","following_url":"https://api.github.com/users/pkafei/following{/other_user}","gists_url":"https://api.github.com/users/pkafei/gists{/gist_id}","starred_url":"https://api.github.com/users/pkafei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkafei/subscriptions","organizations_url":"https://api.github.com/users/pkafei/orgs","repos_url":"https://api.github.com/users/pkafei/repos","events_url":"https://api.github.com/users/pkafei/events{/privacy}","received_events_url":"https://api.github.com/users/pkafei/received_events","type":"User","site_admin":false},"assignees":[{"login":"pkafei","id":1463964,"node_id":"MDQ6VXNlcjE0NjM5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1463964?v=4","gravatar_id":"","url":"https://api.github.com/users/pkafei","html_url":"https://github.com/pkafei","followers_url":"https://api.github.com/users/pkafei/followers","following_url":"https://api.github.com/users/pkafei/following{/other_user}","gists_url":"https://api.github.com/users/pkafei/gists{/gist_id}","starred_url":"https://api.github.com/users/pkafei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkafei/subscriptions","organizations_url":"https://api.github.com/users/pkafei/orgs","repos_url":"https://api.github.com/users/pkafei/repos","events_url":"https://api.github.com/users/pkafei/events{/privacy}","received_events_url":"https://api.github.com/users/pkafei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":259619775,"node_id":"MDU6TGFiZWwyNTk2MTk3NzU=","url":"https://api.github.com/repos/ipfs/js-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712/commits","review_comments_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712/comments","review_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/1712/comments","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/f880357e288b669ada231615b17282cdec1a0cb9","head":{"label":"ipfs:logging-bug","ref":"logging-bug","sha":"f880357e288b669ada231615b17282cdec1a0cb9","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMxMjQ5Nw==","name":"js-ipfs","full_name":"ipfs/js-ipfs","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-11-16T10:28:24Z","pushed_at":"2018-11-16T10:28:22Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"git@github.com:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":9788,"stargazers_count":3104,"watchers_count":3104,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":508,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":508,"open_issues":125,"watchers":3104,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"4bcf4a7f8588da388b2f4525deef17b9c3b829fd","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":20312497,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMxMjQ5Nw==","name":"js-ipfs","full_name":"ipfs/js-ipfs","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/js-ipfs","description":"IPFS implementation in JavaScript","fork":false,"url":"https://api.github.com/repos/ipfs/js-ipfs","forks_url":"https://api.github.com/repos/ipfs/js-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/js-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/js-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/js-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/js-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/js-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/js-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/js-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/js-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/js-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/js-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/js-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/js-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/js-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/js-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/js-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/js-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/js-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/js-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/js-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/js-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/js-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/js-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/js-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/js-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/js-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/js-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/js-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/js-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/js-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/js-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/js-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/js-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/js-ipfs/deployments","created_at":"2014-05-30T00:31:06Z","updated_at":"2018-11-16T10:28:24Z","pushed_at":"2018-11-16T10:28:22Z","git_url":"git://github.com/ipfs/js-ipfs.git","ssh_url":"git@github.com:ipfs/js-ipfs.git","clone_url":"https://github.com/ipfs/js-ipfs.git","svn_url":"https://github.com/ipfs/js-ipfs","homepage":"https://ipfs.io","size":9788,"stargazers_count":3104,"watchers_count":3104,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":508,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":508,"open_issues":125,"watchers":3104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712"},"html":{"href":"https://github.com/ipfs/js-ipfs/pull/1712"},"issue":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1712"},"comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/issues/1712/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/js-ipfs/pulls/1712/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/js-ipfs/statuses/f880357e288b669ada231615b17282cdec1a0cb9"}},"author_association":"NONE"}}
{"actor":{"display_login":"alanshaw"}}