{"push_id":2330950412,"size":31,"distinct_size":13,"ref":"refs/heads/tidy-up-include","head":"36da87a340e71ea3cde9afc43956fc7728a2c75f","before":"507e76aeee1c0cd5ac1b41615aa0b7080b6c76c3","commits":[{"sha":"c6f30a46d2166355dc0878f5a2c93a35665b6741","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Avoid knex warning when destroying a user\n\nno issue\n\n- the warning is \"Transaction was already complete\"\n- destroying a user happens in a transaction, but the event is not asynchronous\n  - so we have to ensure that we don't operate on a finished transaction","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/c6f30a46d2166355dc0878f5a2c93a35665b6741"},{"sha":"82bb3aaea1aa6c71c373c23e106d72a2f66dfdfb","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Do not import unknown author id, fallback to owner id\n\nno issue\n\n- if you import a JSON file with a post, which has an unknown author,\n  the target user was removed from the blog\n- Ghost can handle this case and still succeeds with import\n  - but we have stored an `author_id` in the database, which does not map to any user and won't map in the future\n- this can trouble if we add support for multiple authors\n  - currently, we only return the `author_id` to the client and the client can map with `author_id` with users fetched by the API\n    - if it does not find a user, it just falls back to a different user\n  - but multiple authors have to be included explicit (`include=authors`) and we will return a mapped (author_id => user) result\n  - it won't be able to find the user, because we lookup the database\n  - this would result in an error\n- there is in general no reason to import (or store) an unknown/invalid `author_id` into the database\n- on import, we show you a warning and you can choose a different author if you want\n- solution: fallback to owner user and extend warning\n  - it's not a behaviour change, you still can import unknown author id's and the import won't fail\n  - but we ensure valid author id's\n- updated test\n- further more: returning `author={}` when requesting `include=author` could trouble with ember currently\n  - it expects the author to be returned","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/82bb3aaea1aa6c71c373c23e106d72a2f66dfdfb"},{"sha":"5f9c3b92bde0b90e9fafd284195bd001680ed99d","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Improved Base importer constructor readability\n\nno issue\n\n- better differentiation between options and data\n- better readability how to access required data from file","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/5f9c3b92bde0b90e9fafd284195bd001680ed99d"},{"sha":"2a10c83d92bab710c2f651d361a9e125d855c093","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Improved memory usage in importer\n\nno issue\n\n- returning and remembering the data, which was imported, is...\n  - not required when using the API\n  - not required when importing via script\n  - required for tests\n  - added an option to have control over it\n- make more usage of local variables\n  - the GC cannot tidy up variables, which are defined outside of a loop, but used in the loop\n- try to keep less memory in process\n  - reduce the number of properties we have to remember","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/2a10c83d92bab710c2f651d361a9e125d855c093"},{"sha":"39ee95cc07ba6ba244753daa4f7cf149ae700e71","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Make use of ES6 arrow functions in our data importer\n\nno issue\n\n- reduces the usage of `self`","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/39ee95cc07ba6ba244753daa4f7cf149ae700e71"},{"sha":"ffc6088c7a07574052f7a046596f8508b3d14e90","author":{"name":"Chuck Lam","email":"283bb5a69d73baeb9abe1bd1843a7985fb78decb@stanfordalumni.org"},"message":"Fixed comment in `facebook_url` helper (#9430)\n\nno issue","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/ffc6088c7a07574052f7a046596f8508b3d14e90"},{"sha":"6f4e112c873cc5ef61b21214f927da186288d00c","author":{"name":"Kevin Ansfield","email":"4f8256ed59811c7dd7ca32acad9a4d5484fc1d6c@lookingsideways.co.uk"},"message":"Updated Ghost-Admin: fix Warning: Task \"setup\" not found.\u0007 Use --force to continue.\n\nAborted due to warnings.","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/6f4e112c873cc5ef61b21214f927da186288d00c"},{"sha":"0833b2855761f6d990de6bf0d883f78b4f25dd30","author":{"name":"Kevin Ansfield","email":"4f8256ed59811c7dd7ca32acad9a4d5484fc1d6c@lookingsideways.co.uk"},"message":"Koenig - Rename server-side cards\n\nrefs https://github.com/TryGhost/Ghost/issues/9311\n- match card names to the new generic Koenig card names introduced in https://github.com/TryGhost/Ghost-Admin/commit/95a068615db20664dab578da2e71499ce8b9c50d","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/0833b2855761f6d990de6bf0d883f78b4f25dd30"},{"sha":"05bcf7ee6a6a5c86760aa643b0824088fb75eb7b","author":{"name":"Kevin Ansfield","email":"4f8256ed59811c7dd7ca32acad9a4d5484fc1d6c@lookingsideways.co.uk"},"message":"Fixed missing export of `card-markdown` card\n\nno issue\n- fixes the bug introduced in https://github.com/TryGhost/Ghost/commit/0833b2855761f6d990de6bf0d883f78b4f25dd30","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/05bcf7ee6a6a5c86760aa643b0824088fb75eb7b"},{"sha":"fb973dbbf212558798f50d1e4ed0286f99c8b27d","author":{"name":"Kevin Ansfield","email":"4f8256ed59811c7dd7ca32acad9a4d5484fc1d6c@lookingsideways.co.uk"},"message":"Fixed missing export of `card-markdown` card and broken tests\n\nno issue\n- fixes rendering bug introduced in https://github.com/TryGhost/Ghost/commit/0833b2855761f6d990de6bf0d883f78b4f25dd30\n- updates test generators/fixtures to use new card names","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/fb973dbbf212558798f50d1e4ed0286f99c8b27d"},{"sha":"f9d4d01088b00973f80fc997110bde3dedd69b74","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Reordered error logging on ghost start (#9440)\n\nno issue\r\n\r\n- if we trigger the IPC message to the CLI and the process manager is systemd, systemd will restart Ghost too early (same for local process manager) - this is a timing issue\r\n- the consequence is that the error log won't happen in Ghost (`content/logs/[domain].error.log`  won't contain that error)\r\n- let's reorder both executions\r\n\r\n[See](https://github.com/TryGhost/Ghost-CLI/pull/612/files#r165817172) this comment on the CLI PR.","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/f9d4d01088b00973f80fc997110bde3dedd69b74"},{"sha":"a274d61a8c76dbe51b67aeebd538e26bbc5a05d6","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Removed html usage in error messages (#9444)\n\nno issue\r\n\r\n- all of the error message keys were unused\r\n- the only html anchor i found was for mail, but this doesn't change anything, because the admin does only show the message and not the context at the moment","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/a274d61a8c76dbe51b67aeebd538e26bbc5a05d6"},{"sha":"777247cbc7e691bbe619de95a153f96c96e6e56f","author":{"name":"Austin Burdine","email":"fa3f8c02c0707e6ab86580a94970f9bb7ba6afb5@gmail.com"},"message":"Contributor Role (#9315)\n\ncloses #9314 \r\n\r\n* added fixtures for contributor role\r\n* update post api tests to prevent contributor publishing post\r\n* update permissible function in role/user model\r\n* fix additional author code in invites\r\n* update contributor role migration for knex-migrator v3\r\n* fix paths in contrib migration\r\n* ensure contributors can't edit or delete published posts, fix routing tests [ci skip]\r\n* update db fixtures hash\r\n* strip tags from post if contributor\r\n* cleanup post permissible function\r\n* excludedAttrs to ignore tag updates for now (might be removed later)\r\n* ensure contributors can't edit another's post\r\n* migration script for 1.21","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/777247cbc7e691bbe619de95a153f96c96e6e56f"},{"sha":"c6ec2777edfbb35fce2e0ca3ff50000088f5eff2","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Updated Ghost-Admin to 1.21.0","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/c6ec2777edfbb35fce2e0ca3ff50000088f5eff2"},{"sha":"a8ac58be710f7a2e8b290dc2bf2cd27ed32979dc","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Version bump to 1.21.0","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/a8ac58be710f7a2e8b290dc2bf2cd27ed32979dc"},{"sha":"ed4fde4f006281c48880ff24ba997dc83b097bdd","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"🐛  Fixed migrating from < 1.13 to 1.21\n\nno issue\n\n- discovered while testing\n- the fixture utility needed a protection against non existent roles in the database\n  - it tries to fetch the contributor role from the database, which does not exist yet","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/ed4fde4f006281c48880ff24ba997dc83b097bdd"},{"sha":"2822d725d8b4730e467dfbb603a61cf2e76f803d","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Updated Ghost-Admin to 1.21.1","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/2822d725d8b4730e467dfbb603a61cf2e76f803d"},{"sha":"bfd3286b61fe724206b94d441036019c03122a64","author":{"name":"kirrg001","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Version bump to 1.21.1","distinct":false,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/bfd3286b61fe724206b94d441036019c03122a64"},{"sha":"58157b14118d6148af4282278bc9ea890f3929ea","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"🐛Fixed asset redirects (#9455)\n\ncloses #9445\r\n\r\n- redirects all asset requests if https is configured (theme, core, images)\r\n- re-use and extend our url-redirect middleware\r\n- add proper integration tests for our express site app (no db interaction, component testing required for such important use cases)\r\n- i added some more general tests\r\n- should avoid mixed content warnings in the browser","distinct":true,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/58157b14118d6148af4282278bc9ea890f3929ea"},{"sha":"9ede5905f6cae7b827ad10c84b982d6d18a10003","author":{"name":"Katharina Irrgang","email":"12b0b00dd3ffbbbc5cbc62daa47f60debaf19ead@googlemail.com"},"message":"Reduce toJSON implementation: use the power of bookshelf (#9423)\n\nrefs #6103\r\n\r\n- simplify `toJSON`\r\n- `baseKey` was not used - have not find a single use case\r\n- all the functionality of our `toJSON` is offered in bookshelf\r\n- `omitPivot` does remove pivot elements from the JSON obj (bookshelf feature)\r\n- `shallow` allows you to not return relations\r\n- make use of `serialize`, see http://bookshelfjs.org/docs/src_base_model.js.html#line260\r\n- fetching nested relations e.g. `users.roles` still works (unrelated to this refactoring)\r\n\r\n> pick('shallow', 'baseKey', 'include', 'context')\r\n\r\nWe will re-add options validation in https://github.com/TryGhost/Ghost/pull/9427, but then with the official way: use `filterOptions`.\r\n\r\n---\r\n\r\nWe return all fetched relations (pre-defined with `withRelated`) by default.\r\nYou can disable it with `shallow:true`.","distinct":true,"url":"https://api.github.com/repos/kirrg001/Ghost/commits/9ede5905f6cae7b827ad10c84b982d6d18a10003"}]}
{"actor":{"display_login":"kirrg001"}}