{"action":"created","comment":{"url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/comments/230501715","pull_request_review_id":171263073,"id":230501715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUwMTcxNQ==","diff_hunk":"@@ -69308,8 +69308,7 @@ function rasterLayerLineMixin(_layer) {\n         },\n         strokeColor: getColor(state.encoding.color, layerName),\n         strokeWidth: size,\n-        lineJoin: _typeof(state.mark) === \"object\" ? state.mark.lineJoin : \"miter\",\n-        miterLimit: _typeof(state.mark) === \"object\" ? state.mark.miterLimit : 10\n+        lineJoin: _typeof(state.mark) === \"object\" ? state.mark.lineJoin : \"bevel\"","path":"dist/mapdc.js","position":6,"original_position":6,"commit_id":"e6ed8850edf7bc7ca0b616935048e71b948778d4","original_commit_id":"e6ed8850edf7bc7ca0b616935048e71b948778d4","user":{"login":"jmenestr","id":9904977,"node_id":"MDQ6VXNlcjk5MDQ5Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/9904977?v=4","gravatar_id":"","url":"https://api.github.com/users/jmenestr","html_url":"https://github.com/jmenestr","followers_url":"https://api.github.com/users/jmenestr/followers","following_url":"https://api.github.com/users/jmenestr/following{/other_user}","gists_url":"https://api.github.com/users/jmenestr/gists{/gist_id}","starred_url":"https://api.github.com/users/jmenestr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmenestr/subscriptions","organizations_url":"https://api.github.com/users/jmenestr/orgs","repos_url":"https://api.github.com/users/jmenestr/repos","events_url":"https://api.github.com/users/jmenestr/events{/privacy}","received_events_url":"https://api.github.com/users/jmenestr/received_events","type":"User","site_admin":false},"body":"Why is the file in `dist` changed as well as source?","created_at":"2018-11-02T20:39:22Z","updated_at":"2018-11-02T20:39:22Z","html_url":"https://github.com/omnisci/mapd-charting/pull/263#discussion_r230501715","pull_request_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/comments/230501715"},"html":{"href":"https://github.com/omnisci/mapd-charting/pull/263#discussion_r230501715"},"pull_request":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263","id":228049422,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQ5NDIy","html_url":"https://github.com/omnisci/mapd-charting/pull/263","diff_url":"https://github.com/omnisci/mapd-charting/pull/263.diff","patch_url":"https://github.com/omnisci/mapd-charting/pull/263.patch","issue_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/263","number":263,"state":"open","locked":false,"title":"[FE-5458] changed linejoin option to bevel","user":{"login":"uyanga-gb","id":11098472,"node_id":"MDQ6VXNlcjExMDk4NDcy","avatar_url":"https://avatars2.githubusercontent.com/u/11098472?v=4","gravatar_id":"","url":"https://api.github.com/users/uyanga-gb","html_url":"https://github.com/uyanga-gb","followers_url":"https://api.github.com/users/uyanga-gb/followers","following_url":"https://api.github.com/users/uyanga-gb/following{/other_user}","gists_url":"https://api.github.com/users/uyanga-gb/gists{/gist_id}","starred_url":"https://api.github.com/users/uyanga-gb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyanga-gb/subscriptions","organizations_url":"https://api.github.com/users/uyanga-gb/orgs","repos_url":"https://api.github.com/users/uyanga-gb/repos","events_url":"https://api.github.com/users/uyanga-gb/events{/privacy}","received_events_url":"https://api.github.com/users/uyanga-gb/received_events","type":"User","site_admin":false},"body":"# Merge Checklist\r\n## :wrench: Issue(s) fixed:\r\n- [ ] Author referenced issue(s) fixed by this PR:\r\n- [ ] Fixes https://jira.omnisci.com/browse/FE-5458\r\n\r\n## :smoking: Smoke Test\r\n- [ ] Works in chrome\r\n- [ ] Works in firefox\r\n- [ ] Works in safari\r\n- [ ] Works in ie edge\r\n- [ ] Works in ie 11\r\n\r\n## :ship: Merge\r\n- [ ] author crafted PR's title into release-worthy commit message.\r\n","created_at":"2018-11-02T20:22:24Z","updated_at":"2018-11-02T20:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb2c38e06d6417a8ecb932e8a8a8df057aea2118","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vastcharade","id":5768541,"node_id":"MDQ6VXNlcjU3Njg1NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5768541?v=4","gravatar_id":"","url":"https://api.github.com/users/vastcharade","html_url":"https://github.com/vastcharade","followers_url":"https://api.github.com/users/vastcharade/followers","following_url":"https://api.github.com/users/vastcharade/following{/other_user}","gists_url":"https://api.github.com/users/vastcharade/gists{/gist_id}","starred_url":"https://api.github.com/users/vastcharade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vastcharade/subscriptions","organizations_url":"https://api.github.com/users/vastcharade/orgs","repos_url":"https://api.github.com/users/vastcharade/repos","events_url":"https://api.github.com/users/vastcharade/events{/privacy}","received_events_url":"https://api.github.com/users/vastcharade/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263/commits","review_comments_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263/comments","review_comment_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/263/comments","statuses_url":"https://api.github.com/repos/omnisci/mapd-charting/statuses/e6ed8850edf7bc7ca0b616935048e71b948778d4","head":{"label":"omnisci:uyanga/FE-5458_change_linejoin","ref":"uyanga/FE-5458_change_linejoin","sha":"e6ed8850edf7bc7ca0b616935048e71b948778d4","user":{"login":"omnisci","id":7553829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTM4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7553829?v=4","gravatar_id":"","url":"https://api.github.com/users/omnisci","html_url":"https://github.com/omnisci","followers_url":"https://api.github.com/users/omnisci/followers","following_url":"https://api.github.com/users/omnisci/following{/other_user}","gists_url":"https://api.github.com/users/omnisci/gists{/gist_id}","starred_url":"https://api.github.com/users/omnisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnisci/subscriptions","organizations_url":"https://api.github.com/users/omnisci/orgs","repos_url":"https://api.github.com/users/omnisci/repos","events_url":"https://api.github.com/users/omnisci/events{/privacy}","received_events_url":"https://api.github.com/users/omnisci/received_events","type":"Organization","site_admin":false},"repo":{"id":89939739,"node_id":"MDEwOlJlcG9zaXRvcnk4OTkzOTczOQ==","name":"mapd-charting","full_name":"omnisci/mapd-charting","private":false,"owner":{"login":"omnisci","id":7553829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTM4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7553829?v=4","gravatar_id":"","url":"https://api.github.com/users/omnisci","html_url":"https://github.com/omnisci","followers_url":"https://api.github.com/users/omnisci/followers","following_url":"https://api.github.com/users/omnisci/following{/other_user}","gists_url":"https://api.github.com/users/omnisci/gists{/gist_id}","starred_url":"https://api.github.com/users/omnisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnisci/subscriptions","organizations_url":"https://api.github.com/users/omnisci/orgs","repos_url":"https://api.github.com/users/omnisci/repos","events_url":"https://api.github.com/users/omnisci/events{/privacy}","received_events_url":"https://api.github.com/users/omnisci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omnisci/mapd-charting","description":"Dimensional charting built to work natively with crossfilter rendered using d3.js","fork":false,"url":"https://api.github.com/repos/omnisci/mapd-charting","forks_url":"https://api.github.com/repos/omnisci/mapd-charting/forks","keys_url":"https://api.github.com/repos/omnisci/mapd-charting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omnisci/mapd-charting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omnisci/mapd-charting/teams","hooks_url":"https://api.github.com/repos/omnisci/mapd-charting/hooks","issue_events_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/events{/number}","events_url":"https://api.github.com/repos/omnisci/mapd-charting/events","assignees_url":"https://api.github.com/repos/omnisci/mapd-charting/assignees{/user}","branches_url":"https://api.github.com/repos/omnisci/mapd-charting/branches{/branch}","tags_url":"https://api.github.com/repos/omnisci/mapd-charting/tags","blobs_url":"https://api.github.com/repos/omnisci/mapd-charting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omnisci/mapd-charting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omnisci/mapd-charting/git/refs{/sha}","trees_url":"https://api.github.com/repos/omnisci/mapd-charting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omnisci/mapd-charting/statuses/{sha}","languages_url":"https://api.github.com/repos/omnisci/mapd-charting/languages","stargazers_url":"https://api.github.com/repos/omnisci/mapd-charting/stargazers","contributors_url":"https://api.github.com/repos/omnisci/mapd-charting/contributors","subscribers_url":"https://api.github.com/repos/omnisci/mapd-charting/subscribers","subscription_url":"https://api.github.com/repos/omnisci/mapd-charting/subscription","commits_url":"https://api.github.com/repos/omnisci/mapd-charting/commits{/sha}","git_commits_url":"https://api.github.com/repos/omnisci/mapd-charting/git/commits{/sha}","comments_url":"https://api.github.com/repos/omnisci/mapd-charting/comments{/number}","issue_comment_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/comments{/number}","contents_url":"https://api.github.com/repos/omnisci/mapd-charting/contents/{+path}","compare_url":"https://api.github.com/repos/omnisci/mapd-charting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omnisci/mapd-charting/merges","archive_url":"https://api.github.com/repos/omnisci/mapd-charting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omnisci/mapd-charting/downloads","issues_url":"https://api.github.com/repos/omnisci/mapd-charting/issues{/number}","pulls_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls{/number}","milestones_url":"https://api.github.com/repos/omnisci/mapd-charting/milestones{/number}","notifications_url":"https://api.github.com/repos/omnisci/mapd-charting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omnisci/mapd-charting/labels{/name}","releases_url":"https://api.github.com/repos/omnisci/mapd-charting/releases{/id}","deployments_url":"https://api.github.com/repos/omnisci/mapd-charting/deployments","created_at":"2017-05-01T16:12:49Z","updated_at":"2018-10-29T20:31:23Z","pushed_at":"2018-11-02T20:22:25Z","git_url":"git://github.com/omnisci/mapd-charting.git","ssh_url":"git@github.com:omnisci/mapd-charting.git","clone_url":"https://github.com/omnisci/mapd-charting.git","svn_url":"https://github.com/omnisci/mapd-charting","homepage":"https://www.omnisci.com","size":38647,"stargazers_count":272,"watchers_count":272,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":46,"watchers":272,"default_branch":"master"}},"base":{"label":"omnisci:master","ref":"master","sha":"58d14bd75f5ba0e87e8cbaca350addfd424c7cd7","user":{"login":"omnisci","id":7553829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTM4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7553829?v=4","gravatar_id":"","url":"https://api.github.com/users/omnisci","html_url":"https://github.com/omnisci","followers_url":"https://api.github.com/users/omnisci/followers","following_url":"https://api.github.com/users/omnisci/following{/other_user}","gists_url":"https://api.github.com/users/omnisci/gists{/gist_id}","starred_url":"https://api.github.com/users/omnisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnisci/subscriptions","organizations_url":"https://api.github.com/users/omnisci/orgs","repos_url":"https://api.github.com/users/omnisci/repos","events_url":"https://api.github.com/users/omnisci/events{/privacy}","received_events_url":"https://api.github.com/users/omnisci/received_events","type":"Organization","site_admin":false},"repo":{"id":89939739,"node_id":"MDEwOlJlcG9zaXRvcnk4OTkzOTczOQ==","name":"mapd-charting","full_name":"omnisci/mapd-charting","private":false,"owner":{"login":"omnisci","id":7553829,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTM4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7553829?v=4","gravatar_id":"","url":"https://api.github.com/users/omnisci","html_url":"https://github.com/omnisci","followers_url":"https://api.github.com/users/omnisci/followers","following_url":"https://api.github.com/users/omnisci/following{/other_user}","gists_url":"https://api.github.com/users/omnisci/gists{/gist_id}","starred_url":"https://api.github.com/users/omnisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnisci/subscriptions","organizations_url":"https://api.github.com/users/omnisci/orgs","repos_url":"https://api.github.com/users/omnisci/repos","events_url":"https://api.github.com/users/omnisci/events{/privacy}","received_events_url":"https://api.github.com/users/omnisci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omnisci/mapd-charting","description":"Dimensional charting built to work natively with crossfilter rendered using d3.js","fork":false,"url":"https://api.github.com/repos/omnisci/mapd-charting","forks_url":"https://api.github.com/repos/omnisci/mapd-charting/forks","keys_url":"https://api.github.com/repos/omnisci/mapd-charting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omnisci/mapd-charting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omnisci/mapd-charting/teams","hooks_url":"https://api.github.com/repos/omnisci/mapd-charting/hooks","issue_events_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/events{/number}","events_url":"https://api.github.com/repos/omnisci/mapd-charting/events","assignees_url":"https://api.github.com/repos/omnisci/mapd-charting/assignees{/user}","branches_url":"https://api.github.com/repos/omnisci/mapd-charting/branches{/branch}","tags_url":"https://api.github.com/repos/omnisci/mapd-charting/tags","blobs_url":"https://api.github.com/repos/omnisci/mapd-charting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omnisci/mapd-charting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omnisci/mapd-charting/git/refs{/sha}","trees_url":"https://api.github.com/repos/omnisci/mapd-charting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omnisci/mapd-charting/statuses/{sha}","languages_url":"https://api.github.com/repos/omnisci/mapd-charting/languages","stargazers_url":"https://api.github.com/repos/omnisci/mapd-charting/stargazers","contributors_url":"https://api.github.com/repos/omnisci/mapd-charting/contributors","subscribers_url":"https://api.github.com/repos/omnisci/mapd-charting/subscribers","subscription_url":"https://api.github.com/repos/omnisci/mapd-charting/subscription","commits_url":"https://api.github.com/repos/omnisci/mapd-charting/commits{/sha}","git_commits_url":"https://api.github.com/repos/omnisci/mapd-charting/git/commits{/sha}","comments_url":"https://api.github.com/repos/omnisci/mapd-charting/comments{/number}","issue_comment_url":"https://api.github.com/repos/omnisci/mapd-charting/issues/comments{/number}","contents_url":"https://api.github.com/repos/omnisci/mapd-charting/contents/{+path}","compare_url":"https://api.github.com/repos/omnisci/mapd-charting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omnisci/mapd-charting/merges","archive_url":"https://api.github.com/repos/omnisci/mapd-charting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omnisci/mapd-charting/downloads","issues_url":"https://api.github.com/repos/omnisci/mapd-charting/issues{/number}","pulls_url":"https://api.github.com/repos/omnisci/mapd-charting/pulls{/number}","milestones_url":"https://api.github.com/repos/omnisci/mapd-charting/milestones{/number}","notifications_url":"https://api.github.com/repos/omnisci/mapd-charting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omnisci/mapd-charting/labels{/name}","releases_url":"https://api.github.com/repos/omnisci/mapd-charting/releases{/id}","deployments_url":"https://api.github.com/repos/omnisci/mapd-charting/deployments","created_at":"2017-05-01T16:12:49Z","updated_at":"2018-10-29T20:31:23Z","pushed_at":"2018-11-02T20:22:25Z","git_url":"git://github.com/omnisci/mapd-charting.git","ssh_url":"git@github.com:omnisci/mapd-charting.git","clone_url":"https://github.com/omnisci/mapd-charting.git","svn_url":"https://github.com/omnisci/mapd-charting","homepage":"https://www.omnisci.com","size":38647,"stargazers_count":272,"watchers_count":272,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":46,"watchers":272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263"},"html":{"href":"https://github.com/omnisci/mapd-charting/pull/263"},"issue":{"href":"https://api.github.com/repos/omnisci/mapd-charting/issues/263"},"comments":{"href":"https://api.github.com/repos/omnisci/mapd-charting/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omnisci/mapd-charting/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/omnisci/mapd-charting/statuses/e6ed8850edf7bc7ca0b616935048e71b948778d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmenestr"}}