{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/165362950","pull_request_review_id":93288978,"id":165362950,"diff_hunk":"@@ -407,9 +407,35 @@ public final class Project { // swiftlint:disable:this type_body_length\n \t/// This will fetch dependency repositories as necessary, but will not check\n \t/// them out into the project's working directory.\n \tprivate func latestDependencies(resolver: ResolverProtocol) -> SignalProducer<[Dependency: PinnedVersion], CarthageError> {\n-\t\treturn loadResolvedCartfile()\n-\t\t\t.map { $0.dependencies.mapValues { _ in VersionSpecifier.any } }\n-\t\t\t.flatMap(.merge) { resolver.resolve(dependencies: $0, lastResolved: nil, dependenciesToUpdate: nil) }\n+\t\tfunc resolve(prefersGitReference: Bool) -> SignalProducer<[Dependency: PinnedVersion], CarthageError> {\n+\t\t\treturn SignalProducer\n+\t\t\t\t.combineLatest(loadCombinedCartfile(), loadResolvedCartfile())\n+\t\t\t\t.map { cartfile, resolvedCartfile in\n+\t\t\t\t\tresolvedCartfile\n+\t\t\t\t\t\t.dependencies\n+\t\t\t\t\t\t.reduce(into: [Dependency: VersionSpecifier]()) { result, group in\n+\t\t\t\t\t\t\tlet dependency = group.key\n+\t\t\t\t\t\t\tswitch (prefersGitReference, cartfile.dependencies[dependency]) {","path":"Source/CarthageKit/Project.swift","position":15,"original_position":15,"commit_id":"02b1487015143772ebe396c85265e3ad974f2b94","original_commit_id":"02b1487015143772ebe396c85265e3ad974f2b94","user":{"login":"mdiep","id":1302,"avatar_url":"https://avatars2.githubusercontent.com/u/1302?v=4","gravatar_id":"","url":"https://api.github.com/users/mdiep","html_url":"https://github.com/mdiep","followers_url":"https://api.github.com/users/mdiep/followers","following_url":"https://api.github.com/users/mdiep/following{/other_user}","gists_url":"https://api.github.com/users/mdiep/gists{/gist_id}","starred_url":"https://api.github.com/users/mdiep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdiep/subscriptions","organizations_url":"https://api.github.com/users/mdiep/orgs","repos_url":"https://api.github.com/users/mdiep/repos","events_url":"https://api.github.com/users/mdiep/events{/privacy}","received_events_url":"https://api.github.com/users/mdiep/received_events","type":"User","site_admin":false},"body":"I think this would be clearer as an `if` instead of a `switch`.","created_at":"2018-02-01T14:01:22Z","updated_at":"2018-02-01T14:06:01Z","html_url":"https://github.com/Carthage/Carthage/pull/2328#discussion_r165362950","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2328","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/165362950"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2328#discussion_r165362950"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2328"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2328","id":163945692,"html_url":"https://github.com/Carthage/Carthage/pull/2328","diff_url":"https://github.com/Carthage/Carthage/pull/2328.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2328.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2328","number":2328,"state":"open","locked":false,"title":"[Bug] Fix a bug that carthage outdated fails","user":{"login":"chuganzy","id":2619092,"avatar_url":"https://avatars1.githubusercontent.com/u/2619092?v=4","gravatar_id":"","url":"https://api.github.com/users/chuganzy","html_url":"https://github.com/chuganzy","followers_url":"https://api.github.com/users/chuganzy/followers","following_url":"https://api.github.com/users/chuganzy/following{/other_user}","gists_url":"https://api.github.com/users/chuganzy/gists{/gist_id}","starred_url":"https://api.github.com/users/chuganzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuganzy/subscriptions","organizations_url":"https://api.github.com/users/chuganzy/orgs","repos_url":"https://api.github.com/users/chuganzy/repos","events_url":"https://api.github.com/users/chuganzy/events{/privacy}","received_events_url":"https://api.github.com/users/chuganzy/received_events","type":"User","site_admin":false},"body":"This PR resolves an issue on master branch that `carthage outdated` fails when git ref is used in Cartfile and no release exists for dependency.\r\n","created_at":"2018-01-19T11:23:12Z","updated_at":"2018-02-01T14:06:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90734d3b52b3e98295317d0f381e066f1f587d25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2328/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2328/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2328/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/02b1487015143772ebe396c85265e3ad974f2b94","head":{"label":"chuganzy:fix_outdated_bug","ref":"fix_outdated_bug","sha":"02b1487015143772ebe396c85265e3ad974f2b94","user":{"login":"chuganzy","id":2619092,"avatar_url":"https://avatars1.githubusercontent.com/u/2619092?v=4","gravatar_id":"","url":"https://api.github.com/users/chuganzy","html_url":"https://github.com/chuganzy","followers_url":"https://api.github.com/users/chuganzy/followers","following_url":"https://api.github.com/users/chuganzy/following{/other_user}","gists_url":"https://api.github.com/users/chuganzy/gists{/gist_id}","starred_url":"https://api.github.com/users/chuganzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuganzy/subscriptions","organizations_url":"https://api.github.com/users/chuganzy/orgs","repos_url":"https://api.github.com/users/chuganzy/repos","events_url":"https://api.github.com/users/chuganzy/events{/privacy}","received_events_url":"https://api.github.com/users/chuganzy/received_events","type":"User","site_admin":false},"repo":{"id":109668958,"name":"Carthage","full_name":"chuganzy/Carthage","owner":{"login":"chuganzy","id":2619092,"avatar_url":"https://avatars1.githubusercontent.com/u/2619092?v=4","gravatar_id":"","url":"https://api.github.com/users/chuganzy","html_url":"https://github.com/chuganzy","followers_url":"https://api.github.com/users/chuganzy/followers","following_url":"https://api.github.com/users/chuganzy/following{/other_user}","gists_url":"https://api.github.com/users/chuganzy/gists{/gist_id}","starred_url":"https://api.github.com/users/chuganzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuganzy/subscriptions","organizations_url":"https://api.github.com/users/chuganzy/orgs","repos_url":"https://api.github.com/users/chuganzy/repos","events_url":"https://api.github.com/users/chuganzy/events{/privacy}","received_events_url":"https://api.github.com/users/chuganzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuganzy/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/chuganzy/Carthage","forks_url":"https://api.github.com/repos/chuganzy/Carthage/forks","keys_url":"https://api.github.com/repos/chuganzy/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuganzy/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuganzy/Carthage/teams","hooks_url":"https://api.github.com/repos/chuganzy/Carthage/hooks","issue_events_url":"https://api.github.com/repos/chuganzy/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/chuganzy/Carthage/events","assignees_url":"https://api.github.com/repos/chuganzy/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/chuganzy/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/chuganzy/Carthage/tags","blobs_url":"https://api.github.com/repos/chuganzy/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuganzy/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuganzy/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuganzy/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuganzy/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/chuganzy/Carthage/languages","stargazers_url":"https://api.github.com/repos/chuganzy/Carthage/stargazers","contributors_url":"https://api.github.com/repos/chuganzy/Carthage/contributors","subscribers_url":"https://api.github.com/repos/chuganzy/Carthage/subscribers","subscription_url":"https://api.github.com/repos/chuganzy/Carthage/subscription","commits_url":"https://api.github.com/repos/chuganzy/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuganzy/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuganzy/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuganzy/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuganzy/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/chuganzy/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuganzy/Carthage/merges","archive_url":"https://api.github.com/repos/chuganzy/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuganzy/Carthage/downloads","issues_url":"https://api.github.com/repos/chuganzy/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/chuganzy/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/chuganzy/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/chuganzy/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuganzy/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/chuganzy/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/chuganzy/Carthage/deployments","created_at":"2017-11-06T08:41:47Z","updated_at":"2017-11-06T08:41:50Z","pushed_at":"2018-01-31T09:36:04Z","git_url":"git://github.com/chuganzy/Carthage.git","ssh_url":"git@github.com:chuganzy/Carthage.git","clone_url":"https://github.com/chuganzy/Carthage.git","svn_url":"https://github.com/chuganzy/Carthage","homepage":"","size":17971,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"19e584623e548de68f424ea5c5dc4c081d750112","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2018-02-01T10:52:52Z","pushed_at":"2018-01-31T14:03:28Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":17960,"stargazers_count":11033,"watchers_count":11033,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1027,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1027,"open_issues":182,"watchers":11033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2328"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2328"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2328"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2328/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2328/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2328/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/02b1487015143772ebe396c85265e3ad974f2b94"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mdiep"}}