{"action":"created","issue":{"url":"https://api.github.com/repos/bryphe/esy-bash/issues/19","repository_url":"https://api.github.com/repos/bryphe/esy-bash","labels_url":"https://api.github.com/repos/bryphe/esy-bash/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/bryphe/esy-bash/issues/19/comments","events_url":"https://api.github.com/repos/bryphe/esy-bash/issues/19/events","html_url":"https://github.com/bryphe/esy-bash/pull/19","id":365111272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTM0NjQ3","number":19,"title":"Native esy bash","user":{"login":"prometheansacrifice","id":3097018,"node_id":"MDQ6VXNlcjMwOTcwMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3097018?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheansacrifice","html_url":"https://github.com/prometheansacrifice","followers_url":"https://api.github.com/users/prometheansacrifice/followers","following_url":"https://api.github.com/users/prometheansacrifice/following{/other_user}","gists_url":"https://api.github.com/users/prometheansacrifice/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheansacrifice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheansacrifice/subscriptions","organizations_url":"https://api.github.com/users/prometheansacrifice/orgs","repos_url":"https://api.github.com/users/prometheansacrifice/repos","events_url":"https://api.github.com/users/prometheansacrifice/events{/privacy}","received_events_url":"https://api.github.com/users/prometheansacrifice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-09-29T08:29:57Z","updated_at":"2018-10-13T16:02:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bryphe/esy-bash/pulls/19","html_url":"https://github.com/bryphe/esy-bash/pull/19","diff_url":"https://github.com/bryphe/esy-bash/pull/19.diff","patch_url":"https://github.com/bryphe/esy-bash/pull/19.patch"},"body":"Addresses #16 "},"comment":{"url":"https://api.github.com/repos/bryphe/esy-bash/issues/comments/429553213","html_url":"https://github.com/bryphe/esy-bash/pull/19#issuecomment-429553213","issue_url":"https://api.github.com/repos/bryphe/esy-bash/issues/19","id":429553213,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTU1MzIxMw==","user":{"login":"bryphe","id":13532591,"node_id":"MDQ6VXNlcjEzNTMyNTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13532591?v=4","gravatar_id":"","url":"https://api.github.com/users/bryphe","html_url":"https://github.com/bryphe","followers_url":"https://api.github.com/users/bryphe/followers","following_url":"https://api.github.com/users/bryphe/following{/other_user}","gists_url":"https://api.github.com/users/bryphe/gists{/gist_id}","starred_url":"https://api.github.com/users/bryphe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryphe/subscriptions","organizations_url":"https://api.github.com/users/bryphe/orgs","repos_url":"https://api.github.com/users/bryphe/repos","events_url":"https://api.github.com/users/bryphe/events{/privacy}","received_events_url":"https://api.github.com/users/bryphe/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T16:02:05Z","updated_at":"2018-10-13T16:02:05Z","author_association":"OWNER","body":"> How about taking CYGWIN_PATH from the env?\r\n\r\nThis seems awkward to me, as this package is also responsible for installing the Cygwin pieces. It seems strange that we control where we are putting Cygwin, but we would _still_ need an environment variable to specify where it is at. It doesn't seem necessary to me, given the strategies we have above - we control where we install it, so we should be able to locate it at runtime - we shouldn't need to burden a consumer with that. \r\n\r\nIn other words, I consider where we install Cygwin an implementation detail that shouldn't need to be known or relied on by a consumer of `esy-bash`. \r\n\r\nI'd be OK with it as a debug option but it shouldn't be necessary to run the executable.\r\n\r\n> This frees up where we install cygwin, possibly helping us with Windows: Upgrading / downgrading 'esy' always reinstalls cygwin layer #443\r\n\r\nHmm, it's not clear to me how having a `CYGWIN_PATH` would help here? The root cause is that `esy` is _always_ running `npm install -g esy-bash@x.x.x` at postinstall - my understanding is that the fix has to be  `esy` to see if we already have an `esy-bash` at the appropriate version or not."}}
{"actor":{"display_login":"bryphe"}}