{"action":"created","comment":{"url":"https://api.github.com/repos/mapseed/api/pulls/comments/183137570","pull_request_review_id":114085264,"id":183137570,"diff_hunk":"@@ -211,7 +211,7 @@ class PlaceEmailTemplate (TimeStampedModel):\n     event = models.CharField(max_length=128, choices=EVENT_CHOICES, default='add')\n     recipient_email_field = models.CharField(max_length=128)\n     from_email = models.EmailField()\n-    bcc_email = models.EmailField(blank=True, default=None)\n+    bcc_email = models.CharField(max_length=512, blank=True, default=None)","path":"src/sa_api_v2/models/core.py","position":5,"original_position":5,"commit_id":"44e53d57c5901a1f93a9bd8f5b5c8ab0ee10c299","original_commit_id":"44e53d57c5901a1f93a9bd8f5b5c8ab0ee10c299","user":{"login":"modulitos","id":4207017,"avatar_url":"https://avatars0.githubusercontent.com/u/4207017?v=4","gravatar_id":"","url":"https://api.github.com/users/modulitos","html_url":"https://github.com/modulitos","followers_url":"https://api.github.com/users/modulitos/followers","following_url":"https://api.github.com/users/modulitos/following{/other_user}","gists_url":"https://api.github.com/users/modulitos/gists{/gist_id}","starred_url":"https://api.github.com/users/modulitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modulitos/subscriptions","organizations_url":"https://api.github.com/users/modulitos/orgs","repos_url":"https://api.github.com/users/modulitos/repos","events_url":"https://api.github.com/users/modulitos/events{/privacy}","received_events_url":"https://api.github.com/users/modulitos/received_events","type":"User","site_admin":false},"body":">Maybe a simpler approach for the time being would be to just hard-code a fixed number of BCC EmailFields, like 5 or so, and we'd just be limited to having 5 BCC emails on our templates.\r\n\r\nI think that's a reasonable idea :-)\r\n","created_at":"2018-04-20T18:40:36Z","updated_at":"2018-04-20T18:40:36Z","html_url":"https://github.com/mapseed/api/pull/120#discussion_r183137570","pull_request_url":"https://api.github.com/repos/mapseed/api/pulls/120","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mapseed/api/pulls/comments/183137570"},"html":{"href":"https://github.com/mapseed/api/pull/120#discussion_r183137570"},"pull_request":{"href":"https://api.github.com/repos/mapseed/api/pulls/120"}},"in_reply_to_id":182964166},"pull_request":{"url":"https://api.github.com/repos/mapseed/api/pulls/120","id":182600588,"html_url":"https://github.com/mapseed/api/pull/120","diff_url":"https://github.com/mapseed/api/pull/120.diff","patch_url":"https://github.com/mapseed/api/pull/120.patch","issue_url":"https://api.github.com/repos/mapseed/api/issues/120","number":120,"state":"open","locked":false,"title":"Place email template improvements","user":{"login":"goldpbear","id":9222338,"avatar_url":"https://avatars2.githubusercontent.com/u/9222338?v=4","gravatar_id":"","url":"https://api.github.com/users/goldpbear","html_url":"https://github.com/goldpbear","followers_url":"https://api.github.com/users/goldpbear/followers","following_url":"https://api.github.com/users/goldpbear/following{/other_user}","gists_url":"https://api.github.com/users/goldpbear/gists{/gist_id}","starred_url":"https://api.github.com/users/goldpbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldpbear/subscriptions","organizations_url":"https://api.github.com/users/goldpbear/orgs","repos_url":"https://api.github.com/users/goldpbear/repos","events_url":"https://api.github.com/users/goldpbear/events{/privacy}","received_events_url":"https://api.github.com/users/goldpbear/received_events","type":"User","site_admin":false},"body":"Addresses #117.\r\nFixes #121, #122.\r\n\r\n**Needs to be tested on the staging server before merging**\r\nUPDATE: seems to be working on the staging server as expected\r\n\r\nTwo tweaks to our place email template feature:\r\n* Support multiple emails in the BCC field\r\n* Send emails to the BCC recipients even when no main recipient email is provided\r\n\r\nNote that the multi-email BCC list is just a `CharField` (so we lose email validation checks). There might be a better pattern for entering a list of emails, but I didn't turn up anything after a quick search. We may want to research more carefully but since this isn't user-facing it's not a huge deal I think.\r\n\r\nTODO:\r\n-  [ ] Run migrations","created_at":"2018-04-18T20:56:18Z","updated_at":"2018-04-20T18:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ae18924bc4ab1d4fd2cc8b7a553041e8cdb1022","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapseed/api/pulls/120/commits","review_comments_url":"https://api.github.com/repos/mapseed/api/pulls/120/comments","review_comment_url":"https://api.github.com/repos/mapseed/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapseed/api/issues/120/comments","statuses_url":"https://api.github.com/repos/mapseed/api/statuses/44e53d57c5901a1f93a9bd8f5b5c8ab0ee10c299","head":{"label":"mapseed:goldpbear/place-email","ref":"goldpbear/place-email","sha":"44e53d57c5901a1f93a9bd8f5b5c8ab0ee10c299","user":{"login":"mapseed","id":7245803,"avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"repo":{"id":28839492,"name":"api","full_name":"mapseed/api","owner":{"login":"mapseed","id":7245803,"avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapseed/api","description":"Based on the shareabouts-api (https://github.com/openplans/shareabouts-api), the duwamish-api provides the backend support and datastore for the Hey Duwamish web app","fork":false,"url":"https://api.github.com/repos/mapseed/api","forks_url":"https://api.github.com/repos/mapseed/api/forks","keys_url":"https://api.github.com/repos/mapseed/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapseed/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapseed/api/teams","hooks_url":"https://api.github.com/repos/mapseed/api/hooks","issue_events_url":"https://api.github.com/repos/mapseed/api/issues/events{/number}","events_url":"https://api.github.com/repos/mapseed/api/events","assignees_url":"https://api.github.com/repos/mapseed/api/assignees{/user}","branches_url":"https://api.github.com/repos/mapseed/api/branches{/branch}","tags_url":"https://api.github.com/repos/mapseed/api/tags","blobs_url":"https://api.github.com/repos/mapseed/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapseed/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapseed/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapseed/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapseed/api/statuses/{sha}","languages_url":"https://api.github.com/repos/mapseed/api/languages","stargazers_url":"https://api.github.com/repos/mapseed/api/stargazers","contributors_url":"https://api.github.com/repos/mapseed/api/contributors","subscribers_url":"https://api.github.com/repos/mapseed/api/subscribers","subscription_url":"https://api.github.com/repos/mapseed/api/subscription","commits_url":"https://api.github.com/repos/mapseed/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapseed/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapseed/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapseed/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapseed/api/contents/{+path}","compare_url":"https://api.github.com/repos/mapseed/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapseed/api/merges","archive_url":"https://api.github.com/repos/mapseed/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapseed/api/downloads","issues_url":"https://api.github.com/repos/mapseed/api/issues{/number}","pulls_url":"https://api.github.com/repos/mapseed/api/pulls{/number}","milestones_url":"https://api.github.com/repos/mapseed/api/milestones{/number}","notifications_url":"https://api.github.com/repos/mapseed/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapseed/api/labels{/name}","releases_url":"https://api.github.com/repos/mapseed/api/releases{/id}","deployments_url":"https://api.github.com/repos/mapseed/api/deployments","created_at":"2015-01-06T00:46:59Z","updated_at":"2017-11-07T14:26:48Z","pushed_at":"2018-04-18T21:43:58Z","git_url":"git://github.com/mapseed/api.git","ssh_url":"git@github.com:mapseed/api.git","clone_url":"https://github.com/mapseed/api.git","svn_url":"https://github.com/mapseed/api","homepage":"http://smartercleanup.org","size":6250,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":4,"open_issues":33,"watchers":3,"default_branch":"master"}},"base":{"label":"mapseed:master","ref":"master","sha":"60610e8a11d5c0788de3bcd0463c7dfb55c6fc66","user":{"login":"mapseed","id":7245803,"avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"repo":{"id":28839492,"name":"api","full_name":"mapseed/api","owner":{"login":"mapseed","id":7245803,"avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapseed/api","description":"Based on the shareabouts-api (https://github.com/openplans/shareabouts-api), the duwamish-api provides the backend support and datastore for the Hey Duwamish web app","fork":false,"url":"https://api.github.com/repos/mapseed/api","forks_url":"https://api.github.com/repos/mapseed/api/forks","keys_url":"https://api.github.com/repos/mapseed/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapseed/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapseed/api/teams","hooks_url":"https://api.github.com/repos/mapseed/api/hooks","issue_events_url":"https://api.github.com/repos/mapseed/api/issues/events{/number}","events_url":"https://api.github.com/repos/mapseed/api/events","assignees_url":"https://api.github.com/repos/mapseed/api/assignees{/user}","branches_url":"https://api.github.com/repos/mapseed/api/branches{/branch}","tags_url":"https://api.github.com/repos/mapseed/api/tags","blobs_url":"https://api.github.com/repos/mapseed/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapseed/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapseed/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapseed/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapseed/api/statuses/{sha}","languages_url":"https://api.github.com/repos/mapseed/api/languages","stargazers_url":"https://api.github.com/repos/mapseed/api/stargazers","contributors_url":"https://api.github.com/repos/mapseed/api/contributors","subscribers_url":"https://api.github.com/repos/mapseed/api/subscribers","subscription_url":"https://api.github.com/repos/mapseed/api/subscription","commits_url":"https://api.github.com/repos/mapseed/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapseed/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapseed/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapseed/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapseed/api/contents/{+path}","compare_url":"https://api.github.com/repos/mapseed/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapseed/api/merges","archive_url":"https://api.github.com/repos/mapseed/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapseed/api/downloads","issues_url":"https://api.github.com/repos/mapseed/api/issues{/number}","pulls_url":"https://api.github.com/repos/mapseed/api/pulls{/number}","milestones_url":"https://api.github.com/repos/mapseed/api/milestones{/number}","notifications_url":"https://api.github.com/repos/mapseed/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapseed/api/labels{/name}","releases_url":"https://api.github.com/repos/mapseed/api/releases{/id}","deployments_url":"https://api.github.com/repos/mapseed/api/deployments","created_at":"2015-01-06T00:46:59Z","updated_at":"2017-11-07T14:26:48Z","pushed_at":"2018-04-18T21:43:58Z","git_url":"git://github.com/mapseed/api.git","ssh_url":"git@github.com:mapseed/api.git","clone_url":"https://github.com/mapseed/api.git","svn_url":"https://github.com/mapseed/api","homepage":"http://smartercleanup.org","size":6250,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":4,"open_issues":33,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapseed/api/pulls/120"},"html":{"href":"https://github.com/mapseed/api/pull/120"},"issue":{"href":"https://api.github.com/repos/mapseed/api/issues/120"},"comments":{"href":"https://api.github.com/repos/mapseed/api/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/mapseed/api/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/mapseed/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapseed/api/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/mapseed/api/statuses/44e53d57c5901a1f93a9bd8f5b5c8ab0ee10c299"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"modulitos"}}