{"action":"closed","number":12385,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385","id":168919234,"html_url":"https://github.com/home-assistant/home-assistant/pull/12385","diff_url":"https://github.com/home-assistant/home-assistant/pull/12385.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12385.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12385","number":12385,"state":"closed","locked":false,"title":"Make WUnderground async","user":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nMakes [WUnderground](https://home-assistant.io/components/sensor.wunderground/) sensor platform async, using [aiohttp's HTTP client](http://aiohttp.readthedocs.io/en/v0.15.3/client.html).\r\n\r\nPrevious tests had to be updated quite significantly to use the `aiohttp_mock` fixture. During that process, the JSON payloads were moved to file fixtures. I didn't know how a `unittest.TestCase` class could be transformed to handle async tests, so I had to move the tests to top-level coroutines and change the `self.assert*` calls.\r\n\r\nIf someone knows how to fix the tests/make them aiohttp-aware without changing the whole `test_wunderground.py` file and making reviewing more difficult, please tell me.\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensor:\r\n  - platform: wunderground\r\n    api_key: !secret wunderground_api_key\r\n    monitored_conditions:\r\n      - weather\r\n      - weather_1d_metric\r\n      - weather_1n_metric\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-02-13T18:17:22Z","updated_at":"2018-02-14T19:08:02Z","closed_at":"2018-02-14T19:08:02Z","merged_at":null,"merge_commit_sha":"c03b11eed1d405510eef74577875b3b039a2ae2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":550201448,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.wunderground","name":"platform: sensor.wunderground","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12385/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/20bcc4405b462d5260ae9e018e321a0d1452f4e1","head":{"label":"OttoWinter:async-wunderground","ref":"async-wunderground","sha":"20bcc4405b462d5260ae9e018e321a0d1452f4e1","user":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"repo":{"id":81717015,"name":"home-assistant","full_name":"OttoWinter/home-assistant","owner":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OttoWinter/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/OttoWinter/home-assistant","forks_url":"https://api.github.com/repos/OttoWinter/home-assistant/forks","keys_url":"https://api.github.com/repos/OttoWinter/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OttoWinter/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OttoWinter/home-assistant/teams","hooks_url":"https://api.github.com/repos/OttoWinter/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/OttoWinter/home-assistant/events","assignees_url":"https://api.github.com/repos/OttoWinter/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/OttoWinter/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/tags","blobs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OttoWinter/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/OttoWinter/home-assistant/languages","stargazers_url":"https://api.github.com/repos/OttoWinter/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/OttoWinter/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscription","commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/OttoWinter/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/OttoWinter/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/OttoWinter/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OttoWinter/home-assistant/merges","archive_url":"https://api.github.com/repos/OttoWinter/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OttoWinter/home-assistant/downloads","issues_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/OttoWinter/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/OttoWinter/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/OttoWinter/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OttoWinter/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/OttoWinter/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/OttoWinter/home-assistant/deployments","created_at":"2017-02-12T10:00:20Z","updated_at":"2018-01-22T16:40:59Z","pushed_at":"2018-02-14T17:51:33Z","git_url":"git://github.com/OttoWinter/home-assistant.git","ssh_url":"git@github.com:OttoWinter/home-assistant.git","clone_url":"https://github.com/OttoWinter/home-assistant.git","svn_url":"https://github.com/OttoWinter/home-assistant","homepage":"https://home-assistant.io","size":78689,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"80d2c76e85afbf2da3786492bfa2ab3977bd601a","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-14T18:39:41Z","pushed_at":"2018-02-14T18:25:11Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78856,"stargazers_count":12536,"watchers_count":12536,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3611,"mirror_url":null,"archived":false,"open_issues_count":833,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3611,"open_issues":833,"watchers":12536,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12385"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12385"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12385/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12385/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/20bcc4405b462d5260ae9e018e321a0d1452f4e1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":20,"maintainer_can_modify":false,"commits":6,"additions":262,"deletions":293,"changed_files":5}}
{"actor":{"display_login":"OttoWinter"}}