{"action":"created","comment":{"url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments/179883898","pull_request_review_id":110218526,"id":179883898,"diff_hunk":"@@ -0,0 +1,91 @@\n+require 'test_helper'\n+\n+class PageLayoutHelperTest < ActionView::TestCase\n+\n+  context '#page_title' do\n+    should 'should return the page title when given one' do\n+      assert_equal t('site_name'), page_title(t('site_name'))\n+    end\n+\n+    should 'should concat multiple page titles together when called multiple times' do\n+      page_title(t('admin.users.index.header'))\n+      page_title(t('admin.header'))\n+      assert_equal \"#{t('admin.users.index.header')} | #{t('admin.header')} | #{t('site_name')}\",\n+                   page_title(t('site_name'))\n+    end\n+  end\n+\n+  # page_description\n+  test 'page_description defaults to welcome lead' do\n+    assert_equal I18n.t('welcome.index.welcome_lead'), page_description\n+  end\n+\n+  test 'page_description returns last pushed description' do\n+    page_description('Foo')\n+    page_description('Bar')\n+    page_description('Baz')\n+\n+    assert_equal 'Baz', page_description\n+  end\n+\n+  test 'page_description squishes multiple newlines' do\n+    page_description(\"Foo\\nBar\\nBaz\")\n+\n+    assert_equal 'Foo Bar Baz', page_description\n+  end\n+\n+  test 'page_description truncates long text' do\n+\n+    text = 'Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo\n+    ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis\n+    dis parturient montes, nascetur ridiculus mus. Donec quam felis,\n+    ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa\n+    quis enim. Donec pede justo, fringilla vel, aliquet nec, vulputate eget,\n+    arcu.'\n+\n+    page_description(text)\n+\n+\n+    assert_match /natoque penatibus et...\\z/, page_description\n+  end\n+\n+  test 'page_description sanitizes all html' do\n+    page_description('<b>Bold</b> <h1>Header</h1>')\n+\n+    assert_equal 'Bold Header', page_description\n+  end\n+  # page_image\n+end","path":"test/helpers/page_layout_helper_test.rb","position":58,"original_position":58,"commit_id":"499ed34792c0e4b61339623ab52e123503ae400f","original_commit_id":"499ed34792c0e4b61339623ab52e123503ae400f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/EmptyLinesAroundClassBody: Empty line missing at class body end. (https://github.com/bbatsov/ruby-style-guide#empty-lines-around-bodies)","created_at":"2018-04-06T21:49:25Z","updated_at":"2018-04-06T21:49:26Z","html_url":"https://github.com/ualbertalib/jupiter/pull/619#discussion_r179883898","pull_request_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments/179883898"},"html":{"href":"https://github.com/ualbertalib/jupiter/pull/619#discussion_r179883898"},"pull_request":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619","id":179786448,"html_url":"https://github.com/ualbertalib/jupiter/pull/619","diff_url":"https://github.com/ualbertalib/jupiter/pull/619.diff","patch_url":"https://github.com/ualbertalib/jupiter/pull/619.patch","issue_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/619","number":619,"state":"open","locked":false,"title":"WIP: Frontend checklist (part 3)","user":{"login":"murny","id":1930474,"avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"body":"https://github.com/ualbertalib/jupiter/issues/562\r\n\r\nTODO\r\n\r\n### HEAD\r\n- [x] Facebook OG and Twitter Cards\r\n- [x] meta description\r\n\r\n### ACCESSIBILITY\r\n- [ ] All pages have an H1 and right order for sub headings (H1 to H6)","created_at":"2018-04-05T20:23:49Z","updated_at":"2018-04-06T21:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9a7c9e88d40018b5d4189629b0d73f14830cea7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619/commits","review_comments_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619/comments","review_comment_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/619/comments","statuses_url":"https://api.github.com/repos/ualbertalib/jupiter/statuses/499ed34792c0e4b61339623ab52e123503ae400f","head":{"label":"murny:frontend_checklist-part3","ref":"frontend_checklist-part3","sha":"499ed34792c0e4b61339623ab52e123503ae400f","user":{"login":"murny","id":1930474,"avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"repo":{"id":96910081,"name":"jupiter","full_name":"murny/jupiter","owner":{"login":"murny","id":1930474,"avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murny/jupiter","description":"An experiment","fork":true,"url":"https://api.github.com/repos/murny/jupiter","forks_url":"https://api.github.com/repos/murny/jupiter/forks","keys_url":"https://api.github.com/repos/murny/jupiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murny/jupiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murny/jupiter/teams","hooks_url":"https://api.github.com/repos/murny/jupiter/hooks","issue_events_url":"https://api.github.com/repos/murny/jupiter/issues/events{/number}","events_url":"https://api.github.com/repos/murny/jupiter/events","assignees_url":"https://api.github.com/repos/murny/jupiter/assignees{/user}","branches_url":"https://api.github.com/repos/murny/jupiter/branches{/branch}","tags_url":"https://api.github.com/repos/murny/jupiter/tags","blobs_url":"https://api.github.com/repos/murny/jupiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murny/jupiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murny/jupiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/murny/jupiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murny/jupiter/statuses/{sha}","languages_url":"https://api.github.com/repos/murny/jupiter/languages","stargazers_url":"https://api.github.com/repos/murny/jupiter/stargazers","contributors_url":"https://api.github.com/repos/murny/jupiter/contributors","subscribers_url":"https://api.github.com/repos/murny/jupiter/subscribers","subscription_url":"https://api.github.com/repos/murny/jupiter/subscription","commits_url":"https://api.github.com/repos/murny/jupiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/murny/jupiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/murny/jupiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/murny/jupiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/murny/jupiter/contents/{+path}","compare_url":"https://api.github.com/repos/murny/jupiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murny/jupiter/merges","archive_url":"https://api.github.com/repos/murny/jupiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murny/jupiter/downloads","issues_url":"https://api.github.com/repos/murny/jupiter/issues{/number}","pulls_url":"https://api.github.com/repos/murny/jupiter/pulls{/number}","milestones_url":"https://api.github.com/repos/murny/jupiter/milestones{/number}","notifications_url":"https://api.github.com/repos/murny/jupiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murny/jupiter/labels{/name}","releases_url":"https://api.github.com/repos/murny/jupiter/releases{/id}","deployments_url":"https://api.github.com/repos/murny/jupiter/deployments","created_at":"2017-07-11T15:44:36Z","updated_at":"2018-04-06T16:00:40Z","pushed_at":"2018-04-06T21:49:15Z","git_url":"git://github.com/murny/jupiter.git","ssh_url":"git@github.com:murny/jupiter.git","clone_url":"https://github.com/murny/jupiter.git","svn_url":"https://github.com/murny/jupiter","homepage":"","size":2191,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ualbertalib:master","ref":"master","sha":"ebc05a9d198e971001f211870245b254131ef734","user":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars3.githubusercontent.com/u/2856757?v=4","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"repo":{"id":94144356,"name":"jupiter","full_name":"ualbertalib/jupiter","owner":{"login":"ualbertalib","id":2856757,"avatar_url":"https://avatars3.githubusercontent.com/u/2856757?v=4","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ualbertalib/jupiter","description":"Jupiter is a University of Alberta Libraries-based initiative to create a sustainable and extensible digital asset management system. This is phase 1 (IR).","fork":false,"url":"https://api.github.com/repos/ualbertalib/jupiter","forks_url":"https://api.github.com/repos/ualbertalib/jupiter/forks","keys_url":"https://api.github.com/repos/ualbertalib/jupiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ualbertalib/jupiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ualbertalib/jupiter/teams","hooks_url":"https://api.github.com/repos/ualbertalib/jupiter/hooks","issue_events_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/events{/number}","events_url":"https://api.github.com/repos/ualbertalib/jupiter/events","assignees_url":"https://api.github.com/repos/ualbertalib/jupiter/assignees{/user}","branches_url":"https://api.github.com/repos/ualbertalib/jupiter/branches{/branch}","tags_url":"https://api.github.com/repos/ualbertalib/jupiter/tags","blobs_url":"https://api.github.com/repos/ualbertalib/jupiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ualbertalib/jupiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ualbertalib/jupiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ualbertalib/jupiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ualbertalib/jupiter/statuses/{sha}","languages_url":"https://api.github.com/repos/ualbertalib/jupiter/languages","stargazers_url":"https://api.github.com/repos/ualbertalib/jupiter/stargazers","contributors_url":"https://api.github.com/repos/ualbertalib/jupiter/contributors","subscribers_url":"https://api.github.com/repos/ualbertalib/jupiter/subscribers","subscription_url":"https://api.github.com/repos/ualbertalib/jupiter/subscription","commits_url":"https://api.github.com/repos/ualbertalib/jupiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ualbertalib/jupiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ualbertalib/jupiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ualbertalib/jupiter/contents/{+path}","compare_url":"https://api.github.com/repos/ualbertalib/jupiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ualbertalib/jupiter/merges","archive_url":"https://api.github.com/repos/ualbertalib/jupiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ualbertalib/jupiter/downloads","issues_url":"https://api.github.com/repos/ualbertalib/jupiter/issues{/number}","pulls_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls{/number}","milestones_url":"https://api.github.com/repos/ualbertalib/jupiter/milestones{/number}","notifications_url":"https://api.github.com/repos/ualbertalib/jupiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ualbertalib/jupiter/labels{/name}","releases_url":"https://api.github.com/repos/ualbertalib/jupiter/releases{/id}","deployments_url":"https://api.github.com/repos/ualbertalib/jupiter/deployments","created_at":"2017-06-12T22:00:01Z","updated_at":"2018-04-06T21:03:17Z","pushed_at":"2018-04-06T21:49:16Z","git_url":"git://github.com/ualbertalib/jupiter.git","ssh_url":"git@github.com:ualbertalib/jupiter.git","clone_url":"https://github.com/ualbertalib/jupiter.git","svn_url":"https://github.com/ualbertalib/jupiter","homepage":"","size":2445,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":84,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619"},"html":{"href":"https://github.com/ualbertalib/jupiter/pull/619"},"issue":{"href":"https://api.github.com/repos/ualbertalib/jupiter/issues/619"},"comments":{"href":"https://api.github.com/repos/ualbertalib/jupiter/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/ualbertalib/jupiter/statuses/499ed34792c0e4b61339623ab52e123503ae400f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}