{"action":"created","issue":{"url":"https://api.github.com/repos/erikd/libsndfile/issues/426","repository_url":"https://api.github.com/repos/erikd/libsndfile","labels_url":"https://api.github.com/repos/erikd/libsndfile/issues/426/labels{/name}","comments_url":"https://api.github.com/repos/erikd/libsndfile/issues/426/comments","events_url":"https://api.github.com/repos/erikd/libsndfile/issues/426/events","html_url":"https://github.com/erikd/libsndfile/pull/426","id":368098072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzUxMjQw","number":426,"title":"Fix lossy_comp_test sdlcomp_test_(float|double) for Vorbis","user":{"login":"arthurt","id":233916,"node_id":"MDQ6VXNlcjIzMzkxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/233916?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurt","html_url":"https://github.com/arthurt","followers_url":"https://api.github.com/users/arthurt/followers","following_url":"https://api.github.com/users/arthurt/following{/other_user}","gists_url":"https://api.github.com/users/arthurt/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurt/subscriptions","organizations_url":"https://api.github.com/users/arthurt/orgs","repos_url":"https://api.github.com/users/arthurt/repos","events_url":"https://api.github.com/users/arthurt/events{/privacy}","received_events_url":"https://api.github.com/users/arthurt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-09T08:35:23Z","updated_at":"2018-10-09T08:40:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/erikd/libsndfile/pulls/426","html_url":"https://github.com/erikd/libsndfile/pull/426","diff_url":"https://github.com/erikd/libsndfile/pull/426.diff","patch_url":"https://github.com/erikd/libsndfile/pull/426.patch"},"body":"While experimenting, determined that Vobis' analysis stops working on\r\nnon-normalized floating point input outside the range of [2000.0, -2000.0], and\r\nseems to get worse the larger the magnitude. As the sdlcomp_test_float and\r\nsldcomp_test_double tests work with non-normalized floats with a magnitude of\r\n32000.0, this explains why they do not work for Vorbis.\r\n\r\nThis patch fixes the test by reducing the magnitude of the test data at encode\r\nand restoring it at decode if it detects Vorbis, mantaining the same 32000.0\r\noverall magnitude so the envelope values for the test are the same as they are\r\nfor other tests and format.\r\n\r\nIt is unknown at this time if the input range magnitude of 2000.0 is  a\r\nlimitation of Vorbis or libvorbis."},"comment":{"url":"https://api.github.com/repos/erikd/libsndfile/issues/comments/428109858","html_url":"https://github.com/erikd/libsndfile/pull/426#issuecomment-428109858","issue_url":"https://api.github.com/repos/erikd/libsndfile/issues/426","id":428109858,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODEwOTg1OA==","user":{"login":"arthurt","id":233916,"node_id":"MDQ6VXNlcjIzMzkxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/233916?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurt","html_url":"https://github.com/arthurt","followers_url":"https://api.github.com/users/arthurt/followers","following_url":"https://api.github.com/users/arthurt/following{/other_user}","gists_url":"https://api.github.com/users/arthurt/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurt/subscriptions","organizations_url":"https://api.github.com/users/arthurt/orgs","repos_url":"https://api.github.com/users/arthurt/repos","events_url":"https://api.github.com/users/arthurt/events{/privacy}","received_events_url":"https://api.github.com/users/arthurt/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T08:40:41Z","updated_at":"2018-10-09T08:40:41Z","author_association":"CONTRIBUTOR","body":"This all came out of working on tests for the ogg-opus branch. Adding Opus tests to lossy_comp_tests will require a similar fix as libopus only allows normalized floating point values, possibly depending on whether libopus was compiled with or without floating point support.\r\n\r\nIt seemed to make sense to me to offer this as a stand-alone pull request."}}
{"actor":{"display_login":"arthurt"}}