{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/200042432","pull_request_review_id":134277499,"id":200042432,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA0MjQzMg==","diff_hunk":"@@ -228,18 +222,13 @@ def add_role_request\n     req = nil\n     begin\n       BsRequest.transaction do\n-        req = BsRequest.new\n-        req.state = 'new'\n-        req.description = params[:description]\n-\n         opts = { target_project: params[:project],\n-                 role:           params[:role] }\n+                 role:           params[:role],\n+                 description: params[:description] }\n         opts[:target_package] = params[:package] if params[:package]\n         opts[:person_name] = params[:user] if params[:user]\n         opts[:group_name] = params[:group] if params[:group]\n-        action = BsRequestActionAddRole.new(opts)\n-        req.bs_request_actions << action\n-\n+        req = prepare_bsrequest(:add_role, opts)","path":"src/api/app/controllers/webui/request_controller.rb","position":37,"original_position":37,"commit_id":"12ea4d09a59760fcf6452ce9e5bc295b2230af9d","original_commit_id":"1b43806fb8b5d1d07be62c35210e641c2afebf95","user":{"login":"coolo","id":1067203,"node_id":"MDQ6VXNlcjEwNjcyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1067203?v=4","gravatar_id":"","url":"https://api.github.com/users/coolo","html_url":"https://github.com/coolo","followers_url":"https://api.github.com/users/coolo/followers","following_url":"https://api.github.com/users/coolo/following{/other_user}","gists_url":"https://api.github.com/users/coolo/gists{/gist_id}","starred_url":"https://api.github.com/users/coolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolo/subscriptions","organizations_url":"https://api.github.com/users/coolo/orgs","repos_url":"https://api.github.com/users/coolo/repos","events_url":"https://api.github.com/users/coolo/events{/privacy}","received_events_url":"https://api.github.com/users/coolo/received_events","type":"User","site_admin":false},"body":"params is not an array, but a PermittedParams object - slicing that is not allowed","created_at":"2018-07-04T08:12:33Z","updated_at":"2018-07-04T08:12:33Z","html_url":"https://github.com/openSUSE/open-build-service/pull/5281#discussion_r200042432","pull_request_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/200042432"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/5281#discussion_r200042432"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281"}},"in_reply_to_id":199974794},"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281","id":198947888,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTQ3ODg4","html_url":"https://github.com/openSUSE/open-build-service/pull/5281","diff_url":"https://github.com/openSUSE/open-build-service/pull/5281.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/5281.patch","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/5281","number":5281,"state":"open","locked":false,"title":"[webui] refactoring request_controller and improve spec coverage","user":{"login":"vpereira","id":37418,"node_id":"MDQ6VXNlcjM3NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/37418?v=4","gravatar_id":"","url":"https://api.github.com/users/vpereira","html_url":"https://github.com/vpereira","followers_url":"https://api.github.com/users/vpereira/followers","following_url":"https://api.github.com/users/vpereira/following{/other_user}","gists_url":"https://api.github.com/users/vpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/vpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpereira/subscriptions","organizations_url":"https://api.github.com/users/vpereira/orgs","repos_url":"https://api.github.com/users/vpereira/repos","events_url":"https://api.github.com/users/vpereira/events{/privacy}","received_events_url":"https://api.github.com/users/vpereira/received_events","type":"User","site_admin":false},"body":"added testcase for missing action, added the necessaries factories and refactored some repeated code to it's own method","created_at":"2018-07-03T12:33:15Z","updated_at":"2018-07-04T08:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf1a24d1fe895c243318ba1f358245c1724a42d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":21922370,"node_id":"MDU6TGFiZWwyMTkyMjM3MA==","url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Frontend%20%F0%9F%91%BB","name":"Frontend 👻","color":"c7def8","default":false},{"id":433543039,"node_id":"MDU6TGFiZWw0MzM1NDMwMzk=","url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Refactoring%20:factory:","name":"Refactoring :factory:","color":"CAFF70","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281/commits","review_comments_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281/comments","review_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/5281/comments","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/12ea4d09a59760fcf6452ce9e5bc295b2230af9d","head":{"label":"vpereira:webui_request_controller","ref":"webui_request_controller","sha":"12ea4d09a59760fcf6452ce9e5bc295b2230af9d","user":{"login":"vpereira","id":37418,"node_id":"MDQ6VXNlcjM3NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/37418?v=4","gravatar_id":"","url":"https://api.github.com/users/vpereira","html_url":"https://github.com/vpereira","followers_url":"https://api.github.com/users/vpereira/followers","following_url":"https://api.github.com/users/vpereira/following{/other_user}","gists_url":"https://api.github.com/users/vpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/vpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpereira/subscriptions","organizations_url":"https://api.github.com/users/vpereira/orgs","repos_url":"https://api.github.com/users/vpereira/repos","events_url":"https://api.github.com/users/vpereira/events{/privacy}","received_events_url":"https://api.github.com/users/vpereira/received_events","type":"User","site_admin":false},"repo":{"id":133777614,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3Nzc2MTQ=","name":"open-build-service","full_name":"vpereira/open-build-service","owner":{"login":"vpereira","id":37418,"node_id":"MDQ6VXNlcjM3NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/37418?v=4","gravatar_id":"","url":"https://api.github.com/users/vpereira","html_url":"https://github.com/vpereira","followers_url":"https://api.github.com/users/vpereira/followers","following_url":"https://api.github.com/users/vpereira/following{/other_user}","gists_url":"https://api.github.com/users/vpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/vpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpereira/subscriptions","organizations_url":"https://api.github.com/users/vpereira/orgs","repos_url":"https://api.github.com/users/vpereira/repos","events_url":"https://api.github.com/users/vpereira/events{/privacy}","received_events_url":"https://api.github.com/users/vpereira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vpereira/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":true,"url":"https://api.github.com/repos/vpereira/open-build-service","forks_url":"https://api.github.com/repos/vpereira/open-build-service/forks","keys_url":"https://api.github.com/repos/vpereira/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpereira/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpereira/open-build-service/teams","hooks_url":"https://api.github.com/repos/vpereira/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/vpereira/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/vpereira/open-build-service/events","assignees_url":"https://api.github.com/repos/vpereira/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/vpereira/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/vpereira/open-build-service/tags","blobs_url":"https://api.github.com/repos/vpereira/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpereira/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpereira/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpereira/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpereira/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/vpereira/open-build-service/languages","stargazers_url":"https://api.github.com/repos/vpereira/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/vpereira/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/vpereira/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/vpereira/open-build-service/subscription","commits_url":"https://api.github.com/repos/vpereira/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpereira/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpereira/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpereira/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/vpereira/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/vpereira/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpereira/open-build-service/merges","archive_url":"https://api.github.com/repos/vpereira/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpereira/open-build-service/downloads","issues_url":"https://api.github.com/repos/vpereira/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/vpereira/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/vpereira/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/vpereira/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpereira/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/vpereira/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/vpereira/open-build-service/deployments","created_at":"2018-05-17T07:42:45Z","updated_at":"2018-07-03T08:28:27Z","pushed_at":"2018-07-04T08:09:05Z","git_url":"git://github.com/vpereira/open-build-service.git","ssh_url":"git@github.com:vpereira/open-build-service.git","clone_url":"https://github.com/vpereira/open-build-service.git","svn_url":"https://github.com/vpereira/open-build-service","homepage":"http://openbuildservice.org/","size":60190,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"787e0d0cd8d7de33a047f08ebac5ae8f2f44ba9b","user":{"login":"openSUSE","id":623819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzgxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":2046192,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ2MTky","name":"open-build-service","full_name":"openSUSE/open-build-service","owner":{"login":"openSUSE","id":623819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzgxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":false,"url":"https://api.github.com/repos/openSUSE/open-build-service","forks_url":"https://api.github.com/repos/openSUSE/open-build-service/forks","keys_url":"https://api.github.com/repos/openSUSE/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/open-build-service/teams","hooks_url":"https://api.github.com/repos/openSUSE/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/open-build-service/events","assignees_url":"https://api.github.com/repos/openSUSE/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/open-build-service/tags","blobs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/open-build-service/languages","stargazers_url":"https://api.github.com/repos/openSUSE/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/open-build-service/subscription","commits_url":"https://api.github.com/repos/openSUSE/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/open-build-service/merges","archive_url":"https://api.github.com/repos/openSUSE/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/open-build-service/downloads","issues_url":"https://api.github.com/repos/openSUSE/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/open-build-service/deployments","created_at":"2011-07-14T06:52:57Z","updated_at":"2018-07-04T08:00:04Z","pushed_at":"2018-07-04T08:09:06Z","git_url":"git://github.com/openSUSE/open-build-service.git","ssh_url":"git@github.com:openSUSE/open-build-service.git","clone_url":"https://github.com/openSUSE/open-build-service.git","svn_url":"https://github.com/openSUSE/open-build-service","homepage":"http://openbuildservice.org/","size":60240,"stargazers_count":359,"watchers_count":359,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":512,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":244,"open_issues":512,"watchers":359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/5281"},"issue":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/5281"},"comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/5281/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/5281/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/open-build-service/statuses/12ea4d09a59760fcf6452ce9e5bc295b2230af9d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"coolo"}}