{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/comments/176300528","pull_request_review_id":105977894,"id":176300528,"diff_hunk":"@@ -64,6 +66,37 @@ type ApplicationStatus struct {\n \tObservedGeneration int64 `json:\"observedGeneration,omitempty\"`\n }\n \n+// Maintainer contains information about an individual or organization that maintains the source code, images, and\n+// package for an Application. An Application can have more than one maintainer.\n+type Maintainer struct {\n+\t// Name is the descriptive name of the maintainer.\n+\tName string `json:\"name,omitempty\"`\n+\n+\t// Url could typically be a website address or a mailto: email address.\n+\tUrl string `json:\"url,omitempty\"`\n+}\n+\n+// Link contains information about an URL to surface documentation, dashboards, etc.\n+type Link struct {\n+\t// Type defines the purpose of the link.\n+\tType string `json:\"type,omitempty\"`","path":"pkg/apis/application/v1alpha1/application_types.go","position":54,"original_position":48,"commit_id":"104c74fe96db39153d9f80b7dd612c27e7266cb8","original_commit_id":"b95a1d6758e749f6689b35e608c1deccb3d51218","user":{"login":"deustis","id":11576027,"avatar_url":"https://avatars2.githubusercontent.com/u/11576027?v=4","gravatar_id":"","url":"https://api.github.com/users/deustis","html_url":"https://github.com/deustis","followers_url":"https://api.github.com/users/deustis/followers","following_url":"https://api.github.com/users/deustis/following{/other_user}","gists_url":"https://api.github.com/users/deustis/gists{/gist_id}","starred_url":"https://api.github.com/users/deustis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deustis/subscriptions","organizations_url":"https://api.github.com/users/deustis/orgs","repos_url":"https://api.github.com/users/deustis/repos","events_url":"https://api.github.com/users/deustis/events{/privacy}","received_events_url":"https://api.github.com/users/deustis/received_events","type":"User","site_admin":false},"body":"@mattfarina, no standards that I'm aware of.\r\n\r\nWe ([Google Cloud Launcher](https://console.cloud.google.com/launcher)) have experience collecting product metadata from software vendors. We don't try to categorize different link types today, but we do see very common recurring patterns. We could try to pull together some data if that would be helpful.\r\n\r\nThe main reason to consider categorizing links would be able to give them special treatment in UIs. for example, UIs would typically want to feature the \"user guide\" more prominently than \"tutorials\", or \"community forums\".\r\n\r\nI do think we should either remove Type, or restrict it to a specific set of values. Otherwise, as a free-form string, it doesn't add much value.\r\n\r\n","created_at":"2018-03-22T03:32:56Z","updated_at":"2018-03-22T03:32:56Z","html_url":"https://github.com/kubernetes-sigs/application/pull/4#discussion_r176300528","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/comments/176300528"},"html":{"href":"https://github.com/kubernetes-sigs/application/pull/4#discussion_r176300528"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4"}},"in_reply_to_id":175219142},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4","id":175400651,"html_url":"https://github.com/kubernetes-sigs/application/pull/4","diff_url":"https://github.com/kubernetes-sigs/application/pull/4.diff","patch_url":"https://github.com/kubernetes-sigs/application/pull/4.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/application/issues/4","number":4,"state":"open","locked":false,"title":"Improve Maintainers, Links, Info, and add Notes","user":{"login":"huyhg","id":20563968,"avatar_url":"https://avatars1.githubusercontent.com/u/20563968?v=4","gravatar_id":"","url":"https://api.github.com/users/huyhg","html_url":"https://github.com/huyhg","followers_url":"https://api.github.com/users/huyhg/followers","following_url":"https://api.github.com/users/huyhg/following{/other_user}","gists_url":"https://api.github.com/users/huyhg/gists{/gist_id}","starred_url":"https://api.github.com/users/huyhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huyhg/subscriptions","organizations_url":"https://api.github.com/users/huyhg/orgs","repos_url":"https://api.github.com/users/huyhg/repos","events_url":"https://api.github.com/users/huyhg/events{/privacy}","received_events_url":"https://api.github.com/users/huyhg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-15T22:58:12Z","updated_at":"2018-03-22T03:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"757ab40f8e8f3664556c011d10275bf063c5ab35","assignee":null,"assignees":[],"requested_reviewers":[{"login":"michelleN","id":1497123,"avatar_url":"https://avatars0.githubusercontent.com/u/1497123?v=4","gravatar_id":"","url":"https://api.github.com/users/michelleN","html_url":"https://github.com/michelleN","followers_url":"https://api.github.com/users/michelleN/followers","following_url":"https://api.github.com/users/michelleN/following{/other_user}","gists_url":"https://api.github.com/users/michelleN/gists{/gist_id}","starred_url":"https://api.github.com/users/michelleN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michelleN/subscriptions","organizations_url":"https://api.github.com/users/michelleN/orgs","repos_url":"https://api.github.com/users/michelleN/repos","events_url":"https://api.github.com/users/michelleN/events{/privacy}","received_events_url":"https://api.github.com/users/michelleN/received_events","type":"User","site_admin":false},{"login":"kow3ns","id":11380896,"avatar_url":"https://avatars3.githubusercontent.com/u/11380896?v=4","gravatar_id":"","url":"https://api.github.com/users/kow3ns","html_url":"https://github.com/kow3ns","followers_url":"https://api.github.com/users/kow3ns/followers","following_url":"https://api.github.com/users/kow3ns/following{/other_user}","gists_url":"https://api.github.com/users/kow3ns/gists{/gist_id}","starred_url":"https://api.github.com/users/kow3ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow3ns/subscriptions","organizations_url":"https://api.github.com/users/kow3ns/orgs","repos_url":"https://api.github.com/users/kow3ns/repos","events_url":"https://api.github.com/users/kow3ns/events{/privacy}","received_events_url":"https://api.github.com/users/kow3ns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":864976950,"url":"https://api.github.com/repos/kubernetes-sigs/application/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":868796113,"url":"https://api.github.com/repos/kubernetes-sigs/application/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/application/issues/4/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/application/statuses/104c74fe96db39153d9f80b7dd612c27e7266cb8","head":{"label":"huyhg:master","ref":"master","sha":"104c74fe96db39153d9f80b7dd612c27e7266cb8","user":{"login":"huyhg","id":20563968,"avatar_url":"https://avatars1.githubusercontent.com/u/20563968?v=4","gravatar_id":"","url":"https://api.github.com/users/huyhg","html_url":"https://github.com/huyhg","followers_url":"https://api.github.com/users/huyhg/followers","following_url":"https://api.github.com/users/huyhg/following{/other_user}","gists_url":"https://api.github.com/users/huyhg/gists{/gist_id}","starred_url":"https://api.github.com/users/huyhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huyhg/subscriptions","organizations_url":"https://api.github.com/users/huyhg/orgs","repos_url":"https://api.github.com/users/huyhg/repos","events_url":"https://api.github.com/users/huyhg/events{/privacy}","received_events_url":"https://api.github.com/users/huyhg/received_events","type":"User","site_admin":false},"repo":{"id":125433624,"name":"apps_application","full_name":"huyhg/apps_application","owner":{"login":"huyhg","id":20563968,"avatar_url":"https://avatars1.githubusercontent.com/u/20563968?v=4","gravatar_id":"","url":"https://api.github.com/users/huyhg","html_url":"https://github.com/huyhg","followers_url":"https://api.github.com/users/huyhg/followers","following_url":"https://api.github.com/users/huyhg/following{/other_user}","gists_url":"https://api.github.com/users/huyhg/gists{/gist_id}","starred_url":"https://api.github.com/users/huyhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huyhg/subscriptions","organizations_url":"https://api.github.com/users/huyhg/orgs","repos_url":"https://api.github.com/users/huyhg/repos","events_url":"https://api.github.com/users/huyhg/events{/privacy}","received_events_url":"https://api.github.com/users/huyhg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huyhg/apps_application","description":"Application metadata descriptor CRD","fork":true,"url":"https://api.github.com/repos/huyhg/apps_application","forks_url":"https://api.github.com/repos/huyhg/apps_application/forks","keys_url":"https://api.github.com/repos/huyhg/apps_application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huyhg/apps_application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huyhg/apps_application/teams","hooks_url":"https://api.github.com/repos/huyhg/apps_application/hooks","issue_events_url":"https://api.github.com/repos/huyhg/apps_application/issues/events{/number}","events_url":"https://api.github.com/repos/huyhg/apps_application/events","assignees_url":"https://api.github.com/repos/huyhg/apps_application/assignees{/user}","branches_url":"https://api.github.com/repos/huyhg/apps_application/branches{/branch}","tags_url":"https://api.github.com/repos/huyhg/apps_application/tags","blobs_url":"https://api.github.com/repos/huyhg/apps_application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huyhg/apps_application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huyhg/apps_application/git/refs{/sha}","trees_url":"https://api.github.com/repos/huyhg/apps_application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huyhg/apps_application/statuses/{sha}","languages_url":"https://api.github.com/repos/huyhg/apps_application/languages","stargazers_url":"https://api.github.com/repos/huyhg/apps_application/stargazers","contributors_url":"https://api.github.com/repos/huyhg/apps_application/contributors","subscribers_url":"https://api.github.com/repos/huyhg/apps_application/subscribers","subscription_url":"https://api.github.com/repos/huyhg/apps_application/subscription","commits_url":"https://api.github.com/repos/huyhg/apps_application/commits{/sha}","git_commits_url":"https://api.github.com/repos/huyhg/apps_application/git/commits{/sha}","comments_url":"https://api.github.com/repos/huyhg/apps_application/comments{/number}","issue_comment_url":"https://api.github.com/repos/huyhg/apps_application/issues/comments{/number}","contents_url":"https://api.github.com/repos/huyhg/apps_application/contents/{+path}","compare_url":"https://api.github.com/repos/huyhg/apps_application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huyhg/apps_application/merges","archive_url":"https://api.github.com/repos/huyhg/apps_application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huyhg/apps_application/downloads","issues_url":"https://api.github.com/repos/huyhg/apps_application/issues{/number}","pulls_url":"https://api.github.com/repos/huyhg/apps_application/pulls{/number}","milestones_url":"https://api.github.com/repos/huyhg/apps_application/milestones{/number}","notifications_url":"https://api.github.com/repos/huyhg/apps_application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huyhg/apps_application/labels{/name}","releases_url":"https://api.github.com/repos/huyhg/apps_application/releases{/id}","deployments_url":"https://api.github.com/repos/huyhg/apps_application/deployments","created_at":"2018-03-15T22:32:25Z","updated_at":"2018-03-19T22:15:41Z","pushed_at":"2018-03-19T22:15:40Z","git_url":"git://github.com/huyhg/apps_application.git","ssh_url":"git@github.com:huyhg/apps_application.git","clone_url":"https://github.com/huyhg/apps_application.git","svn_url":"https://github.com/huyhg/apps_application","homepage":null,"size":36423,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"c91065b1a8206d8f7c201ec68d0b6de1d9398a2c","user":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":123396143,"name":"application","full_name":"kubernetes-sigs/application","owner":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/application","description":"Application metadata descriptor CRD","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/application","forks_url":"https://api.github.com/repos/kubernetes-sigs/application/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/application/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/application/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/application/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/application/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/application/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/application/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/application/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/application/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/application/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/application/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/application/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/application/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/application/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/application/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/application/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/application/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/application/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/application/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/application/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/application/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/application/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/application/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/application/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/application/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/application/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/application/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/application/deployments","created_at":"2018-03-01T07:03:20Z","updated_at":"2018-03-21T17:46:33Z","pushed_at":"2018-03-19T22:15:41Z","git_url":"git://github.com/kubernetes-sigs/application.git","ssh_url":"git@github.com:kubernetes-sigs/application.git","clone_url":"https://github.com/kubernetes-sigs/application.git","svn_url":"https://github.com/kubernetes-sigs/application","homepage":null,"size":36419,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":4,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4"},"html":{"href":"https://github.com/kubernetes-sigs/application/pull/4"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/application/issues/4"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/application/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/application/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/application/statuses/104c74fe96db39153d9f80b7dd612c27e7266cb8"}},"author_association":"NONE"}}
{"actor":{"display_login":"deustis"}}