{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/166658584","pull_request_review_id":94757210,"id":166658584,"diff_hunk":"@@ -75,6 +76,9 @@ parseValidator t = do\n         scrScript = Bi.serialize' scr,\n         scrVersion = 0 }\n \n+setVersionOne :: Bi Script_v0 => Script -> Script","path":"txp/Pos/Script.hs","position":12,"original_position":12,"commit_id":"347d098743c62fb8d4db7a7733ab857ee934379b","original_commit_id":"347d098743c62fb8d4db7a7733ab857ee934379b","user":{"login":"neongreen","id":1523306,"avatar_url":"https://avatars3.githubusercontent.com/u/1523306?v=4","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},"body":"No, wait, actually it's even simpler. Why do you need `setVersionOne` at all? Just write `intValidatorWithVersionOne = intValidator {scrVersion = 1}` at the call site.","created_at":"2018-02-07T15:46:10Z","updated_at":"2018-02-07T15:46:10Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2265#discussion_r166658584","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/166658584"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2265#discussion_r166658584"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265"}},"in_reply_to_id":166657786},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265","id":161494632,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/2265","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/2265.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/2265.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2265","number":2265,"state":"open","locked":false,"title":"CSL-1818 Reject transaction if adopted script version mismatch","user":{"login":"v0d1ch","id":1666357,"avatar_url":"https://avatars3.githubusercontent.com/u/1666357?v=4","gravatar_id":"","url":"https://api.github.com/users/v0d1ch","html_url":"https://github.com/v0d1ch","followers_url":"https://api.github.com/users/v0d1ch/followers","following_url":"https://api.github.com/users/v0d1ch/following{/other_user}","gists_url":"https://api.github.com/users/v0d1ch/gists{/gist_id}","starred_url":"https://api.github.com/users/v0d1ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0d1ch/subscriptions","organizations_url":"https://api.github.com/users/v0d1ch/orgs","repos_url":"https://api.github.com/users/v0d1ch/repos","events_url":"https://api.github.com/users/v0d1ch/events{/privacy}","received_events_url":"https://api.github.com/users/v0d1ch/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-06T20:23:48Z","updated_at":"2018-02-07T15:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38cf57e6c7bdf3c8e73384036ff49d67977d6ee2","assignee":{"login":"v0d1ch","id":1666357,"avatar_url":"https://avatars3.githubusercontent.com/u/1666357?v=4","gravatar_id":"","url":"https://api.github.com/users/v0d1ch","html_url":"https://github.com/v0d1ch","followers_url":"https://api.github.com/users/v0d1ch/followers","following_url":"https://api.github.com/users/v0d1ch/following{/other_user}","gists_url":"https://api.github.com/users/v0d1ch/gists{/gist_id}","starred_url":"https://api.github.com/users/v0d1ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0d1ch/subscriptions","organizations_url":"https://api.github.com/users/v0d1ch/orgs","repos_url":"https://api.github.com/users/v0d1ch/repos","events_url":"https://api.github.com/users/v0d1ch/events{/privacy}","received_events_url":"https://api.github.com/users/v0d1ch/received_events","type":"User","site_admin":false},"assignees":[{"login":"v0d1ch","id":1666357,"avatar_url":"https://avatars3.githubusercontent.com/u/1666357?v=4","gravatar_id":"","url":"https://api.github.com/users/v0d1ch","html_url":"https://github.com/v0d1ch","followers_url":"https://api.github.com/users/v0d1ch/followers","following_url":"https://api.github.com/users/v0d1ch/following{/other_user}","gists_url":"https://api.github.com/users/v0d1ch/gists{/gist_id}","starred_url":"https://api.github.com/users/v0d1ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v0d1ch/subscriptions","organizations_url":"https://api.github.com/users/v0d1ch/orgs","repos_url":"https://api.github.com/users/v0d1ch/repos","events_url":"https://api.github.com/users/v0d1ch/events{/privacy}","received_events_url":"https://api.github.com/users/v0d1ch/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pva701","id":7355273,"avatar_url":"https://avatars1.githubusercontent.com/u/7355273?v=4","gravatar_id":"","url":"https://api.github.com/users/pva701","html_url":"https://github.com/pva701","followers_url":"https://api.github.com/users/pva701/followers","following_url":"https://api.github.com/users/pva701/following{/other_user}","gists_url":"https://api.github.com/users/pva701/gists{/gist_id}","starred_url":"https://api.github.com/users/pva701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pva701/subscriptions","organizations_url":"https://api.github.com/users/pva701/orgs","repos_url":"https://api.github.com/users/pva701/repos","events_url":"https://api.github.com/users/pva701/events{/privacy}","received_events_url":"https://api.github.com/users/pva701/received_events","type":"User","site_admin":false},{"login":"rockbmb","id":16455833,"avatar_url":"https://avatars0.githubusercontent.com/u/16455833?v=4","gravatar_id":"","url":"https://api.github.com/users/rockbmb","html_url":"https://github.com/rockbmb","followers_url":"https://api.github.com/users/rockbmb/followers","following_url":"https://api.github.com/users/rockbmb/following{/other_user}","gists_url":"https://api.github.com/users/rockbmb/gists{/gist_id}","starred_url":"https://api.github.com/users/rockbmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockbmb/subscriptions","organizations_url":"https://api.github.com/users/rockbmb/orgs","repos_url":"https://api.github.com/users/rockbmb/repos","events_url":"https://api.github.com/users/rockbmb/events{/privacy}","received_events_url":"https://api.github.com/users/rockbmb/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2265/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/347d098743c62fb8d4db7a7733ab857ee934379b","head":{"label":"input-output-hk:v0d1ch/CSL-1818_Reject_transaction_if_script_version_is_not_adopted_one","ref":"v0d1ch/CSL-1818_Reject_transaction_if_script_version_is_not_adopted_one","sha":"347d098743c62fb8d4db7a7733ab857ee934379b","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-02-07T13:38:49Z","pushed_at":"2018-02-07T15:44:04Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":84692,"stargazers_count":1933,"watchers_count":1933,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":271,"open_issues":115,"watchers":1933,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"1c9c82d87d5d55dd4a5fb7c8f59a26d422c60a7b","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-02-07T13:38:49Z","pushed_at":"2018-02-07T15:44:04Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":84692,"stargazers_count":1933,"watchers_count":1933,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":271,"open_issues":115,"watchers":1933,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/2265"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2265"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2265/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2265/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/347d098743c62fb8d4db7a7733ab857ee934379b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"neongreen"}}