{"action":"created","issue":{"url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/246","repository_url":"https://api.github.com/repos/lionelbarrow/braintree-go","labels_url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/246/comments","events_url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/246/events","html_url":"https://github.com/lionelbarrow/braintree-go/pull/246","id":339096846,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODY2ODU2","number":246,"title":"Add SearchPage to TransactionGateway and SubscriptionGateway","user":{"login":"leighmcculloch","id":351529,"node_id":"MDQ6VXNlcjM1MTUyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/351529?v=4","gravatar_id":"","url":"https://api.github.com/users/leighmcculloch","html_url":"https://github.com/leighmcculloch","followers_url":"https://api.github.com/users/leighmcculloch/followers","following_url":"https://api.github.com/users/leighmcculloch/following{/other_user}","gists_url":"https://api.github.com/users/leighmcculloch/gists{/gist_id}","starred_url":"https://api.github.com/users/leighmcculloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighmcculloch/subscriptions","organizations_url":"https://api.github.com/users/leighmcculloch/orgs","repos_url":"https://api.github.com/users/leighmcculloch/repos","events_url":"https://api.github.com/users/leighmcculloch/events{/privacy}","received_events_url":"https://api.github.com/users/leighmcculloch/received_events","type":"User","site_admin":false},"labels":[{"id":39414506,"node_id":"MDU6TGFiZWwzOTQxNDUwNg==","url":"https://api.github.com/repos/lionelbarrow/braintree-go/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/lionelbarrow/braintree-go/milestones/11","html_url":"https://github.com/lionelbarrow/braintree-go/milestone/11","labels_url":"https://api.github.com/repos/lionelbarrow/braintree-go/milestones/11/labels","id":3406948,"node_id":"MDk6TWlsZXN0b25lMzQwNjk0OA==","number":11,"title":"v0.20.0","description":null,"creator":{"login":"leighmcculloch","id":351529,"node_id":"MDQ6VXNlcjM1MTUyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/351529?v=4","gravatar_id":"","url":"https://api.github.com/users/leighmcculloch","html_url":"https://github.com/leighmcculloch","followers_url":"https://api.github.com/users/leighmcculloch/followers","following_url":"https://api.github.com/users/leighmcculloch/following{/other_user}","gists_url":"https://api.github.com/users/leighmcculloch/gists{/gist_id}","starred_url":"https://api.github.com/users/leighmcculloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighmcculloch/subscriptions","organizations_url":"https://api.github.com/users/leighmcculloch/orgs","repos_url":"https://api.github.com/users/leighmcculloch/repos","events_url":"https://api.github.com/users/leighmcculloch/events{/privacy}","received_events_url":"https://api.github.com/users/leighmcculloch/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2018-06-07T06:43:54Z","updated_at":"2018-07-06T23:51:01Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-07-06T23:33:57Z","updated_at":"2018-07-06T23:57:03Z","closed_at":"2018-07-06T23:51:01Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/lionelbarrow/braintree-go/pulls/246","html_url":"https://github.com/lionelbarrow/braintree-go/pull/246","diff_url":"https://github.com/lionelbarrow/braintree-go/pull/246.diff","patch_url":"https://github.com/lionelbarrow/braintree-go/pull/246.patch"},"body":"What\r\n===\r\nAdd `SearchPage` to `TransactionGatewag` and `SubscriptionGateway` that\r\ncan be used to page through search results returned by `SearchIDs`.\r\nDeprecate other search functions, `Search` and `SearchNext`.\r\n\r\nWhy\r\n===\r\nThe existing pagination pattern of using the `Search` and `SearchNext`\r\nfunctions are not simple to program with, and they limit access to the\r\nsearch space and assume the developer will want to search sequentially\r\nthrough the pages.\r\n\r\nThe complexity with using the functions primarily comes from the fact\r\nthat the developer gets paged results from two different functions. This\r\nmeans the developer cannot put those functions merely in a for loop and\r\niterate. They must call one first, deal with those results, then loop on\r\nthe second function. It is less intuitive to write code this way, and\r\nmuch easier to think about if we get the IDs first, then just iterate\r\nover them in pages."},"comment":{"url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/comments/403172816","html_url":"https://github.com/lionelbarrow/braintree-go/pull/246#issuecomment-403172816","issue_url":"https://api.github.com/repos/lionelbarrow/braintree-go/issues/246","id":403172816,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzE3MjgxNg==","user":{"login":"leighmcculloch","id":351529,"node_id":"MDQ6VXNlcjM1MTUyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/351529?v=4","gravatar_id":"","url":"https://api.github.com/users/leighmcculloch","html_url":"https://github.com/leighmcculloch","followers_url":"https://api.github.com/users/leighmcculloch/followers","following_url":"https://api.github.com/users/leighmcculloch/following{/other_user}","gists_url":"https://api.github.com/users/leighmcculloch/gists{/gist_id}","starred_url":"https://api.github.com/users/leighmcculloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighmcculloch/subscriptions","organizations_url":"https://api.github.com/users/leighmcculloch/orgs","repos_url":"https://api.github.com/users/leighmcculloch/repos","events_url":"https://api.github.com/users/leighmcculloch/events{/privacy}","received_events_url":"https://api.github.com/users/leighmcculloch/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T23:57:02Z","updated_at":"2018-07-06T23:57:02Z","author_association":"COLLABORATOR","body":"I accidentally merged this to master, and immediately removed the commit from `master`. For some reason GitHub isn't letting me reopen this PR though."}}
{"actor":{"display_login":"leighmcculloch"}}