{"action":"created","comment":{"url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/comments/230677151","pull_request_review_id":171465786,"id":230677151,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDY3NzE1MQ==","diff_hunk":"@@ -839,8 +844,25 @@ public StructuredContentField(\n \n \t\tpublic String getDDMFormFieldDataType() {\n \t\t\ttry {\n-\t\t\t\treturn _ddmStructure.getFieldDataType(\n+\t\t\t\tString dataType = _ddmStructure.getFieldDataType(\n \t\t\t\t\t_ddmFormFieldValue.getName());\n+\n+\t\t\t\tString displayDataType = dataType;\n+\n+\t\t\t\tif (Objects.equals(dataType, \"document-library\")) {\n+\t\t\t\t\tdisplayDataType = \"document\";\n+\t\t\t\t}\n+\t\t\t\telse if (Objects.equals(dataType, \"journal-article\")) {","path":"modules/apps/headless-apio/structured-content/structured-content-apio-impl/src/main/java/com/liferay/structured/content/apio/internal/architect/resource/StructuredContentNestedCollectionResource.java","position":39,"original_position":39,"commit_id":"78cdf8e7d77a6c747c2677f662f158a008ff7ded","original_commit_id":"78cdf8e7d77a6c747c2677f662f158a008ff7ded","user":{"login":"ruben-pulido","id":17814626,"node_id":"MDQ6VXNlcjE3ODE0NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17814626?v=4","gravatar_id":"","url":"https://api.github.com/users/ruben-pulido","html_url":"https://github.com/ruben-pulido","followers_url":"https://api.github.com/users/ruben-pulido/followers","following_url":"https://api.github.com/users/ruben-pulido/following{/other_user}","gists_url":"https://api.github.com/users/ruben-pulido/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-pulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-pulido/subscriptions","organizations_url":"https://api.github.com/users/ruben-pulido/orgs","repos_url":"https://api.github.com/users/ruben-pulido/repos","events_url":"https://api.github.com/users/ruben-pulido/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-pulido/received_events","type":"User","site_admin":false},"body":"Not needed in this case. Changed! ","created_at":"2018-11-05T09:19:47Z","updated_at":"2018-11-05T09:19:47Z","html_url":"https://github.com/nhpatt/liferay-portal/pull/63#discussion_r230677151","pull_request_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/comments/230677151"},"html":{"href":"https://github.com/nhpatt/liferay-portal/pull/63#discussion_r230677151"},"pull_request":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63"}},"in_reply_to_id":229968051},"pull_request":{"url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63","id":227488061,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDg4MDYx","html_url":"https://github.com/nhpatt/liferay-portal/pull/63","diff_url":"https://github.com/nhpatt/liferay-portal/pull/63.diff","patch_url":"https://github.com/nhpatt/liferay-portal/pull/63.patch","issue_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/63","number":63,"state":"closed","locked":false,"title":"LPS-84736 Client tests for input control","user":{"login":"ruben-pulido","id":17814626,"node_id":"MDQ6VXNlcjE3ODE0NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17814626?v=4","gravatar_id":"","url":"https://api.github.com/users/ruben-pulido","html_url":"https://github.com/ruben-pulido","followers_url":"https://api.github.com/users/ruben-pulido/followers","following_url":"https://api.github.com/users/ruben-pulido/following{/other_user}","gists_url":"https://api.github.com/users/ruben-pulido/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-pulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-pulido/subscriptions","organizations_url":"https://api.github.com/users/ruben-pulido/orgs","repos_url":"https://api.github.com/users/ruben-pulido/repos","events_url":"https://api.github.com/users/ruben-pulido/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-pulido/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-11-01T01:34:00Z","updated_at":"2018-11-05T09:19:47Z","closed_at":"2018-11-01T08:29:07Z","merged_at":"2018-11-01T08:29:07Z","merge_commit_sha":"4ecbdff9fd5e61e1dca0edca035e19f3ad2804f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63/commits","review_comments_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63/comments","review_comment_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/63/comments","statuses_url":"https://api.github.com/repos/nhpatt/liferay-portal/statuses/78cdf8e7d77a6c747c2677f662f158a008ff7ded","head":{"label":"ruben-pulido:LPS-84736.2","ref":"LPS-84736.2","sha":"78cdf8e7d77a6c747c2677f662f158a008ff7ded","user":{"login":"ruben-pulido","id":17814626,"node_id":"MDQ6VXNlcjE3ODE0NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17814626?v=4","gravatar_id":"","url":"https://api.github.com/users/ruben-pulido","html_url":"https://github.com/ruben-pulido","followers_url":"https://api.github.com/users/ruben-pulido/followers","following_url":"https://api.github.com/users/ruben-pulido/following{/other_user}","gists_url":"https://api.github.com/users/ruben-pulido/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-pulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-pulido/subscriptions","organizations_url":"https://api.github.com/users/ruben-pulido/orgs","repos_url":"https://api.github.com/users/ruben-pulido/repos","events_url":"https://api.github.com/users/ruben-pulido/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-pulido/received_events","type":"User","site_admin":false},"repo":{"id":141705550,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MDU1NTA=","name":"liferay-portal","full_name":"ruben-pulido/liferay-portal","private":false,"owner":{"login":"ruben-pulido","id":17814626,"node_id":"MDQ6VXNlcjE3ODE0NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17814626?v=4","gravatar_id":"","url":"https://api.github.com/users/ruben-pulido","html_url":"https://github.com/ruben-pulido","followers_url":"https://api.github.com/users/ruben-pulido/followers","following_url":"https://api.github.com/users/ruben-pulido/following{/other_user}","gists_url":"https://api.github.com/users/ruben-pulido/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-pulido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-pulido/subscriptions","organizations_url":"https://api.github.com/users/ruben-pulido/orgs","repos_url":"https://api.github.com/users/ruben-pulido/repos","events_url":"https://api.github.com/users/ruben-pulido/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-pulido/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ruben-pulido/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/ruben-pulido/liferay-portal","forks_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/forks","keys_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/teams","hooks_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/events","assignees_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/tags","blobs_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/subscription","commits_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/merges","archive_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/downloads","issues_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ruben-pulido/liferay-portal/deployments","created_at":"2018-07-20T11:45:28Z","updated_at":"2018-11-04T17:24:56Z","pushed_at":"2018-11-05T09:16:34Z","git_url":"git://github.com/ruben-pulido/liferay-portal.git","ssh_url":"git@github.com:ruben-pulido/liferay-portal.git","clone_url":"https://github.com/ruben-pulido/liferay-portal.git","svn_url":"https://github.com/ruben-pulido/liferay-portal","homepage":"http://liferay.com","size":12825813,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"nhpatt:LPS-84736","ref":"LPS-84736","sha":"6a6d1b7557de3a5b6d7b63eae6cf8ee40d0c35a0","user":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"repo":{"id":37995608,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk5NTYwOA==","name":"liferay-portal","full_name":"nhpatt/liferay-portal","private":false,"owner":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nhpatt/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/nhpatt/liferay-portal","forks_url":"https://api.github.com/repos/nhpatt/liferay-portal/forks","keys_url":"https://api.github.com/repos/nhpatt/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhpatt/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhpatt/liferay-portal/teams","hooks_url":"https://api.github.com/repos/nhpatt/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/nhpatt/liferay-portal/events","assignees_url":"https://api.github.com/repos/nhpatt/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/nhpatt/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/nhpatt/liferay-portal/tags","blobs_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhpatt/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/nhpatt/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/nhpatt/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/nhpatt/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/nhpatt/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/nhpatt/liferay-portal/subscription","commits_url":"https://api.github.com/repos/nhpatt/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhpatt/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhpatt/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/nhpatt/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhpatt/liferay-portal/merges","archive_url":"https://api.github.com/repos/nhpatt/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhpatt/liferay-portal/downloads","issues_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/nhpatt/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/nhpatt/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhpatt/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/nhpatt/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/nhpatt/liferay-portal/deployments","created_at":"2015-06-24T16:10:32Z","updated_at":"2018-11-02T10:07:25Z","pushed_at":"2018-11-05T09:16:40Z","git_url":"git://github.com/nhpatt/liferay-portal.git","ssh_url":"git@github.com:nhpatt/liferay-portal.git","clone_url":"https://github.com/nhpatt/liferay-portal.git","svn_url":"https://github.com/nhpatt/liferay-portal","homepage":"http://liferay.com","size":12469313,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63"},"html":{"href":"https://github.com/nhpatt/liferay-portal/pull/63"},"issue":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/issues/63"},"comments":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/nhpatt/liferay-portal/statuses/78cdf8e7d77a6c747c2677f662f158a008ff7ded"}},"author_association":"NONE"}}
{"actor":{"display_login":"ruben-pulido"}}