{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments/209234003","pull_request_review_id":145209295,"id":209234003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIzNDAwMw==","diff_hunk":"@@ -59,27 +60,25 @@ func ValidateConfig(cfg *configpb.MigrationConfig) error {\n }\n \n func buildLogLeaf(logPrefix string, index int64, entry *ct.LeafEntry) (*trillian.LogLeaf, error) {\n-\tlogEntry, err := ct.LogEntryFromLeaf(index, entry)\n-\tif x509.IsFatal(err) {\n-\t\treturn nil, fmt.Errorf(\"failed to build LogEntry[%d]: %v\", index, err)\n+\trle, err := ct.RawLogEntryFromLeaf(entry, index)\n+\tif err != nil {\n+\t\treturn nil, err\n \t}\n-\t// TODO(pavelkalinnikov): Verify the cert chain.\n \n-\tvar cert ct.ASN1Cert\n-\tisPrecert := false\n-\tswitch {\n-\tcase logEntry.X509Cert != nil:\n-\t\tcert = ct.ASN1Cert{Data: logEntry.X509Cert.Raw}\n-\tcase logEntry.Precert != nil:\n-\t\tisPrecert = true\n-\t\tcert = logEntry.Precert.Submitted\n-\tdefault:\n-\t\treturn nil, fmt.Errorf(\"entry at %d is neither cert nor pre-cert\", index)\n+\t// Don't return on x509 parsing errors because we want to migrate this log\n+\t// entry as is. But log the error so that it can be flagged by monitoring.\n+\tif _, err = rle.ToLogEntry(); x509.IsFatal(err) {\n+\t\tglog.Errorf(\"%s: index=%d: x509 fatal error: %v\", logPrefix, err)","path":"trillian/migrillian/core/util.go","position":43,"original_position":43,"commit_id":"84a7fea0f78144109e91c768552062ab835dfc0d","original_commit_id":"84a7fea0f78144109e91c768552062ab835dfc0d","user":{"login":"daviddrysdale","id":457208,"node_id":"MDQ6VXNlcjQ1NzIwOA==","avatar_url":"https://avatars3.githubusercontent.com/u/457208?v=4","gravatar_id":"","url":"https://api.github.com/users/daviddrysdale","html_url":"https://github.com/daviddrysdale","followers_url":"https://api.github.com/users/daviddrysdale/followers","following_url":"https://api.github.com/users/daviddrysdale/following{/other_user}","gists_url":"https://api.github.com/users/daviddrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/daviddrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviddrysdale/subscriptions","organizations_url":"https://api.github.com/users/daviddrysdale/orgs","repos_url":"https://api.github.com/users/daviddrysdale/repos","events_url":"https://api.github.com/users/daviddrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/daviddrysdale/received_events","type":"User","site_admin":false},"body":"Wrong number of arguments (x2)","created_at":"2018-08-10T11:53:40Z","updated_at":"2018-08-10T11:57:10Z","html_url":"https://github.com/google/certificate-transparency-go/pull/320#discussion_r209234003","pull_request_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments/209234003"},"html":{"href":"https://github.com/google/certificate-transparency-go/pull/320#discussion_r209234003"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320","id":207570341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTcwMzQx","html_url":"https://github.com/google/certificate-transparency-go/pull/320","diff_url":"https://github.com/google/certificate-transparency-go/pull/320.diff","patch_url":"https://github.com/google/certificate-transparency-go/pull/320.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/320","number":320,"state":"open","locked":false,"title":"[Migrillian] Make admission control laxer","user":{"login":"pavelkalinnikov","id":3757441,"node_id":"MDQ6VXNlcjM3NTc0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"body":"Different logs use different x509 parsers, so when Migrillian populates a mirror\r\nit might encounter a certificate/chain that it can't parse. This change makes\r\nadmission control in this case laxer: Migrillian only requires that the TLS\r\nencoding of the entry complies with RFC6962.","created_at":"2018-08-10T10:26:21Z","updated_at":"2018-08-10T11:57:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abc0e5a3eaf504d0c9f26142164dbb1e7443b404","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":602120732,"node_id":"MDU6TGFiZWw2MDIxMjA3MzI=","url":"https://api.github.com/repos/google/certificate-transparency-go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/320/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-go/statuses/84a7fea0f78144109e91c768552062ab835dfc0d","head":{"label":"pavelkalinnikov:migrillian_lax_admission","ref":"migrillian_lax_admission","sha":"84a7fea0f78144109e91c768552062ab835dfc0d","user":{"login":"pavelkalinnikov","id":3757441,"node_id":"MDQ6VXNlcjM3NTc0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"repo":{"id":112630682,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2MzA2ODI=","name":"certificate-transparency-go","full_name":"pavelkalinnikov/certificate-transparency-go","owner":{"login":"pavelkalinnikov","id":3757441,"node_id":"MDQ6VXNlcjM3NTc0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavelkalinnikov/certificate-transparency-go","description":"Auditing for TLS certificates, Go code. ","fork":true,"url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go","forks_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/forks","keys_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/teams","hooks_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/hooks","issue_events_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/issues/events{/number}","events_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/events","assignees_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/assignees{/user}","branches_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/branches{/branch}","tags_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/tags","blobs_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/statuses/{sha}","languages_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/languages","stargazers_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/stargazers","contributors_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/contributors","subscribers_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/subscribers","subscription_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/subscription","commits_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/contents/{+path}","compare_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/merges","archive_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/downloads","issues_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/issues{/number}","pulls_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/pulls{/number}","milestones_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/milestones{/number}","notifications_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/labels{/name}","releases_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/releases{/id}","deployments_url":"https://api.github.com/repos/pavelkalinnikov/certificate-transparency-go/deployments","created_at":"2017-11-30T15:57:17Z","updated_at":"2018-08-10T08:49:26Z","pushed_at":"2018-08-10T10:22:16Z","git_url":"git://github.com/pavelkalinnikov/certificate-transparency-go.git","ssh_url":"git@github.com:pavelkalinnikov/certificate-transparency-go.git","clone_url":"https://github.com/pavelkalinnikov/certificate-transparency-go.git","svn_url":"https://github.com/pavelkalinnikov/certificate-transparency-go","homepage":"http://www.certificate-transparency.org/","size":7226,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"feee9a4b7602dba8fab9f680c57fd13cf6305727","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":90636971,"node_id":"MDEwOlJlcG9zaXRvcnk5MDYzNjk3MQ==","name":"certificate-transparency-go","full_name":"google/certificate-transparency-go","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency-go","description":"Auditing for TLS certificates, Go code. ","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-go","forks_url":"https://api.github.com/repos/google/certificate-transparency-go/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-go/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-go/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-go/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-go/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-go/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-go/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-go/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-go/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-go/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-go/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-go/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-go/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-go/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-go/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-go/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-go/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-go/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-go/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-go/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-go/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency-go/deployments","created_at":"2017-05-08T14:22:46Z","updated_at":"2018-08-10T09:48:35Z","pushed_at":"2018-08-10T10:26:22Z","git_url":"git://github.com/google/certificate-transparency-go.git","ssh_url":"git@github.com:google/certificate-transparency-go.git","clone_url":"https://github.com/google/certificate-transparency-go.git","svn_url":"https://github.com/google/certificate-transparency-go","homepage":"http://www.certificate-transparency.org/","size":7230,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":8,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320"},"html":{"href":"https://github.com/google/certificate-transparency-go/pull/320"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-go/issues/320"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-go/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-go/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-go/statuses/84a7fea0f78144109e91c768552062ab835dfc0d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"daviddrysdale"}}