{"action":"created","comment":{"url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/comments/220724803","pull_request_review_id":159200255,"id":220724803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDcyNDgwMw==","diff_hunk":"@@ -215,13 +274,19 @@ message VniRange {\n  * remote_mechanism_type - remote mechanism seleted by NSM2 from the options presented by\n  *                         NSM1\n  * remote_mechanism_parameters - parameters selected by NSM2 for the remote mechanism\n+ * labels - key value pairs to communicate arbitrary context about the reply\n  */\n message RemoteConnectionReply {\n-    required string request_id = 1;\n-    required bool accepted = 2;\n-    optional string admission_error = 3;\n-    required RemoteMechanismType remote_mechanism_type = 4;\n-    required RemoteMechanismParameters remote_mechanism_parameters= 5;\n+    string request_id = 1;\n+    bool accepted = 2;\n+    RemoteMechanismType remote_mechanism_type = 4;\n+    RemoteMechanismParameters remote_mechanism_parameters= 5;\n+    ConnectionContext connection_context = 6;\n+\n+    /* fields below are optional */\n+\n+    map<string,string> labels = 7;\n+    string admission_error = 3;","path":"docs/nsm_api.md","position":154,"original_position":154,"commit_id":"da6eac9a4f3431f0b2e1a389b0767738f8704345","original_commit_id":"da6eac9a4f3431f0b2e1a389b0767738f8704345","user":{"login":"sbezverk","id":16273360,"node_id":"MDQ6VXNlcjE2MjczMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"@edwarnicke then it is nil","created_at":"2018-09-26T21:10:15Z","updated_at":"2018-09-26T21:10:15Z","html_url":"https://github.com/ligato/networkservicemesh/pull/299#discussion_r220724803","pull_request_url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/comments/220724803"},"html":{"href":"https://github.com/ligato/networkservicemesh/pull/299#discussion_r220724803"},"pull_request":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299"}},"in_reply_to_id":220722986},"pull_request":{"url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299","id":217685499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Njg1NDk5","html_url":"https://github.com/ligato/networkservicemesh/pull/299","diff_url":"https://github.com/ligato/networkservicemesh/pull/299.diff","patch_url":"https://github.com/ligato/networkservicemesh/pull/299.patch","issue_url":"https://api.github.com/repos/ligato/networkservicemesh/issues/299","number":299,"state":"open","locked":false,"title":"WIP: Updated NSM2NSM API with ConnectionContext","user":{"login":"edwarnicke","id":1455208,"node_id":"MDQ6VXNlcjE0NTUyMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1455208?v=4","gravatar_id":"","url":"https://api.github.com/users/edwarnicke","html_url":"https://github.com/edwarnicke","followers_url":"https://api.github.com/users/edwarnicke/followers","following_url":"https://api.github.com/users/edwarnicke/following{/other_user}","gists_url":"https://api.github.com/users/edwarnicke/gists{/gist_id}","starred_url":"https://api.github.com/users/edwarnicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwarnicke/subscriptions","organizations_url":"https://api.github.com/users/edwarnicke/orgs","repos_url":"https://api.github.com/users/edwarnicke/repos","events_url":"https://api.github.com/users/edwarnicke/events{/privacy}","received_events_url":"https://api.github.com/users/edwarnicke/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-09-24T14:56:04Z","updated_at":"2018-09-26T21:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7072f1adf5f7077c6a27362a20c2df5fdfa1396b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299/commits","review_comments_url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299/comments","review_comment_url":"https://api.github.com/repos/ligato/networkservicemesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligato/networkservicemesh/issues/299/comments","statuses_url":"https://api.github.com/repos/ligato/networkservicemesh/statuses/da6eac9a4f3431f0b2e1a389b0767738f8704345","head":{"label":"edwarnicke:api_doc","ref":"api_doc","sha":"da6eac9a4f3431f0b2e1a389b0767738f8704345","user":{"login":"edwarnicke","id":1455208,"node_id":"MDQ6VXNlcjE0NTUyMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1455208?v=4","gravatar_id":"","url":"https://api.github.com/users/edwarnicke","html_url":"https://github.com/edwarnicke","followers_url":"https://api.github.com/users/edwarnicke/followers","following_url":"https://api.github.com/users/edwarnicke/following{/other_user}","gists_url":"https://api.github.com/users/edwarnicke/gists{/gist_id}","starred_url":"https://api.github.com/users/edwarnicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwarnicke/subscriptions","organizations_url":"https://api.github.com/users/edwarnicke/orgs","repos_url":"https://api.github.com/users/edwarnicke/repos","events_url":"https://api.github.com/users/edwarnicke/events{/privacy}","received_events_url":"https://api.github.com/users/edwarnicke/received_events","type":"User","site_admin":false},"repo":{"id":127943895,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5NDM4OTU=","name":"networkservicemesh","full_name":"edwarnicke/networkservicemesh","private":false,"owner":{"login":"edwarnicke","id":1455208,"node_id":"MDQ6VXNlcjE0NTUyMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1455208?v=4","gravatar_id":"","url":"https://api.github.com/users/edwarnicke","html_url":"https://github.com/edwarnicke","followers_url":"https://api.github.com/users/edwarnicke/followers","following_url":"https://api.github.com/users/edwarnicke/following{/other_user}","gists_url":"https://api.github.com/users/edwarnicke/gists{/gist_id}","starred_url":"https://api.github.com/users/edwarnicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwarnicke/subscriptions","organizations_url":"https://api.github.com/users/edwarnicke/orgs","repos_url":"https://api.github.com/users/edwarnicke/repos","events_url":"https://api.github.com/users/edwarnicke/events{/privacy}","received_events_url":"https://api.github.com/users/edwarnicke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edwarnicke/networkservicemesh","description":null,"fork":true,"url":"https://api.github.com/repos/edwarnicke/networkservicemesh","forks_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/forks","keys_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/teams","hooks_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/hooks","issue_events_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/issues/events{/number}","events_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/events","assignees_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/assignees{/user}","branches_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/branches{/branch}","tags_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/tags","blobs_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/statuses/{sha}","languages_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/languages","stargazers_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/stargazers","contributors_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/contributors","subscribers_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/subscribers","subscription_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/subscription","commits_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/contents/{+path}","compare_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/merges","archive_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/downloads","issues_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/issues{/number}","pulls_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/pulls{/number}","milestones_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/milestones{/number}","notifications_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/labels{/name}","releases_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/releases{/id}","deployments_url":"https://api.github.com/repos/edwarnicke/networkservicemesh/deployments","created_at":"2018-04-03T17:27:39Z","updated_at":"2018-09-26T14:40:32Z","pushed_at":"2018-09-26T20:35:00Z","git_url":"git://github.com/edwarnicke/networkservicemesh.git","ssh_url":"git@github.com:edwarnicke/networkservicemesh.git","clone_url":"https://github.com/edwarnicke/networkservicemesh.git","svn_url":"https://github.com/edwarnicke/networkservicemesh","homepage":null,"size":14023,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ligato:master","ref":"master","sha":"bb62967e6806f1c4b22e79420ebc2ff6a0519a22","user":{"login":"ligato","id":28989152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTg5MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"repo":{"id":127937836,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5Mzc4MzY=","name":"networkservicemesh","full_name":"ligato/networkservicemesh","private":false,"owner":{"login":"ligato","id":28989152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTg5MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ligato/networkservicemesh","description":"An attempt to re-imagine NFV in a Cloudnative way","fork":false,"url":"https://api.github.com/repos/ligato/networkservicemesh","forks_url":"https://api.github.com/repos/ligato/networkservicemesh/forks","keys_url":"https://api.github.com/repos/ligato/networkservicemesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligato/networkservicemesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligato/networkservicemesh/teams","hooks_url":"https://api.github.com/repos/ligato/networkservicemesh/hooks","issue_events_url":"https://api.github.com/repos/ligato/networkservicemesh/issues/events{/number}","events_url":"https://api.github.com/repos/ligato/networkservicemesh/events","assignees_url":"https://api.github.com/repos/ligato/networkservicemesh/assignees{/user}","branches_url":"https://api.github.com/repos/ligato/networkservicemesh/branches{/branch}","tags_url":"https://api.github.com/repos/ligato/networkservicemesh/tags","blobs_url":"https://api.github.com/repos/ligato/networkservicemesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligato/networkservicemesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligato/networkservicemesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligato/networkservicemesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligato/networkservicemesh/statuses/{sha}","languages_url":"https://api.github.com/repos/ligato/networkservicemesh/languages","stargazers_url":"https://api.github.com/repos/ligato/networkservicemesh/stargazers","contributors_url":"https://api.github.com/repos/ligato/networkservicemesh/contributors","subscribers_url":"https://api.github.com/repos/ligato/networkservicemesh/subscribers","subscription_url":"https://api.github.com/repos/ligato/networkservicemesh/subscription","commits_url":"https://api.github.com/repos/ligato/networkservicemesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligato/networkservicemesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligato/networkservicemesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligato/networkservicemesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligato/networkservicemesh/contents/{+path}","compare_url":"https://api.github.com/repos/ligato/networkservicemesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligato/networkservicemesh/merges","archive_url":"https://api.github.com/repos/ligato/networkservicemesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligato/networkservicemesh/downloads","issues_url":"https://api.github.com/repos/ligato/networkservicemesh/issues{/number}","pulls_url":"https://api.github.com/repos/ligato/networkservicemesh/pulls{/number}","milestones_url":"https://api.github.com/repos/ligato/networkservicemesh/milestones{/number}","notifications_url":"https://api.github.com/repos/ligato/networkservicemesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligato/networkservicemesh/labels{/name}","releases_url":"https://api.github.com/repos/ligato/networkservicemesh/releases{/id}","deployments_url":"https://api.github.com/repos/ligato/networkservicemesh/deployments","created_at":"2018-04-03T16:36:32Z","updated_at":"2018-09-26T15:29:44Z","pushed_at":"2018-09-26T20:35:27Z","git_url":"git://github.com/ligato/networkservicemesh.git","ssh_url":"git@github.com:ligato/networkservicemesh.git","clone_url":"https://github.com/ligato/networkservicemesh.git","svn_url":"https://github.com/ligato/networkservicemesh","homepage":"","size":9526,"stargazers_count":29,"watchers_count":29,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":29,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299"},"html":{"href":"https://github.com/ligato/networkservicemesh/pull/299"},"issue":{"href":"https://api.github.com/repos/ligato/networkservicemesh/issues/299"},"comments":{"href":"https://api.github.com/repos/ligato/networkservicemesh/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligato/networkservicemesh/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/ligato/networkservicemesh/statuses/da6eac9a4f3431f0b2e1a389b0767738f8704345"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sbezverk"}}