{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments/183658732","pull_request_review_id":114695825,"id":183658732,"diff_hunk":"@@ -1009,20 +1019,25 @@ Daemon::ApiImpl::RequestProcessor::setCollectionSecretGetAuthenticationCode(\n \n         // perform the user input flow required to get the input key data which will be used\n         // to unlock this collection.\n-        InteractionParameters ikdRequest;\n-        ikdRequest.setApplicationId(callerApplicationId);\n-        ikdRequest.setPluginName(secret.identifier().storagePluginName());\n-        ikdRequest.setCollectionName(secret.identifier().collectionName());\n-        ikdRequest.setSecretName(secret.identifier().name());\n-        ikdRequest.setOperation(InteractionParameters::StoreSecret);\n-        ikdRequest.setInputType(InteractionParameters::AlphaNumericInput);\n-        ikdRequest.setEchoMode(InteractionParameters::PasswordEchoOnEdit);\n-        ikdRequest.setPromptText(tr(\"Enter the passphrase to unlock the collection %1 in order to store secret %2\")\n-                                 .arg(secret.identifier().collectionName(), secret.identifier().name()));\n+        InteractionParameters promptParams;\n+        promptParams.setApplicationId(callerApplicationId);\n+        promptParams.setPluginName(secret.identifier().storagePluginName());\n+        promptParams.setCollectionName(secret.identifier().collectionName());\n+        promptParams.setSecretName(secret.identifier().name());\n+        promptParams.setOperation(InteractionParameters::StoreSecret);\n+        promptParams.setInputType(InteractionParameters::AlphaNumericInput);\n+        promptParams.setEchoMode(InteractionParameters::PasswordEchoOnEdit);\n+        //: This will be displayed to the user, prompting them to enter the passphrase to unlock the collection in which a new secret will be stored. %1 is the application name, %2 is the  secret name, %3 is the collection name, %4 is the plugin name.\n+        //% \"App %1 wants to store a new secret named %2 into collection %3 in plugin %4. Enter the passphrase to unlock the collection.\"","path":"daemon/SecretsImpl/secretsrequestprocessor.cpp","position":139,"original_position":139,"commit_id":"5b80556d17d9beb01ba28d885fa3baa7ca9ccb63","original_commit_id":"5b80556d17d9beb01ba28d885fa3baa7ca9ccb63","user":{"login":"jpetrell","id":2203667,"avatar_url":"https://avatars3.githubusercontent.com/u/2203667?v=4","gravatar_id":"","url":"https://api.github.com/users/jpetrell","html_url":"https://github.com/jpetrell","followers_url":"https://api.github.com/users/jpetrell/followers","following_url":"https://api.github.com/users/jpetrell/following{/other_user}","gists_url":"https://api.github.com/users/jpetrell/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetrell/subscriptions","organizations_url":"https://api.github.com/users/jpetrell/orgs","repos_url":"https://api.github.com/users/jpetrell/repos","events_url":"https://api.github.com/users/jpetrell/events{/privacy}","received_events_url":"https://api.github.com/users/jpetrell/received_events","type":"User","site_admin":false},"body":"Yeah let's postpone the icon support.","created_at":"2018-04-24T09:13:12Z","updated_at":"2018-04-24T09:13:12Z","html_url":"https://github.com/sailfishos/sailfish-secrets/pull/74#discussion_r183658732","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments/183658732"},"html":{"href":"https://github.com/sailfishos/sailfish-secrets/pull/74#discussion_r183658732"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74"}},"in_reply_to_id":183351322},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74","id":182964932,"html_url":"https://github.com/sailfishos/sailfish-secrets/pull/74","diff_url":"https://github.com/sailfishos/sailfish-secrets/pull/74.diff","patch_url":"https://github.com/sailfishos/sailfish-secrets/pull/74.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/74","number":74,"state":"open","locked":false,"title":"[sailfish-secrets] Add string translation ids. Contributes to JB#36797","user":{"login":"chriadam","id":2569776,"avatar_url":"https://avatars1.githubusercontent.com/u/2569776?v=4","gravatar_id":"","url":"https://api.github.com/users/chriadam","html_url":"https://github.com/chriadam","followers_url":"https://api.github.com/users/chriadam/followers","following_url":"https://api.github.com/users/chriadam/following{/other_user}","gists_url":"https://api.github.com/users/chriadam/gists{/gist_id}","starred_url":"https://api.github.com/users/chriadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriadam/subscriptions","organizations_url":"https://api.github.com/users/chriadam/orgs","repos_url":"https://api.github.com/users/chriadam/repos","events_url":"https://api.github.com/users/chriadam/events{/privacy}","received_events_url":"https://api.github.com/users/chriadam/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-20T05:43:16Z","updated_at":"2018-04-24T09:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28f481c970546174100b838686569e896ff7d8d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/74/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/5b80556d17d9beb01ba28d885fa3baa7ca9ccb63","head":{"label":"sailfishos:translationids","ref":"translationids","sha":"5b80556d17d9beb01ba28d885fa3baa7ca9ccb63","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":109001458,"name":"sailfish-secrets","full_name":"sailfishos/sailfish-secrets","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-secrets","description":null,"fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-secrets","forks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/deployments","created_at":"2017-10-31T13:43:11Z","updated_at":"2018-04-24T02:01:34Z","pushed_at":"2018-04-24T08:08:15Z","git_url":"git://github.com/sailfishos/sailfish-secrets.git","ssh_url":"git@github.com:sailfishos/sailfish-secrets.git","clone_url":"https://github.com/sailfishos/sailfish-secrets.git","svn_url":"https://github.com/sailfishos/sailfish-secrets","homepage":null,"size":1695,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4,"open_issues":17,"watchers":14,"default_branch":"master"}},"base":{"label":"sailfishos:master","ref":"master","sha":"7e7aac93a103dca25a4ce3562310513f31369138","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":109001458,"name":"sailfish-secrets","full_name":"sailfishos/sailfish-secrets","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-secrets","description":null,"fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-secrets","forks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/deployments","created_at":"2017-10-31T13:43:11Z","updated_at":"2018-04-24T02:01:34Z","pushed_at":"2018-04-24T08:08:15Z","git_url":"git://github.com/sailfishos/sailfish-secrets.git","ssh_url":"git@github.com:sailfishos/sailfish-secrets.git","clone_url":"https://github.com/sailfishos/sailfish-secrets.git","svn_url":"https://github.com/sailfishos/sailfish-secrets","homepage":null,"size":1695,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74"},"html":{"href":"https://github.com/sailfishos/sailfish-secrets/pull/74"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/74"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/5b80556d17d9beb01ba28d885fa3baa7ca9ccb63"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jpetrell"}}