{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/172601617","pull_request_review_id":101646575,"id":172601617,"diff_hunk":"@@ -0,0 +1,32 @@\n+package coop.rchain.rholang.interpreter\n+\n+import monix.eval.Task\n+\n+import scala.collection.immutable.HashMap\n+\n+object Env {","path":"rholang/src/main/scala/coop/rchain/rholang/interpreter/Env.scala","position":7,"original_position":7,"commit_id":"adc8a72e2f2ea355fd4f39d940e8522fd7046279","original_commit_id":"da8fd63bb4654d470a3ca900cffbba7107b4a655","user":{"login":"guardbotmk3","id":33846152,"avatar_url":"https://avatars1.githubusercontent.com/u/33846152?v=4","gravatar_id":"","url":"https://api.github.com/users/guardbotmk3","html_url":"https://github.com/guardbotmk3","followers_url":"https://api.github.com/users/guardbotmk3/followers","following_url":"https://api.github.com/users/guardbotmk3/following{/other_user}","gists_url":"https://api.github.com/users/guardbotmk3/gists{/gist_id}","starred_url":"https://api.github.com/users/guardbotmk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardbotmk3/subscriptions","organizations_url":"https://api.github.com/users/guardbotmk3/orgs","repos_url":"https://api.github.com/users/guardbotmk3/repos","events_url":"https://api.github.com/users/guardbotmk3/events{/privacy}","received_events_url":"https://api.github.com/users/guardbotmk3/received_events","type":"User","site_admin":false},"body":"You've explained why, but not what the code actually does. I understand that you want an implicit. I don't see how that gets you from A to B. Why can you add a parameter to Env? Etc. This looks like magic to me, and I won't approve it until I understand it. Also, you're going to need to add comments to the code explaining what is going on.","created_at":"2018-03-06T17:46:08Z","updated_at":"2018-03-06T17:52:29Z","html_url":"https://github.com/rchain/rchain/pull/338#discussion_r172601617","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/338","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/172601617"},"html":{"href":"https://github.com/rchain/rchain/pull/338#discussion_r172601617"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/338"}},"in_reply_to_id":172321515},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/338","id":171738676,"html_url":"https://github.com/rchain/rchain/pull/338","diff_url":"https://github.com/rchain/rchain/pull/338.diff","patch_url":"https://github.com/rchain/rchain/pull/338.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/338","number":338,"state":"open","locked":false,"title":"dev-interpreter","user":{"login":"JosDenmark","id":24320813,"avatar_url":"https://avatars2.githubusercontent.com/u/24320813?v=4","gravatar_id":"","url":"https://api.github.com/users/JosDenmark","html_url":"https://github.com/JosDenmark","followers_url":"https://api.github.com/users/JosDenmark/followers","following_url":"https://api.github.com/users/JosDenmark/following{/other_user}","gists_url":"https://api.github.com/users/JosDenmark/gists{/gist_id}","starred_url":"https://api.github.com/users/JosDenmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosDenmark/subscriptions","organizations_url":"https://api.github.com/users/JosDenmark/orgs","repos_url":"https://api.github.com/users/JosDenmark/repos","events_url":"https://api.github.com/users/JosDenmark/events{/privacy}","received_events_url":"https://api.github.com/users/JosDenmark/received_events","type":"User","site_admin":false},"body":"Substitution and renaming functions for de Bruijn level indicies","created_at":"2018-02-27T17:56:07Z","updated_at":"2018-03-06T17:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8f075bef30cc1a8b0afed4b190af8ad532ce4eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/338/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/338/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/338/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/adc8a72e2f2ea355fd4f39d940e8522fd7046279","head":{"label":"rchain:dev-interpreter","ref":"dev-interpreter","sha":"adc8a72e2f2ea355fd4f39d940e8522fd7046279","user":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"name":"rchain","full_name":"rchain/rchain","owner":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-03-06T17:40:04Z","pushed_at":"2018-03-06T17:32:43Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":7056,"stargazers_count":186,"watchers_count":186,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":10,"watchers":186,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"e300ee47a5d87d8937f91ec0103a38406596861e","user":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"name":"rchain","full_name":"rchain/rchain","owner":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-03-06T17:40:04Z","pushed_at":"2018-03-06T17:32:43Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":7056,"stargazers_count":186,"watchers_count":186,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":10,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/338"},"html":{"href":"https://github.com/rchain/rchain/pull/338"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/338"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/adc8a72e2f2ea355fd4f39d940e8522fd7046279"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"guardbotmk3"}}