{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/214101822","pull_request_review_id":151084404,"id":214101822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDEwMTgyMg==","diff_hunk":"@@ -47,22 +47,75 @@ Command-line options\n ~~~~~~~~~~~~~~~~~~~~\n The node can optionally be started with the following command-line options:\n \n-* ``--base-directory``: The node working directory where all the files are kept (default: ``.``)\n+* ``--base-directory``, ``-b``: The node working directory where all the files are kept (default: ``.``)\n * ``--bootstrap-raft-cluster``: Bootstraps Raft cluster. The node forms a single node cluster (ignoring otherwise configured peer \n   addresses), acting as a seed for other nodes to join the cluster\n-* ``--config-file``: The path to the config file (default: ``node.conf``)                          \n-* ``--help``\n+* ``--clear-network-map-cache``, ``-c``: Clears local copy of network map, on node startup it will be restored from server or file system.\n+* ``--config-file``, ``-f``: The path to the config file. Defaults to ``node.conf``.\n+* ``--dev-mode``, ``-d``: Runs the node in developer mode. Unsafe in production. Defaults to true on MacOS and desktop versions of Windows. False otherwise.","path":"docs/source/running-a-node.rst","position":12,"original_position":12,"commit_id":"6f0b4414391392cd9270b8b4a573272fc3eadd1b","original_commit_id":"434536ee17d13630b4859e76b4c6b989e9a26a41","user":{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false},"body":"No I don't think that's true.\r\nIt's just a boolean. If it's specified via --devMode it uses that value first as that is in the `configOverrides`, then if it's specified in the `node.conf` it uses that from `appConfig`, and if it's not specified in either of those places, it gets the `smartDevMode` value based on the operating system in this [function](https://github.com/corda/corda/blob/7853cfe0034cc769358193f26afa3021c38a0554/node/src/main/kotlin/net/corda/node/services/config/ConfigUtilities.kt#L48).","created_at":"2018-08-30T16:43:33Z","updated_at":"2018-08-30T16:43:33Z","html_url":"https://github.com/corda/corda/pull/3872#discussion_r214101822","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/3872","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/214101822"},"html":{"href":"https://github.com/corda/corda/pull/3872#discussion_r214101822"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/3872"}},"in_reply_to_id":214094899},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/3872","id":212134639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTM0NjM5","html_url":"https://github.com/corda/corda/pull/3872","diff_url":"https://github.com/corda/corda/pull/3872.diff","patch_url":"https://github.com/corda/corda/pull/3872.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/3872","number":3872,"state":"open","locked":false,"title":"CORDA-1755: Modify the node to run using picocli","user":{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false},"body":"* Uses the new picocli base class shared with network bootstrapper\r\n* Fixed the `--sshd` option which never worked and added a `--sshd-port` option\r\n* Added documentation on how to install and upgrade shell extensions\r\n* Made sure the documentation of the node command line options was up to date with the help output\r\n* Added some POSIX style short options for some commands (my idea here was to add them for commands that might be ran on the node regularly, as opposed to one time 'start-up' type options - was going to add that to the UX guidelines)\r\n* Made some slight modifications to the base class\r\n  * Made `initLogging` overridable as the Node logging is slightly more complex than the bootstrapper\r\n  * Moved the `initLogging` function to be the first thing that runs, as it was causing the logging options not to work\r\n  * Combined the --log-to-console and --verbose options in the base class as they were doing the same thing\r\n  * Made the run procedure return an Int which is used as the exit code for the app\r\n  * Added the `AnsiConsole.systemInstall()` so all apps have the same cmdline settings by default\r\n  * Check for a `caplet.jar` property and if so use that instead of the running jar location\r\n","created_at":"2018-08-30T16:13:18Z","updated_at":"2018-08-30T16:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f728d352c114c9f45d45ea4719d6b2532574054","assignee":{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonykeenan","id":34482776,"node_id":"MDQ6VXNlcjM0NDgyNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykeenan","html_url":"https://github.com/anthonykeenan","followers_url":"https://api.github.com/users/anthonykeenan/followers","following_url":"https://api.github.com/users/anthonykeenan/following{/other_user}","gists_url":"https://api.github.com/users/anthonykeenan/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykeenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykeenan/subscriptions","organizations_url":"https://api.github.com/users/anthonykeenan/orgs","repos_url":"https://api.github.com/users/anthonykeenan/repos","events_url":"https://api.github.com/users/anthonykeenan/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykeenan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tlil","id":5948145,"node_id":"MDQ6VXNlcjU5NDgxNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5948145?v=4","gravatar_id":"","url":"https://api.github.com/users/tlil","html_url":"https://github.com/tlil","followers_url":"https://api.github.com/users/tlil/followers","following_url":"https://api.github.com/users/tlil/following{/other_user}","gists_url":"https://api.github.com/users/tlil/gists{/gist_id}","starred_url":"https://api.github.com/users/tlil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlil/subscriptions","organizations_url":"https://api.github.com/users/tlil/orgs","repos_url":"https://api.github.com/users/tlil/repos","events_url":"https://api.github.com/users/tlil/events{/privacy}","received_events_url":"https://api.github.com/users/tlil/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/3872/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/3872/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/3872/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/6f0b4414391392cd9270b8b4a573272fc3eadd1b","head":{"label":"corda:anthony/features/CORDA-1755","ref":"anthony/features/CORDA-1755","sha":"6f0b4414391392cd9270b8b4a573272fc3eadd1b","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-08-30T12:40:08Z","pushed_at":"2018-08-30T16:36:03Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":160587,"stargazers_count":2255,"watchers_count":2255,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":584,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":584,"open_issues":135,"watchers":2255,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"dbc10884173f3e9ff846e5186edd92b50ce3ab5f","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-08-30T12:40:08Z","pushed_at":"2018-08-30T16:36:03Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":160587,"stargazers_count":2255,"watchers_count":2255,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":584,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":584,"open_issues":135,"watchers":2255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/3872"},"html":{"href":"https://github.com/corda/corda/pull/3872"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/3872"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/3872/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/3872/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/3872/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/6f0b4414391392cd9270b8b4a573272fc3eadd1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anthonykeenan"}}