{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63","id":231252494,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjUyNDk0","html_url":"https://github.com/chronologic/MyCrypto/pull/63","diff_url":"https://github.com/chronologic/MyCrypto/pull/63.diff","patch_url":"https://github.com/chronologic/MyCrypto/pull/63.patch","issue_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/63","number":63,"state":"closed","locked":false,"title":"Datepicker improvements","user":{"login":"Kuzirashi","id":4950658,"node_id":"MDQ6VXNlcjQ5NTA2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4950658?v=4","gravatar_id":"","url":"https://api.github.com/users/Kuzirashi","html_url":"https://github.com/Kuzirashi","followers_url":"https://api.github.com/users/Kuzirashi/followers","following_url":"https://api.github.com/users/Kuzirashi/following{/other_user}","gists_url":"https://api.github.com/users/Kuzirashi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuzirashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuzirashi/subscriptions","organizations_url":"https://api.github.com/users/Kuzirashi/orgs","repos_url":"https://api.github.com/users/Kuzirashi/repos","events_url":"https://api.github.com/users/Kuzirashi/events{/privacy}","received_events_url":"https://api.github.com/users/Kuzirashi/received_events","type":"User","site_admin":false},"body":"This relies on https://github.com/MyCryptoHQ/MyCrypto/pull/2247 being merged. In this pull request, only commit: `[FEATURE] Improve DateTime component.` matters.\r\n\r\n### Description\r\n\r\n_This is coming from users scheduling transactions in our contest at Devcon. They tried to type date into the input, and they encountered 'Invalid Date' problem. Also, they had problems figuring out how to pick time (where is time picker).\r\n\r\nThis addresses these two things. It removes react-datepicker dependency, and instead the code of this component is move to this repository, rewritten to TS (it's not perfect, but I didn't want to rewrite their whole codebase to match high quality of MyCrypto codebase).\r\n\r\n### Changes\r\n\r\n- Allows users to type date into input field\r\n- Makes calendar more readable\r\n- DIsplays time picker by default next to calendar\r\n\r\n### Steps to Test\r\n\r\n1. Click 'Send Later'\r\n2. Choose date\r\n\r\n### Screenshots\r\n\r\n![3](https://user-images.githubusercontent.com/4950658/48671855-80662180-eb2e-11e8-87d6-d71b81ee5d53.png)\r\n\r\n### Video\r\n\r\nhttps://youtu.be/zEMAw-4AonA","created_at":"2018-11-15T16:17:16Z","updated_at":"2018-11-18T11:40:06Z","closed_at":"2018-11-18T11:40:06Z","merged_at":null,"merge_commit_sha":"3c55125c883425bfe7b0ad35e31282ad5a2520fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63/commits","review_comments_url":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63/comments","review_comment_url":"https://api.github.com/repos/chronologic/MyCrypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/63/comments","statuses_url":"https://api.github.com/repos/chronologic/MyCrypto/statuses/921b733e188c7844718ec768879d6157dc6628f2","head":{"label":"chronologic:datepicker-improvements","ref":"datepicker-improvements","sha":"921b733e188c7844718ec768879d6157dc6628f2","user":{"login":"chronologic","id":30236695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM2Njk1","avatar_url":"https://avatars1.githubusercontent.com/u/30236695?v=4","gravatar_id":"","url":"https://api.github.com/users/chronologic","html_url":"https://github.com/chronologic","followers_url":"https://api.github.com/users/chronologic/followers","following_url":"https://api.github.com/users/chronologic/following{/other_user}","gists_url":"https://api.github.com/users/chronologic/gists{/gist_id}","starred_url":"https://api.github.com/users/chronologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chronologic/subscriptions","organizations_url":"https://api.github.com/users/chronologic/orgs","repos_url":"https://api.github.com/users/chronologic/repos","events_url":"https://api.github.com/users/chronologic/events{/privacy}","received_events_url":"https://api.github.com/users/chronologic/received_events","type":"Organization","site_admin":false},"repo":{"id":125057450,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwNTc0NTA=","name":"MyCrypto","full_name":"chronologic/MyCrypto","private":false,"owner":{"login":"chronologic","id":30236695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM2Njk1","avatar_url":"https://avatars1.githubusercontent.com/u/30236695?v=4","gravatar_id":"","url":"https://api.github.com/users/chronologic","html_url":"https://github.com/chronologic","followers_url":"https://api.github.com/users/chronologic/followers","following_url":"https://api.github.com/users/chronologic/following{/other_user}","gists_url":"https://api.github.com/users/chronologic/gists{/gist_id}","starred_url":"https://api.github.com/users/chronologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chronologic/subscriptions","organizations_url":"https://api.github.com/users/chronologic/orgs","repos_url":"https://api.github.com/users/chronologic/repos","events_url":"https://api.github.com/users/chronologic/events{/privacy}","received_events_url":"https://api.github.com/users/chronologic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chronologic/MyCrypto","description":"BETA - VISIT https://github.com/MyCryptoHQ/mycrypto.com FOR THE CURRENT SITE","fork":true,"url":"https://api.github.com/repos/chronologic/MyCrypto","forks_url":"https://api.github.com/repos/chronologic/MyCrypto/forks","keys_url":"https://api.github.com/repos/chronologic/MyCrypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chronologic/MyCrypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chronologic/MyCrypto/teams","hooks_url":"https://api.github.com/repos/chronologic/MyCrypto/hooks","issue_events_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/events{/number}","events_url":"https://api.github.com/repos/chronologic/MyCrypto/events","assignees_url":"https://api.github.com/repos/chronologic/MyCrypto/assignees{/user}","branches_url":"https://api.github.com/repos/chronologic/MyCrypto/branches{/branch}","tags_url":"https://api.github.com/repos/chronologic/MyCrypto/tags","blobs_url":"https://api.github.com/repos/chronologic/MyCrypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chronologic/MyCrypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chronologic/MyCrypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/chronologic/MyCrypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chronologic/MyCrypto/statuses/{sha}","languages_url":"https://api.github.com/repos/chronologic/MyCrypto/languages","stargazers_url":"https://api.github.com/repos/chronologic/MyCrypto/stargazers","contributors_url":"https://api.github.com/repos/chronologic/MyCrypto/contributors","subscribers_url":"https://api.github.com/repos/chronologic/MyCrypto/subscribers","subscription_url":"https://api.github.com/repos/chronologic/MyCrypto/subscription","commits_url":"https://api.github.com/repos/chronologic/MyCrypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/chronologic/MyCrypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/chronologic/MyCrypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/chronologic/MyCrypto/contents/{+path}","compare_url":"https://api.github.com/repos/chronologic/MyCrypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chronologic/MyCrypto/merges","archive_url":"https://api.github.com/repos/chronologic/MyCrypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chronologic/MyCrypto/downloads","issues_url":"https://api.github.com/repos/chronologic/MyCrypto/issues{/number}","pulls_url":"https://api.github.com/repos/chronologic/MyCrypto/pulls{/number}","milestones_url":"https://api.github.com/repos/chronologic/MyCrypto/milestones{/number}","notifications_url":"https://api.github.com/repos/chronologic/MyCrypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chronologic/MyCrypto/labels{/name}","releases_url":"https://api.github.com/repos/chronologic/MyCrypto/releases{/id}","deployments_url":"https://api.github.com/repos/chronologic/MyCrypto/deployments","created_at":"2018-03-13T13:39:20Z","updated_at":"2018-11-17T21:55:21Z","pushed_at":"2018-11-18T11:29:09Z","git_url":"git://github.com/chronologic/MyCrypto.git","ssh_url":"git@github.com:chronologic/MyCrypto.git","clone_url":"https://github.com/chronologic/MyCrypto.git","svn_url":"https://github.com/chronologic/MyCrypto","homepage":"http://beta.mycrypto.com","size":12776,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"chronologic:develop","ref":"develop","sha":"05eb9d1109e6eee1198396dd9b2a3233c945f50c","user":{"login":"chronologic","id":30236695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM2Njk1","avatar_url":"https://avatars1.githubusercontent.com/u/30236695?v=4","gravatar_id":"","url":"https://api.github.com/users/chronologic","html_url":"https://github.com/chronologic","followers_url":"https://api.github.com/users/chronologic/followers","following_url":"https://api.github.com/users/chronologic/following{/other_user}","gists_url":"https://api.github.com/users/chronologic/gists{/gist_id}","starred_url":"https://api.github.com/users/chronologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chronologic/subscriptions","organizations_url":"https://api.github.com/users/chronologic/orgs","repos_url":"https://api.github.com/users/chronologic/repos","events_url":"https://api.github.com/users/chronologic/events{/privacy}","received_events_url":"https://api.github.com/users/chronologic/received_events","type":"Organization","site_admin":false},"repo":{"id":125057450,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwNTc0NTA=","name":"MyCrypto","full_name":"chronologic/MyCrypto","private":false,"owner":{"login":"chronologic","id":30236695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM2Njk1","avatar_url":"https://avatars1.githubusercontent.com/u/30236695?v=4","gravatar_id":"","url":"https://api.github.com/users/chronologic","html_url":"https://github.com/chronologic","followers_url":"https://api.github.com/users/chronologic/followers","following_url":"https://api.github.com/users/chronologic/following{/other_user}","gists_url":"https://api.github.com/users/chronologic/gists{/gist_id}","starred_url":"https://api.github.com/users/chronologic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chronologic/subscriptions","organizations_url":"https://api.github.com/users/chronologic/orgs","repos_url":"https://api.github.com/users/chronologic/repos","events_url":"https://api.github.com/users/chronologic/events{/privacy}","received_events_url":"https://api.github.com/users/chronologic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chronologic/MyCrypto","description":"BETA - VISIT https://github.com/MyCryptoHQ/mycrypto.com FOR THE CURRENT SITE","fork":true,"url":"https://api.github.com/repos/chronologic/MyCrypto","forks_url":"https://api.github.com/repos/chronologic/MyCrypto/forks","keys_url":"https://api.github.com/repos/chronologic/MyCrypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chronologic/MyCrypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chronologic/MyCrypto/teams","hooks_url":"https://api.github.com/repos/chronologic/MyCrypto/hooks","issue_events_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/events{/number}","events_url":"https://api.github.com/repos/chronologic/MyCrypto/events","assignees_url":"https://api.github.com/repos/chronologic/MyCrypto/assignees{/user}","branches_url":"https://api.github.com/repos/chronologic/MyCrypto/branches{/branch}","tags_url":"https://api.github.com/repos/chronologic/MyCrypto/tags","blobs_url":"https://api.github.com/repos/chronologic/MyCrypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chronologic/MyCrypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chronologic/MyCrypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/chronologic/MyCrypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chronologic/MyCrypto/statuses/{sha}","languages_url":"https://api.github.com/repos/chronologic/MyCrypto/languages","stargazers_url":"https://api.github.com/repos/chronologic/MyCrypto/stargazers","contributors_url":"https://api.github.com/repos/chronologic/MyCrypto/contributors","subscribers_url":"https://api.github.com/repos/chronologic/MyCrypto/subscribers","subscription_url":"https://api.github.com/repos/chronologic/MyCrypto/subscription","commits_url":"https://api.github.com/repos/chronologic/MyCrypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/chronologic/MyCrypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/chronologic/MyCrypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/chronologic/MyCrypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/chronologic/MyCrypto/contents/{+path}","compare_url":"https://api.github.com/repos/chronologic/MyCrypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chronologic/MyCrypto/merges","archive_url":"https://api.github.com/repos/chronologic/MyCrypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chronologic/MyCrypto/downloads","issues_url":"https://api.github.com/repos/chronologic/MyCrypto/issues{/number}","pulls_url":"https://api.github.com/repos/chronologic/MyCrypto/pulls{/number}","milestones_url":"https://api.github.com/repos/chronologic/MyCrypto/milestones{/number}","notifications_url":"https://api.github.com/repos/chronologic/MyCrypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chronologic/MyCrypto/labels{/name}","releases_url":"https://api.github.com/repos/chronologic/MyCrypto/releases{/id}","deployments_url":"https://api.github.com/repos/chronologic/MyCrypto/deployments","created_at":"2018-03-13T13:39:20Z","updated_at":"2018-11-17T21:55:21Z","pushed_at":"2018-11-18T11:29:09Z","git_url":"git://github.com/chronologic/MyCrypto.git","ssh_url":"git@github.com:chronologic/MyCrypto.git","clone_url":"https://github.com/chronologic/MyCrypto.git","svn_url":"https://github.com/chronologic/MyCrypto","homepage":"http://beta.mycrypto.com","size":12776,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63"},"html":{"href":"https://github.com/chronologic/MyCrypto/pull/63"},"issue":{"href":"https://api.github.com/repos/chronologic/MyCrypto/issues/63"},"comments":{"href":"https://api.github.com/repos/chronologic/MyCrypto/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/chronologic/MyCrypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chronologic/MyCrypto/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/chronologic/MyCrypto/statuses/921b733e188c7844718ec768879d6157dc6628f2"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5890,"deletions":1732,"changed_files":14}}
{"actor":{"display_login":"Kuzirashi"}}