{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/comments/214833620","pull_request_review_id":151966694,"id":214833620,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDgzMzYyMA==","diff_hunk":"@@ -131,22 +133,24 @@ fn assert_data_eq(a: &Data, b: &Data) {\n             for x in 0..a.n.0 {\n                 let idx = (x + y * a.n.1 + z * a.n.1 * a.n.0) as usize;\n \n-                assert_eq!(\n-                    a.vsq[idx], b.vsq[idx],\n+                const EPSILON: f32 = 1E-4;","path":"examples/stencil/src/lib.rs","position":33,"original_position":33,"commit_id":"bfd4f2a4fbdb1d7b941a9e89a3fb82288a2aea04","original_commit_id":"bfd4f2a4fbdb1d7b941a9e89a3fb82288a2aea04","user":{"login":"gnzlbg","id":904614,"node_id":"MDQ6VXNlcjkwNDYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/904614?v=4","gravatar_id":"","url":"https://api.github.com/users/gnzlbg","html_url":"https://github.com/gnzlbg","followers_url":"https://api.github.com/users/gnzlbg/followers","following_url":"https://api.github.com/users/gnzlbg/following{/other_user}","gists_url":"https://api.github.com/users/gnzlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/gnzlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnzlbg/subscriptions","organizations_url":"https://api.github.com/users/gnzlbg/orgs","repos_url":"https://api.github.com/users/gnzlbg/repos","events_url":"https://api.github.com/users/gnzlbg/events{/privacy}","received_events_url":"https://api.github.com/users/gnzlbg/received_events","type":"User","site_admin":false},"body":"Is this the smallest absolute epsilon that works?","created_at":"2018-09-04T08:47:26Z","updated_at":"2018-09-04T08:47:26Z","html_url":"https://github.com/rust-lang-nursery/packed_simd/pull/115#discussion_r214833620","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/comments/214833620"},"html":{"href":"https://github.com/rust-lang-nursery/packed_simd/pull/115#discussion_r214833620"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115","id":212540259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTQwMjU5","html_url":"https://github.com/rust-lang-nursery/packed_simd/pull/115","diff_url":"https://github.com/rust-lang-nursery/packed_simd/pull/115.diff","patch_url":"https://github.com/rust-lang-nursery/packed_simd/pull/115.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/115","number":115,"state":"open","locked":false,"title":"Performance improvements for benchmarks","user":{"login":"GabrielMajeri","id":3010346,"node_id":"MDQ6VXNlcjMwMTAzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3010346?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielMajeri","html_url":"https://github.com/GabrielMajeri","followers_url":"https://api.github.com/users/GabrielMajeri/followers","following_url":"https://api.github.com/users/GabrielMajeri/following{/other_user}","gists_url":"https://api.github.com/users/GabrielMajeri/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielMajeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielMajeri/subscriptions","organizations_url":"https://api.github.com/users/GabrielMajeri/orgs","repos_url":"https://api.github.com/users/GabrielMajeri/repos","events_url":"https://api.github.com/users/GabrielMajeri/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielMajeri/received_events","type":"User","site_admin":false},"body":"This pull request contains improvements to the performance of the example crates in this repository.\r\n\r\n## fannkuch_redux\r\n\r\n- I noticed a small performance reduction because LLVM was emitting memory accesses to the `self.odd` field, insted of storing it in a register.\r\n  Not sure why this happens, LLVM should know we borrow `self` mutably & have exclusive access to `self` and be able to cache its value locally.\r\n\r\n- Overall, about 1.5% better performance.\r\n\r\n## stencil\r\n\r\nSee issue #95 for the full discussion.\r\n\r\n- Improved performance of `Data::reinit` by using unsafe memory accesses. Not part of the benchmark, but it was slow and showing up a lot in the profiler.\r\n- The parallel code is slower than the SIMD code now:\r\n```\r\nsimd: 175 ms\r\nsimd+par: 279 ms\r\nispc: 176 ms\r\nispc+tasks: 373 ms\r\n```\r\n  I guess that's... good?\r\n\r\n### Failing tests\r\n- I've updated the testing code to use approximative float comparisons, with an error no larger than 10^-4.","created_at":"2018-09-01T10:13:31Z","updated_at":"2018-09-04T08:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5571b126d1aa46bf953284b69d01b5ebdc3dc722","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/115/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/statuses/bfd4f2a4fbdb1d7b941a9e89a3fb82288a2aea04","head":{"label":"GabrielMajeri:perf","ref":"perf","sha":"bfd4f2a4fbdb1d7b941a9e89a3fb82288a2aea04","user":{"login":"GabrielMajeri","id":3010346,"node_id":"MDQ6VXNlcjMwMTAzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3010346?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielMajeri","html_url":"https://github.com/GabrielMajeri","followers_url":"https://api.github.com/users/GabrielMajeri/followers","following_url":"https://api.github.com/users/GabrielMajeri/following{/other_user}","gists_url":"https://api.github.com/users/GabrielMajeri/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielMajeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielMajeri/subscriptions","organizations_url":"https://api.github.com/users/GabrielMajeri/orgs","repos_url":"https://api.github.com/users/GabrielMajeri/repos","events_url":"https://api.github.com/users/GabrielMajeri/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielMajeri/received_events","type":"User","site_admin":false},"repo":{"id":146849744,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NDk3NDQ=","name":"packed_simd","full_name":"GabrielMajeri/packed_simd","owner":{"login":"GabrielMajeri","id":3010346,"node_id":"MDQ6VXNlcjMwMTAzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3010346?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielMajeri","html_url":"https://github.com/GabrielMajeri","followers_url":"https://api.github.com/users/GabrielMajeri/followers","following_url":"https://api.github.com/users/GabrielMajeri/following{/other_user}","gists_url":"https://api.github.com/users/GabrielMajeri/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielMajeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielMajeri/subscriptions","organizations_url":"https://api.github.com/users/GabrielMajeri/orgs","repos_url":"https://api.github.com/users/GabrielMajeri/repos","events_url":"https://api.github.com/users/GabrielMajeri/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielMajeri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GabrielMajeri/packed_simd","description":"Portable Packed SIMD Vectors for Rust","fork":true,"url":"https://api.github.com/repos/GabrielMajeri/packed_simd","forks_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/forks","keys_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/teams","hooks_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/hooks","issue_events_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/issues/events{/number}","events_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/events","assignees_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/assignees{/user}","branches_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/branches{/branch}","tags_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/tags","blobs_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/statuses/{sha}","languages_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/languages","stargazers_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/stargazers","contributors_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/contributors","subscribers_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/subscribers","subscription_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/subscription","commits_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/contents/{+path}","compare_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/merges","archive_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/downloads","issues_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/issues{/number}","pulls_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/pulls{/number}","milestones_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/milestones{/number}","notifications_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/labels{/name}","releases_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/releases{/id}","deployments_url":"https://api.github.com/repos/GabrielMajeri/packed_simd/deployments","created_at":"2018-08-31T06:15:27Z","updated_at":"2018-09-03T14:12:00Z","pushed_at":"2018-09-04T08:24:54Z","git_url":"git://github.com/GabrielMajeri/packed_simd.git","ssh_url":"git@github.com:GabrielMajeri/packed_simd.git","clone_url":"https://github.com/GabrielMajeri/packed_simd.git","svn_url":"https://github.com/GabrielMajeri/packed_simd","homepage":"","size":2155,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"8cd9e71bb2c911fd9efd5a9844a9e2b671a37954","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":138868515,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4Njg1MTU=","name":"packed_simd","full_name":"rust-lang-nursery/packed_simd","owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/packed_simd","description":"Portable Packed SIMD Vectors for Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/packed_simd","forks_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/packed_simd/deployments","created_at":"2018-06-27T10:48:26Z","updated_at":"2018-09-03T21:17:11Z","pushed_at":"2018-09-04T08:24:55Z","git_url":"git://github.com/rust-lang-nursery/packed_simd.git","ssh_url":"git@github.com:rust-lang-nursery/packed_simd.git","clone_url":"https://github.com/rust-lang-nursery/packed_simd.git","svn_url":"https://github.com/rust-lang-nursery/packed_simd","homepage":"","size":2255,"stargazers_count":17,"watchers_count":17,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":45,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115"},"html":{"href":"https://github.com/rust-lang-nursery/packed_simd/pull/115"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/115"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/packed_simd/statuses/bfd4f2a4fbdb1d7b941a9e89a3fb82288a2aea04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gnzlbg"}}