{"action":"created","comment":{"url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/comments/194607550","pull_request_review_id":127810553,"id":194607550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYwNzU1MA==","diff_hunk":"@@ -25,6 +25,10 @@\n  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n  */\n \n+#if LMIC_X_DEBUG_LEVEL > 0","path":"src/lmic/radio.c","position":4,"original_position":4,"commit_id":"865dcf042208a4a71bfe3c8c97a74b8141761b4c","original_commit_id":"865dcf042208a4a71bfe3c8c97a74b8141761b4c","user":{"login":"tanupoo","id":320591,"node_id":"MDQ6VXNlcjMyMDU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/320591?v=4","gravatar_id":"","url":"https://api.github.com/users/tanupoo","html_url":"https://github.com/tanupoo","followers_url":"https://api.github.com/users/tanupoo/followers","following_url":"https://api.github.com/users/tanupoo/following{/other_user}","gists_url":"https://api.github.com/users/tanupoo/gists{/gist_id}","starred_url":"https://api.github.com/users/tanupoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanupoo/subscriptions","organizations_url":"https://api.github.com/users/tanupoo/orgs","repos_url":"https://api.github.com/users/tanupoo/repos","events_url":"https://api.github.com/users/tanupoo/events{/privacy}","received_events_url":"https://api.github.com/users/tanupoo/received_events","type":"User","site_admin":false},"body":"Yes, it's Dragino Mini Dev (ATmega328P).  It didn't help much when I disabled the class B staff actually.  Thanks for preserving the AVR use cases. ","created_at":"2018-06-12T03:42:35Z","updated_at":"2018-06-12T03:42:35Z","html_url":"https://github.com/mcci-catena/arduino-lmic/pull/70#discussion_r194607550","pull_request_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/comments/194607550"},"html":{"href":"https://github.com/mcci-catena/arduino-lmic/pull/70#discussion_r194607550"},"pull_request":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70"}},"in_reply_to_id":193597494},"pull_request":{"url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70","id":193169127,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTY5MTI3","html_url":"https://github.com/mcci-catena/arduino-lmic/pull/70","diff_url":"https://github.com/mcci-catena/arduino-lmic/pull/70.diff","patch_url":"https://github.com/mcci-catena/arduino-lmic/pull/70.patch","issue_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/70","number":70,"state":"closed","locked":false,"title":"Another as923jp","user":{"login":"tanupoo","id":320591,"node_id":"MDQ6VXNlcjMyMDU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/320591?v=4","gravatar_id":"","url":"https://api.github.com/users/tanupoo","html_url":"https://github.com/tanupoo","followers_url":"https://api.github.com/users/tanupoo/followers","following_url":"https://api.github.com/users/tanupoo/following{/other_user}","gists_url":"https://api.github.com/users/tanupoo/gists{/gist_id}","starred_url":"https://api.github.com/users/tanupoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanupoo/subscriptions","organizations_url":"https://api.github.com/users/tanupoo/orgs","repos_url":"https://api.github.com/users/tanupoo/repos","events_url":"https://api.github.com/users/tanupoo/events{/privacy}","received_events_url":"https://api.github.com/users/tanupoo/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThanks for providing a great code.  It's wonderful and helpful very much to use arduino-based LoRaWAN module.\r\n\r\nWhen I started to run Dragino with LMiC in Japan, I noticed that there were some missing feature and some non-conforming staff in LMiC.\r\n\r\nI forked from mater and merged TMM-feature-as923jp, (which is not there, I don't why).  Then, I fixed LBT, txpower, and debug messages.\r\n\r\nMy modifications are mixed.  It should be separated to be easy to merge for you.  However, the time is moving.  I have decided to submit a pull request before the diff will be increased.\r\n\r\nPlease any suggestions if you would like to merge this and tell me how I should do.\r\n\r\nThanks,\r\nShoichi","created_at":"2018-06-06T23:40:28Z","updated_at":"2018-06-12T03:42:35Z","closed_at":"2018-06-07T03:08:58Z","merged_at":"2018-06-07T03:08:58Z","merge_commit_sha":"865dcf042208a4a71bfe3c8c97a74b8141761b4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70/commits","review_comments_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70/comments","review_comment_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/70/comments","statuses_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/statuses/865dcf042208a4a71bfe3c8c97a74b8141761b4c","head":{"label":"tanupoo:another-as923jp","ref":"another-as923jp","sha":"865dcf042208a4a71bfe3c8c97a74b8141761b4c","user":{"login":"tanupoo","id":320591,"node_id":"MDQ6VXNlcjMyMDU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/320591?v=4","gravatar_id":"","url":"https://api.github.com/users/tanupoo","html_url":"https://github.com/tanupoo","followers_url":"https://api.github.com/users/tanupoo/followers","following_url":"https://api.github.com/users/tanupoo/following{/other_user}","gists_url":"https://api.github.com/users/tanupoo/gists{/gist_id}","starred_url":"https://api.github.com/users/tanupoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanupoo/subscriptions","organizations_url":"https://api.github.com/users/tanupoo/orgs","repos_url":"https://api.github.com/users/tanupoo/repos","events_url":"https://api.github.com/users/tanupoo/events{/privacy}","received_events_url":"https://api.github.com/users/tanupoo/received_events","type":"User","site_admin":false},"repo":{"id":130679248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzkyNDg=","name":"arduino-lmic","full_name":"tanupoo/arduino-lmic","owner":{"login":"tanupoo","id":320591,"node_id":"MDQ6VXNlcjMyMDU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/320591?v=4","gravatar_id":"","url":"https://api.github.com/users/tanupoo","html_url":"https://github.com/tanupoo","followers_url":"https://api.github.com/users/tanupoo/followers","following_url":"https://api.github.com/users/tanupoo/following{/other_user}","gists_url":"https://api.github.com/users/tanupoo/gists{/gist_id}","starred_url":"https://api.github.com/users/tanupoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanupoo/subscriptions","organizations_url":"https://api.github.com/users/tanupoo/orgs","repos_url":"https://api.github.com/users/tanupoo/repos","events_url":"https://api.github.com/users/tanupoo/events{/privacy}","received_events_url":"https://api.github.com/users/tanupoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tanupoo/arduino-lmic","description":"LoraWAN-in-C library, adapted to run under the Arduino environment","fork":true,"url":"https://api.github.com/repos/tanupoo/arduino-lmic","forks_url":"https://api.github.com/repos/tanupoo/arduino-lmic/forks","keys_url":"https://api.github.com/repos/tanupoo/arduino-lmic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanupoo/arduino-lmic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanupoo/arduino-lmic/teams","hooks_url":"https://api.github.com/repos/tanupoo/arduino-lmic/hooks","issue_events_url":"https://api.github.com/repos/tanupoo/arduino-lmic/issues/events{/number}","events_url":"https://api.github.com/repos/tanupoo/arduino-lmic/events","assignees_url":"https://api.github.com/repos/tanupoo/arduino-lmic/assignees{/user}","branches_url":"https://api.github.com/repos/tanupoo/arduino-lmic/branches{/branch}","tags_url":"https://api.github.com/repos/tanupoo/arduino-lmic/tags","blobs_url":"https://api.github.com/repos/tanupoo/arduino-lmic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanupoo/arduino-lmic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanupoo/arduino-lmic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanupoo/arduino-lmic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanupoo/arduino-lmic/statuses/{sha}","languages_url":"https://api.github.com/repos/tanupoo/arduino-lmic/languages","stargazers_url":"https://api.github.com/repos/tanupoo/arduino-lmic/stargazers","contributors_url":"https://api.github.com/repos/tanupoo/arduino-lmic/contributors","subscribers_url":"https://api.github.com/repos/tanupoo/arduino-lmic/subscribers","subscription_url":"https://api.github.com/repos/tanupoo/arduino-lmic/subscription","commits_url":"https://api.github.com/repos/tanupoo/arduino-lmic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanupoo/arduino-lmic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanupoo/arduino-lmic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanupoo/arduino-lmic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanupoo/arduino-lmic/contents/{+path}","compare_url":"https://api.github.com/repos/tanupoo/arduino-lmic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanupoo/arduino-lmic/merges","archive_url":"https://api.github.com/repos/tanupoo/arduino-lmic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanupoo/arduino-lmic/downloads","issues_url":"https://api.github.com/repos/tanupoo/arduino-lmic/issues{/number}","pulls_url":"https://api.github.com/repos/tanupoo/arduino-lmic/pulls{/number}","milestones_url":"https://api.github.com/repos/tanupoo/arduino-lmic/milestones{/number}","notifications_url":"https://api.github.com/repos/tanupoo/arduino-lmic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanupoo/arduino-lmic/labels{/name}","releases_url":"https://api.github.com/repos/tanupoo/arduino-lmic/releases{/id}","deployments_url":"https://api.github.com/repos/tanupoo/arduino-lmic/deployments","created_at":"2018-04-23T10:22:10Z","updated_at":"2018-06-12T03:03:02Z","pushed_at":"2018-06-12T03:02:53Z","git_url":"git://github.com/tanupoo/arduino-lmic.git","ssh_url":"git@github.com:tanupoo/arduino-lmic.git","clone_url":"https://github.com/tanupoo/arduino-lmic.git","svn_url":"https://github.com/tanupoo/arduino-lmic","homepage":null,"size":10495,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mcci-catena:master","ref":"master","sha":"c5b8d513f91b926094606107f39f56e94b370f76","user":{"login":"mcci-catena","id":23129382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTI5Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/23129382?v=4","gravatar_id":"","url":"https://api.github.com/users/mcci-catena","html_url":"https://github.com/mcci-catena","followers_url":"https://api.github.com/users/mcci-catena/followers","following_url":"https://api.github.com/users/mcci-catena/following{/other_user}","gists_url":"https://api.github.com/users/mcci-catena/gists{/gist_id}","starred_url":"https://api.github.com/users/mcci-catena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcci-catena/subscriptions","organizations_url":"https://api.github.com/users/mcci-catena/orgs","repos_url":"https://api.github.com/users/mcci-catena/repos","events_url":"https://api.github.com/users/mcci-catena/events{/privacy}","received_events_url":"https://api.github.com/users/mcci-catena/received_events","type":"Organization","site_admin":false},"repo":{"id":67839795,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgzOTc5NQ==","name":"arduino-lmic","full_name":"mcci-catena/arduino-lmic","owner":{"login":"mcci-catena","id":23129382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTI5Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/23129382?v=4","gravatar_id":"","url":"https://api.github.com/users/mcci-catena","html_url":"https://github.com/mcci-catena","followers_url":"https://api.github.com/users/mcci-catena/followers","following_url":"https://api.github.com/users/mcci-catena/following{/other_user}","gists_url":"https://api.github.com/users/mcci-catena/gists{/gist_id}","starred_url":"https://api.github.com/users/mcci-catena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcci-catena/subscriptions","organizations_url":"https://api.github.com/users/mcci-catena/orgs","repos_url":"https://api.github.com/users/mcci-catena/repos","events_url":"https://api.github.com/users/mcci-catena/events{/privacy}","received_events_url":"https://api.github.com/users/mcci-catena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mcci-catena/arduino-lmic","description":"LoraWAN-in-C library, adapted to run under the Arduino environment","fork":true,"url":"https://api.github.com/repos/mcci-catena/arduino-lmic","forks_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/forks","keys_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/teams","hooks_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/hooks","issue_events_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/events{/number}","events_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/events","assignees_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/assignees{/user}","branches_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/branches{/branch}","tags_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/tags","blobs_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/statuses/{sha}","languages_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/languages","stargazers_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/stargazers","contributors_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/contributors","subscribers_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/subscribers","subscription_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/subscription","commits_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/contents/{+path}","compare_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/merges","archive_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/downloads","issues_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues{/number}","pulls_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls{/number}","milestones_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/milestones{/number}","notifications_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/labels{/name}","releases_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/releases{/id}","deployments_url":"https://api.github.com/repos/mcci-catena/arduino-lmic/deployments","created_at":"2016-09-09T23:49:49Z","updated_at":"2018-06-11T23:44:05Z","pushed_at":"2018-06-10T02:46:57Z","git_url":"git://github.com/mcci-catena/arduino-lmic.git","ssh_url":"git@github.com:mcci-catena/arduino-lmic.git","clone_url":"https://github.com/mcci-catena/arduino-lmic.git","svn_url":"https://github.com/mcci-catena/arduino-lmic","homepage":null,"size":10586,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":24,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70"},"html":{"href":"https://github.com/mcci-catena/arduino-lmic/pull/70"},"issue":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/70"},"comments":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/mcci-catena/arduino-lmic/statuses/865dcf042208a4a71bfe3c8c97a74b8141761b4c"}},"author_association":"NONE"}}
{"actor":{"display_login":"tanupoo"}}