{"action":"created","comment":{"url":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments/221329610","pull_request_review_id":159957586,"id":221329610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTMyOTYxMA==","diff_hunk":"@@ -44,6 +45,38 @@ test('bootstrap: error when required service not present', () => {\n   ).toThrow('Missing services: decoder');\n });\n \n+test('bootstrap: no error when required service is present', () => {\n+  const core: EthqlPluginFactory = () => ({\n+    name: 'core',\n+    priority: 10,\n+    serviceDefinitions: {\n+      web3: {\n+        implementation: {\n+          factory: () => initWeb3({\n+            jsonrpc: 'http://127.0.0.1:8545',\n+            batching: false\n+          }),\n+        },\n+      }\n+    }\n+  });\n+\n+  const plugin1: EthqlPluginFactory = () => ({\n+    name: 'plugin1',\n+    priority: 10,","path":"src/__tests__/bootstrap.test.ts","position":29,"original_position":29,"commit_id":"94e25176f14df7b80f3a8aae5237f221ac06a454","original_commit_id":"94e25176f14df7b80f3a8aae5237f221ac06a454","user":{"login":"raulk","id":1101242,"node_id":"MDQ6VXNlcjExMDEyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1101242?v=4","gravatar_id":"","url":"https://api.github.com/users/raulk","html_url":"https://github.com/raulk","followers_url":"https://api.github.com/users/raulk/followers","following_url":"https://api.github.com/users/raulk/following{/other_user}","gists_url":"https://api.github.com/users/raulk/gists{/gist_id}","starred_url":"https://api.github.com/users/raulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raulk/subscriptions","organizations_url":"https://api.github.com/users/raulk/orgs","repos_url":"https://api.github.com/users/raulk/repos","events_url":"https://api.github.com/users/raulk/events{/privacy}","received_events_url":"https://api.github.com/users/raulk/received_events","type":"User","site_admin":false},"body":"I suspect this is an ordering issue. Could you make the priority of `plugin1` 11, or add an `order` constraint such that `order.after` = `core`?","created_at":"2018-09-28T17:40:44Z","updated_at":"2018-09-28T17:40:47Z","html_url":"https://github.com/ConsenSys/ethql/pull/108#discussion_r221329610","pull_request_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/108","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments/221329610"},"html":{"href":"https://github.com/ConsenSys/ethql/pull/108#discussion_r221329610"},"pull_request":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/ConsenSys/ethql/pulls/108","id":218836593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODM2NTkz","html_url":"https://github.com/ConsenSys/ethql/pull/108","diff_url":"https://github.com/ConsenSys/ethql/pull/108.diff","patch_url":"https://github.com/ConsenSys/ethql/pull/108.patch","issue_url":"https://api.github.com/repos/ConsenSys/ethql/issues/108","number":108,"state":"open","locked":false,"title":"Fix plugin dependsOn always throwing error","user":{"login":"StevenJNPearce","id":36509712,"node_id":"MDQ6VXNlcjM2NTA5NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/36509712?v=4","gravatar_id":"","url":"https://api.github.com/users/StevenJNPearce","html_url":"https://github.com/StevenJNPearce","followers_url":"https://api.github.com/users/StevenJNPearce/followers","following_url":"https://api.github.com/users/StevenJNPearce/following{/other_user}","gists_url":"https://api.github.com/users/StevenJNPearce/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenJNPearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenJNPearce/subscriptions","organizations_url":"https://api.github.com/users/StevenJNPearce/orgs","repos_url":"https://api.github.com/users/StevenJNPearce/repos","events_url":"https://api.github.com/users/StevenJNPearce/events{/privacy}","received_events_url":"https://api.github.com/users/StevenJNPearce/received_events","type":"User","site_admin":false},"body":"Ran into this whilst getting familiar with the project to work on #106 \r\n`const serviceImplNames = Object.keys(_.filter(serviceDefinitions, 'implementation'));`\r\nThis is returning [ '0', '1', '2', ... ], so ERR_MSG_MISSING_SERVICES is thrown even when a correct service name is provided under dependsOn in the plugin config.\r\n","created_at":"2018-09-28T02:22:55Z","updated_at":"2018-09-28T17:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"075d9daa9d0595b80ccf15b21586f8ec48b5edf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/108/commits","review_comments_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/108/comments","review_comment_url":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConsenSys/ethql/issues/108/comments","statuses_url":"https://api.github.com/repos/ConsenSys/ethql/statuses/94e25176f14df7b80f3a8aae5237f221ac06a454","head":{"label":"StevenJNPearce:master","ref":"master","sha":"94e25176f14df7b80f3a8aae5237f221ac06a454","user":{"login":"StevenJNPearce","id":36509712,"node_id":"MDQ6VXNlcjM2NTA5NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/36509712?v=4","gravatar_id":"","url":"https://api.github.com/users/StevenJNPearce","html_url":"https://github.com/StevenJNPearce","followers_url":"https://api.github.com/users/StevenJNPearce/followers","following_url":"https://api.github.com/users/StevenJNPearce/following{/other_user}","gists_url":"https://api.github.com/users/StevenJNPearce/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenJNPearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenJNPearce/subscriptions","organizations_url":"https://api.github.com/users/StevenJNPearce/orgs","repos_url":"https://api.github.com/users/StevenJNPearce/repos","events_url":"https://api.github.com/users/StevenJNPearce/events{/privacy}","received_events_url":"https://api.github.com/users/StevenJNPearce/received_events","type":"User","site_admin":false},"repo":{"id":150672510,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2NzI1MTA=","name":"ethql","full_name":"StevenJNPearce/ethql","private":false,"owner":{"login":"StevenJNPearce","id":36509712,"node_id":"MDQ6VXNlcjM2NTA5NzEy","avatar_url":"https://avatars3.githubusercontent.com/u/36509712?v=4","gravatar_id":"","url":"https://api.github.com/users/StevenJNPearce","html_url":"https://github.com/StevenJNPearce","followers_url":"https://api.github.com/users/StevenJNPearce/followers","following_url":"https://api.github.com/users/StevenJNPearce/following{/other_user}","gists_url":"https://api.github.com/users/StevenJNPearce/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenJNPearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenJNPearce/subscriptions","organizations_url":"https://api.github.com/users/StevenJNPearce/orgs","repos_url":"https://api.github.com/users/StevenJNPearce/repos","events_url":"https://api.github.com/users/StevenJNPearce/events{/privacy}","received_events_url":"https://api.github.com/users/StevenJNPearce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/StevenJNPearce/ethql","description":"A GraphQL interface to Ethereum :fire:","fork":true,"url":"https://api.github.com/repos/StevenJNPearce/ethql","forks_url":"https://api.github.com/repos/StevenJNPearce/ethql/forks","keys_url":"https://api.github.com/repos/StevenJNPearce/ethql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StevenJNPearce/ethql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StevenJNPearce/ethql/teams","hooks_url":"https://api.github.com/repos/StevenJNPearce/ethql/hooks","issue_events_url":"https://api.github.com/repos/StevenJNPearce/ethql/issues/events{/number}","events_url":"https://api.github.com/repos/StevenJNPearce/ethql/events","assignees_url":"https://api.github.com/repos/StevenJNPearce/ethql/assignees{/user}","branches_url":"https://api.github.com/repos/StevenJNPearce/ethql/branches{/branch}","tags_url":"https://api.github.com/repos/StevenJNPearce/ethql/tags","blobs_url":"https://api.github.com/repos/StevenJNPearce/ethql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StevenJNPearce/ethql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StevenJNPearce/ethql/git/refs{/sha}","trees_url":"https://api.github.com/repos/StevenJNPearce/ethql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StevenJNPearce/ethql/statuses/{sha}","languages_url":"https://api.github.com/repos/StevenJNPearce/ethql/languages","stargazers_url":"https://api.github.com/repos/StevenJNPearce/ethql/stargazers","contributors_url":"https://api.github.com/repos/StevenJNPearce/ethql/contributors","subscribers_url":"https://api.github.com/repos/StevenJNPearce/ethql/subscribers","subscription_url":"https://api.github.com/repos/StevenJNPearce/ethql/subscription","commits_url":"https://api.github.com/repos/StevenJNPearce/ethql/commits{/sha}","git_commits_url":"https://api.github.com/repos/StevenJNPearce/ethql/git/commits{/sha}","comments_url":"https://api.github.com/repos/StevenJNPearce/ethql/comments{/number}","issue_comment_url":"https://api.github.com/repos/StevenJNPearce/ethql/issues/comments{/number}","contents_url":"https://api.github.com/repos/StevenJNPearce/ethql/contents/{+path}","compare_url":"https://api.github.com/repos/StevenJNPearce/ethql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StevenJNPearce/ethql/merges","archive_url":"https://api.github.com/repos/StevenJNPearce/ethql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StevenJNPearce/ethql/downloads","issues_url":"https://api.github.com/repos/StevenJNPearce/ethql/issues{/number}","pulls_url":"https://api.github.com/repos/StevenJNPearce/ethql/pulls{/number}","milestones_url":"https://api.github.com/repos/StevenJNPearce/ethql/milestones{/number}","notifications_url":"https://api.github.com/repos/StevenJNPearce/ethql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StevenJNPearce/ethql/labels{/name}","releases_url":"https://api.github.com/repos/StevenJNPearce/ethql/releases{/id}","deployments_url":"https://api.github.com/repos/StevenJNPearce/ethql/deployments","created_at":"2018-09-28T02:09:03Z","updated_at":"2018-09-28T17:10:43Z","pushed_at":"2018-09-28T17:10:41Z","git_url":"git://github.com/StevenJNPearce/ethql.git","ssh_url":"git@github.com:StevenJNPearce/ethql.git","clone_url":"https://github.com/StevenJNPearce/ethql.git","svn_url":"https://github.com/StevenJNPearce/ethql","homepage":"","size":798,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ConsenSys:master","ref":"master","sha":"8308153fadd52095860751a4ee152ebc52f2fa7a","user":{"login":"ConsenSys","id":10818037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODE4MDM3","avatar_url":"https://avatars3.githubusercontent.com/u/10818037?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"repo":{"id":121815589,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4MTU1ODk=","name":"ethql","full_name":"ConsenSys/ethql","private":false,"owner":{"login":"ConsenSys","id":10818037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODE4MDM3","avatar_url":"https://avatars3.githubusercontent.com/u/10818037?v=4","gravatar_id":"","url":"https://api.github.com/users/ConsenSys","html_url":"https://github.com/ConsenSys","followers_url":"https://api.github.com/users/ConsenSys/followers","following_url":"https://api.github.com/users/ConsenSys/following{/other_user}","gists_url":"https://api.github.com/users/ConsenSys/gists{/gist_id}","starred_url":"https://api.github.com/users/ConsenSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConsenSys/subscriptions","organizations_url":"https://api.github.com/users/ConsenSys/orgs","repos_url":"https://api.github.com/users/ConsenSys/repos","events_url":"https://api.github.com/users/ConsenSys/events{/privacy}","received_events_url":"https://api.github.com/users/ConsenSys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ConsenSys/ethql","description":"A GraphQL interface to Ethereum :fire:","fork":false,"url":"https://api.github.com/repos/ConsenSys/ethql","forks_url":"https://api.github.com/repos/ConsenSys/ethql/forks","keys_url":"https://api.github.com/repos/ConsenSys/ethql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConsenSys/ethql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConsenSys/ethql/teams","hooks_url":"https://api.github.com/repos/ConsenSys/ethql/hooks","issue_events_url":"https://api.github.com/repos/ConsenSys/ethql/issues/events{/number}","events_url":"https://api.github.com/repos/ConsenSys/ethql/events","assignees_url":"https://api.github.com/repos/ConsenSys/ethql/assignees{/user}","branches_url":"https://api.github.com/repos/ConsenSys/ethql/branches{/branch}","tags_url":"https://api.github.com/repos/ConsenSys/ethql/tags","blobs_url":"https://api.github.com/repos/ConsenSys/ethql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConsenSys/ethql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConsenSys/ethql/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConsenSys/ethql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConsenSys/ethql/statuses/{sha}","languages_url":"https://api.github.com/repos/ConsenSys/ethql/languages","stargazers_url":"https://api.github.com/repos/ConsenSys/ethql/stargazers","contributors_url":"https://api.github.com/repos/ConsenSys/ethql/contributors","subscribers_url":"https://api.github.com/repos/ConsenSys/ethql/subscribers","subscription_url":"https://api.github.com/repos/ConsenSys/ethql/subscription","commits_url":"https://api.github.com/repos/ConsenSys/ethql/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConsenSys/ethql/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConsenSys/ethql/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConsenSys/ethql/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConsenSys/ethql/contents/{+path}","compare_url":"https://api.github.com/repos/ConsenSys/ethql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConsenSys/ethql/merges","archive_url":"https://api.github.com/repos/ConsenSys/ethql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConsenSys/ethql/downloads","issues_url":"https://api.github.com/repos/ConsenSys/ethql/issues{/number}","pulls_url":"https://api.github.com/repos/ConsenSys/ethql/pulls{/number}","milestones_url":"https://api.github.com/repos/ConsenSys/ethql/milestones{/number}","notifications_url":"https://api.github.com/repos/ConsenSys/ethql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConsenSys/ethql/labels{/name}","releases_url":"https://api.github.com/repos/ConsenSys/ethql/releases{/id}","deployments_url":"https://api.github.com/repos/ConsenSys/ethql/deployments","created_at":"2018-02-17T00:34:40Z","updated_at":"2018-09-28T14:20:01Z","pushed_at":"2018-09-28T17:10:42Z","git_url":"git://github.com/ConsenSys/ethql.git","ssh_url":"git@github.com:ConsenSys/ethql.git","clone_url":"https://github.com/ConsenSys/ethql.git","svn_url":"https://github.com/ConsenSys/ethql","homepage":"","size":798,"stargazers_count":292,"watchers_count":292,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":23,"watchers":292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/108"},"html":{"href":"https://github.com/ConsenSys/ethql/pull/108"},"issue":{"href":"https://api.github.com/repos/ConsenSys/ethql/issues/108"},"comments":{"href":"https://api.github.com/repos/ConsenSys/ethql/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConsenSys/ethql/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/ConsenSys/ethql/statuses/94e25176f14df7b80f3a8aae5237f221ac06a454"}},"author_association":"NONE"}}
{"actor":{"display_login":"raulk"}}