{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/174218447","pull_request_review_id":103534058,"id":174218447,"diff_hunk":"@@ -43,8 +43,8 @@ groups:\n     description: Interval to watch whether bookie is dead or not, in milliseconds.\n     default: 1000\n   - param: flushInterval\n-    description: How long the interval to flush ledger index pages to disk, in milliseconds. Flushing index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure.\n-    default: 100\n+    description: When entryLogPerLedgerEnabled is enabled, checkpoint doesn't happens when a new active entrylog is created / previous one is rolled over. Instead SyncThread checkpoints periodically with 'flushInterval' delay (in milliseconds) in between executions. Checkpoint flushes both ledger entryLogs and ledger index pages to disk.  Flushing entrylog and index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure. This config is used only when entryLogPerLedgerEnabled is enabled.\n+    default: 10000\n   - param: allowStorageExpansion","path":"site/_data/config/bk_server.yaml","position":8,"original_position":8,"commit_id":"1e52cf49c8769a472c0d7f318340c987f430484f","original_commit_id":"1e52cf49c8769a472c0d7f318340c987f430484f","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"Arw we changing this?","created_at":"2018-03-13T17:28:19Z","updated_at":"2018-03-13T17:28:29Z","html_url":"https://github.com/apache/bookkeeper/pull/1236#discussion_r174218447","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/174218447"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1236#discussion_r174218447"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1236"}}},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1236","id":173658961,"html_url":"https://github.com/apache/bookkeeper/pull/1236","diff_url":"https://github.com/apache/bookkeeper/pull/1236.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1236.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1236","number":1236,"state":"open","locked":false,"title":"Issue #570: make changes to SyncThread/checkpoint logic.","user":{"login":"reddycharan","id":13989266,"avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"body":"Descriptions of the changes in this PR:\r\n\r\nmake changes to SyncThread/checkpoint logic, so that incase of\r\nentrylogperledger, checkpoint happens for every flushInterval\r\nbut not when active entrylog is created/rolled over.\r\n\r\nThis is < sub-task3  > of Issue #570\r\n\r\nMaster Issue: #570 \r\n","created_at":"2018-03-08T06:53:30Z","updated_at":"2018-03-13T17:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e64cb277cca991fcf4913cf51daaed979d4c064","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1236/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1236/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1236/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/1e52cf49c8769a472c0d7f318340c987f430484f","head":{"label":"reddycharan:addcheckpointlogic","ref":"addcheckpointlogic","sha":"1e52cf49c8769a472c0d7f318340c987f430484f","user":{"login":"reddycharan","id":13989266,"avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"repo":{"id":71182574,"name":"bookkeeper","full_name":"reddycharan/bookkeeper","owner":{"login":"reddycharan","id":13989266,"avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reddycharan/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/reddycharan/bookkeeper","forks_url":"https://api.github.com/repos/reddycharan/bookkeeper/forks","keys_url":"https://api.github.com/repos/reddycharan/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddycharan/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddycharan/bookkeeper/teams","hooks_url":"https://api.github.com/repos/reddycharan/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/reddycharan/bookkeeper/events","assignees_url":"https://api.github.com/repos/reddycharan/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/reddycharan/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/reddycharan/bookkeeper/tags","blobs_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddycharan/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/reddycharan/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/reddycharan/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/reddycharan/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/reddycharan/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/reddycharan/bookkeeper/subscription","commits_url":"https://api.github.com/repos/reddycharan/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddycharan/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddycharan/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/reddycharan/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddycharan/bookkeeper/merges","archive_url":"https://api.github.com/repos/reddycharan/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddycharan/bookkeeper/downloads","issues_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/reddycharan/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/reddycharan/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/reddycharan/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddycharan/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/reddycharan/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/reddycharan/bookkeeper/deployments","created_at":"2016-10-17T21:25:32Z","updated_at":"2016-10-17T21:25:35Z","pushed_at":"2018-03-13T07:31:04Z","git_url":"git://github.com/reddycharan/bookkeeper.git","ssh_url":"git@github.com:reddycharan/bookkeeper.git","clone_url":"https://github.com/reddycharan/bookkeeper.git","svn_url":"https://github.com/reddycharan/bookkeeper","homepage":null,"size":22743,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cefdeb6e3c6f4231ca8d09e93cc7f3dedd3a058f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-03-12T18:34:38Z","pushed_at":"2018-03-13T11:42:01Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":26362,"stargazers_count":288,"watchers_count":288,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":154,"open_issues":162,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1236"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1236"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1236"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1236/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1236/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1236/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/1e52cf49c8769a472c0d7f318340c987f430484f"}},"author_association":"NONE"}}
{"actor":{"display_login":"eolivelli"}}