{"action":"created","comment":{"url":"https://api.github.com/repos/stoplightio/spectral/pulls/comments/238882055","pull_request_review_id":181533243,"id":238882055,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODg4MjA1NQ==","diff_hunk":"@@ -87,7 +88,7 @@ export const commonOasRules = (): IRuleDeclaration => ({\n     type: RuleType.VALIDATION,\n     summary: 'Path parameters are correct and valid.',\n     enabled: true,\n-    severity: RuleSeverity.ERROR,\n+    severity: ValidationSeverity.Error,","path":"src/rulesets/oas/index.ts","position":12,"original_position":12,"commit_id":"faec887e91f676a0abd8bc4eb7353f891b4b8a0d","original_commit_id":"faec887e91f676a0abd8bc4eb7353f891b4b8a0d","user":{"login":"marbemac","id":847542,"node_id":"MDQ6VXNlcjg0NzU0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/847542?v=4","gravatar_id":"","url":"https://api.github.com/users/marbemac","html_url":"https://github.com/marbemac","followers_url":"https://api.github.com/users/marbemac/followers","following_url":"https://api.github.com/users/marbemac/following{/other_user}","gists_url":"https://api.github.com/users/marbemac/gists{/gist_id}","starred_url":"https://api.github.com/users/marbemac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marbemac/subscriptions","organizations_url":"https://api.github.com/users/marbemac/orgs","repos_url":"https://api.github.com/users/marbemac/repos","events_url":"https://api.github.com/users/marbemac/events{/privacy}","received_events_url":"https://api.github.com/users/marbemac/received_events","type":"User","site_admin":false},"body":"Numeric severity values are more useful from a programmatic perspective.\r\n\r\n```ts\r\nif (validation.severity >= RuleSeverity.ERROR) {\r\n    // sound the alarm!\r\n}\r\n```\r\n\r\nHuman facing stuff should now use `severityLabel`.","created_at":"2018-12-04T23:38:01Z","updated_at":"2018-12-04T23:38:01Z","html_url":"https://github.com/stoplightio/spectral/pull/60#discussion_r238882055","pull_request_url":"https://api.github.com/repos/stoplightio/spectral/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/comments/238882055"},"html":{"href":"https://github.com/stoplightio/spectral/pull/60#discussion_r238882055"},"pull_request":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/60"}},"in_reply_to_id":238818164},"pull_request":{"url":"https://api.github.com/repos/stoplightio/spectral/pulls/60","id":235899228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODk5MjI4","html_url":"https://github.com/stoplightio/spectral/pull/60","diff_url":"https://github.com/stoplightio/spectral/pull/60.diff","patch_url":"https://github.com/stoplightio/spectral/pull/60.patch","issue_url":"https://api.github.com/repos/stoplightio/spectral/issues/60","number":60,"state":"open","locked":false,"title":"SO-19, SO-20 refactor: reuse IValidationResult","user":{"login":"chris-miaskowski","id":29548931,"node_id":"MDQ6VXNlcjI5NTQ4OTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29548931?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-miaskowski","html_url":"https://github.com/chris-miaskowski","followers_url":"https://api.github.com/users/chris-miaskowski/followers","following_url":"https://api.github.com/users/chris-miaskowski/following{/other_user}","gists_url":"https://api.github.com/users/chris-miaskowski/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-miaskowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-miaskowski/subscriptions","organizations_url":"https://api.github.com/users/chris-miaskowski/orgs","repos_url":"https://api.github.com/users/chris-miaskowski/repos","events_url":"https://api.github.com/users/chris-miaskowski/events{/privacy}","received_events_url":"https://api.github.com/users/chris-miaskowski/received_events","type":"User","site_admin":false},"body":"SO-19\r\n\r\nBREAKING CHANGE: IRuleResult extends IValidationResult which has a required `severityLabel` field.\r\n\r\nI have updated the code to replace IRuleResult with IValidationResult. I left the original interface because it adds its own properties (and because the impact was much lower).","created_at":"2018-12-04T17:40:11Z","updated_at":"2018-12-04T23:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b353d540844dec86deb0db6d39f891da12a683f","assignee":{"login":"chris-miaskowski","id":29548931,"node_id":"MDQ6VXNlcjI5NTQ4OTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29548931?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-miaskowski","html_url":"https://github.com/chris-miaskowski","followers_url":"https://api.github.com/users/chris-miaskowski/followers","following_url":"https://api.github.com/users/chris-miaskowski/following{/other_user}","gists_url":"https://api.github.com/users/chris-miaskowski/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-miaskowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-miaskowski/subscriptions","organizations_url":"https://api.github.com/users/chris-miaskowski/orgs","repos_url":"https://api.github.com/users/chris-miaskowski/repos","events_url":"https://api.github.com/users/chris-miaskowski/events{/privacy}","received_events_url":"https://api.github.com/users/chris-miaskowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"chris-miaskowski","id":29548931,"node_id":"MDQ6VXNlcjI5NTQ4OTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29548931?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-miaskowski","html_url":"https://github.com/chris-miaskowski","followers_url":"https://api.github.com/users/chris-miaskowski/followers","following_url":"https://api.github.com/users/chris-miaskowski/following{/other_user}","gists_url":"https://api.github.com/users/chris-miaskowski/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-miaskowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-miaskowski/subscriptions","organizations_url":"https://api.github.com/users/chris-miaskowski/orgs","repos_url":"https://api.github.com/users/chris-miaskowski/repos","events_url":"https://api.github.com/users/chris-miaskowski/events{/privacy}","received_events_url":"https://api.github.com/users/chris-miaskowski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"marbemac","id":847542,"node_id":"MDQ6VXNlcjg0NzU0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/847542?v=4","gravatar_id":"","url":"https://api.github.com/users/marbemac","html_url":"https://github.com/marbemac","followers_url":"https://api.github.com/users/marbemac/followers","following_url":"https://api.github.com/users/marbemac/following{/other_user}","gists_url":"https://api.github.com/users/marbemac/gists{/gist_id}","starred_url":"https://api.github.com/users/marbemac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marbemac/subscriptions","organizations_url":"https://api.github.com/users/marbemac/orgs","repos_url":"https://api.github.com/users/marbemac/repos","events_url":"https://api.github.com/users/marbemac/events{/privacy}","received_events_url":"https://api.github.com/users/marbemac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stoplightio/spectral/pulls/60/commits","review_comments_url":"https://api.github.com/repos/stoplightio/spectral/pulls/60/comments","review_comment_url":"https://api.github.com/repos/stoplightio/spectral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stoplightio/spectral/issues/60/comments","statuses_url":"https://api.github.com/repos/stoplightio/spectral/statuses/faec887e91f676a0abd8bc4eb7353f891b4b8a0d","head":{"label":"stoplightio:chore/so-19/upgrade-to-use-stoplight-types","ref":"chore/so-19/upgrade-to-use-stoplight-types","sha":"faec887e91f676a0abd8bc4eb7353f891b4b8a0d","user":{"login":"stoplightio","id":10767217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY3MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/10767217?v=4","gravatar_id":"","url":"https://api.github.com/users/stoplightio","html_url":"https://github.com/stoplightio","followers_url":"https://api.github.com/users/stoplightio/followers","following_url":"https://api.github.com/users/stoplightio/following{/other_user}","gists_url":"https://api.github.com/users/stoplightio/gists{/gist_id}","starred_url":"https://api.github.com/users/stoplightio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoplightio/subscriptions","organizations_url":"https://api.github.com/users/stoplightio/orgs","repos_url":"https://api.github.com/users/stoplightio/repos","events_url":"https://api.github.com/users/stoplightio/events{/privacy}","received_events_url":"https://api.github.com/users/stoplightio/received_events","type":"Organization","site_admin":false},"repo":{"id":144890632,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4OTA2MzI=","name":"spectral","full_name":"stoplightio/spectral","private":false,"owner":{"login":"stoplightio","id":10767217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY3MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/10767217?v=4","gravatar_id":"","url":"https://api.github.com/users/stoplightio","html_url":"https://github.com/stoplightio","followers_url":"https://api.github.com/users/stoplightio/followers","following_url":"https://api.github.com/users/stoplightio/following{/other_user}","gists_url":"https://api.github.com/users/stoplightio/gists{/gist_id}","starred_url":"https://api.github.com/users/stoplightio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoplightio/subscriptions","organizations_url":"https://api.github.com/users/stoplightio/orgs","repos_url":"https://api.github.com/users/stoplightio/repos","events_url":"https://api.github.com/users/stoplightio/events{/privacy}","received_events_url":"https://api.github.com/users/stoplightio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stoplightio/spectral","description":"A generic object linting and rule engine","fork":false,"url":"https://api.github.com/repos/stoplightio/spectral","forks_url":"https://api.github.com/repos/stoplightio/spectral/forks","keys_url":"https://api.github.com/repos/stoplightio/spectral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stoplightio/spectral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stoplightio/spectral/teams","hooks_url":"https://api.github.com/repos/stoplightio/spectral/hooks","issue_events_url":"https://api.github.com/repos/stoplightio/spectral/issues/events{/number}","events_url":"https://api.github.com/repos/stoplightio/spectral/events","assignees_url":"https://api.github.com/repos/stoplightio/spectral/assignees{/user}","branches_url":"https://api.github.com/repos/stoplightio/spectral/branches{/branch}","tags_url":"https://api.github.com/repos/stoplightio/spectral/tags","blobs_url":"https://api.github.com/repos/stoplightio/spectral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stoplightio/spectral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stoplightio/spectral/git/refs{/sha}","trees_url":"https://api.github.com/repos/stoplightio/spectral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stoplightio/spectral/statuses/{sha}","languages_url":"https://api.github.com/repos/stoplightio/spectral/languages","stargazers_url":"https://api.github.com/repos/stoplightio/spectral/stargazers","contributors_url":"https://api.github.com/repos/stoplightio/spectral/contributors","subscribers_url":"https://api.github.com/repos/stoplightio/spectral/subscribers","subscription_url":"https://api.github.com/repos/stoplightio/spectral/subscription","commits_url":"https://api.github.com/repos/stoplightio/spectral/commits{/sha}","git_commits_url":"https://api.github.com/repos/stoplightio/spectral/git/commits{/sha}","comments_url":"https://api.github.com/repos/stoplightio/spectral/comments{/number}","issue_comment_url":"https://api.github.com/repos/stoplightio/spectral/issues/comments{/number}","contents_url":"https://api.github.com/repos/stoplightio/spectral/contents/{+path}","compare_url":"https://api.github.com/repos/stoplightio/spectral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stoplightio/spectral/merges","archive_url":"https://api.github.com/repos/stoplightio/spectral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stoplightio/spectral/downloads","issues_url":"https://api.github.com/repos/stoplightio/spectral/issues{/number}","pulls_url":"https://api.github.com/repos/stoplightio/spectral/pulls{/number}","milestones_url":"https://api.github.com/repos/stoplightio/spectral/milestones{/number}","notifications_url":"https://api.github.com/repos/stoplightio/spectral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stoplightio/spectral/labels{/name}","releases_url":"https://api.github.com/repos/stoplightio/spectral/releases{/id}","deployments_url":"https://api.github.com/repos/stoplightio/spectral/deployments","created_at":"2018-08-15T18:43:18Z","updated_at":"2018-12-04T19:25:55Z","pushed_at":"2018-12-04T18:39:47Z","git_url":"git://github.com/stoplightio/spectral.git","ssh_url":"git@github.com:stoplightio/spectral.git","clone_url":"https://github.com/stoplightio/spectral.git","svn_url":"https://github.com/stoplightio/spectral","homepage":null,"size":814,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":8,"default_branch":"develop"}},"base":{"label":"stoplightio:develop","ref":"develop","sha":"ba09f898c5ecc6717f4640dd1d14bcb13d707bb2","user":{"login":"stoplightio","id":10767217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY3MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/10767217?v=4","gravatar_id":"","url":"https://api.github.com/users/stoplightio","html_url":"https://github.com/stoplightio","followers_url":"https://api.github.com/users/stoplightio/followers","following_url":"https://api.github.com/users/stoplightio/following{/other_user}","gists_url":"https://api.github.com/users/stoplightio/gists{/gist_id}","starred_url":"https://api.github.com/users/stoplightio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoplightio/subscriptions","organizations_url":"https://api.github.com/users/stoplightio/orgs","repos_url":"https://api.github.com/users/stoplightio/repos","events_url":"https://api.github.com/users/stoplightio/events{/privacy}","received_events_url":"https://api.github.com/users/stoplightio/received_events","type":"Organization","site_admin":false},"repo":{"id":144890632,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4OTA2MzI=","name":"spectral","full_name":"stoplightio/spectral","private":false,"owner":{"login":"stoplightio","id":10767217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY3MjE3","avatar_url":"https://avatars1.githubusercontent.com/u/10767217?v=4","gravatar_id":"","url":"https://api.github.com/users/stoplightio","html_url":"https://github.com/stoplightio","followers_url":"https://api.github.com/users/stoplightio/followers","following_url":"https://api.github.com/users/stoplightio/following{/other_user}","gists_url":"https://api.github.com/users/stoplightio/gists{/gist_id}","starred_url":"https://api.github.com/users/stoplightio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stoplightio/subscriptions","organizations_url":"https://api.github.com/users/stoplightio/orgs","repos_url":"https://api.github.com/users/stoplightio/repos","events_url":"https://api.github.com/users/stoplightio/events{/privacy}","received_events_url":"https://api.github.com/users/stoplightio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stoplightio/spectral","description":"A generic object linting and rule engine","fork":false,"url":"https://api.github.com/repos/stoplightio/spectral","forks_url":"https://api.github.com/repos/stoplightio/spectral/forks","keys_url":"https://api.github.com/repos/stoplightio/spectral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stoplightio/spectral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stoplightio/spectral/teams","hooks_url":"https://api.github.com/repos/stoplightio/spectral/hooks","issue_events_url":"https://api.github.com/repos/stoplightio/spectral/issues/events{/number}","events_url":"https://api.github.com/repos/stoplightio/spectral/events","assignees_url":"https://api.github.com/repos/stoplightio/spectral/assignees{/user}","branches_url":"https://api.github.com/repos/stoplightio/spectral/branches{/branch}","tags_url":"https://api.github.com/repos/stoplightio/spectral/tags","blobs_url":"https://api.github.com/repos/stoplightio/spectral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stoplightio/spectral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stoplightio/spectral/git/refs{/sha}","trees_url":"https://api.github.com/repos/stoplightio/spectral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stoplightio/spectral/statuses/{sha}","languages_url":"https://api.github.com/repos/stoplightio/spectral/languages","stargazers_url":"https://api.github.com/repos/stoplightio/spectral/stargazers","contributors_url":"https://api.github.com/repos/stoplightio/spectral/contributors","subscribers_url":"https://api.github.com/repos/stoplightio/spectral/subscribers","subscription_url":"https://api.github.com/repos/stoplightio/spectral/subscription","commits_url":"https://api.github.com/repos/stoplightio/spectral/commits{/sha}","git_commits_url":"https://api.github.com/repos/stoplightio/spectral/git/commits{/sha}","comments_url":"https://api.github.com/repos/stoplightio/spectral/comments{/number}","issue_comment_url":"https://api.github.com/repos/stoplightio/spectral/issues/comments{/number}","contents_url":"https://api.github.com/repos/stoplightio/spectral/contents/{+path}","compare_url":"https://api.github.com/repos/stoplightio/spectral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stoplightio/spectral/merges","archive_url":"https://api.github.com/repos/stoplightio/spectral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stoplightio/spectral/downloads","issues_url":"https://api.github.com/repos/stoplightio/spectral/issues{/number}","pulls_url":"https://api.github.com/repos/stoplightio/spectral/pulls{/number}","milestones_url":"https://api.github.com/repos/stoplightio/spectral/milestones{/number}","notifications_url":"https://api.github.com/repos/stoplightio/spectral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stoplightio/spectral/labels{/name}","releases_url":"https://api.github.com/repos/stoplightio/spectral/releases{/id}","deployments_url":"https://api.github.com/repos/stoplightio/spectral/deployments","created_at":"2018-08-15T18:43:18Z","updated_at":"2018-12-04T19:25:55Z","pushed_at":"2018-12-04T18:39:47Z","git_url":"git://github.com/stoplightio/spectral.git","ssh_url":"git@github.com:stoplightio/spectral.git","clone_url":"https://github.com/stoplightio/spectral.git","svn_url":"https://github.com/stoplightio/spectral","homepage":null,"size":814,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/60"},"html":{"href":"https://github.com/stoplightio/spectral/pull/60"},"issue":{"href":"https://api.github.com/repos/stoplightio/spectral/issues/60"},"comments":{"href":"https://api.github.com/repos/stoplightio/spectral/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stoplightio/spectral/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/stoplightio/spectral/statuses/faec887e91f676a0abd8bc4eb7353f891b4b8a0d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marbemac"}}