{"action":"opened","number":20,"pull_request":{"url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20","id":228895721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODk1NzIx","html_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy/pull/20","diff_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy/pull/20.diff","patch_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy/pull/20.patch","issue_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/20","number":20,"state":"open","locked":false,"title":"Support InAppMessageControllerDelegate","user":{"login":"dmiluski","id":5083390,"node_id":"MDQ6VXNlcjUwODMzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5083390?v=4","gravatar_id":"","url":"https://api.github.com/users/dmiluski","html_url":"https://github.com/dmiluski","followers_url":"https://api.github.com/users/dmiluski/followers","following_url":"https://api.github.com/users/dmiluski/following{/other_user}","gists_url":"https://api.github.com/users/dmiluski/gists{/gist_id}","starred_url":"https://api.github.com/users/dmiluski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmiluski/subscriptions","organizations_url":"https://api.github.com/users/dmiluski/orgs","repos_url":"https://api.github.com/users/dmiluski/repos","events_url":"https://api.github.com/users/dmiluski/events{/privacy}","received_events_url":"https://api.github.com/users/dmiluski/received_events","type":"User","site_admin":false},"body":"Problem:\r\nWhile attempting to leverage inAppMessageControllerDelegate, I noticed I was not able to get Delegate Callbacks.\r\n\r\nInvestigation:\r\nNoticed that although a static member was declared for inAppMessageControllerDelegate, this value was never used\r\n\r\nChange:\r\nIf the static delegate member is set before the SharedInstance is initialized, pass into iVar delegate.\r\n\r\nThere's likely many more optimizations to support changing. As well as updating the delegate to be weak instead of strong? But wanted to get the ball rolling on this with eyes that are more aware of the models/functionality (honestly even objc styling here)","created_at":"2018-11-07T02:09:50Z","updated_at":"2018-11-07T02:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20/commits","review_comments_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20/comments","review_comment_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/20/comments","statuses_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/statuses/9ba3d969a7e0473c136843b9d99d42eb663948d1","head":{"label":"dmiluski:feature/SupportInAppMessageDelegate","ref":"feature/SupportInAppMessageDelegate","sha":"9ba3d969a7e0473c136843b9d99d42eb663948d1","user":{"login":"dmiluski","id":5083390,"node_id":"MDQ6VXNlcjUwODMzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5083390?v=4","gravatar_id":"","url":"https://api.github.com/users/dmiluski","html_url":"https://github.com/dmiluski","followers_url":"https://api.github.com/users/dmiluski/followers","following_url":"https://api.github.com/users/dmiluski/following{/other_user}","gists_url":"https://api.github.com/users/dmiluski/gists{/gist_id}","starred_url":"https://api.github.com/users/dmiluski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmiluski/subscriptions","organizations_url":"https://api.github.com/users/dmiluski/orgs","repos_url":"https://api.github.com/users/dmiluski/repos","events_url":"https://api.github.com/users/dmiluski/events{/privacy}","received_events_url":"https://api.github.com/users/dmiluski/received_events","type":"User","site_admin":false},"repo":{"id":156474992,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0NzQ5OTI=","name":"mparticle-apple-integration-appboy","full_name":"dmiluski/mparticle-apple-integration-appboy","private":false,"owner":{"login":"dmiluski","id":5083390,"node_id":"MDQ6VXNlcjUwODMzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5083390?v=4","gravatar_id":"","url":"https://api.github.com/users/dmiluski","html_url":"https://github.com/dmiluski","followers_url":"https://api.github.com/users/dmiluski/followers","following_url":"https://api.github.com/users/dmiluski/following{/other_user}","gists_url":"https://api.github.com/users/dmiluski/gists{/gist_id}","starred_url":"https://api.github.com/users/dmiluski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmiluski/subscriptions","organizations_url":"https://api.github.com/users/dmiluski/orgs","repos_url":"https://api.github.com/users/dmiluski/repos","events_url":"https://api.github.com/users/dmiluski/events{/privacy}","received_events_url":"https://api.github.com/users/dmiluski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmiluski/mparticle-apple-integration-appboy","description":null,"fork":true,"url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy","forks_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/forks","keys_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/teams","hooks_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/hooks","issue_events_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/issues/events{/number}","events_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/events","assignees_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/assignees{/user}","branches_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/branches{/branch}","tags_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/tags","blobs_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/statuses/{sha}","languages_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/languages","stargazers_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/stargazers","contributors_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/contributors","subscribers_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/subscribers","subscription_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/subscription","commits_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/contents/{+path}","compare_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/merges","archive_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/downloads","issues_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/issues{/number}","pulls_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/pulls{/number}","milestones_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/milestones{/number}","notifications_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/labels{/name}","releases_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/releases{/id}","deployments_url":"https://api.github.com/repos/dmiluski/mparticle-apple-integration-appboy/deployments","created_at":"2018-11-07T01:50:57Z","updated_at":"2018-11-07T01:50:59Z","pushed_at":"2018-11-07T02:08:44Z","git_url":"git://github.com/dmiluski/mparticle-apple-integration-appboy.git","ssh_url":"git@github.com:dmiluski/mparticle-apple-integration-appboy.git","clone_url":"https://github.com/dmiluski/mparticle-apple-integration-appboy.git","svn_url":"https://github.com/dmiluski/mparticle-apple-integration-appboy","homepage":null,"size":117,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mparticle-integrations:master","ref":"master","sha":"a1d294b56b6d5445423c9e0e474625e303b28c9f","user":{"login":"mparticle-integrations","id":18220302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjIwMzAy","avatar_url":"https://avatars0.githubusercontent.com/u/18220302?v=4","gravatar_id":"","url":"https://api.github.com/users/mparticle-integrations","html_url":"https://github.com/mparticle-integrations","followers_url":"https://api.github.com/users/mparticle-integrations/followers","following_url":"https://api.github.com/users/mparticle-integrations/following{/other_user}","gists_url":"https://api.github.com/users/mparticle-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/mparticle-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mparticle-integrations/subscriptions","organizations_url":"https://api.github.com/users/mparticle-integrations/orgs","repos_url":"https://api.github.com/users/mparticle-integrations/repos","events_url":"https://api.github.com/users/mparticle-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/mparticle-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":57216044,"node_id":"MDEwOlJlcG9zaXRvcnk1NzIxNjA0NA==","name":"mparticle-apple-integration-appboy","full_name":"mparticle-integrations/mparticle-apple-integration-appboy","private":false,"owner":{"login":"mparticle-integrations","id":18220302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjIwMzAy","avatar_url":"https://avatars0.githubusercontent.com/u/18220302?v=4","gravatar_id":"","url":"https://api.github.com/users/mparticle-integrations","html_url":"https://github.com/mparticle-integrations","followers_url":"https://api.github.com/users/mparticle-integrations/followers","following_url":"https://api.github.com/users/mparticle-integrations/following{/other_user}","gists_url":"https://api.github.com/users/mparticle-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/mparticle-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mparticle-integrations/subscriptions","organizations_url":"https://api.github.com/users/mparticle-integrations/orgs","repos_url":"https://api.github.com/users/mparticle-integrations/repos","events_url":"https://api.github.com/users/mparticle-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/mparticle-integrations/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy","description":null,"fork":false,"url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy","forks_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/forks","keys_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/teams","hooks_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/hooks","issue_events_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/events{/number}","events_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/events","assignees_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/assignees{/user}","branches_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/branches{/branch}","tags_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/tags","blobs_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/statuses/{sha}","languages_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/languages","stargazers_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/stargazers","contributors_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/contributors","subscribers_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/subscribers","subscription_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/subscription","commits_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/contents/{+path}","compare_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/merges","archive_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/downloads","issues_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues{/number}","pulls_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls{/number}","milestones_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/milestones{/number}","notifications_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/labels{/name}","releases_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/releases{/id}","deployments_url":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/deployments","created_at":"2016-04-27T13:37:08Z","updated_at":"2018-10-31T06:04:34Z","pushed_at":"2018-10-17T16:28:55Z","git_url":"git://github.com/mparticle-integrations/mparticle-apple-integration-appboy.git","ssh_url":"git@github.com:mparticle-integrations/mparticle-apple-integration-appboy.git","clone_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy.git","svn_url":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy","homepage":null,"size":117,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20"},"html":{"href":"https://github.com/mparticle-integrations/mparticle-apple-integration-appboy/pull/20"},"issue":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/20"},"comments":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/mparticle-integrations/mparticle-apple-integration-appboy/statuses/9ba3d969a7e0473c136843b9d99d42eb663948d1"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"dmiluski"}}