{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/204125051","pull_request_review_id":139154293,"id":204125051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEyNTA1MQ==","diff_hunk":"@@ -94,5 +95,9 @@ def assert_daemon_set_up\n     def assert_stateful_set_up\n       assert_stateful_set_present(\"stateful-busybox\")\n     end\n+\n+    def assert_crd_up\n+      assert_crd_present(\"mails.stable.example.io\")","path":"test/helpers/fixture_sets/hello_cloud.rb","position":14,"original_position":14,"commit_id":"a300fc604ba9c6315179b304287d0272bebb91bd","original_commit_id":"a300fc604ba9c6315179b304287d0272bebb91bd","user":{"login":"KnVerey","id":4789493,"node_id":"MDQ6VXNlcjQ3ODk0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4789493?v=4","gravatar_id":"","url":"https://api.github.com/users/KnVerey","html_url":"https://github.com/KnVerey","followers_url":"https://api.github.com/users/KnVerey/followers","following_url":"https://api.github.com/users/KnVerey/following{/other_user}","gists_url":"https://api.github.com/users/KnVerey/gists{/gist_id}","starred_url":"https://api.github.com/users/KnVerey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnVerey/subscriptions","organizations_url":"https://api.github.com/users/KnVerey/orgs","repos_url":"https://api.github.com/users/KnVerey/repos","events_url":"https://api.github.com/users/KnVerey/events{/privacy}","received_events_url":"https://api.github.com/users/KnVerey/received_events","type":"User","site_admin":false},"body":"The `mails` plural still irks me :P","created_at":"2018-07-20T18:02:22Z","updated_at":"2018-07-20T18:10:03Z","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/306#discussion_r204125051","pull_request_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments/204125051"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/306#discussion_r204125051"},"pull_request":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306","id":197886316,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODg2MzE2","html_url":"https://github.com/Shopify/kubernetes-deploy/pull/306","diff_url":"https://github.com/Shopify/kubernetes-deploy/pull/306.diff","patch_url":"https://github.com/Shopify/kubernetes-deploy/pull/306.patch","issue_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/306","number":306,"state":"open","locked":false,"title":"Add crd","user":{"login":"dturn","id":12193286,"node_id":"MDQ6VXNlcjEyMTkzMjg2","avatar_url":"https://avatars0.githubusercontent.com/u/12193286?v=4","gravatar_id":"","url":"https://api.github.com/users/dturn","html_url":"https://github.com/dturn","followers_url":"https://api.github.com/users/dturn/followers","following_url":"https://api.github.com/users/dturn/following{/other_user}","gists_url":"https://api.github.com/users/dturn/gists{/gist_id}","starred_url":"https://api.github.com/users/dturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturn/subscriptions","organizations_url":"https://api.github.com/users/dturn/orgs","repos_url":"https://api.github.com/users/dturn/repos","events_url":"https://api.github.com/users/dturn/events{/privacy}","received_events_url":"https://api.github.com/users/dturn/received_events","type":"User","site_admin":false},"body":"Add CRD Resource (part of splitting of https://github.com/Shopify/kubernetes-deploy/pull/188/files)\r\n\r\nSuccess of failure based on the `NamesAccepted` status condition. Is not very sophisticated, but better than nothing.\r\n\r\n<img width=\"1118\" alt=\"screen shot 2018-07-17 at 10 05 31 am\" src=\"https://user-images.githubusercontent.com/12193286/42833484-046aa0b0-89a9-11e8-8234-95a73dea72a7.png\">\r\n","created_at":"2018-06-28T00:16:44Z","updated_at":"2018-07-20T18:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9e4cef90bca35078a26206a1ba1ec563898542","assignee":null,"assignees":[],"requested_reviewers":[{"login":"klautcomputing","id":3520174,"node_id":"MDQ6VXNlcjM1MjAxNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3520174?v=4","gravatar_id":"","url":"https://api.github.com/users/klautcomputing","html_url":"https://github.com/klautcomputing","followers_url":"https://api.github.com/users/klautcomputing/followers","following_url":"https://api.github.com/users/klautcomputing/following{/other_user}","gists_url":"https://api.github.com/users/klautcomputing/gists{/gist_id}","starred_url":"https://api.github.com/users/klautcomputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klautcomputing/subscriptions","organizations_url":"https://api.github.com/users/klautcomputing/orgs","repos_url":"https://api.github.com/users/klautcomputing/repos","events_url":"https://api.github.com/users/klautcomputing/events{/privacy}","received_events_url":"https://api.github.com/users/klautcomputing/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306/commits","review_comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306/comments","review_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/306/comments","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/a300fc604ba9c6315179b304287d0272bebb91bd","head":{"label":"Shopify:add-crd","ref":"add-crd","sha":"a300fc604ba9c6315179b304287d0272bebb91bd","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-07-20T12:53:16Z","pushed_at":"2018-07-20T16:21:13Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6756,"stargazers_count":458,"watchers_count":458,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":45,"watchers":458,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"435b5453d051fc63313477574e1c632e9c36bd6d","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79269805,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTgwNQ==","name":"kubernetes-deploy","full_name":"Shopify/kubernetes-deploy","owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/kubernetes-deploy","description":"A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result","fork":false,"url":"https://api.github.com/repos/Shopify/kubernetes-deploy","forks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/forks","keys_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/teams","hooks_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/events","assignees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/tags","blobs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/languages","stargazers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/subscription","commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/merges","archive_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/downloads","issues_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/kubernetes-deploy/deployments","created_at":"2017-01-17T20:41:23Z","updated_at":"2018-07-20T12:53:16Z","pushed_at":"2018-07-20T16:21:13Z","git_url":"git://github.com/Shopify/kubernetes-deploy.git","ssh_url":"git@github.com:Shopify/kubernetes-deploy.git","clone_url":"https://github.com/Shopify/kubernetes-deploy.git","svn_url":"https://github.com/Shopify/kubernetes-deploy","homepage":"","size":6756,"stargazers_count":458,"watchers_count":458,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":45,"watchers":458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306"},"html":{"href":"https://github.com/Shopify/kubernetes-deploy/pull/306"},"issue":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/306"},"comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/kubernetes-deploy/statuses/a300fc604ba9c6315179b304287d0272bebb91bd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KnVerey"}}