{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/jakubfrieb/Route/pulls/1","id":216692870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjkyODcw","html_url":"https://github.com/jakubfrieb/Route/pull/1","diff_url":"https://github.com/jakubfrieb/Route/pull/1.diff","patch_url":"https://github.com/jakubfrieb/Route/pull/1.patch","issue_url":"https://api.github.com/repos/jakubfrieb/Route/issues/1","number":1,"state":"closed","locked":false,"title":"Fixing various bugs and coding standards","user":{"login":"physcocode","id":7591484,"node_id":"MDQ6VXNlcjc1OTE0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7591484?v=4","gravatar_id":"","url":"https://api.github.com/users/physcocode","html_url":"https://github.com/physcocode","followers_url":"https://api.github.com/users/physcocode/followers","following_url":"https://api.github.com/users/physcocode/following{/other_user}","gists_url":"https://api.github.com/users/physcocode/gists{/gist_id}","starred_url":"https://api.github.com/users/physcocode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/physcocode/subscriptions","organizations_url":"https://api.github.com/users/physcocode/orgs","repos_url":"https://api.github.com/users/physcocode/repos","events_url":"https://api.github.com/users/physcocode/events{/privacy}","received_events_url":"https://api.github.com/users/physcocode/received_events","type":"User","site_admin":false},"body":"Hello there,\r\n Thank you for using Router, the code were little sloppy and unfinished, I have bought in various improvement to the system,   reduced the code and even added some tests to make sure everything is up and running, Various fixes you applied in your branch are incorporated in the core. \r\n\r\nI have also added PSR 7 standards by using Request and Response object for processing routes. Any ideas on future improvements are welcome :)","created_at":"2018-09-19T15:59:04Z","updated_at":"2018-09-19T19:18:30Z","closed_at":"2018-09-19T19:18:30Z","merged_at":"2018-09-19T19:18:30Z","merge_commit_sha":"cc5d0571b17eb0714ee52879c2e2f932df436672","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jakubfrieb/Route/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jakubfrieb/Route/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jakubfrieb/Route/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jakubfrieb/Route/issues/1/comments","statuses_url":"https://api.github.com/repos/jakubfrieb/Route/statuses/6d206434a5c418a39eca7777cffda027bf3bd14f","head":{"label":"Scrawler-php:master","ref":"master","sha":"6d206434a5c418a39eca7777cffda027bf3bd14f","user":{"login":"Scrawler-php","id":39265685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1Njg1","avatar_url":"https://avatars1.githubusercontent.com/u/39265685?v=4","gravatar_id":"","url":"https://api.github.com/users/Scrawler-php","html_url":"https://github.com/Scrawler-php","followers_url":"https://api.github.com/users/Scrawler-php/followers","following_url":"https://api.github.com/users/Scrawler-php/following{/other_user}","gists_url":"https://api.github.com/users/Scrawler-php/gists{/gist_id}","starred_url":"https://api.github.com/users/Scrawler-php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scrawler-php/subscriptions","organizations_url":"https://api.github.com/users/Scrawler-php/orgs","repos_url":"https://api.github.com/users/Scrawler-php/repos","events_url":"https://api.github.com/users/Scrawler-php/events{/privacy}","received_events_url":"https://api.github.com/users/Scrawler-php/received_events","type":"Organization","site_admin":false},"repo":{"id":90492398,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQ5MjM5OA==","name":"Router","full_name":"Scrawler-php/Router","private":false,"owner":{"login":"Scrawler-php","id":39265685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1Njg1","avatar_url":"https://avatars1.githubusercontent.com/u/39265685?v=4","gravatar_id":"","url":"https://api.github.com/users/Scrawler-php","html_url":"https://github.com/Scrawler-php","followers_url":"https://api.github.com/users/Scrawler-php/followers","following_url":"https://api.github.com/users/Scrawler-php/following{/other_user}","gists_url":"https://api.github.com/users/Scrawler-php/gists{/gist_id}","starred_url":"https://api.github.com/users/Scrawler-php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scrawler-php/subscriptions","organizations_url":"https://api.github.com/users/Scrawler-php/orgs","repos_url":"https://api.github.com/users/Scrawler-php/repos","events_url":"https://api.github.com/users/Scrawler-php/events{/privacy}","received_events_url":"https://api.github.com/users/Scrawler-php/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Scrawler-php/Router","description":"An Fully Automatic RESTful PHP Router","fork":false,"url":"https://api.github.com/repos/Scrawler-php/Router","forks_url":"https://api.github.com/repos/Scrawler-php/Router/forks","keys_url":"https://api.github.com/repos/Scrawler-php/Router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scrawler-php/Router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scrawler-php/Router/teams","hooks_url":"https://api.github.com/repos/Scrawler-php/Router/hooks","issue_events_url":"https://api.github.com/repos/Scrawler-php/Router/issues/events{/number}","events_url":"https://api.github.com/repos/Scrawler-php/Router/events","assignees_url":"https://api.github.com/repos/Scrawler-php/Router/assignees{/user}","branches_url":"https://api.github.com/repos/Scrawler-php/Router/branches{/branch}","tags_url":"https://api.github.com/repos/Scrawler-php/Router/tags","blobs_url":"https://api.github.com/repos/Scrawler-php/Router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scrawler-php/Router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scrawler-php/Router/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scrawler-php/Router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scrawler-php/Router/statuses/{sha}","languages_url":"https://api.github.com/repos/Scrawler-php/Router/languages","stargazers_url":"https://api.github.com/repos/Scrawler-php/Router/stargazers","contributors_url":"https://api.github.com/repos/Scrawler-php/Router/contributors","subscribers_url":"https://api.github.com/repos/Scrawler-php/Router/subscribers","subscription_url":"https://api.github.com/repos/Scrawler-php/Router/subscription","commits_url":"https://api.github.com/repos/Scrawler-php/Router/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scrawler-php/Router/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scrawler-php/Router/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scrawler-php/Router/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scrawler-php/Router/contents/{+path}","compare_url":"https://api.github.com/repos/Scrawler-php/Router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scrawler-php/Router/merges","archive_url":"https://api.github.com/repos/Scrawler-php/Router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scrawler-php/Router/downloads","issues_url":"https://api.github.com/repos/Scrawler-php/Router/issues{/number}","pulls_url":"https://api.github.com/repos/Scrawler-php/Router/pulls{/number}","milestones_url":"https://api.github.com/repos/Scrawler-php/Router/milestones{/number}","notifications_url":"https://api.github.com/repos/Scrawler-php/Router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scrawler-php/Router/labels{/name}","releases_url":"https://api.github.com/repos/Scrawler-php/Router/releases{/id}","deployments_url":"https://api.github.com/repos/Scrawler-php/Router/deployments","created_at":"2017-05-06T21:33:24Z","updated_at":"2018-09-19T19:17:28Z","pushed_at":"2018-09-19T19:17:26Z","git_url":"git://github.com/Scrawler-php/Router.git","ssh_url":"git@github.com:Scrawler-php/Router.git","clone_url":"https://github.com/Scrawler-php/Router.git","svn_url":"https://github.com/Scrawler-php/Router","homepage":null,"size":42,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"jakubfrieb:master","ref":"master","sha":"039bb01bee0d005efbe5164e8db9d7c085f10e9b","user":{"login":"jakubfrieb","id":7541799,"node_id":"MDQ6VXNlcjc1NDE3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7541799?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubfrieb","html_url":"https://github.com/jakubfrieb","followers_url":"https://api.github.com/users/jakubfrieb/followers","following_url":"https://api.github.com/users/jakubfrieb/following{/other_user}","gists_url":"https://api.github.com/users/jakubfrieb/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubfrieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubfrieb/subscriptions","organizations_url":"https://api.github.com/users/jakubfrieb/orgs","repos_url":"https://api.github.com/users/jakubfrieb/repos","events_url":"https://api.github.com/users/jakubfrieb/events{/privacy}","received_events_url":"https://api.github.com/users/jakubfrieb/received_events","type":"User","site_admin":false},"repo":{"id":127777543,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc3Nzc1NDM=","name":"Route","full_name":"jakubfrieb/Route","private":false,"owner":{"login":"jakubfrieb","id":7541799,"node_id":"MDQ6VXNlcjc1NDE3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7541799?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubfrieb","html_url":"https://github.com/jakubfrieb","followers_url":"https://api.github.com/users/jakubfrieb/followers","following_url":"https://api.github.com/users/jakubfrieb/following{/other_user}","gists_url":"https://api.github.com/users/jakubfrieb/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubfrieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubfrieb/subscriptions","organizations_url":"https://api.github.com/users/jakubfrieb/orgs","repos_url":"https://api.github.com/users/jakubfrieb/repos","events_url":"https://api.github.com/users/jakubfrieb/events{/privacy}","received_events_url":"https://api.github.com/users/jakubfrieb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jakubfrieb/Route","description":"An Fully Automatic RESTful PHP Router","fork":true,"url":"https://api.github.com/repos/jakubfrieb/Route","forks_url":"https://api.github.com/repos/jakubfrieb/Route/forks","keys_url":"https://api.github.com/repos/jakubfrieb/Route/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakubfrieb/Route/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakubfrieb/Route/teams","hooks_url":"https://api.github.com/repos/jakubfrieb/Route/hooks","issue_events_url":"https://api.github.com/repos/jakubfrieb/Route/issues/events{/number}","events_url":"https://api.github.com/repos/jakubfrieb/Route/events","assignees_url":"https://api.github.com/repos/jakubfrieb/Route/assignees{/user}","branches_url":"https://api.github.com/repos/jakubfrieb/Route/branches{/branch}","tags_url":"https://api.github.com/repos/jakubfrieb/Route/tags","blobs_url":"https://api.github.com/repos/jakubfrieb/Route/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakubfrieb/Route/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakubfrieb/Route/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakubfrieb/Route/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakubfrieb/Route/statuses/{sha}","languages_url":"https://api.github.com/repos/jakubfrieb/Route/languages","stargazers_url":"https://api.github.com/repos/jakubfrieb/Route/stargazers","contributors_url":"https://api.github.com/repos/jakubfrieb/Route/contributors","subscribers_url":"https://api.github.com/repos/jakubfrieb/Route/subscribers","subscription_url":"https://api.github.com/repos/jakubfrieb/Route/subscription","commits_url":"https://api.github.com/repos/jakubfrieb/Route/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakubfrieb/Route/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakubfrieb/Route/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakubfrieb/Route/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakubfrieb/Route/contents/{+path}","compare_url":"https://api.github.com/repos/jakubfrieb/Route/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakubfrieb/Route/merges","archive_url":"https://api.github.com/repos/jakubfrieb/Route/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakubfrieb/Route/downloads","issues_url":"https://api.github.com/repos/jakubfrieb/Route/issues{/number}","pulls_url":"https://api.github.com/repos/jakubfrieb/Route/pulls{/number}","milestones_url":"https://api.github.com/repos/jakubfrieb/Route/milestones{/number}","notifications_url":"https://api.github.com/repos/jakubfrieb/Route/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakubfrieb/Route/labels{/name}","releases_url":"https://api.github.com/repos/jakubfrieb/Route/releases{/id}","deployments_url":"https://api.github.com/repos/jakubfrieb/Route/deployments","created_at":"2018-04-02T15:49:29Z","updated_at":"2018-05-14T11:47:52Z","pushed_at":"2018-09-19T19:18:30Z","git_url":"git://github.com/jakubfrieb/Route.git","ssh_url":"git@github.com:jakubfrieb/Route.git","clone_url":"https://github.com/jakubfrieb/Route.git","svn_url":"https://github.com/jakubfrieb/Route","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jakubfrieb/Route/pulls/1"},"html":{"href":"https://github.com/jakubfrieb/Route/pull/1"},"issue":{"href":"https://api.github.com/repos/jakubfrieb/Route/issues/1"},"comments":{"href":"https://api.github.com/repos/jakubfrieb/Route/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jakubfrieb/Route/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jakubfrieb/Route/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jakubfrieb/Route/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jakubfrieb/Route/statuses/6d206434a5c418a39eca7777cffda027bf3bd14f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jakubfrieb","id":7541799,"node_id":"MDQ6VXNlcjc1NDE3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7541799?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubfrieb","html_url":"https://github.com/jakubfrieb","followers_url":"https://api.github.com/users/jakubfrieb/followers","following_url":"https://api.github.com/users/jakubfrieb/following{/other_user}","gists_url":"https://api.github.com/users/jakubfrieb/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubfrieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubfrieb/subscriptions","organizations_url":"https://api.github.com/users/jakubfrieb/orgs","repos_url":"https://api.github.com/users/jakubfrieb/repos","events_url":"https://api.github.com/users/jakubfrieb/events{/privacy}","received_events_url":"https://api.github.com/users/jakubfrieb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":46,"additions":469,"deletions":276,"changed_files":16}}
{"actor":{"display_login":"jakubfrieb"}}