{"action":"created","comment":{"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments/232695159","pull_request_review_id":173912980,"id":232695159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjY5NTE1OQ==","diff_hunk":"@@ -20,11 +19,10 @@\n \n     @Test\n     public void addAllLastNameCombinationsMultipleNames() {\n-        List<CandidateName> candidateNames = new ArrayList<>();\n         List<String> firstNames = Arrays.asList(\"Aaa\", \"Bbb\", \"Ccc\");\n         List<String> lastNameCombinations = Arrays.asList(\"Ddd\", \"Eee\", \"Ddd Eee\");\n \n-        List<CandidateName> newCandidateNames = addAllLastNameCombinations(candidateNames, firstNames, lastNameCombinations);\n+        List<CandidateName> newCandidateNames = addAllLastNameCombinations(firstNames, lastNameCombinations);","path":"src/test/java/uk/gov/digital/ho/pttg/application/namematching/candidates/MultipleLastNamesFunctionsTest.java","position":17,"original_position":17,"commit_id":"4d0349da8af60faec267addb5726bc2b234ea4d5","original_commit_id":"4d0349da8af60faec267addb5726bc2b234ea4d5","user":{"login":"owainrobertsbjss","id":41990779,"node_id":"MDQ6VXNlcjQxOTkwNzc5","avatar_url":"https://avatars1.githubusercontent.com/u/41990779?v=4","gravatar_id":"","url":"https://api.github.com/users/owainrobertsbjss","html_url":"https://github.com/owainrobertsbjss","followers_url":"https://api.github.com/users/owainrobertsbjss/followers","following_url":"https://api.github.com/users/owainrobertsbjss/following{/other_user}","gists_url":"https://api.github.com/users/owainrobertsbjss/gists{/gist_id}","starred_url":"https://api.github.com/users/owainrobertsbjss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owainrobertsbjss/subscriptions","organizations_url":"https://api.github.com/users/owainrobertsbjss/orgs","repos_url":"https://api.github.com/users/owainrobertsbjss/repos","events_url":"https://api.github.com/users/owainrobertsbjss/events{/privacy}","received_events_url":"https://api.github.com/users/owainrobertsbjss/received_events","type":"User","site_admin":false},"body":"As above - now that this method doesn't alter a list passed in as a parameter its name should change.","created_at":"2018-11-12T15:13:49Z","updated_at":"2018-11-12T15:36:23Z","html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142#discussion_r232695159","pull_request_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments/232695159"},"html":{"href":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142#discussion_r232695159"},"pull_request":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142","id":230143230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTQzMjMw","html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142","diff_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142.diff","patch_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/142","number":142,"state":"open","locked":false,"title":"EE-8289: Simplify the logic in MultipleLastNames Generator","user":{"login":"Tim-Hammonds","id":22787141,"node_id":"MDQ6VXNlcjIyNzg3MTQx","avatar_url":"https://avatars0.githubusercontent.com/u/22787141?v=4","gravatar_id":"","url":"https://api.github.com/users/Tim-Hammonds","html_url":"https://github.com/Tim-Hammonds","followers_url":"https://api.github.com/users/Tim-Hammonds/followers","following_url":"https://api.github.com/users/Tim-Hammonds/following{/other_user}","gists_url":"https://api.github.com/users/Tim-Hammonds/gists{/gist_id}","starred_url":"https://api.github.com/users/Tim-Hammonds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tim-Hammonds/subscriptions","organizations_url":"https://api.github.com/users/Tim-Hammonds/orgs","repos_url":"https://api.github.com/users/Tim-Hammonds/repos","events_url":"https://api.github.com/users/Tim-Hammonds/events{/privacy}","received_events_url":"https://api.github.com/users/Tim-Hammonds/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-12T13:58:41Z","updated_at":"2018-11-12T15:36:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6186187f55e253f2619a4cc63b4c06459b0a983","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vbadiniHO","id":33686898,"node_id":"MDQ6VXNlcjMzNjg2ODk4","avatar_url":"https://avatars3.githubusercontent.com/u/33686898?v=4","gravatar_id":"","url":"https://api.github.com/users/vbadiniHO","html_url":"https://github.com/vbadiniHO","followers_url":"https://api.github.com/users/vbadiniHO/followers","following_url":"https://api.github.com/users/vbadiniHO/following{/other_user}","gists_url":"https://api.github.com/users/vbadiniHO/gists{/gist_id}","starred_url":"https://api.github.com/users/vbadiniHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbadiniHO/subscriptions","organizations_url":"https://api.github.com/users/vbadiniHO/orgs","repos_url":"https://api.github.com/users/vbadiniHO/repos","events_url":"https://api.github.com/users/vbadiniHO/events{/privacy}","received_events_url":"https://api.github.com/users/vbadiniHO/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/142/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/4d0349da8af60faec267addb5726bc2b234ea4d5","head":{"label":"UKHomeOffice:EE-8289-Simplify","ref":"EE-8289-Simplify","sha":"4d0349da8af60faec267addb5726bc2b234ea4d5","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":97106451,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEwNjQ1MQ==","name":"pttg-ip-hmrc","full_name":"UKHomeOffice/pttg-ip-hmrc","private":false,"owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","description":"Interfaces to the HMRC API for Income Proving","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc","forks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/deployments","created_at":"2017-07-13T09:42:02Z","updated_at":"2018-11-07T17:49:14Z","pushed_at":"2018-11-12T13:58:42Z","git_url":"git://github.com/UKHomeOffice/pttg-ip-hmrc.git","ssh_url":"git@github.com:UKHomeOffice/pttg-ip-hmrc.git","clone_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc.git","svn_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","homepage":null,"size":957,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"30d43750104539395de8b9901a3d032cce367ccd","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":97106451,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEwNjQ1MQ==","name":"pttg-ip-hmrc","full_name":"UKHomeOffice/pttg-ip-hmrc","private":false,"owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","description":"Interfaces to the HMRC API for Income Proving","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc","forks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/deployments","created_at":"2017-07-13T09:42:02Z","updated_at":"2018-11-07T17:49:14Z","pushed_at":"2018-11-12T13:58:42Z","git_url":"git://github.com/UKHomeOffice/pttg-ip-hmrc.git","ssh_url":"git@github.com:UKHomeOffice/pttg-ip-hmrc.git","clone_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc.git","svn_url":"https://github.com/UKHomeOffice/pttg-ip-hmrc","homepage":null,"size":957,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142"},"html":{"href":"https://github.com/UKHomeOffice/pttg-ip-hmrc/pull/142"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/142"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/pttg-ip-hmrc/statuses/4d0349da8af60faec267addb5726bc2b234ea4d5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"owainrobertsbjss"}}