{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/238105789","pull_request_review_id":180568844,"id":238105789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEwNTc4OQ==","diff_hunk":"@@ -37,14 +37,15 @@ stdenv.mkDerivation rec {\n \n   enableParallelBuilding = true;\n \n-  patches =\n-    [ ./qemu-patches/elfload.patch\n-      ./qemu-patches/cpu-exec.patch\n-      ./qemu-patches/no-etc-install.patch\n-      ./qemu-patches/translate-all.patch\n-      ./qemu-patches/syscall.patch\n-      ./qemu-patches/qemu-2.3.0-glibc-2.26.patch\n-    ];\n+  patches = [\n+    # patches extracted from afl source\n+    ./qemu-patches/elfload.patch\n+    ./qemu-patches/cpu-exec.patch\n+    ./qemu-patches/syscall.patch","path":"pkgs/tools/security/afl/qemu.nix","position":34,"original_position":34,"commit_id":"2131a52f624892cf265c0e0c9e55dcbb9d5a3d59","original_commit_id":"2131a52f624892cf265c0e0c9e55dcbb9d5a3d59","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"Unlikely - I've hand-modified at least one of them. See the README as to how/why this is necessary.","created_at":"2018-12-02T16:51:00Z","updated_at":"2018-12-02T16:51:00Z","html_url":"https://github.com/NixOS/nixpkgs/pull/51398#discussion_r238105789","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/238105789"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/51398#discussion_r238105789"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398"}},"in_reply_to_id":238105291},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398","id":235269147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjY5MTQ3","html_url":"https://github.com/NixOS/nixpkgs/pull/51398","diff_url":"https://github.com/NixOS/nixpkgs/pull/51398.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/51398.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51398","number":51398,"state":"open","locked":false,"title":"afl-qemu: update to qemu 2.10.0, as specified by afl 2.52b","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"refresh patches & configure options directly from afl 2.52b to make\r\ninstallation as vanilla as possible\r\n\r\n###### Motivation for this change\r\n\r\nafl's qemu mode as packaged in master and release-18.09 doesn't work, because instead of using the specified 2.10.0, it's been left at 2.3.0. This doesn't work because afl 2.52b passes an env var `QEMU_LOG=nochain`, which qemu 2.3.0 doesn't understand, failing with an error message.\r\n\r\nThe patches themselves had also been only minimally updated from what I can see, just enough to get them to compile. Here I've pulled the patches (and `afl-types.h`, `afl-config.h`) fresh from the afl 2.52b sources, but also pulled in a cherrypicked fix from qemu git to build against glibc 2.27.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [x] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-12-02T16:30:04Z","updated_at":"2018-12-02T16:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccc5c5afe8bc4e4c02ddc43377f32727f10cadea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51398/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2131a52f624892cf265c0e0c9e55dcbb9d5a3d59","head":{"label":"risicle:ris-afl-qemu-fix","ref":"ris-afl-qemu-fix","sha":"2131a52f624892cf265c0e0c9e55dcbb9d5a3d59","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"repo":{"id":31165278,"node_id":"MDEwOlJlcG9zaXRvcnkzMTE2NTI3OA==","name":"nixpkgs","full_name":"risicle/nixpkgs","private":false,"owner":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/risicle/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/risicle/nixpkgs","forks_url":"https://api.github.com/repos/risicle/nixpkgs/forks","keys_url":"https://api.github.com/repos/risicle/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/risicle/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/risicle/nixpkgs/teams","hooks_url":"https://api.github.com/repos/risicle/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/risicle/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/risicle/nixpkgs/events","assignees_url":"https://api.github.com/repos/risicle/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/risicle/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/risicle/nixpkgs/tags","blobs_url":"https://api.github.com/repos/risicle/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/risicle/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/risicle/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/risicle/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/risicle/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/risicle/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/risicle/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/risicle/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/risicle/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/risicle/nixpkgs/subscription","commits_url":"https://api.github.com/repos/risicle/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/risicle/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/risicle/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/risicle/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/risicle/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/risicle/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/risicle/nixpkgs/merges","archive_url":"https://api.github.com/repos/risicle/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/risicle/nixpkgs/downloads","issues_url":"https://api.github.com/repos/risicle/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/risicle/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/risicle/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/risicle/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/risicle/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/risicle/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/risicle/nixpkgs/deployments","created_at":"2015-02-22T14:23:22Z","updated_at":"2015-04-01T15:05:29Z","pushed_at":"2018-12-02T16:26:42Z","git_url":"git://github.com/risicle/nixpkgs.git","ssh_url":"git@github.com:risicle/nixpkgs.git","clone_url":"https://github.com/risicle/nixpkgs.git","svn_url":"https://github.com/risicle/nixpkgs","homepage":null,"size":820913,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"97ac980d0d001421042f66c641686809e052534c","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-12-02T16:37:38Z","pushed_at":"2018-12-02T16:43:25Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":894726,"stargazers_count":3052,"watchers_count":3052,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3224,"mirror_url":null,"archived":false,"open_issues_count":3368,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3224,"open_issues":3368,"watchers":3052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/51398"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/51398"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/51398/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51398/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2131a52f624892cf265c0e0c9e55dcbb9d5a3d59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"risicle"}}