{"action":"created","comment":{"url":"https://api.github.com/repos/google/santa/pulls/comments/192792414","pull_request_review_id":125635639,"id":192792414,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc5MjQxNA==","diff_hunk":"@@ -206,7 +206,7 @@ template<typename KeyT, typename ValueT> class SantaCache {\n       lock(bucket);\n       struct entry *entry = (struct entry *)((uintptr_t)bucket->head - 1);\n       while (entry != nullptr) {\n-        if (entry->key != 0) ++count;\n+        if (entry->key != key_zero_) ++count;","path":"Source/santa-driver/SantaCache.h","position":null,"original_position":23,"commit_id":"85492bcce30ab8c466bc160cc44e76b14947ac2a","original_commit_id":"49d8856f5f943bf816d4c0a26ce27b9f53d3d822","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"> I don't think there's anything special about entry->key being zero is there?\r\n\r\nNo, the counting code was wrong and was checking for a zero key rather than a zero value, which is wrong.","created_at":"2018-06-04T15:56:14Z","updated_at":"2018-06-04T15:58:39Z","html_url":"https://github.com/google/santa/pull/276#discussion_r192792414","pull_request_url":"https://api.github.com/repos/google/santa/pulls/276","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/comments/192792414"},"html":{"href":"https://github.com/google/santa/pull/276#discussion_r192792414"},"pull_request":{"href":"https://api.github.com/repos/google/santa/pulls/276"}},"in_reply_to_id":192570538},"pull_request":{"url":"https://api.github.com/repos/google/santa/pulls/276","id":192143285,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTQzMjg1","html_url":"https://github.com/google/santa/pull/276","diff_url":"https://github.com/google/santa/pull/276.diff","patch_url":"https://github.com/google/santa/pull/276.patch","issue_url":"https://api.github.com/repos/google/santa/issues/276","number":276,"state":"open","locked":false,"title":"santa-driver: Switch to a struct for vnode IDs, holding both the file…","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"…system ID and vnode ID.\r\n\r\nAlso drop the separate caches for root/non-root as this doesn't offer any benefit anymore.","created_at":"2018-06-01T21:08:42Z","updated_at":"2018-06-04T15:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ecba29d347ae610b9b741763c7ae6ad722f9fe6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tburgin","id":2117646,"node_id":"MDQ6VXNlcjIxMTc2NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2117646?v=4","gravatar_id":"","url":"https://api.github.com/users/tburgin","html_url":"https://github.com/tburgin","followers_url":"https://api.github.com/users/tburgin/followers","following_url":"https://api.github.com/users/tburgin/following{/other_user}","gists_url":"https://api.github.com/users/tburgin/gists{/gist_id}","starred_url":"https://api.github.com/users/tburgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tburgin/subscriptions","organizations_url":"https://api.github.com/users/tburgin/orgs","repos_url":"https://api.github.com/users/tburgin/repos","events_url":"https://api.github.com/users/tburgin/events{/privacy}","received_events_url":"https://api.github.com/users/tburgin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":136341304,"node_id":"MDU6TGFiZWwxMzYzNDEzMDQ=","url":"https://api.github.com/repos/google/santa/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/google/santa/pulls/276/commits","review_comments_url":"https://api.github.com/repos/google/santa/pulls/276/comments","review_comment_url":"https://api.github.com/repos/google/santa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/santa/issues/276/comments","statuses_url":"https://api.github.com/repos/google/santa/statuses/85492bcce30ab8c466bc160cc44e76b14947ac2a","head":{"label":"russellhancox:vnode-id-struct","ref":"vnode-id-struct","sha":"85492bcce30ab8c466bc160cc44e76b14947ac2a","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"repo":{"id":39463898,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2Mzg5OA==","name":"santa","full_name":"russellhancox/santa","owner":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/russellhancox/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":true,"url":"https://api.github.com/repos/russellhancox/santa","forks_url":"https://api.github.com/repos/russellhancox/santa/forks","keys_url":"https://api.github.com/repos/russellhancox/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/russellhancox/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/russellhancox/santa/teams","hooks_url":"https://api.github.com/repos/russellhancox/santa/hooks","issue_events_url":"https://api.github.com/repos/russellhancox/santa/issues/events{/number}","events_url":"https://api.github.com/repos/russellhancox/santa/events","assignees_url":"https://api.github.com/repos/russellhancox/santa/assignees{/user}","branches_url":"https://api.github.com/repos/russellhancox/santa/branches{/branch}","tags_url":"https://api.github.com/repos/russellhancox/santa/tags","blobs_url":"https://api.github.com/repos/russellhancox/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/russellhancox/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/russellhancox/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/russellhancox/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/russellhancox/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/russellhancox/santa/languages","stargazers_url":"https://api.github.com/repos/russellhancox/santa/stargazers","contributors_url":"https://api.github.com/repos/russellhancox/santa/contributors","subscribers_url":"https://api.github.com/repos/russellhancox/santa/subscribers","subscription_url":"https://api.github.com/repos/russellhancox/santa/subscription","commits_url":"https://api.github.com/repos/russellhancox/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/russellhancox/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/russellhancox/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/russellhancox/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/russellhancox/santa/contents/{+path}","compare_url":"https://api.github.com/repos/russellhancox/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/russellhancox/santa/merges","archive_url":"https://api.github.com/repos/russellhancox/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/russellhancox/santa/downloads","issues_url":"https://api.github.com/repos/russellhancox/santa/issues{/number}","pulls_url":"https://api.github.com/repos/russellhancox/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/russellhancox/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/russellhancox/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/russellhancox/santa/labels{/name}","releases_url":"https://api.github.com/repos/russellhancox/santa/releases{/id}","deployments_url":"https://api.github.com/repos/russellhancox/santa/deployments","created_at":"2015-07-21T18:53:19Z","updated_at":"2018-06-01T18:45:20Z","pushed_at":"2018-06-04T15:53:36Z","git_url":"git://github.com/russellhancox/santa.git","ssh_url":"git@github.com:russellhancox/santa.git","clone_url":"https://github.com/russellhancox/santa.git","svn_url":"https://github.com/russellhancox/santa","homepage":"","size":2113,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"61a67e45c1ad51b04d6fee59b354560a897933c1","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":25009012,"node_id":"MDEwOlJlcG9zaXRvcnkyNTAwOTAxMg==","name":"santa","full_name":"google/santa","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/santa","description":"A binary whitelisting/blacklisting system for Mac OS X","fork":false,"url":"https://api.github.com/repos/google/santa","forks_url":"https://api.github.com/repos/google/santa/forks","keys_url":"https://api.github.com/repos/google/santa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/santa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/santa/teams","hooks_url":"https://api.github.com/repos/google/santa/hooks","issue_events_url":"https://api.github.com/repos/google/santa/issues/events{/number}","events_url":"https://api.github.com/repos/google/santa/events","assignees_url":"https://api.github.com/repos/google/santa/assignees{/user}","branches_url":"https://api.github.com/repos/google/santa/branches{/branch}","tags_url":"https://api.github.com/repos/google/santa/tags","blobs_url":"https://api.github.com/repos/google/santa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/santa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/santa/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/santa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/santa/statuses/{sha}","languages_url":"https://api.github.com/repos/google/santa/languages","stargazers_url":"https://api.github.com/repos/google/santa/stargazers","contributors_url":"https://api.github.com/repos/google/santa/contributors","subscribers_url":"https://api.github.com/repos/google/santa/subscribers","subscription_url":"https://api.github.com/repos/google/santa/subscription","commits_url":"https://api.github.com/repos/google/santa/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/santa/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/santa/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/santa/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/santa/contents/{+path}","compare_url":"https://api.github.com/repos/google/santa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/santa/merges","archive_url":"https://api.github.com/repos/google/santa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/santa/downloads","issues_url":"https://api.github.com/repos/google/santa/issues{/number}","pulls_url":"https://api.github.com/repos/google/santa/pulls{/number}","milestones_url":"https://api.github.com/repos/google/santa/milestones{/number}","notifications_url":"https://api.github.com/repos/google/santa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/santa/labels{/name}","releases_url":"https://api.github.com/repos/google/santa/releases{/id}","deployments_url":"https://api.github.com/repos/google/santa/deployments","created_at":"2014-10-09T21:18:31Z","updated_at":"2018-06-03T16:14:53Z","pushed_at":"2018-06-04T15:53:38Z","git_url":"git://github.com/google/santa.git","ssh_url":"git@github.com:google/santa.git","clone_url":"https://github.com/google/santa.git","svn_url":"https://github.com/google/santa","homepage":"","size":2135,"stargazers_count":2301,"watchers_count":2301,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":156,"open_issues":19,"watchers":2301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/santa/pulls/276"},"html":{"href":"https://github.com/google/santa/pull/276"},"issue":{"href":"https://api.github.com/repos/google/santa/issues/276"},"comments":{"href":"https://api.github.com/repos/google/santa/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/google/santa/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/google/santa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/santa/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/google/santa/statuses/85492bcce30ab8c466bc160cc44e76b14947ac2a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"russellhancox"}}