{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/237715704","pull_request_review_id":180085789,"id":237715704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzcxNTcwNA==","diff_hunk":"@@ -18,7 +18,10 @@\n #\n # Dockerfile to run MXNet on Ubuntu 16.04 for CPU\n \n-FROM nvidia/cuda:9.0-cudnn7-devel\n+FROM nvidia/cuda:10.0-cudnn7-devel\n+\n+# Avoid interactive package installers.\n+ENV DEBIAN_FRONTEND noninteractive","path":"ci/docker/Dockerfile.build.ubuntu_gpu_tensorrt","position":8,"original_position":8,"commit_id":"b2cf02f41f424d5bbd44a1ea0916e24f6f36354c","original_commit_id":"6cc9e3a4ef34258a22c759553cafa7a3e8928e97","user":{"login":"marcoabreu","id":18629099,"node_id":"MDQ6VXNlcjE4NjI5MDk5","avatar_url":"https://avatars1.githubusercontent.com/u/18629099?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoabreu","html_url":"https://github.com/marcoabreu","followers_url":"https://api.github.com/users/marcoabreu/followers","following_url":"https://api.github.com/users/marcoabreu/following{/other_user}","gists_url":"https://api.github.com/users/marcoabreu/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoabreu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoabreu/subscriptions","organizations_url":"https://api.github.com/users/marcoabreu/orgs","repos_url":"https://api.github.com/users/marcoabreu/repos","events_url":"https://api.github.com/users/marcoabreu/events{/privacy}","received_events_url":"https://api.github.com/users/marcoabreu/received_events","type":"User","site_admin":false},"body":"I'd like to get rid of this if possible. Or at least get it tracked down as closely as possible and then restrict the scope of that variable.","created_at":"2018-11-30T01:02:22Z","updated_at":"2018-11-30T01:02:22Z","html_url":"https://github.com/apache/incubator-mxnet/pull/13310#discussion_r237715704","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/237715704"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/13310#discussion_r237715704"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310"}},"in_reply_to_id":236058327},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310","id":231693690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjkzNjkw","html_url":"https://github.com/apache/incubator-mxnet/pull/13310","diff_url":"https://github.com/apache/incubator-mxnet/pull/13310.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/13310.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13310","number":13310,"state":"open","locked":false,"title":"[MXNET-703] Update to TensorRT 5, ONNX IR 3. Fix inference bugs.","user":{"login":"KellenSunderland","id":7443219,"node_id":"MDQ6VXNlcjc0NDMyMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nThis PR updates the IR which is passed to TensorRT to use version3 of the spec, which aligns much better with MXNet defaults and results in a decrease in boilerplate code.  This update also fixes some bugs when building inference engines that were resulting in feature vectors that were very different from what they should have been.\r\n\r\nFixes #12598\r\nFixes #13113\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change","created_at":"2018-11-17T00:52:32Z","updated_at":"2018-11-30T01:02:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2af84cdbdbe2910022970db11191049e1047307b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anirudh2290","id":1522319,"node_id":"MDQ6VXNlcjE1MjIzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1522319?v=4","gravatar_id":"","url":"https://api.github.com/users/anirudh2290","html_url":"https://github.com/anirudh2290","followers_url":"https://api.github.com/users/anirudh2290/followers","following_url":"https://api.github.com/users/anirudh2290/following{/other_user}","gists_url":"https://api.github.com/users/anirudh2290/gists{/gist_id}","starred_url":"https://api.github.com/users/anirudh2290/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anirudh2290/subscriptions","organizations_url":"https://api.github.com/users/anirudh2290/orgs","repos_url":"https://api.github.com/users/anirudh2290/repos","events_url":"https://api.github.com/users/anirudh2290/events{/privacy}","received_events_url":"https://api.github.com/users/anirudh2290/received_events","type":"User","site_admin":false},{"login":"szha","id":2626883,"node_id":"MDQ6VXNlcjI2MjY4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1018798522,"node_id":"MDU6TGFiZWwxMDE4Nzk4NTIy","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/pr-awaiting-review","name":"pr-awaiting-review","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13310/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/b2cf02f41f424d5bbd44a1ea0916e24f6f36354c","head":{"label":"KellenSunderland:master","ref":"master","sha":"b2cf02f41f424d5bbd44a1ea0916e24f6f36354c","user":{"login":"KellenSunderland","id":7443219,"node_id":"MDQ6VXNlcjc0NDMyMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"repo":{"id":104731717,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ3MzE3MTc=","name":"incubator-mxnet","full_name":"KellenSunderland/incubator-mxnet","private":false,"owner":{"login":"KellenSunderland","id":7443219,"node_id":"MDQ6VXNlcjc0NDMyMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KellenSunderland/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet","forks_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/KellenSunderland/incubator-mxnet/deployments","created_at":"2017-09-25T09:44:26Z","updated_at":"2018-11-26T06:18:24Z","pushed_at":"2018-11-26T06:22:45Z","git_url":"git://github.com/KellenSunderland/incubator-mxnet.git","ssh_url":"git@github.com:KellenSunderland/incubator-mxnet.git","clone_url":"https://github.com/KellenSunderland/incubator-mxnet.git","svn_url":"https://github.com/KellenSunderland/incubator-mxnet","homepage":"http://mxnet.io","size":49923,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7b1e7a5040aee0adffb826a2b4acf1380c93b07b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-11-30T00:17:11Z","pushed_at":"2018-11-30T00:59:11Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":49973,"stargazers_count":15667,"watchers_count":15667,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5678,"mirror_url":null,"archived":false,"open_issues_count":979,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5678,"open_issues":979,"watchers":15667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/13310"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/13310"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/13310/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13310/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/b2cf02f41f424d5bbd44a1ea0916e24f6f36354c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marcoabreu"}}