{"action":"created","issue":{"url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/65","repository_url":"https://api.github.com/repos/mattmcspirit/azurestack","labels_url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/65/comments","events_url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/65/events","html_url":"https://github.com/mattmcspirit/azurestack/issues/65","id":384077639,"node_id":"MDU6SXNzdWUzODQwNzc2Mzk=","number":65,"title":"Validate Azure AD credentials at start (offline download method)","user":{"login":"gijs007","id":11969278,"node_id":"MDQ6VXNlcjExOTY5Mjc4","avatar_url":"https://avatars0.githubusercontent.com/u/11969278?v=4","gravatar_id":"","url":"https://api.github.com/users/gijs007","html_url":"https://github.com/gijs007","followers_url":"https://api.github.com/users/gijs007/followers","following_url":"https://api.github.com/users/gijs007/following{/other_user}","gists_url":"https://api.github.com/users/gijs007/gists{/gist_id}","starred_url":"https://api.github.com/users/gijs007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijs007/subscriptions","organizations_url":"https://api.github.com/users/gijs007/orgs","repos_url":"https://api.github.com/users/gijs007/repos","events_url":"https://api.github.com/users/gijs007/events{/privacy}","received_events_url":"https://api.github.com/users/gijs007/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-25T13:10:53Z","updated_at":"2018-11-26T19:06:58Z","closed_at":"2018-11-26T17:24:36Z","author_association":"NONE","body":"I recently ran the script with the offline download method and noticed that the script failed after the extraction part. The issue was that I used the wrong Azure AD credentials.\r\n\r\nI also noticed that a lot of validation steps are executed when the script starts. It would be great if the Azure AD login credentials are also validated at the start, so that these can be corrected immediately if they are incorrect. "},"comment":{"url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/comments/441758662","html_url":"https://github.com/mattmcspirit/azurestack/issues/65#issuecomment-441758662","issue_url":"https://api.github.com/repos/mattmcspirit/azurestack/issues/65","id":441758662,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTc1ODY2Mg==","user":{"login":"gijs007","id":11969278,"node_id":"MDQ6VXNlcjExOTY5Mjc4","avatar_url":"https://avatars0.githubusercontent.com/u/11969278?v=4","gravatar_id":"","url":"https://api.github.com/users/gijs007","html_url":"https://github.com/gijs007","followers_url":"https://api.github.com/users/gijs007/followers","following_url":"https://api.github.com/users/gijs007/following{/other_user}","gists_url":"https://api.github.com/users/gijs007/gists{/gist_id}","starred_url":"https://api.github.com/users/gijs007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijs007/subscriptions","organizations_url":"https://api.github.com/users/gijs007/orgs","repos_url":"https://api.github.com/users/gijs007/repos","events_url":"https://api.github.com/users/gijs007/events{/privacy}","received_events_url":"https://api.github.com/users/gijs007/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T19:06:58Z","updated_at":"2018-11-26T19:06:58Z","author_association":"NONE","body":"Agreed it doesn't make much sense as long as there is a risk that rerunning the script fails.\r\n\r\nThe only thing I can think of is to extract only the files needed for the SQLlocalDB and the modules. Afterwards the script can extract all the other files (ISO, appservices, etc). Not sure if this makes sense or if it's worth the effort though. "}}
{"actor":{"display_login":"gijs007"}}