{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/6091","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/6091/events","html_url":"https://github.com/kubernetes/kops/pull/6091","id":381833346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzEwMDI2","number":6091,"title":"feat(cmd/kops/create_cluster): default to kubelet.anonymousAuth false on k8s versions >=1.10","user":{"login":"jaredallard","id":2391349,"node_id":"MDQ6VXNlcjIzOTEzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/2391349?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredallard","html_url":"https://github.com/jaredallard","followers_url":"https://api.github.com/users/jaredallard/followers","following_url":"https://api.github.com/users/jaredallard/following{/other_user}","gists_url":"https://api.github.com/users/jaredallard/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredallard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredallard/subscriptions","organizations_url":"https://api.github.com/users/jaredallard/orgs","repos_url":"https://api.github.com/users/jaredallard/repos","events_url":"https://api.github.com/users/jaredallard/events{/privacy}","received_events_url":"https://api.github.com/users/jaredallard/received_events","type":"User","site_admin":false},"labels":[{"id":485059302,"node_id":"MDU6TGFiZWw0ODUwNTkzMDI=","url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1086778261,"node_id":"MDU6TGFiZWwxMDg2Nzc4MjYx","url":"https://api.github.com/repos/kubernetes/kops/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":676485644,"node_id":"MDU6TGFiZWw2NzY0ODU2NDQ=","url":"https://api.github.com/repos/kubernetes/kops/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/21","html_url":"https://github.com/kubernetes/kops/milestone/21","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/21/labels","id":3442381,"node_id":"MDk6TWlsZXN0b25lMzQ0MjM4MQ==","number":21,"title":"1.12","description":null,"creator":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":5,"state":"open","created_at":"2018-06-21T15:06:49Z","updated_at":"2018-11-24T20:10:44Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-11-17T06:17:27Z","updated_at":"2018-11-25T01:30:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/6091","html_url":"https://github.com/kubernetes/kops/pull/6091","diff_url":"https://github.com/kubernetes/kops/pull/6091.diff","patch_url":"https://github.com/kubernetes/kops/pull/6091.patch"},"body":"**What this PR does**: Sets `kubelet.anonymousAuth` to `false` by default on new cluster creation\r\n\r\n**Why**: It's _extremely_ dangerous to have this be undefined by default (which defaults to `true`) _and_ not have it in bold letters on the README.md that it's off by default. It's very easy to overlook this as a \"newbie\" or somebody who skims through stuff (not saying that's OK, but people will be that way regardless). So, this introduces setting it to `false` by default on new cluster creation.\r\n\r\n**Notes**: I'm sure this probably isn't the best place to do this, but it seemed like it probably was. I could also see it being moved to `pkg/apis/kops/apiserver.go` as well. "},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/441408332","html_url":"https://github.com/kubernetes/kops/pull/6091#issuecomment-441408332","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/6091","id":441408332,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQwODMzMg==","user":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T01:30:30Z","updated_at":"2018-11-25T01:30:30Z","author_association":"MEMBER","body":"This looks good - the gofmt thing is really annoying - it's because go switched the behaviour of gofmt in go 1.11.  But k8s is only moving to go 1.11 in k8s 1.13, so until then we need to build with go 1.10, and so we verify gofmt with that version.  But of course most people have go 1.11 installed now.  If you have go 1.10 you could use that to gofmt, or I can probably just force-merge it and update gofmt.\r\n\r\nAlthough I agree it's an important issue, we still don't change the behaviour of existing clusters unless we have to - we want everyone to upgrade to the latest kops version and not stay on older versions.  If we start changing behaviours on released clusters we jeopardize that (although, to be fair, addons are in a weird place, which we hope to improve with bundles).  Can we default for >= 1.11 ?  The mechanisms we have are that we can have a release note, and/or we could add a warning that is logged on every kops command."}}
{"actor":{"display_login":"justinsb"}}