{"action":"closed","number":14146,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146","id":212999810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTk5ODEw","html_url":"https://github.com/bitcoin/bitcoin/pull/14146","diff_url":"https://github.com/bitcoin/bitcoin/pull/14146.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14146.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14146","number":14146,"state":"closed","locked":false,"title":"wallet: Remove trailing separators from -walletdir arg","user":{"login":"PierreRochard","id":6299681,"node_id":"MDQ6VXNlcjYyOTk2ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/6299681?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRochard","html_url":"https://github.com/PierreRochard","followers_url":"https://api.github.com/users/PierreRochard/followers","following_url":"https://api.github.com/users/PierreRochard/following{/other_user}","gists_url":"https://api.github.com/users/PierreRochard/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRochard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRochard/subscriptions","organizations_url":"https://api.github.com/users/PierreRochard/orgs","repos_url":"https://api.github.com/users/PierreRochard/repos","events_url":"https://api.github.com/users/PierreRochard/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRochard/received_events","type":"User","site_admin":false},"body":"If a user passes in a path with a trailing separator as the `walletdir`, multiple BerkeleyEnvironments may be created in the same directory which can lead to data corruption.\r\n\r\nDiscovered while reviewing https://github.com/bitcoin/bitcoin/pull/12493#issuecomment-417147646\r\n","created_at":"2018-09-04T14:36:39Z","updated_at":"2018-10-18T09:00:03Z","closed_at":"2018-10-18T09:00:03Z","merged_at":"2018-10-18T09:00:03Z","merge_commit_sha":"2d471636eb9160ab51b08e491e3f003f57adbc36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149424,"node_id":"MDU6TGFiZWwxNDk0MjQ=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14146/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2d471636eb9160ab51b08e491e3f003f57adbc36","head":{"label":"PierreRochard:wallet-env-bug","ref":"wallet-env-bug","sha":"2d471636eb9160ab51b08e491e3f003f57adbc36","user":{"login":"PierreRochard","id":6299681,"node_id":"MDQ6VXNlcjYyOTk2ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/6299681?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRochard","html_url":"https://github.com/PierreRochard","followers_url":"https://api.github.com/users/PierreRochard/followers","following_url":"https://api.github.com/users/PierreRochard/following{/other_user}","gists_url":"https://api.github.com/users/PierreRochard/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRochard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRochard/subscriptions","organizations_url":"https://api.github.com/users/PierreRochard/orgs","repos_url":"https://api.github.com/users/PierreRochard/repos","events_url":"https://api.github.com/users/PierreRochard/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRochard/received_events","type":"User","site_admin":false},"repo":{"id":103171944,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMxNzE5NDQ=","name":"bitcoin","full_name":"PierreRochard/bitcoin","private":false,"owner":{"login":"PierreRochard","id":6299681,"node_id":"MDQ6VXNlcjYyOTk2ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/6299681?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRochard","html_url":"https://github.com/PierreRochard","followers_url":"https://api.github.com/users/PierreRochard/followers","following_url":"https://api.github.com/users/PierreRochard/following{/other_user}","gists_url":"https://api.github.com/users/PierreRochard/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRochard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRochard/subscriptions","organizations_url":"https://api.github.com/users/PierreRochard/orgs","repos_url":"https://api.github.com/users/PierreRochard/repos","events_url":"https://api.github.com/users/PierreRochard/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRochard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PierreRochard/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/PierreRochard/bitcoin","forks_url":"https://api.github.com/repos/PierreRochard/bitcoin/forks","keys_url":"https://api.github.com/repos/PierreRochard/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PierreRochard/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PierreRochard/bitcoin/teams","hooks_url":"https://api.github.com/repos/PierreRochard/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/PierreRochard/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/PierreRochard/bitcoin/events","assignees_url":"https://api.github.com/repos/PierreRochard/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/PierreRochard/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/PierreRochard/bitcoin/tags","blobs_url":"https://api.github.com/repos/PierreRochard/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PierreRochard/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PierreRochard/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/PierreRochard/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PierreRochard/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/PierreRochard/bitcoin/languages","stargazers_url":"https://api.github.com/repos/PierreRochard/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/PierreRochard/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/PierreRochard/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/PierreRochard/bitcoin/subscription","commits_url":"https://api.github.com/repos/PierreRochard/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/PierreRochard/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/PierreRochard/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/PierreRochard/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/PierreRochard/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/PierreRochard/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PierreRochard/bitcoin/merges","archive_url":"https://api.github.com/repos/PierreRochard/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PierreRochard/bitcoin/downloads","issues_url":"https://api.github.com/repos/PierreRochard/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/PierreRochard/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/PierreRochard/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/PierreRochard/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PierreRochard/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/PierreRochard/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/PierreRochard/bitcoin/deployments","created_at":"2017-09-11T18:19:35Z","updated_at":"2018-09-15T21:43:42Z","pushed_at":"2018-09-15T21:43:40Z","git_url":"git://github.com/PierreRochard/bitcoin.git","ssh_url":"git@github.com:PierreRochard/bitcoin.git","clone_url":"https://github.com/PierreRochard/bitcoin.git","svn_url":"https://github.com/PierreRochard/bitcoin","homepage":"https://bitcoin.org/en/download","size":110985,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"8f464549c46db2954d7b64d1feb200eb35f2e7e8","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-10-18T08:38:30Z","pushed_at":"2018-10-18T08:59:12Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":114264,"stargazers_count":35436,"watchers_count":35436,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21390,"mirror_url":null,"archived":false,"open_issues_count":902,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21390,"open_issues":902,"watchers":35436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14146"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14146"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14146/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14146/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/2d471636eb9160ab51b08e491e3f003f57adbc36"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"laanwj","id":126646,"node_id":"MDQ6VXNlcjEyNjY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/126646?v=4","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"comments":16,"review_comments":27,"maintainer_can_modify":false,"commits":2,"additions":153,"deletions":4,"changed_files":6}}
{"actor":{"display_login":"laanwj"}}