{"action":"created","issue":{"url":"https://api.github.com/repos/xiph/opus/issues/100","repository_url":"https://api.github.com/repos/xiph/opus","labels_url":"https://api.github.com/repos/xiph/opus/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/xiph/opus/issues/100/comments","events_url":"https://api.github.com/repos/xiph/opus/issues/100/events","html_url":"https://github.com/xiph/opus/pull/100","id":376266666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTIyOTY0","number":100,"title":"Add basic CMake support for Windows and Linux","user":{"login":"xnorpx","id":302709,"node_id":"MDQ6VXNlcjMwMjcwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/302709?v=4","gravatar_id":"","url":"https://api.github.com/users/xnorpx","html_url":"https://github.com/xnorpx","followers_url":"https://api.github.com/users/xnorpx/followers","following_url":"https://api.github.com/users/xnorpx/following{/other_user}","gists_url":"https://api.github.com/users/xnorpx/gists{/gist_id}","starred_url":"https://api.github.com/users/xnorpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnorpx/subscriptions","organizations_url":"https://api.github.com/users/xnorpx/orgs","repos_url":"https://api.github.com/users/xnorpx/repos","events_url":"https://api.github.com/users/xnorpx/events{/privacy}","received_events_url":"https://api.github.com/users/xnorpx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-11-01T06:11:40Z","updated_at":"2018-11-02T16:52:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xiph/opus/pulls/100","html_url":"https://github.com/xiph/opus/pull/100","diff_url":"https://github.com/xiph/opus/pull/100.diff","patch_url":"https://github.com/xiph/opus/pull/100.patch"},"body":"Yet another proposal for cmake\r\n\r\nIncluded:\r\n- Parse make files for sources\r\n- Some tests that passes\r\n- Tested on Windows 64bit debug and Linux 64 bit\r\n\r\nMissing:\r\n\r\n- Fixed point\r\n- Optimizations\r\n- Correct defines?\r\n- Unittests\r\n- Test on Mac\r\n\r\nHow to run:\r\n\r\n\r\n1. cd opus\r\n2  mkdir build\r\n3. cd build\r\n4. cmake ./../\r\n5. make\r\n6. ctest\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/xiph/opus/issues/comments/435442750","html_url":"https://github.com/xiph/opus/pull/100#issuecomment-435442750","issue_url":"https://api.github.com/repos/xiph/opus/issues/100","id":435442750,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTQ0Mjc1MA==","user":{"login":"xnorpx","id":302709,"node_id":"MDQ6VXNlcjMwMjcwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/302709?v=4","gravatar_id":"","url":"https://api.github.com/users/xnorpx","html_url":"https://github.com/xnorpx","followers_url":"https://api.github.com/users/xnorpx/followers","following_url":"https://api.github.com/users/xnorpx/following{/other_user}","gists_url":"https://api.github.com/users/xnorpx/gists{/gist_id}","starred_url":"https://api.github.com/users/xnorpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xnorpx/subscriptions","organizations_url":"https://api.github.com/users/xnorpx/orgs","repos_url":"https://api.github.com/users/xnorpx/repos","events_url":"https://api.github.com/users/xnorpx/events{/privacy}","received_events_url":"https://api.github.com/users/xnorpx/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T16:52:12Z","updated_at":"2018-11-02T16:52:12Z","author_association":"NONE","body":"@jmvalin \r\n\r\n1. It will do incremental build just fine.\r\n2. CMake will not regenerate the solution automagically as it doesn't see any changes so the user that add/remove a file needs to do either:\r\n\r\n- Delete solution and regenerate solution to pick up the new file or remove the file\r\n- Make a change in CMakelists.txt to get CMake to pick the new changes\r\n\r\nBut this is just for the local development when using CMake, I see this as a small price to pay to get initial CMake support for Opus\r\n\r\n@berkus VS2017 V.15.8.5 did not crash for me when git rm a file from the repo. The file only had a red mark in the solution and could of course not be opened.\r\n\r\n"}}
{"actor":{"display_login":"xnorpx"}}