{"action":"created","comment":{"url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/comments/206758166","pull_request_review_id":142230810,"id":206758166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjc1ODE2Ng==","diff_hunk":"@@ -23,41 +23,49 @@ public class WebsocketsTransport: Transport {\n         \n         webSocket = WebSocket(request: request)\n \n-        webSocket!.event.open = {\n-            self.delegate?.transportDidOpen()\n+        webSocket!.event.open = { [weak self] in\n+            guard let welf = self else { return }\n+            \n+            welf.delegate?.transportDidOpen()","path":"SignalRClient/WebsocketsTransport.swift","position":9,"original_position":9,"commit_id":"639781676459f2f2c4446e9398bfdef01b0aa5e3","original_commit_id":"639781676459f2f2c4446e9398bfdef01b0aa5e3","user":{"login":"moozzyk","id":1438884,"node_id":"MDQ6VXNlcjE0Mzg4ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1438884?v=4","gravatar_id":"","url":"https://api.github.com/users/moozzyk","html_url":"https://github.com/moozzyk","followers_url":"https://api.github.com/users/moozzyk/followers","following_url":"https://api.github.com/users/moozzyk/following{/other_user}","gists_url":"https://api.github.com/users/moozzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/moozzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moozzyk/subscriptions","organizations_url":"https://api.github.com/users/moozzyk/orgs","repos_url":"https://api.github.com/users/moozzyk/repos","events_url":"https://api.github.com/users/moozzyk/events{/privacy}","received_events_url":"https://api.github.com/users/moozzyk/received_events","type":"User","site_admin":false},"body":"What is the advantage of doing this?","created_at":"2018-08-01T05:25:36Z","updated_at":"2018-08-01T05:44:24Z","html_url":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23#discussion_r206758166","pull_request_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/comments/206758166"},"html":{"href":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23#discussion_r206758166"},"pull_request":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23","id":205079482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDc5NDgy","html_url":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23","diff_url":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23.diff","patch_url":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23.patch","issue_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/23","number":23,"state":"open","locked":false,"title":"Fixed a deadlock which occurred when we disconnect while still not fully connected","user":{"login":"miranl","id":297983,"node_id":"MDQ6VXNlcjI5Nzk4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/297983?v=4","gravatar_id":"","url":"https://api.github.com/users/miranl","html_url":"https://github.com/miranl","followers_url":"https://api.github.com/users/miranl/followers","following_url":"https://api.github.com/users/miranl/following{/other_user}","gists_url":"https://api.github.com/users/miranl/gists{/gist_id}","starred_url":"https://api.github.com/users/miranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranl/subscriptions","organizations_url":"https://api.github.com/users/miranl/orgs","repos_url":"https://api.github.com/users/miranl/repos","events_url":"https://api.github.com/users/miranl/events{/privacy}","received_events_url":"https://api.github.com/users/miranl/received_events","type":"User","site_admin":false},"body":"Also fixed some retain cycles ","created_at":"2018-07-31T11:22:40Z","updated_at":"2018-08-01T05:44:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c62beea94b09fe28814d24a419eb5836e9a80ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23/commits","review_comments_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23/comments","review_comment_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/23/comments","statuses_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/statuses/639781676459f2f2c4446e9398bfdef01b0aa5e3","head":{"label":"miranl:master","ref":"master","sha":"639781676459f2f2c4446e9398bfdef01b0aa5e3","user":{"login":"miranl","id":297983,"node_id":"MDQ6VXNlcjI5Nzk4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/297983?v=4","gravatar_id":"","url":"https://api.github.com/users/miranl","html_url":"https://github.com/miranl","followers_url":"https://api.github.com/users/miranl/followers","following_url":"https://api.github.com/users/miranl/following{/other_user}","gists_url":"https://api.github.com/users/miranl/gists{/gist_id}","starred_url":"https://api.github.com/users/miranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranl/subscriptions","organizations_url":"https://api.github.com/users/miranl/orgs","repos_url":"https://api.github.com/users/miranl/repos","events_url":"https://api.github.com/users/miranl/events{/privacy}","received_events_url":"https://api.github.com/users/miranl/received_events","type":"User","site_admin":false},"repo":{"id":143004212,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMDQyMTI=","name":"SignalR-Client-Swift","full_name":"miranl/SignalR-Client-Swift","owner":{"login":"miranl","id":297983,"node_id":"MDQ6VXNlcjI5Nzk4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/297983?v=4","gravatar_id":"","url":"https://api.github.com/users/miranl","html_url":"https://github.com/miranl","followers_url":"https://api.github.com/users/miranl/followers","following_url":"https://api.github.com/users/miranl/following{/other_user}","gists_url":"https://api.github.com/users/miranl/gists{/gist_id}","starred_url":"https://api.github.com/users/miranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranl/subscriptions","organizations_url":"https://api.github.com/users/miranl/orgs","repos_url":"https://api.github.com/users/miranl/repos","events_url":"https://api.github.com/users/miranl/events{/privacy}","received_events_url":"https://api.github.com/users/miranl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miranl/SignalR-Client-Swift","description":"Swift SignalR Client for Asp.Net Core SignalR server","fork":true,"url":"https://api.github.com/repos/miranl/SignalR-Client-Swift","forks_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/forks","keys_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/teams","hooks_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/hooks","issue_events_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/issues/events{/number}","events_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/events","assignees_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/assignees{/user}","branches_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/branches{/branch}","tags_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/tags","blobs_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/statuses/{sha}","languages_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/languages","stargazers_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/stargazers","contributors_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/contributors","subscribers_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/subscribers","subscription_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/subscription","commits_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/contents/{+path}","compare_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/merges","archive_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/downloads","issues_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/issues{/number}","pulls_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/pulls{/number}","milestones_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/milestones{/number}","notifications_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/labels{/name}","releases_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/releases{/id}","deployments_url":"https://api.github.com/repos/miranl/SignalR-Client-Swift/deployments","created_at":"2018-07-31T11:18:23Z","updated_at":"2018-07-31T11:18:25Z","pushed_at":"2018-07-31T10:55:25Z","git_url":"git://github.com/miranl/SignalR-Client-Swift.git","ssh_url":"git@github.com:miranl/SignalR-Client-Swift.git","clone_url":"https://github.com/miranl/SignalR-Client-Swift.git","svn_url":"https://github.com/miranl/SignalR-Client-Swift","homepage":"","size":1952,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moozzyk:master","ref":"master","sha":"1982e8b84df41a9da821d66f5b80c9f7d2e0d5c3","user":{"login":"moozzyk","id":1438884,"node_id":"MDQ6VXNlcjE0Mzg4ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1438884?v=4","gravatar_id":"","url":"https://api.github.com/users/moozzyk","html_url":"https://github.com/moozzyk","followers_url":"https://api.github.com/users/moozzyk/followers","following_url":"https://api.github.com/users/moozzyk/following{/other_user}","gists_url":"https://api.github.com/users/moozzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/moozzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moozzyk/subscriptions","organizations_url":"https://api.github.com/users/moozzyk/orgs","repos_url":"https://api.github.com/users/moozzyk/repos","events_url":"https://api.github.com/users/moozzyk/events{/privacy}","received_events_url":"https://api.github.com/users/moozzyk/received_events","type":"User","site_admin":false},"repo":{"id":83158295,"node_id":"MDEwOlJlcG9zaXRvcnk4MzE1ODI5NQ==","name":"SignalR-Client-Swift","full_name":"moozzyk/SignalR-Client-Swift","owner":{"login":"moozzyk","id":1438884,"node_id":"MDQ6VXNlcjE0Mzg4ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1438884?v=4","gravatar_id":"","url":"https://api.github.com/users/moozzyk","html_url":"https://github.com/moozzyk","followers_url":"https://api.github.com/users/moozzyk/followers","following_url":"https://api.github.com/users/moozzyk/following{/other_user}","gists_url":"https://api.github.com/users/moozzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/moozzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moozzyk/subscriptions","organizations_url":"https://api.github.com/users/moozzyk/orgs","repos_url":"https://api.github.com/users/moozzyk/repos","events_url":"https://api.github.com/users/moozzyk/events{/privacy}","received_events_url":"https://api.github.com/users/moozzyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moozzyk/SignalR-Client-Swift","description":"Swift SignalR Client for Asp.Net Core SignalR server","fork":false,"url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift","forks_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/forks","keys_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/teams","hooks_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/hooks","issue_events_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/events{/number}","events_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/events","assignees_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/assignees{/user}","branches_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/branches{/branch}","tags_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/tags","blobs_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/statuses/{sha}","languages_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/languages","stargazers_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/stargazers","contributors_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/contributors","subscribers_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/subscribers","subscription_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/subscription","commits_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/contents/{+path}","compare_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/merges","archive_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/downloads","issues_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues{/number}","pulls_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls{/number}","milestones_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/milestones{/number}","notifications_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/labels{/name}","releases_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/releases{/id}","deployments_url":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/deployments","created_at":"2017-02-25T19:53:50Z","updated_at":"2018-07-31T08:52:54Z","pushed_at":"2018-07-31T11:22:41Z","git_url":"git://github.com/moozzyk/SignalR-Client-Swift.git","ssh_url":"git@github.com:moozzyk/SignalR-Client-Swift.git","clone_url":"https://github.com/moozzyk/SignalR-Client-Swift.git","svn_url":"https://github.com/moozzyk/SignalR-Client-Swift","homepage":"","size":1954,"stargazers_count":31,"watchers_count":31,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":9,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23"},"html":{"href":"https://github.com/moozzyk/SignalR-Client-Swift/pull/23"},"issue":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/23"},"comments":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/moozzyk/SignalR-Client-Swift/statuses/639781676459f2f2c4446e9398bfdef01b0aa5e3"}},"author_association":"NONE"}}
{"actor":{"display_login":"moozzyk"}}