{"push_id":2320772711,"size":48,"distinct_size":48,"ref":"refs/heads/master","head":"1a8fe42f4a5e866b71323e99929e784bd5dbb174","before":"8d9e0512ec0e4410eb534693f73cc5dff0663484","commits":[{"sha":"f96822ea7782fdffc88a527776f020db0bbd9402","author":{"name":"Taras Tsugrii","email":"b25e393874d158f01b37820ee135abb404ef5073@fb.com"},"message":"Do not install unnecessary packages.\n\nSummary:\nTrusty now has a GCC 4.8 and a GHC 7.6 packages available by default, so there is not need to install them from external sources. Also, default version of GCC is most likely already pulled in by some other dependencies, so in the end we should end up pulling in fewer packages.\nCloses https://github.com/facebook/buck/pull/1755\n\nReviewed By: ttsugriy\n\nPulled By: ttsugriy\n\nfbshipit-source-id: 75044e4","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/f96822ea7782fdffc88a527776f020db0bbd9402"},{"sha":"1aad916a406fba75b72fd29116e27b48e4c4c342","author":{"name":"Sergey Balabanov","email":"eab24c0c41d5f6a3c755695c596dc478158c0dc8@fb.com"},"message":"Wait for event bus before listeners shutdown\n\nSummary:\nNot all event listeners are created equal. SuperConsole event listener is explicitly listed in try-with-resources block and closed before we wait for all events to complete, that leads to race condition - the final super console frame may not be sent to the client. Build finishes but UI does not say so.\nThis is a temporary solution before we refactor all listeners to follow proper deinitialization cycle.\n\nTest Plan: tests, buck run locally, cancellations\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: a403be4","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/1aad916a406fba75b72fd29116e27b48e4c4c342"},{"sha":"38d3f04f814b1c42c7b7f6da01f4aa3ec7b46586","author":{"name":"Taras Tsugrii","email":"b25e393874d158f01b37820ee135abb404ef5073@fb.com"},"message":"Update build instructions.\n\nSummary:\nUsing ant builds is no longer encouraged because they are not\nself-contained. Because of this users should build and use PEX archives\ninstead.\n\nTest Plan: CI\n\nReviewed By: philipjameson\n\nfbshipit-source-id: 9501c3b","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/38d3f04f814b1c42c7b7f6da01f4aa3ec7b46586"},{"sha":"a6a37a06766962ac5e2fdf83c4259a4b07c1de65","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Calculate min Android SDK verions in buck project\n\nSummary:\nIntelliJ projects do not currently support a min Android SDK version for buck created projects. This forces IntelliJ to default to Android SDK version 1, causing many symbols not to resolve as they were added post SDK version 1.\n\nTo solve this, did the following:\n\n1. Added a min Android SDK version config to .buckconfig.\n2. Added parsing of target manifests to buck project generation.\n3. If generate manifests is enabled, project creation generates manifests with best option on min SDK using a combination of defaults from buck config and target specific manifests.\n\nTest Plan: Unit tests added in diff, manual testing against android project\n\nReviewed By: mkillianey\n\nfbshipit-source-id: 3372558","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/a6a37a06766962ac5e2fdf83c4259a4b07c1de65"},{"sha":"a0a15d173fbe5702d9cbee0a10cd6cd8f9cf9684","author":{"name":"Rui Barbosa Martins","email":"e0b976060a5bff07520a2ebeca31a68033eab2bd@fb.com"},"message":"Revert \"[stampede] Genrule cross-cell exec calls lose the cell prefix after deserialisation.\"\n\nSummary: This change causes rule key divergence in examples that don't use cells.\n\nTest Plan: ci\n\nReviewed By: michsien, grzmiel\n\nfbshipit-source-id: 44532ad","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/a0a15d173fbe5702d9cbee0a10cd6cd8f9cf9684"},{"sha":"18ad9fa6d389eca6a1d3df15021dcf1a311678f7","author":{"name":"Ilya Klyuchnikov","email":"68fc6e794402c268a4a5d1798c1f428c3e587f7c@fb.com"},"message":"deleting a leftover\n\nSummary: `__init__.py` is not needed. It is not even listed in any BUCK files. No point to pollute the top directory.\n\nTest Plan: CI\n\nReviewed By: styurin\n\nfbshipit-source-id: a2e57f3","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/18ad9fa6d389eca6a1d3df15021dcf1a311678f7"},{"sha":"807fab0c7613fb81c61c5e681ae57d77d5e678b2","author":{"name":"Ilya Klyuchnikov","email":"68fc6e794402c268a4a5d1798c1f428c3e587f7c@fb.com"},"message":"using the standard (and documented) mechanism for parsing lists of flags in CxxBuckConfig\n\nSummary: The mechanism was introduced a while ago and is properly used in `RustBuckConfig`. `CxxBuckConfig` should use the same logic - windows builds depend on it since on windows it is very likely that quoting/escaping is necessary in cxxflags in toolchain definitions.\n\nTest Plan:\nCI, testing locally with different VS toolchains in `.buckconfig` (with quoted cxxflags and spaces)\nUsing `.buckconfig`:\n```\n[cxx#vs_managed]\n  cc=third-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/cl.exe\n  cflags = \\\n    /Ithird-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/include \\\n    /Ithird-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/atlmfc/include \\\n    /Ithird-party/toolchains/vs2017_15.5/VC/Auxiliary/VS/include \\\n    /Ithird-party/toolchains/vs2017_15.5/WindowsSdk/10.0.16299.91/Include/10.0.16299.0/km \\\n    /Ithird-party/toolchains/vs2017_15.5/WindowsSdk/10.0.16299.91/Include/10.0.16299.0/shared \\\n    /Ithird-party/toolchains/vs2017_15.5/WindowsSdk/10.0.16299.91/Include/10.0.16299.0/ucrt \\\n    /Ithird-party/toolchains/vs2017_15.5/WindowsSdk/10.0.16299.91/Include/10.0.16299.0/um \\\n    /Ithird-party/toolchains/vs2017_15.5/WindowsSdk/10.0.16299.91/Include/10.0.16299.0/winrt\n  ...\n  ld=third-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/link.exe\n  linker_platform=windows\n  ar=third-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/lib.exe\n  archiver_platform=windows\n  ranlib=third-party/toolchains/vs2017_15.5/BuildTools/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/lib.exe\n\n[cxx#vs_local]\n  cc=\"C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/cl.exe\"\n  cflags = \\\n    \"/IC:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/include\" \\\n    \"/IC:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/include\" \\\n    \"/IC:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/VS/include\" \\\n    \"/IC:/Program Files (x86)/Windows Kits/10/Include/10.0.16299.0/shared\" \\\n    \"/IC:/Program Files (x86)/Windows Kits/10/Include/10.0.16299.0/ucrt\" \\\n    \"/IC:/Program Files (x86)/Windows Kits/10/Include/10.0.16299.0/um\" \\\n    \"/IC:/Program Files (x86)/Windows Kits/10/Include/10.0.16299.0/winrt\"\n  cc_type=windows\n  ...\n  ld=\"C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/link.exe\"\n  linker_platform=windows\n  ar=\"C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/lib.exe\"\n  archiver_platform=windows\n  ranlib=\"C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.12.25827/bin/HostX64/x64/lib.exe\"\n```\nBuilding: `buck build \"some_lib#vs_managed,static\"` and `buck build \"some_lib#vs_local,static\"`. Before the change the second target fails, after the chang the second target is OK.\n\nReviewed By: styurin\n\nfbshipit-source-id: e3b557f","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/807fab0c7613fb81c61c5e681ae57d77d5e678b2"},{"sha":"5eeab6d869057b37c958052fe6952f67ef3b2aad","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Do not fall back to python.interpreter when discovering python for the parser\n\nSummary:\nFrom https://github.com/facebook/buck/issues/1749:\n\n`python` sections in .buckconfig are used to define Python configurations and they act as platform configurations. The parser of BUCK files falls back to `python.interpreter` (if parser.python_interpreter can't be found).\n\nThis logic introduces hidden meaning of `python.interpreter` and blocks us from referencing Python interpreters located inside a repository.\n\nThis change stops doing that and modifies the parser to use the `parser.python_interpreter` option to detect an interpreter for BUCK parser without falling back to `python.interpreter`.\n\nThis may break existing projects that rely on python.interpreter. The solution is to copy `python.interpreter` to `parser.python_interpreter`.\n\nNotes for reviewers:\n\n- `ParserPythonInterpreterProvider` was updated to contain logic responsible for finding the interpreter and not use Python toolchain classes (which allows remove dependency on Python toolchain from core component),\n- `ParserPythonInterpreterProvider` was left as an internal detail of implementation. The only change in the interface is the need to pass `ExecutableFinder` which is used by `ParserPythonInterpreterProvider`.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 3603a1a","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/5eeab6d869057b37c958052fe6952f67ef3b2aad"},{"sha":"090e8f7d3c4ff71b370d42220ac29a7c9ebf1689","author":{"name":"Sergey Tyurin","email":"37a8a4295cb534fc4c2ca4cdd320c778f3f1b8ac@fb.com"},"message":"Reduce number of methods in PythonInterpreter\n\nSummary: `PythonInterpreter.getPythonInterpreterPath` was used in parser code which no longer relies on Python toolchain.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 42f0530","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/090e8f7d3c4ff71b370d42220ac29a7c9ebf1689"},{"sha":"73da5abc8ce7d6995dfb60f6985a5200dbdab8a5","author":{"name":"Keegan Parker","email":"3a29528a5997e5bf12b1b2910513efa4a2c44d6e@fb.com"},"message":"Add EndToEndWorkspaceTest with small Proof of Concept test\n\nSummary: Note that I do not expect most tests to follow the format in EndToEndWorkspaceTest, as I will be building the TestRunner on top of the Workspace.\n\nTest Plan: Ran new tests locally\n\nReviewed By: philipjameson\n\nfbshipit-source-id: bb2a990","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/73da5abc8ce7d6995dfb60f6985a5200dbdab8a5"},{"sha":"d92cc362ef3d57b9bab75a545f82afb0d8a10a3c","author":{"name":"Lukasz Langa","email":"351060498a3c66f40a24039a08c74f1f5245129b@fb.com"},"message":"Move inner functions up in the run_inplace.py template\n\nSummary: Trivial no-op that is going to make the next diff way clearer.\n\nTest Plan: everything works exactly the same\n\nReviewed By: cooperlees\n\nfbshipit-source-id: 449d0bb","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/d92cc362ef3d57b9bab75a545f82afb0d8a10a3c"},{"sha":"69ce68554896642301ae7bf736888e5acfff9c54","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"coercers: add query-based macro coercers\n\nSummary: This adds coercer support for the various query macros supports by `genrule`.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 03fe4ca","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/69ce68554896642301ae7bf736888e5acfff9c54"},{"sha":"ff4e46b547523f3c84b1db00c1c8dcd3610ca034","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"coercers: add worker macro\n\nSummary:\nThis adds a coercer for the worker macro supported by `genrule`.  While here,\nthis also refactors the `BuildTargetMacroTypeCoercer` to be more reusable.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: a6850ac","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/ff4e46b547523f3c84b1db00c1c8dcd3610ca034"},{"sha":"de4528359a9440034ff44a4b240fd20d00df8c09","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"StringExpander: port to use strongly-typed `Macro`s\n\nSummary: This refactors `StringExpander` and callers to use strongly typed macros.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: 4d31320","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/de4528359a9440034ff44a4b240fd20d00df8c09"},{"sha":"2026edc2830a89d86f44cd5981cb9fdaa4d3f0e8","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"Macro: add default implementation for target translation\n\nSummary:\nMany sub-classes have no build targets, and so this helps avoid some\nboilerplate code.\n\nTest Plan: CI\n\nReviewed By: dinhviethoa, ttsugriy\n\nfbshipit-source-id: d88aac2","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/2026edc2830a89d86f44cd5981cb9fdaa4d3f0e8"},{"sha":"4b8a403c84d4dd671ff687dba5f86440513f6f9d","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"CxxGenruleDescription: cleanup some IJ warnings\n\nSummary:\nRemove some unneeded throw clauses and reduce inner class constructor\nvisibilities.\n\nTest Plan: CI\n\nReviewed By: jtorkkola\n\nfbshipit-source-id: 966b3c0","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/4b8a403c84d4dd671ff687dba5f86440513f6f9d"},{"sha":"baf872c7d39960b01b39a604c3bddc482bd75fc9","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"cxx_genrule: remove `$(location-platform ...)` macro\n\nSummary:\nThis shouldn't be needed any more now that `$(location ...)` macros support\nchaining other `cxx_genrule`s, via `CxxLocationMacroExpander`.\n\nTest Plan: CI\n\nReviewed By: ttsugriy\n\nfbshipit-source-id: c411274","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/baf872c7d39960b01b39a604c3bddc482bd75fc9"},{"sha":"7ef68353e23d2a330a93200d59661aadc9834543","author":{"name":"Philip Jameson","email":"7b3d3361e0a108d2b236f500b0e8d125703b1241@fb.com"},"message":"Make targets and rulekey stress runners pass targets in random order\n\nSummary: Parser order might matter if people do weird things like caching inside of their targets files. Make sure we get the same results regardless of parse order\n\nTest Plan: Tests failed, updated them so they pass.\n\nReviewed By: styurin\n\nfbshipit-source-id: 2f65560","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/7ef68353e23d2a330a93200d59661aadc9834543"},{"sha":"a4f232e51253956f2e011bdc64430921b6107c3e","author":{"name":"Zhongpeng Lin","email":"d5d4b96fe0a56a5cf3a2b88f9f3a15a9e622ea04@uber.com"},"message":"Copy deps of go_library to go_test\n\nSummary:\nFixed #1704\n\nstyurin Please review.\nCloses https://github.com/facebook/buck/pull/1753\n\nReviewed By: styurin\n\nPulled By: styurin\n\nfbshipit-source-id: 5adaa35","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/a4f232e51253956f2e011bdc64430921b6107c3e"},{"sha":"a6175b10c8746843bb7740631fd46d6611e4cf8b","author":{"name":"Philip Jameson","email":"7b3d3361e0a108d2b236f500b0e8d125703b1241@fb.com"},"message":"Document project.motd\n\nSummary: There's an undocumented project.motd configuration option. Add docs\n\nTest Plan: Read in soyweb-local.sh\n\nReviewed By: jtorkkola\n\nfbshipit-source-id: 2cd1f32","distinct":true,"url":"https://api.github.com/repos/ttsugriy/buck/commits/a6175b10c8746843bb7740631fd46d6611e4cf8b"}]}
{"actor":{"display_login":"ttsugriy"}}