{"action":"created","issue":{"url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/31","repository_url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws","labels_url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/31/comments","events_url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/31/events","html_url":"https://github.com/bclayton-usgs/nshmp-site-ws/issues/31","id":370673049,"node_id":"MDU6SXNzdWUzNzA2NzMwNDk=","number":31,"title":"Service revisions","user":{"login":"pmpowers-usgs","id":2379604,"node_id":"MDQ6VXNlcjIzNzk2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2379604?v=4","gravatar_id":"","url":"https://api.github.com/users/pmpowers-usgs","html_url":"https://github.com/pmpowers-usgs","followers_url":"https://api.github.com/users/pmpowers-usgs/followers","following_url":"https://api.github.com/users/pmpowers-usgs/following{/other_user}","gists_url":"https://api.github.com/users/pmpowers-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/pmpowers-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmpowers-usgs/subscriptions","organizations_url":"https://api.github.com/users/pmpowers-usgs/orgs","repos_url":"https://api.github.com/users/pmpowers-usgs/repos","events_url":"https://api.github.com/users/pmpowers-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/pmpowers-usgs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bclayton-usgs","id":31293106,"node_id":"MDQ6VXNlcjMxMjkzMTA2","avatar_url":"https://avatars1.githubusercontent.com/u/31293106?v=4","gravatar_id":"","url":"https://api.github.com/users/bclayton-usgs","html_url":"https://github.com/bclayton-usgs","followers_url":"https://api.github.com/users/bclayton-usgs/followers","following_url":"https://api.github.com/users/bclayton-usgs/following{/other_user}","gists_url":"https://api.github.com/users/bclayton-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/bclayton-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclayton-usgs/subscriptions","organizations_url":"https://api.github.com/users/bclayton-usgs/orgs","repos_url":"https://api.github.com/users/bclayton-usgs/repos","events_url":"https://api.github.com/users/bclayton-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/bclayton-usgs/received_events","type":"User","site_admin":false},"assignees":[{"login":"bclayton-usgs","id":31293106,"node_id":"MDQ6VXNlcjMxMjkzMTA2","avatar_url":"https://avatars1.githubusercontent.com/u/31293106?v=4","gravatar_id":"","url":"https://api.github.com/users/bclayton-usgs","html_url":"https://github.com/bclayton-usgs","followers_url":"https://api.github.com/users/bclayton-usgs/followers","following_url":"https://api.github.com/users/bclayton-usgs/following{/other_user}","gists_url":"https://api.github.com/users/bclayton-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/bclayton-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclayton-usgs/subscriptions","organizations_url":"https://api.github.com/users/bclayton-usgs/orgs","repos_url":"https://api.github.com/users/bclayton-usgs/repos","events_url":"https://api.github.com/users/bclayton-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/bclayton-usgs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-16T15:34:49Z","updated_at":"2018-11-01T16:41:20Z","closed_at":null,"author_association":"COLLABORATOR","body":"* Follow calls to getBasins(); it looks like the basin file is being read on every request.\r\n* Parsing the basin file should happen once to create a static collection of regions.\r\n* Also store static reference to the raw geojson string; don't hold on to intermediate FeatureCollection classes and reserialize.\r\n* Reduce javadoc to the basics that describe how the service works; primarily that it is a relay to the AGOL service.\r\n* Reduce visibility where possible."},"comment":{"url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/comments/435103333","html_url":"https://github.com/bclayton-usgs/nshmp-site-ws/issues/31#issuecomment-435103333","issue_url":"https://api.github.com/repos/bclayton-usgs/nshmp-site-ws/issues/31","id":435103333,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTEwMzMzMw==","user":{"login":"pmpowers-usgs","id":2379604,"node_id":"MDQ6VXNlcjIzNzk2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2379604?v=4","gravatar_id":"","url":"https://api.github.com/users/pmpowers-usgs","html_url":"https://github.com/pmpowers-usgs","followers_url":"https://api.github.com/users/pmpowers-usgs/followers","following_url":"https://api.github.com/users/pmpowers-usgs/following{/other_user}","gists_url":"https://api.github.com/users/pmpowers-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/pmpowers-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmpowers-usgs/subscriptions","organizations_url":"https://api.github.com/users/pmpowers-usgs/orgs","repos_url":"https://api.github.com/users/pmpowers-usgs/repos","events_url":"https://api.github.com/users/pmpowers-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/pmpowers-usgs/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T16:41:20Z","updated_at":"2018-11-01T16:41:20Z","author_association":"COLLABORATOR","body":"* Add logic to round the supplied lat-lon to the nearest 0.02 degrees; there are a lot of ways this can behave unexpectedly; discuss further\r\n\r\n* Add tests for the following sites (from NshmpSite.java):\r\n```\r\n    List<NshmpSite> locations = ImmutableList.of(\r\n        \r\n        // LA Basin\r\n        LOS_ANGELES_CA,\r\n        NORTHRIDGE_CA,\r\n        \r\n        // Bay Area\r\n        SAN_FRANCISCO_CA,\r\n        SAN_JOSE_CA,\r\n        OAKLAND_CA,\r\n        \r\n        // Wasatch Front\r\n        SALT_LAKE_CITY_UT,\r\n        PROVO_UT,\r\n        \r\n        // Puget Lowland\r\n        SEATTLE_WA,\r\n        TACOMA_WA,\r\n        \r\n        // Outside basin (null expected)\r\n        ELKO_NV);\r\n```\r\n\r\nRun the service against the sites to get the current values and then hard code into the test case.    \r\n\r\n\r\n"}}
{"actor":{"display_login":"pmpowers-usgs"}}