{"action":"created","issue":{"url":"https://api.github.com/repos/cms-dev/cms/issues/913","repository_url":"https://api.github.com/repos/cms-dev/cms","labels_url":"https://api.github.com/repos/cms-dev/cms/issues/913/labels{/name}","comments_url":"https://api.github.com/repos/cms-dev/cms/issues/913/comments","events_url":"https://api.github.com/repos/cms-dev/cms/issues/913/events","html_url":"https://github.com/cms-dev/cms/pull/913","id":308268675,"number":913,"title":"Fix isolate options","user":{"login":"gollux","id":13495329,"avatar_url":"https://avatars0.githubusercontent.com/u/13495329?v=4","gravatar_id":"","url":"https://api.github.com/users/gollux","html_url":"https://github.com/gollux","followers_url":"https://api.github.com/users/gollux/followers","following_url":"https://api.github.com/users/gollux/following{/other_user}","gists_url":"https://api.github.com/users/gollux/gists{/gist_id}","starred_url":"https://api.github.com/users/gollux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gollux/subscriptions","organizations_url":"https://api.github.com/users/gollux/orgs","repos_url":"https://api.github.com/users/gollux/repos","events_url":"https://api.github.com/users/gollux/events{/privacy}","received_events_url":"https://api.github.com/users/gollux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-24T14:53:08Z","updated_at":"2018-03-24T15:00:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cms-dev/cms/pulls/913","html_url":"https://github.com/cms-dev/cms/pull/913","diff_url":"https://github.com/cms-dev/cms/pull/913.diff","patch_url":"https://github.com/cms-dev/cms/pull/913.patch"},"body":"I reviewed how current CMS calls isolate and there are several problems with it:\r\n\r\n(1) When using cgroups (which is currently the CMS default), --cg-timing is not specified, so the time limit does not work properly.\r\n\r\n(2) When not using cgroups, memory limit is still passed as --cg-mem, which does not work.\r\n\r\n(3) We do not set --quota, so unless root set up FS quotas for all UIDs used by isolate, the disk space consumed by the solution is not limited at all.\r\n\r\nThis pull request solves (1) and (2). I would like to know you opinion how to specify the quota: should I add a setting in the config file for that? Or a more general config setting for adding arbitrary isolate options (--extra-time could be handy, too)?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cms-dev/cms/913)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cms-dev/cms/issues/comments/375895481","html_url":"https://github.com/cms-dev/cms/pull/913#issuecomment-375895481","issue_url":"https://api.github.com/repos/cms-dev/cms/issues/913","id":375895481,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-24T15:00:47Z","updated_at":"2018-03-24T15:00:47Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=h1) Report\n> Merging [#913](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=desc) into [master](https://codecov.io/gh/cms-dev/cms/commit/0591fe77cd3f7de83c720fd5a553d3a1f46948b0?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `75%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/cms-dev/cms/pull/913/graphs/tree.svg?token=XVAwZdiUV8&src=pr&height=150&width=650)](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #913      +/-   ##\n==========================================\n+ Coverage   61.08%   61.08%   +<.01%     \n==========================================\n  Files         203      203              \n  Lines       16938    16940       +2     \n==========================================\n+ Hits        10346    10348       +2     \n  Misses       6592     6592\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #functionaltests | `47.14% <75%> (+0.05%)` | :arrow_up: |\n| #unittests | `37.43% <0%> (-0.02%)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cms/grading/Sandbox.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL2dyYWRpbmcvU2FuZGJveC5weQ==) | `67.01% <75%> (+0.29%)` | :arrow_up: |\n| [cms/io/PsycoGevent.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL2lvL1BzeWNvR2V2ZW50LnB5) | `80.48% <0%> (-4.88%)` | :arrow_down: |\n| [cms/db/base.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL2RiL2Jhc2UucHk=) | `84.25% <0%> (-3.71%)` | :arrow_down: |\n| [cms/service/Worker.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvV29ya2VyLnB5) | `80% <0%> (-3.16%)` | :arrow_down: |\n| [cms/grading/Job.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL2dyYWRpbmcvSm9iLnB5) | `90.38% <0%> (-0.97%)` | :arrow_down: |\n| [cms/service/EvaluationService.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvRXZhbHVhdGlvblNlcnZpY2UucHk=) | `68.97% <0%> (-0.77%)` | :arrow_down: |\n| [cms/service/ProxyService.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2UvUHJveHlTZXJ2aWNlLnB5) | `70.2% <0%> (-0.51%)` | :arrow_down: |\n| [cms/server/admin/handlers/base.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL3NlcnZlci9hZG1pbi9oYW5kbGVycy9iYXNlLnB5) | `68.3% <0%> (+0.32%)` | :arrow_up: |\n| [cms/service/workerpool.py](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree#diff-Y21zL3NlcnZpY2Uvd29ya2VycG9vbC5weQ==) | `61.57% <0%> (+0.49%)` | :arrow_up: |\n| ... and [5 more](https://codecov.io/gh/cms-dev/cms/pull/913/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=footer). Last update [0591fe7...fff8912](https://codecov.io/gh/cms-dev/cms/pull/913?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}