{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/94","repository_url":"https://api.github.com/repos/CartoDB/odbc_fdw","labels_url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/94/comments","events_url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/94/events","html_url":"https://github.com/CartoDB/odbc_fdw/issues/94","id":388581856,"node_id":"MDU6SXNzdWUzODg1ODE4NTY=","number":94,"title":"make fails with errors","user":{"login":"arnaudbruniquel","id":45592888,"node_id":"MDQ6VXNlcjQ1NTkyODg4","avatar_url":"https://avatars0.githubusercontent.com/u/45592888?v=4","gravatar_id":"","url":"https://api.github.com/users/arnaudbruniquel","html_url":"https://github.com/arnaudbruniquel","followers_url":"https://api.github.com/users/arnaudbruniquel/followers","following_url":"https://api.github.com/users/arnaudbruniquel/following{/other_user}","gists_url":"https://api.github.com/users/arnaudbruniquel/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaudbruniquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaudbruniquel/subscriptions","organizations_url":"https://api.github.com/users/arnaudbruniquel/orgs","repos_url":"https://api.github.com/users/arnaudbruniquel/repos","events_url":"https://api.github.com/users/arnaudbruniquel/events{/privacy}","received_events_url":"https://api.github.com/users/arnaudbruniquel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-07T09:58:06Z","updated_at":"2018-12-19T16:39:08Z","closed_at":"2018-12-19T16:38:04Z","author_association":"NONE","body":"### Context\r\nI cannot build the project. make command fails with many errors.\r\n\r\n### Steps to Reproduce\r\ngit clone \\<repository\\>\r\nmake\r\n\r\n### Current Result\r\n\r\n`\r\n[root@dbtool odbc_fdw-0.3.0]# make\r\ngcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -DLINUX_OOM_SCORE_ADJ=0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fPIC -I. -I. -I/usr/include/pgsql/server -I/usr/include/pgsql/internal -D_GNU_SOURCE -I/usr/include/libxml2   -c -o odbc_fdw.o odbc_fdw.c\r\nodbc_fdw.c:186:31: erreur: unknown type name ‘ImportForeignSchemaStmt’\r\n List* odbcImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid);\r\n                               ^\r\nodbc_fdw.c: In function ‘odbc_fdw_handler’:\r\nodbc_fdw.c:224:29: attention : assignment from incompatible pointer type [enabled by default]\r\n  fdwroutine->GetForeignPlan = odbcGetForeignPlan;\r\n                             ^\r\nodbc_fdw.c:230:12: erreur: ‘FdwRoutine’ has no member named ‘ImportForeignSchema’\r\n  fdwroutine->ImportForeignSchema = odbcImportForeignSchema;\r\n            ^\r\nodbc_fdw.c:230:36: erreur: ‘odbcImportForeignSchema’ undeclared (first use in this function)\r\n  fdwroutine->ImportForeignSchema = odbcImportForeignSchema;\r\n                                    ^\r\nodbc_fdw.c:230:36: note: each undeclared identifier is reported only once for each function it appears in\r\nodbc_fdw.c: In function ‘odbc_table_size’:\r\nodbc_fdw.c:946:2: attention : ISO C89 interdit les mélanges de déclarations et de code [-Wdeclaration-after-statement]\r\n  Oid serverOid = oid_from_server_name(serverName);\r\n  ^\r\nodbc_fdw.c: In function ‘odbc_query_size’:\r\nodbc_fdw.c:970:2: attention : ISO C89 interdit les mélanges de déclarations et de code [-Wdeclaration-after-statement]\r\n  Oid serverOid = oid_from_server_name(serverName);\r\n  ^\r\nodbc_fdw.c: In function ‘odbc_tables_list’:\r\nodbc_fdw.c:1019:3: attention : ISO C89 interdit les mélanges de déclarations et de code [-Wdeclaration-after-statement]\r\n   MemoryContext oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);\r\n   ^\r\nodbc_fdw.c:1023:3: attention : ISO C89 interdit les mélanges de déclarations et de code [-Wdeclaration-after-statement]\r\n   char *serverName = text_to_cstring(PG_GETARG_TEXT_PP(0));\r\n   ^\r\nodbc_fdw.c:1029:3: attention : ISO C89 interdit les mélanges de déclarations et de code [-Wdeclaration-after-statement]\r\n   odbcFdwOptions options;\r\n   ^\r\nodbc_fdw.c: In function ‘odbcGetForeignPaths’:\r\nodbc_fdw.c:1258:19: erreur: too many arguments to function ‘create_foreignscan_path’\r\n                   NIL /* no fdw_private list */));\r\n                   ^\r\nIn file included from odbc_fdw.c:50:0:\r\n/usr/include/pgsql/server/optimizer/pathnode.h:76:21: note: declared here\r\n extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,\r\n                     ^\r\nodbc_fdw.c: In function ‘odbcGetForeignPlan’:\r\nodbc_fdw.c:1284:26: erreur: too many arguments to function ‘make_foreignscan’\r\n                          NULL /* outer_plan */ );\r\n                          ^\r\nIn file included from odbc_fdw.c:52:0:\r\n/usr/include/pgsql/server/optimizer/planmain.h:49:21: note: declared here\r\n extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,\r\n                     ^\r\nodbc_fdw.c: Hors de toute fonction :\r\nodbc_fdw.c:1863:25: erreur: unknown type name ‘ImportForeignSchemaStmt’\r\n odbcImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)\r\n                         ^\r\nodbc_fdw.c:253:1: attention : ‘empty_string_if_null’ defined but not used [-Wunused-function]\r\n empty_string_if_null(char *string)\r\n ^\r\nodbc_fdw.c:1852:1: attention : ‘appendOption’ defined but not used [-Wunused-function]\r\n appendOption(StringInfo str, bool first, const char* option_name, const char* option_value)\r\n ^\r\nmake: *** [odbc_fdw.o] Erreur 1\r\n`\r\n\r\n### Expected result\r\nsuccess of make command\r\n\r\n\r\n### System trying to connect to and version\r\nI'm planning on using the fdw to connect to a DB2 for iSeries database (odbc part of things already sorted, proprietary IBM driver installed and isql access to database possible)\r\n\r\n\r\n### Additional info\r\nI'm running centos 7.6\r\nI hope it's ok but I did not install following requirements because I only need to connect to DB2 :\r\nlibmyodbc: >= 5.1\r\nFreeTDS: >= 1.0\r\nhive-odbc-native: >= 2.1\r\n\r\nNot sure if this is a bug or if i've done something wrong. I'm new to odbc and postgresql (nor am i a developper).\r\n"},"comment":{"url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/comments/448661320","html_url":"https://github.com/CartoDB/odbc_fdw/issues/94#issuecomment-448661320","issue_url":"https://api.github.com/repos/CartoDB/odbc_fdw/issues/94","id":448661320,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODY2MTMyMA==","user":{"login":"arnaudbruniquel","id":45592888,"node_id":"MDQ6VXNlcjQ1NTkyODg4","avatar_url":"https://avatars0.githubusercontent.com/u/45592888?v=4","gravatar_id":"","url":"https://api.github.com/users/arnaudbruniquel","html_url":"https://github.com/arnaudbruniquel","followers_url":"https://api.github.com/users/arnaudbruniquel/followers","following_url":"https://api.github.com/users/arnaudbruniquel/following{/other_user}","gists_url":"https://api.github.com/users/arnaudbruniquel/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaudbruniquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaudbruniquel/subscriptions","organizations_url":"https://api.github.com/users/arnaudbruniquel/orgs","repos_url":"https://api.github.com/users/arnaudbruniquel/repos","events_url":"https://api.github.com/users/arnaudbruniquel/events{/privacy}","received_events_url":"https://api.github.com/users/arnaudbruniquel/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T16:39:08Z","updated_at":"2018-12-19T16:39:08Z","author_association":"NONE","body":"After switching to centos 7.5 with postgreSQL 9.6, I managed to compile the sources."}}
{"actor":{"display_login":"arnaudbruniquel"}}