{"action":"created","comment":{"url":"https://api.github.com/repos/particl/dapp-shell/pulls/comments/167856604","pull_request_review_id":96132195,"id":167856604,"diff_hunk":"@@ -136,12 +181,12 @@ export class PriceTickerService {\n      * @param currency\n      * @returns {Promise<PriceTicker>}\n      */\n-    public async needTobeUpdate(priceTicker: PriceTicker): Promise<boolean> {\n+    private async needTobeUpdate(priceTicker: PriceTicker): Promise<boolean> {\n         const diffMint = await this.checkDiffBtwDate(priceTicker['updatedAt']);\n         return (diffMint > process.env.DATA_CHECK_DELAY) ? true : false;\n     }\n \n-    public async getAndCreateData(currency: string): Promise<any> {\n+    private async getAndCreateData(currency: string): Promise<any> {\n         const returnData: any = [];","path":"src/api/services/PriceTickerService.ts","position":null,"original_position":83,"commit_id":"30b5b49b3321180f6f523a283c171e646cb2048e","original_commit_id":"306b6140c55f4086adcead11b2c47546402241b1","user":{"login":"cis-navjot-g","id":33522186,"avatar_url":"https://avatars3.githubusercontent.com/u/33522186?v=4","gravatar_id":"","url":"https://api.github.com/users/cis-navjot-g","html_url":"https://github.com/cis-navjot-g","followers_url":"https://api.github.com/users/cis-navjot-g/followers","following_url":"https://api.github.com/users/cis-navjot-g/following{/other_user}","gists_url":"https://api.github.com/users/cis-navjot-g/gists{/gist_id}","starred_url":"https://api.github.com/users/cis-navjot-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cis-navjot-g/subscriptions","organizations_url":"https://api.github.com/users/cis-navjot-g/orgs","repos_url":"https://api.github.com/users/cis-navjot-g/repos","events_url":"https://api.github.com/users/cis-navjot-g/events{/privacy}","received_events_url":"https://api.github.com/users/cis-navjot-g/received_events","type":"User","site_admin":false},"body":"I have removed that and put single function for update and check ","created_at":"2018-02-13T13:01:23Z","updated_at":"2018-02-13T13:01:23Z","html_url":"https://github.com/particl/dapp-shell/pull/151#discussion_r167856604","pull_request_url":"https://api.github.com/repos/particl/dapp-shell/pulls/151","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/comments/167856604"},"html":{"href":"https://github.com/particl/dapp-shell/pull/151#discussion_r167856604"},"pull_request":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/151"}},"in_reply_to_id":167524098},"pull_request":{"url":"https://api.github.com/repos/particl/dapp-shell/pulls/151","id":167922984,"html_url":"https://github.com/particl/dapp-shell/pull/151","diff_url":"https://github.com/particl/dapp-shell/pull/151.diff","patch_url":"https://github.com/particl/dapp-shell/pull/151.patch","issue_url":"https://api.github.com/repos/particl/dapp-shell/issues/151","number":151,"state":"open","locked":false,"title":"PriceTicker : Part 228","user":{"login":"cis-navjot-g","id":33522186,"avatar_url":"https://avatars3.githubusercontent.com/u/33522186?v=4","gravatar_id":"","url":"https://api.github.com/users/cis-navjot-g","html_url":"https://github.com/cis-navjot-g","followers_url":"https://api.github.com/users/cis-navjot-g/followers","following_url":"https://api.github.com/users/cis-navjot-g/following{/other_user}","gists_url":"https://api.github.com/users/cis-navjot-g/gists{/gist_id}","starred_url":"https://api.github.com/users/cis-navjot-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cis-navjot-g/subscriptions","organizations_url":"https://api.github.com/users/cis-navjot-g/orgs","repos_url":"https://api.github.com/users/cis-navjot-g/repos","events_url":"https://api.github.com/users/cis-navjot-g/events{/privacy}","received_events_url":"https://api.github.com/users/cis-navjot-g/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-08T09:52:35Z","updated_at":"2018-02-13T13:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a0f92260a526632ec73ae7af6d321f8981b705d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/particl/dapp-shell/pulls/151/commits","review_comments_url":"https://api.github.com/repos/particl/dapp-shell/pulls/151/comments","review_comment_url":"https://api.github.com/repos/particl/dapp-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/particl/dapp-shell/issues/151/comments","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/30b5b49b3321180f6f523a283c171e646cb2048e","head":{"label":"particl:PriceTicker","ref":"PriceTicker","sha":"30b5b49b3321180f6f523a283c171e646cb2048e","user":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"repo":{"id":109120213,"name":"dapp-shell","full_name":"particl/dapp-shell","owner":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/particl/dapp-shell","description":"DApp Shell","fork":false,"url":"https://api.github.com/repos/particl/dapp-shell","forks_url":"https://api.github.com/repos/particl/dapp-shell/forks","keys_url":"https://api.github.com/repos/particl/dapp-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particl/dapp-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particl/dapp-shell/teams","hooks_url":"https://api.github.com/repos/particl/dapp-shell/hooks","issue_events_url":"https://api.github.com/repos/particl/dapp-shell/issues/events{/number}","events_url":"https://api.github.com/repos/particl/dapp-shell/events","assignees_url":"https://api.github.com/repos/particl/dapp-shell/assignees{/user}","branches_url":"https://api.github.com/repos/particl/dapp-shell/branches{/branch}","tags_url":"https://api.github.com/repos/particl/dapp-shell/tags","blobs_url":"https://api.github.com/repos/particl/dapp-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particl/dapp-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particl/dapp-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/particl/dapp-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/particl/dapp-shell/languages","stargazers_url":"https://api.github.com/repos/particl/dapp-shell/stargazers","contributors_url":"https://api.github.com/repos/particl/dapp-shell/contributors","subscribers_url":"https://api.github.com/repos/particl/dapp-shell/subscribers","subscription_url":"https://api.github.com/repos/particl/dapp-shell/subscription","commits_url":"https://api.github.com/repos/particl/dapp-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/particl/dapp-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/particl/dapp-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/particl/dapp-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/particl/dapp-shell/contents/{+path}","compare_url":"https://api.github.com/repos/particl/dapp-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particl/dapp-shell/merges","archive_url":"https://api.github.com/repos/particl/dapp-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particl/dapp-shell/downloads","issues_url":"https://api.github.com/repos/particl/dapp-shell/issues{/number}","pulls_url":"https://api.github.com/repos/particl/dapp-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/particl/dapp-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/particl/dapp-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particl/dapp-shell/labels{/name}","releases_url":"https://api.github.com/repos/particl/dapp-shell/releases{/id}","deployments_url":"https://api.github.com/repos/particl/dapp-shell/deployments","created_at":"2017-11-01T10:54:18Z","updated_at":"2018-01-24T20:45:39Z","pushed_at":"2018-02-13T11:53:45Z","git_url":"git://github.com/particl/dapp-shell.git","ssh_url":"git@github.com:particl/dapp-shell.git","clone_url":"https://github.com/particl/dapp-shell.git","svn_url":"https://github.com/particl/dapp-shell","homepage":null,"size":3524,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":3,"watchers":3,"default_branch":"develop"}},"base":{"label":"particl:develop","ref":"develop","sha":"b2eed7c6d6dcf7692ccbc798f9735a77d77222e8","user":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"repo":{"id":109120213,"name":"dapp-shell","full_name":"particl/dapp-shell","owner":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/particl/dapp-shell","description":"DApp Shell","fork":false,"url":"https://api.github.com/repos/particl/dapp-shell","forks_url":"https://api.github.com/repos/particl/dapp-shell/forks","keys_url":"https://api.github.com/repos/particl/dapp-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particl/dapp-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particl/dapp-shell/teams","hooks_url":"https://api.github.com/repos/particl/dapp-shell/hooks","issue_events_url":"https://api.github.com/repos/particl/dapp-shell/issues/events{/number}","events_url":"https://api.github.com/repos/particl/dapp-shell/events","assignees_url":"https://api.github.com/repos/particl/dapp-shell/assignees{/user}","branches_url":"https://api.github.com/repos/particl/dapp-shell/branches{/branch}","tags_url":"https://api.github.com/repos/particl/dapp-shell/tags","blobs_url":"https://api.github.com/repos/particl/dapp-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particl/dapp-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particl/dapp-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/particl/dapp-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/particl/dapp-shell/languages","stargazers_url":"https://api.github.com/repos/particl/dapp-shell/stargazers","contributors_url":"https://api.github.com/repos/particl/dapp-shell/contributors","subscribers_url":"https://api.github.com/repos/particl/dapp-shell/subscribers","subscription_url":"https://api.github.com/repos/particl/dapp-shell/subscription","commits_url":"https://api.github.com/repos/particl/dapp-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/particl/dapp-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/particl/dapp-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/particl/dapp-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/particl/dapp-shell/contents/{+path}","compare_url":"https://api.github.com/repos/particl/dapp-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particl/dapp-shell/merges","archive_url":"https://api.github.com/repos/particl/dapp-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particl/dapp-shell/downloads","issues_url":"https://api.github.com/repos/particl/dapp-shell/issues{/number}","pulls_url":"https://api.github.com/repos/particl/dapp-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/particl/dapp-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/particl/dapp-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particl/dapp-shell/labels{/name}","releases_url":"https://api.github.com/repos/particl/dapp-shell/releases{/id}","deployments_url":"https://api.github.com/repos/particl/dapp-shell/deployments","created_at":"2017-11-01T10:54:18Z","updated_at":"2018-01-24T20:45:39Z","pushed_at":"2018-02-13T11:53:45Z","git_url":"git://github.com/particl/dapp-shell.git","ssh_url":"git@github.com:particl/dapp-shell.git","clone_url":"https://github.com/particl/dapp-shell.git","svn_url":"https://github.com/particl/dapp-shell","homepage":null,"size":3524,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":3,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/151"},"html":{"href":"https://github.com/particl/dapp-shell/pull/151"},"issue":{"href":"https://api.github.com/repos/particl/dapp-shell/issues/151"},"comments":{"href":"https://api.github.com/repos/particl/dapp-shell/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/particl/dapp-shell/statuses/30b5b49b3321180f6f523a283c171e646cb2048e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cis-navjot-g"}}