{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10","id":210917685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTE3Njg1","html_url":"https://github.com/maxpumperla/ScalphaGoZero/pull/10","diff_url":"https://github.com/maxpumperla/ScalphaGoZero/pull/10.diff","patch_url":"https://github.com/maxpumperla/ScalphaGoZero/pull/10.patch","issue_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/10","number":10,"state":"closed","locked":false,"title":"Use iterative process instead of recursion for the sake of simplicity","user":{"login":"sderosiaux","id":3936459,"node_id":"MDQ6VXNlcjM5MzY0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3936459?v=4","gravatar_id":"","url":"https://api.github.com/users/sderosiaux","html_url":"https://github.com/sderosiaux","followers_url":"https://api.github.com/users/sderosiaux/followers","following_url":"https://api.github.com/users/sderosiaux/following{/other_user}","gists_url":"https://api.github.com/users/sderosiaux/gists{/gist_id}","starred_url":"https://api.github.com/users/sderosiaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderosiaux/subscriptions","organizations_url":"https://api.github.com/users/sderosiaux/orgs","repos_url":"https://api.github.com/users/sderosiaux/repos","events_url":"https://api.github.com/users/sderosiaux/events{/privacy}","received_events_url":"https://api.github.com/users/sderosiaux/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\n`collectRegion` was simplified and do not use recursion but a classic iterative algorithm. It's more concise and clear to understand what's going on. I suggest you take a look at it to see if it does what it's supposed to do.\r\n\r\nYou can disregard this PR if you prefer the recursive version, no worries.\r\n\r\n## How was this patch tested?\r\n\r\n`sbt test` runs without error.","created_at":"2018-08-25T19:29:31Z","updated_at":"2018-09-10T07:51:34Z","closed_at":"2018-09-10T07:51:34Z","merged_at":"2018-09-10T07:51:34Z","merge_commit_sha":"c973d3a8fdc29b68a064d6f11e47c6900dbedf00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10/commits","review_comments_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10/comments","review_comment_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/10/comments","statuses_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/statuses/4c7e5c4c12573a25fcb631f20d8798ca26ed4eaf","head":{"label":"sderosiaux:simplify-collect-region","ref":"simplify-collect-region","sha":"4c7e5c4c12573a25fcb631f20d8798ca26ed4eaf","user":{"login":"sderosiaux","id":3936459,"node_id":"MDQ6VXNlcjM5MzY0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3936459?v=4","gravatar_id":"","url":"https://api.github.com/users/sderosiaux","html_url":"https://github.com/sderosiaux","followers_url":"https://api.github.com/users/sderosiaux/followers","following_url":"https://api.github.com/users/sderosiaux/following{/other_user}","gists_url":"https://api.github.com/users/sderosiaux/gists{/gist_id}","starred_url":"https://api.github.com/users/sderosiaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderosiaux/subscriptions","organizations_url":"https://api.github.com/users/sderosiaux/orgs","repos_url":"https://api.github.com/users/sderosiaux/repos","events_url":"https://api.github.com/users/sderosiaux/events{/privacy}","received_events_url":"https://api.github.com/users/sderosiaux/received_events","type":"User","site_admin":false},"repo":{"id":146076516,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwNzY1MTY=","name":"ScalphaGoZero","full_name":"sderosiaux/ScalphaGoZero","owner":{"login":"sderosiaux","id":3936459,"node_id":"MDQ6VXNlcjM5MzY0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3936459?v=4","gravatar_id":"","url":"https://api.github.com/users/sderosiaux","html_url":"https://github.com/sderosiaux","followers_url":"https://api.github.com/users/sderosiaux/followers","following_url":"https://api.github.com/users/sderosiaux/following{/other_user}","gists_url":"https://api.github.com/users/sderosiaux/gists{/gist_id}","starred_url":"https://api.github.com/users/sderosiaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderosiaux/subscriptions","organizations_url":"https://api.github.com/users/sderosiaux/orgs","repos_url":"https://api.github.com/users/sderosiaux/repos","events_url":"https://api.github.com/users/sderosiaux/events{/privacy}","received_events_url":"https://api.github.com/users/sderosiaux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sderosiaux/ScalphaGoZero","description":"An independent implementation of DeepMind's AlphaGoZero in Scala, using Deeplearning4J (DL4J)","fork":true,"url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero","forks_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/forks","keys_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/teams","hooks_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/hooks","issue_events_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/issues/events{/number}","events_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/events","assignees_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/assignees{/user}","branches_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/branches{/branch}","tags_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/tags","blobs_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/git/refs{/sha}","trees_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/statuses/{sha}","languages_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/languages","stargazers_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/stargazers","contributors_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/contributors","subscribers_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/subscribers","subscription_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/subscription","commits_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/commits{/sha}","git_commits_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/git/commits{/sha}","comments_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/comments{/number}","issue_comment_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/issues/comments{/number}","contents_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/contents/{+path}","compare_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/merges","archive_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/downloads","issues_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/issues{/number}","pulls_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/pulls{/number}","milestones_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/milestones{/number}","notifications_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/labels{/name}","releases_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/releases{/id}","deployments_url":"https://api.github.com/repos/sderosiaux/ScalphaGoZero/deployments","created_at":"2018-08-25T07:47:37Z","updated_at":"2018-08-25T07:47:39Z","pushed_at":"2018-09-10T07:48:42Z","git_url":"git://github.com/sderosiaux/ScalphaGoZero.git","ssh_url":"git@github.com:sderosiaux/ScalphaGoZero.git","clone_url":"https://github.com/sderosiaux/ScalphaGoZero.git","svn_url":"https://github.com/sderosiaux/ScalphaGoZero","homepage":null,"size":229,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maxpumperla:master","ref":"master","sha":"7239d24bc177fbb4c547e707b4a7b66584c504f5","user":{"login":"maxpumperla","id":3462566,"node_id":"MDQ6VXNlcjM0NjI1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3462566?v=4","gravatar_id":"","url":"https://api.github.com/users/maxpumperla","html_url":"https://github.com/maxpumperla","followers_url":"https://api.github.com/users/maxpumperla/followers","following_url":"https://api.github.com/users/maxpumperla/following{/other_user}","gists_url":"https://api.github.com/users/maxpumperla/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpumperla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpumperla/subscriptions","organizations_url":"https://api.github.com/users/maxpumperla/orgs","repos_url":"https://api.github.com/users/maxpumperla/repos","events_url":"https://api.github.com/users/maxpumperla/events{/privacy}","received_events_url":"https://api.github.com/users/maxpumperla/received_events","type":"User","site_admin":false},"repo":{"id":142998606,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5OTg2MDY=","name":"ScalphaGoZero","full_name":"maxpumperla/ScalphaGoZero","owner":{"login":"maxpumperla","id":3462566,"node_id":"MDQ6VXNlcjM0NjI1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3462566?v=4","gravatar_id":"","url":"https://api.github.com/users/maxpumperla","html_url":"https://github.com/maxpumperla","followers_url":"https://api.github.com/users/maxpumperla/followers","following_url":"https://api.github.com/users/maxpumperla/following{/other_user}","gists_url":"https://api.github.com/users/maxpumperla/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpumperla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpumperla/subscriptions","organizations_url":"https://api.github.com/users/maxpumperla/orgs","repos_url":"https://api.github.com/users/maxpumperla/repos","events_url":"https://api.github.com/users/maxpumperla/events{/privacy}","received_events_url":"https://api.github.com/users/maxpumperla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxpumperla/ScalphaGoZero","description":"An independent implementation of DeepMind's AlphaGoZero in Scala, using Deeplearning4J (DL4J)","fork":false,"url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero","forks_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/forks","keys_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/teams","hooks_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/hooks","issue_events_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/events{/number}","events_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/events","assignees_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/assignees{/user}","branches_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/branches{/branch}","tags_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/tags","blobs_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/statuses/{sha}","languages_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/languages","stargazers_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/stargazers","contributors_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/contributors","subscribers_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/subscribers","subscription_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/subscription","commits_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/contents/{+path}","compare_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/merges","archive_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/downloads","issues_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues{/number}","pulls_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls{/number}","milestones_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/milestones{/number}","notifications_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/labels{/name}","releases_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/releases{/id}","deployments_url":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/deployments","created_at":"2018-07-31T10:22:09Z","updated_at":"2018-09-10T07:47:56Z","pushed_at":"2018-09-10T07:51:34Z","git_url":"git://github.com/maxpumperla/ScalphaGoZero.git","ssh_url":"git@github.com:maxpumperla/ScalphaGoZero.git","clone_url":"https://github.com/maxpumperla/ScalphaGoZero.git","svn_url":"https://github.com/maxpumperla/ScalphaGoZero","homepage":null,"size":180,"stargazers_count":94,"watchers_count":94,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":0,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10"},"html":{"href":"https://github.com/maxpumperla/ScalphaGoZero/pull/10"},"issue":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/10"},"comments":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/maxpumperla/ScalphaGoZero/statuses/4c7e5c4c12573a25fcb631f20d8798ca26ed4eaf"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"maxpumperla","id":3462566,"node_id":"MDQ6VXNlcjM0NjI1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/3462566?v=4","gravatar_id":"","url":"https://api.github.com/users/maxpumperla","html_url":"https://github.com/maxpumperla","followers_url":"https://api.github.com/users/maxpumperla/followers","following_url":"https://api.github.com/users/maxpumperla/following{/other_user}","gists_url":"https://api.github.com/users/maxpumperla/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpumperla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpumperla/subscriptions","organizations_url":"https://api.github.com/users/maxpumperla/orgs","repos_url":"https://api.github.com/users/maxpumperla/repos","events_url":"https://api.github.com/users/maxpumperla/events{/privacy}","received_events_url":"https://api.github.com/users/maxpumperla/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":27,"changed_files":1}}
{"actor":{"display_login":"maxpumperla"}}