{"action":"closed","number":1506,"pull_request":{"url":"https://api.github.com/repos/kamailio/kamailio/pulls/1506","id":183704631,"html_url":"https://github.com/kamailio/kamailio/pull/1506","diff_url":"https://github.com/kamailio/kamailio/pull/1506.diff","patch_url":"https://github.com/kamailio/kamailio/pull/1506.patch","issue_url":"https://api.github.com/repos/kamailio/kamailio/issues/1506","number":1506,"state":"closed","locked":false,"title":"textops: properly initialize new tr_param_t object","user":{"login":"lyokha","id":1219667,"avatar_url":"https://avatars1.githubusercontent.com/u/1219667?v=4","gravatar_id":"","url":"https://api.github.com/users/lyokha","html_url":"https://github.com/lyokha","followers_url":"https://api.github.com/users/lyokha/followers","following_url":"https://api.github.com/users/lyokha/following{/other_user}","gists_url":"https://api.github.com/users/lyokha/gists{/gist_id}","starred_url":"https://api.github.com/users/lyokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyokha/subscriptions","organizations_url":"https://api.github.com/users/lyokha/orgs","repos_url":"https://api.github.com/users/lyokha/repos","events_url":"https://api.github.com/users/lyokha/events{/privacy}","received_events_url":"https://api.github.com/users/lyokha/received_events","type":"User","site_admin":false},"body":"Just `memset()` this to `0`.\r\n\r\nWithout this kamailio segfaults when running `fparam_free_restore()` on a variable that contains transformations immediately after creation, because field `next` of the transformation contains garbage.\r\n\r\nIn my case this was variable which contained `re.subst` transformation. And below is the top of the backtrace.\r\n\r\n```\r\n#0  0x00000000005cba17 in tr_param_free (tp=0x292873257325203a) at core/pvapi.c:1804\r\n#1  0x00000000005cb677 in tr_destroy (t=0x7f6387ed0c40) at core/pvapi.c:1742\r\n#2  0x00000000005cb9c1 in tr_free (t=0x0) at core/pvapi.c:1786\r\n#3  0x00000000005ca194 in pv_spec_destroy (spec=0x7f6387ed0b80) at core/pvapi.c:1570\r\n#4  0x00000000005ca1b7 in pv_spec_free (spec=0x7f6387ed0b80) at core/pvapi.c:1578\r\n#5  0x0000000000541820 in fparam_free_contents (fp=0x7f6387ed0ae0) at core/sr_module.c:1334\r\n#6  0x0000000000541898 in fparam_free_restore (param=0x7f6387ed1168) at core/sr_module.c:1364\r\n```\r\n\r\n<!-- Kamailio Pull Request Template -->\r\n\r\n<!--\r\nIMPORTANT:\r\n  - for detailed contributing guidelines, read:\r\n    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md\r\n  - pull requests must be done to master branch, unless they are backports\r\n    of fixes from master branch to a stable branch\r\n  - backports to stable branches must be done with 'git cherry-pick -x ...'\r\n  - code is contributed under BSD for core and main components (tm, sl, auth, tls)\r\n  - code is contributed GPLv2 or a compatible license for the other components\r\n  - GPL code is contributed with OpenSSL licensing exception\r\n-->\r\n\r\n#### Pre-Submission Checklist\r\n<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->\r\n<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->\r\n<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->\r\n- [ ] Commit message has the format required by CONTRIBUTING guide\r\n- [ ] Commits are split per component (core, individual modules, libs, utils, ...)\r\n- [ ] Each component has a single commit (if not, squash them into one commit)\r\n- [ ] No commits to README files for modules (changes must be done to docbook files\r\nin `doc/` subfolder, the README file is autogenerated)\r\n\r\n#### Type Of Change\r\n- [x] Small bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds new functionality)\r\n- [ ] Breaking change (fix or feature that would change existing functionality)\r\n\r\n#### Checklist:\r\n<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->\r\n- [ ] PR should be backported to stable branches\r\n- [ ] Tested changes locally\r\n- [ ] Related to issue #XXXX (replace XXXX with an open issue number)\r\n\r\n#### Description\r\n<!-- Describe your changes in detail -->\r\n","created_at":"2018-04-24T11:29:09Z","updated_at":"2018-04-24T12:50:22Z","closed_at":"2018-04-24T12:50:22Z","merged_at":null,"merge_commit_sha":"8ca206b0068d7ddf8e852dbf2cefc93a7006c78f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kamailio/kamailio/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/kamailio/kamailio/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/kamailio/kamailio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kamailio/kamailio/issues/1506/comments","statuses_url":"https://api.github.com/repos/kamailio/kamailio/statuses/ff83b3bbe250d662165d04510048d53aaee93b4d","head":{"label":"lyokha:master","ref":"master","sha":"ff83b3bbe250d662165d04510048d53aaee93b4d","user":{"login":"lyokha","id":1219667,"avatar_url":"https://avatars1.githubusercontent.com/u/1219667?v=4","gravatar_id":"","url":"https://api.github.com/users/lyokha","html_url":"https://github.com/lyokha","followers_url":"https://api.github.com/users/lyokha/followers","following_url":"https://api.github.com/users/lyokha/following{/other_user}","gists_url":"https://api.github.com/users/lyokha/gists{/gist_id}","starred_url":"https://api.github.com/users/lyokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyokha/subscriptions","organizations_url":"https://api.github.com/users/lyokha/orgs","repos_url":"https://api.github.com/users/lyokha/repos","events_url":"https://api.github.com/users/lyokha/events{/privacy}","received_events_url":"https://api.github.com/users/lyokha/received_events","type":"User","site_admin":false},"repo":{"id":130840547,"name":"kamailio","full_name":"lyokha/kamailio","owner":{"login":"lyokha","id":1219667,"avatar_url":"https://avatars1.githubusercontent.com/u/1219667?v=4","gravatar_id":"","url":"https://api.github.com/users/lyokha","html_url":"https://github.com/lyokha","followers_url":"https://api.github.com/users/lyokha/followers","following_url":"https://api.github.com/users/lyokha/following{/other_user}","gists_url":"https://api.github.com/users/lyokha/gists{/gist_id}","starred_url":"https://api.github.com/users/lyokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyokha/subscriptions","organizations_url":"https://api.github.com/users/lyokha/orgs","repos_url":"https://api.github.com/users/lyokha/repos","events_url":"https://api.github.com/users/lyokha/events{/privacy}","received_events_url":"https://api.github.com/users/lyokha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyokha/kamailio","description":"Kamailio - The Open Source SIP Server -","fork":true,"url":"https://api.github.com/repos/lyokha/kamailio","forks_url":"https://api.github.com/repos/lyokha/kamailio/forks","keys_url":"https://api.github.com/repos/lyokha/kamailio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyokha/kamailio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyokha/kamailio/teams","hooks_url":"https://api.github.com/repos/lyokha/kamailio/hooks","issue_events_url":"https://api.github.com/repos/lyokha/kamailio/issues/events{/number}","events_url":"https://api.github.com/repos/lyokha/kamailio/events","assignees_url":"https://api.github.com/repos/lyokha/kamailio/assignees{/user}","branches_url":"https://api.github.com/repos/lyokha/kamailio/branches{/branch}","tags_url":"https://api.github.com/repos/lyokha/kamailio/tags","blobs_url":"https://api.github.com/repos/lyokha/kamailio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyokha/kamailio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyokha/kamailio/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyokha/kamailio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyokha/kamailio/statuses/{sha}","languages_url":"https://api.github.com/repos/lyokha/kamailio/languages","stargazers_url":"https://api.github.com/repos/lyokha/kamailio/stargazers","contributors_url":"https://api.github.com/repos/lyokha/kamailio/contributors","subscribers_url":"https://api.github.com/repos/lyokha/kamailio/subscribers","subscription_url":"https://api.github.com/repos/lyokha/kamailio/subscription","commits_url":"https://api.github.com/repos/lyokha/kamailio/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyokha/kamailio/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyokha/kamailio/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyokha/kamailio/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyokha/kamailio/contents/{+path}","compare_url":"https://api.github.com/repos/lyokha/kamailio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyokha/kamailio/merges","archive_url":"https://api.github.com/repos/lyokha/kamailio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyokha/kamailio/downloads","issues_url":"https://api.github.com/repos/lyokha/kamailio/issues{/number}","pulls_url":"https://api.github.com/repos/lyokha/kamailio/pulls{/number}","milestones_url":"https://api.github.com/repos/lyokha/kamailio/milestones{/number}","notifications_url":"https://api.github.com/repos/lyokha/kamailio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyokha/kamailio/labels{/name}","releases_url":"https://api.github.com/repos/lyokha/kamailio/releases{/id}","deployments_url":"https://api.github.com/repos/lyokha/kamailio/deployments","created_at":"2018-04-24T11:00:11Z","updated_at":"2018-04-24T11:11:06Z","pushed_at":"2018-04-24T11:11:04Z","git_url":"git://github.com/lyokha/kamailio.git","ssh_url":"git@github.com:lyokha/kamailio.git","clone_url":"https://github.com/lyokha/kamailio.git","svn_url":"https://github.com/lyokha/kamailio","homepage":"https://www.kamailio.org","size":68486,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kamailio:master","ref":"master","sha":"352440d299f1b9f431cc05397f4ea6a7b5967c8a","user":{"login":"kamailio","id":5348744,"avatar_url":"https://avatars3.githubusercontent.com/u/5348744?v=4","gravatar_id":"","url":"https://api.github.com/users/kamailio","html_url":"https://github.com/kamailio","followers_url":"https://api.github.com/users/kamailio/followers","following_url":"https://api.github.com/users/kamailio/following{/other_user}","gists_url":"https://api.github.com/users/kamailio/gists{/gist_id}","starred_url":"https://api.github.com/users/kamailio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamailio/subscriptions","organizations_url":"https://api.github.com/users/kamailio/orgs","repos_url":"https://api.github.com/users/kamailio/repos","events_url":"https://api.github.com/users/kamailio/events{/privacy}","received_events_url":"https://api.github.com/users/kamailio/received_events","type":"Organization","site_admin":false},"repo":{"id":15101579,"name":"kamailio","full_name":"kamailio/kamailio","owner":{"login":"kamailio","id":5348744,"avatar_url":"https://avatars3.githubusercontent.com/u/5348744?v=4","gravatar_id":"","url":"https://api.github.com/users/kamailio","html_url":"https://github.com/kamailio","followers_url":"https://api.github.com/users/kamailio/followers","following_url":"https://api.github.com/users/kamailio/following{/other_user}","gists_url":"https://api.github.com/users/kamailio/gists{/gist_id}","starred_url":"https://api.github.com/users/kamailio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamailio/subscriptions","organizations_url":"https://api.github.com/users/kamailio/orgs","repos_url":"https://api.github.com/users/kamailio/repos","events_url":"https://api.github.com/users/kamailio/events{/privacy}","received_events_url":"https://api.github.com/users/kamailio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kamailio/kamailio","description":"Kamailio - The Open Source SIP Server -","fork":false,"url":"https://api.github.com/repos/kamailio/kamailio","forks_url":"https://api.github.com/repos/kamailio/kamailio/forks","keys_url":"https://api.github.com/repos/kamailio/kamailio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamailio/kamailio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamailio/kamailio/teams","hooks_url":"https://api.github.com/repos/kamailio/kamailio/hooks","issue_events_url":"https://api.github.com/repos/kamailio/kamailio/issues/events{/number}","events_url":"https://api.github.com/repos/kamailio/kamailio/events","assignees_url":"https://api.github.com/repos/kamailio/kamailio/assignees{/user}","branches_url":"https://api.github.com/repos/kamailio/kamailio/branches{/branch}","tags_url":"https://api.github.com/repos/kamailio/kamailio/tags","blobs_url":"https://api.github.com/repos/kamailio/kamailio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamailio/kamailio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamailio/kamailio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamailio/kamailio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamailio/kamailio/statuses/{sha}","languages_url":"https://api.github.com/repos/kamailio/kamailio/languages","stargazers_url":"https://api.github.com/repos/kamailio/kamailio/stargazers","contributors_url":"https://api.github.com/repos/kamailio/kamailio/contributors","subscribers_url":"https://api.github.com/repos/kamailio/kamailio/subscribers","subscription_url":"https://api.github.com/repos/kamailio/kamailio/subscription","commits_url":"https://api.github.com/repos/kamailio/kamailio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamailio/kamailio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamailio/kamailio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamailio/kamailio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamailio/kamailio/contents/{+path}","compare_url":"https://api.github.com/repos/kamailio/kamailio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamailio/kamailio/merges","archive_url":"https://api.github.com/repos/kamailio/kamailio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamailio/kamailio/downloads","issues_url":"https://api.github.com/repos/kamailio/kamailio/issues{/number}","pulls_url":"https://api.github.com/repos/kamailio/kamailio/pulls{/number}","milestones_url":"https://api.github.com/repos/kamailio/kamailio/milestones{/number}","notifications_url":"https://api.github.com/repos/kamailio/kamailio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamailio/kamailio/labels{/name}","releases_url":"https://api.github.com/repos/kamailio/kamailio/releases{/id}","deployments_url":"https://api.github.com/repos/kamailio/kamailio/deployments","created_at":"2013-12-11T08:09:40Z","updated_at":"2018-04-24T12:48:01Z","pushed_at":"2018-04-24T12:47:58Z","git_url":"git://github.com/kamailio/kamailio.git","ssh_url":"git@github.com:kamailio/kamailio.git","clone_url":"https://github.com/kamailio/kamailio.git","svn_url":"https://github.com/kamailio/kamailio","homepage":"https://www.kamailio.org","size":68494,"stargazers_count":654,"watchers_count":654,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":365,"open_issues":52,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1506"},"html":{"href":"https://github.com/kamailio/kamailio/pull/1506"},"issue":{"href":"https://api.github.com/repos/kamailio/kamailio/issues/1506"},"comments":{"href":"https://api.github.com/repos/kamailio/kamailio/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kamailio/kamailio/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/kamailio/kamailio/statuses/ff83b3bbe250d662165d04510048d53aaee93b4d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"miconda"}}