{"action":"closed","number":116,"pull_request":{"url":"https://api.github.com/repos/node-cron/node-cron/pulls/116","id":221532512,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTMyNTEy","html_url":"https://github.com/node-cron/node-cron/pull/116","diff_url":"https://github.com/node-cron/node-cron/pull/116.diff","patch_url":"https://github.com/node-cron/node-cron/pull/116.patch","issue_url":"https://api.github.com/repos/node-cron/node-cron/issues/116","number":116,"state":"closed","locked":false,"title":"Fix double execution in same second","user":{"login":"merencia","id":1686635,"node_id":"MDQ6VXNlcjE2ODY2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1686635?v=4","gravatar_id":"","url":"https://api.github.com/users/merencia","html_url":"https://github.com/merencia","followers_url":"https://api.github.com/users/merencia/followers","following_url":"https://api.github.com/users/merencia/following{/other_user}","gists_url":"https://api.github.com/users/merencia/gists{/gist_id}","starred_url":"https://api.github.com/users/merencia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merencia/subscriptions","organizations_url":"https://api.github.com/users/merencia/orgs","repos_url":"https://api.github.com/users/merencia/repos","events_url":"https://api.github.com/users/merencia/events{/privacy}","received_events_url":"https://api.github.com/users/merencia/received_events","type":"User","site_admin":false},"body":"The calc to find the next interval timeout is missing 1 milisecond.\r\nThe current calc is: `1000 - new Date().getMiliseconds()` but getMilliseconds may return a value between 0 to 999.\r\n\r\nhttps://www.w3schools.com/jsref/jsref_getmilliseconds.asp\r\n> The getMilliseconds() method returns the milliseconds (from 0 to 999) of the specified date and time.\r\n\r\nWhen `setInterval` is called on node-cron, the maximum delay may be 1000, as the first valid millisecond is `0` when it is used to calculate the next tick, one milisecond must be added, because the elapsed time is used rather than the current milisecond.","created_at":"2018-10-09T18:02:19Z","updated_at":"2018-10-09T18:35:48Z","closed_at":"2018-10-09T18:35:48Z","merged_at":"2018-10-09T18:35:48Z","merge_commit_sha":"db47539e1f45cf20ca815765275127e286f46f8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/node-cron/node-cron/pulls/116/commits","review_comments_url":"https://api.github.com/repos/node-cron/node-cron/pulls/116/comments","review_comment_url":"https://api.github.com/repos/node-cron/node-cron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/node-cron/node-cron/issues/116/comments","statuses_url":"https://api.github.com/repos/node-cron/node-cron/statuses/610e5889b63f3acc564dc31dece791d928e39168","head":{"label":"node-cron:fix-double-execution","ref":"fix-double-execution","sha":"610e5889b63f3acc564dc31dece791d928e39168","user":{"login":"node-cron","id":43762977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzYyOTc3","avatar_url":"https://avatars3.githubusercontent.com/u/43762977?v=4","gravatar_id":"","url":"https://api.github.com/users/node-cron","html_url":"https://github.com/node-cron","followers_url":"https://api.github.com/users/node-cron/followers","following_url":"https://api.github.com/users/node-cron/following{/other_user}","gists_url":"https://api.github.com/users/node-cron/gists{/gist_id}","starred_url":"https://api.github.com/users/node-cron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-cron/subscriptions","organizations_url":"https://api.github.com/users/node-cron/orgs","repos_url":"https://api.github.com/users/node-cron/repos","events_url":"https://api.github.com/users/node-cron/events{/privacy}","received_events_url":"https://api.github.com/users/node-cron/received_events","type":"Organization","site_admin":false},"repo":{"id":51018902,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxODkwMg==","name":"node-cron","full_name":"node-cron/node-cron","private":false,"owner":{"login":"node-cron","id":43762977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzYyOTc3","avatar_url":"https://avatars3.githubusercontent.com/u/43762977?v=4","gravatar_id":"","url":"https://api.github.com/users/node-cron","html_url":"https://github.com/node-cron","followers_url":"https://api.github.com/users/node-cron/followers","following_url":"https://api.github.com/users/node-cron/following{/other_user}","gists_url":"https://api.github.com/users/node-cron/gists{/gist_id}","starred_url":"https://api.github.com/users/node-cron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-cron/subscriptions","organizations_url":"https://api.github.com/users/node-cron/orgs","repos_url":"https://api.github.com/users/node-cron/repos","events_url":"https://api.github.com/users/node-cron/events{/privacy}","received_events_url":"https://api.github.com/users/node-cron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/node-cron/node-cron","description":"A simple cron-like job scheduler for Node.js","fork":false,"url":"https://api.github.com/repos/node-cron/node-cron","forks_url":"https://api.github.com/repos/node-cron/node-cron/forks","keys_url":"https://api.github.com/repos/node-cron/node-cron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-cron/node-cron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-cron/node-cron/teams","hooks_url":"https://api.github.com/repos/node-cron/node-cron/hooks","issue_events_url":"https://api.github.com/repos/node-cron/node-cron/issues/events{/number}","events_url":"https://api.github.com/repos/node-cron/node-cron/events","assignees_url":"https://api.github.com/repos/node-cron/node-cron/assignees{/user}","branches_url":"https://api.github.com/repos/node-cron/node-cron/branches{/branch}","tags_url":"https://api.github.com/repos/node-cron/node-cron/tags","blobs_url":"https://api.github.com/repos/node-cron/node-cron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-cron/node-cron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-cron/node-cron/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-cron/node-cron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-cron/node-cron/statuses/{sha}","languages_url":"https://api.github.com/repos/node-cron/node-cron/languages","stargazers_url":"https://api.github.com/repos/node-cron/node-cron/stargazers","contributors_url":"https://api.github.com/repos/node-cron/node-cron/contributors","subscribers_url":"https://api.github.com/repos/node-cron/node-cron/subscribers","subscription_url":"https://api.github.com/repos/node-cron/node-cron/subscription","commits_url":"https://api.github.com/repos/node-cron/node-cron/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-cron/node-cron/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-cron/node-cron/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-cron/node-cron/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-cron/node-cron/contents/{+path}","compare_url":"https://api.github.com/repos/node-cron/node-cron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-cron/node-cron/merges","archive_url":"https://api.github.com/repos/node-cron/node-cron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-cron/node-cron/downloads","issues_url":"https://api.github.com/repos/node-cron/node-cron/issues{/number}","pulls_url":"https://api.github.com/repos/node-cron/node-cron/pulls{/number}","milestones_url":"https://api.github.com/repos/node-cron/node-cron/milestones{/number}","notifications_url":"https://api.github.com/repos/node-cron/node-cron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-cron/node-cron/labels{/name}","releases_url":"https://api.github.com/repos/node-cron/node-cron/releases{/id}","deployments_url":"https://api.github.com/repos/node-cron/node-cron/deployments","created_at":"2016-02-03T17:55:47Z","updated_at":"2018-10-09T17:09:00Z","pushed_at":"2018-10-09T18:35:48Z","git_url":"git://github.com/node-cron/node-cron.git","ssh_url":"git@github.com:node-cron/node-cron.git","clone_url":"https://github.com/node-cron/node-cron.git","svn_url":"https://github.com/node-cron/node-cron","homepage":"","size":170,"stargazers_count":636,"watchers_count":636,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":62,"open_issues":8,"watchers":636,"default_branch":"master"}},"base":{"label":"node-cron:master","ref":"master","sha":"0f52f9ccb39e749e4b348285f290372a49aec979","user":{"login":"node-cron","id":43762977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzYyOTc3","avatar_url":"https://avatars3.githubusercontent.com/u/43762977?v=4","gravatar_id":"","url":"https://api.github.com/users/node-cron","html_url":"https://github.com/node-cron","followers_url":"https://api.github.com/users/node-cron/followers","following_url":"https://api.github.com/users/node-cron/following{/other_user}","gists_url":"https://api.github.com/users/node-cron/gists{/gist_id}","starred_url":"https://api.github.com/users/node-cron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-cron/subscriptions","organizations_url":"https://api.github.com/users/node-cron/orgs","repos_url":"https://api.github.com/users/node-cron/repos","events_url":"https://api.github.com/users/node-cron/events{/privacy}","received_events_url":"https://api.github.com/users/node-cron/received_events","type":"Organization","site_admin":false},"repo":{"id":51018902,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxODkwMg==","name":"node-cron","full_name":"node-cron/node-cron","private":false,"owner":{"login":"node-cron","id":43762977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzYyOTc3","avatar_url":"https://avatars3.githubusercontent.com/u/43762977?v=4","gravatar_id":"","url":"https://api.github.com/users/node-cron","html_url":"https://github.com/node-cron","followers_url":"https://api.github.com/users/node-cron/followers","following_url":"https://api.github.com/users/node-cron/following{/other_user}","gists_url":"https://api.github.com/users/node-cron/gists{/gist_id}","starred_url":"https://api.github.com/users/node-cron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-cron/subscriptions","organizations_url":"https://api.github.com/users/node-cron/orgs","repos_url":"https://api.github.com/users/node-cron/repos","events_url":"https://api.github.com/users/node-cron/events{/privacy}","received_events_url":"https://api.github.com/users/node-cron/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/node-cron/node-cron","description":"A simple cron-like job scheduler for Node.js","fork":false,"url":"https://api.github.com/repos/node-cron/node-cron","forks_url":"https://api.github.com/repos/node-cron/node-cron/forks","keys_url":"https://api.github.com/repos/node-cron/node-cron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-cron/node-cron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-cron/node-cron/teams","hooks_url":"https://api.github.com/repos/node-cron/node-cron/hooks","issue_events_url":"https://api.github.com/repos/node-cron/node-cron/issues/events{/number}","events_url":"https://api.github.com/repos/node-cron/node-cron/events","assignees_url":"https://api.github.com/repos/node-cron/node-cron/assignees{/user}","branches_url":"https://api.github.com/repos/node-cron/node-cron/branches{/branch}","tags_url":"https://api.github.com/repos/node-cron/node-cron/tags","blobs_url":"https://api.github.com/repos/node-cron/node-cron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-cron/node-cron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-cron/node-cron/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-cron/node-cron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-cron/node-cron/statuses/{sha}","languages_url":"https://api.github.com/repos/node-cron/node-cron/languages","stargazers_url":"https://api.github.com/repos/node-cron/node-cron/stargazers","contributors_url":"https://api.github.com/repos/node-cron/node-cron/contributors","subscribers_url":"https://api.github.com/repos/node-cron/node-cron/subscribers","subscription_url":"https://api.github.com/repos/node-cron/node-cron/subscription","commits_url":"https://api.github.com/repos/node-cron/node-cron/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-cron/node-cron/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-cron/node-cron/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-cron/node-cron/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-cron/node-cron/contents/{+path}","compare_url":"https://api.github.com/repos/node-cron/node-cron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-cron/node-cron/merges","archive_url":"https://api.github.com/repos/node-cron/node-cron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-cron/node-cron/downloads","issues_url":"https://api.github.com/repos/node-cron/node-cron/issues{/number}","pulls_url":"https://api.github.com/repos/node-cron/node-cron/pulls{/number}","milestones_url":"https://api.github.com/repos/node-cron/node-cron/milestones{/number}","notifications_url":"https://api.github.com/repos/node-cron/node-cron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-cron/node-cron/labels{/name}","releases_url":"https://api.github.com/repos/node-cron/node-cron/releases{/id}","deployments_url":"https://api.github.com/repos/node-cron/node-cron/deployments","created_at":"2016-02-03T17:55:47Z","updated_at":"2018-10-09T17:09:00Z","pushed_at":"2018-10-09T18:35:48Z","git_url":"git://github.com/node-cron/node-cron.git","ssh_url":"git@github.com:node-cron/node-cron.git","clone_url":"https://github.com/node-cron/node-cron.git","svn_url":"https://github.com/node-cron/node-cron","homepage":"","size":170,"stargazers_count":636,"watchers_count":636,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":62,"open_issues":8,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-cron/node-cron/pulls/116"},"html":{"href":"https://github.com/node-cron/node-cron/pull/116"},"issue":{"href":"https://api.github.com/repos/node-cron/node-cron/issues/116"},"comments":{"href":"https://api.github.com/repos/node-cron/node-cron/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/node-cron/node-cron/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/node-cron/node-cron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/node-cron/node-cron/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/node-cron/node-cron/statuses/610e5889b63f3acc564dc31dece791d928e39168"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"merencia","id":1686635,"node_id":"MDQ6VXNlcjE2ODY2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1686635?v=4","gravatar_id":"","url":"https://api.github.com/users/merencia","html_url":"https://github.com/merencia","followers_url":"https://api.github.com/users/merencia/followers","following_url":"https://api.github.com/users/merencia/following{/other_user}","gists_url":"https://api.github.com/users/merencia/gists{/gist_id}","starred_url":"https://api.github.com/users/merencia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merencia/subscriptions","organizations_url":"https://api.github.com/users/merencia/orgs","repos_url":"https://api.github.com/users/merencia/repos","events_url":"https://api.github.com/users/merencia/events{/privacy}","received_events_url":"https://api.github.com/users/merencia/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":19,"deletions":20,"changed_files":11}}
{"actor":{"display_login":"merencia"}}