{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/16028","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/16028/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/16028/comments","events_url":"https://api.github.com/repos/electron/electron/issues/16028/events","html_url":"https://github.com/electron/electron/pull/16028","id":390022623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODgxMDE5","number":16028,"title":"fix: fix an original-fs regression introduced in 4.0 betas","user":{"login":"ckerr","id":70381,"node_id":"MDQ6VXNlcjcwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/70381?v=4","gravatar_id":"","url":"https://api.github.com/users/ckerr","html_url":"https://github.com/ckerr","followers_url":"https://api.github.com/users/ckerr/followers","following_url":"https://api.github.com/users/ckerr/following{/other_user}","gists_url":"https://api.github.com/users/ckerr/gists{/gist_id}","starred_url":"https://api.github.com/users/ckerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckerr/subscriptions","organizations_url":"https://api.github.com/users/ckerr/orgs","repos_url":"https://api.github.com/users/ckerr/repos","events_url":"https://api.github.com/users/ckerr/events{/privacy}","received_events_url":"https://api.github.com/users/ckerr/received_events","type":"User","site_admin":true},"labels":[{"id":1086970368,"node_id":"MDU6TGFiZWwxMDg2OTcwMzY4","url":"https://api.github.com/repos/electron/electron/labels/target/4-0-x","name":"target/4-0-x","color":"f22fa2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-12T01:11:41Z","updated_at":"2018-12-12T21:33:13Z","closed_at":"2018-12-12T21:32:54Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/16028","html_url":"https://github.com/electron/electron/pull/16028","diff_url":"https://github.com/electron/electron/pull/16028.diff","patch_url":"https://github.com/electron/electron/pull/16028.patch"},"body":"#### Description of Change\r\n\r\nFixes a 4.0.0-beta.X regression in `original-fs`. Node's `fs` and `internal/fs/streams` have a lazy-loaded circular dependency, so to expose the unmodified Node `fs` functionality, we have to copy both `fs` *and* `internal/fs/streams` and modify the copies to depend on each other instead of on our asarified 'fs' code.\r\n\r\nFixes #15543.\r\n\r\nDiscussion: an earlier draft of this code added a new `original_fs` module into atom/common/node-bindings so that multiple Node code that calls `process.binding('fs')` could also be swapped out with a `process.binding('fs_original')`. This more completely separates the asarified and original versions of `fs`, but it also requires more cloning and inter-dependencies, and is not required for #15543. This PR tries to KISS by replacing only what's clearly needed.\r\n\r\nCC @codebytere \r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n\r\n#### Release Notes\r\n<!-- Used to describe release notes for future release versions. Use `no-notes` to indicate no user-facing changes. -->\r\n\r\nNotes: Fix 4-0-x regression that broke original-fs"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/446752292","html_url":"https://github.com/electron/electron/pull/16028#issuecomment-446752292","issue_url":"https://api.github.com/repos/electron/electron/issues/16028","id":446752292,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Njc1MjI5Mg==","user":{"login":"trop[bot]","id":37223003,"node_id":"MDM6Qm90MzcyMjMwMDM=","avatar_url":"https://avatars1.githubusercontent.com/in/9879?v=4","gravatar_id":"","url":"https://api.github.com/users/trop%5Bbot%5D","html_url":"https://github.com/apps/trop","followers_url":"https://api.github.com/users/trop%5Bbot%5D/followers","following_url":"https://api.github.com/users/trop%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/trop%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/trop%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trop%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/trop%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/trop%5Bbot%5D/repos","events_url":"https://api.github.com/users/trop%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/trop%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-12T21:33:13Z","updated_at":"2018-12-12T21:33:13Z","author_association":"CONTRIBUTOR","body":"I have automatically backported this PR to \"4-0-x\",     please check out #16038"}}
{"actor":{"display_login":"trop"}}