{"action":"created","issue":{"url":"https://api.github.com/repos/substance/texture/issues/1057","repository_url":"https://api.github.com/repos/substance/texture","labels_url":"https://api.github.com/repos/substance/texture/issues/1057/labels{/name}","comments_url":"https://api.github.com/repos/substance/texture/issues/1057/comments","events_url":"https://api.github.com/repos/substance/texture/issues/1057/events","html_url":"https://github.com/substance/texture/pull/1057","id":386781955,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDE4Nzg0","number":1057,"title":"Table footnotes","user":{"login":"oliver----","id":284099,"node_id":"MDQ6VXNlcjI4NDA5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/284099?v=4","gravatar_id":"","url":"https://api.github.com/users/oliver----","html_url":"https://github.com/oliver----","followers_url":"https://api.github.com/users/oliver----/followers","following_url":"https://api.github.com/users/oliver----/following{/other_user}","gists_url":"https://api.github.com/users/oliver----/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver----/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver----/subscriptions","organizations_url":"https://api.github.com/users/oliver----/orgs","repos_url":"https://api.github.com/users/oliver----/repos","events_url":"https://api.github.com/users/oliver----/events{/privacy}","received_events_url":"https://api.github.com/users/oliver----/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-12-03T11:48:34Z","updated_at":"2018-12-07T05:52:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/substance/texture/pulls/1057","html_url":"https://github.com/substance/texture/pull/1057","diff_url":"https://github.com/substance/texture/pull/1057.diff","patch_url":"https://github.com/substance/texture/pull/1057.patch"},"body":"## Why\r\n\r\nImplementation of Feature 'Table Footnotes'. \r\n\r\nRelated:\r\n- #556\r\n\r\n## What\r\n\r\n- [x] Extend kitchen-sink **(O)**\r\n- [x] Extend TextureArticleSchema to allow for `<table-wrap-foot>`\r\n- [x] Extend `TableFigure` to allow for 0-n footnotes (-> children)\r\n- [x] Implement Importer and create footnotes and populate `tableFig.footnotes`\r\n- [x] Implement a label generator for table footnotes **(O)**\r\n- [x] Refactor internal xref collection API for XrefEditDialog **(O)**  \r\n- [x] Display footnotes and footnote references in TableFigure\r\n- [x] Implement dialog for table-footnotes so that it allows only to choose from table footnotes\r\n- [x] InsertFootnoteCrossReferenceCommand for both regular and table footnotes according to detected scope\r\n- [x] Determine xpath for table selections (CustomSelection) \r\n- [x] Implement an InsertFootnoteCommand that creates a footnote in the according scope\r\n- [x] Add InsertFootnoteTool to both views (currently only metadata)\r\n- [x] After creating the first footnote xref, table- footnotes do not update anymore **(O)**\r\n- [x] Fix TableFootnoteManager issues (e.g. no label for xrefs in caption) **(O)**\r\n- [x] Add tests for table-footnote label generator **(O)**\r\n- [x] Order footnotes in order of cross-refs (similar to how references are ordered) **(O)**\r\n- [x] Implement exporter that stores created footnotes into `<table-wrap-foot>` **(O)**\r\n- [x] Add a command and tool to remove a footnote (enabled when cursor inside fn)\r\n- [x] Add tests for table-footnote interaction (create, delete, x-reference)\r\n- [x] Fix table editor in Metadata mode\r\n- [x] Add labels for table figures ('Label:', 'Title:', 'Caption'; 'Footnotes:') and regular figures styled in a same way as we have it in manuscript\r\n"},"comment":{"url":"https://api.github.com/repos/substance/texture/issues/comments/445130550","html_url":"https://github.com/substance/texture/pull/1057#issuecomment-445130550","issue_url":"https://api.github.com/repos/substance/texture/issues/1057","id":445130550,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTEzMDU1MA==","user":{"login":"oliver----","id":284099,"node_id":"MDQ6VXNlcjI4NDA5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/284099?v=4","gravatar_id":"","url":"https://api.github.com/users/oliver----","html_url":"https://github.com/oliver----","followers_url":"https://api.github.com/users/oliver----/followers","following_url":"https://api.github.com/users/oliver----/following{/other_user}","gists_url":"https://api.github.com/users/oliver----/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver----/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver----/subscriptions","organizations_url":"https://api.github.com/users/oliver----/orgs","repos_url":"https://api.github.com/users/oliver----/repos","events_url":"https://api.github.com/users/oliver----/events{/privacy}","received_events_url":"https://api.github.com/users/oliver----/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T05:52:04Z","updated_at":"2018-12-07T05:52:04Z","author_association":"MEMBER","body":"@Integral very nice! Thanks for the tests!"}}
{"actor":{"display_login":"oliver----"}}