{"action":"closed","issue":{"url":"https://api.github.com/repos/Cito/pyramid_ldap3/issues/11","repository_url":"https://api.github.com/repos/Cito/pyramid_ldap3","labels_url":"https://api.github.com/repos/Cito/pyramid_ldap3/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/Cito/pyramid_ldap3/issues/11/comments","events_url":"https://api.github.com/repos/Cito/pyramid_ldap3/issues/11/events","html_url":"https://github.com/Cito/pyramid_ldap3/issues/11","id":376487470,"node_id":"MDU6SXNzdWUzNzY0ODc0NzA=","number":11,"title":"Pyramid 1.10 support","user":{"login":"Epithumia","id":893445,"node_id":"MDQ6VXNlcjg5MzQ0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893445?v=4","gravatar_id":"","url":"https://api.github.com/users/Epithumia","html_url":"https://github.com/Epithumia","followers_url":"https://api.github.com/users/Epithumia/followers","following_url":"https://api.github.com/users/Epithumia/following{/other_user}","gists_url":"https://api.github.com/users/Epithumia/gists{/gist_id}","starred_url":"https://api.github.com/users/Epithumia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Epithumia/subscriptions","organizations_url":"https://api.github.com/users/Epithumia/orgs","repos_url":"https://api.github.com/users/Epithumia/repos","events_url":"https://api.github.com/users/Epithumia/events{/privacy}","received_events_url":"https://api.github.com/users/Epithumia/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-01T17:18:43Z","updated_at":"2018-11-03T19:47:43Z","closed_at":"2018-11-03T19:47:43Z","author_association":"NONE","body":"Pyramid 1.10 was released not too long ago, and one of the deprecations (`pyramid.config.Configurator.set_request_property`, cf. https://github.com/Pylons/pyramid/pull/3368) breaks pyramid_ldap3.\r\n\r\nFortunately, the fix seems to be a simple case of using the non-deprecated method. So, in https://github.com/Cito/pyramid_ldap3/blob/37b3337cea3e26ede8ce2f5bbb6602f08535b305/pyramid_ldap3/__init__.py#L368 replace it with `add_request_method`.\r\n\r\nI suppose something might have to be done with https://github.com/Cito/pyramid_ldap3/blob/37b3337cea3e26ede8ce2f5bbb6602f08535b305/tests/__init__.py#L36 too, not sure."}}
{"actor":{"display_login":"Cito"}}