{"action":"created","comment":{"url":"https://api.github.com/repos/socrata-platform/spandex/pulls/comments/187104683","pull_request_review_id":118817990,"id":187104683,"diff_hunk":"@@ -10,18 +10,26 @@\n         \"autocomplete\": {\n           \"type\": \"custom\",\n           \"tokenizer\": \"word\",\n-          \"filter\": [\"lowercase\", \"autocomplete_edge_ngram\"]\n+          \"filter\": [\"lowercase\", \"ascii_folding\", \"autocomplete_edge_ngram\", \"unique_token\"]","path":"spandex-common/src/main/resources/settings.json","position":5,"original_position":5,"commit_id":"81e5aa06052c49c4aced09392b1cf1d8024d8804","original_commit_id":"81e5aa06052c49c4aced09392b1cf1d8024d8804","user":{"login":"aynleslie","id":6155686,"avatar_url":"https://avatars2.githubusercontent.com/u/6155686?v=4","gravatar_id":"","url":"https://api.github.com/users/aynleslie","html_url":"https://github.com/aynleslie","followers_url":"https://api.github.com/users/aynleslie/followers","following_url":"https://api.github.com/users/aynleslie/following{/other_user}","gists_url":"https://api.github.com/users/aynleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/aynleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aynleslie/subscriptions","organizations_url":"https://api.github.com/users/aynleslie/orgs","repos_url":"https://api.github.com/users/aynleslie/repos","events_url":"https://api.github.com/users/aynleslie/events{/privacy}","received_events_url":"https://api.github.com/users/aynleslie/received_events","type":"User","site_admin":false},"body":"are these generally paired together?  is it that the ascii folder tends to create duplicates?","created_at":"2018-05-09T16:51:06Z","updated_at":"2018-05-09T16:53:05Z","html_url":"https://github.com/socrata-platform/spandex/pull/123#discussion_r187104683","pull_request_url":"https://api.github.com/repos/socrata-platform/spandex/pulls/123","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/comments/187104683"},"html":{"href":"https://github.com/socrata-platform/spandex/pull/123#discussion_r187104683"},"pull_request":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/socrata-platform/spandex/pulls/123","id":186817381,"html_url":"https://github.com/socrata-platform/spandex/pull/123","diff_url":"https://github.com/socrata-platform/spandex/pull/123.diff","patch_url":"https://github.com/socrata-platform/spandex/pull/123.patch","issue_url":"https://api.github.com/repos/socrata-platform/spandex/issues/123","number":123,"state":"open","locked":false,"title":"EN-4730 Handle accented characters better","user":{"login":"rlvoyer","id":172413,"avatar_url":"https://avatars3.githubusercontent.com/u/172413?v=4","gravatar_id":"","url":"https://api.github.com/users/rlvoyer","html_url":"https://github.com/rlvoyer","followers_url":"https://api.github.com/users/rlvoyer/followers","following_url":"https://api.github.com/users/rlvoyer/following{/other_user}","gists_url":"https://api.github.com/users/rlvoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/rlvoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlvoyer/subscriptions","organizations_url":"https://api.github.com/users/rlvoyer/orgs","repos_url":"https://api.github.com/users/rlvoyer/repos","events_url":"https://api.github.com/users/rlvoyer/events{/privacy}","received_events_url":"https://api.github.com/users/rlvoyer/received_events","type":"User","site_admin":false},"body":"This updates the autocomplete analyzer used at index time by the autocomplete service to do\r\ndiacritic folding. Specifically, given a field value of \"estàs\" at index time, the following\r\ntokens would be index:\r\n\r\n```\r\ne\r\nes\r\nest\r\nesta\r\nestas\r\nestà\r\nestàs\r\n```\r\n\r\nPreviously, \"esta\" and \"estas\" would not have been indexed, meaning that the string needed to be\r\nsearched via its exact form in order to be found. Note: this change increases recall which means that\r\nthere is a slight increase in the likelihood of false positives.","created_at":"2018-05-09T04:54:32Z","updated_at":"2018-05-09T16:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be38e54b4b43397aba16847467812e6bcc745712","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/socrata-platform/spandex/pulls/123/commits","review_comments_url":"https://api.github.com/repos/socrata-platform/spandex/pulls/123/comments","review_comment_url":"https://api.github.com/repos/socrata-platform/spandex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata-platform/spandex/issues/123/comments","statuses_url":"https://api.github.com/repos/socrata-platform/spandex/statuses/81e5aa06052c49c4aced09392b1cf1d8024d8804","head":{"label":"socrata-platform:rlvoyer/EN-4730/normalize-diacritics","ref":"rlvoyer/EN-4730/normalize-diacritics","sha":"81e5aa06052c49c4aced09392b1cf1d8024d8804","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars3.githubusercontent.com/u/12076358?v=4","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":26875426,"name":"spandex","full_name":"socrata-platform/spandex","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars3.githubusercontent.com/u/12076358?v=4","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/spandex","description":"autocomplete with elasticsearch ","fork":false,"url":"https://api.github.com/repos/socrata-platform/spandex","forks_url":"https://api.github.com/repos/socrata-platform/spandex/forks","keys_url":"https://api.github.com/repos/socrata-platform/spandex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/spandex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/spandex/teams","hooks_url":"https://api.github.com/repos/socrata-platform/spandex/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/spandex/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/spandex/events","assignees_url":"https://api.github.com/repos/socrata-platform/spandex/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/spandex/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/spandex/tags","blobs_url":"https://api.github.com/repos/socrata-platform/spandex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/spandex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/spandex/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/spandex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/spandex/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/spandex/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/spandex/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/spandex/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/spandex/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/spandex/subscription","commits_url":"https://api.github.com/repos/socrata-platform/spandex/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/spandex/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/spandex/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/spandex/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/spandex/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/spandex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/spandex/merges","archive_url":"https://api.github.com/repos/socrata-platform/spandex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/spandex/downloads","issues_url":"https://api.github.com/repos/socrata-platform/spandex/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/spandex/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/spandex/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/spandex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/spandex/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/spandex/releases{/id}","deployments_url":"https://api.github.com/repos/socrata-platform/spandex/deployments","created_at":"2014-11-19T18:32:11Z","updated_at":"2018-05-07T22:13:22Z","pushed_at":"2018-05-09T16:30:45Z","git_url":"git://github.com/socrata-platform/spandex.git","ssh_url":"git@github.com:socrata-platform/spandex.git","clone_url":"https://github.com/socrata-platform/spandex.git","svn_url":"https://github.com/socrata-platform/spandex","homepage":null,"size":110063,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"socrata-platform:master","ref":"master","sha":"9097430da2e099a96f2ebf12951adac1964a385d","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars3.githubusercontent.com/u/12076358?v=4","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":26875426,"name":"spandex","full_name":"socrata-platform/spandex","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars3.githubusercontent.com/u/12076358?v=4","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/spandex","description":"autocomplete with elasticsearch ","fork":false,"url":"https://api.github.com/repos/socrata-platform/spandex","forks_url":"https://api.github.com/repos/socrata-platform/spandex/forks","keys_url":"https://api.github.com/repos/socrata-platform/spandex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/spandex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/spandex/teams","hooks_url":"https://api.github.com/repos/socrata-platform/spandex/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/spandex/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/spandex/events","assignees_url":"https://api.github.com/repos/socrata-platform/spandex/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/spandex/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/spandex/tags","blobs_url":"https://api.github.com/repos/socrata-platform/spandex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/spandex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/spandex/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/spandex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/spandex/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/spandex/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/spandex/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/spandex/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/spandex/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/spandex/subscription","commits_url":"https://api.github.com/repos/socrata-platform/spandex/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/spandex/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/spandex/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/spandex/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/spandex/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/spandex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/spandex/merges","archive_url":"https://api.github.com/repos/socrata-platform/spandex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/spandex/downloads","issues_url":"https://api.github.com/repos/socrata-platform/spandex/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/spandex/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/spandex/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/spandex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/spandex/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/spandex/releases{/id}","deployments_url":"https://api.github.com/repos/socrata-platform/spandex/deployments","created_at":"2014-11-19T18:32:11Z","updated_at":"2018-05-07T22:13:22Z","pushed_at":"2018-05-09T16:30:45Z","git_url":"git://github.com/socrata-platform/spandex.git","ssh_url":"git@github.com:socrata-platform/spandex.git","clone_url":"https://github.com/socrata-platform/spandex.git","svn_url":"https://github.com/socrata-platform/spandex","homepage":null,"size":110063,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/123"},"html":{"href":"https://github.com/socrata-platform/spandex/pull/123"},"issue":{"href":"https://api.github.com/repos/socrata-platform/spandex/issues/123"},"comments":{"href":"https://api.github.com/repos/socrata-platform/spandex/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata-platform/spandex/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/socrata-platform/spandex/statuses/81e5aa06052c49c4aced09392b1cf1d8024d8804"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aynleslie"}}