{"push_id":2995123058,"size":2,"distinct_size":1,"ref":"refs/heads/globus_scheme_representation_mixin_#475","head":"44095b546f14ea2d6ac065a85090deb138b727bf","before":"8a5795ffef8615147199e57a180c6b9db54d1156","commits":[{"sha":"797e250303f23a0d733dd2614dcfc3beb88686dc","author":{"name":"Ben Clifford","email":"6e9c823d93e7dad5e7e2198704c60762764c20c1@hawaga.org.uk"},"message":"Factor launch code (#580)\n\n* Factor launch code\r\n\r\nPrior to this commit, there were two ways in which a task would be launched,\r\ndepending on whether there were dependencies pending when the task was\r\ncreated or not.\r\n\r\nThese two ways were similar but not identical.\r\n\r\nThis commit makes a single `launch_if_ready` method which captures one of those\r\nlaunch behaviours - the case where a launch had been deferred.\r\n\r\nThis commit also changes the initial submission to always submit as if\r\ndependencies were pending, and then immediately calls `launch_if_ready`.\r\n\r\nThis makes the code easier to follow, I think, as tidying up the separation\r\nof creating a non-running task first, and then separately visiting it\r\nto decide if it can be run.\r\n\r\nThere is a (hopefully minor) increased expense in visiting all of the dependencies\r\ntwice to see if they are done, on task creation (as launch_if_ready always checks\r\ndependencies, even if task creation has just done so).\r\n\r\nThis refactoring also means that `launch_if_ready` can be called *anywhere* where\r\nthere is a possibility that a task has become ready for launch, without needing\r\nfurther co-ordination of that launching.\r\n\r\n* Fix flake8\r\n\r\n* Add some more notes on usage and safety\r\n\r\n* remove a log line\r\n\r\n* Make indentation of launch_if_ready follow correct style\r\n\r\n* remove unneeded status change that only happened in one of the paths\r\n\r\n* tidy documentation","distinct":false,"url":"https://api.github.com/repos/Parsl/parsl/commits/797e250303f23a0d733dd2614dcfc3beb88686dc"},{"sha":"44095b546f14ea2d6ac065a85090deb138b727bf","author":{"name":"Anna Woodard","email":"b96b5feb08b518eb6ea6dbedd13d38f028c9465a@uchicago.edu"},"message":"Merge branch 'master' into globus_scheme_representation_mixin_#475","distinct":true,"url":"https://api.github.com/repos/Parsl/parsl/commits/44095b546f14ea2d6ac065a85090deb138b727bf"}]}
{"actor":{"display_login":"annawoodard"}}