{"action":"created","comment":{"url":"https://api.github.com/repos/skmgoldin/tcr/pulls/comments/204190025","pull_request_review_id":139235596,"id":204190025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5MDAyNQ==","diff_hunk":"@@ -18,11 +18,12 @@ contract Registry {\n     event _ApplicationWhitelisted(bytes32 indexed listingHash);\n     event _ApplicationRemoved(bytes32 indexed listingHash);\n     event _ListingRemoved(bytes32 indexed listingHash);\n-    event _ListingWithdrawn(bytes32 indexed listingHash);\n+    event _ListingWithdrawn(bytes32 indexed listingHash, address indexed owner);","path":"contracts/Registry.sol","position":5,"original_position":5,"commit_id":"b6bf2b95f65d333d2102c2f049248449cc7a1631","original_commit_id":"9e9913c38fb1513f1d67368b29eb7b8c03e01793","user":{"login":"kangarang","id":18040654,"node_id":"MDQ6VXNlcjE4MDQwNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/18040654?v=4","gravatar_id":"","url":"https://api.github.com/users/kangarang","html_url":"https://github.com/kangarang","followers_url":"https://api.github.com/users/kangarang/followers","following_url":"https://api.github.com/users/kangarang/following{/other_user}","gists_url":"https://api.github.com/users/kangarang/gists{/gist_id}","starred_url":"https://api.github.com/users/kangarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangarang/subscriptions","organizations_url":"https://api.github.com/users/kangarang/orgs","repos_url":"https://api.github.com/users/kangarang/repos","events_url":"https://api.github.com/users/kangarang/events{/privacy}","received_events_url":"https://api.github.com/users/kangarang/received_events","type":"User","site_admin":false},"body":"@akuanti @skmgoldin , taking a look at [this commit](https://github.com/skmgoldin/tcr/commit/b5d3898fafc4acc3f81b51f7ccb7ab2d434063c2), we removed `owner` from the `_RewardClaimed` event. \r\n\r\nshortly thereafter, we brought `msg.sender`s [back in](https://github.com/skmgoldin/tcr/commit/1a2603b9947c75b7c98603fa2b0c2267c861e931), for reasons documented here [here.](https://github.com/skmgoldin/tcr/commit/7c4b5bd9e46bbd1ad2a8ba090f043d0aca22fcb4)","created_at":"2018-07-20T23:23:35Z","updated_at":"2018-07-20T23:23:35Z","html_url":"https://github.com/skmgoldin/tcr/pull/72#discussion_r204190025","pull_request_url":"https://api.github.com/repos/skmgoldin/tcr/pulls/72","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/comments/204190025"},"html":{"href":"https://github.com/skmgoldin/tcr/pull/72#discussion_r204190025"},"pull_request":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/72"}},"in_reply_to_id":197167612},"pull_request":{"url":"https://api.github.com/repos/skmgoldin/tcr/pulls/72","id":196281538,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjgxNTM4","html_url":"https://github.com/skmgoldin/tcr/pull/72","diff_url":"https://github.com/skmgoldin/tcr/pull/72.diff","patch_url":"https://github.com/skmgoldin/tcr/pull/72.patch","issue_url":"https://api.github.com/repos/skmgoldin/tcr/issues/72","number":72,"state":"open","locked":false,"title":"Delayed exit","user":{"login":"kareem-ib","id":12586551,"node_id":"MDQ6VXNlcjEyNTg2NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/12586551?v=4","gravatar_id":"","url":"https://api.github.com/users/kareem-ib","html_url":"https://github.com/kareem-ib","followers_url":"https://api.github.com/users/kareem-ib/followers","following_url":"https://api.github.com/users/kareem-ib/following{/other_user}","gists_url":"https://api.github.com/users/kareem-ib/gists{/gist_id}","starred_url":"https://api.github.com/users/kareem-ib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kareem-ib/subscriptions","organizations_url":"https://api.github.com/users/kareem-ib/orgs","repos_url":"https://api.github.com/users/kareem-ib/repos","events_url":"https://api.github.com/users/kareem-ib/events{/privacy}","received_events_url":"https://api.github.com/users/kareem-ib/received_events","type":"User","site_admin":false},"body":"With old exit function, anybody could leave without any repercussions. E.x. a bad actor does something bad on the whitelist and decides to exit before being challenged and they are transferred back their original unstaked deposit. By increasing the time in which one is required to finalize an exit, we can mitigate this.\r\n\r\n* Split up exit function into two, initExit() and finalizeExit().\r\n\r\n* Add two parameters to Parameterizer: exitTimeDelay and exitTimeExpiry. exitTimeDelay represents the first time that the user is allowed to finalize their exit while exitTimeExpiry represents the latest time.\r\n\r\n* Add tests. Refactor a few tests to contain less state.\r\n\r\nThis PR is rebased against the develop branch with commits that are squashed from the original PR #71","created_at":"2018-06-20T21:46:52Z","updated_at":"2018-07-20T23:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab5f9566990d6624ce644d2e41ebac17c255dc8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skmgoldin/tcr/pulls/72/commits","review_comments_url":"https://api.github.com/repos/skmgoldin/tcr/pulls/72/comments","review_comment_url":"https://api.github.com/repos/skmgoldin/tcr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skmgoldin/tcr/issues/72/comments","statuses_url":"https://api.github.com/repos/skmgoldin/tcr/statuses/b6bf2b95f65d333d2102c2f049248449cc7a1631","head":{"label":"nigel-heeral:squash-delayedExit","ref":"squash-delayedExit","sha":"b6bf2b95f65d333d2102c2f049248449cc7a1631","user":{"login":"nigel-heeral","id":40004370,"node_id":"MDQ6VXNlcjQwMDA0Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/40004370?v=4","gravatar_id":"","url":"https://api.github.com/users/nigel-heeral","html_url":"https://github.com/nigel-heeral","followers_url":"https://api.github.com/users/nigel-heeral/followers","following_url":"https://api.github.com/users/nigel-heeral/following{/other_user}","gists_url":"https://api.github.com/users/nigel-heeral/gists{/gist_id}","starred_url":"https://api.github.com/users/nigel-heeral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigel-heeral/subscriptions","organizations_url":"https://api.github.com/users/nigel-heeral/orgs","repos_url":"https://api.github.com/users/nigel-heeral/repos","events_url":"https://api.github.com/users/nigel-heeral/events{/privacy}","received_events_url":"https://api.github.com/users/nigel-heeral/received_events","type":"User","site_admin":false},"repo":{"id":136972021,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5NzIwMjE=","name":"tcr","full_name":"nigel-heeral/tcr","owner":{"login":"nigel-heeral","id":40004370,"node_id":"MDQ6VXNlcjQwMDA0Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/40004370?v=4","gravatar_id":"","url":"https://api.github.com/users/nigel-heeral","html_url":"https://github.com/nigel-heeral","followers_url":"https://api.github.com/users/nigel-heeral/followers","following_url":"https://api.github.com/users/nigel-heeral/following{/other_user}","gists_url":"https://api.github.com/users/nigel-heeral/gists{/gist_id}","starred_url":"https://api.github.com/users/nigel-heeral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigel-heeral/subscriptions","organizations_url":"https://api.github.com/users/nigel-heeral/orgs","repos_url":"https://api.github.com/users/nigel-heeral/repos","events_url":"https://api.github.com/users/nigel-heeral/events{/privacy}","received_events_url":"https://api.github.com/users/nigel-heeral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nigel-heeral/tcr","description":"A generic token-curated registry","fork":true,"url":"https://api.github.com/repos/nigel-heeral/tcr","forks_url":"https://api.github.com/repos/nigel-heeral/tcr/forks","keys_url":"https://api.github.com/repos/nigel-heeral/tcr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nigel-heeral/tcr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nigel-heeral/tcr/teams","hooks_url":"https://api.github.com/repos/nigel-heeral/tcr/hooks","issue_events_url":"https://api.github.com/repos/nigel-heeral/tcr/issues/events{/number}","events_url":"https://api.github.com/repos/nigel-heeral/tcr/events","assignees_url":"https://api.github.com/repos/nigel-heeral/tcr/assignees{/user}","branches_url":"https://api.github.com/repos/nigel-heeral/tcr/branches{/branch}","tags_url":"https://api.github.com/repos/nigel-heeral/tcr/tags","blobs_url":"https://api.github.com/repos/nigel-heeral/tcr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nigel-heeral/tcr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nigel-heeral/tcr/git/refs{/sha}","trees_url":"https://api.github.com/repos/nigel-heeral/tcr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nigel-heeral/tcr/statuses/{sha}","languages_url":"https://api.github.com/repos/nigel-heeral/tcr/languages","stargazers_url":"https://api.github.com/repos/nigel-heeral/tcr/stargazers","contributors_url":"https://api.github.com/repos/nigel-heeral/tcr/contributors","subscribers_url":"https://api.github.com/repos/nigel-heeral/tcr/subscribers","subscription_url":"https://api.github.com/repos/nigel-heeral/tcr/subscription","commits_url":"https://api.github.com/repos/nigel-heeral/tcr/commits{/sha}","git_commits_url":"https://api.github.com/repos/nigel-heeral/tcr/git/commits{/sha}","comments_url":"https://api.github.com/repos/nigel-heeral/tcr/comments{/number}","issue_comment_url":"https://api.github.com/repos/nigel-heeral/tcr/issues/comments{/number}","contents_url":"https://api.github.com/repos/nigel-heeral/tcr/contents/{+path}","compare_url":"https://api.github.com/repos/nigel-heeral/tcr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nigel-heeral/tcr/merges","archive_url":"https://api.github.com/repos/nigel-heeral/tcr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nigel-heeral/tcr/downloads","issues_url":"https://api.github.com/repos/nigel-heeral/tcr/issues{/number}","pulls_url":"https://api.github.com/repos/nigel-heeral/tcr/pulls{/number}","milestones_url":"https://api.github.com/repos/nigel-heeral/tcr/milestones{/number}","notifications_url":"https://api.github.com/repos/nigel-heeral/tcr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nigel-heeral/tcr/labels{/name}","releases_url":"https://api.github.com/repos/nigel-heeral/tcr/releases{/id}","deployments_url":"https://api.github.com/repos/nigel-heeral/tcr/deployments","created_at":"2018-06-11T19:31:56Z","updated_at":"2018-06-18T20:13:43Z","pushed_at":"2018-06-28T16:22:29Z","git_url":"git://github.com/nigel-heeral/tcr.git","ssh_url":"git@github.com:nigel-heeral/tcr.git","clone_url":"https://github.com/nigel-heeral/tcr.git","svn_url":"https://github.com/nigel-heeral/tcr","homepage":"","size":1237,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skmgoldin:develop","ref":"develop","sha":"eae369d4424b347234c508aa370c633651c98832","user":{"login":"skmgoldin","id":6937058,"node_id":"MDQ6VXNlcjY5MzcwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6937058?v=4","gravatar_id":"","url":"https://api.github.com/users/skmgoldin","html_url":"https://github.com/skmgoldin","followers_url":"https://api.github.com/users/skmgoldin/followers","following_url":"https://api.github.com/users/skmgoldin/following{/other_user}","gists_url":"https://api.github.com/users/skmgoldin/gists{/gist_id}","starred_url":"https://api.github.com/users/skmgoldin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmgoldin/subscriptions","organizations_url":"https://api.github.com/users/skmgoldin/orgs","repos_url":"https://api.github.com/users/skmgoldin/repos","events_url":"https://api.github.com/users/skmgoldin/events{/privacy}","received_events_url":"https://api.github.com/users/skmgoldin/received_events","type":"User","site_admin":false},"repo":{"id":110886165,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4ODYxNjU=","name":"tcr","full_name":"skmgoldin/tcr","owner":{"login":"skmgoldin","id":6937058,"node_id":"MDQ6VXNlcjY5MzcwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6937058?v=4","gravatar_id":"","url":"https://api.github.com/users/skmgoldin","html_url":"https://github.com/skmgoldin","followers_url":"https://api.github.com/users/skmgoldin/followers","following_url":"https://api.github.com/users/skmgoldin/following{/other_user}","gists_url":"https://api.github.com/users/skmgoldin/gists{/gist_id}","starred_url":"https://api.github.com/users/skmgoldin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmgoldin/subscriptions","organizations_url":"https://api.github.com/users/skmgoldin/orgs","repos_url":"https://api.github.com/users/skmgoldin/repos","events_url":"https://api.github.com/users/skmgoldin/events{/privacy}","received_events_url":"https://api.github.com/users/skmgoldin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skmgoldin/tcr","description":"A generic token-curated registry","fork":false,"url":"https://api.github.com/repos/skmgoldin/tcr","forks_url":"https://api.github.com/repos/skmgoldin/tcr/forks","keys_url":"https://api.github.com/repos/skmgoldin/tcr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skmgoldin/tcr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skmgoldin/tcr/teams","hooks_url":"https://api.github.com/repos/skmgoldin/tcr/hooks","issue_events_url":"https://api.github.com/repos/skmgoldin/tcr/issues/events{/number}","events_url":"https://api.github.com/repos/skmgoldin/tcr/events","assignees_url":"https://api.github.com/repos/skmgoldin/tcr/assignees{/user}","branches_url":"https://api.github.com/repos/skmgoldin/tcr/branches{/branch}","tags_url":"https://api.github.com/repos/skmgoldin/tcr/tags","blobs_url":"https://api.github.com/repos/skmgoldin/tcr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skmgoldin/tcr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skmgoldin/tcr/git/refs{/sha}","trees_url":"https://api.github.com/repos/skmgoldin/tcr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skmgoldin/tcr/statuses/{sha}","languages_url":"https://api.github.com/repos/skmgoldin/tcr/languages","stargazers_url":"https://api.github.com/repos/skmgoldin/tcr/stargazers","contributors_url":"https://api.github.com/repos/skmgoldin/tcr/contributors","subscribers_url":"https://api.github.com/repos/skmgoldin/tcr/subscribers","subscription_url":"https://api.github.com/repos/skmgoldin/tcr/subscription","commits_url":"https://api.github.com/repos/skmgoldin/tcr/commits{/sha}","git_commits_url":"https://api.github.com/repos/skmgoldin/tcr/git/commits{/sha}","comments_url":"https://api.github.com/repos/skmgoldin/tcr/comments{/number}","issue_comment_url":"https://api.github.com/repos/skmgoldin/tcr/issues/comments{/number}","contents_url":"https://api.github.com/repos/skmgoldin/tcr/contents/{+path}","compare_url":"https://api.github.com/repos/skmgoldin/tcr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skmgoldin/tcr/merges","archive_url":"https://api.github.com/repos/skmgoldin/tcr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skmgoldin/tcr/downloads","issues_url":"https://api.github.com/repos/skmgoldin/tcr/issues{/number}","pulls_url":"https://api.github.com/repos/skmgoldin/tcr/pulls{/number}","milestones_url":"https://api.github.com/repos/skmgoldin/tcr/milestones{/number}","notifications_url":"https://api.github.com/repos/skmgoldin/tcr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skmgoldin/tcr/labels{/name}","releases_url":"https://api.github.com/repos/skmgoldin/tcr/releases{/id}","deployments_url":"https://api.github.com/repos/skmgoldin/tcr/deployments","created_at":"2017-11-15T21:03:09Z","updated_at":"2018-07-20T11:17:11Z","pushed_at":"2018-07-19T22:41:04Z","git_url":"git://github.com/skmgoldin/tcr.git","ssh_url":"git@github.com:skmgoldin/tcr.git","clone_url":"https://github.com/skmgoldin/tcr.git","svn_url":"https://github.com/skmgoldin/tcr","homepage":"","size":1139,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":19,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/72"},"html":{"href":"https://github.com/skmgoldin/tcr/pull/72"},"issue":{"href":"https://api.github.com/repos/skmgoldin/tcr/issues/72"},"comments":{"href":"https://api.github.com/repos/skmgoldin/tcr/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skmgoldin/tcr/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/skmgoldin/tcr/statuses/b6bf2b95f65d333d2102c2f049248449cc7a1631"}},"author_association":"NONE"}}
{"actor":{"display_login":"kangarang"}}