{"action":"created","issue":{"url":"https://api.github.com/repos/lief-project/LIEF/issues/164","repository_url":"https://api.github.com/repos/lief-project/LIEF","labels_url":"https://api.github.com/repos/lief-project/LIEF/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/lief-project/LIEF/issues/164/comments","events_url":"https://api.github.com/repos/lief-project/LIEF/issues/164/events","html_url":"https://github.com/lief-project/LIEF/issues/164","id":320352317,"number":164,"title":"Multiple problems compiling LIEF","user":{"login":"aurelianito","id":106638,"avatar_url":"https://avatars3.githubusercontent.com/u/106638?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelianito","html_url":"https://github.com/aurelianito","followers_url":"https://api.github.com/users/aurelianito/followers","following_url":"https://api.github.com/users/aurelianito/following{/other_user}","gists_url":"https://api.github.com/users/aurelianito/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelianito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelianito/subscriptions","organizations_url":"https://api.github.com/users/aurelianito/orgs","repos_url":"https://api.github.com/users/aurelianito/repos","events_url":"https://api.github.com/users/aurelianito/events{/privacy}","received_events_url":"https://api.github.com/users/aurelianito/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-04T17:09:20Z","updated_at":"2018-05-04T18:30:46Z","closed_at":null,"author_association":"NONE","body":"I am still trying to compile LIEF's static library using VS 2015. Until commit 55e99450f4b2 I was able to using the things made to work around #156. \r\n\r\nBut not anymore :(\r\n\r\nThe first error I got is that std::min is not defined. This was solved adding `#include <algorithm>` to `src/DEX/instruction.cpp`. That was easy, but then the real problems began.\r\n\r\nIf I try to compile setting `-DLIEF_ENABLE_JSON=off -DLIEF_LOGGING=off` then it gives really ugly errors in the new code. The code also does not compile if I try to disable the new features by setting `-DLIEF_OAT=off -DLIEF_DEX=off -DLIEF_VDEX=off -DLIEF_ART=off`\r\n\r\nAll this was tried using VS 2015 and compiling the static library as explained in #156 with the current master (commit 4ef1bb845f81cb467cb21b04b34e11f14b0a76de)\r\n\r\nOne last thing, these errors do not seem to be VS2015 exclusives, as new code references things that are not existent when some parts are set off using `-DLIEF_SOMETHING=off` parameters when invoking cmake."},"comment":{"url":"https://api.github.com/repos/lief-project/LIEF/issues/comments/386693667","html_url":"https://github.com/lief-project/LIEF/issues/164#issuecomment-386693667","issue_url":"https://api.github.com/repos/lief-project/LIEF/issues/164","id":386693667,"user":{"login":"romainthomas","id":7450402,"avatar_url":"https://avatars2.githubusercontent.com/u/7450402?v=4","gravatar_id":"","url":"https://api.github.com/users/romainthomas","html_url":"https://github.com/romainthomas","followers_url":"https://api.github.com/users/romainthomas/followers","following_url":"https://api.github.com/users/romainthomas/following{/other_user}","gists_url":"https://api.github.com/users/romainthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/romainthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainthomas/subscriptions","organizations_url":"https://api.github.com/users/romainthomas/orgs","repos_url":"https://api.github.com/users/romainthomas/repos","events_url":"https://api.github.com/users/romainthomas/events{/privacy}","received_events_url":"https://api.github.com/users/romainthomas/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T18:30:46Z","updated_at":"2018-05-04T18:30:46Z","author_association":"CONTRIBUTOR","body":"https://github.com/lief-project/LIEF/commit/9d7604a1aebe5d1db353a6a52d8148b7785d436f should fix the issue"}}
{"actor":{"display_login":"romainthomas"}}