{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/5366","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/5366/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/5366/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/5366/events","html_url":"https://github.com/serverless/serverless/pull/5366","id":367864678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTc0OTg4","number":5366,"title":"Fixed principal's host issue in China region","user":{"login":"beary","id":6630583,"node_id":"MDQ6VXNlcjY2MzA1ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6630583?v=4","gravatar_id":"","url":"https://api.github.com/users/beary","html_url":"https://github.com/beary","followers_url":"https://api.github.com/users/beary/followers","following_url":"https://api.github.com/users/beary/following{/other_user}","gists_url":"https://api.github.com/users/beary/gists{/gist_id}","starred_url":"https://api.github.com/users/beary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beary/subscriptions","organizations_url":"https://api.github.com/users/beary/orgs","repos_url":"https://api.github.com/users/beary/repos","events_url":"https://api.github.com/users/beary/events{/privacy}","received_events_url":"https://api.github.com/users/beary/received_events","type":"User","site_admin":false},"labels":[{"id":484058097,"node_id":"MDU6TGFiZWw0ODQwNTgwOTc=","url":"https://api.github.com/repos/serverless/serverless/labels/stage/in-review","name":"stage/in-review","color":"fad8c7","default":false},{"id":511595861,"node_id":"MDU6TGFiZWw1MTE1OTU4NjE=","url":"https://api.github.com/repos/serverless/serverless/labels/stage/needs-feedback","name":"stage/needs-feedback","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-08T16:25:14Z","updated_at":"2018-10-22T07:06:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/5366","html_url":"https://github.com/serverless/serverless/pull/5366","diff_url":"https://github.com/serverless/serverless/pull/5366.diff","patch_url":"https://github.com/serverless/serverless/pull/5366.patch"},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nCloses https://github.com/serverless/serverless/issues/5365\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\nReplace `AWS::URLSuffix` in all principal parameters to hardcoded `<service-name>.amazonaws.com`\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\nDeploy a restApi in region `cn-north-1`.\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* Cloud Configuration - List cloud resources and show that the correct configuration is in place (e.g. AWS CLI commands)\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n## Todos:\r\n\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Enable \"Allow edits from maintainers\" for this PR\r\n- [x] Update the messages below\r\n\r\n***Is this ready for review?:*** YES\r\n***Is it a breaking change?:*** NO\r\n"},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/431756090","html_url":"https://github.com/serverless/serverless/pull/5366#issuecomment-431756090","issue_url":"https://api.github.com/repos/serverless/serverless/issues/5366","id":431756090,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTc1NjA5MA==","user":{"login":"beary","id":6630583,"node_id":"MDQ6VXNlcjY2MzA1ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6630583?v=4","gravatar_id":"","url":"https://api.github.com/users/beary","html_url":"https://github.com/beary","followers_url":"https://api.github.com/users/beary/followers","following_url":"https://api.github.com/users/beary/following{/other_user}","gists_url":"https://api.github.com/users/beary/gists{/gist_id}","starred_url":"https://api.github.com/users/beary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beary/subscriptions","organizations_url":"https://api.github.com/users/beary/orgs","repos_url":"https://api.github.com/users/beary/repos","events_url":"https://api.github.com/users/beary/events{/privacy}","received_events_url":"https://api.github.com/users/beary/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T07:06:31Z","updated_at":"2018-10-22T07:06:31Z","author_association":"NONE","body":"Hi @horike37 ,\r\nThanks for your feeback.\r\n\r\nThe particularity of China is because of [GFW](https://en.wikipedia.org/wiki/Great_Firewall), and if overseas companies want to operate in China, they must cooperate with local companies, that is why AWS in China must provide an different endpoint. but [other regions](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.RegionsAndAvailabilityZones.html) do not has this thing.\r\n\r\nEndpoint is face to users, my invoke URL looks like this `https://xxxxxxx.execute-api.cn-north-1.amazonaws.com.cn/prod`, so I keep the `AWS::URLSuffix` [here](https://github.com/serverless/serverless/blob/master/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.js#L32).\r\n\r\nFor principal, the `.cn` suffix issue seem was fixed https://github.com/kubernetes-incubator/kube-aws/pull/15. And before [this commit](https://github.com/serverless/serverless/pull/4665/commits/88ed6c9d4782e4667fdcef7c5322e702dccb8fc1#diff-399cbfb87ef7b0f40e9facc24070c61dL21) , `<service-name>.amazonaws.com` works fine in every regions. So this pull request may not cause problem.\r\n\r\nI know more feedback from the community would be helpful. But serverless is at an early stage in China and this issue is only appear in China. Now I and my workmates needs to make this changes every time after `npm i -g serverless` on our computer or CI :cry:."}}
{"actor":{"display_login":"beary"}}