{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/13495","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/13495/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/13495/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/13495/events","html_url":"https://github.com/magento/magento2/pull/13495","id":294356696,"number":13495,"title":"Removing reprecated dependencies from Braintree module","user":{"login":"joni-jones","id":2736528,"avatar_url":"https://avatars0.githubusercontent.com/u/2736528?v=4","gravatar_id":"","url":"https://api.github.com/users/joni-jones","html_url":"https://github.com/joni-jones","followers_url":"https://api.github.com/users/joni-jones/followers","following_url":"https://api.github.com/users/joni-jones/following{/other_user}","gists_url":"https://api.github.com/users/joni-jones/gists{/gist_id}","starred_url":"https://api.github.com/users/joni-jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joni-jones/subscriptions","organizations_url":"https://api.github.com/users/joni-jones/orgs","repos_url":"https://api.github.com/users/joni-jones/repos","events_url":"https://api.github.com/users/joni-jones/events{/privacy}","received_events_url":"https://api.github.com/users/joni-jones/received_events","type":"User","site_admin":false},"labels":[{"id":703232382,"url":"https://api.github.com/repos/magento/magento2/labels/2.2-develop","name":"2.2-develop","color":"fbca04","default":false},{"id":161563561,"url":"https://api.github.com/repos/magento/magento2/labels/needs%20update","name":"needs update","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"assignees":[{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-02-05T11:15:47Z","updated_at":"2018-02-06T17:18:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/13495","html_url":"https://github.com/magento/magento2/pull/13495","diff_url":"https://github.com/magento/magento2/pull/13495.diff","patch_url":"https://github.com/magento/magento2/pull/13495.patch"},"body":"Braintree module has dependencies on deprecated `\\Magento\\Payment\\Model\\Method\\AbstractMethod` and `\\Magento\\Vault\\Api\\Data\\PaymentTokenInterfaceFactory`. Proposed changes remove or replace them.\r\n\r\n### Description\r\n- Removed dependency of AbstractMethod\r\n- Replaced usage of deprecated Vault factories\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/363496563","html_url":"https://github.com/magento/magento2/pull/13495#issuecomment-363496563","issue_url":"https://api.github.com/repos/magento/magento2/issues/13495","id":363496563,"user":{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T17:18:04Z","updated_at":"2018-02-06T17:18:04Z","author_association":"CONTRIBUTOR","body":"@joni-jones @orlangur I don't like idea to add backward incompatible changes to patch releases when it possible not to do that. You can see on it as \"Each backward incompatible change will cost a lot of businesses in the world some money (dev hours).\", let's not spend it without need.\r\nIn this case - most changes could be adjusted to be just backward compatible. Also here were introduced a lot \"not good\" "}}
{"actor":{"display_login":"ihor-sviziev"}}