{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/233632261","pull_request_review_id":175093968,"id":233632261,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYzMjI2MQ==","diff_hunk":"@@ -217,5 +216,127 @@ public void TestWhiteningOldSavingAndLoading()\n             }\n             Done();\n         }\n+\n+        [Fact]\n+        public void LpNormWorkout()\n+        {\n+            var env = new ConsoleEnvironment(seed: 0);\n+            string dataSource = GetDataPath(\"generated_regression_dataset.csv\");","path":"test/Microsoft.ML.Tests/Transformers/NormalizerTests.cs","position":87,"original_position":28,"commit_id":"83a43fce771da2e751f38fa56c30e63c1aeb2666","original_commit_id":"61b63931e9796e7492665c70c2b8eb406b1c71a2","user":{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false},"body":"it is mostly to avoid typing strings everywhere. \r\n\r\nSee [https://github.com/dotnet/machinelearning/blob/453eb57f0cd94d6412b1f8dee76c00c686e2e06e/test/Microsoft.ML.TestFramework/TestCommandBase.cs#L1754](https://github.com/dotnet/machinelearning/blob/453eb57f0cd94d6412b1f8dee76c00c686e2e06e/test/Microsoft.ML.TestFramework/TestCommandBase.cs#L1754)\r\n\r\n---\r\nIn reply to: [232769077](https://github.com/dotnet/machinelearning/pull/1582#discussion_r232769077) [](ancestors = 232769077,232162621)","created_at":"2018-11-14T21:46:16Z","updated_at":"2018-11-14T21:46:16Z","html_url":"https://github.com/dotnet/machinelearning/pull/1582#discussion_r233632261","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/233632261"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1582#discussion_r233632261"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582"}},"in_reply_to_id":232162621},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582","id":229512216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTEyMjE2","html_url":"https://github.com/dotnet/machinelearning/pull/1582","diff_url":"https://github.com/dotnet/machinelearning/pull/1582.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1582.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1582","number":1582,"state":"open","locked":false,"title":"Convert Gcn and LpNorm to estimators","user":{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false},"body":"Convert gcn and lp norn to estimators","created_at":"2018-11-08T21:20:27Z","updated_at":"2018-11-14T21:46:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd8dff046011dcaec3f9228f6b0d8400a91a1f2c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wschin","id":3524474,"node_id":"MDQ6VXNlcjM1MjQ0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3524474?v=4","gravatar_id":"","url":"https://api.github.com/users/wschin","html_url":"https://github.com/wschin","followers_url":"https://api.github.com/users/wschin/followers","following_url":"https://api.github.com/users/wschin/following{/other_user}","gists_url":"https://api.github.com/users/wschin/gists{/gist_id}","starred_url":"https://api.github.com/users/wschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschin/subscriptions","organizations_url":"https://api.github.com/users/wschin/orgs","repos_url":"https://api.github.com/users/wschin/repos","events_url":"https://api.github.com/users/wschin/events{/privacy}","received_events_url":"https://api.github.com/users/wschin/received_events","type":"User","site_admin":false},{"login":"singlis","id":17055319,"node_id":"MDQ6VXNlcjE3MDU1MzE5","avatar_url":"https://avatars2.githubusercontent.com/u/17055319?v=4","gravatar_id":"","url":"https://api.github.com/users/singlis","html_url":"https://github.com/singlis","followers_url":"https://api.github.com/users/singlis/followers","following_url":"https://api.github.com/users/singlis/following{/other_user}","gists_url":"https://api.github.com/users/singlis/gists{/gist_id}","starred_url":"https://api.github.com/users/singlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singlis/subscriptions","organizations_url":"https://api.github.com/users/singlis/orgs","repos_url":"https://api.github.com/users/singlis/repos","events_url":"https://api.github.com/users/singlis/events{/privacy}","received_events_url":"https://api.github.com/users/singlis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1582/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/83a43fce771da2e751f38fa56c30e63c1aeb2666","head":{"label":"Ivanidzo4ka:Ivanidze/GcnEstimators","ref":"Ivanidze/GcnEstimators","sha":"83a43fce771da2e751f38fa56c30e63c1aeb2666","user":{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false},"repo":{"id":132816008,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4MTYwMDg=","name":"machinelearning","full_name":"Ivanidzo4ka/machinelearning","private":false,"owner":{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ivanidzo4ka/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning","forks_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/forks","keys_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/teams","hooks_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/events","assignees_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/tags","blobs_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/languages","stargazers_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/subscription","commits_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/merges","archive_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/downloads","issues_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/Ivanidzo4ka/machinelearning/deployments","created_at":"2018-05-09T21:45:41Z","updated_at":"2018-11-14T18:36:43Z","pushed_at":"2018-11-14T21:45:27Z","git_url":"git://github.com/Ivanidzo4ka/machinelearning.git","ssh_url":"git@github.com:Ivanidzo4ka/machinelearning.git","clone_url":"https://github.com/Ivanidzo4ka/machinelearning.git","svn_url":"https://github.com/Ivanidzo4ka/machinelearning","homepage":"http://dot.net/ml","size":29059,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"28fb3bbca4d5b8ad5b1f0bc28fef35db4d8232f3","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-11-14T20:48:49Z","pushed_at":"2018-11-14T21:45:29Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":28076,"stargazers_count":4128,"watchers_count":4128,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":773,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":773,"open_issues":367,"watchers":4128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1582"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1582"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1582/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1582/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/83a43fce771da2e751f38fa56c30e63c1aeb2666"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sfilipi"}}