{"push_id":2734219090,"size":1,"distinct_size":1,"ref":"refs/heads/cstor-feature-integration","head":"7507352bebdf3d2848be58c00a34e5b4f6765d2a","before":"90dd702f7a0c28b15d2f4fb5273ed9e3469c4f13","commits":[{"sha":"7507352bebdf3d2848be58c00a34e5b4f6765d2a","author":{"name":"Ganesh Kumar R","email":"3ffdcdce3be7a2573e21b866f581857db5c37d6e@gmail.com"},"message":"Change cvr scope to namespaced and modify channel to mutex. (#384)\n\n* Change cvr scope to namespaced and modify channel to mutex.\r\n1. Why is this change necessary ?\r\nfixes: openebs/openebs#1653 and modifying the means of sync between cstorpool and\r\ncvr from channel to mutex, since channel is more suitable for one-to-one\r\ncommunication.\r\n\r\n2. How does this change address the issue ?\r\n isImported variable is changed from bool channel to boolean and mutex is used for\r\nsync between cstorpool and cvr. When certain import pool operations are being done\r\nin cstorpool, cvr waits else cvr proceeds to create new zfs volume.\r\n\r\n3. How to verify this change ?\r\n make pool-mgmt-image. Apply cstorpool, cvr cr and deployment. Check for logs. Apply\r\nnew cvr crs and verify output. Try deleting one of cvr cr and verify if zfs volume is\r\ndeleted. Check the same by killing cstor-pool-mgmt sidecar only.\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>\r\n\r\n* Modularize and added more comments\r\n1. Why is this change necessary ?\r\n   CStorControllerIP is changed to TargetIP, more comments are added and\r\nerror status are handled and mutex handling is modularized.\r\n\r\n2. How does this change address the issue ?\r\n   When pool request is in progress, all cvr requests will be blocked.\r\nErrorDuplicate status is handled, when there is duplication of request.\r\n\r\n3. How to verify this change ?\r\n   make pool-mgmt-image and apply the yaml files.\r\n   Check the logs of pod and CR description and status.\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>\r\n\r\n* Change sync variables from file scope to struct\r\n1. Why is this change necessary ?\r\n   The synchronization variables, Mux and isImported is changed from being in\r\nfile scope to struct variable and more comments are added.\r\n\r\n2. How to verify this change ?\r\n   make pool-mgmt-image, Applying cstorpool and cvr CRs and the watcher will\r\ncreate and handle the synchronization.\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>\r\n\r\n* Change of workflow of create-pool with status\r\n\r\n1. Why is this change necessary ?\r\n   Create pool should happen based on empty status check,\r\nAlso status case are changed and more comments are added.\r\n\r\n2. How to verify this change ?\r\n   make pool-mgmt-image\r\n\r\nSigned-off-by: gkGaneshR <gkganesh126@gmail.com>","distinct":true,"url":"https://api.github.com/repos/Moteesh/maya/commits/7507352bebdf3d2848be58c00a34e5b4f6765d2a"}]}
{"actor":{"display_login":"Moteesh"}}