{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/comments/193080149","pull_request_review_id":125979126,"id":193080149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA4MDE0OQ==","diff_hunk":"@@ -35,9 +38,16 @@ type AuthConfig struct {\n \tUseInstancePrincipals bool   `yaml:\"useInstancePrincipals\"`\n }\n \n+// VolumeProvisionerOptions describes the potential options available to users of the\n+// volume provisioner.\n+type VolumeProvisionerOptions struct {","path":"pkg/oci/client/config.go","position":16,"original_position":16,"commit_id":"210ddadc106267fc545f50451db8009bbc0b4720","original_commit_id":"210ddadc106267fc545f50451db8009bbc0b4720","user":{"login":"harveylowndes","id":16415876,"node_id":"MDQ6VXNlcjE2NDE1ODc2","avatar_url":"https://avatars2.githubusercontent.com/u/16415876?v=4","gravatar_id":"","url":"https://api.github.com/users/harveylowndes","html_url":"https://github.com/harveylowndes","followers_url":"https://api.github.com/users/harveylowndes/followers","following_url":"https://api.github.com/users/harveylowndes/following{/other_user}","gists_url":"https://api.github.com/users/harveylowndes/gists{/gist_id}","starred_url":"https://api.github.com/users/harveylowndes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harveylowndes/subscriptions","organizations_url":"https://api.github.com/users/harveylowndes/orgs","repos_url":"https://api.github.com/users/harveylowndes/repos","events_url":"https://api.github.com/users/harveylowndes/events{/privacy}","received_events_url":"https://api.github.com/users/harveylowndes/received_events","type":"User","site_admin":false},"body":"@prydie it was there for when there was the option to set the minimum default and i guess to accommodate future options. ","created_at":"2018-06-05T13:53:38Z","updated_at":"2018-06-05T13:53:38Z","html_url":"https://github.com/oracle/oci-volume-provisioner/pull/121#discussion_r193080149","pull_request_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/comments/193080149"},"html":{"href":"https://github.com/oracle/oci-volume-provisioner/pull/121#discussion_r193080149"},"pull_request":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121"}},"in_reply_to_id":193042513},"pull_request":{"url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121","id":190529433,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTI5NDMz","html_url":"https://github.com/oracle/oci-volume-provisioner/pull/121","diff_url":"https://github.com/oracle/oci-volume-provisioner/pull/121.diff","patch_url":"https://github.com/oracle/oci-volume-provisioner/pull/121.patch","issue_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/121","number":121,"state":"open","locked":false,"title":"Round up volumes smaller than 50GB","user":{"login":"owainlewis","id":733944,"node_id":"MDQ6VXNlcjczMzk0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/733944?v=4","gravatar_id":"","url":"https://api.github.com/users/owainlewis","html_url":"https://github.com/owainlewis","followers_url":"https://api.github.com/users/owainlewis/followers","following_url":"https://api.github.com/users/owainlewis/following{/other_user}","gists_url":"https://api.github.com/users/owainlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/owainlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owainlewis/subscriptions","organizations_url":"https://api.github.com/users/owainlewis/orgs","repos_url":"https://api.github.com/users/owainlewis/repos","events_url":"https://api.github.com/users/owainlewis/events{/privacy}","received_events_url":"https://api.github.com/users/owainlewis/received_events","type":"User","site_admin":false},"body":"Fix: #120 \r\n\r\nOCI does not allow for creating block volumes less than 50GB. This change adds the ability to enable volume round up by using a `minVolumeSizeMB` value in the underlying storage class.\r\n\r\nThis behaviour should be \"on\" by default across all OCI Kubernetes Clusters since it is a requirement for conformance tests. ","created_at":"2018-05-25T09:24:44Z","updated_at":"2018-06-05T13:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b9aa9b784d7598d312b2c6712afa8e0ebd65686","assignee":null,"assignees":[],"requested_reviewers":[{"login":"garthy","id":1085290,"node_id":"MDQ6VXNlcjEwODUyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1085290?v=4","gravatar_id":"","url":"https://api.github.com/users/garthy","html_url":"https://github.com/garthy","followers_url":"https://api.github.com/users/garthy/followers","following_url":"https://api.github.com/users/garthy/following{/other_user}","gists_url":"https://api.github.com/users/garthy/gists{/gist_id}","starred_url":"https://api.github.com/users/garthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthy/subscriptions","organizations_url":"https://api.github.com/users/garthy/orgs","repos_url":"https://api.github.com/users/garthy/repos","events_url":"https://api.github.com/users/garthy/events{/privacy}","received_events_url":"https://api.github.com/users/garthy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":684479486,"node_id":"MDU6TGFiZWw2ODQ0Nzk0ODY=","url":"https://api.github.com/repos/oracle/oci-volume-provisioner/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121/commits","review_comments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121/comments","review_comment_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/121/comments","statuses_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/statuses/210ddadc106267fc545f50451db8009bbc0b4720","head":{"label":"oracle:ol/fix-120","ref":"ol/fix-120","sha":"210ddadc106267fc545f50451db8009bbc0b4720","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":102543996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDM5OTY=","name":"oci-volume-provisioner","full_name":"oracle/oci-volume-provisioner","owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/oci-volume-provisioner","description":"The OCI Volume Provisioner enables dynamic provisioning of storage resources when running Kubernetes on Oracle Cloud Infrastructure","fork":false,"url":"https://api.github.com/repos/oracle/oci-volume-provisioner","forks_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/forks","keys_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/teams","hooks_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/hooks","issue_events_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/events","assignees_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/tags","blobs_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/languages","stargazers_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/stargazers","contributors_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/contributors","subscribers_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/subscribers","subscription_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/subscription","commits_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/merges","archive_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/downloads","issues_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/deployments","created_at":"2017-09-06T00:39:39Z","updated_at":"2018-05-31T15:25:11Z","pushed_at":"2018-06-05T13:51:18Z","git_url":"git://github.com/oracle/oci-volume-provisioner.git","ssh_url":"git@github.com:oracle/oci-volume-provisioner.git","clone_url":"https://github.com/oracle/oci-volume-provisioner.git","svn_url":"https://github.com/oracle/oci-volume-provisioner","homepage":"","size":59092,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":22,"watchers":9,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"e110c86a9d459a79941dde08d9f564c47c30dd65","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":102543996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NDM5OTY=","name":"oci-volume-provisioner","full_name":"oracle/oci-volume-provisioner","owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/oci-volume-provisioner","description":"The OCI Volume Provisioner enables dynamic provisioning of storage resources when running Kubernetes on Oracle Cloud Infrastructure","fork":false,"url":"https://api.github.com/repos/oracle/oci-volume-provisioner","forks_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/forks","keys_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/teams","hooks_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/hooks","issue_events_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/events","assignees_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/tags","blobs_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/languages","stargazers_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/stargazers","contributors_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/contributors","subscribers_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/subscribers","subscription_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/subscription","commits_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/merges","archive_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/downloads","issues_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/oci-volume-provisioner/deployments","created_at":"2017-09-06T00:39:39Z","updated_at":"2018-05-31T15:25:11Z","pushed_at":"2018-06-05T13:51:18Z","git_url":"git://github.com/oracle/oci-volume-provisioner.git","ssh_url":"git@github.com:oracle/oci-volume-provisioner.git","clone_url":"https://github.com/oracle/oci-volume-provisioner.git","svn_url":"https://github.com/oracle/oci-volume-provisioner","homepage":"","size":59092,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":22,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121"},"html":{"href":"https://github.com/oracle/oci-volume-provisioner/pull/121"},"issue":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/121"},"comments":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/oci-volume-provisioner/statuses/210ddadc106267fc545f50451db8009bbc0b4720"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"harveylowndes"}}