{"action":"created","issue":{"url":"https://api.github.com/repos/vivo-project/Vitro/issues/74","repository_url":"https://api.github.com/repos/vivo-project/Vitro","labels_url":"https://api.github.com/repos/vivo-project/Vitro/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/vivo-project/Vitro/issues/74/comments","events_url":"https://api.github.com/repos/vivo-project/Vitro/issues/74/events","html_url":"https://github.com/vivo-project/Vitro/pull/74","id":324581570,"number":74,"title":"Add check for language files to smoke tests and remove references to …","user":{"login":"gneissone","id":10748475,"avatar_url":"https://avatars0.githubusercontent.com/u/10748475?v=4","gravatar_id":"","url":"https://api.github.com/users/gneissone","html_url":"https://github.com/gneissone","followers_url":"https://api.github.com/users/gneissone/followers","following_url":"https://api.github.com/users/gneissone/following{/other_user}","gists_url":"https://api.github.com/users/gneissone/gists{/gist_id}","starred_url":"https://api.github.com/users/gneissone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gneissone/subscriptions","organizations_url":"https://api.github.com/users/gneissone/orgs","repos_url":"https://api.github.com/users/gneissone/repos","events_url":"https://api.github.com/users/gneissone/events{/privacy}","received_events_url":"https://api.github.com/users/gneissone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-18T23:48:23Z","updated_at":"2018-05-21T17:31:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vivo-project/Vitro/pulls/74","html_url":"https://github.com/vivo-project/Vitro/pull/74","diff_url":"https://github.com/vivo-project/Vitro/pull/74.diff","patch_url":"https://github.com/vivo-project/Vitro/pull/74.patch"},"body":"…build.properties\r\n\r\n**[JIRA Issue VIVO-1501](https://jira.duraspace.org/browse/VIVO-1501)**: ConfigurationPropertiesSmokeTests raises outdated warning on multi-language startup\r\n\r\n# What does this pull request do?\r\nThis PR fixes a problem where a warning was raised during startup anytime you started VIVO and are using selectable internationalization.\r\n\r\n# What's new?\r\nAdds a test to the configuration smoke tests to check if language files exist at the top webapp level that correspond to all the selectable languages. If the correct language files don't exist, a warning is thrown during startup. \r\n\r\nAlso removes a test that used to check if languages were specified in build.properties, which no longer exists and adjusts a test that checked for languages in build.properties to use the languages specified by selectableLanguages in runtime.properties.\r\n\r\n# How should this be tested?\r\nReplicate the issue by deploying VIVO with the vivo-languages package included and adding a couple languages to the selectable languages setting in runtime.properties. A warning is thrown about languages not being included in build.properties (which doesn't exist anymore).\r\n\r\nTry again with this PR. Above warning should not appear.\r\nTry adding a valid language that isn't included in vivo-languages (e.g. fr_FR) to selectableLanguages in runtime.properties and check that warning is raised during startup. You could also try an invalid locale (e.g. fo_BA). The same warning will be raised and you'll also get a warning from LocaleUtils that it's an invalid locale.\r\n\r\n# Additional Notes:\r\nAny additional information that you think would be helpful when reviewing this PR.\r\n\r\nExample:\r\n* Does this change require documentation to be updated? \r\n* Does this change add any new dependencies? \r\n* Does this change require any other modifications to be made to the repository? \r\n* Could this change impact execution of existing code?\r\n\r\n# Interested parties\r\n@KitioFofack \r\n"},"comment":{"url":"https://api.github.com/repos/vivo-project/Vitro/issues/comments/390725146","html_url":"https://github.com/vivo-project/Vitro/pull/74#issuecomment-390725146","issue_url":"https://api.github.com/repos/vivo-project/Vitro/issues/74","id":390725146,"user":{"login":"j2blake","id":1633937,"avatar_url":"https://avatars3.githubusercontent.com/u/1633937?v=4","gravatar_id":"","url":"https://api.github.com/users/j2blake","html_url":"https://github.com/j2blake","followers_url":"https://api.github.com/users/j2blake/followers","following_url":"https://api.github.com/users/j2blake/following{/other_user}","gists_url":"https://api.github.com/users/j2blake/gists{/gist_id}","starred_url":"https://api.github.com/users/j2blake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2blake/subscriptions","organizations_url":"https://api.github.com/users/j2blake/orgs","repos_url":"https://api.github.com/users/j2blake/repos","events_url":"https://api.github.com/users/j2blake/events{/privacy}","received_events_url":"https://api.github.com/users/j2blake/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T17:31:25Z","updated_at":"2018-05-21T17:31:25Z","author_association":"MEMBER","body":"OK, Ben, I’ll keep that in mind.\r\n\r\nJim\r\n\r\nFrom: Ben <notifications@github.com>\r\nReply-To: vivo-project/Vitro <reply@reply.github.com>\r\nDate: Monday, May 21, 2018 at 12:59 PM\r\nTo: vivo-project/Vitro <Vitro@noreply.github.com>\r\nCc: Jim Blake <jeb228@cornell.edu>, Mention <mention@noreply.github.com>\r\nSubject: Re: [vivo-project/Vitro] Add check for language files to smoke tests and remove references to … (#74)\r\n\r\n\r\n@j2blake<https://github.com/j2blake> thanks a bunch for the help, I have committed your suggestions. In the future, feel free to commit your improvements directly to the branch if you want. I'm submitting PRs based off branches of the main Vitro repo, now.\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/vivo-project/Vitro/pull/74#issuecomment-390716322>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABjukcP-eVI1-h4KXSnAFtziyn-tbKP1ks5t0vKGgaJpZM4UFfBi>.\r\n"}}
{"actor":{"display_login":"j2blake"}}