{"action":"created","comment":{"url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/comments/176252718","pull_request_review_id":105915673,"id":176252718,"diff_hunk":"@@ -1,11 +1,15 @@\n \"\"\"For convenience, load test data into Elasticsearch index \"test\".\n \n+Input must be JSON, not CSV. Unlike JSON, CSV values don't have types, so","path":"test/indexer.py","position":3,"original_position":3,"commit_id":"a48727dad3d5696f31dfbf4043a623f282a33daf","original_commit_id":"a48727dad3d5696f31dfbf4043a623f282a33daf","user":{"login":"alahwa","id":6598882,"avatar_url":"https://avatars0.githubusercontent.com/u/6598882?v=4","gravatar_id":"","url":"https://api.github.com/users/alahwa","html_url":"https://github.com/alahwa","followers_url":"https://api.github.com/users/alahwa/followers","following_url":"https://api.github.com/users/alahwa/following{/other_user}","gists_url":"https://api.github.com/users/alahwa/gists{/gist_id}","starred_url":"https://api.github.com/users/alahwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alahwa/subscriptions","organizations_url":"https://api.github.com/users/alahwa/orgs","repos_url":"https://api.github.com/users/alahwa/repos","events_url":"https://api.github.com/users/alahwa/events{/privacy}","received_events_url":"https://api.github.com/users/alahwa/received_events","type":"User","site_admin":false},"body":"Beyond the scope of this test set, how do we expect most indexable to come in? As JSON exported from bigquery?","created_at":"2018-03-21T22:01:34Z","updated_at":"2018-03-21T22:01:44Z","html_url":"https://github.com/DataBiosphere/data-explorer/pull/26#discussion_r176252718","pull_request_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/comments/176252718"},"html":{"href":"https://github.com/DataBiosphere/data-explorer/pull/26#discussion_r176252718"},"pull_request":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26","id":176356828,"html_url":"https://github.com/DataBiosphere/data-explorer/pull/26","diff_url":"https://github.com/DataBiosphere/data-explorer/pull/26.diff","patch_url":"https://github.com/DataBiosphere/data-explorer/pull/26.patch","issue_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/26","number":26,"state":"open","locked":false,"title":" Read facets from facet_fields.csv","user":{"login":"melissachang","id":10929390,"avatar_url":"https://avatars1.githubusercontent.com/u/10929390?v=4","gravatar_id":"","url":"https://api.github.com/users/melissachang","html_url":"https://github.com/melissachang","followers_url":"https://api.github.com/users/melissachang/followers","following_url":"https://api.github.com/users/melissachang/following{/other_user}","gists_url":"https://api.github.com/users/melissachang/gists{/gist_id}","starred_url":"https://api.github.com/users/melissachang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissachang/subscriptions","organizations_url":"https://api.github.com/users/melissachang/orgs","repos_url":"https://api.github.com/users/melissachang/repos","events_url":"https://api.github.com/users/melissachang/events{/privacy}","received_events_url":"https://api.github.com/users/melissachang/received_events","type":"User","site_admin":false},"body":"For test index, for numeric fields, change Elasticsearch index type (string -> long).\r\nRead config files once during lifetime of Flask server, instead of on every request.","created_at":"2018-03-21T00:18:51Z","updated_at":"2018-03-21T22:01:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc8752c3a37082d43f1ac41de5402e79e5d09427","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26/commits","review_comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26/comments","review_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/26/comments","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer/statuses/a48727dad3d5696f31dfbf4043a623f282a33daf","head":{"label":"DataBiosphere:mc/facet-fields","ref":"mc/facet-fields","sha":"a48727dad3d5696f31dfbf4043a623f282a33daf","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":119908069,"name":"data-explorer","full_name":"DataBiosphere/data-explorer","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/data-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/data-explorer","forks_url":"https://api.github.com/repos/DataBiosphere/data-explorer/forks","keys_url":"https://api.github.com/repos/DataBiosphere/data-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/data-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/data-explorer/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/data-explorer/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/data-explorer/events","assignees_url":"https://api.github.com/repos/DataBiosphere/data-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/data-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/data-explorer/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/data-explorer/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/data-explorer/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/data-explorer/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/data-explorer/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/data-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/data-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/data-explorer/merges","archive_url":"https://api.github.com/repos/DataBiosphere/data-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/data-explorer/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/data-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/data-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/data-explorer/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/data-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/deployments","created_at":"2018-02-01T23:53:44Z","updated_at":"2018-03-16T19:18:41Z","pushed_at":"2018-03-21T20:16:12Z","git_url":"git://github.com/DataBiosphere/data-explorer.git","ssh_url":"git@github.com:DataBiosphere/data-explorer.git","clone_url":"https://github.com/DataBiosphere/data-explorer.git","svn_url":"https://github.com/DataBiosphere/data-explorer","homepage":null,"size":176,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"DataBiosphere:master","ref":"master","sha":"4c22c3bc2625776dda6236b5c504ce6e38a38158","user":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":119908069,"name":"data-explorer","full_name":"DataBiosphere/data-explorer","owner":{"login":"DataBiosphere","id":32805087,"avatar_url":"https://avatars0.githubusercontent.com/u/32805087?v=4","gravatar_id":"","url":"https://api.github.com/users/DataBiosphere","html_url":"https://github.com/DataBiosphere","followers_url":"https://api.github.com/users/DataBiosphere/followers","following_url":"https://api.github.com/users/DataBiosphere/following{/other_user}","gists_url":"https://api.github.com/users/DataBiosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/DataBiosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataBiosphere/subscriptions","organizations_url":"https://api.github.com/users/DataBiosphere/orgs","repos_url":"https://api.github.com/users/DataBiosphere/repos","events_url":"https://api.github.com/users/DataBiosphere/events{/privacy}","received_events_url":"https://api.github.com/users/DataBiosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataBiosphere/data-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/DataBiosphere/data-explorer","forks_url":"https://api.github.com/repos/DataBiosphere/data-explorer/forks","keys_url":"https://api.github.com/repos/DataBiosphere/data-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataBiosphere/data-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataBiosphere/data-explorer/teams","hooks_url":"https://api.github.com/repos/DataBiosphere/data-explorer/hooks","issue_events_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/DataBiosphere/data-explorer/events","assignees_url":"https://api.github.com/repos/DataBiosphere/data-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/DataBiosphere/data-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer/tags","blobs_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataBiosphere/data-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/DataBiosphere/data-explorer/languages","stargazers_url":"https://api.github.com/repos/DataBiosphere/data-explorer/stargazers","contributors_url":"https://api.github.com/repos/DataBiosphere/data-explorer/contributors","subscribers_url":"https://api.github.com/repos/DataBiosphere/data-explorer/subscribers","subscription_url":"https://api.github.com/repos/DataBiosphere/data-explorer/subscription","commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataBiosphere/data-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataBiosphere/data-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/DataBiosphere/data-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataBiosphere/data-explorer/merges","archive_url":"https://api.github.com/repos/DataBiosphere/data-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataBiosphere/data-explorer/downloads","issues_url":"https://api.github.com/repos/DataBiosphere/data-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/DataBiosphere/data-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/DataBiosphere/data-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataBiosphere/data-explorer/labels{/name}","releases_url":"https://api.github.com/repos/DataBiosphere/data-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/DataBiosphere/data-explorer/deployments","created_at":"2018-02-01T23:53:44Z","updated_at":"2018-03-16T19:18:41Z","pushed_at":"2018-03-21T20:16:12Z","git_url":"git://github.com/DataBiosphere/data-explorer.git","ssh_url":"git@github.com:DataBiosphere/data-explorer.git","clone_url":"https://github.com/DataBiosphere/data-explorer.git","svn_url":"https://github.com/DataBiosphere/data-explorer","homepage":null,"size":176,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26"},"html":{"href":"https://github.com/DataBiosphere/data-explorer/pull/26"},"issue":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/26"},"comments":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/DataBiosphere/data-explorer/statuses/a48727dad3d5696f31dfbf4043a623f282a33daf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alahwa"}}