{"action":"created","comment":{"url":"https://api.github.com/repos/php-http/message/pulls/comments/229247554","pull_request_review_id":169698561,"id":229247554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI0NzU1NA==","diff_hunk":"@@ -174,15 +179,17 @@ public function isSeekable()\n      */\n     public function rewind()\n     {\n-        throw new \\RuntimeException('Cannot rewind a filtered stream');\n+        @trigger_error('Filtered streams are not seekable. This method will start raising an exception in the next major version');","path":"src/Encoding/FilteredStream.php","position":42,"original_position":42,"commit_id":"e733eb42cd3e667129528ffca4af17462b30cdc9","original_commit_id":"e733eb42cd3e667129528ffca4af17462b30cdc9","user":{"login":"joelwurtz","id":90466,"node_id":"MDQ6VXNlcjkwNDY2","avatar_url":"https://avatars3.githubusercontent.com/u/90466?v=4","gravatar_id":"","url":"https://api.github.com/users/joelwurtz","html_url":"https://github.com/joelwurtz","followers_url":"https://api.github.com/users/joelwurtz/followers","following_url":"https://api.github.com/users/joelwurtz/following{/other_user}","gists_url":"https://api.github.com/users/joelwurtz/gists{/gist_id}","starred_url":"https://api.github.com/users/joelwurtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelwurtz/subscriptions","organizations_url":"https://api.github.com/users/joelwurtz/orgs","repos_url":"https://api.github.com/users/joelwurtz/repos","events_url":"https://api.github.com/users/joelwurtz/events{/privacy}","received_events_url":"https://api.github.com/users/joelwurtz/received_events","type":"User","site_admin":false},"body":"IMHO it's not a deprecation, but rather being nice to people using a buggy behavior","created_at":"2018-10-30T10:19:25Z","updated_at":"2018-10-30T10:19:25Z","html_url":"https://github.com/php-http/message/pull/104#discussion_r229247554","pull_request_url":"https://api.github.com/repos/php-http/message/pulls/104","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/php-http/message/pulls/comments/229247554"},"html":{"href":"https://github.com/php-http/message/pull/104#discussion_r229247554"},"pull_request":{"href":"https://api.github.com/repos/php-http/message/pulls/104"}},"in_reply_to_id":229222140},"pull_request":{"url":"https://api.github.com/repos/php-http/message/pulls/104","id":226819138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODE5MTM4","html_url":"https://github.com/php-http/message/pull/104","diff_url":"https://github.com/php-http/message/pull/104.diff","patch_url":"https://github.com/php-http/message/pull/104.patch","issue_url":"https://api.github.com/repos/php-http/message/issues/104","number":104,"state":"open","locked":false,"title":"trigger_error instead of exceptions","user":{"login":"dbu","id":76576,"node_id":"MDQ6VXNlcjc2NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/76576?v=4","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | reverts BC break of #100\r\n| Deprecations?   | yes\r\n| Related tickets | fixes #100 \r\n| Documentation   | -\r\n| License         | MIT\r\n\r\n\r\n#### What's in this PR?\r\n\r\nUse trigger_error rather than throw exceptions\r\n\r\n\r\n#### Why?\r\n\r\nConsumers SHOULD are supposed to check `isSeekable` and only seek/rewind if that returns true, but it seems they don't all do that. \r\n\r\n\r\n\r\n#### Checklist\r\n\r\n- [x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix\r\n","created_at":"2018-10-30T07:38:54Z","updated_at":"2018-10-30T10:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60282a128b88c96470a69a501eabaebf2336bf78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php-http/message/pulls/104/commits","review_comments_url":"https://api.github.com/repos/php-http/message/pulls/104/comments","review_comment_url":"https://api.github.com/repos/php-http/message/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-http/message/issues/104/comments","statuses_url":"https://api.github.com/repos/php-http/message/statuses/e733eb42cd3e667129528ffca4af17462b30cdc9","head":{"label":"php-http:avoid-bc-break","ref":"avoid-bc-break","sha":"e733eb42cd3e667129528ffca4af17462b30cdc9","user":{"login":"php-http","id":12104859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA0ODU5","avatar_url":"https://avatars3.githubusercontent.com/u/12104859?v=4","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":48317882,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMxNzg4Mg==","name":"message","full_name":"php-http/message","private":false,"owner":{"login":"php-http","id":12104859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA0ODU5","avatar_url":"https://avatars3.githubusercontent.com/u/12104859?v=4","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php-http/message","description":"HTTP Message related tools","fork":false,"url":"https://api.github.com/repos/php-http/message","forks_url":"https://api.github.com/repos/php-http/message/forks","keys_url":"https://api.github.com/repos/php-http/message/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/message/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/message/teams","hooks_url":"https://api.github.com/repos/php-http/message/hooks","issue_events_url":"https://api.github.com/repos/php-http/message/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/message/events","assignees_url":"https://api.github.com/repos/php-http/message/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/message/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/message/tags","blobs_url":"https://api.github.com/repos/php-http/message/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/message/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/message/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/message/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/message/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/message/languages","stargazers_url":"https://api.github.com/repos/php-http/message/stargazers","contributors_url":"https://api.github.com/repos/php-http/message/contributors","subscribers_url":"https://api.github.com/repos/php-http/message/subscribers","subscription_url":"https://api.github.com/repos/php-http/message/subscription","commits_url":"https://api.github.com/repos/php-http/message/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/message/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/message/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/message/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/message/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/message/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/message/merges","archive_url":"https://api.github.com/repos/php-http/message/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/message/downloads","issues_url":"https://api.github.com/repos/php-http/message/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/message/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/message/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/message/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/message/labels{/name}","releases_url":"https://api.github.com/repos/php-http/message/releases{/id}","deployments_url":"https://api.github.com/repos/php-http/message/deployments","created_at":"2015-12-20T11:36:24Z","updated_at":"2018-10-29T16:47:25Z","pushed_at":"2018-10-30T07:41:50Z","git_url":"git://github.com/php-http/message.git","ssh_url":"git@github.com:php-http/message.git","clone_url":"https://github.com/php-http/message.git","svn_url":"https://github.com/php-http/message","homepage":"http://php-http.org","size":153,"stargazers_count":342,"watchers_count":342,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":5,"watchers":342,"default_branch":"master"}},"base":{"label":"php-http:master","ref":"master","sha":"044735dba1a0ae1fcbb56ce4f10974319324c173","user":{"login":"php-http","id":12104859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA0ODU5","avatar_url":"https://avatars3.githubusercontent.com/u/12104859?v=4","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"repo":{"id":48317882,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMxNzg4Mg==","name":"message","full_name":"php-http/message","private":false,"owner":{"login":"php-http","id":12104859,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTA0ODU5","avatar_url":"https://avatars3.githubusercontent.com/u/12104859?v=4","gravatar_id":"","url":"https://api.github.com/users/php-http","html_url":"https://github.com/php-http","followers_url":"https://api.github.com/users/php-http/followers","following_url":"https://api.github.com/users/php-http/following{/other_user}","gists_url":"https://api.github.com/users/php-http/gists{/gist_id}","starred_url":"https://api.github.com/users/php-http/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-http/subscriptions","organizations_url":"https://api.github.com/users/php-http/orgs","repos_url":"https://api.github.com/users/php-http/repos","events_url":"https://api.github.com/users/php-http/events{/privacy}","received_events_url":"https://api.github.com/users/php-http/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php-http/message","description":"HTTP Message related tools","fork":false,"url":"https://api.github.com/repos/php-http/message","forks_url":"https://api.github.com/repos/php-http/message/forks","keys_url":"https://api.github.com/repos/php-http/message/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-http/message/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-http/message/teams","hooks_url":"https://api.github.com/repos/php-http/message/hooks","issue_events_url":"https://api.github.com/repos/php-http/message/issues/events{/number}","events_url":"https://api.github.com/repos/php-http/message/events","assignees_url":"https://api.github.com/repos/php-http/message/assignees{/user}","branches_url":"https://api.github.com/repos/php-http/message/branches{/branch}","tags_url":"https://api.github.com/repos/php-http/message/tags","blobs_url":"https://api.github.com/repos/php-http/message/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-http/message/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-http/message/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-http/message/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-http/message/statuses/{sha}","languages_url":"https://api.github.com/repos/php-http/message/languages","stargazers_url":"https://api.github.com/repos/php-http/message/stargazers","contributors_url":"https://api.github.com/repos/php-http/message/contributors","subscribers_url":"https://api.github.com/repos/php-http/message/subscribers","subscription_url":"https://api.github.com/repos/php-http/message/subscription","commits_url":"https://api.github.com/repos/php-http/message/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-http/message/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-http/message/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-http/message/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-http/message/contents/{+path}","compare_url":"https://api.github.com/repos/php-http/message/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-http/message/merges","archive_url":"https://api.github.com/repos/php-http/message/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-http/message/downloads","issues_url":"https://api.github.com/repos/php-http/message/issues{/number}","pulls_url":"https://api.github.com/repos/php-http/message/pulls{/number}","milestones_url":"https://api.github.com/repos/php-http/message/milestones{/number}","notifications_url":"https://api.github.com/repos/php-http/message/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-http/message/labels{/name}","releases_url":"https://api.github.com/repos/php-http/message/releases{/id}","deployments_url":"https://api.github.com/repos/php-http/message/deployments","created_at":"2015-12-20T11:36:24Z","updated_at":"2018-10-29T16:47:25Z","pushed_at":"2018-10-30T07:41:50Z","git_url":"git://github.com/php-http/message.git","ssh_url":"git@github.com:php-http/message.git","clone_url":"https://github.com/php-http/message.git","svn_url":"https://github.com/php-http/message","homepage":"http://php-http.org","size":153,"stargazers_count":342,"watchers_count":342,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":5,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-http/message/pulls/104"},"html":{"href":"https://github.com/php-http/message/pull/104"},"issue":{"href":"https://api.github.com/repos/php-http/message/issues/104"},"comments":{"href":"https://api.github.com/repos/php-http/message/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/php-http/message/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/php-http/message/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-http/message/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/php-http/message/statuses/e733eb42cd3e667129528ffca4af17462b30cdc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joelwurtz"}}