{"action":"created","comment":{"url":"https://api.github.com/repos/gltf-rs/gltf/pulls/comments/214534064","pull_request_review_id":151614468,"id":214534064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUzNDA2NA==","diff_hunk":"@@ -242,6 +242,11 @@ pub struct Accessor {\n     pub sparse: Option<sparse::Sparse>,\n }\n \n+// Help serde avoid serializing this glTF 2.0 default value.\n+fn is_normalized_default(b: &bool) -> bool {\n+    *b == bool::default()","path":"gltf-json/src/accessor.rs","position":59,"original_position":59,"commit_id":"392162bab22958637abbd234980fa24226dbd9dc","original_commit_id":"392162bab22958637abbd234980fa24226dbd9dc","user":{"login":"alteous","id":8549126,"node_id":"MDQ6VXNlcjg1NDkxMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/8549126?v=4","gravatar_id":"","url":"https://api.github.com/users/alteous","html_url":"https://github.com/alteous","followers_url":"https://api.github.com/users/alteous/followers","following_url":"https://api.github.com/users/alteous/following{/other_user}","gists_url":"https://api.github.com/users/alteous/gists{/gist_id}","starred_url":"https://api.github.com/users/alteous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alteous/subscriptions","organizations_url":"https://api.github.com/users/alteous/orgs","repos_url":"https://api.github.com/users/alteous/repos","events_url":"https://api.github.com/users/alteous/events{/privacy}","received_events_url":"https://api.github.com/users/alteous/received_events","type":"User","site_admin":false},"body":"This is testing if `b` is `false`, right? If so, then `!(*b)`.","created_at":"2018-09-02T09:16:52Z","updated_at":"2018-09-02T09:16:52Z","html_url":"https://github.com/gltf-rs/gltf/pull/191#discussion_r214534064","pull_request_url":"https://api.github.com/repos/gltf-rs/gltf/pulls/191","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/comments/214534064"},"html":{"href":"https://github.com/gltf-rs/gltf/pull/191#discussion_r214534064"},"pull_request":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/191"}},"in_reply_to_id":214507096},"pull_request":{"url":"https://api.github.com/repos/gltf-rs/gltf/pulls/191","id":212357778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzU3Nzc4","html_url":"https://github.com/gltf-rs/gltf/pull/191","diff_url":"https://github.com/gltf-rs/gltf/pull/191.diff","patch_url":"https://github.com/gltf-rs/gltf/pull/191.patch","issue_url":"https://api.github.com/repos/gltf-rs/gltf/issues/191","number":191,"state":"open","locked":false,"title":"Changes to support glTF 2.0 export/serialization","user":{"login":"anderejd","id":3704611,"node_id":"MDQ6VXNlcjM3MDQ2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3704611?v=4","gravatar_id":"","url":"https://api.github.com/users/anderejd","html_url":"https://github.com/anderejd","followers_url":"https://api.github.com/users/anderejd/followers","following_url":"https://api.github.com/users/anderejd/following{/other_user}","gists_url":"https://api.github.com/users/anderejd/gists{/gist_id}","starred_url":"https://api.github.com/users/anderejd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderejd/subscriptions","organizations_url":"https://api.github.com/users/anderejd/orgs","repos_url":"https://api.github.com/users/anderejd/repos","events_url":"https://api.github.com/users/anderejd/events{/privacy}","received_events_url":"https://api.github.com/users/anderejd/received_events","type":"User","site_admin":false},"body":"Solves: #189 \r\n\r\nPlease see the commit messages for the details related to each commit.\r\n\r\nSome background:\r\nI'm implementing glTF 2.0 export based on this crate, not export of imported data, export of in-process generated assets. This requires all related data structures to be correctly instantiated by user code. I have also made optional json properties optional and added `serde(skip_serializing_if` attributes for some simple default values. This helps to verify that my test output is identical to the reference models provided by Khronos. The TRS properties also must be made optional to follow the specification, please see the commit messages and links to the related sections of the spec.\r\n\r\nI have started to implement some builders to make export easier, that aren't ready yet, but I would like to upstream them as well at a later time, they do depend on this PR.\r\n\r\nIf you would like me to make further changes or go about this in a completely different way, please tell me :slightly_smiling_face: ","created_at":"2018-08-31T11:43:45Z","updated_at":"2018-09-02T09:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0699507e1a054157240a133eff3aeee330275be8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gltf-rs/gltf/pulls/191/commits","review_comments_url":"https://api.github.com/repos/gltf-rs/gltf/pulls/191/comments","review_comment_url":"https://api.github.com/repos/gltf-rs/gltf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gltf-rs/gltf/issues/191/comments","statuses_url":"https://api.github.com/repos/gltf-rs/gltf/statuses/392162bab22958637abbd234980fa24226dbd9dc","head":{"label":"anderejd:gltf_export_fixes","ref":"gltf_export_fixes","sha":"392162bab22958637abbd234980fa24226dbd9dc","user":{"login":"anderejd","id":3704611,"node_id":"MDQ6VXNlcjM3MDQ2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3704611?v=4","gravatar_id":"","url":"https://api.github.com/users/anderejd","html_url":"https://github.com/anderejd","followers_url":"https://api.github.com/users/anderejd/followers","following_url":"https://api.github.com/users/anderejd/following{/other_user}","gists_url":"https://api.github.com/users/anderejd/gists{/gist_id}","starred_url":"https://api.github.com/users/anderejd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderejd/subscriptions","organizations_url":"https://api.github.com/users/anderejd/orgs","repos_url":"https://api.github.com/users/anderejd/repos","events_url":"https://api.github.com/users/anderejd/events{/privacy}","received_events_url":"https://api.github.com/users/anderejd/received_events","type":"User","site_admin":false},"repo":{"id":146443441,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0NDM0NDE=","name":"gltf","full_name":"anderejd/gltf","owner":{"login":"anderejd","id":3704611,"node_id":"MDQ6VXNlcjM3MDQ2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3704611?v=4","gravatar_id":"","url":"https://api.github.com/users/anderejd","html_url":"https://github.com/anderejd","followers_url":"https://api.github.com/users/anderejd/followers","following_url":"https://api.github.com/users/anderejd/following{/other_user}","gists_url":"https://api.github.com/users/anderejd/gists{/gist_id}","starred_url":"https://api.github.com/users/anderejd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderejd/subscriptions","organizations_url":"https://api.github.com/users/anderejd/orgs","repos_url":"https://api.github.com/users/anderejd/repos","events_url":"https://api.github.com/users/anderejd/events{/privacy}","received_events_url":"https://api.github.com/users/anderejd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anderejd/gltf","description":"A crate for loading glTF 2.0","fork":true,"url":"https://api.github.com/repos/anderejd/gltf","forks_url":"https://api.github.com/repos/anderejd/gltf/forks","keys_url":"https://api.github.com/repos/anderejd/gltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anderejd/gltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anderejd/gltf/teams","hooks_url":"https://api.github.com/repos/anderejd/gltf/hooks","issue_events_url":"https://api.github.com/repos/anderejd/gltf/issues/events{/number}","events_url":"https://api.github.com/repos/anderejd/gltf/events","assignees_url":"https://api.github.com/repos/anderejd/gltf/assignees{/user}","branches_url":"https://api.github.com/repos/anderejd/gltf/branches{/branch}","tags_url":"https://api.github.com/repos/anderejd/gltf/tags","blobs_url":"https://api.github.com/repos/anderejd/gltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anderejd/gltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anderejd/gltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/anderejd/gltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anderejd/gltf/statuses/{sha}","languages_url":"https://api.github.com/repos/anderejd/gltf/languages","stargazers_url":"https://api.github.com/repos/anderejd/gltf/stargazers","contributors_url":"https://api.github.com/repos/anderejd/gltf/contributors","subscribers_url":"https://api.github.com/repos/anderejd/gltf/subscribers","subscription_url":"https://api.github.com/repos/anderejd/gltf/subscription","commits_url":"https://api.github.com/repos/anderejd/gltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/anderejd/gltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/anderejd/gltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/anderejd/gltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/anderejd/gltf/contents/{+path}","compare_url":"https://api.github.com/repos/anderejd/gltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anderejd/gltf/merges","archive_url":"https://api.github.com/repos/anderejd/gltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anderejd/gltf/downloads","issues_url":"https://api.github.com/repos/anderejd/gltf/issues{/number}","pulls_url":"https://api.github.com/repos/anderejd/gltf/pulls{/number}","milestones_url":"https://api.github.com/repos/anderejd/gltf/milestones{/number}","notifications_url":"https://api.github.com/repos/anderejd/gltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anderejd/gltf/labels{/name}","releases_url":"https://api.github.com/repos/anderejd/gltf/releases{/id}","deployments_url":"https://api.github.com/repos/anderejd/gltf/deployments","created_at":"2018-08-28T12:22:04Z","updated_at":"2018-08-28T12:22:06Z","pushed_at":"2018-08-31T14:39:36Z","git_url":"git://github.com/anderejd/gltf.git","ssh_url":"git@github.com:anderejd/gltf.git","clone_url":"https://github.com/anderejd/gltf.git","svn_url":"https://github.com/anderejd/gltf","homepage":"","size":850,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gltf-rs:master","ref":"master","sha":"01ff00702c0f7dfc51b1db146016108693910623","user":{"login":"gltf-rs","id":31697379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjk3Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/31697379?v=4","gravatar_id":"","url":"https://api.github.com/users/gltf-rs","html_url":"https://github.com/gltf-rs","followers_url":"https://api.github.com/users/gltf-rs/followers","following_url":"https://api.github.com/users/gltf-rs/following{/other_user}","gists_url":"https://api.github.com/users/gltf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gltf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gltf-rs/subscriptions","organizations_url":"https://api.github.com/users/gltf-rs/orgs","repos_url":"https://api.github.com/users/gltf-rs/repos","events_url":"https://api.github.com/users/gltf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gltf-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":73607455,"node_id":"MDEwOlJlcG9zaXRvcnk3MzYwNzQ1NQ==","name":"gltf","full_name":"gltf-rs/gltf","owner":{"login":"gltf-rs","id":31697379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjk3Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/31697379?v=4","gravatar_id":"","url":"https://api.github.com/users/gltf-rs","html_url":"https://github.com/gltf-rs","followers_url":"https://api.github.com/users/gltf-rs/followers","following_url":"https://api.github.com/users/gltf-rs/following{/other_user}","gists_url":"https://api.github.com/users/gltf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gltf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gltf-rs/subscriptions","organizations_url":"https://api.github.com/users/gltf-rs/orgs","repos_url":"https://api.github.com/users/gltf-rs/repos","events_url":"https://api.github.com/users/gltf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gltf-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gltf-rs/gltf","description":"A crate for loading glTF 2.0","fork":false,"url":"https://api.github.com/repos/gltf-rs/gltf","forks_url":"https://api.github.com/repos/gltf-rs/gltf/forks","keys_url":"https://api.github.com/repos/gltf-rs/gltf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gltf-rs/gltf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gltf-rs/gltf/teams","hooks_url":"https://api.github.com/repos/gltf-rs/gltf/hooks","issue_events_url":"https://api.github.com/repos/gltf-rs/gltf/issues/events{/number}","events_url":"https://api.github.com/repos/gltf-rs/gltf/events","assignees_url":"https://api.github.com/repos/gltf-rs/gltf/assignees{/user}","branches_url":"https://api.github.com/repos/gltf-rs/gltf/branches{/branch}","tags_url":"https://api.github.com/repos/gltf-rs/gltf/tags","blobs_url":"https://api.github.com/repos/gltf-rs/gltf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gltf-rs/gltf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gltf-rs/gltf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gltf-rs/gltf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gltf-rs/gltf/statuses/{sha}","languages_url":"https://api.github.com/repos/gltf-rs/gltf/languages","stargazers_url":"https://api.github.com/repos/gltf-rs/gltf/stargazers","contributors_url":"https://api.github.com/repos/gltf-rs/gltf/contributors","subscribers_url":"https://api.github.com/repos/gltf-rs/gltf/subscribers","subscription_url":"https://api.github.com/repos/gltf-rs/gltf/subscription","commits_url":"https://api.github.com/repos/gltf-rs/gltf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gltf-rs/gltf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gltf-rs/gltf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gltf-rs/gltf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gltf-rs/gltf/contents/{+path}","compare_url":"https://api.github.com/repos/gltf-rs/gltf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gltf-rs/gltf/merges","archive_url":"https://api.github.com/repos/gltf-rs/gltf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gltf-rs/gltf/downloads","issues_url":"https://api.github.com/repos/gltf-rs/gltf/issues{/number}","pulls_url":"https://api.github.com/repos/gltf-rs/gltf/pulls{/number}","milestones_url":"https://api.github.com/repos/gltf-rs/gltf/milestones{/number}","notifications_url":"https://api.github.com/repos/gltf-rs/gltf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gltf-rs/gltf/labels{/name}","releases_url":"https://api.github.com/repos/gltf-rs/gltf/releases{/id}","deployments_url":"https://api.github.com/repos/gltf-rs/gltf/deployments","created_at":"2016-11-13T09:55:26Z","updated_at":"2018-08-28T12:14:42Z","pushed_at":"2018-08-31T14:39:37Z","git_url":"git://github.com/gltf-rs/gltf.git","ssh_url":"git@github.com:gltf-rs/gltf.git","clone_url":"https://github.com/gltf-rs/gltf.git","svn_url":"https://github.com/gltf-rs/gltf","homepage":"","size":856,"stargazers_count":72,"watchers_count":72,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":13,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/191"},"html":{"href":"https://github.com/gltf-rs/gltf/pull/191"},"issue":{"href":"https://api.github.com/repos/gltf-rs/gltf/issues/191"},"comments":{"href":"https://api.github.com/repos/gltf-rs/gltf/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gltf-rs/gltf/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/gltf-rs/gltf/statuses/392162bab22958637abbd234980fa24226dbd9dc"}},"author_association":"NONE"}}
{"actor":{"display_login":"alteous"}}