{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments/212712297","pull_request_review_id":149407341,"id":212712297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjcxMjI5Nw==","diff_hunk":"@@ -7,6 +7,8 @@\n \n #include <crm/common/mainloop.h>\n \n+#define MAX_STONITH_HISTORY 100","path":"daemons/fenced/pacemaker-fenced.h","position":4,"original_position":4,"commit_id":"b23a9447ecdbb58d1463a0e7f770cd99c822988f","original_commit_id":"b23a9447ecdbb58d1463a0e7f770cd99c822988f","user":{"login":"wenningerk","id":15136666,"node_id":"MDQ6VXNlcjE1MTM2NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/15136666?v=4","gravatar_id":"","url":"https://api.github.com/users/wenningerk","html_url":"https://github.com/wenningerk","followers_url":"https://api.github.com/users/wenningerk/followers","following_url":"https://api.github.com/users/wenningerk/following{/other_user}","gists_url":"https://api.github.com/users/wenningerk/gists{/gist_id}","starred_url":"https://api.github.com/users/wenningerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenningerk/subscriptions","organizations_url":"https://api.github.com/users/wenningerk/orgs","repos_url":"https://api.github.com/users/wenningerk/repos","events_url":"https://api.github.com/users/wenningerk/events{/privacy}","received_events_url":"https://api.github.com/users/wenningerk/received_events","type":"User","site_admin":false},"body":"With the xml-overhead + possibly long node-names it might be a few 100 bytes per entry but as we have cib-messages >100K that still shouldn't matter.","created_at":"2018-08-24T18:13:04Z","updated_at":"2018-08-24T18:13:05Z","html_url":"https://github.com/ClusterLabs/pacemaker/pull/1569#discussion_r212712297","pull_request_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments/212712297"},"html":{"href":"https://github.com/ClusterLabs/pacemaker/pull/1569#discussion_r212712297"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569"}},"in_reply_to_id":212704221},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569","id":210793088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzkzMDg4","html_url":"https://github.com/ClusterLabs/pacemaker/pull/1569","diff_url":"https://github.com/ClusterLabs/pacemaker/pull/1569.diff","patch_url":"https://github.com/ClusterLabs/pacemaker/pull/1569.patch","issue_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/1569","number":1569,"state":"open","locked":false,"title":"Fix: stonith-history: keep history recorded within boundaries","user":{"login":"wenningerk","id":15136666,"node_id":"MDQ6VXNlcjE1MTM2NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/15136666?v=4","gravatar_id":"","url":"https://api.github.com/users/wenningerk","html_url":"https://github.com/wenningerk","followers_url":"https://api.github.com/users/wenningerk/followers","following_url":"https://api.github.com/users/wenningerk/following{/other_user}","gists_url":"https://api.github.com/users/wenningerk/gists{/gist_id}","starred_url":"https://api.github.com/users/wenningerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenningerk/subscriptions","organizations_url":"https://api.github.com/users/wenningerk/orgs","repos_url":"https://api.github.com/users/wenningerk/repos","events_url":"https://api.github.com/users/wenningerk/events{/privacy}","received_events_url":"https://api.github.com/users/wenningerk/received_events","type":"User","site_admin":false},"body":"for discussion ...\r\n\r\nintroduced stonith_fence_history_trim so that algorithm used there can easily be switched from currently purging of the whole history to e.g. purging of just half of the history or whatever seems convenient.\r\nMAX_STONITH_HISTORY is available globally so that the decision when to trigger the trim (and if it should be cluster-wide or just locally - e.g. if you want it done synchronously before proceeding) is cheap.","created_at":"2018-08-24T16:46:48Z","updated_at":"2018-08-24T18:13:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc37d3d0ee9919bf05ae515ca1b7d9e6d07fa9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/1569/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/b23a9447ecdbb58d1463a0e7f770cd99c822988f","head":{"label":"wenningerk:Crm_mon_add_fence_history_master","ref":"Crm_mon_add_fence_history_master","sha":"b23a9447ecdbb58d1463a0e7f770cd99c822988f","user":{"login":"wenningerk","id":15136666,"node_id":"MDQ6VXNlcjE1MTM2NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/15136666?v=4","gravatar_id":"","url":"https://api.github.com/users/wenningerk","html_url":"https://github.com/wenningerk","followers_url":"https://api.github.com/users/wenningerk/followers","following_url":"https://api.github.com/users/wenningerk/following{/other_user}","gists_url":"https://api.github.com/users/wenningerk/gists{/gist_id}","starred_url":"https://api.github.com/users/wenningerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenningerk/subscriptions","organizations_url":"https://api.github.com/users/wenningerk/orgs","repos_url":"https://api.github.com/users/wenningerk/repos","events_url":"https://api.github.com/users/wenningerk/events{/privacy}","received_events_url":"https://api.github.com/users/wenningerk/received_events","type":"User","site_admin":false},"repo":{"id":58066294,"node_id":"MDEwOlJlcG9zaXRvcnk1ODA2NjI5NA==","name":"pacemaker","full_name":"wenningerk/pacemaker","owner":{"login":"wenningerk","id":15136666,"node_id":"MDQ6VXNlcjE1MTM2NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/15136666?v=4","gravatar_id":"","url":"https://api.github.com/users/wenningerk","html_url":"https://github.com/wenningerk","followers_url":"https://api.github.com/users/wenningerk/followers","following_url":"https://api.github.com/users/wenningerk/following{/other_user}","gists_url":"https://api.github.com/users/wenningerk/gists{/gist_id}","starred_url":"https://api.github.com/users/wenningerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenningerk/subscriptions","organizations_url":"https://api.github.com/users/wenningerk/orgs","repos_url":"https://api.github.com/users/wenningerk/repos","events_url":"https://api.github.com/users/wenningerk/events{/privacy}","received_events_url":"https://api.github.com/users/wenningerk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wenningerk/pacemaker","description":"Pacemaker is an advanced, scalable High-Availability cluster resource manager","fork":true,"url":"https://api.github.com/repos/wenningerk/pacemaker","forks_url":"https://api.github.com/repos/wenningerk/pacemaker/forks","keys_url":"https://api.github.com/repos/wenningerk/pacemaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wenningerk/pacemaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wenningerk/pacemaker/teams","hooks_url":"https://api.github.com/repos/wenningerk/pacemaker/hooks","issue_events_url":"https://api.github.com/repos/wenningerk/pacemaker/issues/events{/number}","events_url":"https://api.github.com/repos/wenningerk/pacemaker/events","assignees_url":"https://api.github.com/repos/wenningerk/pacemaker/assignees{/user}","branches_url":"https://api.github.com/repos/wenningerk/pacemaker/branches{/branch}","tags_url":"https://api.github.com/repos/wenningerk/pacemaker/tags","blobs_url":"https://api.github.com/repos/wenningerk/pacemaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wenningerk/pacemaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wenningerk/pacemaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/wenningerk/pacemaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wenningerk/pacemaker/statuses/{sha}","languages_url":"https://api.github.com/repos/wenningerk/pacemaker/languages","stargazers_url":"https://api.github.com/repos/wenningerk/pacemaker/stargazers","contributors_url":"https://api.github.com/repos/wenningerk/pacemaker/contributors","subscribers_url":"https://api.github.com/repos/wenningerk/pacemaker/subscribers","subscription_url":"https://api.github.com/repos/wenningerk/pacemaker/subscription","commits_url":"https://api.github.com/repos/wenningerk/pacemaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/wenningerk/pacemaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/wenningerk/pacemaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/wenningerk/pacemaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/wenningerk/pacemaker/contents/{+path}","compare_url":"https://api.github.com/repos/wenningerk/pacemaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wenningerk/pacemaker/merges","archive_url":"https://api.github.com/repos/wenningerk/pacemaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wenningerk/pacemaker/downloads","issues_url":"https://api.github.com/repos/wenningerk/pacemaker/issues{/number}","pulls_url":"https://api.github.com/repos/wenningerk/pacemaker/pulls{/number}","milestones_url":"https://api.github.com/repos/wenningerk/pacemaker/milestones{/number}","notifications_url":"https://api.github.com/repos/wenningerk/pacemaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wenningerk/pacemaker/labels{/name}","releases_url":"https://api.github.com/repos/wenningerk/pacemaker/releases{/id}","deployments_url":"https://api.github.com/repos/wenningerk/pacemaker/deployments","created_at":"2016-05-04T16:15:09Z","updated_at":"2018-08-24T12:23:31Z","pushed_at":"2018-08-24T16:41:37Z","git_url":"git://github.com/wenningerk/pacemaker.git","ssh_url":"git@github.com:wenningerk/pacemaker.git","clone_url":"https://github.com/wenningerk/pacemaker.git","svn_url":"https://github.com/wenningerk/pacemaker","homepage":"http://www.clusterlabs.org","size":52383,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"541b4328c1d96e80cebc0b1edbac5693c11caa12","user":{"login":"ClusterLabs","id":574912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NDkxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/574912?v=4","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2304962,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA0OTYy","name":"pacemaker","full_name":"ClusterLabs/pacemaker","owner":{"login":"ClusterLabs","id":574912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NDkxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/574912?v=4","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/pacemaker","description":"Pacemaker is an advanced, scalable High-Availability cluster resource manager","fork":false,"url":"https://api.github.com/repos/ClusterLabs/pacemaker","forks_url":"https://api.github.com/repos/ClusterLabs/pacemaker/forks","keys_url":"https://api.github.com/repos/ClusterLabs/pacemaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/pacemaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/pacemaker/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/pacemaker/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/pacemaker/events","assignees_url":"https://api.github.com/repos/ClusterLabs/pacemaker/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/pacemaker/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/pacemaker/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/pacemaker/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/pacemaker/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/pacemaker/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/pacemaker/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/pacemaker/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterLabs/pacemaker/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/pacemaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/pacemaker/merges","archive_url":"https://api.github.com/repos/ClusterLabs/pacemaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/pacemaker/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/pacemaker/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/pacemaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/pacemaker/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/pacemaker/releases{/id}","deployments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/deployments","created_at":"2011-09-01T00:08:16Z","updated_at":"2018-08-24T16:01:07Z","pushed_at":"2018-08-24T18:10:37Z","git_url":"git://github.com/ClusterLabs/pacemaker.git","ssh_url":"git@github.com:ClusterLabs/pacemaker.git","clone_url":"https://github.com/ClusterLabs/pacemaker.git","svn_url":"https://github.com/ClusterLabs/pacemaker","homepage":"http://www.clusterlabs.org","size":52344,"stargazers_count":547,"watchers_count":547,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":223,"open_issues":10,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569"},"html":{"href":"https://github.com/ClusterLabs/pacemaker/pull/1569"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/1569"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/1569/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/1569/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/b23a9447ecdbb58d1463a0e7f770cd99c822988f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wenningerk"}}