{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/239691960","pull_request_review_id":182546534,"id":239691960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTY5MTk2MA==","diff_hunk":"@@ -4,4 +4,4 @@\n ::\n \n @echo off\n-call %~dp0..\\..\\..\\..\\tools\\generate.cmd hdinsight/resource-manager %*\n+call %~dp0..\\..\\..\\..\\..\\tools\\generate.cmd hdinsight/resource-manager %*","path":"src/SDKs/HDInsight/Management/Management.HDInsight/generated.cmd","position":5,"original_position":5,"commit_id":"46798b5e4278f4450c456f428eff201bf0cc11bc","original_commit_id":"46798b5e4278f4450c456f428eff201bf0cc11bc","user":{"login":"idear1203","id":7024383,"node_id":"MDQ6VXNlcjcwMjQzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7024383?v=4","gravatar_id":"","url":"https://api.github.com/users/idear1203","html_url":"https://github.com/idear1203","followers_url":"https://api.github.com/users/idear1203/followers","following_url":"https://api.github.com/users/idear1203/following{/other_user}","gists_url":"https://api.github.com/users/idear1203/gists{/gist_id}","starred_url":"https://api.github.com/users/idear1203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idear1203/subscriptions","organizations_url":"https://api.github.com/users/idear1203/orgs","repos_url":"https://api.github.com/users/idear1203/repos","events_url":"https://api.github.com/users/idear1203/events{/privacy}","received_events_url":"https://api.github.com/users/idear1203/received_events","type":"User","site_admin":false},"body":"Hi @shahabhijeet , I will rename the .csproj file. But what about the namespace? We want to keep \"Microsoft.Azure.Management.HDInsight\" because it is from original [Hyak based Job SDK](https://github.com/Azure/azure-sdk-for-net/blob/master/src/ResourceManagement/HDInsightJob/HDInsightJob/HDInsightJob.csproj#L9-L10). Does it make sense to you? Could you please give us some suggestions on this topic?","created_at":"2018-12-07T04:19:09Z","updated_at":"2018-12-07T04:19:10Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5061#discussion_r239691960","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/239691960"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5061#discussion_r239691960"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061"}},"in_reply_to_id":239668149},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061","id":235694647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Njk0NjQ3","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/5061","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/5061.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/5061.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5061","number":5061,"state":"open","locked":false,"title":"[HDInsight] - Swagger-based Job SDK","user":{"login":"idear1203","id":7024383,"node_id":"MDQ6VXNlcjcwMjQzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7024383?v=4","gravatar_id":"","url":"https://api.github.com/users/idear1203","html_url":"https://github.com/idear1203","followers_url":"https://api.github.com/users/idear1203/followers","following_url":"https://api.github.com/users/idear1203/following{/other_user}","gists_url":"https://api.github.com/users/idear1203/gists{/gist_id}","starred_url":"https://api.github.com/users/idear1203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idear1203/subscriptions","organizations_url":"https://api.github.com/users/idear1203/orgs","repos_url":"https://api.github.com/users/idear1203/repos","events_url":"https://api.github.com/users/idear1203/events{/privacy}","received_events_url":"https://api.github.com/users/idear1203/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n<!--\r\nPlease add an informative description that covers that changes made by the pull request.\r\n\r\nIf you are regenerating your SDK based off of a new swagger spec, please add the link to the corresponding swagger spec pull request that has been merged in the azure-rest-api-specs repository\r\n-->\r\n### Swagger PR Links\r\n- [Azure/azure-rest-api-specs#4489: [[HDInsight] - Swagger based job SDK](https://github.com/Azure/azure-rest-api-specs/pull/4489)\r\n\r\n### Note\r\n- This change aims to update [the existing Jobs SDK](https://github.com/Azure/azure-sdk-for-net/tree/master/src/ResourceManagement/HDInsightJob) to make it swagger-based\r\n- Move the Management SDK under folder `Management` and make job SDK under folder `DataPlane`\r\n- Update `generated.cmd` of Management SDK to point to the correct path since the Management SDK code path has changed\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n- [x] Please add REST spec PR link to the SDK PR\r\n- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md).**\r\n- [x] **The pull request does not introduce [breaking changes](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md).**\r\n\r\n### [General Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#general-guidelines)\r\n- [x] Title of the pull request is clear and informative.\r\n- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n\r\n### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#testing-guidelines)\r\n- [x] Pull request includes test coverage for the included changes.\r\n\r\n### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#sdk-generation-guidelines)\r\n- [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.\r\n- [x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.\r\n- [x] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK.\r\n","created_at":"2018-12-04T06:32:33Z","updated_at":"2018-12-07T04:19:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"449106ef01ea35eabd9128b8d678ffcc9ac98da8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":495008110,"node_id":"MDU6TGFiZWw0OTUwMDgxMTA=","url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels/Changes%20Requested","name":"Changes Requested","color":"c12d9f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5061/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/46798b5e4278f4450c456f428eff201bf0cc11bc","head":{"label":"idear1203:hdi_support_job_submission","ref":"hdi_support_job_submission","sha":"46798b5e4278f4450c456f428eff201bf0cc11bc","user":{"login":"idear1203","id":7024383,"node_id":"MDQ6VXNlcjcwMjQzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7024383?v=4","gravatar_id":"","url":"https://api.github.com/users/idear1203","html_url":"https://github.com/idear1203","followers_url":"https://api.github.com/users/idear1203/followers","following_url":"https://api.github.com/users/idear1203/following{/other_user}","gists_url":"https://api.github.com/users/idear1203/gists{/gist_id}","starred_url":"https://api.github.com/users/idear1203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idear1203/subscriptions","organizations_url":"https://api.github.com/users/idear1203/orgs","repos_url":"https://api.github.com/users/idear1203/repos","events_url":"https://api.github.com/users/idear1203/events{/privacy}","received_events_url":"https://api.github.com/users/idear1203/received_events","type":"User","site_admin":false},"repo":{"id":130828259,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4MjgyNTk=","name":"azure-sdk-for-net","full_name":"idear1203/azure-sdk-for-net","private":false,"owner":{"login":"idear1203","id":7024383,"node_id":"MDQ6VXNlcjcwMjQzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7024383?v=4","gravatar_id":"","url":"https://api.github.com/users/idear1203","html_url":"https://github.com/idear1203","followers_url":"https://api.github.com/users/idear1203/followers","following_url":"https://api.github.com/users/idear1203/following{/other_user}","gists_url":"https://api.github.com/users/idear1203/gists{/gist_id}","starred_url":"https://api.github.com/users/idear1203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idear1203/subscriptions","organizations_url":"https://api.github.com/users/idear1203/orgs","repos_url":"https://api.github.com/users/idear1203/repos","events_url":"https://api.github.com/users/idear1203/events{/privacy}","received_events_url":"https://api.github.com/users/idear1203/received_events","type":"User","site_admin":false},"html_url":"https://github.com/idear1203/azure-sdk-for-net","description":"Azure Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/idear1203/azure-sdk-for-net","forks_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/idear1203/azure-sdk-for-net/deployments","created_at":"2018-04-24T09:17:09Z","updated_at":"2018-11-21T02:22:56Z","pushed_at":"2018-12-04T06:31:33Z","git_url":"git://github.com/idear1203/azure-sdk-for-net.git","ssh_url":"git@github.com:idear1203/azure-sdk-for-net.git","clone_url":"https://github.com/idear1203/azure-sdk-for-net.git","svn_url":"https://github.com/idear1203/azure-sdk-for-net","homepage":"https://www.visualstudio.com/features/azure-tools-vs","size":266431,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"psSdkJson6"}},"base":{"label":"Azure:psSdkJson6","ref":"psSdkJson6","sha":"dd8380fcfa80e522e3892ca9e139a620d802eabb","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":".NET Libraries for Azure","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2018-12-07T01:58:23Z","pushed_at":"2018-12-07T01:58:18Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"git@github.com:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":269048,"stargazers_count":1239,"watchers_count":1239,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1253,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1253,"open_issues":307,"watchers":1239,"default_branch":"psSdkJson6"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/5061"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5061"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/5061/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/5061/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/46798b5e4278f4450c456f428eff201bf0cc11bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"idear1203"}}