{"action":"created","comment":{"url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments/235952683","pull_request_review_id":177941760,"id":235952683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTk1MjY4Mw==","diff_hunk":"@@ -129,6 +132,12 @@ Component.propTypes = {\n   headerSearchBarModalHeadingText: PropTypes.string,\n   /** The Search Button the Search Bar modal displays. */\n   headerSearchBarSearchButton: PropTypes.node,\n+  /**\n+   * Used internally by `PropertyPageHero` so ignored in the styleguide.\n+   * This prop is used to reduce the height of the Hero for the Search bar.\n+   * @ignore\n+   */\n+  isFixedSearchBarDisplayed: PropTypes.bool,","path":"src/components/collections/Hero/component.js","position":33,"original_position":33,"commit_id":"e57f258668a48ae4ea37a654beb2a8582680301a","original_commit_id":"e57f258668a48ae4ea37a654beb2a8582680301a","user":{"login":"stephenkr","id":25742275,"node_id":"MDQ6VXNlcjI1NzQyMjc1","avatar_url":"https://avatars0.githubusercontent.com/u/25742275?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkr","html_url":"https://github.com/stephenkr","followers_url":"https://api.github.com/users/stephenkr/followers","following_url":"https://api.github.com/users/stephenkr/following{/other_user}","gists_url":"https://api.github.com/users/stephenkr/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkr/subscriptions","organizations_url":"https://api.github.com/users/stephenkr/orgs","repos_url":"https://api.github.com/users/stephenkr/repos","events_url":"https://api.github.com/users/stephenkr/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkr/received_events","type":"User","site_admin":false},"body":"On review, I will move forward and implement the `bottomOffset` you suggested, its a good approach in keeping the components non-reliant of each other. Plus it would reduce the amount of complexity around the implementation of the search bar height.\r\n\r\nUpdating now.","created_at":"2018-11-23T14:15:04Z","updated_at":"2018-11-23T14:15:05Z","html_url":"https://github.com/lodgify/lodgify-ui/pull/447#discussion_r235952683","pull_request_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments/235952683"},"html":{"href":"https://github.com/lodgify/lodgify-ui/pull/447#discussion_r235952683"},"pull_request":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447"}},"in_reply_to_id":235912223},"pull_request":{"url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447","id":233032692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDMyNjky","html_url":"https://github.com/lodgify/lodgify-ui/pull/447","diff_url":"https://github.com/lodgify/lodgify-ui/pull/447.diff","patch_url":"https://github.com/lodgify/lodgify-ui/pull/447.patch","issue_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/447","number":447,"state":"open","locked":false,"title":"TE-1460: Reduce the PropertyPageHero height","user":{"login":"stephenkr","id":25742275,"node_id":"MDQ6VXNlcjI1NzQyMjc1","avatar_url":"https://avatars0.githubusercontent.com/u/25742275?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkr","html_url":"https://github.com/stephenkr","followers_url":"https://api.github.com/users/stephenkr/followers","following_url":"https://api.github.com/users/stephenkr/following{/other_user}","gists_url":"https://api.github.com/users/stephenkr/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkr/subscriptions","organizations_url":"https://api.github.com/users/stephenkr/orgs","repos_url":"https://api.github.com/users/stephenkr/repos","events_url":"https://api.github.com/users/stephenkr/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkr/received_events","type":"User","site_admin":false},"body":"[Related YouTrack issue](https://youtrack.lodgify.net/issue/TE-1460)\r\n\r\n### What **one** thing does this PR do?\r\nReduce the height of the `PropertyPageHero` to accommodate the fixed search bar\r\n\r\n### Any other notes\r\n- I have added an internal prop call `isFixedSearchBarDisplayed`, this is passed along to the `FullBleed` where the class is applied to reduce the height\r\n- I have also cleaned up the `Hero` readme to not document the search bar\r\n\r\n### Preview \r\n- The height of the hero has been reduced by `85px`\r\n<img width=\"1167\" alt=\"screen shot 2018-11-22 at 17 15 30\" src=\"https://user-images.githubusercontent.com/25742275/48914538-027e7f00-ee7c-11e8-9a06-e0345f83e007.png\">\r\n\r\n","created_at":"2018-11-22T16:30:21Z","updated_at":"2018-11-23T14:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1be33f3c34fd269b531d9c3affab3f7e76c6608c","assignee":{"login":"stephenkr","id":25742275,"node_id":"MDQ6VXNlcjI1NzQyMjc1","avatar_url":"https://avatars0.githubusercontent.com/u/25742275?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkr","html_url":"https://github.com/stephenkr","followers_url":"https://api.github.com/users/stephenkr/followers","following_url":"https://api.github.com/users/stephenkr/following{/other_user}","gists_url":"https://api.github.com/users/stephenkr/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkr/subscriptions","organizations_url":"https://api.github.com/users/stephenkr/orgs","repos_url":"https://api.github.com/users/stephenkr/repos","events_url":"https://api.github.com/users/stephenkr/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkr/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephenkr","id":25742275,"node_id":"MDQ6VXNlcjI1NzQyMjc1","avatar_url":"https://avatars0.githubusercontent.com/u/25742275?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkr","html_url":"https://github.com/stephenkr","followers_url":"https://api.github.com/users/stephenkr/followers","following_url":"https://api.github.com/users/stephenkr/following{/other_user}","gists_url":"https://api.github.com/users/stephenkr/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkr/subscriptions","organizations_url":"https://api.github.com/users/stephenkr/orgs","repos_url":"https://api.github.com/users/stephenkr/repos","events_url":"https://api.github.com/users/stephenkr/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447/commits","review_comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447/comments","review_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/447/comments","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/e57f258668a48ae4ea37a654beb2a8582680301a","head":{"label":"lodgify:TE-1460-reduce-property-hero-height","ref":"TE-1460-reduce-property-hero-height","sha":"e57f258668a48ae4ea37a654beb2a8582680301a","user":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"repo":{"id":122183769,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxODM3Njk=","name":"lodgify-ui","full_name":"lodgify/lodgify-ui","private":false,"owner":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lodgify/lodgify-ui","description":"React components for building amazing websites with Lodgify","fork":false,"url":"https://api.github.com/repos/lodgify/lodgify-ui","forks_url":"https://api.github.com/repos/lodgify/lodgify-ui/forks","keys_url":"https://api.github.com/repos/lodgify/lodgify-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lodgify/lodgify-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lodgify/lodgify-ui/teams","hooks_url":"https://api.github.com/repos/lodgify/lodgify-ui/hooks","issue_events_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/events{/number}","events_url":"https://api.github.com/repos/lodgify/lodgify-ui/events","assignees_url":"https://api.github.com/repos/lodgify/lodgify-ui/assignees{/user}","branches_url":"https://api.github.com/repos/lodgify/lodgify-ui/branches{/branch}","tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/tags","blobs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/lodgify/lodgify-ui/languages","stargazers_url":"https://api.github.com/repos/lodgify/lodgify-ui/stargazers","contributors_url":"https://api.github.com/repos/lodgify/lodgify-ui/contributors","subscribers_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscribers","subscription_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscription","commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/lodgify/lodgify-ui/contents/{+path}","compare_url":"https://api.github.com/repos/lodgify/lodgify-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lodgify/lodgify-ui/merges","archive_url":"https://api.github.com/repos/lodgify/lodgify-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lodgify/lodgify-ui/downloads","issues_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues{/number}","pulls_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/lodgify/lodgify-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/lodgify/lodgify-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lodgify/lodgify-ui/labels{/name}","releases_url":"https://api.github.com/repos/lodgify/lodgify-ui/releases{/id}","deployments_url":"https://api.github.com/repos/lodgify/lodgify-ui/deployments","created_at":"2018-02-20T10:27:00Z","updated_at":"2018-11-23T13:52:24Z","pushed_at":"2018-11-23T13:57:44Z","git_url":"git://github.com/lodgify/lodgify-ui.git","ssh_url":"git@github.com:lodgify/lodgify-ui.git","clone_url":"https://github.com/lodgify/lodgify-ui.git","svn_url":"https://github.com/lodgify/lodgify-ui","homepage":"https://lodgify.github.io/lodgify-ui/","size":14470,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":11,"default_branch":"production"}},"base":{"label":"lodgify:production","ref":"production","sha":"01c27e71ca3a6e12d5752d27d1671fdc4becf2ae","user":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"repo":{"id":122183769,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxODM3Njk=","name":"lodgify-ui","full_name":"lodgify/lodgify-ui","private":false,"owner":{"login":"lodgify","id":7839242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MzkyNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7839242?v=4","gravatar_id":"","url":"https://api.github.com/users/lodgify","html_url":"https://github.com/lodgify","followers_url":"https://api.github.com/users/lodgify/followers","following_url":"https://api.github.com/users/lodgify/following{/other_user}","gists_url":"https://api.github.com/users/lodgify/gists{/gist_id}","starred_url":"https://api.github.com/users/lodgify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lodgify/subscriptions","organizations_url":"https://api.github.com/users/lodgify/orgs","repos_url":"https://api.github.com/users/lodgify/repos","events_url":"https://api.github.com/users/lodgify/events{/privacy}","received_events_url":"https://api.github.com/users/lodgify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lodgify/lodgify-ui","description":"React components for building amazing websites with Lodgify","fork":false,"url":"https://api.github.com/repos/lodgify/lodgify-ui","forks_url":"https://api.github.com/repos/lodgify/lodgify-ui/forks","keys_url":"https://api.github.com/repos/lodgify/lodgify-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lodgify/lodgify-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lodgify/lodgify-ui/teams","hooks_url":"https://api.github.com/repos/lodgify/lodgify-ui/hooks","issue_events_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/events{/number}","events_url":"https://api.github.com/repos/lodgify/lodgify-ui/events","assignees_url":"https://api.github.com/repos/lodgify/lodgify-ui/assignees{/user}","branches_url":"https://api.github.com/repos/lodgify/lodgify-ui/branches{/branch}","tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/tags","blobs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/lodgify/lodgify-ui/languages","stargazers_url":"https://api.github.com/repos/lodgify/lodgify-ui/stargazers","contributors_url":"https://api.github.com/repos/lodgify/lodgify-ui/contributors","subscribers_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscribers","subscription_url":"https://api.github.com/repos/lodgify/lodgify-ui/subscription","commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/lodgify/lodgify-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/lodgify/lodgify-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/lodgify/lodgify-ui/contents/{+path}","compare_url":"https://api.github.com/repos/lodgify/lodgify-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lodgify/lodgify-ui/merges","archive_url":"https://api.github.com/repos/lodgify/lodgify-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lodgify/lodgify-ui/downloads","issues_url":"https://api.github.com/repos/lodgify/lodgify-ui/issues{/number}","pulls_url":"https://api.github.com/repos/lodgify/lodgify-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/lodgify/lodgify-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/lodgify/lodgify-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lodgify/lodgify-ui/labels{/name}","releases_url":"https://api.github.com/repos/lodgify/lodgify-ui/releases{/id}","deployments_url":"https://api.github.com/repos/lodgify/lodgify-ui/deployments","created_at":"2018-02-20T10:27:00Z","updated_at":"2018-11-23T13:52:24Z","pushed_at":"2018-11-23T13:57:44Z","git_url":"git://github.com/lodgify/lodgify-ui.git","ssh_url":"git@github.com:lodgify/lodgify-ui.git","clone_url":"https://github.com/lodgify/lodgify-ui.git","svn_url":"https://github.com/lodgify/lodgify-ui","homepage":"https://lodgify.github.io/lodgify-ui/","size":14470,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":11,"default_branch":"production"}},"_links":{"self":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447"},"html":{"href":"https://github.com/lodgify/lodgify-ui/pull/447"},"issue":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/issues/447"},"comments":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/lodgify/lodgify-ui/statuses/e57f258668a48ae4ea37a654beb2a8582680301a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stephenkr"}}