{"action":"created","issue":{"url":"https://api.github.com/repos/jgm/pandoc/issues/4491","repository_url":"https://api.github.com/repos/jgm/pandoc","labels_url":"https://api.github.com/repos/jgm/pandoc/issues/4491/labels{/name}","comments_url":"https://api.github.com/repos/jgm/pandoc/issues/4491/comments","events_url":"https://api.github.com/repos/jgm/pandoc/issues/4491/events","html_url":"https://github.com/jgm/pandoc/pull/4491","id":308237628,"number":4491,"title":"Several fixes for EPUB footnotes","user":{"login":"Porges","id":12575,"avatar_url":"https://avatars3.githubusercontent.com/u/12575?v=4","gravatar_id":"","url":"https://api.github.com/users/Porges","html_url":"https://github.com/Porges","followers_url":"https://api.github.com/users/Porges/followers","following_url":"https://api.github.com/users/Porges/following{/other_user}","gists_url":"https://api.github.com/users/Porges/gists{/gist_id}","starred_url":"https://api.github.com/users/Porges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Porges/subscriptions","organizations_url":"https://api.github.com/users/Porges/orgs","repos_url":"https://api.github.com/users/Porges/repos","events_url":"https://api.github.com/users/Porges/events{/privacy}","received_events_url":"https://api.github.com/users/Porges/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-24T07:48:19Z","updated_at":"2018-03-25T21:07:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jgm/pandoc/pulls/4491","html_url":"https://github.com/jgm/pandoc/pull/4491","diff_url":"https://github.com/jgm/pandoc/pull/4491.diff","patch_url":"https://github.com/jgm/pandoc/pull/4491.patch"},"body":"1. Footnotes section should have `epub:type=\"footnotes\"` on it. This fixes #4489.\r\n2. The footnote back-link must be at the start of the footnote. The current positioning at the end causes two problems on Kindles (those that have the pop-over footnote functionality), which are fixed by changing this:\r\n    1. Several footnotes run together and appear as one when clicking on a footnote.\r\n    2. Some footnotes do not work at all with pop-over and the link will jump you directly to the footnote section.\r\n3. For EPUB3, Amazon \"strongly recommends\" the use of `aside` elements for footnotes (and this is also the recommendation from Apple), so if we're using EPUB3 or HTML5 then output `aside` instead of `ol`/`li` for footnotes. Additionally, for EPUB2 we will output `div` instead of `ol`/`li`, because (due to the change for back-links), the footnotes are already numbered (and this makes the output consistent with EPUB3).\r\n\r\nHere's a before and after showing the problem that is fixed by change 2:\r\n\r\n![Multiple footnotes run together](https://user-images.githubusercontent.com/12575/37863166-db0fda6e-2fad-11e8-9c2e-a06e161a0a44.jpg)\r\n\r\n ![Single footnote at a time](https://user-images.githubusercontent.com/12575/37863167-e17e3a58-2fad-11e8-9b12-4a40bc5fd6c1.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/jgm/pandoc/issues/comments/376003580","html_url":"https://github.com/jgm/pandoc/pull/4491#issuecomment-376003580","issue_url":"https://api.github.com/repos/jgm/pandoc/issues/4491","id":376003580,"user":{"login":"mb21","id":157497,"avatar_url":"https://avatars0.githubusercontent.com/u/157497?v=4","gravatar_id":"","url":"https://api.github.com/users/mb21","html_url":"https://github.com/mb21","followers_url":"https://api.github.com/users/mb21/followers","following_url":"https://api.github.com/users/mb21/following{/other_user}","gists_url":"https://api.github.com/users/mb21/gists{/gist_id}","starred_url":"https://api.github.com/users/mb21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mb21/subscriptions","organizations_url":"https://api.github.com/users/mb21/orgs","repos_url":"https://api.github.com/users/mb21/repos","events_url":"https://api.github.com/users/mb21/events{/privacy}","received_events_url":"https://api.github.com/users/mb21/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T21:07:51Z","updated_at":"2018-03-25T21:07:51Z","author_association":"COLLABORATOR","body":"Maybe let's try to keep the discussion to one place (I guess this pull request since we're already here)...\r\n\r\nP.S. I guess it would make most sense if the position/display of the backlink could be overridden using CSS..."}}
{"actor":{"display_login":"mb21"}}