{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/239809176","pull_request_review_id":182694674,"id":239809176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTgwOTE3Ng==","diff_hunk":"@@ -159,6 +164,9 @@ class QUICK_EXPORT QgsQuickPositionKit : public QObject\n     //! \\copydoc QgsQuickPositionKit::simulatePositionLongLatRad\n     void setSimulatePositionLongLatRad( const QVector<double> &simulatePositionLongLatRad );\n \n+    //! \\copydoc QgsQuickPositionKit::source","path":"src/quickgui/qgsquickpositionkit.h","position":null,"original_position":16,"commit_id":"e0d3e90eebedad9cfdab41059cb62e00c38808ad","original_commit_id":"d943421ed6fe68e0a01a5b1637e03af11581d5d5","user":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"body":"Actually, one thing that would be very valuable for an API doc is about the lifetime and ownership of the pointer and that it may only be used until the sourceChanged signal has been emitted.","created_at":"2018-12-07T13:37:14Z","updated_at":"2018-12-07T13:37:14Z","html_url":"https://github.com/qgis/QGIS/pull/8622#discussion_r239809176","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/8622","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/239809176"},"html":{"href":"https://github.com/qgis/QGIS/pull/8622#discussion_r239809176"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8622"}},"in_reply_to_id":239800232},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/8622","id":236524514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTI0NTE0","html_url":"https://github.com/qgis/QGIS/pull/8622","diff_url":"https://github.com/qgis/QGIS/pull/8622.diff","patch_url":"https://github.com/qgis/QGIS/pull/8622.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/8622","number":8622,"state":"open","locked":false,"title":"Access of QGeoPositionInfoSource from QgsQuickPostionKit","user":{"login":"sklencar","id":6735606,"node_id":"MDQ6VXNlcjY3MzU2MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6735606?v=4","gravatar_id":"","url":"https://api.github.com/users/sklencar","html_url":"https://github.com/sklencar","followers_url":"https://api.github.com/users/sklencar/followers","following_url":"https://api.github.com/users/sklencar/following{/other_user}","gists_url":"https://api.github.com/users/sklencar/gists{/gist_id}","starred_url":"https://api.github.com/users/sklencar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklencar/subscriptions","organizations_url":"https://api.github.com/users/sklencar/orgs","repos_url":"https://api.github.com/users/sklencar/repos","events_url":"https://api.github.com/users/sklencar/events{/privacy}","received_events_url":"https://api.github.com/users/sklencar/received_events","type":"User","site_admin":false},"body":"Added function to access QGeoPositionInfoSource out of QgsQuickPostionKit context.\r\n\r\nNow source's update functions or other properties can be used (e.g useful when switching GPS update on/off in case of saving battery or see preferred positioning method).","created_at":"2018-12-06T13:10:18Z","updated_at":"2018-12-07T13:37:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60b359eaffc41d4f162f795cf18700c337759684","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/8622/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/8622/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/8622/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/e0d3e90eebedad9cfdab41059cb62e00c38808ad","head":{"label":"PeterPetrik:feature/access_position_kit_source","ref":"feature/access_position_kit_source","sha":"e0d3e90eebedad9cfdab41059cb62e00c38808ad","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"repo":{"id":38666026,"node_id":"MDEwOlJlcG9zaXRvcnkzODY2NjAyNg==","name":"QGIS","full_name":"PeterPetrik/QGIS","private":false,"owner":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PeterPetrik/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/PeterPetrik/QGIS","forks_url":"https://api.github.com/repos/PeterPetrik/QGIS/forks","keys_url":"https://api.github.com/repos/PeterPetrik/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterPetrik/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterPetrik/QGIS/teams","hooks_url":"https://api.github.com/repos/PeterPetrik/QGIS/hooks","issue_events_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/PeterPetrik/QGIS/events","assignees_url":"https://api.github.com/repos/PeterPetrik/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/PeterPetrik/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/tags","blobs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterPetrik/QGIS/languages","stargazers_url":"https://api.github.com/repos/PeterPetrik/QGIS/stargazers","contributors_url":"https://api.github.com/repos/PeterPetrik/QGIS/contributors","subscribers_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscribers","subscription_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscription","commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterPetrik/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/PeterPetrik/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterPetrik/QGIS/merges","archive_url":"https://api.github.com/repos/PeterPetrik/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterPetrik/QGIS/downloads","issues_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterPetrik/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterPetrik/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterPetrik/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/PeterPetrik/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/PeterPetrik/QGIS/deployments","created_at":"2015-07-07T05:24:42Z","updated_at":"2018-12-03T08:55:29Z","pushed_at":"2018-12-07T13:13:06Z","git_url":"git://github.com/PeterPetrik/QGIS.git","ssh_url":"git@github.com:PeterPetrik/QGIS.git","clone_url":"https://github.com/PeterPetrik/QGIS.git","svn_url":"https://github.com/PeterPetrik/QGIS","homepage":"http://qgis.org","size":1417435,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"31b82de5e3a8d8e611b1f326f95f28122df27703","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","private":false,"owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-12-07T08:36:24Z","pushed_at":"2018-12-07T13:13:08Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1491195,"stargazers_count":2358,"watchers_count":2358,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1359,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1359,"open_issues":23,"watchers":2358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8622"},"html":{"href":"https://github.com/qgis/QGIS/pull/8622"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8622"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8622/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8622/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8622/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/e0d3e90eebedad9cfdab41059cb62e00c38808ad"}},"author_association":"NONE"}}
{"actor":{"display_login":"m-kuhn"}}