{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/166775498","pull_request_review_id":94893255,"id":166775498,"diff_hunk":"@@ -907,6 +907,65 @@ public override IOperation VisitWhileLoop(IWhileLoopOperation operation, int? ca\n             return null;\n         }\n \n+        public override IOperation VisitVariableDeclarationGroup(IVariableDeclarationGroupOperation operation, int? captureIdForResult)\n+        {\n+            // We erase variable declarations from the control flow graph, as variable lifetime information is contained in a parallel data structure.\n+            foreach (var declaration in operation.Declarations)\n+            {\n+                VisitVariableDeclaration(declaration, captureIdForResult);\n+            }\n+\n+            return null;\n+        }\n+\n+        public override IOperation VisitVariableDeclaration(IVariableDeclarationOperation operation, int? captureIdForResult)\n+        {\n+            foreach (var declarator in operation.Declarators)","path":"src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs","position":44,"original_position":44,"commit_id":"43561df0b021508ede099c7dd319f22f8d27ee0e","original_commit_id":"43561df0b021508ede099c7dd319f22f8d27ee0e","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":">var [](start = 21, length = 3)\r\n\r\nPlease no ```var```s. The type must be spelled out unless it is spelled out explicitly in the initializer, which is not present here.","created_at":"2018-02-07T22:22:21Z","updated_at":"2018-02-07T22:22:21Z","html_url":"https://github.com/dotnet/roslyn/pull/24692#discussion_r166775498","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24692","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/166775498"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24692#discussion_r166775498"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24692"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/24692","id":167777425,"html_url":"https://github.com/dotnet/roslyn/pull/24692","diff_url":"https://github.com/dotnet/roslyn/pull/24692.diff","patch_url":"https://github.com/dotnet/roslyn/pull/24692.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/24692","number":24692,"state":"open","locked":false,"title":"Variable declaration","user":{"login":"333fred","id":2371880,"avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"body":"Adds support for IVariableDeclarationGroup, IVariableDeclaration, and IVariableDeclarator to control flow graph generation.","created_at":"2018-02-07T18:49:19Z","updated_at":"2018-02-07T22:22:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0b2560f580a8e4b7322b925259e59bb7baec47c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24692/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24692/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/24692/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/43561df0b021508ede099c7dd319f22f8d27ee0e","head":{"label":"333fred:variable-declaration","ref":"variable-declaration","sha":"43561df0b021508ede099c7dd319f22f8d27ee0e","user":{"login":"333fred","id":2371880,"avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"repo":{"id":70755125,"name":"roslyn","full_name":"333fred/roslyn","owner":{"login":"333fred","id":2371880,"avatar_url":"https://avatars0.githubusercontent.com/u/2371880?v=4","gravatar_id":"","url":"https://api.github.com/users/333fred","html_url":"https://github.com/333fred","followers_url":"https://api.github.com/users/333fred/followers","following_url":"https://api.github.com/users/333fred/following{/other_user}","gists_url":"https://api.github.com/users/333fred/gists{/gist_id}","starred_url":"https://api.github.com/users/333fred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/333fred/subscriptions","organizations_url":"https://api.github.com/users/333fred/orgs","repos_url":"https://api.github.com/users/333fred/repos","events_url":"https://api.github.com/users/333fred/events{/privacy}","received_events_url":"https://api.github.com/users/333fred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/333fred/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/333fred/roslyn","forks_url":"https://api.github.com/repos/333fred/roslyn/forks","keys_url":"https://api.github.com/repos/333fred/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/333fred/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/333fred/roslyn/teams","hooks_url":"https://api.github.com/repos/333fred/roslyn/hooks","issue_events_url":"https://api.github.com/repos/333fred/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/333fred/roslyn/events","assignees_url":"https://api.github.com/repos/333fred/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/333fred/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/333fred/roslyn/tags","blobs_url":"https://api.github.com/repos/333fred/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/333fred/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/333fred/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/333fred/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/333fred/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/333fred/roslyn/languages","stargazers_url":"https://api.github.com/repos/333fred/roslyn/stargazers","contributors_url":"https://api.github.com/repos/333fred/roslyn/contributors","subscribers_url":"https://api.github.com/repos/333fred/roslyn/subscribers","subscription_url":"https://api.github.com/repos/333fred/roslyn/subscription","commits_url":"https://api.github.com/repos/333fred/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/333fred/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/333fred/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/333fred/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/333fred/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/333fred/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/333fred/roslyn/merges","archive_url":"https://api.github.com/repos/333fred/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/333fred/roslyn/downloads","issues_url":"https://api.github.com/repos/333fred/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/333fred/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/333fred/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/333fred/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/333fred/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/333fred/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/333fred/roslyn/deployments","created_at":"2016-10-13T01:01:16Z","updated_at":"2017-11-07T06:26:38Z","pushed_at":"2018-02-07T22:10:37Z","git_url":"git://github.com/333fred/roslyn.git","ssh_url":"git@github.com:333fred/roslyn.git","clone_url":"https://github.com/333fred/roslyn.git","svn_url":"https://github.com/333fred/roslyn","homepage":"","size":264147,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"dotnet:features/dataflow","ref":"features/dataflow","sha":"28de8cc4522d823b6c1723dd55d3057060c11efe","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-02-07T22:19:44Z","pushed_at":"2018-02-07T22:14:08Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":280771,"stargazers_count":8807,"watchers_count":8807,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2128,"mirror_url":null,"archived":false,"open_issues_count":4371,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2128,"open_issues":4371,"watchers":8807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24692"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24692"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24692"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24692/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24692/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24692/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/43561df0b021508ede099c7dd319f22f8d27ee0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AlekseyTs"}}