{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/208562402","pull_request_review_id":144390239,"id":208562402,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODU2MjQwMg==","diff_hunk":"@@ -1592,19 +1576,23 @@ func (e UpdateStateChangeError) Error() string { return e.msg }\n // if there was an issue triggering policy updates for the given endpoint,\n // or if endpoint regeneration was unable to be triggered.\n func (e *Endpoint) Update(owner Owner, cfg *models.EndpointConfigurationSpec) error {\n-\te.Mutex.Lock()\n+\tvar lockerr error","path":"pkg/endpoint/endpoint.go","position":146,"original_position":146,"commit_id":"0503862611536968f52925863745242edfb9172f","original_commit_id":"0503862611536968f52925863745242edfb9172f","user":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"body":"Why do use `lockerr` instead of the standard `err` convention?","created_at":"2018-08-08T12:33:32Z","updated_at":"2018-08-08T12:38:40Z","html_url":"https://github.com/cilium/cilium/pull/5116#discussion_r208562402","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/5116","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/208562402"},"html":{"href":"https://github.com/cilium/cilium/pull/5116#discussion_r208562402"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5116"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5116","id":206683373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjgzMzcz","html_url":"https://github.com/cilium/cilium/pull/5116","diff_url":"https://github.com/cilium/cilium/pull/5116.diff","patch_url":"https://github.com/cilium/cilium/pull/5116.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5116","number":5116,"state":"open","locked":false,"title":"Hide pkg/endpoint/Endpoint.Mutex behind wrappers","user":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"body":"fixes #4997\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5116)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-08-07T12:37:37Z","updated_at":"2018-08-08T12:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c640fd6fed89cb3cc86ae1cb77be3a50c67f837a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"proxy","id":2519788,"node_id":"MDQ6VGVhbTI1MTk3ODg=","slug":"proxy","description":"Proxy layer","privacy":"closed","url":"https://api.github.com/teams/2519788","members_url":"https://api.github.com/teams/2519788/members{/member}","repositories_url":"https://api.github.com/teams/2519788/repos","permission":"pull"},{"name":"endpoint","id":2519798,"node_id":"MDQ6VGVhbTI1MTk3OTg=","slug":"endpoint","description":"Endpoint abstraction","privacy":"closed","url":"https://api.github.com/teams/2519798","members_url":"https://api.github.com/teams/2519798/members{/member}","repositories_url":"https://api.github.com/teams/2519798/repos","permission":"pull"}],"labels":[{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/5116/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/5116/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5116/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/0503862611536968f52925863745242edfb9172f","head":{"label":"nebril:endpoint-lock-check-for-deletion","ref":"endpoint-lock-check-for-deletion","sha":"0503862611536968f52925863745242edfb9172f","user":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"repo":{"id":103055444,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMwNTU0NDQ=","name":"cilium","full_name":"nebril/cilium","owner":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nebril/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/nebril/cilium","forks_url":"https://api.github.com/repos/nebril/cilium/forks","keys_url":"https://api.github.com/repos/nebril/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nebril/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nebril/cilium/teams","hooks_url":"https://api.github.com/repos/nebril/cilium/hooks","issue_events_url":"https://api.github.com/repos/nebril/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/nebril/cilium/events","assignees_url":"https://api.github.com/repos/nebril/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/nebril/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/nebril/cilium/tags","blobs_url":"https://api.github.com/repos/nebril/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nebril/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nebril/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/nebril/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nebril/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/nebril/cilium/languages","stargazers_url":"https://api.github.com/repos/nebril/cilium/stargazers","contributors_url":"https://api.github.com/repos/nebril/cilium/contributors","subscribers_url":"https://api.github.com/repos/nebril/cilium/subscribers","subscription_url":"https://api.github.com/repos/nebril/cilium/subscription","commits_url":"https://api.github.com/repos/nebril/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/nebril/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/nebril/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/nebril/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/nebril/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/nebril/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nebril/cilium/merges","archive_url":"https://api.github.com/repos/nebril/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nebril/cilium/downloads","issues_url":"https://api.github.com/repos/nebril/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/nebril/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/nebril/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/nebril/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nebril/cilium/labels{/name}","releases_url":"https://api.github.com/repos/nebril/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/nebril/cilium/deployments","created_at":"2017-09-10T19:21:23Z","updated_at":"2017-09-10T19:21:26Z","pushed_at":"2018-08-08T12:31:41Z","git_url":"git://github.com/nebril/cilium.git","ssh_url":"git@github.com:nebril/cilium.git","clone_url":"https://github.com/nebril/cilium.git","svn_url":"https://github.com/nebril/cilium","homepage":"","size":53791,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"b3e6fa86871e9e9a53d5411003d67dc56cf9e85b","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-08-08T12:15:13Z","pushed_at":"2018-08-08T12:31:58Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":56210,"stargazers_count":2647,"watchers_count":2647,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":502,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":236,"open_issues":502,"watchers":2647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5116"},"html":{"href":"https://github.com/cilium/cilium/pull/5116"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/5116"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/5116/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5116/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5116/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/0503862611536968f52925863745242edfb9172f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tgraf"}}