{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/215864199","pull_request_review_id":153224075,"id":215864199,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTg2NDE5OQ==","diff_hunk":"@@ -220,11 +222,12 @@ func (m *Broadcaster) distribute(event Event) {\n \tm.lock.Lock()\n \tdefer m.lock.Unlock()\n \tif m.fullChannelBehavior == DropIfChannelFull {\n-\t\tfor _, w := range m.watchers {\n+\t\tfor i, w := range m.watchers {\n \t\t\tselect {\n \t\t\tcase w.result <- event:\n \t\t\tcase <-w.stopped:\n \t\t\tdefault: // Don't block if the event can't be queued.\n+\t\t\t\tglog.Warningf(\"Dropping event '%#v' (result channel of watcher %d is full)\", event, i)","path":"staging/src/k8s.io/apimachinery/pkg/watch/mux.go","position":19,"original_position":19,"commit_id":"64b4b66387fb336d37334d3b4613ba11793fd42f","original_commit_id":"64b4b66387fb336d37334d3b4613ba11793fd42f","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"body":"> how about changing glog.Warningf to glog.V(4).Infof?\r\n\r\ni suppose even with a 10 verbosity, it'll still be flooding extremely.  \r\n\r\n/cc @liggitt \r\n","created_at":"2018-09-07T07:05:23Z","updated_at":"2018-09-07T07:05:23Z","html_url":"https://github.com/kubernetes/kubernetes/pull/68393#discussion_r215864199","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/215864199"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68393#discussion_r215864199"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393"}},"in_reply_to_id":215845248},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393","id":213802385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODAyMzg1","html_url":"https://github.com/kubernetes/kubernetes/pull/68393","diff_url":"https://github.com/kubernetes/kubernetes/pull/68393.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68393.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68393","number":68393,"state":"open","locked":false,"title":"print glog warn message when kubernetes events get dropped at the client side","user":{"login":"bruceauyeung","id":1210201,"node_id":"MDQ6VXNlcjEyMTAyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1210201?v=4","gravatar_id":"","url":"https://api.github.com/users/bruceauyeung","html_url":"https://github.com/bruceauyeung","followers_url":"https://api.github.com/users/bruceauyeung/followers","following_url":"https://api.github.com/users/bruceauyeung/following{/other_user}","gists_url":"https://api.github.com/users/bruceauyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/bruceauyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruceauyeung/subscriptions","organizations_url":"https://api.github.com/users/bruceauyeung/orgs","repos_url":"https://api.github.com/users/bruceauyeung/repos","events_url":"https://api.github.com/users/bruceauyeung/events{/privacy}","received_events_url":"https://api.github.com/users/bruceauyeung/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\ni met a situation that kubelet pod's events get lost because of rate limiter inside event broadcaster((https://github.com/kubernetes/kubernetes/issues/67887)). but before diving into the codes, i don't have any clue why the events get lot, there isn't any even in glog verbose info/warn/error messages.\r\nso i think if there are some warn message if events get lost, it will be better to understand what happened under the hood.\r\n\r\n```release-note\r\nprint glog warn message when kubernetes events get dropped at the client side\r\n```\r\n","created_at":"2018-09-07T02:51:54Z","updated_at":"2018-09-07T07:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d2f69a620ab2443114ff581221424ff6108bbc4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"node_id":"MDQ6VXNlcjE3ODcxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68393/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/64b4b66387fb336d37334d3b4613ba11793fd42f","head":{"label":"bruceauyeung:log-if-kubelet-event-dropped","ref":"log-if-kubelet-event-dropped","sha":"64b4b66387fb336d37334d3b4613ba11793fd42f","user":{"login":"bruceauyeung","id":1210201,"node_id":"MDQ6VXNlcjEyMTAyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1210201?v=4","gravatar_id":"","url":"https://api.github.com/users/bruceauyeung","html_url":"https://github.com/bruceauyeung","followers_url":"https://api.github.com/users/bruceauyeung/followers","following_url":"https://api.github.com/users/bruceauyeung/following{/other_user}","gists_url":"https://api.github.com/users/bruceauyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/bruceauyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruceauyeung/subscriptions","organizations_url":"https://api.github.com/users/bruceauyeung/orgs","repos_url":"https://api.github.com/users/bruceauyeung/repos","events_url":"https://api.github.com/users/bruceauyeung/events{/privacy}","received_events_url":"https://api.github.com/users/bruceauyeung/received_events","type":"User","site_admin":false},"repo":{"id":71337876,"node_id":"MDEwOlJlcG9zaXRvcnk3MTMzNzg3Ng==","name":"kubernetes","full_name":"bruceauyeung/kubernetes","owner":{"login":"bruceauyeung","id":1210201,"node_id":"MDQ6VXNlcjEyMTAyMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1210201?v=4","gravatar_id":"","url":"https://api.github.com/users/bruceauyeung","html_url":"https://github.com/bruceauyeung","followers_url":"https://api.github.com/users/bruceauyeung/followers","following_url":"https://api.github.com/users/bruceauyeung/following{/other_user}","gists_url":"https://api.github.com/users/bruceauyeung/gists{/gist_id}","starred_url":"https://api.github.com/users/bruceauyeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruceauyeung/subscriptions","organizations_url":"https://api.github.com/users/bruceauyeung/orgs","repos_url":"https://api.github.com/users/bruceauyeung/repos","events_url":"https://api.github.com/users/bruceauyeung/events{/privacy}","received_events_url":"https://api.github.com/users/bruceauyeung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bruceauyeung/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/bruceauyeung/kubernetes","forks_url":"https://api.github.com/repos/bruceauyeung/kubernetes/forks","keys_url":"https://api.github.com/repos/bruceauyeung/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bruceauyeung/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bruceauyeung/kubernetes/teams","hooks_url":"https://api.github.com/repos/bruceauyeung/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bruceauyeung/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bruceauyeung/kubernetes/events","assignees_url":"https://api.github.com/repos/bruceauyeung/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bruceauyeung/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bruceauyeung/kubernetes/tags","blobs_url":"https://api.github.com/repos/bruceauyeung/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bruceauyeung/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bruceauyeung/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bruceauyeung/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bruceauyeung/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bruceauyeung/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bruceauyeung/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bruceauyeung/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bruceauyeung/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bruceauyeung/kubernetes/subscription","commits_url":"https://api.github.com/repos/bruceauyeung/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bruceauyeung/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bruceauyeung/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bruceauyeung/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bruceauyeung/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bruceauyeung/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bruceauyeung/kubernetes/merges","archive_url":"https://api.github.com/repos/bruceauyeung/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bruceauyeung/kubernetes/downloads","issues_url":"https://api.github.com/repos/bruceauyeung/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bruceauyeung/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bruceauyeung/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bruceauyeung/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bruceauyeung/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bruceauyeung/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/bruceauyeung/kubernetes/deployments","created_at":"2016-10-19T08:53:59Z","updated_at":"2018-09-06T03:26:48Z","pushed_at":"2018-09-07T03:15:56Z","git_url":"git://github.com/bruceauyeung/kubernetes.git","ssh_url":"git@github.com:bruceauyeung/kubernetes.git","clone_url":"https://github.com/bruceauyeung/kubernetes.git","svn_url":"https://github.com/bruceauyeung/kubernetes","homepage":"http://kubernetes.io","size":572345,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"659092d8ba4656c8cb359a13178b41b427b87eb0","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-09-07T06:52:27Z","pushed_at":"2018-09-07T05:42:45Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":807754,"stargazers_count":41107,"watchers_count":41107,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14295,"mirror_url":null,"archived":false,"open_issues_count":3121,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14295,"open_issues":3121,"watchers":41107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68393"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68393"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68393/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68393/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/64b4b66387fb336d37334d3b4613ba11793fd42f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yue9944882"}}