{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/14234","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/14234/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14234/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/14234/events","html_url":"https://github.com/highfidelity/hifi/pull/14234","id":371635660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDM5MzA3","number":14234,"title":"18518 - Make record.js unsubscribe from messaging channel","user":{"login":"r3tk0n","id":39922250,"node_id":"MDQ6VXNlcjM5OTIyMjUw","avatar_url":"https://avatars2.githubusercontent.com/u/39922250?v=4","gravatar_id":"","url":"https://api.github.com/users/r3tk0n","html_url":"https://github.com/r3tk0n","followers_url":"https://api.github.com/users/r3tk0n/followers","following_url":"https://api.github.com/users/r3tk0n/following{/other_user}","gists_url":"https://api.github.com/users/r3tk0n/gists{/gist_id}","starred_url":"https://api.github.com/users/r3tk0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r3tk0n/subscriptions","organizations_url":"https://api.github.com/users/r3tk0n/orgs","repos_url":"https://api.github.com/users/r3tk0n/repos","events_url":"https://api.github.com/users/r3tk0n/events{/privacy}","received_events_url":"https://api.github.com/users/r3tk0n/received_events","type":"User","site_admin":false},"labels":[{"id":743411186,"node_id":"MDU6TGFiZWw3NDM0MTExODY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":314155368,"node_id":"MDU6TGFiZWwzMTQxNTUzNjg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":733764234,"node_id":"MDU6TGFiZWw3MzM3NjQyMzQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Project%20Approved","name":"Project Approved","color":"009800","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/35","html_url":"https://github.com/highfidelity/hifi/milestone/35","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/35/labels","id":3290834,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzNA==","number":35,"title":"v0.75.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":36,"state":"open","created_at":"2018-04-23T19:27:18Z","updated_at":"2018-10-19T01:29:02Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-10-18T17:35:21Z","updated_at":"2018-10-19T01:52:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14234","html_url":"https://github.com/highfidelity/hifi/pull/14234","diff_url":"https://github.com/highfidelity/hifi/pull/14234.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14234.patch"},"body":"Record.js was not unsubscribing from the `HIFI_RECORDER_CHANNEL` on script ending.\r\n\r\n[Relevant MS ticket.](https://highfidelity.fogbugz.com/f/cases/18518/record-js-App-Not-Unsubscribing-from-Message-Channel)\r\n\r\nSo, after consulting with Jeff and Dante... There's really no good test plan for this. We don't have a way of polling whether a script is subscribed or not. So long as `record.js` operates as before (the one in `unpublishedScripts/marketplace/record/record.js`), then there's no issue. This was basically just fixing a small typo."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/431219486","html_url":"https://github.com/highfidelity/hifi/pull/14234#issuecomment-431219486","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14234","id":431219486,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTIxOTQ4Ng==","user":{"login":"hifi-gustavo","id":4554450,"node_id":"MDQ6VXNlcjQ1NTQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T01:52:11Z","updated_at":"2018-10-19T01:52:11Z","author_association":"NONE","body":"Mac OS X build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dmacos/14149/HighFidelity-Beta-PR14234-90bf723.dmg"}}
{"actor":{"display_login":"hifi-gustavo"}}