{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/18318","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/18318/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/18318/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/18318/events","html_url":"https://github.com/facebook/react-native/pull/18318","id":304063049,"number":18318,"title":"[Android] Checkbox to inherit from AppCompatCheckBox","user":{"login":"vonovak","id":1566403,"avatar_url":"https://avatars1.githubusercontent.com/u/1566403?v=4","gravatar_id":"","url":"https://api.github.com/users/vonovak","html_url":"https://github.com/vonovak","followers_url":"https://api.github.com/users/vonovak/followers","following_url":"https://api.github.com/users/vonovak/following{/other_user}","gists_url":"https://api.github.com/users/vonovak/gists{/gist_id}","starred_url":"https://api.github.com/users/vonovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vonovak/subscriptions","organizations_url":"https://api.github.com/users/vonovak/orgs","repos_url":"https://api.github.com/users/vonovak/repos","events_url":"https://api.github.com/users/vonovak/events{/privacy}","received_events_url":"https://api.github.com/users/vonovak/received_events","type":"User","site_admin":false},"labels":[{"id":260305031,"url":"https://api.github.com/repos/facebook/react-native/labels/Android","name":"Android","color":"bfd4f2","default":false},{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false},{"id":488712125,"url":"https://api.github.com/repos/facebook/react-native/labels/Failed%20Commands","name":"Failed Commands","color":"ededed","default":false},{"id":302755315,"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Failed","name":"Import Failed","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-10T11:22:11Z","updated_at":"2018-03-14T14:48:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/18318","html_url":"https://github.com/facebook/react-native/pull/18318","diff_url":"https://github.com/facebook/react-native/pull/18318.diff","patch_url":"https://github.com/facebook/react-native/pull/18318.patch"},"body":"## Motivation\r\n\r\nThe checkbox components inherits from `android.widget.CheckBox`. `AppCompatCheckBox` offers better appearance and support for advanced features (eg. tinting) on older APIs. \r\n\r\n~~However, the build fails for some reason; If somebody could shed some light on this, I'd appreciate it.~~ Thanks for the comment, I was being blind and somehow ignored the BUCK file.\r\n\r\n## Test Plan\r\n\r\nI have created a simple app with a checkbox.\r\n\r\nScreenshot from android 4.1 (current master):\r\n\r\n<img src=\"https://user-images.githubusercontent.com/1566403/37357997-2d34bdb8-26ea-11e8-8c77-709a4f96c6bf.png\" width=\"300\" />\r\n\r\n\r\nScreenshot after applying the change, also android 4.1:\r\n\r\n<img src=\"https://user-images.githubusercontent.com/1566403/37358016-3c28fb86-26ea-11e8-8dca-3a92e41450c9.png\" width=\"300\" />\r\n\r\n## Related PRs\r\n\r\nhttps://github.com/facebook/react-native/pull/18300 https://github.com/facebook/react-native/pull/18300 (this PR is needed to support tinting on older android api levels)\r\n\r\n## Release Notes\r\n\r\n[ ANDROID ]  [ ENHANCEMENT ]  [ Checkbox ] - Checkbox inherits from AppCompatCheckBox\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/373047878","html_url":"https://github.com/facebook/react-native/pull/18318#issuecomment-373047878","issue_url":"https://api.github.com/repos/facebook/react-native/issues/18318","id":373047878,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T14:48:22Z","updated_at":"2018-03-14T14:48:22Z","author_association":"NONE","body":"I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification."}}
{"actor":{"display_login":"facebook-github-bot"}}