{"action":"created","issue":{"url":"https://api.github.com/repos/aerogear/origin-web-console/issues/43","repository_url":"https://api.github.com/repos/aerogear/origin-web-console","labels_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/43/comments","events_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/43/events","html_url":"https://github.com/aerogear/origin-web-console/pull/43","id":324051351,"number":43,"title":"[android-client-build] - Add create android client build form.","user":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars1.githubusercontent.com/u/327352?v=4","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-17T14:35:14Z","updated_at":"2018-05-18T08:09:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aerogear/origin-web-console/pulls/43","html_url":"https://github.com/aerogear/origin-web-console/pull/43","diff_url":"https://github.com/aerogear/origin-web-console/pull/43.diff","patch_url":"https://github.com/aerogear/origin-web-console/pull/43.patch"},"body":"Re-opened due to base branch change see https://github.com/aerogear/origin-web-console/pull/41\r\n\r\n* Create jenkins pipeline build config for android applications.\r\n* Enable \"Create Build\" option only when mobile CI/CD provisioned and client type is Android\r\n\r\n**Verification:**\r\n- [ ] Create project with Mobile CI/CD provisioned and an android client\r\n- [ ] Select \"Create Build\" from the android clients action menu\r\n- [ ] Create a new build for a public repo, debug build type, start the pipeline and verify it completes\r\n- [ ] Create a new build for a private repo, debug build type, start the pipeline and verify it completes\r\n- [ ] Create a new build for a public repo, release build type, start the pipeline and verify it completes\r\n- [ ] Create a new build for a private repo, release build type, start the pipeline and verify it completes\r\n\r\nTo create a test keystore certificate, use the following:\r\n\r\n```\r\nkeytool -genkey -v -keystore testcert.keystore -alias testcert -keyalg RSA -keysize 2048 -validity 10000\r\nkeytool -importkeystore -srckeystore testcert.keystore -destkeystore testcert.p12 -deststoretype PKCS12 -srcalias testcert\r\n```\r\n\r\n**Notes:**\r\n* Test application with a working Jenkinsfile can be found in this repo https://github.com/mikenairn/helloworld-android-gradle/tree/5xjenkinsfile"},"comment":{"url":"https://api.github.com/repos/aerogear/origin-web-console/issues/comments/390129898","html_url":"https://github.com/aerogear/origin-web-console/pull/43#issuecomment-390129898","issue_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/43","id":390129898,"user":{"login":"mikenairn","id":327352,"avatar_url":"https://avatars1.githubusercontent.com/u/327352?v=4","gravatar_id":"","url":"https://api.github.com/users/mikenairn","html_url":"https://github.com/mikenairn","followers_url":"https://api.github.com/users/mikenairn/followers","following_url":"https://api.github.com/users/mikenairn/following{/other_user}","gists_url":"https://api.github.com/users/mikenairn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikenairn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikenairn/subscriptions","organizations_url":"https://api.github.com/users/mikenairn/orgs","repos_url":"https://api.github.com/users/mikenairn/repos","events_url":"https://api.github.com/users/mikenairn/events{/privacy}","received_events_url":"https://api.github.com/users/mikenairn/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T08:09:06Z","updated_at":"2018-05-18T08:09:06Z","author_association":"NONE","body":"Thanks @JameelB \r\n\r\n> I noticed that the Create Build option is available even when the mobile ci|cd provision hasn't finished yet.\r\n\r\nYes you are right, had meant to come back to this. Will update the test to use the filter @sedroche described above.\r\n\r\n> I've also noticed that when an error occurs during build creation, it seems that a build is still created.\r\n\r\nThe way this form is working is a bit wrong tbh, in that it is creating multiple resources with one create action. Instead of doing this, we should be using an approach seen on other forms where we instead ask the user to select an existing secret, or they are moved off this form to another modal view to create a new secret. This way errors would be handled as expected and the user can deal with the errors at the correct time.\r\n\r\nI think making these changes is probably better than trying to hack in validation as it currently is, so will create a follow on issue for that. This was deemed low priority before, but considering it can cause issues with resources being created when they shouldn't, we could maybe change that. \r\n"}}
{"actor":{"display_login":"mikenairn"}}