{"push_id":2775819025,"size":1,"distinct_size":1,"ref":"refs/heads/tk/io","head":"c5dc1b8232aaca92aeff122cda3d8390978a6f0e","before":"f6f07f817077f1e6d6e22348a7af6e8494650738","commits":[{"sha":"c5dc1b8232aaca92aeff122cda3d8390978a6f0e","author":{"name":"Twan Koolen","email":"d7336ee160dccce98aef76f2d15598ff37707402@gmail.com"},"message":"Fix readstring benchmark properly, reuse testbuf again.\n\n`perf_read!` does a `seekstart` at the beginning, but `perf_read!` was not used for the `readstring` benchmark, only the `read` benchmark. So if the `read` benchmark was done before the `readstring` benchmark, `testbuf` would definitely be at eof, as witnessed by the too-good-to-be-true 80 ns benchmark time.\n\nThe implementation in the previous commit was also incorrect, as there can be multiple evaluations per sample.\n\nAlso reuse `testbuf` again in response to https://github.com/JuliaCI/BaseBenchmarks.jl/pull/223#issuecomment-410464560.","distinct":true,"url":"https://api.github.com/repos/tkoolen/BaseBenchmarks.jl/commits/c5dc1b8232aaca92aeff122cda3d8390978a6f0e"}]}
{"actor":{"display_login":"tkoolen"}}