{"action":"created","comment":{"url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/comments/181089023","pull_request_review_id":111630275,"id":181089023,"diff_hunk":"@@ -96,4 +106,71 @@ describe('initial test', () => {\n       expect(eventSpy.calledWith('next', nextSpy));\n     });\n   });\n+\n+  describe('custom Tada ', () => {\n+    describe('in default Tada case without no options >> ', () => {\n+      it('hide navigator and pagination', () => {\n+        //given\n+        const option = {selector: '#tada-class'};\n+        //when\n+        const tada = new Tada(option);\n+        //then\n+        expect(tada.controller._config.showNavigator).to.be.false;","path":"test/index.test.js","position":39,"original_position":39,"commit_id":"f94aa987e63570359426549e883aa32f8c9d620d","original_commit_id":"f94aa987e63570359426549e883aa32f8c9d620d","user":{"login":"hyeonmi","id":2038652,"avatar_url":"https://avatars3.githubusercontent.com/u/2038652?v=4","gravatar_id":"","url":"https://api.github.com/users/hyeonmi","html_url":"https://github.com/hyeonmi","followers_url":"https://api.github.com/users/hyeonmi/followers","following_url":"https://api.github.com/users/hyeonmi/following{/other_user}","gists_url":"https://api.github.com/users/hyeonmi/gists{/gist_id}","starred_url":"https://api.github.com/users/hyeonmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyeonmi/subscriptions","organizations_url":"https://api.github.com/users/hyeonmi/orgs","repos_url":"https://api.github.com/users/hyeonmi/repos","events_url":"https://api.github.com/users/hyeonmi/events{/privacy}","received_events_url":"https://api.github.com/users/hyeonmi/received_events","type":"User","site_admin":false},"body":"config에 getter/setter 쪽 보니까 계산 없이 할당하고 가져다 쓰는데 그러면 의미가 없지 않을까요?\r\n은닉하고 싶은거면 setter/getter 두지말고 toJson만 pulbic 함수로 유지해서 가져다 쓰도록 하면 어떨까 합니다.","created_at":"2018-04-12T13:53:10Z","updated_at":"2018-04-12T13:53:10Z","html_url":"https://github.com/SE-Jr/tada.js/pull/42#discussion_r181089023","pull_request_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/comments/181089023"},"html":{"href":"https://github.com/SE-Jr/tada.js/pull/42#discussion_r181089023"},"pull_request":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42","id":181205595,"html_url":"https://github.com/SE-Jr/tada.js/pull/42","diff_url":"https://github.com/SE-Jr/tada.js/pull/42.diff","patch_url":"https://github.com/SE-Jr/tada.js/pull/42.patch","issue_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/42","number":42,"state":"open","locked":false,"title":"feat(-): 사용자 설정 관련 테스트 코드 추가","user":{"login":"mojosoeun","id":4694139,"avatar_url":"https://avatars0.githubusercontent.com/u/4694139?v=4","gravatar_id":"","url":"https://api.github.com/users/mojosoeun","html_url":"https://github.com/mojosoeun","followers_url":"https://api.github.com/users/mojosoeun/followers","following_url":"https://api.github.com/users/mojosoeun/following{/other_user}","gists_url":"https://api.github.com/users/mojosoeun/gists{/gist_id}","starred_url":"https://api.github.com/users/mojosoeun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojosoeun/subscriptions","organizations_url":"https://api.github.com/users/mojosoeun/orgs","repos_url":"https://api.github.com/users/mojosoeun/repos","events_url":"https://api.github.com/users/mojosoeun/events{/privacy}","received_events_url":"https://api.github.com/users/mojosoeun/received_events","type":"User","site_admin":false},"body":"사용자 설정과 관련된 테스트 코드를 추가하였습니다.\r\n\r\n   - [ ] 사용자는 아무 설정을 하지 않으면\r\n     - [ ] navigator가 보이지 않는다. \r\n     - [ ] pagination이 보이지 않는다.\r\n   - [ ] 사용자는 tada를 커스텀하게 바꿀 수 있다.\r\n     - [ ] 사용자는 설정을 통해 navigator를 만들 수 있다.\r\n     - [ ] 사용자는  설정을 통해 navigator를 숨길 수 있다.\r\n     - [ ] 사용자는 설정을 통해 pagination을 만들 수 있다.\r\n     - [ ] 사용자는 설정을 통해 pagination을 숨길 수 있다. \r\n     - [ ] 사용자가 pagination 모양 설정을 하지 않으면 circle로 노출이 된다.\r\n     - [ ] 사용자는 설정을 통해 pagination 모양을 circle로 바꿀 수 있다. \r\n     - [ ] 사용자는 설정을 통해 pagination 모양을 bar로 바꿀 수 있다.\r\n","created_at":"2018-04-12T13:37:01Z","updated_at":"2018-04-12T13:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e29267446925af6af63b3a4d9aa16bacbc3564","assignee":{"login":"mojosoeun","id":4694139,"avatar_url":"https://avatars0.githubusercontent.com/u/4694139?v=4","gravatar_id":"","url":"https://api.github.com/users/mojosoeun","html_url":"https://github.com/mojosoeun","followers_url":"https://api.github.com/users/mojosoeun/followers","following_url":"https://api.github.com/users/mojosoeun/following{/other_user}","gists_url":"https://api.github.com/users/mojosoeun/gists{/gist_id}","starred_url":"https://api.github.com/users/mojosoeun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojosoeun/subscriptions","organizations_url":"https://api.github.com/users/mojosoeun/orgs","repos_url":"https://api.github.com/users/mojosoeun/repos","events_url":"https://api.github.com/users/mojosoeun/events{/privacy}","received_events_url":"https://api.github.com/users/mojosoeun/received_events","type":"User","site_admin":false},"assignees":[{"login":"mojosoeun","id":4694139,"avatar_url":"https://avatars0.githubusercontent.com/u/4694139?v=4","gravatar_id":"","url":"https://api.github.com/users/mojosoeun","html_url":"https://github.com/mojosoeun","followers_url":"https://api.github.com/users/mojosoeun/followers","following_url":"https://api.github.com/users/mojosoeun/following{/other_user}","gists_url":"https://api.github.com/users/mojosoeun/gists{/gist_id}","starred_url":"https://api.github.com/users/mojosoeun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojosoeun/subscriptions","organizations_url":"https://api.github.com/users/mojosoeun/orgs","repos_url":"https://api.github.com/users/mojosoeun/repos","events_url":"https://api.github.com/users/mojosoeun/events{/privacy}","received_events_url":"https://api.github.com/users/mojosoeun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42/commits","review_comments_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42/comments","review_comment_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/42/comments","statuses_url":"https://api.github.com/repos/SE-Jr/tada.js/statuses/f94aa987e63570359426549e883aa32f8c9d620d","head":{"label":"SE-Jr:soeun/user-no-option","ref":"soeun/user-no-option","sha":"f94aa987e63570359426549e883aa32f8c9d620d","user":{"login":"SE-Jr","id":32861506,"avatar_url":"https://avatars2.githubusercontent.com/u/32861506?v=4","gravatar_id":"","url":"https://api.github.com/users/SE-Jr","html_url":"https://github.com/SE-Jr","followers_url":"https://api.github.com/users/SE-Jr/followers","following_url":"https://api.github.com/users/SE-Jr/following{/other_user}","gists_url":"https://api.github.com/users/SE-Jr/gists{/gist_id}","starred_url":"https://api.github.com/users/SE-Jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SE-Jr/subscriptions","organizations_url":"https://api.github.com/users/SE-Jr/orgs","repos_url":"https://api.github.com/users/SE-Jr/repos","events_url":"https://api.github.com/users/SE-Jr/events{/privacy}","received_events_url":"https://api.github.com/users/SE-Jr/received_events","type":"Organization","site_admin":false},"repo":{"id":107222986,"name":"tada.js","full_name":"SE-Jr/tada.js","owner":{"login":"SE-Jr","id":32861506,"avatar_url":"https://avatars2.githubusercontent.com/u/32861506?v=4","gravatar_id":"","url":"https://api.github.com/users/SE-Jr","html_url":"https://github.com/SE-Jr","followers_url":"https://api.github.com/users/SE-Jr/followers","following_url":"https://api.github.com/users/SE-Jr/following{/other_user}","gists_url":"https://api.github.com/users/SE-Jr/gists{/gist_id}","starred_url":"https://api.github.com/users/SE-Jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SE-Jr/subscriptions","organizations_url":"https://api.github.com/users/SE-Jr/orgs","repos_url":"https://api.github.com/users/SE-Jr/repos","events_url":"https://api.github.com/users/SE-Jr/events{/privacy}","received_events_url":"https://api.github.com/users/SE-Jr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SE-Jr/tada.js","description":":tada: Simple Carousel Javascript Library","fork":false,"url":"https://api.github.com/repos/SE-Jr/tada.js","forks_url":"https://api.github.com/repos/SE-Jr/tada.js/forks","keys_url":"https://api.github.com/repos/SE-Jr/tada.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SE-Jr/tada.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SE-Jr/tada.js/teams","hooks_url":"https://api.github.com/repos/SE-Jr/tada.js/hooks","issue_events_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/events{/number}","events_url":"https://api.github.com/repos/SE-Jr/tada.js/events","assignees_url":"https://api.github.com/repos/SE-Jr/tada.js/assignees{/user}","branches_url":"https://api.github.com/repos/SE-Jr/tada.js/branches{/branch}","tags_url":"https://api.github.com/repos/SE-Jr/tada.js/tags","blobs_url":"https://api.github.com/repos/SE-Jr/tada.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SE-Jr/tada.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SE-Jr/tada.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SE-Jr/tada.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SE-Jr/tada.js/statuses/{sha}","languages_url":"https://api.github.com/repos/SE-Jr/tada.js/languages","stargazers_url":"https://api.github.com/repos/SE-Jr/tada.js/stargazers","contributors_url":"https://api.github.com/repos/SE-Jr/tada.js/contributors","subscribers_url":"https://api.github.com/repos/SE-Jr/tada.js/subscribers","subscription_url":"https://api.github.com/repos/SE-Jr/tada.js/subscription","commits_url":"https://api.github.com/repos/SE-Jr/tada.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SE-Jr/tada.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SE-Jr/tada.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SE-Jr/tada.js/contents/{+path}","compare_url":"https://api.github.com/repos/SE-Jr/tada.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SE-Jr/tada.js/merges","archive_url":"https://api.github.com/repos/SE-Jr/tada.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SE-Jr/tada.js/downloads","issues_url":"https://api.github.com/repos/SE-Jr/tada.js/issues{/number}","pulls_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls{/number}","milestones_url":"https://api.github.com/repos/SE-Jr/tada.js/milestones{/number}","notifications_url":"https://api.github.com/repos/SE-Jr/tada.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SE-Jr/tada.js/labels{/name}","releases_url":"https://api.github.com/repos/SE-Jr/tada.js/releases{/id}","deployments_url":"https://api.github.com/repos/SE-Jr/tada.js/deployments","created_at":"2017-10-17T05:41:59Z","updated_at":"2018-03-18T16:27:41Z","pushed_at":"2018-04-12T13:37:01Z","git_url":"git://github.com/SE-Jr/tada.js.git","ssh_url":"git@github.com:SE-Jr/tada.js.git","clone_url":"https://github.com/SE-Jr/tada.js.git","svn_url":"https://github.com/SE-Jr/tada.js","homepage":"","size":300,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"SE-Jr:soeun/no-dom-selector","ref":"soeun/no-dom-selector","sha":"b2d322a8bd9a70e55a8dcdd81c9bfbd3ae5204d7","user":{"login":"SE-Jr","id":32861506,"avatar_url":"https://avatars2.githubusercontent.com/u/32861506?v=4","gravatar_id":"","url":"https://api.github.com/users/SE-Jr","html_url":"https://github.com/SE-Jr","followers_url":"https://api.github.com/users/SE-Jr/followers","following_url":"https://api.github.com/users/SE-Jr/following{/other_user}","gists_url":"https://api.github.com/users/SE-Jr/gists{/gist_id}","starred_url":"https://api.github.com/users/SE-Jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SE-Jr/subscriptions","organizations_url":"https://api.github.com/users/SE-Jr/orgs","repos_url":"https://api.github.com/users/SE-Jr/repos","events_url":"https://api.github.com/users/SE-Jr/events{/privacy}","received_events_url":"https://api.github.com/users/SE-Jr/received_events","type":"Organization","site_admin":false},"repo":{"id":107222986,"name":"tada.js","full_name":"SE-Jr/tada.js","owner":{"login":"SE-Jr","id":32861506,"avatar_url":"https://avatars2.githubusercontent.com/u/32861506?v=4","gravatar_id":"","url":"https://api.github.com/users/SE-Jr","html_url":"https://github.com/SE-Jr","followers_url":"https://api.github.com/users/SE-Jr/followers","following_url":"https://api.github.com/users/SE-Jr/following{/other_user}","gists_url":"https://api.github.com/users/SE-Jr/gists{/gist_id}","starred_url":"https://api.github.com/users/SE-Jr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SE-Jr/subscriptions","organizations_url":"https://api.github.com/users/SE-Jr/orgs","repos_url":"https://api.github.com/users/SE-Jr/repos","events_url":"https://api.github.com/users/SE-Jr/events{/privacy}","received_events_url":"https://api.github.com/users/SE-Jr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SE-Jr/tada.js","description":":tada: Simple Carousel Javascript Library","fork":false,"url":"https://api.github.com/repos/SE-Jr/tada.js","forks_url":"https://api.github.com/repos/SE-Jr/tada.js/forks","keys_url":"https://api.github.com/repos/SE-Jr/tada.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SE-Jr/tada.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SE-Jr/tada.js/teams","hooks_url":"https://api.github.com/repos/SE-Jr/tada.js/hooks","issue_events_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/events{/number}","events_url":"https://api.github.com/repos/SE-Jr/tada.js/events","assignees_url":"https://api.github.com/repos/SE-Jr/tada.js/assignees{/user}","branches_url":"https://api.github.com/repos/SE-Jr/tada.js/branches{/branch}","tags_url":"https://api.github.com/repos/SE-Jr/tada.js/tags","blobs_url":"https://api.github.com/repos/SE-Jr/tada.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SE-Jr/tada.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SE-Jr/tada.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/SE-Jr/tada.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SE-Jr/tada.js/statuses/{sha}","languages_url":"https://api.github.com/repos/SE-Jr/tada.js/languages","stargazers_url":"https://api.github.com/repos/SE-Jr/tada.js/stargazers","contributors_url":"https://api.github.com/repos/SE-Jr/tada.js/contributors","subscribers_url":"https://api.github.com/repos/SE-Jr/tada.js/subscribers","subscription_url":"https://api.github.com/repos/SE-Jr/tada.js/subscription","commits_url":"https://api.github.com/repos/SE-Jr/tada.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/SE-Jr/tada.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/SE-Jr/tada.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/SE-Jr/tada.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/SE-Jr/tada.js/contents/{+path}","compare_url":"https://api.github.com/repos/SE-Jr/tada.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SE-Jr/tada.js/merges","archive_url":"https://api.github.com/repos/SE-Jr/tada.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SE-Jr/tada.js/downloads","issues_url":"https://api.github.com/repos/SE-Jr/tada.js/issues{/number}","pulls_url":"https://api.github.com/repos/SE-Jr/tada.js/pulls{/number}","milestones_url":"https://api.github.com/repos/SE-Jr/tada.js/milestones{/number}","notifications_url":"https://api.github.com/repos/SE-Jr/tada.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SE-Jr/tada.js/labels{/name}","releases_url":"https://api.github.com/repos/SE-Jr/tada.js/releases{/id}","deployments_url":"https://api.github.com/repos/SE-Jr/tada.js/deployments","created_at":"2017-10-17T05:41:59Z","updated_at":"2018-03-18T16:27:41Z","pushed_at":"2018-04-12T13:37:01Z","git_url":"git://github.com/SE-Jr/tada.js.git","ssh_url":"git@github.com:SE-Jr/tada.js.git","clone_url":"https://github.com/SE-Jr/tada.js.git","svn_url":"https://github.com/SE-Jr/tada.js","homepage":"","size":300,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42"},"html":{"href":"https://github.com/SE-Jr/tada.js/pull/42"},"issue":{"href":"https://api.github.com/repos/SE-Jr/tada.js/issues/42"},"comments":{"href":"https://api.github.com/repos/SE-Jr/tada.js/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SE-Jr/tada.js/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/SE-Jr/tada.js/statuses/f94aa987e63570359426549e883aa32f8c9d620d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hyeonmi"}}