{"action":"created","issue":{"url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/2","repository_url":"https://api.github.com/repos/ssc-oscar/libgit2","labels_url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/2/comments","events_url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/2/events","html_url":"https://github.com/ssc-oscar/libgit2/issues/2","id":381421543,"node_id":"MDU6SXNzdWUzODE0MjE1NDM=","number":2,"title":"get_new_commits crashes","user":{"login":"audrism","id":7920823,"node_id":"MDQ6VXNlcjc5MjA4MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7920823?v=4","gravatar_id":"","url":"https://api.github.com/users/audrism","html_url":"https://github.com/audrism","followers_url":"https://api.github.com/users/audrism/followers","following_url":"https://api.github.com/users/audrism/following{/other_user}","gists_url":"https://api.github.com/users/audrism/gists{/gist_id}","starred_url":"https://api.github.com/users/audrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audrism/subscriptions","organizations_url":"https://api.github.com/users/audrism/orgs","repos_url":"https://api.github.com/users/audrism/repos","events_url":"https://api.github.com/users/audrism/events{/privacy}","received_events_url":"https://api.github.com/users/audrism/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-11-16T02:35:20Z","updated_at":"2018-11-23T06:43:23Z","closed_at":null,"author_association":"NONE","body":"echo tst,https://github.com/ssc-oscar/tst,968cdcf2e6b22fd5f8f95f2c8666f1a976fac0c7,968cdcf2e6b22fd5f8f95f2c8666f1a976fac0c7 | /usr/bin/get_new_commits \r\npath: tst\r\nurl: https://github.com/ssc-oscar/tst\r\nnew head: 968cdcf2e6b22fd5f8f95f2c8666f1a976fac0c7\r\nold head: 968cdcf2e6b22fd5f8f95f2c8666f1a976fac0c7\r\nno update!\r\nSegmentation fault\r\n"},"comment":{"url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/comments/441165260","html_url":"https://github.com/ssc-oscar/libgit2/issues/2#issuecomment-441165260","issue_url":"https://api.github.com/repos/ssc-oscar/libgit2/issues/2","id":441165260,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTE2NTI2MA==","user":{"login":"KayGau","id":26438700,"node_id":"MDQ6VXNlcjI2NDM4NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/26438700?v=4","gravatar_id":"","url":"https://api.github.com/users/KayGau","html_url":"https://github.com/KayGau","followers_url":"https://api.github.com/users/KayGau/followers","following_url":"https://api.github.com/users/KayGau/following{/other_user}","gists_url":"https://api.github.com/users/KayGau/gists{/gist_id}","starred_url":"https://api.github.com/users/KayGau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayGau/subscriptions","organizations_url":"https://api.github.com/users/KayGau/orgs","repos_url":"https://api.github.com/users/KayGau/repos","events_url":"https://api.github.com/users/KayGau/events{/privacy}","received_events_url":"https://api.github.com/users/KayGau/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T06:43:23Z","updated_at":"2018-11-23T06:43:23Z","author_association":"NONE","body":"I traced the execution of fetch, and found the git_smart__negotiate_fetch function in the smart_protocol.c file tells the remote what we want and what we have. I modified it to tell the remote that we have the commits that we got last time, but later when executing to the git_smart__download_pack function in the smart_protocol.c file, the fetch operation raises an error! I checked the output, found the remote indeed knew that we have local commits. Then I checked the function, and found that when downloading from the remote, it first writes the odb in the repo to a writepack. The odb is the object database in the repo, which means that to correctly download the new commits, we must have local repo..."}}
{"actor":{"display_login":"KayGau"}}