{"action":"created","comment":{"url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/comments/228440701","pull_request_review_id":168714599,"id":228440701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODQ0MDcwMQ==","diff_hunk":"@@ -28,14 +29,24 @@ public static String encode(int number) {\n       throw new IllegalArgumentException(\"number must be 0 or a positive integer\");\n     }\n \n-    return convert(number, 0, \"\");\n+    String result = convert(number, 0, \"\");\n+ \n+    return pad(result, symbols[0]);","path":"src/main/java/uk/gov/dft/bluebadge/common/util/Base20.java","position":15,"original_position":15,"commit_id":"03ffd58f462ea52a02f52e3906afc9830fcf4e80","original_commit_id":"03ffd58f462ea52a02f52e3906afc9830fcf4e80","user":{"login":"xytrams","id":1402673,"node_id":"MDQ6VXNlcjE0MDI2NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1402673?v=4","gravatar_id":"","url":"https://api.github.com/users/xytrams","html_url":"https://github.com/xytrams","followers_url":"https://api.github.com/users/xytrams/followers","following_url":"https://api.github.com/users/xytrams/following{/other_user}","gists_url":"https://api.github.com/users/xytrams/gists{/gist_id}","starred_url":"https://api.github.com/users/xytrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xytrams/subscriptions","organizations_url":"https://api.github.com/users/xytrams/orgs","repos_url":"https://api.github.com/users/xytrams/repos","events_url":"https://api.github.com/users/xytrams/events{/privacy}","received_events_url":"https://api.github.com/users/xytrams/received_events","type":"User","site_admin":false},"body":"Ha! I can't know all APIs :) thanks for a tip!","created_at":"2018-10-26T08:16:10Z","updated_at":"2018-10-26T08:16:10Z","html_url":"https://github.com/dft-bluebadge/bluebadge-common/pull/23#discussion_r228440701","pull_request_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/comments/228440701"},"html":{"href":"https://github.com/dft-bluebadge/bluebadge-common/pull/23#discussion_r228440701"},"pull_request":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23"}},"in_reply_to_id":228439977},"pull_request":{"url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23","id":225998144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTk4MTQ0","html_url":"https://github.com/dft-bluebadge/bluebadge-common/pull/23","diff_url":"https://github.com/dft-bluebadge/bluebadge-common/pull/23.diff","patch_url":"https://github.com/dft-bluebadge/bluebadge-common/pull/23.patch","issue_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/23","number":23,"state":"open","locked":false,"title":"BBB-616 pre-pad with char[0] if length less than 6","user":{"login":"xytrams","id":1402673,"node_id":"MDQ6VXNlcjE0MDI2NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1402673?v=4","gravatar_id":"","url":"https://api.github.com/users/xytrams","html_url":"https://github.com/xytrams","followers_url":"https://api.github.com/users/xytrams/followers","following_url":"https://api.github.com/users/xytrams/following{/other_user}","gists_url":"https://api.github.com/users/xytrams/gists{/gist_id}","starred_url":"https://api.github.com/users/xytrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xytrams/subscriptions","organizations_url":"https://api.github.com/users/xytrams/orgs","repos_url":"https://api.github.com/users/xytrams/repos","events_url":"https://api.github.com/users/xytrams/events{/privacy}","received_events_url":"https://api.github.com/users/xytrams/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-26T07:14:32Z","updated_at":"2018-10-26T08:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89dcbe4233c44fa16648ffdb3ae76c96f3cafc9a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aliashik-vt","id":34242383,"node_id":"MDQ6VXNlcjM0MjQyMzgz","avatar_url":"https://avatars2.githubusercontent.com/u/34242383?v=4","gravatar_id":"","url":"https://api.github.com/users/aliashik-vt","html_url":"https://github.com/aliashik-vt","followers_url":"https://api.github.com/users/aliashik-vt/followers","following_url":"https://api.github.com/users/aliashik-vt/following{/other_user}","gists_url":"https://api.github.com/users/aliashik-vt/gists{/gist_id}","starred_url":"https://api.github.com/users/aliashik-vt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliashik-vt/subscriptions","organizations_url":"https://api.github.com/users/aliashik-vt/orgs","repos_url":"https://api.github.com/users/aliashik-vt/repos","events_url":"https://api.github.com/users/aliashik-vt/events{/privacy}","received_events_url":"https://api.github.com/users/aliashik-vt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23/commits","review_comments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23/comments","review_comment_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/23/comments","statuses_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/statuses/03ffd58f462ea52a02f52e3906afc9830fcf4e80","head":{"label":"dft-bluebadge:feature/BBB-616-badge-creation-symbols","ref":"feature/BBB-616-badge-creation-symbols","sha":"03ffd58f462ea52a02f52e3906afc9830fcf4e80","user":{"login":"dft-bluebadge","id":38761127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzYxMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/38761127?v=4","gravatar_id":"","url":"https://api.github.com/users/dft-bluebadge","html_url":"https://github.com/dft-bluebadge","followers_url":"https://api.github.com/users/dft-bluebadge/followers","following_url":"https://api.github.com/users/dft-bluebadge/following{/other_user}","gists_url":"https://api.github.com/users/dft-bluebadge/gists{/gist_id}","starred_url":"https://api.github.com/users/dft-bluebadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dft-bluebadge/subscriptions","organizations_url":"https://api.github.com/users/dft-bluebadge/orgs","repos_url":"https://api.github.com/users/dft-bluebadge/repos","events_url":"https://api.github.com/users/dft-bluebadge/events{/privacy}","received_events_url":"https://api.github.com/users/dft-bluebadge/received_events","type":"Organization","site_admin":false},"repo":{"id":137473336,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NzMzMzY=","name":"bluebadge-common","full_name":"dft-bluebadge/bluebadge-common","private":false,"owner":{"login":"dft-bluebadge","id":38761127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzYxMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/38761127?v=4","gravatar_id":"","url":"https://api.github.com/users/dft-bluebadge","html_url":"https://github.com/dft-bluebadge","followers_url":"https://api.github.com/users/dft-bluebadge/followers","following_url":"https://api.github.com/users/dft-bluebadge/following{/other_user}","gists_url":"https://api.github.com/users/dft-bluebadge/gists{/gist_id}","starred_url":"https://api.github.com/users/dft-bluebadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dft-bluebadge/subscriptions","organizations_url":"https://api.github.com/users/dft-bluebadge/orgs","repos_url":"https://api.github.com/users/dft-bluebadge/repos","events_url":"https://api.github.com/users/dft-bluebadge/events{/privacy}","received_events_url":"https://api.github.com/users/dft-bluebadge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dft-bluebadge/bluebadge-common","description":"Common libs and components","fork":false,"url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common","forks_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/forks","keys_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/teams","hooks_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/hooks","issue_events_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/events{/number}","events_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/events","assignees_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/assignees{/user}","branches_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/branches{/branch}","tags_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/tags","blobs_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/statuses/{sha}","languages_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/languages","stargazers_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/stargazers","contributors_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/contributors","subscribers_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/subscribers","subscription_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/subscription","commits_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/contents/{+path}","compare_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/merges","archive_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/downloads","issues_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues{/number}","pulls_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls{/number}","milestones_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/milestones{/number}","notifications_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/labels{/name}","releases_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/releases{/id}","deployments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/deployments","created_at":"2018-06-15T10:14:19Z","updated_at":"2018-10-24T11:20:11Z","pushed_at":"2018-10-26T07:14:32Z","git_url":"git://github.com/dft-bluebadge/bluebadge-common.git","ssh_url":"git@github.com:dft-bluebadge/bluebadge-common.git","clone_url":"https://github.com/dft-bluebadge/bluebadge-common.git","svn_url":"https://github.com/dft-bluebadge/bluebadge-common","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"dft-bluebadge:develop","ref":"develop","sha":"ca28ac0820f89ba4c6fac2807ba015e5d64fc3ec","user":{"login":"dft-bluebadge","id":38761127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzYxMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/38761127?v=4","gravatar_id":"","url":"https://api.github.com/users/dft-bluebadge","html_url":"https://github.com/dft-bluebadge","followers_url":"https://api.github.com/users/dft-bluebadge/followers","following_url":"https://api.github.com/users/dft-bluebadge/following{/other_user}","gists_url":"https://api.github.com/users/dft-bluebadge/gists{/gist_id}","starred_url":"https://api.github.com/users/dft-bluebadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dft-bluebadge/subscriptions","organizations_url":"https://api.github.com/users/dft-bluebadge/orgs","repos_url":"https://api.github.com/users/dft-bluebadge/repos","events_url":"https://api.github.com/users/dft-bluebadge/events{/privacy}","received_events_url":"https://api.github.com/users/dft-bluebadge/received_events","type":"Organization","site_admin":false},"repo":{"id":137473336,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0NzMzMzY=","name":"bluebadge-common","full_name":"dft-bluebadge/bluebadge-common","private":false,"owner":{"login":"dft-bluebadge","id":38761127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzYxMTI3","avatar_url":"https://avatars3.githubusercontent.com/u/38761127?v=4","gravatar_id":"","url":"https://api.github.com/users/dft-bluebadge","html_url":"https://github.com/dft-bluebadge","followers_url":"https://api.github.com/users/dft-bluebadge/followers","following_url":"https://api.github.com/users/dft-bluebadge/following{/other_user}","gists_url":"https://api.github.com/users/dft-bluebadge/gists{/gist_id}","starred_url":"https://api.github.com/users/dft-bluebadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dft-bluebadge/subscriptions","organizations_url":"https://api.github.com/users/dft-bluebadge/orgs","repos_url":"https://api.github.com/users/dft-bluebadge/repos","events_url":"https://api.github.com/users/dft-bluebadge/events{/privacy}","received_events_url":"https://api.github.com/users/dft-bluebadge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dft-bluebadge/bluebadge-common","description":"Common libs and components","fork":false,"url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common","forks_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/forks","keys_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/teams","hooks_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/hooks","issue_events_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/events{/number}","events_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/events","assignees_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/assignees{/user}","branches_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/branches{/branch}","tags_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/tags","blobs_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/statuses/{sha}","languages_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/languages","stargazers_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/stargazers","contributors_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/contributors","subscribers_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/subscribers","subscription_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/subscription","commits_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/contents/{+path}","compare_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/merges","archive_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/downloads","issues_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues{/number}","pulls_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls{/number}","milestones_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/milestones{/number}","notifications_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/labels{/name}","releases_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/releases{/id}","deployments_url":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/deployments","created_at":"2018-06-15T10:14:19Z","updated_at":"2018-10-24T11:20:11Z","pushed_at":"2018-10-26T07:14:32Z","git_url":"git://github.com/dft-bluebadge/bluebadge-common.git","ssh_url":"git@github.com:dft-bluebadge/bluebadge-common.git","clone_url":"https://github.com/dft-bluebadge/bluebadge-common.git","svn_url":"https://github.com/dft-bluebadge/bluebadge-common","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23"},"html":{"href":"https://github.com/dft-bluebadge/bluebadge-common/pull/23"},"issue":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/23"},"comments":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/dft-bluebadge/bluebadge-common/statuses/03ffd58f462ea52a02f52e3906afc9830fcf4e80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xytrams"}}