{"action":"created","comment":{"url":"https://api.github.com/repos/heremaps/flatdata/pulls/comments/167175943","pull_request_review_id":95357152,"id":167175943,"diff_hunk":"@@ -37,14 +42,28 @@ namespace flatdata\n template < typename IndexType, typename... Args >\n class MultiVector\n {\n+public:\n+    /// Class used to fill an individual list\n+    class List","path":"flatdata-cpp/include/flatdata/MultiVector.h","position":null,"original_position":26,"commit_id":"3fbb51c895b8952bde7a51642c06ca6e50341379","original_commit_id":"50586cf71026cb80f7629a8e4a7462c98003cd76","user":{"login":"VeaaC","id":14972638,"avatar_url":"https://avatars2.githubusercontent.com/u/14972638?v=4","gravatar_id":"","url":"https://api.github.com/users/VeaaC","html_url":"https://github.com/VeaaC","followers_url":"https://api.github.com/users/VeaaC/followers","following_url":"https://api.github.com/users/VeaaC/following{/other_user}","gists_url":"https://api.github.com/users/VeaaC/gists{/gist_id}","starred_url":"https://api.github.com/users/VeaaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeaaC/subscriptions","organizations_url":"https://api.github.com/users/VeaaC/orgs","repos_url":"https://api.github.com/users/VeaaC/repos","events_url":"https://api.github.com/users/VeaaC/events{/privacy}","received_events_url":"https://api.github.com/users/VeaaC/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-02-09T09:23:36Z","updated_at":"2018-02-09T09:23:36Z","html_url":"https://github.com/heremaps/flatdata/pull/25#discussion_r167175943","pull_request_url":"https://api.github.com/repos/heremaps/flatdata/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/comments/167175943"},"html":{"href":"https://github.com/heremaps/flatdata/pull/25#discussion_r167175943"},"pull_request":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/25"}},"in_reply_to_id":167160564},"pull_request":{"url":"https://api.github.com/repos/heremaps/flatdata/pulls/25","id":167519513,"html_url":"https://github.com/heremaps/flatdata/pull/25","diff_url":"https://github.com/heremaps/flatdata/pull/25.diff","patch_url":"https://github.com/heremaps/flatdata/pull/25.patch","issue_url":"https://api.github.com/repos/heremaps/flatdata/issues/25","number":25,"state":"open","locked":false,"title":"Make MultiVector safer/easier to use and more consistent with Vector","user":{"login":"VeaaC","id":14972638,"avatar_url":"https://avatars2.githubusercontent.com/u/14972638?v=4","gravatar_id":"","url":"https://api.github.com/users/VeaaC","html_url":"https://github.com/VeaaC","followers_url":"https://api.github.com/users/VeaaC/followers","following_url":"https://api.github.com/users/VeaaC/following{/other_user}","gists_url":"https://api.github.com/users/VeaaC/gists{/gist_id}","starred_url":"https://api.github.com/users/VeaaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeaaC/subscriptions","organizations_url":"https://api.github.com/users/VeaaC/orgs","repos_url":"https://api.github.com/users/VeaaC/repos","events_url":"https://api.github.com/users/VeaaC/events{/privacy}","received_events_url":"https://api.github.com/users/VeaaC/received_events","type":"User","site_admin":false},"body":"Should now be much safer to use (and in languages like Rust even more so).\r\n\r\nAlso exposed a bug in our BackwardsCompatibilityTests: They were not filling the last bucket properly (nor testing whether it could actually be read). No harm done, but if we ourselves could not use the old interface properly, it is a clear sign that it needed to be changed.","created_at":"2018-02-06T20:19:55Z","updated_at":"2018-02-09T09:23:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e199d9f2cb94559c81868974dc8e7e4f83cbd68","assignee":null,"assignees":[],"requested_reviewers":[{"login":"boxdot","id":3841359,"avatar_url":"https://avatars3.githubusercontent.com/u/3841359?v=4","gravatar_id":"","url":"https://api.github.com/users/boxdot","html_url":"https://github.com/boxdot","followers_url":"https://api.github.com/users/boxdot/followers","following_url":"https://api.github.com/users/boxdot/following{/other_user}","gists_url":"https://api.github.com/users/boxdot/gists{/gist_id}","starred_url":"https://api.github.com/users/boxdot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxdot/subscriptions","organizations_url":"https://api.github.com/users/boxdot/orgs","repos_url":"https://api.github.com/users/boxdot/repos","events_url":"https://api.github.com/users/boxdot/events{/privacy}","received_events_url":"https://api.github.com/users/boxdot/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/heremaps/flatdata/pulls/25/commits","review_comments_url":"https://api.github.com/repos/heremaps/flatdata/pulls/25/comments","review_comment_url":"https://api.github.com/repos/heremaps/flatdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heremaps/flatdata/issues/25/comments","statuses_url":"https://api.github.com/repos/heremaps/flatdata/statuses/3fbb51c895b8952bde7a51642c06ca6e50341379","head":{"label":"VeaaC:multi_vector_grow","ref":"multi_vector_grow","sha":"3fbb51c895b8952bde7a51642c06ca6e50341379","user":{"login":"VeaaC","id":14972638,"avatar_url":"https://avatars2.githubusercontent.com/u/14972638?v=4","gravatar_id":"","url":"https://api.github.com/users/VeaaC","html_url":"https://github.com/VeaaC","followers_url":"https://api.github.com/users/VeaaC/followers","following_url":"https://api.github.com/users/VeaaC/following{/other_user}","gists_url":"https://api.github.com/users/VeaaC/gists{/gist_id}","starred_url":"https://api.github.com/users/VeaaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeaaC/subscriptions","organizations_url":"https://api.github.com/users/VeaaC/orgs","repos_url":"https://api.github.com/users/VeaaC/repos","events_url":"https://api.github.com/users/VeaaC/events{/privacy}","received_events_url":"https://api.github.com/users/VeaaC/received_events","type":"User","site_admin":false},"repo":{"id":119499643,"name":"flatdata","full_name":"VeaaC/flatdata","owner":{"login":"VeaaC","id":14972638,"avatar_url":"https://avatars2.githubusercontent.com/u/14972638?v=4","gravatar_id":"","url":"https://api.github.com/users/VeaaC","html_url":"https://github.com/VeaaC","followers_url":"https://api.github.com/users/VeaaC/followers","following_url":"https://api.github.com/users/VeaaC/following{/other_user}","gists_url":"https://api.github.com/users/VeaaC/gists{/gist_id}","starred_url":"https://api.github.com/users/VeaaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeaaC/subscriptions","organizations_url":"https://api.github.com/users/VeaaC/orgs","repos_url":"https://api.github.com/users/VeaaC/repos","events_url":"https://api.github.com/users/VeaaC/events{/privacy}","received_events_url":"https://api.github.com/users/VeaaC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VeaaC/flatdata","description":"Zero copy memory-mapped data storage ","fork":true,"url":"https://api.github.com/repos/VeaaC/flatdata","forks_url":"https://api.github.com/repos/VeaaC/flatdata/forks","keys_url":"https://api.github.com/repos/VeaaC/flatdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VeaaC/flatdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VeaaC/flatdata/teams","hooks_url":"https://api.github.com/repos/VeaaC/flatdata/hooks","issue_events_url":"https://api.github.com/repos/VeaaC/flatdata/issues/events{/number}","events_url":"https://api.github.com/repos/VeaaC/flatdata/events","assignees_url":"https://api.github.com/repos/VeaaC/flatdata/assignees{/user}","branches_url":"https://api.github.com/repos/VeaaC/flatdata/branches{/branch}","tags_url":"https://api.github.com/repos/VeaaC/flatdata/tags","blobs_url":"https://api.github.com/repos/VeaaC/flatdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VeaaC/flatdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VeaaC/flatdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/VeaaC/flatdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VeaaC/flatdata/statuses/{sha}","languages_url":"https://api.github.com/repos/VeaaC/flatdata/languages","stargazers_url":"https://api.github.com/repos/VeaaC/flatdata/stargazers","contributors_url":"https://api.github.com/repos/VeaaC/flatdata/contributors","subscribers_url":"https://api.github.com/repos/VeaaC/flatdata/subscribers","subscription_url":"https://api.github.com/repos/VeaaC/flatdata/subscription","commits_url":"https://api.github.com/repos/VeaaC/flatdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/VeaaC/flatdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/VeaaC/flatdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/VeaaC/flatdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/VeaaC/flatdata/contents/{+path}","compare_url":"https://api.github.com/repos/VeaaC/flatdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VeaaC/flatdata/merges","archive_url":"https://api.github.com/repos/VeaaC/flatdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VeaaC/flatdata/downloads","issues_url":"https://api.github.com/repos/VeaaC/flatdata/issues{/number}","pulls_url":"https://api.github.com/repos/VeaaC/flatdata/pulls{/number}","milestones_url":"https://api.github.com/repos/VeaaC/flatdata/milestones{/number}","notifications_url":"https://api.github.com/repos/VeaaC/flatdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VeaaC/flatdata/labels{/name}","releases_url":"https://api.github.com/repos/VeaaC/flatdata/releases{/id}","deployments_url":"https://api.github.com/repos/VeaaC/flatdata/deployments","created_at":"2018-01-30T07:33:26Z","updated_at":"2018-02-02T16:47:52Z","pushed_at":"2018-02-09T09:23:25Z","git_url":"git://github.com/VeaaC/flatdata.git","ssh_url":"git@github.com:VeaaC/flatdata.git","clone_url":"https://github.com/VeaaC/flatdata.git","svn_url":"https://github.com/VeaaC/flatdata","homepage":"","size":152,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"heremaps:master","ref":"master","sha":"423bd07302f8dd36bf1651d27b845273f64574ca","user":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"repo":{"id":118035076,"name":"flatdata","full_name":"heremaps/flatdata","owner":{"login":"heremaps","id":2835506,"avatar_url":"https://avatars0.githubusercontent.com/u/2835506?v=4","gravatar_id":"","url":"https://api.github.com/users/heremaps","html_url":"https://github.com/heremaps","followers_url":"https://api.github.com/users/heremaps/followers","following_url":"https://api.github.com/users/heremaps/following{/other_user}","gists_url":"https://api.github.com/users/heremaps/gists{/gist_id}","starred_url":"https://api.github.com/users/heremaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heremaps/subscriptions","organizations_url":"https://api.github.com/users/heremaps/orgs","repos_url":"https://api.github.com/users/heremaps/repos","events_url":"https://api.github.com/users/heremaps/events{/privacy}","received_events_url":"https://api.github.com/users/heremaps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heremaps/flatdata","description":"Zero copy memory-mapped data storage ","fork":false,"url":"https://api.github.com/repos/heremaps/flatdata","forks_url":"https://api.github.com/repos/heremaps/flatdata/forks","keys_url":"https://api.github.com/repos/heremaps/flatdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heremaps/flatdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heremaps/flatdata/teams","hooks_url":"https://api.github.com/repos/heremaps/flatdata/hooks","issue_events_url":"https://api.github.com/repos/heremaps/flatdata/issues/events{/number}","events_url":"https://api.github.com/repos/heremaps/flatdata/events","assignees_url":"https://api.github.com/repos/heremaps/flatdata/assignees{/user}","branches_url":"https://api.github.com/repos/heremaps/flatdata/branches{/branch}","tags_url":"https://api.github.com/repos/heremaps/flatdata/tags","blobs_url":"https://api.github.com/repos/heremaps/flatdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heremaps/flatdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heremaps/flatdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/heremaps/flatdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heremaps/flatdata/statuses/{sha}","languages_url":"https://api.github.com/repos/heremaps/flatdata/languages","stargazers_url":"https://api.github.com/repos/heremaps/flatdata/stargazers","contributors_url":"https://api.github.com/repos/heremaps/flatdata/contributors","subscribers_url":"https://api.github.com/repos/heremaps/flatdata/subscribers","subscription_url":"https://api.github.com/repos/heremaps/flatdata/subscription","commits_url":"https://api.github.com/repos/heremaps/flatdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/heremaps/flatdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/heremaps/flatdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/heremaps/flatdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/heremaps/flatdata/contents/{+path}","compare_url":"https://api.github.com/repos/heremaps/flatdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heremaps/flatdata/merges","archive_url":"https://api.github.com/repos/heremaps/flatdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heremaps/flatdata/downloads","issues_url":"https://api.github.com/repos/heremaps/flatdata/issues{/number}","pulls_url":"https://api.github.com/repos/heremaps/flatdata/pulls{/number}","milestones_url":"https://api.github.com/repos/heremaps/flatdata/milestones{/number}","notifications_url":"https://api.github.com/repos/heremaps/flatdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heremaps/flatdata/labels{/name}","releases_url":"https://api.github.com/repos/heremaps/flatdata/releases{/id}","deployments_url":"https://api.github.com/repos/heremaps/flatdata/deployments","created_at":"2018-01-18T20:34:58Z","updated_at":"2018-02-08T18:25:59Z","pushed_at":"2018-02-09T09:23:27Z","git_url":"git://github.com/heremaps/flatdata.git","ssh_url":"git@github.com:heremaps/flatdata.git","clone_url":"https://github.com/heremaps/flatdata.git","svn_url":"https://github.com/heremaps/flatdata","homepage":"","size":186,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":18,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/25"},"html":{"href":"https://github.com/heremaps/flatdata/pull/25"},"issue":{"href":"https://api.github.com/repos/heremaps/flatdata/issues/25"},"comments":{"href":"https://api.github.com/repos/heremaps/flatdata/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heremaps/flatdata/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/heremaps/flatdata/statuses/3fbb51c895b8952bde7a51642c06ca6e50341379"}},"author_association":"NONE"}}
{"actor":{"display_login":"VeaaC"}}