{"action":"created","comment":{"url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/comments/175262106","pull_request_review_id":104770427,"id":175262106,"diff_hunk":"@@ -71,24 +72,22 @@ public AddPersonalTaskCommand parse(String task) throws ParseException {\n      * @throws DurationParseException if duration format is invalid\n      * @throws TimingClashException   if there is a timing clash\n      */\n-    public static void parseTask(String task) throws DateTimeParseException,\n-            DurationParseException, TimingClashException, IllegalValueException {\n+    private static void parseTask(String task) throws DateTimeParseException,\n+            DurationParseException, TimingClashException {\n \n         String[] arguments = task.split(\"\\\\s\", MAXIMUM_AMOUNT_OF_TASK_PARAMETER);\n-        if (!canPassInitialCheck(arguments)) {\n-            throw new IllegalValueException(MESSAGE_INVALID_INPUT_FORMAT);\n-        }\n         parseDescription(arguments);\n         try {\n             parseDateTime(arguments);\n             parseDuration(arguments);\n-            Schedule.checkClashes(taskDateTime, duration);\n+            isTaskClash(taskDateTime, duration);\n         } catch (DateTimeParseException dtpe) {\n             throw new DateTimeParseException(MESSAGE_INVALID_DATE_TIME, dtpe.getParsedString(), dtpe.getErrorIndex());\n         } catch (DurationParseException dpe) {","path":"src/main/java/seedu/address/logic/parser/AddPersonalTaskCommandParser.java","position":106,"original_position":106,"commit_id":"2a2f1599a7aa9e624d951c5b7337da80bb393f96","original_commit_id":"2a2f1599a7aa9e624d951c5b7337da80bb393f96","user":{"login":"yungyung04","id":35619973,"avatar_url":"https://avatars2.githubusercontent.com/u/35619973?v=4","gravatar_id":"","url":"https://api.github.com/users/yungyung04","html_url":"https://github.com/yungyung04","followers_url":"https://api.github.com/users/yungyung04/followers","following_url":"https://api.github.com/users/yungyung04/following{/other_user}","gists_url":"https://api.github.com/users/yungyung04/gists{/gist_id}","starred_url":"https://api.github.com/users/yungyung04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yungyung04/subscriptions","organizations_url":"https://api.github.com/users/yungyung04/orgs","repos_url":"https://api.github.com/users/yungyung04/repos","events_url":"https://api.github.com/users/yungyung04/events{/privacy}","received_events_url":"https://api.github.com/users/yungyung04/received_events","type":"User","site_admin":false},"body":"can delete this catch statement since it is also handled in the constructor?","created_at":"2018-03-17T16:04:50Z","updated_at":"2018-03-17T16:04:50Z","html_url":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60#discussion_r175262106","pull_request_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/comments/175262106"},"html":{"href":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60#discussion_r175262106"},"pull_request":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60","id":175693354,"html_url":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60","diff_url":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60.diff","patch_url":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60.patch","issue_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/60","number":60,"state":"open","locked":false,"title":"[V1.2][T11-B1] Cho Chih Tun. Test cases for parsers and time clash","user":{"login":"ChoChihTun","id":33831669,"avatar_url":"https://avatars0.githubusercontent.com/u/33831669?v=4","gravatar_id":"","url":"https://api.github.com/users/ChoChihTun","html_url":"https://github.com/ChoChihTun","followers_url":"https://api.github.com/users/ChoChihTun/followers","following_url":"https://api.github.com/users/ChoChihTun/following{/other_user}","gists_url":"https://api.github.com/users/ChoChihTun/gists{/gist_id}","starred_url":"https://api.github.com/users/ChoChihTun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChoChihTun/subscriptions","organizations_url":"https://api.github.com/users/ChoChihTun/orgs","repos_url":"https://api.github.com/users/ChoChihTun/repos","events_url":"https://api.github.com/users/ChoChihTun/events{/privacy}","received_events_url":"https://api.github.com/users/ChoChihTun/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-17T10:03:26Z","updated_at":"2018-03-17T16:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"574ca07971457ee7ee6c9182a9842ba1d0545f5b","assignee":{"login":"ChoChihTun","id":33831669,"avatar_url":"https://avatars0.githubusercontent.com/u/33831669?v=4","gravatar_id":"","url":"https://api.github.com/users/ChoChihTun","html_url":"https://github.com/ChoChihTun","followers_url":"https://api.github.com/users/ChoChihTun/followers","following_url":"https://api.github.com/users/ChoChihTun/following{/other_user}","gists_url":"https://api.github.com/users/ChoChihTun/gists{/gist_id}","starred_url":"https://api.github.com/users/ChoChihTun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChoChihTun/subscriptions","organizations_url":"https://api.github.com/users/ChoChihTun/orgs","repos_url":"https://api.github.com/users/ChoChihTun/repos","events_url":"https://api.github.com/users/ChoChihTun/events{/privacy}","received_events_url":"https://api.github.com/users/ChoChihTun/received_events","type":"User","site_admin":false},"assignees":[{"login":"ChoChihTun","id":33831669,"avatar_url":"https://avatars0.githubusercontent.com/u/33831669?v=4","gravatar_id":"","url":"https://api.github.com/users/ChoChihTun","html_url":"https://github.com/ChoChihTun","followers_url":"https://api.github.com/users/ChoChihTun/followers","following_url":"https://api.github.com/users/ChoChihTun/following{/other_user}","gists_url":"https://api.github.com/users/ChoChihTun/gists{/gist_id}","starred_url":"https://api.github.com/users/ChoChihTun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChoChihTun/subscriptions","organizations_url":"https://api.github.com/users/ChoChihTun/orgs","repos_url":"https://api.github.com/users/ChoChihTun/repos","events_url":"https://api.github.com/users/ChoChihTun/events{/privacy}","received_events_url":"https://api.github.com/users/ChoChihTun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60/commits","review_comments_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60/comments","review_comment_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/60/comments","statuses_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/statuses/2a2f1599a7aa9e624d951c5b7337da80bb393f96","head":{"label":"ChoChihTun:V1.2","ref":"V1.2","sha":"2a2f1599a7aa9e624d951c5b7337da80bb393f96","user":{"login":"ChoChihTun","id":33831669,"avatar_url":"https://avatars0.githubusercontent.com/u/33831669?v=4","gravatar_id":"","url":"https://api.github.com/users/ChoChihTun","html_url":"https://github.com/ChoChihTun","followers_url":"https://api.github.com/users/ChoChihTun/followers","following_url":"https://api.github.com/users/ChoChihTun/following{/other_user}","gists_url":"https://api.github.com/users/ChoChihTun/gists{/gist_id}","starred_url":"https://api.github.com/users/ChoChihTun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChoChihTun/subscriptions","organizations_url":"https://api.github.com/users/ChoChihTun/orgs","repos_url":"https://api.github.com/users/ChoChihTun/repos","events_url":"https://api.github.com/users/ChoChihTun/events{/privacy}","received_events_url":"https://api.github.com/users/ChoChihTun/received_events","type":"User","site_admin":false},"repo":{"id":123231389,"name":"addressbook-level4","full_name":"ChoChihTun/addressbook-level4","owner":{"login":"ChoChihTun","id":33831669,"avatar_url":"https://avatars0.githubusercontent.com/u/33831669?v=4","gravatar_id":"","url":"https://api.github.com/users/ChoChihTun","html_url":"https://github.com/ChoChihTun","followers_url":"https://api.github.com/users/ChoChihTun/followers","following_url":"https://api.github.com/users/ChoChihTun/following{/other_user}","gists_url":"https://api.github.com/users/ChoChihTun/gists{/gist_id}","starred_url":"https://api.github.com/users/ChoChihTun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChoChihTun/subscriptions","organizations_url":"https://api.github.com/users/ChoChihTun/orgs","repos_url":"https://api.github.com/users/ChoChihTun/repos","events_url":"https://api.github.com/users/ChoChihTun/events{/privacy}","received_events_url":"https://api.github.com/users/ChoChihTun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChoChihTun/addressbook-level4","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/ChoChihTun/addressbook-level4","forks_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/forks","keys_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/events","assignees_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/merges","archive_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/ChoChihTun/addressbook-level4/deployments","created_at":"2018-02-28T04:57:52Z","updated_at":"2018-03-17T00:45:46Z","pushed_at":"2018-03-17T15:15:04Z","git_url":"git://github.com/ChoChihTun/addressbook-level4.git","ssh_url":"git@github.com:ChoChihTun/addressbook-level4.git","clone_url":"https://github.com/ChoChihTun/addressbook-level4.git","svn_url":"https://github.com/ChoChihTun/addressbook-level4","homepage":"https://nus-cs2103-ay1718s2.github.io/addressbook-level4/","size":8613,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103JAN2018-T11-B1:master","ref":"master","sha":"6f98d64547ec380cb849c36012a07df1fa701be4","user":{"login":"CS2103JAN2018-T11-B1","id":36795815,"avatar_url":"https://avatars3.githubusercontent.com/u/36795815?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-T11-B1","html_url":"https://github.com/CS2103JAN2018-T11-B1","followers_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/followers","following_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/repos","events_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/received_events","type":"Organization","site_admin":false},"repo":{"id":123225689,"name":"main","full_name":"CS2103JAN2018-T11-B1/main","owner":{"login":"CS2103JAN2018-T11-B1","id":36795815,"avatar_url":"https://avatars3.githubusercontent.com/u/36795815?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-T11-B1","html_url":"https://github.com/CS2103JAN2018-T11-B1","followers_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/followers","following_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/repos","events_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-T11-B1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS2103JAN2018-T11-B1/main","description":"TuitionConnect (TC) application:","fork":true,"url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main","forks_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/forks","keys_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/teams","hooks_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/events","assignees_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/tags","blobs_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/languages","stargazers_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/subscription","commits_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/merges","archive_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/downloads","issues_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/deployments","created_at":"2018-02-28T03:47:23Z","updated_at":"2018-03-17T15:20:05Z","pushed_at":"2018-03-17T15:25:45Z","git_url":"git://github.com/CS2103JAN2018-T11-B1/main.git","ssh_url":"git@github.com:CS2103JAN2018-T11-B1/main.git","clone_url":"https://github.com/CS2103JAN2018-T11-B1/main.git","svn_url":"https://github.com/CS2103JAN2018-T11-B1/main","homepage":"https://cs2103jan2018-t11-b1.github.io/main/","size":8601,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":4,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60"},"html":{"href":"https://github.com/CS2103JAN2018-T11-B1/main/pull/60"},"issue":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/60"},"comments":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103JAN2018-T11-B1/main/statuses/2a2f1599a7aa9e624d951c5b7337da80bb393f96"}},"author_association":"NONE"}}
{"actor":{"display_login":"yungyung04"}}