{"action":"created","issue":{"url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/56","repository_url":"https://api.github.com/repos/TriBITSPub/TriBITS","labels_url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/56/comments","events_url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/56/events","html_url":"https://github.com/TriBITSPub/TriBITS/issues/56","id":59865175,"node_id":"MDU6SXNzdWU1OTg2NTE3NQ==","number":56,"title":"Packages required only for tests are built even when tests are disabled","user":{"login":"kddevin","id":9597421,"node_id":"MDQ6VXNlcjk1OTc0MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9597421?v=4","gravatar_id":"","url":"https://api.github.com/users/kddevin","html_url":"https://github.com/kddevin","followers_url":"https://api.github.com/users/kddevin/followers","following_url":"https://api.github.com/users/kddevin/following{/other_user}","gists_url":"https://api.github.com/users/kddevin/gists{/gist_id}","starred_url":"https://api.github.com/users/kddevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddevin/subscriptions","organizations_url":"https://api.github.com/users/kddevin/orgs","repos_url":"https://api.github.com/users/kddevin/repos","events_url":"https://api.github.com/users/kddevin/events{/privacy}","received_events_url":"https://api.github.com/users/kddevin/received_events","type":"User","site_admin":false},"labels":[{"id":328775939,"node_id":"MDU6TGFiZWwzMjg3NzU5Mzk=","url":"https://api.github.com/repos/TriBITSPub/TriBITS/labels/stage:%20ready","name":"stage: ready","color":"ededed","default":false},{"id":126954505,"node_id":"MDU6TGFiZWwxMjY5NTQ1MDU=","url":"https://api.github.com/repos/TriBITSPub/TriBITS/labels/type:%20bug","name":"type: bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"bartlettroscoe","id":1959736,"node_id":"MDQ6VXNlcjE5NTk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false},"assignees":[{"login":"bartlettroscoe","id":1959736,"node_id":"MDQ6VXNlcjE5NTk3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1959736?v=4","gravatar_id":"","url":"https://api.github.com/users/bartlettroscoe","html_url":"https://github.com/bartlettroscoe","followers_url":"https://api.github.com/users/bartlettroscoe/followers","following_url":"https://api.github.com/users/bartlettroscoe/following{/other_user}","gists_url":"https://api.github.com/users/bartlettroscoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bartlettroscoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartlettroscoe/subscriptions","organizations_url":"https://api.github.com/users/bartlettroscoe/orgs","repos_url":"https://api.github.com/users/bartlettroscoe/repos","events_url":"https://api.github.com/users/bartlettroscoe/events{/privacy}","received_events_url":"https://api.github.com/users/bartlettroscoe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2015-03-04T21:30:22Z","updated_at":"2018-07-01T20:14:23Z","closed_at":null,"author_association":"NONE","body":"Ross and I have discussed this issue already, but I wanted to record it so that I don't forget about it.\n\nPackages that are required only for tests (via TEST_REQUIRED_DEP_PACKAGES) are built even when all tests are disabled.  These required dependencies should be built only if tests are enabled.\n\nThe following Trilinos configuration demonstrates this problem:\n\n```\ncmake \\\n-D CMAKE_BUILD_TYPE:STRING=\"DEBUG\" \\\n-D TPL_ENABLE_MPI:BOOL=ON \\\n-D MPI_EXEC_MAX_NUMPROCS:STRING=11 \\\n-D TPL_ENABLE_BinUtils:BOOL=OFF \\\n-D TPL_ENABLE_Pthread:BOOL=OFF \\\n\\\n-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=OFF \\\n-D Trilinos_ENABLE_TESTS:BOOL=OFF \\\n-D Trilinos_ENABLE_EXAMPLES:BOOL=OFF \\\n-D Trilinos_ENABLE_Fortran:BOOL=OFF \\\n\\\n-D Trilinos_ENABLE_Zoltan2:BOOL=ON \\\n-D Zoltan2_ENABLE_Experimental:BOOL=ON \\\n\\\n-D Teuchos_ENABLE_STACKTRACE:BOOL=OFF \\\n-D Teuchos_ENABLE_LONG_LONG_INT:BOOL=ON \\\n..\n```\n\nOnly Zoltan2 is enabled.  Packages pamgen and galeri are needed only for Zoltan2 tests, which are disabled.  Yet these two packages are both built anyway.\n\nIn my build directory,\n\n```\n% ls packages/\nepetra/         kokkos/         teuchos/        xpetra/\ngaleri/         pamgen/         tpetra/         zoltan2/\n```\n"},"comment":{"url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/comments/401630313","html_url":"https://github.com/TriBITSPub/TriBITS/issues/56#issuecomment-401630313","issue_url":"https://api.github.com/repos/TriBITSPub/TriBITS/issues/56","id":401630313,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTYzMDMxMw==","user":{"login":"sethrj","id":741229,"node_id":"MDQ6VXNlcjc0MTIyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/741229?v=4","gravatar_id":"","url":"https://api.github.com/users/sethrj","html_url":"https://github.com/sethrj","followers_url":"https://api.github.com/users/sethrj/followers","following_url":"https://api.github.com/users/sethrj/following{/other_user}","gists_url":"https://api.github.com/users/sethrj/gists{/gist_id}","starred_url":"https://api.github.com/users/sethrj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethrj/subscriptions","organizations_url":"https://api.github.com/users/sethrj/orgs","repos_url":"https://api.github.com/users/sethrj/repos","events_url":"https://api.github.com/users/sethrj/events{/privacy}","received_events_url":"https://api.github.com/users/sethrj/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T20:14:23Z","updated_at":"2018-07-01T20:14:23Z","author_association":"CONTRIBUTOR","body":"@bartlettroscoe Since simply changing the behavior outright would affect so many projects, couldn't you make a project-wide option to enable optional/required test dependencies after the tests are enabled? I could also imagine this requiring multiple iterations of sweeping through packages, then sweeping through enable tests..."}}
{"actor":{"display_login":"sethrj"}}