{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/230243859","pull_request_review_id":170938367,"id":230243859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDI0Mzg1OQ==","diff_hunk":"@@ -1185,6 +1245,11 @@ TR_ResolvedJ9JITaaSServerMethod::createResolvedJ9MethodMirror(TR_ResolvedJ9JITaa\n    std::string methodInfoStr = bodyInfo ? std::string((char*)bodyInfo->getMethodInfo(), sizeof(TR_PersistentMethodInfo)) : std::string();\n    std::get<1>(methodInfo) = jbi;\n    std::get<2>(methodInfo) = methodInfoStr;\n+\n+   // set IP method data string.\n+   // fanin info is not used at cold opt level, so there is no point sending this information to the server\n+   TR_JITaaSClientIProfiler *iProfiler = (TR_JITaaSClientIProfiler *)((TR_J9VMBase *) fe)->getIProfiler();\n+   std::get<3>(methodInfo) = (TR::comp() && TR::comp()->getOptLevel() >= warm && iProfiler) ? iProfiler->serializeIProfilerMethodEntry(method) : std::string();","path":"runtime/compiler/env/j9methodServer.cpp","position":75,"original_position":75,"commit_id":"60c190c44da07b7e1a748ee5a71402bd064308a6","original_commit_id":"60c190c44da07b7e1a748ee5a71402bd064308a6","user":{"login":"mpirvu","id":22594880,"node_id":"MDQ6VXNlcjIyNTk0ODgw","avatar_url":"https://avatars1.githubusercontent.com/u/22594880?v=4","gravatar_id":"","url":"https://api.github.com/users/mpirvu","html_url":"https://github.com/mpirvu","followers_url":"https://api.github.com/users/mpirvu/followers","following_url":"https://api.github.com/users/mpirvu/following{/other_user}","gists_url":"https://api.github.com/users/mpirvu/gists{/gist_id}","starred_url":"https://api.github.com/users/mpirvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpirvu/subscriptions","organizations_url":"https://api.github.com/users/mpirvu/orgs","repos_url":"https://api.github.com/users/mpirvu/repos","events_url":"https://api.github.com/users/mpirvu/events{/privacy}","received_events_url":"https://api.github.com/users/mpirvu/received_events","type":"User","site_admin":false},"body":"Is it ever possible for TR::comp() to return 0 at this point?","created_at":"2018-11-02T00:47:57Z","updated_at":"2018-11-02T00:47:57Z","html_url":"https://github.com/eclipse/openj9/pull/3460#discussion_r230243859","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/3460","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/230243859"},"html":{"href":"https://github.com/eclipse/openj9/pull/3460#discussion_r230243859"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3460"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3460","id":226155144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTU1MTQ0","html_url":"https://github.com/eclipse/openj9/pull/3460","diff_url":"https://github.com/eclipse/openj9/pull/3460.diff","patch_url":"https://github.com/eclipse/openj9/pull/3460.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3460","number":3460,"state":"open","locked":false,"title":"Reduce number of messages related to inlining","user":{"login":"dmitry-ten","id":13917464,"node_id":"MDQ6VXNlcjEzOTE3NDY0","avatar_url":"https://avatars0.githubusercontent.com/u/13917464?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-ten","html_url":"https://github.com/dmitry-ten","followers_url":"https://api.github.com/users/dmitry-ten/followers","following_url":"https://api.github.com/users/dmitry-ten/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-ten/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-ten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-ten/subscriptions","organizations_url":"https://api.github.com/users/dmitry-ten/orgs","repos_url":"https://api.github.com/users/dmitry-ten/repos","events_url":"https://api.github.com/users/dmitry-ten/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-ten/received_events","type":"User","site_admin":false},"body":"- Eliminate `CompInfo_isCompiled` messages by replacing\r\na remote call with checking whether a resolved method\r\nis not interpreted. It is the same thing, but isInterpreted\r\nis already cached in resolved method.\r\n\r\n- Reduce number of calls to `IProfiler_searchForMethodSample`.\r\nReplace calls to `fe->getNumberofCallersAndTotalWeight` and `fe->getOtherBucketWeight` with a call to `resolvedMethod->getFaninInfo`.\r\nReplace call to `fe->getCallerWeight` with `resolvedMethod->getCallerWeight`.\r\nThis enables us to get number and weight of callers, total weight and\r\nother bucket weight at the creation of client-side mirror\r\nand cache these values\r\non the server.\r\nWhile the number of callers and their weights might change\r\nduring a compilation, this should be a good enough approximation.\r\n\r\nAddresses:#3401","created_at":"2018-10-26T16:24:55Z","updated_at":"2018-11-02T00:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff19f4eefab10199c50250e2ef5d7e038aa141f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1065695685,"node_id":"MDU6TGFiZWwxMDY1Njk1Njg1","url":"https://api.github.com/repos/eclipse/openj9/labels/jitaas","name":"jitaas","color":"003df7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3460/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3460/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3460/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/60c190c44da07b7e1a748ee5a71402bd064308a6","head":{"label":"dmitry-ten:big_method","ref":"big_method","sha":"60c190c44da07b7e1a748ee5a71402bd064308a6","user":{"login":"dmitry-ten","id":13917464,"node_id":"MDQ6VXNlcjEzOTE3NDY0","avatar_url":"https://avatars0.githubusercontent.com/u/13917464?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-ten","html_url":"https://github.com/dmitry-ten","followers_url":"https://api.github.com/users/dmitry-ten/followers","following_url":"https://api.github.com/users/dmitry-ten/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-ten/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-ten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-ten/subscriptions","organizations_url":"https://api.github.com/users/dmitry-ten/orgs","repos_url":"https://api.github.com/users/dmitry-ten/repos","events_url":"https://api.github.com/users/dmitry-ten/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-ten/received_events","type":"User","site_admin":false},"repo":{"id":132659373,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2NTkzNzM=","name":"openj9","full_name":"dmitry-ten/openj9","private":false,"owner":{"login":"dmitry-ten","id":13917464,"node_id":"MDQ6VXNlcjEzOTE3NDY0","avatar_url":"https://avatars0.githubusercontent.com/u/13917464?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-ten","html_url":"https://github.com/dmitry-ten","followers_url":"https://api.github.com/users/dmitry-ten/followers","following_url":"https://api.github.com/users/dmitry-ten/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-ten/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-ten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-ten/subscriptions","organizations_url":"https://api.github.com/users/dmitry-ten/orgs","repos_url":"https://api.github.com/users/dmitry-ten/repos","events_url":"https://api.github.com/users/dmitry-ten/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-ten/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitry-ten/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/dmitry-ten/openj9","forks_url":"https://api.github.com/repos/dmitry-ten/openj9/forks","keys_url":"https://api.github.com/repos/dmitry-ten/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitry-ten/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitry-ten/openj9/teams","hooks_url":"https://api.github.com/repos/dmitry-ten/openj9/hooks","issue_events_url":"https://api.github.com/repos/dmitry-ten/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/dmitry-ten/openj9/events","assignees_url":"https://api.github.com/repos/dmitry-ten/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/dmitry-ten/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/dmitry-ten/openj9/tags","blobs_url":"https://api.github.com/repos/dmitry-ten/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitry-ten/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitry-ten/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitry-ten/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitry-ten/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitry-ten/openj9/languages","stargazers_url":"https://api.github.com/repos/dmitry-ten/openj9/stargazers","contributors_url":"https://api.github.com/repos/dmitry-ten/openj9/contributors","subscribers_url":"https://api.github.com/repos/dmitry-ten/openj9/subscribers","subscription_url":"https://api.github.com/repos/dmitry-ten/openj9/subscription","commits_url":"https://api.github.com/repos/dmitry-ten/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitry-ten/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitry-ten/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitry-ten/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitry-ten/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/dmitry-ten/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitry-ten/openj9/merges","archive_url":"https://api.github.com/repos/dmitry-ten/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitry-ten/openj9/downloads","issues_url":"https://api.github.com/repos/dmitry-ten/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/dmitry-ten/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitry-ten/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitry-ten/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitry-ten/openj9/labels{/name}","releases_url":"https://api.github.com/repos/dmitry-ten/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/dmitry-ten/openj9/deployments","created_at":"2018-05-08T20:09:50Z","updated_at":"2018-06-08T16:46:38Z","pushed_at":"2018-11-01T21:08:35Z","git_url":"git://github.com/dmitry-ten/openj9.git","ssh_url":"git@github.com:dmitry-ten/openj9.git","clone_url":"https://github.com/dmitry-ten/openj9.git","svn_url":"https://github.com/dmitry-ten/openj9","homepage":"","size":37947,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:jitaas","ref":"jitaas","sha":"6bd3e7e9ed88289a8bb1717da068c7f110099f48","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-11-01T23:32:27Z","pushed_at":"2018-11-01T23:32:10Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":37870,"stargazers_count":1510,"watchers_count":1510,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"archived":false,"open_issues_count":572,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":293,"open_issues":572,"watchers":1510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3460"},"html":{"href":"https://github.com/eclipse/openj9/pull/3460"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3460"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3460/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3460/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3460/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/60c190c44da07b7e1a748ee5a71402bd064308a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpirvu"}}