{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/168281803","pull_request_review_id":96624072,"id":168281803,"diff_hunk":"@@ -43,34 +43,39 @@\n \n \n @tags('cray', 'mom')\n-class TestBasilInventory(TestFunctional):\n+class TestBasilQuery(TestFunctional):","path":"test/tests/functional/pbs_apbasil_inventory.py","position":5,"original_position":5,"commit_id":"ad34af01e1205234659f077c3346d04918a74b71","original_commit_id":"3bfc20b3c82825568531a943f5d9ef4303b1bf3c","user":{"login":"dilip-krishnan","id":17922772,"avatar_url":"https://avatars3.githubusercontent.com/u/17922772?v=4","gravatar_id":"","url":"https://api.github.com/users/dilip-krishnan","html_url":"https://github.com/dilip-krishnan","followers_url":"https://api.github.com/users/dilip-krishnan/followers","following_url":"https://api.github.com/users/dilip-krishnan/following{/other_user}","gists_url":"https://api.github.com/users/dilip-krishnan/gists{/gist_id}","starred_url":"https://api.github.com/users/dilip-krishnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilip-krishnan/subscriptions","organizations_url":"https://api.github.com/users/dilip-krishnan/orgs","repos_url":"https://api.github.com/users/dilip-krishnan/repos","events_url":"https://api.github.com/users/dilip-krishnan/events{/privacy}","received_events_url":"https://api.github.com/users/dilip-krishnan/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-02-14T19:20:03Z","updated_at":"2018-02-14T19:20:03Z","html_url":"https://github.com/PBSPro/pbspro/pull/529#discussion_r168281803","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/168281803"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/529#discussion_r168281803"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/529"}},"in_reply_to_id":168052415},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/529","id":164005757,"html_url":"https://github.com/PBSPro/pbspro/pull/529","diff_url":"https://github.com/PBSPro/pbspro/pull/529.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/529.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/529","number":529,"state":"open","locked":false,"title":"PP-706 Automatically create KNL specific information","user":{"login":"dilip-krishnan","id":17922772,"avatar_url":"https://avatars3.githubusercontent.com/u/17922772?v=4","gravatar_id":"","url":"https://api.github.com/users/dilip-krishnan","html_url":"https://github.com/dilip-krishnan","followers_url":"https://api.github.com/users/dilip-krishnan/followers","following_url":"https://api.github.com/users/dilip-krishnan/following{/other_user}","gists_url":"https://api.github.com/users/dilip-krishnan/gists{/gist_id}","starred_url":"https://api.github.com/users/dilip-krishnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilip-krishnan/subscriptions","organizations_url":"https://api.github.com/users/dilip-krishnan/orgs","repos_url":"https://api.github.com/users/dilip-krishnan/repos","events_url":"https://api.github.com/users/dilip-krishnan/events{/privacy}","received_events_url":"https://api.github.com/users/dilip-krishnan/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\n* Automatically create KNL specific information\r\n*[PP-706](https://pbspro.atlassian.net/browse/PP-706)*\r\n\r\n#### Affected Platform(s) and PBS Version\r\n* Changes are specific for Cray cluster, with bootable processor capability. \r\n\r\n#### Cause / Analysis / Design\r\nAs part of the BASIL 1.7 project, we will be making a System Query to get KNL Node information. One vnode per KNL node will be created using this information.\r\n\r\nIn the current system, we make an Inventory (BASIL 1.4) Query to get Inventory information. Vnodes are created for compute nodes based on this information.\r\n\r\nWe are currently at BASIL 1.4. For BASIL 1.5 and 1.6, changes have not been implemented in PBS. This project aims to support the BASIL 1.7 System Query for KNL nodes only.\r\n\r\nAt some point in the future, we may migrate from the the existing Inventory (BASIL 1.4) Query and implement the Inventory (BASIL 1.7) Query.\r\n\r\nDefinitions:\r\n\r\nA Node may have one or more Microprocessors/Sockets.\r\nEach Socket may have one or more Segments (also known as NUMA Nodes).\r\nEach Segment may have one or more CPUs.\r\nIn the current system, for non-KNL nodes returned as part of the Inventory (BASIL 1.4) Query, we create a vnode per Segment( vnode_per_numa_node=True). The PBScrayseg attribute of the created vnode will reflect the segment ordinal e.g.\r\n\r\nfor ordinal=0, PBScrayseg=0, for ordinal=1, PBScrayseg=1 etc.\r\n\r\nIn the current system, for KNL nodes returned as part of the Inventory (BASIL 1.4) Query, we create 1 vnode per Node (the segment ordinal for KNL Nodes is set to 0 & PBScrayseg = 0).\r\n\r\nThe System (BASIL 1.7) Query returns grouped information (attributes) that apply to a range of Nodes.\r\n\r\nThe numa_nodes attribute will reflect the number of NUMA Nodes/Segments this KNL Node has. Regardless, we will be creating 1 vnode per KNL Node.\r\n\r\nAdditional attributes such as numa_cfg, hbm_cache_pct and hbm_size_mb will also be considered when creating KNL vnodes.\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [ ] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [x] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/spaces/PD/pages/68845606/PP-706+Automatically+create+KNL+specific+information)** for details.\r\n- [x] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [x] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-01-19T16:02:55Z","updated_at":"2018-02-14T19:20:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbae38a01d73df24ae2ab33388d79565ac666630","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/529/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/529/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/529/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/ad34af01e1205234659f077c3346d04918a74b71","head":{"label":"dilip-krishnan:PP-706","ref":"PP-706","sha":"ad34af01e1205234659f077c3346d04918a74b71","user":{"login":"dilip-krishnan","id":17922772,"avatar_url":"https://avatars3.githubusercontent.com/u/17922772?v=4","gravatar_id":"","url":"https://api.github.com/users/dilip-krishnan","html_url":"https://github.com/dilip-krishnan","followers_url":"https://api.github.com/users/dilip-krishnan/followers","following_url":"https://api.github.com/users/dilip-krishnan/following{/other_user}","gists_url":"https://api.github.com/users/dilip-krishnan/gists{/gist_id}","starred_url":"https://api.github.com/users/dilip-krishnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilip-krishnan/subscriptions","organizations_url":"https://api.github.com/users/dilip-krishnan/orgs","repos_url":"https://api.github.com/users/dilip-krishnan/repos","events_url":"https://api.github.com/users/dilip-krishnan/events{/privacy}","received_events_url":"https://api.github.com/users/dilip-krishnan/received_events","type":"User","site_admin":false},"repo":{"id":63232421,"name":"pbspro","full_name":"dilip-krishnan/pbspro","owner":{"login":"dilip-krishnan","id":17922772,"avatar_url":"https://avatars3.githubusercontent.com/u/17922772?v=4","gravatar_id":"","url":"https://api.github.com/users/dilip-krishnan","html_url":"https://github.com/dilip-krishnan","followers_url":"https://api.github.com/users/dilip-krishnan/followers","following_url":"https://api.github.com/users/dilip-krishnan/following{/other_user}","gists_url":"https://api.github.com/users/dilip-krishnan/gists{/gist_id}","starred_url":"https://api.github.com/users/dilip-krishnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilip-krishnan/subscriptions","organizations_url":"https://api.github.com/users/dilip-krishnan/orgs","repos_url":"https://api.github.com/users/dilip-krishnan/repos","events_url":"https://api.github.com/users/dilip-krishnan/events{/privacy}","received_events_url":"https://api.github.com/users/dilip-krishnan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilip-krishnan/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/dilip-krishnan/pbspro","forks_url":"https://api.github.com/repos/dilip-krishnan/pbspro/forks","keys_url":"https://api.github.com/repos/dilip-krishnan/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilip-krishnan/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilip-krishnan/pbspro/teams","hooks_url":"https://api.github.com/repos/dilip-krishnan/pbspro/hooks","issue_events_url":"https://api.github.com/repos/dilip-krishnan/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/dilip-krishnan/pbspro/events","assignees_url":"https://api.github.com/repos/dilip-krishnan/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/dilip-krishnan/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/dilip-krishnan/pbspro/tags","blobs_url":"https://api.github.com/repos/dilip-krishnan/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilip-krishnan/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilip-krishnan/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilip-krishnan/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilip-krishnan/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/dilip-krishnan/pbspro/languages","stargazers_url":"https://api.github.com/repos/dilip-krishnan/pbspro/stargazers","contributors_url":"https://api.github.com/repos/dilip-krishnan/pbspro/contributors","subscribers_url":"https://api.github.com/repos/dilip-krishnan/pbspro/subscribers","subscription_url":"https://api.github.com/repos/dilip-krishnan/pbspro/subscription","commits_url":"https://api.github.com/repos/dilip-krishnan/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilip-krishnan/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilip-krishnan/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilip-krishnan/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilip-krishnan/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/dilip-krishnan/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilip-krishnan/pbspro/merges","archive_url":"https://api.github.com/repos/dilip-krishnan/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilip-krishnan/pbspro/downloads","issues_url":"https://api.github.com/repos/dilip-krishnan/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/dilip-krishnan/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/dilip-krishnan/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/dilip-krishnan/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilip-krishnan/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/dilip-krishnan/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/dilip-krishnan/pbspro/deployments","created_at":"2016-07-13T09:18:08Z","updated_at":"2016-07-13T09:18:13Z","pushed_at":"2018-02-14T13:22:53Z","git_url":"git://github.com/dilip-krishnan/pbspro.git","ssh_url":"git@github.com:dilip-krishnan/pbspro.git","clone_url":"https://github.com/dilip-krishnan/pbspro.git","svn_url":"https://github.com/dilip-krishnan/pbspro","homepage":"www.pbspro.org","size":10264,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"15893270ffd89209890819767c67bf2589230148","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-02-07T01:02:35Z","pushed_at":"2018-02-14T16:20:32Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":10227,"stargazers_count":143,"watchers_count":143,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":125,"open_issues":15,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/529"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/529"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/529"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/ad34af01e1205234659f077c3346d04918a74b71"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dilip-krishnan"}}