{"action":"created","comment":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/comments/219220776","pull_request_review_id":157344901,"id":219220776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTIyMDc3Ng==","diff_hunk":"@@ -7,6 +7,8 @@ function DashboardContentTitle (props) {\n }\n \n function PanelTopBar (props) {\n+  const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount","path":"packages/@uppy/dashboard/src/components/PanelTopBar.js","position":null,"original_position":4,"commit_id":"b2206f636fd9186cafe378ee3aadd65bad2b1065","original_commit_id":"ac945e146052d383788e70342d0f96d74c8b8fd6","user":{"login":"arturi","id":1199054,"node_id":"MDQ6VXNlcjExOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199054?v=4","gravatar_id":"","url":"https://api.github.com/users/arturi","html_url":"https://github.com/arturi","followers_url":"https://api.github.com/users/arturi/followers","following_url":"https://api.github.com/users/arturi/following{/other_user}","gists_url":"https://api.github.com/users/arturi/gists{/gist_id}","starred_url":"https://api.github.com/users/arturi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturi/subscriptions","organizations_url":"https://api.github.com/users/arturi/orgs","repos_url":"https://api.github.com/users/arturi/repos","events_url":"https://api.github.com/users/arturi/events{/privacy}","received_events_url":"https://api.github.com/users/arturi/received_events","type":"User","site_admin":false},"body":"Updated, like this?","created_at":"2018-09-20T15:54:40Z","updated_at":"2018-09-20T15:54:40Z","html_url":"https://github.com/transloadit/uppy/pull/1063#discussion_r219220776","pull_request_url":"https://api.github.com/repos/transloadit/uppy/pulls/1063","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/comments/219220776"},"html":{"href":"https://github.com/transloadit/uppy/pull/1063#discussion_r219220776"},"pull_request":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1063"}},"in_reply_to_id":219095846},"pull_request":{"url":"https://api.github.com/repos/transloadit/uppy/pulls/1063","id":216835094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODM1MDk0","html_url":"https://github.com/transloadit/uppy/pull/1063","diff_url":"https://github.com/transloadit/uppy/pull/1063.diff","patch_url":"https://github.com/transloadit/uppy/pull/1063.patch","issue_url":"https://api.github.com/repos/transloadit/uppy/issues/1063","number":1063,"state":"open","locked":false,"title":"[@uppy/dashboard] Only show the plus button if selected file count !== maxNumberOfFiles","user":{"login":"arturi","id":1199054,"node_id":"MDQ6VXNlcjExOTkwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199054?v=4","gravatar_id":"","url":"https://api.github.com/users/arturi","html_url":"https://github.com/arturi","followers_url":"https://api.github.com/users/arturi/followers","following_url":"https://api.github.com/users/arturi/following{/other_user}","gists_url":"https://api.github.com/users/arturi/gists{/gist_id}","starred_url":"https://api.github.com/users/arturi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturi/subscriptions","organizations_url":"https://api.github.com/users/arturi/orgs","repos_url":"https://api.github.com/users/arturi/repos","events_url":"https://api.github.com/users/arturi/events{/privacy}","received_events_url":"https://api.github.com/users/arturi/received_events","type":"User","site_admin":false},"body":"When you can only select 2 files and 2 are already selected, it makes no sense to show a plus button in the Dashboard. This PR fixes that.\r\n\r\n> Hi, I have to handle each image separately in the application by assigning each image several properties, such as date, credit, photographer and so on. It doesn't make sense to support multiple files for that particular interface. I can set the max number of files to 1, however the Dashboard interface could be confusing to users since they present the add (+) button when a file has already been picked while I'd prefer to tell Dashboard to not display that button by either enabling some single-selection mode or by having it behaving differently by not showing that button when the number of files has already reached its limit.\r\n\r\nFixes https://github.com/transloadit/uppy/issues/1061","created_at":"2018-09-20T03:32:49Z","updated_at":"2018-09-20T15:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"728d81ac069a6073c3be842c25dc43b975c7b359","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transloadit/uppy/pulls/1063/commits","review_comments_url":"https://api.github.com/repos/transloadit/uppy/pulls/1063/comments","review_comment_url":"https://api.github.com/repos/transloadit/uppy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transloadit/uppy/issues/1063/comments","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/b2206f636fd9186cafe378ee3aadd65bad2b1065","head":{"label":"transloadit:improvement/dashboard-plusBtn-limit","ref":"improvement/dashboard-plusBtn-limit","sha":"b2206f636fd9186cafe378ee3aadd65bad2b1065","user":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"repo":{"id":46273445,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI3MzQ0NQ==","name":"uppy","full_name":"transloadit/uppy","private":false,"owner":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transloadit/uppy","description":"The next open source file uploader for web browsers :dog: ","fork":false,"url":"https://api.github.com/repos/transloadit/uppy","forks_url":"https://api.github.com/repos/transloadit/uppy/forks","keys_url":"https://api.github.com/repos/transloadit/uppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transloadit/uppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transloadit/uppy/teams","hooks_url":"https://api.github.com/repos/transloadit/uppy/hooks","issue_events_url":"https://api.github.com/repos/transloadit/uppy/issues/events{/number}","events_url":"https://api.github.com/repos/transloadit/uppy/events","assignees_url":"https://api.github.com/repos/transloadit/uppy/assignees{/user}","branches_url":"https://api.github.com/repos/transloadit/uppy/branches{/branch}","tags_url":"https://api.github.com/repos/transloadit/uppy/tags","blobs_url":"https://api.github.com/repos/transloadit/uppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transloadit/uppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transloadit/uppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/transloadit/uppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/{sha}","languages_url":"https://api.github.com/repos/transloadit/uppy/languages","stargazers_url":"https://api.github.com/repos/transloadit/uppy/stargazers","contributors_url":"https://api.github.com/repos/transloadit/uppy/contributors","subscribers_url":"https://api.github.com/repos/transloadit/uppy/subscribers","subscription_url":"https://api.github.com/repos/transloadit/uppy/subscription","commits_url":"https://api.github.com/repos/transloadit/uppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/transloadit/uppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/transloadit/uppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/transloadit/uppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/transloadit/uppy/contents/{+path}","compare_url":"https://api.github.com/repos/transloadit/uppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transloadit/uppy/merges","archive_url":"https://api.github.com/repos/transloadit/uppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transloadit/uppy/downloads","issues_url":"https://api.github.com/repos/transloadit/uppy/issues{/number}","pulls_url":"https://api.github.com/repos/transloadit/uppy/pulls{/number}","milestones_url":"https://api.github.com/repos/transloadit/uppy/milestones{/number}","notifications_url":"https://api.github.com/repos/transloadit/uppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transloadit/uppy/labels{/name}","releases_url":"https://api.github.com/repos/transloadit/uppy/releases{/id}","deployments_url":"https://api.github.com/repos/transloadit/uppy/deployments","created_at":"2015-11-16T12:32:33Z","updated_at":"2018-09-20T15:50:12Z","pushed_at":"2018-09-20T15:54:32Z","git_url":"git://github.com/transloadit/uppy.git","ssh_url":"git@github.com:transloadit/uppy.git","clone_url":"https://github.com/transloadit/uppy.git","svn_url":"https://github.com/transloadit/uppy","homepage":"https://uppy.io","size":200975,"stargazers_count":11923,"watchers_count":11923,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":512,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":512,"open_issues":97,"watchers":11923,"default_branch":"master"}},"base":{"label":"transloadit:master","ref":"master","sha":"4c3b302d0b406699a1d490bd9a8e8bc342c3217f","user":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"repo":{"id":46273445,"node_id":"MDEwOlJlcG9zaXRvcnk0NjI3MzQ0NQ==","name":"uppy","full_name":"transloadit/uppy","private":false,"owner":{"login":"transloadit","id":125754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTc1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/125754?v=4","gravatar_id":"","url":"https://api.github.com/users/transloadit","html_url":"https://github.com/transloadit","followers_url":"https://api.github.com/users/transloadit/followers","following_url":"https://api.github.com/users/transloadit/following{/other_user}","gists_url":"https://api.github.com/users/transloadit/gists{/gist_id}","starred_url":"https://api.github.com/users/transloadit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transloadit/subscriptions","organizations_url":"https://api.github.com/users/transloadit/orgs","repos_url":"https://api.github.com/users/transloadit/repos","events_url":"https://api.github.com/users/transloadit/events{/privacy}","received_events_url":"https://api.github.com/users/transloadit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transloadit/uppy","description":"The next open source file uploader for web browsers :dog: ","fork":false,"url":"https://api.github.com/repos/transloadit/uppy","forks_url":"https://api.github.com/repos/transloadit/uppy/forks","keys_url":"https://api.github.com/repos/transloadit/uppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transloadit/uppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transloadit/uppy/teams","hooks_url":"https://api.github.com/repos/transloadit/uppy/hooks","issue_events_url":"https://api.github.com/repos/transloadit/uppy/issues/events{/number}","events_url":"https://api.github.com/repos/transloadit/uppy/events","assignees_url":"https://api.github.com/repos/transloadit/uppy/assignees{/user}","branches_url":"https://api.github.com/repos/transloadit/uppy/branches{/branch}","tags_url":"https://api.github.com/repos/transloadit/uppy/tags","blobs_url":"https://api.github.com/repos/transloadit/uppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transloadit/uppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transloadit/uppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/transloadit/uppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transloadit/uppy/statuses/{sha}","languages_url":"https://api.github.com/repos/transloadit/uppy/languages","stargazers_url":"https://api.github.com/repos/transloadit/uppy/stargazers","contributors_url":"https://api.github.com/repos/transloadit/uppy/contributors","subscribers_url":"https://api.github.com/repos/transloadit/uppy/subscribers","subscription_url":"https://api.github.com/repos/transloadit/uppy/subscription","commits_url":"https://api.github.com/repos/transloadit/uppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/transloadit/uppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/transloadit/uppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/transloadit/uppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/transloadit/uppy/contents/{+path}","compare_url":"https://api.github.com/repos/transloadit/uppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transloadit/uppy/merges","archive_url":"https://api.github.com/repos/transloadit/uppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transloadit/uppy/downloads","issues_url":"https://api.github.com/repos/transloadit/uppy/issues{/number}","pulls_url":"https://api.github.com/repos/transloadit/uppy/pulls{/number}","milestones_url":"https://api.github.com/repos/transloadit/uppy/milestones{/number}","notifications_url":"https://api.github.com/repos/transloadit/uppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transloadit/uppy/labels{/name}","releases_url":"https://api.github.com/repos/transloadit/uppy/releases{/id}","deployments_url":"https://api.github.com/repos/transloadit/uppy/deployments","created_at":"2015-11-16T12:32:33Z","updated_at":"2018-09-20T15:50:12Z","pushed_at":"2018-09-20T15:54:32Z","git_url":"git://github.com/transloadit/uppy.git","ssh_url":"git@github.com:transloadit/uppy.git","clone_url":"https://github.com/transloadit/uppy.git","svn_url":"https://github.com/transloadit/uppy","homepage":"https://uppy.io","size":200975,"stargazers_count":11923,"watchers_count":11923,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":512,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":512,"open_issues":97,"watchers":11923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1063"},"html":{"href":"https://github.com/transloadit/uppy/pull/1063"},"issue":{"href":"https://api.github.com/repos/transloadit/uppy/issues/1063"},"comments":{"href":"https://api.github.com/repos/transloadit/uppy/issues/1063/comments"},"review_comments":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1063/comments"},"review_comment":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transloadit/uppy/pulls/1063/commits"},"statuses":{"href":"https://api.github.com/repos/transloadit/uppy/statuses/b2206f636fd9186cafe378ee3aadd65bad2b1065"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"arturi"}}