{"action":"created","issue":{"url":"https://api.github.com/repos/i18next/react-i18next/issues/607","repository_url":"https://api.github.com/repos/i18next/react-i18next","labels_url":"https://api.github.com/repos/i18next/react-i18next/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/i18next/react-i18next/issues/607/comments","events_url":"https://api.github.com/repos/i18next/react-i18next/issues/607/events","html_url":"https://github.com/i18next/react-i18next/issues/607","id":377084863,"node_id":"MDU6SXNzdWUzNzcwODQ4NjM=","number":607,"title":"About subpath","user":{"login":"revskill10","id":1390196,"node_id":"MDQ6VXNlcjEzOTAxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1390196?v=4","gravatar_id":"","url":"https://api.github.com/users/revskill10","html_url":"https://github.com/revskill10","followers_url":"https://api.github.com/users/revskill10/followers","following_url":"https://api.github.com/users/revskill10/following{/other_user}","gists_url":"https://api.github.com/users/revskill10/gists{/gist_id}","starred_url":"https://api.github.com/users/revskill10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revskill10/subscriptions","organizations_url":"https://api.github.com/users/revskill10/orgs","repos_url":"https://api.github.com/users/revskill10/repos","events_url":"https://api.github.com/users/revskill10/events{/privacy}","received_events_url":"https://api.github.com/users/revskill10/received_events","type":"User","site_admin":false},"labels":[{"id":1102399481,"node_id":"MDU6TGFiZWwxMTAyMzk5NDgx","url":"https://api.github.com/repos/i18next/react-i18next/labels/next.js","name":"next.js","color":"dda704","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-03T19:17:32Z","updated_at":"2018-11-03T20:50:04Z","closed_at":"2018-11-03T20:50:04Z","author_association":"CONTRIBUTOR","body":"**Problem**\r\nI have seen many usage pattern on using lang on route, most of sites i know use `lng` as a query parameter , instead of subpath.\r\n\r\nCurrent (for example) nextjs sample handles subpath in a very weird way, which leads to the code smell everywhere in the i18n related codebase.\r\n\r\n**Suggestion**\r\nRemoving usage of subpath, and using query parameter instead.\r\n"},"comment":{"url":"https://api.github.com/repos/i18next/react-i18next/issues/comments/435619778","html_url":"https://github.com/i18next/react-i18next/issues/607#issuecomment-435619778","issue_url":"https://api.github.com/repos/i18next/react-i18next/issues/607","id":435619778,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTYxOTc3OA==","user":{"login":"isaachinman","id":10575782,"node_id":"MDQ6VXNlcjEwNTc1Nzgy","avatar_url":"https://avatars1.githubusercontent.com/u/10575782?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachinman","html_url":"https://github.com/isaachinman","followers_url":"https://api.github.com/users/isaachinman/followers","following_url":"https://api.github.com/users/isaachinman/following{/other_user}","gists_url":"https://api.github.com/users/isaachinman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachinman/subscriptions","organizations_url":"https://api.github.com/users/isaachinman/orgs","repos_url":"https://api.github.com/users/isaachinman/repos","events_url":"https://api.github.com/users/isaachinman/events{/privacy}","received_events_url":"https://api.github.com/users/isaachinman/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T20:50:04Z","updated_at":"2018-11-03T20:50:04Z","author_association":"COLLABORATOR","body":"@jamuhl With the number of these issues opened, we might want to consider a full rewrite of the NextJs example.\r\n\r\n@revskill10 You're saying we have a problem of being too opinionated, and then proposing an opinionated \"solution\". \r\n\r\n> nextjs sample handles subpath in a very weird way\r\n\r\nWe're handling localised URLs in an industry standard way. If you want to handle lang via a query param, go ahead. If you want to share that approach with others, feel free create an example. That's not something @jamuhl or I am going to spend time on."}}
{"actor":{"display_login":"isaachinman"}}