{"action":"opened","number":62,"pull_request":{"url":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62","id":196899168,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODk5MTY4","html_url":"https://github.com/kentcdodds/dom-testing-library/pull/62","diff_url":"https://github.com/kentcdodds/dom-testing-library/pull/62.diff","patch_url":"https://github.com/kentcdodds/dom-testing-library/pull/62.patch","issue_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/62","number":62,"state":"open","locked":false,"title":"fix(TS): add typings for getByValue, getAllByValue, queryByValue, queryAllByValue","user":{"login":"benelliott","id":4996462,"node_id":"MDQ6VXNlcjQ5OTY0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4996462?v=4","gravatar_id":"","url":"https://api.github.com/users/benelliott","html_url":"https://github.com/benelliott","followers_url":"https://api.github.com/users/benelliott/followers","following_url":"https://api.github.com/users/benelliott/following{/other_user}","gists_url":"https://api.github.com/users/benelliott/gists{/gist_id}","starred_url":"https://api.github.com/users/benelliott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelliott/subscriptions","organizations_url":"https://api.github.com/users/benelliott/orgs","repos_url":"https://api.github.com/users/benelliott/repos","events_url":"https://api.github.com/users/benelliott/events{/privacy}","received_events_url":"https://api.github.com/users/benelliott/received_events","type":"User","site_admin":false},"body":"\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n\r\n**What**: \r\n\r\nAdds TypeScript typings for `getByValue`, `getAllByValue`, `queryByValue`, `queryAllByValue`\r\n\r\n<!-- Why are these changes necessary? -->\r\n\r\n**Why**: \r\n\r\nThese typings were missing.\r\n\r\n<!-- How were these changes implemented? -->\r\n\r\n**How**:\r\n\r\nAdding the typings in keeping with those already listed\r\n\r\n<!-- Have you done all of these things?  -->\r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [ ] Documentation N/A\r\n* [ ] Tests N/A\r\n* [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2018-06-23T12:16:44Z","updated_at":"2018-06-23T12:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62/commits","review_comments_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62/comments","review_comment_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/62/comments","statuses_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/statuses/45ba8f329be4d5a57fd20daed8025ff03d809c13","head":{"label":"benelliott:by-value-typings","ref":"by-value-typings","sha":"45ba8f329be4d5a57fd20daed8025ff03d809c13","user":{"login":"benelliott","id":4996462,"node_id":"MDQ6VXNlcjQ5OTY0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4996462?v=4","gravatar_id":"","url":"https://api.github.com/users/benelliott","html_url":"https://github.com/benelliott","followers_url":"https://api.github.com/users/benelliott/followers","following_url":"https://api.github.com/users/benelliott/following{/other_user}","gists_url":"https://api.github.com/users/benelliott/gists{/gist_id}","starred_url":"https://api.github.com/users/benelliott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelliott/subscriptions","organizations_url":"https://api.github.com/users/benelliott/orgs","repos_url":"https://api.github.com/users/benelliott/repos","events_url":"https://api.github.com/users/benelliott/events{/privacy}","received_events_url":"https://api.github.com/users/benelliott/received_events","type":"User","site_admin":false},"repo":{"id":138396503,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzOTY1MDM=","name":"dom-testing-library","full_name":"benelliott/dom-testing-library","owner":{"login":"benelliott","id":4996462,"node_id":"MDQ6VXNlcjQ5OTY0NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4996462?v=4","gravatar_id":"","url":"https://api.github.com/users/benelliott","html_url":"https://github.com/benelliott","followers_url":"https://api.github.com/users/benelliott/followers","following_url":"https://api.github.com/users/benelliott/following{/other_user}","gists_url":"https://api.github.com/users/benelliott/gists{/gist_id}","starred_url":"https://api.github.com/users/benelliott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benelliott/subscriptions","organizations_url":"https://api.github.com/users/benelliott/orgs","repos_url":"https://api.github.com/users/benelliott/repos","events_url":"https://api.github.com/users/benelliott/events{/privacy}","received_events_url":"https://api.github.com/users/benelliott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benelliott/dom-testing-library","description":"🐙 Simple and complete DOM testing utilities that encourage good testing practices.","fork":true,"url":"https://api.github.com/repos/benelliott/dom-testing-library","forks_url":"https://api.github.com/repos/benelliott/dom-testing-library/forks","keys_url":"https://api.github.com/repos/benelliott/dom-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benelliott/dom-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benelliott/dom-testing-library/teams","hooks_url":"https://api.github.com/repos/benelliott/dom-testing-library/hooks","issue_events_url":"https://api.github.com/repos/benelliott/dom-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/benelliott/dom-testing-library/events","assignees_url":"https://api.github.com/repos/benelliott/dom-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/benelliott/dom-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/benelliott/dom-testing-library/tags","blobs_url":"https://api.github.com/repos/benelliott/dom-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benelliott/dom-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benelliott/dom-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/benelliott/dom-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benelliott/dom-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/benelliott/dom-testing-library/languages","stargazers_url":"https://api.github.com/repos/benelliott/dom-testing-library/stargazers","contributors_url":"https://api.github.com/repos/benelliott/dom-testing-library/contributors","subscribers_url":"https://api.github.com/repos/benelliott/dom-testing-library/subscribers","subscription_url":"https://api.github.com/repos/benelliott/dom-testing-library/subscription","commits_url":"https://api.github.com/repos/benelliott/dom-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/benelliott/dom-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/benelliott/dom-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/benelliott/dom-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/benelliott/dom-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/benelliott/dom-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benelliott/dom-testing-library/merges","archive_url":"https://api.github.com/repos/benelliott/dom-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benelliott/dom-testing-library/downloads","issues_url":"https://api.github.com/repos/benelliott/dom-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/benelliott/dom-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/benelliott/dom-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/benelliott/dom-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benelliott/dom-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/benelliott/dom-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/benelliott/dom-testing-library/deployments","created_at":"2018-06-23T11:40:02Z","updated_at":"2018-06-23T11:40:04Z","pushed_at":"2018-06-23T12:13:59Z","git_url":"git://github.com/benelliott/dom-testing-library.git","ssh_url":"git@github.com:benelliott/dom-testing-library.git","clone_url":"https://github.com/benelliott/dom-testing-library.git","svn_url":"https://github.com/benelliott/dom-testing-library","homepage":"http://npm.im/dom-testing-library","size":116,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kentcdodds:master","ref":"master","sha":"275496f7dac2b25aed1ab3f83ffafa105d4e083b","user":{"login":"kentcdodds","id":1500684,"node_id":"MDQ6VXNlcjE1MDA2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"repo":{"id":128396076,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTYwNzY=","name":"dom-testing-library","full_name":"kentcdodds/dom-testing-library","owner":{"login":"kentcdodds","id":1500684,"node_id":"MDQ6VXNlcjE1MDA2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kentcdodds/dom-testing-library","description":"🐙 Simple and complete DOM testing utilities that encourage good testing practices.","fork":false,"url":"https://api.github.com/repos/kentcdodds/dom-testing-library","forks_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/forks","keys_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/teams","hooks_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/hooks","issue_events_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/events{/number}","events_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/events","assignees_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/assignees{/user}","branches_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/branches{/branch}","tags_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/tags","blobs_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/statuses/{sha}","languages_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/languages","stargazers_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/stargazers","contributors_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/contributors","subscribers_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/subscribers","subscription_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/subscription","commits_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/contents/{+path}","compare_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/merges","archive_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/downloads","issues_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues{/number}","pulls_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls{/number}","milestones_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/milestones{/number}","notifications_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/labels{/name}","releases_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/releases{/id}","deployments_url":"https://api.github.com/repos/kentcdodds/dom-testing-library/deployments","created_at":"2018-04-06T13:08:11Z","updated_at":"2018-06-22T16:50:38Z","pushed_at":"2018-06-19T13:28:31Z","git_url":"git://github.com/kentcdodds/dom-testing-library.git","ssh_url":"git@github.com:kentcdodds/dom-testing-library.git","clone_url":"https://github.com/kentcdodds/dom-testing-library.git","svn_url":"https://github.com/kentcdodds/dom-testing-library","homepage":"http://npm.im/dom-testing-library","size":116,"stargazers_count":402,"watchers_count":402,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":4,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62"},"html":{"href":"https://github.com/kentcdodds/dom-testing-library/pull/62"},"issue":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/62"},"comments":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/kentcdodds/dom-testing-library/statuses/45ba8f329be4d5a57fd20daed8025ff03d809c13"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"benelliott"}}