{"action":"created","comment":{"url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/comments/223376220","pull_request_review_id":162485429,"id":223376220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzM3NjIyMA==","diff_hunk":"@@ -19,18 +21,19 @@ export class ProductsEffect {\n   @Effect()\n   loadProducts$: Observable<productActions.ProductsAction> = this.actions$.pipe(\n     ofType(productActions.LOAD_PRODUCTS),\n-    switchMap(() => {\n+    switchMap((action: Action) => {\n \n-      return this.productService.getProducts().pipe(\n+      return this.productService.getProducts(action['payload']).pipe(\n       map ((response: { success: boolean, products: Product[] }) => {\n           const products: Product[] = response['products'];\n-          const entities: { [key: string]: Product }  = {};\n+        const filters: Filter = action['payload'];","path":"src/app/features/shop/@store/effects/products.effect.ts","position":25,"original_position":25,"commit_id":"9965ced010dc3c17a48be1f8e58f8d79310174ba","original_commit_id":"9965ced010dc3c17a48be1f8e58f8d79310174ba","user":{"login":"McSim182","id":37288054,"node_id":"MDQ6VXNlcjM3Mjg4MDU0","avatar_url":"https://avatars0.githubusercontent.com/u/37288054?v=4","gravatar_id":"","url":"https://api.github.com/users/McSim182","html_url":"https://github.com/McSim182","followers_url":"https://api.github.com/users/McSim182/followers","following_url":"https://api.github.com/users/McSim182/following{/other_user}","gists_url":"https://api.github.com/users/McSim182/gists{/gist_id}","starred_url":"https://api.github.com/users/McSim182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McSim182/subscriptions","organizations_url":"https://api.github.com/users/McSim182/orgs","repos_url":"https://api.github.com/users/McSim182/repos","events_url":"https://api.github.com/users/McSim182/events{/privacy}","received_events_url":"https://api.github.com/users/McSim182/received_events","type":"User","site_admin":false},"body":"we could assign it in reducer, so our LoadProductsSuccess action still will accept only array of products + entities","created_at":"2018-10-08T14:06:42Z","updated_at":"2018-10-08T14:14:05Z","html_url":"https://github.com/McSim182/incode-internship-frontend/pull/14#discussion_r223376220","pull_request_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/comments/223376220"},"html":{"href":"https://github.com/McSim182/incode-internship-frontend/pull/14#discussion_r223376220"},"pull_request":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14","id":221107426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTA3NDI2","html_url":"https://github.com/McSim182/incode-internship-frontend/pull/14","diff_url":"https://github.com/McSim182/incode-internship-frontend/pull/14.diff","patch_url":"https://github.com/McSim182/incode-internship-frontend/pull/14.patch","issue_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/14","number":14,"state":"open","locked":false,"title":"product list filters","user":{"login":"verlil","id":29058258,"node_id":"MDQ6VXNlcjI5MDU4MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/29058258?v=4","gravatar_id":"","url":"https://api.github.com/users/verlil","html_url":"https://github.com/verlil","followers_url":"https://api.github.com/users/verlil/followers","following_url":"https://api.github.com/users/verlil/following{/other_user}","gists_url":"https://api.github.com/users/verlil/gists{/gist_id}","starred_url":"https://api.github.com/users/verlil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verlil/subscriptions","organizations_url":"https://api.github.com/users/verlil/orgs","repos_url":"https://api.github.com/users/verlil/repos","events_url":"https://api.github.com/users/verlil/events{/privacy}","received_events_url":"https://api.github.com/users/verlil/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-08T12:57:31Z","updated_at":"2018-10-08T14:14:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9a9da7d41908935e8f1215f2d7bd73ce425647","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14/commits","review_comments_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14/comments","review_comment_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/14/comments","statuses_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/statuses/9965ced010dc3c17a48be1f8e58f8d79310174ba","head":{"label":"verlil:master","ref":"master","sha":"9965ced010dc3c17a48be1f8e58f8d79310174ba","user":{"login":"verlil","id":29058258,"node_id":"MDQ6VXNlcjI5MDU4MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/29058258?v=4","gravatar_id":"","url":"https://api.github.com/users/verlil","html_url":"https://github.com/verlil","followers_url":"https://api.github.com/users/verlil/followers","following_url":"https://api.github.com/users/verlil/following{/other_user}","gists_url":"https://api.github.com/users/verlil/gists{/gist_id}","starred_url":"https://api.github.com/users/verlil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verlil/subscriptions","organizations_url":"https://api.github.com/users/verlil/orgs","repos_url":"https://api.github.com/users/verlil/repos","events_url":"https://api.github.com/users/verlil/events{/privacy}","received_events_url":"https://api.github.com/users/verlil/received_events","type":"User","site_admin":false},"repo":{"id":151061431,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwNjE0MzE=","name":"incode-internship-frontend","full_name":"verlil/incode-internship-frontend","private":false,"owner":{"login":"verlil","id":29058258,"node_id":"MDQ6VXNlcjI5MDU4MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/29058258?v=4","gravatar_id":"","url":"https://api.github.com/users/verlil","html_url":"https://github.com/verlil","followers_url":"https://api.github.com/users/verlil/followers","following_url":"https://api.github.com/users/verlil/following{/other_user}","gists_url":"https://api.github.com/users/verlil/gists{/gist_id}","starred_url":"https://api.github.com/users/verlil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verlil/subscriptions","organizations_url":"https://api.github.com/users/verlil/orgs","repos_url":"https://api.github.com/users/verlil/repos","events_url":"https://api.github.com/users/verlil/events{/privacy}","received_events_url":"https://api.github.com/users/verlil/received_events","type":"User","site_admin":false},"html_url":"https://github.com/verlil/incode-internship-frontend","description":null,"fork":true,"url":"https://api.github.com/repos/verlil/incode-internship-frontend","forks_url":"https://api.github.com/repos/verlil/incode-internship-frontend/forks","keys_url":"https://api.github.com/repos/verlil/incode-internship-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verlil/incode-internship-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verlil/incode-internship-frontend/teams","hooks_url":"https://api.github.com/repos/verlil/incode-internship-frontend/hooks","issue_events_url":"https://api.github.com/repos/verlil/incode-internship-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/verlil/incode-internship-frontend/events","assignees_url":"https://api.github.com/repos/verlil/incode-internship-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/verlil/incode-internship-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/verlil/incode-internship-frontend/tags","blobs_url":"https://api.github.com/repos/verlil/incode-internship-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verlil/incode-internship-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verlil/incode-internship-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/verlil/incode-internship-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verlil/incode-internship-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/verlil/incode-internship-frontend/languages","stargazers_url":"https://api.github.com/repos/verlil/incode-internship-frontend/stargazers","contributors_url":"https://api.github.com/repos/verlil/incode-internship-frontend/contributors","subscribers_url":"https://api.github.com/repos/verlil/incode-internship-frontend/subscribers","subscription_url":"https://api.github.com/repos/verlil/incode-internship-frontend/subscription","commits_url":"https://api.github.com/repos/verlil/incode-internship-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/verlil/incode-internship-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/verlil/incode-internship-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/verlil/incode-internship-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/verlil/incode-internship-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/verlil/incode-internship-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verlil/incode-internship-frontend/merges","archive_url":"https://api.github.com/repos/verlil/incode-internship-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verlil/incode-internship-frontend/downloads","issues_url":"https://api.github.com/repos/verlil/incode-internship-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/verlil/incode-internship-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/verlil/incode-internship-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/verlil/incode-internship-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verlil/incode-internship-frontend/labels{/name}","releases_url":"https://api.github.com/repos/verlil/incode-internship-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/verlil/incode-internship-frontend/deployments","created_at":"2018-10-01T09:01:41Z","updated_at":"2018-10-08T12:56:54Z","pushed_at":"2018-10-08T12:56:51Z","git_url":"git://github.com/verlil/incode-internship-frontend.git","ssh_url":"git@github.com:verlil/incode-internship-frontend.git","clone_url":"https://github.com/verlil/incode-internship-frontend.git","svn_url":"https://github.com/verlil/incode-internship-frontend","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"McSim182:master","ref":"master","sha":"55e1428a9ee61aec9ebedc66a0d04c0bce0e07fc","user":{"login":"McSim182","id":37288054,"node_id":"MDQ6VXNlcjM3Mjg4MDU0","avatar_url":"https://avatars0.githubusercontent.com/u/37288054?v=4","gravatar_id":"","url":"https://api.github.com/users/McSim182","html_url":"https://github.com/McSim182","followers_url":"https://api.github.com/users/McSim182/followers","following_url":"https://api.github.com/users/McSim182/following{/other_user}","gists_url":"https://api.github.com/users/McSim182/gists{/gist_id}","starred_url":"https://api.github.com/users/McSim182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McSim182/subscriptions","organizations_url":"https://api.github.com/users/McSim182/orgs","repos_url":"https://api.github.com/users/McSim182/repos","events_url":"https://api.github.com/users/McSim182/events{/privacy}","received_events_url":"https://api.github.com/users/McSim182/received_events","type":"User","site_admin":false},"repo":{"id":151046042,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwNDYwNDI=","name":"incode-internship-frontend","full_name":"McSim182/incode-internship-frontend","private":false,"owner":{"login":"McSim182","id":37288054,"node_id":"MDQ6VXNlcjM3Mjg4MDU0","avatar_url":"https://avatars0.githubusercontent.com/u/37288054?v=4","gravatar_id":"","url":"https://api.github.com/users/McSim182","html_url":"https://github.com/McSim182","followers_url":"https://api.github.com/users/McSim182/followers","following_url":"https://api.github.com/users/McSim182/following{/other_user}","gists_url":"https://api.github.com/users/McSim182/gists{/gist_id}","starred_url":"https://api.github.com/users/McSim182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McSim182/subscriptions","organizations_url":"https://api.github.com/users/McSim182/orgs","repos_url":"https://api.github.com/users/McSim182/repos","events_url":"https://api.github.com/users/McSim182/events{/privacy}","received_events_url":"https://api.github.com/users/McSim182/received_events","type":"User","site_admin":false},"html_url":"https://github.com/McSim182/incode-internship-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/McSim182/incode-internship-frontend","forks_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/forks","keys_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/teams","hooks_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/hooks","issue_events_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/events","assignees_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/tags","blobs_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/languages","stargazers_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/stargazers","contributors_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/contributors","subscribers_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/subscribers","subscription_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/subscription","commits_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/merges","archive_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/downloads","issues_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/labels{/name}","releases_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/McSim182/incode-internship-frontend/deployments","created_at":"2018-10-01T06:36:56Z","updated_at":"2018-10-08T06:22:00Z","pushed_at":"2018-10-08T14:03:06Z","git_url":"git://github.com/McSim182/incode-internship-frontend.git","ssh_url":"git@github.com:McSim182/incode-internship-frontend.git","clone_url":"https://github.com/McSim182/incode-internship-frontend.git","svn_url":"https://github.com/McSim182/incode-internship-frontend","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14"},"html":{"href":"https://github.com/McSim182/incode-internship-frontend/pull/14"},"issue":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/14"},"comments":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/McSim182/incode-internship-frontend/statuses/9965ced010dc3c17a48be1f8e58f8d79310174ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"McSim182"}}