{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/25785","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/25785/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/25785/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/25785/events","html_url":"https://github.com/odoo/odoo/pull/25785","id":341502880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjI1MTI2","number":25785,"title":"[FIX] account: test: prevent aged report to crash on july, 16th and a…","user":{"login":"kebeclibre","id":17759223,"node_id":"MDQ6VXNlcjE3NzU5MjIz","avatar_url":"https://avatars3.githubusercontent.com/u/17759223?v=4","gravatar_id":"","url":"https://api.github.com/users/kebeclibre","html_url":"https://github.com/kebeclibre","followers_url":"https://api.github.com/users/kebeclibre/followers","following_url":"https://api.github.com/users/kebeclibre/following{/other_user}","gists_url":"https://api.github.com/users/kebeclibre/gists{/gist_id}","starred_url":"https://api.github.com/users/kebeclibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kebeclibre/subscriptions","organizations_url":"https://api.github.com/users/kebeclibre/orgs","repos_url":"https://api.github.com/users/kebeclibre/repos","events_url":"https://api.github.com/users/kebeclibre/events{/privacy}","received_events_url":"https://api.github.com/users/kebeclibre/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-16T12:42:04Z","updated_at":"2018-08-01T10:12:24Z","closed_at":"2018-07-16T13:24:21Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/25785","html_url":"https://github.com/odoo/odoo/pull/25785","diff_url":"https://github.com/odoo/odoo/pull/25785.diff","patch_url":"https://github.com/odoo/odoo/pull/25785.patch"},"body":"…fter\r\n\r\nBefore this commit, the test aged report crashed on date Year/07/16 (and probably after, too) because:\r\n- we create a partial reconcile today (create_date = Year/07/16)  when making the payment to the invoice\r\n- the report date is set as Year/07/15, so, the partial reconciliation, if tested after that date, always appears in another period,\r\nwhich is not the use case we test, hence the crash of the test\r\n\r\nAfter this commit, we force the create date of the partial reconciliation to *before* the report is called,\r\nthus, no error occurs\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/409524911","html_url":"https://github.com/odoo/odoo/pull/25785#issuecomment-409524911","issue_url":"https://api.github.com/repos/odoo/odoo/issues/25785","id":409524911,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUyNDkxMQ==","user":{"login":"wtaferner","id":362478,"node_id":"MDQ6VXNlcjM2MjQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/362478?v=4","gravatar_id":"","url":"https://api.github.com/users/wtaferner","html_url":"https://github.com/wtaferner","followers_url":"https://api.github.com/users/wtaferner/followers","following_url":"https://api.github.com/users/wtaferner/following{/other_user}","gists_url":"https://api.github.com/users/wtaferner/gists{/gist_id}","starred_url":"https://api.github.com/users/wtaferner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtaferner/subscriptions","organizations_url":"https://api.github.com/users/wtaferner/orgs","repos_url":"https://api.github.com/users/wtaferner/repos","events_url":"https://api.github.com/users/wtaferner/events{/privacy}","received_events_url":"https://api.github.com/users/wtaferner/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T10:12:24Z","updated_at":"2018-08-01T10:12:24Z","author_association":"CONTRIBUTOR","body":"@kebeclibre \r\nTrue, but it was more about to make a point about these kind of non-deterministic testing methods. Having a static date will for sure make troubles with any other non-static date...so, please try to improve this or actually fix it as it is a nightmare to work with Odoo based on this concerning the testing of addons or doing other integration tests."}}
{"actor":{"display_login":"wtaferner"}}