{"action":"created","comment":{"url":"https://api.github.com/repos/occitech/fcl-data/pulls/comments/188943774","pull_request_review_id":121018947,"id":188943774,"diff_hunk":"@@ -1,5 +1,26 @@\n .page {\n-  @include horizontal-spacing();\n   max-width: $desktop;\n-  margin: 3rem auto;\n+  display: flex;\n+  justify-content: center;\n+  position: relative;\n+  overflow: hidden;\n+  padding: 0 calc((100vw - #{$tablet}));\n+  h1 {\n+    text-shadow: 0 2px 4px rgba(0, 0, 0, 0.35);\n+    color: $white;\n+  }\n+}\n+\n+@media screen and (min-width: $desktop) {\n+  .page {\n+    padding: 0 calc((100vw - #{$desktop}));\n+  }\n+}\n+\n+@media screen and (min-width: $largeDesktop) {\n+  .page {\n+    //Here I had to use 75rem due to tests for padding weird comportement","path":"src/web/theme/ui/templates/Page/Page.scss","position":24,"original_position":24,"commit_id":"4d1f0d3140f8f173f030de3929d3c51dffdc6a7f","original_commit_id":"4d1f0d3140f8f173f030de3929d3c51dffdc6a7f","user":{"login":"milkae","id":15647338,"avatar_url":"https://avatars1.githubusercontent.com/u/15647338?v=4","gravatar_id":"","url":"https://api.github.com/users/milkae","html_url":"https://github.com/milkae","followers_url":"https://api.github.com/users/milkae/followers","following_url":"https://api.github.com/users/milkae/following{/other_user}","gists_url":"https://api.github.com/users/milkae/gists{/gist_id}","starred_url":"https://api.github.com/users/milkae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milkae/subscriptions","organizations_url":"https://api.github.com/users/milkae/orgs","repos_url":"https://api.github.com/users/milkae/repos","events_url":"https://api.github.com/users/milkae/events{/privacy}","received_events_url":"https://api.github.com/users/milkae/received_events","type":"User","site_admin":false},"body":"I don't think the behavior of the padding itself is weird, nor that this comment is very useful. You did tests to find the value that suited your needs and you found it, that's all.\r\n","created_at":"2018-05-17T12:47:32Z","updated_at":"2018-05-17T12:47:58Z","html_url":"https://github.com/occitech/fcl-data/pull/2#discussion_r188943774","pull_request_url":"https://api.github.com/repos/occitech/fcl-data/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/comments/188943774"},"html":{"href":"https://github.com/occitech/fcl-data/pull/2#discussion_r188943774"},"pull_request":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/occitech/fcl-data/pulls/2","id":188464555,"html_url":"https://github.com/occitech/fcl-data/pull/2","diff_url":"https://github.com/occitech/fcl-data/pull/2.diff","patch_url":"https://github.com/occitech/fcl-data/pull/2.patch","issue_url":"https://api.github.com/repos/occitech/fcl-data/issues/2","number":2,"state":"open","locked":false,"title":"Feature/12015 1st card home","user":{"login":"erochOnGit","id":24712827,"avatar_url":"https://avatars2.githubusercontent.com/u/24712827?v=4","gravatar_id":"","url":"https://api.github.com/users/erochOnGit","html_url":"https://github.com/erochOnGit","followers_url":"https://api.github.com/users/erochOnGit/followers","following_url":"https://api.github.com/users/erochOnGit/following{/other_user}","gists_url":"https://api.github.com/users/erochOnGit/gists{/gist_id}","starred_url":"https://api.github.com/users/erochOnGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erochOnGit/subscriptions","organizations_url":"https://api.github.com/users/erochOnGit/orgs","repos_url":"https://api.github.com/users/erochOnGit/repos","events_url":"https://api.github.com/users/erochOnGit/events{/privacy}","received_events_url":"https://api.github.com/users/erochOnGit/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-16T15:04:25Z","updated_at":"2018-05-17T12:47:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ac8852a296292c2a207fd22e43b67bd9ddc0227","assignee":null,"assignees":[],"requested_reviewers":[{"login":"real34","id":75968,"avatar_url":"https://avatars0.githubusercontent.com/u/75968?v=4","gravatar_id":"","url":"https://api.github.com/users/real34","html_url":"https://github.com/real34","followers_url":"https://api.github.com/users/real34/followers","following_url":"https://api.github.com/users/real34/following{/other_user}","gists_url":"https://api.github.com/users/real34/gists{/gist_id}","starred_url":"https://api.github.com/users/real34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real34/subscriptions","organizations_url":"https://api.github.com/users/real34/orgs","repos_url":"https://api.github.com/users/real34/repos","events_url":"https://api.github.com/users/real34/events{/privacy}","received_events_url":"https://api.github.com/users/real34/received_events","type":"User","site_admin":false},{"login":"JulienPradet","id":4851789,"avatar_url":"https://avatars2.githubusercontent.com/u/4851789?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienPradet","html_url":"https://github.com/JulienPradet","followers_url":"https://api.github.com/users/JulienPradet/followers","following_url":"https://api.github.com/users/JulienPradet/following{/other_user}","gists_url":"https://api.github.com/users/JulienPradet/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienPradet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienPradet/subscriptions","organizations_url":"https://api.github.com/users/JulienPradet/orgs","repos_url":"https://api.github.com/users/JulienPradet/repos","events_url":"https://api.github.com/users/JulienPradet/events{/privacy}","received_events_url":"https://api.github.com/users/JulienPradet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/occitech/fcl-data/pulls/2/commits","review_comments_url":"https://api.github.com/repos/occitech/fcl-data/pulls/2/comments","review_comment_url":"https://api.github.com/repos/occitech/fcl-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/occitech/fcl-data/issues/2/comments","statuses_url":"https://api.github.com/repos/occitech/fcl-data/statuses/4d1f0d3140f8f173f030de3929d3c51dffdc6a7f","head":{"label":"occitech:feature/12015-1st-card-home","ref":"feature/12015-1st-card-home","sha":"4d1f0d3140f8f173f030de3929d3c51dffdc6a7f","user":{"login":"occitech","id":1442500,"avatar_url":"https://avatars3.githubusercontent.com/u/1442500?v=4","gravatar_id":"","url":"https://api.github.com/users/occitech","html_url":"https://github.com/occitech","followers_url":"https://api.github.com/users/occitech/followers","following_url":"https://api.github.com/users/occitech/following{/other_user}","gists_url":"https://api.github.com/users/occitech/gists{/gist_id}","starred_url":"https://api.github.com/users/occitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occitech/subscriptions","organizations_url":"https://api.github.com/users/occitech/orgs","repos_url":"https://api.github.com/users/occitech/repos","events_url":"https://api.github.com/users/occitech/events{/privacy}","received_events_url":"https://api.github.com/users/occitech/received_events","type":"Organization","site_admin":false},"repo":{"id":133488663,"name":"fcl-data","full_name":"occitech/fcl-data","owner":{"login":"occitech","id":1442500,"avatar_url":"https://avatars3.githubusercontent.com/u/1442500?v=4","gravatar_id":"","url":"https://api.github.com/users/occitech","html_url":"https://github.com/occitech","followers_url":"https://api.github.com/users/occitech/followers","following_url":"https://api.github.com/users/occitech/following{/other_user}","gists_url":"https://api.github.com/users/occitech/gists{/gist_id}","starred_url":"https://api.github.com/users/occitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occitech/subscriptions","organizations_url":"https://api.github.com/users/occitech/orgs","repos_url":"https://api.github.com/users/occitech/repos","events_url":"https://api.github.com/users/occitech/events{/privacy}","received_events_url":"https://api.github.com/users/occitech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/occitech/fcl-data","description":"Prototype your next eCommerce experiences using modern web technologies.","fork":false,"url":"https://api.github.com/repos/occitech/fcl-data","forks_url":"https://api.github.com/repos/occitech/fcl-data/forks","keys_url":"https://api.github.com/repos/occitech/fcl-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/occitech/fcl-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/occitech/fcl-data/teams","hooks_url":"https://api.github.com/repos/occitech/fcl-data/hooks","issue_events_url":"https://api.github.com/repos/occitech/fcl-data/issues/events{/number}","events_url":"https://api.github.com/repos/occitech/fcl-data/events","assignees_url":"https://api.github.com/repos/occitech/fcl-data/assignees{/user}","branches_url":"https://api.github.com/repos/occitech/fcl-data/branches{/branch}","tags_url":"https://api.github.com/repos/occitech/fcl-data/tags","blobs_url":"https://api.github.com/repos/occitech/fcl-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/occitech/fcl-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/occitech/fcl-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/occitech/fcl-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/occitech/fcl-data/statuses/{sha}","languages_url":"https://api.github.com/repos/occitech/fcl-data/languages","stargazers_url":"https://api.github.com/repos/occitech/fcl-data/stargazers","contributors_url":"https://api.github.com/repos/occitech/fcl-data/contributors","subscribers_url":"https://api.github.com/repos/occitech/fcl-data/subscribers","subscription_url":"https://api.github.com/repos/occitech/fcl-data/subscription","commits_url":"https://api.github.com/repos/occitech/fcl-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/occitech/fcl-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/occitech/fcl-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/occitech/fcl-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/occitech/fcl-data/contents/{+path}","compare_url":"https://api.github.com/repos/occitech/fcl-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/occitech/fcl-data/merges","archive_url":"https://api.github.com/repos/occitech/fcl-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/occitech/fcl-data/downloads","issues_url":"https://api.github.com/repos/occitech/fcl-data/issues{/number}","pulls_url":"https://api.github.com/repos/occitech/fcl-data/pulls{/number}","milestones_url":"https://api.github.com/repos/occitech/fcl-data/milestones{/number}","notifications_url":"https://api.github.com/repos/occitech/fcl-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/occitech/fcl-data/labels{/name}","releases_url":"https://api.github.com/repos/occitech/fcl-data/releases{/id}","deployments_url":"https://api.github.com/repos/occitech/fcl-data/deployments","created_at":"2018-05-15T08:56:16Z","updated_at":"2018-05-16T08:21:46Z","pushed_at":"2018-05-16T15:11:37Z","git_url":"git://github.com/occitech/fcl-data.git","ssh_url":"git@github.com:occitech/fcl-data.git","clone_url":"https://github.com/occitech/fcl-data.git","svn_url":"https://github.com/occitech/fcl-data","homepage":null,"size":566,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"occitech:develop","ref":"develop","sha":"8c4dc69833ab92ee2b1913f7d585302f0fb7779c","user":{"login":"occitech","id":1442500,"avatar_url":"https://avatars3.githubusercontent.com/u/1442500?v=4","gravatar_id":"","url":"https://api.github.com/users/occitech","html_url":"https://github.com/occitech","followers_url":"https://api.github.com/users/occitech/followers","following_url":"https://api.github.com/users/occitech/following{/other_user}","gists_url":"https://api.github.com/users/occitech/gists{/gist_id}","starred_url":"https://api.github.com/users/occitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occitech/subscriptions","organizations_url":"https://api.github.com/users/occitech/orgs","repos_url":"https://api.github.com/users/occitech/repos","events_url":"https://api.github.com/users/occitech/events{/privacy}","received_events_url":"https://api.github.com/users/occitech/received_events","type":"Organization","site_admin":false},"repo":{"id":133488663,"name":"fcl-data","full_name":"occitech/fcl-data","owner":{"login":"occitech","id":1442500,"avatar_url":"https://avatars3.githubusercontent.com/u/1442500?v=4","gravatar_id":"","url":"https://api.github.com/users/occitech","html_url":"https://github.com/occitech","followers_url":"https://api.github.com/users/occitech/followers","following_url":"https://api.github.com/users/occitech/following{/other_user}","gists_url":"https://api.github.com/users/occitech/gists{/gist_id}","starred_url":"https://api.github.com/users/occitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occitech/subscriptions","organizations_url":"https://api.github.com/users/occitech/orgs","repos_url":"https://api.github.com/users/occitech/repos","events_url":"https://api.github.com/users/occitech/events{/privacy}","received_events_url":"https://api.github.com/users/occitech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/occitech/fcl-data","description":"Prototype your next eCommerce experiences using modern web technologies.","fork":false,"url":"https://api.github.com/repos/occitech/fcl-data","forks_url":"https://api.github.com/repos/occitech/fcl-data/forks","keys_url":"https://api.github.com/repos/occitech/fcl-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/occitech/fcl-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/occitech/fcl-data/teams","hooks_url":"https://api.github.com/repos/occitech/fcl-data/hooks","issue_events_url":"https://api.github.com/repos/occitech/fcl-data/issues/events{/number}","events_url":"https://api.github.com/repos/occitech/fcl-data/events","assignees_url":"https://api.github.com/repos/occitech/fcl-data/assignees{/user}","branches_url":"https://api.github.com/repos/occitech/fcl-data/branches{/branch}","tags_url":"https://api.github.com/repos/occitech/fcl-data/tags","blobs_url":"https://api.github.com/repos/occitech/fcl-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/occitech/fcl-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/occitech/fcl-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/occitech/fcl-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/occitech/fcl-data/statuses/{sha}","languages_url":"https://api.github.com/repos/occitech/fcl-data/languages","stargazers_url":"https://api.github.com/repos/occitech/fcl-data/stargazers","contributors_url":"https://api.github.com/repos/occitech/fcl-data/contributors","subscribers_url":"https://api.github.com/repos/occitech/fcl-data/subscribers","subscription_url":"https://api.github.com/repos/occitech/fcl-data/subscription","commits_url":"https://api.github.com/repos/occitech/fcl-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/occitech/fcl-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/occitech/fcl-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/occitech/fcl-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/occitech/fcl-data/contents/{+path}","compare_url":"https://api.github.com/repos/occitech/fcl-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/occitech/fcl-data/merges","archive_url":"https://api.github.com/repos/occitech/fcl-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/occitech/fcl-data/downloads","issues_url":"https://api.github.com/repos/occitech/fcl-data/issues{/number}","pulls_url":"https://api.github.com/repos/occitech/fcl-data/pulls{/number}","milestones_url":"https://api.github.com/repos/occitech/fcl-data/milestones{/number}","notifications_url":"https://api.github.com/repos/occitech/fcl-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/occitech/fcl-data/labels{/name}","releases_url":"https://api.github.com/repos/occitech/fcl-data/releases{/id}","deployments_url":"https://api.github.com/repos/occitech/fcl-data/deployments","created_at":"2018-05-15T08:56:16Z","updated_at":"2018-05-16T08:21:46Z","pushed_at":"2018-05-16T15:11:37Z","git_url":"git://github.com/occitech/fcl-data.git","ssh_url":"git@github.com:occitech/fcl-data.git","clone_url":"https://github.com/occitech/fcl-data.git","svn_url":"https://github.com/occitech/fcl-data","homepage":null,"size":566,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/2"},"html":{"href":"https://github.com/occitech/fcl-data/pull/2"},"issue":{"href":"https://api.github.com/repos/occitech/fcl-data/issues/2"},"comments":{"href":"https://api.github.com/repos/occitech/fcl-data/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/occitech/fcl-data/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/occitech/fcl-data/statuses/4d1f0d3140f8f173f030de3929d3c51dffdc6a7f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"milkae"}}