{"action":"opened","issue":{"url":"https://api.github.com/repos/easydigitaldownloads/edd-message/issues/78","repository_url":"https://api.github.com/repos/easydigitaldownloads/edd-message","labels_url":"https://api.github.com/repos/easydigitaldownloads/edd-message/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/easydigitaldownloads/edd-message/issues/78/comments","events_url":"https://api.github.com/repos/easydigitaldownloads/edd-message/issues/78/events","html_url":"https://github.com/easydigitaldownloads/edd-message/issues/78","id":326323076,"number":78,"title":"Recommendations for EDD 3.0","user":{"login":"JJJ","id":88951,"avatar_url":"https://avatars3.githubusercontent.com/u/88951?v=4","gravatar_id":"","url":"https://api.github.com/users/JJJ","html_url":"https://github.com/JJJ","followers_url":"https://api.github.com/users/JJJ/followers","following_url":"https://api.github.com/users/JJJ/following{/other_user}","gists_url":"https://api.github.com/users/JJJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JJJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJJ/subscriptions","organizations_url":"https://api.github.com/users/JJJ/orgs","repos_url":"https://api.github.com/users/JJJ/repos","events_url":"https://api.github.com/users/JJJ/events{/privacy}","received_events_url":"https://api.github.com/users/JJJ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-24T22:47:36Z","updated_at":"2018-05-24T22:47:36Z","closed_at":null,"author_association":"NONE","body":"EDD 3.0 introduces a few custom database tables for logs. EDD Messages will want to use `edd_logs` and `edd_logmeta` for all of what it does currently. In testing EDD Messages with EDD 3.0, I've identified a few problems, and have some recommendations.\r\n\r\n* EDD Messages sets `post_parent` to `0` which is no longer allowed. All logs in EDD 3.0 require an object ID and object type to associate themselves with.\r\n* EDD Messages stores the `customer_id` in post meta. This should be moved to `object_id`, and `customer` as the object type.\r\n* EDD Logs are considered \"ancillary\" or \"non-critical\" so no feedback or notices are provided when logs do not successfully save. In the case of EDD Messages & logging, it might be nice to include a notice that a message was not saved.\r\n* As is, EDD Messages is not compatible with EDD 3.0, but in a way that EDD 3.0 can/should not make compromises for (in my opinion.) Logs without object IDs & types are not useful, and hard to report against.\r\n\r\n## Deeper thoughts:\r\n\r\nI think EDD Messages would benefit greatly from getting out of `wp_posts` and post types and all of that, and instead using the new `EDD\\DB` API to have its own database tables. While Messages are similar to both the Notes and Logs components, they are unique to this plugin, and should exist as such.\r\n\r\n## More Technicals\r\n\r\nI think we should create a version of this plugin that _is_ EDD 3.0 compatible, uses custom tables for messages and message meta, and bump the version numbers accordingly to represent the dependency relationship."}}
{"actor":{"display_login":"JJJ"}}