{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-helm/pulls/comments/192373192","pull_request_review_id":125139154,"id":192373192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM3MzE5Mg==","diff_hunk":"@@ -60,7 +60,7 @@ get_mon_config $IP_VERSION\n chown ceph. /var/log/ceph\n \n # If we don't have a monitor keyring, this is a new monitor\n-if [ ! -e \"$MON_DATA_DIR/keyring\" ]; then\n+if [ ! -e \"${MON_DATA_DIR}/done\" ]; then","path":"ceph/ceph/templates/bin/_start_mon.sh.tpl","position":5,"original_position":5,"commit_id":"734936a465d17393f75946d7363dc6a0a3d90ef4","original_commit_id":"734936a465d17393f75946d7363dc6a0a3d90ef4","user":{"login":"rootfs","id":7062400,"node_id":"MDQ6VXNlcjcwNjI0MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"can you double check if keyring is here?","created_at":"2018-06-01T11:55:34Z","updated_at":"2018-06-01T11:55:34Z","html_url":"https://github.com/ceph/ceph-helm/pull/59#discussion_r192373192","pull_request_url":"https://api.github.com/repos/ceph/ceph-helm/pulls/59","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/comments/192373192"},"html":{"href":"https://github.com/ceph/ceph-helm/pull/59#discussion_r192373192"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-helm/pulls/59","id":191918658,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTE4NjU4","html_url":"https://github.com/ceph/ceph-helm/pull/59","diff_url":"https://github.com/ceph/ceph-helm/pull/59.diff","patch_url":"https://github.com/ceph/ceph-helm/pull/59.patch","issue_url":"https://api.github.com/repos/ceph/ceph-helm/issues/59","number":59,"state":"open","locked":false,"title":"Fix keyring does not exist","user":{"login":"zenglg","id":5380589,"node_id":"MDQ6VXNlcjUzODA1ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/5380589?v=4","gravatar_id":"","url":"https://api.github.com/users/zenglg","html_url":"https://github.com/zenglg","followers_url":"https://api.github.com/users/zenglg/followers","following_url":"https://api.github.com/users/zenglg/following{/other_user}","gists_url":"https://api.github.com/users/zenglg/gists{/gist_id}","starred_url":"https://api.github.com/users/zenglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenglg/subscriptions","organizations_url":"https://api.github.com/users/zenglg/orgs","repos_url":"https://api.github.com/users/zenglg/repos","events_url":"https://api.github.com/users/zenglg/events{/privacy}","received_events_url":"https://api.github.com/users/zenglg/received_events","type":"User","site_admin":false},"body":"In ceph.conf:\r\n...\r\nauth_cluster_required = none\r\nauth_client_required = none\r\nauth_service_required = none\r\n...\r\n\r\nThe 'keyring' file would not be generated while the auth is turned off.\r\nSo, generate 'done' file to make sure the 'mon' has been created.\r\n\r\nSigned-off-by: Linggang Zeng <linggang.zeng@easystack.cn>","created_at":"2018-06-01T02:23:13Z","updated_at":"2018-06-01T11:55:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06da894e6402cf8b5514cc7995a5e988a125adf2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-helm/pulls/59/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-helm/pulls/59/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-helm/issues/59/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-helm/statuses/734936a465d17393f75946d7363dc6a0a3d90ef4","head":{"label":"zenglg:master","ref":"master","sha":"734936a465d17393f75946d7363dc6a0a3d90ef4","user":{"login":"zenglg","id":5380589,"node_id":"MDQ6VXNlcjUzODA1ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/5380589?v=4","gravatar_id":"","url":"https://api.github.com/users/zenglg","html_url":"https://github.com/zenglg","followers_url":"https://api.github.com/users/zenglg/followers","following_url":"https://api.github.com/users/zenglg/following{/other_user}","gists_url":"https://api.github.com/users/zenglg/gists{/gist_id}","starred_url":"https://api.github.com/users/zenglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenglg/subscriptions","organizations_url":"https://api.github.com/users/zenglg/orgs","repos_url":"https://api.github.com/users/zenglg/repos","events_url":"https://api.github.com/users/zenglg/events{/privacy}","received_events_url":"https://api.github.com/users/zenglg/received_events","type":"User","site_admin":false},"repo":{"id":128615895,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2MTU4OTU=","name":"ceph-helm","full_name":"zenglg/ceph-helm","owner":{"login":"zenglg","id":5380589,"node_id":"MDQ6VXNlcjUzODA1ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/5380589?v=4","gravatar_id":"","url":"https://api.github.com/users/zenglg","html_url":"https://github.com/zenglg","followers_url":"https://api.github.com/users/zenglg/followers","following_url":"https://api.github.com/users/zenglg/following{/other_user}","gists_url":"https://api.github.com/users/zenglg/gists{/gist_id}","starred_url":"https://api.github.com/users/zenglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenglg/subscriptions","organizations_url":"https://api.github.com/users/zenglg/orgs","repos_url":"https://api.github.com/users/zenglg/repos","events_url":"https://api.github.com/users/zenglg/events{/privacy}","received_events_url":"https://api.github.com/users/zenglg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenglg/ceph-helm","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/zenglg/ceph-helm","forks_url":"https://api.github.com/repos/zenglg/ceph-helm/forks","keys_url":"https://api.github.com/repos/zenglg/ceph-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenglg/ceph-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenglg/ceph-helm/teams","hooks_url":"https://api.github.com/repos/zenglg/ceph-helm/hooks","issue_events_url":"https://api.github.com/repos/zenglg/ceph-helm/issues/events{/number}","events_url":"https://api.github.com/repos/zenglg/ceph-helm/events","assignees_url":"https://api.github.com/repos/zenglg/ceph-helm/assignees{/user}","branches_url":"https://api.github.com/repos/zenglg/ceph-helm/branches{/branch}","tags_url":"https://api.github.com/repos/zenglg/ceph-helm/tags","blobs_url":"https://api.github.com/repos/zenglg/ceph-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenglg/ceph-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenglg/ceph-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenglg/ceph-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenglg/ceph-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/zenglg/ceph-helm/languages","stargazers_url":"https://api.github.com/repos/zenglg/ceph-helm/stargazers","contributors_url":"https://api.github.com/repos/zenglg/ceph-helm/contributors","subscribers_url":"https://api.github.com/repos/zenglg/ceph-helm/subscribers","subscription_url":"https://api.github.com/repos/zenglg/ceph-helm/subscription","commits_url":"https://api.github.com/repos/zenglg/ceph-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenglg/ceph-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenglg/ceph-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenglg/ceph-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenglg/ceph-helm/contents/{+path}","compare_url":"https://api.github.com/repos/zenglg/ceph-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenglg/ceph-helm/merges","archive_url":"https://api.github.com/repos/zenglg/ceph-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenglg/ceph-helm/downloads","issues_url":"https://api.github.com/repos/zenglg/ceph-helm/issues{/number}","pulls_url":"https://api.github.com/repos/zenglg/ceph-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/zenglg/ceph-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/zenglg/ceph-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenglg/ceph-helm/labels{/name}","releases_url":"https://api.github.com/repos/zenglg/ceph-helm/releases{/id}","deployments_url":"https://api.github.com/repos/zenglg/ceph-helm/deployments","created_at":"2018-04-08T08:04:01Z","updated_at":"2018-06-01T02:22:12Z","pushed_at":"2018-06-01T02:22:07Z","git_url":"git://github.com/zenglg/ceph-helm.git","ssh_url":"git@github.com:zenglg/ceph-helm.git","clone_url":"https://github.com/zenglg/ceph-helm.git","svn_url":"https://github.com/zenglg/ceph-helm","homepage":"","size":2242,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"722fc4852909cfd46c7147c2f253c5bb5929393f","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":101767086,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3NjcwODY=","name":"ceph-helm","full_name":"ceph/ceph-helm","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-helm","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/ceph/ceph-helm","forks_url":"https://api.github.com/repos/ceph/ceph-helm/forks","keys_url":"https://api.github.com/repos/ceph/ceph-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-helm/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-helm/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-helm/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-helm/events","assignees_url":"https://api.github.com/repos/ceph/ceph-helm/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-helm/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-helm/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-helm/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-helm/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-helm/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-helm/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-helm/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-helm/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-helm/merges","archive_url":"https://api.github.com/repos/ceph/ceph-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-helm/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-helm/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-helm/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-helm/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-helm/deployments","created_at":"2017-08-29T13:54:59Z","updated_at":"2018-05-29T01:34:51Z","pushed_at":"2018-06-01T02:23:13Z","git_url":"git://github.com/ceph/ceph-helm.git","ssh_url":"git@github.com:ceph/ceph-helm.git","clone_url":"https://github.com/ceph/ceph-helm.git","svn_url":"https://github.com/ceph/ceph-helm","homepage":"","size":2242,"stargazers_count":27,"watchers_count":27,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":9,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/59"},"html":{"href":"https://github.com/ceph/ceph-helm/pull/59"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-helm/issues/59"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-helm/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-helm/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-helm/statuses/734936a465d17393f75946d7363dc6a0a3d90ef4"}},"author_association":"NONE"}}
{"actor":{"display_login":"rootfs"}}