{"action":"created","issue":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/389","repository_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/389/comments","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/389/events","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/389","id":294233369,"number":389,"title":"Add a static property to AmqpTcpEndpoint to specify the default SSL protocol versions and use it on ConnectionFactory.SetUri","user":{"login":"paulomorgado","id":470455,"avatar_url":"https://avatars0.githubusercontent.com/u/470455?v=4","gravatar_id":"","url":"https://api.github.com/users/paulomorgado","html_url":"https://github.com/paulomorgado","followers_url":"https://api.github.com/users/paulomorgado/followers","following_url":"https://api.github.com/users/paulomorgado/following{/other_user}","gists_url":"https://api.github.com/users/paulomorgado/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomorgado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomorgado/subscriptions","organizations_url":"https://api.github.com/users/paulomorgado/orgs","repos_url":"https://api.github.com/users/paulomorgado/repos","events_url":"https://api.github.com/users/paulomorgado/events{/privacy}","received_events_url":"https://api.github.com/users/paulomorgado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-04T21:40:00Z","updated_at":"2018-03-15T10:16:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/pulls/389","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/389","diff_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/389.diff","patch_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/389.patch"},"body":"## Proposed Changes\r\n\r\nWhen creating a connection from an `Uri` there's no way to specify the accepted TLS versions.\r\n\r\nHaving a property  on [`AmqpTcpEndpoint`](blob/master/projects/client/RabbitMQ.Client/src/client/api/AmqpTcpEndpoint.cs) that is used by [`ConnectionFactory.SetUri`](blob/master/projects/client/RabbitMQ.Client/src/client/api/ConnectionFactory.cs) would allow users of the library to control the default SSL protocol versions used.\r\n\r\n## Types of Changes\r\n\r\nWhat types of changes does your code introduce to this project?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [ ] Bugfix (non-breaking change which fixes issue #NNNN)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Documentation (correction or otherwise)\r\n- [ ] Cosmetics (whitespace, appearance)\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating\r\nthe PR. If you're unsure about any of them, don't hesitate to ask on the\r\nmailing list. We're here to help! This is simply a reminder of what we are\r\ngoing to look for before merging your code._\r\n\r\n- [x] I have read the `CONTRIBUTING.md` document\r\n- [x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)\r\n- [ ] All tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n- [ ] Any dependent changes have been merged and published in related repositories\r\n\r\n## Further Comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc.\r\n"},"comment":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/comments/373327010","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/389#issuecomment-373327010","issue_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/389","id":373327010,"user":{"login":"paulomorgado","id":470455,"avatar_url":"https://avatars0.githubusercontent.com/u/470455?v=4","gravatar_id":"","url":"https://api.github.com/users/paulomorgado","html_url":"https://github.com/paulomorgado","followers_url":"https://api.github.com/users/paulomorgado/followers","following_url":"https://api.github.com/users/paulomorgado/following{/other_user}","gists_url":"https://api.github.com/users/paulomorgado/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomorgado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomorgado/subscriptions","organizations_url":"https://api.github.com/users/paulomorgado/orgs","repos_url":"https://api.github.com/users/paulomorgado/repos","events_url":"https://api.github.com/users/paulomorgado/events{/privacy}","received_events_url":"https://api.github.com/users/paulomorgado/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T10:16:48Z","updated_at":"2018-03-15T10:16:48Z","author_association":"NONE","body":"The build is ending in error with \r\n\r\n    Couldn't find 'project.json' in '.\\projects\\client\\Unit'\r\n\r\nBut the PR only touches one .cs file. Why is this failing?"}}
{"actor":{"display_login":"paulomorgado"}}