{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/202473475","pull_request_review_id":137190963,"id":202473475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ3MzQ3NQ==","diff_hunk":"@@ -0,0 +1,170 @@\n+// Copyright 2018 Dolphin Emulator Project\n+// Licensed under GPLv2+\n+// Refer to the license.txt file included.\n+\n+#include \"DolphinQt/Config/GameConfigEdit.h\"\n+\n+#include <QCompleter>\n+#include <QDesktopServices>\n+#include <QFile>\n+#include <QMenu>\n+#include <QTextCursor>\n+#include <QTextEdit>\n+#include <QVBoxLayout>\n+#include <QWhatsThis>\n+\n+#include \"DolphinQt/Config/GameConfigHighlighter.h\"\n+\n+GameConfigEdit::GameConfigEdit(QWidget* parent, const QString& path) : m_path(path)\n+{\n+  LoadFile();\n+\n+  setAcceptRichText(false);\n+  setContextMenuPolicy(Qt::CustomContextMenu);\n+\n+  new GameConfigHighlighter(document());\n+\n+  m_keyword_map[QStringLiteral(\"Core\")] =\n+      tr(\"Section that contains most CPU- and Hardware related settings.\");\n+\n+  m_keyword_map[QStringLiteral(\"CPUThread\")] = tr(\n+      \"Controls whether or not Dual-Core should be enabled. Can improve performance but can also \"\n+      \"cause issues. Defaults to <b>True</b>\");\n+  m_keyword_map[QStringLiteral(\"FastDiscspeed\")] =\n+      tr(\"Shortens loading times but may break some games. Defaults to <b>False</b>\");\n+  m_keyword_map[QStringLiteral(\"Fastmem\")] =\n+      tr(\"Assumes standard SDK memory accesses. Improves speed and works for most titles.\");\n+  m_keyword_map[QStringLiteral(\"MMU\")] = tr(\"Controls whether or not the Memory Management Unit \"\n+                                            \"should be emulated. Required for many games.\");\n+  m_keyword_map[QStringLiteral(\"DSPHLE\")] =\n+      tr(\"Controls whether to use high- or low-level DSP emulation. Defaults to <b>True</b>\");\n+  m_keyword_map[QStringLiteral(\"JITFollowBranch\")] =\n+      tr(\"Tries to translate branches ahead of time, improving performance in most cases. Defaults \"\n+         \"to <b>True</b>\");\n+\n+  m_keyword_map[QStringLiteral(\"Gecko\")] = tr(\"Section that contains all Gecko cheat codes.\");\n+  m_keyword_map[QStringLiteral(\"ActionReplay\")] =\n+      tr(\"Section that contains all ActionReplay cheat codes.\");\n+  m_keyword_map[QStringLiteral(\"Video_Settings\")] =\n+      tr(\"Section that contains all Graphics related settings.\");\n+\n+  Connect();\n+}\n+\n+void GameConfigEdit::LoadFile()\n+{\n+  QFile file(m_path);\n+  if (!file.open(QIODevice::ReadOnly | QIODevice::Text))\n+    return;\n+\n+  setPlainText(QString::fromStdString(file.readAll().toStdString()));\n+}\n+\n+#include <iostream>\n+\n+void GameConfigEdit::SaveFile()\n+{\n+  if (!isVisible() || isReadOnly())\n+    return;\n+\n+  QFile file(m_path);\n+\n+  if (!file.open(QIODevice::WriteOnly | QIODevice::Truncate | QIODevice::Text))\n+    return;\n+\n+  const std::string contents = toPlainText().toStdString();\n+\n+  file.write(contents.c_str(), contents.length());","path":"Source/Core/DolphinQt/Config/GameConfigEdit.cpp","position":76,"original_position":77,"commit_id":"3661034c56c480f417f54902cf380611decbdf31","original_commit_id":"8a4070161d1e96833c289eb62052962d2c40650f","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"Storing Dolphin on a USB drive or the settings on the USB drive (yeah, don't get me wrong it's as dumb as it sounds, but hey, users) and then removing it (or the port happening to fail after the open). It can also happen on a regular drive that happens to fail after the open, though this would likely be a much rarer case.","created_at":"2018-07-13T21:09:41Z","updated_at":"2018-07-13T21:09:41Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/7263#discussion_r202473475","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/202473475"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7263#discussion_r202473475"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263"}},"in_reply_to_id":202465415},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263","id":201384296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzg0Mjk2","html_url":"https://github.com/dolphin-emu/dolphin/pull/7263","diff_url":"https://github.com/dolphin-emu/dolphin/pull/7263.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/7263.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7263","number":7263,"state":"open","locked":false,"title":"Qt/GameConfigWidget: Complete overhaul","user":{"login":"spycrab","id":1440715,"node_id":"MDQ6VXNlcjE0NDA3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1440715?v=4","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"body":"![Screenshot](https://i.imgur.com/QRYcTSl.png)\r\n\r\nNew features:\r\n* View all default configs at the same time\r\n* Explanation for selected options\r\n* Ability to add config values via context menu","created_at":"2018-07-13T19:48:22Z","updated_at":"2018-07-13T21:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4361e9f4bbcf6784c772297caaea8b11869c97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7263/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3661034c56c480f417f54902cf380611decbdf31","head":{"label":"spycrab:qt_ini_edit","ref":"qt_ini_edit","sha":"3661034c56c480f417f54902cf380611decbdf31","user":{"login":"spycrab","id":1440715,"node_id":"MDQ6VXNlcjE0NDA3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1440715?v=4","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"repo":{"id":88349585,"node_id":"MDEwOlJlcG9zaXRvcnk4ODM0OTU4NQ==","name":"dolphin","full_name":"spycrab/dolphin","owner":{"login":"spycrab","id":1440715,"node_id":"MDQ6VXNlcjE0NDA3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1440715?v=4","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spycrab/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/spycrab/dolphin","forks_url":"https://api.github.com/repos/spycrab/dolphin/forks","keys_url":"https://api.github.com/repos/spycrab/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spycrab/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spycrab/dolphin/teams","hooks_url":"https://api.github.com/repos/spycrab/dolphin/hooks","issue_events_url":"https://api.github.com/repos/spycrab/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/spycrab/dolphin/events","assignees_url":"https://api.github.com/repos/spycrab/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/spycrab/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/spycrab/dolphin/tags","blobs_url":"https://api.github.com/repos/spycrab/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spycrab/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spycrab/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spycrab/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spycrab/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/spycrab/dolphin/languages","stargazers_url":"https://api.github.com/repos/spycrab/dolphin/stargazers","contributors_url":"https://api.github.com/repos/spycrab/dolphin/contributors","subscribers_url":"https://api.github.com/repos/spycrab/dolphin/subscribers","subscription_url":"https://api.github.com/repos/spycrab/dolphin/subscription","commits_url":"https://api.github.com/repos/spycrab/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spycrab/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spycrab/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spycrab/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spycrab/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/spycrab/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spycrab/dolphin/merges","archive_url":"https://api.github.com/repos/spycrab/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spycrab/dolphin/downloads","issues_url":"https://api.github.com/repos/spycrab/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/spycrab/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/spycrab/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/spycrab/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spycrab/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/spycrab/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/spycrab/dolphin/deployments","created_at":"2017-04-15T13:46:17Z","updated_at":"2018-05-25T18:28:21Z","pushed_at":"2018-07-13T20:41:14Z","git_url":"git://github.com/spycrab/dolphin.git","ssh_url":"git@github.com:spycrab/dolphin.git","clone_url":"https://github.com/spycrab/dolphin.git","svn_url":"https://github.com/spycrab/dolphin","homepage":"https://dolphin-emu.org/","size":328424,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"4826acd931144fe8ef532cf38e16c9dee034da99","user":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NzMwNA==","name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2018-07-13T11:07:50Z","pushed_at":"2018-07-13T20:41:16Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":365731,"stargazers_count":4505,"watchers_count":4505,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1068,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1068,"open_issues":104,"watchers":4505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7263"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7263"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7263/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7263/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3661034c56c480f417f54902cf380611decbdf31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lioncash"}}