{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/237183776","pull_request_review_id":179420974,"id":237183776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE4Mzc3Ng==","diff_hunk":"@@ -453,7 +453,8 @@ def _labels_to_key(self, labels):\n         try:\n             return (\n                 labels['dag_id'], labels['task_id'],\n-                self._label_safe_datestring_to_datetime(labels['execution_date']))\n+                self._label_safe_datestring_to_datetime(labels['execution_date']),\n+                labels['try_number'])","path":"airflow/contrib/executors/kubernetes_executor.py","position":15,"original_position":15,"commit_id":"4eebf95e7ecd75dc476e0076dbf72245726dee5e","original_commit_id":"4eebf95e7ecd75dc476e0076dbf72245726dee5e","user":{"login":"vardancse","id":9549839,"node_id":"MDQ6VXNlcjk1NDk4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9549839?v=4","gravatar_id":"","url":"https://api.github.com/users/vardancse","html_url":"https://github.com/vardancse","followers_url":"https://api.github.com/users/vardancse/followers","following_url":"https://api.github.com/users/vardancse/following{/other_user}","gists_url":"https://api.github.com/users/vardancse/gists{/gist_id}","starred_url":"https://api.github.com/users/vardancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vardancse/subscriptions","organizations_url":"https://api.github.com/users/vardancse/orgs","repos_url":"https://api.github.com/users/vardancse/repos","events_url":"https://api.github.com/users/vardancse/events{/privacy}","received_events_url":"https://api.github.com/users/vardancse/received_events","type":"User","site_admin":false},"body":"@aliaksandr-d can you please apply the [patch](https://github.com/apache/incubator-airflow/compare/master...vardancse:k8s_pod?expand=1) and confirm the resolution? ","created_at":"2018-11-28T17:24:01Z","updated_at":"2018-11-28T17:24:01Z","html_url":"https://github.com/apache/incubator-airflow/pull/3994#discussion_r237183776","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/237183776"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3994#discussion_r237183776"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994"}},"in_reply_to_id":237007226},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994","id":219937982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTM3OTgy","html_url":"https://github.com/apache/incubator-airflow/pull/3994","diff_url":"https://github.com/apache/incubator-airflow/pull/3994.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3994.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3994","number":3994,"state":"closed","locked":false,"title":"[AIRFLOW-3136] Add retry_number to TaskInstance Key property to avoid race condition","user":{"login":"vardancse","id":9549839,"node_id":"MDQ6VXNlcjk1NDk4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9549839?v=4","gravatar_id":"","url":"https://api.github.com/users/vardancse","html_url":"https://github.com/vardancse","followers_url":"https://api.github.com/users/vardancse/followers","following_url":"https://api.github.com/users/vardancse/following{/other_user}","gists_url":"https://api.github.com/users/vardancse/gists{/gist_id}","starred_url":"https://api.github.com/users/vardancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vardancse/subscriptions","organizations_url":"https://api.github.com/users/vardancse/orgs","repos_url":"https://api.github.com/users/vardancse/repos","events_url":"https://api.github.com/users/vardancse/events{/privacy}","received_events_url":"https://api.github.com/users/vardancse/received_events","type":"User","site_admin":false},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [AIRFLOW-3136](https://issues.apache.org/jira/browse/AIRFLOW-3136) issues and references them in the PR title. \r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR.\r\nWe were seeing an intermittent issue where executor reports task instance finished while task says it's in queue state, it was due to a race condition between scheduler which was clearing event_buffer in _process_executor_events method in jobs.py executor was about to put next_retry task's status as running which was failed in previous try. So, we thought to add retry_number as the member of TaskInstance key property.\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n","created_at":"2018-10-03T07:22:59Z","updated_at":"2018-11-28T17:24:01Z","closed_at":"2018-10-31T20:40:32Z","merged_at":"2018-10-31T20:40:32Z","merge_commit_sha":"8f15661001706e5bd76a7134c4c8ece06ad83a63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3994/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/4eebf95e7ecd75dc476e0076dbf72245726dee5e","head":{"label":"vardancse:master","ref":"master","sha":"4eebf95e7ecd75dc476e0076dbf72245726dee5e","user":{"login":"vardancse","id":9549839,"node_id":"MDQ6VXNlcjk1NDk4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9549839?v=4","gravatar_id":"","url":"https://api.github.com/users/vardancse","html_url":"https://github.com/vardancse","followers_url":"https://api.github.com/users/vardancse/followers","following_url":"https://api.github.com/users/vardancse/following{/other_user}","gists_url":"https://api.github.com/users/vardancse/gists{/gist_id}","starred_url":"https://api.github.com/users/vardancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vardancse/subscriptions","organizations_url":"https://api.github.com/users/vardancse/orgs","repos_url":"https://api.github.com/users/vardancse/repos","events_url":"https://api.github.com/users/vardancse/events{/privacy}","received_events_url":"https://api.github.com/users/vardancse/received_events","type":"User","site_admin":false},"repo":{"id":143717101,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MTcxMDE=","name":"incubator-airflow","full_name":"vardancse/incubator-airflow","private":false,"owner":{"login":"vardancse","id":9549839,"node_id":"MDQ6VXNlcjk1NDk4Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9549839?v=4","gravatar_id":"","url":"https://api.github.com/users/vardancse","html_url":"https://github.com/vardancse","followers_url":"https://api.github.com/users/vardancse/followers","following_url":"https://api.github.com/users/vardancse/following{/other_user}","gists_url":"https://api.github.com/users/vardancse/gists{/gist_id}","starred_url":"https://api.github.com/users/vardancse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vardancse/subscriptions","organizations_url":"https://api.github.com/users/vardancse/orgs","repos_url":"https://api.github.com/users/vardancse/repos","events_url":"https://api.github.com/users/vardancse/events{/privacy}","received_events_url":"https://api.github.com/users/vardancse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vardancse/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/vardancse/incubator-airflow","forks_url":"https://api.github.com/repos/vardancse/incubator-airflow/forks","keys_url":"https://api.github.com/repos/vardancse/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vardancse/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vardancse/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/vardancse/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/vardancse/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/vardancse/incubator-airflow/events","assignees_url":"https://api.github.com/repos/vardancse/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/vardancse/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/vardancse/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/vardancse/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vardancse/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vardancse/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vardancse/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vardancse/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/vardancse/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/vardancse/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/vardancse/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/vardancse/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/vardancse/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/vardancse/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vardancse/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vardancse/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vardancse/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vardancse/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/vardancse/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vardancse/incubator-airflow/merges","archive_url":"https://api.github.com/repos/vardancse/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vardancse/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/vardancse/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/vardancse/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/vardancse/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/vardancse/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vardancse/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/vardancse/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/vardancse/incubator-airflow/deployments","created_at":"2018-08-06T11:09:07Z","updated_at":"2018-11-28T17:15:59Z","pushed_at":"2018-11-28T17:21:38Z","git_url":"git://github.com/vardancse/incubator-airflow.git","ssh_url":"git@github.com:vardancse/incubator-airflow.git","clone_url":"https://github.com/vardancse/incubator-airflow.git","svn_url":"https://github.com/vardancse/incubator-airflow","homepage":"https://airflow.apache.org","size":24691,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e703d6beeb379ee88ef5e7df495e8a785666f8af","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"incubator-airflow","full_name":"apache/incubator-airflow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2018-11-28T16:53:03Z","pushed_at":"2018-11-28T16:52:16Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"https://airflow.apache.org","size":28199,"stargazers_count":10063,"watchers_count":10063,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3488,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3488,"open_issues":309,"watchers":10063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3994"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3994"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3994/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3994/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/4eebf95e7ecd75dc476e0076dbf72245726dee5e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vardancse"}}