{"action":"closed","number":574,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574","id":174925937,"html_url":"https://github.com/Metaswitch/clearwater-etcd/pull/574","diff_url":"https://github.com/Metaswitch/clearwater-etcd/pull/574.diff","patch_url":"https://github.com/Metaswitch/clearwater-etcd/pull/574.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/574","number":574,"state":"closed","locked":false,"title":"[Reviewer: KAF] Fix up RPH config access plugin to use new interface","user":{"login":"sebrexmetaswitch","id":4903681,"avatar_url":"https://avatars3.githubusercontent.com/u/4903681?v=4","gravatar_id":"","url":"https://api.github.com/users/sebrexmetaswitch","html_url":"https://github.com/sebrexmetaswitch","followers_url":"https://api.github.com/users/sebrexmetaswitch/followers","following_url":"https://api.github.com/users/sebrexmetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/sebrexmetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/sebrexmetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebrexmetaswitch/subscriptions","organizations_url":"https://api.github.com/users/sebrexmetaswitch/orgs","repos_url":"https://api.github.com/users/sebrexmetaswitch/repos","events_url":"https://api.github.com/users/sebrexmetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/sebrexmetaswitch/received_events","type":"User","site_admin":false},"body":"Test changes corresponding to: https://github.com/Metaswitch/clearwater-etcd-plugins/pull/60\r\n\r\n`make full_test` passes, and I've live tested uploading valid rph_json and it works (and invalid rph_json is correctly rejected).","created_at":"2018-03-14T11:28:21Z","updated_at":"2018-03-14T12:22:06Z","closed_at":"2018-03-14T12:22:06Z","merged_at":"2018-03-14T12:22:06Z","merge_commit_sha":"59b59076eb9051e5f9cd8a5e3fb22dbb2cc20d26","assignee":{"login":"kenferguson","id":26568647,"avatar_url":"https://avatars3.githubusercontent.com/u/26568647?v=4","gravatar_id":"","url":"https://api.github.com/users/kenferguson","html_url":"https://github.com/kenferguson","followers_url":"https://api.github.com/users/kenferguson/followers","following_url":"https://api.github.com/users/kenferguson/following{/other_user}","gists_url":"https://api.github.com/users/kenferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/kenferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenferguson/subscriptions","organizations_url":"https://api.github.com/users/kenferguson/orgs","repos_url":"https://api.github.com/users/kenferguson/repos","events_url":"https://api.github.com/users/kenferguson/events{/privacy}","received_events_url":"https://api.github.com/users/kenferguson/received_events","type":"User","site_admin":false},"assignees":[{"login":"kenferguson","id":26568647,"avatar_url":"https://avatars3.githubusercontent.com/u/26568647?v=4","gravatar_id":"","url":"https://api.github.com/users/kenferguson","html_url":"https://github.com/kenferguson","followers_url":"https://api.github.com/users/kenferguson/followers","following_url":"https://api.github.com/users/kenferguson/following{/other_user}","gists_url":"https://api.github.com/users/kenferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/kenferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenferguson/subscriptions","organizations_url":"https://api.github.com/users/kenferguson/orgs","repos_url":"https://api.github.com/users/kenferguson/repos","events_url":"https://api.github.com/users/kenferguson/events{/privacy}","received_events_url":"https://api.github.com/users/kenferguson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/574/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/54d170bcd5def2c5ffc54a6d20a4f5d47651c883","head":{"label":"Metaswitch:iss_3717","ref":"iss_3717","sha":"54d170bcd5def2c5ffc54a6d20a4f5d47651c883","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":34358654,"name":"clearwater-etcd","full_name":"Metaswitch/clearwater-etcd","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd","description":"Wrappers around etcd for ease of integration into Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/deployments","created_at":"2015-04-22T00:03:08Z","updated_at":"2018-03-14T12:18:15Z","pushed_at":"2018-03-14T12:22:06Z","git_url":"git://github.com/Metaswitch/clearwater-etcd.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd","homepage":null,"size":46772,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":29,"watchers":4,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"5c57e57d213d8ae075dc79672ba1abe52bc3c89b","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":34358654,"name":"clearwater-etcd","full_name":"Metaswitch/clearwater-etcd","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd","description":"Wrappers around etcd for ease of integration into Project Clearwater","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd/deployments","created_at":"2015-04-22T00:03:08Z","updated_at":"2018-03-14T12:18:15Z","pushed_at":"2018-03-14T12:22:06Z","git_url":"git://github.com/Metaswitch/clearwater-etcd.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd","homepage":null,"size":46772,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":29,"watchers":4,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574"},"html":{"href":"https://github.com/Metaswitch/clearwater-etcd/pull/574"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/574"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/issues/574/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/pulls/574/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd/statuses/54d170bcd5def2c5ffc54a6d20a4f5d47651c883"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sebrexmetaswitch","id":4903681,"avatar_url":"https://avatars3.githubusercontent.com/u/4903681?v=4","gravatar_id":"","url":"https://api.github.com/users/sebrexmetaswitch","html_url":"https://github.com/sebrexmetaswitch","followers_url":"https://api.github.com/users/sebrexmetaswitch/followers","following_url":"https://api.github.com/users/sebrexmetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/sebrexmetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/sebrexmetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebrexmetaswitch/subscriptions","organizations_url":"https://api.github.com/users/sebrexmetaswitch/orgs","repos_url":"https://api.github.com/users/sebrexmetaswitch/repos","events_url":"https://api.github.com/users/sebrexmetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/sebrexmetaswitch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":6,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"sebrexmetaswitch"}}