{"action":"created","issue":{"url":"https://api.github.com/repos/pawn-lang/compiler/issues/363","repository_url":"https://api.github.com/repos/pawn-lang/compiler","labels_url":"https://api.github.com/repos/pawn-lang/compiler/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/pawn-lang/compiler/issues/363/comments","events_url":"https://api.github.com/repos/pawn-lang/compiler/issues/363/events","html_url":"https://github.com/pawn-lang/compiler/pull/363","id":357747711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjg5MjM5","number":363,"title":"amxaux.c: Don't forget to close the program file before returning","user":{"login":"Daniel-Cortez","id":5159716,"node_id":"MDQ6VXNlcjUxNTk3MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5159716?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-Cortez","html_url":"https://github.com/Daniel-Cortez","followers_url":"https://api.github.com/users/Daniel-Cortez/followers","following_url":"https://api.github.com/users/Daniel-Cortez/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-Cortez/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-Cortez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-Cortez/subscriptions","organizations_url":"https://api.github.com/users/Daniel-Cortez/orgs","repos_url":"https://api.github.com/users/Daniel-Cortez/repos","events_url":"https://api.github.com/users/Daniel-Cortez/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-Cortez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-06T17:11:17Z","updated_at":"2018-09-07T17:47:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pawn-lang/compiler/pulls/363","html_url":"https://github.com/pawn-lang/compiler/pull/363","diff_url":"https://github.com/pawn-lang/compiler/pull/363.diff","patch_url":"https://github.com/pawn-lang/compiler/pull/363.patch"},"body":"<!--\r\nPlease ensure you have read the CONTRIBUTING.md document before submitting this\r\npull request. Requests that fail to follow enough of the guidelines will likely\r\nbe closed immediately with request to rectify the issues.\r\n\r\nNever pull to `master` - always pull to `dev` or a relevant feature branch.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nFixes bugs introduced in 44312b96532cc1056a9f6e46bec82525d5a53229 (the interpreter won't close the AMX file if `aux_ProgramSize()` or `aux_LoadProgram()` couldn't read the data from it). Not that these bugs matter much (the file is closed automatically by the OS when the interpreter process is terminated anyway), but I believe it still would be right to fix them.\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\n<!--GitHub tip: using \"Fixes #<issue number> will automatically close the issue upon being merged-->\r\n\r\n-\r\n\r\n**What kind of pull this is**:\r\n\r\n<!--Replace [ ] with [x] to mark the checkbox-->\r\n\r\n* [x] A Bug Fix\r\n* [ ] A New Feature\r\n* [ ] Some repository meta (documentation, etc)\r\n* [ ] Other\r\n\r\n**Additional Documentation**:\r\n\r\n<!--\r\nIf your PR introduces a change that requires documentation, add it here so it can be added to the wiki.\r\nFeel free to edit the wiki yourself once your PR has been accepted.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/pawn-lang/compiler/issues/comments/419515495","html_url":"https://github.com/pawn-lang/compiler/pull/363#issuecomment-419515495","issue_url":"https://api.github.com/repos/pawn-lang/compiler/issues/363","id":419515495,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUxNTQ5NQ==","user":{"login":"Zeex","id":1277375,"node_id":"MDQ6VXNlcjEyNzczNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1277375?v=4","gravatar_id":"","url":"https://api.github.com/users/Zeex","html_url":"https://github.com/Zeex","followers_url":"https://api.github.com/users/Zeex/followers","following_url":"https://api.github.com/users/Zeex/following{/other_user}","gists_url":"https://api.github.com/users/Zeex/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeex/subscriptions","organizations_url":"https://api.github.com/users/Zeex/orgs","repos_url":"https://api.github.com/users/Zeex/repos","events_url":"https://api.github.com/users/Zeex/events{/privacy}","received_events_url":"https://api.github.com/users/Zeex/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T17:47:04Z","updated_at":"2018-09-07T17:47:04Z","author_association":"COLLABORATOR","body":"@Y-Less amxaux is now used by [pawnruns](https://github.com/pawn-lang/compiler/blob/dev/source/compiler/pawnruns.c) (the program that runs runtime tests), so I think we do need to take care of bugs related to it. \r\n\r\nI know that I kind of said earlier that VM changes are out of scope of this project - that is because pretty much nobody uses this version of the VM, so if something gets broken hardly anyone would notice. With the compiler it's easy - just compile stuff and see if it works, and there are a lot of people who use it and can report bugs. But with the VM how do you verify that some patch or feature works? \r\n\r\nWell, I'm not the one to decide what to include anyway since I kind of retired, but if VM patches are useful to somebody I don't have a problem with that, feel free to accept them 😃 "}}
{"actor":{"display_login":"Zeex"}}