{"action":"created","issue":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9657","repository_url":"https://api.github.com/repos/paritytech/parity-ethereum","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9657/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9657/comments","events_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9657/events","html_url":"https://github.com/paritytech/parity-ethereum/pull/9657","id":364240718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDc2MTIy","number":9657,"title":"[WIP] Replace `tokio_core` with `tokio` (`ring` -> 0.13)","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"labels":[{"id":323587553,"node_id":"MDU6TGFiZWwzMjM1ODc1NTM=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/A3-inprogress%20%E2%8F%B3","name":"A3-inprogress ⏳","color":"DBC6F8","default":false},{"id":890839339,"node_id":"MDU6TGFiZWw4OTA4MzkzMzk=","url":"https://api.github.com/repos/paritytech/parity-ethereum/labels/M5-dependencies%20%F0%9F%96%87","name":"M5-dependencies 🖇","color":"eff9f6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/23","html_url":"https://github.com/paritytech/parity-ethereum/milestone/23","labels_url":"https://api.github.com/repos/paritytech/parity-ethereum/milestones/23/labels","id":3293872,"node_id":"MDk6TWlsZXN0b25lMzI5Mzg3Mg==","number":23,"title":"2.2","description":"","creator":{"login":"5chdn","id":15729797,"node_id":"MDQ6VXNlcjE1NzI5Nzk3","avatar_url":"https://avatars3.githubusercontent.com/u/15729797?v=4","gravatar_id":"","url":"https://api.github.com/users/5chdn","html_url":"https://github.com/5chdn","followers_url":"https://api.github.com/users/5chdn/followers","following_url":"https://api.github.com/users/5chdn/following{/other_user}","gists_url":"https://api.github.com/users/5chdn/gists{/gist_id}","starred_url":"https://api.github.com/users/5chdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5chdn/subscriptions","organizations_url":"https://api.github.com/users/5chdn/orgs","repos_url":"https://api.github.com/users/5chdn/repos","events_url":"https://api.github.com/users/5chdn/events{/privacy}","received_events_url":"https://api.github.com/users/5chdn/received_events","type":"User","site_admin":false},"open_issues":165,"closed_issues":175,"state":"open","created_at":"2018-04-24T17:56:33Z","updated_at":"2018-10-09T20:07:26Z","due_on":"2018-10-29T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-09-26T22:42:46Z","updated_at":"2018-10-09T23:40:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/pulls/9657","html_url":"https://github.com/paritytech/parity-ethereum/pull/9657","diff_url":"https://github.com/paritytech/parity-ethereum/pull/9657.diff","patch_url":"https://github.com/paritytech/parity-ethereum/pull/9657.patch"},"body":"## Changes\r\n\r\n* Remove `tokio-core` and replace with `tokio` in\r\n    - `ethcore/stratum`\r\n    - `secret_store`\r\n    - `util/fetch`\r\n    - `util/reactor`\r\n\r\n* Bump hyper to 0.12 in\r\n    - `miner`\r\n    - `util/fake-fetch`\r\n    - `util/fetch`\r\n\r\n* Bump `jsonrpc-***` to 0.9 in\r\n    - `parity`\r\n    - `ethcore/stratum`\r\n    - `ipfs`\r\n    - `rpc`\r\n    - `rpc_client`\r\n    - `whisper`\r\n\r\n* Bump `ring` to 0.13\r\n\r\n## Still Incomplete\r\n\r\n* [X] Troubleshoot the following failing tests:\r\n    - json_tests::state::state_tests::GeneralStateTest_stCallCreateCallCodeTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stDelegatecallTestHomestead\r\n    - json_tests::state::state_tests::GeneralStateTest_stInitCodeTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stRandom\r\n    - json_tests::state::state_tests::GeneralStateTest_stRevertTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stSpecialTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stSystemOperationsTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stTransactionTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stTransitionTest\r\n    - json_tests::state::state_tests::GeneralStateTest_stZeroCallsRevert\r\n* [ ] Replace/Update dependency sources:\r\n    - [X] `parity-common` (Needs a release, tag, or branch other than master)\r\n    - [X] `ring` (unclear if upstream works properly on Android)\r\n    - [ ] `jsonrpc-***` \r\n      - [X] awaiting merge\r\n      - [ ] need a tag, branch, or release to depend on\r\n    - [X] `cid`\r\n* [ ] Determine what to do with the `it_should_not_read_too_much_data_sync`\r\n  test (`util/fetch/src/client.rs:807`).\r\n\r\n\r\n## Related Upcoming TODOs (separate PR)\r\n\r\n* Remove `CpuPool` and consolidate runtime uses. Rename and redesign `EventLoop` for use as as the primary tokio runtime entry point. This will include adding separate methods for spawning tasks on a threadpool as opposed to spawning on a single-threaded reactor. Some functionality relies, perhaps foolishly, on ordering assumptions which just happen to be true in practice when using a single-threaded runtime but which *may* not necessarily always be the case.\r\n* Convert many boxed future return types to `impl Future` and clean up extra types.\r\n* Ensure no errors are discarded in `secret_store/src/key_server_cluster/cluster.rs` (and elsewhere).\r\n* Consider a more graceful shutdown process for `ClusterCore` (`secret_store/src/key_server_cluster/cluster.rs:801`).\r\n\r\nI could really use help from someone familiar with the json_tests to help me troubleshoot the failures there. Please advise on what to do about the other incomplete items."},"comment":{"url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/comments/428389585","html_url":"https://github.com/paritytech/parity-ethereum/pull/9657#issuecomment-428389585","issue_url":"https://api.github.com/repos/paritytech/parity-ethereum/issues/9657","id":428389585,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODM4OTU4NQ==","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T23:40:47Z","updated_at":"2018-10-09T23:40:47Z","author_association":"CONTRIBUTOR","body":"This PR is ready to go, modulo the two points noted above (see OP)."}}
{"actor":{"display_login":"c0gent"}}