{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/4226","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/4226/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4226/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/4226/events","html_url":"https://github.com/prometheus/prometheus/pull/4226","id":329571869,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzk1NTI5","number":4226,"title":"Add offset to selectParams","user":{"login":"jacksontj","id":1619869,"node_id":"MDQ6VXNlcjE2MTk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":47,"created_at":"2018-06-05T18:22:47Z","updated_at":"2018-06-13T20:40:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4226","html_url":"https://github.com/prometheus/prometheus/pull/4226","diff_url":"https://github.com/prometheus/prometheus/pull/4226.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4226.patch"},"body":"This adds the Offset from the promql.EvalStmt to the selectParams which\r\nis sent to the querier during Select()\r\n\r\nFixes #4224"},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/397078843","html_url":"https://github.com/prometheus/prometheus/pull/4226#issuecomment-397078843","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4226","id":397078843,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzA3ODg0Mw==","user":{"login":"fabxc","id":4948210,"node_id":"MDQ6VXNlcjQ5NDgyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4948210?v=4","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T20:40:34Z","updated_at":"2018-06-13T20:40:34Z","author_association":"MEMBER","body":"> (as adding time selectors to the Select() method in the TSDB would be good as well -- to avoid over-fetching)\r\n\r\nAs you wrote further up, TSDB loads data lazily. So there is no over-fetching beyond the very high level (how many blocks to we include to begin with), which is unlikely to show up in any performance profile.  \r\nCould you clarify what kind of problem adding time selectors would solve?"}}
{"actor":{"display_login":"fabxc"}}