{"action":"created","comment":{"url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/comments/198017296","pull_request_review_id":131868613,"id":198017296,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODAxNzI5Ng==","diff_hunk":"@@ -0,0 +1,144 @@\n+/**\n+ * @file traffic_light_detector.cpp\n+ * @author Adrian Malaran\n+ * @competition IARRC 2018\n+ */\n+\n+// OPENCV includes\n+// #include <opencv2/highgui/highgui.hpp>\n+// #include <opencv2/imgproc/imgproc.hpp>\n+\n+// OTHER includes\n+#include <iostream>\n+#include <vector>\n+#include <cmath>\n+#include \"traffic_light_detection/traffic_light_detector.hpp\"\n+\n+#include <darknet_ros_msgs/BoundingBoxes.h>\n+#include <darknet_ros_msgs/BoundingBox.h>\n+\n+#include <sensor_msgs/Image.h>\n+#include <std_msgs/Int8.h>\n+\n+#include <ros/ros.h>\n+\n+// OpenCv\n+#include <image_transport/image_transport.h>\n+#include <sensor_msgs/image_encodings.h>\n+#include <opencv2/imgproc/imgproc.hpp>\n+#include <opencv2/highgui/highgui.hpp>\n+#include <cv_bridge/cv_bridge.h>\n+\n+namespace enc = sensor_msgs::image_encodings;\n+\n+/**@name TrafficLightDetector \n+ * @brief Constructor\n+ */","path":"darknet_ros/traffic_light_detection/src/traffic_light_detector.cpp","position":null,"original_position":36,"commit_id":"136200e61e05637d9d17474a201b3bc1d5a665f4","original_commit_id":"2523bd4f67c830d8af0938c257e13ac2f80c9c07","user":{"login":"Oluwatoni","id":10319891,"node_id":"MDQ6VXNlcjEwMzE5ODkx","avatar_url":"https://avatars3.githubusercontent.com/u/10319891?v=4","gravatar_id":"","url":"https://api.github.com/users/Oluwatoni","html_url":"https://github.com/Oluwatoni","followers_url":"https://api.github.com/users/Oluwatoni/followers","following_url":"https://api.github.com/users/Oluwatoni/following{/other_user}","gists_url":"https://api.github.com/users/Oluwatoni/gists{/gist_id}","starred_url":"https://api.github.com/users/Oluwatoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oluwatoni/subscriptions","organizations_url":"https://api.github.com/users/Oluwatoni/orgs","repos_url":"https://api.github.com/users/Oluwatoni/repos","events_url":"https://api.github.com/users/Oluwatoni/events{/privacy}","received_events_url":"https://api.github.com/users/Oluwatoni/received_events","type":"User","site_admin":false},"body":"fix indentation","created_at":"2018-06-26T05:28:38Z","updated_at":"2018-06-26T05:31:45Z","html_url":"https://github.com/uwrobotics/RobotRacing2018/pull/29#discussion_r198017296","pull_request_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/comments/198017296"},"html":{"href":"https://github.com/uwrobotics/RobotRacing2018/pull/29#discussion_r198017296"},"pull_request":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29","id":195991564,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTkxNTY0","html_url":"https://github.com/uwrobotics/RobotRacing2018/pull/29","diff_url":"https://github.com/uwrobotics/RobotRacing2018/pull/29.diff","patch_url":"https://github.com/uwrobotics/RobotRacing2018/pull/29.patch","issue_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/29","number":29,"state":"open","locked":false,"title":"Revising Traffic Light Processor Node/Integration of YOLO object classifier","user":{"login":"AdrianMalaran","id":16600325,"node_id":"MDQ6VXNlcjE2NjAwMzI1","avatar_url":"https://avatars1.githubusercontent.com/u/16600325?v=4","gravatar_id":"","url":"https://api.github.com/users/AdrianMalaran","html_url":"https://github.com/AdrianMalaran","followers_url":"https://api.github.com/users/AdrianMalaran/followers","following_url":"https://api.github.com/users/AdrianMalaran/following{/other_user}","gists_url":"https://api.github.com/users/AdrianMalaran/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianMalaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianMalaran/subscriptions","organizations_url":"https://api.github.com/users/AdrianMalaran/orgs","repos_url":"https://api.github.com/users/AdrianMalaran/repos","events_url":"https://api.github.com/users/AdrianMalaran/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianMalaran/received_events","type":"User","site_admin":false},"body":"This PR includes:\r\n- Addition of YOLO object classifier as a separate ROS node to be launched as a dependency of the traffic light detector node\r\n- Complete revision of traffic light processor node to support use of YOLO\r\n\r\n**Notes:**\r\n@Oluwatoni Please confirm that these changes (Addition of YOLO node) will not break compilation on machines that don't have CUDA installed.\r\n\r\nYOLO object classifier node reference: https://github.com/leggedrobotics/darknet_ros \r\n\r\nFurther testing will be performed through hardware tests to determine classification success rate.","created_at":"2018-06-20T00:17:47Z","updated_at":"2018-06-26T05:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62aee5ad0071425591cb1d00b1469222967cb960","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29/commits","review_comments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29/comments","review_comment_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/29/comments","statuses_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/statuses/136200e61e05637d9d17474a201b3bc1d5a665f4","head":{"label":"uwrobotics:darknet-object-detector","ref":"darknet-object-detector","sha":"136200e61e05637d9d17474a201b3bc1d5a665f4","user":{"login":"uwrobotics","id":30238881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM4ODgx","avatar_url":"https://avatars3.githubusercontent.com/u/30238881?v=4","gravatar_id":"","url":"https://api.github.com/users/uwrobotics","html_url":"https://github.com/uwrobotics","followers_url":"https://api.github.com/users/uwrobotics/followers","following_url":"https://api.github.com/users/uwrobotics/following{/other_user}","gists_url":"https://api.github.com/users/uwrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/uwrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwrobotics/subscriptions","organizations_url":"https://api.github.com/users/uwrobotics/orgs","repos_url":"https://api.github.com/users/uwrobotics/repos","events_url":"https://api.github.com/users/uwrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/uwrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":117773968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NzM5Njg=","name":"RobotRacing2018","full_name":"uwrobotics/RobotRacing2018","owner":{"login":"uwrobotics","id":30238881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM4ODgx","avatar_url":"https://avatars3.githubusercontent.com/u/30238881?v=4","gravatar_id":"","url":"https://api.github.com/users/uwrobotics","html_url":"https://github.com/uwrobotics","followers_url":"https://api.github.com/users/uwrobotics/followers","following_url":"https://api.github.com/users/uwrobotics/following{/other_user}","gists_url":"https://api.github.com/users/uwrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/uwrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwrobotics/subscriptions","organizations_url":"https://api.github.com/users/uwrobotics/orgs","repos_url":"https://api.github.com/users/uwrobotics/repos","events_url":"https://api.github.com/users/uwrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/uwrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwrobotics/RobotRacing2018","description":"This repository contains the current competition code (2018). This code will be used for the IARRC 2018. This code currently handles LIDAR mapping, trajectory rollout, PID speed control, lane detection and traffic light detection.","fork":false,"url":"https://api.github.com/repos/uwrobotics/RobotRacing2018","forks_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/forks","keys_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/teams","hooks_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/hooks","issue_events_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/events{/number}","events_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/events","assignees_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/assignees{/user}","branches_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/branches{/branch}","tags_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/tags","blobs_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/statuses/{sha}","languages_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/languages","stargazers_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/stargazers","contributors_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/contributors","subscribers_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/subscribers","subscription_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/subscription","commits_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/contents/{+path}","compare_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/merges","archive_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/downloads","issues_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues{/number}","pulls_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls{/number}","milestones_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/milestones{/number}","notifications_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/labels{/name}","releases_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/releases{/id}","deployments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/deployments","created_at":"2018-01-17T02:48:14Z","updated_at":"2018-06-21T06:30:41Z","pushed_at":"2018-06-26T04:15:40Z","git_url":"git://github.com/uwrobotics/RobotRacing2018.git","ssh_url":"git@github.com:uwrobotics/RobotRacing2018.git","clone_url":"https://github.com/uwrobotics/RobotRacing2018.git","svn_url":"https://github.com/uwrobotics/RobotRacing2018","homepage":"http://uwrobotics.uwaterloo.ca/","size":17403,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":4,"default_branch":"master"}},"base":{"label":"uwrobotics:master","ref":"master","sha":"49b9d6a617d8a16048fcebe4cfb55fa3402a1fe0","user":{"login":"uwrobotics","id":30238881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM4ODgx","avatar_url":"https://avatars3.githubusercontent.com/u/30238881?v=4","gravatar_id":"","url":"https://api.github.com/users/uwrobotics","html_url":"https://github.com/uwrobotics","followers_url":"https://api.github.com/users/uwrobotics/followers","following_url":"https://api.github.com/users/uwrobotics/following{/other_user}","gists_url":"https://api.github.com/users/uwrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/uwrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwrobotics/subscriptions","organizations_url":"https://api.github.com/users/uwrobotics/orgs","repos_url":"https://api.github.com/users/uwrobotics/repos","events_url":"https://api.github.com/users/uwrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/uwrobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":117773968,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NzM5Njg=","name":"RobotRacing2018","full_name":"uwrobotics/RobotRacing2018","owner":{"login":"uwrobotics","id":30238881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjM4ODgx","avatar_url":"https://avatars3.githubusercontent.com/u/30238881?v=4","gravatar_id":"","url":"https://api.github.com/users/uwrobotics","html_url":"https://github.com/uwrobotics","followers_url":"https://api.github.com/users/uwrobotics/followers","following_url":"https://api.github.com/users/uwrobotics/following{/other_user}","gists_url":"https://api.github.com/users/uwrobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/uwrobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwrobotics/subscriptions","organizations_url":"https://api.github.com/users/uwrobotics/orgs","repos_url":"https://api.github.com/users/uwrobotics/repos","events_url":"https://api.github.com/users/uwrobotics/events{/privacy}","received_events_url":"https://api.github.com/users/uwrobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwrobotics/RobotRacing2018","description":"This repository contains the current competition code (2018). This code will be used for the IARRC 2018. This code currently handles LIDAR mapping, trajectory rollout, PID speed control, lane detection and traffic light detection.","fork":false,"url":"https://api.github.com/repos/uwrobotics/RobotRacing2018","forks_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/forks","keys_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/teams","hooks_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/hooks","issue_events_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/events{/number}","events_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/events","assignees_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/assignees{/user}","branches_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/branches{/branch}","tags_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/tags","blobs_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/statuses/{sha}","languages_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/languages","stargazers_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/stargazers","contributors_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/contributors","subscribers_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/subscribers","subscription_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/subscription","commits_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/contents/{+path}","compare_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/merges","archive_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/downloads","issues_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues{/number}","pulls_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls{/number}","milestones_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/milestones{/number}","notifications_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/labels{/name}","releases_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/releases{/id}","deployments_url":"https://api.github.com/repos/uwrobotics/RobotRacing2018/deployments","created_at":"2018-01-17T02:48:14Z","updated_at":"2018-06-21T06:30:41Z","pushed_at":"2018-06-26T04:15:40Z","git_url":"git://github.com/uwrobotics/RobotRacing2018.git","ssh_url":"git@github.com:uwrobotics/RobotRacing2018.git","clone_url":"https://github.com/uwrobotics/RobotRacing2018.git","svn_url":"https://github.com/uwrobotics/RobotRacing2018","homepage":"http://uwrobotics.uwaterloo.ca/","size":17403,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29"},"html":{"href":"https://github.com/uwrobotics/RobotRacing2018/pull/29"},"issue":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/29"},"comments":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/uwrobotics/RobotRacing2018/statuses/136200e61e05637d9d17474a201b3bc1d5a665f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"Oluwatoni"}}