{"action":"created","comment":{"url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/comments/215499560","pull_request_review_id":152776810,"id":215499560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ5OTU2MA==","diff_hunk":"@@ -23,4 +24,4 @@ def run_genesis(top: str,\n     res = os.system(cmd)\n     if not res == 0:\n         raise RuntimeError(f\"Genesis failed! cmd = {cmd}\")\n-    return f\"genesis_verif/{top}.v\"\n+    return f\"genesis_verif/{top}.{'sv' if system_verilog else 'v'}\"","path":"common/run_genesis.py","position":15,"original_position":15,"commit_id":"77fb665381e44cf3468703ed48e9aa16831931f2","original_commit_id":"77fb665381e44cf3468703ed48e9aa16831931f2","user":{"login":"rsetaluri","id":5567915,"node_id":"MDQ6VXNlcjU1Njc5MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5567915?v=4","gravatar_id":"","url":"https://api.github.com/users/rsetaluri","html_url":"https://github.com/rsetaluri","followers_url":"https://api.github.com/users/rsetaluri/followers","following_url":"https://api.github.com/users/rsetaluri/following{/other_user}","gists_url":"https://api.github.com/users/rsetaluri/gists{/gist_id}","starred_url":"https://api.github.com/users/rsetaluri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsetaluri/subscriptions","organizations_url":"https://api.github.com/users/rsetaluri/orgs","repos_url":"https://api.github.com/users/rsetaluri/repos","events_url":"https://api.github.com/users/rsetaluri/events{/privacy}","received_events_url":"https://api.github.com/users/rsetaluri/received_events","type":"User","site_admin":false},"body":"is the `system_verilog` flag only used for returning the correct output verilog filename? I actually think we need to re-up the genesis wrappers, for the case where multiple files are output. We ideally are keeping track of all of the verilog files in a design (in some way, even if we don't parse them).\r\n\r\nFor now this is good.","created_at":"2018-09-06T05:27:57Z","updated_at":"2018-09-06T05:29:39Z","html_url":"https://github.com/StanfordAHA/garnet/pull/97#discussion_r215499560","pull_request_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/comments/215499560"},"html":{"href":"https://github.com/StanfordAHA/garnet/pull/97#discussion_r215499560"},"pull_request":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97"}},"in_reply_to_id":215487727},"pull_request":{"url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97","id":213486799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDg2Nzk5","html_url":"https://github.com/StanfordAHA/garnet/pull/97","diff_url":"https://github.com/StanfordAHA/garnet/pull/97.diff","patch_url":"https://github.com/StanfordAHA/garnet/pull/97.patch","issue_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/97","number":97,"state":"open","locked":false,"title":"Initialize PE wrapper","user":{"login":"leonardt","id":3766436,"node_id":"MDQ6VXNlcjM3NjY0MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3766436?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardt","html_url":"https://github.com/leonardt","followers_url":"https://api.github.com/users/leonardt/followers","following_url":"https://api.github.com/users/leonardt/following{/other_user}","gists_url":"https://api.github.com/users/leonardt/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardt/subscriptions","organizations_url":"https://api.github.com/users/leonardt/orgs","repos_url":"https://api.github.com/users/leonardt/repos","events_url":"https://api.github.com/users/leonardt/events{/privacy}","received_events_url":"https://api.github.com/users/leonardt/received_events","type":"User","site_admin":false},"body":"Depends on my fork of pyverilog (https://github.com/leonardt/Pyverilog) which adds preliminary support for `logic`, `always_ff`, and `always_comb` in the parser  (see https://github.com/leonardt/Pyverilog/commit/5701a9abdcced82edff238acd35bb795e0e11275).\r\n\r\nRight now the magma frontend just ignores this, as it's an annotation on the module declaration like `reg`, which is only used by the Verilog compiler for synthesis/simulation, but not in the magma interface (it just maps to Bit or Bits with a direction). Adding these constructs to the parser avoids the parse errors though.\r\n\r\nI will present this to the Pyverilog developers and see about getting it mainlined (they may want more robust support that covers all the cases, this is just what I needed to parse the PE so it may not be complete).\r\n\r\nThe only change to the PE genesis code was to replace the `DataWidth` verilog module parameter with a genesis2 parameter `data_width`. This is because magma's frontend does not support parametrized verilog modules. There are ways to support this feature, but I think the change was trivial enough on the genesis side (basically search and replace the verilog parameter with perl value interpolation) that I chose not to add the feature that's fairly complex.","created_at":"2018-09-06T03:40:01Z","updated_at":"2018-09-06T05:29:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0544a9ee70df79e4f02fd59f3ff4b4a02f77c525","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexcarsello","id":4943164,"node_id":"MDQ6VXNlcjQ5NDMxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4943164?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcarsello","html_url":"https://github.com/alexcarsello","followers_url":"https://api.github.com/users/alexcarsello/followers","following_url":"https://api.github.com/users/alexcarsello/following{/other_user}","gists_url":"https://api.github.com/users/alexcarsello/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcarsello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcarsello/subscriptions","organizations_url":"https://api.github.com/users/alexcarsello/orgs","repos_url":"https://api.github.com/users/alexcarsello/repos","events_url":"https://api.github.com/users/alexcarsello/events{/privacy}","received_events_url":"https://api.github.com/users/alexcarsello/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97/commits","review_comments_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97/comments","review_comment_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/97/comments","statuses_url":"https://api.github.com/repos/StanfordAHA/garnet/statuses/77fb665381e44cf3468703ed48e9aa16831931f2","head":{"label":"StanfordAHA:wrap-pe","ref":"wrap-pe","sha":"77fb665381e44cf3468703ed48e9aa16831931f2","user":{"login":"StanfordAHA","id":26314150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTUw","avatar_url":"https://avatars1.githubusercontent.com/u/26314150?v=4","gravatar_id":"","url":"https://api.github.com/users/StanfordAHA","html_url":"https://github.com/StanfordAHA","followers_url":"https://api.github.com/users/StanfordAHA/followers","following_url":"https://api.github.com/users/StanfordAHA/following{/other_user}","gists_url":"https://api.github.com/users/StanfordAHA/gists{/gist_id}","starred_url":"https://api.github.com/users/StanfordAHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanfordAHA/subscriptions","organizations_url":"https://api.github.com/users/StanfordAHA/orgs","repos_url":"https://api.github.com/users/StanfordAHA/repos","events_url":"https://api.github.com/users/StanfordAHA/events{/privacy}","received_events_url":"https://api.github.com/users/StanfordAHA/received_events","type":"Organization","site_admin":false},"repo":{"id":140670939,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NzA5Mzk=","name":"garnet","full_name":"StanfordAHA/garnet","owner":{"login":"StanfordAHA","id":26314150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTUw","avatar_url":"https://avatars1.githubusercontent.com/u/26314150?v=4","gravatar_id":"","url":"https://api.github.com/users/StanfordAHA","html_url":"https://github.com/StanfordAHA","followers_url":"https://api.github.com/users/StanfordAHA/followers","following_url":"https://api.github.com/users/StanfordAHA/following{/other_user}","gists_url":"https://api.github.com/users/StanfordAHA/gists{/gist_id}","starred_url":"https://api.github.com/users/StanfordAHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanfordAHA/subscriptions","organizations_url":"https://api.github.com/users/StanfordAHA/orgs","repos_url":"https://api.github.com/users/StanfordAHA/repos","events_url":"https://api.github.com/users/StanfordAHA/events{/privacy}","received_events_url":"https://api.github.com/users/StanfordAHA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StanfordAHA/garnet","description":"Next generation CGRA generator","fork":false,"url":"https://api.github.com/repos/StanfordAHA/garnet","forks_url":"https://api.github.com/repos/StanfordAHA/garnet/forks","keys_url":"https://api.github.com/repos/StanfordAHA/garnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StanfordAHA/garnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StanfordAHA/garnet/teams","hooks_url":"https://api.github.com/repos/StanfordAHA/garnet/hooks","issue_events_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/events{/number}","events_url":"https://api.github.com/repos/StanfordAHA/garnet/events","assignees_url":"https://api.github.com/repos/StanfordAHA/garnet/assignees{/user}","branches_url":"https://api.github.com/repos/StanfordAHA/garnet/branches{/branch}","tags_url":"https://api.github.com/repos/StanfordAHA/garnet/tags","blobs_url":"https://api.github.com/repos/StanfordAHA/garnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StanfordAHA/garnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StanfordAHA/garnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/StanfordAHA/garnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StanfordAHA/garnet/statuses/{sha}","languages_url":"https://api.github.com/repos/StanfordAHA/garnet/languages","stargazers_url":"https://api.github.com/repos/StanfordAHA/garnet/stargazers","contributors_url":"https://api.github.com/repos/StanfordAHA/garnet/contributors","subscribers_url":"https://api.github.com/repos/StanfordAHA/garnet/subscribers","subscription_url":"https://api.github.com/repos/StanfordAHA/garnet/subscription","commits_url":"https://api.github.com/repos/StanfordAHA/garnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/StanfordAHA/garnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/StanfordAHA/garnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/StanfordAHA/garnet/contents/{+path}","compare_url":"https://api.github.com/repos/StanfordAHA/garnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StanfordAHA/garnet/merges","archive_url":"https://api.github.com/repos/StanfordAHA/garnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StanfordAHA/garnet/downloads","issues_url":"https://api.github.com/repos/StanfordAHA/garnet/issues{/number}","pulls_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls{/number}","milestones_url":"https://api.github.com/repos/StanfordAHA/garnet/milestones{/number}","notifications_url":"https://api.github.com/repos/StanfordAHA/garnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StanfordAHA/garnet/labels{/name}","releases_url":"https://api.github.com/repos/StanfordAHA/garnet/releases{/id}","deployments_url":"https://api.github.com/repos/StanfordAHA/garnet/deployments","created_at":"2018-07-12T06:30:10Z","updated_at":"2018-09-06T03:30:17Z","pushed_at":"2018-09-06T03:40:01Z","git_url":"git://github.com/StanfordAHA/garnet.git","ssh_url":"git@github.com:StanfordAHA/garnet.git","clone_url":"https://github.com/StanfordAHA/garnet.git","svn_url":"https://github.com/StanfordAHA/garnet","homepage":"","size":506,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"base":{"label":"StanfordAHA:master","ref":"master","sha":"aeb7d732a895a50783197006ddf25d2114968d2c","user":{"login":"StanfordAHA","id":26314150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTUw","avatar_url":"https://avatars1.githubusercontent.com/u/26314150?v=4","gravatar_id":"","url":"https://api.github.com/users/StanfordAHA","html_url":"https://github.com/StanfordAHA","followers_url":"https://api.github.com/users/StanfordAHA/followers","following_url":"https://api.github.com/users/StanfordAHA/following{/other_user}","gists_url":"https://api.github.com/users/StanfordAHA/gists{/gist_id}","starred_url":"https://api.github.com/users/StanfordAHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanfordAHA/subscriptions","organizations_url":"https://api.github.com/users/StanfordAHA/orgs","repos_url":"https://api.github.com/users/StanfordAHA/repos","events_url":"https://api.github.com/users/StanfordAHA/events{/privacy}","received_events_url":"https://api.github.com/users/StanfordAHA/received_events","type":"Organization","site_admin":false},"repo":{"id":140670939,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2NzA5Mzk=","name":"garnet","full_name":"StanfordAHA/garnet","owner":{"login":"StanfordAHA","id":26314150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTUw","avatar_url":"https://avatars1.githubusercontent.com/u/26314150?v=4","gravatar_id":"","url":"https://api.github.com/users/StanfordAHA","html_url":"https://github.com/StanfordAHA","followers_url":"https://api.github.com/users/StanfordAHA/followers","following_url":"https://api.github.com/users/StanfordAHA/following{/other_user}","gists_url":"https://api.github.com/users/StanfordAHA/gists{/gist_id}","starred_url":"https://api.github.com/users/StanfordAHA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanfordAHA/subscriptions","organizations_url":"https://api.github.com/users/StanfordAHA/orgs","repos_url":"https://api.github.com/users/StanfordAHA/repos","events_url":"https://api.github.com/users/StanfordAHA/events{/privacy}","received_events_url":"https://api.github.com/users/StanfordAHA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StanfordAHA/garnet","description":"Next generation CGRA generator","fork":false,"url":"https://api.github.com/repos/StanfordAHA/garnet","forks_url":"https://api.github.com/repos/StanfordAHA/garnet/forks","keys_url":"https://api.github.com/repos/StanfordAHA/garnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StanfordAHA/garnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StanfordAHA/garnet/teams","hooks_url":"https://api.github.com/repos/StanfordAHA/garnet/hooks","issue_events_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/events{/number}","events_url":"https://api.github.com/repos/StanfordAHA/garnet/events","assignees_url":"https://api.github.com/repos/StanfordAHA/garnet/assignees{/user}","branches_url":"https://api.github.com/repos/StanfordAHA/garnet/branches{/branch}","tags_url":"https://api.github.com/repos/StanfordAHA/garnet/tags","blobs_url":"https://api.github.com/repos/StanfordAHA/garnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StanfordAHA/garnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StanfordAHA/garnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/StanfordAHA/garnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StanfordAHA/garnet/statuses/{sha}","languages_url":"https://api.github.com/repos/StanfordAHA/garnet/languages","stargazers_url":"https://api.github.com/repos/StanfordAHA/garnet/stargazers","contributors_url":"https://api.github.com/repos/StanfordAHA/garnet/contributors","subscribers_url":"https://api.github.com/repos/StanfordAHA/garnet/subscribers","subscription_url":"https://api.github.com/repos/StanfordAHA/garnet/subscription","commits_url":"https://api.github.com/repos/StanfordAHA/garnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/StanfordAHA/garnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/StanfordAHA/garnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/StanfordAHA/garnet/contents/{+path}","compare_url":"https://api.github.com/repos/StanfordAHA/garnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StanfordAHA/garnet/merges","archive_url":"https://api.github.com/repos/StanfordAHA/garnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StanfordAHA/garnet/downloads","issues_url":"https://api.github.com/repos/StanfordAHA/garnet/issues{/number}","pulls_url":"https://api.github.com/repos/StanfordAHA/garnet/pulls{/number}","milestones_url":"https://api.github.com/repos/StanfordAHA/garnet/milestones{/number}","notifications_url":"https://api.github.com/repos/StanfordAHA/garnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StanfordAHA/garnet/labels{/name}","releases_url":"https://api.github.com/repos/StanfordAHA/garnet/releases{/id}","deployments_url":"https://api.github.com/repos/StanfordAHA/garnet/deployments","created_at":"2018-07-12T06:30:10Z","updated_at":"2018-09-06T03:30:17Z","pushed_at":"2018-09-06T03:40:01Z","git_url":"git://github.com/StanfordAHA/garnet.git","ssh_url":"git@github.com:StanfordAHA/garnet.git","clone_url":"https://github.com/StanfordAHA/garnet.git","svn_url":"https://github.com/StanfordAHA/garnet","homepage":"","size":506,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":0,"open_issues":22,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97"},"html":{"href":"https://github.com/StanfordAHA/garnet/pull/97"},"issue":{"href":"https://api.github.com/repos/StanfordAHA/garnet/issues/97"},"comments":{"href":"https://api.github.com/repos/StanfordAHA/garnet/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StanfordAHA/garnet/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/StanfordAHA/garnet/statuses/77fb665381e44cf3468703ed48e9aa16831931f2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rsetaluri"}}