{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/227544477","pull_request_review_id":167611984,"id":227544477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzU0NDQ3Nw==","diff_hunk":"@@ -0,0 +1,115 @@\n+/*\n+ *\n+ * Copyright 2018 gRPC authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ *\n+ */\n+\n+package healthcheck\n+\n+import (\n+\t\"errors\"\n+\t\"io\"\n+\t\"time\"\n+\n+\t\"golang.org/x/net/context\"\n+\t\"google.golang.org/grpc\"\n+\t\"google.golang.org/grpc/codes\"\n+\thealthpb \"google.golang.org/grpc/health/grpc_health_v1\"\n+\t\"google.golang.org/grpc/internal\"\n+\t\"google.golang.org/grpc/internal/backoff\"\n+\t\"google.golang.org/grpc/status\"\n+)\n+\n+func init() {\n+\tinternal.HealthCheckFunc = newClientHealthCheck\n+}\n+\n+const maxDelay time.Duration = 5 * time.Second","path":"healthcheck/healthcheck.go","position":null,"original_position":39,"commit_id":"fb29394f9288a96359f625234325162b13b7aebf","original_commit_id":"d7eaf1223925134cc78fabf1177698c79dd07cd6","user":{"login":"canguler","id":7987187,"node_id":"MDQ6VXNlcjc5ODcxODc=","avatar_url":"https://avatars2.githubusercontent.com/u/7987187?v=4","gravatar_id":"","url":"https://api.github.com/users/canguler","html_url":"https://github.com/canguler","followers_url":"https://api.github.com/users/canguler/followers","following_url":"https://api.github.com/users/canguler/following{/other_user}","gists_url":"https://api.github.com/users/canguler/gists{/gist_id}","starred_url":"https://api.github.com/users/canguler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canguler/subscriptions","organizations_url":"https://api.github.com/users/canguler/orgs","repos_url":"https://api.github.com/users/canguler/repos","events_url":"https://api.github.com/users/canguler/events{/privacy}","received_events_url":"https://api.github.com/users/canguler/received_events","type":"User","site_admin":false},"body":"I've removed the type. But I have another question: What should our maximum delay be?","created_at":"2018-10-23T20:06:46Z","updated_at":"2018-10-23T20:06:46Z","html_url":"https://github.com/grpc/grpc-go/pull/2389#discussion_r227544477","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/227544477"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2389#discussion_r227544477"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2389"}},"in_reply_to_id":227498071},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/2389","id":224145100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTQ1MTAw","html_url":"https://github.com/grpc/grpc-go/pull/2389","diff_url":"https://github.com/grpc/grpc-go/pull/2389.diff","patch_url":"https://github.com/grpc/grpc-go/pull/2389.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/2389","number":2389,"state":"open","locked":false,"title":"healthcheck: newClientHealthCheck and its unit test","user":{"login":"canguler","id":7987187,"node_id":"MDQ6VXNlcjc5ODcxODc=","avatar_url":"https://avatars2.githubusercontent.com/u/7987187?v=4","gravatar_id":"","url":"https://api.github.com/users/canguler","html_url":"https://github.com/canguler","followers_url":"https://api.github.com/users/canguler/followers","following_url":"https://api.github.com/users/canguler/following{/other_user}","gists_url":"https://api.github.com/users/canguler/gists{/gist_id}","starred_url":"https://api.github.com/users/canguler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canguler/subscriptions","organizations_url":"https://api.github.com/users/canguler/orgs","repos_url":"https://api.github.com/users/canguler/repos","events_url":"https://api.github.com/users/canguler/events{/privacy}","received_events_url":"https://api.github.com/users/canguler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-19T01:23:53Z","updated_at":"2018-10-23T20:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22b034d6086fa3ce36ec3d94f0308da9f4059e3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2389/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2389/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/2389/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/fb29394f9288a96359f625234325162b13b7aebf","head":{"label":"canguler:healthcheck","ref":"healthcheck","sha":"fb29394f9288a96359f625234325162b13b7aebf","user":{"login":"canguler","id":7987187,"node_id":"MDQ6VXNlcjc5ODcxODc=","avatar_url":"https://avatars2.githubusercontent.com/u/7987187?v=4","gravatar_id":"","url":"https://api.github.com/users/canguler","html_url":"https://github.com/canguler","followers_url":"https://api.github.com/users/canguler/followers","following_url":"https://api.github.com/users/canguler/following{/other_user}","gists_url":"https://api.github.com/users/canguler/gists{/gist_id}","starred_url":"https://api.github.com/users/canguler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canguler/subscriptions","organizations_url":"https://api.github.com/users/canguler/orgs","repos_url":"https://api.github.com/users/canguler/repos","events_url":"https://api.github.com/users/canguler/events{/privacy}","received_events_url":"https://api.github.com/users/canguler/received_events","type":"User","site_admin":false},"repo":{"id":152323780,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzMjM3ODA=","name":"grpc-go","full_name":"canguler/grpc-go","private":false,"owner":{"login":"canguler","id":7987187,"node_id":"MDQ6VXNlcjc5ODcxODc=","avatar_url":"https://avatars2.githubusercontent.com/u/7987187?v=4","gravatar_id":"","url":"https://api.github.com/users/canguler","html_url":"https://github.com/canguler","followers_url":"https://api.github.com/users/canguler/followers","following_url":"https://api.github.com/users/canguler/following{/other_user}","gists_url":"https://api.github.com/users/canguler/gists{/gist_id}","starred_url":"https://api.github.com/users/canguler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canguler/subscriptions","organizations_url":"https://api.github.com/users/canguler/orgs","repos_url":"https://api.github.com/users/canguler/repos","events_url":"https://api.github.com/users/canguler/events{/privacy}","received_events_url":"https://api.github.com/users/canguler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/canguler/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/canguler/grpc-go","forks_url":"https://api.github.com/repos/canguler/grpc-go/forks","keys_url":"https://api.github.com/repos/canguler/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canguler/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canguler/grpc-go/teams","hooks_url":"https://api.github.com/repos/canguler/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/canguler/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/canguler/grpc-go/events","assignees_url":"https://api.github.com/repos/canguler/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/canguler/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/canguler/grpc-go/tags","blobs_url":"https://api.github.com/repos/canguler/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canguler/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canguler/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/canguler/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canguler/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/canguler/grpc-go/languages","stargazers_url":"https://api.github.com/repos/canguler/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/canguler/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/canguler/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/canguler/grpc-go/subscription","commits_url":"https://api.github.com/repos/canguler/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/canguler/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/canguler/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/canguler/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/canguler/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/canguler/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canguler/grpc-go/merges","archive_url":"https://api.github.com/repos/canguler/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canguler/grpc-go/downloads","issues_url":"https://api.github.com/repos/canguler/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/canguler/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/canguler/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/canguler/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canguler/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/canguler/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/canguler/grpc-go/deployments","created_at":"2018-10-09T21:27:48Z","updated_at":"2018-10-18T22:36:40Z","pushed_at":"2018-10-23T20:04:33Z","git_url":"git://github.com/canguler/grpc-go.git","ssh_url":"git@github.com:canguler/grpc-go.git","clone_url":"https://github.com/canguler/grpc-go.git","svn_url":"https://github.com/canguler/grpc-go","homepage":"","size":6865,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"d7518259e000d23a615e7caa4812dd15f2fd3b46","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkwNw==","name":"grpc-go","full_name":"grpc/grpc-go","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2018-10-23T18:56:47Z","pushed_at":"2018-10-23T20:04:35Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":7393,"stargazers_count":6663,"watchers_count":6663,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1296,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1296,"open_issues":96,"watchers":6663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2389"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2389"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2389"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2389/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2389/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2389/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/fb29394f9288a96359f625234325162b13b7aebf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"canguler"}}