{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/221867535","pull_request_review_id":160617796,"id":221867535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg2NzUzNQ==","diff_hunk":"@@ -355,23 +494,85 @@ class ResolverBehavior: Behavior<ResolverProtocol.Type> {\n \t\t\t\t\t]\n \n \t\t\t\tdo {\n-\t\t\t\t\tlet resolved = db.resolve(resolverType, [ github1: .atLeast(.v3_0_0) ])\n+\t\t\t\t\tlet resolved = db.resolve(resolverClass, [ github1: .atLeast(.v3_0_0) ])\n \t\t\t\t\texpect(resolved.value).to(beNil())\n \t\t\t\t\texpect(resolved.error).notTo(beNil())\n \t\t\t\t}\n \t\t\t\t\n \t\t\t\tdo {\n-\t\t\t\t\tlet resolved = db.resolve(resolverType, [ github1: .compatibleWith(.v3_0_0) ])\n+\t\t\t\t\tlet resolved = db.resolve(resolverClass, [ github1: .compatibleWith(.v3_0_0) ])\n \t\t\t\t\texpect(resolved.value).to(beNil())\n \t\t\t\t\texpect(resolved.error).notTo(beNil())\n \t\t\t\t}\n \t\t\t\t\n \t\t\t\tdo {\n-\t\t\t\t\tlet resolved = db.resolve(resolverType, [ github1: .exactly(.v3_0_0) ])\n+\t\t\t\t\tlet resolved = db.resolve(resolverClass, [ github1: .exactly(.v3_0_0) ])\n \t\t\t\t\texpect(resolved.value).to(beNil())\n \t\t\t\t\texpect(resolved.error).notTo(beNil())\n \t\t\t\t}\n \t\t\t}\n \t\t}\n+\n+        pending(\"should fail on cyclic dependencies\") {\n+            let db: DB = [\n+                github1: [\n+                    .v1_0_0: [\n+                        github2: .compatibleWith(.v1_0_0),\n+                    ],\n+                    .v1_1_0: [\n+                        github2: .compatibleWith(.v1_0_0),\n+                    ],\n+                    .v2_0_0: [\n+                        github2: .compatibleWith(.v2_0_0),","path":"Tests/CarthageKitTests/ResolverSpec.swift","position":402,"original_position":402,"commit_id":"e28a77dcfa7653a468a392afa18836ee169f74a7","original_commit_id":"e28a77dcfa7653a468a392afa18836ee169f74a7","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)","created_at":"2018-10-02T08:42:59Z","updated_at":"2018-10-02T08:43:01Z","html_url":"https://github.com/Carthage/Carthage/pull/2519#discussion_r221867535","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2519","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/221867535"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2519#discussion_r221867535"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2519"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2519","id":202535081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTM1MDgx","html_url":"https://github.com/Carthage/Carthage/pull/2519","diff_url":"https://github.com/Carthage/Carthage/pull/2519.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2519.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2519","number":2519,"state":"open","locked":false,"title":"Resolver diagnostics","user":{"login":"werner77","id":467589,"node_id":"MDQ6VXNlcjQ2NzU4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/467589?v=4","gravatar_id":"","url":"https://api.github.com/users/werner77","html_url":"https://github.com/werner77","followers_url":"https://api.github.com/users/werner77/followers","following_url":"https://api.github.com/users/werner77/following{/other_user}","gists_url":"https://api.github.com/users/werner77/gists{/gist_id}","starred_url":"https://api.github.com/users/werner77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werner77/subscriptions","organizations_url":"https://api.github.com/users/werner77/orgs","repos_url":"https://api.github.com/users/werner77/repos","events_url":"https://api.github.com/users/werner77/events{/privacy}","received_events_url":"https://api.github.com/users/werner77/received_events","type":"User","site_admin":false},"body":"Adds the diagnose command to store dependency information and Cartfile for problematic dependency trees so offline diagnosis can be done e.g. with unit tests.","created_at":"2018-07-19T11:55:40Z","updated_at":"2018-10-02T08:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504e759ed2f80be35c2e6e97fdf822a4dc2194da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2519/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2519/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2519/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/e28a77dcfa7653a468a392afa18836ee169f74a7","head":{"label":"werner77:resolver-diagnostics","ref":"resolver-diagnostics","sha":"e28a77dcfa7653a468a392afa18836ee169f74a7","user":{"login":"werner77","id":467589,"node_id":"MDQ6VXNlcjQ2NzU4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/467589?v=4","gravatar_id":"","url":"https://api.github.com/users/werner77","html_url":"https://github.com/werner77","followers_url":"https://api.github.com/users/werner77/followers","following_url":"https://api.github.com/users/werner77/following{/other_user}","gists_url":"https://api.github.com/users/werner77/gists{/gist_id}","starred_url":"https://api.github.com/users/werner77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werner77/subscriptions","organizations_url":"https://api.github.com/users/werner77/orgs","repos_url":"https://api.github.com/users/werner77/repos","events_url":"https://api.github.com/users/werner77/events{/privacy}","received_events_url":"https://api.github.com/users/werner77/received_events","type":"User","site_admin":false},"repo":{"id":118369484,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNjk0ODQ=","name":"Carthage","full_name":"werner77/Carthage","private":false,"owner":{"login":"werner77","id":467589,"node_id":"MDQ6VXNlcjQ2NzU4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/467589?v=4","gravatar_id":"","url":"https://api.github.com/users/werner77","html_url":"https://github.com/werner77","followers_url":"https://api.github.com/users/werner77/followers","following_url":"https://api.github.com/users/werner77/following{/other_user}","gists_url":"https://api.github.com/users/werner77/gists{/gist_id}","starred_url":"https://api.github.com/users/werner77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werner77/subscriptions","organizations_url":"https://api.github.com/users/werner77/orgs","repos_url":"https://api.github.com/users/werner77/repos","events_url":"https://api.github.com/users/werner77/events{/privacy}","received_events_url":"https://api.github.com/users/werner77/received_events","type":"User","site_admin":false},"html_url":"https://github.com/werner77/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/werner77/Carthage","forks_url":"https://api.github.com/repos/werner77/Carthage/forks","keys_url":"https://api.github.com/repos/werner77/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/werner77/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/werner77/Carthage/teams","hooks_url":"https://api.github.com/repos/werner77/Carthage/hooks","issue_events_url":"https://api.github.com/repos/werner77/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/werner77/Carthage/events","assignees_url":"https://api.github.com/repos/werner77/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/werner77/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/werner77/Carthage/tags","blobs_url":"https://api.github.com/repos/werner77/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/werner77/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/werner77/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/werner77/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/werner77/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/werner77/Carthage/languages","stargazers_url":"https://api.github.com/repos/werner77/Carthage/stargazers","contributors_url":"https://api.github.com/repos/werner77/Carthage/contributors","subscribers_url":"https://api.github.com/repos/werner77/Carthage/subscribers","subscription_url":"https://api.github.com/repos/werner77/Carthage/subscription","commits_url":"https://api.github.com/repos/werner77/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/werner77/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/werner77/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/werner77/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/werner77/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/werner77/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/werner77/Carthage/merges","archive_url":"https://api.github.com/repos/werner77/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/werner77/Carthage/downloads","issues_url":"https://api.github.com/repos/werner77/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/werner77/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/werner77/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/werner77/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/werner77/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/werner77/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/werner77/Carthage/deployments","created_at":"2018-01-21T20:06:40Z","updated_at":"2018-07-20T18:58:26Z","pushed_at":"2018-10-02T08:42:42Z","git_url":"git://github.com/werner77/Carthage.git","ssh_url":"git@github.com:werner77/Carthage.git","clone_url":"https://github.com/werner77/Carthage.git","svn_url":"https://github.com/werner77/Carthage","homepage":"","size":18696,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"733e9a89f75da6d6900aa3469bbe8fb064d7999a","user":{"login":"Carthage","id":9146792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDY3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA1MDg0NA==","name":"Carthage","full_name":"Carthage/Carthage","private":false,"owner":{"login":"Carthage","id":9146792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDY3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2018-10-02T03:16:31Z","pushed_at":"2018-10-02T08:42:45Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":18603,"stargazers_count":12037,"watchers_count":12037,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1137,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1137,"open_issues":132,"watchers":12037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2519"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2519"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2519"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2519/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2519/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2519/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/e28a77dcfa7653a468a392afa18836ee169f74a7"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}