{"action":"created","issue":{"url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/1","repository_url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2","labels_url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/1/comments","events_url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/1/events","html_url":"https://github.com/JohnnyHendriks/TestAdapter_Catch2/issues/1","id":341110123,"node_id":"MDU6SXNzdWUzNDExMTAxMjM=","number":1,"title":"Sample Project?","user":{"login":"davegi","id":14829103,"node_id":"MDQ6VXNlcjE0ODI5MTAz","avatar_url":"https://avatars0.githubusercontent.com/u/14829103?v=4","gravatar_id":"","url":"https://api.github.com/users/davegi","html_url":"https://github.com/davegi","followers_url":"https://api.github.com/users/davegi/followers","following_url":"https://api.github.com/users/davegi/following{/other_user}","gists_url":"https://api.github.com/users/davegi/gists{/gist_id}","starred_url":"https://api.github.com/users/davegi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegi/subscriptions","organizations_url":"https://api.github.com/users/davegi/orgs","repos_url":"https://api.github.com/users/davegi/repos","events_url":"https://api.github.com/users/davegi/events{/privacy}","received_events_url":"https://api.github.com/users/davegi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-13T18:05:05Z","updated_at":"2018-07-15T21:21:55Z","closed_at":"2018-07-14T10:21:01Z","author_association":"NONE","body":"I've been trying to get this adapter working, by tweaking the _.runsettings_ file, but have yet to get it to even list the `TEST_CASE`  in the Test Explorer. TE is showing MS-Test test cases in the same DLL.\r\n\r\nThis is the test file:\r\n```C++\r\n#include \"stdafx.h\"\r\n//#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do this in one cpp file\r\n#define CATCH_CONFIG_RUNNER\r\n#include \"catch.hpp\"\r\n\r\nunsigned int Factorial(unsigned int number) {\r\n\treturn number <= 1 ? number : Factorial(number - 1)*number;\r\n}\r\n\r\nTEST_CASE(\"Factorials are computed\", \"[factorial]\") {\r\n\tREQUIRE(Factorial(1) == 1);\r\n\tREQUIRE(Factorial(2) == 2);\r\n\tREQUIRE(Factorial(3) == 6);\r\n\tREQUIRE(Factorial(10) == 3628800);\r\n}\r\n```\r\nSo, by chance can you post a fully working / configured Project that successfully uses your Adapter?\r\n\r\nThanks,\r\ndjg"},"comment":{"url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/comments/405119366","html_url":"https://github.com/JohnnyHendriks/TestAdapter_Catch2/issues/1#issuecomment-405119366","issue_url":"https://api.github.com/repos/JohnnyHendriks/TestAdapter_Catch2/issues/1","id":405119366,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTExOTM2Ng==","user":{"login":"davegi","id":14829103,"node_id":"MDQ6VXNlcjE0ODI5MTAz","avatar_url":"https://avatars0.githubusercontent.com/u/14829103?v=4","gravatar_id":"","url":"https://api.github.com/users/davegi","html_url":"https://github.com/davegi","followers_url":"https://api.github.com/users/davegi/followers","following_url":"https://api.github.com/users/davegi/following{/other_user}","gists_url":"https://api.github.com/users/davegi/gists{/gist_id}","starred_url":"https://api.github.com/users/davegi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegi/subscriptions","organizations_url":"https://api.github.com/users/davegi/orgs","repos_url":"https://api.github.com/users/davegi/repos","events_url":"https://api.github.com/users/davegi/events{/privacy}","received_events_url":"https://api.github.com/users/davegi/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T21:21:55Z","updated_at":"2018-07-15T21:21:55Z","author_association":"NONE","body":"OK…I was able to get both of your samples working! Additionally, here’s what I’ve discovered so far…\r\n- I was building a DLL w/`CATCH_CONFIG_RUNNER` defined\r\n- You (I'm guessing) built an EXE w/:\r\n-- Very Basic Example (VBE): `CATCH_CONFIG_MAIN` defined\r\n-- With Custom Discovery (WCD): `CATCH_CONFIG_RUNNER` defined\r\n\r\nI misunderstood the meaning of the two `defines`. I thought the `CATCH_CONFIG_RUNNER` was needed when creating a DLL (i.e., no `main()`).\r\n\r\nThe adapter does not discover any tests when built as a DLL w/either `define`s (!).\r\n\r\nAlso, I noticed that in the VBE the runsettings file contained:\r\n- `<DiscoverCommandLine>--list-tests *</DiscoverCommandLine>`\r\n\r\nWhereas the one for WCD contains:\r\n- `<DiscoverCommandLine>--discover *</DiscoverCommandLine>`\r\n\r\nI missed the difference the first time through.\r\n\r\nThanks for very quick replies and assistance,\r\ndjg"}}
{"actor":{"display_login":"davegi"}}