{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/6802","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/6802/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/6802/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/6802/events","html_url":"https://github.com/webpack/webpack/pull/6802","id":306688880,"number":6802,"title":"[Seeking feedback] Reuse existing entry points if doing multiple passes","user":{"login":"jeffchan","id":97428,"avatar_url":"https://avatars1.githubusercontent.com/u/97428?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchan","html_url":"https://github.com/jeffchan","followers_url":"https://api.github.com/users/jeffchan/followers","following_url":"https://api.github.com/users/jeffchan/following{/other_user}","gists_url":"https://api.github.com/users/jeffchan/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchan/subscriptions","organizations_url":"https://api.github.com/users/jeffchan/orgs","repos_url":"https://api.github.com/users/jeffchan/repos","events_url":"https://api.github.com/users/jeffchan/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchan/received_events","type":"User","site_admin":false},"labels":[{"id":572712741,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":575748502,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20small","name":"PR: small","color":"5319e7","default":false},{"id":572817354,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-20T00:48:08Z","updated_at":"2018-03-20T01:12:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/6802","html_url":"https://github.com/webpack/webpack/pull/6802","diff_url":"https://github.com/webpack/webpack/pull/6802.diff","patch_url":"https://github.com/webpack/webpack/pull/6802.patch"},"body":"**What kind of change does this PR introduce?**\r\n\r\nBugfix\r\n\r\n**Did you add tests for your changes?**\r\n\r\nNot yet. I wanted to get some feedback first.\r\n\r\n**If relevant, link to documentation update:**\r\n\r\nN/A\r\n\r\n**Summary**\r\n\r\nWe have a slightly custom version of `webpack-dev-middleware` where we dynamically add entrypoints to the config as they're requested. I found that each top-level chunk was generating duplicate `Entrypoint` objects, which breaks `chunk.hasRuntime()` since `chunk.hasRuntime()` only looks at the first chunkGroup.\r\n\r\nLooking for some feedback:\r\n- Is this a bug?\r\n- If so, is this best way to fix?\r\n- How best to go about constructing a test case?\r\n\r\nThanks!\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nProbably yes, but bug fix.\r\n\r\n**Other information**\r\n\r\nN/A"},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/374438499","html_url":"https://github.com/webpack/webpack/pull/6802#issuecomment-374438499","issue_url":"https://api.github.com/repos/webpack/webpack/issues/6802","id":374438499,"user":{"login":"webpack-bot","id":26676291,"avatar_url":"https://avatars0.githubusercontent.com/u/26676291?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-bot","html_url":"https://github.com/webpack-bot","followers_url":"https://api.github.com/users/webpack-bot/followers","following_url":"https://api.github.com/users/webpack-bot/following{/other_user}","gists_url":"https://api.github.com/users/webpack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-bot/subscriptions","organizations_url":"https://api.github.com/users/webpack-bot/orgs","repos_url":"https://api.github.com/users/webpack-bot/repos","events_url":"https://api.github.com/users/webpack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T01:12:39Z","updated_at":"2018-03-20T01:12:39Z","author_association":"NONE","body":"<!-- identifier: ci-result -->\n\nThank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon."}}
{"actor":{"display_login":"webpack-bot"}}