{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/204123883","pull_request_review_id":139152663,"id":204123883,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEyMzg4Mw==","diff_hunk":"@@ -189,18 +187,18 @@ public boolean equals(Object o) {\n       return false;\n     }\n     DefaultAccessControlList that = (DefaultAccessControlList) o;\n+    boolean extendedEquals = (mExtendedEntries == null && that.mExtendedEntries == null)","path":"core/common/src/main/java/alluxio/security/authorization/DefaultAccessControlList.java","position":114,"original_position":114,"commit_id":"0b6c0fbc4ec16f87b9addfad32fa1679b5d7144c","original_commit_id":"0b6c0fbc4ec16f87b9addfad32fa1679b5d7144c","user":{"login":"yuzhu","id":736171,"node_id":"MDQ6VXNlcjczNjE3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/736171?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzhu","html_url":"https://github.com/yuzhu","followers_url":"https://api.github.com/users/yuzhu/followers","following_url":"https://api.github.com/users/yuzhu/following{/other_user}","gists_url":"https://api.github.com/users/yuzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzhu/subscriptions","organizations_url":"https://api.github.com/users/yuzhu/orgs","repos_url":"https://api.github.com/users/yuzhu/repos","events_url":"https://api.github.com/users/yuzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzhu/received_events","type":"User","site_admin":false},"body":"should this be changed to consider `null` and empty `extendedEntries` the same?  like `AccessControlList`? ","created_at":"2018-07-20T17:58:01Z","updated_at":"2018-07-20T17:59:02Z","html_url":"https://github.com/Alluxio/alluxio/pull/7649#discussion_r204123883","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/204123883"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7649#discussion_r204123883"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649","id":202894950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODk0OTUw","html_url":"https://github.com/Alluxio/alluxio/pull/7649","diff_url":"https://github.com/Alluxio/alluxio/pull/7649.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7649.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7649","number":7649,"state":"open","locked":false,"title":"[ALLUXIO-3256] Reduce mem usage of ACLs","user":{"login":"gpang","id":429032,"node_id":"MDQ6VXNlcjQyOTAzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-3256","created_at":"2018-07-20T16:14:36Z","updated_at":"2018-07-20T17:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8406488acfbefb4402ffe71e9b44a7c50638f8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7649/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/0b6c0fbc4ec16f87b9addfad32fa1679b5d7144c","head":{"label":"gpang:aclmem","ref":"aclmem","sha":"0b6c0fbc4ec16f87b9addfad32fa1679b5d7144c","user":{"login":"gpang","id":429032,"node_id":"MDQ6VXNlcjQyOTAzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"repo":{"id":32651495,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY1MTQ5NQ==","name":"alluxio","full_name":"gpang/alluxio","owner":{"login":"gpang","id":429032,"node_id":"MDQ6VXNlcjQyOTAzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gpang/alluxio","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/gpang/alluxio","forks_url":"https://api.github.com/repos/gpang/alluxio/forks","keys_url":"https://api.github.com/repos/gpang/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpang/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpang/alluxio/teams","hooks_url":"https://api.github.com/repos/gpang/alluxio/hooks","issue_events_url":"https://api.github.com/repos/gpang/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/gpang/alluxio/events","assignees_url":"https://api.github.com/repos/gpang/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/gpang/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/gpang/alluxio/tags","blobs_url":"https://api.github.com/repos/gpang/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpang/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpang/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpang/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpang/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/gpang/alluxio/languages","stargazers_url":"https://api.github.com/repos/gpang/alluxio/stargazers","contributors_url":"https://api.github.com/repos/gpang/alluxio/contributors","subscribers_url":"https://api.github.com/repos/gpang/alluxio/subscribers","subscription_url":"https://api.github.com/repos/gpang/alluxio/subscription","commits_url":"https://api.github.com/repos/gpang/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpang/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpang/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpang/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpang/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/gpang/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpang/alluxio/merges","archive_url":"https://api.github.com/repos/gpang/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpang/alluxio/downloads","issues_url":"https://api.github.com/repos/gpang/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/gpang/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/gpang/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/gpang/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpang/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/gpang/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/gpang/alluxio/deployments","created_at":"2015-03-21T21:51:11Z","updated_at":"2018-04-11T16:32:46Z","pushed_at":"2018-07-20T17:24:29Z","git_url":"git://github.com/gpang/alluxio.git","ssh_url":"git@github.com:gpang/alluxio.git","clone_url":"https://github.com/gpang/alluxio.git","svn_url":"https://github.com/gpang/alluxio","homepage":"http://alluxio.org/","size":90861,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"8ae099b42fccc31b2edef37fcf592121f63d5409","user":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2OTU0","name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-07-20T17:15:20Z","pushed_at":"2018-07-20T17:26:47Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":90073,"stargazers_count":3573,"watchers_count":3573,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1913,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1913,"open_issues":15,"watchers":3573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7649"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7649"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7649/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7649/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/0b6c0fbc4ec16f87b9addfad32fa1679b5d7144c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yuzhu"}}