{"action":"created","issue":{"url":"https://api.github.com/repos/citra-emu/citra/issues/4468","repository_url":"https://api.github.com/repos/citra-emu/citra","labels_url":"https://api.github.com/repos/citra-emu/citra/issues/4468/labels{/name}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/4468/comments","events_url":"https://api.github.com/repos/citra-emu/citra/issues/4468/events","html_url":"https://github.com/citra-emu/citra/pull/4468","id":384085122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzc5NTE3","number":4468,"title":"[DO NOT MERGE] Multiplayer version 4","user":{"login":"zhaowenlan1779","id":21307832,"node_id":"MDQ6VXNlcjIxMzA3ODMy","avatar_url":"https://avatars0.githubusercontent.com/u/21307832?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaowenlan1779","html_url":"https://github.com/zhaowenlan1779","followers_url":"https://api.github.com/users/zhaowenlan1779/followers","following_url":"https://api.github.com/users/zhaowenlan1779/following{/other_user}","gists_url":"https://api.github.com/users/zhaowenlan1779/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaowenlan1779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaowenlan1779/subscriptions","organizations_url":"https://api.github.com/users/zhaowenlan1779/orgs","repos_url":"https://api.github.com/users/zhaowenlan1779/repos","events_url":"https://api.github.com/users/zhaowenlan1779/events{/privacy}","received_events_url":"https://api.github.com/users/zhaowenlan1779/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-25T14:40:30Z","updated_at":"2018-12-19T06:50:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/4468","html_url":"https://github.com/citra-emu/citra/pull/4468","diff_url":"https://github.com/citra-emu/citra/pull/4468.diff","patch_url":"https://github.com/citra-emu/citra/pull/4468.patch"},"body":"**DO NOT MERGE OR PUT THIS ON CANARY. THIS REQUIRES A VERSION BUMP.**\r\n\r\nThis is a mega PR for the 4th multiplayer version. When the sub-PRs are reviewed, they should be force pushed to here. (Maintainers can push to my branch)\r\n\r\nCurrent plans (All Done!):\r\n\r\nFeatures:\r\n- [X] ~~**(Done #4378)** Web services authentication~~\r\n- [X] ~~**(Done #4379)** #3677~~\r\n- [X] ~~**(Done #4466)** Basic moderation~~\r\n- [X] ~~**(Done #4393)** #3721~~\r\n- [X] ~~(Deferred after discussion) #3681~~\r\n- [X] ~~**(Done #4390)** Protect multiple users with the same Console ID from connecting to the same room~~\r\n- [X] ~~**(Done #4394)** #4177 server side validation~~\r\n- [X] ~~**(Done #4417)** \"XXX Joined\" and \"XXX Left\" status message like IRC~~\r\n- [X] ~~**(Done #4477)** User pings while chatting~~\r\n\r\nBug fixes:\r\n- [X] ~~**(Done #4407)** \"Connected\" message does not appear on first connection to a room~~\r\n\r\n... and more (request for comments)\r\n\r\nBefore merging:\r\n- [x] #4507 \r\n- [x] #4516 \r\n- [x] Test this out with the mods\r\n- [x] Change the lobby endpoint to `/lobby`\r\n- [ ] @chris062689: 1. Switch `/lobby2` to `/lobby` api side; 2. Push an update to citra-emu/citra-multiplayer-dedicated\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/4468)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/citra-emu/citra/issues/comments/448488471","html_url":"https://github.com/citra-emu/citra/pull/4468#issuecomment-448488471","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/4468","id":448488471,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQ4ODQ3MQ==","user":{"login":"edoaxyz","id":17519322,"node_id":"MDQ6VXNlcjE3NTE5MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/17519322?v=4","gravatar_id":"","url":"https://api.github.com/users/edoaxyz","html_url":"https://github.com/edoaxyz","followers_url":"https://api.github.com/users/edoaxyz/followers","following_url":"https://api.github.com/users/edoaxyz/following{/other_user}","gists_url":"https://api.github.com/users/edoaxyz/gists{/gist_id}","starred_url":"https://api.github.com/users/edoaxyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edoaxyz/subscriptions","organizations_url":"https://api.github.com/users/edoaxyz/orgs","repos_url":"https://api.github.com/users/edoaxyz/repos","events_url":"https://api.github.com/users/edoaxyz/events{/privacy}","received_events_url":"https://api.github.com/users/edoaxyz/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T06:50:45Z","updated_at":"2018-12-19T06:50:45Z","author_association":"NONE","body":"Is it possible to add UI sounds triggered whenever an user pings you or an user enters your same room? Obviously these must be selectable in options with enabled ping as default (I think)."}}
{"actor":{"display_login":"edoaxyz"}}