{"action":"opened","number":1822,"pull_request":{"url":"https://api.github.com/repos/CESNET/perun/pulls/1822","id":181463720,"html_url":"https://github.com/CESNET/perun/pull/1822","diff_url":"https://github.com/CESNET/perun/pull/1822.diff","patch_url":"https://github.com/CESNET/perun/pull/1822.patch","issue_url":"https://api.github.com/repos/CESNET/perun/issues/1822","number":1822,"state":"open","locked":false,"title":"ENGINE: Modify Task processing to be more thread safe","user":{"login":"zlamalp","id":1336607,"avatar_url":"https://avatars0.githubusercontent.com/u/1336607?v=4","gravatar_id":"","url":"https://api.github.com/users/zlamalp","html_url":"https://github.com/zlamalp","followers_url":"https://api.github.com/users/zlamalp/followers","following_url":"https://api.github.com/users/zlamalp/following{/other_user}","gists_url":"https://api.github.com/users/zlamalp/gists{/gist_id}","starred_url":"https://api.github.com/users/zlamalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlamalp/subscriptions","organizations_url":"https://api.github.com/users/zlamalp/orgs","repos_url":"https://api.github.com/users/zlamalp/repos","events_url":"https://api.github.com/users/zlamalp/events{/privacy}","received_events_url":"https://api.github.com/users/zlamalp/received_events","type":"User","site_admin":false},"body":"- Added javadoc and comments to many places with explanation and\r\n  reasoning for changes or original source.\r\n- Lowered number of concurrently running SendTasks to 150 from 1000.\r\n  Some machines doesn't like so many sleeping/waiting threads.\r\n- Updated tests to match changes listed below.\r\n\r\nEventProcessorImpl\r\n- If Task is already in pool, do not modify it. Let engine finish\r\n  the job. Dispatcher doesn't reschedule partial destinations\r\n  or forced flag anyway.\r\nTaskExecutionException\r\n- Modified to contain whole Task and related Destination if any.\r\n- This make sure we can always get related Task if propagation fails.\r\n\r\nGenPlanner\r\n- Change Task status immediately after its taken from incoming queue.\r\n- Set startTime after is really submitted for execution.\r\n- This prevents cleaning thread from wrongly killing processing\r\n  Tasks with seemingly inconsistent state.\r\nGenCollector\r\n- Change Task status immediately after its taken from\r\n  genCompletionService.\r\n- Report Task status to Dispatcher before submitting to generatedTasks\r\n  queue since SendPlanner takes it immediately and modify state and\r\n  report different status (SENDING overrun GENERATED).\r\nSendPlanner\r\n- Change Task status immediately after its taken from generatedTasks\r\n  queue and report status to Dispatcher.\r\nSendCollector\r\n- Reimplemented to manage Task status change and endTime. Once\r\n  SendTask is done, its removed from Engine. If there are no more\r\n  SendTasks for Task, Task is also removed.\r\n- We now have Task and Destination always available, since\r\n  implementation of TaskExecutionException changed.\r\n\r\nGenWorkerImpl\r\n- No longer modify Task status, since it might collide with cleaning\r\n  tread which might overrun blockingTake from the queue.\r\nSendWorkerImpl\r\n- Properly set SendTask status and end time, since SendCollector\r\n  manages only Task as a whole. Pass related Task in\r\n  TaskExecutionException.\r\nPropagationMaintainer\r\n- Updated implementation of endStuckTasks() to reflect changes in\r\n  workers and planners/collectors.\r\n- Added many explaining comments for implementation reasoning.","created_at":"2018-04-13T11:43:08Z","updated_at":"2018-04-13T11:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CESNET/perun/pulls/1822/commits","review_comments_url":"https://api.github.com/repos/CESNET/perun/pulls/1822/comments","review_comment_url":"https://api.github.com/repos/CESNET/perun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CESNET/perun/issues/1822/comments","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/b36b6fdc67a46649f2fe29ee01edfab5ef0d05b4","head":{"label":"zlamalp:engine","ref":"engine","sha":"b36b6fdc67a46649f2fe29ee01edfab5ef0d05b4","user":{"login":"zlamalp","id":1336607,"avatar_url":"https://avatars0.githubusercontent.com/u/1336607?v=4","gravatar_id":"","url":"https://api.github.com/users/zlamalp","html_url":"https://github.com/zlamalp","followers_url":"https://api.github.com/users/zlamalp/followers","following_url":"https://api.github.com/users/zlamalp/following{/other_user}","gists_url":"https://api.github.com/users/zlamalp/gists{/gist_id}","starred_url":"https://api.github.com/users/zlamalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlamalp/subscriptions","organizations_url":"https://api.github.com/users/zlamalp/orgs","repos_url":"https://api.github.com/users/zlamalp/repos","events_url":"https://api.github.com/users/zlamalp/events{/privacy}","received_events_url":"https://api.github.com/users/zlamalp/received_events","type":"User","site_admin":false},"repo":{"id":13830293,"name":"perun","full_name":"zlamalp/perun","owner":{"login":"zlamalp","id":1336607,"avatar_url":"https://avatars0.githubusercontent.com/u/1336607?v=4","gravatar_id":"","url":"https://api.github.com/users/zlamalp","html_url":"https://github.com/zlamalp","followers_url":"https://api.github.com/users/zlamalp/followers","following_url":"https://api.github.com/users/zlamalp/following{/other_user}","gists_url":"https://api.github.com/users/zlamalp/gists{/gist_id}","starred_url":"https://api.github.com/users/zlamalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlamalp/subscriptions","organizations_url":"https://api.github.com/users/zlamalp/orgs","repos_url":"https://api.github.com/users/zlamalp/repos","events_url":"https://api.github.com/users/zlamalp/events{/privacy}","received_events_url":"https://api.github.com/users/zlamalp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zlamalp/perun","description":"Identity and Access Management System","fork":true,"url":"https://api.github.com/repos/zlamalp/perun","forks_url":"https://api.github.com/repos/zlamalp/perun/forks","keys_url":"https://api.github.com/repos/zlamalp/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zlamalp/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zlamalp/perun/teams","hooks_url":"https://api.github.com/repos/zlamalp/perun/hooks","issue_events_url":"https://api.github.com/repos/zlamalp/perun/issues/events{/number}","events_url":"https://api.github.com/repos/zlamalp/perun/events","assignees_url":"https://api.github.com/repos/zlamalp/perun/assignees{/user}","branches_url":"https://api.github.com/repos/zlamalp/perun/branches{/branch}","tags_url":"https://api.github.com/repos/zlamalp/perun/tags","blobs_url":"https://api.github.com/repos/zlamalp/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zlamalp/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zlamalp/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/zlamalp/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zlamalp/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/zlamalp/perun/languages","stargazers_url":"https://api.github.com/repos/zlamalp/perun/stargazers","contributors_url":"https://api.github.com/repos/zlamalp/perun/contributors","subscribers_url":"https://api.github.com/repos/zlamalp/perun/subscribers","subscription_url":"https://api.github.com/repos/zlamalp/perun/subscription","commits_url":"https://api.github.com/repos/zlamalp/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/zlamalp/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/zlamalp/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/zlamalp/perun/issues/comments{/number}","contents_url":"https://api.github.com/repos/zlamalp/perun/contents/{+path}","compare_url":"https://api.github.com/repos/zlamalp/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zlamalp/perun/merges","archive_url":"https://api.github.com/repos/zlamalp/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zlamalp/perun/downloads","issues_url":"https://api.github.com/repos/zlamalp/perun/issues{/number}","pulls_url":"https://api.github.com/repos/zlamalp/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/zlamalp/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/zlamalp/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zlamalp/perun/labels{/name}","releases_url":"https://api.github.com/repos/zlamalp/perun/releases{/id}","deployments_url":"https://api.github.com/repos/zlamalp/perun/deployments","created_at":"2013-10-24T11:29:23Z","updated_at":"2018-04-11T12:56:30Z","pushed_at":"2018-04-12T12:01:49Z","git_url":"git://github.com/zlamalp/perun.git","ssh_url":"git@github.com:zlamalp/perun.git","clone_url":"https://github.com/zlamalp/perun.git","svn_url":"https://github.com/zlamalp/perun","homepage":"https://perun.cesnet.cz/","size":32179,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CESNET:master","ref":"master","sha":"8e97b1250edded65783f55346ced44163fc1fae5","user":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars2.githubusercontent.com/u/1116469?v=4","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"repo":{"id":4085998,"name":"perun","full_name":"CESNET/perun","owner":{"login":"CESNET","id":1116469,"avatar_url":"https://avatars2.githubusercontent.com/u/1116469?v=4","gravatar_id":"","url":"https://api.github.com/users/CESNET","html_url":"https://github.com/CESNET","followers_url":"https://api.github.com/users/CESNET/followers","following_url":"https://api.github.com/users/CESNET/following{/other_user}","gists_url":"https://api.github.com/users/CESNET/gists{/gist_id}","starred_url":"https://api.github.com/users/CESNET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESNET/subscriptions","organizations_url":"https://api.github.com/users/CESNET/orgs","repos_url":"https://api.github.com/users/CESNET/repos","events_url":"https://api.github.com/users/CESNET/events{/privacy}","received_events_url":"https://api.github.com/users/CESNET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESNET/perun","description":"Identity and Access Management System","fork":false,"url":"https://api.github.com/repos/CESNET/perun","forks_url":"https://api.github.com/repos/CESNET/perun/forks","keys_url":"https://api.github.com/repos/CESNET/perun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESNET/perun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESNET/perun/teams","hooks_url":"https://api.github.com/repos/CESNET/perun/hooks","issue_events_url":"https://api.github.com/repos/CESNET/perun/issues/events{/number}","events_url":"https://api.github.com/repos/CESNET/perun/events","assignees_url":"https://api.github.com/repos/CESNET/perun/assignees{/user}","branches_url":"https://api.github.com/repos/CESNET/perun/branches{/branch}","tags_url":"https://api.github.com/repos/CESNET/perun/tags","blobs_url":"https://api.github.com/repos/CESNET/perun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESNET/perun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESNET/perun/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESNET/perun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESNET/perun/statuses/{sha}","languages_url":"https://api.github.com/repos/CESNET/perun/languages","stargazers_url":"https://api.github.com/repos/CESNET/perun/stargazers","contributors_url":"https://api.github.com/repos/CESNET/perun/contributors","subscribers_url":"https://api.github.com/repos/CESNET/perun/subscribers","subscription_url":"https://api.github.com/repos/CESNET/perun/subscription","commits_url":"https://api.github.com/repos/CESNET/perun/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESNET/perun/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESNET/perun/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESNET/perun/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESNET/perun/contents/{+path}","compare_url":"https://api.github.com/repos/CESNET/perun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESNET/perun/merges","archive_url":"https://api.github.com/repos/CESNET/perun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESNET/perun/downloads","issues_url":"https://api.github.com/repos/CESNET/perun/issues{/number}","pulls_url":"https://api.github.com/repos/CESNET/perun/pulls{/number}","milestones_url":"https://api.github.com/repos/CESNET/perun/milestones{/number}","notifications_url":"https://api.github.com/repos/CESNET/perun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESNET/perun/labels{/name}","releases_url":"https://api.github.com/repos/CESNET/perun/releases{/id}","deployments_url":"https://api.github.com/repos/CESNET/perun/deployments","created_at":"2012-04-20T11:55:38Z","updated_at":"2018-04-11T12:52:19Z","pushed_at":"2018-04-12T04:55:14Z","git_url":"git://github.com/CESNET/perun.git","ssh_url":"git@github.com:CESNET/perun.git","clone_url":"https://github.com/CESNET/perun.git","svn_url":"https://github.com/CESNET/perun","homepage":"https://perun.cesnet.cz/web/","size":31775,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":46,"open_issues":16,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1822"},"html":{"href":"https://github.com/CESNET/perun/pull/1822"},"issue":{"href":"https://api.github.com/repos/CESNET/perun/issues/1822"},"comments":{"href":"https://api.github.com/repos/CESNET/perun/issues/1822/comments"},"review_comments":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1822/comments"},"review_comment":{"href":"https://api.github.com/repos/CESNET/perun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CESNET/perun/pulls/1822/commits"},"statuses":{"href":"https://api.github.com/repos/CESNET/perun/statuses/b36b6fdc67a46649f2fe29ee01edfab5ef0d05b4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":592,"deletions":295,"changed_files":25}}
{"actor":{"display_login":"zlamalp"}}