{"push_id":2817687492,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"46a4959a67390cdbc0dddf14150b49a215e7c55a","before":"08d39fef30e571dc4f54d65729ae94d893ddd8dd","commits":[{"sha":"46a4959a67390cdbc0dddf14150b49a215e7c55a","author":{"name":"Ed Schiebel","email":"0ca8a83847a5889cf05cb219c0ab09f6b646243b@instructure.com"},"message":"Move toggle label into aria-label\n\nMoving the toggle/checkbox's label from a screenreader-only span to the\ncheckbox's aria-label does the trick.\n\nNOTE: the change is in the analytics repo. to test, checkout the gerrit\ninto gems/plugins/analytics!\n\nfixes ADMIN-1313\n\ntest plan:\n  - have a student in a course with some activity\n  - go to /accounts/1/analytics\n  > expect screenreaders to read the page, including the view toggle,\n    correctly\n  > expect JAWS+ie to include the toggle's label in the menu list of\n    form fields (keybad-insert + f5).\n\n  - repeat at /courses/:course_id/analytics/users/:user_id (go to the\n    course -> people, click on a student, in the student tray that opens\n    click on Analytics)\n  > expect it to work here too\n\n  - repeat for department analytics, but I don't know where that is\n    (though all the changes are exactly the same, so you could assume\n    it works here too if it worked in the other 2 places)\n\nIn firefox, jaws doesn't see _any_ form fields on this page, or\nthe edit assignment page called out in the ticket as an example\nof where to see the menu work properly. This is an issue with\nff + jaws, and not the ticket.\n\nChange-Id: I4919a4df1d2c97f6e593b1eebc6362e26cfb7b56\nReviewed-on: https://gerrit.instructure.com/161159\nTested-by: Jenkins\nReviewed-by: Dan Minkevitch <dan@instructure.com>\nQA-Review: Dan Sasaki <dsasaki@instructure.com>\nProduct-Review: Ed Schiebel <eschiebel@instructure.com>","distinct":true,"url":"https://api.github.com/repos/instructure/analytics/commits/46a4959a67390cdbc0dddf14150b49a215e7c55a"}]}
{"actor":{"display_login":"instructure-gerrit"}}