{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/171754578","pull_request_review_id":100664770,"id":171754578,"diff_hunk":"@@ -0,0 +1,91 @@\n+// Code generated by protoc-gen-validate\n+// source: cilium/nphds.proto\n+// DO NOT EDIT!!!\n+\n+package cilium\n+\n+import (\n+\t\"bytes\"\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"net\"\n+\t\"net/mail\"\n+\t\"net/url\"\n+\t\"regexp\"\n+\t\"strings\"\n+\t\"time\"\n+\t\"unicode/utf8\"\n+\n+\t\"github.com/golang/protobuf/ptypes\"\n+)\n+\n+// ensure the imports are used\n+var (\n+\t_ = bytes.MinRead\n+\t_ = errors.New(\"\")","path":"pkg/envoy/cilium/nphds.pb.validate.go","position":25,"original_position":25,"commit_id":"0949fd511f181018c239c4a72df6e13b1e1ca46b","original_commit_id":"0949fd511f181018c239c4a72df6e13b1e1ca46b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"error var _ should have name of the form errFoo","created_at":"2018-03-02T02:55:17Z","updated_at":"2018-03-02T02:55:19Z","html_url":"https://github.com/cilium/cilium/pull/2993#discussion_r171754578","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/2993","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/171754578"},"html":{"href":"https://github.com/cilium/cilium/pull/2993#discussion_r171754578"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2993"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/2993","id":172410567,"html_url":"https://github.com/cilium/cilium/pull/2993","diff_url":"https://github.com/cilium/cilium/pull/2993.diff","patch_url":"https://github.com/cilium/cilium/pull/2993.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/2993","number":2993,"state":"open","locked":false,"title":"envoy: Fix NPDS message definitions","user":{"login":"rlenglet","id":126329,"avatar_url":"https://avatars3.githubusercontent.com/u/126329?v=4","gravatar_id":"","url":"https://api.github.com/users/rlenglet","html_url":"https://github.com/rlenglet","followers_url":"https://api.github.com/users/rlenglet/followers","following_url":"https://api.github.com/users/rlenglet/following{/other_user}","gists_url":"https://api.github.com/users/rlenglet/gists{/gist_id}","starred_url":"https://api.github.com/users/rlenglet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlenglet/subscriptions","organizations_url":"https://api.github.com/users/rlenglet/orgs","repos_url":"https://api.github.com/users/rlenglet/repos","events_url":"https://api.github.com/users/rlenglet/events{/privacy}","received_events_url":"https://api.github.com/users/rlenglet/received_events","type":"User","site_admin":false},"body":"Generate protobuf validation code for Cilium's xDS API:\r\n    \r\n- Install protoc-gen-validate into $PATH into Vagrant VM.\r\n- Use protoc-gen-validate to generate validation code when generating\r\n- Cilium's xDS protocol buffers code.\r\n\r\nFix NPDS protocol message validation:\r\n\r\n- Remove DirectionNetworkPolicy message.\r\n- Relax field validation constraints.\r\n- Validate every NetworkPolicy message after conversion before sending it to Envoy, to prevent validation errors within Envoy.","created_at":"2018-03-02T02:55:11Z","updated_at":"2018-03-02T02:55:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15496516faf14858f1ec0dc030fb47525d6e7507","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jrajahalme","id":6518235,"avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"proxy","id":2519788,"slug":"proxy","description":"Proxy layer","privacy":"closed","url":"https://api.github.com/teams/2519788","members_url":"https://api.github.com/teams/2519788/members{/member}","repositories_url":"https://api.github.com/teams/2519788/repos","permission":"pull"},{"name":"agent","id":2519792,"slug":"agent","description":"Cilium Agent","privacy":"closed","url":"https://api.github.com/teams/2519792","members_url":"https://api.github.com/teams/2519792/members{/member}","repositories_url":"https://api.github.com/teams/2519792/repos","permission":"pull"},{"name":"vagrant","id":2524637,"slug":"vagrant","description":"Vagrant use","privacy":"closed","url":"https://api.github.com/teams/2524637","members_url":"https://api.github.com/teams/2524637/members{/member}","repositories_url":"https://api.github.com/teams/2524637/repos","permission":"pull"}],"labels":[{"id":721424175,"url":"https://api.github.com/repos/cilium/cilium/labels/area/proxy","name":"area/proxy","color":"fef2c0","default":false},{"id":300384439,"url":"https://api.github.com/repos/cilium/cilium/labels/kind/bug","name":"kind/bug","color":"fc2929","default":false},{"id":403149902,"url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/2993/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/2993/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/2993/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/0949fd511f181018c239c4a72df6e13b1e1ca46b","head":{"label":"cilium:fix-npds-messages","ref":"fix-npds-messages","sha":"0949fd511f181018c239c4a72df6e13b1e1ca46b","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-02T02:06:07Z","pushed_at":"2018-03-02T02:55:11Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":41957,"stargazers_count":1519,"watchers_count":1519,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":379,"watchers":1519,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"5e90ac8271773a8d4cceca8b61511062489e845d","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-02T02:06:07Z","pushed_at":"2018-03-02T02:55:11Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":41957,"stargazers_count":1519,"watchers_count":1519,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":150,"open_issues":379,"watchers":1519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2993"},"html":{"href":"https://github.com/cilium/cilium/pull/2993"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/2993"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/2993/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2993/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2993/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/0949fd511f181018c239c4a72df6e13b1e1ca46b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}