{"action":"created","comment":{"url":"https://api.github.com/repos/kcat/openal-soft/pulls/comments/230454354","pull_request_review_id":171203515,"id":230454354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ1NDM1NA==","diff_hunk":"@@ -20,10 +20,11 @@\n \n #include \"config.h\"\n \n-#include <stdlib.h>\n-#include <stdio.h>\n-#include <assert.h>\n-#include <limits.h>\n+#include <cassert>\n+#include <climits>\n+#include <cstdio>\n+#include <cstdlib>","path":"OpenAL32/alBuffer.cpp","position":11,"original_position":11,"commit_id":"9e9fe0886bfe1f8771b3ba781df704e7c16816e5","original_commit_id":"9e9fe0886bfe1f8771b3ba781df704e7c16816e5","user":{"login":"ShFil119","id":7227492,"node_id":"MDQ6VXNlcjcyMjc0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7227492?v=4","gravatar_id":"","url":"https://api.github.com/users/ShFil119","html_url":"https://github.com/ShFil119","followers_url":"https://api.github.com/users/ShFil119/followers","following_url":"https://api.github.com/users/ShFil119/following{/other_user}","gists_url":"https://api.github.com/users/ShFil119/gists{/gist_id}","starred_url":"https://api.github.com/users/ShFil119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShFil119/subscriptions","organizations_url":"https://api.github.com/users/ShFil119/orgs","repos_url":"https://api.github.com/users/ShFil119/repos","events_url":"https://api.github.com/users/ShFil119/events{/privacy}","received_events_url":"https://api.github.com/users/ShFil119/received_events","type":"User","site_admin":false},"body":"Yeah. Some implementation also have function in global namespace and std. I'll recheck usages. \r\n\r\nReason for change is that `c` libs are less liked by templates.","created_at":"2018-11-02T17:42:04Z","updated_at":"2018-11-02T17:42:04Z","html_url":"https://github.com/kcat/openal-soft/pull/244#discussion_r230454354","pull_request_url":"https://api.github.com/repos/kcat/openal-soft/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/comments/230454354"},"html":{"href":"https://github.com/kcat/openal-soft/pull/244#discussion_r230454354"},"pull_request":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/244"}},"in_reply_to_id":230430966},"pull_request":{"url":"https://api.github.com/repos/kcat/openal-soft/pulls/244","id":227949894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTQ5ODk0","html_url":"https://github.com/kcat/openal-soft/pull/244","diff_url":"https://github.com/kcat/openal-soft/pull/244.diff","patch_url":"https://github.com/kcat/openal-soft/pull/244.patch","issue_url":"https://api.github.com/repos/kcat/openal-soft/issues/244","number":244,"state":"open","locked":false,"title":"Cleanup alBuffer.cpp","user":{"login":"ShFil119","id":7227492,"node_id":"MDQ6VXNlcjcyMjc0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7227492?v=4","gravatar_id":"","url":"https://api.github.com/users/ShFil119","html_url":"https://github.com/ShFil119","followers_url":"https://api.github.com/users/ShFil119/followers","following_url":"https://api.github.com/users/ShFil119/following{/other_user}","gists_url":"https://api.github.com/users/ShFil119/gists{/gist_id}","starred_url":"https://api.github.com/users/ShFil119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShFil119/subscriptions","organizations_url":"https://api.github.com/users/ShFil119/orgs","repos_url":"https://api.github.com/users/ShFil119/repos","events_url":"https://api.github.com/users/ShFil119/events{/privacy}","received_events_url":"https://api.github.com/users/ShFil119/received_events","type":"User","site_admin":false},"body":"Used c++ libs, changed argument name to match with implementation. ","created_at":"2018-11-02T14:14:35Z","updated_at":"2018-11-02T17:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0874a558d7429f07c634575ebc64cab233d973a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kcat/openal-soft/pulls/244/commits","review_comments_url":"https://api.github.com/repos/kcat/openal-soft/pulls/244/comments","review_comment_url":"https://api.github.com/repos/kcat/openal-soft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kcat/openal-soft/issues/244/comments","statuses_url":"https://api.github.com/repos/kcat/openal-soft/statuses/9e9fe0886bfe1f8771b3ba781df704e7c16816e5","head":{"label":"ShFil119:impr/cleanup_alBuffer.cpp","ref":"impr/cleanup_alBuffer.cpp","sha":"9e9fe0886bfe1f8771b3ba781df704e7c16816e5","user":{"login":"ShFil119","id":7227492,"node_id":"MDQ6VXNlcjcyMjc0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7227492?v=4","gravatar_id":"","url":"https://api.github.com/users/ShFil119","html_url":"https://github.com/ShFil119","followers_url":"https://api.github.com/users/ShFil119/followers","following_url":"https://api.github.com/users/ShFil119/following{/other_user}","gists_url":"https://api.github.com/users/ShFil119/gists{/gist_id}","starred_url":"https://api.github.com/users/ShFil119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShFil119/subscriptions","organizations_url":"https://api.github.com/users/ShFil119/orgs","repos_url":"https://api.github.com/users/ShFil119/repos","events_url":"https://api.github.com/users/ShFil119/events{/privacy}","received_events_url":"https://api.github.com/users/ShFil119/received_events","type":"User","site_admin":false},"repo":{"id":155132123,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxMzIxMjM=","name":"openal-soft","full_name":"ShFil119/openal-soft","private":false,"owner":{"login":"ShFil119","id":7227492,"node_id":"MDQ6VXNlcjcyMjc0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7227492?v=4","gravatar_id":"","url":"https://api.github.com/users/ShFil119","html_url":"https://github.com/ShFil119","followers_url":"https://api.github.com/users/ShFil119/followers","following_url":"https://api.github.com/users/ShFil119/following{/other_user}","gists_url":"https://api.github.com/users/ShFil119/gists{/gist_id}","starred_url":"https://api.github.com/users/ShFil119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShFil119/subscriptions","organizations_url":"https://api.github.com/users/ShFil119/orgs","repos_url":"https://api.github.com/users/ShFil119/repos","events_url":"https://api.github.com/users/ShFil119/events{/privacy}","received_events_url":"https://api.github.com/users/ShFil119/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ShFil119/openal-soft","description":"OpenAL Soft is a software implementation of the OpenAL 3D audio API.","fork":true,"url":"https://api.github.com/repos/ShFil119/openal-soft","forks_url":"https://api.github.com/repos/ShFil119/openal-soft/forks","keys_url":"https://api.github.com/repos/ShFil119/openal-soft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShFil119/openal-soft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShFil119/openal-soft/teams","hooks_url":"https://api.github.com/repos/ShFil119/openal-soft/hooks","issue_events_url":"https://api.github.com/repos/ShFil119/openal-soft/issues/events{/number}","events_url":"https://api.github.com/repos/ShFil119/openal-soft/events","assignees_url":"https://api.github.com/repos/ShFil119/openal-soft/assignees{/user}","branches_url":"https://api.github.com/repos/ShFil119/openal-soft/branches{/branch}","tags_url":"https://api.github.com/repos/ShFil119/openal-soft/tags","blobs_url":"https://api.github.com/repos/ShFil119/openal-soft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShFil119/openal-soft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShFil119/openal-soft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShFil119/openal-soft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShFil119/openal-soft/statuses/{sha}","languages_url":"https://api.github.com/repos/ShFil119/openal-soft/languages","stargazers_url":"https://api.github.com/repos/ShFil119/openal-soft/stargazers","contributors_url":"https://api.github.com/repos/ShFil119/openal-soft/contributors","subscribers_url":"https://api.github.com/repos/ShFil119/openal-soft/subscribers","subscription_url":"https://api.github.com/repos/ShFil119/openal-soft/subscription","commits_url":"https://api.github.com/repos/ShFil119/openal-soft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShFil119/openal-soft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShFil119/openal-soft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShFil119/openal-soft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShFil119/openal-soft/contents/{+path}","compare_url":"https://api.github.com/repos/ShFil119/openal-soft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShFil119/openal-soft/merges","archive_url":"https://api.github.com/repos/ShFil119/openal-soft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShFil119/openal-soft/downloads","issues_url":"https://api.github.com/repos/ShFil119/openal-soft/issues{/number}","pulls_url":"https://api.github.com/repos/ShFil119/openal-soft/pulls{/number}","milestones_url":"https://api.github.com/repos/ShFil119/openal-soft/milestones{/number}","notifications_url":"https://api.github.com/repos/ShFil119/openal-soft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShFil119/openal-soft/labels{/name}","releases_url":"https://api.github.com/repos/ShFil119/openal-soft/releases{/id}","deployments_url":"https://api.github.com/repos/ShFil119/openal-soft/deployments","created_at":"2018-10-29T01:04:02Z","updated_at":"2018-10-31T00:17:02Z","pushed_at":"2018-11-02T14:12:01Z","git_url":"git://github.com/ShFil119/openal-soft.git","ssh_url":"git@github.com:ShFil119/openal-soft.git","clone_url":"https://github.com/ShFil119/openal-soft.git","svn_url":"https://github.com/ShFil119/openal-soft","homepage":null,"size":10782,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kcat:master","ref":"master","sha":"aaa31d987f92f767af0d5d9633da5bab9d7862b8","user":{"login":"kcat","id":1545516,"node_id":"MDQ6VXNlcjE1NDU1MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1545516?v=4","gravatar_id":"","url":"https://api.github.com/users/kcat","html_url":"https://github.com/kcat","followers_url":"https://api.github.com/users/kcat/followers","following_url":"https://api.github.com/users/kcat/following{/other_user}","gists_url":"https://api.github.com/users/kcat/gists{/gist_id}","starred_url":"https://api.github.com/users/kcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcat/subscriptions","organizations_url":"https://api.github.com/users/kcat/orgs","repos_url":"https://api.github.com/users/kcat/repos","events_url":"https://api.github.com/users/kcat/events{/privacy}","received_events_url":"https://api.github.com/users/kcat/received_events","type":"User","site_admin":false},"repo":{"id":23277337,"node_id":"MDEwOlJlcG9zaXRvcnkyMzI3NzMzNw==","name":"openal-soft","full_name":"kcat/openal-soft","private":false,"owner":{"login":"kcat","id":1545516,"node_id":"MDQ6VXNlcjE1NDU1MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1545516?v=4","gravatar_id":"","url":"https://api.github.com/users/kcat","html_url":"https://github.com/kcat","followers_url":"https://api.github.com/users/kcat/followers","following_url":"https://api.github.com/users/kcat/following{/other_user}","gists_url":"https://api.github.com/users/kcat/gists{/gist_id}","starred_url":"https://api.github.com/users/kcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcat/subscriptions","organizations_url":"https://api.github.com/users/kcat/orgs","repos_url":"https://api.github.com/users/kcat/repos","events_url":"https://api.github.com/users/kcat/events{/privacy}","received_events_url":"https://api.github.com/users/kcat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kcat/openal-soft","description":"OpenAL Soft is a software implementation of the OpenAL 3D audio API.","fork":false,"url":"https://api.github.com/repos/kcat/openal-soft","forks_url":"https://api.github.com/repos/kcat/openal-soft/forks","keys_url":"https://api.github.com/repos/kcat/openal-soft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kcat/openal-soft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kcat/openal-soft/teams","hooks_url":"https://api.github.com/repos/kcat/openal-soft/hooks","issue_events_url":"https://api.github.com/repos/kcat/openal-soft/issues/events{/number}","events_url":"https://api.github.com/repos/kcat/openal-soft/events","assignees_url":"https://api.github.com/repos/kcat/openal-soft/assignees{/user}","branches_url":"https://api.github.com/repos/kcat/openal-soft/branches{/branch}","tags_url":"https://api.github.com/repos/kcat/openal-soft/tags","blobs_url":"https://api.github.com/repos/kcat/openal-soft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kcat/openal-soft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kcat/openal-soft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kcat/openal-soft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kcat/openal-soft/statuses/{sha}","languages_url":"https://api.github.com/repos/kcat/openal-soft/languages","stargazers_url":"https://api.github.com/repos/kcat/openal-soft/stargazers","contributors_url":"https://api.github.com/repos/kcat/openal-soft/contributors","subscribers_url":"https://api.github.com/repos/kcat/openal-soft/subscribers","subscription_url":"https://api.github.com/repos/kcat/openal-soft/subscription","commits_url":"https://api.github.com/repos/kcat/openal-soft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kcat/openal-soft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kcat/openal-soft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kcat/openal-soft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kcat/openal-soft/contents/{+path}","compare_url":"https://api.github.com/repos/kcat/openal-soft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kcat/openal-soft/merges","archive_url":"https://api.github.com/repos/kcat/openal-soft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kcat/openal-soft/downloads","issues_url":"https://api.github.com/repos/kcat/openal-soft/issues{/number}","pulls_url":"https://api.github.com/repos/kcat/openal-soft/pulls{/number}","milestones_url":"https://api.github.com/repos/kcat/openal-soft/milestones{/number}","notifications_url":"https://api.github.com/repos/kcat/openal-soft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kcat/openal-soft/labels{/name}","releases_url":"https://api.github.com/repos/kcat/openal-soft/releases{/id}","deployments_url":"https://api.github.com/repos/kcat/openal-soft/deployments","created_at":"2014-08-24T09:13:17Z","updated_at":"2018-11-02T16:44:01Z","pushed_at":"2018-11-02T16:43:58Z","git_url":"git://github.com/kcat/openal-soft.git","ssh_url":"git@github.com:kcat/openal-soft.git","clone_url":"https://github.com/kcat/openal-soft.git","svn_url":"https://github.com/kcat/openal-soft","homepage":null,"size":10921,"stargazers_count":576,"watchers_count":576,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":159,"open_issues":69,"watchers":576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/244"},"html":{"href":"https://github.com/kcat/openal-soft/pull/244"},"issue":{"href":"https://api.github.com/repos/kcat/openal-soft/issues/244"},"comments":{"href":"https://api.github.com/repos/kcat/openal-soft/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kcat/openal-soft/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/kcat/openal-soft/statuses/9e9fe0886bfe1f8771b3ba781df704e7c16816e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ShFil119"}}