{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/243377827","pull_request_review_id":187133089,"id":243377827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM3NzgyNw==","diff_hunk":"@@ -164,6 +181,55 @@ def _list_services(self, cmd):\n \n             return HandleCommandResult(odata=\"\\n\".join(lines))\n \n+    def _create_osd(self, cmd):","path":"src/pybind/mgr/orchestrator_cli/module.py","position":null,"original_position":45,"commit_id":"8edc877805bbb9d75da2ee8ffbe81662efc3a0f0","original_commit_id":"070a24ca622db8a3797da45ef492b816e0002fb0","user":{"login":"jmolmo","id":1820049,"node_id":"MDQ6VXNlcjE4MjAwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1820049?v=4","gravatar_id":"","url":"https://api.github.com/users/jmolmo","html_url":"https://github.com/jmolmo","followers_url":"https://api.github.com/users/jmolmo/followers","following_url":"https://api.github.com/users/jmolmo/following{/other_user}","gists_url":"https://api.github.com/users/jmolmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmolmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmolmo/subscriptions","organizations_url":"https://api.github.com/users/jmolmo/orgs","repos_url":"https://api.github.com/users/jmolmo/repos","events_url":"https://api.github.com/users/jmolmo/events{/privacy}","received_events_url":"https://api.github.com/users/jmolmo/received_events","type":"User","site_admin":false},"body":"I have take advantage of this modification and i have implemented the \"Drive group\" class in the Orchestrator. Now Orchestrator cli.create_osds uses a \"drive_group\" object that is passed  to the internal orchestrator module. Each internal orchestrator module process the \"drive_group\" object as required. I think that when we will have teh ceph-volume \"implementation\" probably this object will be passed directly. In any case, now we have in the orchestrator a \"drive group\" object to manage any kind of transformation/process.","created_at":"2018-12-20T18:44:30Z","updated_at":"2018-12-20T18:44:30Z","html_url":"https://github.com/ceph/ceph/pull/25497#discussion_r243377827","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25497","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/243377827"},"html":{"href":"https://github.com/ceph/ceph/pull/25497#discussion_r243377827"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25497"}},"in_reply_to_id":242565517},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25497","id":237801787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODAxNzg3","html_url":"https://github.com/ceph/ceph/pull/25497","diff_url":"https://github.com/ceph/ceph/pull/25497.diff","patch_url":"https://github.com/ceph/ceph/pull/25497.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25497","number":25497,"state":"open","locked":false,"title":"mgr/ansible: Create/Remove OSDs","user":{"login":"jmolmo","id":1820049,"node_id":"MDQ6VXNlcjE4MjAwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1820049?v=4","gravatar_id":"","url":"https://api.github.com/users/jmolmo","html_url":"https://github.com/jmolmo","followers_url":"https://api.github.com/users/jmolmo/followers","following_url":"https://api.github.com/users/jmolmo/following{/other_user}","gists_url":"https://api.github.com/users/jmolmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmolmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmolmo/subscriptions","organizations_url":"https://api.github.com/users/jmolmo/orgs","repos_url":"https://api.github.com/users/jmolmo/repos","events_url":"https://api.github.com/users/jmolmo/events{/privacy}","received_events_url":"https://api.github.com/users/jmolmo/received_events","type":"User","site_admin":false},"body":"mgr/ansible: Create/Remove OSDs\r\n\r\nNew functionality to create/remove osd's using the Ansible Orchestrator. \r\n\r\n- [ ] References tracker ticket\r\n- [x] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\nSigned-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>\r\n\r\n\r\n\r\n\r\n","created_at":"2018-12-11T19:35:03Z","updated_at":"2018-12-20T18:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f112d62f06c6f71dd636589941a6f586a4f36753","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":454906768,"node_id":"MDU6TGFiZWw0NTQ5MDY3Njg=","url":"https://api.github.com/repos/ceph/ceph/labels/mgr","name":"mgr","color":"c2e0c6","default":false},{"id":1111279478,"node_id":"MDU6TGFiZWwxMTExMjc5NDc4","url":"https://api.github.com/repos/ceph/ceph/labels/orchestrator","name":"orchestrator","color":"ff00c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25497/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25497/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25497/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/8edc877805bbb9d75da2ee8ffbe81662efc3a0f0","head":{"label":"jmolmo:wip_ansible_orchestrator","ref":"wip_ansible_orchestrator","sha":"8edc877805bbb9d75da2ee8ffbe81662efc3a0f0","user":{"login":"jmolmo","id":1820049,"node_id":"MDQ6VXNlcjE4MjAwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1820049?v=4","gravatar_id":"","url":"https://api.github.com/users/jmolmo","html_url":"https://github.com/jmolmo","followers_url":"https://api.github.com/users/jmolmo/followers","following_url":"https://api.github.com/users/jmolmo/following{/other_user}","gists_url":"https://api.github.com/users/jmolmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmolmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmolmo/subscriptions","organizations_url":"https://api.github.com/users/jmolmo/orgs","repos_url":"https://api.github.com/users/jmolmo/repos","events_url":"https://api.github.com/users/jmolmo/events{/privacy}","received_events_url":"https://api.github.com/users/jmolmo/received_events","type":"User","site_admin":false},"repo":{"id":148655030,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2NTUwMzA=","name":"ceph","full_name":"jmolmo/ceph","private":false,"owner":{"login":"jmolmo","id":1820049,"node_id":"MDQ6VXNlcjE4MjAwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1820049?v=4","gravatar_id":"","url":"https://api.github.com/users/jmolmo","html_url":"https://github.com/jmolmo","followers_url":"https://api.github.com/users/jmolmo/followers","following_url":"https://api.github.com/users/jmolmo/following{/other_user}","gists_url":"https://api.github.com/users/jmolmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jmolmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmolmo/subscriptions","organizations_url":"https://api.github.com/users/jmolmo/orgs","repos_url":"https://api.github.com/users/jmolmo/repos","events_url":"https://api.github.com/users/jmolmo/events{/privacy}","received_events_url":"https://api.github.com/users/jmolmo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmolmo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/jmolmo/ceph","forks_url":"https://api.github.com/repos/jmolmo/ceph/forks","keys_url":"https://api.github.com/repos/jmolmo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmolmo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmolmo/ceph/teams","hooks_url":"https://api.github.com/repos/jmolmo/ceph/hooks","issue_events_url":"https://api.github.com/repos/jmolmo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/jmolmo/ceph/events","assignees_url":"https://api.github.com/repos/jmolmo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/jmolmo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/jmolmo/ceph/tags","blobs_url":"https://api.github.com/repos/jmolmo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmolmo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmolmo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmolmo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmolmo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/jmolmo/ceph/languages","stargazers_url":"https://api.github.com/repos/jmolmo/ceph/stargazers","contributors_url":"https://api.github.com/repos/jmolmo/ceph/contributors","subscribers_url":"https://api.github.com/repos/jmolmo/ceph/subscribers","subscription_url":"https://api.github.com/repos/jmolmo/ceph/subscription","commits_url":"https://api.github.com/repos/jmolmo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmolmo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmolmo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmolmo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmolmo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/jmolmo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmolmo/ceph/merges","archive_url":"https://api.github.com/repos/jmolmo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmolmo/ceph/downloads","issues_url":"https://api.github.com/repos/jmolmo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/jmolmo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/jmolmo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/jmolmo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmolmo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/jmolmo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/jmolmo/ceph/deployments","created_at":"2018-09-13T15:01:48Z","updated_at":"2018-12-10T09:19:57Z","pushed_at":"2018-12-20T18:30:52Z","git_url":"git://github.com/jmolmo/ceph.git","ssh_url":"git@github.com:jmolmo/ceph.git","clone_url":"https://github.com/jmolmo/ceph.git","svn_url":"https://github.com/jmolmo/ceph","homepage":"http://ceph.com","size":333737,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"1ef61370e6d7d5824e14b34fd20bf35c063b00d7","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-12-20T15:53:02Z","pushed_at":"2018-12-20T18:40:46Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":339087,"stargazers_count":5421,"watchers_count":5421,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2846,"mirror_url":null,"archived":false,"open_issues_count":646,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2846,"open_issues":646,"watchers":5421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25497"},"html":{"href":"https://github.com/ceph/ceph/pull/25497"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25497"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25497/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25497/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25497/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/8edc877805bbb9d75da2ee8ffbe81662efc3a0f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmolmo"}}