{"action":"created","issue":{"url":"https://api.github.com/repos/http4s/http4s/issues/1676","repository_url":"https://api.github.com/repos/http4s/http4s","labels_url":"https://api.github.com/repos/http4s/http4s/issues/1676/labels{/name}","comments_url":"https://api.github.com/repos/http4s/http4s/issues/1676/comments","events_url":"https://api.github.com/repos/http4s/http4s/issues/1676/events","html_url":"https://github.com/http4s/http4s/pull/1676","id":300035707,"number":1676,"title":"WIP - Break up Cookie into Request and Response","user":{"login":"kevinmeredith","id":1967302,"avatar_url":"https://avatars3.githubusercontent.com/u/1967302?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinmeredith","html_url":"https://github.com/kevinmeredith","followers_url":"https://api.github.com/users/kevinmeredith/followers","following_url":"https://api.github.com/users/kevinmeredith/following{/other_user}","gists_url":"https://api.github.com/users/kevinmeredith/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmeredith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmeredith/subscriptions","organizations_url":"https://api.github.com/users/kevinmeredith/orgs","repos_url":"https://api.github.com/users/kevinmeredith/repos","events_url":"https://api.github.com/users/kevinmeredith/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmeredith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-25T15:38:08Z","updated_at":"2018-03-02T03:00:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/http4s/http4s/pulls/1676","html_url":"https://github.com/http4s/http4s/pull/1676","diff_url":"https://github.com/http4s/http4s/pull/1676.diff","patch_url":"https://github.com/http4s/http4s/pull/1676.patch"},"body":"This PR adds a `RequestCookie` and `ResponseCookie` per the discussion in https://gitter.im/http4s/http4s?at=5a90d82b0202dc012e79241a.\r\n\r\nI opened this PR due to the following motivation:\r\n\r\n> The only reason I ask is that, at work, I, having not used Cookie's in a real app, wrongly wrote code that checked on an HTTP Request's Cookie's cookie.isSecure && cookie.isHttpOnly. If an HTTP Request's Cookie only contained name=value pairs, then that would eliminate that type of error\r\n\r\nper https://gitter.im/http4s/http4s?at=5a90d82b0202dc012e79241a.\r\n\r\nIt uses the `abstract class` approach that @jmcardon mentioned in https://gitter.im/http4s/http4s?at=5a90d8cd0202dc012e79266d."},"comment":{"url":"https://api.github.com/repos/http4s/http4s/issues/comments/369805450","html_url":"https://github.com/http4s/http4s/pull/1676#issuecomment-369805450","issue_url":"https://api.github.com/repos/http4s/http4s/issues/1676","id":369805450,"user":{"login":"kevinmeredith","id":1967302,"avatar_url":"https://avatars3.githubusercontent.com/u/1967302?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinmeredith","html_url":"https://github.com/kevinmeredith","followers_url":"https://api.github.com/users/kevinmeredith/followers","following_url":"https://api.github.com/users/kevinmeredith/following{/other_user}","gists_url":"https://api.github.com/users/kevinmeredith/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmeredith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmeredith/subscriptions","organizations_url":"https://api.github.com/users/kevinmeredith/orgs","repos_url":"https://api.github.com/users/kevinmeredith/repos","events_url":"https://api.github.com/users/kevinmeredith/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmeredith/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T03:00:16Z","updated_at":"2018-03-02T03:00:16Z","author_association":"NONE","body":"Please excuse the `git push -f`. I almost always avoid re-basing on a PR with comments.\r\n\r\nAnyway, I was able to run `sbt \"; project tests; test` successfully on this branch."}}
{"actor":{"display_login":"kevinmeredith"}}