{"action":"created","comment":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/comments/174029024","pull_request_review_id":103310130,"id":174029024,"diff_hunk":"@@ -90,7 +90,7 @@ extension Reactive where Base: DatabaseWriter {\n     ///   its first right upon subscription.\n     /// - parameter scheduler: The scheduler on which mapFetch emits its\n     ///   elements (default is MainScheduler.instance).\n-    public func fetchTokens(\n+    public func fetchTokens<Request: FetchRequest>(","path":"RxGRDB/DatabaseWriter+Rx.swift","position":14,"original_position":14,"commit_id":"02fb9980afcbbe59fae020d8fdb60222dd30cb69","original_commit_id":"02fb9980afcbbe59fae020d8fdb60222dd30cb69","user":{"login":"groue","id":54219,"avatar_url":"https://avatars2.githubusercontent.com/u/54219?v=4","gravatar_id":"","url":"https://api.github.com/users/groue","html_url":"https://github.com/groue","followers_url":"https://api.github.com/users/groue/followers","following_url":"https://api.github.com/users/groue/following{/other_user}","gists_url":"https://api.github.com/users/groue/gists{/gist_id}","starred_url":"https://api.github.com/users/groue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groue/subscriptions","organizations_url":"https://api.github.com/users/groue/orgs","repos_url":"https://api.github.com/users/groue/repos","events_url":"https://api.github.com/users/groue/events{/privacy}","received_events_url":"https://api.github.com/users/groue/received_events","type":"User","site_admin":false},"body":"Don't we face the PAT kiss here?\r\n\r\n```swift\r\nlet players = Player.all()\r\nlet teams = Team.all()\r\ndbQueue.fetchTokens(in: [players, teams])... // I expect a compiler error\r\n```\r\n\r\nThere's room for improvement here, even if this array of observed requests will sometimes be replaced with a single joined request.","created_at":"2018-03-13T06:46:21Z","updated_at":"2018-03-13T06:52:36Z","html_url":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27#discussion_r174029024","pull_request_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/comments/174029024"},"html":{"href":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27#discussion_r174029024"},"pull_request":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27","id":174500368,"html_url":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27","diff_url":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27.diff","patch_url":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27.patch","issue_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/27","number":27,"state":"open","locked":false,"title":"Support for GRDB 3.0","user":{"login":"hartbit","id":325519,"avatar_url":"https://avatars1.githubusercontent.com/u/325519?v=4","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"body":"The tests all pass. Does this look good to you? I had to set the submodule to the latest commit of GRDB3-Associations, but I'm not sure is that how you keep repos in sync.","created_at":"2018-03-12T21:30:32Z","updated_at":"2018-03-13T06:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf1762827d457753e91a8669c8fd0e14b66d9ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27/commits","review_comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27/comments","review_comment_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/27/comments","statuses_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/statuses/02fb9980afcbbe59fae020d8fdb60222dd30cb69","head":{"label":"hartbit:GRDB3","ref":"GRDB3","sha":"02fb9980afcbbe59fae020d8fdb60222dd30cb69","user":{"login":"hartbit","id":325519,"avatar_url":"https://avatars1.githubusercontent.com/u/325519?v=4","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"repo":{"id":124948902,"name":"RxGRDB","full_name":"hartbit/RxGRDB","owner":{"login":"hartbit","id":325519,"avatar_url":"https://avatars1.githubusercontent.com/u/325519?v=4","gravatar_id":"","url":"https://api.github.com/users/hartbit","html_url":"https://github.com/hartbit","followers_url":"https://api.github.com/users/hartbit/followers","following_url":"https://api.github.com/users/hartbit/following{/other_user}","gists_url":"https://api.github.com/users/hartbit/gists{/gist_id}","starred_url":"https://api.github.com/users/hartbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartbit/subscriptions","organizations_url":"https://api.github.com/users/hartbit/orgs","repos_url":"https://api.github.com/users/hartbit/repos","events_url":"https://api.github.com/users/hartbit/events{/privacy}","received_events_url":"https://api.github.com/users/hartbit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hartbit/RxGRDB","description":"Reactive extensions for SQLite","fork":true,"url":"https://api.github.com/repos/hartbit/RxGRDB","forks_url":"https://api.github.com/repos/hartbit/RxGRDB/forks","keys_url":"https://api.github.com/repos/hartbit/RxGRDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hartbit/RxGRDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hartbit/RxGRDB/teams","hooks_url":"https://api.github.com/repos/hartbit/RxGRDB/hooks","issue_events_url":"https://api.github.com/repos/hartbit/RxGRDB/issues/events{/number}","events_url":"https://api.github.com/repos/hartbit/RxGRDB/events","assignees_url":"https://api.github.com/repos/hartbit/RxGRDB/assignees{/user}","branches_url":"https://api.github.com/repos/hartbit/RxGRDB/branches{/branch}","tags_url":"https://api.github.com/repos/hartbit/RxGRDB/tags","blobs_url":"https://api.github.com/repos/hartbit/RxGRDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hartbit/RxGRDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hartbit/RxGRDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/hartbit/RxGRDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hartbit/RxGRDB/statuses/{sha}","languages_url":"https://api.github.com/repos/hartbit/RxGRDB/languages","stargazers_url":"https://api.github.com/repos/hartbit/RxGRDB/stargazers","contributors_url":"https://api.github.com/repos/hartbit/RxGRDB/contributors","subscribers_url":"https://api.github.com/repos/hartbit/RxGRDB/subscribers","subscription_url":"https://api.github.com/repos/hartbit/RxGRDB/subscription","commits_url":"https://api.github.com/repos/hartbit/RxGRDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/hartbit/RxGRDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/hartbit/RxGRDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/hartbit/RxGRDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/hartbit/RxGRDB/contents/{+path}","compare_url":"https://api.github.com/repos/hartbit/RxGRDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hartbit/RxGRDB/merges","archive_url":"https://api.github.com/repos/hartbit/RxGRDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hartbit/RxGRDB/downloads","issues_url":"https://api.github.com/repos/hartbit/RxGRDB/issues{/number}","pulls_url":"https://api.github.com/repos/hartbit/RxGRDB/pulls{/number}","milestones_url":"https://api.github.com/repos/hartbit/RxGRDB/milestones{/number}","notifications_url":"https://api.github.com/repos/hartbit/RxGRDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hartbit/RxGRDB/labels{/name}","releases_url":"https://api.github.com/repos/hartbit/RxGRDB/releases{/id}","deployments_url":"https://api.github.com/repos/hartbit/RxGRDB/deployments","created_at":"2018-03-12T20:41:42Z","updated_at":"2018-03-12T20:41:44Z","pushed_at":"2018-03-12T21:29:07Z","git_url":"git://github.com/hartbit/RxGRDB.git","ssh_url":"git@github.com:hartbit/RxGRDB.git","clone_url":"https://github.com/hartbit/RxGRDB.git","svn_url":"https://github.com/hartbit/RxGRDB","homepage":"","size":2133,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RxSwiftCommunity:master","ref":"master","sha":"c93ecd2100c2d9952592e22e1b46e63971ac1616","user":{"login":"RxSwiftCommunity","id":15903991,"avatar_url":"https://avatars3.githubusercontent.com/u/15903991?v=4","gravatar_id":"","url":"https://api.github.com/users/RxSwiftCommunity","html_url":"https://github.com/RxSwiftCommunity","followers_url":"https://api.github.com/users/RxSwiftCommunity/followers","following_url":"https://api.github.com/users/RxSwiftCommunity/following{/other_user}","gists_url":"https://api.github.com/users/RxSwiftCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/RxSwiftCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxSwiftCommunity/subscriptions","organizations_url":"https://api.github.com/users/RxSwiftCommunity/orgs","repos_url":"https://api.github.com/users/RxSwiftCommunity/repos","events_url":"https://api.github.com/users/RxSwiftCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/RxSwiftCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":87106676,"name":"RxGRDB","full_name":"RxSwiftCommunity/RxGRDB","owner":{"login":"RxSwiftCommunity","id":15903991,"avatar_url":"https://avatars3.githubusercontent.com/u/15903991?v=4","gravatar_id":"","url":"https://api.github.com/users/RxSwiftCommunity","html_url":"https://github.com/RxSwiftCommunity","followers_url":"https://api.github.com/users/RxSwiftCommunity/followers","following_url":"https://api.github.com/users/RxSwiftCommunity/following{/other_user}","gists_url":"https://api.github.com/users/RxSwiftCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/RxSwiftCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxSwiftCommunity/subscriptions","organizations_url":"https://api.github.com/users/RxSwiftCommunity/orgs","repos_url":"https://api.github.com/users/RxSwiftCommunity/repos","events_url":"https://api.github.com/users/RxSwiftCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/RxSwiftCommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RxSwiftCommunity/RxGRDB","description":"Reactive extensions for SQLite","fork":false,"url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB","forks_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/forks","keys_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/teams","hooks_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/hooks","issue_events_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/events{/number}","events_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/events","assignees_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/assignees{/user}","branches_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/branches{/branch}","tags_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/tags","blobs_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/statuses/{sha}","languages_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/languages","stargazers_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/stargazers","contributors_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/contributors","subscribers_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/subscribers","subscription_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/subscription","commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/contents/{+path}","compare_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/merges","archive_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/downloads","issues_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues{/number}","pulls_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls{/number}","milestones_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/milestones{/number}","notifications_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/labels{/name}","releases_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/releases{/id}","deployments_url":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/deployments","created_at":"2017-04-03T18:24:45Z","updated_at":"2018-03-12T08:53:02Z","pushed_at":"2018-03-12T21:30:33Z","git_url":"git://github.com/RxSwiftCommunity/RxGRDB.git","ssh_url":"git@github.com:RxSwiftCommunity/RxGRDB.git","clone_url":"https://github.com/RxSwiftCommunity/RxGRDB.git","svn_url":"https://github.com/RxSwiftCommunity/RxGRDB","homepage":"","size":2125,"stargazers_count":57,"watchers_count":57,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7,"open_issues":2,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27"},"html":{"href":"https://github.com/RxSwiftCommunity/RxGRDB/pull/27"},"issue":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/27"},"comments":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/RxSwiftCommunity/RxGRDB/statuses/02fb9980afcbbe59fae020d8fdb60222dd30cb69"}},"author_association":"NONE"}}
{"actor":{"display_login":"groue"}}