{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/200744081","pull_request_review_id":135123555,"id":200744081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDc0NDA4MQ==","diff_hunk":"@@ -47,18 +47,18 @@ use rustc::ty::TyCtxt;\n use std::io::{self, Write};\n use transform::MirSource;\n \n-pub type LocalSet = IdxSetBuf<Local>;\n+pub type LocalSet<V: Idx> = IdxSetBuf<V>;\n \n /// This gives the result of the liveness analysis at the boundary of\n /// basic blocks. You can use `simulate_block` to obtain the\n /// intra-block results.\n-pub struct LivenessResult {\n+pub struct LivenessResult<V: Idx> {","path":"src/librustc_mir/util/liveness.rs","position":11,"original_position":11,"commit_id":"9f43363f6a5a3270a3ed78ed510fef1f32c7b8cf","original_commit_id":"9f43363f6a5a3270a3ed78ed510fef1f32c7b8cf","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"We should probably add some kind of trait like `LiveVariableMap`, which would look kind of like so:\r\n\r\n```rust\r\ntrait LiveVariableMap {\r\n    type LiveVar;\r\n\r\n    fn from_local(&self, local: Local) -> Option<Self::LiveVar>;\r\n    fn from_live_var(&self, local: Self::LiveVar) -> Local;\r\n}\r\n```\r\n\r\nWe would also make an \"identity map\" type that we use for now:\r\n\r\n```rust\r\nstruct IdentityMap;\r\n\r\nimpl LiveVariableMap for IdentityMap {\r\n    type LiveVar = Local;\r\n\r\n    fn from_local(&self, local: Local) -> Option<Local> {\r\n        Some(local)\r\n    }\r\n\r\n    fn from_live_var(&self, local: Self::LiveVar) -> Local {\r\n        local\r\n    }\r\n}\r\n```","created_at":"2018-07-06T19:05:37Z","updated_at":"2018-07-06T19:12:58Z","html_url":"https://github.com/rust-lang/rust/pull/52115#discussion_r200744081","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/52115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/200744081"},"html":{"href":"https://github.com/rust-lang/rust/pull/52115#discussion_r200744081"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52115"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/52115","id":199802222,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODAyMjIy","html_url":"https://github.com/rust-lang/rust/pull/52115","diff_url":"https://github.com/rust-lang/rust/pull/52115.diff","patch_url":"https://github.com/rust-lang/rust/pull/52115.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/52115","number":52115,"state":"open","locked":false,"title":"[WIP]  only compute liveness for variables whose types include regions","user":{"login":"Dylan-DPC","id":12371125,"node_id":"MDQ6VXNlcjEyMzcxMTI1","avatar_url":"https://avatars1.githubusercontent.com/u/12371125?v=4","gravatar_id":"","url":"https://api.github.com/users/Dylan-DPC","html_url":"https://github.com/Dylan-DPC","followers_url":"https://api.github.com/users/Dylan-DPC/followers","following_url":"https://api.github.com/users/Dylan-DPC/following{/other_user}","gists_url":"https://api.github.com/users/Dylan-DPC/gists{/gist_id}","starred_url":"https://api.github.com/users/Dylan-DPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dylan-DPC/subscriptions","organizations_url":"https://api.github.com/users/Dylan-DPC/orgs","repos_url":"https://api.github.com/users/Dylan-DPC/repos","events_url":"https://api.github.com/users/Dylan-DPC/events{/privacy}","received_events_url":"https://api.github.com/users/Dylan-DPC/received_events","type":"User","site_admin":false},"body":"Closes #52034 \r\n\r\nr? @nikomatsakis ","created_at":"2018-07-06T17:09:57Z","updated_at":"2018-07-06T19:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2cab42fdf84e8ae3be5db01336d59024cc5fe85","assignee":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/52115/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/52115/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/52115/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/9f43363f6a5a3270a3ed78ed510fef1f32c7b8cf","head":{"label":"Dylan-DPC:feature/nll-liveness-regions","ref":"feature/nll-liveness-regions","sha":"9f43363f6a5a3270a3ed78ed510fef1f32c7b8cf","user":{"login":"Dylan-DPC","id":12371125,"node_id":"MDQ6VXNlcjEyMzcxMTI1","avatar_url":"https://avatars1.githubusercontent.com/u/12371125?v=4","gravatar_id":"","url":"https://api.github.com/users/Dylan-DPC","html_url":"https://github.com/Dylan-DPC","followers_url":"https://api.github.com/users/Dylan-DPC/followers","following_url":"https://api.github.com/users/Dylan-DPC/following{/other_user}","gists_url":"https://api.github.com/users/Dylan-DPC/gists{/gist_id}","starred_url":"https://api.github.com/users/Dylan-DPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dylan-DPC/subscriptions","organizations_url":"https://api.github.com/users/Dylan-DPC/orgs","repos_url":"https://api.github.com/users/Dylan-DPC/repos","events_url":"https://api.github.com/users/Dylan-DPC/events{/privacy}","received_events_url":"https://api.github.com/users/Dylan-DPC/received_events","type":"User","site_admin":false},"repo":{"id":111899631,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4OTk2MzE=","name":"rust","full_name":"Dylan-DPC/rust","owner":{"login":"Dylan-DPC","id":12371125,"node_id":"MDQ6VXNlcjEyMzcxMTI1","avatar_url":"https://avatars1.githubusercontent.com/u/12371125?v=4","gravatar_id":"","url":"https://api.github.com/users/Dylan-DPC","html_url":"https://github.com/Dylan-DPC","followers_url":"https://api.github.com/users/Dylan-DPC/followers","following_url":"https://api.github.com/users/Dylan-DPC/following{/other_user}","gists_url":"https://api.github.com/users/Dylan-DPC/gists{/gist_id}","starred_url":"https://api.github.com/users/Dylan-DPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dylan-DPC/subscriptions","organizations_url":"https://api.github.com/users/Dylan-DPC/orgs","repos_url":"https://api.github.com/users/Dylan-DPC/repos","events_url":"https://api.github.com/users/Dylan-DPC/events{/privacy}","received_events_url":"https://api.github.com/users/Dylan-DPC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dylan-DPC/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Dylan-DPC/rust","forks_url":"https://api.github.com/repos/Dylan-DPC/rust/forks","keys_url":"https://api.github.com/repos/Dylan-DPC/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dylan-DPC/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dylan-DPC/rust/teams","hooks_url":"https://api.github.com/repos/Dylan-DPC/rust/hooks","issue_events_url":"https://api.github.com/repos/Dylan-DPC/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Dylan-DPC/rust/events","assignees_url":"https://api.github.com/repos/Dylan-DPC/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Dylan-DPC/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Dylan-DPC/rust/tags","blobs_url":"https://api.github.com/repos/Dylan-DPC/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dylan-DPC/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dylan-DPC/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dylan-DPC/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dylan-DPC/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Dylan-DPC/rust/languages","stargazers_url":"https://api.github.com/repos/Dylan-DPC/rust/stargazers","contributors_url":"https://api.github.com/repos/Dylan-DPC/rust/contributors","subscribers_url":"https://api.github.com/repos/Dylan-DPC/rust/subscribers","subscription_url":"https://api.github.com/repos/Dylan-DPC/rust/subscription","commits_url":"https://api.github.com/repos/Dylan-DPC/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dylan-DPC/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dylan-DPC/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dylan-DPC/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dylan-DPC/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Dylan-DPC/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dylan-DPC/rust/merges","archive_url":"https://api.github.com/repos/Dylan-DPC/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dylan-DPC/rust/downloads","issues_url":"https://api.github.com/repos/Dylan-DPC/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Dylan-DPC/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Dylan-DPC/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Dylan-DPC/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dylan-DPC/rust/labels{/name}","releases_url":"https://api.github.com/repos/Dylan-DPC/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Dylan-DPC/rust/deployments","created_at":"2017-11-24T09:22:40Z","updated_at":"2017-11-24T09:23:06Z","pushed_at":"2018-07-06T15:54:28Z","git_url":"git://github.com/Dylan-DPC/rust.git","ssh_url":"git@github.com:Dylan-DPC/rust.git","clone_url":"https://github.com/Dylan-DPC/rust.git","svn_url":"https://github.com/Dylan-DPC/rust","homepage":"https://www.rust-lang.org","size":377130,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"50302821c4f63f487783762c1b45b412c2574334","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-07-06T19:08:50Z","pushed_at":"2018-07-06T18:03:52Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":378051,"stargazers_count":29172,"watchers_count":29172,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5039,"mirror_url":null,"archived":false,"open_issues_count":3937,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5039,"open_issues":3937,"watchers":29172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52115"},"html":{"href":"https://github.com/rust-lang/rust/pull/52115"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/52115"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/52115/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52115/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/52115/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/9f43363f6a5a3270a3ed78ed510fef1f32c7b8cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nikomatsakis"}}