{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/12397","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/12397/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12397/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/12397/events","html_url":"https://github.com/highfidelity/hifi/pull/12397","id":297202166,"number":12397,"title":"Bug fix/entity mat avatar dual quaternions","user":{"login":"hyperlogic","id":20499,"avatar_url":"https://avatars2.githubusercontent.com/u/20499?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperlogic","html_url":"https://github.com/hyperlogic","followers_url":"https://api.github.com/users/hyperlogic/followers","following_url":"https://api.github.com/users/hyperlogic/following{/other_user}","gists_url":"https://api.github.com/users/hyperlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperlogic/subscriptions","organizations_url":"https://api.github.com/users/hyperlogic/orgs","repos_url":"https://api.github.com/users/hyperlogic/repos","events_url":"https://api.github.com/users/hyperlogic/events{/privacy}","received_events_url":"https://api.github.com/users/hyperlogic/received_events","type":"User","site_admin":false},"labels":[{"id":837498945,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Avatar","name":"Avatar","color":"fcc4dc","default":false},{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/19","html_url":"https://github.com/highfidelity/hifi/milestone/19","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/19/labels","id":3082013,"number":19,"title":"RC65","description":"","creator":{"login":"divyaelango88","id":30877259,"avatar_url":"https://avatars3.githubusercontent.com/u/30877259?v=4","gravatar_id":"","url":"https://api.github.com/users/divyaelango88","html_url":"https://github.com/divyaelango88","followers_url":"https://api.github.com/users/divyaelango88/followers","following_url":"https://api.github.com/users/divyaelango88/following{/other_user}","gists_url":"https://api.github.com/users/divyaelango88/gists{/gist_id}","starred_url":"https://api.github.com/users/divyaelango88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyaelango88/subscriptions","organizations_url":"https://api.github.com/users/divyaelango88/orgs","repos_url":"https://api.github.com/users/divyaelango88/repos","events_url":"https://api.github.com/users/divyaelango88/events{/privacy}","received_events_url":"https://api.github.com/users/divyaelango88/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":24,"state":"open","created_at":"2018-02-01T20:03:01Z","updated_at":"2018-02-14T22:27:14Z","due_on":"2018-02-19T08:00:00Z","closed_at":null},"comments":6,"created_at":"2018-02-14T18:40:07Z","updated_at":"2018-02-14T22:40:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12397","html_url":"https://github.com/highfidelity/hifi/pull/12397","diff_url":"https://github.com/highfidelity/hifi/pull/12397.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12397.patch"},"body":"In order to fix the non-uniform scaling issue for model entities with complex skeleton hierarchies.  We non longer use dual quaternion skinning for model entities and instead revert back to matrix palette skinning.  Avatars can continue to use the higher quality dual quaternion skinning because they can never non-uniformly scaled.\r\n\r\n* Removed SKIN_DQ preprocessor define for switching between dual quat and matrix skinning.\r\n* Added a DUAL_QUAT_SKINNING flag to Shape key flags.\r\n* Split model vertex shaders into matrix and dual quat versions.\r\n* Build an additional 12 gl programs/pipelines to include matrix and dq versions of each flavor of model rendering.\r\n* Added a _useDualQuaternionSkinning flag to model.  This flag is not dynamic, but can be used to determine which kind of skinning the model will use at construction time.  By default this value is false.\r\n* Only SkeletonModel derived classes set _useDualQuaternionSkinning to true.  Which means only Avatars will use dual quaternion skinning pipelines for rendering.\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/365769040","html_url":"https://github.com/highfidelity/hifi/pull/12397#issuecomment-365769040","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12397","id":365769040,"user":{"login":"sbennett77","id":35040612,"avatar_url":"https://avatars1.githubusercontent.com/u/35040612?v=4","gravatar_id":"","url":"https://api.github.com/users/sbennett77","html_url":"https://github.com/sbennett77","followers_url":"https://api.github.com/users/sbennett77/followers","following_url":"https://api.github.com/users/sbennett77/following{/other_user}","gists_url":"https://api.github.com/users/sbennett77/gists{/gist_id}","starred_url":"https://api.github.com/users/sbennett77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbennett77/subscriptions","organizations_url":"https://api.github.com/users/sbennett77/orgs","repos_url":"https://api.github.com/users/sbennett77/repos","events_url":"https://api.github.com/users/sbennett77/events{/privacy}","received_events_url":"https://api.github.com/users/sbennett77/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T22:40:27Z","updated_at":"2018-02-14T22:40:27Z","author_association":"NONE","body":"Passed\r\n\r\n@conklin94122 "}}
{"actor":{"display_login":"sbennett77"}}