{"action":"created","comment":{"url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/comments/225520382","pull_request_review_id":165135014,"id":225520382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTUyMDM4Mg==","diff_hunk":"@@ -75,6 +75,30 @@ This function can also be used in hiera files, for example to set class paramete\n some_class::password: \"%{lookup('important-secret')}\"\n ```\n \n+You can use a fact to specify different vaults for different groups of nodes, for example:\n+\n+```yaml\n+- name: 'Azure Key Vault Secrets per environment'\n+    lookup_key: azure_key_vault::lookup\n+    options:\n+      vault_name: \"%{facts.environment}-vault\"\n+      vault_api_version: '2016-10-01'\n+      metadata_api_version: '2018-02-01'\n+```\n+\n+For extra security consider including the name of the vault as an\n+[extension in the certificate request](https://puppet.com/docs/puppet/latest/ssl_attributes_extensions.html)\n+so it cannot be changed:\n+\n+```yaml\n+- name: 'Azure Key Vault Secrets from trusted fact'","path":"README.md","position":68,"original_position":20,"commit_id":"223e1fddba5c8e2f39a7f7ede24732a23aed38a8","original_commit_id":"223e1fddba5c8e2f39a7f7ede24732a23aed38a8","user":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"body":"Either get rid of this example OR leave it saying this is another way you could ensure nodes use the appropriate vault for secrets.","created_at":"2018-10-16T12:39:53Z","updated_at":"2018-10-16T12:41:25Z","html_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13#discussion_r225520382","pull_request_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/comments/225520382"},"html":{"href":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13#discussion_r225520382"},"pull_request":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13","id":219730354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzMwMzU0","html_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13","diff_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13.diff","patch_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13.patch","issue_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/13","number":13,"state":"open","locked":false,"title":"Add a Hiera backend","user":{"login":"hbuckle","id":18499079,"node_id":"MDQ6VXNlcjE4NDk5MDc5","avatar_url":"https://avatars1.githubusercontent.com/u/18499079?v=4","gravatar_id":"","url":"https://api.github.com/users/hbuckle","html_url":"https://github.com/hbuckle","followers_url":"https://api.github.com/users/hbuckle/followers","following_url":"https://api.github.com/users/hbuckle/following{/other_user}","gists_url":"https://api.github.com/users/hbuckle/gists{/gist_id}","starred_url":"https://api.github.com/users/hbuckle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbuckle/subscriptions","organizations_url":"https://api.github.com/users/hbuckle/orgs","repos_url":"https://api.github.com/users/hbuckle/repos","events_url":"https://api.github.com/users/hbuckle/events{/privacy}","received_events_url":"https://api.github.com/users/hbuckle/received_events","type":"User","site_admin":false},"body":"Firstly, thanks for your work on this module! This PR adds a lookup function so that secrets can also be looked up from Hiera","created_at":"2018-10-02T14:44:12Z","updated_at":"2018-10-16T12:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0040c5eab315ca54427ca2f578927cee41e97e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13/commits","review_comments_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13/comments","review_comment_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/13/comments","statuses_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/statuses/223e1fddba5c8e2f39a7f7ede24732a23aed38a8","head":{"label":"hiscox:hiera","ref":"hiera","sha":"223e1fddba5c8e2f39a7f7ede24732a23aed38a8","user":{"login":"hiscox","id":31988696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTg4Njk2","avatar_url":"https://avatars1.githubusercontent.com/u/31988696?v=4","gravatar_id":"","url":"https://api.github.com/users/hiscox","html_url":"https://github.com/hiscox","followers_url":"https://api.github.com/users/hiscox/followers","following_url":"https://api.github.com/users/hiscox/following{/other_user}","gists_url":"https://api.github.com/users/hiscox/gists{/gist_id}","starred_url":"https://api.github.com/users/hiscox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiscox/subscriptions","organizations_url":"https://api.github.com/users/hiscox/orgs","repos_url":"https://api.github.com/users/hiscox/repos","events_url":"https://api.github.com/users/hiscox/events{/privacy}","received_events_url":"https://api.github.com/users/hiscox/received_events","type":"Organization","site_admin":false},"repo":{"id":151062849,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwNjI4NDk=","name":"tragiccode-azure_key_vault","full_name":"hiscox/tragiccode-azure_key_vault","private":false,"owner":{"login":"hiscox","id":31988696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTg4Njk2","avatar_url":"https://avatars1.githubusercontent.com/u/31988696?v=4","gravatar_id":"","url":"https://api.github.com/users/hiscox","html_url":"https://github.com/hiscox","followers_url":"https://api.github.com/users/hiscox/followers","following_url":"https://api.github.com/users/hiscox/following{/other_user}","gists_url":"https://api.github.com/users/hiscox/gists{/gist_id}","starred_url":"https://api.github.com/users/hiscox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiscox/subscriptions","organizations_url":"https://api.github.com/users/hiscox/orgs","repos_url":"https://api.github.com/users/hiscox/repos","events_url":"https://api.github.com/users/hiscox/events{/privacy}","received_events_url":"https://api.github.com/users/hiscox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hiscox/tragiccode-azure_key_vault","description":"Pull secrets from Azure's key vault with this puppet module.","fork":true,"url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault","forks_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/forks","keys_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/teams","hooks_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/hooks","issue_events_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/issues/events{/number}","events_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/events","assignees_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/assignees{/user}","branches_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/branches{/branch}","tags_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/tags","blobs_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/languages","stargazers_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/stargazers","contributors_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/contributors","subscribers_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/subscribers","subscription_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/subscription","commits_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/contents/{+path}","compare_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/merges","archive_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/downloads","issues_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/issues{/number}","pulls_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/labels{/name}","releases_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/releases{/id}","deployments_url":"https://api.github.com/repos/hiscox/tragiccode-azure_key_vault/deployments","created_at":"2018-10-01T09:14:24Z","updated_at":"2018-10-01T09:14:26Z","pushed_at":"2018-10-15T15:44:32Z","git_url":"git://github.com/hiscox/tragiccode-azure_key_vault.git","ssh_url":"git@github.com:hiscox/tragiccode-azure_key_vault.git","clone_url":"https://github.com/hiscox/tragiccode-azure_key_vault.git","svn_url":"https://github.com/hiscox/tragiccode-azure_key_vault","homepage":"","size":60,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TraGicCode:master","ref":"master","sha":"e5de8288294e776a7c0d93564e890c0fe756abaa","user":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"repo":{"id":132260746,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyNjA3NDY=","name":"tragiccode-azure_key_vault","full_name":"TraGicCode/tragiccode-azure_key_vault","private":false,"owner":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault","description":"Pull secrets from Azure's key vault with this puppet module.","fork":false,"url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault","forks_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/forks","keys_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/teams","hooks_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/hooks","issue_events_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/events{/number}","events_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/events","assignees_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/assignees{/user}","branches_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/branches{/branch}","tags_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/tags","blobs_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/languages","stargazers_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/stargazers","contributors_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/contributors","subscribers_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/subscribers","subscription_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/subscription","commits_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/contents/{+path}","compare_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/merges","archive_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/downloads","issues_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues{/number}","pulls_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/labels{/name}","releases_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/releases{/id}","deployments_url":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/deployments","created_at":"2018-05-05T15:33:34Z","updated_at":"2018-10-11T14:48:26Z","pushed_at":"2018-10-15T15:44:34Z","git_url":"git://github.com/TraGicCode/tragiccode-azure_key_vault.git","ssh_url":"git@github.com:TraGicCode/tragiccode-azure_key_vault.git","clone_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault.git","svn_url":"https://github.com/TraGicCode/tragiccode-azure_key_vault","homepage":"","size":40,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13"},"html":{"href":"https://github.com/TraGicCode/tragiccode-azure_key_vault/pull/13"},"issue":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/13"},"comments":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/TraGicCode/tragiccode-azure_key_vault/statuses/223e1fddba5c8e2f39a7f7ede24732a23aed38a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"TraGicCode"}}