{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21436","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21436/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21436/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21436/events","html_url":"https://github.com/tensorflow/tensorflow/pull/21436","id":348245776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjM5MjQ3","number":21436,"title":"modify _TopKGrad so that all operations can run on GPU for better performance","user":{"login":"carusyte","id":1680881,"node_id":"MDQ6VXNlcjE2ODA4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1680881?v=4","gravatar_id":"","url":"https://api.github.com/users/carusyte","html_url":"https://github.com/carusyte","followers_url":"https://api.github.com/users/carusyte/followers","following_url":"https://api.github.com/users/carusyte/following{/other_user}","gists_url":"https://api.github.com/users/carusyte/gists{/gist_id}","starred_url":"https://api.github.com/users/carusyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusyte/subscriptions","organizations_url":"https://api.github.com/users/carusyte/orgs","repos_url":"https://api.github.com/users/carusyte/repos","events_url":"https://api.github.com/users/carusyte/events{/privacy}","received_events_url":"https://api.github.com/users/carusyte/received_events","type":"User","site_admin":false},"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false},"assignees":[{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-07T09:44:23Z","updated_at":"2018-08-12T15:57:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21436","html_url":"https://github.com/tensorflow/tensorflow/pull/21436","diff_url":"https://github.com/tensorflow/tensorflow/pull/21436.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/21436.patch"},"body":"This PR is intended to be a workaround to address #5719 by working on the Python client code level.\r\nRecap:\r\n1. Upcasting tensor to int64 type before sending to `array_ops.gather`, due to #5445;\r\n2. Replace `sparse_ops.sparse_to_dense` with `array_ops.scatter_nd`, due to #8321;"},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/412352230","html_url":"https://github.com/tensorflow/tensorflow/pull/21436#issuecomment-412352230","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21436","id":412352230,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjM1MjIzMA==","user":{"login":"ebrevdo","id":1794715,"node_id":"MDQ6VXNlcjE3OTQ3MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1794715?v=4","gravatar_id":"","url":"https://api.github.com/users/ebrevdo","html_url":"https://github.com/ebrevdo","followers_url":"https://api.github.com/users/ebrevdo/followers","following_url":"https://api.github.com/users/ebrevdo/following{/other_user}","gists_url":"https://api.github.com/users/ebrevdo/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrevdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrevdo/subscriptions","organizations_url":"https://api.github.com/users/ebrevdo/orgs","repos_url":"https://api.github.com/users/ebrevdo/repos","events_url":"https://api.github.com/users/ebrevdo/events{/privacy}","received_events_url":"https://api.github.com/users/ebrevdo/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T15:57:16Z","updated_at":"2018-08-12T15:57:16Z","author_association":"CONTRIBUTOR","body":"That's unrelated to you, feel free to ignore\n\nOn Sat, Aug 11, 2018, 9:31 PM Jonathan Zhang <notifications@github.com>\nwrote:\n\n> the test target points to\n> //tensorflow/contrib/data/python/kernel_tests/serialization:optimize_dataset_serialization_test\n>\n> full error log: link\n> <https://source.cloud.google.com/results/invocations/80e91e52-4e14-46ca-bef4-aac835bf4508/targets/%2F%2Ftensorflow%2Fcontrib%2Fdata%2Fpython%2Fkernel_tests%2Fserialization:optimize_dataset_serialization_test/log>\n>\n> Doesn't look related. Was it during running a topk test?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tensorflow/tensorflow/pull/21436#issuecomment-412317984>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABtim9hgpoDzIrn_CqGIc2Aa-EV3uRgoks5uP6-OgaJpZM4Vx1IE>\n> .\n>\n"}}
{"actor":{"display_login":"ebrevdo"}}