{"action":"created","comment":{"url":"https://api.github.com/repos/developit/microbundle/pulls/comments/239030622","pull_request_review_id":181712134,"id":239030622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAzMDYyMg==","diff_hunk":"@@ -377,26 +376,46 @@ function createConfig(options, entry, format, writeMeta) {\n \t\t\t\t\t\t\t},\n \t\t\t\t\t\t}),\n \t\t\t\t\t!useTypescript && flow({ all: true, pretty: true }),\n-\t\t\t\t\t// Only used for async await\n-\t\t\t\t\tbabel({\n-\t\t\t\t\t\t// We mainly use bublé to transpile JS and only use babel to\n-\t\t\t\t\t\t// transpile down `async/await`. To prevent conflicts with user\n-\t\t\t\t\t\t// supplied configurations we set this option to false. Note\n-\t\t\t\t\t\t// that we never supported using custom babel configs anyway.\n-\t\t\t\t\t\tbabelrc: false,\n-\t\t\t\t\t\texclude: 'node_modules/**',\n-\t\t\t\t\t\tplugins: [\n-\t\t\t\t\t\t\trequire.resolve('@babel/plugin-syntax-jsx'),\n-\t\t\t\t\t\t\t[\n-\t\t\t\t\t\t\t\trequire.resolve('babel-plugin-transform-async-to-promises'),\n-\t\t\t\t\t\t\t\t{ inlineHelpers: true, externalHelpers: true },\n-\t\t\t\t\t\t\t],\n-\t\t\t\t\t\t\t[\n-\t\t\t\t\t\t\t\trequire.resolve('@babel/plugin-proposal-class-properties'),\n-\t\t\t\t\t\t\t\t{ loose: true },\n-\t\t\t\t\t\t\t],\n-\t\t\t\t\t\t],\n-\t\t\t\t\t}),\n+\t\t\t\t\tbabel(\n+\t\t\t\t\t\t(await isFile('.babelrc')) || (await isFile('.babelrc.js'))","path":"src/index.js","position":51,"original_position":51,"commit_id":"90fab42f60691bea813eca0177773153bfee7640","original_commit_id":"90fab42f60691bea813eca0177773153bfee7640","user":{"login":"marvinhagemeister","id":1062408,"node_id":"MDQ6VXNlcjEwNjI0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1062408?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinhagemeister","html_url":"https://github.com/marvinhagemeister","followers_url":"https://api.github.com/users/marvinhagemeister/followers","following_url":"https://api.github.com/users/marvinhagemeister/following{/other_user}","gists_url":"https://api.github.com/users/marvinhagemeister/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinhagemeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinhagemeister/subscriptions","organizations_url":"https://api.github.com/users/marvinhagemeister/orgs","repos_url":"https://api.github.com/users/marvinhagemeister/repos","events_url":"https://api.github.com/users/marvinhagemeister/events{/privacy}","received_events_url":"https://api.github.com/users/marvinhagemeister/received_events","type":"User","site_admin":false},"body":"ohh I like that idea of a dedicated `microbundle` preset 👍 ","created_at":"2018-12-05T11:35:48Z","updated_at":"2018-12-05T11:35:49Z","html_url":"https://github.com/developit/microbundle/pull/263#discussion_r239030622","pull_request_url":"https://api.github.com/repos/developit/microbundle/pulls/263","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/developit/microbundle/pulls/comments/239030622"},"html":{"href":"https://github.com/developit/microbundle/pull/263#discussion_r239030622"},"pull_request":{"href":"https://api.github.com/repos/developit/microbundle/pulls/263"}},"in_reply_to_id":238966797},"pull_request":{"url":"https://api.github.com/repos/developit/microbundle/pulls/263","id":235949332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTQ5MzMy","html_url":"https://github.com/developit/microbundle/pull/263","diff_url":"https://github.com/developit/microbundle/pull/263.diff","patch_url":"https://github.com/developit/microbundle/pull/263.patch","issue_url":"https://api.github.com/repos/developit/microbundle/issues/263","number":263,"state":"open","locked":false,"title":"Replace bublé with babel","user":{"login":"esphen","id":5845924,"node_id":"MDQ6VXNlcjU4NDU5MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5845924?v=4","gravatar_id":"","url":"https://api.github.com/users/esphen","html_url":"https://github.com/esphen","followers_url":"https://api.github.com/users/esphen/followers","following_url":"https://api.github.com/users/esphen/following{/other_user}","gists_url":"https://api.github.com/users/esphen/gists{/gist_id}","starred_url":"https://api.github.com/users/esphen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esphen/subscriptions","organizations_url":"https://api.github.com/users/esphen/orgs","repos_url":"https://api.github.com/users/esphen/repos","events_url":"https://api.github.com/users/esphen/events{/privacy}","received_events_url":"https://api.github.com/users/esphen/received_events","type":"User","site_admin":false},"body":"Hello 👋\r\n\r\nFirst of all - thank you so much for this project, it makes following best practices when packaging libraries for npm really easy!\r\n\r\nI saw the PR at #39 and thought I should help out by merging in the latest code from master and getting it up to date. However, a lot seems to have changed since #39 was created, so it was actually a lot easier to start from scratch. So that's what I did, and in this branch it now works with babel 7.\r\n\r\nReading [the discussion in #39](https://github.com/developit/microbundle/pull/39/files#r160703934), I interpreted @developit's comment as intent to replace bublé with babel, so that's what this PR does.\r\n\r\n> as long as we can get a default babel config that is as optimized as Bublé, we can just default to Babel\r\n\r\nThe generated configuration uses a default babel config consisting of preset-env and preset-react, alongside the existing plugins for async/await support. If a babel config file is detected, it uses a clean slate. I hope this is a sensible starting point; free to suggest changes or improvements.\r\n\r\nI kept the custom shebang plugin even though it references bublé because the build fails without it.\r\n\r\nThe tests are currently failing due to increased output sizes. I wanted to get some feedback before I update the snapshots. Should we look into reducing them before going forward with this?\r\n\r\nA lot of inspiration in this PR was taken from @Andarist in #39. Thanks a lot for the pointers on where to look! Hope it's okay with you that I did it this way.\r\n\r\nFixes #25 ","created_at":"2018-12-04T20:30:54Z","updated_at":"2018-12-05T11:35:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"242afb952c36f91f599e9e590d388b7bcf7570af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/developit/microbundle/pulls/263/commits","review_comments_url":"https://api.github.com/repos/developit/microbundle/pulls/263/comments","review_comment_url":"https://api.github.com/repos/developit/microbundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/developit/microbundle/issues/263/comments","statuses_url":"https://api.github.com/repos/developit/microbundle/statuses/90fab42f60691bea813eca0177773153bfee7640","head":{"label":"esphen:buble-to-babel","ref":"buble-to-babel","sha":"90fab42f60691bea813eca0177773153bfee7640","user":{"login":"esphen","id":5845924,"node_id":"MDQ6VXNlcjU4NDU5MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5845924?v=4","gravatar_id":"","url":"https://api.github.com/users/esphen","html_url":"https://github.com/esphen","followers_url":"https://api.github.com/users/esphen/followers","following_url":"https://api.github.com/users/esphen/following{/other_user}","gists_url":"https://api.github.com/users/esphen/gists{/gist_id}","starred_url":"https://api.github.com/users/esphen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esphen/subscriptions","organizations_url":"https://api.github.com/users/esphen/orgs","repos_url":"https://api.github.com/users/esphen/repos","events_url":"https://api.github.com/users/esphen/events{/privacy}","received_events_url":"https://api.github.com/users/esphen/received_events","type":"User","site_admin":false},"repo":{"id":160413666,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MTM2NjY=","name":"microbundle","full_name":"esphen/microbundle","private":false,"owner":{"login":"esphen","id":5845924,"node_id":"MDQ6VXNlcjU4NDU5MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5845924?v=4","gravatar_id":"","url":"https://api.github.com/users/esphen","html_url":"https://github.com/esphen","followers_url":"https://api.github.com/users/esphen/followers","following_url":"https://api.github.com/users/esphen/following{/other_user}","gists_url":"https://api.github.com/users/esphen/gists{/gist_id}","starred_url":"https://api.github.com/users/esphen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esphen/subscriptions","organizations_url":"https://api.github.com/users/esphen/orgs","repos_url":"https://api.github.com/users/esphen/repos","events_url":"https://api.github.com/users/esphen/events{/privacy}","received_events_url":"https://api.github.com/users/esphen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/esphen/microbundle","description":"📦 Zero-configuration bundler for tiny modules.","fork":true,"url":"https://api.github.com/repos/esphen/microbundle","forks_url":"https://api.github.com/repos/esphen/microbundle/forks","keys_url":"https://api.github.com/repos/esphen/microbundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esphen/microbundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esphen/microbundle/teams","hooks_url":"https://api.github.com/repos/esphen/microbundle/hooks","issue_events_url":"https://api.github.com/repos/esphen/microbundle/issues/events{/number}","events_url":"https://api.github.com/repos/esphen/microbundle/events","assignees_url":"https://api.github.com/repos/esphen/microbundle/assignees{/user}","branches_url":"https://api.github.com/repos/esphen/microbundle/branches{/branch}","tags_url":"https://api.github.com/repos/esphen/microbundle/tags","blobs_url":"https://api.github.com/repos/esphen/microbundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esphen/microbundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esphen/microbundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/esphen/microbundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esphen/microbundle/statuses/{sha}","languages_url":"https://api.github.com/repos/esphen/microbundle/languages","stargazers_url":"https://api.github.com/repos/esphen/microbundle/stargazers","contributors_url":"https://api.github.com/repos/esphen/microbundle/contributors","subscribers_url":"https://api.github.com/repos/esphen/microbundle/subscribers","subscription_url":"https://api.github.com/repos/esphen/microbundle/subscription","commits_url":"https://api.github.com/repos/esphen/microbundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/esphen/microbundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/esphen/microbundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/esphen/microbundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/esphen/microbundle/contents/{+path}","compare_url":"https://api.github.com/repos/esphen/microbundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esphen/microbundle/merges","archive_url":"https://api.github.com/repos/esphen/microbundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esphen/microbundle/downloads","issues_url":"https://api.github.com/repos/esphen/microbundle/issues{/number}","pulls_url":"https://api.github.com/repos/esphen/microbundle/pulls{/number}","milestones_url":"https://api.github.com/repos/esphen/microbundle/milestones{/number}","notifications_url":"https://api.github.com/repos/esphen/microbundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esphen/microbundle/labels{/name}","releases_url":"https://api.github.com/repos/esphen/microbundle/releases{/id}","deployments_url":"https://api.github.com/repos/esphen/microbundle/deployments","created_at":"2018-12-04T20:17:09Z","updated_at":"2018-12-04T20:17:11Z","pushed_at":"2018-12-04T20:19:10Z","git_url":"git://github.com/esphen/microbundle.git","ssh_url":"git@github.com:esphen/microbundle.git","clone_url":"https://github.com/esphen/microbundle.git","svn_url":"https://github.com/esphen/microbundle","homepage":"https://npm.im/microbundle","size":336,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"developit:master","ref":"master","sha":"1f23940faccb8e212993e0ed0dff47edbdabb139","user":{"login":"developit","id":105127,"node_id":"MDQ6VXNlcjEwNTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/105127?v=4","gravatar_id":"","url":"https://api.github.com/users/developit","html_url":"https://github.com/developit","followers_url":"https://api.github.com/users/developit/followers","following_url":"https://api.github.com/users/developit/following{/other_user}","gists_url":"https://api.github.com/users/developit/gists{/gist_id}","starred_url":"https://api.github.com/users/developit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developit/subscriptions","organizations_url":"https://api.github.com/users/developit/orgs","repos_url":"https://api.github.com/users/developit/repos","events_url":"https://api.github.com/users/developit/events{/privacy}","received_events_url":"https://api.github.com/users/developit/received_events","type":"User","site_admin":false},"repo":{"id":113912360,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5MTIzNjA=","name":"microbundle","full_name":"developit/microbundle","private":false,"owner":{"login":"developit","id":105127,"node_id":"MDQ6VXNlcjEwNTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/105127?v=4","gravatar_id":"","url":"https://api.github.com/users/developit","html_url":"https://github.com/developit","followers_url":"https://api.github.com/users/developit/followers","following_url":"https://api.github.com/users/developit/following{/other_user}","gists_url":"https://api.github.com/users/developit/gists{/gist_id}","starred_url":"https://api.github.com/users/developit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developit/subscriptions","organizations_url":"https://api.github.com/users/developit/orgs","repos_url":"https://api.github.com/users/developit/repos","events_url":"https://api.github.com/users/developit/events{/privacy}","received_events_url":"https://api.github.com/users/developit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/developit/microbundle","description":"📦 Zero-configuration bundler for tiny modules.","fork":false,"url":"https://api.github.com/repos/developit/microbundle","forks_url":"https://api.github.com/repos/developit/microbundle/forks","keys_url":"https://api.github.com/repos/developit/microbundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/developit/microbundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/developit/microbundle/teams","hooks_url":"https://api.github.com/repos/developit/microbundle/hooks","issue_events_url":"https://api.github.com/repos/developit/microbundle/issues/events{/number}","events_url":"https://api.github.com/repos/developit/microbundle/events","assignees_url":"https://api.github.com/repos/developit/microbundle/assignees{/user}","branches_url":"https://api.github.com/repos/developit/microbundle/branches{/branch}","tags_url":"https://api.github.com/repos/developit/microbundle/tags","blobs_url":"https://api.github.com/repos/developit/microbundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/developit/microbundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/developit/microbundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/developit/microbundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/developit/microbundle/statuses/{sha}","languages_url":"https://api.github.com/repos/developit/microbundle/languages","stargazers_url":"https://api.github.com/repos/developit/microbundle/stargazers","contributors_url":"https://api.github.com/repos/developit/microbundle/contributors","subscribers_url":"https://api.github.com/repos/developit/microbundle/subscribers","subscription_url":"https://api.github.com/repos/developit/microbundle/subscription","commits_url":"https://api.github.com/repos/developit/microbundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/developit/microbundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/developit/microbundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/developit/microbundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/developit/microbundle/contents/{+path}","compare_url":"https://api.github.com/repos/developit/microbundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/developit/microbundle/merges","archive_url":"https://api.github.com/repos/developit/microbundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/developit/microbundle/downloads","issues_url":"https://api.github.com/repos/developit/microbundle/issues{/number}","pulls_url":"https://api.github.com/repos/developit/microbundle/pulls{/number}","milestones_url":"https://api.github.com/repos/developit/microbundle/milestones{/number}","notifications_url":"https://api.github.com/repos/developit/microbundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/developit/microbundle/labels{/name}","releases_url":"https://api.github.com/repos/developit/microbundle/releases{/id}","deployments_url":"https://api.github.com/repos/developit/microbundle/deployments","created_at":"2017-12-11T21:51:02Z","updated_at":"2018-12-05T10:49:47Z","pushed_at":"2018-12-05T11:13:31Z","git_url":"git://github.com/developit/microbundle.git","ssh_url":"git@github.com:developit/microbundle.git","clone_url":"https://github.com/developit/microbundle.git","svn_url":"https://github.com/developit/microbundle","homepage":"https://npm.im/microbundle","size":341,"stargazers_count":2735,"watchers_count":2735,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":44,"license":null,"forks":125,"open_issues":44,"watchers":2735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/developit/microbundle/pulls/263"},"html":{"href":"https://github.com/developit/microbundle/pull/263"},"issue":{"href":"https://api.github.com/repos/developit/microbundle/issues/263"},"comments":{"href":"https://api.github.com/repos/developit/microbundle/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/developit/microbundle/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/developit/microbundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/developit/microbundle/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/developit/microbundle/statuses/90fab42f60691bea813eca0177773153bfee7640"}},"author_association":"NONE"}}
{"actor":{"display_login":"marvinhagemeister"}}