{"action":"created","comment":{"url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/comments/234490010","pull_request_review_id":176139152,"id":234490010,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ5MDAxMA==","diff_hunk":"@@ -68,7 +68,7 @@ def produce_require_config_syntax(\n         filename = self.get_js_library(pinyin)\n         if filename:\n             jshost = self._resolve_jshost(jshost, use_github)\n-            return \"'{}': '{}/{}'\".format(pinyin, jshost, filename)\n+            return \"'{}': Jupyter.notebook.base_url.slice(0,-1) + '{}/{}'\".format(pinyin, jshost, filename)","path":"pyecharts/js_extensions.py","position":5,"original_position":5,"commit_id":"a56bb93f4596d10ec2aa7bc6fbfa0cf79a7c9c48","original_commit_id":"a56bb93f4596d10ec2aa7bc6fbfa0cf79a7c9c48","user":{"login":"chenjiandongx","id":19553554,"node_id":"MDQ6VXNlcjE5NTUzNTU0","avatar_url":"https://avatars2.githubusercontent.com/u/19553554?v=4","gravatar_id":"","url":"https://api.github.com/users/chenjiandongx","html_url":"https://github.com/chenjiandongx","followers_url":"https://api.github.com/users/chenjiandongx/followers","following_url":"https://api.github.com/users/chenjiandongx/following{/other_user}","gists_url":"https://api.github.com/users/chenjiandongx/gists{/gist_id}","starred_url":"https://api.github.com/users/chenjiandongx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenjiandongx/subscriptions","organizations_url":"https://api.github.com/users/chenjiandongx/orgs","repos_url":"https://api.github.com/users/chenjiandongx/repos","events_url":"https://api.github.com/users/chenjiandongx/events{/privacy}","received_events_url":"https://api.github.com/users/chenjiandongx/received_events","type":"User","site_admin":false},"body":"Jupyter.notebook.base_url.slice(0,-1) 这个值怎么读取？","created_at":"2018-11-19T04:15:04Z","updated_at":"2018-11-19T04:15:05Z","html_url":"https://github.com/pyecharts/pyecharts/pull/831#discussion_r234490010","pull_request_url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/comments/234490010"},"html":{"href":"https://github.com/pyecharts/pyecharts/pull/831#discussion_r234490010"},"pull_request":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831"}},"in_reply_to_id":231315026},"pull_request":{"url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831","id":228599743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTk5NzQz","html_url":"https://github.com/pyecharts/pyecharts/pull/831","diff_url":"https://github.com/pyecharts/pyecharts/pull/831.diff","patch_url":"https://github.com/pyecharts/pyecharts/pull/831.patch","issue_url":"https://api.github.com/repos/pyecharts/pyecharts/issues/831","number":831,"state":"open","locked":false,"title":"request js files from the notebook.base_url route","user":{"login":"forbxy","id":8939700,"node_id":"MDQ6VXNlcjg5Mzk3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8939700?v=4","gravatar_id":"","url":"https://api.github.com/users/forbxy","html_url":"https://github.com/forbxy","followers_url":"https://api.github.com/users/forbxy/followers","following_url":"https://api.github.com/users/forbxy/following{/other_user}","gists_url":"https://api.github.com/users/forbxy/gists{/gist_id}","starred_url":"https://api.github.com/users/forbxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbxy/subscriptions","organizations_url":"https://api.github.com/users/forbxy/orgs","repos_url":"https://api.github.com/users/forbxy/repos","events_url":"https://api.github.com/users/forbxy/events{/privacy}","received_events_url":"https://api.github.com/users/forbxy/received_events","type":"User","site_admin":false},"body":"<!--\r\n\r\n### 提 PR 注意事项\r\n0. 同步到 dev 分支的最新版本\r\n1. 代码尽量保持与项目统一风格，尽量按照 PEP8 规范写代码，必要时附上注释\r\n2. 如需要时请添加单元测试，也请确保所有测试能够通过\r\n3. 将 PR 推送至远程的 dev 分支，master 分支只负责发布新版本。请在提交信息中描述关于该 PR 的详细信息，需要时加上截图。\r\n4. 若是对文档进行修改，请确保数字，字母与中文之间两边均有一空格，如你所看到的所有文档一样\r\n\r\n-->\r\nnotebook下\r\npyecharts 请求静态文件的时候应该在url的最开始加上Jupyter.notebook.base_url，\r\n这个前缀在默认的notebook配置下是空，但是是可配置的。\r\n特别是由jupyterhub启动的notebook，这个参数一定不为空。\r\n代码逻辑看的不太清晰，所以就找了个地方先加上，是可以运行的，只是可能结构不太好，因此这个pr可能只是一个提示，需要作者自己再改代码啦。\r\n如何复现bug：\r\n在notebook中修改配置\r\nc.NotebookApp.base_url = '/asd'，重启notebook后调用pyecharts画图\r\n\r\n\r\n","created_at":"2018-11-06T07:45:30Z","updated_at":"2018-11-19T04:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b5ef238e19841f324339bee135b19060d780c1d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831/commits","review_comments_url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831/comments","review_comment_url":"https://api.github.com/repos/pyecharts/pyecharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyecharts/pyecharts/issues/831/comments","statuses_url":"https://api.github.com/repos/pyecharts/pyecharts/statuses/a56bb93f4596d10ec2aa7bc6fbfa0cf79a7c9c48","head":{"label":"forbxy:dev","ref":"dev","sha":"a56bb93f4596d10ec2aa7bc6fbfa0cf79a7c9c48","user":{"login":"forbxy","id":8939700,"node_id":"MDQ6VXNlcjg5Mzk3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8939700?v=4","gravatar_id":"","url":"https://api.github.com/users/forbxy","html_url":"https://github.com/forbxy","followers_url":"https://api.github.com/users/forbxy/followers","following_url":"https://api.github.com/users/forbxy/following{/other_user}","gists_url":"https://api.github.com/users/forbxy/gists{/gist_id}","starred_url":"https://api.github.com/users/forbxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbxy/subscriptions","organizations_url":"https://api.github.com/users/forbxy/orgs","repos_url":"https://api.github.com/users/forbxy/repos","events_url":"https://api.github.com/users/forbxy/events{/privacy}","received_events_url":"https://api.github.com/users/forbxy/received_events","type":"User","site_admin":false},"repo":{"id":156342494,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDI0OTQ=","name":"pyecharts","full_name":"forbxy/pyecharts","private":false,"owner":{"login":"forbxy","id":8939700,"node_id":"MDQ6VXNlcjg5Mzk3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/8939700?v=4","gravatar_id":"","url":"https://api.github.com/users/forbxy","html_url":"https://github.com/forbxy","followers_url":"https://api.github.com/users/forbxy/followers","following_url":"https://api.github.com/users/forbxy/following{/other_user}","gists_url":"https://api.github.com/users/forbxy/gists{/gist_id}","starred_url":"https://api.github.com/users/forbxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbxy/subscriptions","organizations_url":"https://api.github.com/users/forbxy/orgs","repos_url":"https://api.github.com/users/forbxy/repos","events_url":"https://api.github.com/users/forbxy/events{/privacy}","received_events_url":"https://api.github.com/users/forbxy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/forbxy/pyecharts","description":"🎨 Python Echarts Plotting Library","fork":true,"url":"https://api.github.com/repos/forbxy/pyecharts","forks_url":"https://api.github.com/repos/forbxy/pyecharts/forks","keys_url":"https://api.github.com/repos/forbxy/pyecharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forbxy/pyecharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forbxy/pyecharts/teams","hooks_url":"https://api.github.com/repos/forbxy/pyecharts/hooks","issue_events_url":"https://api.github.com/repos/forbxy/pyecharts/issues/events{/number}","events_url":"https://api.github.com/repos/forbxy/pyecharts/events","assignees_url":"https://api.github.com/repos/forbxy/pyecharts/assignees{/user}","branches_url":"https://api.github.com/repos/forbxy/pyecharts/branches{/branch}","tags_url":"https://api.github.com/repos/forbxy/pyecharts/tags","blobs_url":"https://api.github.com/repos/forbxy/pyecharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forbxy/pyecharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forbxy/pyecharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/forbxy/pyecharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forbxy/pyecharts/statuses/{sha}","languages_url":"https://api.github.com/repos/forbxy/pyecharts/languages","stargazers_url":"https://api.github.com/repos/forbxy/pyecharts/stargazers","contributors_url":"https://api.github.com/repos/forbxy/pyecharts/contributors","subscribers_url":"https://api.github.com/repos/forbxy/pyecharts/subscribers","subscription_url":"https://api.github.com/repos/forbxy/pyecharts/subscription","commits_url":"https://api.github.com/repos/forbxy/pyecharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/forbxy/pyecharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/forbxy/pyecharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/forbxy/pyecharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/forbxy/pyecharts/contents/{+path}","compare_url":"https://api.github.com/repos/forbxy/pyecharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forbxy/pyecharts/merges","archive_url":"https://api.github.com/repos/forbxy/pyecharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forbxy/pyecharts/downloads","issues_url":"https://api.github.com/repos/forbxy/pyecharts/issues{/number}","pulls_url":"https://api.github.com/repos/forbxy/pyecharts/pulls{/number}","milestones_url":"https://api.github.com/repos/forbxy/pyecharts/milestones{/number}","notifications_url":"https://api.github.com/repos/forbxy/pyecharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forbxy/pyecharts/labels{/name}","releases_url":"https://api.github.com/repos/forbxy/pyecharts/releases{/id}","deployments_url":"https://api.github.com/repos/forbxy/pyecharts/deployments","created_at":"2018-11-06T07:21:13Z","updated_at":"2018-11-06T07:25:45Z","pushed_at":"2018-11-06T07:30:14Z","git_url":"git://github.com/forbxy/pyecharts.git","ssh_url":"git@github.com:forbxy/pyecharts.git","clone_url":"https://github.com/forbxy/pyecharts.git","svn_url":"https://github.com/forbxy/pyecharts","homepage":"http://pyecharts.org","size":96743,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyecharts:dev","ref":"dev","sha":"f59f955703b5a4d72454b306774388ff0d184479","user":{"login":"pyecharts","id":34701774,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzAxNzc0","avatar_url":"https://avatars3.githubusercontent.com/u/34701774?v=4","gravatar_id":"","url":"https://api.github.com/users/pyecharts","html_url":"https://github.com/pyecharts","followers_url":"https://api.github.com/users/pyecharts/followers","following_url":"https://api.github.com/users/pyecharts/following{/other_user}","gists_url":"https://api.github.com/users/pyecharts/gists{/gist_id}","starred_url":"https://api.github.com/users/pyecharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyecharts/subscriptions","organizations_url":"https://api.github.com/users/pyecharts/orgs","repos_url":"https://api.github.com/users/pyecharts/repos","events_url":"https://api.github.com/users/pyecharts/events{/privacy}","received_events_url":"https://api.github.com/users/pyecharts/received_events","type":"Organization","site_admin":false},"repo":{"id":95067884,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA2Nzg4NA==","name":"pyecharts","full_name":"pyecharts/pyecharts","private":false,"owner":{"login":"pyecharts","id":34701774,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzAxNzc0","avatar_url":"https://avatars3.githubusercontent.com/u/34701774?v=4","gravatar_id":"","url":"https://api.github.com/users/pyecharts","html_url":"https://github.com/pyecharts","followers_url":"https://api.github.com/users/pyecharts/followers","following_url":"https://api.github.com/users/pyecharts/following{/other_user}","gists_url":"https://api.github.com/users/pyecharts/gists{/gist_id}","starred_url":"https://api.github.com/users/pyecharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyecharts/subscriptions","organizations_url":"https://api.github.com/users/pyecharts/orgs","repos_url":"https://api.github.com/users/pyecharts/repos","events_url":"https://api.github.com/users/pyecharts/events{/privacy}","received_events_url":"https://api.github.com/users/pyecharts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pyecharts/pyecharts","description":"🎨 Python Echarts Plotting Library","fork":false,"url":"https://api.github.com/repos/pyecharts/pyecharts","forks_url":"https://api.github.com/repos/pyecharts/pyecharts/forks","keys_url":"https://api.github.com/repos/pyecharts/pyecharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyecharts/pyecharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyecharts/pyecharts/teams","hooks_url":"https://api.github.com/repos/pyecharts/pyecharts/hooks","issue_events_url":"https://api.github.com/repos/pyecharts/pyecharts/issues/events{/number}","events_url":"https://api.github.com/repos/pyecharts/pyecharts/events","assignees_url":"https://api.github.com/repos/pyecharts/pyecharts/assignees{/user}","branches_url":"https://api.github.com/repos/pyecharts/pyecharts/branches{/branch}","tags_url":"https://api.github.com/repos/pyecharts/pyecharts/tags","blobs_url":"https://api.github.com/repos/pyecharts/pyecharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyecharts/pyecharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyecharts/pyecharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyecharts/pyecharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyecharts/pyecharts/statuses/{sha}","languages_url":"https://api.github.com/repos/pyecharts/pyecharts/languages","stargazers_url":"https://api.github.com/repos/pyecharts/pyecharts/stargazers","contributors_url":"https://api.github.com/repos/pyecharts/pyecharts/contributors","subscribers_url":"https://api.github.com/repos/pyecharts/pyecharts/subscribers","subscription_url":"https://api.github.com/repos/pyecharts/pyecharts/subscription","commits_url":"https://api.github.com/repos/pyecharts/pyecharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyecharts/pyecharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyecharts/pyecharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyecharts/pyecharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyecharts/pyecharts/contents/{+path}","compare_url":"https://api.github.com/repos/pyecharts/pyecharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyecharts/pyecharts/merges","archive_url":"https://api.github.com/repos/pyecharts/pyecharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyecharts/pyecharts/downloads","issues_url":"https://api.github.com/repos/pyecharts/pyecharts/issues{/number}","pulls_url":"https://api.github.com/repos/pyecharts/pyecharts/pulls{/number}","milestones_url":"https://api.github.com/repos/pyecharts/pyecharts/milestones{/number}","notifications_url":"https://api.github.com/repos/pyecharts/pyecharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyecharts/pyecharts/labels{/name}","releases_url":"https://api.github.com/repos/pyecharts/pyecharts/releases{/id}","deployments_url":"https://api.github.com/repos/pyecharts/pyecharts/deployments","created_at":"2017-06-22T02:50:25Z","updated_at":"2018-11-19T02:03:18Z","pushed_at":"2018-11-19T04:08:03Z","git_url":"git://github.com/pyecharts/pyecharts.git","ssh_url":"git@github.com:pyecharts/pyecharts.git","clone_url":"https://github.com/pyecharts/pyecharts.git","svn_url":"https://github.com/pyecharts/pyecharts","homepage":"http://pyecharts.org","size":96751,"stargazers_count":4183,"watchers_count":4183,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":910,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":910,"open_issues":85,"watchers":4183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831"},"html":{"href":"https://github.com/pyecharts/pyecharts/pull/831"},"issue":{"href":"https://api.github.com/repos/pyecharts/pyecharts/issues/831"},"comments":{"href":"https://api.github.com/repos/pyecharts/pyecharts/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyecharts/pyecharts/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/pyecharts/pyecharts/statuses/a56bb93f4596d10ec2aa7bc6fbfa0cf79a7c9c48"}},"author_association":"NONE"}}
{"actor":{"display_login":"chenjiandongx"}}