{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/1082","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/1082/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1082/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/1082/events","html_url":"https://github.com/alibaba/pouch/pull/1082","id":312584978,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwMzUxMDIw","number":1082,"title":"bugfix: fix use old image's cmd when upgrade container","user":{"login":"HusterWan","id":10414039,"node_id":"MDQ6VXNlcjEwNDE0MDM5","avatar_url":"https://avatars3.githubusercontent.com/u/10414039?v=4","gravatar_id":"","url":"https://api.github.com/users/HusterWan","html_url":"https://github.com/HusterWan","followers_url":"https://api.github.com/users/HusterWan/followers","following_url":"https://api.github.com/users/HusterWan/following{/other_user}","gists_url":"https://api.github.com/users/HusterWan/gists{/gist_id}","starred_url":"https://api.github.com/users/HusterWan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HusterWan/subscriptions","organizations_url":"https://api.github.com/users/HusterWan/orgs","repos_url":"https://api.github.com/users/HusterWan/repos","events_url":"https://api.github.com/users/HusterWan/events{/privacy}","received_events_url":"https://api.github.com/users/HusterWan/received_events","type":"User","site_admin":false},"labels":[{"id":722344260,"node_id":"MDU6TGFiZWw3MjIzNDQyNjA=","url":"https://api.github.com/repos/alibaba/pouch/labels/conflict/needs-rebase","name":"conflict/needs-rebase","color":"cccccc","default":false},{"id":684575943,"node_id":"MDU6TGFiZWw2ODQ1NzU5NDM=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":722334372,"node_id":"MDU6TGFiZWw3MjIzMzQzNzI=","url":"https://api.github.com/repos/alibaba/pouch/labels/priority/P2","name":"priority/P2","color":"d93f0b","default":false},{"id":722355278,"node_id":"MDU6TGFiZWw3MjIzNTUyNzg=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/XL","name":"size/XL","color":"f4abdb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-09T15:47:48Z","updated_at":"2018-08-23T01:58:16Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1082","html_url":"https://github.com/alibaba/pouch/pull/1082","diff_url":"https://github.com/alibaba/pouch/pull/1082.diff","patch_url":"https://github.com/alibaba/pouch/pull/1082.patch"},"body":"Signed-off-by: Michael Wan <zirenwan@gmail.com>\r\n\r\n### Ⅰ. Describe what this PR did\r\nfix create new container using old image's cmd params when upgrade a container\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\nfixes https://github.com/alibaba/pouch/issues/1077\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n1. create a new container:\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch run --name test -d registry.hub.docker.com/library/busybox:latest\r\n517711dd75bb33a2ec12d6f6355ca6cd7d83fcf13140484285c9d03135b7cfad\r\n```\r\n\r\n2.  `upgrade` container with `hello-world` image:\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch upgrade --name test registry.hub.docker.com/library/hello-world:latest\r\ntest\r\n```\r\n\r\n3. check container status:\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch ps -a\r\nName   ID       Status   Created          Image                                                Runtime\r\ntest   517711   exited   49 seconds ago   registry.hub.docker.com/library/hello-world:latest   runc\r\n```\r\n\r\n4. now we `upgrade` the container with `busybox` image again:\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch upgrade --name test registry.hub.docker.com/library/busybox:1.28\r\ntest\r\n```\r\n\r\n5. check container status again: still `exited`,  because the container's status is `exited` before `upgrade`\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch ps -a\r\nName   ID       Status   Created        Image                                          Runtime\r\ntest   517711   exited   1 minute ago   registry.hub.docker.com/library/busybox:1.28   runc\r\n```\r\n\r\n6. now we start the container:\r\n```\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch start test\r\nroot@osboxes:test (zr/fix-upgrade) -> pouch ps\r\nName   ID       Status         Created        Image                                          Runtime\r\ntest   517711   Up 2 seconds   1 minute ago   registry.hub.docker.com/library/busybox:1.28   runc\r\n```\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/415255993","html_url":"https://github.com/alibaba/pouch/pull/1082#issuecomment-415255993","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1082","id":415255993,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTI1NTk5Mw==","user":{"login":"pouchrobot","id":33292901,"node_id":"MDQ6VXNlcjMzMjkyOTAx","avatar_url":"https://avatars1.githubusercontent.com/u/33292901?v=4","gravatar_id":"","url":"https://api.github.com/users/pouchrobot","html_url":"https://github.com/pouchrobot","followers_url":"https://api.github.com/users/pouchrobot/followers","following_url":"https://api.github.com/users/pouchrobot/following{/other_user}","gists_url":"https://api.github.com/users/pouchrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/pouchrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pouchrobot/subscriptions","organizations_url":"https://api.github.com/users/pouchrobot/orgs","repos_url":"https://api.github.com/users/pouchrobot/repos","events_url":"https://api.github.com/users/pouchrobot/events{/privacy}","received_events_url":"https://api.github.com/users/pouchrobot/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T01:58:16Z","updated_at":"2018-08-23T01:58:16Z","author_association":"COLLABORATOR","body":"ping @HusterWan \nConflict happens after merging a previous commit.\nPlease rebase the branch against master and push it back again. Thanks a lot.\n"}}
{"actor":{"display_login":"pouchrobot"}}