{"action":"created","issue":{"url":"https://api.github.com/repos/plotly/image-exporter/issues/66","repository_url":"https://api.github.com/repos/plotly/image-exporter","labels_url":"https://api.github.com/repos/plotly/image-exporter/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/plotly/image-exporter/issues/66/comments","events_url":"https://api.github.com/repos/plotly/image-exporter/issues/66/events","html_url":"https://github.com/plotly/image-exporter/pull/66","id":313424875,"number":66,"title":"Forbid from displaying pop-up windows during image export","user":{"login":"JamesCropcho","id":3657,"avatar_url":"https://avatars3.githubusercontent.com/u/3657?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesCropcho","html_url":"https://github.com/JamesCropcho","followers_url":"https://api.github.com/users/JamesCropcho/followers","following_url":"https://api.github.com/users/JamesCropcho/following{/other_user}","gists_url":"https://api.github.com/users/JamesCropcho/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesCropcho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesCropcho/subscriptions","organizations_url":"https://api.github.com/users/JamesCropcho/orgs","repos_url":"https://api.github.com/users/JamesCropcho/repos","events_url":"https://api.github.com/users/JamesCropcho/events{/privacy}","received_events_url":"https://api.github.com/users/JamesCropcho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-11T17:49:29Z","updated_at":"2018-04-12T15:39:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/plotly/image-exporter/pulls/66","html_url":"https://github.com/plotly/image-exporter/pull/66","diff_url":"https://github.com/plotly/image-exporter/pull/66.diff","patch_url":"https://github.com/plotly/image-exporter/pull/66.patch"},"body":"Hello,\r\n\r\nThis pull requested created at the behest of @jackparmer (at https://github.com/plotly/image-exporter/issues/65#issuecomment-380532988).\r\n\r\ncc: @jmmease @etpinard @n-riesco \r\n\r\nHow does it look?\r\n\r\n―James"},"comment":{"url":"https://api.github.com/repos/plotly/image-exporter/issues/comments/380849582","html_url":"https://github.com/plotly/image-exporter/pull/66#issuecomment-380849582","issue_url":"https://api.github.com/repos/plotly/image-exporter/issues/66","id":380849582,"user":{"login":"jmmease","id":15064365,"avatar_url":"https://avatars1.githubusercontent.com/u/15064365?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmease","html_url":"https://github.com/jmmease","followers_url":"https://api.github.com/users/jmmease/followers","following_url":"https://api.github.com/users/jmmease/following{/other_user}","gists_url":"https://api.github.com/users/jmmease/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmease/subscriptions","organizations_url":"https://api.github.com/users/jmmease/orgs","repos_url":"https://api.github.com/users/jmmease/repos","events_url":"https://api.github.com/users/jmmease/events{/privacy}","received_events_url":"https://api.github.com/users/jmmease/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T15:39:11Z","updated_at":"2018-04-12T15:39:11Z","author_association":"NONE","body":"I have two additional related suggestions for your consideration in this PR @JamesCropcho  @jackparmer @etpinard @chriddyp \r\n\r\n1) The electron `BrowserWindow` has a `skipTaskbar` option with [description](https://electronjs.org/docs/api/browser-window)\r\n> `skipTaskbar` Boolean (optional) - Whether to show the window in taskbar. Default is false.\r\n\r\nOn Windows and Linux, setting this to `true` should keep the electron window from displaying in the taskbar, which I believe to be desirable for making image export a seamless experience for Windows and Linux Python/R users.  I think this change would just involve adding the `skipTaskbar` option everywhere the `show` option is added.\r\n\r\nNote: I'm on OS X so I can't test this directly, as the dock is not considered a taskbar (See below)\r\n\r\n2) To hide the electron icon from the dock on OS X it is recommended (electron-userland/electron-builder#1456) to add `\"extendInfo\": {\"LSUIElement\": 1}` to the top-level [`mac` configuration settings](https://www.electron.build/configuration/mac) (which I believe are in `package.json` for this project). e.g.\r\n\r\n```\r\n\"mac\": {\r\n  \"extendInfo\": {\r\n    \"LSUIElement\": 1\r\n  }\r\n}\r\n```\r\nNote: I believe these settings only take effect after the application is bundled, so I don't expect it to change the behavior of running `bin/plotly-graph-exporter.js` out of the development directory.\r\n\r\nThanks for considering. I know I'm being a perfectionist here :-)"}}
{"actor":{"display_login":"jmmease"}}