{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/comments/174300813","pull_request_review_id":103632375,"id":174300813,"diff_hunk":"@@ -0,0 +1,23 @@\n+module Conversionfunctions","path":"src/Conversionfunctions.jl","position":1,"original_position":1,"commit_id":"857f5116006a2c75333795ba6576e59b894da36e","original_commit_id":"857f5116006a2c75333795ba6576e59b894da36e","user":{"login":"giordano","id":765740,"avatar_url":"https://avatars0.githubusercontent.com/u/765740?v=4","gravatar_id":"","url":"https://api.github.com/users/giordano","html_url":"https://github.com/giordano","followers_url":"https://api.github.com/users/giordano/followers","following_url":"https://api.github.com/users/giordano/following{/other_user}","gists_url":"https://api.github.com/users/giordano/gists{/gist_id}","starred_url":"https://api.github.com/users/giordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giordano/subscriptions","organizations_url":"https://api.github.com/users/giordano/orgs","repos_url":"https://api.github.com/users/giordano/repos","events_url":"https://api.github.com/users/giordano/events{/privacy}","received_events_url":"https://api.github.com/users/giordano/received_events","type":"User","site_admin":false},"body":"I think there is no need of a module for each function, just include the file.","created_at":"2018-03-13T22:10:03Z","updated_at":"2018-03-13T22:34:14Z","html_url":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4#discussion_r174300813","pull_request_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/comments/174300813"},"html":{"href":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4#discussion_r174300813"},"pull_request":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4"}},"in_reply_to_id":174273437},"pull_request":{"url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4","id":174777640,"html_url":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4","diff_url":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4.diff","patch_url":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4.patch","issue_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/4","number":4,"state":"open","locked":false,"title":"Ported function eraTaitt","user":{"login":"prakharcode","id":13493237,"avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"body":"Closes #3 \r\n\r\nFirst PR for solving #1\r\n\r\n- Which Function?\r\n     Ported eraTaitt (previously `ccall`-ed to Taitt, pure Julia)\r\n- What is added?\r\n    A new module ConversionFunctions.jl which will be an amalgamation of all the ported function. \r\n","created_at":"2018-03-13T20:16:51Z","updated_at":"2018-03-13T22:34:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6ef3f35a646cb708f34dcefc1147aedf4bcf099","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":866223457,"url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/labels/needs%20docs","name":"needs docs","color":"a9fcd6","default":false},{"id":866223351,"url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/labels/needs%20tests","name":"needs tests","color":"5b90e5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4/commits","review_comments_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4/comments","review_comment_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/4/comments","statuses_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/statuses/857f5116006a2c75333795ba6576e59b894da36e","head":{"label":"prakharcode:master","ref":"master","sha":"857f5116006a2c75333795ba6576e59b894da36e","user":{"login":"prakharcode","id":13493237,"avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"repo":{"id":122171962,"name":"AstronomicalTime.jl","full_name":"prakharcode/AstronomicalTime.jl","owner":{"login":"prakharcode","id":13493237,"avatar_url":"https://avatars3.githubusercontent.com/u/13493237?v=4","gravatar_id":"","url":"https://api.github.com/users/prakharcode","html_url":"https://github.com/prakharcode","followers_url":"https://api.github.com/users/prakharcode/followers","following_url":"https://api.github.com/users/prakharcode/following{/other_user}","gists_url":"https://api.github.com/users/prakharcode/gists{/gist_id}","starred_url":"https://api.github.com/users/prakharcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prakharcode/subscriptions","organizations_url":"https://api.github.com/users/prakharcode/orgs","repos_url":"https://api.github.com/users/prakharcode/repos","events_url":"https://api.github.com/users/prakharcode/events{/privacy}","received_events_url":"https://api.github.com/users/prakharcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prakharcode/AstronomicalTime.jl","description":"Astronomical time keeping in Julia","fork":true,"url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl","forks_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/forks","keys_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/teams","hooks_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/hooks","issue_events_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues/events{/number}","events_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/events","assignees_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/assignees{/user}","branches_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/branches{/branch}","tags_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/tags","blobs_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/languages","stargazers_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/stargazers","contributors_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/contributors","subscribers_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/subscribers","subscription_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/subscription","commits_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/contents/{+path}","compare_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/merges","archive_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/downloads","issues_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/issues{/number}","pulls_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/labels{/name}","releases_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/releases{/id}","deployments_url":"https://api.github.com/repos/prakharcode/AstronomicalTime.jl/deployments","created_at":"2018-02-20T08:24:18Z","updated_at":"2018-03-13T20:01:15Z","pushed_at":"2018-03-13T20:01:14Z","git_url":"git://github.com/prakharcode/AstronomicalTime.jl.git","ssh_url":"git@github.com:prakharcode/AstronomicalTime.jl.git","clone_url":"https://github.com/prakharcode/AstronomicalTime.jl.git","svn_url":"https://github.com/prakharcode/AstronomicalTime.jl","homepage":"http://juliaastro.github.io/","size":72,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaAstro:master","ref":"master","sha":"12ac27ca26ab388e8245c63f242e65e6a49caa62","user":{"login":"JuliaAstro","id":6685132,"avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"repo":{"id":83114211,"name":"AstronomicalTime.jl","full_name":"JuliaAstro/AstronomicalTime.jl","owner":{"login":"JuliaAstro","id":6685132,"avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaAstro/AstronomicalTime.jl","description":"Astronomical time keeping in Julia","fork":false,"url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl","forks_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/forks","keys_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/teams","hooks_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/events","assignees_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/tags","blobs_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/subscription","commits_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/merges","archive_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/downloads","issues_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/deployments","created_at":"2017-02-25T07:18:27Z","updated_at":"2017-09-21T16:19:07Z","pushed_at":"2018-03-13T20:16:52Z","git_url":"git://github.com/JuliaAstro/AstronomicalTime.jl.git","ssh_url":"git@github.com:JuliaAstro/AstronomicalTime.jl.git","clone_url":"https://github.com/JuliaAstro/AstronomicalTime.jl.git","svn_url":"https://github.com/JuliaAstro/AstronomicalTime.jl","homepage":"http://juliaastro.github.io/","size":68,"stargazers_count":2,"watchers_count":2,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4"},"html":{"href":"https://github.com/JuliaAstro/AstronomicalTime.jl/pull/4"},"issue":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/4"},"comments":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaAstro/AstronomicalTime.jl/statuses/857f5116006a2c75333795ba6576e59b894da36e"}},"author_association":"NONE"}}
{"actor":{"display_login":"giordano"}}