{"action":"created","issue":{"url":"https://api.github.com/repos/freeipa/freeipa/issues/2156","repository_url":"https://api.github.com/repos/freeipa/freeipa","labels_url":"https://api.github.com/repos/freeipa/freeipa/issues/2156/labels{/name}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/2156/comments","events_url":"https://api.github.com/repos/freeipa/freeipa/issues/2156/events","html_url":"https://github.com/freeipa/freeipa/pull/2156","id":341225963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQ1NzA3","number":2156,"title":"[Backport][ipa-4-6] Fix Pylint 2.0 violations","user":{"login":"tiran","id":444071,"node_id":"MDQ6VXNlcjQ0NDA3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/444071?v=4","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"labels":[{"id":427471125,"node_id":"MDU6TGFiZWw0Mjc0NzExMjU=","url":"https://api.github.com/repos/freeipa/freeipa/labels/ack","name":"ack","color":"0e8a16","default":false},{"id":427484529,"node_id":"MDU6TGFiZWw0Mjc0ODQ1Mjk=","url":"https://api.github.com/repos/freeipa/freeipa/labels/pushed","name":"pushed","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-14T10:17:05Z","updated_at":"2018-07-16T12:46:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/2156","html_url":"https://github.com/freeipa/freeipa/pull/2156","diff_url":"https://github.com/freeipa/freeipa/pull/2156.diff","patch_url":"https://github.com/freeipa/freeipa/pull/2156.patch"},"body":"Manual backport of PR #2149 to 4.6 branch\r\n\r\nFix the following violations aiming to support Pylint 2.0\r\n\r\n- `unneeded-not` (C0113):\r\n  Consider changing \"not item in items\" to \"item not in items\" used\r\n  when a boolean expression contains an unneeded negation.\r\n\r\n- `useless-import-alias` (C0414):\r\n  Import alias does not rename original package Used when an import\r\n  alias is same as original package.e.g using import numpy as numpy\r\n  instead of import numpy as np\r\n\r\n- `raising-format-tuple` (W0715):\r\n  Exception arguments suggest string formatting might be intended Used\r\n  when passing multiple arguments to an exception constructor, the\r\n  first of them a string literal containing what appears to be\r\n  placeholders intended for formatting\r\n\r\n- `bad-continuation` (C0330):\r\n  This was already included on the disable list, although with current\r\n  version of pylint (2.0.0.dev2) violations at the end of the files\r\n  are not being ignored.\r\n  See: https://github.com/PyCQA/pylint/issues/2278\r\n\r\n- `try-except-raise` (E0705):\r\n  The except handler raises immediately Used when an except handler\r\n  uses raise as its first or only operator. This is useless because it\r\n  raises back the exception immediately. Remove the raise operator or\r\n  the entire try-except-raise block!\r\n\r\n- `consider-using-set-comprehension` (R1718):\r\n  Consider using a set comprehension Although there is nothing\r\n  syntactically wrong with this code, it is hard to read and can be\r\n  simplified to a set comprehension.Also it is faster since you don't\r\n  need to create another transient list\r\n\r\n- `dict-keys-not-iterating` (W1655):\r\n  dict.keys referenced when not iterating Used when dict.keys is\r\n  referenced in a non-iterating context (returns an iterator in\r\n  Python 3)\r\n\r\n- `comprehension-escape` (W1662):\r\n  Using a variable that was bound inside a comprehension Emitted when\r\n  using a variable, that was bound in a comprehension handler, outside\r\n  of the comprehension itself. On Python 3 these variables will be\r\n  deleted outside of the comprehension.\r\n\r\nIssue: https://pagure.io/freeipa/issue/7614\r\n\r\nSigned-off-by: Armando Neto <abiagion@redhat.com>\r\nReviewed-By: Christian Heimes <cheimes@redhat.com>"},"comment":{"url":"https://api.github.com/repos/freeipa/freeipa/issues/comments/405235599","html_url":"https://github.com/freeipa/freeipa/pull/2156#issuecomment-405235599","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/2156","id":405235599,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTIzNTU5OQ==","user":{"login":"tiran","id":444071,"node_id":"MDQ6VXNlcjQ0NDA3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/444071?v=4","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T12:46:05Z","updated_at":"2018-07-16T12:46:05Z","author_association":"MEMBER","body":"ipa-4-6:\n\n* a49e933eb6aef3531ce4f2e705d2d525cbfe4329 Fix Pylint 2.0 violations\n\n"}}
{"actor":{"display_login":"tiran"}}