{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1644","repository_url":"https://api.github.com/repos/ARMmbed/mbedtls","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1644/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1644/comments","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1644/events","html_url":"https://github.com/ARMmbed/mbedtls/pull/1644","id":325442715,"number":1644,"title":"Automatically configure mbedtls_platform_zeroize under Windows and C11","user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"labels":[{"id":937149694,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Platform","name":"component: Platform","color":"F6CED8","default":false},{"id":19280386,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":408190313,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":705358813,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-22T20:03:20Z","updated_at":"2018-05-30T12:59:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1644","html_url":"https://github.com/ARMmbed/mbedtls/pull/1644","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1644.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1644.patch"},"body":"This PR adds functionality to automatically configure Mbed TLS to use the appropriate secure zeroize functions under Windows and C11. Please note that this is **under development**. It still needs to be tested under Windows.\r\n\r\nMy system's libc does not have support for Annex K of C11 , which is the one that defines memset_s(). So, I have not been able to test this functionality either. I am trying to get a hold of another libc with support for that, but if it is not straight forward, I will consider removing the use of memset_s(). @sbutcher-arm: What do you think?\r\n\r\nThe Windows detection and #define use the code in https://github.com/ARMmbed/mbedtls/pull/1522 as stated in the ChangeLog.\r\n\r\n## Status\r\n**IN DEVELOPMENT**\r\n\r\n## Requires Backporting\r\nNO  \r\n## Todos\r\n- [ ] Tests"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments/393151905","html_url":"https://github.com/ARMmbed/mbedtls/pull/1644#issuecomment-393151905","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1644","id":393151905,"user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T12:59:27Z","updated_at":"2018-05-30T12:59:27Z","author_association":"CONTRIBUTOR","body":"@RonEld: Thanks for the review. What sort of tests are you suggesting? We already have a zeroize test included in all.sh. Also, please note that any tests in windows will check that platform and its very difficult to get a libc that supports memset_s(). I am actually thinking whether we should remove that..."}}
{"actor":{"display_login":"andresag01"}}