{"action":"created","comment":{"url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/comments/179738902","pull_request_review_id":110040181,"id":179738902,"diff_hunk":"@@ -0,0 +1,78 @@\n+//\n+//  VSLCodecs.h\n+//  Copyright © 2018 Devhouse Spindle. All rights reserved.\n+//\n+\n+\n+#import <Foundation/Foundation.h>\n+\n+#import \"VSLCodecConfiguration.h\"\n+\n+/**\n+ *  Enum of possible Audio Codecs.\n+ */\n+typedef NS_ENUM(NSInteger, VSLAudioCodec) {\n+        // G711a\n+    VSLAudioCodecG711a,\n+        // G722\n+    VSLAudioCodecG722,\n+        // iLBC\n+    VSLAudioCodecILBC,\n+        // G711\n+    VSLAudioCodecG711,\n+        // Speex 8 kHz\n+    VSLAudioCodecSpeex8000,\n+        // Speex 16 kHz\n+    VSLAudioCodecSpeex16000,\n+        // Speex 32 kHz\n+    VSLAudioCodecSpeex32000,\n+        // GSM 8 kHZ\n+    VSLAudioCodecGSM,\n+        // Opus\n+    VSLAudioCodecOpus,\n+};\n+#define VSLAudioCodecString(VSLAudioCodec) [VSLAudioCodecArray objectAtIndex:VSLAudioCodec]\n+#define VSLAudioCodecStringWithIndex(NSInteger) [VSLAudioCodecArray objectAtIndex:NSInteger]\n+#define VSLAudioCodecArray @[@\"PCMA/8000/1\", @\"G722/16000/1\", @\"iLBC/8000/1\", @\"PCMU/8000/1\", @\"speex/8000/1\", @\"speex/16000/1\", @\"speex/32000/1\", @\"GSM/8000/1\", @\"opus/48000/2\"]\n+\n+\n+@interface VSLAudioCodecs : NSObject\n+\n+/**\n+ *  The prioritiy of the codec\n+ */\n+@property (readonly, nonatomic) NSUInteger priority;\n+\n+/**\n+ * The used codec.\n+ */\n+@property (readonly, nonatomic) VSLAudioCodec codec;\n+\n+/**\n+ * Make the default init unavaibale.\n+ */\n+- (instancetype _Nonnull) init __attribute__((unavailable(\"init not available. Use initWithAudioCodec instead.\")));\n+\n+/**\n+ * The init to setup the audio codecs.\n+ *\n+ * @param codec     Audio codec codec to set the prioritiy for.\n+ * @param priority  NSUInteger the priority the codec will have.\n+ */\n+- (instancetype _Nonnull)initWithAudioCodec:(VSLAudioCodec)codec andPriotity:(NSUInteger)priority;","path":"Pod/Classes/VSLAudioCodecs.h","position":62,"original_position":62,"commit_id":"d704e2a04403f8d440cd4a230108f612931051c4","original_commit_id":"d704e2a04403f8d440cd4a230108f612931051c4","user":{"login":"jeremynorman89","id":34450322,"avatar_url":"https://avatars1.githubusercontent.com/u/34450322?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremynorman89","html_url":"https://github.com/jeremynorman89","followers_url":"https://api.github.com/users/jeremynorman89/followers","following_url":"https://api.github.com/users/jeremynorman89/following{/other_user}","gists_url":"https://api.github.com/users/jeremynorman89/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremynorman89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremynorman89/subscriptions","organizations_url":"https://api.github.com/users/jeremynorman89/orgs","repos_url":"https://api.github.com/users/jeremynorman89/repos","events_url":"https://api.github.com/users/jeremynorman89/events{/privacy}","received_events_url":"https://api.github.com/users/jeremynorman89/received_events","type":"User","site_admin":false},"body":"Typo (priotity)","created_at":"2018-04-06T12:12:19Z","updated_at":"2018-04-06T12:15:19Z","html_url":"https://github.com/VoIPGRID/VialerSIPLib/pull/133#discussion_r179738902","pull_request_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/comments/179738902"},"html":{"href":"https://github.com/VoIPGRID/VialerSIPLib/pull/133#discussion_r179738902"},"pull_request":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133","id":179860426,"html_url":"https://github.com/VoIPGRID/VialerSIPLib/pull/133","diff_url":"https://github.com/VoIPGRID/VialerSIPLib/pull/133.diff","patch_url":"https://github.com/VoIPGRID/VialerSIPLib/pull/133.patch","issue_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/133","number":133,"state":"open","locked":false,"title":"Add configurable codecs","user":{"login":"redmerloen","id":12196822,"avatar_url":"https://avatars0.githubusercontent.com/u/12196822?v=4","gravatar_id":"","url":"https://api.github.com/users/redmerloen","html_url":"https://github.com/redmerloen","followers_url":"https://api.github.com/users/redmerloen/followers","following_url":"https://api.github.com/users/redmerloen/following{/other_user}","gists_url":"https://api.github.com/users/redmerloen/gists{/gist_id}","starred_url":"https://api.github.com/users/redmerloen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redmerloen/subscriptions","organizations_url":"https://api.github.com/users/redmerloen/orgs","repos_url":"https://api.github.com/users/redmerloen/repos","events_url":"https://api.github.com/users/redmerloen/events{/privacy}","received_events_url":"https://api.github.com/users/redmerloen/received_events","type":"User","site_admin":false},"body":"Added a codec configuration option.\r\nSo that the codecs can be configured without having to touch the actually endpoint code.","created_at":"2018-04-06T05:55:59Z","updated_at":"2018-04-06T12:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9225199d41c5e0bbf178310c7eddc67596a8f6c6","assignee":{"login":"redmerloen","id":12196822,"avatar_url":"https://avatars0.githubusercontent.com/u/12196822?v=4","gravatar_id":"","url":"https://api.github.com/users/redmerloen","html_url":"https://github.com/redmerloen","followers_url":"https://api.github.com/users/redmerloen/followers","following_url":"https://api.github.com/users/redmerloen/following{/other_user}","gists_url":"https://api.github.com/users/redmerloen/gists{/gist_id}","starred_url":"https://api.github.com/users/redmerloen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redmerloen/subscriptions","organizations_url":"https://api.github.com/users/redmerloen/orgs","repos_url":"https://api.github.com/users/redmerloen/repos","events_url":"https://api.github.com/users/redmerloen/events{/privacy}","received_events_url":"https://api.github.com/users/redmerloen/received_events","type":"User","site_admin":false},"assignees":[{"login":"redmerloen","id":12196822,"avatar_url":"https://avatars0.githubusercontent.com/u/12196822?v=4","gravatar_id":"","url":"https://api.github.com/users/redmerloen","html_url":"https://github.com/redmerloen","followers_url":"https://api.github.com/users/redmerloen/followers","following_url":"https://api.github.com/users/redmerloen/following{/other_user}","gists_url":"https://api.github.com/users/redmerloen/gists{/gist_id}","starred_url":"https://api.github.com/users/redmerloen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redmerloen/subscriptions","organizations_url":"https://api.github.com/users/redmerloen/orgs","repos_url":"https://api.github.com/users/redmerloen/repos","events_url":"https://api.github.com/users/redmerloen/events{/privacy}","received_events_url":"https://api.github.com/users/redmerloen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133/commits","review_comments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133/comments","review_comment_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/133/comments","statuses_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/statuses/d704e2a04403f8d440cd4a230108f612931051c4","head":{"label":"VoIPGRID:feature/configure-codecs","ref":"feature/configure-codecs","sha":"d704e2a04403f8d440cd4a230108f612931051c4","user":{"login":"VoIPGRID","id":941462,"avatar_url":"https://avatars1.githubusercontent.com/u/941462?v=4","gravatar_id":"","url":"https://api.github.com/users/VoIPGRID","html_url":"https://github.com/VoIPGRID","followers_url":"https://api.github.com/users/VoIPGRID/followers","following_url":"https://api.github.com/users/VoIPGRID/following{/other_user}","gists_url":"https://api.github.com/users/VoIPGRID/gists{/gist_id}","starred_url":"https://api.github.com/users/VoIPGRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoIPGRID/subscriptions","organizations_url":"https://api.github.com/users/VoIPGRID/orgs","repos_url":"https://api.github.com/users/VoIPGRID/repos","events_url":"https://api.github.com/users/VoIPGRID/events{/privacy}","received_events_url":"https://api.github.com/users/VoIPGRID/received_events","type":"Organization","site_admin":false},"repo":{"id":47065814,"name":"VialerSIPLib","full_name":"VoIPGRID/VialerSIPLib","owner":{"login":"VoIPGRID","id":941462,"avatar_url":"https://avatars1.githubusercontent.com/u/941462?v=4","gravatar_id":"","url":"https://api.github.com/users/VoIPGRID","html_url":"https://github.com/VoIPGRID","followers_url":"https://api.github.com/users/VoIPGRID/followers","following_url":"https://api.github.com/users/VoIPGRID/following{/other_user}","gists_url":"https://api.github.com/users/VoIPGRID/gists{/gist_id}","starred_url":"https://api.github.com/users/VoIPGRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoIPGRID/subscriptions","organizations_url":"https://api.github.com/users/VoIPGRID/orgs","repos_url":"https://api.github.com/users/VoIPGRID/repos","events_url":"https://api.github.com/users/VoIPGRID/events{/privacy}","received_events_url":"https://api.github.com/users/VoIPGRID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoIPGRID/VialerSIPLib","description":"An Objective-c wrapper for PJSIP","fork":false,"url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib","forks_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/forks","keys_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/teams","hooks_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/hooks","issue_events_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/events{/number}","events_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/events","assignees_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/assignees{/user}","branches_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/branches{/branch}","tags_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/tags","blobs_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/statuses/{sha}","languages_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/languages","stargazers_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/stargazers","contributors_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/contributors","subscribers_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/subscribers","subscription_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/subscription","commits_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/contents/{+path}","compare_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/merges","archive_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/downloads","issues_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues{/number}","pulls_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls{/number}","milestones_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/milestones{/number}","notifications_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/labels{/name}","releases_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/releases{/id}","deployments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/deployments","created_at":"2015-11-29T14:05:25Z","updated_at":"2018-04-06T09:04:18Z","pushed_at":"2018-04-06T11:37:47Z","git_url":"git://github.com/VoIPGRID/VialerSIPLib.git","ssh_url":"git@github.com:VoIPGRID/VialerSIPLib.git","clone_url":"https://github.com/VoIPGRID/VialerSIPLib.git","svn_url":"https://github.com/VoIPGRID/VialerSIPLib","homepage":"","size":31680,"stargazers_count":65,"watchers_count":65,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":27,"open_issues":20,"watchers":65,"default_branch":"develop"}},"base":{"label":"VoIPGRID:develop","ref":"develop","sha":"bcbb4f84b095fff1b7ac00153bed5054bb9fc9b4","user":{"login":"VoIPGRID","id":941462,"avatar_url":"https://avatars1.githubusercontent.com/u/941462?v=4","gravatar_id":"","url":"https://api.github.com/users/VoIPGRID","html_url":"https://github.com/VoIPGRID","followers_url":"https://api.github.com/users/VoIPGRID/followers","following_url":"https://api.github.com/users/VoIPGRID/following{/other_user}","gists_url":"https://api.github.com/users/VoIPGRID/gists{/gist_id}","starred_url":"https://api.github.com/users/VoIPGRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoIPGRID/subscriptions","organizations_url":"https://api.github.com/users/VoIPGRID/orgs","repos_url":"https://api.github.com/users/VoIPGRID/repos","events_url":"https://api.github.com/users/VoIPGRID/events{/privacy}","received_events_url":"https://api.github.com/users/VoIPGRID/received_events","type":"Organization","site_admin":false},"repo":{"id":47065814,"name":"VialerSIPLib","full_name":"VoIPGRID/VialerSIPLib","owner":{"login":"VoIPGRID","id":941462,"avatar_url":"https://avatars1.githubusercontent.com/u/941462?v=4","gravatar_id":"","url":"https://api.github.com/users/VoIPGRID","html_url":"https://github.com/VoIPGRID","followers_url":"https://api.github.com/users/VoIPGRID/followers","following_url":"https://api.github.com/users/VoIPGRID/following{/other_user}","gists_url":"https://api.github.com/users/VoIPGRID/gists{/gist_id}","starred_url":"https://api.github.com/users/VoIPGRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoIPGRID/subscriptions","organizations_url":"https://api.github.com/users/VoIPGRID/orgs","repos_url":"https://api.github.com/users/VoIPGRID/repos","events_url":"https://api.github.com/users/VoIPGRID/events{/privacy}","received_events_url":"https://api.github.com/users/VoIPGRID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoIPGRID/VialerSIPLib","description":"An Objective-c wrapper for PJSIP","fork":false,"url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib","forks_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/forks","keys_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/teams","hooks_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/hooks","issue_events_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/events{/number}","events_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/events","assignees_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/assignees{/user}","branches_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/branches{/branch}","tags_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/tags","blobs_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/statuses/{sha}","languages_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/languages","stargazers_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/stargazers","contributors_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/contributors","subscribers_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/subscribers","subscription_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/subscription","commits_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/contents/{+path}","compare_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/merges","archive_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/downloads","issues_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues{/number}","pulls_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls{/number}","milestones_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/milestones{/number}","notifications_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/labels{/name}","releases_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/releases{/id}","deployments_url":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/deployments","created_at":"2015-11-29T14:05:25Z","updated_at":"2018-04-06T09:04:18Z","pushed_at":"2018-04-06T11:37:47Z","git_url":"git://github.com/VoIPGRID/VialerSIPLib.git","ssh_url":"git@github.com:VoIPGRID/VialerSIPLib.git","clone_url":"https://github.com/VoIPGRID/VialerSIPLib.git","svn_url":"https://github.com/VoIPGRID/VialerSIPLib","homepage":"","size":31680,"stargazers_count":65,"watchers_count":65,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":27,"open_issues":20,"watchers":65,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133"},"html":{"href":"https://github.com/VoIPGRID/VialerSIPLib/pull/133"},"issue":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/133"},"comments":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/VoIPGRID/VialerSIPLib/statuses/d704e2a04403f8d440cd4a230108f612931051c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeremynorman89"}}