{"action":"closed","number":73,"pull_request":{"url":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73","id":201060303,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDYwMzAz","html_url":"https://github.com/caiyue1993/IceCream/pull/73","diff_url":"https://github.com/caiyue1993/IceCream/pull/73.diff","patch_url":"https://github.com/caiyue1993/IceCream/pull/73.patch","issue_url":"https://api.github.com/repos/caiyue1993/IceCream/issues/73","number":73,"state":"closed","locked":false,"title":"Sharing flow","user":{"login":"rodericj","id":75346,"node_id":"MDQ6VXNlcjc1MzQ2","avatar_url":"https://avatars0.githubusercontent.com/u/75346?v=4","gravatar_id":"","url":"https://api.github.com/users/rodericj","html_url":"https://github.com/rodericj","followers_url":"https://api.github.com/users/rodericj/followers","following_url":"https://api.github.com/users/rodericj/following{/other_user}","gists_url":"https://api.github.com/users/rodericj/gists{/gist_id}","starred_url":"https://api.github.com/users/rodericj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodericj/subscriptions","organizations_url":"https://api.github.com/users/rodericj/orgs","repos_url":"https://api.github.com/users/rodericj/repos","events_url":"https://api.github.com/users/rodericj/events{/privacy}","received_events_url":"https://api.github.com/users/rodericj/received_events","type":"User","site_admin":false},"body":"This resolves #4 and provides basic sync functionality with the shared database. \r\nThere are a few considerations here that are worth discussing. \r\n\r\n1. The objects that conform to `CKRecordRecoverable` now require a `databaseType` attribute so this effectively is an API breaking change.\r\n2. Many of the CloudKit operations are now database specific and as such required some API changes. \r\n3. We `@available`'ed the methods for zone change updates for backwards compatibility.\r\n4. This is built off of @sprynmr's changes in #72 so it may make sense to either merge that PR first, or view this PR through a branch diff tool of your choice. As the sharing is all in one commit, you might look here: https://github.com/caiyue1993/IceCream/commit/b128ba4ca9a09be430f987bec9d8de65d3b47767\r\n5. This PR does not cover accepting the share though `internal func application(_ application: UIApplication, userDidAcceptCloudKitShareWith cloudKitShareMetadata: CKShare.Metadata)`\r\n ","created_at":"2018-07-12T16:38:07Z","updated_at":"2018-08-14T18:14:15Z","closed_at":"2018-08-14T18:14:15Z","merged_at":null,"merge_commit_sha":"f4633ba77d5dbe12d77635fd1f76b65b31058f26","assignee":{"login":"caiyue1993","id":6007760,"node_id":"MDQ6VXNlcjYwMDc3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6007760?v=4","gravatar_id":"","url":"https://api.github.com/users/caiyue1993","html_url":"https://github.com/caiyue1993","followers_url":"https://api.github.com/users/caiyue1993/followers","following_url":"https://api.github.com/users/caiyue1993/following{/other_user}","gists_url":"https://api.github.com/users/caiyue1993/gists{/gist_id}","starred_url":"https://api.github.com/users/caiyue1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiyue1993/subscriptions","organizations_url":"https://api.github.com/users/caiyue1993/orgs","repos_url":"https://api.github.com/users/caiyue1993/repos","events_url":"https://api.github.com/users/caiyue1993/events{/privacy}","received_events_url":"https://api.github.com/users/caiyue1993/received_events","type":"User","site_admin":false},"assignees":[{"login":"caiyue1993","id":6007760,"node_id":"MDQ6VXNlcjYwMDc3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6007760?v=4","gravatar_id":"","url":"https://api.github.com/users/caiyue1993","html_url":"https://github.com/caiyue1993","followers_url":"https://api.github.com/users/caiyue1993/followers","following_url":"https://api.github.com/users/caiyue1993/following{/other_user}","gists_url":"https://api.github.com/users/caiyue1993/gists{/gist_id}","starred_url":"https://api.github.com/users/caiyue1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiyue1993/subscriptions","organizations_url":"https://api.github.com/users/caiyue1993/orgs","repos_url":"https://api.github.com/users/caiyue1993/repos","events_url":"https://api.github.com/users/caiyue1993/events{/privacy}","received_events_url":"https://api.github.com/users/caiyue1993/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73/commits","review_comments_url":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73/comments","review_comment_url":"https://api.github.com/repos/caiyue1993/IceCream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caiyue1993/IceCream/issues/73/comments","statuses_url":"https://api.github.com/repos/caiyue1993/IceCream/statuses/3ea5d8b427288a2e1221be50c8d107aa9e4cb14d","head":{"label":"ThumbWorks:sharingFlow","ref":"sharingFlow","sha":"3ea5d8b427288a2e1221be50c8d107aa9e4cb14d","user":{"login":"ThumbWorks","id":10676374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc2Mzc0","avatar_url":"https://avatars3.githubusercontent.com/u/10676374?v=4","gravatar_id":"","url":"https://api.github.com/users/ThumbWorks","html_url":"https://github.com/ThumbWorks","followers_url":"https://api.github.com/users/ThumbWorks/followers","following_url":"https://api.github.com/users/ThumbWorks/following{/other_user}","gists_url":"https://api.github.com/users/ThumbWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/ThumbWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThumbWorks/subscriptions","organizations_url":"https://api.github.com/users/ThumbWorks/orgs","repos_url":"https://api.github.com/users/ThumbWorks/repos","events_url":"https://api.github.com/users/ThumbWorks/events{/privacy}","received_events_url":"https://api.github.com/users/ThumbWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":137294402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyOTQ0MDI=","name":"IceCream","full_name":"ThumbWorks/IceCream","owner":{"login":"ThumbWorks","id":10676374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc2Mzc0","avatar_url":"https://avatars3.githubusercontent.com/u/10676374?v=4","gravatar_id":"","url":"https://api.github.com/users/ThumbWorks","html_url":"https://github.com/ThumbWorks","followers_url":"https://api.github.com/users/ThumbWorks/followers","following_url":"https://api.github.com/users/ThumbWorks/following{/other_user}","gists_url":"https://api.github.com/users/ThumbWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/ThumbWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThumbWorks/subscriptions","organizations_url":"https://api.github.com/users/ThumbWorks/orgs","repos_url":"https://api.github.com/users/ThumbWorks/repos","events_url":"https://api.github.com/users/ThumbWorks/events{/privacy}","received_events_url":"https://api.github.com/users/ThumbWorks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ThumbWorks/IceCream","description":"Sync Realm Database with CloudKit","fork":true,"url":"https://api.github.com/repos/ThumbWorks/IceCream","forks_url":"https://api.github.com/repos/ThumbWorks/IceCream/forks","keys_url":"https://api.github.com/repos/ThumbWorks/IceCream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThumbWorks/IceCream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThumbWorks/IceCream/teams","hooks_url":"https://api.github.com/repos/ThumbWorks/IceCream/hooks","issue_events_url":"https://api.github.com/repos/ThumbWorks/IceCream/issues/events{/number}","events_url":"https://api.github.com/repos/ThumbWorks/IceCream/events","assignees_url":"https://api.github.com/repos/ThumbWorks/IceCream/assignees{/user}","branches_url":"https://api.github.com/repos/ThumbWorks/IceCream/branches{/branch}","tags_url":"https://api.github.com/repos/ThumbWorks/IceCream/tags","blobs_url":"https://api.github.com/repos/ThumbWorks/IceCream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThumbWorks/IceCream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThumbWorks/IceCream/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThumbWorks/IceCream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThumbWorks/IceCream/statuses/{sha}","languages_url":"https://api.github.com/repos/ThumbWorks/IceCream/languages","stargazers_url":"https://api.github.com/repos/ThumbWorks/IceCream/stargazers","contributors_url":"https://api.github.com/repos/ThumbWorks/IceCream/contributors","subscribers_url":"https://api.github.com/repos/ThumbWorks/IceCream/subscribers","subscription_url":"https://api.github.com/repos/ThumbWorks/IceCream/subscription","commits_url":"https://api.github.com/repos/ThumbWorks/IceCream/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThumbWorks/IceCream/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThumbWorks/IceCream/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThumbWorks/IceCream/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThumbWorks/IceCream/contents/{+path}","compare_url":"https://api.github.com/repos/ThumbWorks/IceCream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThumbWorks/IceCream/merges","archive_url":"https://api.github.com/repos/ThumbWorks/IceCream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThumbWorks/IceCream/downloads","issues_url":"https://api.github.com/repos/ThumbWorks/IceCream/issues{/number}","pulls_url":"https://api.github.com/repos/ThumbWorks/IceCream/pulls{/number}","milestones_url":"https://api.github.com/repos/ThumbWorks/IceCream/milestones{/number}","notifications_url":"https://api.github.com/repos/ThumbWorks/IceCream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThumbWorks/IceCream/labels{/name}","releases_url":"https://api.github.com/repos/ThumbWorks/IceCream/releases{/id}","deployments_url":"https://api.github.com/repos/ThumbWorks/IceCream/deployments","created_at":"2018-06-14T02:13:07Z","updated_at":"2018-07-12T18:02:45Z","pushed_at":"2018-08-14T18:13:30Z","git_url":"git://github.com/ThumbWorks/IceCream.git","ssh_url":"git@github.com:ThumbWorks/IceCream.git","clone_url":"https://github.com/ThumbWorks/IceCream.git","svn_url":"https://github.com/ThumbWorks/IceCream","homepage":"","size":363,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caiyue1993:master","ref":"master","sha":"7ffbb884ccb5cfb2a3321e837d8c1b23f602db6a","user":{"login":"caiyue1993","id":6007760,"node_id":"MDQ6VXNlcjYwMDc3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6007760?v=4","gravatar_id":"","url":"https://api.github.com/users/caiyue1993","html_url":"https://github.com/caiyue1993","followers_url":"https://api.github.com/users/caiyue1993/followers","following_url":"https://api.github.com/users/caiyue1993/following{/other_user}","gists_url":"https://api.github.com/users/caiyue1993/gists{/gist_id}","starred_url":"https://api.github.com/users/caiyue1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiyue1993/subscriptions","organizations_url":"https://api.github.com/users/caiyue1993/orgs","repos_url":"https://api.github.com/users/caiyue1993/repos","events_url":"https://api.github.com/users/caiyue1993/events{/privacy}","received_events_url":"https://api.github.com/users/caiyue1993/received_events","type":"User","site_admin":false},"repo":{"id":107280628,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyODA2Mjg=","name":"IceCream","full_name":"caiyue1993/IceCream","owner":{"login":"caiyue1993","id":6007760,"node_id":"MDQ6VXNlcjYwMDc3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6007760?v=4","gravatar_id":"","url":"https://api.github.com/users/caiyue1993","html_url":"https://github.com/caiyue1993","followers_url":"https://api.github.com/users/caiyue1993/followers","following_url":"https://api.github.com/users/caiyue1993/following{/other_user}","gists_url":"https://api.github.com/users/caiyue1993/gists{/gist_id}","starred_url":"https://api.github.com/users/caiyue1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caiyue1993/subscriptions","organizations_url":"https://api.github.com/users/caiyue1993/orgs","repos_url":"https://api.github.com/users/caiyue1993/repos","events_url":"https://api.github.com/users/caiyue1993/events{/privacy}","received_events_url":"https://api.github.com/users/caiyue1993/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caiyue1993/IceCream","description":"Sync Realm Database with CloudKit","fork":false,"url":"https://api.github.com/repos/caiyue1993/IceCream","forks_url":"https://api.github.com/repos/caiyue1993/IceCream/forks","keys_url":"https://api.github.com/repos/caiyue1993/IceCream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caiyue1993/IceCream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caiyue1993/IceCream/teams","hooks_url":"https://api.github.com/repos/caiyue1993/IceCream/hooks","issue_events_url":"https://api.github.com/repos/caiyue1993/IceCream/issues/events{/number}","events_url":"https://api.github.com/repos/caiyue1993/IceCream/events","assignees_url":"https://api.github.com/repos/caiyue1993/IceCream/assignees{/user}","branches_url":"https://api.github.com/repos/caiyue1993/IceCream/branches{/branch}","tags_url":"https://api.github.com/repos/caiyue1993/IceCream/tags","blobs_url":"https://api.github.com/repos/caiyue1993/IceCream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caiyue1993/IceCream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caiyue1993/IceCream/git/refs{/sha}","trees_url":"https://api.github.com/repos/caiyue1993/IceCream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caiyue1993/IceCream/statuses/{sha}","languages_url":"https://api.github.com/repos/caiyue1993/IceCream/languages","stargazers_url":"https://api.github.com/repos/caiyue1993/IceCream/stargazers","contributors_url":"https://api.github.com/repos/caiyue1993/IceCream/contributors","subscribers_url":"https://api.github.com/repos/caiyue1993/IceCream/subscribers","subscription_url":"https://api.github.com/repos/caiyue1993/IceCream/subscription","commits_url":"https://api.github.com/repos/caiyue1993/IceCream/commits{/sha}","git_commits_url":"https://api.github.com/repos/caiyue1993/IceCream/git/commits{/sha}","comments_url":"https://api.github.com/repos/caiyue1993/IceCream/comments{/number}","issue_comment_url":"https://api.github.com/repos/caiyue1993/IceCream/issues/comments{/number}","contents_url":"https://api.github.com/repos/caiyue1993/IceCream/contents/{+path}","compare_url":"https://api.github.com/repos/caiyue1993/IceCream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caiyue1993/IceCream/merges","archive_url":"https://api.github.com/repos/caiyue1993/IceCream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caiyue1993/IceCream/downloads","issues_url":"https://api.github.com/repos/caiyue1993/IceCream/issues{/number}","pulls_url":"https://api.github.com/repos/caiyue1993/IceCream/pulls{/number}","milestones_url":"https://api.github.com/repos/caiyue1993/IceCream/milestones{/number}","notifications_url":"https://api.github.com/repos/caiyue1993/IceCream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caiyue1993/IceCream/labels{/name}","releases_url":"https://api.github.com/repos/caiyue1993/IceCream/releases{/id}","deployments_url":"https://api.github.com/repos/caiyue1993/IceCream/deployments","created_at":"2017-10-17T14:33:33Z","updated_at":"2018-08-14T03:59:02Z","pushed_at":"2018-08-14T18:13:46Z","git_url":"git://github.com/caiyue1993/IceCream.git","ssh_url":"git@github.com:caiyue1993/IceCream.git","clone_url":"https://github.com/caiyue1993/IceCream.git","svn_url":"https://github.com/caiyue1993/IceCream","homepage":"","size":387,"stargazers_count":961,"watchers_count":961,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":65,"open_issues":9,"watchers":961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73"},"html":{"href":"https://github.com/caiyue1993/IceCream/pull/73"},"issue":{"href":"https://api.github.com/repos/caiyue1993/IceCream/issues/73"},"comments":{"href":"https://api.github.com/repos/caiyue1993/IceCream/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/caiyue1993/IceCream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caiyue1993/IceCream/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/caiyue1993/IceCream/statuses/3ea5d8b427288a2e1221be50c8d107aa9e4cb14d"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":198,"deletions":97,"changed_files":8}}
{"actor":{"display_login":"rodericj"}}