{"action":"created","comment":{"url":"https://api.github.com/repos/sensu/sensu-go/pulls/comments/175643706","pull_request_review_id":105205422,"id":175643706,"diff_hunk":"@@ -1,41 +1,92 @@\n package messaging\n \n-import \"sync\"\n+import (\n+\t\"context\"\n+\t\"errors\"\n+\t\"strconv\"\n+\t\"sync\"\n+\n+\t\"github.com/sensu/sensu-go/types\"\n+)\n \n // WizardTopic encapsulates state around a WizardBus topic and its\n // consumer channel bindings.\n type WizardTopic struct {\n+\tID       string","path":"backend/messaging/wizard_topic.go","position":16,"original_position":16,"commit_id":"330f845b4fbccf31d74f88221519507dcc6e24cb","original_commit_id":"330f845b4fbccf31d74f88221519507dcc6e24cb","user":{"login":"echlebek","id":1633772,"avatar_url":"https://avatars0.githubusercontent.com/u/1633772?v=4","gravatar_id":"","url":"https://api.github.com/users/echlebek","html_url":"https://github.com/echlebek","followers_url":"https://api.github.com/users/echlebek/followers","following_url":"https://api.github.com/users/echlebek/following{/other_user}","gists_url":"https://api.github.com/users/echlebek/gists{/gist_id}","starred_url":"https://api.github.com/users/echlebek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echlebek/subscriptions","organizations_url":"https://api.github.com/users/echlebek/orgs","repos_url":"https://api.github.com/users/echlebek/repos","events_url":"https://api.github.com/users/echlebek/events{/privacy}","received_events_url":"https://api.github.com/users/echlebek/received_events","type":"User","site_admin":false},"body":"ID, Bindings and Ring are all implementation details and shouldn't be exported.","created_at":"2018-03-20T03:00:18Z","updated_at":"2018-03-20T03:10:21Z","html_url":"https://github.com/sensu/sensu-go/pull/1190#discussion_r175643706","pull_request_url":"https://api.github.com/repos/sensu/sensu-go/pulls/1190","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/comments/175643706"},"html":{"href":"https://github.com/sensu/sensu-go/pull/1190#discussion_r175643706"},"pull_request":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/1190"}}},"pull_request":{"url":"https://api.github.com/repos/sensu/sensu-go/pulls/1190","id":176072934,"html_url":"https://github.com/sensu/sensu-go/pull/1190","diff_url":"https://github.com/sensu/sensu-go/pull/1190.diff","patch_url":"https://github.com/sensu/sensu-go/pull/1190.patch","issue_url":"https://api.github.com/repos/sensu/sensu-go/issues/1190","number":1190,"state":"open","locked":false,"title":"Rework WizardBus Subscribe() method to remove subscriber ID","user":{"login":"grepory","id":356446,"avatar_url":"https://avatars1.githubusercontent.com/u/356446?v=4","gravatar_id":"","url":"https://api.github.com/users/grepory","html_url":"https://github.com/grepory","followers_url":"https://api.github.com/users/grepory/followers","following_url":"https://api.github.com/users/grepory/following{/other_user}","gists_url":"https://api.github.com/users/grepory/gists{/gist_id}","starred_url":"https://api.github.com/users/grepory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grepory/subscriptions","organizations_url":"https://api.github.com/users/grepory/orgs","repos_url":"https://api.github.com/users/grepory/repos","events_url":"https://api.github.com/users/grepory/events{/privacy}","received_events_url":"https://api.github.com/users/grepory/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Greg Poirier <greg.istehbest@gmail.com>\r\n\r\n## What is this change?\r\n\r\nRemoves the concept of subscriber IDs from the message bus, and instead Subscribe takes a Subscriber and returns a Subscription (which can be later cancelled).\r\n\r\n\r\n## Why is this change necessary?\r\n\r\nThis fixes #1097. Rather than simply prolonging the life of user-supplied subscriber IDs, we decided to tackle this bit of tech debt now.\r\n\r\n## Does your change need a Changelog entry?\r\n\r\nAdded.\r\n","created_at":"2018-03-20T02:21:55Z","updated_at":"2018-03-20T03:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40bfac87119324be04e497dcacff73938adb1ffc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"portertech","id":149630,"avatar_url":"https://avatars2.githubusercontent.com/u/149630?v=4","gravatar_id":"","url":"https://api.github.com/users/portertech","html_url":"https://github.com/portertech","followers_url":"https://api.github.com/users/portertech/followers","following_url":"https://api.github.com/users/portertech/following{/other_user}","gists_url":"https://api.github.com/users/portertech/gists{/gist_id}","starred_url":"https://api.github.com/users/portertech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portertech/subscriptions","organizations_url":"https://api.github.com/users/portertech/orgs","repos_url":"https://api.github.com/users/portertech/repos","events_url":"https://api.github.com/users/portertech/events{/privacy}","received_events_url":"https://api.github.com/users/portertech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":658326752,"url":"https://api.github.com/repos/sensu/sensu-go/labels/ready-for-review","name":"ready-for-review","color":"ff8800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sensu/sensu-go/pulls/1190/commits","review_comments_url":"https://api.github.com/repos/sensu/sensu-go/pulls/1190/comments","review_comment_url":"https://api.github.com/repos/sensu/sensu-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensu/sensu-go/issues/1190/comments","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/330f845b4fbccf31d74f88221519507dcc6e24cb","head":{"label":"sensu:bugfix/subscriptions","ref":"bugfix/subscriptions","sha":"330f845b4fbccf31d74f88221519507dcc6e24cb","user":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":82981995,"name":"sensu-go","full_name":"sensu/sensu-go","owner":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-go","description":"The next generation of the Sensu you know and love. We'd love having you involved ❤","fork":false,"url":"https://api.github.com/repos/sensu/sensu-go","forks_url":"https://api.github.com/repos/sensu/sensu-go/forks","keys_url":"https://api.github.com/repos/sensu/sensu-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-go/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-go/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-go/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-go/events","assignees_url":"https://api.github.com/repos/sensu/sensu-go/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-go/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-go/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-go/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-go/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-go/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-go/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-go/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-go/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-go/merges","archive_url":"https://api.github.com/repos/sensu/sensu-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-go/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-go/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-go/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-go/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-go/deployments","created_at":"2017-02-23T23:38:08Z","updated_at":"2018-03-19T23:15:49Z","pushed_at":"2018-03-20T02:44:45Z","git_url":"git://github.com/sensu/sensu-go.git","ssh_url":"git@github.com:sensu/sensu-go.git","clone_url":"https://github.com/sensu/sensu-go.git","svn_url":"https://github.com/sensu/sensu-go","homepage":"","size":29090,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":12,"open_issues":156,"watchers":110,"default_branch":"master"}},"base":{"label":"sensu:master","ref":"master","sha":"e004fa108177b4ef08898ab7941fcdde5affffa7","user":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":82981995,"name":"sensu-go","full_name":"sensu/sensu-go","owner":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-go","description":"The next generation of the Sensu you know and love. We'd love having you involved ❤","fork":false,"url":"https://api.github.com/repos/sensu/sensu-go","forks_url":"https://api.github.com/repos/sensu/sensu-go/forks","keys_url":"https://api.github.com/repos/sensu/sensu-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-go/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-go/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-go/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-go/events","assignees_url":"https://api.github.com/repos/sensu/sensu-go/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-go/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-go/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-go/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-go/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-go/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-go/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-go/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-go/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-go/merges","archive_url":"https://api.github.com/repos/sensu/sensu-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-go/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-go/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-go/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-go/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-go/deployments","created_at":"2017-02-23T23:38:08Z","updated_at":"2018-03-19T23:15:49Z","pushed_at":"2018-03-20T02:44:45Z","git_url":"git://github.com/sensu/sensu-go.git","ssh_url":"git@github.com:sensu/sensu-go.git","clone_url":"https://github.com/sensu/sensu-go.git","svn_url":"https://github.com/sensu/sensu-go","homepage":"","size":29090,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":12,"open_issues":156,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/1190"},"html":{"href":"https://github.com/sensu/sensu-go/pull/1190"},"issue":{"href":"https://api.github.com/repos/sensu/sensu-go/issues/1190"},"comments":{"href":"https://api.github.com/repos/sensu/sensu-go/issues/1190/comments"},"review_comments":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/1190/comments"},"review_comment":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/1190/commits"},"statuses":{"href":"https://api.github.com/repos/sensu/sensu-go/statuses/330f845b4fbccf31d74f88221519507dcc6e24cb"}},"author_association":"OWNER"}}
{"actor":{"display_login":"echlebek"}}