{"action":"opened","number":5554,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/5554","id":206011585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDExNTg1","html_url":"https://github.com/emberjs/data/pull/5554","diff_url":"https://github.com/emberjs/data/pull/5554.diff","patch_url":"https://github.com/emberjs/data/pull/5554.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/5554","number":5554,"state":"open","locked":false,"title":"[BUGFIX] Destroy proxy object in BelongsTo relation when no longer needed.","user":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"body":"The `_promiseProxy` object that is used by the belongsTo relationship is not destroyed when no longer needed.\r\n\r\nThis `_promiseProxy` keeps a reference to the internalModel. This especially a problem if the record is deleted while the other side of the relationship is still alive.\r\n\r\nThis results for us in a large memory leak: our application has a small set of long living records and during the lifetime it receives a large number of records (those records will be deleted after a while) that has a belongsTo reference to the records in the first set.\r\n\r\nThere is also a memory leak when proxies are destroyed when the proxied object is still alive. (reported as a separate issue in ember.js)","created_at":"2018-08-03T12:10:24Z","updated_at":"2018-08-03T12:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/5554/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/5554/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/5554/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/5d6316ee5ae360a53109cf010d55d47f93423a98","head":{"label":"pieter-v:relation-leak","ref":"relation-leak","sha":"5d6316ee5ae360a53109cf010d55d47f93423a98","user":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"repo":{"id":143395556,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzOTU1NTY=","name":"data","full_name":"pieter-v/data","owner":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pieter-v/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/pieter-v/data","forks_url":"https://api.github.com/repos/pieter-v/data/forks","keys_url":"https://api.github.com/repos/pieter-v/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pieter-v/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pieter-v/data/teams","hooks_url":"https://api.github.com/repos/pieter-v/data/hooks","issue_events_url":"https://api.github.com/repos/pieter-v/data/issues/events{/number}","events_url":"https://api.github.com/repos/pieter-v/data/events","assignees_url":"https://api.github.com/repos/pieter-v/data/assignees{/user}","branches_url":"https://api.github.com/repos/pieter-v/data/branches{/branch}","tags_url":"https://api.github.com/repos/pieter-v/data/tags","blobs_url":"https://api.github.com/repos/pieter-v/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pieter-v/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pieter-v/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/pieter-v/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pieter-v/data/statuses/{sha}","languages_url":"https://api.github.com/repos/pieter-v/data/languages","stargazers_url":"https://api.github.com/repos/pieter-v/data/stargazers","contributors_url":"https://api.github.com/repos/pieter-v/data/contributors","subscribers_url":"https://api.github.com/repos/pieter-v/data/subscribers","subscription_url":"https://api.github.com/repos/pieter-v/data/subscription","commits_url":"https://api.github.com/repos/pieter-v/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/pieter-v/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/pieter-v/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/pieter-v/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/pieter-v/data/contents/{+path}","compare_url":"https://api.github.com/repos/pieter-v/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pieter-v/data/merges","archive_url":"https://api.github.com/repos/pieter-v/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pieter-v/data/downloads","issues_url":"https://api.github.com/repos/pieter-v/data/issues{/number}","pulls_url":"https://api.github.com/repos/pieter-v/data/pulls{/number}","milestones_url":"https://api.github.com/repos/pieter-v/data/milestones{/number}","notifications_url":"https://api.github.com/repos/pieter-v/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pieter-v/data/labels{/name}","releases_url":"https://api.github.com/repos/pieter-v/data/releases{/id}","deployments_url":"https://api.github.com/repos/pieter-v/data/deployments","created_at":"2018-08-03T07:45:53Z","updated_at":"2018-08-03T07:45:56Z","pushed_at":"2018-08-03T11:58:54Z","git_url":"git://github.com/pieter-v/data.git","ssh_url":"git@github.com:pieter-v/data.git","clone_url":"https://github.com/pieter-v/data.git","svn_url":"https://github.com/pieter-v/data","homepage":"","size":15979,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"1abc3bb38ddba37d68b4cf9c14f4486628746d89","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"node_id":"MDEwOlJlcG9zaXRvcnkzMDE2NTYy","name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2018-07-31T21:58:12Z","pushed_at":"2018-08-02T08:12:20Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":15978,"stargazers_count":2885,"watchers_count":2885,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1218,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1218,"open_issues":154,"watchers":2885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/5554"},"html":{"href":"https://github.com/emberjs/data/pull/5554"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/5554"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/5554/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/5554/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/5554/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/5d6316ee5ae360a53109cf010d55d47f93423a98"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"pieter-v"}}