{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/14736","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/14736/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14736/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/14736/events","html_url":"https://github.com/xbmc/xbmc/pull/14736","id":374884908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDU4MDEy","number":14736,"title":"[pvr][guilib] Add new API HasArchive for ListItem","user":{"login":"arthur-liberman","id":502466,"node_id":"MDQ6VXNlcjUwMjQ2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/502466?v=4","gravatar_id":"","url":"https://api.github.com/users/arthur-liberman","html_url":"https://github.com/arthur-liberman","followers_url":"https://api.github.com/users/arthur-liberman/followers","following_url":"https://api.github.com/users/arthur-liberman/following{/other_user}","gists_url":"https://api.github.com/users/arthur-liberman/gists{/gist_id}","starred_url":"https://api.github.com/users/arthur-liberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthur-liberman/subscriptions","organizations_url":"https://api.github.com/users/arthur-liberman/orgs","repos_url":"https://api.github.com/users/arthur-liberman/repos","events_url":"https://api.github.com/users/arthur-liberman/events{/privacy}","received_events_url":"https://api.github.com/users/arthur-liberman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-29T07:11:20Z","updated_at":"2018-10-29T07:54:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14736","html_url":"https://github.com/xbmc/xbmc/pull/14736","diff_url":"https://github.com/xbmc/xbmc/pull/14736.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14736.patch"},"body":"## Description\r\nThis PR adds a new API for ListItem. The skin can now query the channel or the program in the EPG whether it can be \"Played from EPG tag\" or not (introduced in 21900fd). \r\nI'm not sure about the naming used as \"archive\", and if you can think of a better naming scheme for this I'm all for it.\r\n\r\n## Motivation and Context\r\nIn some cases this functionality is not supported on all available channels, and it is very useful to have a visual indication of whether a channel/program supports it or not. \r\n\r\n## Screenshots (if appropriate):\r\n![image](https://user-images.githubusercontent.com/502466/47634313-cb0d0300-db59-11e8-886c-673ab2effbad.png)\r\n![image](https://user-images.githubusercontent.com/502466/47634319-d3653e00-db59-11e8-8a77-b78b148369c3.png)\r\n\r\n## Types of change\r\n\r\n- [ ] **Bug fix** (non-breaking change which fixes an issue)\r\n- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)\r\n- [x] **Improvement** (non-breaking change which improves existing functionality)\r\n- [x] **New feature** (non-breaking change which adds functionality)\r\n- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)\r\n- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)\r\n- [ ] **None of the above** (please explain below)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `X` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project \r\n- [x] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/433817624","html_url":"https://github.com/xbmc/xbmc/pull/14736#issuecomment-433817624","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14736","id":433817624,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzgxNzYyNA==","user":{"login":"ksooo","id":3226626,"node_id":"MDQ6VXNlcjMyMjY2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3226626?v=4","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T07:54:21Z","updated_at":"2018-10-29T07:54:21Z","author_association":"MEMBER","body":"Tusks for this nice contribution.\r\n\r\nFirst, as this PR includes  PVR add-on API, JSON API and database version bumps it can't make it into v18, sorry. We're nearing RC phase and incompatible API changes are not possible at this stage. So, this one is for v19.\r\n\r\nCode looks pretty much okay, I will do a review later.\r\n\r\nI'm also uncertain about the wording - we can figure this out later.\r\n\r\nQuestions:\r\n- can channels without EPG have \"archive\" support? \r\n- which pvr add-on did you extend to test your charges / make the screen shots? Show me the code, please.\r\n- the green dots on the epg grid - this is \"ListItem.IsPlayable \", right? "}}
{"actor":{"display_login":"ksooo"}}