{"action":"closed","number":1153,"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153","id":204794947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Nzk0OTQ3","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1153","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1153.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1153.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1153","number":1153,"state":"closed","locked":false,"title":"Remove winrt support and add UAP support","user":{"login":"bgavrilMS","id":12273384,"node_id":"MDQ6VXNlcjEyMjczMzg0","avatar_url":"https://avatars1.githubusercontent.com/u/12273384?v=4","gravatar_id":"","url":"https://api.github.com/users/bgavrilMS","html_url":"https://github.com/bgavrilMS","followers_url":"https://api.github.com/users/bgavrilMS/followers","following_url":"https://api.github.com/users/bgavrilMS/following{/other_user}","gists_url":"https://api.github.com/users/bgavrilMS/gists{/gist_id}","starred_url":"https://api.github.com/users/bgavrilMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgavrilMS/subscriptions","organizations_url":"https://api.github.com/users/bgavrilMS/orgs","repos_url":"https://api.github.com/users/bgavrilMS/repos","events_url":"https://api.github.com/users/bgavrilMS/events{/privacy}","received_events_url":"https://api.github.com/users/bgavrilMS/received_events","type":"User","site_admin":false},"body":"The only logic change is related to the User / UserInformation API, which affects how ADAL deals with ClientCrendentials(), i.e. it tries to figure out the principal name of the current user (e.g. bogavril@microsoft.com) \r\n\r\nTested with: \r\n- MSA user (this fails as there is no principal name)\r\n- AD-joined machine  \r\n- AAD-joined machine\r\n- app without capabilities (this fails and the error message suggests which capabilities to add)\r\n\r\nFor reviewers: there are 2 commits, first one with the logic changes, second is less important and deals with dev app changes)\r\n\r\nNote about builds: \r\n\r\n- the builds will fail because they are still trying to build the old VS2015 artefacts\r\n- please don't merge this PR, I will do it and then immediately fix the builds (I have draft versions of the builds for this branch)","created_at":"2018-07-30T12:55:31Z","updated_at":"2018-08-01T07:18:43Z","closed_at":"2018-08-01T07:18:43Z","merged_at":null,"merge_commit_sha":"f12b82c345e9809b84145ada0f33a0b769220f1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rayluo","id":821550,"node_id":"MDQ6VXNlcjgyMTU1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/821550?v=4","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},{"login":"jmprieur","id":13203188,"node_id":"MDQ6VXNlcjEzMjAzMTg4","avatar_url":"https://avatars0.githubusercontent.com/u/13203188?v=4","gravatar_id":"","url":"https://api.github.com/users/jmprieur","html_url":"https://github.com/jmprieur","followers_url":"https://api.github.com/users/jmprieur/followers","following_url":"https://api.github.com/users/jmprieur/following{/other_user}","gists_url":"https://api.github.com/users/jmprieur/gists{/gist_id}","starred_url":"https://api.github.com/users/jmprieur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmprieur/subscriptions","organizations_url":"https://api.github.com/users/jmprieur/orgs","repos_url":"https://api.github.com/users/jmprieur/repos","events_url":"https://api.github.com/users/jmprieur/events{/privacy}","received_events_url":"https://api.github.com/users/jmprieur/received_events","type":"User","site_admin":false},{"login":"jennyf19","id":19942418,"node_id":"MDQ6VXNlcjE5OTQyNDE4","avatar_url":"https://avatars2.githubusercontent.com/u/19942418?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyf19","html_url":"https://github.com/jennyf19","followers_url":"https://api.github.com/users/jennyf19/followers","following_url":"https://api.github.com/users/jennyf19/following{/other_user}","gists_url":"https://api.github.com/users/jennyf19/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyf19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyf19/subscriptions","organizations_url":"https://api.github.com/users/jennyf19/orgs","repos_url":"https://api.github.com/users/jennyf19/repos","events_url":"https://api.github.com/users/jennyf19/events{/privacy}","received_events_url":"https://api.github.com/users/jennyf19/received_events","type":"User","site_admin":false},{"login":"trwalke","id":30090357,"node_id":"MDQ6VXNlcjMwMDkwMzU3","avatar_url":"https://avatars1.githubusercontent.com/u/30090357?v=4","gravatar_id":"","url":"https://api.github.com/users/trwalke","html_url":"https://github.com/trwalke","followers_url":"https://api.github.com/users/trwalke/followers","following_url":"https://api.github.com/users/trwalke/following{/other_user}","gists_url":"https://api.github.com/users/trwalke/gists{/gist_id}","starred_url":"https://api.github.com/users/trwalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trwalke/subscriptions","organizations_url":"https://api.github.com/users/trwalke/orgs","repos_url":"https://api.github.com/users/trwalke/repos","events_url":"https://api.github.com/users/trwalke/events{/privacy}","received_events_url":"https://api.github.com/users/trwalke/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1153/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/2ee6a20c74535bf46c11953b5204d6643f7830a1","head":{"label":"AzureAD:bogavril/winrt","ref":"bogavril/winrt","sha":"2ee6a20c74535bf46c11953b5204d6643f7830a1","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEyMzAzMQ==","name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":null,"fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-07-31T20:05:11Z","pushed_at":"2018-08-01T02:25:03Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":null,"size":11878,"stargazers_count":197,"watchers_count":197,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":166,"open_issues":53,"watchers":197,"default_branch":"dev"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"0f3b6f405ba113a23261974911173c7bd0835bd7","user":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19123031,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEyMzAzMQ==","name":"azure-activedirectory-library-for-dotnet","full_name":"AzureAD/azure-activedirectory-library-for-dotnet","owner":{"login":"AzureAD","id":2966316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjYzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2966316?v=4","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","description":null,"fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/deployments","created_at":"2014-04-24T20:29:51Z","updated_at":"2018-07-31T20:05:11Z","pushed_at":"2018-08-01T02:25:03Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-dotnet.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet","homepage":null,"size":11878,"stargazers_count":197,"watchers_count":197,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":166,"open_issues":53,"watchers":197,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1153"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1153"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1153/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1153/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/statuses/2ee6a20c74535bf46c11953b5204d6643f7830a1"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":16,"maintainer_can_modify":false,"commits":4,"additions":1336,"deletions":1172,"changed_files":76}}
{"actor":{"display_login":"bgavrilMS"}}