{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/readability/pulls/comments/212383687","pull_request_review_id":149004938,"id":212383687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM4MzY4Nw==","diff_hunk":"@@ -1198,62 +1198,66 @@ Readability.prototype = {\n     var values = {};\n     var metaElements = this._doc.getElementsByTagName(\"meta\");\n \n-    // Match \"description\", or Twitter's \"twitter:description\" (Cards)\n-    // in name attribute.\n-    var namePattern = /^\\s*((twitter)\\s*:\\s*)?(description|title)\\s*$/i;\n+    // property is a space-separated list of values\n+    var propertyPattern = /\\s*(dc|dcterm|og|twitter)\\s*:\\s*(author|creator|description|title)\\s*/gi;\n \n-    // Match Facebook's Open Graph title & description properties.\n-    var propertyPattern = /^\\s*og\\s*:\\s*(description|title)\\s*$/i;\n+    // name is a single value\n+    var namePattern = /^\\s*(?:(dc|dcterm|og|twitter)\\s*[\\.:]\\s*)?(author|creator|description|title)\\s*$/gi;","path":"Readability.js","position":13,"original_position":13,"commit_id":"5b1dabb1700510e9466e79ea0e03cc8542cbcb8d","original_commit_id":"5b1dabb1700510e9466e79ea0e03cc8542cbcb8d","user":{"login":"gijsk","id":375983,"node_id":"MDQ6VXNlcjM3NTk4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/375983?v=4","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"body":"That is, I can see you want the global modifier with `propertyPattern`, but not (in the current implementation) with `namePattern.","created_at":"2018-08-23T16:58:26Z","updated_at":"2018-08-23T16:58:26Z","html_url":"https://github.com/mozilla/readability/pull/478#discussion_r212383687","pull_request_url":"https://api.github.com/repos/mozilla/readability/pulls/478","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/readability/pulls/comments/212383687"},"html":{"href":"https://github.com/mozilla/readability/pull/478#discussion_r212383687"},"pull_request":{"href":"https://api.github.com/repos/mozilla/readability/pulls/478"}},"in_reply_to_id":212277245},"pull_request":{"url":"https://api.github.com/repos/mozilla/readability/pulls/478","id":206559603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTU5NjAz","html_url":"https://github.com/mozilla/readability/pull/478","diff_url":"https://github.com/mozilla/readability/pull/478.diff","patch_url":"https://github.com/mozilla/readability/pull/478.patch","issue_url":"https://api.github.com/repos/mozilla/readability/issues/478","number":478,"state":"open","locked":false,"title":"Improve metadata extraction","user":{"login":"da2x","id":1102886,"node_id":"MDQ6VXNlcjExMDI4ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1102886?v=4","gravatar_id":"","url":"https://api.github.com/users/da2x","html_url":"https://github.com/da2x","followers_url":"https://api.github.com/users/da2x/followers","following_url":"https://api.github.com/users/da2x/following{/other_user}","gists_url":"https://api.github.com/users/da2x/gists{/gist_id}","starred_url":"https://api.github.com/users/da2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2x/subscriptions","organizations_url":"https://api.github.com/users/da2x/orgs","repos_url":"https://api.github.com/users/da2x/repos","events_url":"https://api.github.com/users/da2x/events{/privacy}","received_events_url":"https://api.github.com/users/da2x/received_events","type":"User","site_admin":false},"body":"* Recognize meta[property] as a space-separated list.\r\n* Recognize Dublin Core (dc|dcterm): metadata.\r\n* Prefer Dublin Core, Open Graph, HTML5, and Twitter in that order.\r\n* _getArticleTitle() is now only used as fallback if document doesn't provide good metadata. This function has many localization issues and is “magical” in nature.\r\n* Check for matches in both name and property attributes (both OGP and Twitter have mixed these up in recommendations over the years).","created_at":"2018-08-07T01:56:18Z","updated_at":"2018-08-23T16:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"927fdd36cce11e5d1bb8b75cbd26930a70d9c6d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/readability/pulls/478/commits","review_comments_url":"https://api.github.com/repos/mozilla/readability/pulls/478/comments","review_comment_url":"https://api.github.com/repos/mozilla/readability/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/readability/issues/478/comments","statuses_url":"https://api.github.com/repos/mozilla/readability/statuses/5b1dabb1700510e9466e79ea0e03cc8542cbcb8d","head":{"label":"da2x:patch-1","ref":"patch-1","sha":"5b1dabb1700510e9466e79ea0e03cc8542cbcb8d","user":{"login":"da2x","id":1102886,"node_id":"MDQ6VXNlcjExMDI4ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1102886?v=4","gravatar_id":"","url":"https://api.github.com/users/da2x","html_url":"https://github.com/da2x","followers_url":"https://api.github.com/users/da2x/followers","following_url":"https://api.github.com/users/da2x/following{/other_user}","gists_url":"https://api.github.com/users/da2x/gists{/gist_id}","starred_url":"https://api.github.com/users/da2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2x/subscriptions","organizations_url":"https://api.github.com/users/da2x/orgs","repos_url":"https://api.github.com/users/da2x/repos","events_url":"https://api.github.com/users/da2x/events{/privacy}","received_events_url":"https://api.github.com/users/da2x/received_events","type":"User","site_admin":false},"repo":{"id":143802064,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4MDIwNjQ=","name":"readability","full_name":"da2x/readability","owner":{"login":"da2x","id":1102886,"node_id":"MDQ6VXNlcjExMDI4ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1102886?v=4","gravatar_id":"","url":"https://api.github.com/users/da2x","html_url":"https://github.com/da2x","followers_url":"https://api.github.com/users/da2x/followers","following_url":"https://api.github.com/users/da2x/following{/other_user}","gists_url":"https://api.github.com/users/da2x/gists{/gist_id}","starred_url":"https://api.github.com/users/da2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2x/subscriptions","organizations_url":"https://api.github.com/users/da2x/orgs","repos_url":"https://api.github.com/users/da2x/repos","events_url":"https://api.github.com/users/da2x/events{/privacy}","received_events_url":"https://api.github.com/users/da2x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/da2x/readability","description":"A standalone version of the readability lib","fork":true,"url":"https://api.github.com/repos/da2x/readability","forks_url":"https://api.github.com/repos/da2x/readability/forks","keys_url":"https://api.github.com/repos/da2x/readability/keys{/key_id}","collaborators_url":"https://api.github.com/repos/da2x/readability/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/da2x/readability/teams","hooks_url":"https://api.github.com/repos/da2x/readability/hooks","issue_events_url":"https://api.github.com/repos/da2x/readability/issues/events{/number}","events_url":"https://api.github.com/repos/da2x/readability/events","assignees_url":"https://api.github.com/repos/da2x/readability/assignees{/user}","branches_url":"https://api.github.com/repos/da2x/readability/branches{/branch}","tags_url":"https://api.github.com/repos/da2x/readability/tags","blobs_url":"https://api.github.com/repos/da2x/readability/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/da2x/readability/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/da2x/readability/git/refs{/sha}","trees_url":"https://api.github.com/repos/da2x/readability/git/trees{/sha}","statuses_url":"https://api.github.com/repos/da2x/readability/statuses/{sha}","languages_url":"https://api.github.com/repos/da2x/readability/languages","stargazers_url":"https://api.github.com/repos/da2x/readability/stargazers","contributors_url":"https://api.github.com/repos/da2x/readability/contributors","subscribers_url":"https://api.github.com/repos/da2x/readability/subscribers","subscription_url":"https://api.github.com/repos/da2x/readability/subscription","commits_url":"https://api.github.com/repos/da2x/readability/commits{/sha}","git_commits_url":"https://api.github.com/repos/da2x/readability/git/commits{/sha}","comments_url":"https://api.github.com/repos/da2x/readability/comments{/number}","issue_comment_url":"https://api.github.com/repos/da2x/readability/issues/comments{/number}","contents_url":"https://api.github.com/repos/da2x/readability/contents/{+path}","compare_url":"https://api.github.com/repos/da2x/readability/compare/{base}...{head}","merges_url":"https://api.github.com/repos/da2x/readability/merges","archive_url":"https://api.github.com/repos/da2x/readability/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/da2x/readability/downloads","issues_url":"https://api.github.com/repos/da2x/readability/issues{/number}","pulls_url":"https://api.github.com/repos/da2x/readability/pulls{/number}","milestones_url":"https://api.github.com/repos/da2x/readability/milestones{/number}","notifications_url":"https://api.github.com/repos/da2x/readability/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/da2x/readability/labels{/name}","releases_url":"https://api.github.com/repos/da2x/readability/releases{/id}","deployments_url":"https://api.github.com/repos/da2x/readability/deployments","created_at":"2018-08-07T01:24:08Z","updated_at":"2018-08-07T01:24:11Z","pushed_at":"2018-08-22T22:12:48Z","git_url":"git://github.com/da2x/readability.git","ssh_url":"git@github.com:da2x/readability.git","clone_url":"https://github.com/da2x/readability.git","svn_url":"https://github.com/da2x/readability","homepage":null,"size":4245,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"0449dbf186aef03274936a80d2dd116363a76885","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":30231828,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMTgyOA==","name":"readability","full_name":"mozilla/readability","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/readability","description":"A standalone version of the readability lib","fork":false,"url":"https://api.github.com/repos/mozilla/readability","forks_url":"https://api.github.com/repos/mozilla/readability/forks","keys_url":"https://api.github.com/repos/mozilla/readability/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/readability/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/readability/teams","hooks_url":"https://api.github.com/repos/mozilla/readability/hooks","issue_events_url":"https://api.github.com/repos/mozilla/readability/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/readability/events","assignees_url":"https://api.github.com/repos/mozilla/readability/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/readability/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/readability/tags","blobs_url":"https://api.github.com/repos/mozilla/readability/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/readability/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/readability/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/readability/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/readability/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/readability/languages","stargazers_url":"https://api.github.com/repos/mozilla/readability/stargazers","contributors_url":"https://api.github.com/repos/mozilla/readability/contributors","subscribers_url":"https://api.github.com/repos/mozilla/readability/subscribers","subscription_url":"https://api.github.com/repos/mozilla/readability/subscription","commits_url":"https://api.github.com/repos/mozilla/readability/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/readability/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/readability/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/readability/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/readability/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/readability/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/readability/merges","archive_url":"https://api.github.com/repos/mozilla/readability/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/readability/downloads","issues_url":"https://api.github.com/repos/mozilla/readability/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/readability/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/readability/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/readability/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/readability/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/readability/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/readability/deployments","created_at":"2015-02-03T08:01:54Z","updated_at":"2018-08-23T07:51:12Z","pushed_at":"2018-08-22T22:12:50Z","git_url":"git://github.com/mozilla/readability.git","ssh_url":"git@github.com:mozilla/readability.git","clone_url":"https://github.com/mozilla/readability.git","svn_url":"https://github.com/mozilla/readability","homepage":null,"size":4210,"stargazers_count":1406,"watchers_count":1406,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":149,"license":null,"forks":219,"open_issues":149,"watchers":1406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/readability/pulls/478"},"html":{"href":"https://github.com/mozilla/readability/pull/478"},"issue":{"href":"https://api.github.com/repos/mozilla/readability/issues/478"},"comments":{"href":"https://api.github.com/repos/mozilla/readability/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/readability/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/readability/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/readability/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/readability/statuses/5b1dabb1700510e9466e79ea0e03cc8542cbcb8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gijsk"}}