{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/223405776","pull_request_review_id":162524627,"id":223405776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQwNTc3Ng==","diff_hunk":"@@ -0,0 +1,78 @@\n+/*\n+ * Copyright 2018 Palantir Technologies, Inc. All rights reserved.\n+ *\n+ * Licensed under the BSD-3 License (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://opensource.org/licenses/BSD-3-Clause","path":"timelock-impl/src/main/java/com/palantir/atlasdb/timelock/transaction/timestamp/DelegatingClientAwareManagedTimestampService.java","position":8,"original_position":8,"commit_id":"2d547f56198641a28cb959079934a29878bbfaf8","original_commit_id":"2d547f56198641a28cb959079934a29878bbfaf8","user":{"login":"felixdesouza","id":4521225,"node_id":"MDQ6VXNlcjQ1MjEyMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4521225?v=4","gravatar_id":"","url":"https://api.github.com/users/felixdesouza","html_url":"https://github.com/felixdesouza","followers_url":"https://api.github.com/users/felixdesouza/followers","following_url":"https://api.github.com/users/felixdesouza/following{/other_user}","gists_url":"https://api.github.com/users/felixdesouza/gists{/gist_id}","starred_url":"https://api.github.com/users/felixdesouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixdesouza/subscriptions","organizations_url":"https://api.github.com/users/felixdesouza/orgs","repos_url":"https://api.github.com/users/felixdesouza/repos","events_url":"https://api.github.com/users/felixdesouza/events{/privacy}","received_events_url":"https://api.github.com/users/felixdesouza/received_events","type":"User","site_admin":false},"body":"- [ ] License","created_at":"2018-10-08T15:27:33Z","updated_at":"2018-10-08T15:27:58Z","html_url":"https://github.com/palantir/atlasdb/pull/3527#discussion_r223405776","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3527","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/223405776"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3527#discussion_r223405776"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3527"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3527","id":218666785,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjY2Nzg1","html_url":"https://github.com/palantir/atlasdb/pull/3527","diff_url":"https://github.com/palantir/atlasdb/pull/3527.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3527.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3527","number":3527,"state":"open","locked":false,"title":"_transactions2, Part 4: Client Aware Managed Timestamp Services","user":{"login":"jeremyk-91","id":5955510,"node_id":"MDQ6VXNlcjU5NTU1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5955510?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyk-91","html_url":"https://github.com/jeremyk-91","followers_url":"https://api.github.com/users/jeremyk-91/followers","following_url":"https://api.github.com/users/jeremyk-91/following{/other_user}","gists_url":"https://api.github.com/users/jeremyk-91/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyk-91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyk-91/subscriptions","organizations_url":"https://api.github.com/users/jeremyk-91/orgs","repos_url":"https://api.github.com/users/jeremyk-91/repos","events_url":"https://api.github.com/users/jeremyk-91/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyk-91/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**:\r\n- Have a version of the timestamp service interface that allows users to provide an ID; we'll do the right thing from then on (here, giving out timestamps with a stable residue modulo-16).\r\n\r\n**Implementation Description (bullets)**:\r\n- Implement `getFreshTimestampForClient`. This works by retrieving 16 timestamps from the timestamp service and then getting one that matches our residue according to a `NumericPartitionAllocator`.\r\n\r\n**Testing (What was existing testing like?  What have you done to improve it?)**:\r\n- This is new code, and it comes tested.\r\n\r\n**Concerns (what feedback would you like?)**:\r\n- Does it make sense to centralise the logic for deciding on how to advance the clock in timelock?\r\n- I made a decision that having the memorised information be destroyed at the time of a leader election is reasonable; is this the case?\r\n- We grab 16 timestamps at a shot and then find the one we want. There are ways to do this while being a bit less wasteful, but I thought this is fine as timestamps are longs.\r\n\r\n**Where should we start reviewing?**: `ClientAwareManagedTimestampService`\r\n\r\n**Priority (whenever / two weeks / yesterday)**: this week / early next\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/3527)\n<!-- Reviewable:end -->\n","created_at":"2018-09-27T14:08:27Z","updated_at":"2018-10-08T15:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c8526d83615f94ee7ab82b7de2c7ccaac73b3e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sandorw","id":8271534,"node_id":"MDQ6VXNlcjgyNzE1MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8271534?v=4","gravatar_id":"","url":"https://api.github.com/users/sandorw","html_url":"https://github.com/sandorw","followers_url":"https://api.github.com/users/sandorw/followers","following_url":"https://api.github.com/users/sandorw/following{/other_user}","gists_url":"https://api.github.com/users/sandorw/gists{/gist_id}","starred_url":"https://api.github.com/users/sandorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandorw/subscriptions","organizations_url":"https://api.github.com/users/sandorw/orgs","repos_url":"https://api.github.com/users/sandorw/repos","events_url":"https://api.github.com/users/sandorw/events{/privacy}","received_events_url":"https://api.github.com/users/sandorw/received_events","type":"User","site_admin":false},{"login":"gokcanozakdag","id":9950842,"node_id":"MDQ6VXNlcjk5NTA4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/9950842?v=4","gravatar_id":"","url":"https://api.github.com/users/gokcanozakdag","html_url":"https://github.com/gokcanozakdag","followers_url":"https://api.github.com/users/gokcanozakdag/followers","following_url":"https://api.github.com/users/gokcanozakdag/following{/other_user}","gists_url":"https://api.github.com/users/gokcanozakdag/gists{/gist_id}","starred_url":"https://api.github.com/users/gokcanozakdag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokcanozakdag/subscriptions","organizations_url":"https://api.github.com/users/gokcanozakdag/orgs","repos_url":"https://api.github.com/users/gokcanozakdag/repos","events_url":"https://api.github.com/users/gokcanozakdag/events{/privacy}","received_events_url":"https://api.github.com/users/gokcanozakdag/received_events","type":"User","site_admin":false},{"login":"tboam","id":24569178,"node_id":"MDQ6VXNlcjI0NTY5MTc4","avatar_url":"https://avatars1.githubusercontent.com/u/24569178?v=4","gravatar_id":"","url":"https://api.github.com/users/tboam","html_url":"https://github.com/tboam","followers_url":"https://api.github.com/users/tboam/followers","following_url":"https://api.github.com/users/tboam/following{/other_user}","gists_url":"https://api.github.com/users/tboam/gists{/gist_id}","starred_url":"https://api.github.com/users/tboam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboam/subscriptions","organizations_url":"https://api.github.com/users/tboam/orgs","repos_url":"https://api.github.com/users/tboam/repos","events_url":"https://api.github.com/users/tboam/events{/privacy}","received_events_url":"https://api.github.com/users/tboam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3527/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3527/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3527/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/2d547f56198641a28cb959079934a29878bbfaf8","head":{"label":"palantir:jkong/mft-2","ref":"jkong/mft-2","sha":"2d547f56198641a28cb959079934a29878bbfaf8","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","private":false,"owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-10-08T14:51:55Z","pushed_at":"2018-10-08T15:02:51Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":74936,"stargazers_count":634,"watchers_count":634,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":324,"watchers":634,"default_branch":"develop"}},"base":{"label":"palantir:jkong/mft-1","ref":"jkong/mft-1","sha":"b1e65bf0f508eeb81cb6815801954ba73018d75a","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","private":false,"owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-10-08T14:51:55Z","pushed_at":"2018-10-08T15:02:51Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":74936,"stargazers_count":634,"watchers_count":634,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":324,"watchers":634,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3527"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3527"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3527"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3527/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3527/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3527/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/2d547f56198641a28cb959079934a29878bbfaf8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"felixdesouza"}}