{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/220518210","pull_request_review_id":158941419,"id":220518210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDUxODIxMA==","diff_hunk":"@@ -571,22 +520,17 @@ public StatefulSet generateStatefulSet(boolean isOpenShift) {\n      * for signing brokers certificates used for communication with clients\n      * @return The generated Secret\n      */\n-    public Secret generateClientsCASecret() {\n-        Map<String, String> data = new HashMap<>();\n-        data.put(\"clients-ca.key\", clientsCA.keyAsBase64String());\n-        data.put(\"clients-ca.crt\", clientsCA.certAsBase64String());\n-        return createSecret(KafkaCluster.clientsCASecretName(cluster), data);\n+    public Secret generateClientsCASecret(ClientsCa clientsCa) {","path":"cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java","position":151,"original_position":151,"commit_id":"b3c0cc3cfc373aa509797f002f924e2f1b6ae0b8","original_commit_id":"b3c0cc3cfc373aa509797f002f924e2f1b6ae0b8","user":{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"body":"It doesn't actually _generate_ anything at this point either. I guess we should just inline these methods.","created_at":"2018-09-26T11:04:48Z","updated_at":"2018-09-26T11:04:48Z","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/842#discussion_r220518210","pull_request_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/220518210"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/842#discussion_r220518210"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842"}},"in_reply_to_id":220498910},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842","id":213968344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTY4MzQ0","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/842","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/842.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/842.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/842","number":842,"state":"open","locked":false,"title":"Cert renewal 2","user":{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n\r\n- Enhancement / new feature\r\n\r\n### Description\r\n\r\nThis PR factors out a `Certificates` class, which has the responsibility for managing the cluster certificates. It then uses this to ensure we regenerate the certificates signed with the cluster CA certificate when the latter gets renewed.\r\n\r\nA future PR will aim to reuse `Certificates` in the UO.\r\n\r\nThis PR still needs ST.\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Write tests\r\n- [ ] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n- [ ] Update CHANGELOG.md\r\n\r\n","created_at":"2018-09-07T15:44:15Z","updated_at":"2018-09-26T11:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abe1119942019e4416f54e9749ee2e6d6cb71da9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/842/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/b3c0cc3cfc373aa509797f002f924e2f1b6ae0b8","head":{"label":"strimzi:cert-renewal-2","ref":"cert-renewal-2","sha":"b3c0cc3cfc373aa509797f002f924e2f1b6ae0b8","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-09-26T08:39:59Z","pushed_at":"2018-09-26T10:39:59Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"git@github.com:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":15632,"stargazers_count":371,"watchers_count":371,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":81,"open_issues":112,"watchers":371,"default_branch":"master"}},"base":{"label":"strimzi:cert-renewal","ref":"cert-renewal","sha":"c8861b94def714e13ffc5ac895978b28a8089fb2","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-09-26T08:39:59Z","pushed_at":"2018-09-26T10:39:59Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"git@github.com:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":15632,"stargazers_count":371,"watchers_count":371,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":81,"open_issues":112,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/842"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/842"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/842/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/842/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/b3c0cc3cfc373aa509797f002f924e2f1b6ae0b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tombentley"}}