{"action":"created","issue":{"url":"https://api.github.com/repos/nerves-project/nerves_network/issues/41","repository_url":"https://api.github.com/repos/nerves-project/nerves_network","labels_url":"https://api.github.com/repos/nerves-project/nerves_network/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/nerves-project/nerves_network/issues/41/comments","events_url":"https://api.github.com/repos/nerves-project/nerves_network/issues/41/events","html_url":"https://github.com/nerves-project/nerves_network/issues/41","id":260132215,"number":41,"title":"`setup` API is too loose","user":{"login":"ConnorRigby","id":21150830,"avatar_url":"https://avatars3.githubusercontent.com/u/21150830?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorRigby","html_url":"https://github.com/ConnorRigby","followers_url":"https://api.github.com/users/ConnorRigby/followers","following_url":"https://api.github.com/users/ConnorRigby/following{/other_user}","gists_url":"https://api.github.com/users/ConnorRigby/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorRigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorRigby/subscriptions","organizations_url":"https://api.github.com/users/ConnorRigby/orgs","repos_url":"https://api.github.com/users/ConnorRigby/repos","events_url":"https://api.github.com/users/ConnorRigby/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorRigby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-25T01:27:05Z","updated_at":"2018-03-05T21:30:17Z","closed_at":null,"author_association":"MEMBER","body":"in ref to #17, #38 and by extension #40 i would like to start an official discussion of the `setup` api.\r\n\r\nI don't personally want to support both string and atom keys for things. And this is only one part of this particular issue. I would like to parse and confirm them before passing further down to be messed up anywhere. I think the `parse_settings` function @Hermanverschooten introduced is on the right track, but instead of coxing things into a proper shape, we should enforce the proper shape. I think the public api should raise ArgumentError's when options are not inputted correctly. "},"comment":{"url":"https://api.github.com/repos/nerves-project/nerves_network/issues/comments/370572792","html_url":"https://github.com/nerves-project/nerves_network/issues/41#issuecomment-370572792","issue_url":"https://api.github.com/repos/nerves-project/nerves_network/issues/41","id":370572792,"user":{"login":"ConnorRigby","id":21150830,"avatar_url":"https://avatars3.githubusercontent.com/u/21150830?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorRigby","html_url":"https://github.com/ConnorRigby","followers_url":"https://api.github.com/users/ConnorRigby/followers","following_url":"https://api.github.com/users/ConnorRigby/following{/other_user}","gists_url":"https://api.github.com/users/ConnorRigby/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorRigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorRigby/subscriptions","organizations_url":"https://api.github.com/users/ConnorRigby/orgs","repos_url":"https://api.github.com/users/ConnorRigby/repos","events_url":"https://api.github.com/users/ConnorRigby/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorRigby/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T21:30:17Z","updated_at":"2018-03-05T21:30:17Z","author_association":"MEMBER","body":"in 3.x releases, we are now logging an incompatible type for ifnames such as [here](https://github.com/nerves-project/nerves_network/blob/6a9bb7dab326e58d78edcb20f5afca40769dd4c3/lib/nerves_network/if_supervisor.ex#L19)\r\n\r\nNext `major` version update, we will be actually enforcing incompatible types."}}
{"actor":{"display_login":"ConnorRigby"}}