{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/casper/issues/138","repository_url":"https://api.github.com/repos/ethereum/casper","labels_url":"https://api.github.com/repos/ethereum/casper/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/casper/issues/138/comments","events_url":"https://api.github.com/repos/ethereum/casper/issues/138/events","html_url":"https://github.com/ethereum/casper/issues/138","id":322219220,"number":138,"title":"Move casper contract to use custom units?","user":{"login":"jacqueswww","id":6917456,"avatar_url":"https://avatars0.githubusercontent.com/u/6917456?v=4","gravatar_id":"","url":"https://api.github.com/users/jacqueswww","html_url":"https://github.com/jacqueswww","followers_url":"https://api.github.com/users/jacqueswww/followers","following_url":"https://api.github.com/users/jacqueswww/following{/other_user}","gists_url":"https://api.github.com/users/jacqueswww/gists{/gist_id}","starred_url":"https://api.github.com/users/jacqueswww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacqueswww/subscriptions","organizations_url":"https://api.github.com/users/jacqueswww/orgs","repos_url":"https://api.github.com/users/jacqueswww/repos","events_url":"https://api.github.com/users/jacqueswww/events{/privacy}","received_events_url":"https://api.github.com/users/jacqueswww/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-11T08:53:37Z","updated_at":"2018-05-13T06:13:10Z","closed_at":null,"author_association":"NONE","body":"Hi There!\r\n\r\nSo we recently introduced _custom units_ into vyper with [VIP 752](https://github.com/ethereum/vyper/issues/752). Quick example of usage https://vyper.readthedocs.io/en/latest/types.html#custom-unit-types.\r\n\r\nWhat I would like to probe - if there is perhaps reason we can remove some of the current static unit types from vyper completely.\r\n\r\n```\r\nm\r\ncurrency_value\r\ncurrency1_value\r\ncurrency2_value\r\n```\r\n\r\nI feel like these are quite opaque and will cause trouble for future users of vyper. Additionally because we force a description field on custom units, future users will be able to understand the units much better.\r\n\r\nWhat is everyone's thoughts on this?\r\nIf there is consensus in agreement with the above proposal, I will create a VIP to remove the not-obvious static units from vyper."},"comment":{"url":"https://api.github.com/repos/ethereum/casper/issues/comments/388604232","html_url":"https://github.com/ethereum/casper/issues/138#issuecomment-388604232","issue_url":"https://api.github.com/repos/ethereum/casper/issues/138","id":388604232,"user":{"login":"ChihChengLiang","id":3391420,"avatar_url":"https://avatars0.githubusercontent.com/u/3391420?v=4","gravatar_id":"","url":"https://api.github.com/users/ChihChengLiang","html_url":"https://github.com/ChihChengLiang","followers_url":"https://api.github.com/users/ChihChengLiang/followers","following_url":"https://api.github.com/users/ChihChengLiang/following{/other_user}","gists_url":"https://api.github.com/users/ChihChengLiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ChihChengLiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChihChengLiang/subscriptions","organizations_url":"https://api.github.com/users/ChihChengLiang/orgs","repos_url":"https://api.github.com/users/ChihChengLiang/repos","events_url":"https://api.github.com/users/ChihChengLiang/events{/privacy}","received_events_url":"https://api.github.com/users/ChihChengLiang/received_events","type":"User","site_admin":false},"created_at":"2018-05-13T06:13:09Z","updated_at":"2018-05-13T06:13:09Z","author_association":"CONTRIBUTOR","body":"ah thanks Danny. I support this too. all custom units and no built-ins."}}
{"actor":{"display_login":"ChihChengLiang"}}