{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/199449511","pull_request_review_id":133565632,"id":199449511,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQ0OTUxMQ==","diff_hunk":"@@ -156,6 +158,23 @@ static int cnl_ipc_is_ready(struct snd_sof_dev *sdev)\n \treturn 1;\n }\n \n+static int cnl_ipc_reply_done(struct snd_sof_dev *sdev)\n+{\n+\t/* clear DONE bit - tell DSP we have completed the operation */\n+\tsnd_sof_dsp_update_bits_forced(sdev, HDA_DSP_BAR,\n+\t\t\t\t       CNL_DSP_REG_HIPCIDA,\n+\t\t\t\t       CNL_DSP_REG_HIPCIDA_DONE,\n+\t\t\t\t       CNL_DSP_REG_HIPCIDA_DONE);\n+\n+\t/* unmask Done interrupt */\n+\tsnd_sof_dsp_update_bits(sdev, HDA_DSP_BAR,\n+\t\t\t\tCNL_DSP_REG_HIPCCTL,\n+\t\t\t\tCNL_DSP_REG_HIPCCTL_DONE,\n+\t\t\t\tCNL_DSP_REG_HIPCCTL_DONE);\n+\n+\treturn 0;","path":"sound/soc/sof/intel/cnl.c","position":69,"original_position":55,"commit_id":"ef4e812d79f2b2aed37cf60a3b4ef42d1d5c3bac","original_commit_id":"b3fa742270b76ed636a947bd17cd4a6abd2884f6","user":{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},"body":"This looks like the same flow in the irq thread.  If so, IRQ thread should call this directly.","created_at":"2018-07-02T10:15:47Z","updated_at":"2018-07-02T10:19:39Z","html_url":"https://github.com/thesofproject/linux/pull/13#discussion_r199449511","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/199449511"},"html":{"href":"https://github.com/thesofproject/linux/pull/13#discussion_r199449511"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/13","id":198598558,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTk4NTU4","html_url":"https://github.com/thesofproject/linux/pull/13","diff_url":"https://github.com/thesofproject/linux/pull/13.diff","patch_url":"https://github.com/thesofproject/linux/pull/13.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/13","number":13,"state":"open","locked":false,"title":"Fix IPC timeout issue on APL&CNL","user":{"login":"RanderWang","id":39945651,"node_id":"MDQ6VXNlcjM5OTQ1NjUx","avatar_url":"https://avatars2.githubusercontent.com/u/39945651?v=4","gravatar_id":"","url":"https://api.github.com/users/RanderWang","html_url":"https://github.com/RanderWang","followers_url":"https://api.github.com/users/RanderWang/followers","following_url":"https://api.github.com/users/RanderWang/following{/other_user}","gists_url":"https://api.github.com/users/RanderWang/gists{/gist_id}","starred_url":"https://api.github.com/users/RanderWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanderWang/subscriptions","organizations_url":"https://api.github.com/users/RanderWang/orgs","repos_url":"https://api.github.com/users/RanderWang/repos","events_url":"https://api.github.com/users/RanderWang/events{/privacy}","received_events_url":"https://api.github.com/users/RanderWang/received_events","type":"User","site_admin":false},"body":"DSP only processes one IPC msg at one time, so driver should do as it required. If two IPC msgs are sent to DSP at the same time, IPC timeout.  Now check is_dsp_ready at the IPC sent time to comply with the rule.\r\n\r\nAlso Refine the is_dsp_ready function, check both BUSY bit and DONE bit. To make sure the last IPC msg is not overwriten, DONE bit is set in reply_done function which is called at the end of msg processing function.","created_at":"2018-07-02T07:53:43Z","updated_at":"2018-07-02T10:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e6308e4575232795fea1498c8cf9b00be3c2e56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/13/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/13/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/13/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/ef4e812d79f2b2aed37cf60a3b4ef42d1d5c3bac","head":{"label":"RanderWang:sof-dev","ref":"sof-dev","sha":"ef4e812d79f2b2aed37cf60a3b4ef42d1d5c3bac","user":{"login":"RanderWang","id":39945651,"node_id":"MDQ6VXNlcjM5OTQ1NjUx","avatar_url":"https://avatars2.githubusercontent.com/u/39945651?v=4","gravatar_id":"","url":"https://api.github.com/users/RanderWang","html_url":"https://github.com/RanderWang","followers_url":"https://api.github.com/users/RanderWang/followers","following_url":"https://api.github.com/users/RanderWang/following{/other_user}","gists_url":"https://api.github.com/users/RanderWang/gists{/gist_id}","starred_url":"https://api.github.com/users/RanderWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanderWang/subscriptions","organizations_url":"https://api.github.com/users/RanderWang/orgs","repos_url":"https://api.github.com/users/RanderWang/repos","events_url":"https://api.github.com/users/RanderWang/events{/privacy}","received_events_url":"https://api.github.com/users/RanderWang/received_events","type":"User","site_admin":false},"repo":{"id":137188132,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxODgxMzI=","name":"linux","full_name":"RanderWang/linux","owner":{"login":"RanderWang","id":39945651,"node_id":"MDQ6VXNlcjM5OTQ1NjUx","avatar_url":"https://avatars2.githubusercontent.com/u/39945651?v=4","gravatar_id":"","url":"https://api.github.com/users/RanderWang","html_url":"https://github.com/RanderWang","followers_url":"https://api.github.com/users/RanderWang/followers","following_url":"https://api.github.com/users/RanderWang/following{/other_user}","gists_url":"https://api.github.com/users/RanderWang/gists{/gist_id}","starred_url":"https://api.github.com/users/RanderWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanderWang/subscriptions","organizations_url":"https://api.github.com/users/RanderWang/orgs","repos_url":"https://api.github.com/users/RanderWang/repos","events_url":"https://api.github.com/users/RanderWang/events{/privacy}","received_events_url":"https://api.github.com/users/RanderWang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RanderWang/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/RanderWang/linux","forks_url":"https://api.github.com/repos/RanderWang/linux/forks","keys_url":"https://api.github.com/repos/RanderWang/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RanderWang/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RanderWang/linux/teams","hooks_url":"https://api.github.com/repos/RanderWang/linux/hooks","issue_events_url":"https://api.github.com/repos/RanderWang/linux/issues/events{/number}","events_url":"https://api.github.com/repos/RanderWang/linux/events","assignees_url":"https://api.github.com/repos/RanderWang/linux/assignees{/user}","branches_url":"https://api.github.com/repos/RanderWang/linux/branches{/branch}","tags_url":"https://api.github.com/repos/RanderWang/linux/tags","blobs_url":"https://api.github.com/repos/RanderWang/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RanderWang/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RanderWang/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/RanderWang/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RanderWang/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/RanderWang/linux/languages","stargazers_url":"https://api.github.com/repos/RanderWang/linux/stargazers","contributors_url":"https://api.github.com/repos/RanderWang/linux/contributors","subscribers_url":"https://api.github.com/repos/RanderWang/linux/subscribers","subscription_url":"https://api.github.com/repos/RanderWang/linux/subscription","commits_url":"https://api.github.com/repos/RanderWang/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/RanderWang/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/RanderWang/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/RanderWang/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/RanderWang/linux/contents/{+path}","compare_url":"https://api.github.com/repos/RanderWang/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RanderWang/linux/merges","archive_url":"https://api.github.com/repos/RanderWang/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RanderWang/linux/downloads","issues_url":"https://api.github.com/repos/RanderWang/linux/issues{/number}","pulls_url":"https://api.github.com/repos/RanderWang/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/RanderWang/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/RanderWang/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RanderWang/linux/labels{/name}","releases_url":"https://api.github.com/repos/RanderWang/linux/releases{/id}","deployments_url":"https://api.github.com/repos/RanderWang/linux/deployments","created_at":"2018-06-13T08:45:09Z","updated_at":"2018-06-28T03:09:20Z","pushed_at":"2018-07-02T07:39:54Z","git_url":"git://github.com/RanderWang/linux.git","ssh_url":"git@github.com:RanderWang/linux.git","clone_url":"https://github.com/RanderWang/linux.git","svn_url":"https://github.com/RanderWang/linux","homepage":"","size":2168046,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"topic/sof-dev"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"cb05347d9f85e18b414098d512c8287c297933d2","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2018-06-26T15:01:28Z","pushed_at":"2018-07-02T07:53:44Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"git@github.com:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":2172639,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":6,"watchers":0,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/13"},"html":{"href":"https://github.com/thesofproject/linux/pull/13"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/13"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/ef4e812d79f2b2aed37cf60a3b4ef42d1d5c3bac"}},"author_association":"NONE"}}
{"actor":{"display_login":"lgirdwood"}}