{"action":"opened","number":1393,"pull_request":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/1393","id":215250327,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjUwMzI3","html_url":"https://github.com/openMVG/openMVG/pull/1393","diff_url":"https://github.com/openMVG/openMVG/pull/1393.diff","patch_url":"https://github.com/openMVG/openMVG/pull/1393.patch","issue_url":"https://api.github.com/repos/openMVG/openMVG/issues/1393","number":1393,"state":"open","locked":false,"title":"remove two non consistent squares","user":{"login":"rjanvier","id":1537100,"node_id":"MDQ6VXNlcjE1MzcxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1537100?v=4","gravatar_id":"","url":"https://api.github.com/users/rjanvier","html_url":"https://github.com/rjanvier","followers_url":"https://api.github.com/users/rjanvier/followers","following_url":"https://api.github.com/users/rjanvier/following{/other_user}","gists_url":"https://api.github.com/users/rjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/rjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjanvier/subscriptions","organizations_url":"https://api.github.com/users/rjanvier/orgs","repos_url":"https://api.github.com/users/rjanvier/repos","events_url":"https://api.github.com/users/rjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/rjanvier/received_events","type":"User","site_admin":false},"body":"I believe these thresholds were squared by mistake. While I agree we could maybe raise the angular threshold, the squared residual error is far too permissive.","created_at":"2018-09-13T11:28:28Z","updated_at":"2018-09-13T11:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openMVG/openMVG/pulls/1393/commits","review_comments_url":"https://api.github.com/repos/openMVG/openMVG/pulls/1393/comments","review_comment_url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openMVG/openMVG/issues/1393/comments","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/98841220af558a24df838f553d2ee91394cdeaa9","head":{"label":"rjanvier:patch-3","ref":"patch-3","sha":"98841220af558a24df838f553d2ee91394cdeaa9","user":{"login":"rjanvier","id":1537100,"node_id":"MDQ6VXNlcjE1MzcxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1537100?v=4","gravatar_id":"","url":"https://api.github.com/users/rjanvier","html_url":"https://github.com/rjanvier","followers_url":"https://api.github.com/users/rjanvier/followers","following_url":"https://api.github.com/users/rjanvier/following{/other_user}","gists_url":"https://api.github.com/users/rjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/rjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjanvier/subscriptions","organizations_url":"https://api.github.com/users/rjanvier/orgs","repos_url":"https://api.github.com/users/rjanvier/repos","events_url":"https://api.github.com/users/rjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/rjanvier/received_events","type":"User","site_admin":false},"repo":{"id":35932473,"node_id":"MDEwOlJlcG9zaXRvcnkzNTkzMjQ3Mw==","name":"openMVG","full_name":"rjanvier/openMVG","owner":{"login":"rjanvier","id":1537100,"node_id":"MDQ6VXNlcjE1MzcxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1537100?v=4","gravatar_id":"","url":"https://api.github.com/users/rjanvier","html_url":"https://github.com/rjanvier","followers_url":"https://api.github.com/users/rjanvier/followers","following_url":"https://api.github.com/users/rjanvier/following{/other_user}","gists_url":"https://api.github.com/users/rjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/rjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjanvier/subscriptions","organizations_url":"https://api.github.com/users/rjanvier/orgs","repos_url":"https://api.github.com/users/rjanvier/repos","events_url":"https://api.github.com/users/rjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/rjanvier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjanvier/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/rjanvier/openMVG","forks_url":"https://api.github.com/repos/rjanvier/openMVG/forks","keys_url":"https://api.github.com/repos/rjanvier/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjanvier/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjanvier/openMVG/teams","hooks_url":"https://api.github.com/repos/rjanvier/openMVG/hooks","issue_events_url":"https://api.github.com/repos/rjanvier/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/rjanvier/openMVG/events","assignees_url":"https://api.github.com/repos/rjanvier/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/rjanvier/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/rjanvier/openMVG/tags","blobs_url":"https://api.github.com/repos/rjanvier/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjanvier/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjanvier/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjanvier/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjanvier/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/rjanvier/openMVG/languages","stargazers_url":"https://api.github.com/repos/rjanvier/openMVG/stargazers","contributors_url":"https://api.github.com/repos/rjanvier/openMVG/contributors","subscribers_url":"https://api.github.com/repos/rjanvier/openMVG/subscribers","subscription_url":"https://api.github.com/repos/rjanvier/openMVG/subscription","commits_url":"https://api.github.com/repos/rjanvier/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjanvier/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjanvier/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjanvier/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjanvier/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/rjanvier/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjanvier/openMVG/merges","archive_url":"https://api.github.com/repos/rjanvier/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjanvier/openMVG/downloads","issues_url":"https://api.github.com/repos/rjanvier/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/rjanvier/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/rjanvier/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/rjanvier/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjanvier/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/rjanvier/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/rjanvier/openMVG/deployments","created_at":"2015-05-20T07:20:40Z","updated_at":"2018-04-21T20:36:49Z","pushed_at":"2018-09-13T11:25:55Z","git_url":"git://github.com/rjanvier/openMVG.git","ssh_url":"git@github.com:rjanvier/openMVG.git","clone_url":"https://github.com/rjanvier/openMVG.git","svn_url":"https://github.com/rjanvier/openMVG","homepage":"","size":27282,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openMVG:develop","ref":"develop","sha":"835f1e585377a55d4143548fa9181438f5d23889","user":{"login":"openMVG","id":3512104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTIxMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3512104?v=4","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"repo":{"id":8096326,"node_id":"MDEwOlJlcG9zaXRvcnk4MDk2MzI2","name":"openMVG","full_name":"openMVG/openMVG","owner":{"login":"openMVG","id":3512104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTIxMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3512104?v=4","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openMVG/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/openMVG/openMVG","forks_url":"https://api.github.com/repos/openMVG/openMVG/forks","keys_url":"https://api.github.com/repos/openMVG/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openMVG/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openMVG/openMVG/teams","hooks_url":"https://api.github.com/repos/openMVG/openMVG/hooks","issue_events_url":"https://api.github.com/repos/openMVG/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/openMVG/openMVG/events","assignees_url":"https://api.github.com/repos/openMVG/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/openMVG/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/openMVG/openMVG/tags","blobs_url":"https://api.github.com/repos/openMVG/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openMVG/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openMVG/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/openMVG/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/openMVG/openMVG/languages","stargazers_url":"https://api.github.com/repos/openMVG/openMVG/stargazers","contributors_url":"https://api.github.com/repos/openMVG/openMVG/contributors","subscribers_url":"https://api.github.com/repos/openMVG/openMVG/subscribers","subscription_url":"https://api.github.com/repos/openMVG/openMVG/subscription","commits_url":"https://api.github.com/repos/openMVG/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/openMVG/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/openMVG/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/openMVG/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/openMVG/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/openMVG/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openMVG/openMVG/merges","archive_url":"https://api.github.com/repos/openMVG/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openMVG/openMVG/downloads","issues_url":"https://api.github.com/repos/openMVG/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/openMVG/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/openMVG/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/openMVG/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openMVG/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/openMVG/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/openMVG/openMVG/deployments","created_at":"2013-02-08T16:01:08Z","updated_at":"2018-09-13T08:49:32Z","pushed_at":"2018-09-10T20:20:46Z","git_url":"git://github.com/openMVG/openMVG.git","ssh_url":"git@github.com:openMVG/openMVG.git","clone_url":"https://github.com/openMVG/openMVG.git","svn_url":"https://github.com/openMVG/openMVG","homepage":"","size":27438,"stargazers_count":1816,"watchers_count":1816,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":807,"open_issues":111,"watchers":1816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/1393"},"html":{"href":"https://github.com/openMVG/openMVG/pull/1393"},"issue":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/1393"},"comments":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/1393/comments"},"review_comments":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/1393/comments"},"review_comment":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/1393/commits"},"statuses":{"href":"https://api.github.com/repos/openMVG/openMVG/statuses/98841220af558a24df838f553d2ee91394cdeaa9"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"rjanvier"}}