{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/13666","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/13666/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/13666/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/13666/events","html_url":"https://github.com/mrdoob/three.js/issues/13666","id":307787200,"number":13666,"title":"Documentation: .filters description doesn't make sense","user":{"login":"cwilso","id":507001,"avatar_url":"https://avatars2.githubusercontent.com/u/507001?v=4","gravatar_id":"","url":"https://api.github.com/users/cwilso","html_url":"https://github.com/cwilso","followers_url":"https://api.github.com/users/cwilso/followers","following_url":"https://api.github.com/users/cwilso/following{/other_user}","gists_url":"https://api.github.com/users/cwilso/gists{/gist_id}","starred_url":"https://api.github.com/users/cwilso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwilso/subscriptions","organizations_url":"https://api.github.com/users/cwilso/orgs","repos_url":"https://api.github.com/users/cwilso/repos","events_url":"https://api.github.com/users/cwilso/events{/privacy}","received_events_url":"https://api.github.com/users/cwilso/received_events","type":"User","site_admin":false},"labels":[{"id":606658124,"url":"https://api.github.com/repos/mrdoob/three.js/labels/Bug%20(easy)","name":"Bug (easy)","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-22T19:39:31Z","updated_at":"2018-03-23T16:08:52Z","closed_at":null,"author_association":"NONE","body":"The description of the .filters on Audio doesn't make sense -\r\n just says \"Whether the audio is currently playing. Default is empty array.\"  rather than describing what an element in the array is or represents (WebAudio BiquadFilterNode or any chainable filter, I guess?).  Also, the setFilter behavior seems like it would blow away any previous filters.\r\n\r\n(around this line: https://github.com/mrdoob/three.js/blob/683289bd00dc2eb8230744c03d7e7c67c68a2f2b/docs/api/audio/Audio.html#L66)"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/375716564","html_url":"https://github.com/mrdoob/three.js/issues/13666#issuecomment-375716564","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/13666","id":375716564,"user":{"login":"cwilso","id":507001,"avatar_url":"https://avatars2.githubusercontent.com/u/507001?v=4","gravatar_id":"","url":"https://api.github.com/users/cwilso","html_url":"https://github.com/cwilso","followers_url":"https://api.github.com/users/cwilso/followers","following_url":"https://api.github.com/users/cwilso/following{/other_user}","gists_url":"https://api.github.com/users/cwilso/gists{/gist_id}","starred_url":"https://api.github.com/users/cwilso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwilso/subscriptions","organizations_url":"https://api.github.com/users/cwilso/orgs","repos_url":"https://api.github.com/users/cwilso/repos","events_url":"https://api.github.com/users/cwilso/events{/privacy}","received_events_url":"https://api.github.com/users/cwilso/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T16:08:51Z","updated_at":"2018-03-23T16:08:51Z","author_association":"NONE","body":"What's the right thing to do here?\r\n\r\n1. Describe current behavior of setFilter and setFilters, and the .filters array.  This will have some odd text, since the setFilter* methods are kind of odd.  (\"This is an array containing any filters that have been set.\")\r\n2. Quietly remove mention of setFilters, change setFilter description to be correct. (\"inserts a Web Audio filtering node into the audio output.  Takes a Web Audio AudioNode, such as BiquadFilterNode. Will replace any other filter set.\")\r\n3. As #2, but remove setFilters code too.\r\n4. Fix setFilters code?  This is pretty open-ended; I expect you'd really want to have a setFilter that took an offset, and setFilters shouldn't exist.\r\n\r\nI'm not really sure?  TBH, I'm not sure what value this is trying to add over the Web Audio API, since it's still using the Web Audio nodes (and the developer has to understand them)."}}
{"actor":{"display_login":"cwilso"}}