{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/220973818","pull_request_review_id":159510727,"id":220973818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDk3MzgxOA==","diff_hunk":"@@ -109,15 +111,39 @@ func convertSet(ctx *sql.Context, n *sqlparser.Set) (sql.Node, error) {\n \t\t\treturn nil, err\n \t\t}\n \n-\t\tfmt.Println(strings.TrimSpace(strings.ToLower(e.Name.Qualifier.Name.String())))\n-\t\tswitch strings.TrimSpace(strings.ToLower(e.Name.Qualifier.Name.String())) {\n-\t\tcase \"@@session\", \"\": // do nothing\n-\t\tdefault:\n-\t\t\treturn nil, ErrUnsupportedFeature.New(\"qualifiers in set variable names other than @@session\")\n+\t\tname := strings.TrimSpace(e.Name.Lowered())\n+\t\tif strings.Contains(name, \"autocommit\") {","path":"sql/parse/parse.go","position":26,"original_position":26,"commit_id":"21d6fd94d8eb33a6c22a8ef849fa75c0147b6290","original_commit_id":"21d6fd94d8eb33a6c22a8ef849fa75c0147b6290","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"body":"Is ON/OFF only for autocommit on MySQL?","created_at":"2018-09-27T15:37:28Z","updated_at":"2018-09-27T15:37:46Z","html_url":"https://github.com/src-d/go-mysql-server/pull/383#discussion_r220973818","pull_request_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/220973818"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/383#discussion_r220973818"},"pull_request":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383"}}},"pull_request":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383","id":218288673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Mjg4Njcz","html_url":"https://github.com/src-d/go-mysql-server/pull/383","diff_url":"https://github.com/src-d/go-mysql-server/pull/383.diff","patch_url":"https://github.com/src-d/go-mysql-server/pull/383.patch","issue_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/383","number":383,"state":"open","locked":false,"title":"Support ON/OFF for SET autocommit ","user":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"body":"Signed-off-by: kuba-- <kuba@sourced.tech>\r\nIt closes https://github.com/src-d/go-mysql-server/issues/374\r\n","created_at":"2018-09-26T11:58:43Z","updated_at":"2018-09-27T15:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1afde127d601c5e78fe55d06fcc34679baf56254","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ajnavarro","id":1196465,"node_id":"MDQ6VXNlcjExOTY0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1196465?v=4","gravatar_id":"","url":"https://api.github.com/users/ajnavarro","html_url":"https://github.com/ajnavarro","followers_url":"https://api.github.com/users/ajnavarro/followers","following_url":"https://api.github.com/users/ajnavarro/following{/other_user}","gists_url":"https://api.github.com/users/ajnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/ajnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajnavarro/subscriptions","organizations_url":"https://api.github.com/users/ajnavarro/orgs","repos_url":"https://api.github.com/users/ajnavarro/repos","events_url":"https://api.github.com/users/ajnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/ajnavarro/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":835651614,"node_id":"MDU6TGFiZWw4MzU2NTE2MTQ=","url":"https://api.github.com/repos/src-d/go-mysql-server/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":844048792,"node_id":"MDU6TGFiZWw4NDQwNDg3OTI=","url":"https://api.github.com/repos/src-d/go-mysql-server/labels/proposal","name":"proposal","color":"fc8880","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383/commits","review_comments_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383/comments","review_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/383/comments","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/21d6fd94d8eb33a6c22a8ef849fa75c0147b6290","head":{"label":"kuba--:fix-374/upgrade-vitess","ref":"fix-374/upgrade-vitess","sha":"21d6fd94d8eb33a6c22a8ef849fa75c0147b6290","user":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"repo":{"id":143021670,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMjE2NzA=","name":"go-mysql-server","full_name":"kuba--/go-mysql-server","private":false,"owner":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kuba--/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":true,"url":"https://api.github.com/repos/kuba--/go-mysql-server","forks_url":"https://api.github.com/repos/kuba--/go-mysql-server/forks","keys_url":"https://api.github.com/repos/kuba--/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuba--/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuba--/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/kuba--/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/kuba--/go-mysql-server/events","assignees_url":"https://api.github.com/repos/kuba--/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/kuba--/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/kuba--/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuba--/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/kuba--/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/kuba--/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/kuba--/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/kuba--/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/kuba--/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/kuba--/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuba--/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuba--/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/kuba--/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuba--/go-mysql-server/merges","archive_url":"https://api.github.com/repos/kuba--/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuba--/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/kuba--/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/kuba--/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/kuba--/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuba--/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/kuba--/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/kuba--/go-mysql-server/deployments","created_at":"2018-07-31T13:58:14Z","updated_at":"2018-09-25T08:22:17Z","pushed_at":"2018-09-27T15:21:21Z","git_url":"git://github.com/kuba--/go-mysql-server.git","ssh_url":"git@github.com:kuba--/go-mysql-server.git","clone_url":"https://github.com/kuba--/go-mysql-server.git","svn_url":"https://github.com/kuba--/go-mysql-server","homepage":"","size":1433,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"95285948912f7edaf92e2e66e44fa6c6ad509942","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":121319560,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzMTk1NjA=","name":"go-mysql-server","full_name":"src-d/go-mysql-server","private":false,"owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/src-d/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":false,"url":"https://api.github.com/repos/src-d/go-mysql-server","forks_url":"https://api.github.com/repos/src-d/go-mysql-server/forks","keys_url":"https://api.github.com/repos/src-d/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/src-d/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/go-mysql-server/events","assignees_url":"https://api.github.com/repos/src-d/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/src-d/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/src-d/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/src-d/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/src-d/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/src-d/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/go-mysql-server/merges","archive_url":"https://api.github.com/repos/src-d/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/src-d/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/src-d/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/go-mysql-server/deployments","created_at":"2018-02-13T00:24:19Z","updated_at":"2018-09-27T10:33:39Z","pushed_at":"2018-09-27T15:21:22Z","git_url":"git://github.com/src-d/go-mysql-server.git","ssh_url":"git@github.com:src-d/go-mysql-server.git","clone_url":"https://github.com/src-d/go-mysql-server.git","svn_url":"https://github.com/src-d/go-mysql-server","homepage":"","size":1422,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":21,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/383"},"issue":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/383"},"comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/go-mysql-server/statuses/21d6fd94d8eb33a6c22a8ef849fa75c0147b6290"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"erizocosmico"}}