{"action":"opened","number":115,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115","id":167518412,"html_url":"https://github.com/JuliaLang/Pkg3.jl/pull/115","diff_url":"https://github.com/JuliaLang/Pkg3.jl/pull/115.diff","patch_url":"https://github.com/JuliaLang/Pkg3.jl/pull/115.patch","issue_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/115","number":115,"state":"open","locked":false,"title":"Significantly improve performance by not using broadcasting for very small arrays","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars1.githubusercontent.com/u/1282691?v=4","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"body":"From profiling, a large bottleneck was found in creating the `Graph`. This is because broadcasting (while convenient) actually has a significant overhead when used on small arrays. This was frequently the case here.\r\n\r\nBefore the changes here, creating the `Graph` took 0.93 seconds when adding DifferentialEquations with a total time for `Pkg3.add` of 2.0 seconds.\r\n\r\nAfter the changes, `Graph`takes 0.30 seconds and total time 1.36 seconds.\r\n\r\nThe changes to Operations.jl are for readability, was hard to me to keep the nested generators in my head (also this way we only do one loop).","created_at":"2018-02-06T20:15:01Z","updated_at":"2018-02-06T20:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/115/comments","statuses_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/statuses/c4736da6fe4a7ef35eb9ece5ec111121b9912c00","head":{"label":"JuliaLang:kc/perf_graph","ref":"kc/perf_graph","sha":"c4736da6fe4a7ef35eb9ece5ec111121b9912c00","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":82341193,"name":"Pkg3.jl","full_name":"JuliaLang/Pkg3.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/Pkg3.jl","description":null,"fork":false,"url":"https://api.github.com/repos/JuliaLang/Pkg3.jl","forks_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/deployments","created_at":"2017-02-17T21:51:01Z","updated_at":"2018-01-25T10:38:52Z","pushed_at":"2018-02-06T20:10:43Z","git_url":"git://github.com/JuliaLang/Pkg3.jl.git","ssh_url":"git@github.com:JuliaLang/Pkg3.jl.git","clone_url":"https://github.com/JuliaLang/Pkg3.jl.git","svn_url":"https://github.com/JuliaLang/Pkg3.jl","homepage":null,"size":2629,"stargazers_count":60,"watchers_count":60,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":37,"watchers":60,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"53cceb67439e1709234177bda4d4c9d5adb23ede","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":82341193,"name":"Pkg3.jl","full_name":"JuliaLang/Pkg3.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/Pkg3.jl","description":null,"fork":false,"url":"https://api.github.com/repos/JuliaLang/Pkg3.jl","forks_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/Pkg3.jl/deployments","created_at":"2017-02-17T21:51:01Z","updated_at":"2018-01-25T10:38:52Z","pushed_at":"2018-02-06T20:10:43Z","git_url":"git://github.com/JuliaLang/Pkg3.jl.git","ssh_url":"git@github.com:JuliaLang/Pkg3.jl.git","clone_url":"https://github.com/JuliaLang/Pkg3.jl.git","svn_url":"https://github.com/JuliaLang/Pkg3.jl","homepage":null,"size":2629,"stargazers_count":60,"watchers_count":60,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":37,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115"},"html":{"href":"https://github.com/JuliaLang/Pkg3.jl/pull/115"},"issue":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/115"},"comments":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/Pkg3.jl/statuses/c4736da6fe4a7ef35eb9ece5ec111121b9912c00"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"KristofferC"}}