{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/170434295","pull_request_review_id":99125155,"id":170434295,"diff_hunk":"@@ -0,0 +1,131 @@\n+#region Copyright & License Information\n+/*\n+ * Copyright 2007-2018 The OpenRA Developers (see AUTHORS)\n+ * This file is part of OpenRA, which is free software. It is made\n+ * available to you under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation, either version 3 of\n+ * the License, or (at your option) any later version. For more\n+ * information, see COPYING.\n+ */\n+#endregion\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Drawing;\n+using System.IO;\n+using OpenRA.Graphics;\n+using OpenRA.Traits;\n+\n+namespace OpenRA.Mods.Common.Traits\n+{\n+\t[Desc(\"Load a GIMP .gpl or JASC .pal palette file. Supports per-color alpha.\")]\n+\tclass PaletteFromGimpOrJascFileInfo : ITraitInfo\n+\t{\n+\t\t[FieldLoader.Require, PaletteDefinition]\n+\t\t[Desc(\"Palette name used internally.\")]\n+\t\tpublic readonly string Name = null;\n+\n+\t\t[Desc(\"Defines for which tileset IDs this palette should be loaded.\",\n+\t\t\t\"If none specified, it applies to all tileset IDs not explicitly excluded.\")]\n+\t\tpublic readonly HashSet<string> Tilesets = new HashSet<string>();\n+\n+\t\t[Desc(\"Don't load palette for these tileset IDs.\")]\n+\t\tpublic readonly HashSet<string> ExcludeTilesets = new HashSet<string>();\n+\n+\t\t[FieldLoader.Require]\n+\t\t[Desc(\"Name of the file to load.\")]\n+\t\tpublic readonly string Filename = null;\n+\n+\t\t[Desc(\"Map listed indices to shadow. Ignores previous color.\")]\n+\t\tpublic readonly int[] ShadowIndex = { };","path":"OpenRA.Mods.Common/Traits/World/PaletteFromGimpOrJascFile.cs","position":40,"original_position":40,"commit_id":"d8a2ed9eac5897e02d3ba9e6cfeb1a9800acf5ea","original_commit_id":"d8a2ed9eac5897e02d3ba9e6cfeb1a9800acf5ea","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars1.githubusercontent.com/u/167819?v=4","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Modders can define shadows (including alpha) directly in the palette, so this is redundant.","created_at":"2018-02-24T22:30:01Z","updated_at":"2018-02-24T22:30:02Z","html_url":"https://github.com/OpenRA/OpenRA/pull/14851#discussion_r170434295","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/170434295"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/14851#discussion_r170434295"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851","id":171167500,"html_url":"https://github.com/OpenRA/OpenRA/pull/14851","diff_url":"https://github.com/OpenRA/OpenRA/pull/14851.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/14851.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/14851","number":14851,"state":"open","locked":false,"title":"Add support for GIMP and JASC palettes (with per-color alpha)","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"body":"Supersedes #13913.\r\n\r\nCompared to #13913, following changes and additions were made:\r\n- merged GIMP/JASC support into a single trait\r\n- replaced the limited-use `Tileset` with `Tilesets` + `ExcludeTilesets`\r\n- Added support for per-color alpha\r\n- updated testcase commits to account for per-color alpha (RA effects, TS units) and make testing quicker","created_at":"2018-02-24T07:57:53Z","updated_at":"2018-02-24T22:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3e1db24d12d89c2d4cd29f23dab2aa19bb3c09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118143255,"url":"https://api.github.com/repos/OpenRA/OpenRA/labels/PR:%20Needs%20+2","name":"PR: Needs +2","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/14851/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/d8a2ed9eac5897e02d3ba9e6cfeb1a9800acf5ea","head":{"label":"reaperrr:more-pals-v2","ref":"more-pals-v2","sha":"d8a2ed9eac5897e02d3ba9e6cfeb1a9800acf5ea","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"repo":{"id":6804707,"name":"OpenRA","full_name":"reaperrr/OpenRA","owner":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars3.githubusercontent.com/u/2857877?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reaperrr/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX. Bugs at http://bugs.open-ra.org/","fork":true,"url":"https://api.github.com/repos/reaperrr/OpenRA","forks_url":"https://api.github.com/repos/reaperrr/OpenRA/forks","keys_url":"https://api.github.com/repos/reaperrr/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperrr/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperrr/OpenRA/teams","hooks_url":"https://api.github.com/repos/reaperrr/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/reaperrr/OpenRA/events","assignees_url":"https://api.github.com/repos/reaperrr/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/reaperrr/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/reaperrr/OpenRA/tags","blobs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperrr/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperrr/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperrr/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperrr/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperrr/OpenRA/languages","stargazers_url":"https://api.github.com/repos/reaperrr/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/reaperrr/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/reaperrr/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/reaperrr/OpenRA/subscription","commits_url":"https://api.github.com/repos/reaperrr/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperrr/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperrr/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperrr/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaperrr/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/reaperrr/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperrr/OpenRA/merges","archive_url":"https://api.github.com/repos/reaperrr/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperrr/OpenRA/downloads","issues_url":"https://api.github.com/repos/reaperrr/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/reaperrr/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperrr/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperrr/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperrr/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/reaperrr/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/reaperrr/OpenRA/deployments","created_at":"2012-11-21T23:13:26Z","updated_at":"2015-09-20T21:10:57Z","pushed_at":"2018-02-24T18:03:05Z","git_url":"git://github.com/reaperrr/OpenRA.git","ssh_url":"git@github.com:reaperrr/OpenRA.git","clone_url":"https://github.com/reaperrr/OpenRA.git","svn_url":"https://github.com/reaperrr/OpenRA","homepage":"http://open-ra.org","size":133896,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"cf944ae9f17e1fffce32b650afa6bf874bf8d6a3","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2018-02-24T20:11:11Z","pushed_at":"2018-02-24T19:22:25Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":131830,"stargazers_count":4967,"watchers_count":4967,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1469,"mirror_url":null,"archived":false,"open_issues_count":1425,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1469,"open_issues":1425,"watchers":4967,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/14851"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/14851"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/14851/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14851/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/d8a2ed9eac5897e02d3ba9e6cfeb1a9800acf5ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pchote"}}