{"action":"created","comment":{"url":"https://api.github.com/repos/pepkit/peppy/pulls/comments/236966464","pull_request_review_id":179152936,"id":236966464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk2NjQ2NA==","diff_hunk":"@@ -512,6 +498,19 @@ def get_sample(self, sample_name):\n \n         return samples[0]\n \n+    def activate_subproject(self, subproject):\n+        \"\"\"\n+        Activate a subproject.\n+\n+        This method will update Project attributes, adding new values\n+        associated with the subproject indicated, and in case of collision with\n+        an existing key/attribute the subproject's value will be favored.\n+\n+        :param str subproject: A string with a subproject name to be activated\n+        :return Project: A Project with the selected subproject activated\n+        \"\"\"\n+        return self.__init__(self.config_file, subproject=subproject)","path":"peppy/project.py","position":72,"original_position":72,"commit_id":"cfd20f869c249c2588a5215a448afa39d64d0e00","original_commit_id":"cfd20f869c249c2588a5215a448afa39d64d0e00","user":{"login":"vreuter","id":12036370,"node_id":"MDQ6VXNlcjEyMDM2Mzcw","avatar_url":"https://avatars1.githubusercontent.com/u/12036370?v=4","gravatar_id":"","url":"https://api.github.com/users/vreuter","html_url":"https://github.com/vreuter","followers_url":"https://api.github.com/users/vreuter/followers","following_url":"https://api.github.com/users/vreuter/following{/other_user}","gists_url":"https://api.github.com/users/vreuter/gists{/gist_id}","starred_url":"https://api.github.com/users/vreuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vreuter/subscriptions","organizations_url":"https://api.github.com/users/vreuter/orgs","repos_url":"https://api.github.com/users/vreuter/repos","events_url":"https://api.github.com/users/vreuter/events{/privacy}","received_events_url":"https://api.github.com/users/vreuter/received_events","type":"User","site_admin":false},"body":"This should work, some attributes on a `Project` instance that aren't included in a config file that may have been dynamically set by a user post-construction would be reset by this. That may be the intended behavior...what do you guys think? If we wanted the update to be strictly based on the subproject, what about making this `self.parse_config_file(subproject)`?","created_at":"2018-11-28T07:31:59Z","updated_at":"2018-11-28T07:31:59Z","html_url":"https://github.com/pepkit/peppy/pull/232#discussion_r236966464","pull_request_url":"https://api.github.com/repos/pepkit/peppy/pulls/232","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/comments/236966464"},"html":{"href":"https://github.com/pepkit/peppy/pull/232#discussion_r236966464"},"pull_request":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/232"}}},"pull_request":{"url":"https://api.github.com/repos/pepkit/peppy/pulls/232","id":234026754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDI2NzU0","html_url":"https://github.com/pepkit/peppy/pull/232","diff_url":"https://github.com/pepkit/peppy/pull/232.diff","patch_url":"https://github.com/pepkit/peppy/pull/232.patch","issue_url":"https://api.github.com/repos/pepkit/peppy/issues/232","number":232,"state":"open","locked":false,"title":"Subproj related","user":{"login":"michalstolarczyk","id":22797900,"node_id":"MDQ6VXNlcjIyNzk3OTAw","avatar_url":"https://avatars2.githubusercontent.com/u/22797900?v=4","gravatar_id":"","url":"https://api.github.com/users/michalstolarczyk","html_url":"https://github.com/michalstolarczyk","followers_url":"https://api.github.com/users/michalstolarczyk/followers","following_url":"https://api.github.com/users/michalstolarczyk/following{/other_user}","gists_url":"https://api.github.com/users/michalstolarczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/michalstolarczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalstolarczyk/subscriptions","organizations_url":"https://api.github.com/users/michalstolarczyk/orgs","repos_url":"https://api.github.com/users/michalstolarczyk/repos","events_url":"https://api.github.com/users/michalstolarczyk/events{/privacy}","received_events_url":"https://api.github.com/users/michalstolarczyk/received_events","type":"User","site_admin":false},"body":" addressed issues: #224, #228, #229 ","created_at":"2018-11-27T19:07:36Z","updated_at":"2018-11-28T07:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d312bc3d444aba333a873e3d5847439727557453","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nsheff","id":5271009,"node_id":"MDQ6VXNlcjUyNzEwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5271009?v=4","gravatar_id":"","url":"https://api.github.com/users/nsheff","html_url":"https://github.com/nsheff","followers_url":"https://api.github.com/users/nsheff/followers","following_url":"https://api.github.com/users/nsheff/following{/other_user}","gists_url":"https://api.github.com/users/nsheff/gists{/gist_id}","starred_url":"https://api.github.com/users/nsheff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsheff/subscriptions","organizations_url":"https://api.github.com/users/nsheff/orgs","repos_url":"https://api.github.com/users/nsheff/repos","events_url":"https://api.github.com/users/nsheff/events{/privacy}","received_events_url":"https://api.github.com/users/nsheff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pepkit/peppy/pulls/232/commits","review_comments_url":"https://api.github.com/repos/pepkit/peppy/pulls/232/comments","review_comment_url":"https://api.github.com/repos/pepkit/peppy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pepkit/peppy/issues/232/comments","statuses_url":"https://api.github.com/repos/pepkit/peppy/statuses/cfd20f869c249c2588a5215a448afa39d64d0e00","head":{"label":"pepkit:subproj_related","ref":"subproj_related","sha":"cfd20f869c249c2588a5215a448afa39d64d0e00","user":{"login":"pepkit","id":29280461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjgwNDYx","avatar_url":"https://avatars1.githubusercontent.com/u/29280461?v=4","gravatar_id":"","url":"https://api.github.com/users/pepkit","html_url":"https://github.com/pepkit","followers_url":"https://api.github.com/users/pepkit/followers","following_url":"https://api.github.com/users/pepkit/following{/other_user}","gists_url":"https://api.github.com/users/pepkit/gists{/gist_id}","starred_url":"https://api.github.com/users/pepkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepkit/subscriptions","organizations_url":"https://api.github.com/users/pepkit/orgs","repos_url":"https://api.github.com/users/pepkit/repos","events_url":"https://api.github.com/users/pepkit/events{/privacy}","received_events_url":"https://api.github.com/users/pepkit/received_events","type":"Organization","site_admin":false},"repo":{"id":58154852,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE1NDg1Mg==","name":"peppy","full_name":"pepkit/peppy","private":false,"owner":{"login":"pepkit","id":29280461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjgwNDYx","avatar_url":"https://avatars1.githubusercontent.com/u/29280461?v=4","gravatar_id":"","url":"https://api.github.com/users/pepkit","html_url":"https://github.com/pepkit","followers_url":"https://api.github.com/users/pepkit/followers","following_url":"https://api.github.com/users/pepkit/following{/other_user}","gists_url":"https://api.github.com/users/pepkit/gists{/gist_id}","starred_url":"https://api.github.com/users/pepkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepkit/subscriptions","organizations_url":"https://api.github.com/users/pepkit/orgs","repos_url":"https://api.github.com/users/pepkit/repos","events_url":"https://api.github.com/users/pepkit/events{/privacy}","received_events_url":"https://api.github.com/users/pepkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pepkit/peppy","description":"A python-based project metadata manager for portable encapsulated projects","fork":false,"url":"https://api.github.com/repos/pepkit/peppy","forks_url":"https://api.github.com/repos/pepkit/peppy/forks","keys_url":"https://api.github.com/repos/pepkit/peppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pepkit/peppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pepkit/peppy/teams","hooks_url":"https://api.github.com/repos/pepkit/peppy/hooks","issue_events_url":"https://api.github.com/repos/pepkit/peppy/issues/events{/number}","events_url":"https://api.github.com/repos/pepkit/peppy/events","assignees_url":"https://api.github.com/repos/pepkit/peppy/assignees{/user}","branches_url":"https://api.github.com/repos/pepkit/peppy/branches{/branch}","tags_url":"https://api.github.com/repos/pepkit/peppy/tags","blobs_url":"https://api.github.com/repos/pepkit/peppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pepkit/peppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pepkit/peppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pepkit/peppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pepkit/peppy/statuses/{sha}","languages_url":"https://api.github.com/repos/pepkit/peppy/languages","stargazers_url":"https://api.github.com/repos/pepkit/peppy/stargazers","contributors_url":"https://api.github.com/repos/pepkit/peppy/contributors","subscribers_url":"https://api.github.com/repos/pepkit/peppy/subscribers","subscription_url":"https://api.github.com/repos/pepkit/peppy/subscription","commits_url":"https://api.github.com/repos/pepkit/peppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pepkit/peppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pepkit/peppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pepkit/peppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pepkit/peppy/contents/{+path}","compare_url":"https://api.github.com/repos/pepkit/peppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pepkit/peppy/merges","archive_url":"https://api.github.com/repos/pepkit/peppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pepkit/peppy/downloads","issues_url":"https://api.github.com/repos/pepkit/peppy/issues{/number}","pulls_url":"https://api.github.com/repos/pepkit/peppy/pulls{/number}","milestones_url":"https://api.github.com/repos/pepkit/peppy/milestones{/number}","notifications_url":"https://api.github.com/repos/pepkit/peppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pepkit/peppy/labels{/name}","releases_url":"https://api.github.com/repos/pepkit/peppy/releases{/id}","deployments_url":"https://api.github.com/repos/pepkit/peppy/deployments","created_at":"2016-05-05T19:20:05Z","updated_at":"2018-09-21T19:46:59Z","pushed_at":"2018-11-27T21:03:37Z","git_url":"git://github.com/pepkit/peppy.git","ssh_url":"git@github.com:pepkit/peppy.git","clone_url":"https://github.com/pepkit/peppy.git","svn_url":"https://github.com/pepkit/peppy","homepage":"http://peppy.readthedocs.io","size":1784,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":5,"open_issues":31,"watchers":21,"default_branch":"master"}},"base":{"label":"pepkit:dev","ref":"dev","sha":"6b8545f94102de1abc0c2db08d15cbecc03be06d","user":{"login":"pepkit","id":29280461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjgwNDYx","avatar_url":"https://avatars1.githubusercontent.com/u/29280461?v=4","gravatar_id":"","url":"https://api.github.com/users/pepkit","html_url":"https://github.com/pepkit","followers_url":"https://api.github.com/users/pepkit/followers","following_url":"https://api.github.com/users/pepkit/following{/other_user}","gists_url":"https://api.github.com/users/pepkit/gists{/gist_id}","starred_url":"https://api.github.com/users/pepkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepkit/subscriptions","organizations_url":"https://api.github.com/users/pepkit/orgs","repos_url":"https://api.github.com/users/pepkit/repos","events_url":"https://api.github.com/users/pepkit/events{/privacy}","received_events_url":"https://api.github.com/users/pepkit/received_events","type":"Organization","site_admin":false},"repo":{"id":58154852,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE1NDg1Mg==","name":"peppy","full_name":"pepkit/peppy","private":false,"owner":{"login":"pepkit","id":29280461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjgwNDYx","avatar_url":"https://avatars1.githubusercontent.com/u/29280461?v=4","gravatar_id":"","url":"https://api.github.com/users/pepkit","html_url":"https://github.com/pepkit","followers_url":"https://api.github.com/users/pepkit/followers","following_url":"https://api.github.com/users/pepkit/following{/other_user}","gists_url":"https://api.github.com/users/pepkit/gists{/gist_id}","starred_url":"https://api.github.com/users/pepkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepkit/subscriptions","organizations_url":"https://api.github.com/users/pepkit/orgs","repos_url":"https://api.github.com/users/pepkit/repos","events_url":"https://api.github.com/users/pepkit/events{/privacy}","received_events_url":"https://api.github.com/users/pepkit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pepkit/peppy","description":"A python-based project metadata manager for portable encapsulated projects","fork":false,"url":"https://api.github.com/repos/pepkit/peppy","forks_url":"https://api.github.com/repos/pepkit/peppy/forks","keys_url":"https://api.github.com/repos/pepkit/peppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pepkit/peppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pepkit/peppy/teams","hooks_url":"https://api.github.com/repos/pepkit/peppy/hooks","issue_events_url":"https://api.github.com/repos/pepkit/peppy/issues/events{/number}","events_url":"https://api.github.com/repos/pepkit/peppy/events","assignees_url":"https://api.github.com/repos/pepkit/peppy/assignees{/user}","branches_url":"https://api.github.com/repos/pepkit/peppy/branches{/branch}","tags_url":"https://api.github.com/repos/pepkit/peppy/tags","blobs_url":"https://api.github.com/repos/pepkit/peppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pepkit/peppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pepkit/peppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pepkit/peppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pepkit/peppy/statuses/{sha}","languages_url":"https://api.github.com/repos/pepkit/peppy/languages","stargazers_url":"https://api.github.com/repos/pepkit/peppy/stargazers","contributors_url":"https://api.github.com/repos/pepkit/peppy/contributors","subscribers_url":"https://api.github.com/repos/pepkit/peppy/subscribers","subscription_url":"https://api.github.com/repos/pepkit/peppy/subscription","commits_url":"https://api.github.com/repos/pepkit/peppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pepkit/peppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pepkit/peppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pepkit/peppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pepkit/peppy/contents/{+path}","compare_url":"https://api.github.com/repos/pepkit/peppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pepkit/peppy/merges","archive_url":"https://api.github.com/repos/pepkit/peppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pepkit/peppy/downloads","issues_url":"https://api.github.com/repos/pepkit/peppy/issues{/number}","pulls_url":"https://api.github.com/repos/pepkit/peppy/pulls{/number}","milestones_url":"https://api.github.com/repos/pepkit/peppy/milestones{/number}","notifications_url":"https://api.github.com/repos/pepkit/peppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pepkit/peppy/labels{/name}","releases_url":"https://api.github.com/repos/pepkit/peppy/releases{/id}","deployments_url":"https://api.github.com/repos/pepkit/peppy/deployments","created_at":"2016-05-05T19:20:05Z","updated_at":"2018-09-21T19:46:59Z","pushed_at":"2018-11-27T21:03:37Z","git_url":"git://github.com/pepkit/peppy.git","ssh_url":"git@github.com:pepkit/peppy.git","clone_url":"https://github.com/pepkit/peppy.git","svn_url":"https://github.com/pepkit/peppy","homepage":"http://peppy.readthedocs.io","size":1784,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":5,"open_issues":31,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/232"},"html":{"href":"https://github.com/pepkit/peppy/pull/232"},"issue":{"href":"https://api.github.com/repos/pepkit/peppy/issues/232"},"comments":{"href":"https://api.github.com/repos/pepkit/peppy/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pepkit/peppy/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/pepkit/peppy/statuses/cfd20f869c249c2588a5215a448afa39d64d0e00"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vreuter"}}