{"action":"created","comment":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/203940566","pull_request_review_id":138931664,"id":203940566,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzk0MDU2Ng==","diff_hunk":"@@ -42,26 +43,33 @@\n  * #L%\n  */\n @Interceptor(I_AD_User.class)\n-@Component\n+@Component(\"de.metas.marketing.base.model.interceptor.AD_User\")\n public class AD_User\n {\n+\n \tprivate final static String MRG_MKTG_Campaign_NewsletterGroup_Missing_For_Org = \"MKTG_Campaign_NewsletterGroup_Missing_For_Org\";\n \n+\tprivate final CampaignRepository campaignRepository;\n+\tprivate final CampaignService converters;","path":"de.metas.marketing/base/src/main/java/de/metas/marketing/base/model/interceptor/AD_User.java","position":31,"original_position":31,"commit_id":"40d7918c68b7cb2b684a36c6819bf2689ed7862c","original_commit_id":"40d7918c68b7cb2b684a36c6819bf2689ed7862c","user":{"login":"metas-ts","id":1264789,"node_id":"MDQ6VXNlcjEyNjQ3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1264789?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-ts","html_url":"https://github.com/metas-ts","followers_url":"https://api.github.com/users/metas-ts/followers","following_url":"https://api.github.com/users/metas-ts/following{/other_user}","gists_url":"https://api.github.com/users/metas-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-ts/subscriptions","organizations_url":"https://api.github.com/users/metas-ts/orgs","repos_url":"https://api.github.com/users/metas-ts/repos","events_url":"https://api.github.com/users/metas-ts/events{/privacy}","received_events_url":"https://api.github.com/users/metas-ts/received_events","type":"User","site_admin":false},"body":"please choose a more clear field name, e.g. `campaignService`","created_at":"2018-07-20T05:25:49Z","updated_at":"2018-07-20T05:31:38Z","html_url":"https://github.com/metasfresh/metasfresh/pull/4389#discussion_r203940566","pull_request_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/203940566"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4389#discussion_r203940566"},"pull_request":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389"}}},"pull_request":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389","id":202228461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjI4NDYx","html_url":"https://github.com/metasfresh/metasfresh/pull/4389","diff_url":"https://github.com/metasfresh/metasfresh/pull/4389.diff","patch_url":"https://github.com/metasfresh/metasfresh/pull/4389.patch","issue_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4389","number":4389,"state":"open","locked":false,"title":"Gh4092 sync emails between user and mktg contact person","user":{"login":"metas-rc","id":16001442,"node_id":"MDQ6VXNlcjE2MDAxNDQy","avatar_url":"https://avatars3.githubusercontent.com/u/16001442?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-rc","html_url":"https://github.com/metas-rc","followers_url":"https://api.github.com/users/metas-rc/followers","following_url":"https://api.github.com/users/metas-rc/following{/other_user}","gists_url":"https://api.github.com/users/metas-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-rc/subscriptions","organizations_url":"https://api.github.com/users/metas-rc/orgs","repos_url":"https://api.github.com/users/metas-rc/repos","events_url":"https://api.github.com/users/metas-rc/events{/privacy}","received_events_url":"https://api.github.com/users/metas-rc/received_events","type":"User","site_admin":false},"body":"https://github.com/metasfresh/metasfresh/issues/4092","created_at":"2018-07-18T11:56:24Z","updated_at":"2018-07-20T05:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee7acea6472f3c7a45fbec6295141a5071de6384","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389/commits","review_comments_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389/comments","review_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4389/comments","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/40d7918c68b7cb2b684a36c6819bf2689ed7862c","head":{"label":"metasfresh:gh4092","ref":"gh4092","sha":"40d7918c68b7cb2b684a36c6819bf2689ed7862c","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-07-19T08:13:49Z","pushed_at":"2018-07-19T14:23:49Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":80654,"stargazers_count":212,"watchers_count":212,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":848,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":93,"open_issues":848,"watchers":212,"default_branch":"master"}},"base":{"label":"metasfresh:master","ref":"master","sha":"60a5a9eb58de70beb171bdf27e93fbaa2986b4aa","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-07-19T08:13:49Z","pushed_at":"2018-07-19T14:23:49Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":80654,"stargazers_count":212,"watchers_count":212,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":848,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":93,"open_issues":848,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4389"},"issue":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4389"},"comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4389/comments"},"review_comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389/comments"},"review_comment":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4389/commits"},"statuses":{"href":"https://api.github.com/repos/metasfresh/metasfresh/statuses/40d7918c68b7cb2b684a36c6819bf2689ed7862c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"metas-ts"}}