{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/233189342","pull_request_review_id":174544669,"id":233189342,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE4OTM0Mg==","diff_hunk":"@@ -254,52 +248,28 @@ func NewClient(ctx, projectName string) (*Client, error) {\n \n // OpenTopic opens an existing topic on the pubsub server and returns a Topic\n // that can be used to send messages to that topic.\n-func (c *Client) OpenTopic(ctx context.Context, topicName string, opts *TopicOptions) (*pubsub.Topic, error) {\n-\tif opts == nil {\n-\t\topts = defaultTopicOptions\n-\t}\n+func (c *Client) OpenTopic(ctx context.Context, topicName string) (*pubsub.Topic, error) {\n \trt, err := c.rawclient.Topic(ctx, topicName)\n \tif err != nil {\n \t\treturn err\n \t}\n-\tt := &topic{\n-\t\trawTopic: rt,\n-\t\topts: opts,\n-\t}\n-\treturn pubsub.NewTopic(t, opts.TopicOptions)\n+\tt := &topic{ rawTopic: rt }\n+\treturn pubsub.NewTopic(t)\n }\n \n // OpenSubscription opens an existing subscription on the server and returns a\n // Subscription that can be used to receive messages.\n-func (c *Client) OpenSubscription(ctx context.Context, subscriptionName string, opts *SubscriptionOptions) (*pubsub.Subscription, error) {\n-\tif opts == nil {\n-\t\topts = defaultSubscriptionOptions\n-\t}\n+func (c *Client) OpenSubscription(ctx context.Context, subscriptionName string) {","path":"internal/docs/pubsub/design.md","position":97,"original_position":97,"commit_id":"26a98f6cb328009fa5806eb9c937d0fe51bca07e","original_commit_id":"26a98f6cb328009fa5806eb9c937d0fe51bca07e","user":{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},"body":"I suspect that driver constructors will still want to have options for provider-specific extensibility.","created_at":"2018-11-13T19:26:33Z","updated_at":"2018-11-13T19:31:44Z","html_url":"https://github.com/google/go-cloud/pull/683#discussion_r233189342","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/683","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/233189342"},"html":{"href":"https://github.com/google/go-cloud/pull/683#discussion_r233189342"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/683"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/683","id":230555052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTU1MDUy","html_url":"https://github.com/google/go-cloud/pull/683","diff_url":"https://github.com/google/go-cloud/pull/683.diff","patch_url":"https://github.com/google/go-cloud/pull/683.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/683","number":683,"state":"open","locked":false,"title":"pubsub: update design doc in response to rsc feedback: no options, nonblocking Acks","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"body":"Fixes #680 ","created_at":"2018-11-13T17:06:45Z","updated_at":"2018-11-13T19:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ade55ef6115144e2f76c3cbb32266eb858f9cb0e","assignee":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"assignees":[{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/683/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/683/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/683/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/26a98f6cb328009fa5806eb9c937d0fe51bca07e","head":{"label":"ijt:pubsub-design-mods","ref":"pubsub-design-mods","sha":"26a98f6cb328009fa5806eb9c937d0fe51bca07e","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"repo":{"id":157408808,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MDg4MDg=","name":"go-cloud","full_name":"ijt/go-cloud","private":false,"owner":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ijt/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/ijt/go-cloud","forks_url":"https://api.github.com/repos/ijt/go-cloud/forks","keys_url":"https://api.github.com/repos/ijt/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijt/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijt/go-cloud/teams","hooks_url":"https://api.github.com/repos/ijt/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/ijt/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/ijt/go-cloud/events","assignees_url":"https://api.github.com/repos/ijt/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/ijt/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/ijt/go-cloud/tags","blobs_url":"https://api.github.com/repos/ijt/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijt/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijt/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijt/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijt/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/ijt/go-cloud/languages","stargazers_url":"https://api.github.com/repos/ijt/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/ijt/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/ijt/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/ijt/go-cloud/subscription","commits_url":"https://api.github.com/repos/ijt/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijt/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijt/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijt/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijt/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/ijt/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijt/go-cloud/merges","archive_url":"https://api.github.com/repos/ijt/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijt/go-cloud/downloads","issues_url":"https://api.github.com/repos/ijt/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/ijt/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/ijt/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/ijt/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijt/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/ijt/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/ijt/go-cloud/deployments","created_at":"2018-11-13T16:12:47Z","updated_at":"2018-11-13T16:12:50Z","pushed_at":"2018-11-13T18:54:33Z","git_url":"git://github.com/ijt/go-cloud.git","ssh_url":"git@github.com:ijt/go-cloud.git","clone_url":"https://github.com/ijt/go-cloud.git","svn_url":"https://github.com/ijt/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18602,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"fecdeb74aefffbd13ceffb211e992cfaea9479ab","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2018-11-13T19:14:50Z","pushed_at":"2018-11-13T19:27:11Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18587,"stargazers_count":4960,"watchers_count":4960,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":272,"open_issues":96,"watchers":4960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/683"},"html":{"href":"https://github.com/google/go-cloud/pull/683"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/683"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/26a98f6cb328009fa5806eb9c937d0fe51bca07e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zombiezen"}}