{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments/215330129","pull_request_review_id":152569601,"id":215330129,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTMzMDEyOQ==","diff_hunk":"@@ -198,6 +198,24 @@ describe('Firewall', function() {\n       firewall.setMetadata(metadata, assert.ifError);\n     });\n \n+    it('should respect network specification', function(done) {\n+      var metadata = {network: 'custom-network'};\n+\n+      firewall.request = function(reqOpts) {\n+        assert.strictEqual(reqOpts.method, 'PATCH');","path":"test/firewall.js","position":17,"original_position":17,"commit_id":"cabffdf40a62adfe6f1da2e7dd943ba419042559","original_commit_id":"cabffdf40a62adfe6f1da2e7dd943ba419042559","user":{"login":"stephenplusplus","id":723048,"node_id":"MDQ6VXNlcjcyMzA0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/723048?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenplusplus","html_url":"https://github.com/stephenplusplus","followers_url":"https://api.github.com/users/stephenplusplus/followers","following_url":"https://api.github.com/users/stephenplusplus/following{/other_user}","gists_url":"https://api.github.com/users/stephenplusplus/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenplusplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenplusplus/subscriptions","organizations_url":"https://api.github.com/users/stephenplusplus/orgs","repos_url":"https://api.github.com/users/stephenplusplus/repos","events_url":"https://api.github.com/users/stephenplusplus/events{/privacy}","received_events_url":"https://api.github.com/users/stephenplusplus/received_events","type":"User","site_admin":false},"body":"I think we agree, the only thing is that I don't want to duplicate tests. In the previous test block, \"it should make the correct API request\", we check that all the arguments to `firewall.request()` are as expected. We don't need to confirm them again, since `src/firewall.js` only affects the `reqOpts.json.network` property when it sees `metadata.network` is set.","created_at":"2018-09-05T15:58:20Z","updated_at":"2018-09-05T15:58:20Z","html_url":"https://github.com/googleapis/nodejs-compute/pull/150#discussion_r215330129","pull_request_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments/215330129"},"html":{"href":"https://github.com/googleapis/nodejs-compute/pull/150#discussion_r215330129"},"pull_request":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150"}},"in_reply_to_id":215293036},"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150","id":213259012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjU5MDEy","html_url":"https://github.com/googleapis/nodejs-compute/pull/150","diff_url":"https://github.com/googleapis/nodejs-compute/pull/150.diff","patch_url":"https://github.com/googleapis/nodejs-compute/pull/150.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/150","number":150,"state":"open","locked":false,"title":"adding ability to specify firewall network","user":{"login":"apankratov","id":14836659,"node_id":"MDQ6VXNlcjE0ODM2NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14836659?v=4","gravatar_id":"","url":"https://api.github.com/users/apankratov","html_url":"https://github.com/apankratov","followers_url":"https://api.github.com/users/apankratov/followers","following_url":"https://api.github.com/users/apankratov/following{/other_user}","gists_url":"https://api.github.com/users/apankratov/gists{/gist_id}","starred_url":"https://api.github.com/users/apankratov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apankratov/subscriptions","organizations_url":"https://api.github.com/users/apankratov/orgs","repos_url":"https://api.github.com/users/apankratov/repos","events_url":"https://api.github.com/users/apankratov/events{/privacy}","received_events_url":"https://api.github.com/users/apankratov/received_events","type":"User","site_admin":false},"body":"Fixes #125 \r\n\r\n- [ ] Tests and linter pass\r\n- [ ] Code coverage does not decrease (if any source code was changed)\r\n- [ ] Appropriate docs were updated (if necessary)\r\n\r\n- added possibility to specify non-default network for setMetadata firewall method","created_at":"2018-09-05T11:25:51Z","updated_at":"2018-09-05T15:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acc4ec79bf92e3e36b1b4d6eefd555c71fa51f9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":738762758,"node_id":"MDU6TGFiZWw3Mzg3NjI3NTg=","url":"https://api.github.com/repos/googleapis/nodejs-compute/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/150/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/cabffdf40a62adfe6f1da2e7dd943ba419042559","head":{"label":"apankratov:master","ref":"master","sha":"cabffdf40a62adfe6f1da2e7dd943ba419042559","user":{"login":"apankratov","id":14836659,"node_id":"MDQ6VXNlcjE0ODM2NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14836659?v=4","gravatar_id":"","url":"https://api.github.com/users/apankratov","html_url":"https://github.com/apankratov","followers_url":"https://api.github.com/users/apankratov/followers","following_url":"https://api.github.com/users/apankratov/following{/other_user}","gists_url":"https://api.github.com/users/apankratov/gists{/gist_id}","starred_url":"https://api.github.com/users/apankratov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apankratov/subscriptions","organizations_url":"https://api.github.com/users/apankratov/orgs","repos_url":"https://api.github.com/users/apankratov/repos","events_url":"https://api.github.com/users/apankratov/events{/privacy}","received_events_url":"https://api.github.com/users/apankratov/received_events","type":"User","site_admin":false},"repo":{"id":147218810,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMTg4MTA=","name":"nodejs-compute","full_name":"apankratov/nodejs-compute","owner":{"login":"apankratov","id":14836659,"node_id":"MDQ6VXNlcjE0ODM2NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14836659?v=4","gravatar_id":"","url":"https://api.github.com/users/apankratov","html_url":"https://github.com/apankratov","followers_url":"https://api.github.com/users/apankratov/followers","following_url":"https://api.github.com/users/apankratov/following{/other_user}","gists_url":"https://api.github.com/users/apankratov/gists{/gist_id}","starred_url":"https://api.github.com/users/apankratov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apankratov/subscriptions","organizations_url":"https://api.github.com/users/apankratov/orgs","repos_url":"https://api.github.com/users/apankratov/repos","events_url":"https://api.github.com/users/apankratov/events{/privacy}","received_events_url":"https://api.github.com/users/apankratov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apankratov/nodejs-compute","description":"Node.js client for Google Compute Engine: Scalable, High-Performance Virtual Machines","fork":true,"url":"https://api.github.com/repos/apankratov/nodejs-compute","forks_url":"https://api.github.com/repos/apankratov/nodejs-compute/forks","keys_url":"https://api.github.com/repos/apankratov/nodejs-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apankratov/nodejs-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apankratov/nodejs-compute/teams","hooks_url":"https://api.github.com/repos/apankratov/nodejs-compute/hooks","issue_events_url":"https://api.github.com/repos/apankratov/nodejs-compute/issues/events{/number}","events_url":"https://api.github.com/repos/apankratov/nodejs-compute/events","assignees_url":"https://api.github.com/repos/apankratov/nodejs-compute/assignees{/user}","branches_url":"https://api.github.com/repos/apankratov/nodejs-compute/branches{/branch}","tags_url":"https://api.github.com/repos/apankratov/nodejs-compute/tags","blobs_url":"https://api.github.com/repos/apankratov/nodejs-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apankratov/nodejs-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apankratov/nodejs-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/apankratov/nodejs-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apankratov/nodejs-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/apankratov/nodejs-compute/languages","stargazers_url":"https://api.github.com/repos/apankratov/nodejs-compute/stargazers","contributors_url":"https://api.github.com/repos/apankratov/nodejs-compute/contributors","subscribers_url":"https://api.github.com/repos/apankratov/nodejs-compute/subscribers","subscription_url":"https://api.github.com/repos/apankratov/nodejs-compute/subscription","commits_url":"https://api.github.com/repos/apankratov/nodejs-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/apankratov/nodejs-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/apankratov/nodejs-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/apankratov/nodejs-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/apankratov/nodejs-compute/contents/{+path}","compare_url":"https://api.github.com/repos/apankratov/nodejs-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apankratov/nodejs-compute/merges","archive_url":"https://api.github.com/repos/apankratov/nodejs-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apankratov/nodejs-compute/downloads","issues_url":"https://api.github.com/repos/apankratov/nodejs-compute/issues{/number}","pulls_url":"https://api.github.com/repos/apankratov/nodejs-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/apankratov/nodejs-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/apankratov/nodejs-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apankratov/nodejs-compute/labels{/name}","releases_url":"https://api.github.com/repos/apankratov/nodejs-compute/releases{/id}","deployments_url":"https://api.github.com/repos/apankratov/nodejs-compute/deployments","created_at":"2018-09-03T14:50:48Z","updated_at":"2018-09-05T14:10:45Z","pushed_at":"2018-09-05T14:10:42Z","git_url":"git://github.com/apankratov/nodejs-compute.git","ssh_url":"git@github.com:apankratov/nodejs-compute.git","clone_url":"https://github.com/apankratov/nodejs-compute.git","svn_url":"https://github.com/apankratov/nodejs-compute","homepage":"https://cloud.google.com/compute/","size":1057,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"5e8faf628efed07c2a8b94a60366a0b0c239de92","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463458,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzQ1OA==","name":"nodejs-compute","full_name":"googleapis/nodejs-compute","owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/nodejs-compute","description":"Node.js client for Google Compute Engine: Scalable, High-Performance Virtual Machines","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-compute","forks_url":"https://api.github.com/repos/googleapis/nodejs-compute/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-compute/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-compute/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-compute/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-compute/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-compute/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-compute/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-compute/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-compute/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-compute/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-compute/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-compute/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-compute/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-compute/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-compute/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-compute/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-compute/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-compute/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-compute/deployments","created_at":"2017-07-26T20:31:42Z","updated_at":"2018-09-04T17:53:49Z","pushed_at":"2018-09-05T14:10:44Z","git_url":"git://github.com/googleapis/nodejs-compute.git","ssh_url":"git@github.com:googleapis/nodejs-compute.git","clone_url":"https://github.com/googleapis/nodejs-compute.git","svn_url":"https://github.com/googleapis/nodejs-compute","homepage":"https://cloud.google.com/compute/","size":1054,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":18,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150"},"html":{"href":"https://github.com/googleapis/nodejs-compute/pull/150"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/issues/150"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-compute/statuses/cabffdf40a62adfe6f1da2e7dd943ba419042559"}},"author_association":"NONE"}}
{"actor":{"display_login":"stephenplusplus"}}