{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68379","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68379/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68379/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68379/events","html_url":"https://github.com/kubernetes/kubernetes/pull/68379","id":357848249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzY1OTMw","number":68379,"title":"Enable configure_helper.sh to support two scenarios for etcd level encryption: decryption and adding encryption to existing clusters.","user":{"login":"immutableT","id":24857912,"node_id":"MDQ6VXNlcjI0ODU3OTEy","avatar_url":"https://avatars1.githubusercontent.com/u/24857912?v=4","gravatar_id":"","url":"https://api.github.com/users/immutableT","html_url":"https://github.com/immutableT","followers_url":"https://api.github.com/users/immutableT/followers","following_url":"https://api.github.com/users/immutableT/following{/other_user}","gists_url":"https://api.github.com/users/immutableT/gists{/gist_id}","starred_url":"https://api.github.com/users/immutableT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutableT/subscriptions","organizations_url":"https://api.github.com/users/immutableT/orgs","repos_url":"https://api.github.com/users/immutableT/repos","events_url":"https://api.github.com/users/immutableT/events{/privacy}","received_events_url":"https://api.github.com/users/immutableT/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":573014062,"node_id":"MDU6TGFiZWw1NzMwMTQwNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-06T22:16:27Z","updated_at":"2018-09-06T22:17:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68379","html_url":"https://github.com/kubernetes/kubernetes/pull/68379","diff_url":"https://github.com/kubernetes/kubernetes/pull/68379.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68379.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n1. Enables two additional scenarios for etcd level encryption:\r\n    Adding encryption to an existing cluster\r\n   Decryption\r\nBoth of the above mentioned scenarios require that secrets be \"touched\" by the envelope transformer post cluster startup. This functionality is implemented in the apply-encryption-config function.\r\n2. Refactor all encryption related logic into a single function - setup-etcd-encryption\r\n3. Remove the responsibility of generating kms-plugin manifest from configure-helper.sh. Implementers of kms-plugins (cloud-providers) should rely on the up-stream components to generate kms-plugin manifest. \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/419258946","html_url":"https://github.com/kubernetes/kubernetes/pull/68379#issuecomment-419258946","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68379","id":419258946,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTI1ODk0Ng==","user":{"login":"immutableT","id":24857912,"node_id":"MDQ6VXNlcjI0ODU3OTEy","avatar_url":"https://avatars1.githubusercontent.com/u/24857912?v=4","gravatar_id":"","url":"https://api.github.com/users/immutableT","html_url":"https://github.com/immutableT","followers_url":"https://api.github.com/users/immutableT/followers","following_url":"https://api.github.com/users/immutableT/following{/other_user}","gists_url":"https://api.github.com/users/immutableT/gists{/gist_id}","starred_url":"https://api.github.com/users/immutableT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutableT/subscriptions","organizations_url":"https://api.github.com/users/immutableT/orgs","repos_url":"https://api.github.com/users/immutableT/repos","events_url":"https://api.github.com/users/immutableT/events{/privacy}","received_events_url":"https://api.github.com/users/immutableT/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T22:17:08Z","updated_at":"2018-09-06T22:17:08Z","author_association":"CONTRIBUTOR","body":"/assign @mikedanese "}}
{"actor":{"display_login":"immutableT"}}