{"action":"closed","number":639,"pull_request":{"url":"https://api.github.com/repos/ACEmulator/ACE/pulls/639","id":168955101,"html_url":"https://github.com/ACEmulator/ACE/pull/639","diff_url":"https://github.com/ACEmulator/ACE/pull/639.diff","patch_url":"https://github.com/ACEmulator/ACE/pull/639.patch","issue_url":"https://api.github.com/repos/ACEmulator/ACE/issues/639","number":639,"state":"closed","locked":false,"title":"Implement CellLandblock geometry cache.","user":{"login":"gmriggs","id":8909245,"avatar_url":"https://avatars0.githubusercontent.com/u/8909245?v=4","gravatar_id":"","url":"https://api.github.com/users/gmriggs","html_url":"https://github.com/gmriggs","followers_url":"https://api.github.com/users/gmriggs/followers","following_url":"https://api.github.com/users/gmriggs/following{/other_user}","gists_url":"https://api.github.com/users/gmriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/gmriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmriggs/subscriptions","organizations_url":"https://api.github.com/users/gmriggs/orgs","repos_url":"https://api.github.com/users/gmriggs/repos","events_url":"https://api.github.com/users/gmriggs/events{/privacy}","received_events_url":"https://api.github.com/users/gmriggs/received_events","type":"User","site_admin":false},"body":"This pull request is for the 2 Trello tasks:\r\n\r\nhttps://trello.com/c/4ErxP7lc/90-implement-celllandblock-geometry-cache\r\nhttps://trello.com/c/TxnqEnBH/85-celllandblockgetz-needs-rework\r\n\r\nI'm still learning my way around the ACE project, so it's possible this code is not integrated in the correct location yet...\r\n\r\nA LoadMesh() method has been added to Landblock.cs, which uses the Region file to determine the correct heights for the vertices. It loads the landblock grid as a triangle mesh, using a snippet of code from AC2D to ensure the cells are split between the correct vertices. I have verified in a few different locations that these splitters are being generated correctly, but I have no automated way of ensuring 100% accuracy across the entire map yet.\r\n\r\nThe GetZ() method has been implemented in Landblock.cs, which returns the correct Z-height information for any X/Y position on the map.\r\n\r\nThere are no unit tests yet, but here is a video of the landblock grid mesh visualization:\r\n\r\nhttps://youtu.be/5yTTcMY-1Pw\r\n\r\nThe video quality was unfortunately degraded when uploaded to Youtube, but in the right corner is a 'current landblock height' stat that is updated every time the camera moves. This shows the information returned by GetZ().\r\n\r\nSince this mesh data is to eventually be consumed by other classes, it can be tailored to provide whatever public API would be most useful to these other classes. For now it just has some of the basics, but more can be added as needed.\r\n\r\n\r\n","created_at":"2018-02-13T21:02:50Z","updated_at":"2018-02-14T04:56:18Z","closed_at":"2018-02-14T04:56:18Z","merged_at":"2018-02-14T04:56:18Z","merge_commit_sha":"44129d99945af074626ccb11db63113fdb00e9b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/639/commits","review_comments_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/639/comments","review_comment_url":"https://api.github.com/repos/ACEmulator/ACE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ACEmulator/ACE/issues/639/comments","statuses_url":"https://api.github.com/repos/ACEmulator/ACE/statuses/b70663953b9a98a6a39d9792babb1b1fe9d70e3e","head":{"label":"gmriggs:master","ref":"master","sha":"b70663953b9a98a6a39d9792babb1b1fe9d70e3e","user":{"login":"gmriggs","id":8909245,"avatar_url":"https://avatars0.githubusercontent.com/u/8909245?v=4","gravatar_id":"","url":"https://api.github.com/users/gmriggs","html_url":"https://github.com/gmriggs","followers_url":"https://api.github.com/users/gmriggs/followers","following_url":"https://api.github.com/users/gmriggs/following{/other_user}","gists_url":"https://api.github.com/users/gmriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/gmriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmriggs/subscriptions","organizations_url":"https://api.github.com/users/gmriggs/orgs","repos_url":"https://api.github.com/users/gmriggs/repos","events_url":"https://api.github.com/users/gmriggs/events{/privacy}","received_events_url":"https://api.github.com/users/gmriggs/received_events","type":"User","site_admin":false},"repo":{"id":121125790,"name":"ACE","full_name":"gmriggs/ACE","owner":{"login":"gmriggs","id":8909245,"avatar_url":"https://avatars0.githubusercontent.com/u/8909245?v=4","gravatar_id":"","url":"https://api.github.com/users/gmriggs","html_url":"https://github.com/gmriggs","followers_url":"https://api.github.com/users/gmriggs/followers","following_url":"https://api.github.com/users/gmriggs/following{/other_user}","gists_url":"https://api.github.com/users/gmriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/gmriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmriggs/subscriptions","organizations_url":"https://api.github.com/users/gmriggs/orgs","repos_url":"https://api.github.com/users/gmriggs/repos","events_url":"https://api.github.com/users/gmriggs/events{/privacy}","received_events_url":"https://api.github.com/users/gmriggs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmriggs/ACE","description":"Asheron's Call server emulator.","fork":true,"url":"https://api.github.com/repos/gmriggs/ACE","forks_url":"https://api.github.com/repos/gmriggs/ACE/forks","keys_url":"https://api.github.com/repos/gmriggs/ACE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmriggs/ACE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmriggs/ACE/teams","hooks_url":"https://api.github.com/repos/gmriggs/ACE/hooks","issue_events_url":"https://api.github.com/repos/gmriggs/ACE/issues/events{/number}","events_url":"https://api.github.com/repos/gmriggs/ACE/events","assignees_url":"https://api.github.com/repos/gmriggs/ACE/assignees{/user}","branches_url":"https://api.github.com/repos/gmriggs/ACE/branches{/branch}","tags_url":"https://api.github.com/repos/gmriggs/ACE/tags","blobs_url":"https://api.github.com/repos/gmriggs/ACE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmriggs/ACE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmriggs/ACE/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmriggs/ACE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmriggs/ACE/statuses/{sha}","languages_url":"https://api.github.com/repos/gmriggs/ACE/languages","stargazers_url":"https://api.github.com/repos/gmriggs/ACE/stargazers","contributors_url":"https://api.github.com/repos/gmriggs/ACE/contributors","subscribers_url":"https://api.github.com/repos/gmriggs/ACE/subscribers","subscription_url":"https://api.github.com/repos/gmriggs/ACE/subscription","commits_url":"https://api.github.com/repos/gmriggs/ACE/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmriggs/ACE/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmriggs/ACE/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmriggs/ACE/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmriggs/ACE/contents/{+path}","compare_url":"https://api.github.com/repos/gmriggs/ACE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmriggs/ACE/merges","archive_url":"https://api.github.com/repos/gmriggs/ACE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmriggs/ACE/downloads","issues_url":"https://api.github.com/repos/gmriggs/ACE/issues{/number}","pulls_url":"https://api.github.com/repos/gmriggs/ACE/pulls{/number}","milestones_url":"https://api.github.com/repos/gmriggs/ACE/milestones{/number}","notifications_url":"https://api.github.com/repos/gmriggs/ACE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmriggs/ACE/labels{/name}","releases_url":"https://api.github.com/repos/gmriggs/ACE/releases{/id}","deployments_url":"https://api.github.com/repos/gmriggs/ACE/deployments","created_at":"2018-02-11T13:24:57Z","updated_at":"2018-02-11T13:25:00Z","pushed_at":"2018-02-13T20:38:36Z","git_url":"git://github.com/gmriggs/ACE.git","ssh_url":"git@github.com:gmriggs/ACE.git","clone_url":"https://github.com/gmriggs/ACE.git","svn_url":"https://github.com/gmriggs/ACE","homepage":"http://acemulator.org","size":5966,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ACEmulator:master","ref":"master","sha":"96a62b7ede4438f582d7ed27ac83c1279d02a1a9","user":{"login":"ACEmulator","id":24881359,"avatar_url":"https://avatars0.githubusercontent.com/u/24881359?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEmulator","html_url":"https://github.com/ACEmulator","followers_url":"https://api.github.com/users/ACEmulator/followers","following_url":"https://api.github.com/users/ACEmulator/following{/other_user}","gists_url":"https://api.github.com/users/ACEmulator/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEmulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEmulator/subscriptions","organizations_url":"https://api.github.com/users/ACEmulator/orgs","repos_url":"https://api.github.com/users/ACEmulator/repos","events_url":"https://api.github.com/users/ACEmulator/events{/privacy}","received_events_url":"https://api.github.com/users/ACEmulator/received_events","type":"Organization","site_admin":false},"repo":{"id":79078680,"name":"ACE","full_name":"ACEmulator/ACE","owner":{"login":"ACEmulator","id":24881359,"avatar_url":"https://avatars0.githubusercontent.com/u/24881359?v=4","gravatar_id":"","url":"https://api.github.com/users/ACEmulator","html_url":"https://github.com/ACEmulator","followers_url":"https://api.github.com/users/ACEmulator/followers","following_url":"https://api.github.com/users/ACEmulator/following{/other_user}","gists_url":"https://api.github.com/users/ACEmulator/gists{/gist_id}","starred_url":"https://api.github.com/users/ACEmulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACEmulator/subscriptions","organizations_url":"https://api.github.com/users/ACEmulator/orgs","repos_url":"https://api.github.com/users/ACEmulator/repos","events_url":"https://api.github.com/users/ACEmulator/events{/privacy}","received_events_url":"https://api.github.com/users/ACEmulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ACEmulator/ACE","description":"Asheron's Call server emulator.","fork":false,"url":"https://api.github.com/repos/ACEmulator/ACE","forks_url":"https://api.github.com/repos/ACEmulator/ACE/forks","keys_url":"https://api.github.com/repos/ACEmulator/ACE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ACEmulator/ACE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ACEmulator/ACE/teams","hooks_url":"https://api.github.com/repos/ACEmulator/ACE/hooks","issue_events_url":"https://api.github.com/repos/ACEmulator/ACE/issues/events{/number}","events_url":"https://api.github.com/repos/ACEmulator/ACE/events","assignees_url":"https://api.github.com/repos/ACEmulator/ACE/assignees{/user}","branches_url":"https://api.github.com/repos/ACEmulator/ACE/branches{/branch}","tags_url":"https://api.github.com/repos/ACEmulator/ACE/tags","blobs_url":"https://api.github.com/repos/ACEmulator/ACE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ACEmulator/ACE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ACEmulator/ACE/git/refs{/sha}","trees_url":"https://api.github.com/repos/ACEmulator/ACE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ACEmulator/ACE/statuses/{sha}","languages_url":"https://api.github.com/repos/ACEmulator/ACE/languages","stargazers_url":"https://api.github.com/repos/ACEmulator/ACE/stargazers","contributors_url":"https://api.github.com/repos/ACEmulator/ACE/contributors","subscribers_url":"https://api.github.com/repos/ACEmulator/ACE/subscribers","subscription_url":"https://api.github.com/repos/ACEmulator/ACE/subscription","commits_url":"https://api.github.com/repos/ACEmulator/ACE/commits{/sha}","git_commits_url":"https://api.github.com/repos/ACEmulator/ACE/git/commits{/sha}","comments_url":"https://api.github.com/repos/ACEmulator/ACE/comments{/number}","issue_comment_url":"https://api.github.com/repos/ACEmulator/ACE/issues/comments{/number}","contents_url":"https://api.github.com/repos/ACEmulator/ACE/contents/{+path}","compare_url":"https://api.github.com/repos/ACEmulator/ACE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ACEmulator/ACE/merges","archive_url":"https://api.github.com/repos/ACEmulator/ACE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ACEmulator/ACE/downloads","issues_url":"https://api.github.com/repos/ACEmulator/ACE/issues{/number}","pulls_url":"https://api.github.com/repos/ACEmulator/ACE/pulls{/number}","milestones_url":"https://api.github.com/repos/ACEmulator/ACE/milestones{/number}","notifications_url":"https://api.github.com/repos/ACEmulator/ACE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ACEmulator/ACE/labels{/name}","releases_url":"https://api.github.com/repos/ACEmulator/ACE/releases{/id}","deployments_url":"https://api.github.com/repos/ACEmulator/ACE/deployments","created_at":"2017-01-16T03:18:11Z","updated_at":"2018-02-13T21:53:55Z","pushed_at":"2018-02-14T04:56:18Z","git_url":"git://github.com/ACEmulator/ACE.git","ssh_url":"git@github.com:ACEmulator/ACE.git","clone_url":"https://github.com/ACEmulator/ACE.git","svn_url":"https://github.com/ACEmulator/ACE","homepage":"http://acemulator.org","size":5966,"stargazers_count":71,"watchers_count":71,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":73,"open_issues":12,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/639"},"html":{"href":"https://github.com/ACEmulator/ACE/pull/639"},"issue":{"href":"https://api.github.com/repos/ACEmulator/ACE/issues/639"},"comments":{"href":"https://api.github.com/repos/ACEmulator/ACE/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ACEmulator/ACE/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/ACEmulator/ACE/statuses/b70663953b9a98a6a39d9792babb1b1fe9d70e3e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"LtRipley36706","id":11369233,"avatar_url":"https://avatars2.githubusercontent.com/u/11369233?v=4","gravatar_id":"","url":"https://api.github.com/users/LtRipley36706","html_url":"https://github.com/LtRipley36706","followers_url":"https://api.github.com/users/LtRipley36706/followers","following_url":"https://api.github.com/users/LtRipley36706/following{/other_user}","gists_url":"https://api.github.com/users/LtRipley36706/gists{/gist_id}","starred_url":"https://api.github.com/users/LtRipley36706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LtRipley36706/subscriptions","organizations_url":"https://api.github.com/users/LtRipley36706/orgs","repos_url":"https://api.github.com/users/LtRipley36706/repos","events_url":"https://api.github.com/users/LtRipley36706/events{/privacy}","received_events_url":"https://api.github.com/users/LtRipley36706/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":521,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"LtRipley36706"}}