{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/84","repository_url":"https://api.github.com/repos/kubernetes-csi/csi-test","labels_url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/84/comments","events_url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/84/events","html_url":"https://github.com/kubernetes-csi/csi-test/pull/84","id":334968068,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODA1NzA3","number":84,"title":"Add test for ControllerPublishVolume","user":{"login":"codenrhoden","id":1627176,"node_id":"MDQ6VXNlcjE2MjcxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1627176?v=4","gravatar_id":"","url":"https://api.github.com/users/codenrhoden","html_url":"https://github.com/codenrhoden","followers_url":"https://api.github.com/users/codenrhoden/followers","following_url":"https://api.github.com/users/codenrhoden/following{/other_user}","gists_url":"https://api.github.com/users/codenrhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/codenrhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenrhoden/subscriptions","organizations_url":"https://api.github.com/users/codenrhoden/orgs","repos_url":"https://api.github.com/users/codenrhoden/repos","events_url":"https://api.github.com/users/codenrhoden/events{/privacy}","received_events_url":"https://api.github.com/users/codenrhoden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"assignees":[{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-22T17:59:06Z","updated_at":"2018-06-29T04:48:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes-csi/csi-test/pulls/84","html_url":"https://github.com/kubernetes-csi/csi-test/pull/84","diff_url":"https://github.com/kubernetes-csi/csi-test/pull/84.diff","patch_url":"https://github.com/kubernetes-csi/csi-test/pull/84.patch"},"body":"I'm opening this PR to demonstrate an error I am seeing with `csi-test` master. When updating the CSI external attacher/detacher, I always get a test failure for ControllerPublishVolume. In fact it hangs - took a while to track it down to this.\r\n\r\nThe `reflect.DeepEqual` that `gomock` performs to check for object equivalence is failing for the `ControllerPublishVolume` input. Oddly, it is *only* that call that fails - all the other tests pass. For simplicity, I added a test here in `csi-test` that demonstrates it.\r\n\r\nWhen the test fails, you will see the following:\r\n```\r\nUnexpected call to *driver.MockControllerServer.ControllerPublishVolume([context.Background.WithCancel.WithCancel.WithValue(peer.peerKey{}, &peer.Peer{Addr:(*net.TCPAddr)(0xc4201b0c60), AuthInfo:credentials.AuthInfo(nil)}).WithValue(metadata.mdIncomingKey{}, metadata.MD{\":authority\":[]string{\"127.0.0.1:51284\"}, \"content-type\":[]string{\"application/grpc\"}, \"user-agent\":[]string{\"grpc-go/1.12.2\"}}).WithValue(grpc.streamKey{}, <stream: 0xc42032a000, /csi.v0.Controller/ControllerPublishVolume>) volume_id:\"myname\" node_id:\"MyNodeID\" volume_capability:<mount:<> access_mode:<mode:MULTI_NODE_MULTI_WRITER > > ]) at /Users/trhoden/go/src/github.com/kubernetes-csi/csi-test/driver/driver.mock.go:522 because:\r\nExpected call at /Users/trhoden/go/src/github.com/kubernetes-csi/csi-test/driver/driver.mock.go:529 doesn't match the argument at index 1.\r\nGot: volume_id:\"myname\" node_id:\"MyNodeID\" volume_capability:<mount:<> access_mode:<mode:MULTI_NODE_MULTI_WRITER > >\r\nWant: is equal to volume_id:\"myname\" node_id:\"MyNodeID\" volume_capability:<mount:<> access_mode:<mode:MULTI_NODE_MULTI_WRITER > >\r\npanic: MOCK TEST FATAL FAILURE\r\n```\r\n\r\nNote that the Expected and Got lines show the object is correct, but it is not being picked up that way. I've tried using different versions of `gomock`, `grpc`, regenerating the mock objects, etc., but haven't gotten around this one yet. Help is appreciated!"},"comment":{"url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/comments/401246504","html_url":"https://github.com/kubernetes-csi/csi-test/pull/84#issuecomment-401246504","issue_url":"https://api.github.com/repos/kubernetes-csi/csi-test/issues/84","id":401246504,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTI0NjUwNA==","user":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T04:48:18Z","updated_at":"2018-06-29T04:48:18Z","author_association":"MEMBER","body":"@codenrhoden Hi, thanks for the PR. What do you suggest. Would you suggest adding this as a library to ci-test?"}}
{"actor":{"display_login":"lpabon"}}