{"action":"created","comment":{"url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments/171220427","pull_request_review_id":100033325,"id":171220427,"diff_hunk":"@@ -159,15 +159,16 @@ private static void GenerateContributors(VolleyManagementEntities context)\n                 Contributors091Atqc(),\n                 Contributors096Net(),\n                 Contributors103Net(),\n-                Contributors122Net()\n+                Contributors122Net(),\n+                Contributors297Net()","path":"src/VolleyManagement.Backend/VolleyManagement.Data.MsSql/Context/Migrations/SeedDataGenerator.cs","position":6,"original_position":6,"commit_id":"3dc07346940a8efc659e25aa8f9c56add15e687d","original_commit_id":"3dc07346940a8efc659e25aa8f9c56add15e687d","user":{"login":"sdiachen","id":13673187,"avatar_url":"https://avatars2.githubusercontent.com/u/13673187?v=4","gravatar_id":"","url":"https://api.github.com/users/sdiachen","html_url":"https://github.com/sdiachen","followers_url":"https://api.github.com/users/sdiachen/followers","following_url":"https://api.github.com/users/sdiachen/following{/other_user}","gists_url":"https://api.github.com/users/sdiachen/gists{/gist_id}","starred_url":"https://api.github.com/users/sdiachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdiachen/subscriptions","organizations_url":"https://api.github.com/users/sdiachen/orgs","repos_url":"https://api.github.com/users/sdiachen/repos","events_url":"https://api.github.com/users/sdiachen/events{/privacy}","received_events_url":"https://api.github.com/users/sdiachen/received_events","type":"User","site_admin":false},"body":"What is the goal of those changes?","created_at":"2018-02-28T11:49:57Z","updated_at":"2018-02-28T11:49:57Z","html_url":"https://github.com/VolleyManagement/volley-management/pull/178#discussion_r171220427","pull_request_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments/171220427"},"html":{"href":"https://github.com/VolleyManagement/volley-management/pull/178#discussion_r171220427"},"pull_request":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178","id":170220436,"html_url":"https://github.com/VolleyManagement/volley-management/pull/178","diff_url":"https://github.com/VolleyManagement/volley-management/pull/178.diff","patch_url":"https://github.com/VolleyManagement/volley-management/pull/178.patch","issue_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/178","number":178,"state":"open","locked":false,"title":"Issue #96 fix sonar lint","user":{"login":"YuriiChornyi","id":17709640,"avatar_url":"https://avatars2.githubusercontent.com/u/17709640?v=4","gravatar_id":"","url":"https://api.github.com/users/YuriiChornyi","html_url":"https://github.com/YuriiChornyi","followers_url":"https://api.github.com/users/YuriiChornyi/followers","following_url":"https://api.github.com/users/YuriiChornyi/following{/other_user}","gists_url":"https://api.github.com/users/YuriiChornyi/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriiChornyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriiChornyi/subscriptions","organizations_url":"https://api.github.com/users/YuriiChornyi/orgs","repos_url":"https://api.github.com/users/YuriiChornyi/repos","events_url":"https://api.github.com/users/YuriiChornyi/events{/privacy}","received_events_url":"https://api.github.com/users/YuriiChornyi/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nEnable Threat Warnings as errors for Release configuration for all projects\r\nFix warnings starting with \"S\", e.g. S101. Note: SA errors are out of scope\r\n\r\n### Areas Of Interest\r\n\r\nAll files need review\r\n\r\n### Checklist\r\n\r\n#### Design\r\n\r\n- [x] Web API layer contains as little logic as possible\r\n- [x] Domain objects use semantic names\r\n\r\n#### Perfromance\r\n\r\n- [x] In case of any DB query was changed: attach generated SQL for review\r\n- [x] Number of DB roundtrips should be as low as possible\r\n\r\n#### Unit Tests\r\n\r\n- [x] Naming: Initial state and expected result are properly stated\r\n- [x] Test follows [AAA](https://medium.com/@pjbgf/title-testing-code-ocd-and-the-aaa-pattern-df453975ab80) pattern.\r\n- [x] Test is Isolated\r\n- [x] Mock instances and expected instances do not share references\r\n","created_at":"2018-02-20T15:15:06Z","updated_at":"2018-02-28T11:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"791937bf9e2488e98c2a94ba2b24de79dc6932d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178/commits","review_comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178/comments","review_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/178/comments","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/3dc07346940a8efc659e25aa8f9c56add15e687d","head":{"label":"VolleyManagement:issue_#96_fix_SonarLint","ref":"issue_#96_fix_SonarLint","sha":"3dc07346940a8efc659e25aa8f9c56add15e687d","user":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"repo":{"id":117831469,"name":"volley-management","full_name":"VolleyManagement/volley-management","owner":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VolleyManagement/volley-management","description":null,"fork":false,"url":"https://api.github.com/repos/VolleyManagement/volley-management","forks_url":"https://api.github.com/repos/VolleyManagement/volley-management/forks","keys_url":"https://api.github.com/repos/VolleyManagement/volley-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VolleyManagement/volley-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VolleyManagement/volley-management/teams","hooks_url":"https://api.github.com/repos/VolleyManagement/volley-management/hooks","issue_events_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/events{/number}","events_url":"https://api.github.com/repos/VolleyManagement/volley-management/events","assignees_url":"https://api.github.com/repos/VolleyManagement/volley-management/assignees{/user}","branches_url":"https://api.github.com/repos/VolleyManagement/volley-management/branches{/branch}","tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/tags","blobs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/{sha}","languages_url":"https://api.github.com/repos/VolleyManagement/volley-management/languages","stargazers_url":"https://api.github.com/repos/VolleyManagement/volley-management/stargazers","contributors_url":"https://api.github.com/repos/VolleyManagement/volley-management/contributors","subscribers_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscribers","subscription_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscription","commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/VolleyManagement/volley-management/contents/{+path}","compare_url":"https://api.github.com/repos/VolleyManagement/volley-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VolleyManagement/volley-management/merges","archive_url":"https://api.github.com/repos/VolleyManagement/volley-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VolleyManagement/volley-management/downloads","issues_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues{/number}","pulls_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls{/number}","milestones_url":"https://api.github.com/repos/VolleyManagement/volley-management/milestones{/number}","notifications_url":"https://api.github.com/repos/VolleyManagement/volley-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VolleyManagement/volley-management/labels{/name}","releases_url":"https://api.github.com/repos/VolleyManagement/volley-management/releases{/id}","deployments_url":"https://api.github.com/repos/VolleyManagement/volley-management/deployments","created_at":"2018-01-17T12:12:11Z","updated_at":"2018-02-22T20:32:57Z","pushed_at":"2018-02-28T11:44:56Z","git_url":"git://github.com/VolleyManagement/volley-management.git","ssh_url":"git@github.com:VolleyManagement/volley-management.git","clone_url":"https://github.com/VolleyManagement/volley-management.git","svn_url":"https://github.com/VolleyManagement/volley-management","homepage":null,"size":7913,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":94,"watchers":2,"default_branch":"master"}},"base":{"label":"VolleyManagement:master","ref":"master","sha":"16f177e71cd0c0df3cc3d6911fe3f47871213b71","user":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"repo":{"id":117831469,"name":"volley-management","full_name":"VolleyManagement/volley-management","owner":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VolleyManagement/volley-management","description":null,"fork":false,"url":"https://api.github.com/repos/VolleyManagement/volley-management","forks_url":"https://api.github.com/repos/VolleyManagement/volley-management/forks","keys_url":"https://api.github.com/repos/VolleyManagement/volley-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VolleyManagement/volley-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VolleyManagement/volley-management/teams","hooks_url":"https://api.github.com/repos/VolleyManagement/volley-management/hooks","issue_events_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/events{/number}","events_url":"https://api.github.com/repos/VolleyManagement/volley-management/events","assignees_url":"https://api.github.com/repos/VolleyManagement/volley-management/assignees{/user}","branches_url":"https://api.github.com/repos/VolleyManagement/volley-management/branches{/branch}","tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/tags","blobs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/{sha}","languages_url":"https://api.github.com/repos/VolleyManagement/volley-management/languages","stargazers_url":"https://api.github.com/repos/VolleyManagement/volley-management/stargazers","contributors_url":"https://api.github.com/repos/VolleyManagement/volley-management/contributors","subscribers_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscribers","subscription_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscription","commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/VolleyManagement/volley-management/contents/{+path}","compare_url":"https://api.github.com/repos/VolleyManagement/volley-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VolleyManagement/volley-management/merges","archive_url":"https://api.github.com/repos/VolleyManagement/volley-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VolleyManagement/volley-management/downloads","issues_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues{/number}","pulls_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls{/number}","milestones_url":"https://api.github.com/repos/VolleyManagement/volley-management/milestones{/number}","notifications_url":"https://api.github.com/repos/VolleyManagement/volley-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VolleyManagement/volley-management/labels{/name}","releases_url":"https://api.github.com/repos/VolleyManagement/volley-management/releases{/id}","deployments_url":"https://api.github.com/repos/VolleyManagement/volley-management/deployments","created_at":"2018-01-17T12:12:11Z","updated_at":"2018-02-22T20:32:57Z","pushed_at":"2018-02-28T11:44:56Z","git_url":"git://github.com/VolleyManagement/volley-management.git","ssh_url":"git@github.com:VolleyManagement/volley-management.git","clone_url":"https://github.com/VolleyManagement/volley-management.git","svn_url":"https://github.com/VolleyManagement/volley-management","homepage":null,"size":7913,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":94,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178"},"html":{"href":"https://github.com/VolleyManagement/volley-management/pull/178"},"issue":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/issues/178"},"comments":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/3dc07346940a8efc659e25aa8f9c56add15e687d"}},"author_association":"NONE"}}
{"actor":{"display_login":"sdiachen"}}