{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/185672466","pull_request_review_id":117109319,"id":185672466,"diff_hunk":"@@ -11,7 +11,7 @@ enum\n     // Unused = 1 << 0,\n     fscrReturnExpression = 1 << 1,   // call should return the last expression\n     fscrImplicitThis = 1 << 2,   // 'this.' is optional (for Call)\n-    fscrImplicitParents = 1 << 3,   // the parents of 'this' are implicit","path":"lib/Parser/ParseFlags.h","position":4,"original_position":4,"commit_id":"9515daf4180be03edfd283c0d56e7fad46b0a98e","original_commit_id":"9515daf4180be03edfd283c0d56e7fad46b0a98e","user":{"login":"pleath","id":15825988,"avatar_url":"https://avatars0.githubusercontent.com/u/15825988?v=4","gravatar_id":"","url":"https://api.github.com/users/pleath","html_url":"https://github.com/pleath","followers_url":"https://api.github.com/users/pleath/followers","following_url":"https://api.github.com/users/pleath/following{/other_user}","gists_url":"https://api.github.com/users/pleath/gists{/gist_id}","starred_url":"https://api.github.com/users/pleath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleath/subscriptions","organizations_url":"https://api.github.com/users/pleath/orgs","repos_url":"https://api.github.com/users/pleath/repos","events_url":"https://api.github.com/users/pleath/events{/privacy}","received_events_url":"https://api.github.com/users/pleath/received_events","type":"User","site_admin":false},"body":"The two flags are treated interchangeably. I've wanted to merge them for a long time, and I'm doing it now in advance of another change involving the parser flags.","created_at":"2018-05-03T00:05:33Z","updated_at":"2018-05-03T00:05:33Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/5086#discussion_r185672466","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/185672466"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5086#discussion_r185672466"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086"}},"in_reply_to_id":185670069},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086","id":185562195,"html_url":"https://github.com/Microsoft/ChakraCore/pull/5086","diff_url":"https://github.com/Microsoft/ChakraCore/pull/5086.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/5086.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5086","number":5086,"state":"open","locked":false,"title":"Remove redundant fscrImplicitParents from parser flags","user":{"login":"pleath","id":15825988,"avatar_url":"https://avatars0.githubusercontent.com/u/15825988?v=4","gravatar_id":"","url":"https://api.github.com/users/pleath","html_url":"https://github.com/pleath","followers_url":"https://api.github.com/users/pleath/followers","following_url":"https://api.github.com/users/pleath/following{/other_user}","gists_url":"https://api.github.com/users/pleath/gists{/gist_id}","starred_url":"https://api.github.com/users/pleath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleath/subscriptions","organizations_url":"https://api.github.com/users/pleath/orgs","repos_url":"https://api.github.com/users/pleath/repos","events_url":"https://api.github.com/users/pleath/events{/privacy}","received_events_url":"https://api.github.com/users/pleath/received_events","type":"User","site_admin":false},"body":"\"fscrImplicitThis\" and \"fscrImplicitParents\" are treated interchangeably by the engine, so merge them to one flag.","created_at":"2018-05-02T21:11:02Z","updated_at":"2018-05-03T00:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02e017a18b5757f6826acff3bf46275de7c844e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5086/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/9515daf4180be03edfd283c0d56e7fad46b0a98e","head":{"label":"pleath:implicitparents","ref":"implicitparents","sha":"9515daf4180be03edfd283c0d56e7fad46b0a98e","user":{"login":"pleath","id":15825988,"avatar_url":"https://avatars0.githubusercontent.com/u/15825988?v=4","gravatar_id":"","url":"https://api.github.com/users/pleath","html_url":"https://github.com/pleath","followers_url":"https://api.github.com/users/pleath/followers","following_url":"https://api.github.com/users/pleath/following{/other_user}","gists_url":"https://api.github.com/users/pleath/gists{/gist_id}","starred_url":"https://api.github.com/users/pleath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleath/subscriptions","organizations_url":"https://api.github.com/users/pleath/orgs","repos_url":"https://api.github.com/users/pleath/repos","events_url":"https://api.github.com/users/pleath/events{/privacy}","received_events_url":"https://api.github.com/users/pleath/received_events","type":"User","site_admin":false},"repo":{"id":50529260,"name":"ChakraCore","full_name":"pleath/ChakraCore","owner":{"login":"pleath","id":15825988,"avatar_url":"https://avatars0.githubusercontent.com/u/15825988?v=4","gravatar_id":"","url":"https://api.github.com/users/pleath","html_url":"https://github.com/pleath","followers_url":"https://api.github.com/users/pleath/followers","following_url":"https://api.github.com/users/pleath/following{/other_user}","gists_url":"https://api.github.com/users/pleath/gists{/gist_id}","starred_url":"https://api.github.com/users/pleath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleath/subscriptions","organizations_url":"https://api.github.com/users/pleath/orgs","repos_url":"https://api.github.com/users/pleath/repos","events_url":"https://api.github.com/users/pleath/events{/privacy}","received_events_url":"https://api.github.com/users/pleath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pleath/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/pleath/ChakraCore","forks_url":"https://api.github.com/repos/pleath/ChakraCore/forks","keys_url":"https://api.github.com/repos/pleath/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pleath/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pleath/ChakraCore/teams","hooks_url":"https://api.github.com/repos/pleath/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/pleath/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/pleath/ChakraCore/events","assignees_url":"https://api.github.com/repos/pleath/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/pleath/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/pleath/ChakraCore/tags","blobs_url":"https://api.github.com/repos/pleath/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pleath/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pleath/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/pleath/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pleath/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/pleath/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/pleath/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/pleath/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/pleath/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/pleath/ChakraCore/subscription","commits_url":"https://api.github.com/repos/pleath/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/pleath/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/pleath/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/pleath/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/pleath/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/pleath/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pleath/ChakraCore/merges","archive_url":"https://api.github.com/repos/pleath/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pleath/ChakraCore/downloads","issues_url":"https://api.github.com/repos/pleath/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/pleath/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/pleath/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/pleath/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pleath/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/pleath/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/pleath/ChakraCore/deployments","created_at":"2016-01-27T18:41:10Z","updated_at":"2016-01-27T18:41:26Z","pushed_at":"2018-05-02T21:11:02Z","git_url":"git://github.com/pleath/ChakraCore.git","ssh_url":"git@github.com:pleath/ChakraCore.git","clone_url":"https://github.com/pleath/ChakraCore.git","svn_url":"https://github.com/pleath/ChakraCore","homepage":null,"size":123254,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7eb83c286059d340f0e5ed5312827ee242f27320","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2018-05-02T21:15:54Z","pushed_at":"2018-05-02T22:59:20Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":"","size":128433,"stargazers_count":6961,"watchers_count":6961,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":917,"mirror_url":null,"archived":false,"open_issues_count":333,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":917,"open_issues":333,"watchers":6961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/5086"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5086"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/5086/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/5086/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/9515daf4180be03edfd283c0d56e7fad46b0a98e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pleath"}}