{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/comments/183323241","pull_request_review_id":114298166,"id":183323241,"diff_hunk":"@@ -749,6 +749,14 @@ end = struct\n     | ( Pat {ppat_desc= Ppat_construct _}\n       , Ppat_construct ({txt= Lident \"::\"}, _) ) ->\n         true\n+    | ( (Exp {pexp_desc= Pexp_let _; _} | Str {pstr_desc= Pstr_value _; _})\n+      , ( Ppat_construct (_, Some _)\n+        | Ppat_variant (_, Some _)\n+        | Ppat_or _ | Ppat_alias _ ) ) ->\n+        (* let (Some p) = e *)\n+        (* let (P1 | P2) = e *)\n+        (* let (pat as ident) = e *)","path":"src/Ast.ml","position":null,"original_position":10,"commit_id":"1c92d77ee99600346feda4327db358c54da652fb","original_commit_id":"a6b438767700671c44c9262a1bfe815e50e88807","user":{"login":"hhugo","id":835209,"avatar_url":"https://avatars2.githubusercontent.com/u/835209?v=4","gravatar_id":"","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"body":"It was only meaningful internally to help understand what diffs can be upstream. Now removed.","created_at":"2018-04-23T09:09:41Z","updated_at":"2018-04-23T09:09:41Z","html_url":"https://github.com/ocaml-ppx/ocamlformat/pull/151#discussion_r183323241","pull_request_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/comments/183323241"},"html":{"href":"https://github.com/ocaml-ppx/ocamlformat/pull/151#discussion_r183323241"},"pull_request":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151"}},"in_reply_to_id":183262321},"pull_request":{"url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151","id":182401287,"html_url":"https://github.com/ocaml-ppx/ocamlformat/pull/151","diff_url":"https://github.com/ocaml-ppx/ocamlformat/pull/151.diff","patch_url":"https://github.com/ocaml-ppx/ocamlformat/pull/151.patch","issue_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/151","number":151,"state":"open","locked":false,"title":"Improve: more parens in patterns","user":{"login":"hhugo","id":835209,"avatar_url":"https://avatars2.githubusercontent.com/u/835209?v=4","gravatar_id":"","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"body":"Put parens around complex pattern on the lhs of let binding.","created_at":"2018-04-18T08:21:39Z","updated_at":"2018-04-23T09:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd9434a197d90d462bbdb36a15a53f6a5734f589","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":726912631,"url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/labels/CLA%20Signed","name":"CLA Signed","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151/commits","review_comments_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151/comments","review_comment_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/151/comments","statuses_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/statuses/1c92d77ee99600346feda4327db358c54da652fb","head":{"label":"hhugo:parens-pattern","ref":"parens-pattern","sha":"1c92d77ee99600346feda4327db358c54da652fb","user":{"login":"hhugo","id":835209,"avatar_url":"https://avatars2.githubusercontent.com/u/835209?v=4","gravatar_id":"","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"repo":{"id":126765007,"name":"ocamlformat","full_name":"hhugo/ocamlformat","owner":{"login":"hhugo","id":835209,"avatar_url":"https://avatars2.githubusercontent.com/u/835209?v=4","gravatar_id":"","url":"https://api.github.com/users/hhugo","html_url":"https://github.com/hhugo","followers_url":"https://api.github.com/users/hhugo/followers","following_url":"https://api.github.com/users/hhugo/following{/other_user}","gists_url":"https://api.github.com/users/hhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/hhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhugo/subscriptions","organizations_url":"https://api.github.com/users/hhugo/orgs","repos_url":"https://api.github.com/users/hhugo/repos","events_url":"https://api.github.com/users/hhugo/events{/privacy}","received_events_url":"https://api.github.com/users/hhugo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhugo/ocamlformat","description":"Auto-formatter for OCaml code","fork":true,"url":"https://api.github.com/repos/hhugo/ocamlformat","forks_url":"https://api.github.com/repos/hhugo/ocamlformat/forks","keys_url":"https://api.github.com/repos/hhugo/ocamlformat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhugo/ocamlformat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhugo/ocamlformat/teams","hooks_url":"https://api.github.com/repos/hhugo/ocamlformat/hooks","issue_events_url":"https://api.github.com/repos/hhugo/ocamlformat/issues/events{/number}","events_url":"https://api.github.com/repos/hhugo/ocamlformat/events","assignees_url":"https://api.github.com/repos/hhugo/ocamlformat/assignees{/user}","branches_url":"https://api.github.com/repos/hhugo/ocamlformat/branches{/branch}","tags_url":"https://api.github.com/repos/hhugo/ocamlformat/tags","blobs_url":"https://api.github.com/repos/hhugo/ocamlformat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhugo/ocamlformat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhugo/ocamlformat/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhugo/ocamlformat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhugo/ocamlformat/statuses/{sha}","languages_url":"https://api.github.com/repos/hhugo/ocamlformat/languages","stargazers_url":"https://api.github.com/repos/hhugo/ocamlformat/stargazers","contributors_url":"https://api.github.com/repos/hhugo/ocamlformat/contributors","subscribers_url":"https://api.github.com/repos/hhugo/ocamlformat/subscribers","subscription_url":"https://api.github.com/repos/hhugo/ocamlformat/subscription","commits_url":"https://api.github.com/repos/hhugo/ocamlformat/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhugo/ocamlformat/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhugo/ocamlformat/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhugo/ocamlformat/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhugo/ocamlformat/contents/{+path}","compare_url":"https://api.github.com/repos/hhugo/ocamlformat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhugo/ocamlformat/merges","archive_url":"https://api.github.com/repos/hhugo/ocamlformat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhugo/ocamlformat/downloads","issues_url":"https://api.github.com/repos/hhugo/ocamlformat/issues{/number}","pulls_url":"https://api.github.com/repos/hhugo/ocamlformat/pulls{/number}","milestones_url":"https://api.github.com/repos/hhugo/ocamlformat/milestones{/number}","notifications_url":"https://api.github.com/repos/hhugo/ocamlformat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhugo/ocamlformat/labels{/name}","releases_url":"https://api.github.com/repos/hhugo/ocamlformat/releases{/id}","deployments_url":"https://api.github.com/repos/hhugo/ocamlformat/deployments","created_at":"2018-03-26T02:52:22Z","updated_at":"2018-04-11T07:40:31Z","pushed_at":"2018-04-23T09:07:27Z","git_url":"git://github.com/hhugo/ocamlformat.git","ssh_url":"git@github.com:hhugo/ocamlformat.git","clone_url":"https://github.com/hhugo/ocamlformat.git","svn_url":"https://github.com/hhugo/ocamlformat","homepage":"","size":348,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml-ppx:master","ref":"master","sha":"cf82be1837727e37dc08f6887ea8ee00976efc4c","user":{"login":"ocaml-ppx","id":31065556,"avatar_url":"https://avatars2.githubusercontent.com/u/31065556?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml-ppx","html_url":"https://github.com/ocaml-ppx","followers_url":"https://api.github.com/users/ocaml-ppx/followers","following_url":"https://api.github.com/users/ocaml-ppx/following{/other_user}","gists_url":"https://api.github.com/users/ocaml-ppx/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml-ppx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml-ppx/subscriptions","organizations_url":"https://api.github.com/users/ocaml-ppx/orgs","repos_url":"https://api.github.com/users/ocaml-ppx/repos","events_url":"https://api.github.com/users/ocaml-ppx/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml-ppx/received_events","type":"Organization","site_admin":false},"repo":{"id":106263946,"name":"ocamlformat","full_name":"ocaml-ppx/ocamlformat","owner":{"login":"ocaml-ppx","id":31065556,"avatar_url":"https://avatars2.githubusercontent.com/u/31065556?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml-ppx","html_url":"https://github.com/ocaml-ppx","followers_url":"https://api.github.com/users/ocaml-ppx/followers","following_url":"https://api.github.com/users/ocaml-ppx/following{/other_user}","gists_url":"https://api.github.com/users/ocaml-ppx/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml-ppx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml-ppx/subscriptions","organizations_url":"https://api.github.com/users/ocaml-ppx/orgs","repos_url":"https://api.github.com/users/ocaml-ppx/repos","events_url":"https://api.github.com/users/ocaml-ppx/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml-ppx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml-ppx/ocamlformat","description":"Auto-formatter for OCaml code","fork":false,"url":"https://api.github.com/repos/ocaml-ppx/ocamlformat","forks_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/forks","keys_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/teams","hooks_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/hooks","issue_events_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/events","assignees_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/tags","blobs_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/languages","stargazers_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/stargazers","contributors_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/contributors","subscribers_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/subscribers","subscription_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/subscription","commits_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/merges","archive_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/downloads","issues_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/labels{/name}","releases_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml-ppx/ocamlformat/deployments","created_at":"2017-10-09T09:34:08Z","updated_at":"2018-04-23T02:27:29Z","pushed_at":"2018-04-23T09:07:28Z","git_url":"git://github.com/ocaml-ppx/ocamlformat.git","ssh_url":"git@github.com:ocaml-ppx/ocamlformat.git","clone_url":"https://github.com/ocaml-ppx/ocamlformat.git","svn_url":"https://github.com/ocaml-ppx/ocamlformat","homepage":"","size":386,"stargazers_count":122,"watchers_count":122,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":29,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151"},"html":{"href":"https://github.com/ocaml-ppx/ocamlformat/pull/151"},"issue":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/151"},"comments":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml-ppx/ocamlformat/statuses/1c92d77ee99600346feda4327db358c54da652fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hhugo"}}