{"action":"closed","number":1207,"pull_request":{"url":"https://api.github.com/repos/ninenines/cowboy/pulls/1207","id":137632564,"html_url":"https://github.com/ninenines/cowboy/pull/1207","diff_url":"https://github.com/ninenines/cowboy/pull/1207.diff","patch_url":"https://github.com/ninenines/cowboy/pull/1207.patch","issue_url":"https://api.github.com/repos/ninenines/cowboy/issues/1207","number":1207,"state":"closed","locked":false,"title":"Add max_frame_size option for websocket handlers.","user":{"login":"evilbluebeaver","id":4312604,"avatar_url":"https://avatars2.githubusercontent.com/u/4312604?v=4","gravatar_id":"","url":"https://api.github.com/users/evilbluebeaver","html_url":"https://github.com/evilbluebeaver","followers_url":"https://api.github.com/users/evilbluebeaver/followers","following_url":"https://api.github.com/users/evilbluebeaver/following{/other_user}","gists_url":"https://api.github.com/users/evilbluebeaver/gists{/gist_id}","starred_url":"https://api.github.com/users/evilbluebeaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilbluebeaver/subscriptions","organizations_url":"https://api.github.com/users/evilbluebeaver/orgs","repos_url":"https://api.github.com/users/evilbluebeaver/repos","events_url":"https://api.github.com/users/evilbluebeaver/events{/privacy}","received_events_url":"https://api.github.com/users/evilbluebeaver/received_events","type":"User","site_admin":false},"body":"Option allows to limit a frame by size before decoding its payload.\r\nRelated to [612](https://github.com/ninenines/cowboy/issues/612).\r\nI took [this](https://github.com/ninenines/cowboy/pull/1081/commits/2f518e5dbf7d63b7f19f7bb6fe599cb169b183b6) for basis, made it optional and fixed tests. Should I remove limit of 8 MBytes by default or leave it as is?","created_at":"2017-08-25T09:23:14Z","updated_at":"2018-03-28T14:44:20Z","closed_at":"2018-03-28T14:44:20Z","merged_at":null,"merge_commit_sha":"f5fdc161fff74dbf79d66589d7e6e719f52b8944","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":247988027,"url":"https://api.github.com/repos/ninenines/cowboy/labels/Feature%20request","name":"Feature request","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/ninenines/cowboy/milestones/20","html_url":"https://github.com/ninenines/cowboy/milestone/20","labels_url":"https://api.github.com/repos/ninenines/cowboy/milestones/20/labels","id":2974829,"number":20,"title":"2.x \"better Websocket\"","description":"Websocket could use a command-based interface for return values (backward compatible) and many small options and improvements.","creator":{"login":"essen","id":141739,"avatar_url":"https://avatars2.githubusercontent.com/u/141739?v=4","gravatar_id":"","url":"https://api.github.com/users/essen","html_url":"https://github.com/essen","followers_url":"https://api.github.com/users/essen/followers","following_url":"https://api.github.com/users/essen/following{/other_user}","gists_url":"https://api.github.com/users/essen/gists{/gist_id}","starred_url":"https://api.github.com/users/essen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essen/subscriptions","organizations_url":"https://api.github.com/users/essen/orgs","repos_url":"https://api.github.com/users/essen/repos","events_url":"https://api.github.com/users/essen/events{/privacy}","received_events_url":"https://api.github.com/users/essen/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":1,"state":"open","created_at":"2017-12-12T16:08:33Z","updated_at":"2018-03-28T14:44:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ninenines/cowboy/pulls/1207/commits","review_comments_url":"https://api.github.com/repos/ninenines/cowboy/pulls/1207/comments","review_comment_url":"https://api.github.com/repos/ninenines/cowboy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninenines/cowboy/issues/1207/comments","statuses_url":"https://api.github.com/repos/ninenines/cowboy/statuses/06e9bb7aebb18ff789166fb548a34e4fd1464c65","head":{"label":"evilbluebeaver:master","ref":"master","sha":"06e9bb7aebb18ff789166fb548a34e4fd1464c65","user":{"login":"evilbluebeaver","id":4312604,"avatar_url":"https://avatars2.githubusercontent.com/u/4312604?v=4","gravatar_id":"","url":"https://api.github.com/users/evilbluebeaver","html_url":"https://github.com/evilbluebeaver","followers_url":"https://api.github.com/users/evilbluebeaver/followers","following_url":"https://api.github.com/users/evilbluebeaver/following{/other_user}","gists_url":"https://api.github.com/users/evilbluebeaver/gists{/gist_id}","starred_url":"https://api.github.com/users/evilbluebeaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilbluebeaver/subscriptions","organizations_url":"https://api.github.com/users/evilbluebeaver/orgs","repos_url":"https://api.github.com/users/evilbluebeaver/repos","events_url":"https://api.github.com/users/evilbluebeaver/events{/privacy}","received_events_url":"https://api.github.com/users/evilbluebeaver/received_events","type":"User","site_admin":false},"repo":{"id":101383386,"name":"cowboy","full_name":"evilbluebeaver/cowboy","owner":{"login":"evilbluebeaver","id":4312604,"avatar_url":"https://avatars2.githubusercontent.com/u/4312604?v=4","gravatar_id":"","url":"https://api.github.com/users/evilbluebeaver","html_url":"https://github.com/evilbluebeaver","followers_url":"https://api.github.com/users/evilbluebeaver/followers","following_url":"https://api.github.com/users/evilbluebeaver/following{/other_user}","gists_url":"https://api.github.com/users/evilbluebeaver/gists{/gist_id}","starred_url":"https://api.github.com/users/evilbluebeaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilbluebeaver/subscriptions","organizations_url":"https://api.github.com/users/evilbluebeaver/orgs","repos_url":"https://api.github.com/users/evilbluebeaver/repos","events_url":"https://api.github.com/users/evilbluebeaver/events{/privacy}","received_events_url":"https://api.github.com/users/evilbluebeaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evilbluebeaver/cowboy","description":"Small, fast, modern HTTP server for Erlang/OTP.","fork":true,"url":"https://api.github.com/repos/evilbluebeaver/cowboy","forks_url":"https://api.github.com/repos/evilbluebeaver/cowboy/forks","keys_url":"https://api.github.com/repos/evilbluebeaver/cowboy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evilbluebeaver/cowboy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evilbluebeaver/cowboy/teams","hooks_url":"https://api.github.com/repos/evilbluebeaver/cowboy/hooks","issue_events_url":"https://api.github.com/repos/evilbluebeaver/cowboy/issues/events{/number}","events_url":"https://api.github.com/repos/evilbluebeaver/cowboy/events","assignees_url":"https://api.github.com/repos/evilbluebeaver/cowboy/assignees{/user}","branches_url":"https://api.github.com/repos/evilbluebeaver/cowboy/branches{/branch}","tags_url":"https://api.github.com/repos/evilbluebeaver/cowboy/tags","blobs_url":"https://api.github.com/repos/evilbluebeaver/cowboy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evilbluebeaver/cowboy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evilbluebeaver/cowboy/git/refs{/sha}","trees_url":"https://api.github.com/repos/evilbluebeaver/cowboy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evilbluebeaver/cowboy/statuses/{sha}","languages_url":"https://api.github.com/repos/evilbluebeaver/cowboy/languages","stargazers_url":"https://api.github.com/repos/evilbluebeaver/cowboy/stargazers","contributors_url":"https://api.github.com/repos/evilbluebeaver/cowboy/contributors","subscribers_url":"https://api.github.com/repos/evilbluebeaver/cowboy/subscribers","subscription_url":"https://api.github.com/repos/evilbluebeaver/cowboy/subscription","commits_url":"https://api.github.com/repos/evilbluebeaver/cowboy/commits{/sha}","git_commits_url":"https://api.github.com/repos/evilbluebeaver/cowboy/git/commits{/sha}","comments_url":"https://api.github.com/repos/evilbluebeaver/cowboy/comments{/number}","issue_comment_url":"https://api.github.com/repos/evilbluebeaver/cowboy/issues/comments{/number}","contents_url":"https://api.github.com/repos/evilbluebeaver/cowboy/contents/{+path}","compare_url":"https://api.github.com/repos/evilbluebeaver/cowboy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evilbluebeaver/cowboy/merges","archive_url":"https://api.github.com/repos/evilbluebeaver/cowboy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evilbluebeaver/cowboy/downloads","issues_url":"https://api.github.com/repos/evilbluebeaver/cowboy/issues{/number}","pulls_url":"https://api.github.com/repos/evilbluebeaver/cowboy/pulls{/number}","milestones_url":"https://api.github.com/repos/evilbluebeaver/cowboy/milestones{/number}","notifications_url":"https://api.github.com/repos/evilbluebeaver/cowboy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evilbluebeaver/cowboy/labels{/name}","releases_url":"https://api.github.com/repos/evilbluebeaver/cowboy/releases{/id}","deployments_url":"https://api.github.com/repos/evilbluebeaver/cowboy/deployments","created_at":"2017-08-25T08:29:00Z","updated_at":"2017-08-25T08:29:02Z","pushed_at":"2017-08-25T10:15:07Z","git_url":"git://github.com/evilbluebeaver/cowboy.git","ssh_url":"git@github.com:evilbluebeaver/cowboy.git","clone_url":"https://github.com/evilbluebeaver/cowboy.git","svn_url":"https://github.com/evilbluebeaver/cowboy","homepage":"https://ninenines.eu","size":5679,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninenines:master","ref":"master","sha":"3d8339267b2de011c30db868002f23ab4da0cc2f","user":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars0.githubusercontent.com/u/1166740?v=4","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"repo":{"id":1460612,"name":"cowboy","full_name":"ninenines/cowboy","owner":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars0.githubusercontent.com/u/1166740?v=4","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninenines/cowboy","description":"Small, fast, modern HTTP server for Erlang/OTP.","fork":false,"url":"https://api.github.com/repos/ninenines/cowboy","forks_url":"https://api.github.com/repos/ninenines/cowboy/forks","keys_url":"https://api.github.com/repos/ninenines/cowboy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninenines/cowboy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninenines/cowboy/teams","hooks_url":"https://api.github.com/repos/ninenines/cowboy/hooks","issue_events_url":"https://api.github.com/repos/ninenines/cowboy/issues/events{/number}","events_url":"https://api.github.com/repos/ninenines/cowboy/events","assignees_url":"https://api.github.com/repos/ninenines/cowboy/assignees{/user}","branches_url":"https://api.github.com/repos/ninenines/cowboy/branches{/branch}","tags_url":"https://api.github.com/repos/ninenines/cowboy/tags","blobs_url":"https://api.github.com/repos/ninenines/cowboy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninenines/cowboy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninenines/cowboy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninenines/cowboy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninenines/cowboy/statuses/{sha}","languages_url":"https://api.github.com/repos/ninenines/cowboy/languages","stargazers_url":"https://api.github.com/repos/ninenines/cowboy/stargazers","contributors_url":"https://api.github.com/repos/ninenines/cowboy/contributors","subscribers_url":"https://api.github.com/repos/ninenines/cowboy/subscribers","subscription_url":"https://api.github.com/repos/ninenines/cowboy/subscription","commits_url":"https://api.github.com/repos/ninenines/cowboy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninenines/cowboy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninenines/cowboy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninenines/cowboy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninenines/cowboy/contents/{+path}","compare_url":"https://api.github.com/repos/ninenines/cowboy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninenines/cowboy/merges","archive_url":"https://api.github.com/repos/ninenines/cowboy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninenines/cowboy/downloads","issues_url":"https://api.github.com/repos/ninenines/cowboy/issues{/number}","pulls_url":"https://api.github.com/repos/ninenines/cowboy/pulls{/number}","milestones_url":"https://api.github.com/repos/ninenines/cowboy/milestones{/number}","notifications_url":"https://api.github.com/repos/ninenines/cowboy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninenines/cowboy/labels{/name}","releases_url":"https://api.github.com/repos/ninenines/cowboy/releases{/id}","deployments_url":"https://api.github.com/repos/ninenines/cowboy/deployments","created_at":"2011-03-09T19:55:52Z","updated_at":"2018-03-28T09:17:04Z","pushed_at":"2018-03-27T21:03:48Z","git_url":"git://github.com/ninenines/cowboy.git","ssh_url":"git@github.com:ninenines/cowboy.git","clone_url":"https://github.com/ninenines/cowboy.git","svn_url":"https://github.com/ninenines/cowboy","homepage":"https://ninenines.eu","size":6379,"stargazers_count":4846,"watchers_count":4846,"language":"Erlang","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":908,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":908,"open_issues":107,"watchers":4846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninenines/cowboy/pulls/1207"},"html":{"href":"https://github.com/ninenines/cowboy/pull/1207"},"issue":{"href":"https://api.github.com/repos/ninenines/cowboy/issues/1207"},"comments":{"href":"https://api.github.com/repos/ninenines/cowboy/issues/1207/comments"},"review_comments":{"href":"https://api.github.com/repos/ninenines/cowboy/pulls/1207/comments"},"review_comment":{"href":"https://api.github.com/repos/ninenines/cowboy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninenines/cowboy/pulls/1207/commits"},"statuses":{"href":"https://api.github.com/repos/ninenines/cowboy/statuses/06e9bb7aebb18ff789166fb548a34e4fd1464c65"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":18,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":63,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"essen"}}