{"action":"created","issue":{"url":"https://api.github.com/repos/opendatakit/collect/issues/1871","repository_url":"https://api.github.com/repos/opendatakit/collect","labels_url":"https://api.github.com/repos/opendatakit/collect/issues/1871/labels{/name}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/1871/comments","events_url":"https://api.github.com/repos/opendatakit/collect/issues/1871/events","html_url":"https://github.com/opendatakit/collect/pull/1871","id":297596014,"number":1871,"title":"Adds AdminSharedPreferences and GeneralSharedPreferences as a dependency    ","user":{"login":"shobhitagarwal1612","id":8918023,"avatar_url":"https://avatars1.githubusercontent.com/u/8918023?v=4","gravatar_id":"","url":"https://api.github.com/users/shobhitagarwal1612","html_url":"https://github.com/shobhitagarwal1612","followers_url":"https://api.github.com/users/shobhitagarwal1612/followers","following_url":"https://api.github.com/users/shobhitagarwal1612/following{/other_user}","gists_url":"https://api.github.com/users/shobhitagarwal1612/gists{/gist_id}","starred_url":"https://api.github.com/users/shobhitagarwal1612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shobhitagarwal1612/subscriptions","organizations_url":"https://api.github.com/users/shobhitagarwal1612/orgs","repos_url":"https://api.github.com/users/shobhitagarwal1612/repos","events_url":"https://api.github.com/users/shobhitagarwal1612/events{/privacy}","received_events_url":"https://api.github.com/users/shobhitagarwal1612/received_events","type":"User","site_admin":false},"labels":[{"id":474694259,"url":"https://api.github.com/repos/opendatakit/collect/labels/needs%20discussion","name":"needs discussion","color":"fbca04","default":false},{"id":612677864,"url":"https://api.github.com/repos/opendatakit/collect/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-15T21:05:04Z","updated_at":"2018-05-14T21:38:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/1871","html_url":"https://github.com/opendatakit/collect/pull/1871","diff_url":"https://github.com/opendatakit/collect/pull/1871.diff","patch_url":"https://github.com/opendatakit/collect/pull/1871.patch"},"body":"This is a draft to remove the singleton pattern from `AdminSharedPreferences` and `GeneralSharedPreferences`. By using this, we can inject them as a dependency, hence making the code more testable.\r\n\r\n@jknightco @lognaturel @yanokwa Let's discuss if this a better solution than having a singleton. If yes then we can remove it completely form everywhere and apply this solution.\r\n"},"comment":{"url":"https://api.github.com/repos/opendatakit/collect/issues/comments/388971432","html_url":"https://github.com/opendatakit/collect/pull/1871#issuecomment-388971432","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/1871","id":388971432,"user":{"login":"lognaturel","id":967540,"avatar_url":"https://avatars3.githubusercontent.com/u/967540?v=4","gravatar_id":"","url":"https://api.github.com/users/lognaturel","html_url":"https://github.com/lognaturel","followers_url":"https://api.github.com/users/lognaturel/followers","following_url":"https://api.github.com/users/lognaturel/following{/other_user}","gists_url":"https://api.github.com/users/lognaturel/gists{/gist_id}","starred_url":"https://api.github.com/users/lognaturel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lognaturel/subscriptions","organizations_url":"https://api.github.com/users/lognaturel/orgs","repos_url":"https://api.github.com/users/lognaturel/repos","events_url":"https://api.github.com/users/lognaturel/events{/privacy}","received_events_url":"https://api.github.com/users/lognaturel/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T21:38:16Z","updated_at":"2018-05-14T21:38:16Z","author_association":"MEMBER","body":"> is it blocked on needing a discussion?\r\n\r\nExactly. Seems like a great idea in principle. Would be great to get a sanity check from someone with more Dagger experience to make sure it's the best structure."}}
{"actor":{"display_login":"lognaturel"}}