{"action":"created","comment":{"url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/comments/184676440","pull_request_review_id":115923546,"id":184676440,"diff_hunk":"@@ -1,12 +1,13 @@\n // use react-native component // 1","path":"App.js","position":1,"original_position":1,"commit_id":"e1771b0292a3adb47053239f8d74344cc0978014","original_commit_id":"e1771b0292a3adb47053239f8d74344cc0978014","user":{"login":"minwoojeon","id":17987845,"avatar_url":"https://avatars2.githubusercontent.com/u/17987845?v=4","gravatar_id":"","url":"https://api.github.com/users/minwoojeon","html_url":"https://github.com/minwoojeon","followers_url":"https://api.github.com/users/minwoojeon/followers","following_url":"https://api.github.com/users/minwoojeon/following{/other_user}","gists_url":"https://api.github.com/users/minwoojeon/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoojeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoojeon/subscriptions","organizations_url":"https://api.github.com/users/minwoojeon/orgs","repos_url":"https://api.github.com/users/minwoojeon/repos","events_url":"https://api.github.com/users/minwoojeon/events{/privacy}","received_events_url":"https://api.github.com/users/minwoojeon/received_events","type":"User","site_admin":false},"body":"@SemicolonJungwon 불필요한 주석입니다. 지우세요.","created_at":"2018-04-27T12:46:57Z","updated_at":"2018-04-27T13:00:27Z","html_url":"https://github.com/SemicolonJungwon/jsOxygen/pull/12#discussion_r184676440","pull_request_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/comments/184676440"},"html":{"href":"https://github.com/SemicolonJungwon/jsOxygen/pull/12#discussion_r184676440"},"pull_request":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12","id":184577567,"html_url":"https://github.com/SemicolonJungwon/jsOxygen/pull/12","diff_url":"https://github.com/SemicolonJungwon/jsOxygen/pull/12.diff","patch_url":"https://github.com/SemicolonJungwon/jsOxygen/pull/12.patch","issue_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/12","number":12,"state":"open","locked":false,"title":"Won","user":{"login":"SemicolonJungwon","id":17876889,"avatar_url":"https://avatars1.githubusercontent.com/u/17876889?v=4","gravatar_id":"","url":"https://api.github.com/users/SemicolonJungwon","html_url":"https://github.com/SemicolonJungwon","followers_url":"https://api.github.com/users/SemicolonJungwon/followers","following_url":"https://api.github.com/users/SemicolonJungwon/following{/other_user}","gists_url":"https://api.github.com/users/SemicolonJungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/SemicolonJungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemicolonJungwon/subscriptions","organizations_url":"https://api.github.com/users/SemicolonJungwon/orgs","repos_url":"https://api.github.com/users/SemicolonJungwon/repos","events_url":"https://api.github.com/users/SemicolonJungwon/events{/privacy}","received_events_url":"https://api.github.com/users/SemicolonJungwon/received_events","type":"User","site_admin":false},"body":"코드 진행방향 전체적으로 수정\r\n1. 너저분한 코드 다 수정하거나 지움\r\n2. fetch async 문법에 맞게 정리\r\n3. api가져오면서 생기는 시간에 로딩 화면 추가\r\n4. 로딩후 fade in 되면서 날씨 정보 표시 할 수 있도록 애니메이션 효과 추가\r\n5. tablelayout 사용 안하는 것으로 수정\r\n\r\nopenweatherAPI(날씨요청) > KAKAO API(현재나의 위치 요청) > 공공DB 미세먼지API(나의 위치값에 맞는 미세먼지 값 요청 하는 방식으로 처리함\r\n\r\n원래는 geolocation 사용하여 나의 경위도 값 요청 > 경위도 값으로 날씨요청 > 경위도값 tm값으로 변경 요청 > tm값으로 나에게서 가장 가까운 측정소 요청 > 해당 측정소에서 현재시각 기준 pm10, pm25 값 요청이 목표 였으나\r\n\r\n현재 공공DB 미세먼지 API에서 가까운 측정소 요청하는 것을 업데이트 중인지 사용 가능한 api값에서 없음.. 하여 일단은 내가 있는 도시값으로 나올수 있도록 하였음.\r\n--- 수정 위의 가장 가까운 측정소로 요청하여 값 보내줄수 있도록 수정하였음 ----","created_at":"2018-04-27T10:02:18Z","updated_at":"2018-04-27T13:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f0c17f82b4082bd1dd911de13cfd3141b8e91db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12/commits","review_comments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12/comments","review_comment_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/12/comments","statuses_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/statuses/e1771b0292a3adb47053239f8d74344cc0978014","head":{"label":"SemicolonJungwon:won","ref":"won","sha":"e1771b0292a3adb47053239f8d74344cc0978014","user":{"login":"SemicolonJungwon","id":17876889,"avatar_url":"https://avatars1.githubusercontent.com/u/17876889?v=4","gravatar_id":"","url":"https://api.github.com/users/SemicolonJungwon","html_url":"https://github.com/SemicolonJungwon","followers_url":"https://api.github.com/users/SemicolonJungwon/followers","following_url":"https://api.github.com/users/SemicolonJungwon/following{/other_user}","gists_url":"https://api.github.com/users/SemicolonJungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/SemicolonJungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemicolonJungwon/subscriptions","organizations_url":"https://api.github.com/users/SemicolonJungwon/orgs","repos_url":"https://api.github.com/users/SemicolonJungwon/repos","events_url":"https://api.github.com/users/SemicolonJungwon/events{/privacy}","received_events_url":"https://api.github.com/users/SemicolonJungwon/received_events","type":"User","site_admin":false},"repo":{"id":128541049,"name":"jsOxygen","full_name":"SemicolonJungwon/jsOxygen","owner":{"login":"SemicolonJungwon","id":17876889,"avatar_url":"https://avatars1.githubusercontent.com/u/17876889?v=4","gravatar_id":"","url":"https://api.github.com/users/SemicolonJungwon","html_url":"https://github.com/SemicolonJungwon","followers_url":"https://api.github.com/users/SemicolonJungwon/followers","following_url":"https://api.github.com/users/SemicolonJungwon/following{/other_user}","gists_url":"https://api.github.com/users/SemicolonJungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/SemicolonJungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemicolonJungwon/subscriptions","organizations_url":"https://api.github.com/users/SemicolonJungwon/orgs","repos_url":"https://api.github.com/users/SemicolonJungwon/repos","events_url":"https://api.github.com/users/SemicolonJungwon/events{/privacy}","received_events_url":"https://api.github.com/users/SemicolonJungwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SemicolonJungwon/jsOxygen","description":null,"fork":false,"url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen","forks_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/forks","keys_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/teams","hooks_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/hooks","issue_events_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/events{/number}","events_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/events","assignees_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/assignees{/user}","branches_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/branches{/branch}","tags_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/tags","blobs_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/refs{/sha}","trees_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/statuses/{sha}","languages_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/languages","stargazers_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/stargazers","contributors_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/contributors","subscribers_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/subscribers","subscription_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/subscription","commits_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/commits{/sha}","git_commits_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/commits{/sha}","comments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/comments{/number}","issue_comment_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/comments{/number}","contents_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/contents/{+path}","compare_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/merges","archive_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/downloads","issues_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues{/number}","pulls_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls{/number}","milestones_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/milestones{/number}","notifications_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/labels{/name}","releases_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/releases{/id}","deployments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/deployments","created_at":"2018-04-07T15:21:04Z","updated_at":"2018-04-25T19:29:30Z","pushed_at":"2018-04-27T12:19:31Z","git_url":"git://github.com/SemicolonJungwon/jsOxygen.git","ssh_url":"git@github.com:SemicolonJungwon/jsOxygen.git","clone_url":"https://github.com/SemicolonJungwon/jsOxygen.git","svn_url":"https://github.com/SemicolonJungwon/jsOxygen","homepage":null,"size":268,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SemicolonJungwon:master","ref":"master","sha":"e7dc1eda24fd11884667be9dae70af75ae47b0a9","user":{"login":"SemicolonJungwon","id":17876889,"avatar_url":"https://avatars1.githubusercontent.com/u/17876889?v=4","gravatar_id":"","url":"https://api.github.com/users/SemicolonJungwon","html_url":"https://github.com/SemicolonJungwon","followers_url":"https://api.github.com/users/SemicolonJungwon/followers","following_url":"https://api.github.com/users/SemicolonJungwon/following{/other_user}","gists_url":"https://api.github.com/users/SemicolonJungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/SemicolonJungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemicolonJungwon/subscriptions","organizations_url":"https://api.github.com/users/SemicolonJungwon/orgs","repos_url":"https://api.github.com/users/SemicolonJungwon/repos","events_url":"https://api.github.com/users/SemicolonJungwon/events{/privacy}","received_events_url":"https://api.github.com/users/SemicolonJungwon/received_events","type":"User","site_admin":false},"repo":{"id":128541049,"name":"jsOxygen","full_name":"SemicolonJungwon/jsOxygen","owner":{"login":"SemicolonJungwon","id":17876889,"avatar_url":"https://avatars1.githubusercontent.com/u/17876889?v=4","gravatar_id":"","url":"https://api.github.com/users/SemicolonJungwon","html_url":"https://github.com/SemicolonJungwon","followers_url":"https://api.github.com/users/SemicolonJungwon/followers","following_url":"https://api.github.com/users/SemicolonJungwon/following{/other_user}","gists_url":"https://api.github.com/users/SemicolonJungwon/gists{/gist_id}","starred_url":"https://api.github.com/users/SemicolonJungwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemicolonJungwon/subscriptions","organizations_url":"https://api.github.com/users/SemicolonJungwon/orgs","repos_url":"https://api.github.com/users/SemicolonJungwon/repos","events_url":"https://api.github.com/users/SemicolonJungwon/events{/privacy}","received_events_url":"https://api.github.com/users/SemicolonJungwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SemicolonJungwon/jsOxygen","description":null,"fork":false,"url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen","forks_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/forks","keys_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/teams","hooks_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/hooks","issue_events_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/events{/number}","events_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/events","assignees_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/assignees{/user}","branches_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/branches{/branch}","tags_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/tags","blobs_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/refs{/sha}","trees_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/statuses/{sha}","languages_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/languages","stargazers_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/stargazers","contributors_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/contributors","subscribers_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/subscribers","subscription_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/subscription","commits_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/commits{/sha}","git_commits_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/git/commits{/sha}","comments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/comments{/number}","issue_comment_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/comments{/number}","contents_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/contents/{+path}","compare_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/merges","archive_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/downloads","issues_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues{/number}","pulls_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls{/number}","milestones_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/milestones{/number}","notifications_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/labels{/name}","releases_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/releases{/id}","deployments_url":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/deployments","created_at":"2018-04-07T15:21:04Z","updated_at":"2018-04-25T19:29:30Z","pushed_at":"2018-04-27T12:19:31Z","git_url":"git://github.com/SemicolonJungwon/jsOxygen.git","ssh_url":"git@github.com:SemicolonJungwon/jsOxygen.git","clone_url":"https://github.com/SemicolonJungwon/jsOxygen.git","svn_url":"https://github.com/SemicolonJungwon/jsOxygen","homepage":null,"size":268,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12"},"html":{"href":"https://github.com/SemicolonJungwon/jsOxygen/pull/12"},"issue":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/12"},"comments":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/SemicolonJungwon/jsOxygen/statuses/e1771b0292a3adb47053239f8d74344cc0978014"}},"author_association":"OWNER"}}
{"actor":{"display_login":"minwoojeon"}}