{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments/204930917","pull_request_review_id":140100345,"id":204930917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDkzMDkxNw==","diff_hunk":"@@ -12,7 +12,7 @@ import SettingsCard from '../settings/SettingsCard';\n import { IconHome, IconStream, IconSettings } from '../common/Icons';\n import IconUnreadConversations from '../nav/IconUnreadConversations';\n \n-export default TabNavigator(\n+export default createMaterialTopTabNavigator(","path":"src/main/MainTabs.js","position":14,"original_position":14,"commit_id":"9f8cf040c51a14f0d30f015f8181cda97558cbaa","original_commit_id":"9f8cf040c51a14f0d30f015f8181cda97558cbaa","user":{"login":"gnprice","id":28173,"node_id":"MDQ6VXNlcjI4MTcz","avatar_url":"https://avatars1.githubusercontent.com/u/28173?v=4","gravatar_id":"","url":"https://api.github.com/users/gnprice","html_url":"https://github.com/gnprice","followers_url":"https://api.github.com/users/gnprice/followers","following_url":"https://api.github.com/users/gnprice/following{/other_user}","gists_url":"https://api.github.com/users/gnprice/gists{/gist_id}","starred_url":"https://api.github.com/users/gnprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnprice/subscriptions","organizations_url":"https://api.github.com/users/gnprice/orgs","repos_url":"https://api.github.com/users/gnprice/repos","events_url":"https://api.github.com/users/gnprice/events{/privacy}","received_events_url":"https://api.github.com/users/gnprice/received_events","type":"User","site_admin":false},"body":"Wow, that is confusing that this works! I appreciate that the apparent contradiction is pointed out in the commit message. :-)\r\n\r\nIt doesn't actually seem to be documented that this is something you can do -- `tabBarPosition` doesn't appear on this page:\r\nhttps://reactnavigation.org/docs/en/material-top-tab-navigator.html\r\nAs long as it does work, it's OK, but it's something we'd want to call out and be watchful for on future upgrades.\r\n\r\nIt looks like there is a \"bottom\" counterpart to this component, though:\r\nhttps://reactnavigation.org/docs/en/material-bottom-tab-navigator.html\r\nDoes that one work? If so, that seems cleaner.\r\n","created_at":"2018-07-24T22:24:48Z","updated_at":"2018-07-24T22:51:24Z","html_url":"https://github.com/zulip/zulip-mobile/pull/2702#discussion_r204930917","pull_request_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments/204930917"},"html":{"href":"https://github.com/zulip/zulip-mobile/pull/2702#discussion_r204930917"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702","id":196208980,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjA4OTgw","html_url":"https://github.com/zulip/zulip-mobile/pull/2702","diff_url":"https://github.com/zulip/zulip-mobile/pull/2702.diff","patch_url":"https://github.com/zulip/zulip-mobile/pull/2702.patch","issue_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/2702","number":2702,"state":"open","locked":false,"title":"Upgrade to React Navigation v2","user":{"login":"borisyankov","id":867242,"node_id":"MDQ6VXNlcjg2NzI0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"body":"The PR migrates to React Navigation v2 without changing or introducing new behavior.","created_at":"2018-06-20T16:55:28Z","updated_at":"2018-07-24T22:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9be1b1ec9cedfb48280c99a97e7f570f545b7df2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/2702/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/9f8cf040c51a14f0d30f015f8181cda97558cbaa","head":{"label":"borisyankov:rn2","ref":"rn2","sha":"9f8cf040c51a14f0d30f015f8181cda97558cbaa","user":{"login":"borisyankov","id":867242,"node_id":"MDQ6VXNlcjg2NzI0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"repo":{"id":68862567,"node_id":"MDEwOlJlcG9zaXRvcnk2ODg2MjU2Nw==","name":"zulip-mobile","full_name":"borisyankov/zulip-mobile","owner":{"login":"borisyankov","id":867242,"node_id":"MDQ6VXNlcjg2NzI0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisyankov/zulip-mobile","description":"Zulip mobile app using React Native","fork":true,"url":"https://api.github.com/repos/borisyankov/zulip-mobile","forks_url":"https://api.github.com/repos/borisyankov/zulip-mobile/forks","keys_url":"https://api.github.com/repos/borisyankov/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisyankov/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisyankov/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/borisyankov/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/borisyankov/zulip-mobile/events","assignees_url":"https://api.github.com/repos/borisyankov/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/borisyankov/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/borisyankov/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisyankov/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/borisyankov/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/borisyankov/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/borisyankov/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/borisyankov/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/borisyankov/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/borisyankov/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisyankov/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisyankov/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/borisyankov/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisyankov/zulip-mobile/merges","archive_url":"https://api.github.com/repos/borisyankov/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisyankov/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/borisyankov/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/borisyankov/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/borisyankov/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisyankov/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/borisyankov/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/borisyankov/zulip-mobile/deployments","created_at":"2016-09-21T22:23:02Z","updated_at":"2018-07-24T07:37:30Z","pushed_at":"2018-07-24T07:39:00Z","git_url":"git://github.com/borisyankov/zulip-mobile.git","ssh_url":"git@github.com:borisyankov/zulip-mobile.git","clone_url":"https://github.com/borisyankov/zulip-mobile.git","svn_url":"https://github.com/borisyankov/zulip-mobile","homepage":"","size":38164,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"3923c90af3bb67166fe14c511f11fa7c10386ce1","user":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":58298428,"node_id":"MDEwOlJlcG9zaXRvcnk1ODI5ODQyOA==","name":"zulip-mobile","full_name":"zulip/zulip-mobile","owner":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-mobile","description":"Zulip mobile app using React Native","fork":false,"url":"https://api.github.com/repos/zulip/zulip-mobile","forks_url":"https://api.github.com/repos/zulip/zulip-mobile/forks","keys_url":"https://api.github.com/repos/zulip/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-mobile/events","assignees_url":"https://api.github.com/repos/zulip/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-mobile/merges","archive_url":"https://api.github.com/repos/zulip/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-mobile/deployments","created_at":"2016-05-08T05:41:48Z","updated_at":"2018-07-24T07:19:23Z","pushed_at":"2018-07-24T14:56:57Z","git_url":"git://github.com/zulip/zulip-mobile.git","ssh_url":"git@github.com:zulip/zulip-mobile.git","clone_url":"https://github.com/zulip/zulip-mobile.git","svn_url":"https://github.com/zulip/zulip-mobile","homepage":"","size":20506,"stargazers_count":370,"watchers_count":370,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":158,"open_issues":245,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702"},"html":{"href":"https://github.com/zulip/zulip-mobile/pull/2702"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/2702"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/2702/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2702/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-mobile/statuses/9f8cf040c51a14f0d30f015f8181cda97558cbaa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gnprice"}}