{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/33744","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/33744/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/33744/comments","events_url":"https://api.github.com/repos/rails/rails/issues/33744/events","html_url":"https://github.com/rails/rails/pull/33744","id":355082531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjkyODAy","number":33744,"title":"Prevent leaking of user's DB credentials on `rails db:create` failure","user":{"login":"bogdanvlviv","id":6443532,"node_id":"MDQ6VXNlcjY0NDM1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6443532?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanvlviv","html_url":"https://github.com/bogdanvlviv","followers_url":"https://api.github.com/users/bogdanvlviv/followers","following_url":"https://api.github.com/users/bogdanvlviv/following{/other_user}","gists_url":"https://api.github.com/users/bogdanvlviv/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanvlviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanvlviv/subscriptions","organizations_url":"https://api.github.com/users/bogdanvlviv/orgs","repos_url":"https://api.github.com/users/bogdanvlviv/repos","events_url":"https://api.github.com/users/bogdanvlviv/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanvlviv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"eileencodes","id":1080678,"node_id":"MDQ6VXNlcjEwODA2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1080678?v=4","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":true},"assignees":[{"login":"eileencodes","id":1080678,"node_id":"MDQ6VXNlcjEwODA2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1080678?v=4","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":true}],"milestone":null,"comments":0,"created_at":"2018-08-29T09:49:31Z","updated_at":"2018-08-29T09:49:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33744","html_url":"https://github.com/rails/rails/pull/33744","diff_url":"https://github.com/rails/rails/pull/33744.diff","patch_url":"https://github.com/rails/rails/pull/33744.patch"},"body":"Issue #27852 reports that when `rails db:create` fails, it causes\r\nleaking of user's DB credentials to $stderr.\r\nWe print a DB's configuration hash in order to help users more quickly\r\nto figure out what could be wrong with his configuration.\r\n\r\nThis commit changes message from\r\n\"Couldn't create database for #{configuration.inspect}\" to\r\n\"Couldn't create '#{configuration['database']}' database. Please check your configuration.\".\r\n\r\nThere are two PRs that fixing it #27878, #27879, but they need a bit more work.\r\nI decided help to finish this and added Author of those PRs credit in this commit.\r\n\r\nSince it is a security issue, I think we should backport it to\r\n`5-2-stable`, and `5-1-stable`.\r\nGuided by https://edgeguides.rubyonrails.org/maintenance_policy.html#security-issues\r\n\r\nFixes #27852\r\nCloses #27879\r\nRelated to #27878\r\n\r\n[Alexander Marrs & bogdanvlviv]"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/416894260","html_url":"https://github.com/rails/rails/pull/33744#issuecomment-416894260","issue_url":"https://api.github.com/repos/rails/rails/issues/33744","id":416894260,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjg5NDI2MA==","user":{"login":"rails-bot","id":7468109,"node_id":"MDQ6VXNlcjc0NjgxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7468109?v=4","gravatar_id":"","url":"https://api.github.com/users/rails-bot","html_url":"https://github.com/rails-bot","followers_url":"https://api.github.com/users/rails-bot/followers","following_url":"https://api.github.com/users/rails-bot/following{/other_user}","gists_url":"https://api.github.com/users/rails-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-bot/subscriptions","organizations_url":"https://api.github.com/users/rails-bot/orgs","repos_url":"https://api.github.com/users/rails-bot/repos","events_url":"https://api.github.com/users/rails-bot/events{/privacy}","received_events_url":"https://api.github.com/users/rails-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T09:49:34Z","updated_at":"2018-08-29T09:49:34Z","author_association":"NONE","body":"r? @eileencodes\n\n(@rails-bot has picked a reviewer for you, use r? to override)"}}
{"actor":{"display_login":"rails-bot"}}